Timeline
Aug 16, 2008:
- 10:06 PM Changeset in webkit [35805] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Geoffrey Garen.
Disable dead code stripping in debug builds.
- Configurations/Base.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 8:28 PM Changeset in webkit [35804] by
-
- 3 edits in trunk/WebCore
2008-08-15 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Disable dead code stripping in debug builds.
- Configurations/Base.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
Aug 15, 2008:
- 11:53 PM Changeset in webkit [35803] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/6143072> FastMallocZone's enumeration code makes assumptions about handling of remote memory regions that overlap
Reviewed by Oliver Hunt.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Don't directly compare pointers mapped into the local process with
a pointer that has not been mapped. Instead, calculate a local address for the pointer and compare with that.
(WTF::TCMallocStats::FreeObjectFinder::findFreeObjects): Pass in the remote address of the central free list so that it can
be used when calculating local addresses.
(WTF::TCMallocStats::FastMallocZone::enumerate): Ditto.
- 11:48 PM Changeset in webkit [35802] by
-
- 15 edits in trunk
<rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
Rubber-stamped by Geoff Garen.
- 3:58 PM Changeset in webkit [35801] by
-
- 6 edits in trunk/WebCore
2008-08-15 Antti Koivisto <Antti Koivisto>
Reviewed by Anders.
Don't start preloading body resources before the head is complete. This prevents
body preloads from slowing down initial display when there is limited amount
of bandwidth available.
Works by queuing up found body preloads to DocLoader and only issuing them
after document has rendering.
With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
without affecting complete load time.
- html/PreloadScanner.cpp: (WebCore::PreloadScanner::PreloadScanner): (WebCore::PreloadScanner::scanningBody): (WebCore::PreloadScanner::emitTag): (WebCore::PreloadScanner::emitCSSRule):
- html/PreloadScanner.h:
- loader/DocLoader.cpp: (WebCore::DocLoader::preload): (WebCore::DocLoader::checkForPendingPreloads): (WebCore::DocLoader::requestPreload):
- loader/DocLoader.h:
- loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail):
- 2:08 PM Changeset in webkit [35800] by
-
- 2 edits in trunk/WebCore
Use item's computed style if the render style is 0 before falling back to the <select>'s style.
This way style set on an <hr> within a <select> will be honored.
Reviewed by Dave Hyatt and Dan Bernstein.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle):
- 1:48 PM Changeset in webkit [35799] by
-
- 3 edits in trunk/WebCore
2008-08-15 Antti Koivisto <Antti Koivisto>
Reviewed by Oliver.
Some loader performance tweaks:
- Make stylesheets highest priority instead of scripts. We block script execution on stylesheets. Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue to not delay rendering.
- Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup can take long time when latency is high so it is good to get started early.
- When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the load queues. Issue remaining loads to the network layer.
- loader/loader.cpp: (WebCore::Loader::determinePriority): (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests):
- loader/loader.h:
- 11:35 AM Changeset in webkit [35798] by
-
- 2 edits in trunk/WebCore
Detach the script debugger when the Web Inspector's window closes.
This has always been the intended design, but never fully implemented.
Reviewed by Adam Roben.
- page/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): Call stopDebugging() if the window is no longer visible.
- 11:27 AM Changeset in webkit [35797] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Tim Hatcher.
- update results for console.dir
- fast/dom/Window/window-properties-expected.txt:
- 11:12 AM Changeset in webkit [35796] by
-
- 7 edits in trunk/WebKit/qt
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_UNDOCOMMAND/STACK
- 11:12 AM Changeset in webkit [35795] by
-
- 2 edits in trunk/WebKit/qt
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_STYLE_STYLESHEET
- 11:12 AM Changeset in webkit [35794] by
-
- 2 edits in trunk/WebKit/qt
Håvard Wall <hwall@trolltech.com>
Fixes: compile with QT_NO_SHORTCUT
- 11:12 AM Changeset in webkit [35793] by
-
- 9 edits in trunk
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_CONTEXTMENU
- 11:11 AM Changeset in webkit [35792] by
-
- 7 edits in trunk
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_WHEELEVENT
- 11:11 AM Changeset in webkit [35791] by
-
- 3 edits in trunk/WebKit/qt
Håvard Wall <hwall@trolltech.com>
Fixes: compile with QT_NO_PRINTER
- 11:10 AM Changeset in webkit [35790] by
-
- 3 edits in trunk/WebKit/qt
2008-08-15 David Boddie <dboddie@trolltech.com>
Reviewed by Simon.
Doc: Added documentation for default property values.
- 11:10 AM Changeset in webkit [35789] by
-
- 2 edits in trunk/WebKit/qt
David Boddie <dboddie@trolltech.com>
Doc: Renamed snippets that appear in the code directory.
- 10:48 AM Changeset in webkit [35788] by
-
- 7 edits in trunk/WebCore
Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
Reviewed by Tim Hatcher.
- page/Console.cpp: (WebCore::Console::group): (WebCore::Console::groupEnd):
- page/Console.h: (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
- page/InspectorController.cpp: (WebCore::InspectorController::startGroup): Increments group level by one and adds console message with StartGroupMessaageLevel. (WebCore::InspectorController::endGroup): Decrements group level by one and adds console message with EndGroupMessaageLevel.
- page/InspectorController.h:
- page/inspector/Console.js: (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup if the message is StartGroupMessaageLevel. (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleGroup.prototype.addMessage):
- page/inspector/inspector.js:
- 10:35 AM Changeset in webkit [35787] by
-
- 8 edits in trunk/WebCore
Adds support for console.dir to the Inspector
Reviewed by Tim Hatcher.
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::dir):
- page/Console.cpp: (WebCore::Console::dir):
- page/Console.h: Added ObjectMessageLevel.
- page/Console.idl: Added console.dir.
- page/inspector/Console.js: (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an ObjectPropertiesSection if the MessageLevel is Object.
- page/inspector/ObjectPropertiesSection.js: "in" operator can't be used on primitive data types.
- page/inspector/inspector.css:
- 10:06 AM Changeset in webkit [35786] by
-
- 2 edits in trunk/WebCore
Adds support for clear() in the Inspector console.
Reviewed by Tim Hatcher.
- page/inspector/Console.js:
- 10:02 AM Changeset in webkit [35785] by
-
- 2 edits in trunk/WebCore
Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
Platform distinction and modifier key matching adjusted
by Daniel Jalkut <jalkut@red-sweater.com>
Bug 16313: text search (find) keybindings should work in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=16313
Reviewed by Tim Hatcher.
- page/inspector/inspector.js: Added a case for the F key
- 9:50 AM Changeset in webkit [35784] by
-
- 2 edits in trunk/WebCore
Fix for error when the string doesn't contain a webkit-profile link.
Reviewed by Tim Hatcher.
- page/inspector/inspector.js:
- 9:33 AM Changeset in webkit [35783] by
-
- 3 edits1 add in trunk/WebCore
Fixes two bugs where JavaScript could be executed from the page
while the debugger is paused.
The first issue was JSLazyEventListener not checking the paused
state before parsing the code.
The second issue was with the PageGroup version of
JavaScriptDebugServer::setJavaScriptPaused always passing false
to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
and not the paused argument.
Reviewed by Adam Roben.
- bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Check the paused state of the ScriptController. Return early if paused.
- manual-tests/inspector/debugger-execution-while-paused.html: Added.
- page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Pass the paused argument to the Page version of setJavaScriptPaused.
- 7:55 AM Changeset in webkit [35782] by
-
- 2 edits in trunk/JavaScriptCore
Fix the 64-bit build.
Add extra cast to avoid warnings about loss of precision when casting from
JSValue* to an integer type.
- kjs/JSImmediate.h:
(KJS::JSImmediate::intValue):
(KJS::JSImmediate::uintValue):
- 4:59 AM Changeset in webkit [35781] by
-
- 2 edits in trunk/JavaScriptCore
Still fixing Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added OpaqueJSString to yet another place.
- 4:41 AM Changeset in webkit [35780] by
-
- 1 edit in trunk/JavaScriptCore/kjs/JSImmediate.h
Windows build fix
- 4:14 AM Changeset in webkit [35779] by
-
- 1 edit1 add in trunk/JavaScriptCore
Trying to fix non-Apple builds.
- ForwardingHeaders/JavaScriptCore/OpaqueJSString.h: Added.
- 3:42 AM Changeset in webkit [35778] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Allow JSImmediate to hold 31 bit signed integer immediate values. The low two bits of a
JSValue* are a tag, with the tag value 00 indicating the JSValue* is a pointer to a
JSCell. Non-zero tag values used to indicate that the JSValue* is not a real pointer,
but instead holds an immediate value encoded within the pointer. This patch changes the
encoding so both the tag values 01 and 11 indicate the value is a signed integer, allowing
a 31 bit value to be stored. All other immediates are tagged with the value 10, and
distinguished by a secondary tag.
Roughly +2% on SunSpider.
- kjs/JSImmediate.h: Encoding of JSImmediates has changed - see comment at head of file for
descption of new layout.
- 3:18 AM Changeset in webkit [35777] by
-
- 4 edits in trunk/JavaScriptCore
More build fixes.
- API/OpaqueJSString.h: Add a namespace to friend declaration to appease MSVC.
- API/JSStringRefCF.h: (JSStringCreateWithCFString) Cast UniChar* to UChar* explicitly.
- JavaScriptCore.exp: Added OpaqueJSString::create(const KJS::UString&) to fix WebCore build.
- 1:32 AM Changeset in webkit [35776] by
-
- 5 edits in trunk/JavaScriptCore
Build fix.
- JavaScriptCore.xcodeproj/project.pbxproj: Marked OpaqueJSString as private
- kjs/identifier.cpp: (KJS::Identifier::checkSameIdentifierTable):
- kjs/identifier.h: (KJS::Identifier::add): Since checkSameIdentifierTable is exported for debug build's sake, gcc wants it to be non-inline in release builds, too.
- JavaScriptCore.exp: Don't export inline OpaqueJSString destructor.
- 12:43 AM Changeset in webkit [35775] by
-
- 19 edits2 adds in trunk
Reviewed by Geoff Garen.
JSStringRef is created context-free, but can get linked to one via an identifier table,
breaking an implicit API contract.
Made JSStringRef point to OpaqueJSString, which is a new string object separate from UString.
Aug 14, 2008:
- 11:15 PM Changeset in webkit [35774] by
-
- 2 edits in trunk/WebKit/win
Update cache capacities to match values used on Mac.
Reviewed by Dan Bernstein.
- WebView.cpp: (WebView::setCacheModel):
- 10:10 PM Changeset in webkit [35773] by
-
- 2 edits in trunk/WebCore
wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
- 5:53 PM Changeset in webkit [35772] by
-
- 2 edits in trunk/WebCore
2008-08-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
<video> elements on Windows never becomes visible when a page is restored from the cache
Always pass "set" calls down to MediaPlayerPrivate instead of only when the
value is different from the cached value. Let the implementation decide when
to avoid work because nothing has changed.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setVolume): (WebCore::MediaPlayer::setRate): (WebCore::MediaPlayer::setRect): (WebCore::MediaPlayer::setVisible):
- 5:44 PM Changeset in webkit [35771] by
-
- 4 edits in trunk/WebKit/win
2008-08-14 Sam Weinig <sam@webkit.org>
Reviewed by Jon Honeycutt.
Add WebView SPI to set HTMLTokenizer yielding parameters.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp: (WebView::setCustomHTMLTokenizerTimeDelay): (WebView::setCustomHTMLTokenizerChunkSize):
- WebView.h:
- 4:58 PM Changeset in webkit [35770] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add the bug URL to the ChangeLog.
- 4:57 PM Changeset in webkit [35769] by
-
- 2 edits1 add in trunk/WebCore
Make Firebug command line API respect predefined variables.
Reviewed by Tim Hatcher.
- page/inspector/Console.js:
- 4:45 PM Changeset in webkit [35768] by
-
- 2 edits2 adds in trunk/LayoutTests
2008-08-14 Simon Fraser <Simon Fraser>
Fix testcase and add pixel results for testcase in
https://bugs.webkit.org/show_bug.cgi?id=20367
- platform/mac/fast/css/font-face-in-media-rule-expected.checksum: Added.
- platform/mac/fast/css/font-face-in-media-rule-expected.png: Added.
- platform/mac/fast/css/font-face-in-media-rule-expected.txt:
- 4:33 PM Changeset in webkit [35767] by
-
- 9 edits in trunk
WebCore:
2008-08-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen and Timothy Hatcher.
Allow programatically setting the HTMLTokenizers time delay and chunk size
which are used for determining how aggressively we yield.
- WebCore.base.exp:
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::continueProcessing):
- html/HTMLTokenizer.h:
- page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setCustomHTMLTokenizerTimeDelay): (WebCore::Page::setCustomHTMLTokenizerChunkSize):
- page/Page.h: (WebCore::Page::hasCustomHTMLTokenizerTimeDelay): (WebCore::Page::customHTMLTokenizerTimeDelay): (WebCore::Page::hasCustomHTMLTokenizerChunkSize): (WebCore::Page::customHTMLTokenizerChunkSize):
WebKit/mac:
2008-08-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen and Timothy Hatcher.
Add WebView SPI to set HTMLTokenizer yielding parameters.
- WebView/WebView.mm: (-[WebView _setCustomHTMLTokenizerTimeDelay:]): (-[WebView _setCustomHTMLTokenizerChunkSize:]):
- WebView/WebViewPrivate.h:
- 4:20 PM Changeset in webkit [35766] by
-
- 7 edits in trunk/WebCore
Reviewed by Beth.
Move us one step closer to cross-platform svg/graphics code
- WebCore.xcodeproj/project.pbxproj:
- html/CanvasStyle.cpp:
- platform/graphics/Color.cpp: (WebCore::colorWithOverrideAlpha):
- platform/graphics/Color.h:
- svg/graphics/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::strokeBoundingBox):
- svg/graphics/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
- 4:19 PM Changeset in webkit [35765] by
-
- 4 edits in trunk/WebCore
Reviewed by Alexey.
Remove un-need includes from HTMLCanvas and use the
Gradient platform abstraction in one place in CanvasStyle
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fillRect):
- html/CanvasStyle.cpp:
- html/HTMLCanvasElement.cpp:
- 4:19 PM Changeset in webkit [35764] by
-
- 2 edits in trunk/WebCore
Reviewed by Alexey.
Clean up GlyphBuffer.h, removing more #ifdefs
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
- 4:19 PM Changeset in webkit [35763] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam.
Clean up AffineTransform.h, removing #ifdefs
- platform/graphics/AffineTransform.h:
- platform/graphics/cairo/AffineTransformCairo.cpp:
- platform/graphics/cg/AffineTransformCG.cpp:
- platform/graphics/qt/AffineTransformQt.cpp:
- platform/graphics/wx/AffineTransformWx.cpp:
- 4:12 PM Changeset in webkit [35762] by
-
- 4 edits in trunk/WebCore
2008-08-14 Dan Bernstein <mitz@apple.com>
- fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex):
- platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex):
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex):
- 4:08 PM Changeset in webkit [35761] by
-
- 6 edits in trunk/WebCore
2008-08-14 Dan Bernstein <mitz@apple.com>
Reviewed by Brady Eidson.
- fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): Added initialization of m_hasUniformFrameSize. (WebCore::BitmapImage::cacheFrame): Added code to get the size of the cached frame for use in decoded size computation and for setting m_hasUniformFrameSize. (WebCore::BitmapImage::currentFrameSize): Added. (WebCore::BitmapImage::dataChanged): Added code to reset m_hasUniformFrameSize.
- platform/graphics/BitmapImage.h: Added currentFrameSize() and m_hasUniformFrameSize.
- platform/graphics/ImageSource.h: Added frameSizeAtIndex().
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This fixes the bug, which resulted from assuming that the frame being drawn was the same size as the first frame.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and changed to get the size of the frame at the given index. (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
- 4:04 PM Changeset in webkit [35760] by
-
- 3 edits2 adds in trunk
2008-08-13 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel
Fix @font-face inside @media rule crash.
https://bugs.webkit.org/show_bug.cgi?id=20367
Test: fast/css/font-face-in-media-rule.html
- css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet):
- 3:52 PM Changeset in webkit [35759] by
-
- 6 edits in trunk/WebCore
wx build fixes after recent changes to Canvas and Image classes.
- 12:26 PM Changeset in webkit [35758] by
-
- 2 edits in trunk/WebCore
2008-08-14 Maxime Britto <britto@apple.com>
Reviewed by Sam Weinig.
rdar://6102511
When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
IE and FF are both preventing the keyboard event to interact with the page while scrolling.
Some differences exist between them concerning the kind of key which is pressed :
IE7 : every key leads to a stop of the panning
FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
- 12:14 PM Changeset in webkit [35757] by
-
- 4 edits in trunk/WebCore
Gtk+/ Cairo build fix, patch by Dirk Schulze.
- 11:11 AM Changeset in webkit [35756] by
-
- 16 edits in trunk
2008-08-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6115819> Notify of profile in console
- Profiles now have a unique ID so that they can be linked to the console message that announces that a profile completed.
- profiler/HeavyProfile.cpp: (KJS::HeavyProfile::HeavyProfile):
- profiler/Profile.cpp: (KJS::Profile::create): (KJS::Profile::Profile):
- profiler/Profile.h: (KJS::Profile::uid):
- profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
- profiler/ProfileGenerator.h:
- profiler/Profiler.cpp: (KJS::Profiler::startProfiling):
- profiler/TreeProfile.cpp: (KJS::TreeProfile::create): (KJS::TreeProfile::TreeProfile):
- profiler/TreeProfile.h:
WebCore:
2008-08-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6115819> Notify of profile in console
- page/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileMessageToConsole): Called by addProfile this is the function that adds a message to the console that a profile finished.
- page/InspectorController.h:
- page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match the console log to the profile in the web inspector. (WebCore::getUniqueIdCallback): (WebCore::ProfileClass):
- page/inspector/ProfilesPanel.js: Created a map of all the profiles by Id to bring up the requested profile. Also select and reveal the profile in the profile panel. And created displayTitleForProfileLink() which formats a title taking into account if it's user initiated or if there are multiples. Lasty, I put the user initiated profile in a variable.
- page/inspector/inspector.js: Make the profile title be a clickable link that will take the user to the identified profile. Also expose the count of user initiated profiles so they can be displayed in the console with the correct count.
- 10:41 AM Changeset in webkit [35755] by
-
- 3 edits in trunk/WebCore
Avoid formating ConsoleMessages twice unless the message will be
displayed in bubbles of a SourceFrame.
Reviewed by Kevin McCullough.
- page/inspector/Console.js: (WebInspector.ConsoleMessage): Only format the plain text message if the URL and line are valid and the level is error or warning. (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added. Helper to test for error or warning level.
- page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): Don't add the message if there is no message or valid line or if the msg isn't an error or warning.
- 9:12 AM Changeset in webkit [35754] by
-
- 2 edits in trunk/WebKit/mac
Fixes a bug where Safari's find banner would be permanently hidden
when attaching or closing the Web Inspector while attached.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close]): Carefully manipulate the WebFrameView's frame when closing to not assume the WebFrameView's frame fills the inspected WebView. (-[WebInspectorWindowController setAttachedWindowHeight:]): Carefully manipulate the WebFrameView's frame when docking to not assume the WebFrameView plus the Web Inspector WebViews fills the full inspected WebView.
- 8:07 AM Changeset in webkit [35753] by
-
- 2 edits in trunk/WebCore
2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
partial Gtk build fix, not reviewed
- platform/graphics/cairo/PatternCairo.cpp:
Aug 13, 2008:
- 9:49 PM Changeset in webkit [35752] by
-
- 2 edits in trunk/WebCore
2008-08-13 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlson.
Fix style issue.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia):
- 9:26 PM Changeset in webkit [35751] by
-
- 2 edits in trunk/WebKit/mac
2008-08-13 Stephanie Lewis <Stephanie Lewis>
fix 64bit build
- WebCoreSupport/WebInspectorClient.mm:
- 8:43 PM Changeset in webkit [35750] by
-
- 2 edits in trunk/JavaScriptCore
2007-08-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Nixed a PIC branch from JSObject::getOwnPropertySlot, by forcing
fillGetterProperty, which references a global function pointer,
out-of-line.
.2% SunSpider speedup, 4.3% access-nbody speedup, 8.7% speedup on a
custom property access benchmark for objects with one property.
- kjs/JSObject.cpp: (KJS::JSObject::fillGetterPropertySlot):
- 8:16 PM Changeset in webkit [35749] by
-
- 4 edits in trunk
Versioning.
- 8:13 PM Changeset in webkit [35748] by
-
- 1 copy in tags/Safari-6528.1
New tag.
- 8:06 PM Changeset in webkit [35747] by
-
- 2 edits in trunk/WebCore
Build fix for Cairo, not reviewed. (exposed by gtk build slave)
Continue Erics build fixes, after the Image cleanup.
- 7:38 PM Changeset in webkit [35746] by
-
- 2 edits in trunk/WebCore
Build fix for Qt, not reviewed.
Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.
- 7:26 PM Changeset in webkit [35745] by
-
- 2 edits in trunk/WebCore
Build fix, not reviewed.
Add ScriptElement.cpp to Gtk build.
- 7:22 PM Changeset in webkit [35744] by
-
- 10 edits2 adds in trunk/WebCore
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
Refactor HTMLScriptElement's code into a common base class: ScriptElement.
SVGScriptElement will be converted to use ScriptElement in a follow-up patch.
This resolves code duplications and allows us to completly replace the old
SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)
As ScriptElement, doesn't actually inherit from Element, we may want to rename
it, though StyleElement uses the same naming convention, so I left it as is for now.
Eventually we'll rename both files in future.
No functional changes yet, as SVGScriptElement doesn't yet use the new base class.
- 7:17 PM Changeset in webkit [35743] by
-
- 4 edits in trunk/WebCore
Attempt to fix the Gtk build, no review.
I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/qt/GradientQt.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozWidget):
- 7:06 PM Changeset in webkit [35742] by
-
- 2 edits in trunk/WebKit/win
Attempt to fix the windows build, not review.
- WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap):
- 7:03 PM Changeset in webkit [35741] by
-
- 3 edits in trunk/WebCore
Attempt to fix the Windows build, no review.
- platform/win/CursorWin.cpp: (WebCore::loadCursorByName):
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::paint):
- 6:29 PM Changeset in webkit [35740] by
-
- 3 edits in trunk/WebCore
Attempt to fix the Windows build, no review.
- platform/win/CursorWin.cpp: (WebCore::loadCursorByName):
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::paint):
- 6:24 PM Changeset in webkit [35739] by
-
- 2 edits in trunk/WebCore
Attempt to fix the Qt build, no review.
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::image):
- 6:21 PM Changeset in webkit [35738] by
-
- 3 edits in trunk/WebCore
Attempt to fix the Windows build, no review.
- platform/graphics/win/ImageWin.cpp: (WebCore::Image::loadPlatformResource):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintMissingPluginIcon):
- 6:15 PM Changeset in webkit [35737] by
-
- 3 edits in trunk/WebCore
Another attempt to fix the Qt build, no review.
- platform/graphics/qt/ImageQt.cpp:
- platform/graphics/qt/StillImageQt.h:
- 6:05 PM Changeset in webkit [35736] by
-
- 2 edits in trunk/WebCore
No review, build fix only.
Fix mac build, due to change in new code since my patch was written.
- svg/graphics/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
- 5:59 PM Changeset in webkit [35735] by
-
- 3 edits in trunk/WebCore
Build fix only, no review.
Attempt to fix the Qt build.
- platform/graphics/qt/ImageBufferQt.cpp:
- platform/graphics/qt/StillImageQt.h: (WebCore::StillImage::create): (WebCore::StillImage::destroyDecodedData): (WebCore::StillImage::decodedSize):
- 5:42 PM Changeset in webkit [35734] by
-
- 2 edits in trunk/WebCore
Build fix only, no review.
Attempt to fix the Qt build.
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
- 5:30 PM Changeset in webkit [35733] by
-
- 3 edits3 adds in trunk
Reviewed by Sam.
Match HTML5 spec by throwing INVALID_STATE_ERR when
createPattern is called and the HTMLImageElement is not
yet done loading the image (!isComplete)
https://bugs.webkit.org/show_bug.cgi?id=20351
Test: http/misc/canvas-pattern-from-incremental-image.html
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
- 5:29 PM Changeset in webkit [35732] by
-
- 16 edits5 adds in trunk/WebCore
Reviewed by Niko.
Split out a Pattern class from CanvasPattern
and remove all the Pattern-related #ifdefs
(This will break non-mac platforms! I will fix them.)
https://bugs.webkit.org/show_bug.cgi?id=20351
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/CanvasPattern.cpp: (WebCore::CanvasPattern::parseRepetitionType): (WebCore::CanvasPattern::CanvasPattern):
- html/CanvasPattern.h: (WebCore::CanvasPattern::create): (WebCore::CanvasPattern::pattern): (WebCore::CanvasPattern::originClean):
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
- html/CanvasRenderingContext2D.h:
- html/HTMLCanvasElement.cpp:
- html/HTMLCanvasElement.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createHistoryItem):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern):
- 5:29 PM Changeset in webkit [35731] by
-
- 26 edits in trunk/WebCore
Reviewed by Niko.
Make Images RefCounted (and clean up callers)
https://bugs.webkit.org/show_bug.cgi?id=20351
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
- loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::brokenImage): (WebCore::nullImage): (WebCore::CachedImage::image): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::createImage):
- loader/CachedImage.h:
- loader/icon/IconRecord.cpp: (WebCore::IconRecord::setImageData): (WebCore::IconRecord::loadImageFromResource):
- loader/icon/IconRecord.h:
- platform/graphics/BitmapImage.h: (WebCore::BitmapImage::create):
- platform/graphics/GeneratedImage.h:
- platform/graphics/Gradient.cpp:
- platform/graphics/Gradient.h:
- platform/graphics/Image.cpp: (WebCore::Image::nullImage):
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::image):
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::image): (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
- platform/graphics/cg/PDFDocumentImage.h: (WebCore::PDFDocumentImage::create): (WebCore::PDFDocumentImage::destroyDecodedData): (WebCore::PDFDocumentImage::decodedSize):
- platform/graphics/gtk/ImageGtk.cpp: (WebCore::Image::loadPlatformResource):
- platform/graphics/mac/ImageMac.mm: (WebCore::Image::loadPlatformResource):
- rendering/RenderImage.cpp:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls):
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
- svg/graphics/SVGImage.h: (WebCore::SVGImage::create): (WebCore::SVGImage::destroyDecodedData): (WebCore::SVGImage::decodedSize): (WebCore::SVGImage::frameAtIndex):
- svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: (WebCore::SVGPaintServerPattern::setup):
- svg/graphics/cairo/SVGResourceMaskerCairo.cpp: (WebCore::SVGResourceMasker::applyMask):
- svg/graphics/cg/SVGPaintServerPatternCg.cpp: (WebCore::patternCallback):
- svg/graphics/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
- 5:28 PM Changeset in webkit [35730] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam.
Remove #ifdefs from CanvasStyle by using platform/Color.h
There are some down-sides to this commit.
This commit limits us to 255 levels of grey for calls like:
context.setStrokeStyle(.37, 1.0)
previously CG might have used up to 32bits to store the grey level
Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.
Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
to RGBA32 (like all the rest of colors in WebCore), thus:
context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32
If this is a problem for Dashboard, we can either roll out this commit
or add a beefier Color abstraction, which can be used internally by GraphicsContext
when keeping state, and then GraphicsContext can grow some additional set* routines
for setting the a grey/float/whatever fill and stroke.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFillStyle):
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle): (WebCore::colorWithOverrideAlpha): (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
- html/CanvasStyle.h:
- platform/graphics/Color.cpp: (WebCore::colorFloatToRGBAByte): (WebCore::makeRGBA32FromFloats):
- platform/graphics/Color.h:
- 4:50 PM Changeset in webkit [35729] by
-
- 3 edits2 adds in trunk
WebCore:
2008-08-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Fix for <rdar://problem/6137931>
https://bugs.webkit.org/show_bug.cgi?id=20360
Remove all parameters from the MIME type before checking with the MIME type registry
Tests: media/video-source-type-params.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';' to isSupportedMediaMIMEType()
LayoutTests:
2008-08-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/6137931>
https://bugs.webkit.org/show_bug.cgi?id=20360
Add test case for parameters on a <source> element 'type' attribute.
- media/video-source-type-params-expected.txt: Added.
- media/video-source-type-params.html: Added.
- 2:36 PM Changeset in webkit [35728] by
-
- 4 edits in trunk/WebCore
2008-08-13 Beth Dakin <Beth Dakin>
Reviewed by Sam Weinig.
Fix for <rdar://problem/6141345>
This patch refines findString and markAllMatchesForText functions'
interactions with disconnected frames. They no longer rely on
knowing where a range is relative to the visible region and work
with disconnected frames that contain frames.
- editing/Editor.cpp: (WebCore::Editor::insideVisibleArea): Now returns a bool instead of the visiblity enum. (WebCore::Editor::firstVisibleRange): This now returns the very first visible range in the document. It's no longer dependent on searching forward. (WebCore::Editor::lastVisibleRange): This now returns the very last visible range in the document. It's no longer dependent on searching backwards. (WebCore::Editor::nextVisibleRange): This returns the next visible range in the appropriate direction from the current range.
- editing/Editor.h:
- page/Frame.cpp: (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText):
- 1:07 PM Changeset in webkit [35727] by
-
- 2 edits in trunk/WebCore
wx build fix for case-sensitive platforms, like Linux.
- 1:00 PM Changeset in webkit [35726] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-13 Alp Toker <alp@nuanti.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20349
WTF::initializeThreading() fails if threading is already initialized
Fix threading initialization logic to support cases where
g_thread_init() has already been called elsewhere.
Resolves database-related crashers reported in several applications.
- wtf/ThreadingGtk.cpp: (WTF::initializeThreading):
- 12:56 PM Changeset in webkit [35725] by
-
- 2 edits in trunk/WebCore
2008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=16881
[GTK] PlatformScreenGtk is unimplemented
Original patch by Christian Dywan.
- platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
- 12:42 PM Changeset in webkit [35724] by
-
- 2 edits in trunk/WebCore
2008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=20318
SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add
g_idle_add is the same as g_idle_add_full with a priority of
G_PRIORITY_DEFAULT_IDLE, so we can safely use that.
- platform/gtk/SharedTimerGtk.cpp: (WebCore::setSharedTimerFireTime):
- 12:03 PM Changeset in webkit [35723] by
-
- 6 edits in trunk/WebKit/win
Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
Added IWebFrame::paintDocumentRectToContext() so we can paint a frame's
content into a device context. Changed WebView::paintDocumentRectToContext()
to call that WebFrame method.
Reviewed by Adam Roben.
- DOMHTMLClasses.cpp: (DOMHTMLElement::idName):
- Interfaces/IWebFramePrivate.idl:
- WebFrame.cpp: (WebFrame::paintDocumentRectToContext): (WebFrame::frameElement):
- WebFrame.h:
- WebView.cpp: (WebView::paintDocumentRectToContext):
- 11:11 AM Changeset in webkit [35722] by
-
- 7 edits in trunk
Remember the docked state of the Web Inspector, so it can be reopened docked if it was last docked.
WebCore:
2008-08-13 Timothy Hatcher <timothy@apple.com>
Changed the InspectorController so it can be notified when the
attached state of the Inspector changes in WebKit.
Reviewed by Kevin McCullough.
- WebCore.base.exp: Updated the symbol for setWindowVisible.
- page/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): Added an attached argument, that defaults to false.Call setAttachedWindow with the attached argument. (WebCore::InspectorController::setAttachedWindow): Call the script version of setAttachedWindow.
- page/InspectorController.h:
- page/inspector/inspector.js: (WebInspector.setAttachedWindow): Set the attached property.
WebKit/mac:
2008-08-13 Timothy Hatcher <timothy@apple.com>
Remember the docked state of the Web Inspector, so it can be
reopened docked if it was last docked.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Initialize _shouldAttach to the value stored in the user defaults. If there has never been a value stored, default to being attached. (-[WebInspectorWindowController showWindow:]): Pass the attached state to InspectorController::setWindowVisible.
- 11:10 AM Changeset in webkit [35721] by
-
- 2 edits in trunk/WebKit/mac
Remove the Inspector's WebView for the view hierarchy when closed
while attached. This prevents it from showing in the background
while the page changes.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close:]): Call removeFromSuperview on the Inspector's WebView if it isn't attached, so it will not be visible when navigating pages while closed.
- 11:10 AM Changeset in webkit [35720] by
-
- 6 edits1 add in trunk/WebCore
Added a close button to the Inspector's toolbar when docked.
Reviewed by Kevin McCullough.
- page/InspectorController.cpp: (WebCore::closeWindow): Call InspectorController::closeWindow. (WebCore::InspectorController::windowScriptObjectAvailable): Added closeWindow to the script class.
- page/InspectorController.h:
- page/inspector/Images/closeButtons.png: Added.
- page/inspector/inspector.css: Added and changed styles.
- page/inspector/inspector.html: Added the close button.
- page/inspector/inspector.js: (WebInspector.loaded): Added click event listener to the close button. (WebInspector.close): Call InspectorController.closeWindow.
- 11:10 AM Changeset in webkit [35719] by
-
- 23 edits in trunk
Make the docked Web Inspector resizable.
WebCore:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Make the docked Web Inspector resizable. This is the cross platform
portion of the code. Each InspectorClient needs to implement the
real resize code.
Reviewed by Kevin McCullough.
- loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
- page/InspectorClient.h: Added setAttachedWindowHeight.
- page/InspectorController.cpp: (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight on the InspectorController. (WebCore::InspectorController::setAttachedWindowHeight): Call setAttachedWindowHeight on the client. (WebCore::InspectorController::windowScriptObjectAvailable): Added setAttachedWindowHeight to the script class.
- page/InspectorController.h:
- page/inspector/inspector.css: Make the cursor on the toolbar be row-resize when docked.
- page/inspector/inspector.js: (WebInspector.loaded): Always add the toolbarDragStart event listener. (WebInspector.toolbarDragStart): Return early if we are not attached and not on Leopard. Call WebInspector.elementDragStart. (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd. (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight, otherwise call moveByUnrestricted.
WebKit/gtk:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Add a stub for InspectorClient::setAttachedWindowHeight.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::setAttachedWindowHeight): Call notImplemented().
- WebCoreSupport/InspectorClientGtk.h:
WebKit/mac:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Make the docked Web Inspector resizable.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::setAttachedWindowHeight): Call setAttachedWindowHeight: on the WebInspectorWindowController. (-[WebInspectorWindowController showWindow:]): Call setAttachedWindowHeight:. (-[WebInspectorWindowController setAttachedWindowHeight:]): Moved code from showWindow: and generalized to allow being called multiple times. Remembers the last height passed, which is used by showWindow: the next time the Inspector attaches.
WebKit/qt:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Add a stub for InspectorClient::setAttachedWindowHeight.
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::setAttachedWindowHeight): Call notImplemented().
- WebCoreSupport/InspectorClientQt.h:
WebKit/win:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Add a stub for InspectorClient::setAttachedWindowHeight.
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::setAttachedWindowHeight): Add a FIXME to implement this.
- WebCoreSupport/WebInspectorClient.h:
WebKit/wx:
2008-08-12 Timothy Hatcher <timothy@apple.com>
Add a stub for InspectorClient::setAttachedWindowHeight.
- WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::setAttachedWindowHeight): Call notImplemented().
- WebKitSupport/InspectorClientWx.h:
- 7:32 AM Changeset in webkit [35718] by
-
- 2 edits in trunk/WebKit/qt
2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Use full-page zoom in QtLauncher.
- QtLauncher/main.cpp: (MainWindow::zoomIn): (MainWindow::zoomOut): (MainWindow::resetZoom): (MainWindow::setupUI):
- 7:32 AM Changeset in webkit [35717] by
-
- 2 edits in trunk/WebKit/qt
2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix linking with QtWebKit.
- Api/qwebframe.h: remove non-existing function/property.
- 6:43 AM Changeset in webkit [35716] by
-
- 9 edits in trunk
WebCore:
2008-08-13 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Initialize m_zoomsTextOnly in the Settings constructor.
WebKit/qt:
2008-08-13 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Based on patch by Siraj razick <siraj.razick@collabora.co.uk>
Added functions to get/set the zoom factor.
Added a QWebFrame/QWebView::zoomFactor as well as a boolean
ZoomTextOnly attribute in QWebSettings.
- 6:33 AM Changeset in webkit [35715] by
-
- 2 edits in trunk/LayoutTests
Removing http/tests/xmlhttprequest/readystatechange.html from Windows skipped list -
this test hasn't been failing locally for a long time.
- platform/win/Skipped:
- 6:31 AM Changeset in webkit [35714] by
-
- 4 edits in trunk
2008-08-13 Brad Hughes <bhughes@trolltech.com>
Reviewed by Simon.
Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux
The latest upgrade of the intel compiler allows us to compile all of
Qt with optimizations enabled (yay!).
- 6:24 AM Changeset in webkit [35713] by
-
- 2 edits in trunk/WebCore
2008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
Reviewed by Simon.
Fix QtWebKit not displaying content on 403 HTTP responses
Just like with 404 responses also display content with 403, as
used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/
- 6:16 AM Changeset in webkit [35712] by
-
- 3 edits2 adds in trunk
WebCore:
2008-08-13 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Make the formatting of String::format() locale independent through the use of QString::vsprintf.
LayoutTests:
2008-08-13 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Adjusted the length-list-parser layout test to compensate for the subtle difference of
dropping a sign for a "negative zero" as a result of the QString::vsprintf use.
- 5:07 AM Changeset in webkit [35711] by
-
- 2 edits in trunk/WebKitTools
2008-08-13 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Holger.
Revert r31585 and disable http tests for the Qt build again unless
explicitly enabled.
Running the http tests unfortunately currently still triggers
failures in non-http tests due to side-effects. Disable them by default for
now, for more reliable results.
- 5:02 AM Changeset in webkit [35710] by
-
- 4 edits in trunk
2008-08-13 Simon Hausmann <Simon Hausmann>
Reviewed by Lars.
Fix QWebFrame::setHtml() not setting the new contents immediately.
Added a setter to the DocumentLoader to toggle the deferred loading of the main
resource when it comes from substitute data.
Disable deferred loading of the main resource when we have valid substitute data,
as used by QWebFrame::setHtml.
- 4:51 AM Changeset in webkit [35709] by
-
- 4 edits in trunk/WebKit/qt
2008-08-13 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Holger.
Fix QWebPage::isModified().
isModified() would return true after loading a new page or it would continue to
return true after undoing modifications. Fix this by eliminating the
QWebPagePrivate::modified variable and use the undoStack's canUndo() property
instead.
- 4:38 AM Changeset in webkit [35708] by
-
- 2 edits in trunk/WebKit/qt
2008-08-13 David Boddie <dboddie@trolltech.com>
Reviewed by Simon.
Updated docs with the signal emission behavior of urlChanged()
- 4:35 AM Changeset in webkit [35707] by
-
- 2 edits in trunk/WebKit/qt
2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix Ctrl+Y to work again when editing text in contextEditable mode.
This fixes regression in LayoutTests/editing/pasteboard/emacs-cntl-y-001.html
- 2:58 AM Changeset in webkit [35706] by
-
- 2 edits in trunk/WebCore
Speculative GTK build fix.
- 2:11 AM Changeset in webkit [35705] by
-
- 4 edits in trunk
2008-08-13 Thiago Macieira <tjmaciei@trolltech.com>
Reviewed by Simon.
Fix encoding of [ and ] in the host part of the URL
Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
doesn't encode [ and ] when they are found in the host part. That is, the
following URL:
http://[::1]/
is valid and should not be reencoded to:
http://%5b::1%5d/
Aug 12, 2008:
- 9:35 PM Changeset in webkit [35704] by
-
- 2 edits in trunk/LayoutTests
2008-08-12 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
- platform/mac/Skipped: Add fast/dom/cssTarget-crash.html to the skipped list.
- 8:17 PM Changeset in webkit [35703] by
-
- 3 edits in trunk/JavaScriptCore
Add peephole optimisation to 'op_not... jfalse...' (eg. if(!...) )
Reviewed by Geoff Garen
This is a very slight win in sunspider, and a fairly substantial win
in hot code that does if(!...), etc.
- 3:49 PM Changeset in webkit [35702] by
-
- 5 edits in trunk/LayoutTests
Not reviewed.
Revert the last SVGLineElement commit. It's not needed, the first run on buildbot showed them as failures
the next build doesn't complain anymore (this was before adjusting the offsets.) No idea what's going on,
but if it's fixed I'm happy.
While I'm at it, regenerate struct-image-02-b.svg (invisible differences) to have a clean baseline.
All SVG pixel test results are accurate on Leopard now.
- 3:26 PM Changeset in webkit [35701] by
-
- 3 edits in trunk/LayoutTests
Not reviewed. The last SVGLineElement* fix attempt, fixed 4/8 failing tests.
Trying two variations in two tests to find out the right offset to make the other four tests work on Tiger.
- 3:18 PM Changeset in webkit [35700] by
-
- 1 edit40 adds in trunk/LayoutTests
Rubber stamped by Eric.
Add new dynamic-update layout tests covering SVGRectElement.
- 3:13 PM Changeset in webkit [35699] by
-
- 9 edits in trunk/LayoutTests
Not reviewed. Trying to modify mouseevent target location, to work around known CG/Tiger hit test problem.
- 2:59 PM Changeset in webkit [35698] by
-
- 5 edits in trunk/LayoutTests
Reviewed by Sam.
Forgot to include these in my last commit.
- 2:49 PM Changeset in webkit [35697] by
-
- 4 edits2 adds in trunk
WebCore:
2008-08-12 Mihnea Ovidenie <mihnea@adobe.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=19891
Broken HTML object elements cause de-reference of pointer to freed memory.
If we fail to load an image for an object tag and we no longer believe the object tag points at
an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the
fall back content.
Reviewed by Dave Hyatt and Alexey Proskuryakov.
Test: http/tests/misc/object-image-error-with-onload.html
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):
- page/Frame.cpp: (WebCore::Frame::Frame):
LayoutTests:
2008-08-12 Mihnea Ovidenie <mihnea@adobe.com>
Test for https://bugs.webkit.org/show_bug.cgi?id=19891
Broken HTML object elements cause de-reference of pointer to freed memory.
Reviewed by Dave Hyatt and Alexey Proskuryakov.
- http/tests/misc/object-image-error-with-onload-expected.txt: Added.
- http/tests/misc/object-image-error-with-onload.html: Added.
- 2:46 PM Changeset in webkit [35696] by
-
- 84 edits in trunk/LayoutTests
Reviewed by Eric.
Fix typo in most files: "mesage" -> "message".
Remove unused code in SVGTestCase.js
- 2:18 PM Changeset in webkit [35695] by
-
- 1 edit70 adds in trunk/LayoutTests
Rubber stamped by Eric.
Add new dynamic-update layout tests covering SVGPatternElement.
- 2:11 PM Changeset in webkit [35694] by
-
- 13 edits in trunk
Reviewed by Dave.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798
Masks are translated, and the mask images are swapped on the y-axis.
Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm
is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want.
Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate
the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before.
- 2:05 PM Changeset in webkit [35693] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Sam.
Speculative fix for hit testing problems in dynamic-updates/SVGLineElement* on Tiger.
Supposed to fix the hanging tests on the buildbot.
- 2:00 PM Changeset in webkit [35692] by
-
- 2 edits in trunk/LayoutTests
2008-08-12 Sam Weinig <sam@webkit.org>
- fast/dom/Window/window-properties-expected.txt: Update results.
- 1:54 PM Changeset in webkit [35691] by
-
- 11 edits in trunk
- JavaScriptCore part of <rdar://problem/6121636> Make fast*alloc() abort() on failure and add "try" variants that return NULL on failure.
Reviewed by Darin Adler.
- JavaScriptCore.exp: Exported tryFastCalloc().
- VM/RegisterFile.h: (KJS::RegisterFile::RegisterFile): Removed an ASSERT().
- kjs/JSArray.cpp: (KJS::JSArray::putSlowCase): Changed to use tryFastRealloc(). (KJS::JSArray::increaseVectorLength): Ditto.
- kjs/ustring.cpp: (KJS::allocChars): Changed to use tryFastMalloc(). (KJS::reallocChars): Changed to use tryFastRealloc().
- wtf/FastMalloc.cpp: (WTF::fastZeroedMalloc): Removed null checking of fastMalloc()'s result and removed extra call to InvokeNewHook(). (WTF::tryFastZeroedMalloc): Added. Uses tryFastMalloc(). (WTF::tryFastMalloc): Renamed fastMalloc() to this. (WTF::fastMalloc): Added. This version abort()s if allocation fails. (WTF::tryFastCalloc): Renamed fastCalloc() to this. (WTF::fastCalloc): Added. This version abort()s if allocation fails. (WTF::tryFastRealloc): Renamed fastRealloc() to this. (WTF::fastRealloc): Added. This version abort()s if allocation fails. (WTF::do_malloc): Made this a function template. When the abortOnFailure template parameter is set, the function abort()s on failure to allocate. Otherwise, it sets errno to ENOMEM and returns zero. (WTF::TCMallocStats::fastMalloc): Defined to abort() on failure. (WTF::TCMallocStats::tryFastMalloc): Added. Does not abort() on failure. (WTF::TCMallocStats::fastCalloc): Defined to abort() on failure. (WTF::TCMallocStats::tryFastCalloc): Added. Does not abort() on failure. (WTF::TCMallocStats::fastRealloc): Defined to abort() on failure. (WTF::TCMallocStats::tryFastRealloc): Added. Does not abort() on failure.
- wtf/FastMalloc.h: Declared the "try" variants.
WebCore:
- WebCore part of <rdar://problem/6121636> Make fast*alloc() abort() on failure and add "try" variants that return NULL on failure.
Reviewed by Darin Adler.
- platform/Arena.cpp: (WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s result.
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::create): Changed to use tryFastCalloc().
- 11:27 AM Changeset in webkit [35690] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=19348 <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
Test: fast/frames/frameset-style-recalc.html
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base class implementation after marking for layout.
LayoutTests:
Reviewed by Darin Adler.
- test for https://bugs.webkit.org/show_bug.cgi?id=19348 <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works
- fast/frames/frameset-style-recalc.html: Added.
- platform/mac/fast/frames/frameset-style-recalc-expected.checksum: Added.
- platform/mac/fast/frames/frameset-style-recalc-expected.png: Added.
- platform/mac/fast/frames/frameset-style-recalc-expected.txt: Added.
- 10:45 AM Changeset in webkit [35689] by
-
- 4 edits in trunk/WebKit/mac
Remove unneeded header imports from some Web Inspector files.
Reviewed by Adam Roben.
- WebCoreSupport/WebInspectorClient.mm:
- WebInspector/WebInspector.mm:
- WebInspector/WebNodeHighlightView.m:
- 10:45 AM Changeset in webkit [35688] by
-
- 2 edits in trunk/WebKit/mac
Remove the call to WKNSWindowMakeBottomCornersSquare on the
Web Inspector's window. This isn't needed anymore since the
window style masks used always have square bottom corners.
Reviewed by Adam Roben.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]): Remove the call to WKNSWindowMakeBottomCornersSquare.
- 10:45 AM Changeset in webkit [35687] by
-
- 2 edits in trunk/WebKit/mac
Make attaching and detaching the Web Inspector instantaneous.
This also preserves the current view, other state, and keeps
the script debugger attached.
Reviewed by Adam Roben.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close]): Only call setWindowVisible(false) when not moving windows.
- 10:13 AM Changeset in webkit [35686] by
-
- 2 edits in trunk/WebKit/win
Export WTFLog in Debug builds
Reviewed by John Sullivan.
- WebKit.vcproj/WebKit_debug.def:
- 10:04 AM Changeset in webkit [35685] by
-
- 19 edits in trunk
WebCore:
Reviewed by John Sullivan.
- move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden
- WebCore.base.exp:
- page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::shouldUpdateWhileHidden): (WebCore::FrameView::setShouldUpdateWhileHidden):
- page/FrameView.h:
- page/Settings.cpp:
- page/Settings.h:
WebKit/mac:
Reviewed by John Sullivan.
- replace -[WebPreferences updatesWhenOffscreen] with -[WebView shouldUpdateWhileHidden]
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileHidden]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLView.mm: (-[WebHTMLView windowWillOrderOnScreen:]):
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView _preferencesChangedNotification:]): (-[WebView setBackgroundColor:]): (-[WebView setDrawsBackground:]): (-[WebView shouldUpdateWhileHidden]): (-[WebView setShouldUpdateWhileHidden:]):
- WebView/WebViewPrivate.h:
- 7:58 AM Changeset in webkit [35684] by
-
- 2 edits in trunk/WebCore
Windows build fix
- bindings/js/JSSVGPODTypeWrapper.h: Align JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's members on 16-byte boundaries to avoid an alignment warning.
- 7:40 AM Changeset in webkit [35683] by
-
- 3 edits20 adds in trunk/LayoutTests
Rubber stamped by Anders.
Add new dynamic-update layout tests covering SVGCursorElement.
Scale svg/webarchive/resources/green-checker.png to a value < 128x128,
as this is the maximum hardcoded cursor size (fixes manual testing of svg-cursor-subresources.png).
- 5:01 AM Changeset in webkit [35682] by
-
- 1 edit4 moves60 adds in trunk/LayoutTests
Rubber stamped by Oliver.
Add new dynamice-update layout tests covering SVGMaskElement.
Move pixel tests results of SVGMarkerElement* to the right positions, while I'm at it.
- 4:59 AM Changeset in webkit [35681] by
-
- 3 edits in trunk/WebKit/qt
2008-08-12 Urs Wolfer <uwolfer@kde.org>
Reviewed by Simon.
Fix crash in QWebPage in case contextMenuEvent has been overwritten
because context menu has the view as parent and thus is deleted too early.
Add testcase for this crash.
- 3:35 AM Changeset in webkit [35680] by
-
- 3 edits75 adds in trunk
Reviewed by Oliver.
Add new dynamice-update layout tests covering SVGMarkerElement.
Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering.
Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle.
- 3:27 AM Changeset in webkit [35679] by
-
- 3 edits50 adds in trunk
Reviewed by Oliver.
Add new dynamic-update layout tests covering SVGImageElement.
Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes.
Aug 11, 2008:
- 9:28 PM Changeset in webkit [35678] by
-
- 2 edits in trunk/WebCore
Changed Option/Alt-Up or Down in CSS editing when the value is
near zero to jump to the next integer.
Reviewed by Tim Hatcher.
- page/inspector/StylesSidebarPane.js:
- 9:20 PM Changeset in webkit [35677] by
-
- 2 edits in trunk/WebCore
Changed the line highlight transition for an easier animation.
Reviewed by Tim Hatcher.
- page/inspector/SourceFrame.js:
- 8:57 PM Changeset in webkit [35676] by
-
- 2 edits in trunk/WebCore
Added support for some Firebug Command Line APIs.
Reviewed by Tim Hatcher.
https://bugs.webkit.org/show_bug.cgi?id=19867
https://bugs.webkit.org/show_bug.cgi?id=19868
https://bugs.webkit.org/show_bug.cgi?id=19869
https://bugs.webkit.org/show_bug.cgi?id=19875
https://bugs.webkit.org/show_bug.cgi?id=19876
https://bugs.webkit.org/show_bug.cgi?id=19880
- page/inspector/Console.js: (WebInspector.Console.prototype._evalInInspectedWindow): Create an object on the inspected window that holds the console command line API functions. This object is used in a with statement around the typed expression.
- 7:55 PM Changeset in webkit [35675] by
-
- 1 edit110 adds in trunk/LayoutTests
Rubber stamped by Oliver.
Add a bunch of new dynamic-updates tests covering SVGLineElement & SVGRadialGradientElement.
No functional changes needed, all work out of the box.
- 7:22 PM Changeset in webkit [35674] by
-
- 11 edits15 adds in trunk
Reviewed by Antti.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736
JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)
Added tests: svg/custom/svg-modify-currentTranslate.html
svg/custom/tearoffs-with-tearoffs.html
svg/custom/immutable-properties.html
Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html
- 5:34 PM Changeset in webkit [35673] by
-
- 3 edits in trunk/WebCore
2008-08-11 Brady Eidson <beidson@apple.com>
Reviewed by John and Anders
Fix for <rdar://problem/6141797>
When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
would never have nil data.
When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
semantics with some WebKit applications.
The guarantee was a good one and should be restored.
Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
creates an empty data object in the case of null data for its own purposes.
- loader/SubstituteResource.h: (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This well help any future subclassers not make this mistake.
- loader/archive/ArchiveResource.cpp: (WebCore::ArchiveResource::create): Return 0 if the data is null.
- 3:44 PM Changeset in webkit [35672] by
-
- 3 edits2 adds in trunk
2008-08-11 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
https://bugs.webkit.org/show_bug.cgi?id=20328
Fix a problem when an 'all' transition transition with more than
one property changing is interrupted, and did some AnimationController
cleanup.
Test: transitions/interrupted-all-transition.html
- page/AnimationController.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::AnimationControllerPrivate::blendProperties): (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::cleanupFinishedAnimations): (WebCore::CompositeAnimation::setTransitionStartTime): (WebCore::CompositeAnimation::overrideImplicitAnimations): (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations): (WebCore::ImplicitAnimation::animate): (WebCore::ImplicitAnimation::onAnimationEnd): (WebCore::ImplicitAnimation::sendTransitionEvent): (WebCore::ImplicitAnimation::affectsProperty): (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::onAnimationEnd):
- 1:45 PM Changeset in webkit [35671] by
-
- 3 edits in trunk/WebCore
2008-08-11 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
- Because console messages have group levels now, newly created messages that do not specify the level lose their message since the number of arguments is wrong.
- page/inspector/Console.js:
- page/inspector/Resource.js:
- 12:52 PM Changeset in webkit [35670] by
-
- 2 edits in trunk/WebCore
2008-08-11 Alp Toker <alp@nuanti.com>
Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
the opportunity to sort the sources lists.
- GNUmakefile.am:
- 11:48 AM Changeset in webkit [35669] by
-
- 2 edits in trunk/WebCore
Speed up the the JavaScript syntax highlighter by generating
the finders only once per script instead of per line.
Reviewed by Adam Roben.
- page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Removed, factored into syntaxHighlightJavascript as an inline function. (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Pulled in the _syntaxHighlightJavascriptLine so it will create a closure. Generate the finders before iterating the lines.
- 11:31 AM Changeset in webkit [35668] by
-
- 2 edits in trunk/WebCore
Windows build fix
- WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file, too.
- 11:04 AM Changeset in webkit [35667] by
-
- 7 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
Test: fast/css/counters/invalidate-cached-counter-node.html
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all RenderCounters in :before and :after content.
- rendering/RenderContainer.h:
- rendering/RenderCounter.cpp: (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this to match the RenderObject method. (WebCore::RenderCounter::invalidate): Added. Resets the cached CounterNode and invalidates the object's layout and preferred widths. (WebCore::destroyCounterNodeChildren): Added a call to invalidateCounters().
- rendering/RenderCounter.h:
- rendering/RenderObject.h: (WebCore::RenderObject::invalidateCounters):
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
- fast/css/counters/invalidate-cached-counter-node.html: Added.
- platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.checksum: Added.
- platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.png: Added.
- platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.txt: Added.
- 10:24 AM Changeset in webkit [35666] by
-
- 19 edits7 adds in trunk/WebCore
Implement CSS Animation and Transition Events
https://bugs.webkit.org/show_bug.cgi?id=20337
Implement the events defined in the CSS Animations
and Transitions specifications so code can react
to animations and transitions.
Reviewed by Tim Hatcher and Dave Hyatt.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
Build configs for new files
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSEventCustom.cpp:
- dom/Document.h:
- dom/Event.cpp:
- dom/Event.h:
- dom/EventTarget.cpp:
- dom/EventTargetNode.cpp:
- dom/EventTargetNode.h:
- html/HTMLElement.cpp:
- page/AnimationController.cpp:
do all the new event stuff
- html/HTMLAttributeNames.in:
the onwebkitanimation* and onwebkittransitionend attrs
- dom/WebKitAnimationEvent.cpp: Added.
- dom/WebKitAnimationEvent.h: Added.
- dom/WebKitAnimationEvent.idl: Added.
- dom/WebKitTransitionEvent.cpp: Added.
- dom/WebKitTransitionEvent.h: Added.
- dom/WebKitTransitionEvent.idl: Added.
New files for the events
- manual-tests/transition-events.html: Added.
New testfile
- 10:21 AM Changeset in webkit [35665] by
-
- 5 edits2 adds in trunk
Move WTF::notFound into its own header so that it can be used independently of Vector
Move WTF::notFound into its own header so that it can be used
independently of Vector
Rubberstamped by Darin Adler.
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj: Added NotFound.h to the project.
- wtf/NotFound.h: Added. Moved the notFound constant here...
- wtf/Vector.h: ...from here.
WebCore:
Add a ForwardingHeader for wtf/NotFound.h
Rubberstamped by Darin Adler.
- ForwardingHeaders/wtf/NotFound.h: Added.
- 9:53 AM Changeset in webkit [35664] by
-
- 2 edits2 adds in trunk/WebCore
Fixes a bug where error bubbles in JavaScript resources would
be clobbered by the syntax highlighter.
Reviewed by Adam Roben.
- manual-tests/inspector/resources/script-error.js: Added.
- manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
- page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._addMessageToSource): Check the nodeType and not the nodeName, this is less fragile. (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Check if the lastChild is an error bubble, if so remove it before getting the line's textContent. Add the error bubble back at the end.
- 5:01 AM Changeset in webkit [35663] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Mark Rowe.
<rdar://problem/6130393> REGRESSION: PhotoBooth hangs after launching under TOT Webkit
- API/JSContextRef.cpp: (JSGlobalContextRelease): Corrected a comment.
- kjs/collector.cpp: (KJS::Heap::~Heap): Ensure that JSGlobalData is not deleted while sweeping the heap.
Aug 10, 2008:
- 10:07 PM Changeset in webkit [35662] by
-
- 3 edits3 copies in trunk
Roll over three large ChangeLogs.
- 9:51 PM Changeset in webkit [35661] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
- fix https://bugs.webkit.org/show_bug.cgi?id=20339 REGRESSION (r35531-r35615): Acid3 crashes on Windows in CachedFont::getSVGFontById
- dom/make_names.pl: Removed "using namespace WebCore::*Names" from *ElementFactory.cpp files.
- 7:17 PM Changeset in webkit [35660] by
-
- 4 edits in trunk/WebCore
Fix crash in Acid3 in Windows and Gtk ports, introduced in r35590.
Reviewed by Cameron Zwarich.
- bindings/js/ScriptControllerGtk.cpp: Fix the logic.
- bindings/js/ScriptControllerWin.cpp: Ditto.
- bindings/js/ScriptControllerQt.cpp: Switch to isPluginView for consistency with Gtk and Windows.
- 3:36 PM Changeset in webkit [35659] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6074587> REGRESSION (34722): Unable to view AT&T wireless bill - window title contains markup, window is empty
Test: fast/tokenizer/ampersand-in-special-tag.html
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): Changed to only advance lastDecodedEntityPosition if an entity was found and decoded.
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/6074587> REGRESSION (34722): Unable to view AT&T wireless bill - window title contains markup, window is empty
- fast/tokenizer/ampersand-in-special-tag-expected.txt: Added.
- fast/tokenizer/ampersand-in-special-tag.html: Added.
- 11:21 AM Changeset in webkit [35658] by
-
- 9 edits3 deletes in trunk
2008-08-10 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed (and updated) by Alp Toker.
https://bugs.webkit.org/show_bug.cgi?id=16620
[GTK] Autotools make dist and make check support
Get make dist working.
Note that not all possible configurations have been tested yet.
- GNUmakefile.am:
2008-08-10 Alp Toker <alp@nuanti.com>
Remove leftover qmake/GTK+ build files.
- DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
- GtkLauncher/GtkLauncher.pro: Removed.
- 3:06 AM Changeset in webkit [35657] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
Added same heap debug checks to more code paths.
- kjs/JSActivation.cpp: (KJS::JSActivation::put): (KJS::JSActivation::putWithAttributes):
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::putWithAttributes):
- kjs/JSObject.h: (KJS::JSObject::putDirect):
- kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTablePut): (KJS::JSVariableObject::symbolTablePutWithAttributes):
Aug 9, 2008:
- 10:32 PM CygwinInstallerPackages created by
- A list of all the packages included in the cygwin installer for …
- 10:19 PM BuildingOnWindows edited by
- Adding a link to a new list of all packages included in the cygwin … (diff)
- 8:11 PM Changeset in webkit [35656] by
-
- 2 edits in trunk
2008-08-09 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=19045
[gtk] ./configure doesn't check for x toolkit availability
Some old versions of Xt do not provide xt.pc, in this case use
AC_CHECK_LIB to check if the library is installed and then fall back
to using just -lXt.
- configure.ac:
- 8:00 PM Changeset in webkit [35655] by
-
- 2 edits in trunk
2008-08-09 Alp Toker <alp@nuanti.com>
GTK+ build fixes.
Back out r20338 libxslt check (conditional check already exists and
this broke the build).
Make the flex version check a warning rather than fatal to fix the
build bot.
- configure.ac:
- 7:03 PM Changeset in webkit [35654] by
-
- 2 edits in trunk
2008-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=20338
[Gtk] Autotools should check for libxslt
Autotools check for libxslt
- configure.ac:
- 2:14 PM Changeset in webkit [35653] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Fix some style issues in the sampling tool.
- VM/SamplingTool.cpp: (KJS::sleepForMicroseconds): (KJS::SamplingTool::dump):
- 4:00 AM Changeset in webkit [35652] by
-
- 5 edits in trunk/JavaScriptCore
2008-08-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Revision 35651, despite being a rather trivial change, introduced a
large regression on the regexp-dna SunSpider test. This regression
stemmed from an increase in the size of CodeBlock::dump(). There is
no reason for this method (and several related methods) to be compiled
in non-debug builds with the sampling tool disabled. This patch
conditionally compiles them, reversing the regression on SunSpider.
- JavaScriptCore.exp:
- VM/CodeBlock.cpp:
- VM/CodeBlock.h:
- VM/Machine.cpp:
Aug 8, 2008:
- 8:56 PM Changeset in webkit [35651] by
-
- 4 edits3 adds in trunk
2008-08-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Bug 20330: JSCore crash loading any filehurricane media page
<https://bugs.webkit.org/show_bug.cgi?id=20330>
Fix a typo in the constant loading patch. Also, add a case for
op_unexpected_load to CodeBlock::dump().
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::addUnexpectedConstant):
LayoutTests:
- fast/js/resources/unexpected-constant-crash.js: Added.
- fast/js/unexpected-constant-crash-expected.txt: Added.
- fast/js/unexpected-constant-crash.html: Added.
- 8:37 PM Changeset in webkit [35650] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by John Sullivan.
- fix <rdar://problem/6130216> Exception "windowRegionBeingDrawn != nil" in NSView when caching image of a subframe
This change reintroduces <https://bugs.webkit.org/show_bug.cgi?id=5195> on Leopard.
- WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Removed an unsuccessful workaround for <rdar://problem/5668489>, because invoking layout may change the view hierarchy during the drawing operation, which is not supported on Leopard.
- 6:05 PM Changeset in webkit [35649] by
-
- 4 edits in trunk/WebCore
2008-08-08 Beth Dakin <Beth Dakin>
Reviewed by Darin.
This patch makes the findString and markAllMatchesForText functions
work with disconnected frames that are contained within
overflow:hidden blocks.
- editing/Editor.cpp: (WebCore::Editor::rangeVisibility): (WebCore::Editor::firstVisibleRange): (WebCore::Editor::lastVisibleRange):
- editing/Editor.h: (WebCore::Editor::):
- page/Frame.cpp: (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText):
- 5:15 PM Changeset in webkit [35648] by
-
- 15 edits2 adds in trunk
2008-08-08 Maxime Britto <britto@apple.com>
Reviewed by Adele.
Test: fast/events/scroll-to-anchor-in-overflow-hidden.html
https://bugs.webkit.org/show_bug.cgi?id=20270
Jump to an anchor wasn't working when the overflow:hidden CSS attribute was set on the page.
- WebCore.base.exp:
- dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDraggedEvent):
- page/Frame.cpp: (WebCore::Frame::revealSelection): (WebCore::Frame::revealCaret):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Takes a new parameter "scrollToAnchor" since it's a special case of scroll. It passes this new bool to canBeProgrammaticallyScrolled. (WebCore::RenderLayer::autoscroll):
- rendering/RenderLayer.h:
- rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
- rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): If the call is coming from a scrollToAnchor we don't need scrollBars to accept.
- rendering/RenderObject.h:
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):
2008-08-08 Maxime Britto <britto@apple.com>
Reviewed by Adele.
- WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]):
2008-08-08 Maxime Britto <britto@apple.com>
Reviewed by Adele.
https://bugs.webkit.org/show_bug.cgi?id=20270
This test is automatic and can also be run manually.
- fast/events/scroll-to-anchor-in-overflow-hidden-expected.txt: Added.
- fast/events/scroll-to-anchor-in-overflow-hidden.html: Added.
- 4:40 PM Changeset in webkit [35647] by
-
- 2 edits in trunk/WebCore
2008-08-08 Maxime Britto <britto@apple.com>
Reviewed by Adele.
<rdar://problem/6137022>
<https://bugs.webkit.org/show_bug.cgi?id=20331>
REGRESSION(r35177-r35203): Scrolling slowly over a scrollable field scrolls the page instead of the field (20331)
- page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): fixed the wrong cast for the wheel delta which was truncated to 0 on slow wheel scrolls.
- 1:44 PM Changeset in webkit [35646] by
-
- 7 edits3 adds in trunk/WebCore
Execute CSS Animations using new AnimationController
https://bugs.webkit.org/show_bug.cgi?id=20119
I still need to file some follow-on bugs that EricS noticed.
Reviewed by Dave Hyatt
Some new tests:
- manual-tests/animate-duration.html: Added.
- manual-tests/animate-left.html: Added.
- manual-tests/animate-none.html: Added.
- css/CSSStyleSelector.cpp:
- dom/Document.cpp:
- don't redo style when page is place into cache
- page/AnimationController.cpp:
- page/AnimationController.h:
- execute the animations
- rendering/RenderObject.cpp:
- rendering/style/RenderStyle.h:
- make border radii const (for blending)
- 1:25 PM Changeset in webkit [35645] by
-
- 5 edits in trunk/WebCore
2008-08-08 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6136326> JSProfiler: Start/stop profiling button in the
Web Inspector does not match the menu.
- page/InspectorController.cpp: (WebCore::InspectorController::toggleRecordButton): Toggle the record button in the webInspector. (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
- page/InspectorController.h:
- page/inspector/ProfilesPanel.js: Move the UI part of the record button into its funtion so that it can be called from the Inspector controller.
- page/inspector/inspector.js:
- 11:57 AM Changeset in webkit [35644] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-08 Matt Lilek <webkit@mattlilek.com>
Not reviewed, build fix.
- JavaScriptCore.exp:
- 11:48 AM Changeset in webkit [35643] by
-
- 2 edits in trunk/WebKit/mac
2008-08-08 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Fix for <rdar://problem/5865504>
This bug was actually *largely* fixed by http://trac.webkit.org/changeset/35538.
But with that same patch, it became possible for a WebResource to fail to initialize.
Therefore we were trying to add nil to an NSCFArray for certain situations, which is bad.
Lets fix that, shall we?
- WebView/WebArchive.mm: (-[WebArchive subresources]):
- 11:21 AM Changeset in webkit [35642] by
-
- 3 edits in trunk/WebCore
2008-08-08 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6131187> Profiles don't show up immediately when run
with the UI.
- page/InspectorController.cpp: (WebCore::startProfiling): Added so that the inspector's JS code could call through to the same function used by the Develop menu. This way both can call didFinishAllExecution() which puts the profile in the Web Inspector. (WebCore::stopProfiling): Ditto (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::stopUserInitiatedProfiling): Now calls didFinishAllExecution() to put the profile in the Web Inspector. This should be safe since the UIs shouldn't work if JS is still running.
- page/inspector/ProfilesPanel.js: Use the new functions.
- 10:38 AM Changeset in webkit [35641] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/5961260> GDI text: transparent fill color text does not render if it it has a stroke or shadow
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
- 5:59 AM Changeset in webkit [35640] by
-
- 11 edits7 adds in branches/XBL2
WebCore:
2008-08-08 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Tests: fast/xbl/xbl-crash-inline.xhtml
fast/xbl/xbl-document-sheets-modification.xhtml
fast/xbl/xbl-element-binding.xhtml
Bug 20212: [XBL] Add full support for element="" attachment
- Add attributeChanged method to XBLBindingElement to catch "element" changes and update the bindings.
- Translate "element" attribute to a stylesheet that is added to the bound document's sheets.
- GNUmakefile.am: Add XBLBindingElement.cpp.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Add binding sheets.
- dom/Document.cpp: (WebCore::Document::~Document): Remove binding sheet information.
(WebCore::Document::recalcStyleSelector): When
recalculating the style selector, remove all the bindings
as the removed sheets would never remove theirs.
(WebCore::Document::addBindingSheet): Update binding manager
information.
(WebCore::Document::removeBindingSheet): Ditto.
- dom/Document.h:
- xbl/XBLBindingElement.cpp: Added. (WebCore::XBLBindingElement::XBLBindingElement): (WebCore::XBLBindingElement::attributeChanged): Check for "element" changes and update the cached sheet and the bound element's bindings style sheets.
(WebCore::XBLBindingElement::generateBindingSheet): Create
the style sheet from the "element" attribute.
- xbl/XBLBindingElement.h:
- xbl/XBLBindingManager.cpp: (WebCore::XBLBindingManager::addBindingSheet): (WebCore::XBLBindingManager::removeBindingSheet): (WebCore::XBLBindingManager::clearBindingSheets): (WebCore::XBLBindingManager::getBindingSheets): All 4 previous methods are used to manage the binding sheets.
- xbl/XBLBindingManager.h:
LayoutTests:
2008-08-08 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Test case for bug 20212: [XBL] Add full support for element="" attachment
- fast/xbl/xbl-crash-inline-expected.txt: Added.
- fast/xbl/xbl-crash-inline.xhtml: Added.
- fast/xbl/xbl-document-sheets-modification-expected.txt: Added.
- fast/xbl/xbl-document-sheets-modification.xhtml: Added.
- fast/xbl/xbl-element-binding-expected.txt: Added.
- fast/xbl/xbl-element-binding.xhtml: Added.
- 2:48 AM Changeset in webkit [35639] by
-
- 5 edits in trunk/JavaScriptCore
Improve performance of arithmetic operators
Reviewed by Cameron Zwarich
Added a fast (non-virtual) mechanism to determine if a non-immediate JSValue*
is a JSNumberCell. We then use this to allow improved specialisation in many
arithmetic operators. SunSpider reports a 2.5% progression overall, with greater
than 10% progressions on a number of arithmetic heavy tests.
- 2:32 AM Changeset in webkit [35638] by
-
- 2 edits in trunk/WebCore
2008-08-08 Adam Treat <treat@kde.org>
Reviewed by Simon.
Return the canonical file path in Qt's listDirectory as WebCore::PluginDatabase
uses this method to retrieve a list of possible plugins. Many linux systems
have nested symbolic links scattered throughout the plugin directories which
resulted in the PluginDatabase loading the same plugin N times depending on
the number of symbolic links.
- 1:21 AM Changeset in webkit [35637] by
-
- 5 edits in branches/XBL2/WebCore
008-08-08 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Re-enable last bits of XBLDocument loading
legacy code.
- loader/DocLoader.cpp: (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::requestResource):
- loader/DocLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest):
- xbl/XBLDocument.h: (WebCore::XBLDocument::create): Removed adoptRef to match other Document 'create' method as it would lead to refcount churn. Also added missing 'const' in isXBLDocument.
Aug 7, 2008:
- 9:05 PM Changeset in webkit [35636] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix bug numbers.
- 9:04 PM Changeset in webkit [35635] by
-
- 1 edit in tags/Safari-6528.0.3/WebCore/DerivedSources.cpp
Build fix.
- 9:04 PM Changeset in webkit [35634] by
-
- 4 edits in tags/Safari-6528.0.3
Versioning.
- 8:56 PM Changeset in webkit [35633] by
-
- 2 edits in trunk/WebCore
Change highlight time from 300ms to 500ms and fade effect from 1s to 2s
Reviewed by Timothy Hatcher.
- page/inspector/SourceFrame.js:
- 8:55 PM Changeset in webkit [35632] by
-
- 3 edits in trunk/WebCore
The search is only performed if the field contains more than 3
letters or if Enter is pressed.
Search is now performed through a keyup event.
Added a WebInspector.lastQuery to remember the last query and not
perform it again (eg. the user hits a modifier key).
Reviewed by Timothy Hatcher.
- page/inspector/inspector.html: Removed the onsearch and incremental attributes
- page/inspector/inspector.js:
- 8:30 PM Changeset in webkit [35631] by
-
- 1 copy in tags/Safari-6528.0.3
New tag.
- 5:35 PM Changeset in webkit [35630] by
-
- 2 edits1 add in tags/Safari-6528.0.2/WebCore
Merge r35629.
- 4:38 PM Changeset in webkit [35629] by
-
- 2 edits1 add in trunk/WebCore
Compile derived sources through an all-in-one cpp file.
Fixes Windows release build on non-x64 systems by reducing the size of WebCore.lib from 1.5GB to 1GB.
Reviewed by Mark Rowe.
- DerivedSources.cpp: Added.
- WebCore.vcproj/WebCore.vcproj:
- 3:29 PM Changeset in webkit [35628] by
-
- 4 edits in trunk/WebCore
2008-08-07 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adam.
<rdar://problem/5712917> Confusing console error message clear
behavior (16791)
https://bugs.webkit.org/show_bug.cgi?id=16791
<rdar://problem/5831899> The Web Inspector does not correctly clear the
console messages
- page/InspectorController.cpp: Clear the message so they don't show up in the inspector after it has cleared them. (WebCore::clearMessages): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::windowScriptObjectAvailable):
- page/InspectorController.h:
- page/inspector/Console.js: Tell the InspectorController to clear the messages it's holding onto.
- 2:55 PM Changeset in webkit [35627] by
-
- 10 edits2 adds in trunk/WebCore
2008-08-07 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig
Rename Marquee to RenderMarquee and move to its own file.
https://bugs.webkit.org/show_bug.cgi?id=20319
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLMarqueeElement.cpp:
- rendering/RenderBlock.cpp:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
- rendering/RenderMarquee.cpp: Added. (WebCore::RenderMarquee::RenderMarquee): (WebCore::RenderMarquee::marqueeSpeed): (WebCore::RenderMarquee::direction): (WebCore::RenderMarquee::isHorizontal): (WebCore::RenderMarquee::computePosition): (WebCore::RenderMarquee::start): (WebCore::RenderMarquee::suspend): (WebCore::RenderMarquee::stop): (WebCore::RenderMarquee::updateMarqueePosition): (WebCore::RenderMarquee::updateMarqueeStyle): (WebCore::RenderMarquee::timerFired):
- rendering/RenderMarquee.h: Added. (WebCore::RenderMarquee::speed): (WebCore::RenderMarquee::reverseDirection): (WebCore::RenderMarquee::setEnd):
- 1:32 PM Changeset in webkit [35626] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- fix <rdar://problem/6118816> Initial empty page or bookmarks view window has white strip where vertical scrollbar would be (which vanishes on resize)
- page/Frame.cpp: (WebCore::Frame::setZoomFactor): If the view has never had a layout with the old zoom factor, then there is no need to explicitly call layout() here.
- 10:28 AM Changeset in webkit [35625] by
-
- 2 edits in trunk/WebCore
2008-08-07 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
<rdar://problem/6115981> Start the profiler in Heavy view
- page/inspector/ProfileView.js:
- 9:04 AM Changeset in webkit [35624] by
-
- 2 edits in trunk/WebKit/win
Delete backing stores before 5 second WM_TIMER fires if more than 2 are already queued.
WM_TIMER-based timers can be starved if enough other events are keeping
our message loop busy. This change prevents many backing store deletes from stacking
up in this case.
Reviewed by Geoff Garen.
- WebView.cpp: (WebView::deleteBackingStore): (WebView::deleteBackingStoreSoon): (WebView::cancelDeleteBackingStoreSoon):
- 5:09 AM Changeset in webkit [35623] by
-
- 2 edits in trunk/WebCore
2008-08-07 Alp Toker <alp@nuanti.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20313
Add null check in String::fromUTF8()
Make String::fromUTF8() consistent with other constructors by
returning a null String when the input is null instead of crashing.
- platform/text/String.cpp: (WebCore::String::fromUTF8):
- 5:08 AM Changeset in webkit [35622] by
-
- 3 edits in trunk
2008-08-07 Kalle Vahlman <zuh@iki.fi>
Reviewed by David Kilzer.
Check for correct flex version to avoid faulty builds
A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it
https://bugs.webkit.org/show_bug.cgi?id=20253
acinclude.m4: Import AX_COMPARE_VERSION macro
configure.ac: Check for flex version
- acinclude.m4:
- configure.ac:
- 4:31 AM Changeset in webkit [35621] by
-
- 3 edits8 adds in trunk
2008-08-07 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Lars.
Added API tests for QWebPage/QWebFrame based on QTestLib.
Aug 6, 2008:
- 8:52 PM Changeset in webkit [35620] by
-
- 4 edits2 adds in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Create a wxWebFrame API to match other ports and to prepare for frames support.
Also fixes a frame leak in wx port on trunk.
https://bugs.webkit.org/show_bug.cgi?id=19041
- 5:46 PM Changeset in webkit [35619] by
-
- 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION
Versioning.
- 4:48 PM Changeset in webkit [35618] by
-
- 2 edits in trunk/WebCore
wx build fix after Frame -> ScriptController moves. Also, remove a character which was in an unknown encoding and replace it with an ANSI representation (which the author used for their Bugzilla account too).
- 4:08 PM Changeset in webkit [35617] by
-
- 2 edits in trunk/WebCore
2008-08-06 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
- Make XHR console message clearer.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
- 4:07 PM Changeset in webkit [35616] by
-
- 4 edits in trunk/WebCore
2008-08-06 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
- Created a new function to create DOM links from text without converting back and forth from HTML and messing with escaping special characters.
- page/inspector/Console.js:
- page/inspector/inspector.js:
- page/inspector/utilities.js:
- 3:39 PM Changeset in webkit [35615] by
-
- 3 edits in trunk/WebCore
Reviewed by hyatt.
Fix a large animation leak found on the buildbot
(m_animations and m_transitions were never deleted)
Drag RenderStyle (kicking and screaming) into the 21st century
of memory management with a little application of OwnPtr.
- rendering/style/RenderStyle.cpp: (WebCore::FillLayer::cullEmptyLayers): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::contentDataEquivalent): (WebCore::RenderStyle::setContent): (WebCore::BindingURI::BindingURI): (WebCore::RenderStyle::setBoxShadow): (WebCore::ShadowData::ShadowData): (WebCore::RenderStyle::counterDirectives): (WebCore::RenderStyle::accessCounterDirectives): (WebCore::RenderStyle::adjustAnimations): (WebCore::RenderStyle::adjustTransitions): (WebCore::RenderStyle::accessAnimations): (WebCore::RenderStyle::accessTransitions):
- rendering/style/RenderStyle.h: (WebCore::RenderStyle::clearAnimations): (WebCore::RenderStyle::clearTransitions):
- 3:17 PM Changeset in webkit [35614] by
-
- 4 edits in trunk/WebCore
2008-08-06 Brady Eidson <beidson@apple.com>
Reviewed by MitzPettel
<rdar://problem/6078543> - Many LocalStorageThreads may be started
The original decision to key LocalStorage sets to PageGroups was a poor one.
It seems a much better solution is to key them to the actual path of on-disk storage,
which also solves all of the avenues that could lead to a boundless number of threads.
In this patch, I am not attempting to completely sever the attachment of LocalStorage
to PageGroups as that would require a more substantial re-working of the lifetime
between pages, groups, and local storage threads.
- page/PageGroup.cpp: (WebCore::PageGroup::addPage):
- storage/LocalStorage.cpp: (WebCore::localStorageMap): Map paths to LocalStorage objects here. (WebCore::LocalStorage::localStorage): Return the shared LocalStorage object for this path, or create a new one if it doesn't yet exist. (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::~LocalStorage): Add to remove the path->LocalStorage mapping
- storage/LocalStorage.h:
- 3:12 PM Changeset in webkit [35613] by
-
- 2 edits in trunk/WebCore
2008-08-06 Beth Dakin <Beth Dakin>
Reviewed by Adele.
Fix for <rdar://problem/6130724>
Disconnected frames should not be allowed to resize the window.
- page/DOMWindow.cpp: (WebCore::DOMWindow::resizeBy): (WebCore::DOMWindow::resizeTo):
- 2:27 PM Changeset in webkit [35612] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Added bug URLs
- 2:15 PM Changeset in webkit [35611] by
-
- 5 edits2 adds in trunk
WebCore:
Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com
<https://bugs.webkit.org/show_bug.cgi?id=20038>
<rdar://problem/6092270>
Reviewed by Eric Seidel.
Test: fast/forms/submit-to-url-fragment.html
The problem was that isFormSubmission was not being set to true in
FrameLoader::loadWithDocumentLoader() when we were actually
submitting a form, causing the page to scroll instead of the form to
be submitted.
The isFormSubmission variable wasn't set to true because a FormState
object was not being created in
FrameLoader::loadFrameRequestWithFormAndValues().
The FormState object was not being created because
HTMLFormElement::submit(Event*, bool activateSubmitButton) would
only set FrameLoader::m_formAboutToBeSubmitted to the current form
if there was a "text field" element in the form (type = text,
password, search or isindex).
Thus when FrameLoader::submitForm(const FrameLoadRequest&, Event*)
called FrameLoader::loadFrameRequestWithFormAndValues(), a null
HTMLFormElement pointer would be sent and cause the above failures.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Call new FrameLoader::setFormAboutToBeSubmitted() method outside the for loop so we always set FrameLoader::m_formAboutToBeSubmitted exactly once for any form submission. The FrameLoader::recordFormValue() method is only called with the name/value pair of each text field.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::setFormAboutToBeSubmitted): Added method that only sets m_formAboutToBeSubmitted. (WebCore::FrameLoader::recordFormValue): Removed PassRefPtr<HTMLFormElement> argument since this method only sets name/value pairs on m_formValuesAboutToBeSubmitted now. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Create a FormState object as long as submitForm is not null so that other FrameLoader methods know when a form is being submitted.
- loader/FrameLoader.h:
LayoutTests:
Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com
<https://bugs.webkit.org/show_bug.cgi?id=20038>
<rdar://problem/6092270>
Reviewed by Eric Seidel.
- fast/forms/submit-to-url-fragment-expected.txt: Added.
- fast/forms/submit-to-url-fragment.html: Added.
- 1:26 PM Changeset in webkit [35610] by
-
- 4 edits in trunk/WebCore
BUILD FIX: Add HTMLPlugInImageElement.cpp to all other build systems
- GNUmakefile.am:
- WebCore.pro:
- WebCoreSources.bkl:
- 1:22 PM Changeset in webkit [35609] by
-
- 2 edits in trunk/WebCore
- Windows build fix
- WebCore.vcproj/WebCore.vcproj: Added PlugInImageElement.*
- 1:01 PM Changeset in webkit [35608] by
-
- 6 edits in trunk/WebKitTools
Reviewed by darin.
Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.
I've made AccessibilityUIElement a stack object for now. It could be
made RefCounted, but I figured that might be overkill for the moment.
Essentially it's just a RefPtr itself. :)
I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
which was causing additional leaks. :)
I added toAXElement to remove a bunch of copy/paste code.
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/AccessibilityUIElement.cpp: (toAXElement): (allAttributesCallback): (attributesOfLinkedUIElementsCallback): (attributesOfChildrenCallback): (lineForIndexCallback): (boundsForRangeCallback): (childAtIndexCallback): (getRoleCallback): (getTitleCallback): (getDescriptionCallback): (getWidthCallback): (getHeightCallback): (getIntValueCallback): (getMinValueCallback): (getMaxValueCallback): (getInsertionPointLineNumberCallback): (finalize):
- DumpRenderTree/AccessibilityUIElement.h: (AccessibilityUIElement::platformUIElement):
- DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::focusedElement):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfChildren):
- 11:47 AM Changeset in webkit [35607] by
-
- 4 edits in trunk/WebCore
2008-08-06 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim and Darin.
<rdar://problem/6126160> URLs in the console should be clickable.
- Implemented and now use linkifyString() to parse console messages for URLs.
- page/inspector/Console.js:
- page/inspector/inspector.js:
- page/inspector/utilities.js:
- 10:23 AM Changeset in webkit [35606] by
-
- 8 edits10 adds in trunk
WebCore:
Images using QT plugin do not display correctly
<https://bugs.webkit.org/show_bug.cgi?id=9214>
<rdar://problem/5683413>
Reviewed by Darin.
Tests: fast/images/embed-image.html
fast/images/object-image.html
Use RenderImage instead of RenderPartObject for a renderer when
the <embed> tag references an image. Extract common code from
HTMLEmbedElement and HTMLObjectElement into HTMLPlugInImageElement.
- WebCore.xcodeproj/project.pbxproj: Added new source files.
- html/HTMLEmbedElement.cpp: Cleaned up #include statements. (WebCore::HTMLEmbedElement::HTMLEmbedElement): Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLEmbedElement::parseMappedAttribute): Split codeAttr and srcAttr cases. Create or clear HTMLImageLoader as needed for srcAttr. (WebCore::HTMLEmbedElement::rendererIsNeeded): Use HTMLPlugInElement::rendererIsNeeded() for images. (WebCore::HTMLEmbedElement::createRenderer): Create a RenderImage instead of a RenderPartObject for images. (WebCore::HTMLEmbedElement::attach): Create HTMLImageLoader, load image and populate RenderImage for images. (WebCore::HTMLEmbedElement::updateWidget): Don't call RenderPartObject::updateWidget() for images. (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added.
- html/HTMLEmbedElement.h: Removed unneeded namespace and class declarations. Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added. (WebCore::HTMLEmbedElement::serviceType): Moved to HTMLPlugInImageElement. (WebCore::HTMLEmbedElement::url): Ditto.
- html/HTMLObjectElement.cpp: Cleaned up #include statements. (WebCore::HTMLObjectElement::attach): Removed local variable. (WebCore::HTMLObjectElement::isImageType): Moved to HTMLPlugInImageElement.
- html/HTMLObjectElement.h: Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLObjectElement::isImageType): Moved to HTMLPlugInImageElement. (WebCore::HTMLObjectElement::serviceType): Ditto. (WebCore::HTMLObjectElement::url): Ditto.
- html/HTMLPlugInImageElement.cpp: Added. (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Added. (WebCore::HTMLPlugInImageElement::~HTMLPlugInImageElement): Added. (WebCore::HTMLPlugInImageElement::isImageType): Moved from HTMLObjectElement.
- html/HTMLPlugInImageElement.h: Added. (WebCore::HTMLPlugInImageElement::isImageType): Added from HTMLObjectElement. (WebCore::HTMLPlugInImageElement::serviceType): Ditto. (WebCore::HTMLPlugInImageElement::url): Ditto.
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): Return urlString for embed elements with images.
LayoutTests:
Images using QT plugin do not display correctly
<https://bugs.webkit.org/show_bug.cgi?id=9214>
<rdar://problem/5683413>
Reviewed by Darin.
Test images rendered by both embed and object elements.
- fast/images/embed-image.html: Added.
- fast/images/object-image.html: Added.
- platform/mac/fast/images/embed-image-expected.checksum: Added.
- platform/mac/fast/images/embed-image-expected.png: Added.
- platform/mac/fast/images/embed-image-expected.txt: Added.
- platform/mac/fast/images/object-image-expected.checksum: Added.
- platform/mac/fast/images/object-image-expected.png: Added.
- platform/mac/fast/images/object-image-expected.txt: Added.
- 9:33 AM Changeset in webkit [35605] by
-
- 4 edits in trunk
Fix an accessibility layout test that was failing on different platforms
- 7:50 AM Changeset in webkit [35604] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix the Windows build bots
- API/JSBase.cpp: Touch this to force JSC to rebuild and re-copy the WTF headers.
- 6:30 AM Changeset in webkit [35603] by
-
- 2 edits in trunk/WebKit/qt
2008-08-06 Benjamin C Meyer <ben@meyerhome.net>
Reviewed by Simon.
During the drag operation only accept the event if the action is not ignore action.
- 6:02 AM Changeset in webkit [35602] by
-
- 2 edits in trunk/JavaScriptCore
Revert change 35595.
- 5:46 AM Changeset in webkit [35601] by
-
- 2 edits in trunk/WebCore
2008-08-06 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=20295
RegularExpression::match should not crash when a null string is passed
RegularExpression::match used to pass null subject strings to
jsRegExpExecute causing an ASSERT failure and then a crash.
There is no need to fix also RegularExpression:search and
RegularExpression::searchRev as they just call
RegularExpression::match.
- platform/text/RegularExpression.cpp: (WebCore::RegularExpression::match): Return -1 if the string is null.
- 5:40 AM Changeset in webkit [35600] by
-
- 2 edits in trunk
2008-08-06 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=20276
[GTK] Makefile rules for the enum GTypes files depend on Makefile
instead of GNUmakefile
The patch committed in revision 34649 added the code needed to
generate GTypes for enums but the makefile rules for
stamp-webkitenumtypes.h and webkitenumtypes.cpp were depending on
Makefile (used by other ports) instead of GNUmakefile.
- GNUmakefile.am: Depend on GNUmakefile instead of Makefile.
- 5:35 AM Changeset in webkit [35599] by
-
- 3 edits in trunk/WebCore
2008-08-06 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix only
- bindings/js/ScriptControllerGtk.cpp:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::~PluginView):
- 5:11 AM Changeset in webkit [35598] by
-
- 11 edits in trunk
Reviewed by Cameron Zwarich.
Fix warnings and errors seen on Qt bot.
Including one correctness fix for ThreadingQt.
According to the Qt 4.4 docs, we were always passing
seconds to "wait()" when we should have been passing
milliseconds.
Lots of float <-> int conversion warnings.
- css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
- dom/Element.cpp: (WebCore::adjustForLocalZoom): (WebCore::adjustForAbsoluteZoom): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop):
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
- loader/CachedImage.cpp: (WebCore::CachedImage::imageRect):
- page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::scrollTo):
- page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent):
- plugins/npapi.cpp:
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::~PluginView):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::intrinsicSizeChanged):
- 4:46 AM Changeset in webkit [35597] by
-
- 4 edits in trunk
2008-08-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
Fix the Qt build due to recent ScriptController refactoring.
- 4:46 AM Changeset in webkit [35596] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fix non-Mac build.
- 4:17 AM Changeset in webkit [35595] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
Fix non-Mac build.
- 3:50 AM Changeset in webkit [35594] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-06 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Darin. Landed by Cameron.
Bug 20272: typo in JavaScriptCore
<https://bugs.webkit.org/show_bug.cgi?id=20272>
Correct the documentation for op_not. (typo)
Fix #undef. (typo)
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- 3:37 AM Changeset in webkit [35593] by
-
- 18 edits3 adds in trunk
2008-08-06 Cameron Zwarich <cwzwarich@webkit.org>
Reviewed by Maciej.
Bug 20286: Load constants all at once instead of using op_load
<https://bugs.webkit.org/show_bug.cgi?id=20286>
Load constants all at once into temporary registers instead of using
individual instances of op_load.
This is a 2.6% speedup on SunSpider.
- JavaScriptCore.exp:
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump): (KJS::CodeBlock::mark):
- VM/CodeBlock.h:
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): (KJS::CodeGenerator::newTemporary): (KJS::CodeGenerator::addConstant): (KJS::CodeGenerator::addUnexpectedConstant): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitUnexpectedLoad): (KJS::CodeGenerator::emitNewError):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::slideRegisterWindowForCall): (KJS::Machine::unwindCallFrame): (KJS::Machine::throwException): (KJS::Machine::execute): (KJS::Machine::privateExecute):
- VM/Machine.h:
- VM/Opcode.h:
- VM/RegisterID.h: (KJS::RegisterID::RegisterID): (KJS::RegisterID::makeConstant): (KJS::RegisterID::isTemporary):
- kjs/NodeInfo.h:
- kjs/Parser.cpp: (KJS::Parser::didFinishParsing):
- kjs/Parser.h: (KJS::Parser::parse):
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::NullNode::emitCode): (KJS::BooleanNode::emitCode): (KJS::NumberNode::emitCode): (KJS::StringNode::emitCode): (KJS::ArrayNode::emitCode): (KJS::DeleteResolveNode::emitCode): (KJS::DeleteValueNode::emitCode): (KJS::VoidNode::emitCode): (KJS::ConstDeclNode::emitCodeSingle): (KJS::ReturnNode::emitCode): (KJS::ScopeNode::ScopeNode): (KJS::ProgramNode::ProgramNode): (KJS::ProgramNode::create): (KJS::EvalNode::EvalNode): (KJS::EvalNode::create): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::FunctionBodyNode::create): (KJS::FunctionBodyNode::emitCode):
- kjs/nodes.h: (KJS::ScopeNode::neededConstants):
LayoutTests:
- fast/js/constant-count-expected.txt: Added.
- fast/js/constant-count.html: Added.
- fast/js/deep-recursion-test.html:
- fast/js/resources/constant-count.js: Added.
- 3:34 AM Changeset in webkit [35592] by
-
- 6 edits in trunk/WebCore
Build fix only, no review.
Attempt to fix the Windows and Qt builds.
- bindings/js/ScriptControllerWin.cpp: add runtime.h include
- bindings/js/ScriptControllerQt.cpp: add QWidget include
- page/win/FrameWin.cpp: remove bogus using namespace
- plugins/PluginView.cpp: (WebCore::PluginView::bindingInstance): use script()
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::getValue): use script() (WebCore::PluginView::~PluginView): use script()
- 3:17 AM Changeset in webkit [35591] by
-
- 3 edits in trunk/WebCore
Build fix only, no review.
Attempt to fix the Linux and --no-svg builds.
- bindings/js/ScriptController.h: wrap RetainPtr include in PLATFORM(MAC)
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): add missing CSSProperties to switch
- 3:01 AM Changeset in webkit [35590] by
-
- 35 edits3 copies1 add in trunk
Reviewed by Cameron Zwarich.
Move more methods from Frame into ScriptController
https://bugs.webkit.org/show_bug.cgi?id=20294
Finally finish more of the work which Darin started long ago
Move a few more Frame methods into ScriptController.
I also took this opportunity to clean up some of the plugin
code as well, and moved some of that into ScriptController.
I removed Frame::clearScriptController() and ScriptController::clear() is now clearWindowShell()
No functional changes, thus no test cases.
- GNUmakefile.am:
- WebCore.NPAPI.exp:
- WebCore.base.exp:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::bindingRootObject): (WebCore::ScriptController::createRootObject): (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::createScriptObjectForPluginElement): New method. (WebCore::ScriptController::clearPlatformScriptObjects): (WebCore::ScriptController::disconnectPlatformScriptObjects): (WebCore::ScriptController::cleanupScriptObjectsForPlugin): (WebCore::ScriptController::clearScriptObjects):
- bindings/js/ScriptController.h: (WebCore::ScriptController::sourceURL): (WebCore::ScriptController::clearFormerWindow):
- bindings/js/ScriptControllerGtk.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp. (WebCore::Frame::createScriptInstanceForWidget):
- bindings/js/ScriptControllerMac.mm: Added. (WebCore::ScriptController::createScriptInstanceForWidget): (WebCore::ScriptController::windowScriptObject): (WebCore::ScriptController::clearPlatformScriptObjects): (WebCore::ScriptController::disconnectPlatformScriptObjects): (WebCore::updateRenderingForBindings): (WebCore::ScriptController::initJavaJSBindings):
- bindings/js/ScriptControllerQt.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp. (WebCore::ScriptController::createScriptInstanceForWidget):
- bindings/js/ScriptControllerWin.cpp: Copied from WebCore/svg/graphics/cg/SVGResourceMaskerCg.cpp. (WebCore::ScriptController::createScriptInstanceForWidget):
- bindings/objc/DOM.mm: (-[DOMNode KJS::Bindings::]):
- bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
- bridge/jni/jni_jsobject.mm: (createRootObject):
- html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
- html/HTMLAppletElement.h:
- html/HTMLEmbedElement.cpp: (WebCore::findWidgetRenderer): (WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
- html/HTMLEmbedElement.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::renderWidgetForJSBindings): (WebCore::HTMLObjectElement::detach):
- html/HTMLObjectElement.h:
- html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::~HTMLPlugInElement): (WebCore::HTMLPlugInElement::detach): (WebCore::HTMLPlugInElement::getInstance): (WebCore::HTMLPlugInElement::parseMappedAttribute): (WebCore::HTMLPlugInElement::getNPObject):
- html/HTMLPlugInElement.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):
- page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): (WebCore::FramePrivate::FramePrivate):
- page/Frame.h:
- page/FramePrivate.h:
- page/gtk/FrameGtk.cpp:
- page/mac/FrameMac.mm:
- page/qt/FrameQt.cpp:
- page/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
- 2:06 AM Changeset in webkit [35589] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Cameron Zwarich.
Speculative fix for an error I keep seeing in my Cygwin build
- Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
- 12:09 AM Changeset in webkit [35588] by
-
- 4 edits in trunk/WebKit/mac
Reviewed by Mark Rowe.
- fix an assertion failure in Cache::setCapacities()
- Misc/WebKitSystemBits.h: Changed the return type of WebMemorySize() to uint64_t.
- Misc/WebKitSystemBits.m: (WebMemorySize):
- WebView/WebView.mm: (+[WebView _setCacheModel:]):
Aug 5, 2008:
- 9:33 PM Changeset in webkit [35587] by
-
- 2 edits in trunk/WebCore
2008-08-05 Steve Falkenburg <sfalken@apple.com>
Fix last timer fix.
Add null check, clear timer using InterlockedExchange.
Reviewed by Alice Liu.
- platform/win/SharedTimerWin.cpp: (WebCore::clearTimer): (WebCore::queueTimerProc): (WebCore::stopSharedTimer):
- 9:29 PM Changeset in webkit [35586] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron.
- add fast path for immediates to % operator, as we have for many other math ops
This fixes handling for a 0 divisor relative to the last patch. Only an 0.2% speedup on SunSpider but
still a 1.4x win on Oliver's prime test.
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- 5:57 PM Changeset in webkit [35585] by
-
- 2 edits in trunk/WebCore
2008-08-05 Steve Falkenburg <sfalken@apple.com>
Fix timer leak, flag.
Timers need to be deleted explicitly, even if they fire.
Also added WT_EXECUTEONLYONCE flag, since this is not a repeating timer.
Reviewed by Ada Chan.
- platform/win/SharedTimerWin.cpp: (WebCore::queueTimerProc):
- 5:39 PM Changeset in webkit [35584] by
-
- 5 edits in trunk
2008-08-05 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin.
Bug 20293: Crash in JavaScript codegen for eval("const a;")
<https://bugs.webkit.org/show_bug.cgi?id=20293>
Correctly handle constant declarations in eval code with no initializer.
- kjs/nodes.cpp: (KJS::ConstDeclNode::emitCodeSingle):
LayoutTests:
- fast/js/const-expected.txt:
- fast/js/resources/const.js:
- 5:36 PM Changeset in webkit [35583] by
-
- 2 edits in trunk/WebKit/mac
2008-08-05 Anders Carlsson <andersca@apple.com>
Pass in the correct class here.
- WebView/WebResource.mm: (-[WebResourcePrivate dealloc]):
- 5:19 PM Changeset in webkit [35582] by
-
- 15 edits in trunk
WebCore:
2008-08-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
<rdar://problem/6037398>
ER: Deallocate WebKit objects on the main thread, even if released on secondary thread
Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.
- bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]):
- bindings/objc/WebScriptObject.mm: (-[WebScriptObject dealloc]):
- platform/mac/SharedBufferMac.mm: (-[WebCoreSharedBufferData dealloc]):
WebKit/mac:
2008-08-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
<rdar://problem/6037398>
ER: Deallocate WebKit objects on the main thread, even if released on secondary thread
Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.
- Carbon/CarbonWindowAdapter.m: (-[CarbonWindowAdapter dealloc]):
- History/WebBackForwardList.mm: (-[WebBackForwardList dealloc]):
- History/WebHistoryItem.mm: (-[WebHistoryItem dealloc]):
- Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]): (-[WebElementDictionary dealloc]):
- WebCoreSupport/WebEditorClient.mm: (-[WebEditCommand dealloc]):
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebArchive.mm: (-[WebArchivePrivate dealloc]):
- WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]):
- WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView dealloc]):
- WebView/WebResource.mm: (-[WebResourcePrivate dealloc]):
- 4:43 PM Changeset in webkit [35581] by
-
- 9 edits2 deletes in trunk
../../../../../../WebCore:
2008-08-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
Move the main thread deallocator here from WebKit.
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/WebCoreObjCExtras.c: (method_getImplementation): (deallocCallback): (WebCoreObjCScheduleDeallocateOnMainThread):
- platform/mac/WebCoreObjCExtras.h:
../../../../../../WebKit:
2008-08-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
Remove MainThreadObjectDeallocator.{h|mm}.
- WebKit.xcodeproj/project.pbxproj:
../../../../../../WebKit/mac:
2008-08-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
Remove MainThreadObjectDeallocator.{h|mm}.
- WebView/MainThreadObjectDeallocator.h: Removed.
- WebView/MainThreadObjectDeallocator.mm: Removed.
- WebView/WebView.mm: (-[WebView dealloc]): Call WebCoreObjCScheduleDeallocateOnMainThread instead.
- 4:01 PM Changeset in webkit [35580] by
-
- 16 edits4 adds in trunk/WebCore
Parse CSS Animations, including the new
-webkit-animation properties and the @-webkit-keyframes rule.
Adds some new interfaces for the style rules.
https://bugs.webkit.org/show_bug.cgi?id=20088
Reviewed by David Hyatt.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
build config for new files
- css/tokenizer.flex:
- css/CSSGrammar.y:
- css/CSSParser.cpp:
- css/CSSParser.h:
new @-webkit-keyframes parsing
- css/CSSPropertyNames.in:
-webkit-animation properties
- css/CSSRule.h:
- css/CSSStyleSelector.cpp:
- css/CSSStyleSelector.h:
- css/CSSValueKeywords.in:
- css/StyleBase.h:
- css/WebKitCSSKeyframeRule.cpp: Added.
- css/WebKitCSSKeyframeRule.h: Added.
- css/WebKitCSSKeyframesRule.cpp: Added.
- css/WebKitCSSKeyframesRule.h: Added.
- 3:57 PM Changeset in webkit [35579] by
-
- 4 edits in trunk/WebKit/mac
2008-08-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
Make the main thread object deallocator work with subclasses.
- WebView/MainThreadObjectDeallocator.h:
- WebView/MainThreadObjectDeallocator.mm: (deallocCallback): Call the correct dealloc method.
(scheduleDeallocateOnMainThread):
Store both the class and the instance, so we know which dealloc method to call.
- WebView/WebView.mm: (-[WebViewPrivate dealloc]): Schedule deallocation on the main thread.
- 3:50 PM Changeset in webkit [35578] by
-
- 4 edits in trunk/WebKit/win
Add a getter for CFURLRequestRef in WebMutableURLRequest.
Reviewed by Anders Carlsson.
- Interfaces/IWebMutableURLRequestPrivate.idl:
- WebMutableURLRequest.cpp: (WebMutableURLRequest::cfRequest):
- WebMutableURLRequest.h:
- 3:35 PM Changeset in webkit [35577] by
-
- 2 edits in trunk/WebCore
2008-08-05 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
- LayoutTests fix. Log only to the Inspector because other listeners may not want XHR notifications, including DRT and the numerous tests that don't expect them.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
- 3:34 PM Changeset in webkit [35576] by
-
- 5 edits in trunk/WebCore
Makes DOM attribute editing start on double-click to match the styles
pane. Links in attributes are now triggered with a single click again.
Reviewed by Adam Roben.
- English.lproj/localizedStrings.js: Removed some strings.
- page/inspector/ElementsPanel.js: (WebInspector.DOMNodeTreeElement.prototype.onattach): Call _preventFollowingLinksOnDoubleClick. (WebInspector.DOMNodeTreeElement.prototype._preventFollowingLinksOnDoubleClick): Renamed from _makeURLsActivateOnModifiedClick. Simply sets the preventFollowOnDoubleClick property on all links. (WebInspector.DOMNodeTreeElement.prototype.onselect): Removed _selectedByCurrentMouseDown. (WebInspector.DOMNodeTreeElement.prototype.onmousedown): Moved editing code to ondblclick. (WebInspector.DOMNodeTreeElement.prototype.ondblclick): Calls _startEditing. Removed URL check. (WebInspector.DOMNodeTreeElement.prototype._updateTitle): Calls _preventFollowingLinksOnDoubleClick.
- page/inspector/inspector.css: (.editing): Removed the text-decoration property. (.editing, .editing *): Added the text-decoration property here so it removes underlines on child elements.
- page/inspector/inspector.js: (WebInspector.documentClick): Removed the followOnAltClick code. Added support for preventFollowOnDoubleClick, which sets a timeout on the first click where future clicks will cancel it (double click). If the timeout isn't canceled, the link is followed.
- 3:10 PM Changeset in webkit [35575] by
-
- 3 edits in trunk/WebCore
2008-08-05 Antti Koivisto <Antti Koivisto>
Reviewed by Sam Weinig.
<rdar://problem/6112219> Video in standalone media document flashes when navigating away
When navigating out from a page, MediaPlayer was set invisible and then immediately
made visible again causing flicker in some cases.
The document is not yet marked being in page cache when willSaveToCache() is called.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache):
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer):
- 3:06 PM Changeset in webkit [35574] by
-
- 2 edits in trunk/WebCore
- fix typo
- page/mac/FrameMac.mm:
- 3:04 PM Changeset in webkit [35573] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Mark Rowe and Anders Carlsson.
- fix WebMemorySize() reporting a value capped at 2GB
- misc/WebKitSystemBits.m: (WebMemorySize): Changed to return the max_mem field, which, unlike memory_size, is not capped at 2GB.
- WebView/WebView.mm: (+[WebView _setCacheModel:]): Made the cache sizes for over 2GB RAM the same as for 2GB, so that behavior on machines that have more than 2GB RAM is not affected by the fix to WebMemorySize().
- 3:03 PM Changeset in webkit [35572] by
-
- 2 edits in trunk/WebCore
- try to fix the 64-bit build
- page/mac/FrameMac.mm:
- 2:41 PM Changeset in webkit [35571] by
-
- 2 edits in trunk/WebCore
2008-08-05 Alp Toker <alp@nuanti.com>
Remove leftover mark pragma from r35568 to fix compiler warning spew.
- rendering/style/RenderStyle.h:
- 2:33 PM Changeset in webkit [35570] by
-
- 3 edits in trunk
2008-08-05 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=19045
[gtk] ./configure doesn't check for x toolkit availability
Check for the .pc file for Xt instead of hard coding -lXt in the
GNUmakefile.am.
Thanks to Dominik Röttsches for the initial patch.
- GNUmakefile.am:
- configure.ac:
- 12:15 PM Changeset in webkit [35569] by
-
- 1 edit1 add in trunk/WebCore
2008-08-05 Kevin McCullough <kmccullough@apple.com>
- Added a test that checks for several edge cases (see description in test.
- manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Added.
- 12:08 PM Changeset in webkit [35568] by
-
- 6 edits in trunk/WebCore
Reviewed by Dave Hyatt
Add support for CSS Animation properties to RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=20068
(also fix some minor whitespace issues and remove debugging code)
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSStyleSelector.cpp:
- page/AnimationController.cpp:
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- 12:07 PM Changeset in webkit [35567] by
-
- 2 edits in trunk/WebCore
2008-08-05 Kevin McCullough <kmccullough@apple.com>
- Updated a manual test to be an accurate description of what it is actually testing.
- manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html:
- 12:06 PM Changeset in webkit [35566] by
-
- 2 edits in trunk/WebKit/win
2008-08-05 Steve Falkenburg <sfalken@apple.com>
Don't invalidate a WebView in the process of being closed when prefs change.
Reviewed by Ada Chan.
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 11:00 AM Changeset in webkit [35565] by
-
- 2 edits in trunk/WebCore
2008-08-05 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/5732836> XMLHttpRequest: Inspector should show network
activity/XHR in Console (17233)
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
- 10:48 AM Changeset in webkit [35564] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix the ChangeLog that was corrupted by r34545.
- 9:47 AM Changeset in webkit [35563] by
-
- 2 edits in trunk/WebCore
Makes the selection surround just the name or value that was
double clicked when editing CSS properties. This regressed when
the Inspector started using focus/blur events, since a focus on
a content editable region changes the selection.
Reviewed by Adam Roben.
- page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.startEditing): Change the selection after calling WebInspector.startEditing, since WebInspector.startEditing will set an initial selection due to a focus event.
- 9:47 AM Changeset in webkit [35562] by
-
- 2 edits in trunk/WebCore
Changes the editing behavior in the Inspector to commit changes
when focus is lost, instead of reverting the changes.
Reviewed by Adam Roben.
- page/inspector/inspector.js: (WebInspector.startEditing): Call editingCommitted in blurEventListener instead of editingCancelled.
- 9:47 AM Changeset in webkit [35561] by
-
- 4 edits in trunk/WebCore
Adds the ability to increment/decrement numbers in editable style
properties with the arrow and page keys.
Reviewed by Adam Roben.
- page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateAll): Updates all properties in the current section, or all sections depending in the argument passed. (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Call updateAll instead of having duplicate code. (WebInspector.StylePropertyTreeElement.prototype.startEditing): Assign the list element's handleKeyEvent to editingKeyDown. (WebInspector.StylePropertyTreeElement.prototype.editingKeyDown): Handles the Up and Down arrows keys. Finds the word based on the selection and extracts the number, prefix and suffix. Increments or decrements the number based on the key and modifiers. Replaces the original word with the new value and selects it. Also applies the style so the page reflects the changes live. (WebInspector.StylePropertyTreeElement.prototype.editingEnded): Delete the handleKeyEvent and originalCSSText properties. (WebInspector.StylePropertyTreeElement.prototype.editingCancelled): If originalCSSText exists, set the cssText to that value and call updateAll. Otherwise just call updateTitle like before. (WebInspector.StylePropertyTreeElement.prototype.editingCommitted): Factored out the style applying code to applyStyleText. (WebInspector.StylePropertyTreeElement.prototype.applyStyleText): Factored out from editingCommitted. Takes an argument that specifies if the interface should be updated when the style is applied.
- page/inspector/inspector.js: (WebInspector.startEditing): Call the original key handler, if one existed before interrupting key events.
- page/inspector/utilities.js: (getStyleTextWithShorthands): Helper to return CSS text that preserves shorthand values, since the cssText property only outputs longhands.
- 9:46 AM Changeset in webkit [35560] by
-
- 4 edits in trunk/WebCore
Factors out the TextPrompt.scanBackwards function into a generic
helper function on the Node prototype, named rangeOfWord.
Reviewed by Adam Roben.
- page/inspector/Console.js: (WebInspector.Console.prototype.completions): Use rangeOfWord.
- page/inspector/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): Ditto. (WebInspector.TextPrompt.prototype.scanBackwards): Removed.
- page/inspector/utilities.js: (Node.prototype.rangeOfWord): Added. Copied from TextPrompt.scanBackwards, and added a direction argument allowing scanning forward, backward or both directions from the offset.
- 9:46 AM Changeset in webkit [35559] by
-
- 2 edits in trunk/WebCore
Fixes a bug where the property toggle button would not be hidden
during editing.
Reviewed by Adam Roben.
- page/inspector/inspector.css: (li.editing .swatch, li.editing .enabled-button): Make the display !important, since a more specific rule for .enabledbutton overrides display.
- 6:40 AM Changeset in webkit [35558] by
-
- 4 edits in trunk/WebKit/qt
2008-08-05 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Move event handling of the return-key from EditorClientQt to QWebPage.
This is a first step in refactoring the big switch block
in EditorClientQt::handleKeyboardEvent to using WebActions
instead.
The new logic uses two new StandardKeys from QKeySequence:
- InsertParagraphSeparator
- InsertLineSeparator
Which translate to the commands InsertNewline and InsertLineBreak
respectivly. On Windows/X11 pressing the shift modifier will invoke
the latter action. For Mac this is triggered by pressing the meta
modifier (Ctrl).
Initial patch by: Erik Bunce
- 5:51 AM S60CheckoutAndBuild edited by
- (diff)
- 4:00 AM Changeset in webkit [35557] by
-
- 3 edits3 adds in trunk
2008-08-05 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Roll out r35555 because of correctness issues.
- VM/Machine.cpp: (KJS::Machine::privateExecute):
LayoutTests:
- fast/js/mod-crash-expected.txt: Added.
- fast/js/mod-crash.html: Added.
- fast/js/resources/mod-crash.js: Added.
- 12:40 AM Changeset in webkit [35556] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoffrey Garen.
- remove redundant #imports from FrameMac.mm
- page/mac/FrameMac.mm:
- 12:15 AM Changeset in webkit [35555] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff.
- add fast path for immediates to % operator, as we have for many other math ops
0.6% speedup on SunSpider. 1.4x speedup on a prime testing torture test that Oliver whipped up.
- VM/Machine.cpp: (KJS::Machine::privateExecute):
Aug 4, 2008:
- 11:03 PM Changeset in webkit [35554] by
-
- 4 edits in tags/Safari-6528.0.2
Versioning.
- 11:03 PM Changeset in webkit [35553] by
-
- 7 edits1 add in tags/Safari-6528.0.2/WebKit
- 10:13 PM Changeset in webkit [35552] by
-
- 2 edits in trunk/WebKit/win
2008-08-04 Alice Liu <alice.liu@apple.com>
Reviewed by Steve Falkenburg.
Fix CFDictionary leak
- CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::Write): m_dictionary is a RetainPtr and should adopt the CF type created
- 9:09 PM Changeset in webkit [35551] by
-
- 5 edits in trunk
WebCore:
2008-08-04 Bernhard Kruepl <kruepl@dbai.tuwien.ac.at>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
Corrected offsetTop for table cells by subtracting borderTopExtra
- rendering/RenderObject.cpp: (WebCore::RenderObject::offsetTop):
LayoutTests:
2008-08-04 Bernhard Kruepl <kruepl@dbai.tuwien.ac.at>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
Tests for offsetTop of table cells updated so that they don't include borderExtraTop
- fast/dom/Element/offsetTop-table-cell-expected.txt:
- fast/dom/Element/offsetTop-table-cell.html:
- 8:58 PM Changeset in webkit [35550] by
-
- 3 edits in trunk/LayoutTests
2008-08-04 Sam Weinig <sam@webkit.org>
Rubber-stamped by Dan Bernstein.
Fix typo in Skipped lists.
- platform/mac-tiger/Skipped:
- platform/win/Skipped:
- 8:19 PM Changeset in webkit [35549] by
-
- 1 copy in tags/Safari-6528.0.2
New tag.
- 8:16 PM Changeset in webkit [35548] by
-
- 2 edits in trunk/WebKit/mac
Build fix.
- 7:02 PM Changeset in webkit [35547] by
-
- 4 edits in trunk/WebKit/mac
Adopt the formal protocols where necessary.
Final part of fix for <rdar://problem/5853147>.
Reviewed by Kevin Decker.
- 7:02 PM Changeset in webkit [35546] by
-
- 4 edits1 add in trunk/WebKit
Declare empty protocols when using versions of AppKit that do not use formal protocols for delegates and data sources.
Part one of fix for <rdar://problem/5853147>.
Reviewed by Darin Adler.
- 6:54 PM Changeset in webkit [35545] by
-
- 28 edits3 adds in trunk
2008-08-04 Dean Jackson <dino@apple.com>
Reviewed by Dave Hyatt.
Improve AnimationController
https://bugs.webkit.org/show_bug.cgi?id=19938
- Transition class is now called Animation
- new state-based AnimationController that can support CSS Animations
- add support for -webkit-transition-delay
- remove -webkit-transition-repeat-count (since it never existed officially)
- updates the -webkit-transition shorthand to reflect removing repeat count
- updates the Transition class so that properties can be shared with animations
- adds a "now" keyword for -webkit-transition-delay
- adds a new change type for style (changed by animation)
- adds new event names (although they are not dispatched yet)
- makes text stroke and text fill colors returned by RenderStyle const
Tests:
- manual-tests/transition-left.html
- manual-tests/transition-delay.html
- manual-tests/transition-timing-functions.html
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSParser.cpp:
- css/CSSParser.h:
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp:
- css/CSSStyleSelector.h:
- css/CSSTimingFunctionValue.h:
- css/CSSValue.h:
- css/CSSValueKeywords.in:
- css/WebKitCSSTransformValue.cpp:
- dom/Document.cpp:
- dom/Document.h:
- dom/Element.cpp:
- dom/EventNames.h:
- dom/Node.cpp:
- dom/Node.h:
- history/CachedPage.cpp:
- page/AnimationController.cpp:
- page/AnimationController.h:
- page/Frame.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderWidget.cpp:
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- 5:39 PM Changeset in webkit [35544] by
-
- 4 edits in trunk/WebCore
Reviewed by Antti.
Currently we create two copies of script in the HTMLTokenizer.
One copy gets passed into the javascript engine, the other gets
stored in the DOM. Modify the HTMLParser so that it does not
chunk the string into it's normal 64K chunks for script code,
and modify the HTMLTokenizer to pass that same string into the
JS engine. On some sites (e.g. GMail), which have hundreds of
KB of inline JS, this saves more than a MB of RAM to run the page.
(Strings use 16bit strings, so 600KB of JS code == 1.2MB of memory)
- html\HTMLParser.cpp
- html\HTMLTokenizer.cpp
- 4:01 PM Changeset in webkit [35543] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Fix warning seen in MSVC converting ints to floats.
- rendering/Length.h: (WebCore::Length::calcFloatValue):
- 2:24 PM Changeset in webkit [35542] by
-
- 2 edits in trunk/WebCore
2008-08-04 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove extra braces left in from JSLock removal.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection):
- 1:29 PM Changeset in webkit [35541] by
-
- 3 edits in trunk/LayoutTests
2008-08-04 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Update skipped lists for renamed tests.
- platform/mac-tiger/Skipped:
- platform/win/Skipped:
- 1:21 PM Changeset in webkit [35540] by
-
- 6 edits14 adds in trunk
WebCore:
2008-08-02 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Implement the Access-control for Cross Site requests
preflight cache.
Tests: http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/KURL.h: (WTF::):
- platform/KURLHash.h: Added. (WebCore::KURLHash::hash): (WebCore::KURLHash::equal): (WTF::):
- xml/XMLHttpRequest.cpp: (WebCore::PreflightResultCacheItem::PreflightResultCacheItem): (WebCore::preflightResultCache): (WebCore::appendPreflightResultCacheEntry): (WebCore::canSkipPrelight): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::parseAccessControlAllowList): (WebCore::parseAccessControlMaxAge): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
LayoutTests:
2008-08-04 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Tests for the Access-control for Cross Site requests
preflight cache.
- ChangeLog:
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html: Added.
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html: Added.
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html: Added.
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html: Added.
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php: Added.
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php: Added.
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php: Added.
- http/tests/xmlhttprequest/resources/portabilityLayer.php: Added.
- http/tests/xmlhttprequest/resources/reset-temp-file.php: Added.
- 12:59 PM Changeset in webkit [35539] by
-
- 2 edits in trunk/WebCore
Reviewed by hyatt.
Clean up Gradient constructors, make sure all members are initialized.
- platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient):
- 12:53 PM Changeset in webkit [35538] by
-
- 2 edits in trunk/WebKit/mac
2008-08-04 Brady Eidson <beidson@apple.com>
Reviewed by Mitz Pettel
Fix <rdar://problem/5820157> - Saving WebArchives of Mail attachments broken.
This broke in r31355 when we stopped returning nil WebResources when there was nil
resource data.
- WebView/WebResource.mm: (-[WebResource _initWithCoreResource:]): Restore previous behavior of returning nil when the resource data is null.
- 9:02 AM Changeset in webkit [35537] by
-
- 2 edits in trunk/WebKit/qt
2008-08-04 Erik Bunce <elbunce@thehive.com>
Reviewed by Simon.
Add updateAction() support to ToggleBold, ToggleItalic, and ToggleUnderline.
Add lookup table for mapping web actions to editor commands.
- 7:31 AM Changeset in webkit [35536] by
-
- 2 edits in trunk/WebKit/qt
2008-08-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
A bunch of improvements to the QtLauncher.
Among others:
- Unify and unclutter the toolbar, use menu for addition actions
- Simplify URL edit, just use QLineEdit (no fancy close button etc)
- Guess the URL from the command line so now we can run ./QtLauncher www.google.com
- Shortcut keys for most actions
- Simple autocomplete for the URL edit
- Actions for zooming, New Window and Close Window
- Show Format menu only when the content is set to editable
- 7:03 AM Changeset in webkit [35535] by
-
- 2 edits in trunk/WebKit/qt
2008-08-04 Erik Bunce <elbunce@thehive.com>
Reviewed by Simon.
Allow Copy key sequence to work in non-editable areas.
Aug 3, 2008:
- 7:34 PM Changeset in webkit [35534] by
-
- 2 edits in trunk/LayoutTests
Future-proof fast/cookies/local-file-can-set-cookies.html
Reviewed by Anders Carlsson.
- fast/cookies/local-file-can-set-cookies.html: Set cookie expiration date 60 seconds into the future instead of a hard-coded date.
- 2:58 AM Changeset in webkit [35533] by
-
- 10 edits3 adds in trunk
Bug 19359: JavaScriptCore behaves differently from FF2/3 and IE when handling context in catch statement
<https://bugs.webkit.org/show_bug.cgi?id=19359>
Reviewed by Cameron Zwarich
Make our catch behave like Firefox and IE, we do this by using a StaticScopeObject
instead of a generic JSObject for the scope node. We still don't make use of the
fact that we have a static scope inside the catch block, so the internal performance
of the catch block is not improved, even though technically it would be possible to
do so.
- 1:34 AM Changeset in webkit [35532] by
-
- 13 edits8 adds in trunk
2008-08-02 Maxime Britto <britto@apple.com>
Reviewed by Eric Seidel.
<rdar://problem/6118969>
https://bugs.webkit.org/show_bug.cgi?id=19971
Modifiy the cursor interactively when on panning mode (middle click auto scroll)
When the panning is in progress the cursor is an arrow representing the direction of the current scroll
- page/EventHandler.cpp: (WebCore::EventHandler::autoscrollTimerFired): Before each scroll we actualize the cursor to match the current direction (WebCore::EventHandler::setPanScrollCursor): determines the direction of the upcoming scroll. (WebCore::EventHandler::handleMouseMoveEvent):
- page/EventHandler.h:
- platform/Cursor.h: Add propotypes for the new cursor functions
- platform/gtk/CursorGtk.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
- platform/mac/CursorMac.mm: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
- platform/qt/CursorQt.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
- platform/win/CursorWin.cpp: Add specific icons for the panning as windows resizing icons are both sides arrows (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
- platform/wx/CursorWx.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
2008-08-02 Maxime Britto <britto@apple.com>
Reviewed by Eric Seidel.
These icons are copies from the resizers in WebCore/Ressources
- ChangeLog:
- WebKit.vcproj/WebKit.rc:
- WebKit.vcproj/panEastCursor.png: Added.
- WebKit.vcproj/panNorthCursor.png: Added.
- WebKit.vcproj/panNorthEastCursor.png: Added.
- WebKit.vcproj/panNorthWestCursor.png: Added.
- WebKit.vcproj/panSouthCursor.png: Added.
- WebKit.vcproj/panSouthEastCursor.png: Added.
- WebKit.vcproj/panSouthWestCursor.png: Added.
- WebKit.vcproj/panWestCursor.png: Added.
- WebKit.vcproj/resource.h:
- WebKitDLL.cpp: (loadResourceIntoBuffer):
Aug 2, 2008:
- 6:47 PM Changeset in webkit [35531] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-02 Rob Gowin <robg@gowin.net>
Reviewed by Eric Seidel.
Added JavaScriptCore/API/WebKitAvailability to list of files in
javascriptcore_h_api.
- GNUmakefile.am:
- 3:34 PM Changeset in webkit [35530] by
-
- 2 edits in trunk/WebKit/mac
2008-08-02 Matt Lilek <webkit@mattlilek.com>
Reviewed by Tim Hatcher.
Update the window gradient offset to match the inspector toolbar's new height.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]):
- 3:24 PM Changeset in webkit [35529] by
-
- 2 edits in trunk/WebKitTools
Forgot to commit licensing correction in last commit.
- 2:50 PM Changeset in webkit [35528] by
-
- 1 edit3 adds in trunk/WebKitTools
Reviewed by Eric Seidel.
Scripts for building a wxWebKit installer for wxPython on Win, eventually will
be used for nightlies.
https://bugs.webkit.org/show_bug.cgi?id=20036
- 2:33 PM Changeset in webkit [35527] by
-
- 2 edits in trunk/WebCore
Move to using constants in accordance with discussions about wx renderer commit.
- 2:38 AM Changeset in webkit [35526] by
-
- 2 edits in trunk/WebCore
2008-08-02 Wouter Bolsterlee <wbolster@svn.gnome.org>
Reviewed by Eric Seidel.
- plugins/gtk/gtk2xtbin.h:
https://bugs.webkit.org/show_bug.cgi?id=20034
Fix malformed Vim modeline.
- 2:38 AM Changeset in webkit [35525] by
-
- 1 edit1 delete in trunk/WebKit/gtk
2008-08-02 Christian Dywan <christian@twotoasts.de>
Reviewed by Eric Seidel.
Remove webkit-marshal.list, which was made obsolete in #19742
- webkit/webkit-marshal.list: Removed.
Aug 1, 2008:
- 11:10 PM Changeset in webkit [35524] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- tweak a comment
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
- 10:48 PM ApplicationsGtk edited by
- Updates (diff)
- 10:19 PM Changeset in webkit [35523] by
-
- 1 edit in trunk/WebKit/gtk/ChangeLog
Forgot to add the reviewer of r35522.
- WebKit/gtk/ChangeLog:
- 10:12 PM Changeset in webkit [35522] by
-
- 2 edits in trunk/WebKit/gtk
2008-08-01 Wouter Bolsterlee <uws@xs4all.nl>
https://bugs.webkit.org/show_bug.cgi?id=20035
[GTK] Fix return value for webkit_web_view_go_to_back_forward_item()
- webkit/webkitwebview.cpp:
- 10:11 PM Changeset in webkit [35521] by
-
- 1 edit in trunk/WebCore/ChangeLog
2008-08-01 Jan Michael Alonzo <jmalonzo@webkit.org>
- ChangeLog: Fix date of previous commit (r35520)
- 10:01 PM Changeset in webkit [35520] by
-
- 2 edits in trunk/WebCore
2008-06-17 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=19603
[SOUP] segfault when closing a file using gio
Call client->didFinishLoading() only after releasing all the gio
resources.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::closeCallback): (WebCore::readCallback):
- 5:29 PM Changeset in webkit [35519] by
-
- 4 edits in trunk
../../../../../../WebCore:
2008-08-01 Anders Carlsson <andersca@apple.com>
Reviewed by Jon.
<rdar://problem/6120206>
Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.
Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.
- plugins/PluginStream.cpp: (WebCore::PluginStream::wantsAllStreams):
../../../../../../WebKit/mac:
2008-08-01 Anders Carlsson <andersca@apple.com>
Reviewed by Jon.
<rdar://problem/6120206>
Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.
Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream wantsAllStreams]):
- 5:06 PM Changeset in webkit [35518] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
Native rendering implementations for form elements in the wx port.
https://bugs.webkit.org/show_bug.cgi?id=19069
- 2:50 PM Changeset in webkit [35517] by
-
- 4 edits in trunk/WebKit/win
2008-08-01 Beth Dakin <Beth Dakin>
Reviewed by Adam Roben.
Fix for <rdar://problem/6119382> Need to hook up WebFrame's
disconnected frame API on Windows.
- Interfaces/IWebFrame.idl:
- WebFrame.cpp: (WebFrame::setIsDisconnected):
- WebFrame.h:
- 2:32 PM Changeset in webkit [35516] by
-
- 2 edits in trunk/WebKit/win
Fix <rdar://6118733> REGRESSION (r35502): Crash when submitting any form
Reviewed by Darin Adler.
- COMPropertyBag.h: (COMPropertyBag::QueryInterface): Cast to an appropriate type before assigning into ppvObject.
- 1:24 PM Changeset in webkit [35515] by
-
- 2 edits in trunk/WebCore
2008-07-30 David Hyatt <hyatt@apple.com>
Improvements to selection drawing.
Clip out floating and positioned objects when drawing selection so
that there is no "double painting" of selection when the selection spans both the space behind the positioned/floating
object and the positioned/floating object itself. Improves most Web pages.
Do not paint left/right selection gaps if the object's edge is already outside the boundary (at a negative
position). Significantly improves the look of selections on digg.com, since it uses giant negative text-indent.
Reviewed by Dan
Covered by existing selection pixel tests.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::paintSelection): (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
- 1:23 PM Changeset in webkit [35514] by
-
- 4 edits in trunk/WebCore
Adds the ability to disable individual properties of a CSS rule.
When hovering over a rule, checkboxes show up to the right of all
properties and toggling a checkbox disables/enables the property.
Behind the scenes the property is removed from the rule when disabled,
but still remains in the list and in the computed style. When disabled
the property has a line through it, and is faded in computed style.
<rdar://problem/5712828> Support disabling individual CSS properties
https://bugs.webkit.org/show_bug.cgi?id=14377
Reviewed by Adam Roben.
- page/inspector/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): Include the inline style when it also has disabled properties. Call deleteDisabledProperty for any property that is in the style, since it might have been added back by the page. Remember all disabled properties so they show up in computed style. (deleteDisabledProperty): Helper function to delete all the right properties that track disabled properties. (WebInspector.StylePropertiesSection): Add the computed-style class when the section is Computed Style. (WebInspector.StylePropertiesSection.prototype.onpopulate): Include disabled properties. (WebInspector.StylePropertyTreeElement): Added a disabled argument. (WebInspector.StylePropertyTreeElement.prototype.get/set disabled): Sets the _disabled property and calls updateState. (WebInspector.StylePropertyTreeElement.prototype.get priority): Return the priority of enabled or disabled properties. (WebInspector.StylePropertyTreeElement.prototype.get value): Return the value of enabled or disabled properties. (WebInspector.StylePropertyTreeElement.prototype.updateTitle): Use the priority and value getter. Append the checkbox for root elements of an editable section. (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Add or remove properties from the rule and remember removed ones by adding three objects to the style: disabledProperties, disabledPropertyValues and disabledPropertyPriorities. The disabledProperties object will include all longhand properties of a shorthand for use by Computed Style. (WebInspector.StylePropertyTreeElement.prototype.updateState): Use the value getter. Update the disabled state.
- page/inspector/inspector.css:
- page/inspector/utilities.js: (Object.hasProperties): Added. Helper to test if an object has any properties.
- 12:23 PM Changeset in webkit [35513] by
-
- 13 edits in trunk
../../../../../../WebCore:
2008-07-31 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
<rdar://problem/5949410>
Add the ability to transfer a given application cache to a new database.
- WebCore.base.exp: Export ApplicationCacheStorage::storeCopyOfCache.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::~ApplicationCache): Don't call cacheDestroyed for our special "copy" groups.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup): Add a "copy" flag to the ApplicationCacheGroup constructor. A "copied" group is special and can only be stored to disk.
- loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::isCopy): New getter.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): Make sure to set the storageID when storing an application resource.
(WebCore::ApplicationCacheStorage::storeNewestCache):
Change this to return true/false depending on whether storing the cache succeeded or not.
(WebCore::ApplicationCacheStorage::storeCopyOfCache):
New method which stores a given cache in a new storage (database file).
- loader/appcache/ApplicationCacheStorage.h: Add new methods.
../../../../../../WebKit/mac:
2008-07-31 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
<rdar://problem/5949410>
Add the ability to transfer a given application cache to a new database.
- Misc/WebKitNSStringExtras.h:
- Misc/WebKitNSStringExtras.m: (+[NSString _webkit_applicationCacheDirectoryWithBundleIdentifier:]): New method which returns the appopriate cache directory for a given bundle identifier.
- WebView/WebDataSource.mm: (-[WebDataSource _transferApplicationCache:]): Transfer the application cache.
- WebView/WebDataSourcePrivate.h:
- WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): Change this to use _webkit_applicationCacheDirectoryWithBundleIdentifier.
- 11:20 AM Changeset in webkit [35512] by
-
- 2 edits in trunk/WebKitSite
Add a link to the instructions to use Apple's Safari for Windows symbol server
Reviewed by Eric Seidel.
- building/debug.html:
- 1:38 AM Changeset in webkit [35511] by
-
- 2 edits in trunk/JavaScriptCore
Rubber-stamped by Maciej.
Remove JSGlobalData::DataInstance. It was only needed when we had per-thread JSGlobalData
instances.
- kjs/JSGlobalData.h:
- 1:06 AM Changeset in webkit [35510] by
-
- 4 edits in tags/Safari-6528.0.1
Versioning.
- 1:06 AM Changeset in webkit [35509] by
-
- 2 edits in tags/Safari-6528.0.1/WebKit/mac
Build fix.
- 12:53 AM Changeset in webkit [35508] by
-
- 1 copy in tags/Safari-6528.0.1
New tag.
Jul 31, 2008:
- 8:10 PM Changeset in webkit [35507] by
-
- 4 edits in trunk
Versioning.
- 7:52 PM Changeset in webkit [35506] by
-
- 4 edits in tags/Safari-6528
Versioning.
- 7:52 PM Changeset in webkit [35505] by
-
- 3 edits in tags/Safari-6528/WebKit/mac
- 7:32 PM Changeset in webkit [35504] by
-
- 1 copy in tags/Safari-6528
New tag.
- 5:08 PM Changeset in webkit [35503] by
-
- 5 edits in trunk/LayoutTests
Updated test results for DumpRenderTree fix in r35497
- svg/custom/image-with-prefix-in-webarchive-expected.webarchive: Contents of the main resource are now displayed instead of encoded data.
- svg/webarchive/svg-cursor-subresources-expected.webarchive: Ditto.
- svg/webarchive/svg-feimage-subresources-expected.webarchive: Ditto.
- svg/webarchive/svg-script-subresouces-expected.webarchive: Ditto. Also updated MIME types for JavaScript source now that we don't mangle application/x-javascript into text/javascript.
- 4:16 PM Changeset in webkit [35502] by
-
- 5 edits2 deletes in trunk/WebKit/win
2008-07-31 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Get rid of FormValuesPropertyBag and use COMPropertyBag instead.
- COMPropertyBag.h: Implement parts of IPropertyBag2. Currently just one method (CountProperties) is implemented.
- WebCoreSupport/FormValuesPropertyBag.cpp: Removed.
- WebCoreSupport/FormValuesPropertyBag.h: Removed.
- WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): Create a COMPropertyBag instead.
- WebKit.vcproj/WebKit.vcproj:
- 3:18 PM Changeset in webkit [35501] by
-
- 2 edits in trunk/WebKitTools
Follow-up to r35500
- WinLauncher/WinLauncher.vcproj: Set the manifest properties for the Release configuration, too.
- 3:12 PM Changeset in webkit [35500] by
-
- 2 edits in trunk/WebKitTools
2008-07-31 Stefan Landvogt <stefan.landvogt@gmail.com>
Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
the box
Reviewed by Adam Roben.
- WinLauncher/WinLauncher.vcproj: adding the following properties to WinLauncher > Properties > Manifest Tool > Isolated COM Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb Component File Name: WebKit$(WebKitDLLConfigSuffix) Doing the change on "All Configurations"
- 2:42 PM Changeset in webkit [35499] by
-
- 11 edits in trunk
WebCore:
2008-07-31 John Sullivan <sullivan@apple.com>
WebCore part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs
Reviewed by Hyatt
- WebCore.base.exp: export symbol for WebCoreSettings::setZoomsTextOnly()
- page/Frame.cpp: (WebCore::Frame::isZoomFactorTextOnly): use value from Settings instead of data member (WebCore::Frame::shouldApplyTextZoom): call isZoomFactorTextOnly() to get value instead of accessing now-removed data member (WebCore::Frame::shouldApplyPageZoom): ditto (WebCore::Frame::setZoomFactor): set value into Settings rather than into data member (WebCore::FramePrivate::FramePrivate): don't set initial value of now-removed data member; this is managed by Settings now
- page/FramePrivate.h: removed m_zoomFactorIsTextOnly
- page/Settings.cpp: (WebCore::Settings::setZoomsTextOnly): new function, sets values and reapplies styles in all frames
- page/Settings.h: (WebCore::Settings::zoomsTextOnly): new function, returns value of new data member
WebKit/mac:
2008-07-31 John Sullivan <sullivan@apple.com>
WebKit part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs
Reviewed by Hyatt
- WebView/WebPreferenceKeysPrivate.h: added WebKitZoomsTextOnlyPreferenceKey
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): default value of YES for WebKitZoomsTextOnlyPreferenceKey (-[WebPreferences zoomsTextOnly]): getter for WebKitZoomsTextOnlyPreferenceKey (-[WebPreferences setZoomsTextOnly:]): setter for WebKitZoomsTextOnlyPreferenceKey
- WebView/WebPreferencesPrivate.h: declare zoomsTextOnly/setZoomsTextOnly:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): update WebCore::Settings value for zoomsTextOnly
- 2:35 PM Changeset in webkit [35498] by
-
- 2 edits in trunk/WebKitTools
Windows build bot fix
- DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only exist for people at Apple can't be found. Also updated the ICU version to 3.8.
- 2:21 PM Changeset in webkit [35497] by
-
- 10 edits1 add1 delete in trunk
Fix layout test results for webarchive/test-xml-stylesheet.xml
WebKit:
Fix layout test results for webarchive/test-xml-stylesheet.xml
Reviewed by Darin.
- WebKit.xcodeproj/project.pbxproj: Added WebHTMLRepresentationInternal.h. Changed WebHTMLRepresentationInternal.h and WebHTMLRepresentationPrivate.h to private so they're copied into PrivateHeaders.
WebKit/mac:
Fix layout test results for webarchive/test-xml-stylesheet.xml
Reviewed by Darin.
Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
for DumpRenderTree.
- WebView/WebHTMLRepresentationInternal.h: Added.
WebKitTools:
Fix layout test results for webarchive/test-xml-stylesheet.xml
Reviewed by Darin.
- DumpRenderTree/mac/DumpRenderTree.mm: (convertMIMEType): Work around the "text/xml" local file type regression in Leopard using the BUILDING_ON_LEOPARD macro. Also stop mangling "application/x-javascript" into "text/javascript". (convertWebResourceDataToString): When checking whether to dump a resource as text, also check to see if the MIME type is in the -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
- DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD macro.
LayoutTests:
Fix layout test results for webarchive/test-xml-stylesheet.xml
Reviewed by Darin.
- platform/mac/webarchive/test-xml-stylesheet-expected.txt: Removed unused test results.
- webarchive/test-duplicate-resources-expected.webarchive: Updated results now that we don't mangle application/x-javascript into text/javascript.
- webarchive/test-script-src-expected.webarchive: Ditto.
- webarchive/test-xml-stylesheet-expected.webarchive: Updated results now that we handle application/xml correctly.
- 2:10 PM Changeset in webkit [35496] by
-
- 2 edits in trunk/WebCore
2008-07-31 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Null-check parent clip rects, because they may not have been
set up yet.
https://bugs.webkit.org/show_bug.cgi?id=20243
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects):
- 1:55 PM Changeset in webkit [35495] by
-
- 2 copies in trunk/WebKit/win/WebCoreSupport
Did not mean to remove these files.
- 1:54 PM Changeset in webkit [35494] by
-
- 2 edits2 deletes in trunk/WebKit/win
2008-07-31 Anders Carlsson <andersca@apple.com>
Reviewed by Jon.
Tweak the names.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
- 1:48 PM Changeset in webkit [35493] by
-
- 5 edits3 adds in trunk/WebKit/win
2008-07-31 Anders Carlsson <andersca@apple.com>
Reviewed by Jon.
<rdar://problem/5826110>
Add a way for WebKit clients to embed custom content in web pages.
- Interfaces/IWebEmbeddedView.idl: Added. New interface which an embedded view must implement.
- Interfaces/IWebUIDelegatePrivate.idl: Add new UI delegate method for creating an embedded view.
- Interfaces/WebKit.idl: Include IWebEmbeddedView.idl.
- WebCoreSupport/EmbeddedWidget.cpp: Added.
- WebCoreSupport/EmbeddedWidget.h: Added. Add EmbeddedWidget, a widget subclass which can hold an IWebEmbeddedView.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check if the UI delegate wants to create an embedded view.
- WebKit.vcproj/WebKit.vcproj: Add EmbeddedWidget.{cpp|h}
- 1:46 PM Changeset in webkit [35492] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- fix <rdar://problem/6058958> REGRESSION (r34210): Seams are visible in border-image
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): To work around a Core Graphics interpolation issue, reverted to using a temporary subimage for drawing a portion of the image with scaling and high-quality interpolation in effect.
- 1:44 PM Changeset in webkit [35491] by
-
- 8 edits2 adds in trunk
<rdar://problem/3563671> VO doesn't highlight characters when interacting when static text in web areas
Add ability to get bounds for individual characters through accessibility
- 1:39 PM Changeset in webkit [35490] by
-
- 1 edit in trunk/WebCore/ChangeLog
Removed da BOM from the ChangeLog.
- 12:15 PM Changeset in webkit [35489] by
-
- 2 edits in trunk/WebKit/mac
Release build fix.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setWindowIfNecessary]): Don't define to npErr in release builds, as it is only used for logging.
- 10:50 AM Changeset in webkit [35488] by
-
- 2 edits in trunk/WebKit/mac
2008-07-31 John Sullivan <sullivan@apple.com>
Fixed <https://bugs.webkit.org/show_bug.cgi?id=5195>
drawing with cacheDisplayInRect:toBitmapImageRep: doesn't trigger layout on Leopard
Reviewed by Dan
- WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): include Leopard in the #ifdef that forces a layout if needed
- 10:33 AM Changeset in webkit [35487] by
-
- 7 edits in trunk
Second attempt at Windows/wx build fix. Instead of avoiding inclusion of windows.h, use defines, etc. to avoid conflicts in each affected file.
- 10:20 AM Changeset in webkit [35486] by
-
- 2 edits in trunk/WebCore
2008-07-31 Erik Bunce <elbunce@thehive.com>
Reviewed by Simon.
Include the Writing Direction sub-menu in the context menu of all
platforms but GTK. This fixes a regression introduced by revision
34426.
- 10:14 AM Changeset in webkit [35485] by
-
- 9 edits in trunk
WebCore:
2008-07-31 Brady Eidson <beidson@apple.com>
Reviewed by Adam and Hyatt
Fix for <rdar://problem/6099748>
Adds a "don't enforce CSS mime type in strict mode" quirk for iWeb 2
- WebCore.base.exp:
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet):
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::canUseSheet):
- loader/CachedCSSStyleSheet.h: (WebCore::CachedCSSStyleSheet::sheetText):
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setEnforceCSSMIMETypeInStrictMode):
- page/Settings.h: (WebCore::Settings::enforceCSSMIMETypeInStrictMode):
WebKit/mac:
2008-07-30 Brady Eidson <beidson@apple.com>
Reviewed by Adam and Hyatt
Fix for <rdar://problem/6099748>
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Set the "don't enforce CSS mime type in strict mode" quirk when running under iWeb 2
- 9:56 AM Changeset in webkit [35484] by
-
- 3 edits in trunk/JavaScriptCore
2008-07-31 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Fix Windows build.
- kjs/collector.h:
- wtf/FastMalloc.cpp:
- 8:11 AM Changeset in webkit [35483] by
-
- 2 edits in trunk/WebCore
2008-07-31 Erik Bunce <elbunce@thehive.com>
Reviewed by Simon.
Added the ability to get SQLite headers and source from the location·
specified via the SQLITE3SRCDIR environtment variable.
- 8:10 AM Changeset in webkit [35482] by
-
- 2 edits in trunk/WebKitTools
2008-07-31 Erik Bunce <elbunce@thehive.com>
Reviewed by Simon.
Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.
- 8:03 AM Changeset in webkit [35481] by
-
- 2 edits in trunk/WebKit/qt
2008-07-31 Erik Bunce <elbunce@thehive.com>
Reviewed by Simon.
Make sure edit actions get updated when the contents change.
- 8:00 AM Changeset in webkit [35480] by
-
- 2 edits in trunk/WebKit/qt
2008-07-31 Erik Bunce <elbunce@thehive.com>
Reviewed by Simon.
Add simple edit test abilities to QtLauncher.
- 8:00 AM Changeset in webkit [35479] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-31 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
Reviewed by Simon.
Bug 20170: [Qt] missing namespace defines in JavaScriptCore.pro
<https://bugs.webkit.org/show_bug.cgi?id=20170>
- 5:19 AM Changeset in webkit [35478] by
-
- 102 edits5 deletes in trunk
Rubber-stamped by Maciej.
Eliminate JSLock (it was already disabled, removing the stub implementaion and all
call sites now).
- 2:58 AM Changeset in webkit [35477] by
-
- 2 edits in trunk/JavaScriptCore
Rubber-stamped by Oliver Hunt.
Fix the Mac project to not display "test/" as part of file name for tests.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 1:44 AM Changeset in webkit [35476] by
-
- 10 edits in trunk/JavaScriptCore
Reviewed by Alexey Proskuryakov.
Rename USE(MULTIPLE_THREADS) to ENABLE(JSC_MULTIPLE_THREADS)
to better match the use/enable pattern (and better describe
the usage of the feature in question.)
I also fixed a couple other ENABLE_ macros to be pre-processor
definition override-able to match the rest of the ENABLE_ macros
since it seems to be our convention that build systems can set
ENABLE_ macros in Makefiles.
- kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce):
- kjs/JSGlobalData.cpp: (KJS::JSGlobalData::JSGlobalData): (KJS::JSGlobalData::~JSGlobalData):
- kjs/MathObject.cpp:
- kjs/collector.cpp: (KJS::Heap::Heap): (KJS::Heap::~Heap): (KJS::allocateBlock): (KJS::Heap::markStackObjectsConservatively):
- kjs/collector.h:
- kjs/dtoa.cpp: (KJS::pow5mult): (KJS::rv_alloc): (KJS::freedtoa): (KJS::dtoa):
- wtf/FastMalloc.cpp:
- wtf/Platform.h:
- wtf/RefCountedLeakCounter.cpp:
- 12:37 AM Changeset in webkit [35475] by
-
- 2 edits in trunk/WebKit/win
Windows build fix.
Jul 30, 2008:
- 11:38 PM Changeset in webkit [35474] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Mark Rowe.
Try to clean up our usage of USE(MULTIPLE_THREADS) vs. USE(PTHREADS) a little.
It looks like JSC assumes that if MULTIPLE_THREADS is defined, then pthreads will always be available
I'm not sure that's always the case for gtk, certainly not for Windows. We should eventually go back
and fix wtf/Threading.h to cover all these cases some day.
- kjs/JSLock.cpp:
- kjs/collector.h:
- wtf/Platform.h:
- 11:14 PM Changeset in webkit [35473] by
-
- 2 edits in trunk/WebKit/win
Windows build fix.
- 9:04 PM Changeset in webkit [35472] by
-
- 4 edits in trunk/WebCore
Fix various minor bugs with style editing in the Inspector.
- Restores the scroll position to 0,0 when finished editing a string that was longer than the editing input area.
- Adjusts the margin of the list item to ensure the text does not shift when entering and exiting editing mode.
- Reliably remembers if a shorthand has children when the children haven't been populated yet.
- Reliably remembers if a shorthand was expanded, and expands if needed after editing finishes.
- Hides color swatches when editing.
Reviewed by Adam Roben.
- page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.startEditing): Store the expanded state and children state in wasExpanded and reallyHasChildren properties. (WebInspector.StylePropertyTreeElement.prototype.editingEnded): Removed the wasExpanded argument and use the reallyHasChildren and wasExpanded properties to restore state. Deletes the state properties. (WebInspector.StylePropertyTreeElement.prototype.editingCancelled): Removed the wasExpanded argument. (WebInspector.StylePropertyTreeElement.prototype.editingCommitted): Removed the wasExpanded argument.
- page/inspector/inspector.css: Tweak the margin and hides the color swatches. ALso removes a rule that was not needed.
- page/inspector/inspector.js: (WebInspector.startEditing): Restore the scrollLeft and scrollTop to zero when editing finishes.
- 6:21 PM Changeset in webkit [35471] by
-
- 3 edits2 deletes in trunk/WebKit/win
2008-07-30 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Use a COMPropertyBag instead of the HTTPHeaderPropertyBag.
- HTTPHeaderPropertyBag.cpp: Removed.
- HTTPHeaderPropertyBag.h: Removed.
- WebURLResponse.cpp: (WebURLResponse::allHeaderFields):
- 6:11 PM Changeset in webkit [35470] by
-
- 3 edits in trunk/WebKit/win
2008-07-30 Anders Carlsson <andersca@apple.com>
Fix copyright years.
- COMPropertyBag.h:
- COMVariantSetter.h:
- 5:33 PM Changeset in webkit [35469] by
-
- 5 edits in trunk/WebCore
2008-07-30 Alice Liu <alice.liu@apple.com>
Implement userIdleTime() for Windows, and place a band-aid over other
platform implementations of userIdleTime(). This will fix the issue
of indefinitely postposing releasing pages from the PageCache
on non-Mac platforms, causing us to hang onto just about everything
else about a web page.
Reviewed by Sam Weinig.
- platform/gtk/TemporaryLinkStubs.cpp:
- platform/wx/TemporaryLinkStubs.cpp:
- platform/qt/TemporaryLinkStubs.cpp: (WebCore::userIdleTime): set to FLT_MAX
- platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime): implemented
- 5:19 PM Changeset in webkit [35468] by
-
- 3 edits in trunk/WebKit/win
2008-07-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
More property bag work.
- COMPropertyBag.h: (COMPropertyBag::COMPropertyBag): (::adopt): (::Read):
- COMVariantSetter.h: (COMIUnknownVariantSetter::setVariant):
- 5:01 PM Changeset in webkit [35467] by
-
- 11 edits in trunk
WebCore:
2008-07-30 Beth Dakin <Beth Dakin>
Reviewed by Anders Carlsson.
Fixes <rdar://problem/6041390>
Adds the ability to have a frame that is "disconnected" from the
main frame from the perspective of top and parent in
Javascript.
- WebCore.base.exp:
- page/DOMWindow.cpp: (WebCore::DOMWindow::parent): (WebCore::DOMWindow::top):
- page/Frame.cpp: (WebCore::Frame::isDisconnectedFrame): (WebCore::Frame::setIsDisconnectedFrame): (WebCore::FramePrivate::FramePrivate):
- page/Frame.h:
- page/FramePrivate.h:
- page/FrameTree.cpp: (WebCore::FrameTree::parent): (WebCore::FrameTree::top):
- page/FrameTree.h:
WebKit/mac:
2008-07-30 Beth Dakin <Beth Dakin>
Reviewed by Anders Carlsson.
Fixes <rdar://problem/6041390>
Adds the ability to have a frame that is "disconnected" from the
main frame from the perspective of top and parent in
Javascript.
- WebView/WebFrame.mm: (-[WebFrame _setIsDisconnectedFrame]):
- WebView/WebFramePrivate.h:
- 4:14 PM Changeset in webkit [35466] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Oliver.
MSVC warns when structs are called classes or vice versa.
Make all the source refer to JSGlobalData as a class.
- kjs/CommonIdentifiers.h:
- kjs/JSGlobalData.h:
- kjs/Parser.h:
- kjs/lexer.h:
- 4:13 PM Changeset in webkit [35465] by
-
- 2 edits1 add in trunk/WebCore
Reviewed by Justin.
Crash Safari when dragging images into Google presentations
https://bugs.webkit.org/show_bug.cgi?id=20161
Test: manual-tests/remove-on-drop-crash.html
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- manual-tests/remove-on-drop-crash.html: Added.
- 3:59 PM Changeset in webkit [35464] by
-
- 2 edits in trunk/WebKitTools
2008-07-30 Jessica Kahn <jess@apple.com>
Reviewed by Adam Roben.
Slightly stricter checking for previous change, suggested by Adam.
- Scripts/extract-localizable-strings:
- 3:29 PM Changeset in webkit [35463] by
-
- 3 edits2 adds in trunk/WebKit/win
2008-07-30 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
Add COMPropertyBag, a simple template class that implements the IPropertyBag interface. All
property bag values must be of the same type.
The COMVariantSetter helpers are now in COMVariantSetter.h
- COMEnumVariant.h:
- COMPropertyBag.h: Added.
- COMVariantSetter.h: Added.
- WebKit.vcproj/WebKit.vcproj:
- 3:22 PM Changeset in webkit [35462] by
-
- 2 edits in trunk/WebKitTools
2008-07-30 Jessica Kahn <jess@apple.com>
Reviewed by Darin Adler.
Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.
- Scripts/extract-localizable-strings:
- 2:12 PM Changeset in webkit [35461] by
-
- 2 edits in trunk/WebCore
Build fix for Cairo < 1.6
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::boundingRect): use cairo_stroke_extends for < 1.6
Reviewed by Mark.
- 1:34 PM Changeset in webkit [35460] by
-
- 52 edits in trunk/WebKit/win
2008-07-30 Alice Liu <alice.liu@apple.com>
Reviewed by Adam Roben.
Adding logging of COM class names and counts to facilitate
investigating memory issues.
- Interfaces/IWebKitStatistics.idl:
- WebKitDLL.cpp:
- WebKitDLL.h:
- WebKitStatistics.cpp: (WebKitStatistics::comClassNameCounts):
- WebKitStatistics.h:
- 1:17 PM Changeset in webkit [35459] by
-
- 2 edits in trunk/WebCore
2008-07-29 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
<rdar://problem/6110314> Crash in profiler dereferencing null frame or
page (20214)
- Null check.
- page/Console.cpp: (WebCore::Console::finishedProfiling):
- 1:16 PM Changeset in webkit [35458] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Geoff Garen.
Add consistency checks to UString to document and enforce its design.
- kjs/ustring.cpp: (KJS::UString::Rep::create): (KJS::UString::Rep::destroy): (KJS::UString::Rep::checkConsistency): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::spliceSubstringsWithSeparators): (KJS::UString::append):
- kjs/ustring.h: (KJS::UString::Rep::checkConsistency):
- 1:02 PM Changeset in webkit [35457] by
-
- 2 edits in trunk/WebCore
2008-07-30 David Hyatt <hyatt@apple.com>
Full page zoom needs to work properly with JS mouse events. Make sure to adjust the coordinates of the
JS mouse event to account for zoom.
Reviewed by olliej
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
- 12:00 PM Changeset in webkit [35456] by
-
- 17 edits4 moves10 deletes in trunk
WebCore:
2008-07-29 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Update Cross-site XMLHttpRequests using Access control to
the latest spec. (Editor's Draft 8 July 2008)
- This leaves us at about the same place as we previously were still needing preflight caching and better redirect support.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- xml/AccessControlList.cpp: Removed.
- xml/AccessControlList.h: Removed.
- xml/AccessItem.cpp: Removed.
- xml/AccessItem.h: Removed.
- xml/AccessItemRule.cpp: Removed.
- xml/AccessItemRule.h: Removed.
- xml/XMLHttpRequest.cpp: (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::isSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::clearRequest): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didFinishLoadingPreflight): (WebCore::XMLHttpRequest::accessControlCheck): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::parseAccessControlAllowList): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
- xml/XMLHttpRequest.h:
LayoutTests:
2008-07-29 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Update Cross-site XMLHttpRequests using Access control to
the latest spec. (Editor's Draft 8 July 2008)
- Update syntax in tests a remove tests for removed features.
- http/tests/xmlhttprequest/access-control-basic-allow-async.html:
- http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers-expected.txt: Removed.
- http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers.html: Removed.
- http/tests/xmlhttprequest/access-control-basic-exclude.html: Removed.
- http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-async-expected.txt.
- http/tests/xmlhttprequest/access-control-basic-non-simple-allow-async.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-async.html.
- http/tests/xmlhttprequest/access-control-basic-non-simple-allow-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow-expected.txt.
- http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html: Copied from LayoutTests/http/tests/xmlhttprequest/access-control-basic-not-get-allow.html.
- http/tests/xmlhttprequest/access-control-basic-not-get-allow-async-expected.txt: Removed.
- http/tests/xmlhttprequest/access-control-basic-not-get-allow-async.html: Removed.
- http/tests/xmlhttprequest/access-control-basic-not-get-allow-expected.txt: Removed.
- http/tests/xmlhttprequest/access-control-basic-not-get-allow.html: Removed.
- http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-allow-print-headers.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-allow.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-exclude.cgi: Removed.
- http/tests/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-non-get-allow.cgi:
- http/tests/xmlhttprequest/resources/access-control-basic-whitelist-response-headers.cgi:
- 11:17 AM Changeset in webkit [35455] by
-
- 5 edits in trunk
[GTK] Auto generate webkitmarshal.list
Auto generate webkitmarshal.list from source files to reduce the
number of conflicts when merging git branches or when applying
patches.
Also rename webkit-marshal.* to webkitmarshal.* for consistency.
Reviewed by Holger.
- 10:38 AM Changeset in webkit [35454] by
-
- 14 edits2 copies in trunk/JavaScriptCore
2008-07-30 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Fixes for Windows and non-AllInOne file build with SamplingTool, plus review fixes.
- GNUmakefile.am: Adding SamplingTool.cpp to build.
- JavaScriptCore.exp: Export hooks to init & control SamplingTool.
- JavaScriptCore.pri: Adding SamplingTool.cpp to build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Adding SamplingTool.cpp to build.
- JavaScriptCore.xcodeproj/project.pbxproj: Adding SamplingTool.cpp to build.
- JavaScriptCoreSources.bkl: Adding SamplingTool.cpp to build.
- VM/Machine.cpp: MACHINE_SAMPLING_callingNativeFunction renamed MACHINE_SAMPLING_callingHostFunction
- VM/Machine.h:
- VM/Opcode.cpp: SamplingTool moved to SamplingTool.cpp/.h, opcodeNames generated from FOR_EACH_OPCODE_ID.
- VM/Opcode.h:
- VM/SamplingTool.cpp: Added .cpp/.h for SamplingTool.
- VM/SamplingTool.h:
- kjs/Shell.cpp: Switched SAMPLING_TOOL_ENABLED to ENABLE_SAMPLING_TOOL.
- wtf/Platform.h: Added ENABLE_SAMPLING_TOOL config option.
- kjs/nodes.cpp: Header include to fix non-AllInOne builds.
- 10:09 AM Changeset in webkit [35453] by
-
- 2 edits in trunk/WebKitTools
2008-07-30 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Copy icu38* files instead of icu36* files.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- 9:58 AM Changeset in webkit [35452] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-30 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Alexey Proskuryakov.
Fix compilation without multi-threading support.
- kjs/collector.cpp: (KJS::Heap::Heap):
- 9:37 AM Changeset in webkit [35451] by
-
- 1 edit1 add in trunk/JavaScriptCore
2008-07-30 Anders Carlsson <andersca@apple.com>
Add WebKitAvailability.h forwarding header.
- ForwardingHeaders/JavaScriptCore/WebKitAvailability.h: Added.
- 9:24 AM Changeset in webkit [35450] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-30 Anders Carlsson <andersca@apple.com>
Fix the else.
- API/WebKitAvailability.h:
- 9:22 AM Changeset in webkit [35449] by
-
- 3 edits in trunk/JavaScriptCore
2008-07-30 Anders Carlsson <andersca@apple.com>
- API/WebKitAvailability.h: Fix Windows (and other non-Mac builds).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add WebKitAvailability.h to the project.
- 9:17 AM Changeset in webkit [35448] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-30 Anders Carlsson <andersca@apple.com>
One step closer towards fixing the Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Make sure to copy WebKitAvailability.h
- 8:24 AM Changeset in webkit [35447] by
-
- 2 edits in trunk/WebKit/gtk
Typo in comment for bracer ending block
https://bugs.webkit.org/show_bug.cgi?id=20205
- webkit/webkitprivate.cpp: Typo fix in comment for the brace
that ends the WebKit namespace; WebCore -> WebKit
Reviewed by Sam.
- 7:42 AM Changeset in webkit [35446] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-29 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 20209: Atomize constant strings
<https://bugs.webkit.org/show_bug.cgi?id=20209>
Prevents significant performance degradation seen when a script contains multiple
identical strings that are used as keys to identify properties on objects.
No performance change on SunSpider.
- kjs/nodes.cpp: Atomize constant strings.
- 1:00 AM Changeset in webkit [35445] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/6111648> JavaScript exceptions fail if the scope chain includes the global object
Reviewed by Alexey Proskuryakov.
In an attempt to remove the branch I just added to KJS::depth I
used the existence of a Variable Object at a point in the scope
chain as an indicator of function or global scope activation.
However this assumption results in incorrect behaviour if the
global object is injected into the scope chain with 'with'.
- 12:09 AM Changeset in webkit [35444] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geoff Garen.
Don't call JSGarbageCollect() on a released context.
- API/testapi.c: (main):
Jul 29, 2008:
- 11:14 PM Changeset in webkit [35443] by
-
- 2 edits in trunk/WebCore
2008-07-29 Kevin Calhoun <kcalhoun@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6060647> Adopt QTMovieOpenForPlaybackAttribute flag
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
- 11:05 PM Changeset in webkit [35442] by
-
- 15 edits in trunk
Reviewed by Geoff Garen.
Implement JSContextGroup APIs to make concurrent execution possible for
JavaScriptCore clients.
This changes the behavior of JSGlobalContextCreate(), so that it now uses a private context
group for each context, making JSlock implicit locking unnecessary.
- API/JSContextRef.h:
- API/JSContextRef.cpp: (JSContextGroupCreate): (JSContextGroupRetain): (JSContextGroupRelease): (JSGlobalContextCreate): (JSGlobalContextCreateInGroup): (JSGlobalContextRelease): (JSContextGetGroup): Added new methods. JSGlobalContextCreate() calls JSGlobalContextCreateInGroup() now.
- API/APICast.h: (toJS): (toRef): Added converters for JSContextGroupRef.
- API/JSBase.cpp: (JSGarbageCollect): JSGarbageCollect(0) is now a no-op, and the passed in context is actually used.
- API/JSBase.h: Aded a typedef for JSContextGroupRef. Updated documentation for JSGarbageCollect().
- JavaScriptCore.exp: Removed JSGlobalData::sharedInstance().
- kjs/JSGlobalData.cpp:
- kjs/JSGlobalData.h: Removed support for JSGlobalData shared instance. JSGlobalData::isSharedInstance member variable still remains, to be deleted in a followup patch.
- kjs/JSLock.cpp: (KJS::JSLock::JSLock): Disabled JSLock, to be deleted in a follow-up patch.
- kjs/collector.cpp: (KJS::Heap::markOtherThreadConservatively): Removed an assertion that referenced JSGlobalData::sharedInstance.
- kjs/collector.h: Made Heap destructor public, so that JSContextRelease can use it.
JavaScriptGlue:
- JSRun.cpp: (JSRun::JSRun):
- JSUtils.cpp: (getThreadGlobalExecState): Changed JavaScriptGlue to use a JSGlobalData of its own, now that there is no shared instance.
- 11:02 PM Changeset in webkit [35441] by
-
- 2 edits in trunk/WebCore
2008-07-29 Kevin Calhoun <kcalhoun@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6031021> Make standalone video render more like the quicktime plugin to improve performance
For standalone video, use QTMovieView to draw.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): Moved nil checks to setUpVideoRendering. Associate the QTMovieView with the WebCoreMovieObserver. If we're in a media document, allow QTMovieView to render in its default mode; otherwise tell it to draw synchronously. (WebCore::MediaPlayerPrivate::detachQTMovieView): Set the WebCoreMovieObserver's view to nil. (WebCore::MediaPlayerPrivate::createQTVideoRenderer): Nil check is now in setUpVideoRendering, which is the only caller of this. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Added nil checks. Call createQTMovieView for media documents. (WebCore::MediaPlayerPrivate::tearDownVideoRendering): Call detachQTMovieView if a QTMovieView exists. (WebCore::MediaPlayerPrivate::setRect): Call setFrame on the QTMovieView if necessary. (-[WebCoreMovieObserver menuForEventDelegate:]): Added. Returns the frame view's menu. (-[WebCoreMovieObserver setView:]): Added.
- 10:55 PM Changeset in webkit [35440] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Geoff Garen.
Fix a leak of ThreadRegistrar objects.
As the heap is usually deleted when registered threads still exist, ThreadSpecific doesn't
have a chance to clean up per-thread object. Switched to native pthread calls, storing a
plain pointer that doesn't require cleanup.
- kjs/collector.cpp: (KJS::PlatformThread::PlatformThread): (KJS::Heap::Thread::Thread): (KJS::Heap::Heap): (KJS::Heap::~Heap): (KJS::Heap::registerThread): (KJS::Heap::unregisterThread):
- kjs/collector.h:
- 10:52 PM Changeset in webkit [35439] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20169
Memory allocated with fastMalloc is freed with delete
- VM/JSPropertyNameIterator.cpp: (KJS::JSPropertyNameIterator::invalidate): Free the array properly. (KJS::JSPropertyNameIterator::~JSPropertyNameIterator): Delete the array by calling invalidate().
- 10:42 PM Changeset in webkit [35438] by
-
- 7 edits in trunk/WebCore
2008-07-29 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/6073372> Move built-in controls below <video> element for standalone media documents
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added -webkit-full-page-media pseudo class.
- css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoFullPageMedia.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added case to apply PseudoFullPageMedia for elements in a full page media document.
- css/html4.css: Added rule to shift control panel down for video in standalone media documents.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::lowestPosition): Added implementation that takes the controls into account. This makes sure that scrollbars on the page will account for controls not directly contained in the RenderMedia. (WebCore::RenderMedia::rightmostPosition): ditto. (WebCore::RenderMedia::leftmostPosition): ditto.
- rendering/RenderMedia.h:
- 10:34 PM Changeset in webkit [35437] by
-
- 3 edits in trunk/WebKit/wx
Reviewed by Sam Weinig.
Add tooltip support to the wx port.
- 10:00 PM Changeset in webkit [35436] by
-
- 4 edits in trunk/WebKit/win
2008-07-29 Alice Liu <alice.liu@apple.com>
Reviewed by Geoff Garen.
Fix WebDocumentLoader leak on Windows.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createDocumentLoader):
- WebDocumentLoader.cpp: (WebDocumentLoader::create):
- WebDocumentLoader.h:
- 7:39 PM Changeset in webkit [35435] by
-
- 29 edits12 adds in trunk
WebCore:
2008-07-29 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
<rdar://problem/6084585> Investigate upload progress events.
- Add progress notifications for data being sent via a ResourceHandle.
- Add XMLHttpRequestUpload support.
Upload notifications only work on the Mac right now as the CFNetwork API
on windows does not expose enough information.
Tests: http/tests/xmlhttprequest/upload-onload-event.html
http/tests/xmlhttprequest/upload-onloadstart-event.html
http/tests/xmlhttprequest/upload-onprogress-event.html
http/tests/xmlhttprequest/upload-progress-events.html
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSEventTargetBase.cpp: (WebCore::toJS):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: Added. (WebCore::JSXMLHttpRequestUpload::mark): (WebCore::JSXMLHttpRequestUpload::onabort): (WebCore::JSXMLHttpRequestUpload::setOnabort): (WebCore::JSXMLHttpRequestUpload::onerror): (WebCore::JSXMLHttpRequestUpload::setOnerror): (WebCore::JSXMLHttpRequestUpload::onload): (WebCore::JSXMLHttpRequestUpload::setOnload): (WebCore::JSXMLHttpRequestUpload::onloadstart): (WebCore::JSXMLHttpRequestUpload::setOnloadstart): (WebCore::JSXMLHttpRequestUpload::onprogress): (WebCore::JSXMLHttpRequestUpload::setOnprogress): (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener): (WebCore::JSXMLHttpRequestUpload::dispatchEvent):
- dom/EventTarget.cpp: (WebCore::EventTarget::toXMLHttpRequestUpload):
- dom/EventTarget.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didSendData):
- loader/ResourceLoader.h:
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didSendData):
- loader/SubresourceLoader.h:
- loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didSendData):
- page/DOMWindow.idl:
- platform/network/FormData.cpp: (WebCore::FormData::FormData):
- platform/network/FormData.h: (WebCore::FormData::alwaysStream): (WebCore::FormData::setAlwaysStream):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didSendData):
- platform/network/mac/FormDataStreamMac.h:
- platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDataMap): (WebCore::getStreamResourceHandleMap): (WebCore::associateStreamWithResourceHandle): (WebCore::disassociateStreamWithResourceHandle): (WebCore::DidSendDataCallbackData::DidSendDataCallbackData): (WebCore::performDidSendDataCallback): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::formRead): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::upload): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::networkError): (WebCore::XMLHttpRequest::abortError): (WebCore::XMLHttpRequest::didSendData):
- xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::optionalUpload):
- xml/XMLHttpRequest.idl:
- xml/XMLHttpRequestUpload.cpp: Added. (WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload): (WebCore::XMLHttpRequestUpload::addEventListener): (WebCore::XMLHttpRequestUpload::removeEventListener): (WebCore::XMLHttpRequestUpload::dispatchEvent): (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent): (WebCore::XMLHttpRequestUpload::dispatchAbortEvent): (WebCore::XMLHttpRequestUpload::dispatchErrorEvent): (WebCore::XMLHttpRequestUpload::dispatchLoadEvent): (WebCore::XMLHttpRequestUpload::dispatchLoadStartEvent): (WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
- xml/XMLHttpRequestUpload.h: Added. (WebCore::XMLHttpRequestUpload::create): (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload): (WebCore::XMLHttpRequestUpload::associatedXMLHttpRequest): (WebCore::XMLHttpRequestUpload::disconnectXMLHttpRequest): (WebCore::XMLHttpRequestUpload::setOnAbortListener): (WebCore::XMLHttpRequestUpload::onAbortListener): (WebCore::XMLHttpRequestUpload::setOnErrorListener): (WebCore::XMLHttpRequestUpload::onErrorListener): (WebCore::XMLHttpRequestUpload::setOnLoadListener): (WebCore::XMLHttpRequestUpload::onLoadListener): (WebCore::XMLHttpRequestUpload::setOnLoadStartListener): (WebCore::XMLHttpRequestUpload::onLoadStartListener): (WebCore::XMLHttpRequestUpload::setOnProgressListener): (WebCore::XMLHttpRequestUpload::onProgressListener): (WebCore::XMLHttpRequestUpload::eventListeners): (WebCore::XMLHttpRequestUpload::refEventTarget): (WebCore::XMLHttpRequestUpload::derefEventTarget):
- xml/XMLHttpRequestUpload.idl: Added.
LayoutTests:
2008-07-29 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
<rdar://problem/6084585> Investigate upload progress events
- fast/dom/Window/window-properties-expected.txt:
- http/tests/xmlhttprequest/upload-onload-event-expected.txt: Added.
- http/tests/xmlhttprequest/upload-onload-event.html: Added.
- http/tests/xmlhttprequest/upload-onloadstart-event-expected.txt: Added.
- http/tests/xmlhttprequest/upload-onloadstart-event.html: Added.
- http/tests/xmlhttprequest/upload-onprogress-event-expected.txt: Added.
- http/tests/xmlhttprequest/upload-onprogress-event.html: Added.
- http/tests/xmlhttprequest/upload-progress-events-expected.txt: Added.
- http/tests/xmlhttprequest/upload-progress-events.html: Added.
- platform/win/Skipped: Skip new tests on windows where the feature is not implemented yet.
- 4:33 PM Changeset in webkit [35434] by
-
- 2 edits in trunk/WebCore
2008-07-29 Maxime Britto <britto@apple.com>
Reviewed by Darin.
<rdar://problem/6095023> "When pan-scrolling, mouse click on hyperlink stop the pan-Scroll but follow the link after that."
With this patch we now stop the pan scroll and swallow the event to prevent any following action.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): If we were in pan scrolling mode we no longer just stop the pan scroll and continue with the function, we now stop and return true to attest that we swallowed the event.
- 3:59 PM Changeset in webkit [35433] by
-
- 3 edits2 adds in trunk
2008-07-29 Maxime Britto <britto@apple.com>
Reviewed by adele.
Test: fast/events/autoscroll-in-textfield.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): reverted a bad change introduced in r35244 nb:the test case introduced in r35244 is still working.
2008-07-29 Maxime Britto <britto@apple.com>
Reviewed by adele.
This test verifies that the autoscroll works within textfields.
- fast/events/autoscroll-in-textfield-expected.txt: Added.
- fast/events/autoscroll-in-textfield.html: Added.
- 3:47 PM Changeset in webkit [35432] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to fix the Qt build.
- wtf/ThreadingQt.cpp: Add the extra argument to createThread.
- 3:38 PM Changeset in webkit [35431] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
- update results for console.group and console.groupEnd
- fast/dom/Window/window-properties-expected.txt:
- 1:58 PM Changeset in webkit [35430] by
-
- 3 edits in trunk/WebKit/mac
Tweak to the build fix to keep Dan happy.
- 1:28 PM Changeset in webkit [35429] by
-
- 6 edits2 adds in trunk
WebCore:
2008-07-29 Adele Peterson <adele@apple.com>
Reviewed by Sammy Weinig.
Fix for <rdar://problem/6103024>
When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video
Test: media/video-click-dlbclick-standalone.html
- loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler): For standalone media documents, match the default Quicktime plugin behavior to allow clicking and double-clicking to pause and play the media.
- loader/MediaDocument.h: Added defaultEventHandler.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler): Return early if the event has been handled.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Correct what was probably a typo. Instead of "event->defaultHandled()", it is supposed to be "event->setDefaultHandled()". (WebCore::MediaControlPlayButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): ditto. (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): ditto.
LayoutTests:
2008-07-29 Adele Peterson <adele@apple.com>
Reviewed by Sammy Weinig.
Test for <rdar://problem/6103024>
When a QT movie is loaded directly in the browser, I can't pause it by single-clicking on the video
- media/video-click-dlbclick-standalone-expected.txt: Added.
- media/video-click-dlbclick-standalone.html: Added.
- 1:13 PM Changeset in webkit [35428] by
-
- 3 edits in trunk/WebKit/mac
Build fix.
- 11:55 AM Changeset in webkit [35427] by
-
- 7 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com
Test: fast/overflow/float-in-relpositioned.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): Add this block's relative offset to floats' and positioned objects' lowest position. (WebCore::RenderBlock::rightmostPosition): Ditto. (WebCore::RenderBlock::leftmostPosition): Ditto.
- rendering/RenderBox.cpp: (WebCore::RenderBox::lowestPosition): Removed redundant test. (WebCore::RenderBox::rightmostPosition): Ditto. (WebCore::RenderBox::leftmostPosition): Ditto.
LayoutTests:
Reviewed by Dave Hyatt.
- test, updated test and results for <rdar://problem/6059648> Some content not visible when the window is short at courtneyalbright.com
- fast/overflow/float-in-relpositioned.html: Added.
- fast/repaint/containing-block-position-change.html: Changed to avoid a full repaint due to a scroll bar appearing.
- platform/mac/fast/clip/015-expected.txt:
- platform/mac/fast/overflow/float-in-relpositioned-expected.checksum: Added.
- platform/mac/fast/overflow/float-in-relpositioned-expected.png: Added.
- platform/mac/fast/overflow/float-in-relpositioned-expected.txt: Added.
- platform/mac/fast/repaint/clipped-relative-expected.txt:
- 11:51 AM Changeset in webkit [35426] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6048566> Repaint original element's position, not its offset position
Test: fast/repaint/layout-state-relative.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): Changed the LayoutState-enabled code path to account for the object's relative offset. (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.
LayoutTests:
Reviewed by Dave Hyatt.
- repaint test for <rdar://problem/6048566> Repaint original element's position, not its offset position
- fast/repaint/layout-state-relative.html: Added.
- platform/mac/fast/repaint/layout-state-relative-expected.checksum: Added.
- platform/mac/fast/repaint/layout-state-relative-expected.png: Added.
- platform/mac/fast/repaint/layout-state-relative-expected.txt: Added.
- 11:51 AM Changeset in webkit [35425] by
-
- 2 edits in trunk/JavaScriptCore
Change Vector::find to return an index instead of an iterator
Indices are more natural than iterators when working with Vector.
Reviewed by John Sullivan.
- wtf/Vector.h: (WTF::Vector::find): Changed to iterate the Vector manually and return the index of the found item, rather than an iterator. When the item could not be found, we return WTF::notFound.
- 11:28 AM Changeset in webkit [35424] by
-
- 3 adds in trunk/LayoutTests/platform/mac/fast/css/variables/alternate-syntax
- 11:27 AM Changeset in webkit [35423] by
-
- 1 edit5 adds in trunk/LayoutTests
2008-07-29 David Hyatt <hyatt@apple.com>
Add a layout test for using multiple variable declaration blocks in a single style rule.
- fast/css/variables/alternate-syntax/multiple-blocks-test.html: Added.
- fast/css/variables/multiple-blocks-test.html: Added.
- platform/mac/fast/css/variables/multiple-blocks-test-expected.checksum: Added.
- platform/mac/fast/css/variables/multiple-blocks-test-expected.png: Added.
- platform/mac/fast/css/variables/multiple-blocks-test-expected.txt: Added.
- 11:10 AM Changeset in webkit [35422] by
-
- 3 edits in trunk/WebKit/win
Export detachThread
Reviewed by Geoff Garen.
- WebKit.vcproj/WebKit.def:
- WebKit.vcproj/WebKit_debug.def:
- 11:04 AM Changeset in webkit [35421] by
-
- 10 edits in trunk/WebCore
Fixed Bug 19158: Inspector should support console.group/console.groupEnd
Reviewed by Tim Hatcher and Adam Roben.
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::group): Added.
- page/Console.cpp: (WebCore::Console::group): Added. (WebCore::Console::groupEnd): Added.
- page/Console.h: (WebCore::):
- page/Console.idl: Added group/groupEnd.
- page/InspectorController.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::InspectorController::InspectorController): Added m_groupLevel. (WebCore::InspectorController::addMessageToConsole): Added groupLevel argument. (WebCore::InspectorController::startGroup): Increments m_groupLevel by one and calls js function if needed. (WebCore::InspectorController::endGroup): Decrements m_groupLevel by one and calls js function if needed. (WebCore::InspectorController::addScriptConsoleMessage): Added groupLevel argument. (WebCore::InspectorController::didCommitLoad): Resets m_groupLevel.
- page/InspectorController.h:
- page/inspector/Console.js: (WebInspector.Console): Added groupLevel and currentGroup topGroup. (WebInspector.Console.addMessage): Calls addMessage method in the currentGroup. (WebInspector.Console.startGroup): Added. (WebInspector.Console.endGroup): Added. (WebInspector.Console.clearMessages): Resets groupLevel and currentGroup. (WebInspector.ConsoleMessage): Added groupLevel property. (WebInspector.ConsoleMessage.MessageLevel.GroupTitle): Added. (WebInspector.ConsoleGroup): Added. (WebInspector.ConsoleGroup.addMessage): Adds console message to group. (WebInspector.ConsoleGroup._titleClicked): Adds "collapsed" style class.
- page/inspector/inspector.css:
- page/inspector/inspector.js: (WebInspector.startGroupInConsole): Calls console.startGroup (WebInspector.endGroupInConsole): Calls console.endGroup
- 9:23 AM Changeset in webkit [35420] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- wtf/ThreadingWin.cpp: (WTF::setThreadName): Move a misplaced assertion to here... (WTF::createThread): ...from here.
- 9:11 AM Changeset in webkit [35419] by
-
- 15 edits in trunk
Add support for setting thread names on Windows
Add support for setting thread names on Windows
These thread names make it much easier to identify particular threads
in Visual Studio's Threads panel.
WTF::createThread now takes a const char* representing the thread's
name. On Windows, we throw a special exception to set this string as
the thread's name. Other platforms do nothing with this name for now.
Reviewed by Anders Carlsson.
- JavaScriptCore.exp: Export the new version of createThread that takes 3 arguments (the old one continues to be exported for backward compatibility).
- wtf/Threading.h: Add a threadName argument to createThread.
- wtf/ThreadingGtk.cpp: (WTF::createThread):
- wtf/ThreadingNone.cpp: (WTF::createThread): Updated for function signature change.
- wtf/ThreadingPthreads.cpp: (WTF::createThread): Updated for function signature change. We keep around the old 2-argument version of createThread for backward compatibility.
- wtf/ThreadingWin.cpp: (WTF::setThreadName): Added. This function's implementation came from MSDN. (WTF::initializeThreading): Set the name of the main thread. (WTF::createThread): Call setThreadName. We keep around the old 2-argument version of createThread for backward compatibility.
WebCore:
Add names for WebCore's threads
Reviewed by Anders Carlsson.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::start):
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::start): Pass in names to createThread.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::runLoaderThread): (WebCore::ResourceHandle::loaderRunLoop): Changed to use WTF::createThread.
WebKit/win:
Export the new version of createThread
Reviewed by Anders Carlsson.
- WebKit.vcproj/WebKit.def:
- WebKit.vcproj/WebKit_debug.def: Also moved the old version of createThread into the deprecated section.
- 1:16 AM Changeset in webkit [35418] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by Oliver Hunt.
Store UString::Rep::isStatic bit in identifierTable pointer instead of reportedCost for
slightly nicer code and a 0.5% SunSpider improvement.
Jul 28, 2008:
- 5:37 PM Changeset in webkit [35417] by
-
- 3 edits in trunk/WebCore
2008-07-28 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Based on a patch from Dimcho Balev.
Windows part of
https://bugs.webkit.org/show_bug.cgi?id=18676
<rdar://problem/6106578>
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs
- plugins/PluginStream.cpp: (WebCore::PluginStream::wantsAllStreams):
- plugins/PluginStream.h:
- 4:38 PM Changeset in webkit [35416] by
-
- 11 edits2 adds in branches/XBL2
WebCore:
2008-07-28 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 20196: [XBL] Re-enable CSS binding attachment
- Re-enable legacy CSS attachment code.
- Add XBLBindingManager bits so that it also creates / removes the required bindings.
- Renamed '-webkit-binding' property to 'binding' (the name in the specification)
Test: fast/xbl/xbl-css-attachment.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::removeBindings): Added remove bindings and the style information associated.
- css/CSSStyleSelector.h:
- dom/Element.cpp: (WebCore::Element::hasBinding): Update the style as it will cause binding updates.
- rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::BindingURI::BindingURI):
- rendering/style/RenderStyle.h:
- xbl/XBLBindingManager.cpp: (WebCore::XBLBindingManager::addBinding): Limit to one binding per element with the same uri as the CSS attachment code can be hit twice.
LayoutTests:
2008-07-28 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Test case for bug 20196: [XBL] Re-enable CSS binding attachment
- fast/xbl/xbl-css-attachment-expected.txt: Added.
- fast/xbl/xbl-css-attachment.html: Added.
- 4:34 PM Changeset in webkit [35415] by
-
- 6 edits4 adds in trunk
WebCore:
2008-07-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Test: security/autocomplete-cleared-on-back.html
<rdar://problem/6093281> - autocomplete="off" should work when going back
Taken care of in two ways:
1 - Listening for the page cache notification to clear the form, in cases where the page
is being restored from the page cache
2 - Not saving such form elements when doing the normal "save state" to a history item,
for cases with no page cache
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::parseMappedAttribute): (WebCore::HTMLFormElement::didRestoreFromCache): (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
- html/HTMLFormElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::saveState): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::needsCacheCallback): (WebCore::HTMLInputElement::registerForCacheCallbackIfNeeded): Only register if the type or attribute indicate we should. (WebCore::HTMLInputElement::unregisterForCacheCallbackIfNeeded): Only unregister if both the type and attribute are clear of needing registration. (WebCore::HTMLInputElement::didRestoreFromCache): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
- html/HTMLInputElement.h:
LayoutTests:
2008-07-28 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
<rdar://problem/6093281> - autocomplete="off" should work when going back
- security/autocomplete-cleared-on-back-expected.txt: Added.
- security/autocomplete-cleared-on-back.html: Added.
- security/resources: Added.
- security/resources/autocomplete-cleared-on-back2.html: Added.
- 3:50 PM Changeset in webkit [35414] by
-
- 14 edits16 adds in trunk
2008-07-28 David Hyatt <hyatt@apple.com>
Add support for CSS variable declaration blocks.
Reviewed by Sam
Added tests in fast/css/variables.
- css/CSSGrammar.y:
- css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::isMutableStyleDeclaration):
- css/CSSParser.cpp: (WebCore::CSSParser::addVariableDeclarationBlock):
- css/CSSParser.h:
- css/CSSProperty.cpp: (WebCore::CSSProperty::cssText):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration): (WebCore::CSSStyleSelector::resolveVariablesForDeclaration):
- css/CSSStyleSelector.h:
- css/CSSValueList.h: (WebCore::CSSValueList::isValueList):
- css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::getVariableValue): (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::addParsedVariable): (WebCore::CSSVariablesDeclaration::getParsedSimpleVariable): (WebCore::CSSVariablesDeclaration::getParsedComplexVariable):
- css/CSSVariablesDeclaration.h: (WebCore::CSSVariablesDeclaration::create):
- css/StyleBase.cpp: (WebCore::StyleBase::cssText):
- css/StyleBase.h: (WebCore::StyleBase::isValueList): (WebCore::StyleBase::isMutableStyleDeclaration):
- 3:46 PM Changeset in webkit [35413] by
-
- 4 edits4 adds in trunk
../../../../../../LayoutTests:
2008-07-28 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
<rdar://problem/6098335>
https://bugs.webkit.org/show_bug.cgi?id=20150
Add tests.
- http/tests/xmlhttprequest/resources/forbidden.txt: Added.
- http/tests/xmlhttprequest/resources/redirect.php: Added.
- http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html: Added.
../../../../../../WebCore:
2008-07-28 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
<rdar://problem/6098335>
https://bugs.webkit.org/show_bug.cgi?id=20150
Handle willSendRequest correctly.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::willSendRequest): Make sure to keep the previous URL around so we know when to call willSendRequest.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::processSyncLoadResults): Abort if we don't have access to the response URL.
(WebCore::XMLHttpRequest::willSendRequest):
Dispatch a network error if we can't access the new URL.
- 2:15 PM Changeset in webkit [35412] by
-
- 4 edits1 add in branches/XBL2/WebCore
2008-07-28 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 20171: [XBL] Add <binding> 'element' attribute
- DerivedSources.make: Add attrs file.
- GNUmakefile.am: Ditto.
- WebCore.pro: Ditto.
- xbl/xblattrs.in: Added.
- 1:04 PM Changeset in webkit [35411] by
-
- 25 edits in trunk
2008-07-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Renamed "ConstructTypeNative" => "ConstructTypeHost".
WebCore:
2008-07-28 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Renamed "ConstructTypeNative" => "ConstructTypeHost".
- 12:23 PM Changeset in webkit [35410] by
-
- 2 edits in trunk
Add radar number
- 12:20 PM Changeset in webkit [35409] by
-
- 10 edits in trunk
../../../../../../WebCore:
2008-07-28 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Based on a patch by Dimcho Balev.
https://bugs.webkit.org/show_bug.cgi?id=18676
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs
- bridge/npapi.h: Add new enum values.
- loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): When the plug-in indicates that it wants all streams to be delivered, don't cancel the stream if an error occurs.
- loader/NetscapePlugInStreamLoader.h: (WebCore::NetscapePlugInStreamLoaderClient::wantsAllStreams): Add new client method.
../../../../../../WebKit/mac:
2008-07-28 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Based on a patch by Dimcho Balev.
https://bugs.webkit.org/show_bug.cgi?id=18676
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs
- Plugins/WebBaseNetscapePluginStream.h: Add NPP_GetValue pointer.
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream setPlugin:]): Initialize NPP_GetValue.
(-[WebBaseNetscapePluginStream wantsAllStreams]):
Call NPP_GetValue.
- Plugins/WebPlugInStreamLoaderDelegate.h:
- WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
- WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: (WebNetscapePlugInStreamLoaderClient::wantsAllStreams): Implement this and call down to the stream.
- 9:59 AM Changeset in webkit [35408] by
-
- 2 edits in trunk/WebKit/mac
2008-07-28 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
<rdar://problem/6105529>
https://bugs.webkit.org/show_bug.cgi?id=19659
Turning off plugins causes crash
When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
end up in a state where they don't have an event handler. Because of this, we need to
check that the plug-in has been started before calling the event handler.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView handleMouseMoved:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView scrollWheel:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView flagsChanged:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView inputContext]):
- 12:37 AM Changeset in webkit [35407] by
-
- 2 edits in trunk/WebKitSite
2008-07-28 Robert Blaut <webkit@blaut.biz>
Reviewed by Mark Rowe.
Fix for bug: Website provides no guidance on debugging
<https://bugs.webkit.org/show_bug.cgi?id=3643>
- building/debug.html: added info about Xcode Debugging Guide.
Jul 27, 2008:
- 3:03 PM Changeset in webkit [35406] by
-
- 5 edits6 adds in trunk
WebCore:
2008-07-27 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20176
querySelectorAll id optimization no longer working
Turn the querySelector/querySelectorAll id optimization back on
for only strict and almost strict mode. In quirks mode, the optimiztion
won't work as the id match is not case sensitive.
Tests: fast/dom/SelectorAPI/caseID-almost-strict.html
fast/dom/SelectorAPI/caseID-strict.html
fast/dom/SelectorAPI/caseID.html
- dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):
- dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
- dom/SelectorNodeList.h:
LayoutTests:
2008-07-27 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Tests for https://bugs.webkit.org/show_bug.cgi?id=20176
querySelectorAll id optimization no longer working
- fast/dom/SelectorAPI/caseID-almost-strict-expected.txt: Added.
- fast/dom/SelectorAPI/caseID-almost-strict.html: Added.
- fast/dom/SelectorAPI/caseID-expected.txt: Added.
- fast/dom/SelectorAPI/caseID-strict-expected.txt: Added.
- fast/dom/SelectorAPI/caseID-strict.html: Added.
- fast/dom/SelectorAPI/caseID.html: Added.
- 2:34 PM Changeset in webkit [35405] by
-
- 2 edits in trunk/WebKit/qt
Fix Qt build failure.
- Api/qwebframe.h: (QWebFrame::setScrollOffset): Make argument const.
- 2:27 PM Changeset in webkit [35404] by
-
- 3558 edits in trunk/LayoutTests
Set svn:mime-type to image/png.
- 2:08 PM Changeset in webkit [35403] by
-
- 9 edits3 adds in trunk
WebCore:
2008-07-21 Anatoli Papirovski <apapirovski@mac.com>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=14346
Modified the css parser:
- not to fail when closing braces are not found for a declaration at the end of the file
- not to accept "!important fail" as valid
- to keep accepting @import when it comes after invalid @ rules
- not to drop the whole @media block when there's an error before the closing brace + some other minor css parsing revisions.
CSSGrammar.y tweaked by David Kilzer to fix Tiger builds.
- css/CSSGrammar.y:
LayoutTests:
2008-07-21 Anatoli Papirovski <apapirovski@mac.com>
Reviewed by Dave Hyatt.
Updated layout CSS2.1 test suite tests related to css parsing:
https://bugs.webkit.org/show_bug.cgi?id=14346
- platform/mac/css2.1/t040105-import-01-b-expected.checksum:
- platform/mac/css2.1/t040105-import-01-b-expected.png:
- platform/mac/css2.1/t040105-import-01-b-expected.txt:
- platform/mac/css2.1/t0402-syntax-05-f-expected.checksum:
- platform/mac/css2.1/t0402-syntax-05-f-expected.png:
- platform/mac/css2.1/t0402-syntax-05-f-expected.txt:
- platform/mac/css2.1/t0402-syntax-06-f-expected.checksum:
- platform/mac/css2.1/t0402-syntax-06-f-expected.png:
- platform/mac/css2.1/t0402-syntax-06-f-expected.txt:
- 3:43 AM Changeset in webkit [35402] by
-
- 5 edits in trunk/WebCore
2008-07-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Eric Seidel.
Use --outputDir instead of --output when invoking make_names.pl
There's no option named "output" in make_names.pl
- GNUmakefile.am:
- WebCore.pro:
- DerivedSources.make: Remove --output. Not necessary here.
- bindings/scripts/generate-bindings.pl: Rename --outputdir to --outputDir for consistency with make_names.pl
- 3:28 AM HackingGtk edited by
- (diff)
Jul 26, 2008:
- 11:56 PM Changeset in webkit [35401] by
-
- 3 edits in trunk/LayoutTests
2008-07-26 Mark Rowe <mrowe@apple.com>
Update some layout test results.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/domListEnumeration-expected.txt:
- 11:08 PM Changeset in webkit [35400] by
-
- 2 edits in trunk/WebKitSite
2008-07-26 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Oliver Hunt.
Update the Squirrelfish bytecode documentation.
- specs/squirrelfish-bytecode.html:
- 11:02 PM Changeset in webkit [35399] by
-
- 2 edits in trunk/WebCore
2008-07-26 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=18694
[CAIRO] Problem with rotation in a given matrix in SVG
Changed values given to AffineTransform.
- platform/graphics/cairo/AffineTransformCairo.cpp: (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix):
- 11:00 PM Changeset in webkit [35398] by
-
- 3 edits in trunk
2008-07-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Mark Rowe.
Copy the way Gtk detects jpeglib. Hinted by Wouter Bolsterlee.
[Gtk] Improve detection jpeglib
https://bugs.webkit.org/show_bug.cgi?id=17865
- GNUmakefile.am:
- configure.ac:
- 10:59 PM Changeset in webkit [35397] by
-
- 3 edits in trunk/WebKit/qt
2008-07-26 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=20010
[Qt] Add API access to scrolling
- Api/qwebframe.cpp: Added access to a frame scroll offset. (QWebFrame::scroll): (QWebFrame::scrollOffset): (QWebFrame::setScrollOffset):
- Api/qwebframe.h:
- 10:58 PM Changeset in webkit [35396] by
-
- 3 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
- update test and expected results for attributes added to HTMLFormElement and HTMLSelectElement.
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/resources/domListEnumeration.js:
- 10:53 PM Changeset in webkit [35395] by
-
- 2 edits in trunk/WebKitSite
2008-07-26 Robert Blaut <webkit@blaut.biz>
Reviewed by Eric Seidel.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=19712>
Corrected validation errors in main.css file.
- css/main.css:
- 10:52 PM Changeset in webkit [35394] by
-
- 2 edits in trunk/WebCore
2008-07-26 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Mark Rowe.
Call curl_global_cleanup() to release resources acquired by curl_global_init()
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::~ResourceHandleManager):
- 10:49 PM Changeset in webkit [35393] by
-
- 2 edits in trunk/WebCore
2008-07-26 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
Reviewed by Simon Hausmann.
Bug 18938: [GTK] Plugins not resized
https://bugs.webkit.org/show_bug.cgi?id=18938
- plugins/PluginView.cpp: (WebCore::PluginView::setFrameGeometry): When viewing a full-page plugin in unix, geometry changes have to be passed to the plugin.
- 10:44 PM Changeset in webkit [35392] by
-
- 6 edits1 add in trunk/WebCore
2008-07-26 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Adam Roben.
Add console.time/timeEnd.
https://bugs.webkit.org/show_bug.cgi?id=19159
- manual-tests/inspector/console-time.html: Added. Test cases for console.time/timeEnd.
- page/Console.cpp: (WebCore::Console::time): Added. (WebCore::Console::timeEnd): Added.
- page/Console.h:
- page/Console.idl: Added console.time/timeEnd.
- page/InspectorController.cpp: (WebCore::InspectorController::startTiming): Added. (WebCore::InspectorController::stopTiming): Added.
- page/InspectorController.h:
- 10:40 PM Changeset in webkit [35391] by
-
- 3 edits in trunk/WebCore
2008-07-26 Dirk Schulze <vbs85@gmx.de>
Reviewed by Nikolas Zimmermann.
Fixes rendering issues with gradients in SVG/Cairo.
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::boundingRect):
- svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::SVGPaintServerGradient::setup):
- 10:38 PM Changeset in webkit [35390] by
-
- 2 edits in trunk/WebCore
2008-07-26 Dirk Schulze <vbs85@gmx.de>
Reviewed by Nikolas Zimmermann.
Added pattern-support for SVG in Cairo.
- svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::SVGPaintServerPattern::setup):
- 10:32 PM Changeset in webkit [35389] by
-
- 2 edits in trunk/WebKitSite
2008-07-26 Robert Blaut <webkit@blaut.biz>
Reviewed by Alexey Proskuryakov.
Fix for bug: <https://bugs.webkit.org/show_bug.cgi?id=18186>
Added notes about unsupported Visual Studio versions.
- building/tools.html:
- 10:29 PM Changeset in webkit [35388] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-26 Mark Rowe <mrowe@apple.com>
Speculative fix for the wx build.
- JavaScriptCoreSources.bkl: Add JSStaticScopeObject.cpp to the list of source files.
- 10:27 PM Changeset in webkit [35387] by
-
- 2 edits in trunk/WebKit/gtk
2008-07-26 Mark Rowe <mrowe@apple.com>
Build fix. Changes to accommodate newly named/signatured loading methods in WebCore.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
- 10:23 PM Changeset in webkit [35386] by
-
- 3 edits in trunk/WebKit/qt
2008-07-26 Daniel Jalkut <jalkut@red-sweater.com>
Build fix. Adjust to updated WebCore FrameLoader method names & signatures.
- Api/qwebpage.cpp: (QWebPage::triggerAction):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):
- 10:20 PM Changeset in webkit [35385] by
-
- 2 edits in trunk/WebKitSite
2008-07-26 Robert Blaut <webkit@blaut.biz>
Reviewed by Eric Seidel.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=16719>
Removed basic requirements for undetected version of WebKit.
- quality/reporting.html:
- 10:18 PM Changeset in webkit [35384] by
-
- 2 edits in trunk/WebKitSite
2008-07-26 Robert Blaut <webkit@blaut.biz>
Reviewed by Adele Petersen.
Fix for bug 7436: Truncated title on webkit DOM page.
<https://bugs.webkit.org/show_bug.cgi?id=7436>
- projects/dom/index.html: Added basic project informations.
- 10:14 PM Changeset in webkit [35383] by
-
- 2 edits in trunk/WebCore
2008-07-26 Keishi Hattori <casey.hattori@gmail.com>
Reviewed by Adam Roben.
Fixed bug 18540: console.log('multiple', 'strings') quotes all strings after the first
<https://bugs.webkit.org/show_bug.cgi?id=18540>
- page/inspector/Console.js: (WebInspector.ConsoleMessage.prototype._format): String arguments are appended without formatting.
- 10:10 PM Changeset in webkit [35382] by
-
- 2 edits in trunk/WebCore
2008-07-26 Anthony Ricaud <rik24d@gmail.com>
Reviewed by Tim Hatcher.
<https://bugs.webkit.org/show_bug.cgi?id=17589> Line highlighting should last longer
Restore the fade out effect after highlighting.
- page/inspector/SourceFrame.js: Add a class for fade-out effects and sets it at the end of highlighting time.
- 10:08 PM Changeset in webkit [35381] by
-
- 13 edits20 adds in trunk
2008-07-26 Michelangelo De Simone <michelangelo@me.com>
Reviewed by Adele Petersen.
Added the simple willValidate attribute to form controls according to
WebForms 2 spec.
Tests: fast/forms/willvalidate-000.html
fast/forms/willvalidate-001.html
fast/forms/willvalidate-002.html
fast/forms/willvalidate-003.html
fast/forms/willvalidate-004.html
fast/forms/willvalidate-005.html
fast/forms/willvalidate-006.html
fast/forms/willvalidate-007.html
fast/forms/willvalidate-008.html
fast/forms/willvalidate-009.html
- html/HTMLButtonElement.h: Added willValidate(), always false.
- html/HTMLButtonElement.idl: willValidate attribute exposed.
- html/HTMLFieldSetElement.h: Added willValidate(), always false.
- html/HTMLFieldSetElement.idl: willValidate attribute exposed.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willValidate): Added base willValidate() implementation.
- html/HTMLFormControlElement.h: Added willValidate().
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willValidate): Added willValidate(), checks for input type.
- html/HTMLInputElement.h: Added willValidate()
- html/HTMLInputElement.idl: willValidate attribute exposed.
- html/HTMLSelectElement.idl: willValidate attribute exposed.
- html/HTMLTextAreaElement.idl: willValidate attribute exposed.
2008-07-26 Michelangelo De Simone <m.des@mac.com>
Reviewed by Adele Petersen.
Test suite for the willValidate form controls attribute.
- fast/forms/willvalidate-000-expected.txt: Added.
- fast/forms/willvalidate-000.html: Added.
- fast/forms/willvalidate-001-expected.txt: Added.
- fast/forms/willvalidate-001.html: Added.
- fast/forms/willvalidate-002-expected.txt: Added.
- fast/forms/willvalidate-002.html: Added.
- fast/forms/willvalidate-003-expected.txt: Added.
- fast/forms/willvalidate-003.html: Added.
- fast/forms/willvalidate-004-expected.txt: Added.
- fast/forms/willvalidate-004.html: Added.
- fast/forms/willvalidate-005-expected.txt: Added.
- fast/forms/willvalidate-005.html: Added.
- fast/forms/willvalidate-006-expected.txt: Added.
- fast/forms/willvalidate-006.html: Added.
- fast/forms/willvalidate-007-expected.txt: Added.
- fast/forms/willvalidate-007.html: Added.
- fast/forms/willvalidate-008-expected.txt: Added.
- fast/forms/willvalidate-008.html: Added.
- fast/forms/willvalidate-009-expected.txt: Added.
- fast/forms/willvalidate-009.html: Added.
- 9:21 PM Changeset in webkit [35380] by
-
- 2 edits in trunk/WebCore
Build fix.
- 9:10 PM Changeset in webkit [35379] by
-
- 3 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
- platform/win/Skipped: Added fast/text/international/bidi-AN-after-empty-run.html (<rdar://problem/5075790>) and svg/custom/stroke-width-click.svg (<rdar://problem/5539822>).
- platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Updated results for the new way path data is dumped after <http://trac.webkit.org/changeset/34117>.
- 9:07 PM Changeset in webkit [35378] by
-
- 2 edits in trunk/WebCore
Build fix.
- 8:49 PM Changeset in webkit [35377] by
-
- 16 edits in trunk
2008-07-26 Daniel Jalkut <jalkut@red-sweater.com>
Reviewed by Geoff Garen.
Revised the FrameLoader class to clean up a variety of load methods, and hopefully
move things closer to integrating into a smaller set of load methods. To this
end, I renamed many of the overloaded load() methods to have more meaningful and
easier to search names. I added comments to the header file to provide clues as
to how many of the load methods are being used, and how they fit into the loading
process. I suspect that the renamed methods and comments indicating their present
usage will facilitate easier cleanup by myself and others as inspiration strikes.
Updated clients of FrameLoader where necessary to adapt to the new method names and signatures.
Combined the 3 canLoad() methods into a single canLoad which expresses the
intended logic of the 3 with a single method interface.
Removed unnecessary "treatAsLocal" attribute of CachedResource. It was only called from
one place in FrameLoader.cpp, and it derived at initialization time by calling back to FrameLoader.
Removed unused userGesture parameter to one variant of the urlSelected method, and
moved one of the urlSelected methods so that it lives nearer to its overloaded
sibling.
- WebCore.base.exp:
- loader/Cache.cpp: (WebCore::Cache::requestResource):
- loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
- loader/CachedResource.h: (WebCore::CachedResource::errorOccurred):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadFrameRequestWithFormState): (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithNavigationAction): (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::loadItem):
- loader/FrameLoader.h:
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
2008-07-26 Daniel Jalkut <jalkut@red-sweater.com>
Reviewed by Geoff Garen.
Changes to accommodate newly named/signatured loading methods in WebCore.
- Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
- Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
- WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2008-07-26 Matt Lilek <webkit@mattlilek.com>
Reviewed by Geoff Garen.
Changes to accommodate newly named/signatured loading methods in WebCore.
- WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):
- 7:47 PM Changeset in webkit [35376] by
-
- 2 edits in trunk
Add radar number to ChangeLog
- 7:45 PM Changeset in webkit [35375] by
-
- 6 edits8 adds in trunk
WebCore:
2008-07-26 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix https://bugs.webkit.org/show_bug.cgi?id=20122
REGRESSION (r35075-r35110): Cannot enlarge images at Apple Store product page
Use strict parsing when in AlmostStrict mode.
Tests: fast/dom/SelectorAPI/dumpNodeList-almost-strict.html
fast/dom/SelectorAPI/id-fastpath-almost-strict.html
fast/dom/SelectorAPI/id-fastpath-strict.html
- dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):
LayoutTests:
2008-07-26 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix https://bugs.webkit.org/show_bug.cgi?id=20122
REGRESSION (r35075-r35110): Cannot enlarge images at Apple Store product page
- Additionally, fix some errors introduced in old tests.
- fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt: Added.
- fast/dom/SelectorAPI/dumpNodeList-almost-strict.html: Added.
- fast/dom/SelectorAPI/dumpNodeList-expected.txt:
- fast/dom/SelectorAPI/dumpNodeList.html:
- fast/dom/SelectorAPI/id-fastpath-almost-strict-expected.txt: Added.
- fast/dom/SelectorAPI/id-fastpath-almost-strict.html: Added.
- fast/dom/SelectorAPI/id-fastpath-strict-expected.txt: Added.
- fast/dom/SelectorAPI/id-fastpath-strict.html: Added.
- fast/dom/SelectorAPI/resources/id-fastpath-almost-strict.js: Added.
- fast/dom/SelectorAPI/resources/id-fastpath-strict.js: Added.
- fast/dom/SelectorAPI/resources/id-fastpath.js:
- 4:59 PM Changeset in webkit [35374] by
-
- 1 edit2 moves2 adds in trunk/LayoutTests
- move Leopard-only expected failure results back to mac-leopard; these are covered by <rdar://problem/5539818> and <rdar://problem/5539820>.
- platform/mac-leopard/http: Added.
- platform/mac-leopard/http/tests: Added.
- platform/mac-leopard/http/tests/security: Copied from platform/mac/http/tests/security.
- platform/mac-leopard/security: Copied from platform/mac/security.
- platform/mac/http/tests/security: Removed.
- platform/mac/http/tests/security/dataURL: Removed.
- platform/mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
- platform/mac/security: Removed.
- platform/mac/security/block-test-expected.txt: Removed.
- 4:37 PM Changeset in webkit [35373] by
-
- 2 edits1 copy1 move1 add3 deletes in trunk/LayoutTests
Reviewed by Oliver Hunt.
- clean up expected layout test results
- fast/encoding/idn-security-expected.txt: Replaced with LayoutTests/platform/mac/fast/encoding/idn-security-expected.txt, which is the version of the results for platforms that have "newer ICU".
- platform/mac-leopard/Skipped: Added svg/custom/stroke-width-click.svg.
- platform/mac-tiger/fast/encoding: Added.
- platform/mac-tiger/fast/encoding/idn-security-expected.txt: Copied from LayoutTests/fast/encoding/idn-security-expected.txt, as Tiger still needs the "older ICU" version of the results.
- platform/mac/fast/encoding/idn-security-expected.txt: Removed.
- platform/mac/svg/custom/stroke-width-click-expected.checksum: Removed pixel results for a text-only test.
- platform/mac/svg/custom/stroke-width-click-expected.png: Ditto.
- platform/mac/svg/custom/stroke-width-click-expected.txt: Removed platform-specific results for a text-only test.
- 1:04 PM Changeset in webkit [35372] by
-
- 5 edits2 adds in branches/XBL2
WebCore:
2008-07-26 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by David Hyatt.
Bug 20172: [XBL] XBL elements should not be rendered
- Roll out renderer disabling bits as they were bogus.
- Add XBL CSS default rules to html4.css.
Test: fast/xbl/xbl-default-rules.xhtml
- css/html4.css:
- xbl/XBLDocument.h: (WebCore::XBLDocument::XBLDocument):
- xbl/XBLElement.h: (WebCore::XBLElement::isXBLElement):
LayoutTest:
2008-07-26 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by David Hyatt.
Test case for bug 20172: [XBL] XBL elements should not be rendered
- fast/xbl/xbl-default-rules-expected.txt: Added.
- fast/xbl/xbl-default-rules.xhtml: Added.
- 11:59 AM Changeset in webkit [35371] by
-
- 1 edit1 move in trunk/LayoutTests
Rubber-stamped by Nikolas Zimmermann.
- move platform-independent results back to the generic location
- platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Removed.
- svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Copied from LayoutTests/platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt.
- 6:03 AM Changeset in webkit [35370] by
-
- 3 edits in trunk/WebCore
2008-07-25 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Switch off QPainter's anti aliasing when painting the widgets using QStyle
because otherwise the widgets will look blurry and not crisp.
- platform/qt/RenderThemeQt.cpp: (WebCore::StylePainter::StylePainter): (WebCore::StylePainter::~StylePainter):
- platform/qt/RenderThemeQt.h:
Jul 25, 2008:
- 10:18 PM Changeset in webkit [35369] by
-
- 2 edits in trunk/JavaScriptCore
Whoops, forgot to save style correction.
RS=Cameron Zwarich
- 8:52 PM Changeset in webkit [35368] by
-
- 12 edits2 adds in trunk
Bug 19718: Named anonymous functions are slow accessing global variables
<https://bugs.webkit.org/show_bug.cgi?id=19718>
Reviewed by Cameron Zwarich.
To fix this we switch over to an activation-like scope object for
on which we attach the function name property, and add logic to
prevent cross scope assignment to read only properties.
- 7:28 PM Changeset in webkit [35367] by
-
- 2 edits in trunk/JavaScriptCore
On wx/Win, including windows.h in Threading.h causes multiply-defined symbol errors for libjpeg and wx, and also wx needs to include windows.h itself first for wx includes to work right. So until we can find a better solution to this problem on wx, we work around the need to include windows.h here.
- 5:35 PM Changeset in webkit [35366] by
-
- 1 edit1541 copies1 move9 adds7 deletes in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
- moved expected results from platform/mac-leopard to platform/mac. Where the mac baseline differed from the Leopard results, moved the results from mac to mac-tiger.
- 5:34 PM Changeset in webkit [35365] by
-
- 2 edits in trunk/WebKitTools
2008-07-25 Jan Michael Alonzo <jmalonzo@webkit.org>
DRT/Gtk build fix for r35362
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
- 5:00 PM Changeset in webkit [35364] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
- fix crash due to re-entering purgeInactiveFontData() now that it is called by releaseFontData()
Not testable in DumpRenderTree
- platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Added a reentry guard.
- 4:22 PM Changeset in webkit [35363] by
-
- 1 edit in trunk/WebCore/WebCore.base.exp
Need to check this in, too *sigh*
- 4:20 PM Changeset in webkit [35362] by
-
- 10 edits2 adds in trunk
WebCore:
2008-07-25 Brady Eidson <beidson@apple.com>
Reviewed by Sam
Test: security/set-form-autocomplete-attribute.html
Part of the fix for <rdar://problem/6093281> - Improper handling of autocomplete
The autocomplete attribute works on both <form> and <input> elements, but was not
inherited properly when someone asked an <input> if it should autocomplete.
I fixed this up based on the rules in the current WF2 spec so if the <input> element
has its own autocomplete attribute set, it will follow that but otherwise it will
inherit from its parent <form>
- WebCore.base.exp:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): (WebCore::HTMLInputElement::autoComplete): (WebCore::HTMLInputElement::parseMappedAttribute):
- html/HTMLInputElement.h: (WebCore::HTMLInputElement::):
WebKitTools:
2008-07-25 Brady Eidson <beidson@apple.com>
Reviewed by Sam
Add the ability to dump whether-or-not an element should have autocomplete enabled,
from the perspective of the WebKit API
- DumpRenderTree/LayoutTestController.cpp: (elementDoesAutoCompleteForElementWithIdCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows
LayoutTests:
2008-07-25 Brady Eidson <beidson@apple.com>
Reviewed by Sam
Test for autocomplete attribute cleanup
- platform/win/Skipped:
- security/set-form-autocomplete-attribute-expected.txt: Added.
- security/set-form-autocomplete-attribute.html: Added.
- 4:16 PM Changeset in webkit [35361] by
-
- 2 edits in trunk/WebCore
2008-07-25 Wouter Bolsterlee <uws+webkit@xs4all.nl>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=20078
[GTK] Use G_* macros instead of deprecated GTK_* macros in gtk2xtbin.h
- plugins/gtk/gtk2xtbin.h:
- 4:12 PM Changeset in webkit [35360] by
-
- 2 edits in trunk/WebCore
2008-07-25 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
Add workaround for a Leopard bug which causes webarchive/test-xml-stylesheet.xml to fail.
- platform/network/mac/WebCoreURLResponse.mm: (-[NSURLResponse _webcore_MIMEType]):
- 3:43 PM Changeset in webkit [35359] by
-
- 3 edits1 add in trunk/LayoutTests
2008-07-25 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Make the willCacheResponse test more robust.
- http/tests/misc/resources/willCacheResponse-success.html: Added.
- http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
- http/tests/misc/willCacheResponse-delegate-callback.html:
- 3:13 PM Changeset in webkit [35358] by
-
- 1 add in trunk/LayoutTests/fast/css/variables/alternate-syntax/color-hex-test-expected.txt
Add result for hex color test
- 2:42 PM Changeset in webkit [35357] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Anders Carlsson.
- http/tests/misc/acid3.html: Updated test 77 from acidtests.org. Added alert()ing the log when the score is less than 100.
- 1:59 PM Changeset in webkit [35356] by
-
- 1 edit9 adds2 deletes in trunk/LayoutTests
Rubber-stamped by Brady Eidson.
- add missing pixel results and move the render tree results under the platform directory
- platform/mac/svg/dom/SVGRectElement: Added.
- platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.checksum: Added.
- platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Added.
- platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Added.
- platform/mac/webarchive: Added.
- platform/mac/webarchive/loading: Added.
- platform/mac/webarchive/loading/cache-expired-subresource-expected.checksum: Added.
- platform/mac/webarchive/loading/cache-expired-subresource-expected.png: Added.
- platform/mac/webarchive/loading/cache-expired-subresource-expected.txt: Added.
- svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Removed.
- webarchive/loading/cache-expired-subresource-expected.txt: Removed.
- 1:35 PM Changeset in webkit [35355] by
-
- 9 edits4 adds in trunk
<rdar://problem/6084806> AX: REGRESSION: returned line number from TextArea is incorrect
- 1:21 PM Changeset in webkit [35354] by
-
- 4 edits5 adds in trunk
WebCore:
2008-07-25 Jacob Refstrup <jacob.refstrup@hp.com>
Reviewed by mitz.
- fix https://bugs.webkit.org/show_bug.cgi?id=17906 <rdar://problem/5805741> white-space: pre-wrap or -webkit-line-break: after-white-space text can overlap float at end of line
Test: fast/block/float/editable-text-overlapping-float.html
- rendering/RenderBlock.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::skipTrailingWhitespace):
- renamed to reflect usage and removed call to position floats; they only get added (WebCore::RenderBlock::skipLeadingWhitespace):
- renamed to reflect usage (WebCore::RenderBlock::findNextLineBreak):
- use skipTrailingWhitespace at end of line (as before but with new name)
LayoutTests:
2008-07-25 Jacob Refstrup <jacob.refstrup@hp.com>
Reviewed by mitz.
- added test case for float being added in trailing whitespace of an already full line (with pre-wrap or after-white-space set). <rdar://problem/5805741> https://bugs.webkit.org/show_bug.cgi?id=17906
- fast/block/float/editable-text-overlapping-float.html: Added.
- platform/mac/fast/block/float/editable-text-overlapping-float-expected.checksum: Added.
- platform/mac/fast/block/float/editable-text-overlapping-float-expected.png: Added.
- platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt: Added.
- platform/qt/fast/block/float/editable-text-overlapping-float-expected.txt: Added.
- 12:27 PM Changeset in webkit [35353] by
-
- 2 edits in trunk/WebKitTools
Try to fix the Windows build bot
- DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files that don't exist for people outside of Apple.
- 12:10 PM Changeset in webkit [35352] by
-
- 2 edits in trunk/WebCore
2008-07-25 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
- Finish fixing https://bugs.webkit.org/show_bug.cgi?id=17097 <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound
- platform/graphics/FontCache.cpp: (WebCore::FontDataCacheKeyTraits): Changed needsDestruction to true because FontPlatformData instances hold references to the platform resources and release them in the destructor. (WebCore::cTargetInactiveFontData): Added, replacing cInactiveFontDataPurgeRatio with the number of inactive FontData instances to leave in the cache when automatically purging. (WebCore::FontCache::getCachedFontData): Moved the code that checks if there are too many inactive FontData instances and if so calls purgeInactiveFontData() from here... (WebCore::FontCache::releaseFontData): ... to here. (WebCore::FontCache::purgeInactiveFontData): Added code to also purge the platform font data cache. All FontPlatformData instances that do not have entries in the font data cache are removed, thus releasing the platform resources (such as HFONTs and NSFonts).
- 11:33 AM Changeset in webkit [35351] by
-
- 14 edits71 adds in trunk
WebCore:
2008-07-24 David Hyatt <hyatt@apple.com>
Add support for an alternate syntax for CSS variables. Testers on www-style will be able to try out
both versions of the syntax in WebKit to help us make a decision regarding which one to go with.
Reviewed by Dan
Added fast/css/variables/alternate-syntax/ (duplicated all existing CSS variables tests)
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::createVariablesRule): (WebCore::CSSParser::checkForVariables):
- css/CSSParser.h:
- css/CSSParserValues.cpp: (WebCore::CSSParserValue::isVariable): (WebCore::CSSParserValueList::addValue): (WebCore::CSSParserValueList::deleteValueAt): (WebCore::CSSParserValue::createCSSValue):
- css/CSSParserValues.h:
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::isVariable):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration):
- css/CSSVariablesRule.cpp: (WebCore::CSSVariablesRule::CSSVariablesRule): (WebCore::CSSVariablesRule::cssText):
- css/CSSVariablesRule.h: (WebCore::CSSVariablesRule::create):
- css/maketokenizer:
- css/tokenizer.flex:
LayoutTests:
2008-07-24 David Hyatt <hyatt@apple.com>
Add support for an alternate proposed syntax for CSS variables. This alternate syntax will allow
testers on www-style to try out both versions of the syntax (to help make a decision regarding
which one should be used).
Reviewed by Dan
- fast/css/variables/alternate-syntax: Added.
- fast/css/variables/alternate-syntax/color-hex-test.html: Added.
- fast/css/variables/alternate-syntax/colors-test.html: Added.
- fast/css/variables/alternate-syntax/font-test.html: Added.
- fast/css/variables/alternate-syntax/image-test.html: Added.
- fast/css/variables/alternate-syntax/import-test.html: Added.
- fast/css/variables/alternate-syntax/inline-style-test.html: Added.
- fast/css/variables/alternate-syntax/invalid-variable-test.html: Added.
- fast/css/variables/alternate-syntax/margin-test.html: Added.
- fast/css/variables/alternate-syntax/misplaced-import-test.html: Added.
- fast/css/variables/alternate-syntax/misplaced-variables-test.html: Added.
- fast/css/variables/alternate-syntax/multiple-term-test.html: Added.
- fast/css/variables/alternate-syntax/override-test.html: Added.
- fast/css/variables/alternate-syntax/print-test.html: Added.
- fast/css/variables/alternate-syntax/remove-variable-test.html: Added.
- fast/css/variables/alternate-syntax/resources: Added.
- fast/css/variables/alternate-syntax/resources/bad.css: Added.
- fast/css/variables/alternate-syntax/resources/good.css: Added.
- fast/css/variables/alternate-syntax/resources/listmark.gif: Added.
- fast/css/variables/alternate-syntax/set-variable-test.html: Added.
- fast/css/variables/alternate-syntax/shorthand-test.html: Added.
- fast/css/variables/alternate-syntax/variable-iteration-test.html: Added.
- 11:30 AM Changeset in webkit [35350] by
-
- 2 edits in trunk/WebCore
2008-07-25 Maxime Britto <britto@apple.com>
Reviewed by Anders Carlsson.
<rdar://6102387> "REGRESSION: horizontal scroll with the mouse wheel is inverted on some subframes"
- page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): Inverted the scroll direction relative to the delta value (positive scrolls left,negative scrolls right)
- 10:46 AM Changeset in webkit [35349] by
-
- 2 edits in trunk/WebKit/win
Try to fix the Windows build bot
- WebKit.vcproj/WebKit.sln: Linearize the project dependencies. Each project now depends only on the project that should immediately precede it in the build. For the frameworks, this order makes sense. For the applications built on top of the frameworks, the order is arbitrary (but roughly follows the applications' complexity).
- 10:11 AM Changeset in webkit [35348] by
-
- 2 edits in trunk/WebCore
2008-07-25 Adele Peterson <adele@apple.com>
Another build fix.
- platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint):
- 9:54 AM Changeset in webkit [35347] by
-
- 2 edits in trunk/WebCore
2008-07-25 Adele Peterson <adele@apple.com>
More build fixes.
- platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint):
- 9:30 AM Changeset in webkit [35346] by
-
- 2 edits in trunk/WebCore
2008-07-25 Adele Peterson <adele@apple.com>
Build fix.
- platform/win/PlatformScrollBarSafari.cpp:
- 8:58 AM Changeset in webkit [35345] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/testapi/testapi.vcproj: Add API/ to the include path.
- 6:11 AM Changeset in webkit [35344] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-25 Simon Hausmann <Simon Hausmann>
Fix the build of jsc on Qt/Windows, make sure os-win32 is in the
include search path (added by WebKit.pri).
- 6:05 AM Changeset in webkit [35343] by
-
- 2 edits in trunk/WebKit/qt
2008-07-25 Joerg Bornemann <joerg.bornemann@trolltech.com>
Reviewed by Simon.
Compile with QT_NO_PRINTER.
- 5:05 AM Changeset in webkit [35342] by
-
- 4 edits13 moves1 add in trunk/JavaScriptCore
Reviewed by Simon Hausmann.
Move JavaScriptCore API tests into a subdirectory of their own to avoid header name
conflicts and developer confusion.
- API/JSNode.c: Removed.
- API/JSNode.h: Removed.
- API/JSNodeList.c: Removed.
- API/JSNodeList.h: Removed.
- API/Node.c: Removed.
- API/Node.h: Removed.
- API/NodeList.c: Removed.
- API/NodeList.h: Removed.
- API/minidom.c: Removed.
- API/minidom.html: Removed.
- API/minidom.js: Removed.
- API/testapi.c: Removed.
- API/testapi.js: Removed.
- API/tests: Added.
- API/tests/JSNode.c: Copied from JavaScriptCore/API/JSNode.c.
- API/tests/JSNode.h: Copied from JavaScriptCore/API/JSNode.h.
- API/tests/JSNodeList.c: Copied from JavaScriptCore/API/JSNodeList.c.
- API/tests/JSNodeList.h: Copied from JavaScriptCore/API/JSNodeList.h.
- API/tests/Node.c: Copied from JavaScriptCore/API/Node.c.
- API/tests/Node.h: Copied from JavaScriptCore/API/Node.h.
- API/tests/NodeList.c: Copied from JavaScriptCore/API/NodeList.c.
- API/tests/NodeList.h: Copied from JavaScriptCore/API/NodeList.h.
- API/tests/minidom.c: Copied from JavaScriptCore/API/minidom.c.
- API/tests/minidom.html: Copied from JavaScriptCore/API/minidom.html.
- API/tests/minidom.js: Copied from JavaScriptCore/API/minidom.js.
- API/tests/testapi.c: Copied from JavaScriptCore/API/testapi.c.
- API/tests/testapi.js: Copied from JavaScriptCore/API/testapi.js.
- GNUmakefile.am:
- JavaScriptCore.vcproj/testapi/testapi.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 5:05 AM Changeset in webkit [35341] by
-
- 3 edits in trunk/WebCore
2008-07-24 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon
Provide access to the underlying QKeyEvent in PlatformKeyboardEvent.
- 5:04 AM Changeset in webkit [35340] by
-
- 2 edits in trunk/WebKit/qt
2008-07-24 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon
Don't insert text on keyDown event in EditorClientQt.
- 4:43 AM Changeset in webkit [35339] by
-
- 2 edits in trunk/WebCore
2008-07-25 Simon Hausmann <Simon Hausmann>
Fix linking of QtWebKit against the statically built JavaScriptCore
library, under Windows/Mac we may need _d/_debug suffixes.
- 4:02 AM Changeset in webkit [35338] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-25 Simon Hausmann <Simon Hausmann>
Prospective WX build fix, add JavaScriptCore/API to the include search
path.
- 3:56 AM Changeset in webkit [35337] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-25 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Lars.
Fix the build on Windows. operator new for ArgList is implemented using fastMalloc()
but operator delete was not implemented. Unfortunately MSVC decides to call/reference
the function, so a simple implementation using fastFree() fixes the build.
- 3:55 AM Changeset in webkit [35336] by
-
- 3 edits in trunk/WebCore
2008-07-25 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Lars.
Fix the Qt build by adapting to the latest ArgList API changes and
replacing the inclusion of npapi.h in MainThreadScheduler with a forward
declaration of NPP to avoid an include conflict. npapi.h on X11 includes
X headers, which include wonderful defines such as "#define Status" that
cause conflicts.
- 3:55 AM Changeset in webkit [35335] by
-
- 8 edits1 add in trunk
2008-07-25 Simon Hausmann <Simon Hausmann>
Discussed with and rubber-stamped by Lars.
Fix the build system for the Qt port.
Recent JavaScriptCore changes require the addition of JavaScriptCore/API to the
include search path. With a build process that combines JavaScriptCore and
WebCore in one build process/Makefile the existance of
JavaScriptCore/API/Node.h and WebCore/dom/Node.h causes include conflicts.
This commit solves this by introducing a separate build of JavaScriptCore into
a static library.
As a result of the split-up a race-condition due to broken dependencies of
regular source files to header files of generated sources showed up very
frequently when doing parallel builds (which the buildbot does). This commit at
the same time tries to address the dependency problem by making the
addExtraCompiler() function also generate a pseudo extra compiler that
represents the header file output, so that qmake is aware of the creation of
the header file for dependency calculation.
At the same time I removed a lot of cruft from the pro files to ease maintenance.
Jul 24, 2008:
- 11:40 PM Changeset in webkit [35334] by
-
- 3 edits in trunk/JavaScriptCore
2008-07-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Fixed a strict aliasing violation, which caused hash tables with floating
point keys not to find items that were indeed in the tables
(intermittently, and only in release builds, of course).
SunSpider reports no change.
This bug doesn't seem to affect any existing code, but it causes obvious
crashes in some new code I'm working on.
- wtf/HashFunctions.h: (WTF::FloatHash::hash): Use a union when punning between a float / double and an unsigned (bucket of bits). With strict aliasing enabled, unions are the only safe way to do this kind of type punning.
- wtf/HashTable.h: When rehashing, ASSERT that the item we just added to the table is indeed in the table. In the buggy case described above, this ASSERT fires.
- 3:57 PM Changeset in webkit [35333] by
-
- 4 edits in trunk/WebCore
wx build fix on Win for plugins coode.
- 2:55 PM Changeset in webkit [35332] by
-
- 11 edits in trunk/WebCore
2008-07-24 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Make isElementNode() non-virtual for a speedup on many benchmarks
including 20% on http://ejohn.org/apps/fragment/.
- Replace Node::m_attrWasSpecifiedOrElementHasRareData with bits in Element and Attr where space was available. Use the new free bit to represent if an node is an element or not.
- dom/Attr.cpp: (WebCore::Attr::Attr):
- dom/Attr.h: (WebCore::Attr::specified): (WebCore::Attr::setSpecified):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::ContainerNode):
- dom/ContainerNode.h:
- dom/Element.cpp: (WebCore::Element::Element):
- dom/Element.h: (WebCore::Element::hasRareData): (WebCore::Element::setHasRareData):
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::EventTargetNode):
- dom/EventTargetNode.h:
- dom/Node.cpp: (WebCore::Node::Node):
- dom/Node.h: (WebCore::Node::isElementNode):
- 2:38 PM Changeset in webkit [35331] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- fix <rdar://problem/6082111> REGRESSION (r31876): Root element with percent height does not resize when resizing the window vertically
Not testable in DumpRenderTree
- rendering/RenderView.cpp: (WebCore::RenderView::layout): Ensured that all children with percentage heights get laid out again if the height changes.
- 2:27 PM Changeset in webkit [35330] by
-
- 2 edits in trunk/WebCore
Windows build fix for wx. wx doesn't implement pan scrolling yet.
- 1:38 PM Changeset in webkit [35329] by
-
- 2 edits in trunk/WebKitSite
Remove some redundant text accidentally checked in
- building/tools.html:
- 1:36 PM Changeset in webkit [35328] by
-
- 2 edits in trunk/WebKitSite
Fix a dead link to the Windows Platform SDK and related instructions
Rubberstamped by Alexey Proskuryakov.
- building/tools.html: Fixed a dead link.
- 1:24 PM Changeset in webkit [35327] by
-
- 2 edits in trunk/WebCore
2008-07-24 David Hyatt <hyatt@apple.com>
Fix for bug 18673, crash when using full page zoom on generated content. Don't call
intrinsicSizeChanged when we are first setting our style.
Reviewed by olliej
- ChangeLog:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::setStyle):
- 10:34 AM Changeset in webkit [35326] by
-
- 9 edits5 adds in branches/XBL2
WebKitTools:
2008-07-24 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Ap.
Add XBL detection to run-webkit-test.
- Scripts/build-drawtest:
- Scripts/run-drawtest:
- Scripts/run-webkit-tests: Detect if WebKit was compiled with XBL support and enable or disable XBL test.
- Scripts/webkitdirs.pm: Renamed checkWebKitSVGSupport to checkWebKitSupportFor taking a string parameter for the standard to test to share the code between SVG and XBL.
LayoutTest:
2008-07-24 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Ap.
- Add test for bug 19917: [XBL] We need the ability to manage bindings
- Updated some tests' results.
Note: the 2 updated test in fast/dom will fail when XBL is disabled
because they depend on Element's number of properties. It is
fine for now but it will need to be properly fixed.
- fast/dom/Window/window-properties-expected.txt: Updated as we have added the 3 new methods to Element.
- fast/dom/domListEnumeration-expected.txt: Ditto.
- fast/dom/resources/domListEnumeration.js: Ditto.
- fast/xbl: Added.
- fast/xbl/resources: Added.
- fast/xbl/resources/xbl-empty-binding.xbl: Added.
- fast/xbl/xbl-ElementXBL-Interface-expected.txt: Added.
- fast/xbl/xbl-ElementXBL-Interface.html: Added.
- 7:19 AM Changeset in webkit [35325] by
-
- 5 edits2 adds in branches/XBL2/WebCore
2008-07-24 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 20029: [XBL] Add more tags
Add <binding> and <template> classes.
Add <div> tag.
The two classes are stubs for the moment.
These tags are required to have a simple XBL example
running.
XBLElement now inherits from StyledElement as <div>
is a placeholder for CSS style information.
- WebCore.xcodeproj/project.pbxproj:
- dom/make_names.pl: Add 'generateNameOnly' attribute used for <div> as we do not want to add a specialized class.
- xbl/XBLBindingElement.h: Added. (WebCore::XBLBindingElement::XBLBindingElement):
- xbl/XBLElement.h: (WebCore::XBLElement::XBLElement): Now XBLElement inherits from styledElement.
- xbl/XBLTemplateElement.h: Added. (WebCore::XBLTemplateElement::XBLTemplateElement):
- xbl/xbltags.in: Add tags.
- 3:58 AM Changeset in webkit [35324] by
-
- 9 edits3 adds in branches/XBL2/WebCore
2008-07-24 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 19917: [XBL] We need the ability to manage bindings
- Move XBLBindingManager from per-document to global.
- Implement part of ElementXBL interface (to add bindings, remove bindings and check if an element has a binding).
- GNUmakefile.am: Add compilation information.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Document.cpp: (WebCore::Document::Document): Remove per-document XBLBindingManager instance. (WebCore::Document::~Document): Ditto.
- dom/Document.h: Ditto.
- dom/Element.cpp: (WebCore::Element::~Element): Remove associated bindings to avoid leaks. (WebCore::Element::addBinding): Part of ElementXBL interface to manage bindings. (WebCore::Element::removeBinding): Ditto. (WebCore::Element::hasBinding): Ditto.
- dom/Element.h: Add ElementXBL interface.
- dom/Element.idl: Ditto.
- xbl/XBLBinding.h: Added. (WebCore::XBLBinding::XBLBinding): (WebCore::XBLBinding::uri):
- xbl/XBLBindingManager.cpp: Added. (WebCore::XBLBindingManager::sharedInstance): (WebCore::XBLBindingManager::XBLBindingManager): (WebCore::XBLBindingManager::addBinding): (WebCore::XBLBindingManager::removeBinding): (WebCore::XBLBindingManager::hasBinding): (WebCore::XBLBindingManager::removeAllBindings): Used in Element destructor to remove all the bindings associated with the Element.
- xbl/XBLBindingManager.h: Added.
- 3:16 AM Changeset in webkit [35323] by
-
- 3 edits3 adds in trunk
Bug 20142: REGRESSION(r35245): /=/ weirdness
<https://bugs.webkit.org/show_bug.cgi?id=20142>
Reviewed by Alexey Proskuryakov.
When adding all the meta data needed for exception error messages
I accidentally clobbered the handling of regex beginning with /=.
- 1:44 AM Changeset in webkit [35322] by
-
- 8 edits1 add1 delete in trunk/WebCore
2008-07-24 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 20053: .in files should use a custom format instead of XML
- Remove our XML parser perl module (XML::Tiny)
- Add a custom perl parser
- Move XML files to the new format
- bindings/scripts/InFilesParser.pm: Added.
- bindings/scripts/XMLTiny.pm: Removed.
- dom/make_names.pl: Switched to our new parser.
- html/HTMLAttributeNames.in: Switched to our custom format.
- html/HTMLTagNames.in: Ditto.
- svg/svgattrs.in: Ditto.
- svg/svgtags.in: Ditto.
- svg/xlinkattrs.in: Ditto.
- xml/xmlattrs.in: Ditto.
- 12:45 AM Changeset in webkit [35321] by
-
- 4 edits2 adds in trunk
WebCore:
2008-07-23 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 19588: CRASH doing open() on destroyed window
https://bugs.webkit.org/show_bug.cgi?id=19588
Add frame's page null check as it could have been
detached from the page.
Test: fast/frames/crash-removed-iframe.html
- bindings/js/JSDOMWindowBase.cpp: (WebCore::windowProtoFuncOpen):
- page/FrameTree.cpp: (WebCore::FrameTree::find):
LayoutTest:
2008-07-23 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Test for bug 19588: CRASH doing open() on destroyed window
https://bugs.webkit.org/show_bug.cgi?id=19588
Test case from Eric Roman.
- fast/frames/crash-removed-iframe-expected.txt: Added.
- fast/frames/crash-removed-iframe.html: Added.
Jul 23, 2008:
- 11:55 PM Changeset in webkit [35320] by
-
- 8 edits in trunk
WebCore:
Reviewed by Alexey Proskuryakov.
- fix a leak when using hex color values in CSS variables
- fix CSSOM access to hex color values in variables declarations
Test: fast/css/variables/color-hex-test.html
Added a new unit/type, CSS_PARSER_HEXCOLOR, which serves as the unit for
CSSParserValues coming from colors in hex notation. CSSParserValues can
no longer have CSS_RGBCOLOR as their unit. CSS_PARSER_HEXCOLOR is also
used as the type for CSSValues in CSS variables declarations where the
parser value was a hex color. However the type of all other color
CSSValues remains CSS_RGBCOLOR.
- css/CSSGrammar.y: Changed to use the new CSS_PARSER_HEXCOLOR value for color values in hex notation.
- css/CSSParser.cpp: (WebCore::CSSParser::parseColorFromValue): Updated for the new unit.
- css/CSSParserValues.cpp: (WebCore::CSSParserValue::createCSSValue): Ditto.
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): Fixed the leak by deref()ing the string containing the color. (WebCore::CSSPrimitiveValue::cssText): Added support for CSS_PARSER_HEXCOLOR for when serializing variable values. (WebCore::CSSPrimitiveValue::parserValue): Updated for the new unit.
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): Added a new unti, CSS_PARSER_HEXCOLOR.
LayoutTests:
Reviewed by Alexey Proskuryakov.
- updated test to cover serializing variable values which are colors in hex notation
- fast/css/variables/color-hex-test.html:
- 11:16 PM Changeset in webkit [35319] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-23 Alp Toker <alp@nuanti.com>
Build fix after r35293: Add API/ to the include path.
- GNUmakefile.am:
- 8:43 PM Changeset in webkit [35318] by
-
- 6 edits16 adds in trunk
WebCore:
2008-07-23 Beth Dakin <Beth Dakin>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/5997215> display: table-row-group
for :before content causes a crash
The actual bug fix here is to ddd the generated content container
as a child before adding any of the generated content to the
container. There are two correctness fixes as well that deal with
style changes and correctly.
This patch also makes Node::diff() a static function.
- dom/Node.cpp: (WebCore::Node::diff):
- dom/Node.h: (WebCore::Node::): (WebCore::Node::recalcStyle):
- rendering/RenderContainer.cpp: (WebCore::findBeforeAfterParent): (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::recalcStyle):
LayoutTests:
2008-07-23 Beth Dakin <Beth Dakin>
Reviewed by Dan Bernstein.
Tests for <rdar://problem/5997215> display: table-row-group
for :before content causes a crash
- fast/css-generated-content/table-row-group-to-inline.html: Added.
- fast/css-generated-content/table-row-group-with-before.html: Added.
- fast/css-generated-content/table-row-with-before.html: Added.
- fast/css-generated-content/table-with-before.html: Added.
- platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.png: Added.
- platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.txt: Added.
- platform/mac/fast/css-generated-content/table-row-group-with-before-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-row-group-with-before-expected.png: Added.
- platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt: Added.
- platform/mac/fast/css-generated-content/table-row-with-before-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-row-with-before-expected.png: Added.
- platform/mac/fast/css-generated-content/table-row-with-before-expected.txt: Added.
- platform/mac/fast/css-generated-content/table-with-before-expected.checksum: Added.
- platform/mac/fast/css-generated-content/table-with-before-expected.png: Added.
- platform/mac/fast/css-generated-content/table-with-before-expected.txt: Added.
- 7:48 PM Changeset in webkit [35317] by
-
- 7 edits3 adds in trunk/WebCore
Updates the elements DOM tree when nodes are added or removed from
the inspected document.
https://bugs.webkit.org/show_bug.cgi?id=6590
<rdar://problem/5712921>
Reviewed by Adam Roben.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchWindowObjectAvailable): Added a call to InspectorController::inspectedWindowScriptObjectCleared.
- page/InspectorController.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared): Calls the WebInspector.inspectedWindowCleared script function.
- page/InspectorController.h:
- page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Create the event listener callback wrappers. (WebInspector.ElementsPanel.prototype.show): Call _updateModifiedNodes if there are any recently modified nodes. (WebInspector.ElementsPanel.prototype.reset): Remove previous mutation event listeners. Adds a check for InspectorController.isWindowVisible to prevent adding event listeners when the window isn't visible. (WebInspector.ElementsPanel.prototype.inspectedWindowCleared): (WebInspector.ElementsPanel.prototype._addMutationEventListeners): Add DOMNodeInserted, DOMNodeRemoved and DOMContentLoaded event listeners to the passed in window or window's document. (WebInspector.ElementsPanel.prototype._removeMutationEventListeners): Removes the event listeners added in _addMutationEventListeners. (WebInspector.ElementsPanel.prototype.updateMutationEventListeners): Call _addMutationEventListeners again to reinstate the listners if the document changed or window cleared them. (WebInspector.ElementsPanel.prototype.registerMutationEventListeners): Append the window to _mutationMonitoredWindows and call _addMutationEventListeners. (WebInspector.ElementsPanel.prototype.unregisterMutationEventListeners): Remove the window from _mutationMonitoredWindows and call _removeMutationEventListeners. (WebInspector.ElementsPanel.prototype.unregisterAllMutationEventListeners): Call _removeMutationEventListeners for all windows in _mutationMonitoredWindows and clear _mutationMonitoredWindows. (WebInspector.ElementsPanel.prototype._contentLoaded): Append the node and parent to the recentlyModifiedNodes array. Call _updateModifiedNodesSoon if visible. (WebInspector.ElementsPanel.prototype._nodeInserted): Ditto. (WebInspector.ElementsPanel.prototype._nodeRemoved): Ditto. (WebInspector.ElementsPanel.prototype._updateModifiedNodesSoon): Call _updateModifiedNodes on a zero timeout. (WebInspector.ElementsPanel.prototype._updateModifiedNodes): Iterate over the recentlyModifiedNodes array and call updateChildren on all the parent elements that had changes. Only calls updateChildren once per parent element. (WebInspector.ElementsPanel.prototype._isAncestorIncludingParentFrames): Return false if the nodes are the same. Return true if the nodes are the same while looking at ancestor frame elements. THis use to return false, which was incorrect. (WebInspector.DOMNodeTreeElement.prototype.onpopulate): Call updateChildren. (WebInspector.DOMNodeTreeElement.prototype.updateChildren): Copied from onpopulate and changed to rebuild the children elements by adding new children, moving existing children and removed old children. (WebInspector.DOMNodeTreeElement.prototype.onexpand): If the node has a contentDocument call registerMutationEventListeners to track any mutations.
- page/inspector/inspector.js: (WebInspector.inspectedWindowCleared): Call ElementsPanel.inspectedWindowCleared.
- page/inspector/treeoutline.js: (TreeElement.prototype.get hasChildren): Return _hasChildren. (TreeElement.prototype.set hasChildren): Set _hasChildren and update the className. (TreeElement.prototype.hasAncestor): Return true if the element has the passed in ancestor. (TreeElement.prototype.expand): Fix an exception that can happen if expand is called before _attach.
- WebCore/manual-tests/inspector/dom-mutation.html: Added.
- WebCore/manual-tests/inspector/resources/mutate-frame-2.html: Added.
- WebCore/manual-tests/inspector/resources/mutate-frame.html: Added.
- 7:48 PM Changeset in webkit [35316] by
-
- 2 edits in trunk/WebCore
Fix an exception that occurred when double clicking the closing tag
of an element in the DOM tree.
Reviewed by Anders Carlsson.
- page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._ondblclick): Null check element.ondblclick.
- 7:48 PM Changeset in webkit [35315] by
-
- 4 edits in trunk/WebCore
Fix a regression where elements in subframes would not be revealed
or selected when inspected from the context menu. This was caused by
JavaScript equality is not being true for JSInspectedObjectWrappers
of the same node wrapped with different global ExecStates. This change
adds a helper function that uses isSameNode to compare wrapped nodes.
Reviewed by Adam Roben.
- page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.set rootDOMNode): Use objectsAreSame to compare nodes. (WebInspector.ElementsPanel.prototype.set focusedDOMNode): Ditto. (WebInspector.ElementsPanel.prototype.set hoveredDOMNode): Ditto. (WebInspector.ElementsPanel.prototype._updateModifiedNodes): Ditto. (WebInspector.ElementsPanel.prototype.revealNode): Ditto. (WebInspector.ElementsPanel.prototype.updateBreadcrumb): Ditto. (WebInspector.DOMNodeTreeElement.prototype.updateChildren): Ditto.
- page/inspector/treeoutline.js: (TreeOutline.prototype.findTreeElement): Add an equal argument to accept a functions to compare two representedObjects. Defaults to strict equal if not supplied. All current clients pass objectsAreSame.
- page/inspector/utilities.js: (Node.prototype.enclosingNodeOrSelfWithNodeNameInArray): Use objectsAreSame to compare nodes. (Node.prototype.enclosingNodeOrSelfWithClass): Ditto. (Element.prototype.query): Use the ownerDocument of the node, not document. (objectsAreSame): Added. Compares strict equal first, then uses isSameNode if it exists on both objects. (isAncestorNode): Use objectsAreSame to compare nodes. (firstCommonNodeAncestor): Ditto. (traverseNextNode): Ditto.
- 7:47 PM Changeset in webkit [35314] by
-
- 2 edits in trunk/WebCore
Added InspectorController.isWindowVisible to the JavaScript class
for use in an upcoming change. This will allow the Inspector to not
perform selective actions while the window is hidden.
Reviewed by Adam Roben.
- page/InspectorController.cpp: (WebCore::isWindowVisible): Call InspectorController::windowVisible. (WebCore::InspectorController::windowScriptObjectAvailable): Add the isWindowVisible function to the JavaScript class.
- 7:47 PM Changeset in webkit [35313] by
-
- 2 edits in trunk/WebCore
Added TreeOutline.removeChildAtIndex and TreeElement.removeChildAtIndex
for efficiency of callers that know the index of the child. This
will be used in an upcoming change.
Reviewed by Adam Roben.
- page/inspector/treeoutline.js: (TreeOutline._removeChildAtIndex): Renamed from _removeChild and modified to take an index. (TreeOutline._removeChild): Call _removeChildAtIndex with the child index found using indexOf. (TreeOutline.prototype.removeChildAtIndex): Added. Calls TreeOutline._removeChildAtIndex. (TreeElement.prototype.removeChildAtIndex): Ditto.
- 7:46 PM Changeset in webkit [35312] by
-
- 2 edits in trunk/WebCore
Fixes a regression where TreeOutline.findTreeElement would
return the parent TreeElement of the representedObject instead
of the TreeElement for the representedObject. Regressed with the
fix for bug 19164.
Reviewed by Adam Roben.
- page/inspector/treeoutline.js: (TreeOutline.prototype.findTreeElement): When performing a slow search, do a final search for representedObject instead of returning item, which is the parent of representedObject.
- 7:45 PM Changeset in webkit [35311] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.exp
speculative build fix
- 6:00 PM Changeset in webkit [35310] by
-
- 6 edits in trunk/JavaScriptCore
Windows build fixes
Build fix after r35293:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add API/ to the include path.
Build fix after r35305:
- VM/Machine.cpp:
- VM/Machine.h:
- VM/Opcode.cpp:
- VM/Opcode.h: Completely compile out all sampler-related code when SAMPLING_TOOL_ENABLED is 0. The sampler code can't be compiled 1) on non-AllInOne configurations due to circular header dependencies, and 2) on platforms that don't have a usleep() function, such as Windows.
- 5:49 PM Changeset in webkit [35309] by
-
- 12 edits3 adds in trunk
Improve switch performance.
Reviewed by Geoff Garen and Sam Weinig.
Improve switch performance by converting to a hashmap based jump
table to avoid the sequence of dispatches that would otherwise be
needed. This results in a 9-19x performance win for string switches
based on ad hoc testing, and a 6x improvement for integer switch
statements. SunSpider reports a 1.2% progression.
- 5:35 PM Changeset in webkit [35308] by
-
- 22 edits1 add in trunk
WebCore:
2008-07-23 Adele Peterson <adele@apple.com>
Reviewed by Adam.
WebCore part of fix for <rdar://problem/5698672> Add drawing callback for a WebKit app to draw its own scrollbars
- WebCore.base.exp: Added symbols.
- page/Chrome.cpp: (WebCore::ChromeClient::paintCustomScrollbar): Added. Calls up to WebKit, which will call a new delegate method. (WebCore::ChromeClient::paintCustomScrollCorner): ditto.
- page/ChromeClient.h:
- page/Settings.cpp: (WebCore::Settings::Settings): Added the ability to store whether or not the application has decided to draw its own scrollbars. (WebCore::Settings::setShouldPaintCustomScrollbars):
- page/Settings.h: (WebCore::Settings::shouldPaintCustomScrollbars):
- platform/ScrollBar.h: Moved ScrollbarControlSize enum to ScrollTypes.h
- platform/ScrollTypes.h: (WebCore::): Moved some existing types, and added new ones to be used in WebCore in WebKit.
- platform/win/PlatformScrollBar.h: Moved ScrollbarPart enum to ScrollTypes.h
- platform/win/PlatformScrollBarSafari.cpp: (WebCore::ScrollbarPartToScrollBarPiece): Added helper function. (WebCore::ScrollBarPieceMaskToScrollbarControlPartMask): ditto. (WebCore::ScrollbarControlStateFromThemeState): ditto. (WebCore::PlatformScrollbar::paint): Consolidated painting so the logic for the individual pieces is all in one place. Added new code to paint the custom scrollbars if necessary.
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::paint): Added code to paint the custom scroll corner if necessary.
WebKit/win:
2008-07-17 Adele Peterson <adele@apple.com>
Reviewed by Adam.
WebKit part of fix for <rdar://problem/5698672> Add drawing callback for a WebKit app to draw its own scrollbars
Added a setting so an application can tell WebKit its going to draw custom scrollbars. Also added delegate methods for the actual painting.
- Interfaces/IWebPreferences.idl: Added setShouldPaintCustomScrollbars and shouldPaintCustomScrollbars.
- Interfaces/IWebScrollBarPrivate.idl: Moved types to WebScrollbarTypes.idl
- Interfaces/IWebUIDelegate.idl: Added WebUIDelegate4 with new delegate methods, paintCustomScrollbar and paintCustomScrollCorner
- Interfaces/WebKit.idl: Include new WebScrollbarTypes.idl
- Interfaces/WebScrollbarTypes.idl: Added. Has types that the new delegate methods use.
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::paintCustomScrollbar): Added. Calls new delegate method and converts between WebCore types and types exported in WebScrollbarTypes.idl (WebChromeClient::paintCustomScrollCorner): Added. Calls new delegate method. (WebChromeClient::uiDelegate4): Added.
- WebCoreSupport/WebChromeClient.h:
- WebPreferenceKeysPrivate.h: Added WebKitPaintCustomScrollbarsPreferenceKey
- WebPreferences.cpp: (WebPreferences::): Added. (WebPreferences::shouldPaintCustomScrollbars): Added.
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
- 5:33 PM Changeset in webkit [35307] by
-
- 2 edits in trunk/LayoutTests
2008-07-23 Dean Jackson <dino@apple.com>
Reviewed by Dan Bernstein.
Update computed style test for transform to reflect that
we return "none" rather than identity matrix.
- svg/css/getComputedStyle-basic-expected.txt:
- 4:15 PM Changeset in webkit [35306] by
-
- 1 edit in trunk/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
build fix.
- 3:36 PM Changeset in webkit [35305] by
-
- 8 edits in trunk/JavaScriptCore
2008-07-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Sampling tool to analyze cost of instruction execution and identify hot regions of JS code.
Enable Switches by setting SAMPLING_TOOL_ENABLED in Opcode.h.
- JavaScriptCore.exp: Export symbols for Shell.cpp.
- VM/Machine.cpp: Added sampling hooks.
- VM/Machine.h: Machine contains a pointer to a sampler, when sampling.
- VM/Opcode.cpp: Tool implementation.
- VM/Opcode.h: Tool declaration.
- kjs/Shell.cpp: Initialize the sampler, if enabled.
- kjs/nodes.cpp: Added sampling hooks.
- 3:32 PM Changeset in webkit [35304] by
-
- 14 edits in trunk/WebCore
2008-07-23 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Cleanup and pack the member variables in Node.
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark):
- dom/Attr.cpp: (WebCore::Attr::Attr):
- dom/Attr.h: (WebCore::Attr::specified): (WebCore::Attr::setSpecified):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::setFocus):
- dom/Document.cpp: (WebCore::Document::adoptNode):
- dom/Element.cpp: (WebCore::Element::~Element): (WebCore::Element::rareData): (WebCore::Element::createRareData):
- dom/Element.h: (WebCore::Element::hasRareData): (WebCore::Element::setHasRareData):
- dom/Node.h: (WebCore::Node::setIsLink): (WebCore::Node::inSubtreeMark): (WebCore::Node::setInSubtreeMark): (WebCore::Node::attrWasSpecifiedOrElementHasRareData): (WebCore::Node::setAttrWasSpecifiedOrElementHasRareData):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::supportsFocus): (WebCore::HTMLAnchorElement::isFocusable): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::parseMappedAttribute): (WebCore::HTMLAnchorElement::isLiveLink):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType):
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::attach):
- svg/SVGAElement.cpp: (WebCore::SVGAElement::svgAttributeChanged): (WebCore::SVGAElement::defaultEventHandler):
- 2:45 PM Changeset in webkit [35303] by
-
- 2 edits in trunk/WebCore
2008-07-23 Kevin Calhoun <kcalhoun@apple.com>
Reviewed by Adele.
Follow-up fix for <rdar://problem/6031039> don't disable track-types when media is in a standalone document
Associate MovieControllers with Movies to support all of the media types QuickTime is able to play in standalone media documents.
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::QTMovieWinPrivate): (QTMovieWinPrivate::~QTMovieWinPrivate): (QTMovieWinPrivate::task): (QTMovieWinPrivate::createMovieController): (QTMovieWinPrivate::createGWorld): (QTMovieWinPrivate::setSize): (QTMovieWinPrivate::deleteGWorld): (QTMovieWin::play): (QTMovieWin::pause): (QTMovieWin::setRate): (QTMovieWin::setCurrentTime): (QTMovieWin::load):
- 2:40 PM Changeset in webkit [35302] by
-
- 5 edits in trunk/WebCore
2008-07-23 Kevin Calhoun <kcalhoun@apple.com>
Reviewed by Adele.
Added a debug mode for viewing frames per second for videos. This is controlled by two
independent compiler flags DRAW_FRAME_RATE in MediaPlayerPrivateQTKit.h and MediaPlayerPrivateQuickTimeWin.h.
Unless either flags is turned on there is no change to the code for video frame drawing.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::repaint): (WebCore::MediaPlayerPrivate::paint):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::movieNewImageAvailable):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
- 2:30 PM Changeset in webkit [35301] by
-
- 5 edits in trunk/WebCore
2008-07-23 Adele Peterson <adele@apple.com>
Reviewed by Sam.
Fix for <rdar://problem/6080634> use lower quality CG interpolation in MediaPlayerPrivateQTKit to improve performance
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): Call setImageInterpolationQuality(InterpolationNone) instead of setUseLowQualityImageInterpolation(true).
- platform/graphics/GraphicsContext.h: (WebCore::): Added InterpolationQuality enum. (WebCore::GraphicsContext::setImageInterpolationQuality): Renamed from setUseLowQualityImageInterpolation. The implementation was always setting the quality to "none", and now we want to distinguish between "none" and "low". (WebCore::GraphicsContext::imageInterpolationQuality): Renamed from useLowQualityImageInterpolation.
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setImageInterpolationQuality): Added. (WebCore::GraphicsContext::imageInterpolationQuality): Added.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint): Calls setImageInterpolationQuality(InterpolationLow) which will improve the painting performance without degrading quality too much.
- 2:28 PM Changeset in webkit [35300] by
-
- 1 edit1 delete in trunk/LayoutTests
2008-07-23 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Remove tiger specific result for toDataURL-supportedTypes.html as it should have the
same results on all platforms.
- platform/mac-tiger/fast/canvas: Removed.
- platform/mac-tiger/fast/canvas/toDataURL-supportedTypes-expected.txt: Removed.
- 1:15 PM Changeset in webkit [35299] by
-
- 9 edits in branches/XBL2/WebCore
WebCore:
2008-07-23 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 20056: [XBL] XBLCachedDocument cleanup
https://bugs.webkit.org/show_bug.cgi?id=20056
- Changed XBLDocument::create return to XBLDocument to match SVGDocument.
- Updated CachedXBLDocument methods to behave as the other CachedResourceClients.
- Fixed some coding style violation and variable names.
- XBL -> XBLDocument in CachedResource::Type enum.
- loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::getStatistics):
- loader/Cache.h:
- loader/CachedResource.h: (WebCore::CachedResource::): XBL -> XBLDocument as XBL was ambiguous.
- loader/CachedResourceClient.h: (WebCore::CachedResourceClient::setXBLDocument):
- loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument): (WebCore::CachedXBLDocument::~CachedXBLDocument): Removed deref() call as we use a RefPtr now.
(WebCore::CachedXBLDocument::addClient): Removed ref()
call replaced with addClient.
(WebCore::CachedXBLDocument::setEncoding):
(WebCore::CachedXBLDocument::data): Changed signature
and method to match other CachedResourceClients.
(WebCore::CachedXBLDocument::checkNotify):
- loader/CachedXBLDocument.h: Use a RefPtr<XBLDocument> instead of a raw XBLDocument.
(WebCore::CachedXBLDocument::document): Return a PassRefPtr.
- loader/loader.cpp: (WebCore::Loader::determinePriority):
- xbl/XBLDocument.h: (WebCore::XBLDocument::create): return an XBLDocument instead of a Document to match SVGDocument::create.
- 1:13 PM Changeset in webkit [35298] by
-
- 10 edits in trunk/WebCore
2008-07-23 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove extraneous allocations by using equalIgnoringCase rather than
String::lower.
- dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch):
- html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::getNamedFormItem):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::containsJavaApplet):
- html/PreloadScanner.cpp: (WebCore::PreloadScanner::emitCSSRule):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createJavaAppletWidget):
- page/DOMSelection.cpp: (WebCore::DOMSelection::modify):
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
- 1:12 PM Changeset in webkit [35297] by
-
- 2 edits in trunk/WebCore
2008-07-23 Maxime Britto <britto@apple.com>
Reviewed by Adam Roben.
<rdar://6092952> "REGRESSION: Crash beneath EventHandler::stopAutoscrollTimer() when closing Gmail"
Add a check for the m_page member value before asking for page()->mainFrame()
- page/EventHandler.cpp: (WebCore::EventHandler::stopAutoscrollTimer):
- 11:16 AM Changeset in webkit [35296] by
-
- 2 edits in trunk/WebCore
2008-07-23 Kevin Calhoun <kcalhoun@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/5710065> QT movies should be inactive when opened
Implemented deferral of set-up of video rendering on Mac until the ready state is Loaded and
until after movie tracks of unsupported types have been disabled, to make sure they never draw.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::setVisible):
- 9:48 AM Changeset in webkit [35295] by
-
- 3 edits in trunk/WebCore
2008-07-22 Maxime Britto <britto@apple.com>
Reviewed by John Sullivan.
<rdar://problem/6083116>
When pan-scrolling, Back then Forward causes pan-scrolling to start again
- page/Frame.cpp: (WebCore::Frame::clearTimers): Ask to stop the autoscroll timer when we clear the timers from the frame
- loader/FrameLoader.cpp: (WebCore::FrameLoader::scrollToAnchor): When the link is an anchor we Frame::clearTimers() isn't called since we're only scrolling the page so we need to ask to stop the autoscroll timer here too.
- 8:00 AM Changeset in webkit [35294] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-23 Gabor Loki <loki@inf.u-szeged.hu>
Bug 20097: [Qt] 20% Sunspider slow-down
Reviewed by Simon Hausmann.
- kjs/jsc.pro: Added missing NDEBUG define for release builds.
- 3:15 AM Changeset in webkit [35293] by
-
- 9 edits1 add in trunk
Reviewed by Geoff Garen.
JSClassRef is created context-free, but gets infatuated with the first context it sees.
The implicit API contract is that JSClassRef can be used with any context on any thread.
This no longer worked, because UStrings in the class were turned into per-context
identifiers, and the cached JSObject prototype was tied to JSGlobalData, too.
- 1:21 AM Changeset in webkit [35292] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- kjs/ArgList.h: (KJS::ArgList::operator new): removed an extraneous "ArgList::" inside the class definition.
Jul 22, 2008:
- 10:10 PM Changeset in webkit [35291] by
-
- 84 edits in trunk
2008-07-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Sam Weinig.
Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.
This means a few things:
- Register::jsValue() clients, including ArgList clients, must now supply an ExecState* when accessing an entry in an ArgList, in case the entry will need to create a JSValue* on the fly.
- Register clients that definitely don't want to create a JSValue* on the fly now use different APIs: getJSValue() for clients that know the register contains a JSValue*, and v() for clients who just want a void*.
- I had to change some headers around in order to resolve dependency problems created by using a Register in the ArgList header.
SunSpider reports no change.
JavaScriptGlue:
2008-07-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Sam Weinig.
Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.
WebCore:
2008-07-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Sam Weinig.
Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.
- 8:11 PM Changeset in webkit [35290] by
-
- 5 edits1 move in trunk
WebCore:
2008-07-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
<rdar://problem/5788451> toDataURL not implemented for Windows (need mapping of MIME type to UTI)
Add additional support for JPEG and GIF for toDataURL encoding canvases.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::utiFromMIMEType):
LayoutTests:
2008-07-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
<rdar://problem/5788451> toDataURL not implemented for Windows (need mapping of MIME type to UTI)
Add additional support for JPEG and GIF for toDataURL encoding canvases.
- Turn on and simplify toDataURL-supportedTypes.html to only test for support of mimeTypes and not fail due to differences in image encoders.
- fast/canvas/toDataURL-supportedTypes-expected.txt:
- fast/canvas/toDataURL-supportedTypes.html: Copied from fast/canvas/toDataURL-supportedTypes.html-disabled.
- fast/canvas/toDataURL-supportedTypes.html-disabled: Removed.
- 2:45 PM Changeset in webkit [35289] by
-
- 3 edits2 adds in trunk
<rdar://problem/6004877> internal anchors on this page are not showing up in the AXLinkedUIElements
- 2:28 PM BuildingGtk edited by
- (diff)
- 1:23 PM Changeset in webkit [35288] by
-
- 2 edits in trunk/WebCore
2008-07-22 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Allocate the empty StringImpl from the heap.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::empty):
- 10:25 AM Changeset in webkit [35287] by
-
- 4 edits in trunk/WebCore
2008-07-21 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/5951532> JSProfiler: Implement heavy (or bottom-up)
view (19228)
- Implement UI for Heavy (Bottom Up) view.
- English.lproj/localizedStrings.js:
- page/JavaScriptProfile.cpp: Expose the ability to get a heavy/tree profile from a profile to the Web Inspector's JavaScript. (WebCore::getHeavyProfileCallback): (WebCore::getTreeProfileCallback): (WebCore::ProfileClass):
- page/inspector/ProfileView.js: Implement the dropdown for changing profile views.
- page/inspector/inspector.css:
- 8:51 AM Changeset in webkit [35286] by
-
- 5 edits in trunk
Reviewed by Adam Roben.
<rdar://problem/5955602> WebKit should support charset name x-windows-949
Test: fast/encoding/char-decoding.html
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Added support for this name for Firefox compatibility.
- 7:26 AM Changeset in webkit [35285] by
-
- 3 edits1 add in trunk
2008-07-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Alexey Proskuryakov.
Prevent integer overflow when reallocating storage vector for arrays.
Sunspider reports 1.005x as fast (no change expected).
- kjs/JSArray.cpp:
WebCore:
2008-07-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Alexey Proskuryakov.
New test to check that arrays fail gracefully (throw an out of memory exception)
when the vector grows to large.
- manual-tests/array-out-of-memory.html: Added.
Jul 21, 2008:
- 10:52 PM Changeset in webkit [35284] by
-
- 3 edits2 adds in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=20117
setBaseAndExtent fails to reverse the current selection
Test: editing/selection/setBaseAndExtent-revert-selection.html
- editing/Selection.h: (WebCore::operator==): Compare direction, too.
- 9:35 PM Changeset in webkit [35283] by
-
- 2 edits in trunk/WebKit/wx
wx build fix. Fix pthread linkage under Linux.
- 6:43 PM Changeset in webkit [35282] by
-
- 6 edits in trunk/WebCore
WebCore:
2008-07-21 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Sam Weinig.
Bug 19919: Add selectors' string parsing in CSSParser
https://bugs.webkit.org/show_bug.cgi?id=19919
No functional change.
- css/CSSGrammar.y: Added entry for parsing only a selector.
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSelector):
- css/CSSParser.h: Added m_floatingSelector to hold the Selector parsed in parseSelector.
- css/tokenizer.flex: Added "@-webkit-selector" token.
- dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll): Switched to parseSelector method.
- 6:19 PM Changeset in webkit [35281] by
-
- 2 edits in trunk/WebCore
2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6081160> REGRESSION: Hang loading many pages if QuickTime isn't installed
- platform/graphics/win/QTMovieWin.cpp: (initializeSupportedTypes): Do a Quicktime version minimum version check. (QTMovieWin::initializeQuickTime): Store the Quicktime version globally so in can be used in initializeSupportedTypes as well.
- 6:09 PM Changeset in webkit [35280] by
-
- 2 edits in trunk/WebCore
2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/5713336> <video> and <audio> elements that use a autoplay attribute fail to start playing when returning back to page
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache): Reset the ready state to DATA_UNAVAILABLE when saving to the cache so that everything starts back up normally when the page is retrieved from the cache.
- 6:06 PM Changeset in webkit [35279] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
Remove unused interface declaration.
- platform/network/mac/ResourceHandleMac.mm:
- 6:05 PM Changeset in webkit [35278] by
-
- 12 edits in trunk
<rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.
Reviewed by Sam Weinig.
- 6:02 PM Changeset in webkit [35277] by
-
- 5 edits in trunk/WebCore
2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6031039> don't disable track-types when media is in a standalone document
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::inMediaDocument): Added.
- platform/graphics/MediaPlayer.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::updateStates):
- 5:41 PM Changeset in webkit [35276] by
-
- 2 edits in trunk/WebCore
2008-07-21 Anders Carlsson <andersca@apple.com>
Reviewed by Jon.
Don't allow requests to be made when the document loader is stopping all loaders.
- plugins/PluginView.cpp: (WebCore::PluginView::load):
- 4:07 PM Changeset in webkit [35275] by
-
- 3 edits2 adds in trunk
WebKit/mac:
2008-07-21 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/5820667>
CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load
Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
LayoutTests:
2008-07-21 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/5820667>
CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load
- http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt: Added.
- http/tests/plugins/geturlnotify-from-npp-destroystream.html: Added.
- 1:23 PM Changeset in webkit [35274] by
-
- 3 edits in trunk/WebCore
2008-07-20 Maxime Britto <britto@apple.com>
Reviewed by John Sullivan.
[PFR] <rdar://problem/6080639> New middle click scrolling speed seems much slower than in FF
Accelerate and enhance the smoothness of the pan scrollling.
- page/EventHandler.cpp: Changed the TimerInterval from 0.1 to 0.05. The scrolling is way more fluid like this.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::panScrollFromPoint): Differentiate the speed within a 200 pixel side square, around the original click location to the speed for farther distances. This way we allow easyier handle when we are close to the center and very fast scrolling when we go far from the original point.
- 1:16 PM Changeset in webkit [35273] by
-
- 2 edits4 adds in trunk
2008-07-18 David Hyatt <hyatt@apple.com>
Change the cached clip rects to not assume they should be infinite when the root layer has been
shifted as the result of a transformation.
Reviewed by Maciej
Added fast/transforms/overflow-with-transform.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects):
- 1:15 PM Changeset in webkit [35272] by
-
- 5 edits2 adds in trunk
Reviewed by Mitz.
https://bugs.webkit.org/show_bug.cgi?id=19966
CSS variables crash when using hex notation for colors
Support hex colors as values for the css variables.
Test: fast/css/variables/color-hex-test.html
- 11:29 AM Changeset in webkit [35271] by
-
- 2 edits in trunk/WebKitSite
Update Akismet plugin to 2.1.6.
- 11:16 AM Changeset in webkit [35270] by
-
- 225 edits43 adds in trunk/WebKitSite
Update to WordPress 2.6.
- 10:43 AM Changeset in webkit [35269] by
-
- 2 edits in trunk/JavaScriptCore
Add Vector::find
This is a convenience wrapper around std::find.
Reviewed by Anders Carlsson.
- wtf/Vector.h:
- 8:13 AM Changeset in webkit [35268] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/5624143> WebView printing doesn't work correctly in x86_64
Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
This prevents a garbage value being used for the scale factor that the NSView print machinery applies.
Reviewed by Adam Roben.
- WebView/WebHTMLView.mm:
- 8:13 AM Changeset in webkit [35267] by
-
- 2 edits in trunk/WebKit/mac
Fix CallDelegateReturningFloat for x86_64.
The x86_64 Objective-C runtime only uses objc_msgSend_fpret for
long double return values. For float return values the standard
objc_msgSend is used, as on ppc and ppc64.
Reviewed by Adam Roben.
- WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of
objc_msgSend with the correct return type. We can no longer call it objc_msgSend_fpret
as that method is defined by the Objective-C runtime for x86_64.
(CallDelegateReturningFloat):
- 7:45 AM Changeset in webkit [35266] by
-
- 9 edits3 deletes in trunk
Roll out r35261
- 6:47 AM Changeset in webkit [35265] by
-
- 2 edits in trunk/WebCore
2008-07-21 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Fix drawing of windowless plugins on Windows with the Qt port by
avoiding the reset of the translation of the HDC to 0, 0.
- 6:46 AM Changeset in webkit [35264] by
-
- 2 edits in trunk/WebCore
2008-07-21 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Fix rendering of transparent windowless netscape plugins by passing
the right conversion parameter to QPixmap::fromWinHBITMAP when
converting from HBITMAP to QPixmap.
- 6:46 AM Changeset in webkit [35263] by
-
- 2 edits in trunk/WebCore
2008-07-21 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
In the implementation of getValue for NPNVnetscapeWindow treat
windowHandleForPlatformWidget on the return value of
containingWindow() to receive the correct HWND for the Qt port.
- 6:46 AM Changeset in webkit [35262] by
-
- 2 edits in trunk/WebCore
2008-07-21 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Fix windowHandleForPlatformWidget to return 0 as HWND if we don't have
a QWidget. This can happen on page/view destruction for example.
- 2:34 AM Changeset in webkit [35261] by
-
- 12 edits in trunk
WebCore:
2008-07-21 Anatoli Papirovski <apapirovski@mac.com>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=14346
Modified the css parser:
- not to fail when closing braces are not found for a declaration at the end of the file
- not to accept "!important fail" as valid
- to keep accepting @import when it comes after invalid @ rules
- not to drop the whole @media block when there's an error before the closing brace + some other minor css parsing revisions.
- css/CSSGrammar.y:
LayoutTests:
2008-07-21 Anatoli Papirovski <apapirovski@mac.com>
Reviewed by Dave Hyatt.
Updated layout CSS2.1 test suite tests related to css parsing:
https://bugs.webkit.org/show_bug.cgi?id=14346
- platform/mac/css2.1/t040105-import-01-b-expected.checksum:
- platform/mac/css2.1/t040105-import-01-b-expected.png:
- platform/mac/css2.1/t040105-import-01-b-expected.txt:
- platform/mac/css2.1/t0402-syntax-05-f-expected.checksum:
- platform/mac/css2.1/t0402-syntax-05-f-expected.png:
- platform/mac/css2.1/t0402-syntax-05-f-expected.txt:
- platform/mac/css2.1/t0402-syntax-06-f-expected.checksum:
- platform/mac/css2.1/t0402-syntax-06-f-expected.png:
- platform/mac/css2.1/t0402-syntax-06-f-expected.txt:
Jul 20, 2008:
- 8:39 PM Changeset in webkit [35260] by
-
- 2 edits in trunk/WebCore
Touch file to force rebuild for vsprops change.
- WebCorePrefix.h:
- 8:38 PM Changeset in webkit [35259] by
-
- 2 edits in trunk/WebKitLibraries
Build fix.
- win/tools/vsprops/common.vsprops:
- 6:37 PM Changeset in webkit [35258] by
-
- 1 edit1 add in trunk/LayoutTests
Whoops, forgot to commit expected output for this test.
RS=Dan Bernstein
- 4:39 PM Changeset in webkit [35257] by
-
- 2 edits in trunk/WebCore
2008-07-20 Sam Weinig <sam@webkit.org>
Remove extra space Oliver Hunt left in.
- page/Console.cpp: (WebCore::Console::reportException): (WebCore::Console::reportCurrentException):
- 2:31 PM Changeset in webkit [35256] by
-
- 2 edits in trunk/WebCore
Bug 19757: Crash when an ondragstart handler hides the element
<https://bugs.webkit.org/show_bug.cgi?id=19757>
Reviewed by Dan Bernstein.
The solution to this is problem is just to null check the renderer
immediately before launching the system drag, and terminate the
drag if the renderer is gone.
- 1:48 PM Changeset in webkit [35255] by
-
- 6 edits4 adds in trunk
Reviewed by Oliver.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=12171
Remove manual SVG property <-> XML attribute synchronization in SVGPolyElement.
Added svg/custom/poly-points-attribute-changes.svg (testcase from Rob)
- 1:40 PM Changeset in webkit [35254] by
-
- 6 edits in trunk/WebCore
Reviewed by Oliver.
Cleanup JSSVGPODTypeWrapper code.
- 5:43 AM Changeset in webkit [35253] by
-
- 28 edits2 adds in trunk
Bug 15979: Console logs in a database callback lose line number information
<https://bugs.webkit.org/show_bug.cgi?id=15979>
Reviewed by Mark Rowe
The problem was that there were multiple versions of the logic to
log an exception to the console, many of which were incorrect. We
resolve this by making one single shared reportException method,
which handles the exceptions correctly.
This improves fidelity of callback errors, and ensures that
exceptions thrown in timer callbacks correctly report line numbers,
etc.
Test: fast/js/exceptions-thrown-in-callbacks.html
- 4:46 AM Changeset in webkit [35252] by
-
- 2 edits in trunk/WebCore
Rubber stamped by Oliver.
Another attempt to fix the win build.
- 2:24 AM Changeset in webkit [35251] by
-
- 2 edits in trunk/WebCore
Reviewed by David Kilzer.
Fix high CPU usage on testmyiphone.com.
- Made the logic for determining when to stop looking for meta charset more strainghtforward. Previously, this happened if a tag that's disallowed in HEAD was seen past the first 512 bytes. Now, the algorithm bails out at the boundary if we are lo longer in HEAD (i.e, an offending tag was seen at any point before).
- The above change made one of our regression tests fail, because it had its <meta> declaration past the 512 byte boundary. Fixed it by raising the boundary to 1024 bytes.
- Made the algorithm bail out quickly if a comment that's not in HEAD crosses the boundary.
- Moved a check for XML content type out of the loop.
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
- 12:05 AM FAQ edited by
- (diff)
Jul 19, 2008:
- 10:29 PM Changeset in webkit [35250] by
-
- 8 edits in trunk
Bug 20104: Exception in tables/mozilla_expected_failures/bugs/bug92868_1.html includes the equals operator in the quoted expression
<https://bugs.webkit.org/show_bug.cgi?id=20104>
Reviewed by Cameron Zwarich
To make this correct we make the dot and bracket assign nodes emit the information to indicate
the failure range is the dot/bracket accessor.
- 3:05 PM Changeset in webkit [35249] by
-
- 2 edits in trunk/WebCore
Attempt to fix windows build.
- 8:46 AM Changeset in webkit [35248] by
-
- 116 edits1 add in trunk/WebCore
Reviewed by Oliver & parts by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20051
Rewrite animated property concept without heavy macro usage, replace by a templatified solution.
Fewer virtual function calls, no more usage of the tear-off's within internal code (synchronization needed it before.)
Jul 18, 2008:
- 9:40 PM Changeset in webkit [35247] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- kjs/JSGlobalObjectFunctions.cpp: (KJS::isStrWhiteSpace):
- 9:11 PM Changeset in webkit [35246] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- kjs/nodes.h: (KJS::ThrowableExpressionData::ThrowableExpressionData):
- 6:44 PM Changeset in webkit [35245] by
-
- 37 edits2 adds in trunk
Bug 18774: SQUIRRELFISH: print meaningful error messages <https://bugs.webkit.org/show_bug.cgi?id=18774>
<rdar://problem/5769353> SQUIRRELFISH: JavaScript error messages are missing informative text
Reviewed by Cameron Zwarich
Add support for decent error messages in JavaScript. This patch achieves this by providing
ensuring the common errors and exceptions have messages that provide the text of expression
that trigger the exception. In addition it attaches a number of properties to the exception
object detailing where in the source the expression came from.
- 6:36 PM Changeset in webkit [35244] by
-
- 8 edits3 adds in trunk
2008-07-18 Maxime Britto <britto@apple.com>
Reviewed by Adele.
Fixed <rdar://problem/6049803>
Prevent the autoscroll to trigger in WebClips when starting or hovering on an editable field.
Test: fast/events/autoscroll-with-non-scrollable-parent.html
- ChangeLog:
- page/EventHandler.cpp: Edited (WebCore::EventHandler::handleMousePressEvent): changed the name of the funtion called to canBeProgramaticallyScrolled() (WebCore::EventHandler::handleMouseDraggedEvent): prevent the autoscroll to keep looking for a renderer when it's already triggered
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): verifies that the top layer can be programmatically scrolled before asking him to make the rect visible
- rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
- rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): Edited : For the 3rd case we want document's renderer to have scrollbar as it's the top layer (WebCore::RenderObject::hasScrollableView): Verifies that the Object has a view with scrollBars
- rendering/RenderObject.h: Renamed shouldAutosroll() for canBeProgramaticallyScrolled()
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):
2008-07-18 Adele Peterson & Maxime Britto <britto@apple.com>
Reviewed by Adele.
Test for <rdar://problem/6049803> Autoscroll triggered on no scrolling iframes
- ChangeLog:
- fast/events/autoscroll-with-non-scrollable-parent-expected.txt: Added.
- fast/events/autoscroll-with-non-scrollable-parent.html: Added.
- fast/events/resources/big-page-with-input.html: Added.
- 5:22 PM Changeset in webkit [35243] by
-
- 4 edits in trunk/WebCore
2008-07-18 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
<rdar://problem/6087283> Add support for uploading files via XMLHttpRequest
- Overload XMLHttpRequests send() method to accept File tokens.
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
- xml/XMLHttpRequest.h:
- 3:18 PM Changeset in webkit [35242] by
-
- 34 edits in trunk
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Three renames:
"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"
JavaScriptGlue:
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Three renames:
"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"
- ChangeLog:
- JSObject.cpp: (JSUserObject::getCallData):
WebCore:
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Three renames:
"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"
- 3:15 PM Changeset in webkit [35241] by
-
- 2 edits in trunk/WebCore
2008-07-18 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
I recently made a change to avoid fading media controls in and out if a video element actually only contains audio,
which broke the code that did the same thing for audio elements that contain video (but don't actually display that video).
This change will now check both the media element and the player to decide whether or not to make the controls persistent.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControlVisibility):
- 3:04 PM Changeset in webkit [35240] by
-
- 2 edits in trunk/WebCore
2008-07-18 Simon Fraser <Simon Fraser>
Reviewed by mitz
Remove braces around single-line conditional.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform):
- 2:59 PM Changeset in webkit [35239] by
-
- 5 edits in trunk
2008-07-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
getComputedStyle() for -webkit-transform should return
'none' for elements with no renderer, or those with no
transform.
Testcase: LayoutTests/fast/css/computed-style-without-renderer
LayoutTests/fast/css/computed-style-expected.txt
- 2:44 PM Changeset in webkit [35238] by
-
- 2 edits in trunk/WebCore
2008-07-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Fix assertion about creating Length values with percentage types
when blending transforms.
https://bugs.webkit.org/show_bug.cgi?id=20086
- 2:25 PM Changeset in webkit [35237] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Optimized <= for immediate number cases.
SunSpider reports no overall change, but a 10% speedup on access-nsieve.
- 2:03 PM Changeset in webkit [35236] by
-
- 3 edits in trunk/JavaScriptCore
Fix some casts added in a previous build fix to match the style used
throughout WebKit.
Rubber-stamped by Sam Weinig.
- VM/Machine.cpp:
(KJS::Machine::initializeCallFrame):
- VM/Register.h:
(KJS::Register::Register):
- 11:31 AM Changeset in webkit [35235] by
-
- 2 edits in trunk/LayoutTests
Update expected results for a recently added test to what is seen when running the
full test suite.
- fast/forms/form-and-frame-interaction-retains-values-expected.txt:
- 8:31 AM Changeset in webkit [35234] by
-
- 7 edits in trunk
Bug 19975: [OpenBSD] Patches to enable build of WebKit
2008-07-18 Landry Breuil <landry@openbsd.org>
Bug 19975: [OpenBSD] Patches to enable build of WebKit
Reviewed by David Kilzer.
Support for OpenBSD, mostly threading and libm tweaks.
- kjs/collector.cpp: #include <pthread.h> (KJS::currentThreadStackBase): use pthread_stackseg_np() to get stack base
- kjs/config.h: OpenBSD also provides <pthread_np.h>
- wtf/MathExtras.h: #include <sys/types.h> and <machine/ieee.h> (isfinite), (signbit): as long as we don't have those functions provide fallback implementations
- wtf/Platform.h: Add support for PLATFORM(OPENBSD) and PLATFORM(SPARC64) macro
WebKitTools:
2008-07-18 Landry Breuil <landry@openbsd.org>
Bug 19975: [OpenBSD] Patches to enable build of WebKit
Reviewed by David Kilzer.
- DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
- 8:21 AM Changeset in webkit [35233] by
-
- 2 edits in trunk/WebKitSite
Fixed indentation of example code for C++ pointers/references!
- coding/coding-style.html:
- 8:15 AM Changeset in webkit [35232] by
-
- 2 edits in trunk/WebKitSite
2008-07-18 Robert Blaut <webkit@blaut.biz>
Reviewed by David Kilzer.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=12313>
Added code style guidelines for multi-line boolean expressions
- coding/coding-style.html:
Jul 17, 2008:
- 9:00 PM Changeset in webkit [35231] by
-
- 7 edits in trunk/JavaScriptCore
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Next step toward putting doubles in registers: Store constant pool
entries as registers, not JSValue*s.
SunSpider reports no change.
- 4:53 PM Changeset in webkit [35230] by
-
- 3 edits in trunk/JavaScriptCore
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by John Sullivan and Oliver Hunt.
A tiny bit of tidying in function call register allocation.
This patch saves one register when invoking a function expression and/or
a new expression that is stored in a temporary.
Since it's just one register, I can't make a testcase for it.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitCall): No need to ref the function we're calling or its base. We'd like the call frame to overlap with them, if possible. op_call will read the function and its base before writing the call frame, so this is safe.
- kjs/nodes.cpp: (KJS::NewExprNode::emitCode): No need to ref the function we're new-ing, for the same reasons stated above.
(KJS::FunctionCallValueNode::emitCode): ditto
- 3:28 PM Changeset in webkit [35229] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-17 Steve Falkenburg <sfalken@apple.com>
Build fix.
- kjs/InternalFunction.cpp:
- 2:42 PM Changeset in webkit [35228] by
-
- 5 edits3 adds in trunk
2008-07-17 Sam Weinig <sam@webkit.org>
Roll out r35199 as it is causing failures on the PPC build.
LayoutTests:
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by David Kilzer.
Test for https://bugs.webkit.org/show_bug.cgi?id=20067
Support function.name (Firefox extension)
- fast/js/function-name-expected.txt: Added.
- fast/js/function-name.html: Added.
- fast/js/resources/function-name.js: Added.
- 2:11 PM Changeset in webkit [35227] by
-
- 6 edits in trunk/JavaScriptCore
2008-07-17 Sam Weinig <sam@webkit.org>
Roll out r35199 as it is causing failures on the PPC build.
- 1:39 PM Changeset in webkit [35226] by
-
- 3 edits3 adds in trunk
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed <rdar://problem/6081636> Functions calls use more temporary
registers than necessary
Holding a reference to the last statement result register caused each
successive statement to output its result to an even higher register.
Happily, statements don't actually need to return a result register
at all. I hope to make this clearer in a future cleanup patch,
but this change will fix the major bug for now.
- kjs/nodes.cpp: (KJS::statementListEmitCode):
LayoutTests:
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Test for <rdar://problem/6081636> Functions calls use more temporary
registers than necessary
- fast/js/function-call-register-allocation.html: Added.
- fast/js/function-call-register-allocation-expected.txt: Added.
- fast/js/resources/function-call-register-allocation.js: Added.
- 12:49 PM Changeset in webkit [35225] by
-
- 4 edits2 adds in trunk
Reviewed by rwlbuis@gmail.com
- Added "@"{ident} rule (below other @-rules) to use flex for longest match (if an earlier rule - e.g. @media - also matches then flex chooses that one
however, if a longer match - e.g. @mediaall matches flex will choose that)
- Updated grammar to defined ATKEYWORD token and to use that instead of '@' in the error recovery grammar.
Test: css2.1/atrule_longest_match.html
- 12:24 PM Changeset in webkit [35224] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Merge pre&post dot nodes to simplify the parse tree.
Sunspider results show 0.6% progression (no performance change expected).
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 11:24 AM Changeset in webkit [35223] by
-
- 2 edits in trunk/WebCore
2008-07-17 David Hyatt <hyatt@apple.com>
Make sure the check to see if a frame/iframe is being rendered inside a transparency layer is
recursive (and checks for transparency layers all the way up the ancestor document chain back to
the top-level frame).
Reviewed by Dan
- rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
- 6:25 AM Changeset in webkit [35222] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Cameron Zwarich.
Merge pre&post resolve nodes to simplify the parse tree.
Sunspider results show no performance change.
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 5:06 AM Changeset in webkit [35221] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Cameron Zwarich.
Merge logical nodes to simplify the parse tree.
Sunspider results show 0.6% progression (no performance change expected).
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 5:01 AM Changeset in webkit [35220] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix MinGW build (broken in r35198) and simplify getLocalTime().
- kjs/DateMath.cpp: (KJS::getLocalTime):
- 4:51 AM Changeset in webkit [35219] by
-
- 2 edits in trunk/WebKit/gtk
[GTK] WebKit crashes on invalid settings notify callback
https://bugs.webkit.org/show_bug.cgi?id=19813
Disconnect in webkit_web_view_finalize
Reviewed by Holger Freyther.
- 4:44 AM Changeset in webkit [35218] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Merge pre&post bracket nodes to simplify the parse tree.
Sunspider results show no performance change.
Reviewed by Sam Weinig.
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 4:34 AM Changeset in webkit [35217] by
-
- 3 edits in trunk/JavaScriptCore
2008-07-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix the 32-bit gcc builds, conversion from "long int" to Register is
ambiguous. Explicitly choose the intptr_t constructor.
- 12:18 AM Changeset in webkit [35216] by
-
- 2 edits in trunk/WebCore
Reviewed by mitz.
Attempt to make initializeATSUStyle human-readable by
splitting it out into better-named static inline functions.
No functional changes, thus no tests.
- platform/graphics/mac/FontMac.mm: (WebCore::fontHasMirroringInfo): (WebCore::disableLigatures): (WebCore::initializeATSUStyle):
- 12:17 AM Changeset in webkit [35215] by
-
- 2 edits in trunk/WebCore
No review, build fix only.
Attempt to fix Mac build
- WebCore.xcodeproj/project.pbxproj: Make TextRun.h a private header.
