Context Navigation

GNUmakefile.am:
JavaScriptCore.scons:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
assembler/X86Assembler.h:
runtime/RegExp.cpp:
wrec/CharacterClass.cpp: Copied from wrec/CharacterClassConstructor.cpp. (JSC::WREC::CharacterClass::newline): (JSC::WREC::CharacterClass::digits): (JSC::WREC::CharacterClass::spaces): (JSC::WREC::CharacterClass::wordchar): (JSC::WREC::CharacterClass::nondigits): (JSC::WREC::CharacterClass::nonspaces): (JSC::WREC::CharacterClass::nonwordchar):
wrec/CharacterClass.h: Copied from wrec/CharacterClassConstructor.h.
wrec/CharacterClassConstructor.cpp: (JSC::WREC::CharacterClassConstructor::addSortedRange): (JSC::WREC::CharacterClassConstructor::append):
wrec/CharacterClassConstructor.h:
wrec/Quantifier.h: Copied from wrec/WREC.h.
wrec/WREC.cpp: (JSC::WREC::compileRegExp):
wrec/WREC.h:
wrec/WRECFunctors.cpp: Copied from wrec/WREC.cpp.
wrec/WRECFunctors.h: Copied from wrec/WREC.cpp. (JSC::WREC::GenerateAtomFunctor::~GenerateAtomFunctor): (JSC::WREC::GeneratePatternCharacterFunctor::GeneratePatternCharacterFunctor): (JSC::WREC::GenerateCharacterClassFunctor::GenerateCharacterClassFunctor): (JSC::WREC::GenerateBackreferenceFunctor::GenerateBackreferenceFunctor): (JSC::WREC::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
wrec/WRECGenerator.cpp: Copied from wrec/WREC.cpp. (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateCharacterClass): (JSC::WREC::Generator::generateParentheses): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary):
wrec/WRECGenerator.h: Copied from wrec/WREC.h.
wrec/WRECParser.cpp: Copied from wrec/WREC.cpp. (JSC::WREC::Parser::parseGreedyQuantifier): (JSC::WREC::Parser::parseCharacterClassQuantifier): (JSC::WREC::Parser::parseParentheses): (JSC::WREC::Parser::parseCharacterClass): (JSC::WREC::Parser::parseEscape): (JSC::WREC::Parser::parseTerm):
wrec/WRECParser.h: Copied from wrec/WREC.h. (JSC::WREC::Parser::): (JSC::WREC::Parser::Parser): (JSC::WREC::Parser::setError): (JSC::WREC::Parser::error): (JSC::WREC::Parser::recordSubpattern): (JSC::WREC::Parser::numSubpatterns): (JSC::WREC::Parser::ignoreCase): (JSC::WREC::Parser::multiline):

4:46 PM Changeset in webkit [38543] by Nikolas Zimmermann

5 edits in trunk/WebCore

Reviewed by Mark Rowe.

Remove WBXML code. MainResourceLoader is not an appropriate location.
Revert until we find a better place.

The mime type which belongs to wmlc should be enabled anyway so WML documents get build.
Remove the ENABLE(WBXML) blocks around these types in MIMETypeRegistry / DOMImplementation.

4:23 PM Changeset in webkit [38542] by Nikolas Zimmermann

2 edits in trunk/WebCore

Not reviewed. Build fix.
Oops, disable WML by default on Qt.

4:04 PM Changeset in webkit [38541] by Nikolas Zimmermann

33 edits
84 adds in trunk

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22324 (Add basic subset of WML elements)

Add first bits of WML support. Only <card> & <p> and <a> elements are supported in this first patch.
Support for most other elements will be added step-by-step (merging in small chunks from a big patch).

WML is not build by default. Enabling possible in Qt, Gtk & Mac. Win/Wx are TODO.

3:57 PM Changeset in webkit [38540] by mitz@apple.com

3 edits in trunk/LayoutTests

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=22320 SVG svg/text/text-text-08-b.svg fails

Updated the expected results to the correct ones.

platform/mac/svg/text/text-text-08-b-expected.checksum:
platform/mac/svg/text/text-text-08-b-expected.png:

3:50 PM Changeset in webkit [38539] by ggaren@apple.com

2 edits in trunk/WebKitSite

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig and Antti Koivisto.

Clarified the last coding style rule, which was a baffling in its
initial form.

(Now let's see if our code ever starts following this rule!)

coding/coding-style.html:

3:39 PM Changeset in webkit [38538] by beidson@apple.com

2 edits in trunk/WebKitSite

2008-11-17 Brady Eidson <beidson@apple.com>

Reviewed by Mark Rowe

Clarify an edge case for acronym capitalization.

coding/coding-style.html:

3:37 PM Changeset in webkit [38537] by ggaren@apple.com

2 edits in trunk/WebKit/qt

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix qt build.

Api/qwebframe.cpp:

3:36 PM Changeset in webkit [38536] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix a few builds.

JavaScriptCoreSources.bkl:

3:35 PM Changeset in webkit [38535] by ggaren@apple.com

2 edits in trunk/WebKitTools

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix gtk build.

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId):

3:24 PM Changeset in webkit [38534] by ggaren@apple.com

4 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix a few builds.

JavaScriptCore.pri:
JavaScriptCore.scons:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

3:23 PM Changeset in webkit [38533] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

3:20 PM Changeset in webkit [38532] by mrowe@apple.com

1 copy in tags/Safari-5525.27.1

New tag.

3:16 PM Changeset in webkit [38531] by ggaren@apple.com

18 edits
2 copies
1 add
1 delete in trunk

JavaScriptCore:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved VM/CTI.* => jit/JIT.*.

Removed VM.

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.scons:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
VM/CTI.cpp: Removed.
VM/CTI.h: Removed.
bytecode/CodeBlock.cpp:
interpreter/Interpreter.cpp:
jit: Added.
jit/JIT.cpp: Copied from VM/CTI.cpp.
jit/JIT.h: Copied from VM/CTI.h.
runtime/RegExp.cpp:

WebCore:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore renames.

WebCore.pro:
webcore-base.bkl:

WebKit/wx:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore renames.

presets/wxwebkit.bkl:

2:58 PM Changeset in webkit [38530] by ggaren@apple.com

2 edits in trunk/WebKit/mac

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Mac build.

WebView/WebScriptDebugDelegate.mm:

2:40 PM Changeset in webkit [38529] by justin.garcia@apple.com

4 edits
2 adds in trunk

WebCore:

2008-11-17 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/4922709> Copying less than a paragraph of quoted text and pasting it doesn't retain quote level

There was code to intentionally avoid quoting pasted content if less than a paragraph of
it was copied. That was added for <rdar://problem/5006779>, but was unnecessary because
that bug was about Paste and Match style for single paragraphs. And quote stripping for
Paste and Match style is handled elsewhere.

editing/markup.cpp: (WebCore::createMarkup):

LayoutTests:

2008-11-17 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/4922709> Copying less than a paragraph of quoted text and pasting it doesn't retain quote level

editing/pasteboard/4922709-expected.txt: Added.
editing/pasteboard/4922709.html: Added.
editing/pasteboard/5006779.html:

2:11 PM Changeset in webkit [38528] by ggaren@apple.com

35 edits
4 moves in trunk

JavaScriptCore:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved runtime/ExecState.* => interpreter/CallFrame.*.

API/JSBase.cpp:
API/OpaqueJSString.cpp:
GNUmakefile.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
debugger/DebuggerCallFrame.h:
interpreter/CallFrame.cpp: Copied from runtime/ExecState.cpp.
interpreter/CallFrame.h: Copied from runtime/ExecState.h.
interpreter/Interpreter.cpp:
parser/Nodes.cpp:
profiler/ProfileGenerator.cpp:
profiler/Profiler.cpp:
runtime/ClassInfo.h:
runtime/Collector.cpp:
runtime/Completion.cpp:
runtime/ExceptionHelpers.cpp:
runtime/ExecState.cpp: Removed.
runtime/ExecState.h: Removed.
runtime/Identifier.cpp:
runtime/JSFunction.cpp:
runtime/JSGlobalObjectFunctions.cpp:
runtime/JSLock.cpp:
runtime/JSNumberCell.h:
runtime/JSObject.h:
runtime/JSString.h:
runtime/Lookup.h:
runtime/PropertyNameArray.h:

JavaScriptGlue:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore rename.

ForwardingHeaders/runtime/CallFrame.h: Copied from JavaScriptGlue/ForwardingHeaders/runtime/ExecState.h.
ForwardingHeaders/runtime/ExecState.h: Removed.
config.h:

WebCore:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore rename.

ForwardingHeaders/interpreter/CallFrame.h: Copied from WebCore/ForwardingHeaders/runtime/ExecState.h.
ForwardingHeaders/runtime/ExecState.h: Removed.
bindings/objc/WebScriptObject.mm:
bridge/c/c_instance.cpp:
bridge/jni/jni_jsobject.mm:
dom/Node.cpp:
dom/NodeFilter.cpp:
dom/NodeIterator.cpp:
dom/TreeWalker.cpp:
inspector/JavaScriptCallFrame.h:

2:10 PM Changeset in webkit [38527] by dino@apple.com

2 edits in trunk/WebKitTools

2008-11-17 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Maciej.

Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
on Tiger.

https://bugs.webkit.org/show_bug.cgi?id=22271

Scripts/run-webkit-tests:

2:05 PM Changeset in webkit [38526] by dino@apple.com

20 edits
5 adds in trunk

WebCore:
2008-11-17 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Sam Weinig.

Added functionality to AnimationController to allow pausing a running
animation or transition at a given time for testing purposes.

https://bugs.webkit.org/show_bug.cgi?id=21261

Tests: animations/animation-drt-api.html

transitions/transition-drt-api.html

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:
page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine): (WebCore::AnimationBase::progress): (WebCore::AnimationBase::pauseAtTime):
page/animation/AnimationBase.h:
page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::pauseAnimationAtTime): (WebCore::AnimationControllerPrivate::pauseTransitionAtTime): (WebCore::AnimationController::pauseAnimationAtTime): (WebCore::AnimationController::pauseTransitionAtTime):
page/animation/AnimationController.h:
page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::isAnimating): (WebCore::CompositeAnimationPrivate::pauseAnimationAtTime): (WebCore::CompositeAnimationPrivate::pauseTransitionAtTime): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::pauseTransitionAtTime):
page/animation/CompositeAnimation.h:
page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::animate):

WebKit/mac:
2008-11-17 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Sam Weinig.

Added SPI to allow pausing a running CSS transition or animation
at a given time for testing purposes.

https://bugs.webkit.org/show_bug.cgi?id=21261

WebView/WebFrame.mm: (-[WebFrame _pauseAnimation:onNode:atTime:]): (-[WebFrame _pauseTransitionOfProperty:onNode:atTime:]):
WebView/WebFramePrivate.h:

WebKitTools:
2008-11-17 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Sam Weinig.

Added new JavaScript API on LayoutController to pause a running
CSS transition or animation at a given time.

https://bugs.webkit.org/show_bug.cgi?id=21261

DumpRenderTree/LayoutTestController.cpp: (pauseAnimationAtTimeOnElementWithIdCallback): (pauseTransitionAtTimeOnElementWithIdCallback): (LayoutTestController::staticFunctions):
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId):

LayoutTests:
2008-11-17 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Sam Weinig.

Added tests to cover the new LayoutController JavaScript API available
in DRT (Mac only).

https://bugs.webkit.org/show_bug.cgi?id=21261

animations/animation-drt-api.html: Added.
platform/mac/animations/animation-drt-api-expected.txt: Added.
platform/mac/transitions/transition-drt-api-expected.txt: Added.
platform/win/Skipped:
transitions/transition-drt-api.html: Added.

1:53 PM Changeset in webkit [38525] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

API/APICast.h:

1:51 PM Changeset in webkit [38524] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

API/APICast.h:
runtime/ExecState.h:

1:44 PM Changeset in webkit [38523] by ggaren@apple.com

8 edits
2 moves in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved VM/SamplingTool.* => bytecode/SamplingTool.*.

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.scons:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
VM/SamplingTool.cpp: Removed.
VM/SamplingTool.h: Removed.
bytecode/SamplingTool.cpp: Copied from VM/SamplingTool.cpp.
bytecode/SamplingTool.h: Copied from VM/SamplingTool.h.
jsc.cpp: (runWithScripts):

1:35 PM Changeset in webkit [38522] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

runtime/ExecState.h:

1:34 PM Changeset in webkit [38521] by ggaren@apple.com

7 edits
1 move in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved VM/ExceptionHelpers.cpp => runtime/ExceptionHelpers.cpp.

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.scons:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
VM/ExceptionHelpers.cpp: Removed.
runtime/ExceptionHelpers.cpp: Copied from VM/ExceptionHelpers.cpp.

1:29 PM Changeset in webkit [38520] by ggaren@apple.com

8 edits
1 move in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved VM/RegisterFile.cpp => interpreter/RegisterFile.cpp.

AllInOneFile.cpp:
GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.scons:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
VM/RegisterFile.cpp: Removed.
interpreter/RegisterFile.cpp: Copied from VM/RegisterFile.cpp.

1:28 PM Changeset in webkit [38519] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch/WebKit/mac

Merge r31925.

1:28 PM Changeset in webkit [38518] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

1:22 PM Changeset in webkit [38517] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

1:20 PM Changeset in webkit [38516] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

JavaScriptCore.vcproj/jsc/jsc.vcproj:

1:19 PM Changeset in webkit [38515] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

1:09 PM Changeset in webkit [38514] by ggaren@apple.com

4 edits
3 moves in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved:

VM/ExceptionHelpers.h => runtime/ExceptionHelpers.h
VM/Register.h => interpreter/Register.h
VM/RegisterFile.h => interpreter/RegisterFile.h

GNUmakefile.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
VM/ExceptionHelpers.h: Removed.
VM/Register.h: Removed.
VM/RegisterFile.h: Removed.
interpreter/Register.h: Copied from VM/Register.h.
interpreter/RegisterFile.h: Copied from VM/RegisterFile.h.
runtime/ExceptionHelpers.h: Copied from VM/ExceptionHelpers.h.

1:03 PM Changeset in webkit [38513] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Qt build.

JavaScriptCore.pri:

1:02 PM Changeset in webkit [38512] by ggaren@apple.com

8 edits
1 move in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved VM/Machine.cpp => interpreter/Interpreter.cpp.

DerivedSources.make:
GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.scons:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
VM/Machine.cpp: Removed.
interpreter/Interpreter.cpp: Copied from VM/Machine.cpp.

12:57 PM Changeset in webkit [38511] by ggaren@apple.com

34 edits
1 copy
1 move
2 adds
1 delete in trunk

JavaScriptCore:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved VM/Machine.h => interpreter/Interpreter.h

GNUmakefile.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
VM/CTI.cpp:
VM/CTI.h:
VM/ExceptionHelpers.cpp:
VM/Machine.cpp:
VM/Machine.h: Removed.
VM/SamplingTool.cpp:
bytecode/CodeBlock.cpp:
bytecompiler/BytecodeGenerator.cpp:
bytecompiler/BytecodeGenerator.h:
debugger/DebuggerCallFrame.cpp:
interpreter: Added.
interpreter/Interpreter.h: Copied from VM/Machine.h.
profiler/ProfileGenerator.cpp:
runtime/Arguments.h:
runtime/ArrayPrototype.cpp:
runtime/Collector.cpp:
runtime/Completion.cpp:
runtime/ExecState.h:
runtime/FunctionPrototype.cpp:
runtime/JSActivation.cpp:
runtime/JSFunction.cpp:
runtime/JSGlobalData.cpp:
runtime/JSGlobalObject.cpp:
runtime/JSGlobalObjectFunctions.cpp:
wrec/WREC.cpp:

WebCore:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore renames.

ForwardingHeaders/VM: Removed.
ForwardingHeaders/VM/Machine.h: Removed.
ForwardingHeaders/interpreter: Added.
ForwardingHeaders/interpreter/Interpreter.h: Copied from ForwardingHeaders/VM/Machine.h.
WebCore.pro:
bindings/js/JSXMLHttpRequestCustom.cpp:
page/Console.cpp:
webcore-base.bkl:

WebKit/wx:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore renames.

presets/wxwebkit.bkl:

10:32 AM Changeset in webkit [38510] by ggaren@apple.com

2 edits in trunk/WebKit/wx

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix wx build.

presets/wxwebkit.bkl:

9:55 AM Changeset in webkit [38509] by ggaren@apple.com

24 edits
2 moves
2 deletes in trunk

JavaScriptCore:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved runtime/Interpreter.cpp => runtime/Completion.cpp.

Moved functions from Interpreter.h to Completion.h, and removed
Interpreter.h from the project.

API/JSBase.cpp:
AllInOneFile.cpp:
GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
jsc.cpp:
runtime/Completion.cpp: Copied from runtime/Interpreter.cpp.
runtime/Completion.h:
runtime/Interpreter.cpp: Removed.
runtime/Interpreter.h: Removed.

WebCore:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore renames.

ForwardingHeaders/runtime/Interpreter.h: Removed.
WebCore.vcproj/WebCore.vcproj:
bindings/js/JSDOMBinding.h:
bindings/js/WorkerScriptController.cpp:
bindings/objc/WebScriptObject.mm:
bridge/NP_jsobject.cpp:
bridge/jni/jni_jsobject.mm:
html/CanvasRenderingContext2D.cpp:
inspector/JavaScriptCallFrame.cpp:
page/Console.cpp:

WebKit/mac:

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore renames.

ForwardingHeaders/runtime/Completion.h: Copied from ForwardingHeaders/runtime/Interpreter.h.
ForwardingHeaders/runtime/Interpreter.h: Removed.
WebView/WebScriptDebugDelegate.mm:

9:36 AM Changeset in webkit [38508] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Darin Adler.

<https://bugs.webkit.org/show_bug.cgi?id=22312>
Fix PCRE include path problem on Qt-port

JavaScriptCore.pri:
pcre/pcre.pri:

9:34 AM Changeset in webkit [38507] by ggaren@apple.com

3 edits in trunk/WebKitTools

2008-11-17 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Darin Adler.

<https://bugs.webkit.org/show_bug.cgi?id=22309>
Pass the remaining options to build system on Qt-port

Scripts/build-webkit:
Scripts/webkitdirs.pm:

9:34 AM Changeset in webkit [38506] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Darin Adler.

<https://bugs.webkit.org/show_bug.cgi?id=22313>
Add missing CTI source to the build system on Qt-port

JavaScriptCore.pri:

9:31 AM Changeset in webkit [38505] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix JSGlue build.

JavaScriptCore.xcodeproj/project.pbxproj:

9:23 AM Changeset in webkit [38504] by ggaren@apple.com

2 edits in trunk/WebCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix wx build.

webcore-base.bkl:

9:22 AM Changeset in webkit [38503] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Qt build.

jsc.pro:

9:11 AM Changeset in webkit [38502] by bolsinga@apple.com

6 edits in trunk/WebCore

2008-11-17 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

Find some missing DEFINE_STATIC_LOCAL use cases.

9:00 AM Changeset in webkit [38501] by ggaren@apple.com

2 edits in trunk/WebCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Qt build.

WebCore.pro:

8:55 AM Changeset in webkit [38500] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Qt build.

JavaScriptCore.pri:

8:50 AM Changeset in webkit [38499] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Qt build.

JavaScriptCore.pri:

8:43 AM Changeset in webkit [38498] by ggaren@apple.com

9 edits
6 moves
1 add in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

More file moves:

VM/CodeBlock.* => bytecode/CodeBlock.*
VM/EvalCodeCache.h => bytecode/EvalCodeCache.h
VM/Instruction.h => bytecode/Instruction.h
VM/Opcode.* => bytecode/Opcode.*

GNUmakefile.am:
JavaScriptCore.scons:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/jsc/jsc.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
VM/CodeBlock.cpp: Removed.
VM/CodeBlock.h: Removed.
VM/EvalCodeCache.h: Removed.
VM/Instruction.h: Removed.
VM/Opcode.cpp: Removed.
VM/Opcode.h: Removed.
bytecode: Added.
bytecode/CodeBlock.cpp: Copied from VM/CodeBlock.cpp.
bytecode/CodeBlock.h: Copied from VM/CodeBlock.h.
bytecode/EvalCodeCache.h: Copied from VM/EvalCodeCache.h.
bytecode/Instruction.h: Copied from VM/Instruction.h.
bytecode/Opcode.cpp: Copied from VM/Opcode.cpp.
bytecode/Opcode.h: Copied from VM/Opcode.h.
jsc.pro:
jscore.bkl:

8:24 AM Changeset in webkit [38497] by ggaren@apple.com

5 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix a few more builds.

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.scons:
JavaScriptCoreSources.bkl:

8:22 AM Changeset in webkit [38496] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix gtk build.

GNUmakefile.am:

8:20 AM Changeset in webkit [38495] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

8:18 AM Changeset in webkit [38494] by ggaren@apple.com

6 edits
5 moves in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Some file moves:

VM/LabelID.h => bytecompiler/Label.h
VM/RegisterID.h => bytecompiler/RegisterID.h
VM/SegmentedVector.h => bytecompiler/SegmentedVector.h
bytecompiler/CodeGenerator.* => bytecompiler/BytecodeGenerator.*

AllInOneFile.cpp:
JavaScriptCore.xcodeproj/project.pbxproj:
VM/LabelID.h: Removed.
VM/RegisterID.h: Removed.
VM/SegmentedVector.h: Removed.
bytecompiler/BytecodeGenerator.cpp: Copied from bytecompiler/CodeGenerator.cpp.
bytecompiler/BytecodeGenerator.h: Copied from bytecompiler/CodeGenerator.h.
bytecompiler/CodeGenerator.cpp: Removed.
bytecompiler/CodeGenerator.h: Removed.
bytecompiler/Label.h: Copied from VM/LabelID.h.
bytecompiler/LabelScope.h:
bytecompiler/RegisterID.h: Copied from VM/RegisterID.h.
bytecompiler/SegmentedVector.h: Copied from VM/SegmentedVector.h.
jsc.cpp:
parser/Nodes.cpp:

7:13 AM Changeset in webkit [38493] by Simon Hausmann

3 edits
1 add in trunk/WebKit/qt

2008-11-17 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø and Simon Hausmann.

Fix regression when loading resources from Qt resource system using qrc:/.

Added a unit test to catch future regression.

Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
tests/qwebframe/image.png: Added.
tests/qwebframe/tst_qwebframe.cpp:

12:46 AM Changeset in webkit [38492] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

12:34 AM Changeset in webkit [38491] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

12:03 AM Changeset in webkit [38490] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-17 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

Nov 16, 2008:

10:53 PM Changeset in webkit [38489] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

JavaScriptCore.vcproj/jsc/jsc.vcproj:

10:34 PM Changeset in webkit [38488] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

10:27 PM Changeset in webkit [38487] by ggaren@apple.com

4 edits
2 copies
1 add
1 delete in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved masm => assembler and split "AssemblerBuffer.h" out of "X86Assembler.h".

Also renamed ENABLE_MASM to ENABLE_ASSEMBLER.

GNUmakefile.am:
JavaScriptCore.xcodeproj/project.pbxproj:
assembler: Added.
assembler/AssemblerBuffer.h: Copied from masm/X86Assembler.h. (JSC::AssemblerBuffer::AssemblerBuffer): (JSC::AssemblerBuffer::~AssemblerBuffer): (JSC::AssemblerBuffer::ensureSpace): (JSC::AssemblerBuffer::isAligned): (JSC::AssemblerBuffer::putByteUnchecked): (JSC::AssemblerBuffer::putByte): (JSC::AssemblerBuffer::putShortUnchecked): (JSC::AssemblerBuffer::putShort): (JSC::AssemblerBuffer::putIntUnchecked): (JSC::AssemblerBuffer::putInt): (JSC::AssemblerBuffer::data): (JSC::AssemblerBuffer::size): (JSC::AssemblerBuffer::reset): (JSC::AssemblerBuffer::executableCopy): (JSC::AssemblerBuffer::grow):
assembler/X86Assembler.h: Copied from masm/X86Assembler.h.
masm: Removed.
masm/X86Assembler.h: Removed.
wtf/Platform.h:

10:19 PM Changeset in webkit [38486] by ggaren@apple.com

3 edits in trunk/LayoutTests

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Changed "window." to "this." to unbreak these test I just broke in
non-browser builds.

fast/js/resources/duplicate-param-gc-crash.js: (gc):
fast/js/resources/var-shadows-arg-gc-crash.js: (gc):

10:15 PM Changeset in webkit [38485] by ggaren@apple.com

3 edits in trunk/LayoutTests

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Sped up two of the slowest JS layout tests by replacing some hand-rolled
"force GC" code with something orders of magnitude faster.

fast/js/resources/duplicate-param-gc-crash.js: (gc):
fast/js/resources/var-shadows-arg-gc-crash.js: (gc):

9:52 PM Changeset in webkit [38484] by ggaren@apple.com

2 edits in trunk

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix gtk build.

configure.ac:

9:49 PM Changeset in webkit [38483] by ggaren@apple.com

2 edits in trunk/WebKit/win

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

WebCoreSupport/WebFrameLoaderClient.cpp:

9:44 PM Changeset in webkit [38482] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix gtk build.

GNUmakefile.am:

9:30 PM Changeset in webkit [38481] by ggaren@apple.com

1 edit
3 deletes in trunk/LayoutTests

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed ascii-regexp-subject.html because it was the slowest JS test (20s
on my iMac) and it didn't actually verify anything.

Filed https://bugs.webkit.org/show_bug.cgi?id=22303 to cover fixing
the bug that ascii-regexp-subject.html purported to test for, and
then relanding a faster version of ascii-regexp-subject.html once it
would pass (currently, it would fail).

fast/js/ascii-regexp-subject-expected.txt: Removed.
fast/js/ascii-regexp-subject.html: Removed.
fast/js/resources/ascii-regexp-subject.js: Removed.

9:03 PM Changeset in webkit [38480] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Fixed tyop.

VM/CTI.cpp:

8:59 PM Changeset in webkit [38479] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix windows build.

VM/CTI.cpp:

8:50 PM Changeset in webkit [38478] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix gtk build.

GNUmakefile.am:

8:25 PM Changeset in webkit [38477] by ggaren@apple.com

13 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed ENABLE_CTI and ENABLE(CTI) to ENABLE_JIT and ENABLE(JIT).

VM/CTI.cpp:
VM/CTI.h:
VM/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock):
VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock):
VM/Machine.cpp: (JSC::Interpreter::Interpreter): (JSC::Interpreter::initialize): (JSC::Interpreter::~Interpreter): (JSC::Interpreter::execute): (JSC::Interpreter::privateExecute):
VM/Machine.h:
bytecompiler/CodeGenerator.cpp: (JSC::prepareJumpTableForStringSwitch):
runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction):
runtime/JSGlobalData.h:
wrec/WREC.h:
wtf/Platform.h:
wtf/TCSystemAlloc.cpp:

8:17 PM Changeset in webkit [38476] by bolsinga@apple.com

2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

Remove .o files from the exclude list that have had their exit-time destructors removed.
Handle case when there is no current symbol.

8:09 PM Changeset in webkit [38475] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix gtk build.

VM/CTI.cpp:

7:44 PM Changeset in webkit [38474] by Simon Fraser

5 edits
4 adds in trunk

2008-11-16 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=22118

Fix resize corner tracking in transformed elements by using
mapping the point into local coords using absoluteToLocal,
rather than convertToLayerCoords.

Test: fast/css/resize-corner-tracking-transformed.html

page/EventHandler.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::absoluteToContents): (WebCore::RenderLayer::offsetFromResizeCorner): (WebCore::RenderLayer::isPointInResizeControl):
rendering/RenderLayer.h:

7:34 PM Changeset in webkit [38473] by ggaren@apple.com

20 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by a few people on squirrelfish-dev.

Renamed CTI => JIT.

VM/CTI.cpp: (JSC::JIT::killLastResultRegister): (JSC::JIT::emitGetVirtualRegister): (JSC::JIT::emitGetVirtualRegisters): (JSC::JIT::emitPutCTIArgFromVirtualRegister): (JSC::JIT::emitPutCTIArg): (JSC::JIT::emitGetCTIArg): (JSC::JIT::emitPutCTIArgConstant): (JSC::JIT::getConstantImmediateNumericArg): (JSC::JIT::emitPutCTIParam): (JSC::JIT::emitGetCTIParam): (JSC::JIT::emitPutToCallFrameHeader): (JSC::JIT::emitGetFromCallFrameHeader): (JSC::JIT::emitPutVirtualRegister): (JSC::JIT::emitInitRegister): (JSC::JIT::printBytecodeOperandTypes): (JSC::JIT::emitAllocateNumber): (JSC::JIT::emitNakedCall): (JSC::JIT::emitNakedFastCall): (JSC::JIT::emitCTICall): (JSC::JIT::emitJumpSlowCaseIfNotJSCell): (JSC::JIT::linkSlowCaseIfNotJSCell): (JSC::JIT::emitJumpSlowCaseIfNotImmNum): (JSC::JIT::emitJumpSlowCaseIfNotImmNums): (JSC::JIT::getDeTaggedConstantImmediate): (JSC::JIT::emitFastArithDeTagImmediate): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::emitFastArithReTagImmediate): (JSC::JIT::emitFastArithPotentiallyReTagImmediate): (JSC::JIT::emitFastArithImmToInt): (JSC::JIT::emitFastArithIntToImmOrSlowCase): (JSC::JIT::emitFastArithIntToImmNoCheck): (JSC::JIT::emitArithIntToImmWithJump): (JSC::JIT::emitTagAsBoolImmediate): (JSC::JIT::JIT): (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpCallEvalSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileLinkPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::freeCTIMachineTrampolines): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::emitGetVariableObjectRegister): (JSC::JIT::emitPutVariableObjectRegister):
VM/CTI.h: (JSC::JIT::compile): (JSC::JIT::compileGetByIdSelf): (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdReplace): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compileCTIMachineTrampolines): (JSC::JIT::compilePatchGetArrayLength):
VM/CodeBlock.cpp: (JSC::CodeBlock::unlinkCallers):
VM/Machine.cpp: (JSC::Interpreter::initialize): (JSC::Interpreter::~Interpreter): (JSC::Interpreter::execute): (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_call_JSFunction): (JSC::Interpreter::cti_vm_dontLazyLinkCall): (JSC::Interpreter::cti_vm_lazyLinkCall):
VM/Machine.h:
VM/RegisterFile.h:
parser/Nodes.h:
runtime/JSArray.h:
runtime/JSCell.h:
runtime/JSFunction.h:
runtime/JSImmediate.h:
runtime/JSNumberCell.h:
runtime/JSObject.h:
runtime/JSString.h:
runtime/JSVariableObject.h:
runtime/ScopeChain.h:
runtime/Structure.h:
runtime/TypeInfo.h:
runtime/UString.h:

7:28 PM Changeset in webkit [38472] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix wx build.

jscore.bkl:

7:21 PM Changeset in webkit [38471] by ggaren@apple.com

4 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Nixed X86: and X86Assembler:: prefixes in a lot of places using typedefs.

VM/CTI.cpp: (JSC::CTI::emitGetVirtualRegister): (JSC::CTI::emitGetVirtualRegisters): (JSC::CTI::emitPutCTIArgFromVirtualRegister): (JSC::CTI::emitPutCTIArg): (JSC::CTI::emitGetCTIArg): (JSC::CTI::emitPutCTIParam): (JSC::CTI::emitGetCTIParam): (JSC::CTI::emitPutToCallFrameHeader): (JSC::CTI::emitGetFromCallFrameHeader): (JSC::CTI::emitPutVirtualRegister): (JSC::CTI::emitNakedCall): (JSC::CTI::emitNakedFastCall): (JSC::CTI::emitCTICall): (JSC::CTI::emitJumpSlowCaseIfNotJSCell): (JSC::CTI::emitJumpSlowCaseIfNotImmNum): (JSC::CTI::emitJumpSlowCaseIfNotImmNums): (JSC::CTI::emitFastArithDeTagImmediate): (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero): (JSC::CTI::emitFastArithReTagImmediate): (JSC::CTI::emitFastArithPotentiallyReTagImmediate): (JSC::CTI::emitFastArithImmToInt): (JSC::CTI::emitFastArithIntToImmOrSlowCase): (JSC::CTI::emitFastArithIntToImmNoCheck): (JSC::CTI::emitArithIntToImmWithJump): (JSC::CTI::emitTagAsBoolImmediate): (JSC::CTI::compileOpCall): (JSC::CTI::compileOpStrictEq): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdSelf): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompilePutByIdReplace): (JSC::CTI::privateCompilePutByIdTransition): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::privateCompilePatchGetArrayLength): (JSC::CTI::emitGetVariableObjectRegister): (JSC::CTI::emitPutVariableObjectRegister):
VM/CTI.h: (JSC::CallRecord::CallRecord): (JSC::JmpTable::JmpTable): (JSC::SlowCaseEntry::SlowCaseEntry): (JSC::CTI::JSRInfo::JSRInfo):
wrec/WREC.h:

7:17 PM Changeset in webkit [38470] by ggaren@apple.com

2 edits in trunk/WebCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Qt build.

WebCore.pro:

7:13 PM Changeset in webkit [38469] by bolsinga@apple.com

4 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

Use DEFINE_STATIC_LOCAL for static RetainPtr<T>

7:05 PM Changeset in webkit [38468] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Qt build.

JavaScriptCore.pri:

7:02 PM Changeset in webkit [38467] by ggaren@apple.com

4 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed OBJECT_OFFSET => FIELD_OFFSET

Nixed use of OBJECT_OFFSET outside of CTI.cpp by making CTI a friend in
more places.

VM/CTI.cpp: (JSC::CTI::compileOpCallInitializeCallFrame): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdSelf): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompilePutByIdReplace): (JSC::CTI::privateCompilePutByIdTransition): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::privateCompilePatchGetArrayLength): (JSC::CTI::emitGetVariableObjectRegister): (JSC::CTI::emitPutVariableObjectRegister):
runtime/JSValue.h:
runtime/JSVariableObject.h:

6:40 PM Changeset in webkit [38466] by ggaren@apple.com

4 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renames:

X86Assembler::copy => X86Assembler::executableCopy
AssemblerBuffer::copy => AssemblerBuffer::executableCopy

VM/CTI.cpp: (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdSelf): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompilePutByIdReplace): (JSC::CTI::privateCompilePutByIdTransition): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::privateCompilePatchGetArrayLength):
masm/X86Assembler.h: (JSC::AssemblerBuffer::executableCopy): (JSC::X86Assembler::executableCopy):
wrec/WREC.cpp: (JSC::WREC::compileRegExp):

6:33 PM Changeset in webkit [38465] by ggaren@apple.com

7 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed WREC => JSC::WREC, removing JSC:: prefix in a lot of places.
Renamed WRECFunction => WREC::CompiledRegExp, and deployed this type
name in place of a few casts.

runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::~RegExp): (JSC::RegExp::match):
runtime/RegExp.h:
wrec/CharacterClassConstructor.cpp:
wrec/CharacterClassConstructor.h:
wrec/WREC.cpp: (JSC::WREC::compileRegExp):
wrec/WREC.h: (JSC::WREC::Generator::Generator): (JSC::WREC::Parser::Parser): (JSC::WREC::Parser::parseAlternative):

6:21 PM Changeset in webkit [38464] by ggaren@apple.com

19 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed BytecodeInterpreter => Interpreter.

JavaScriptCore.exp:
VM/CTI.cpp: (JSC::): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdSelf): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompilePutByIdReplace): (JSC::CTI::privateCompilePutByIdTransition): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::freeCTIMachineTrampolines): (JSC::CTI::patchGetByIdSelf): (JSC::CTI::patchPutByIdReplace): (JSC::CTI::privateCompilePatchGetArrayLength):
VM/CTI.h:
VM/CodeBlock.cpp: (JSC::CodeBlock::printStructures): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):
VM/Machine.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::resolveBaseAndFunc): (JSC::Interpreter::slideRegisterWindowForCall): (JSC::Interpreter::callEval): (JSC::Interpreter::Interpreter): (JSC::Interpreter::initialize): (JSC::Interpreter::~Interpreter): (JSC::Interpreter::dumpCallFrame): (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::isOpcode): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::execute): (JSC::Interpreter::debug): (JSC::Interpreter::resetTimeoutCheck): (JSC::Interpreter::checkTimeout): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::uncachePutByID): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::uncacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments): (JSC::Interpreter::retrieveCaller): (JSC::Interpreter::retrieveLastCaller): (JSC::Interpreter::findFunctionCallFrame): (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_convert_this): (JSC::Interpreter::cti_op_end): (JSC::Interpreter::cti_op_add): (JSC::Interpreter::cti_op_pre_inc): (JSC::Interpreter::cti_timeout_check): (JSC::Interpreter::cti_register_file_check): (JSC::Interpreter::cti_op_loop_if_less): (JSC::Interpreter::cti_op_loop_if_lesseq): (JSC::Interpreter::cti_op_new_object): (JSC::Interpreter::cti_op_put_by_id): (JSC::Interpreter::cti_op_put_by_id_second): (JSC::Interpreter::cti_op_put_by_id_generic): (JSC::Interpreter::cti_op_put_by_id_fail): (JSC::Interpreter::cti_op_get_by_id): (JSC::Interpreter::cti_op_get_by_id_second): (JSC::Interpreter::cti_op_get_by_id_generic): (JSC::Interpreter::cti_op_get_by_id_fail): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_del_by_id): (JSC::Interpreter::cti_op_mul): (JSC::Interpreter::cti_op_new_func): (JSC::Interpreter::cti_op_call_JSFunction): (JSC::Interpreter::cti_op_call_arityCheck): (JSC::Interpreter::cti_vm_dontLazyLinkCall): (JSC::Interpreter::cti_vm_lazyLinkCall): (JSC::Interpreter::cti_op_push_activation): (JSC::Interpreter::cti_op_call_NotJSFunction): (JSC::Interpreter::cti_op_create_arguments): (JSC::Interpreter::cti_op_create_arguments_no_params): (JSC::Interpreter::cti_op_tear_off_activation): (JSC::Interpreter::cti_op_tear_off_arguments): (JSC::Interpreter::cti_op_profile_will_call): (JSC::Interpreter::cti_op_profile_did_call): (JSC::Interpreter::cti_op_ret_scopeChain): (JSC::Interpreter::cti_op_new_array): (JSC::Interpreter::cti_op_resolve): (JSC::Interpreter::cti_op_construct_JSConstruct): (JSC::Interpreter::cti_op_construct_NotJSConstruct): (JSC::Interpreter::cti_op_get_by_val): (JSC::Interpreter::cti_op_resolve_func): (JSC::Interpreter::cti_op_sub): (JSC::Interpreter::cti_op_put_by_val): (JSC::Interpreter::cti_op_put_by_val_array): (JSC::Interpreter::cti_op_lesseq): (JSC::Interpreter::cti_op_loop_if_true): (JSC::Interpreter::cti_op_negate): (JSC::Interpreter::cti_op_resolve_base): (JSC::Interpreter::cti_op_resolve_skip): (JSC::Interpreter::cti_op_resolve_global): (JSC::Interpreter::cti_op_div): (JSC::Interpreter::cti_op_pre_dec): (JSC::Interpreter::cti_op_jless): (JSC::Interpreter::cti_op_not): (JSC::Interpreter::cti_op_jtrue): (JSC::Interpreter::cti_op_post_inc): (JSC::Interpreter::cti_op_eq): (JSC::Interpreter::cti_op_lshift): (JSC::Interpreter::cti_op_bitand): (JSC::Interpreter::cti_op_rshift): (JSC::Interpreter::cti_op_bitnot): (JSC::Interpreter::cti_op_resolve_with_base): (JSC::Interpreter::cti_op_new_func_exp): (JSC::Interpreter::cti_op_mod): (JSC::Interpreter::cti_op_less): (JSC::Interpreter::cti_op_neq): (JSC::Interpreter::cti_op_post_dec): (JSC::Interpreter::cti_op_urshift): (JSC::Interpreter::cti_op_bitxor): (JSC::Interpreter::cti_op_new_regexp): (JSC::Interpreter::cti_op_bitor): (JSC::Interpreter::cti_op_call_eval): (JSC::Interpreter::cti_op_throw): (JSC::Interpreter::cti_op_get_pnames): (JSC::Interpreter::cti_op_next_pname): (JSC::Interpreter::cti_op_push_scope): (JSC::Interpreter::cti_op_pop_scope): (JSC::Interpreter::cti_op_typeof): (JSC::Interpreter::cti_op_is_undefined): (JSC::Interpreter::cti_op_is_boolean): (JSC::Interpreter::cti_op_is_number): (JSC::Interpreter::cti_op_is_string): (JSC::Interpreter::cti_op_is_object): (JSC::Interpreter::cti_op_is_function): (JSC::Interpreter::cti_op_stricteq): (JSC::Interpreter::cti_op_nstricteq): (JSC::Interpreter::cti_op_to_jsnumber): (JSC::Interpreter::cti_op_in): (JSC::Interpreter::cti_op_push_new_scope): (JSC::Interpreter::cti_op_jmp_scopes): (JSC::Interpreter::cti_op_put_by_index): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_op_switch_char): (JSC::Interpreter::cti_op_switch_string): (JSC::Interpreter::cti_op_del_by_val): (JSC::Interpreter::cti_op_put_getter): (JSC::Interpreter::cti_op_put_setter): (JSC::Interpreter::cti_op_new_error): (JSC::Interpreter::cti_op_debug): (JSC::Interpreter::cti_vm_throw):
VM/Machine.h:
VM/Register.h:
VM/SamplingTool.h: (JSC::SamplingTool::SamplingTool):
bytecompiler/CodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::BytecodeGenerator):
jsc.cpp: (runWithScripts):
runtime/ExecState.h: (JSC::ExecState::interpreter):
runtime/JSCell.h:
runtime/JSFunction.h:
runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
runtime/JSGlobalData.h:
runtime/JSString.h:
wrec/WREC.cpp: (WREC::compileRegExp):
wrec/WREC.h:

6:08 PM Changeset in webkit [38463] by ggaren@apple.com

27 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Roll out r38461 (my last patch) because it broke the world.

6:03 PM Changeset in webkit [38462] by bolsinga@apple.com

2 edits in trunk/WebCore

Reviewed by Geoffrey Garen.

Use RefPtr and PassRefPtr where appropriate.

5:48 PM Changeset in webkit [38461] by ggaren@apple.com

27 edits in trunk/JavaScriptCore

2008-11-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

A few more renames:

BytecodeInterpreter => Interpreter
WREC => JSC::WREC, removing JSC:: prefix in a lot of places
X86Assembler::copy => X86Assembler::executableCopy
AssemblerBuffer::copy => AssemblerBuffer::executableCopy
WRECFunction => WREC::RegExpFunction
OBJECT_OFFSET => FIELD_OFFSET

Also:

Nixed use of OBJECT_OFFSET outside of CTI.cpp by making CTI a friend in more places.

Nixed X86: and X86Assembler:: prefixes in a lot of places using typedefs

JavaScriptCore.exp:
VM/CTI.cpp: (JSC::): (JSC::CTI::emitGetVirtualRegister): (JSC::CTI::emitGetVirtualRegisters): (JSC::CTI::emitPutCTIArgFromVirtualRegister): (JSC::CTI::emitPutCTIArg): (JSC::CTI::emitGetCTIArg): (JSC::CTI::emitPutCTIParam): (JSC::CTI::emitGetCTIParam): (JSC::CTI::emitPutToCallFrameHeader): (JSC::CTI::emitGetFromCallFrameHeader): (JSC::CTI::emitPutVirtualRegister): (JSC::CTI::emitNakedCall): (JSC::CTI::emitNakedFastCall): (JSC::CTI::emitCTICall): (JSC::CTI::emitJumpSlowCaseIfNotJSCell): (JSC::CTI::emitJumpSlowCaseIfNotImmNum): (JSC::CTI::emitJumpSlowCaseIfNotImmNums): (JSC::CTI::emitFastArithDeTagImmediate): (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero): (JSC::CTI::emitFastArithReTagImmediate): (JSC::CTI::emitFastArithPotentiallyReTagImmediate): (JSC::CTI::emitFastArithImmToInt): (JSC::CTI::emitFastArithIntToImmOrSlowCase): (JSC::CTI::emitFastArithIntToImmNoCheck): (JSC::CTI::emitArithIntToImmWithJump): (JSC::CTI::emitTagAsBoolImmediate): (JSC::CTI::compileOpCallInitializeCallFrame): (JSC::CTI::compileOpCall): (JSC::CTI::compileOpStrictEq): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdSelf): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompilePutByIdReplace): (JSC::CTI::privateCompilePutByIdTransition): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::freeCTIMachineTrampolines): (JSC::CTI::patchGetByIdSelf): (JSC::CTI::patchPutByIdReplace): (JSC::CTI::privateCompilePatchGetArrayLength): (JSC::CTI::emitGetVariableObjectRegister): (JSC::CTI::emitPutVariableObjectRegister):
VM/CTI.h: (JSC::CallRecord::CallRecord): (JSC::JmpTable::JmpTable): (JSC::SlowCaseEntry::SlowCaseEntry): (JSC::CTI::JSRInfo::JSRInfo):
VM/CodeBlock.cpp: (JSC::CodeBlock::printStructures): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):
VM/Machine.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::resolveBaseAndFunc): (JSC::Interpreter::slideRegisterWindowForCall): (JSC::Interpreter::callEval): (JSC::Interpreter::Interpreter): (JSC::Interpreter::initialize): (JSC::Interpreter::~Interpreter): (JSC::Interpreter::dumpCallFrame): (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::isOpcode): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::execute): (JSC::Interpreter::debug): (JSC::Interpreter::resetTimeoutCheck): (JSC::Interpreter::checkTimeout): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::uncachePutByID): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::uncacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments): (JSC::Interpreter::retrieveCaller): (JSC::Interpreter::retrieveLastCaller): (JSC::Interpreter::findFunctionCallFrame): (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::): (JSC::Interpreter::cti_op_convert_this): (JSC::Interpreter::cti_op_end): (JSC::Interpreter::cti_op_add): (JSC::Interpreter::cti_op_pre_inc): (JSC::Interpreter::cti_timeout_check): (JSC::Interpreter::cti_register_file_check): (JSC::Interpreter::cti_op_loop_if_less): (JSC::Interpreter::cti_op_loop_if_lesseq): (JSC::Interpreter::cti_op_new_object): (JSC::Interpreter::cti_op_put_by_id): (JSC::Interpreter::cti_op_put_by_id_second): (JSC::Interpreter::cti_op_put_by_id_generic): (JSC::Interpreter::cti_op_put_by_id_fail): (JSC::Interpreter::cti_op_get_by_id): (JSC::Interpreter::cti_op_get_by_id_second): (JSC::Interpreter::cti_op_get_by_id_generic): (JSC::Interpreter::cti_op_get_by_id_fail): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_del_by_id): (JSC::Interpreter::cti_op_mul): (JSC::Interpreter::cti_op_new_func): (JSC::Interpreter::cti_op_call_JSFunction): (JSC::Interpreter::cti_op_call_arityCheck): (JSC::Interpreter::cti_vm_dontLazyLinkCall): (JSC::Interpreter::cti_vm_lazyLinkCall): (JSC::Interpreter::cti_op_push_activation): (JSC::Interpreter::cti_op_call_NotJSFunction): (JSC::Interpreter::cti_op_create_arguments): (JSC::Interpreter::cti_op_create_arguments_no_params): (JSC::Interpreter::cti_op_tear_off_activation): (JSC::Interpreter::cti_op_tear_off_arguments): (JSC::Interpreter::cti_op_profile_will_call): (JSC::Interpreter::cti_op_profile_did_call): (JSC::Interpreter::cti_op_ret_scopeChain): (JSC::Interpreter::cti_op_new_array): (JSC::Interpreter::cti_op_resolve): (JSC::Interpreter::cti_op_construct_JSConstruct): (JSC::Interpreter::cti_op_construct_NotJSConstruct): (JSC::Interpreter::cti_op_get_by_val): (JSC::Interpreter::cti_op_resolve_func): (JSC::Interpreter::cti_op_sub): (JSC::Interpreter::cti_op_put_by_val): (JSC::Interpreter::cti_op_put_by_val_array): (JSC::Interpreter::cti_op_lesseq): (JSC::Interpreter::cti_op_loop_if_true): (JSC::Interpreter::cti_op_negate): (JSC::Interpreter::cti_op_resolve_base): (JSC::Interpreter::cti_op_resolve_skip): (JSC::Interpreter::cti_op_resolve_global): (JSC::Interpreter::cti_op_div): (JSC::Interpreter::cti_op_pre_dec): (JSC::Interpreter::cti_op_jless): (JSC::Interpreter::cti_op_not): (JSC::Interpreter::cti_op_jtrue): (JSC::Interpreter::cti_op_post_inc): (JSC::Interpreter::cti_op_eq): (JSC::Interpreter::cti_op_lshift): (JSC::Interpreter::cti_op_bitand): (JSC::Interpreter::cti_op_rshift): (JSC::Interpreter::cti_op_bitnot): (JSC::Interpreter::cti_op_resolve_with_base): (JSC::Interpreter::cti_op_new_func_exp): (JSC::Interpreter::cti_op_mod): (JSC::Interpreter::cti_op_less): (JSC::Interpreter::cti_op_neq): (JSC::Interpreter::cti_op_post_dec): (JSC::Interpreter::cti_op_urshift): (JSC::Interpreter::cti_op_bitxor): (JSC::Interpreter::cti_op_new_regexp): (JSC::Interpreter::cti_op_bitor): (JSC::Interpreter::cti_op_call_eval): (JSC::Interpreter::cti_op_throw): (JSC::Interpreter::cti_op_get_pnames): (JSC::Interpreter::cti_op_next_pname): (JSC::Interpreter::cti_op_push_scope): (JSC::Interpreter::cti_op_pop_scope): (JSC::Interpreter::cti_op_typeof): (JSC::Interpreter::cti_op_is_undefined): (JSC::Interpreter::cti_op_is_boolean): (JSC::Interpreter::cti_op_is_number): (JSC::Interpreter::cti_op_is_string): (JSC::Interpreter::cti_op_is_object): (JSC::Interpreter::cti_op_is_function): (JSC::Interpreter::cti_op_stricteq): (JSC::Interpreter::cti_op_nstricteq): (JSC::Interpreter::cti_op_to_jsnumber): (JSC::Interpreter::cti_op_in): (JSC::Interpreter::cti_op_push_new_scope): (JSC::Interpreter::cti_op_jmp_scopes): (JSC::Interpreter::cti_op_put_by_index): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_op_switch_char): (JSC::Interpreter::cti_op_switch_string): (JSC::Interpreter::cti_op_del_by_val): (JSC::Interpreter::cti_op_put_getter): (JSC::Interpreter::cti_op_put_setter): (JSC::Interpreter::cti_op_new_error): (JSC::Interpreter::cti_op_debug): (JSC::Interpreter::cti_vm_throw):
VM/Machine.h:
VM/Register.h:
VM/SamplingTool.cpp: (JSC::SamplingTool::dump):
VM/SamplingTool.h: (JSC::SamplingTool::SamplingTool):
bytecompiler/CodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::BytecodeGenerator):
jsc.cpp: (runWithScripts):
masm/X86Assembler.h: (JSC::AssemblerBuffer::executableCopy): (JSC::X86Assembler::executableCopy):
runtime/ExecState.h: (JSC::ExecState::interpreter):
runtime/JSCell.h:
runtime/JSFunction.h:
runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
runtime/JSGlobalData.h:
runtime/JSImmediate.h:
runtime/JSString.h:
runtime/JSValue.h:
runtime/JSVariableObject.h:
runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::~RegExp): (JSC::RegExp::match):
runtime/RegExp.h:
wrec/CharacterClassConstructor.cpp:
wrec/CharacterClassConstructor.h:
wrec/WREC.cpp: (JSC::WREC::compileRegExp):
wrec/WREC.h: (JSC::WREC::Generator::Generator): (JSC::WREC::Parser::): (JSC::WREC::Parser::Parser): (JSC::WREC::Parser::parseAlternative):

5:43 PM Changeset in webkit [38460] by bolsinga@apple.com

2 edits in trunk/WebCore

Fix build break for real.

5:38 PM Changeset in webkit [38459] by bolsinga@apple.com

2 edits in trunk/WebCore

Fix build break and bug.

5:05 PM Changeset in webkit [38458] by bolsinga@apple.com

16 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

Use DEFINE_STATIC_LOCAL for static RetainPtr<T>, RefPtr<T>. Add additional
uses of DEFINE_STATIC_LOCAL where appropriate.

3:07 PM Changeset in webkit [38457] by bolsinga@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

Conditionally have the DEFINE_STATIC_LOCAL workaround <rdar://problem/6354696>
(Codegen issue with C++ static reference in gcc build 5465) based upon the compiler
build versions. It will use the:
static T& = *new T;
style for all other compilers.

2:17 PM Changeset in webkit [38456] by weinig@apple.com

2 edits in trunk/LayoutTests

2008-11-16 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Disable XHR upload progress event tests on Tiger due to race condition causing
intermittent failure reported in https://bugs.webkit.org/show_bug.cgi?id=22298

platform/mac-tiger/Skipped:

1:53 PM Changeset in webkit [38455] by zecke@webkit.org

2 edits in trunk/WebCore

Do not spit Curl errors into the stdout as this is used by DRT

We have failing tests results due the curl errors printed to stdout,
move them to stderr to be able to pass those tests.

1:49 PM Changeset in webkit [38454] by zecke@webkit.org

2 edits in trunk/WebCore

Gtk+ build fix

12:07 PM Changeset in webkit [38453] by Darin Adler

2 edits in trunk/WebCore

2008-11-16 Darin Adler <Darin Adler>

try to fix Qt build

WebCore.pro: Add the worker-related source files.

11:58 AM Changeset in webkit [38452] by Darin Adler

3 edits in trunk/WebCore

2008-11-16 Darin Adler <Darin Adler>

Suggested by Alexey Proskuryakov.

fix the GTK build another way

GNUmakefile.am: Add the worker-related source files.
bindings/js/JSEventTarget.cpp: Take the #if back out.

11:51 AM Changeset in webkit [38451] by Darin Adler

2 edits in trunk/WebCore

2008-11-16 Darin Adler <Darin Adler>

try to fix GTK build

bindings/js/JSEventTarget.cpp: Put worker includes inside an #if.

11:49 AM Changeset in webkit [38450] by Darin Adler

2 edits in trunk/WebKit/qt

2008-11-16 Darin Adler <Darin Adler>

try to fix build

Api/qwebhistory.cpp: Added include of "KURL.h".

11:39 AM Changeset in webkit [38449] by Darin Adler

15 edits in trunk

WebCore:

2008-11-16 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22295 track which history items are from page load failures

history/HistoryItem.cpp: Sort includes, add newly needed ones, and remove no-longer-needed ones. (WebCore::HistoryItem::HistoryItem): Initialize m_lastVisitWasFailure to false. (WebCore::HistoryItem::showTreeWithIndent): Rewrote to avoid appending to a String, since that's not efficient.

history/HistoryItem.h: Removed unneeded includes. Added lastVisitWasFailure, setLastVisitWasFailure, and m_lastVisitWasFailure.

history/mac/HistoryItemMac.mm: Add newly-needed include (WebCore::HistoryItem::setTransientProperty): Rewrote to avoid keeping a m_transientProperties map around when it is empty.

loader/FrameLoader.cpp: (WebCore::FrameLoader::createHistoryItem): Call setLastVisitWasFailure when the page was unreachable or an HTTP page with a status code that indicates failure.

WebKit/mac:

2008-11-16 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22295 track which history items are from page load failures

History/WebHistoryItem.mm: Added lastVisitWasFailureKey. (-[WebHistoryItem initFromDictionaryRepresentation:]): Set the lastVisitWasFailure flag in the history item if the dictionary had lastVisitWasFailureKey true. (-[WebHistoryItem dictionaryRepresentation]): Set the lastVisitWasFailureKey boolean in the dictionary if the history item had the lastVisitWasFailure flag. (-[WebHistoryItem lastVisitWasFailure]): Added.

History/WebHistoryItemInternal.h: Moved include of WebBackForwardList here from WebHistoryItemPrivate.h; removed other unneeded includes.

History/WebHistoryItemPrivate.h: Added lastVisitWasFailure method. Removed unneeded includes.

Misc/WebNSDictionaryExtras.h: Added _webkit_boolForKey.
Misc/WebNSDictionaryExtras.m: (-[NSDictionary _webkit_boolForKey:]): Added.

WebKit/win:

2008-11-16 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22295 track which history items are from page load failures

Interfaces/IWebHistoryItemPrivate.idl: Added lastVisitWasFailure function.

WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): Set the lastVisitWasFailure flag in the history item if the dictionary had an entry for lastVisitWasFailureKey. (WebHistoryItem::dictionaryRepresentation): Set the lastVisitWasFailureKey key in the dictionary if the history item had the lastVisitWasFailure flag. (WebHistoryItem::lastVisitWasFailure): Added.

WebHistoryItem.h: Added lastVisitWasFailure function.

10:43 AM Changeset in webkit [38448] by weinig@apple.com

2 edits in trunk/WebKitTools

2008-11-16 Sam Weinig <sam@webkit.org>

Scripts/do-webcore-rename: Remove now fixed renames.

10:21 AM Changeset in webkit [38447] by Darin Adler

2 edits in trunk/WebKitTools

2008-11-16 Darin Adler <Darin Adler>

Scripts/do-webcore-rename: Plan some future renames.

6:10 AM Changeset in webkit [38446] by christian@webkit.org

2 edits in trunk/WebKit/gtk

2008-11-16 Christian Dywan <christian@twoasts.de>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22207
[Gtk] Font sizes are not handled properly when updated at runtime

webkit/webkitwebview.cpp: Move the DPI/ conversion into a helper function and apply the logic in the notification callback.

4:45 AM Changeset in webkit [38445] by staikos@webkit.org

2 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

Optimization: don't relayout, repaint, or emit a DOM event if the
scroll event didn't scroll anywhere.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): add early exit

2:05 AM Changeset in webkit [38444] by ap@webkit.org

13 edits in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22290
Remove cross-heap GC and MessagePort multi-threading support

It is broken (and may not be implementable at all), and no longer needed, as we
don't use MessagePorts for communication with workers any more.

JavaScriptCore:

JavaScriptCore.exp:
runtime/Collector.cpp: (JSC::Heap::collect):
runtime/JSGlobalObject.cpp:
runtime/JSGlobalObject.h: Remove hooks for cross-heap GC.

WebCore:

bindings/js/JSDOMBinding.cpp:
bindings/js/JSDOMBinding.h:
bindings/js/JSDOMWindowBase.cpp:
bindings/js/JSDOMWindowBase.h: Removed cross-heap GC implementation.

dom/MessagePort.cpp: (WebCore::MessagePort::hasPendingActivity):
dom/MessagePort.h: Made objects RefCounted instead of ThreadSafeShared, added FIXME comments for code that is unnecessarily complicated for single threaded case.

1:11 AM Changeset in webkit [38443] by ap@webkit.org

14 edits
6 moves
2 adds in trunk/WebCore

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=22266
Stop using MessagePort for communication with workers

The current MessagePort specification is not well suited for being implemented in a
multi-threaded or multi-process environment, and this doesn't appear to be easily fixable.
This patch implements a simpler Mozilla API for workers instead.

WebCore.xcodeproj/project.pbxproj:
DerivedSources.make:
bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseWorker):
bindings/js/JSDedicatedWorkerConstructor.cpp: Removed.
bindings/js/JSDedicatedWorkerConstructor.h: Removed.
bindings/js/JSDedicatedWorkerCustom.cpp: Removed.
bindings/js/JSWorkerConstructor.cpp: Copied from WebCore/bindings/js/JSDedicatedWorkerConstructor.cpp.
bindings/js/JSWorkerConstructor.h: Copied from WebCore/bindings/js/JSDedicatedWorkerConstructor.h.
bindings/js/JSWorkerCustom.cpp: Copied from WebCore/bindings/js/JSDedicatedWorkerCustom.cpp.
dom/DedicatedWorker.cpp: Removed.
dom/DedicatedWorker.h: Removed.
dom/DedicatedWorker.idl: Removed. Renamed DedicatedWorker to Worker to match Mozilla and current WHATWG cpec.

bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): Clear worker exceptions to avoid hitting an assertion.

dom/EventTarget.cpp: (WebCore::EventTarget::toWorker):
dom/EventTarget.h:
bindings/js/JSEventTarget.cpp: (WebCore::toJS): WorkerContext is now an EventTarget, too.

bindings/js/JSWorkerContext.cpp: Removed onconnect, constructors for MessageChannel and MessagePort. Added postMessage() and onmessage.

dom/ScriptExecutionContext.cpp: (WebCore::performTask): Do not reference ScriptExecutionContext when posting a task - this operation is not thread safe. It is also not necessary any more, as the context is kept alive by WorkerMessagingProxy.

dom/Worker.cpp: Copied from WebCore/dom/DedicatedWorker.cpp. (WebCore::Worker::Worker): Start loading the script right away - there is no reason to do that on a timer. (WebCore::Worker::~Worker): Notify messaging proxy. (WebCore::Worker::postMessage): Just ask the proxy to post the message. (WebCore::Worker::notifyFinished): Notify messaging proxy when a thread object becomes available. Also, it is now safe to unsetPendingActivity(), making the object collectable. I'm not sure if this is the right lifetime for workers, as unreachable workers with event listeners should probably be kept alive, but it at least lets the object be collected. (WebCore::Worker::addEventListener): Added an EventTarget implementation. (WebCore::Worker::removeEventListener): Added an EventTarget implementation. (WebCore::Worker::dispatchEvent): Added an EventTarget implementation.

dom/Worker.h: Copied from WebCore/dom/DedicatedWorker.h.
dom/Worker.idl: Copied from WebCore/dom/DedicatedWorker.idl. Removed onclose, made an EventListener. Actual messaging is now handled by WorkerMessagingProxy.

dom/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): Notify messaging proxy that the context was shut down successfully. (WebCore::WorkerContext::postMessage): Added. Post the message via messaging proxy.

dom/WorkerContext.h: Added postMessage and onmessage, removed onconnect.

dom/WorkerMessagingProxy.cpp: Added.
dom/WorkerMessagingProxy.h: Added. This new class implements actual messaging. It is notified when a Worker is garbage collected, and asks the thread to shut down. It also owns the thread object, and references script execution context, making it safe to post messages to it remotely.

dom/WorkerThread.cpp:
dom/WorkerThread.h: Keep a reference to messaging proxy, not to Worker itself. Also, the thread object no longer keeps itself alive - it is now the job of messaging proxy.

Nov 15, 2008:

10:04 PM Changeset in webkit [38442] by weinig@apple.com

2 edits in trunk/JavaScriptCore

2008-11-15 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Cleanup jsc command line code a little.

jsc.cpp: (functionQuit): (main): Use standard exit status macros (cleanupGlobalData): Factor out cleanup code into this function. (printUsageStatement): Use standard exit status macros.

9:36 PM Changeset in webkit [38441] by weinig@apple.com

4 edits in trunk/JavaScriptCore

2008-11-15 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Cleanup BytecodeGenerator constructors.

bytecompiler/CodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
bytecompiler/CodeGenerator.h:
parser/Nodes.cpp: (JSC::ProgramNode::generateBytecode):

8:40 PM Changeset in webkit [38440] by Darin Adler

150 edits
6 moves in trunk

JavaScriptCore:

2008-11-15 Darin Adler <Darin Adler>

Rubber stamped by Geoff Garen.

do the long-planned StructureID -> Structure rename

API/JSCallbackConstructor.cpp: (JSC::JSCallbackConstructor::JSCallbackConstructor):
API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
API/JSCallbackObjectFunctions.h: (JSC::::JSCallbackObject):
API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor):
GNUmakefile.am:
JavaScriptCore.exp:
JavaScriptCore.pri:
JavaScriptCore.scons:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
VM/CTI.cpp: (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileGetByIdSelf): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompilePutByIdReplace): (JSC::transitionWillNeedStorageRealloc): (JSC::CTI::privateCompilePutByIdTransition): (JSC::CTI::patchGetByIdSelf): (JSC::CTI::patchPutByIdReplace):
VM/CTI.h: (JSC::CTI::compileGetByIdSelf): (JSC::CTI::compileGetByIdProto): (JSC::CTI::compileGetByIdChain): (JSC::CTI::compilePutByIdReplace): (JSC::CTI::compilePutByIdTransition):
VM/CodeBlock.cpp: (JSC::CodeBlock::printStructure): (JSC::CodeBlock::printStructures): (JSC::CodeBlock::dump): (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):
VM/CodeBlock.h:
VM/Instruction.h: (JSC::Instruction::Instruction): (JSC::Instruction::):
VM/Machine.cpp: (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::BytecodeInterpreter::resolveGlobal): (JSC::BytecodeInterpreter::BytecodeInterpreter): (JSC::cachePrototypeChain): (JSC::BytecodeInterpreter::tryCachePutByID): (JSC::BytecodeInterpreter::uncachePutByID): (JSC::BytecodeInterpreter::tryCacheGetByID): (JSC::BytecodeInterpreter::uncacheGetByID): (JSC::BytecodeInterpreter::privateExecute): (JSC::BytecodeInterpreter::tryCTICachePutByID): (JSC::BytecodeInterpreter::tryCTICacheGetByID): (JSC::BytecodeInterpreter::cti_op_instanceof): (JSC::BytecodeInterpreter::cti_op_construct_JSConstruct): (JSC::BytecodeInterpreter::cti_op_resolve_global): (JSC::BytecodeInterpreter::cti_op_is_undefined):
runtime/Arguments.h: (JSC::Arguments::createStructure):
runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
runtime/ArrayConstructor.h:
runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::ArrayPrototype):
runtime/ArrayPrototype.h:
runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
runtime/BooleanConstructor.h:
runtime/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject):
runtime/BooleanObject.h:
runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
runtime/BooleanPrototype.h:
runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
runtime/DateConstructor.h:
runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
runtime/DateInstance.h:
runtime/DatePrototype.cpp: (JSC::DatePrototype::DatePrototype):
runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
runtime/ErrorConstructor.h:
runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance):
runtime/ErrorInstance.h:
runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
runtime/ErrorPrototype.h:
runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
runtime/FunctionConstructor.h:
runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype): (JSC::FunctionPrototype::addFunctionProperties):
runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction):
runtime/GlobalEvalFunction.h:
runtime/Identifier.h:
runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
runtime/InternalFunction.h: (JSC::InternalFunction::createStructure): (JSC::InternalFunction::InternalFunction):
runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
runtime/JSActivation.h: (JSC::JSActivation::createStructure):
runtime/JSArray.cpp: (JSC::JSArray::JSArray):
runtime/JSArray.h: (JSC::JSArray::createStructure):
runtime/JSCell.h: (JSC::JSCell::JSCell): (JSC::JSCell::isObject): (JSC::JSCell::isString): (JSC::JSCell::structure): (JSC::JSValue::needsThisConversion):
runtime/JSFunction.cpp: (JSC::JSFunction::construct):
runtime/JSFunction.h: (JSC::JSFunction::JSFunction): (JSC::JSFunction::createStructure):
runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::createLeaked):
runtime/JSGlobalData.h:
runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::reset):
runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): (JSC::JSGlobalObject::argumentsStructure): (JSC::JSGlobalObject::arrayStructure): (JSC::JSGlobalObject::booleanObjectStructure): (JSC::JSGlobalObject::callbackConstructorStructure): (JSC::JSGlobalObject::callbackFunctionStructure): (JSC::JSGlobalObject::callbackObjectStructure): (JSC::JSGlobalObject::dateStructure): (JSC::JSGlobalObject::emptyObjectStructure): (JSC::JSGlobalObject::errorStructure): (JSC::JSGlobalObject::functionStructure): (JSC::JSGlobalObject::numberObjectStructure): (JSC::JSGlobalObject::prototypeFunctionStructure): (JSC::JSGlobalObject::regExpMatchesArrayStructure): (JSC::JSGlobalObject::regExpStructure): (JSC::JSGlobalObject::stringObjectStructure): (JSC::JSGlobalObject::createStructure): (JSC::Structure::prototypeForLookup):
runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
runtime/JSNumberCell.h: (JSC::JSNumberCell::createStructure): (JSC::JSNumberCell::JSNumberCell):
runtime/JSObject.cpp: (JSC::JSObject::mark): (JSC::JSObject::put): (JSC::JSObject::deleteProperty): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::getPropertyAttributes): (JSC::JSObject::getPropertyNames): (JSC::JSObject::removeDirect): (JSC::JSObject::createInheritorID):
runtime/JSObject.h: (JSC::JSObject::getDirect): (JSC::JSObject::getDirectLocation): (JSC::JSObject::hasCustomProperties): (JSC::JSObject::hasGetterSetterProperties): (JSC::JSObject::createStructure): (JSC::JSObject::JSObject): (JSC::JSObject::~JSObject): (JSC::JSObject::prototype): (JSC::JSObject::setPrototype): (JSC::JSObject::setStructure): (JSC::JSObject::inheritorID): (JSC::JSObject::inlineGetOwnPropertySlot): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSCell::fastGetOwnPropertySlot): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::transitionTo):
runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::next):
runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::JSStaticScopeObject): (JSC::JSStaticScopeObject::createStructure):
runtime/JSString.h: (JSC::JSString::JSString): (JSC::JSString::createStructure):
runtime/JSVariableObject.h: (JSC::JSVariableObject::JSVariableObject):
runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject):
runtime/MathObject.cpp: (JSC::MathObject::MathObject):
runtime/MathObject.h: (JSC::MathObject::createStructure):
runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
runtime/NativeErrorConstructor.h:
runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
runtime/NativeErrorPrototype.h:
runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
runtime/NumberObject.cpp: (JSC::NumberObject::NumberObject):
runtime/NumberObject.h:
runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
runtime/NumberPrototype.h:
runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
runtime/ObjectConstructor.h:
runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype):
runtime/ObjectPrototype.h:
runtime/Operations.h: (JSC::equalSlowCaseInline):
runtime/PropertyNameArray.h: (JSC::PropertyNameArrayData::setCachedStructure): (JSC::PropertyNameArrayData::cachedStructure): (JSC::PropertyNameArrayData::setCachedPrototypeChain): (JSC::PropertyNameArrayData::cachedPrototypeChain): (JSC::PropertyNameArrayData::PropertyNameArrayData):
runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
runtime/PrototypeFunction.h:
runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure):
runtime/RegExpObject.cpp: (JSC::RegExpObject::RegExpObject):
runtime/RegExpObject.h: (JSC::RegExpObject::createStructure):
runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
runtime/RegExpPrototype.h:
runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
runtime/StringConstructor.h:
runtime/StringObject.cpp: (JSC::StringObject::StringObject):
runtime/StringObject.h: (JSC::StringObject::createStructure):
runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::create): (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined): (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
runtime/StringPrototype.h:
runtime/Structure.cpp: Copied from JavaScriptCore/runtime/StructureID.cpp. (JSC::Structure::dumpStatistics): (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::startIgnoringLeaks): (JSC::Structure::stopIgnoringLeaks): (JSC::Structure::materializePropertyMap): (JSC::Structure::getEnumerablePropertyNames): (JSC::Structure::clearEnumerationCache): (JSC::Structure::growPropertyStorageCapacity): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::removePropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::fromDictionaryTransition): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::removePropertyWithoutTransition): (JSC::Structure::createCachedPrototypeChain): (JSC::Structure::checkConsistency): (JSC::Structure::copyPropertyTable): (JSC::Structure::get): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable): (JSC::Structure::expandPropertyMapHashTable): (JSC::Structure::rehashPropertyMapHashTable): (JSC::Structure::getEnumerablePropertyNamesInternal):
runtime/Structure.h: Copied from JavaScriptCore/runtime/StructureID.h. (JSC::Structure::create): (JSC::Structure::previousID): (JSC::Structure::setCachedPrototypeChain): (JSC::Structure::cachedPrototypeChain): (JSC::Structure::): (JSC::Structure::get):
runtime/StructureChain.cpp: Copied from JavaScriptCore/runtime/StructureIDChain.cpp. (JSC::StructureChain::StructureChain): (JSC::structureChainsAreEqual):
runtime/StructureChain.h: Copied from JavaScriptCore/runtime/StructureIDChain.h. (JSC::StructureChain::create): (JSC::StructureChain::head):
runtime/StructureID.cpp: Removed.
runtime/StructureID.h: Removed.
runtime/StructureIDChain.cpp: Removed.
runtime/StructureIDChain.h: Removed.
runtime/StructureIDTransitionTable.h: Removed.
runtime/StructureTransitionTable.h: Copied from JavaScriptCore/runtime/StructureIDTransitionTable.h.

JavaScriptGlue:

2008-11-15 Darin Adler <Darin Adler>

Rubber stamped by Geoff Garen.

do the long-planned StructureID -> Structure rename

JSRun.cpp: (JSGlueGlobalObject::JSGlueGlobalObject): (JSRun::JSRun):
JSRun.h: (JSGlueGlobalObject::userObjectStructure):
JSUtils.cpp: (getThreadGlobalObject):
UserObjectImp.cpp: (UserObjectImp::UserObjectImp):
UserObjectImp.h: (UserObjectImp::createStructure):

WebCore:

2008-11-15 Darin Adler <Darin Adler>

Rubber stamped by Geoff Garen.

do the long-planned StructureID -> Structure rename

ForwardingHeaders/runtime/Structure.h: Copied from WebCore/ForwardingHeaders/runtime/StructureID.h.
ForwardingHeaders/runtime/StructureID.h: Removed.
bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMStructure): (WebCore::cacheDOMStructure):
bindings/js/JSDOMBinding.h: (WebCore::DOMObject::DOMObject): (WebCore::getDOMStructure):
bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase):
bindings/js/JSDOMWindowBase.h:
bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow):
bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
bindings/js/JSDedicatedWorkerConstructor.cpp: (WebCore::JSDedicatedWorkerConstructor::JSDedicatedWorkerConstructor):
bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): (WebCore::JSHTMLAllCollection::createStructure):
bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
bindings/js/JSInspectedObjectWrapper.h:
bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::leakInspectorCallbackWrapperStructure): (WebCore::JSInspectorCallbackWrapper::wrap): (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper):
bindings/js/JSInspectorCallbackWrapper.h:
bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
bindings/js/JSNamedNodesCollection.h: (WebCore::JSNamedNodesCollection::createStructure):
bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
bindings/js/JSQuarantinedObjectWrapper.h: (WebCore::JSQuarantinedObjectWrapper::createStructure):
bindings/js/JSRGBColor.h: (WebCore::JSRGBColor::createStructure):
bindings/js/JSWorkerContext.cpp: (WebCore::createJSWorkerContextStructure): (WebCore::JSWorkerContext::JSWorkerContext): (WebCore::JSWorkerContext::createPrototype):
bindings/js/JSWorkerContext.h: (WebCore::JSWorkerContext::createStructure): (WebCore::JSWorkerContextPrototype::JSWorkerContextPrototype): (WebCore::JSWorkerContextPrototype::createStructure):
bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
bindings/scripts/CodeGeneratorJS.pm:
bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtConnectionObject::execute):
bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethod::createStructure):
bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::RuntimeObjectImp):
bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructure):

WebKitTools:

2008-11-15 Darin Adler <Darin Adler>

Rubber stamped by Geoff Garen.

do the long-planned StructureID -> Structure rename

Scripts/check-for-global-initializers: Update name of StructureID.o.
Scripts/do-webcore-rename: Renaming script that I used.

8:35 PM Changeset in webkit [38439] by Darin Adler

2 edits in trunk/WebCore

2008-11-15 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

fix just-introduced crash in the svg/custom/svg-fonts-in-html.html test

This gets rid of the crash. It restores the behavior of the CG case from before Dirk
Shulze removed the platorm-dependent code, but perhaps it should be changed further
in the future so that the default for no style is "no stroke". I think the patch is
fine for fill.

svg/graphics/SVGPaintServerSolid.cpp: (WebCore::SVGPaintServerSolid::setup): Added null checks for svgStyle. (WebCore::SVGPaintServerSolid::renderPath): Added null checks for style and svgStyle.

7:58 PM Changeset in webkit [38438] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-11-15 Darin Adler <Darin Adler>

fix non-WREC build

runtime/RegExp.cpp: Put "using namespace WREC" inside #if ENABLE(WREC).

3:45 PM Changeset in webkit [38437] by kevino@webkit.org

2 edits in trunk/JavaScriptCore

Reviewed by Timothy Hatcher.

As ThreadingNone doesn't implement threads, isMainThread should return true, not false.

https://bugs.webkit.org/show_bug.cgi?id=22285

3:39 PM Changeset in webkit [38436] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

Initialize m_networkStateChangedFunction to 0 as otherwise the check for null will fail.

https://bugs.webkit.org/show_bug.cgi?id=22284

3:24 PM Changeset in webkit [38435] by krit@webkit.org

2 edits in trunk/WebCore

2008-11-15 Dirk Schulze <krit@webkit.org>

Reviewed by Geoffrey Garen.

r38426 caused a wrong drawing of a LayoutTest. Use another
way to set the color to pass this test again.

svg/graphics/SVGPaintServerSolid.cpp: (WebCore::SVGPaintServerSolid::setup):

3:02 PM Changeset in webkit [38434] by ggaren@apple.com

10 edits in trunk/JavaScriptCore

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved all WREC-related code into WREC.cpp and put it in a WREC namespace.
Removed the WREC prefix from class names.

VM/CTI.cpp:
VM/CTI.h:
VM/Machine.h: (JSC::BytecodeInterpreter::assemblerBuffer):
masm/X86Assembler.h:
runtime/RegExp.cpp: (JSC::RegExp::RegExp):
wrec/CharacterClassConstructor.cpp:
wrec/CharacterClassConstructor.h:
wrec/WREC.cpp: (WREC::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor): (WREC::GeneratePatternCharacterFunctor::generateAtom): (WREC::GeneratePatternCharacterFunctor::backtrack): (WREC::GenerateCharacterClassFunctor::generateAtom): (WREC::GenerateCharacterClassFunctor::backtrack): (WREC::GenerateBackreferenceFunctor::generateAtom): (WREC::GenerateBackreferenceFunctor::backtrack): (WREC::GenerateParenthesesNonGreedyFunctor::generateAtom): (WREC::GenerateParenthesesNonGreedyFunctor::backtrack): (WREC::Generator::generateBacktrack1): (WREC::Generator::generateBacktrackBackreference): (WREC::Generator::generateBackreferenceQuantifier): (WREC::Generator::generateNonGreedyQuantifier): (WREC::Generator::generateGreedyQuantifier): (WREC::Generator::generatePatternCharacter): (WREC::Generator::generateCharacterClassInvertedRange): (WREC::Generator::generateCharacterClassInverted): (WREC::Generator::generateCharacterClass): (WREC::Generator::generateParentheses): (WREC::Generator::generateParenthesesNonGreedy): (WREC::Generator::generateParenthesesResetTrampoline): (WREC::Generator::generateAssertionBOL): (WREC::Generator::generateAssertionEOL): (WREC::Generator::generateAssertionWordBoundary): (WREC::Generator::generateBackreference): (WREC::Generator::generateDisjunction): (WREC::Generator::terminateDisjunction): (WREC::Parser::parseGreedyQuantifier): (WREC::Parser::parseQuantifier): (WREC::Parser::parsePatternCharacterQualifier): (WREC::Parser::parseCharacterClassQuantifier): (WREC::Parser::parseBackreferenceQuantifier): (WREC::Parser::parseParentheses): (WREC::Parser::parseCharacterClass): (WREC::Parser::parseOctalEscape): (WREC::Parser::parseEscape): (WREC::Parser::parseTerm): (WREC::Parser::parseDisjunction): (WREC::compileRegExp):
wrec/WREC.h: (WREC::Generator::Generator): (WREC::Parser::Parser): (WREC::Parser::parseAlternative):

2:47 PM Changeset in webkit [38433] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Changed another case of "m_jit" to "m_assembler".

VM/CTI.cpp:
wrec/WREC.cpp:
wrec/WREC.h: (JSC::WRECGenerator::WRECGenerator): (JSC::WRECParser::WRECParser):

2:43 PM Changeset in webkit [38432] by ggaren@apple.com

4 edits in trunk/JavaScriptCore

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed "jit" to "assembler" and, for brevity, replaced *jit.* with
using a macro.

VM/CTI.cpp: (JSC::CTI::emitGetVirtualRegister): (JSC::CTI::emitPutCTIArgFromVirtualRegister): (JSC::CTI::emitPutCTIArg): (JSC::CTI::emitGetCTIArg): (JSC::CTI::emitPutCTIArgConstant): (JSC::CTI::emitPutCTIParam): (JSC::CTI::emitGetCTIParam): (JSC::CTI::emitPutToCallFrameHeader): (JSC::CTI::emitGetFromCallFrameHeader): (JSC::CTI::emitPutVirtualRegister): (JSC::CTI::emitInitRegister): (JSC::CTI::emitAllocateNumber): (JSC::CTI::emitNakedCall): (JSC::CTI::emitNakedFastCall): (JSC::CTI::emitCTICall): (JSC::CTI::emitJumpSlowCaseIfNotJSCell): (JSC::CTI::linkSlowCaseIfNotJSCell): (JSC::CTI::emitJumpSlowCaseIfNotImmNum): (JSC::CTI::emitJumpSlowCaseIfNotImmNums): (JSC::CTI::emitFastArithDeTagImmediate): (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero): (JSC::CTI::emitFastArithReTagImmediate): (JSC::CTI::emitFastArithPotentiallyReTagImmediate): (JSC::CTI::emitFastArithImmToInt): (JSC::CTI::emitFastArithIntToImmOrSlowCase): (JSC::CTI::emitFastArithIntToImmNoCheck): (JSC::CTI::emitArithIntToImmWithJump): (JSC::CTI::emitTagAsBoolImmediate): (JSC::CTI::CTI): (JSC::CTI::compileOpCallInitializeCallFrame): (JSC::CTI::compileOpCall): (JSC::CTI::compileOpStrictEq): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileLinkPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdSelf): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompilePutByIdReplace): (JSC::CTI::privateCompilePutByIdTransition): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::privateCompilePatchGetArrayLength): (JSC::CTI::emitGetVariableObjectRegister): (JSC::CTI::emitPutVariableObjectRegister): (JSC::CTI::compileRegExp):
VM/CTI.h:
wrec/WREC.cpp: (JSC::WRECGenerator::generateBacktrack1): (JSC::WRECGenerator::generateBacktrackBackreference): (JSC::WRECGenerator::generateBackreferenceQuantifier): (JSC::WRECGenerator::generateNonGreedyQuantifier): (JSC::WRECGenerator::generateGreedyQuantifier): (JSC::WRECGenerator::generatePatternCharacter): (JSC::WRECGenerator::generateCharacterClassInvertedRange): (JSC::WRECGenerator::generateCharacterClassInverted): (JSC::WRECGenerator::generateCharacterClass): (JSC::WRECGenerator::generateParentheses): (JSC::WRECGenerator::generateParenthesesNonGreedy): (JSC::WRECGenerator::generateParenthesesResetTrampoline): (JSC::WRECGenerator::generateAssertionBOL): (JSC::WRECGenerator::generateAssertionEOL): (JSC::WRECGenerator::generateAssertionWordBoundary): (JSC::WRECGenerator::generateBackreference): (JSC::WRECGenerator::generateDisjunction): (JSC::WRECGenerator::terminateDisjunction):

2:36 PM Changeset in webkit [38431] by weinig@apple.com

2 edits in trunk/JavaScriptCore

2008-11-15 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove dead method declaration.

bytecompiler/CodeGenerator.h:

2:33 PM Changeset in webkit [38430] by ggaren@apple.com

6 edits in trunk/JavaScriptCore

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed LabelID to Label, Label::isForwardLabel to Label::isForward.

VM/LabelID.h: (JSC::Label::Label): (JSC::Label::isForward):
bytecompiler/CodeGenerator.cpp: (JSC::BytecodeGenerator::newLabel): (JSC::BytecodeGenerator::emitLabel): (JSC::BytecodeGenerator::emitJump): (JSC::BytecodeGenerator::emitJumpIfTrue): (JSC::BytecodeGenerator::emitJumpIfFalse): (JSC::BytecodeGenerator::pushFinallyContext): (JSC::BytecodeGenerator::emitComplexJumpScopes): (JSC::BytecodeGenerator::emitJumpScopes): (JSC::BytecodeGenerator::emitNextPropertyName): (JSC::BytecodeGenerator::emitCatch): (JSC::BytecodeGenerator::emitJumpSubroutine): (JSC::prepareJumpTableForImmediateSwitch): (JSC::prepareJumpTableForCharacterSwitch): (JSC::prepareJumpTableForStringSwitch): (JSC::BytecodeGenerator::endSwitch):
bytecompiler/CodeGenerator.h:
bytecompiler/LabelScope.h: (JSC::LabelScope::LabelScope): (JSC::LabelScope::breakTarget): (JSC::LabelScope::continueTarget):
parser/Nodes.cpp: (JSC::LogicalOpNode::emitBytecode): (JSC::ConditionalNode::emitBytecode): (JSC::IfNode::emitBytecode): (JSC::IfElseNode::emitBytecode): (JSC::DoWhileNode::emitBytecode): (JSC::WhileNode::emitBytecode): (JSC::ForNode::emitBytecode): (JSC::ForInNode::emitBytecode): (JSC::ReturnNode::emitBytecode): (JSC::CaseBlockNode::emitBytecodeForBlock): (JSC::TryNode::emitBytecode):

2:24 PM Changeset in webkit [38429] by ggaren@apple.com

5 edits in trunk/JavaScriptCore

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed JITCodeBuffer to AssemblerBuffer and renamed its data members
to be more like the rest of our buffer classes, with a size and a
capacity.

Added an assert in the unchecked put case to match the test in the checked
put case.

Changed a C-style cast to a C++-style cast.

Renamed MAX_INSTRUCTION_SIZE to maxInstructionSize.

VM/CTI.cpp: (JSC::CTI::CTI): (JSC::CTI::compileRegExp):
VM/Machine.cpp: (JSC::BytecodeInterpreter::BytecodeInterpreter):
VM/Machine.h: (JSC::BytecodeInterpreter::assemblerBuffer):
masm/X86Assembler.h: (JSC::AssemblerBuffer::AssemblerBuffer): (JSC::AssemblerBuffer::~AssemblerBuffer): (JSC::AssemblerBuffer::ensureSpace): (JSC::AssemblerBuffer::isAligned): (JSC::AssemblerBuffer::putByteUnchecked): (JSC::AssemblerBuffer::putByte): (JSC::AssemblerBuffer::putShortUnchecked): (JSC::AssemblerBuffer::putShort): (JSC::AssemblerBuffer::putIntUnchecked): (JSC::AssemblerBuffer::putInt): (JSC::AssemblerBuffer::data): (JSC::AssemblerBuffer::size): (JSC::AssemblerBuffer::reset): (JSC::AssemblerBuffer::copy): (JSC::AssemblerBuffer::grow): (JSC::X86Assembler::): (JSC::X86Assembler::X86Assembler): (JSC::X86Assembler::testl_i32r): (JSC::X86Assembler::movl_mr): (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::movl_i32m): (JSC::X86Assembler::emitCall): (JSC::X86Assembler::label): (JSC::X86Assembler::emitUnlinkedJmp): (JSC::X86Assembler::emitUnlinkedJne): (JSC::X86Assembler::emitUnlinkedJe): (JSC::X86Assembler::emitUnlinkedJl): (JSC::X86Assembler::emitUnlinkedJb): (JSC::X86Assembler::emitUnlinkedJle): (JSC::X86Assembler::emitUnlinkedJbe): (JSC::X86Assembler::emitUnlinkedJge): (JSC::X86Assembler::emitUnlinkedJg): (JSC::X86Assembler::emitUnlinkedJa): (JSC::X86Assembler::emitUnlinkedJae): (JSC::X86Assembler::emitUnlinkedJo): (JSC::X86Assembler::emitUnlinkedJp): (JSC::X86Assembler::emitUnlinkedJs): (JSC::X86Assembler::link): (JSC::X86Assembler::emitModRm_rr): (JSC::X86Assembler::emitModRm_rm): (JSC::X86Assembler::emitModRm_opr):

1:37 PM Changeset in webkit [38428] by ggaren@apple.com

21 edits in trunk/JavaScriptCore

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Suggested by Maciej Stachowiak.

Reverted most "opcode" => "bytecode" renames. We use "bytecode" as a
mass noun to refer to a stream of instructions. Each instruction may be
an opcode or an operand.

VM/CTI.cpp: (JSC::CTI::emitCTICall): (JSC::CTI::compileOpCall): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
VM/CTI.h:
VM/CodeBlock.cpp: (JSC::CodeBlock::printStructureIDs): (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructureIDs): (JSC::CodeBlock::refStructureIDs):
VM/CodeBlock.h:
VM/ExceptionHelpers.cpp: (JSC::createNotAnObjectError):
VM/Instruction.h: (JSC::Instruction::Instruction): (JSC::Instruction::):
VM/Machine.cpp: (JSC::BytecodeInterpreter::isOpcode): (JSC::BytecodeInterpreter::throwException): (JSC::BytecodeInterpreter::tryCachePutByID): (JSC::BytecodeInterpreter::uncachePutByID): (JSC::BytecodeInterpreter::tryCacheGetByID): (JSC::BytecodeInterpreter::uncacheGetByID): (JSC::BytecodeInterpreter::privateExecute): (JSC::BytecodeInterpreter::tryCTICachePutByID): (JSC::BytecodeInterpreter::tryCTICacheGetByID):
VM/Machine.h: (JSC::BytecodeInterpreter::getOpcode): (JSC::BytecodeInterpreter::getOpcodeID): (JSC::BytecodeInterpreter::isCallBytecode):
VM/Opcode.cpp: (JSC::): (JSC::OpcodeStats::OpcodeStats): (JSC::compareOpcodeIndices): (JSC::compareOpcodePairIndices): (JSC::OpcodeStats::~OpcodeStats): (JSC::OpcodeStats::recordInstruction): (JSC::OpcodeStats::resetLastInstruction):
VM/Opcode.h: (JSC::): (JSC::padOpcodeName):
VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): (JSC::SamplingTool::run): (JSC::compareOpcodeIndicesSampling): (JSC::SamplingTool::dump):
VM/SamplingTool.h: (JSC::ScopeSampleRecord::ScopeSampleRecord): (JSC::SamplingTool::SamplingTool):
bytecompiler/CodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitLabel): (JSC::BytecodeGenerator::emitOpcode): (JSC::BytecodeGenerator::emitJump): (JSC::BytecodeGenerator::emitJumpIfTrue): (JSC::BytecodeGenerator::emitJumpIfFalse): (JSC::BytecodeGenerator::emitMove): (JSC::BytecodeGenerator::emitUnaryOp): (JSC::BytecodeGenerator::emitPreInc): (JSC::BytecodeGenerator::emitPreDec): (JSC::BytecodeGenerator::emitPostInc): (JSC::BytecodeGenerator::emitPostDec): (JSC::BytecodeGenerator::emitBinaryOp): (JSC::BytecodeGenerator::emitEqualityOp): (JSC::BytecodeGenerator::emitUnexpectedLoad): (JSC::BytecodeGenerator::emitInstanceOf): (JSC::BytecodeGenerator::emitResolve): (JSC::BytecodeGenerator::emitGetScopedVar): (JSC::BytecodeGenerator::emitPutScopedVar): (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveWithBase): (JSC::BytecodeGenerator::emitResolveFunction): (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitPutById): (JSC::BytecodeGenerator::emitPutGetter): (JSC::BytecodeGenerator::emitPutSetter): (JSC::BytecodeGenerator::emitDeleteById): (JSC::BytecodeGenerator::emitGetByVal): (JSC::BytecodeGenerator::emitPutByVal): (JSC::BytecodeGenerator::emitDeleteByVal): (JSC::BytecodeGenerator::emitPutByIndex): (JSC::BytecodeGenerator::emitNewObject): (JSC::BytecodeGenerator::emitNewArray): (JSC::BytecodeGenerator::emitNewFunction): (JSC::BytecodeGenerator::emitNewRegExp): (JSC::BytecodeGenerator::emitNewFunctionExpression): (JSC::BytecodeGenerator::emitCall): (JSC::BytecodeGenerator::emitReturn): (JSC::BytecodeGenerator::emitUnaryNoDstOp): (JSC::BytecodeGenerator::emitConstruct): (JSC::BytecodeGenerator::emitPopScope): (JSC::BytecodeGenerator::emitDebugHook): (JSC::BytecodeGenerator::emitComplexJumpScopes): (JSC::BytecodeGenerator::emitJumpScopes): (JSC::BytecodeGenerator::emitNextPropertyName): (JSC::BytecodeGenerator::emitCatch): (JSC::BytecodeGenerator::emitNewError): (JSC::BytecodeGenerator::emitJumpSubroutine): (JSC::BytecodeGenerator::emitSubroutineReturn): (JSC::BytecodeGenerator::emitPushNewScope): (JSC::BytecodeGenerator::beginSwitch):
bytecompiler/CodeGenerator.h:
jsc.cpp: (runWithScripts):
masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::emitModRm_opr): (JSC::X86Assembler::emitModRm_opr_Unchecked): (JSC::X86Assembler::emitModRm_opm): (JSC::X86Assembler::emitModRm_opm_Unchecked): (JSC::X86Assembler::emitModRm_opmsib):
parser/Nodes.cpp: (JSC::UnaryOpNode::emitBytecode): (JSC::BinaryOpNode::emitBytecode): (JSC::ReverseBinaryOpNode::emitBytecode): (JSC::ThrowableBinaryOpNode::emitBytecode): (JSC::emitReadModifyAssignment): (JSC::ScopeNode::ScopeNode):
parser/Nodes.h: (JSC::UnaryPlusNode::): (JSC::NegateNode::): (JSC::BitwiseNotNode::): (JSC::LogicalNotNode::): (JSC::MultNode::): (JSC::DivNode::): (JSC::ModNode::): (JSC::AddNode::): (JSC::SubNode::): (JSC::LeftShiftNode::): (JSC::RightShiftNode::): (JSC::UnsignedRightShiftNode::): (JSC::LessNode::): (JSC::GreaterNode::): (JSC::LessEqNode::): (JSC::GreaterEqNode::): (JSC::InstanceOfNode::): (JSC::InNode::): (JSC::EqualNode::): (JSC::NotEqualNode::): (JSC::StrictEqualNode::): (JSC::NotStrictEqualNode::): (JSC::BitAndNode::): (JSC::BitOrNode::): (JSC::BitXOrNode::):
runtime/StructureID.cpp: (JSC::StructureID::fromDictionaryTransition):
wtf/Platform.h:

1:05 PM Changeset in webkit [38427] by ggaren@apple.com

11 edits in trunk/JavaScriptCore

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renames:

CodeGenerator => BytecodeGenerator
emitCodeForBlock => emitBytecodeForBlock
generatedByteCode => generatedBytecode
generateCode => generateBytecode

JavaScriptCore.exp:
bytecompiler/CodeGenerator.cpp: (JSC::BytecodeGenerator::setDumpsGeneratedCode): (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::addVar): (JSC::BytecodeGenerator::addGlobalVar): (JSC::BytecodeGenerator::allocateConstants): (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::addParameter): (JSC::BytecodeGenerator::registerFor): (JSC::BytecodeGenerator::constRegisterFor): (JSC::BytecodeGenerator::isLocal): (JSC::BytecodeGenerator::isLocalConstant): (JSC::BytecodeGenerator::newRegister): (JSC::BytecodeGenerator::newTemporary): (JSC::BytecodeGenerator::highestUsedRegister): (JSC::BytecodeGenerator::newLabelScope): (JSC::BytecodeGenerator::newLabel): (JSC::BytecodeGenerator::emitLabel): (JSC::BytecodeGenerator::emitBytecode): (JSC::BytecodeGenerator::retrieveLastBinaryOp): (JSC::BytecodeGenerator::retrieveLastUnaryOp): (JSC::BytecodeGenerator::rewindBinaryOp): (JSC::BytecodeGenerator::rewindUnaryOp): (JSC::BytecodeGenerator::emitJump): (JSC::BytecodeGenerator::emitJumpIfTrue): (JSC::BytecodeGenerator::emitJumpIfFalse): (JSC::BytecodeGenerator::addConstant): (JSC::BytecodeGenerator::addUnexpectedConstant): (JSC::BytecodeGenerator::addRegExp): (JSC::BytecodeGenerator::emitMove): (JSC::BytecodeGenerator::emitUnaryOp): (JSC::BytecodeGenerator::emitPreInc): (JSC::BytecodeGenerator::emitPreDec): (JSC::BytecodeGenerator::emitPostInc): (JSC::BytecodeGenerator::emitPostDec): (JSC::BytecodeGenerator::emitBinaryOp): (JSC::BytecodeGenerator::emitEqualityOp): (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitUnexpectedLoad): (JSC::BytecodeGenerator::findScopedProperty): (JSC::BytecodeGenerator::emitInstanceOf): (JSC::BytecodeGenerator::emitResolve): (JSC::BytecodeGenerator::emitGetScopedVar): (JSC::BytecodeGenerator::emitPutScopedVar): (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveWithBase): (JSC::BytecodeGenerator::emitResolveFunction): (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitPutById): (JSC::BytecodeGenerator::emitPutGetter): (JSC::BytecodeGenerator::emitPutSetter): (JSC::BytecodeGenerator::emitDeleteById): (JSC::BytecodeGenerator::emitGetByVal): (JSC::BytecodeGenerator::emitPutByVal): (JSC::BytecodeGenerator::emitDeleteByVal): (JSC::BytecodeGenerator::emitPutByIndex): (JSC::BytecodeGenerator::emitNewObject): (JSC::BytecodeGenerator::emitNewArray): (JSC::BytecodeGenerator::emitNewFunction): (JSC::BytecodeGenerator::emitNewRegExp): (JSC::BytecodeGenerator::emitNewFunctionExpression): (JSC::BytecodeGenerator::emitCall): (JSC::BytecodeGenerator::emitCallEval): (JSC::BytecodeGenerator::emitReturn): (JSC::BytecodeGenerator::emitUnaryNoDstOp): (JSC::BytecodeGenerator::emitConstruct): (JSC::BytecodeGenerator::emitPushScope): (JSC::BytecodeGenerator::emitPopScope): (JSC::BytecodeGenerator::emitDebugHook): (JSC::BytecodeGenerator::pushFinallyContext): (JSC::BytecodeGenerator::popFinallyContext): (JSC::BytecodeGenerator::breakTarget): (JSC::BytecodeGenerator::continueTarget): (JSC::BytecodeGenerator::emitComplexJumpScopes): (JSC::BytecodeGenerator::emitJumpScopes): (JSC::BytecodeGenerator::emitNextPropertyName): (JSC::BytecodeGenerator::emitCatch): (JSC::BytecodeGenerator::emitNewError): (JSC::BytecodeGenerator::emitJumpSubroutine): (JSC::BytecodeGenerator::emitSubroutineReturn): (JSC::BytecodeGenerator::emitPushNewScope): (JSC::BytecodeGenerator::beginSwitch): (JSC::BytecodeGenerator::endSwitch): (JSC::BytecodeGenerator::emitThrowExpressionTooDeepException):
bytecompiler/CodeGenerator.h:
jsc.cpp: (runWithScripts):
parser/Nodes.cpp: (JSC::ThrowableExpressionData::emitThrowError): (JSC::NullNode::emitBytecode): (JSC::BooleanNode::emitBytecode): (JSC::NumberNode::emitBytecode): (JSC::StringNode::emitBytecode): (JSC::RegExpNode::emitBytecode): (JSC::ThisNode::emitBytecode): (JSC::ResolveNode::isPure): (JSC::ResolveNode::emitBytecode): (JSC::ArrayNode::emitBytecode): (JSC::ObjectLiteralNode::emitBytecode): (JSC::PropertyListNode::emitBytecode): (JSC::BracketAccessorNode::emitBytecode): (JSC::DotAccessorNode::emitBytecode): (JSC::ArgumentListNode::emitBytecode): (JSC::NewExprNode::emitBytecode): (JSC::EvalFunctionCallNode::emitBytecode): (JSC::FunctionCallValueNode::emitBytecode): (JSC::FunctionCallResolveNode::emitBytecode): (JSC::FunctionCallBracketNode::emitBytecode): (JSC::FunctionCallDotNode::emitBytecode): (JSC::emitPreIncOrDec): (JSC::emitPostIncOrDec): (JSC::PostfixResolveNode::emitBytecode): (JSC::PostfixBracketNode::emitBytecode): (JSC::PostfixDotNode::emitBytecode): (JSC::PostfixErrorNode::emitBytecode): (JSC::DeleteResolveNode::emitBytecode): (JSC::DeleteBracketNode::emitBytecode): (JSC::DeleteDotNode::emitBytecode): (JSC::DeleteValueNode::emitBytecode): (JSC::VoidNode::emitBytecode): (JSC::TypeOfResolveNode::emitBytecode): (JSC::TypeOfValueNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode): (JSC::PrefixBracketNode::emitBytecode): (JSC::PrefixDotNode::emitBytecode): (JSC::PrefixErrorNode::emitBytecode): (JSC::UnaryOpNode::emitBytecode): (JSC::BinaryOpNode::emitBytecode): (JSC::EqualNode::emitBytecode): (JSC::StrictEqualNode::emitBytecode): (JSC::ReverseBinaryOpNode::emitBytecode): (JSC::ThrowableBinaryOpNode::emitBytecode): (JSC::InstanceOfNode::emitBytecode): (JSC::LogicalOpNode::emitBytecode): (JSC::ConditionalNode::emitBytecode): (JSC::emitReadModifyAssignment): (JSC::ReadModifyResolveNode::emitBytecode): (JSC::AssignResolveNode::emitBytecode): (JSC::AssignDotNode::emitBytecode): (JSC::ReadModifyDotNode::emitBytecode): (JSC::AssignErrorNode::emitBytecode): (JSC::AssignBracketNode::emitBytecode): (JSC::ReadModifyBracketNode::emitBytecode): (JSC::CommaNode::emitBytecode): (JSC::ConstDeclNode::emitCodeSingle): (JSC::ConstDeclNode::emitBytecode): (JSC::ConstStatementNode::emitBytecode): (JSC::statementListEmitCode): (JSC::BlockNode::emitBytecode): (JSC::EmptyStatementNode::emitBytecode): (JSC::DebuggerStatementNode::emitBytecode): (JSC::ExprStatementNode::emitBytecode): (JSC::VarStatementNode::emitBytecode): (JSC::IfNode::emitBytecode): (JSC::IfElseNode::emitBytecode): (JSC::DoWhileNode::emitBytecode): (JSC::WhileNode::emitBytecode): (JSC::ForNode::emitBytecode): (JSC::ForInNode::emitBytecode): (JSC::ContinueNode::emitBytecode): (JSC::BreakNode::emitBytecode): (JSC::ReturnNode::emitBytecode): (JSC::WithNode::emitBytecode): (JSC::CaseBlockNode::emitBytecodeForBlock): (JSC::SwitchNode::emitBytecode): (JSC::LabelNode::emitBytecode): (JSC::ThrowNode::emitBytecode): (JSC::TryNode::emitBytecode): (JSC::EvalNode::emitBytecode): (JSC::EvalNode::generateBytecode): (JSC::FunctionBodyNode::generateBytecode): (JSC::FunctionBodyNode::emitBytecode): (JSC::ProgramNode::emitBytecode): (JSC::ProgramNode::generateBytecode): (JSC::FuncDeclNode::emitBytecode): (JSC::FuncExprNode::emitBytecode):
parser/Nodes.h: (JSC::ExpressionNode::): (JSC::BooleanNode::): (JSC::NumberNode::): (JSC::StringNode::): (JSC::ProgramNode::): (JSC::EvalNode::): (JSC::FunctionBodyNode::):
runtime/Arguments.h: (JSC::Arguments::getArgumentsData): (JSC::JSActivation::copyRegisters):
runtime/JSActivation.cpp: (JSC::JSActivation::mark):
runtime/JSActivation.h: (JSC::JSActivation::JSActivationData::JSActivationData):
runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction):

12:48 PM Changeset in webkit [38426] by krit@webkit.org

7 edits
3 deletes in trunk/WebCore

2008-11-15 Dirk Schulze <vbs85@gmx.de>

Reviewed by Darin Adler.

Removed platform dependent code on SVGPaintServerSolid.

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
svg/graphics/SVGPaintServerSolid.cpp: (WebCore::SVGPaintServerSolid::setup): (WebCore::SVGPaintServerSolid::renderPath):
svg/graphics/SVGPaintServerSolid.h:
svg/graphics/cairo/SVGPaintServerSolidCairo.cpp: Removed.
svg/graphics/cg/SVGPaintServerSolidCg.cpp: Removed.
svg/graphics/qt/SVGPaintServerSolidQt.cpp: Removed.

12:34 PM Changeset in webkit [38425] by ggaren@apple.com

22 edits in trunk/JavaScriptCore

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed all forms of "byte code" "opcode" "op code" "code" "bitcode"
etc. to "bytecode".

VM/CTI.cpp: (JSC::CTI::printBytecodeOperandTypes): (JSC::CTI::emitAllocateNumber): (JSC::CTI::emitNakedCall): (JSC::CTI::emitNakedFastCall): (JSC::CTI::emitCTICall): (JSC::CTI::emitJumpSlowCaseIfNotJSCell): (JSC::CTI::emitJumpSlowCaseIfNotImmNum): (JSC::CTI::emitJumpSlowCaseIfNotImmNums): (JSC::CTI::emitFastArithIntToImmOrSlowCase): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
VM/CTI.h: (JSC::CallRecord::CallRecord): (JSC::SwitchRecord::SwitchRecord):
VM/CodeBlock.cpp: (JSC::CodeBlock::printStructureIDs): (JSC::CodeBlock::dump): (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::derefStructureIDs): (JSC::CodeBlock::refStructureIDs):
VM/CodeBlock.h: (JSC::StructureStubInfo::StructureStubInfo):
VM/ExceptionHelpers.cpp: (JSC::createNotAnObjectError):
VM/Instruction.h: (JSC::Instruction::Instruction): (JSC::Instruction::):
VM/Machine.cpp: (JSC::BytecodeInterpreter::isBytecode): (JSC::BytecodeInterpreter::throwException): (JSC::BytecodeInterpreter::execute): (JSC::BytecodeInterpreter::tryCachePutByID): (JSC::BytecodeInterpreter::uncachePutByID): (JSC::BytecodeInterpreter::tryCacheGetByID): (JSC::BytecodeInterpreter::uncacheGetByID): (JSC::BytecodeInterpreter::privateExecute): (JSC::BytecodeInterpreter::tryCTICachePutByID): (JSC::BytecodeInterpreter::tryCTICacheGetByID): (JSC::BytecodeInterpreter::cti_op_call_JSFunction): (JSC::BytecodeInterpreter::cti_vm_dontLazyLinkCall): (JSC::BytecodeInterpreter::cti_vm_lazyLinkCall):
VM/Machine.h: (JSC::BytecodeInterpreter::getBytecode): (JSC::BytecodeInterpreter::getBytecodeID): (JSC::BytecodeInterpreter::isCallBytecode):
VM/Opcode.cpp: (JSC::): (JSC::BytecodeStats::BytecodeStats): (JSC::compareBytecodeIndices): (JSC::compareBytecodePairIndices): (JSC::BytecodeStats::~BytecodeStats): (JSC::BytecodeStats::recordInstruction): (JSC::BytecodeStats::resetLastInstruction):
VM/Opcode.h: (JSC::): (JSC::padBytecodeName):
VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): (JSC::SamplingTool::run): (JSC::compareBytecodeIndicesSampling): (JSC::SamplingTool::dump):
VM/SamplingTool.h: (JSC::ScopeSampleRecord::ScopeSampleRecord): (JSC::SamplingTool::SamplingTool):
bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::generate): (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::emitLabel): (JSC::CodeGenerator::emitBytecode): (JSC::CodeGenerator::emitJump): (JSC::CodeGenerator::emitJumpIfTrue): (JSC::CodeGenerator::emitJumpIfFalse): (JSC::CodeGenerator::emitMove): (JSC::CodeGenerator::emitUnaryOp): (JSC::CodeGenerator::emitPreInc): (JSC::CodeGenerator::emitPreDec): (JSC::CodeGenerator::emitPostInc): (JSC::CodeGenerator::emitPostDec): (JSC::CodeGenerator::emitBinaryOp): (JSC::CodeGenerator::emitEqualityOp): (JSC::CodeGenerator::emitUnexpectedLoad): (JSC::CodeGenerator::emitInstanceOf): (JSC::CodeGenerator::emitResolve): (JSC::CodeGenerator::emitGetScopedVar): (JSC::CodeGenerator::emitPutScopedVar): (JSC::CodeGenerator::emitResolveBase): (JSC::CodeGenerator::emitResolveWithBase): (JSC::CodeGenerator::emitResolveFunction): (JSC::CodeGenerator::emitGetById): (JSC::CodeGenerator::emitPutById): (JSC::CodeGenerator::emitPutGetter): (JSC::CodeGenerator::emitPutSetter): (JSC::CodeGenerator::emitDeleteById): (JSC::CodeGenerator::emitGetByVal): (JSC::CodeGenerator::emitPutByVal): (JSC::CodeGenerator::emitDeleteByVal): (JSC::CodeGenerator::emitPutByIndex): (JSC::CodeGenerator::emitNewObject): (JSC::CodeGenerator::emitNewArray): (JSC::CodeGenerator::emitNewFunction): (JSC::CodeGenerator::emitNewRegExp): (JSC::CodeGenerator::emitNewFunctionExpression): (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitReturn): (JSC::CodeGenerator::emitUnaryNoDstOp): (JSC::CodeGenerator::emitConstruct): (JSC::CodeGenerator::emitPopScope): (JSC::CodeGenerator::emitDebugHook): (JSC::CodeGenerator::emitComplexJumpScopes): (JSC::CodeGenerator::emitJumpScopes): (JSC::CodeGenerator::emitNextPropertyName): (JSC::CodeGenerator::emitCatch): (JSC::CodeGenerator::emitNewError): (JSC::CodeGenerator::emitJumpSubroutine): (JSC::CodeGenerator::emitSubroutineReturn): (JSC::CodeGenerator::emitPushNewScope): (JSC::CodeGenerator::beginSwitch): (JSC::CodeGenerator::endSwitch):
bytecompiler/CodeGenerator.h: (JSC::CodeGenerator::emitNode):
jsc.cpp: (runWithScripts):
masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::emitModRm_opr): (JSC::X86Assembler::emitModRm_opr_Unchecked): (JSC::X86Assembler::emitModRm_opm): (JSC::X86Assembler::emitModRm_opm_Unchecked): (JSC::X86Assembler::emitModRm_opmsib):
parser/Nodes.cpp: (JSC::NullNode::emitBytecode): (JSC::BooleanNode::emitBytecode): (JSC::NumberNode::emitBytecode): (JSC::StringNode::emitBytecode): (JSC::RegExpNode::emitBytecode): (JSC::ThisNode::emitBytecode): (JSC::ResolveNode::emitBytecode): (JSC::ArrayNode::emitBytecode): (JSC::ObjectLiteralNode::emitBytecode): (JSC::PropertyListNode::emitBytecode): (JSC::BracketAccessorNode::emitBytecode): (JSC::DotAccessorNode::emitBytecode): (JSC::ArgumentListNode::emitBytecode): (JSC::NewExprNode::emitBytecode): (JSC::EvalFunctionCallNode::emitBytecode): (JSC::FunctionCallValueNode::emitBytecode): (JSC::FunctionCallResolveNode::emitBytecode): (JSC::FunctionCallBracketNode::emitBytecode): (JSC::FunctionCallDotNode::emitBytecode): (JSC::PostfixResolveNode::emitBytecode): (JSC::PostfixBracketNode::emitBytecode): (JSC::PostfixDotNode::emitBytecode): (JSC::PostfixErrorNode::emitBytecode): (JSC::DeleteResolveNode::emitBytecode): (JSC::DeleteBracketNode::emitBytecode): (JSC::DeleteDotNode::emitBytecode): (JSC::DeleteValueNode::emitBytecode): (JSC::VoidNode::emitBytecode): (JSC::TypeOfResolveNode::emitBytecode): (JSC::TypeOfValueNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode): (JSC::PrefixBracketNode::emitBytecode): (JSC::PrefixDotNode::emitBytecode): (JSC::PrefixErrorNode::emitBytecode): (JSC::UnaryOpNode::emitBytecode): (JSC::BinaryOpNode::emitBytecode): (JSC::EqualNode::emitBytecode): (JSC::StrictEqualNode::emitBytecode): (JSC::ReverseBinaryOpNode::emitBytecode): (JSC::ThrowableBinaryOpNode::emitBytecode): (JSC::InstanceOfNode::emitBytecode): (JSC::LogicalOpNode::emitBytecode): (JSC::ConditionalNode::emitBytecode): (JSC::emitReadModifyAssignment): (JSC::ReadModifyResolveNode::emitBytecode): (JSC::AssignResolveNode::emitBytecode): (JSC::AssignDotNode::emitBytecode): (JSC::ReadModifyDotNode::emitBytecode): (JSC::AssignErrorNode::emitBytecode): (JSC::AssignBracketNode::emitBytecode): (JSC::ReadModifyBracketNode::emitBytecode): (JSC::CommaNode::emitBytecode): (JSC::ConstDeclNode::emitBytecode): (JSC::ConstStatementNode::emitBytecode): (JSC::BlockNode::emitBytecode): (JSC::EmptyStatementNode::emitBytecode): (JSC::DebuggerStatementNode::emitBytecode): (JSC::ExprStatementNode::emitBytecode): (JSC::VarStatementNode::emitBytecode): (JSC::IfNode::emitBytecode): (JSC::IfElseNode::emitBytecode): (JSC::DoWhileNode::emitBytecode): (JSC::WhileNode::emitBytecode): (JSC::ForNode::emitBytecode): (JSC::ForInNode::emitBytecode): (JSC::ContinueNode::emitBytecode): (JSC::BreakNode::emitBytecode): (JSC::ReturnNode::emitBytecode): (JSC::WithNode::emitBytecode): (JSC::SwitchNode::emitBytecode): (JSC::LabelNode::emitBytecode): (JSC::ThrowNode::emitBytecode): (JSC::TryNode::emitBytecode): (JSC::ScopeNode::ScopeNode): (JSC::EvalNode::emitBytecode): (JSC::FunctionBodyNode::emitBytecode): (JSC::ProgramNode::emitBytecode): (JSC::FuncDeclNode::emitBytecode): (JSC::FuncExprNode::emitBytecode):
parser/Nodes.h: (JSC::UnaryPlusNode::): (JSC::NegateNode::): (JSC::BitwiseNotNode::): (JSC::LogicalNotNode::): (JSC::MultNode::): (JSC::DivNode::): (JSC::ModNode::): (JSC::AddNode::): (JSC::SubNode::): (JSC::LeftShiftNode::): (JSC::RightShiftNode::): (JSC::UnsignedRightShiftNode::): (JSC::LessNode::): (JSC::GreaterNode::): (JSC::LessEqNode::): (JSC::GreaterEqNode::): (JSC::InstanceOfNode::): (JSC::InNode::): (JSC::EqualNode::): (JSC::NotEqualNode::): (JSC::StrictEqualNode::): (JSC::NotStrictEqualNode::): (JSC::BitAndNode::): (JSC::BitOrNode::): (JSC::BitXOrNode::): (JSC::ProgramNode::): (JSC::EvalNode::): (JSC::FunctionBodyNode::):
runtime/JSNotAnObject.h:
runtime/StructureID.cpp: (JSC::StructureID::fromDictionaryTransition):
wtf/Platform.h:

12:23 PM Changeset in webkit [38424] by kevino@webkit.org

3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add API for setting transparent webview background.

https://bugs.webkit.org/show_bug.cgi?id=22281

11:55 AM Changeset in webkit [38423] by ggaren@apple.com

45 edits in trunk

JavaScriptCore:

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed Machine to BytecodeInterpreter.

Nixed the Interpreter class, and changed its two functions to stand-alone
functions.

JavaScriptCore.exp:
VM/CTI.cpp: (JSC::): (JSC::CTI::emitCTICall): (JSC::CTI::CTI): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdSelf): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompilePutByIdReplace): (JSC::CTI::privateCompilePutByIdTransition): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::freeCTIMachineTrampolines): (JSC::CTI::patchGetByIdSelf): (JSC::CTI::patchPutByIdReplace): (JSC::CTI::privateCompilePatchGetArrayLength): (JSC::CTI::compileRegExp):
VM/CTI.h:
VM/CodeBlock.cpp: (JSC::CodeBlock::printStructureIDs): (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructureIDs): (JSC::CodeBlock::refStructureIDs):
VM/ExceptionHelpers.cpp: (JSC::createNotAnObjectError):
VM/Machine.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::BytecodeInterpreter::resolve): (JSC::BytecodeInterpreter::resolveSkip): (JSC::BytecodeInterpreter::resolveGlobal): (JSC::BytecodeInterpreter::resolveBase): (JSC::BytecodeInterpreter::resolveBaseAndProperty): (JSC::BytecodeInterpreter::resolveBaseAndFunc): (JSC::BytecodeInterpreter::slideRegisterWindowForCall): (JSC::BytecodeInterpreter::callEval): (JSC::BytecodeInterpreter::BytecodeInterpreter): (JSC::BytecodeInterpreter::initialize): (JSC::BytecodeInterpreter::~BytecodeInterpreter): (JSC::BytecodeInterpreter::dumpCallFrame): (JSC::BytecodeInterpreter::dumpRegisters): (JSC::BytecodeInterpreter::isOpcode): (JSC::BytecodeInterpreter::unwindCallFrame): (JSC::BytecodeInterpreter::throwException): (JSC::BytecodeInterpreter::execute): (JSC::BytecodeInterpreter::debug): (JSC::BytecodeInterpreter::resetTimeoutCheck): (JSC::BytecodeInterpreter::checkTimeout): (JSC::BytecodeInterpreter::createExceptionScope): (JSC::BytecodeInterpreter::tryCachePutByID): (JSC::BytecodeInterpreter::uncachePutByID): (JSC::BytecodeInterpreter::tryCacheGetByID): (JSC::BytecodeInterpreter::uncacheGetByID): (JSC::BytecodeInterpreter::privateExecute): (JSC::BytecodeInterpreter::retrieveArguments): (JSC::BytecodeInterpreter::retrieveCaller): (JSC::BytecodeInterpreter::retrieveLastCaller): (JSC::BytecodeInterpreter::findFunctionCallFrame): (JSC::BytecodeInterpreter::tryCTICachePutByID): (JSC::BytecodeInterpreter::tryCTICacheGetByID): (JSC::BytecodeInterpreter::cti_op_convert_this): (JSC::BytecodeInterpreter::cti_op_end): (JSC::BytecodeInterpreter::cti_op_add): (JSC::BytecodeInterpreter::cti_op_pre_inc): (JSC::BytecodeInterpreter::cti_timeout_check): (JSC::BytecodeInterpreter::cti_register_file_check): (JSC::BytecodeInterpreter::cti_op_loop_if_less): (JSC::BytecodeInterpreter::cti_op_loop_if_lesseq): (JSC::BytecodeInterpreter::cti_op_new_object): (JSC::BytecodeInterpreter::cti_op_put_by_id): (JSC::BytecodeInterpreter::cti_op_put_by_id_second): (JSC::BytecodeInterpreter::cti_op_put_by_id_generic): (JSC::BytecodeInterpreter::cti_op_put_by_id_fail): (JSC::BytecodeInterpreter::cti_op_get_by_id): (JSC::BytecodeInterpreter::cti_op_get_by_id_second): (JSC::BytecodeInterpreter::cti_op_get_by_id_generic): (JSC::BytecodeInterpreter::cti_op_get_by_id_fail): (JSC::BytecodeInterpreter::cti_op_instanceof): (JSC::BytecodeInterpreter::cti_op_del_by_id): (JSC::BytecodeInterpreter::cti_op_mul): (JSC::BytecodeInterpreter::cti_op_new_func): (JSC::BytecodeInterpreter::cti_op_call_JSFunction): (JSC::BytecodeInterpreter::cti_op_call_arityCheck): (JSC::BytecodeInterpreter::cti_vm_dontLazyLinkCall): (JSC::BytecodeInterpreter::cti_vm_lazyLinkCall): (JSC::BytecodeInterpreter::cti_op_push_activation): (JSC::BytecodeInterpreter::cti_op_call_NotJSFunction): (JSC::BytecodeInterpreter::cti_op_create_arguments): (JSC::BytecodeInterpreter::cti_op_create_arguments_no_params): (JSC::BytecodeInterpreter::cti_op_tear_off_activation): (JSC::BytecodeInterpreter::cti_op_tear_off_arguments): (JSC::BytecodeInterpreter::cti_op_profile_will_call): (JSC::BytecodeInterpreter::cti_op_profile_did_call): (JSC::BytecodeInterpreter::cti_op_ret_scopeChain): (JSC::BytecodeInterpreter::cti_op_new_array): (JSC::BytecodeInterpreter::cti_op_resolve): (JSC::BytecodeInterpreter::cti_op_construct_JSConstruct): (JSC::BytecodeInterpreter::cti_op_construct_NotJSConstruct): (JSC::BytecodeInterpreter::cti_op_get_by_val): (JSC::BytecodeInterpreter::cti_op_resolve_func): (JSC::BytecodeInterpreter::cti_op_sub): (JSC::BytecodeInterpreter::cti_op_put_by_val): (JSC::BytecodeInterpreter::cti_op_put_by_val_array): (JSC::BytecodeInterpreter::cti_op_lesseq): (JSC::BytecodeInterpreter::cti_op_loop_if_true): (JSC::BytecodeInterpreter::cti_op_negate): (JSC::BytecodeInterpreter::cti_op_resolve_base): (JSC::BytecodeInterpreter::cti_op_resolve_skip): (JSC::BytecodeInterpreter::cti_op_resolve_global): (JSC::BytecodeInterpreter::cti_op_div): (JSC::BytecodeInterpreter::cti_op_pre_dec): (JSC::BytecodeInterpreter::cti_op_jless): (JSC::BytecodeInterpreter::cti_op_not): (JSC::BytecodeInterpreter::cti_op_jtrue): (JSC::BytecodeInterpreter::cti_op_post_inc): (JSC::BytecodeInterpreter::cti_op_eq): (JSC::BytecodeInterpreter::cti_op_lshift): (JSC::BytecodeInterpreter::cti_op_bitand): (JSC::BytecodeInterpreter::cti_op_rshift): (JSC::BytecodeInterpreter::cti_op_bitnot): (JSC::BytecodeInterpreter::cti_op_resolve_with_base): (JSC::BytecodeInterpreter::cti_op_new_func_exp): (JSC::BytecodeInterpreter::cti_op_mod): (JSC::BytecodeInterpreter::cti_op_less): (JSC::BytecodeInterpreter::cti_op_neq): (JSC::BytecodeInterpreter::cti_op_post_dec): (JSC::BytecodeInterpreter::cti_op_urshift): (JSC::BytecodeInterpreter::cti_op_bitxor): (JSC::BytecodeInterpreter::cti_op_new_regexp): (JSC::BytecodeInterpreter::cti_op_bitor): (JSC::BytecodeInterpreter::cti_op_call_eval): (JSC::BytecodeInterpreter::cti_op_throw): (JSC::BytecodeInterpreter::cti_op_get_pnames): (JSC::BytecodeInterpreter::cti_op_next_pname): (JSC::BytecodeInterpreter::cti_op_push_scope): (JSC::BytecodeInterpreter::cti_op_pop_scope): (JSC::BytecodeInterpreter::cti_op_typeof): (JSC::BytecodeInterpreter::cti_op_is_undefined): (JSC::BytecodeInterpreter::cti_op_is_boolean): (JSC::BytecodeInterpreter::cti_op_is_number): (JSC::BytecodeInterpreter::cti_op_is_string): (JSC::BytecodeInterpreter::cti_op_is_object): (JSC::BytecodeInterpreter::cti_op_is_function): (JSC::BytecodeInterpreter::cti_op_stricteq): (JSC::BytecodeInterpreter::cti_op_nstricteq): (JSC::BytecodeInterpreter::cti_op_to_jsnumber): (JSC::BytecodeInterpreter::cti_op_in): (JSC::BytecodeInterpreter::cti_op_push_new_scope): (JSC::BytecodeInterpreter::cti_op_jmp_scopes): (JSC::BytecodeInterpreter::cti_op_put_by_index): (JSC::BytecodeInterpreter::cti_op_switch_imm): (JSC::BytecodeInterpreter::cti_op_switch_char): (JSC::BytecodeInterpreter::cti_op_switch_string): (JSC::BytecodeInterpreter::cti_op_del_by_val): (JSC::BytecodeInterpreter::cti_op_put_getter): (JSC::BytecodeInterpreter::cti_op_put_setter): (JSC::BytecodeInterpreter::cti_op_new_error): (JSC::BytecodeInterpreter::cti_op_debug): (JSC::BytecodeInterpreter::cti_vm_throw):
VM/Machine.h:
VM/Register.h:
VM/SamplingTool.cpp: (JSC::SamplingTool::run):
VM/SamplingTool.h: (JSC::SamplingTool::SamplingTool):
bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::generate): (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::emitOpcode):
debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
jsc.cpp: (runWithScripts):
parser/Nodes.cpp: (JSC::ScopeNode::ScopeNode):
profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::addParentForConsoleStart):
runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush):
runtime/Collector.cpp: (JSC::Heap::collect):
runtime/ExecState.h: (JSC::ExecState::interpreter):
runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncApply):
runtime/Interpreter.cpp: (JSC::Interpreter::evaluate):
runtime/JSCell.h:
runtime/JSFunction.cpp: (JSC::JSFunction::call): (JSC::JSFunction::argumentsGetter): (JSC::JSFunction::callerGetter): (JSC::JSFunction::construct):
runtime/JSFunction.h:
runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData):
runtime/JSGlobalData.h:
runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::~JSGlobalObject): (JSC::JSGlobalObject::setTimeoutTime): (JSC::JSGlobalObject::startTimeoutCheck): (JSC::JSGlobalObject::stopTimeoutCheck): (JSC::JSGlobalObject::mark):
runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
runtime/JSString.h:
runtime/RegExp.cpp: (JSC::RegExp::RegExp):

JavaScriptGlue:

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore renames.

JSRun.cpp: (JSRun::Evaluate): (JSRun::CheckSyntax):

WebCore:

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore renames.

bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark):
bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
bindings/objc/WebScriptObject.mm: (-[WebScriptObject evaluateWebScript:]):
bridge/NP_jsobject.cpp: (_NPN_Evaluate):
bridge/jni/jni_jsobject.mm: (JavaJSObject::eval):
page/Console.cpp: (WebCore::retrieveLastCaller): (WebCore::Console::trace):

WebKit/win:

2008-11-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore renames.

WebScriptCallFrame.cpp: (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):

10:19 AM Changeset in webkit [38422] by bolsinga@apple.com

2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
exit-time destructor. Update code that was changed to fix this issue that ran
into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
in gcc build 5465). Also typdefs for template types needed to be added in some
cases so the type could make it through the macro successfully.

Basically code of the form:
static T m;
becomes:
DEFINE_STATIC_LOCAL(T, m, ());

Also any code of the form:
static T& m = *new T;
also becomes:
DEFINE_STATIC_LOCAL(T, m, ());

Remove .o files from the exclude list that have had their exit-time destructors removed.

8:55 AM Changeset in webkit [38421] by bolsinga@apple.com

6 edits
1 add in trunk/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
exit-time destructor. Update code that was changed to fix this issue that ran
into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
in gcc build 5465). Also typdefs for template types needed to be added in some
cases so the type could make it through the macro successfully.

Basically code of the form:
static T m;
becomes:
DEFINE_STATIC_LOCAL(T, m, ());

Also any code of the form:
static T& m = *new T;
also becomes:
DEFINE_STATIC_LOCAL(T, m, ());

12:22 AM Changeset in webkit [38420] by mjs@apple.com

6 edits in trunk/JavaScriptCore

2008-11-15 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Remove SymbolTable from FunctionBodyNode and move it to CodeBlock

It's not needed for functions that have never been executed, so no
need to waste the memory. Saves ~4M on membuster after 30 pages.

VM/CodeBlock.h:
VM/Machine.cpp: (JSC::Machine::retrieveArguments):
parser/Nodes.cpp: (JSC::EvalNode::generateCode): (JSC::FunctionBodyNode::generateCode):
parser/Nodes.h:
runtime/JSActivation.h: (JSC::JSActivation::JSActivationData::JSActivationData):

Nov 14, 2008:

11:43 PM Changeset in webkit [38419] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-14 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22259: Make all opcodes use eax as their final result register
<https://bugs.webkit.org/show_bug.cgi?id=22259>

Change one case of op_add (and the corresponding slow case) to use eax
rather than edx. Also, change the order in which the two results of
resolve_func and resolve_base are emitted so that the retrieved value is
put last into eax.

This gives no performance change on SunSpider or the V8 benchmark suite
when run in either harness.

VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):

8:47 PM Changeset in webkit [38418] by bolsinga@apple.com

80 edits
1 add in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
exit-time destructor. Update code that was changed to fix this issue that ran
into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
in gcc build 5465). Also typdefs for template types needed to be added in some
cases so the type could make it through the macro successfully.

Basically code of the form:
static T m;
becomes:
DEFINE_STATIC_LOCAL(T, m, ());

Also any code of the form:
static T& m = *new T;
also becomes:
DEFINE_STATIC_LOCAL(T, m, ());

8:24 PM Changeset in webkit [38417] by mitz@apple.com

2 edits in trunk/WebCore

attempt to fix the Qt build

platform/qt/Localizations.cpp: (WebCore::contextMenuItemTagTextDirectionMenu): Added. Maybe this string needs to go somewhere else in addition to here.

8:19 PM Changeset in webkit [38416] by mitz@apple.com

2 edits in trunk/WebKit/win

try to fix the Windows build

WebCoreLocalizedStrings.cpp: (WebCore::contextMenuItemTagTextDirectionMenu): Added.

7:25 PM Changeset in webkit [38415] by kevino@webkit.org

4 edits in trunk

wx build (and buildbot) fix.

6:51 PM Changeset in webkit [38414] by barraclough@apple.com

3 edits in trunk/JavaScriptCore

2008-11-14 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Geoff has this wacky notion that emitGetArg and emitPutArg should be related to
doing the same thing. Crazy.

Rename the methods for accessing virtual registers to say 'VirtualRegister' in the
name, and those for setting up the arguments for CTI methods to contain 'CTIArg'.

VM/CTI.cpp: (JSC::CTI::emitGetVirtualRegister): (JSC::CTI::emitGetVirtualRegisters): (JSC::CTI::emitPutCTIArgFromVirtualRegister): (JSC::CTI::emitPutCTIArg): (JSC::CTI::emitGetCTIArg): (JSC::CTI::emitPutCTIArgConstant): (JSC::CTI::emitPutVirtualRegister): (JSC::CTI::compileOpCallSetupArgs): (JSC::CTI::compileOpCallEvalSetupArgs): (JSC::CTI::compileOpConstructSetupArgs): (JSC::CTI::compileOpCall): (JSC::CTI::compileOpStrictEq): (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompileCTIMachineTrampolines):
VM/CTI.h:

5:37 PM Changeset in webkit [38413] by bolsinga@apple.com

3 edits in trunk/JavaScriptCore

Reviewed by Antti Koivisto

Fix potential build break by adding StdLibExtras.h

5:33 PM Changeset in webkit [38412] by barraclough@apple.com

6 edits in trunk/JavaScriptCore

2008-11-14 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Generate less code for the slow cases of op_call and op_construct.
https://bugs.webkit.org/show_bug.cgi?id=22272

1% progression on v8 tests.

VM/CTI.cpp: (JSC::CTI::emitRetrieveArg): (JSC::CTI::emitNakedCall): (JSC::CTI::compileOpCallInitializeCallFrame): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompileCTIMachineTrampolines):
VM/CTI.h:
VM/CodeBlock.h: (JSC::getCallLinkInfoReturnLocation): (JSC::CodeBlock::getCallLinkInfo):
VM/Machine.cpp: (JSC::Machine::Machine): (JSC::Machine::cti_vm_dontLazyLinkCall): (JSC::Machine::cti_vm_lazyLinkCall):
VM/Machine.h:

5:29 PM Changeset in webkit [38411] by bolsinga@apple.com

4 edits
1 add in trunk/JavaScriptCore

Reviewed by Darin Alder.

https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
exit-time destructor. Update code that was changed to fix this issue that ran
into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
in gcc build 5465). Also typdefs for template types needed to be added in some
cases so the type could make it through the macro successfully.

Basically code of the form:
static T m;
becomes:
DEFINE_STATIC_LOCAL(T, m, ());

Also any code of the form:
static T& m = *new T;
also becomes:
DEFINE_STATIC_LOCAL(T, m, ());

3:50 PM Changeset in webkit [38410] by mitz@apple.com

31 edits in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/6234307> Support action methods for setting and clearing character-level directionality
WebCore part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate

WebCore.base.exp: Exported WebCore::Settings::setTextDirectionSubmenuInclusionBehavior().

editing/ApplyStyleCommand.cpp: (StyleChange::init): Changed to always include the direction property in the result if the unicode-bidi property is included. (ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Added. Finds the highest ancestor of the given node that establishes bidi embedding. If that embedding agrees with the given allowed direction, finds the second-highest embedding ancestor. Splits all nodes through that ancestor. If the highest embedding ancestor did not need to be split, it is returned. (ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Added. Removes bidi embedding attributes and styles from all ancestors of the given node up to its enclosing block or the given node. (ApplyStyleCommand::applyInlineStyle): Added code to handle the unicode-bidi property. Applying style the includes this property involves removing all bidi embedding in effect, except for one-level embedding that agrees with the desired embedding, then applying the desired embedding where it is not already in effect. (ApplyStyleCommand::applyInlineStyleToRange): Factored out from applyInlineStyle(). (ApplyStyleCommand::removeHTMLBidiEmbeddingStyle): Added. Removed the "dir" attribute if necessary and the element if it becomes an unstyled style span. (ApplyStyleCommand::removeCSSStyle): Changed to remove the direction property when removing the unicode-bidi property. (ApplyStyleCommand::removeInlineStyle): Added a call to removeHTMLBidiEmbeddingStyle().

editing/ApplyStyleCommand.h:
editing/Editor.cpp: (Editor::textDirectionForSelection): Added. Returns the character-level writing direction of the selection if it is uniform and simple (at most one level of embedding). (Editor::hasBidiSelection): Added. Returns true if the selection lies entirely within a single block, and that block has direction:rtl or contains any inline boxes with non-zero bidi embedding level.

editing/Editor.h:
editing/EditorCommand.cpp: (stateTextWritingDirection): Added this helper function for deciding the state of Text Direction submenu items. (executeMakeTextWritingDirectionLeftToRight): Added. Applies "unicode-bidi: embed; direction: ltr;". (executeMakeTextWritingDirectionNatural): Added. Applies "unicode-bidi: normal;" (executeMakeTextWritingDirectionRightToLeft): Added. Applies "unicode-bidi: embed; direction: rtl;". (stateTextWritingDirectionLeftToRight): Added. (stateTextWritingDirectionNatural): Added. (stateTextWritingDirectionRightToLeft): Added. (createCommandMap): Added "MakeTextWritingDirectionLeftToRight", "MakeTextWritingDirectionNatural", and "MakeTextWritingDirectionRightToLeft".

editing/InsertTextCommand.cpp: (InsertTextCommand::input): Added code to maintain the unicode-bidi and direction properties in the typing style. Even if they have the same values as the computed style at the caret, they need to be included in the typing style so that inserted text will not inherit any nested embedding.

page/ContextMenuController.cpp: (ContextMenuController::contextMenuItemSelected): Added calls to the editor for the text direction menu items.

page/Frame.cpp (Frame::computeAndSetTypingStyle): Added code to maintain the unicode-bidi and direction properties in the typing style.

page/Settings.cpp: (Settings::setTextDirectionSubmenuInclusionBehavior): Added this setter.

page/Settings.h: Added a TextDirectionSubmenuInclusionBehavior enum, an m_textDirectionSubmenuInclusionBehavior member, and accessors.

page/mac/WebCoreViewFactory.h:
platform/ContextMenu.cpp: (WebCore::createAndAppendTextDirectionSubMenu): Added. (ContextMenu::populate): Added the Text Direction submenu item based on the inclusion behavior and the existence of a bidi selection. (ContextMenu::checkOrEnableIfNeeded): Added code for the text direction menu items.

platform/ContextMenuItem.h:
platform/LocalizedStrings.h: Declared contextMenuItemTagTextDirectionMenu().

platform/mac/LocalizedStringsMac.mm: Defined contextMenuItemTagTextDirectionMenu().

rendering/RenderBlock.cpp: (RenderBlock::containsNonZeroBidiLevel): Added.
rendering/RenderBlock.h:

WebKit:

Reviewed by Darin Adler.

part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate

English.lproj/Localizable.strings: Added the Text Direction submenu title.

WebKit/mac:

Reviewed by Darin Adler.

<rdar://problem/6234333> Implement action methods for setting and clearing character-level directionality
part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagTextDirectionMenu]): Added.
WebView/WebFrame.mm: (core): Added a convertor from WebTextDirectionSubmenuInclusionBehavior to WebCore::TextDirectionSubmenuInclusionBehavior.
WebView/WebFrameInternal.h:
WebView/WebHTMLView.mm: Added makeTextWritingDirectionLeftToRight:, makeTextWritingDirectionNatural: and makeTextWritingDirectionRightToLeft: using the WEBCORE_COMMAND macro.
WebView/WebPreferenceKeysPrivate.h: Added WebKitTextDirectionSubmenuInclusionBehaviorPreferenceKey.
WebView/WebPreferences.mm: (+[WebPreferences initialize]): Set the default Text Direction submenu inclusion behavior to never include. (-[WebPreferences textDirectionSubmenuInclusionBehavior]): Added this accessor. (-[WebPreferences setTextDirectionSubmenuInclusionBehavior:]): Ditto.
WebView/WebPreferencesPrivate.h: Defined the WebTextDirectionSubmenuInclusionBehavior enum and declared accessors.
WebView/WebUIDelegatePrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Added code to transfer the Text Direction submenu inclusion behavior preference to WebCore settings.

3:48 PM Changeset in webkit [38409] by bolsinga@apple.com

4 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22264
Need to update to latest Geolocation spec (13 November 2008)

Update to new error code constants and values.

page/Geolocation.cpp: Use new named ErrorCode enums (WebCore::Geolocation::GeoNotifier::timerFired): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition):
page/PositionError.h: Have ErrorCode enum names match new error constant names and values (WebCore::PositionError::):
page/PositionError.idl: Add new named error constants

3:37 PM Changeset in webkit [38408] by Beth Dakin

9 edits
4 adds in trunk

WebCore:

2008-11-14 Beth Dakin <Beth Dakin>

Reviewed by Justin Garcia.

Fix (again) for <rdar://problem/5089327> Too much indentation when
pasting quoted paragraphs

This patch goes back to Justin's original approach to fix this bug,
written in revision 38273. That fix was mostly rolled out by
revision 38310 because of styling issues created by the addition of
extra blockquote nodes. This patch again goes back to Justin's
original fix because of cases we discovered the newer fix could not
possibly cover. This version of the patch minimizes the styling
issues of extra blockquotes by opting into the merge start code.

editing/ReplaceSelectionCommand.cpp: (WebCore::hasMatchingQuoteLevel): We want shouldMergeStart to return true when the quoting level of the end of the inserted content matches the quoting level of the end of the existing content. (WebCore::ReplaceSelectionCommand::shouldMergeStart): Now calls hasMatchingQuoteLevel (WebCore::ReplaceSelectionCommand::doApply):

LayoutTests:

2008-11-14 Beth Dakin <Beth Dakin>

Reviewed by Justin Garcia.

Tests for <rdar://problem/5089327> Too much indentation when
pasting quoted paragraphs

New test:

editing/pasteboard/paste-blockquote-into-blockquote-4.html: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-4-expected.checksum: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-4-expected.png: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-4-expected.txt: Added.

Changes results for existing tests:

platform/mac/editing/pasteboard/merge-end-blockquote- expected.checksum:
platform/mac/editing/pasteboard/merge-end-blockquote- expected.png:
platform/mac/editing/pasteboard/merge-end-blockquote- expected.txt:
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.txt:
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.txt:
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.txt:

3:36 PM Changeset in webkit [38407] by weinig@apple.com

6 edits in trunk/JavaScriptCore

2008-11-13 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler

Fix for https://bugs.webkit.org/show_bug.cgi?id=22269
Reduce PropertyMap usage

From observation of StructureID statistics, it became clear that many
StructureID's were not being used as StructureIDs themselves, but rather
only being necessary as links in the transition chain. Acknowledging this
and that PropertyMaps stored in StructureIDs can be treated as caches, that
is that they can be reconstructed on demand, it became clear that we could
reduce the memory consumption of StructureIDs by only keeping PropertyMaps
for the StructureIDs that need them the most.

The specific strategy used to reduce the number of StructureIDs with
PropertyMaps is to take the previous StructureIDs PropertyMap when initially
transitioning (addPropertyTransition) from it and clearing out the pointer
in the process. The next time we need to do the same transition, for instance
repeated calls to the same constructor, we use the new addPropertyTransitionToExistingStructure
first, which allows us not to need the PropertyMap to determine if the property
exists already, since a transition to that property would require it not already
be present in the StructureID. Should there be no transition, the PropertyMap
can be constructed on demand (via materializePropertyMap) to determine if the put is a
replace or a transition to a new StructureID.

Reduces memory use on Membuster head test (30 pages open) by ~15MB.

JavaScriptCore.exp:
runtime/JSObject.h: (JSC::JSObject::putDirect): First use addPropertyTransitionToExistingStructure so that we can avoid building the PropertyMap on subsequent similar object creations.
runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry): Add version of constructor which takes all values to be used when lazily building the PropertyMap.
runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics): Add statistics on the number of StructureIDs with PropertyMaps. (JSC::StructureID::StructureID): Rename m_cachedTransistionOffset to m_offset (JSC::isPowerOf2): (JSC::nextPowerOf2): (JSC::sizeForKeyCount): Returns the expected size of a PropertyMap for a key count. (JSC::StructureID::materializePropertyMap): Builds the PropertyMap out of its previous pointer chain. (JSC::StructureID::addPropertyTransitionToExistingStructure): Only transitions if there is a an existing transition. (JSC::StructureID::addPropertyTransition): Instead of always copying the ProperyMap, try and take it from it previous pointer. (JSC::StructureID::removePropertyTransition): Simplify by calling toDictionaryTransition() to do transition work. (JSC::StructureID::changePrototypeTransition): Build the PropertyMap if necessary before transitioning because once you have transitioned, you will not be able to reconstruct it afterwards as there is no previous pointer, pinning the ProperyMap as well. (JSC::StructureID::getterSetterTransition): Ditto. (JSC::StructureID::toDictionaryTransition): Pin the PropertyMap so that it is not destroyed on further transitions. (JSC::StructureID::fromDictionaryTransition): We can only transition back from a dictionary transition if there are no deleted offsets. (JSC::StructureID::addPropertyWithoutTransition): Build PropertyMap on demands and pin. (JSC::StructureID::removePropertyWithoutTransition): Ditto. (JSC::StructureID::get): Build on demand. (JSC::StructureID::createPropertyMapHashTable): Add version of create that takes a size for on demand building. (JSC::StructureID::expandPropertyMapHashTable): (JSC::StructureID::rehashPropertyMapHashTable): (JSC::StructureID::getEnumerablePropertyNamesInternal): Build PropertyMap on demand.
runtime/StructureID.h: (JSC::StructureID::propertyStorageSize): Account for StructureIDs without PropertyMaps. (JSC::StructureID::isEmpty): Ditto. (JSC::StructureID::materializePropertyMapIfNecessary): (JSC::StructureID::get): Build PropertyMap on demand

2:58 PM Changeset in webkit [38406] by alp@webkit.org

2 edits in trunk/WebKitTools

2008-11-14 Alp Toker <alp@nuanti.com>

GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.

Fixes Debian bug #505723
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

1:41 PM Changeset in webkit [38405] by eric@webkit.org

10 edits
3 deletes in trunk/WebCore

Reviewed by Eric Seidel.

Made SVGResourceClipper platform independent.
https://bugs.webkit.org/show_bug.cgi?id=21444

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipPath):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clipPath):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clipPath):
svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::applyClip):
svg/graphics/cairo/SVGResourceClipperCairo.cpp: Removed.
svg/graphics/cg/SVGResourceClipperCg.cpp: Removed.
svg/graphics/qt/SVGResourceClipperQt.cpp: Removed.

1:34 PM Changeset in webkit [38404] by Antti Koivisto

3 edits in trunk/WebCore

2008-11-14 Antti Koivisto <Antti Koivisto>

Reviewed by Anders Carlsson.

Combine loadFrameRequestWithFormState to loadFrameRequestWithFormAndValues.

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
loader/FrameLoader.h:

12:02 PM Changeset in webkit [38403] by weinig@apple.com

2 edits in trunk/WebCore

2008-11-14 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Remove unneeded forward declaration.

plugins/Plugin.h:

11:32 AM Changeset in webkit [38402] by Darin Adler

2 edits in trunk/WebKit/mac

2008-11-14 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

fix https://bugs.webkit.org/show_bug.cgi?id=22222 selectKeyViewPrecedingView: with document view that can't be first responder makes WebFrameView be first responder

WebView/WebFrameView.mm: (-[WebFrameView becomeFirstResponder]): Moved the acceptsFirstResponder special case inside the if statement so it won't run in the "selecting previous" case. Also removed the "just before shipping Tiger" code that doesn't need to be here any more.

11:29 AM Changeset in webkit [38401] by Simon Hausmann

2 edits in trunk/WebKit/qt

2008-10-24 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Added some basic unit tests for the public database API.

11:01 AM Changeset in webkit [38400] by Simon Hausmann

3 edits in trunk/WebKit/qt

2008-11-14 Simon Hausmann <Simon Hausmann>

Fix the Qt build, add missing export macros for the new classes.

10:53 AM Changeset in webkit [38399] by darin@chromium.org

2 edits in trunk/WebCore

2008-11-14 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22251
HTMLCanvasElement.cpp unnecessarily includes runtime/Interpreter.h

html/HTMLCanvasElement.cpp:

10:52 AM Changeset in webkit [38398] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-14 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

<https://bugs.webkit.org/show_bug.cgi?id=21500>

JavaScriptCore build with -O3 flag instead of -O2 (gcc).
2.02% speedup on SunSpider (Qt-port on Linux)
1.10% speedup on V8 (Qt-port on Linux)
3.45% speedup on WindScorpion (Qt-port on Linux)

10:44 AM Changeset in webkit [38397] by Simon Hausmann

2 edits in trunk/WebKitTools

2008-11-14 Krishna <krishnamurty.podipireddy@nokia.com>

Reviewed by Simon Hausmann.

Fix hanging DRT with Qt.

https://bugs.webkit.org/show_bug.cgi?id=22209

10:40 AM Changeset in webkit [38396] by Simon Hausmann

11 edits
6 adds in trunk

WebCore:

2008-11-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Add new files from the Qt port to the build.

WebCore.pro:

WebKit/qt:

2008-10-24 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Adding public API to provide access to the security origin
(QWebSecurityOrigin) and the databases used for the offline
storage (QWebDatabase).

In addition QWebSettings gains configuration functions for
enabling/disabling offline storage, web application cache
and DOM local storage.

This commits lands the core feature(s), the unit tests and the
documentation are going to follow in the comming days/weeks.

Note: The API is not frozen yet.

10:39 AM Changeset in webkit [38395] by Simon Hausmann

2 edits in trunk/WebCore

2008-11-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Make it possible to get the cache directory set in the application
cache storage.

10:39 AM Changeset in webkit [38394] by Simon Hausmann

3 edits in trunk/WebCore

2008-11-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Make it possible to get the cache directory set in the application
cache storage.

10:30 AM Changeset in webkit [38393] by justin.garcia@apple.com

4 edits
2 adds in trunk

WebCore:

2008-11-14 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/4230923> "Make Plain Text" doesn't reset text alignment in single paragraph messages

When applying block styles, we would add block properties to the body element, and Mail's
Make Plain Text feature isn't equipped to remove those. This could have been fixed on our side,
but this change has the advantage that it fixes the bug on Tiger, where Mail does not plan future updates.

We have code that puts the paragraphs that we're operating on into blocks of their own before
adding or removing block properties from the blocks that enclose them. We need to run this code
when the enclosing block is the body element.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Added, moved code from moveParagraphContents to here. (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Renamed some variables for clarity. Added a few comments. Fixed bug by not bailing out when the block about to be used is the body element.
editing/CompositeEditCommand.h:

LayoutTests:

2008-11-14 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/4230923> "Make Plain Text" doesn't reset text alignment in single paragraph messages

editing/style/4230923-expected.txt: Added.
editing/style/4230923.html: Added.

9:54 AM Changeset in webkit [38392] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-14 Kristian Amlie <kristian.amlie@trolltech.com>

Reviewed by Darin Adler.

Compile fix for RVCT.

In reality, it is two fixes:

Remove typename. I believe typename can only be used when the named type depends on the template parameters, which it doesn't in this case, so I think this is more correct.
Replace ::iterator scope with specialized typedef. This is to work around a bug in RVCT.

https://bugs.webkit.org/show_bug.cgi?id=22260

9:53 AM Changeset in webkit [38391] by Simon Hausmann

3 edits in trunk/JavaScriptCore

2008-11-14 Kristian Amlie <kristian.amlie@trolltech.com>

Reviewed by Darin Adler.

Compile fix for WINSCW.

This fix doesn't protect against implicit conversions from bool to
integers, but most likely that will be caught on another platform.

https://bugs.webkit.org/show_bug.cgi?id=22260

9:49 AM Changeset in webkit [38390] by cwzwarich@webkit.org

11 edits in trunk

2008-11-14 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22245: Move wtf/dtoa.h into the WTF namespace
<https://bugs.webkit.org/show_bug.cgi?id=22245>

Move wtf/dtoa.h into the WTF namespace from the JSC namespace. This
introduces some ambiguities in name lookups, so I changed all uses of
the functions in wtf/dtoa.h to explicitly state the namespace.

JavaScriptCore:

JavaScriptCore.exp:
parser/Lexer.cpp: (JSC::Lexer::lex):
runtime/InitializeThreading.cpp:
runtime/JSGlobalObjectFunctions.cpp: (JSC::parseInt):
runtime/NumberPrototype.cpp: (JSC::integerPartNoExp): (JSC::numberProtoFuncToExponential):
runtime/UString.cpp: (JSC::concatenate): (JSC::UString::from): (JSC::UString::toDouble):
wtf/dtoa.cpp:
wtf/dtoa.h:

WebCore:

platform/text/String.cpp: (WebCore::charactersToDouble):

3:21 AM Changeset in webkit [38389] by vestbo@webkit.org

2 edits in trunk/WebCore

2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Make sure Qt scrollbars follow the style with regard to context menus

3:20 AM Changeset in webkit [38388] by vestbo@webkit.org

2 edits in trunk/WebCore

2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Make scrollbar look active when the window is active on Qt/Mac

12:21 AM Changeset in webkit [38387] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-14 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 22257: Enable redundant read optimizations for results generated by compileBinaryArithOp()
<https://bugs.webkit.org/show_bug.cgi?id=22257>

This shows no change in performance on either SunSpider or the V8
benchmark suite, but it removes an ugly special case and allows for
future optimizations to be implemented in a cleaner fashion.

This patch was essentially given to me by Gavin Barraclough upon my
request, but I did regression and performance testing so that he could
work on something else.

VM/CTI.cpp: (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate): Move the final result to eax if it is not already there. (JSC::CTI::compileBinaryArithOp): Remove the killing of the final result register that disables the optimization.

Nov 13, 2008:

8:39 PM Changeset in webkit [38386] by mrowe@apple.com

3 edits in trunk/WebKit/mac

Fix the build.

Don't use NSPICTPboardType on systems where it is deprecated. The system will take care of converting
from this format to a format that we can understand.

WebCoreSupport/WebPasteboardHelper.mm:

(WebPasteboardHelper::insertablePasteboardTypes):

WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
(+[WebHTMLView _insertablePasteboardTypes]):
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

8:29 PM Changeset in webkit [38385] by Adam Roben

2 edits in trunk/WebKit/win

Fix Bug 22244: Webkit nightly builds crash with Safari 3.2

<https://bugs.webkit.org/show_bug.cgi?id=22244>

r36652 added IWebViewPrivate::clearMainFrameName into the middle of
the IWebViewPrivate interface, which modifies the part of the
IWebViewPrivate vtable that Safari 3.2 relies on.

Reviewed by Dan Bernstein.

Interfaces/IWebViewPrivate.idl: Move clearMainFrameName to the end of the interface.

8:26 PM Changeset in webkit [38384] by eric@webkit.org

1 edit
2 adds in trunk/WebCore

Reviewed by Adam Roben.

Add a basic Scons-based build system for building
Chromium-Mac WebCore.
https://bugs.webkit.org/show_bug.cgi?id=21991

The build currently fails due to missing files from our
platform directory (platform skia and platform chromium)
I will be sending those up shortly in separate patches.
I expect it will be a while before our WebCore build links.

SConstruct: Added.
WebCore.scons: Added.

8:26 PM Changeset in webkit [38383] by eric@webkit.org

1 edit
2 adds in trunk/JavaScriptCore

Reviewed by Adam Roben.

Add a Scons-based build system for building
the Chromium-Mac build of JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=21991

JavaScriptCore.scons: Added.
SConstruct: Added.

7:54 PM Changeset in webkit [38382] by eric@webkit.org

2 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.

Add PLATFORM(CHROMIUM) to the "we don't use cairo" blacklist
until https://bugs.webkit.org/show_bug.cgi?id=22250 is fixed.

wtf/Platform.h:

7:45 PM Changeset in webkit [38381] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

In r38375 the 'jsc' shell was changed to improve teardown on quit. The
main() function in jsc.cpp uses Structured Exception Handling, so Visual
C++ emits a warning when destructors are used.

In order to speculatively fix the Windows build, this patch changes that
code to use explicit pointer manipulation and locking rather than smart
pointers and RAII.

jsc.cpp: (main):

5:54 PM Changeset in webkit [38380] by darin@chromium.org

2 edits in trunk/WebCore

2008-11-13 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22248
AtomicString.cpp uses JSC types outside of #if USE(JSC)

platform/text/AtomicString.cpp: (WebCore::AtomicString::add):

5:40 PM Changeset in webkit [38379] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22246: Get arguments for opcodes together to eliminate more redundant memory reads
<https://bugs.webkit.org/show_bug.cgi?id=22246>

It is common for opcodes to read their first operand into eax and their
second operand into edx. If the value intended for the second operand is
in eax, we should first move eax to the register for the second operand
and then read the first operand into eax.

This is a 0.5% speedup on SunSpider and a 2.0% speedup on the V8
benchmark suite when measured using the V8 harness.

VM/CTI.cpp: (JSC::CTI::emitGetArgs): (JSC::CTI::compileOpStrictEq): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
VM/CTI.h:

2:54 PM Changeset in webkit [38378] by mrowe@apple.com

4 copies
1 add in releases/Apple/Safari 3.2

Tag the Safari 3.2 release.

This release consists of JavaScriptCore-x525.26.2, JavaScriptGlue-x525.26.2, WebCore-x525.26.6 and WebKit-x525.26.2.

2:27 PM Changeset in webkit [38377] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22238: Avoid unnecessary reads of temporaries when the target machine register is not eax
<https://bugs.webkit.org/show_bug.cgi?id=22238>

Enable the optimization of not reading a value back from memory that we
just wrote when the target machine register is not eax. In order to do
this, the code generation for op_put_global_var must be changed to
read its argument into a register before overwriting eax.

This is a 0.5% speedup on SunSpider and shows no change on the V8
benchmark suite when run in either harness.

VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::privateCompileMainPass):

1:04 PM Changeset in webkit [38376] by justin.garcia@apple.com

2 edits in trunk/WebCore

2008-11-13 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=18620
Long hang under TextIterator::advance() when loading http://www.lsvd.de/

A huge section at the beginning of this document is invisible. As we iterate through it,
we create VisiblePositions unnecessarily.

editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Don't proceed to VisiblePosition creation if m_node is unrendered or invisible. The answers wouldn't have much meaning and would be wasteful. Also fixed some comments to reflect the fact that this function isn't specifically about emitting a newline.

11:50 AM Changeset in webkit [38375] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Perform teardown in the 'jsc' shell in order to suppress annoying and
misleading leak messages. There is still a lone JSC::Node leaking when
quit() is called, but hopefully that can be fixed as well.

jsc.cpp: (functionQuit): (main):

10:49 AM Changeset in webkit [38374] by cmarrin@apple.com

3 edits in trunk/WebCore

2008-11-13 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Sam Weinig.

Remove unused or unnecessary code from AnimationBase class.

page/animation/AnimationBase.cpp: (WebCore::AnimationBase::AnimationBase): (WebCore::AnimationBase::playStatePlaying):
page/animation/AnimationBase.h:

10:35 AM Changeset in webkit [38373] by sullivan@apple.com

8 edits
1 add
1 delete in trunk/WebKit

WebKit:

2008-11-13 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/6361578> Web Kit UI strings: a few edits

Reviewed by Tim Hatcher

English.lproj/Localizable.strings: updated for these changes

StringsNotToBeLocalized.txt: removed unused exception

WebKit/mac:

2008-11-13 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/6361578> Web Kit UI strings: a few edits

Reviewed by Tim Hatcher

Misc/WebKitErrors.m: "Cannot show content with specified mime type" -> "Content with specified MIME type can't be shown" "Cannot show URL" -> "The URL can't be shown" "Cannot find plug-in" -> "The plug-in can't be found" "Cannot load plug-in" -> "The plug-in can't be loaded"

Panels/English.lproj/WebAuthenticationPanel.nib/classes.nib:
Panels/English.lproj/WebAuthenticationPanel.nib/info.nib:
Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Added.
Panels/English.lproj/WebAuthenticationPanel.nib/objects.nib: Removed. Changed placeholder fine print in the nib to match one of the two strings it might be replaced by. This automagically updated the nib to a newer format, hence the objects -> keyedobjects change. I could have changed the placeholder fine print to be empty but this lets localizers understand the dialog layout better.

Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): "you need to log in" -> "you must log in" "Your log-in information" -> "Your login information" "The name or password entered" -> "The user name or password you entered" "Please try again." -> "Make sure you're entering them correctly, and then try again."

10:09 AM Changeset in webkit [38372] by weinig@apple.com

2 edits in trunk/JavaScriptCore

2008-11-13 Mike Pinkerton <pinkerton@chromium.org>

Reviewed by Sam Weinig.

Fix for https://bugs.webkit.org/show_bug.cgi?id=22087
Need correct platform defines for Mac Chromium

Set the appropriate platform defines for Mac Chromium, which is
similar to PLATFORM(MAC), but isn't.

wtf/Platform.h:

7:20 AM Changeset in webkit [38371] by vestbo@webkit.org

5 edits
2 adds in trunk/WebCore

2008-11-12 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Inital implementation of PluginPackage and PluginView for Mac NPAPI support in WebCore

Currently only used by QtWebKit. See also:

https://bugs.webkit.org/show_bug.cgi?id=21427

7:20 AM Changeset in webkit [38370] by vestbo@webkit.org

2 edits in trunk/WebKit/qt

2008-11-12 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Tor Arne Vestbø.

Mention the color role change (r38331) in the API doc.

Api/qwebpage.cpp:

4:53 AM Changeset in webkit [38369] by mjs@apple.com

4 edits in trunk/JavaScriptCore

2008-11-13 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.

remove immediate checks from native codegen for known non-immediate cases like "this"

~.5% speedup on v8 benchmarks

In the future we can extend this model to remove all sorts of
typechecks based on local type info or type inference.

I also added an assertion to verify that all slow cases linked as
many slow case jumps as the corresponding fast case generated, and
fixed the pre-existing cases where this was not true.

VM/CTI.cpp: (JSC::CTI::emitJumpSlowCaseIfNotJSCell): (JSC::CTI::linkSlowCaseIfNotJSCell): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
VM/CTI.h:
VM/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):

3:26 AM Changeset in webkit [38368] by cwzwarich@webkit.org

5 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21943: Avoid needless reads of temporary values in CTI code
<https://bugs.webkit.org/show_bug.cgi?id=21943>

If an opcode needs to load a virtual register and a previous opcode left
the contents of that virtual register in a machine register, use the
value in the machine register rather than getting it from memory.

In order to perform this optimization, it is necessary to know the
jump tagets in the CodeBlock. For temporaries, the only problematic
jump targets are binary logical operators and the ternary conditional
operator. However, if this optimization were to be extended to local
variable registers as well, other jump targets would need to be
included, like switch statement cases and the beginnings of catch
blocks.

This optimization also requires that the fast case and the slow case
of an opcode use emitPutResult() on the same register, which was chosen
to be eax, as that is the register into which we read the first operand
of opcodes. In order to make this the case, we needed to add some mov
instructions to the slow cases of some instructions.

This optimizaton is not applied whenever compileBinaryArithOp() is used
to compile an opcode, because different machine registers may be used to
store the final result. It seems possible to rewrite the code generation
in compileBinaryArithOp() to allow for this optimization.

This optimization is also not applied when generating slow cases,
because some fast cases overwrite the value of eax before jumping to the
slow case. In the future, it may be possible to apply this optimization
to slow cases as well, but it did not seem to be a speedup when testing
an early version of this patch.

This is a 1.0% speedup on SunSpider and a 6.3% speedup on the V8
benchmark suite.

VM/CTI.cpp: (JSC::CTI::killLastResultRegister): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::emitGetCTIParam): (JSC::CTI::emitGetFromCallFrameHeader): (JSC::CTI::emitPutResult): (JSC::CTI::emitCTICall): (JSC::CTI::CTI): (JSC::CTI::compileOpCall): (JSC::CTI::compileOpStrictEq): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompilePatchGetArrayLength):
VM/CTI.h:
VM/CodeBlock.h: (JSC::CodeBlock::isTemporaryRegisterIndex):
bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitLabel):

Nov 12, 2008:

11:35 PM Changeset in webkit [38367] by ap@webkit.org

2 edits in trunk/WebKitTools

2008-11-12 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=22216

Scripts/build-webkit: Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.

11:32 PM Changeset in webkit [38366] by ap@webkit.org

4 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22200
Crash when close event is dispatched to MessagePort due to document destruction

Test: fast/events/message-port-onclose.html

dom/MessagePort.cpp: (WebCore::MessagePort::contextDestroyed): Don't dispatch close event, even though HTML5 currently says that we should. It is not right for GC to have observable effects.

11:27 PM Changeset in webkit [38365] by ap@webkit.org

24 edits
2 adds in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22203
Implement Worker messaging

No test cases included, because this functionality is disabled by default.

The implementation is known to still have many race condition, but works quite well for
testing.

WebCore.xcodeproj/project.pbxproj: Added WorkerTask.{h,cpp}.

bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Re-worded comments a little. (WebCore::markCrossHeapDependentObjectsForContext): Existing cross-heap GC protocol was incorrect, changed it to a much simpler (but still incorrect) version.

dom/WorkerTask.cpp: Added. (WebCore::WorkerTask::~WorkerTask):
dom/WorkerTask.h: Added. Tasks posted to workers implement this new interface.

bindings/js/JSDedicatedWorkerCustom.cpp: (WebCore::JSDedicatedWorker::mark): (WebCore::JSDedicatedWorker::connect):
dom/DedicatedWorker.h:
dom/DedicatedWorker.idl: Auto-generate event listener attributes. Renamed startConversation() to connect(), tracking WHATWG discussions.

dom/DedicatedWorker.cpp: (WebCore::WorkerConnectTask::WorkerConnectTask): A task that performs worker-side connect() operations. (WebCore::DedicatedWorker::DedicatedWorker): Initialize WorkerThread pointer. (WebCore::DedicatedWorker::connect): Connect() creates a pair of entangled ports, and posts one to worker. Since message port registration in ScriptExecutionContext is not thread safe, this port starts with a null context pointer. (WebCore::DedicatedWorker::notifyFinished): Since Worker methods should work immediately after creation, we have to queue tasks until after a WorkerThread object is created. Then we forward all queued tasks to its queue.

dom/EventTarget.cpp: (WebCore::EventTarget::toWorkerContext):
dom/EventTarget.h:
bindings/js/JSEventTarget.cpp: (WebCore::toJS): Added cases for WorkerContext, which is now an EventTarget, too.

bindings/js/JSWorkerContext.h: Added JSWorkerContext::put() to make onconnect settable.
bindings/js/JSWorkerContext.cpp: (WebCore::JSWorkerContext::mark): Mark event listeners. (WebCore::JSWorkerContext::createPrototype): Fixed a typo, use the right StructureID. (WebCore::JSWorkerContext::put): Implemented. (WebCore::jsWorkerContextPrototypeFunctionAddEventListener): Added an EventTarget implementation. (WebCore::jsWorkerContextPrototypeFunctionRemoveEventListener): Ditto. (WebCore::jsWorkerContextPrototypeFunctionDispatchEvent): Ditto. (WebCore::jsWorkerContextOnconnect): Added. (WebCore::setJSWorkerContextOnconnect): Added.

bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): Made it actually work by adding necessary setup.

bindings/js/WorkerScriptController.h: (WebCore::WorkerScriptController::initScriptIfNeeded): Check the right variable - it is the wrapper that may not be initialized yet.

dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::ActiveDOMObject): (WebCore::ActiveDOMObject::~ActiveDOMObject): Assert being called from the correct thread, as active DOM object tracking is not thread safe.

dom/ScriptExecutionContext.h: Added a Task interface and a postTask() method, to be used for asynchronously executing tasks in context's thread.

dom/ScriptExecutionContext.cpp: (WebCore::ProcessMessagesSoonTask): Changed from a Timer to a Task (WebCore::ScriptExecutionContext::ScriptExecutionContext): Removed m_firedMessagePortTimer. It was an optimization that couldn't be easily preserved without introducing race conditions in multithreading case. (WebCore::ScriptExecutionContext::processMessagePortMessagesSoon): Use postTask(). (WebCore::ScriptExecutionContext::dispatchMessagePortEvents): Added a comment explaining why it's OK to not ref() ports in a frozen copy. (WebCore::ScriptExecutionContext::createdMessagePort): Assert that we're not being called from a wrong thread. (WebCore::ScriptExecutionContext::destroyedMessagePort): Ditto. (WebCore::ScriptExecutionContextTaskTimer): Part of ScriptExecutionContext::Task implementation - use Timer if posting from main thread to main thread. (WebCore::ScriptExecutionContextTaskWorkerTask): Another part - use WorkerTask if posting to a worker. (WebCore::PerformTaskContext::PerformTaskContext): Finally, use callOnMainThread() if posting to main thread from a secondary one. (WebCore::performTask): A helper function for callOnMainThread(). (WebCore::ScriptExecutionContext::postTask): Use one of the above implementations.

dom/MessagePort.h: Fixed message queue to keep EventData pointers - otherwise, we would ref/deref EventData::message from different threads, which is not allowed.

dom/MessagePort.cpp: (WebCore::MessagePortCloseEventTask): Use a task instead of a timer to work across threads. (WebCore::MessagePort::EventData::create): Updated for EventData being refcountable now. (WebCore::MessagePort::EventData::EventData): Ditto. (WebCore::MessagePort::MessagePort): ScriptExecutionContext is now allowed to be null at first, because we need to create ports for posting to other threads, and it is not possible to register in a context from another thread. (WebCore::MessagePort::clone): Always create ports with null contexts - it is now message receiver's job to set the context. (WebCore::MessagePort::postMessage): Enable posting to ports that are not attached to any context yet. (WebCore::MessagePort::startConversation): Ditto. Data port is always posted unattached. (WebCore::MessagePort::contextDestroyed): Assert that we had a context. (WebCore::MessagePort::attachToContext): Called when receiving a data port to register in context. (WebCore::MessagePort::scriptExecutionContext): Moved from header, as the function is virtual. (WebCore::MessagePort::dispatchMessages): Attach data port to receiving context. Use postTask(). (WebCore::MessagePort::queueCloseEvent): Use postTask(). (WebCore::MessagePort::hasPendingActivity): Reworded comment a little. As mentioned above, MessagePort cross-heap GC is still quite wrong.

dom/WorkerContext.h: Made WorkerContext an event target, added onconnect attribute.
dom/WorkerContext.cpp: Keep a pointer to WorkerThread. It is only used for debug assertions now, but there is no harm in tracking it in release builds, too.

dom/WorkerThread.cpp: (WebCore::WorkerThread::create): WorkerThread is refcountable, construct with create(). (WebCore::WorkerThread::workerThread): Implemented a message loop.
dom/WorkerThread.h: (WebCore::WorkerThread::threadID): Also only used for assertions. (WebCore::WorkerThread::messageQueue): Return a reference to queue, so clients can post to it.

page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): MessagePort::clone() no longer takes a context, as it always sets it to null. (WebCore::DOMWindow::postMessageTimerFired): Attach data port to receiving context.

11:17 PM Changeset in webkit [38364] by krit@webkit.org

3 edits
3 adds in trunk

2008-11-12 Dirk Schulze <vbs85@gmx.de>

WebCore:

Reviewed Darin Adler.

use strokeColor.alpha() instead of fillColor.alpha()
on GraphicsContext::strokePath()

[Canvas] Transparent fillStyle stops line rendering
https://bugs.webkit.org/show_bug.cgi?id=21888

Test: fast/canvas/canvas-stroke-empty-fill.html

ChangeLog:
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokePath):

LayoutTests:

Reviewed by Darin Adler.

Check behavior of canvas.stroke() on transparent fillStyle()

fast/canvas/canvas-stroke-empty-fill-expected.txt: Added.
fast/canvas/canvas-stroke-empty-fill.html: Added.
fast/canvas/canvas-stroke-empty-fill.js: Added.

11:17 PM Changeset in webkit [38363] by Stephanie Lewis

2 edits in trunk/WebKit/mac

2008-11-12 Stephanie Lewis <Stephanie Lewis>

Fix Mac build.

Panels/WebAuthenticationPanel.m:

10:08 PM Changeset in webkit [38362] by Stephanie Lewis

2 edits in trunk/WebCore

2008-11-12 Stephanie <Stephanie Lewis>

Reviewed by Mark Rowe.

Fix context leak in XSLStyleSheets.
See bug https://bugs.webkit.org/show_bug.cgi?id=15715

xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString):

8:47 PM Changeset in webkit [38361] by sullivan@apple.com

5 edits in trunk/WebKit

WebKit:

2008-11-12 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/3839110> Authentication dialogs talk about passwords being sent "in the clear"

Reviewed by Tim Hatcher

English.lproj/Localizable.strings:
StringsNotToBeLocalized.txt: updated for this change

WebKit/mac:

2008-11-12 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/3839110> Authentication dialogs talk about passwords being sent "in the clear"

Reviewed by Tim Hatcher

Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): use "unencrypted" instead of "in the clear". Also, use the "Your log-in information will be sent securely" version when the receiving server is https, regardless of whether it uses basic or digest authentication.

8:26 PM Changeset in webkit [38360] by alp@webkit.org

2 edits in trunk/WebCore

2008-11-12 Alp Toker <alp@nuanti.com>

autotools: List web worker-related headers needed for a successful
build. distcheck is passing again with this change.

GNUmakefile.am:

7:57 PM Changeset in webkit [38359] by mrowe@apple.com

4 edits in tags/Safari-6528.4.3

Versioning.

7:57 PM Changeset in webkit [38358] by mrowe@apple.com

2 edits in tags/Safari-6528.4.3/WebKit/mac

Merge r37827.

7:39 PM Changeset in webkit [38357] by mrowe@apple.com

1 copy in tags/Safari-6528.4.3

New tag.

6:30 PM Changeset in webkit [38356] by alp@webkit.org

4 edits in trunk

2008-11-12 Alp Toker <alp@nuanti.com>

autotools build system fix-up only. Add FloatQuad.h to the source
lists and sort them.

6:04 PM Changeset in webkit [38355] by Darin Adler

2 edits in trunk/WebKit/mac

2008-11-12 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

fix https://bugs.webkit.org/show_bug.cgi?id=22223 <rdar://problem/6366864> REGRESSION(r38245): "View Source" crashes the browser

WebView/WebFrameView.mm: (-[WebFrameView viewDidMoveToWindow]): Add missing null check.

5:41 PM Changeset in webkit [38354] by mitz@apple.com

5 edits
40 adds in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

Updated reference images so that all pixel tests now "pass" on 10.4.11 PowerPC + r38347.
https://bugs.webkit.org/show_bug.cgi?id=21821

Checked-in specific reference images for pixel tests that are valid on Tiger but fail
because difference with reference image due to text rendering is greater than 1.0%

platform/mac-tiger/svg/carto.net: Added.
platform/mac-tiger/svg/carto.net/selectionlist-expected.checksum: Added.
platform/mac-tiger/svg/carto.net/selectionlist-expected.png: Added.
platform/mac-tiger/svg/custom/feComponentTransfer-Gamma-expected.checksum: Added.
platform/mac-tiger/svg/custom/feComponentTransfer-Gamma-expected.png: Added.
platform/mac-tiger/svg/text/text-align-01-b-expected.checksum: Added.
platform/mac-tiger/svg/text/text-align-01-b-expected.png: Added.
platform/mac-tiger/svg/text/text-align-02-b-expected.checksum: Added.
platform/mac-tiger/svg/text/text-align-02-b-expected.png: Added.
platform/mac-tiger/svg/text/text-align-04-b-expected.checksum: Added.
platform/mac-tiger/svg/text/text-align-04-b-expected.png: Added.
platform/mac-tiger/svg/text/text-fonts-01-t-expected.checksum: Added.
platform/mac-tiger/svg/text/text-fonts-01-t-expected.png: Added.
platform/mac-tiger/svg/text/text-text-03-b-expected.checksum: Added.
platform/mac-tiger/svg/text/text-text-03-b-expected.png: Added.
platform/mac-tiger/svg/text/text-tselect-01-b-expected.checksum: Added.
platform/mac-tiger/svg/text/text-tselect-01-b-expected.png: Added.
platform/mac-tiger/svg/text/text-tspan-01-b-expected.checksum: Added.
platform/mac-tiger/svg/text/text-tspan-01-b-expected.png: Added.
platform/mac-tiger/svg/text/text-ws-01-t-expected.checksum: Added.
platform/mac-tiger/svg/text/text-ws-01-t-expected.png: Added.
platform/mac-tiger/svg/text/text-ws-02-t-expected.checksum: Added.
platform/mac-tiger/svg/text/text-ws-02-t-expected.png: Added.
platform/mac-tiger/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum: Added.
platform/mac-tiger/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
platform/mac-tiger/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum: Added.
platform/mac-tiger/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.

svg/batik/paints/gradientLimit.svg is rendering different on Tiger and Leopard
https://bugs.webkit.org/show_bug.cgi?id=22219

platform/mac-tiger/svg/batik: Added.
platform/mac-tiger/svg/batik/paints: Added.
platform/mac-tiger/svg/batik/paints/gradientLimit-expected.checksum: Added.
platform/mac-tiger/svg/batik/paints/gradientLimit-expected.png: Added.

svg/custom/mask-excessive-malloc.svg is failing on Tiger
https://bugs.webkit.org/show_bug.cgi?id=22218

platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum: Added.
platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.png: Added.

svg/W3C-SVG-1.1/pservers-grad-17-b.svg is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=22220

platform/mac-leopard/svg: Added.
platform/mac-leopard/svg/W3C-SVG-1.1: Added.
platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum: Added.
platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png: Added.
platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:

svg/custom/foreign-object-skew.svg is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=22221

platform/mac-leopard/svg/custom: Added.
platform/mac-leopard/svg/custom/foreign-object-skew-expected.checksum: Added.
platform/mac-leopard/svg/custom/foreign-object-skew-expected.png: Added.
platform/mac/svg/custom/foreign-object-skew-expected.checksum:
platform/mac/svg/custom/foreign-object-skew-expected.png:

5:32 PM Changeset in webkit [38353] by Simon Fraser

17 edits
4 adds in trunk

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=22212

Rename absoluteOutlineBox() to absoluteOutlineBounds(), to indicate that
it may be the bounding outline box of a transformed element, and fix it
to respect transforms by mapping the outline box to an absolute quad and
taking the enclosing rect.

RenderBox::localToAbsoluteQuad() can no longer assert that there is no
LayoutState, but LayoutState cannot be used during quad mapping (it knows
nothing about transforms).

Finally, fix a bug in RenderBox::localToAbsoluteQuad() which was getting
borderTopExtra() from the object, rather than its container (as localToAbsolute()
does).

Test: fast/repaint/transform-absolute-child.html

5:22 PM Changeset in webkit [38352] by ggaren@apple.com

1 edit in trunk/LayoutTests/ChangeLog

dyslexics untie\!

5:20 PM Changeset in webkit [38351] by ggaren@apple.com

2 edits in trunk/LayoutTests

2008-11-12 Geoffrey Garen <ggaren@apple.com>

Roll in r38322, onw that test failures have been fixed.

fast/js/global-recursion-on-full-stack-expected.txt:

4:51 PM Changeset in webkit [38350] by jchaffraix@webkit.org

6 edits in branches/XBL2/WebCore

2008-11-12 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 22133: [XBL] Add shorter method to get the global XBLBindingManager

Renamed XBBindingManager::sharedInstance() to bindingManager().

Suggested by Eric Seidel.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::removeBindings):
dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::recalcStyleSelector): (WebCore::Document::addBindingSheet): (WebCore::Document::removeBindingSheet):
dom/Element.cpp: (WebCore::Element::~Element): (WebCore::Element::addBinding): (WebCore::Element::removeBinding): (WebCore::Element::hasBinding):
xbl/XBLBindingManager.cpp: (WebCore::bindingManager):
xbl/XBLBindingManager.h:

4:48 PM Changeset in webkit [38349] by ggaren@apple.com

11 edits in trunk/JavaScriptCore

2008-11-12 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed https://bugs.webkit.org/show_bug.cgi?id=22192
+37 failures in fast/profiler

along with Darin's review comments in
https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot

VM/Machine.cpp: (JSC::returnToThrowTrampoline): (JSC::throwStackOverflowError): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_vm_throw): Moved the throw logic into a function, since functions are better than macros.

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitConstruct): Ensure that the function register is preserved if profiling is enabled, since the profiler uses that register.

runtime/JSGlobalData.h: Renamed throwReturnAddress to exceptionLocation, because I had a hard time understanding what "throwReturnAddress" meant.

4:44 PM Changeset in webkit [38348] by alp@webkit.org

2 edits in trunk/WebCore

2008-11-12 Alp Toker <alp@nuanti.com>

Build fixes for r38346. FloatQuad.cpp is missing:

1) #include "config.h"
2) #include <algorithm> for various mathematical definitions it uses.

platform/graphics/FloatQuad.cpp:

4:24 PM Changeset in webkit [38347] by mitz@apple.com

2 edits in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

Skip fast/repaint/body-background-image.html test as it is not reliable.

https://bugs.webkit.org/show_bug.cgi?id=21913

platform/mac/Skipped:

3:43 PM Changeset in webkit [38346] by Simon Fraser

41 edits
2 adds in trunk/WebCore

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=21942
https://bugs.webkit.org/show_bug.cgi?id=18557

Add methods which can be used to map renderer-local rectangles
to quads in absolute coordinates, taking transforms into account:

localToAbsoluteQuad() converts a local rect into an absolute quad.
collectAbsoluteLineBoxQuads() is an analogue of addLineBoxRects()

that works with quads.

absoluteQuads() is an analogue of absoluteRects(), for quads.

Use the quad methods to fix the inspector highlight for transformed
elements.

3:04 PM Changeset in webkit [38345] by andersca@apple.com

2 edits in trunk/WebKit/mac

2008-11-12 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Fix stupid bug.

Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]):

2:53 PM Changeset in webkit [38344] by mitz@apple.com

1 edit
1 delete in trunk/LayoutTests

2008-11-12 Dan Bernstein <mitz@apple.com>

remove an empty directory

platform/mac-leopard/http: Removed.
platform/mac-leopard/http/tests: Removed.
platform/mac-leopard/http/tests/security: Removed.
platform/mac-leopard/http/tests/security/dataURL: Removed.

1:54 PM Changeset in webkit [38343] by Adam Roben

2 edits in trunk/WebCore

Fix Bug 22178: Build errors in WebKit Cairo port

<https://bugs.webkit.org/show_bug.cgi?id=22178>

Reviewed by Mark Rowe.

platform/graphics/cairo/PatternCairo.cpp: Correct build error under Visual Studio. (WebCore::Pattern::createPlatformPattern):

1:49 PM Changeset in webkit [38342] by Adam Roben

2 edits in trunk/WebCore

Fix a typo in the include path for the Release_Cairo configuration

WebCore.vcproj/WebCore.vcproj: Fixed "caro" -> "cairo" typo.

1:02 PM Changeset in webkit [38341] by sfalken@apple.com

1 edit in trunk/WebKit/win/WebKitPrefix.cpp

Touch precompiled header wrapper to fix build.

12:44 PM Changeset in webkit [38340] by mitz@apple.com

4 edits in trunk/LayoutTests/platform/mac/fast

Set svn:mime-type to image/png on .png files that did not have it

12:28 PM Changeset in webkit [38339] by Simon Fraser

2 edits in trunk/WebCore

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=17840
Patch 2

Code cleanup in RenderBox::computeAbsoluteRepaintRect().

rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):

12:22 PM Changeset in webkit [38338] by Simon Fraser

3 edits
8 adds in trunk

2008-11-12 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=17840

Fix repainting when the transform on a positioned element changes.
In computeAbsoluteRepaintRect(), add the offsets due to relative positioning,
and being in a positioned container after applying the transform to the local
rect.

Tests: fast/repaint/transform-absolute-in-positioned-container.html

fast/repaint/transform-relative-position.html

rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):

12:08 PM Changeset in webkit [38337] by justin.garcia@apple.com

7 edits
2 adds in trunk

WebCore:

2008-11-12 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/5495723> Selecting and deleting quoted text quotes other text
<rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted

We don't want to merge into a block if it will mean changing the quote level of content after deleting
selections that contain a whole number paragraphs plus a line break, since it is unclear to most users
that such a selection actually ends at the start of the next paragraph. Instead we want to completely
remove the selected paragraph(s) and all evidence of the first one's quote level. This matches TextEdit behavior
for indented paragraphs.

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): For the selections described above, do not try to merge after the deletion. Instead try and prune the start block or blocks if they've been emptied so that we remove evidence of the deleted paragraphs' quote level. (WebCore::DeleteSelectionCommand::mergeParagraphs): Try and prune the start block(s) if necessary. Also make sure that the caret is placed correctly so that it ends up on the same line that the deleted selection started on, instead of one higher.
editing/DeleteSelectionCommand.h:
editing/htmlediting.cpp: (WebCore::numEnclosingMailBlockquotes): Added.
editing/htmlediting.h:

LayoutTests:

2008-11-12 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/5495723> Selecting and deleting quoted text quotes other text
<rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted

editing/deleting/5495723-expected.txt: Added.
editing/deleting/5495723.html: Added.
platform/mac/editing/deleting/delete-4038408-fix-expected.txt: Change demonstrates that we now behave correctly when pressing delete when the caret is just after empty quoted paragraphs.

11:40 AM Changeset in webkit [38336] by sfalken@apple.com

1 edit in trunk/WebCore/WebCorePrefix.cpp

Touch precompiled header wrapper to try and fix build.

10:35 AM Changeset in webkit [38335] by mitz@apple.com

50 edits in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

Updated reference images so that all pixel tests now "pass" on 10.5.5 Intel + r38318.
https://bugs.webkit.org/show_bug.cgi?id=21821

Removed empty directory.

platform/mac-leopard/http: Removed.
platform/mac-leopard/http/tests: Removed.
platform/mac-leopard/http/tests/security: Removed.
platform/mac-leopard/http/tests/security/dataURL: Removed.

Test doesn't repaint entire view so result is corrupted by previous test
https://bugs.webkit.org/show_bug.cgi?id=21916

platform/mac/Skipped:

Test is passing but original reference image was invalid.

platform/mac/fast/backgrounds/size/backgroundSize05-expected.checksum:
platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:

Invalid image tiling
https://bugs.webkit.org/show_bug.cgi?id=21915

platform/mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:

SVG not rendering
https://bugs.webkit.org/show_bug.cgi?id=21910

platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-1-expected.png:
platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-2-expected.png:
platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-3-expected.png:
platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
platform/mac/fast/backgrounds/svg-as-mask-expected.checksum:
platform/mac/fast/backgrounds/svg-as-mask-expected.png:
platform/mac/fast/borders/svg-as-border-image-2-expected.checksum:
platform/mac/fast/borders/svg-as-border-image-2-expected.png:
platform/mac/fast/borders/svg-as-border-image-expected.checksum:
platform/mac/fast/borders/svg-as-border-image-expected.png:
platform/mac/fast/images/svg-as-background-expected.checksum:
platform/mac/fast/images/svg-as-background-expected.png:
platform/mac/fast/images/svg-as-image-expected.checksum:
platform/mac/fast/images/svg-as-image-expected.png:
platform/mac/fast/images/svg-as-relative-image-expected.checksum:
platform/mac/fast/images/svg-as-relative-image-expected.png:
platform/mac/fast/images/svg-as-tiled-background-expected.checksum:
platform/mac/fast/images/svg-as-tiled-background-expected.png:

Possible Flash failure
https://bugs.webkit.org/show_bug.cgi?id=21912

platform/mac/fast/dynamic/flash-replacement-test-expected.checksum:
platform/mac/fast/dynamic/flash-replacement-test-expected.png:

Repaint failure
https://bugs.webkit.org/show_bug.cgi?id=21913

platform/mac/fast/repaint/body-background-image-expected.checksum:
platform/mac/fast/repaint/body-background-image-expected.png:

Excessive repainting
https://bugs.webkit.org/show_bug.cgi?id=21914

platform/mac/fast/repaint/float-overflow-expected.checksum:
platform/mac/fast/repaint/float-overflow-expected.png:
platform/mac/fast/repaint/float-overflow-right-expected.checksum:
platform/mac/fast/repaint/float-overflow-right-expected.png:

No video images
https://bugs.webkit.org/show_bug.cgi?id=21911

platform/mac/media/video-aspect-ratio-expected.checksum:
platform/mac/media/video-aspect-ratio-expected.png:
platform/mac/media/video-controls-rendering-expected.checksum:
platform/mac/media/video-controls-rendering-expected.png:
platform/mac/media/video-display-toggle-expected.checksum:
platform/mac/media/video-display-toggle-expected.png:
platform/mac/media/video-layer-crash-expected.checksum:
platform/mac/media/video-layer-crash-expected.png:
platform/mac/media/video-transformed-expected.checksum:
platform/mac/media/video-transformed-expected.png:

3:31 AM Changeset in webkit [38334] by barraclough@apple.com

3 edits
2 adds in trunk

JavaScriptCore:

2008-11-12 Gavin Barraclough <barraclough@apple.com>

Reviewed by Cameron Zwarich.

Fix for https://bugs.webkit.org/show_bug.cgi?id=22201
Integer conversion in array.length was safe signed values,
but the length is unsigned.

VM/CTI.cpp: (JSC::CTI::privateCompilePatchGetArrayLength):

LayoutTests:

2008-11-12 Gavin Barraclough <barraclough@apple.com>

Reviewed by Cameron Zwarich.

Test for https://bugs.webkit.org/show_bug.cgi?id=22201

fast/js/pic/cached-array-length-access-expected.txt: Added.
fast/js/pic/cached-array-length-access.html: Added.

2:51 AM Changeset in webkit [38333] by vestbo@webkit.org

6 edits in trunk

2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Move _web_encodingForResource from WebKit into WebCore and change return type

This change is needed to implement NSAPI in WebCore for Mac, see:

https://bugs.webkit.org/show_bug.cgi?id=21427

2:44 AM Changeset in webkit [38332] by vestbo@webkit.org

6 edits in trunk

2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Moved the implementation of _webkit_isCaseInsensitiveEqualToString to
WebCore's WebCoreNSStringExtras as _stringIsCaseInsensitiveEqualToString.

This change is needed to implement NSAPI in WebCore for Mac, see:

https://bugs.webkit.org/show_bug.cgi?id=21427

1:51 AM Changeset in webkit [38331] by vestbo@webkit.org

3 edits in trunk/WebKit/qt

2008-11-11 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø and Simon Hausmann.

Use QPalette::Base (instead of QPalette::Background) for the page
background.

Api/qwebframe.cpp: (QWebFramePrivate::updateBackground):
Api/qwebview.cpp: (QWebView::QWebView):

1:34 AM Changeset in webkit [38330] by cwzwarich@webkit.org

12 edits in trunk

2008-11-12 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Mark Rowe.

Roll out r38322 due to test failures on the bots.

JavaScriptCore:

VM/CTI.cpp: (JSC::CTI::compileOpCallSetupArgs): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
VM/CTI.h:
VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
VM/Machine.cpp: (JSC::Machine::callEval): (JSC::Machine::dumpCallFrame): (JSC::Machine::dumpRegisters): (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::throwStackOverflowPreviousFrame): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_vm_throw):
VM/Machine.h:
bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitCallEval): (JSC::CodeGenerator::emitConstruct):
bytecompiler/CodeGenerator.h:
parser/Nodes.cpp: (JSC::EvalFunctionCallNode::emitCode): (JSC::FunctionCallValueNode::emitCode): (JSC::FunctionCallResolveNode::emitCode): (JSC::FunctionCallBracketNode::emitCode): (JSC::FunctionCallDotNode::emitCode):
parser/Nodes.h: (JSC::ScopeNode::neededConstants):

LayoutTests:

fast/js/global-recursion-on-full-stack-expected.txt:

Nov 11, 2008:

7:30 PM Changeset in webkit [38329] by Stephanie Lewis

3 edits
2 adds in trunk

2008-11-11 Stephanie <Stephanie Lewis>

Reviewed by Dan Bernstein.

Null check image data before setting it as image source.

Test: fast/images/image-empty-data.html

platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):

Test loading an image with no data.

fast/images/image-empty-data-expected.txt: Added.
fast/images/image-empty-data.html: Added.

7:09 PM Changeset in webkit [38328] by adele@apple.com

2 edits in trunk/WebCore

2008-11-11 Adele Peterson <adele@apple.com>

Reviewed by Tim Hatcher.

Remove ifdef so future OS versions can use the new delegate method.

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didSendBodyDataDelegateExists):

5:53 PM Changeset in webkit [38327] by eric@webkit.org

14 edits in trunk/WebCore

Reviewed by Antti Koivisto and Sam Weinig.

Clean up HTMLTokenizer a litle
https://bugs.webkit.org/show_bug.cgi?id=22188

Rename pendingScripts to m_pendingScripts
Rename scriptNode to m_scriptNode make the type specific
Rename pendingSrc to m_pendingSrc
Rename currentPrependingSrc to m_currentPrependingSrc
Rename noMoreData to m_noMoreData and cBuffer to m_cBuffer
Remove long-since-dead kdDebug and qDebug calls
Rename brokenComments to m_brokenComments
Remove HTMLTokenizer includes and document the rest
Rename src to m_src
Rename parser to m_parser and make it an OwnPtr
Rename inWrite to m_inWrite and jsProxy to scriptController
Rename brokenServer to m_brokenServer
Rename buffer to m_buffer and dest to m_dest
Rename size to m_bufferSize
Rename attrName to m_attrName
Rename searchStopper to m_searchStopper and searchStopperLen to m_searchStopperLen
Rename scriptCode* to m_scriptCode* and change scriptCodeMax to m_scriptCodeCapacity
Rename scriptStartLineno to m_currentScriptTagStartLineNumber and tagStartLineno to m_currentTagStartLineNumber
Rename scriptSrc to m_scriptTagSrcAttrValue and scriptSrcCharset to m_scriptTagCharsetAttrValue -- a bit unwieldy, but more precise
Rename flat to selfClosingTag
Rename currToken to m_currentToken

css/CSSParser.cpp:
dom/XMLTokenizer.cpp:
dom/XMLTokenizerLibxml2.cpp:
html/HTMLDocument.cpp:
html/HTMLElement.cpp:
html/HTMLFormControlElement.cpp:
html/HTMLParser.h:
html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::processListing): (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseServer): (WebCore::HTMLTokenizer::parseProcessingInstruction): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::processingData): (WebCore::HTMLTokenizer::end): (WebCore::HTMLTokenizer::finish): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::processDoctypeToken): (WebCore::HTMLTokenizer::~HTMLTokenizer): (WebCore::HTMLTokenizer::enlargeBuffer): (WebCore::HTMLTokenizer::enlargeScriptBuffer): (WebCore::HTMLTokenizer::notifyFinished): (WebCore::HTMLTokenizer::setSrc):
html/HTMLTokenizer.h: (WebCore::Token::Token): (WebCore::Token::reset): (WebCore::HTMLTokenizer::processingContentWrittenByScript): (WebCore::HTMLTokenizer::htmlParser): (WebCore::HTMLTokenizer::checkBuffer): (WebCore::HTMLTokenizer::checkScriptBuffer):
html/HTMLViewSourceDocument.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::lineWidth):
xml/XSLTProcessor.cpp:

5:37 PM Changeset in webkit [38326] by Simon Fraser

3 edits in trunk/WebKitSite

2008-11-11 Simon Fraser <Simon Fraser>

Update leaves animation sample.

blog-files/leaves/index.html:
blog-files/leaves/leaves.css:

5:35 PM Changeset in webkit [38325] by dino@apple.com

2 edits in trunk/WebKitSite

2008-11-11 Dean Jackson <dino@apple.com>

Removed quotes in animation name value.

blog-files/pulse.html:

4:49 PM Changeset in webkit [38324] by dino@apple.com

1 edit
1 add in trunk/WebKitSite

2008-11-11 Dean Jackson <dino@apple.com>

Added a smaller version of a screenshot.

blog-files/leaves-screenshot-small.jpg: Added.

4:32 PM Changeset in webkit [38323] by dino@apple.com

1 edit
17 adds in trunk/WebKitSite

2008-11-11 Dean Jackson <dino@apple.com>

Add a bunch of examples for CSS Animation blog draft.

blog-files/bounce.html: Added.
blog-files/bounce.png: Added.
blog-files/leaves-screenshot.jpg: Added.
blog-files/leaves/images/apple-touch-icon.png: Added.
blog-files/leaves/images/backgroundLeaves.jpg: Added.
blog-files/leaves/images/realLeaf1.png: Added.
blog-files/leaves/images/realLeaf2.png: Added.
blog-files/leaves/images/realLeaf3.png: Added.
blog-files/leaves/images/realLeaf4.png: Added.
blog-files/leaves/images/textBackground.png: Added.
blog-files/leaves/index.html: Added.
blog-files/leaves/leaves.css: Added.
blog-files/leaves/leaves.js: Added.
blog-files/pulse.html: Added.
blog-files/pulse.png: Added.

4:32 PM Changeset in webkit [38322] by ggaren@apple.com

12 edits in trunk

2008-11-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot.

Instead, the caller emits an explicit load or mov instruction, or relies
on implicit knowledge that "this" is already in the first argument slot.
As a result, two operands to op_call are gone: firstArg and thisVal.

SunSpider and v8 tests show no change in bytecode or CTI.

VM/CTI.cpp: (JSC::CTI::compileOpCallSetupArgs): (JSC::CTI::compileOpCallEvalSetupArgs): (JSC::CTI::compileOpConstructSetupArgs): Split apart these three versions of setting up arguments to op_call, because they're more different than they are the same -- even more so with this patch.

(JSC::CTI::compileOpCall): Updated for the fact that op_construct doesn't
match op_call anymore.

(JSC::CTI::privateCompileMainPass):
(JSC::CTI::privateCompileSlowCases): Merged a few call cases. Updated
for changes mentioned above.

VM/CTI.h:

VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Updated for new bytecode format of call / construct.

VM/Machine.cpp: (JSC::Machine::callEval): Updated for new bytecode format of call / construct.

(JSC::Machine::dumpCallFrame):
(JSC::Machine::dumpRegisters): Simplified these debugging functions,
taking advantage of the new call frame layout.

(JSC::Machine::execute): Fixed up the eval version of execute to be
friendlier to calls in the new format.

(JSC::Machine::privateExecute): Implemented the new call format in
bytecode.

(JSC::Machine::cti_op_call_NotJSFunction):
(JSC::Machine::cti_op_construct_JSConstruct):
(JSC::Machine::cti_op_construct_NotJSConstruct):
(JSC::Machine::cti_op_call_eval): Updated CTI helpers to match the new
call format.

Fixed a latent bug in stack overflow checking that is now hit because
the register layout has changed a bit -- namely: when throwing a stack
overflow exception inside an op_call helper, we need to account for the
fact that the current call frame is only half-constructed, and use the
parent call frame instead.

VM/Machine.h:

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitCallEval): (JSC::CodeGenerator::emitConstruct):
bytecompiler/CodeGenerator.h: Updated codegen to match the new call format.

parser/Nodes.cpp: (JSC::EvalFunctionCallNode::emitCode): (JSC::FunctionCallValueNode::emitCode): (JSC::FunctionCallResolveNode::emitCode): (JSC::FunctionCallBracketNode::emitCode): (JSC::FunctionCallDotNode::emitCode):
parser/Nodes.h: (JSC::ScopeNode::neededConstants): ditto

2008-11-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Updated a test after fixing https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot.

fast/js/global-recursion-on-full-stack-expected.txt: This test passes a little differently now, because the register layout has changed. Specifically, the stack overflow now happens in the call to f() instead of the initiation of the <script> tag, so it is caught, and it does not log an exception to the console.

4:28 PM Changeset in webkit [38321] by weinig@apple.com

4 edits in trunk/WebCore

2008-11-11 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=22189
Track CachedScript decoded data

We now track the decoded size of CachedScripts in the Cache allowing
them to accounted for when deciding when to evict data. The decoded
data itself can be evicted when Cache pressure gets high enough through
CachedScript::destroyDecodedData.

loader/CachedResource.h: (WebCore::CachedResource::allClientsRemoved): (WebCore::CachedResource::destroyDecodedData):
loader/CachedScript.cpp: (WebCore::CachedScript::script): (WebCore::CachedScript::data): (WebCore::CachedScript::destroyDecodedData):
loader/CachedScript.h:

3:39 PM Changeset in webkit [38320] by cwzwarich@webkit.org

8 edits
1 delete in trunk

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Remove pointless dependencies on the now-deleted kjs directory and
mentions of it in comments that are no longer relevant.

JavaScriptCore:

ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.

WebCore:

WebCore.pro:
webcore-base.bkl:

WebKit/qt:

WebKit_pch.h:

WebKit/wx:

presets/wxwebkit.bkl:

3:26 PM Changeset in webkit [38319] by adachan@apple.com

2 edits in trunk/WebKitLibraries

Fix: https://bugs.webkit.org/show_bug.cgi?id=22187
Bug 22187: CLEARTYPE_QUALITY flag is not supported on Win2000

Update window versions to correspond to Windows XP.

Reviewed by Steve Falkenburg.

win/tools/vsprops/common.vsprops:

2:45 PM Changeset in webkit [38318] by mitz@apple.com

16 edits in trunk

WebCore:

Reviewed by Adam Roben.

WebCore part of adding a master volume control for media elements in a WebView

WebCore.base.exp: Exported WebCore::Page::setMediaVolume().
dom/Document.cpp: (WebCore::Document::mediaVolumeDidChange): Added. Called by the Page when the media volume is changed. (WebCore::Document::registerForMediaVolumeCallbacks): Added. Allows elements to register for a callback when the media volume is changed. (WebCore::Document::unregisterForMediaVolumeCallbacks): Added. Allows elements to unregister for the callback.
dom/Document.h:
dom/Element.h: (WebCore::Element::mediaVolumeDidChange): Added an empty implementation.
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Added a call to registerForMediaVolumeCallbacks(). (WebCore::HTMLMediaElement::~HTMLMediaElement): Added a call to unregisterForMediaVolumeCallbacks(). (WebCore::HTMLMediaElement::updateVolume): Changed to multiply the element's intrinsic volume by the master volume from the page. (WebCore::HTMLMediaElement::mediaVolumeDidChange): Added. Calls updateVolume().
html/HTMLMediaElement.h:
page/Page.cpp: (WebCore::Page::Page): Initialize m_mediaVolume to 1. (WebCore::Page::setMediaVolume): Added. Calls mediaVolumeDidChange() on every document in the page when the master volume changes.
page/Page.h: (WebCore::Page::mediaVolume): Added this getter.

WebKit/mac:

Reviewed by Adam Roben.

WebKit/mac part of adding a master volume control for media elements in a WebView

WebView/WebView.mm: (-[WebView setMediaVolume:]): Added. (-[WebView mediaVolume]): Added.
WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by Adam Roben.

WebKit/win part of adding a master volume control for media elements in a WebView

Interfaces/IWebViewPrivate.idl: Added setMediaVolume() and mediaVolume().
WebView.cpp: (WebView::setMediaVolume): Added. (WebView::mediaVolume): Added.
WebView.h:

2:31 PM Changeset in webkit [38317] by andersca@apple.com

1 edit
6 deletes in trunk/LayoutTests

2008-11-11 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Mark Rowe.

Removed invalid bases incorrectly checked-in in r38305.

https://bugs.webkit.org/show_bug.cgi?id=22185

platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.checksum: Removed.
platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.png: Removed.
platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.txt: Removed.
platform/mac-tiger/fast/text/international/hindi-spacing-expected.checksum: Removed.
platform/mac-tiger/fast/text/international/hindi-spacing-expected.png: Removed.
platform/mac-tiger/fast/text/international/hindi-spacing-expected.txt: Removed.

2:25 PM Changeset in webkit [38316] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Fix broken dependencies building JavaScriptCore on a freezing cold cat, caused
by failure to update all instances of "kjs" to their new locations.

JavaScriptCore.xcodeproj/project.pbxproj:

2:13 PM Changeset in webkit [38315] by ddkilzer@apple.com

2 edits in trunk/WebKit/mac

2008-11-11 Aaron Golden <agolden@apple.com>

Bug 22134: -[WebHistoryItem dictionaryRepresentation] accesses past the end of a vector

<https://bugs.webkit.org/show_bug.cgi?id=22134>

Reviewed by Geoff Garen.

History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem dictionaryRepresentation]):

1:49 PM Changeset in webkit [38314] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Rubber-stamped by Adam Roben.

wtf/AVLTree.h: (WTF::AVLTree::Iterator::start_iter): Fix indentation a little more.

1:11 PM Changeset in webkit [38313] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Clean up EvalCodeCache to match our coding style a bit more.

VM/EvalCodeCache.h: (JSC::EvalCodeCache::get):

12:43 PM Changeset in webkit [38312] by hyatt@apple.com

2 edits in trunk/WebCore

2008-11-11 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=22182

Fix problems with scrollbars when the OS setting for clicks in the track jumping the thumb to that location
is turned on. Make sure to only jump the thumb if the click happens in the track. Also fix some math
errors when jumping the thumb that cause dragging after the jump to incorrectly jump the thumb again.

Reviewed by Adele

platform/Scrollbar.cpp: (WebCore::Scrollbar::mouseDown):

12:06 PM Changeset in webkit [38311] by cwzwarich@webkit.org

6 edits
1 copy in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Bug 22179: Move EvalCodeCache from CodeBlock.h into its own file
<https://bugs.webkit.org/show_bug.cgi?id=22179>

GNUmakefile.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
VM/CodeBlock.h:
VM/EvalCodeCache.h: Copied from VM/CodeBlock.h.
VM/Machine.cpp:

11:58 AM Changeset in webkit [38310] by Beth Dakin

12 edits
4 adds in trunk

WebCore:

2008-11-11 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for <rdar://problem/5089327> Too much indentation when pasting
quoted paragraphs

This patch re-addresses pasting blockquotes into blockquotes. It
backs out most of revision 38273. 38273 fixed the bug by inserting
the pasted content as a sibling blockquote node to the pre-existing
blockquote node. The problem with that is that by default,
blockquotes have a giant margin, so visually, this can be weird.
This patch instead inserts the pasted content as siblings of the
the content already inside the outer blockquote, and then removes
the blockquote node from the pasted content itself, so that it
doesn't nest itself into the outer blockquote.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):

Move contains() from Element to Node since there is nothing
Element-specific about it.

dom/Element.cpp:
dom/Element.h:
dom/Node.cpp: (WebCore::Node::contains):
dom/Node.h:

LayoutTests:

2008-11-11 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Tests for <rdar://problem/5089327> Too much indentation when
pasting quoted paragraphs

This is a new test:

editing/pasteboard/paste-blockquote-into-blockquote-3.html: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.checksum: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.png: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.txt: Added.

The results for these tests previously reflected the behavior
implemented in revision 38273. We have since decided that that
behavior is wrong and we changed it with this patch.

platform/mac/editing/pasteboard/merge-end-blockquote- expected.checksum:
platform/mac/editing/pasteboard/merge-end-blockquote- expected.png:
platform/mac/editing/pasteboard/merge-end-blockquote- expected.txt:
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.txt:
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.txt:

11:50 AM Changeset in webkit [38309] by hyatt@apple.com

2 edits in trunk/WebCore

2008-11-11 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=17997

Stop using the new Leopard API tiling call for scaled tiles when drawing background images. The method
is buggy. Fall back to using the slower (and more correct) pattern tiling that Tiger still uses. This
is a Leopard-only workaround, since the API has been fixed on Snow Leopard.

Reviewed by John Sullivan

platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):

11:41 AM Changeset in webkit [38308] by krit@webkit.org

5 edits in trunk/LayoutTests

2008-11-11 Dirk Schulze <krit@webkit.org>

Reviewed by Dave Hyatt.

Pattern transform check was too strict for Cg. Scaling can cause a wrong
color on the borders of the scaled object.

Correct expected result of the tests.

fast/canvas/canvas-pattern-transform-expected.txt:
fast/canvas/canvas-pattern-transform.html:
fast/canvas/canvas-pattern-transform.js:
fast/canvas/canvas-radial-gradient-spreadMethod-expected.txt:

11:18 AM Changeset in webkit [38307] by hyatt@apple.com

2 edits
4 adds in trunk

2008-11-10 David Hyatt <hyatt@apple.com>

Disable the Aqua look for menu lists when full page zoom is turned on. Because the control is buggy
when scaling and because it's impossible to paint into an offscreen bitmap without completely rewriting
how we draw the control on Mac, our only real option for now is to just switch to our styled look when zoomed.

Reviewed by Adam Roben

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):

10:31 AM Changeset in webkit [38306] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove the 'm_' prefix from the fields of the SwitchRecord struct.

VM/CTI.cpp: (JSC::CTI::privateCompile):
VM/CTI.h: (JSC::SwitchRecord): (JSC::SwitchRecord::SwitchRecord):

10:26 AM Changeset in webkit [38305] by mitz@apple.com

27 edits
18 adds
640 deletes in trunk/LayoutTests

2008-11-11 Pierre-Olivier Latour <pol@apple.com>

Rubber-stamped by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21821

Removed pixel results in platform/mac-tiger that were only slightly different
(within 1% tolerance) from the platform/mac results.
Removed results in platform/mac-tiger where the results in platform/mac were
also correct for Tiger.
Also updated results in platform/mac-tiger that were out of date.

Made sure every test that has a specific mac-tiger render tree output also has matching images.

(file listing elided)

9:59 AM Changeset in webkit [38304] by Darin Adler

2 edits in trunk/WebCore

2008-11-11 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22160 speculative fix for <rdar://problem/5995450> Nil deref because nextLinePosition (previousLinePosition, too) uses a nil node

editing/visible_units.cpp: (WebCore::nextLinePosition): Use RenderObject::node instead of RenderObject::element to check editingIgnoresContent. It makes sense to use the associated DOM node for this, even in cases of anonymous content, and it avoids the case where element() can be 0. (WebCore::previousLinePosition): Ditto.

9:54 AM Changeset in webkit [38303] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Make asInteger() a static function so that it has internal linkage.

VM/CTI.cpp: (JSC::asInteger):

9:40 AM Changeset in webkit [38302] by krit@webkit.org

3 edits
3 adds in trunk

2008-11-11 Dirk Schulze <vbs85@gmx.de>

WebCore:

Reviewed by Darin Adler.

Removed default: in applySpreadMethod. This causes the problems
in radial gradients. We don't need CAIRO_EXTEND_NONE in SVG, Canvas
or CSS.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::applySpreadMethod):

LayoutTests:

Reviewed by Darin Adler.

Check behavior of default spreadMethod on radial gradients.

fast/canvas/canvas-radial-gradient-spreadMethod-expected.txt: Added.
fast/canvas/canvas-radial-gradient-spreadMethod.html: Added.
fast/canvas/canvas-radial-gradient-spreadMethod.js: Added.

5:32 AM Changeset in webkit [38301] by vestbo@webkit.org

2 edits in trunk/WebCore

2008-11-11 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø.

Fix crash when rendering the file chooser.
Also proper implementation for multi-selected files.

platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::basenameForWidth):

3:35 AM Changeset in webkit [38300] by krit@webkit.org

1 edit
3 adds in trunk/LayoutTests

2008-11-11 Dirk Schulze <vbs85@gmx.de>

Reviewed by Oliver Hunter.

Added test to check behavior on transformations of patterns in canvas.

fast/canvas/canvas-pattern-transform-expected.txt: Added.
fast/canvas/canvas-pattern-transform.html: Added.
fast/canvas/canvas-pattern-transform.js: Added.

3:05 AM Changeset in webkit [38299] by krit@webkit.org

4 edits in trunk/WebCore

1:51 AM Changeset in webkit [38298] by mjs@apple.com

4 edits in trunk/JavaScriptCore

2008-11-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

shrink CodeBlock and AST related Vectors to exact fit (5-10M savings on membuster test)

No perf regression combined with the last patch (each seems like a small regression individually)

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::generate):
parser/Nodes.h: (JSC::SourceElements::releaseContentsIntoVector):
wtf/Vector.h: (WTF::Vector::shrinkToFit):

1:11 AM Changeset in webkit [38297] by mitz@apple.com

2023 edits
35 adds in trunk/LayoutTests

2008-11-11 Pierre-Olivier Latour <pol@apple.com>

Rubber-stamped by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=21821

Remaining set of updated expected pixel results. This includes http/,
media/, plugins/, scrollbars/, tables/, transforms/, transitions/ and
webarchive/.

(file listing elided)

1:10 AM Changeset in webkit [38296] by mjs@apple.com

3 edits in trunk/JavaScriptCore

2008-11-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

remove inline capacity from declaration stacks (15M savings on membuster test)

No perf regression on SunSpider or V8 test combined with other upcoming memory improvement patch.

JavaScriptCore.exp:
parser/Nodes.h:

12:06 AM Changeset in webkit [38295] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

While r38286 removed the need for the m_callFrame member variable of
CTI, it should be also be removed.

VM/CTI.h:

Nov 10, 2008:

11:57 PM Changeset in webkit [38294] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

Make CTI::asInteger() a non-member function, since it needs no access to
any of CTI's member variables.

VM/CTI.cpp: (JSC::asInteger):
VM/CTI.h:

11:06 PM Changeset in webkit [38293] by Stephanie Lewis

3 edits in trunk/WebCore

2008-11-10 Stephanie Lewis <Stephanie Lewis>

Reviewed by Dan Bernstein.

Clear the image source cache even if we haven't decoded any of the image data.
We use the image source cache when calculating layout.

loader/Cache.cpp: (WebCore::Cache::pruneDeadResources):
platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):

10:04 PM Changeset in webkit [38292] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Use 'value' instead of 'js' in CTI as a name for JSValue* to match our
usual convention elsewhere.

VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes):

9:55 PM Changeset in webkit [38291] by cwzwarich@webkit.org

4 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Make CTI::getConstant() a member function of CodeBlock instead.

VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
VM/CTI.h:
VM/CodeBlock.h: (JSC::CodeBlock::getConstant):

9:45 PM Changeset in webkit [38290] by cwzwarich@webkit.org

4 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Rename CodeBlock::isConstant() to isConstantRegisterIndex().

VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
VM/CodeBlock.h: (JSC::CodeBlock::isConstantRegisterIndex):
bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):

9:40 PM Changeset in webkit [38289] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

non-CTI build fix take 2

9:31 PM Changeset in webkit [38288] by barraclough@apple.com

1 edit in trunk/JavaScriptCore/VM/Machine.cpp

non-CTI build fix

9:22 PM Changeset in webkit [38287] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove the unused labels member variable of CodeBlock.

VM/CodeBlock.h:
VM/LabelID.h: (JSC::LabelID::setLocation):

9:09 PM Changeset in webkit [38286] by barraclough@apple.com

7 edits in trunk/JavaScriptCore

2008-11-10 Gavin Barraclough <barraclough@apple.com>

Reviewed by Camron Zwarich.

Batch compile the set of static trampolines at the point Machine is constructed, using a single allocation.
Refactor out m_callFrame from CTI, since this is only needed to access the global data (instead store a
pointer to the global data directly, since this is available at the point the Machine is constructed).
Add a method to align the code buffer, to allow JIT generation for multiple trampolines in one block.

VM/CTI.cpp: (JSC::CTI::getConstant): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::CTI): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::freeCTIMachineTrampolines):
VM/CTI.h: (JSC::CTI::compile): (JSC::CTI::compileGetByIdSelf): (JSC::CTI::compileGetByIdProto): (JSC::CTI::compileGetByIdChain): (JSC::CTI::compilePutByIdReplace): (JSC::CTI::compilePutByIdTransition): (JSC::CTI::compileCTIMachineTrampolines): (JSC::CTI::compilePatchGetArrayLength):
VM/Machine.cpp: (JSC::Machine::initialize): (JSC::Machine::~Machine): (JSC::Machine::execute): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::tryCTICacheGetByID): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_lazyLinkCall):
VM/Machine.h:
masm/X86Assembler.h: (JSC::JITCodeBuffer::isAligned): (JSC::X86Assembler::): (JSC::X86Assembler::align):
runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):

7:51 PM Changeset in webkit [38285] by mjs@apple.com

2 edits in trunk/JavaScriptCore

2008-11-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

Make Vector::clear() release the Vector's memory (1MB savings on membuster) https://bugs.webkit.org/show_bug.cgi?id=22170

wtf/Vector.h: (WTF::VectorBufferBase::deallocateBuffer): Set capacity to 0 as well as size, otherwise shrinking capacity to 0 can fail to reset the capacity and thus cause a future crash. (WTF::Vector::~Vector): Shrink size not capacity; we only need to call destructors, the buffer will be freed anyway. (WTF::Vector::clear): Change this to shrinkCapacity(0), not just shrink(0). (WTF::::shrinkCapacity): Use shrink() instead of resize() for case where the size is greater than the new capacity, to work with types that have no default constructor.

7:38 PM Changeset in webkit [38284] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Split multiple definitions into separate lines.

VM/CTI.cpp: (JSC::CTI::compileBinaryArithOp):

5:26 PM Changeset in webkit [38283] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move renewGState to the base class.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView renewGState]):
Plugins/WebNetscapePluginView.mm:

5:23 PM Changeset in webkit [38282] by andersca@apple.com

5 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move start, stop and all the related methods down to WebBaseNetscapePluginView.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView updateAndSetWindow]): (-[WebBaseNetscapePluginView addWindowObservers]): (-[WebBaseNetscapePluginView removeWindowObservers]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToHostWindow]): (-[WebBaseNetscapePluginView windowWillClose:]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView windowDidMiniaturize:]): (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]): (-[WebBaseNetscapePluginView preferencesHaveChanged:]):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm:

5:13 PM Changeset in webkit [38281] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move rightMouseDown, rightMouseUp and sendActivateEvent to the base plugin view.
Add stubs for createPlugin, loadStream, shouldStop and destroyPlugin.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowFocusChanged:]): (-[WebBaseNetscapePluginView createPlugin]): (-[WebBaseNetscapePluginView loadStream]): (-[WebBaseNetscapePluginView destroyPlugin]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView rightMouseDown:]): (-[WebBaseNetscapePluginView rightMouseUp:]):
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView windowFocusChanged:]):

4:51 PM Changeset in webkit [38280] by andersca@apple.com

2 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Factor plug-in type specific code out to three new methods, createPlugin, destroyPlugin and loadStream.

Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]): (-[WebNetscapePluginView loadStream]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView shouldStop]): (-[WebNetscapePluginView destroyPlugin]): (-[WebNetscapePluginView stop]):

4:38 PM Changeset in webkit [38279] by andersca@apple.com

2 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Fix Tiger build.

Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

4:29 PM Changeset in webkit [38278] by andersca@apple.com

5 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move even more code down to WebBaseNetscapePluginView, get rid of some unnecessary methods.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView focusChanged]): (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView acceptsFirstResponder]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView focusChanged]): (-[WebNetscapePluginView tellQuickTimeToChill]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView stop]): (-[WebNetscapePluginView viewWillMoveToWindow:]): (-[WebNetscapePluginView createPluginScriptableObject]): (-[WebNetscapePluginView pluginView:receivedData:]): (-[WebNetscapePluginView pluginView:receivedError:]): (-[WebNetscapePluginView pluginViewFinishedLoading:]): (-[WebNetscapePluginView inputContext]): (-[WebNetscapePluginView hasMarkedText]): (-[WebNetscapePluginView insertText:]): (-[WebNetscapePluginView markedRange]): (-[WebNetscapePluginView selectedRange]): (-[WebNetscapePluginView setMarkedText:selectedRange:]): (-[WebNetscapePluginView unmarkText]): (-[WebNetscapePluginView validAttributesForMarkedText]): (-[WebNetscapePluginView attributedSubstringFromRange:]): (-[WebNetscapePluginView characterIndexForPoint:]): (-[WebNetscapePluginView doCommandBySelector:]): (-[WebNetscapePluginView firstRectForCharacterRange:]): (-[WebNetscapePluginView _viewHasMoved]): (-[WebNetscapePluginView _redeliverStream]):

3:43 PM Changeset in webkit [38277] by andersca@apple.com

6 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move timer handling code down to WebBaseNetscapePluginView.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView startTimers]): (-[WebBaseNetscapePluginView restartTimers]):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView stopTimers]): (-[WebNetscapePluginView startTimers]): (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
WebView/WebHTMLView.mm: (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):

2:59 PM Changeset in webkit [38276] by andersca@apple.com

8 edits in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add WebHostedNetscapePluginView to the project.

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move a bunch of methods and ivars up to WebBaseNetscapePluginView.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView finalize]): (-[WebBaseNetscapePluginView removeTrackingRect]): (-[WebBaseNetscapePluginView resetTrackingRect]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView webFrame]): (-[WebBaseNetscapePluginView webView]): (-[WebBaseNetscapePluginView currentWindow]):
Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView sendActivateEvent:]): (-[WebNetscapePluginView restartTimers]): (-[WebNetscapePluginView setHasFocus:]): (-[WebNetscapePluginView mouseDown:]): (-[WebNetscapePluginView mouseUp:]): (-[WebNetscapePluginView mouseEntered:]): (-[WebNetscapePluginView mouseExited:]): (-[WebNetscapePluginView handleMouseMoved:]): (-[WebNetscapePluginView mouseDragged:]): (-[WebNetscapePluginView scrollWheel:]): (-[WebNetscapePluginView keyUp:]): (-[WebNetscapePluginView keyDown:]): (-[WebNetscapePluginView flagsChanged:]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView setWindowIfNecessary]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView stop]): (-[WebNetscapePluginView isStarted]): (-[WebNetscapePluginView dealloc]): (-[WebNetscapePluginView finalize]): (-[WebNetscapePluginView drawRect:]): (-[WebNetscapePluginView windowBecameKey:]): (-[WebNetscapePluginView preferencesHaveChanged:]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): (-[WebNetscapePluginView _viewHasMoved]):

2:27 PM Changeset in webkit [38275] by andersca@apple.com

8 edits
2 adds in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker and Mark Rowe.

Add a WebHostedNetscapePluginView class.

Plugins/WebHostedNetscapePluginView.h: Added.
Plugins/WebHostedNetscapePluginView.mm: Added.

Plugins/WebNetscapePluginPackage.h: Use the right define.

Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): Check for WebBaseNetscapePluginView.

(-[WebPluginDatabase destroyAllPluginInstanceViews]):
Check for WebBaseNetscapePluginView.

WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): Use WebBaseNetscapePluginView.

(netscapePluginViewClass):
New function that returns the right netscape plugin view type to use.

(WebFrameLoaderClient::createPlugin):
Get the right class.

WebKitPrefix.h: Prefix the #define with WTF_.

WebView/WebHTMLView.mm: (-[NSArray _web_makePluginViewsPerformSelector:withObject:]): Check for WebBaseNetscapePluginView.

WebView/WebView.mm: Remove an unnecessary include.

2:12 PM Changeset in webkit [38274] by Adam Roben

3 edits
2 adds in trunk

Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when loading microsoftpdc.com

WebCore:

Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when
loading microsoftpdc.com

<https://bugs.webkit.org/show_bug.cgi?id=22161>

Reviewed by Dan Bernstein.

Test: fast/css/outline-invert-assertion.html

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::systemColor): If we can't determine a good Win32 system color to use, defer to RenderTheme instead of asserting. This matches what RenderThemeMac does.

LayoutTests:

Test for Bug 22161: Assertion failure in RenderThemeWin::systemColor
when loading microsoftpdc.com

<https://bugs.webkit.org/show_bug.cgi?id=22161>

Note that this test would only fail if DumpRenderTree used
RenderThemeWin, which it doesn't. I did test that locally, though.

Reviewed by Dan Bernstein.

fast/css/outline-invert-assertion-expected.txt: Added.
fast/css/outline-invert-assertion.html: Added.

1:51 PM Changeset in webkit [38273] by Beth Dakin

6 edits
8 adds in trunk

WebCore:

2008-11-10 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/4037481> REGRESSION (Mail): pasting quoted text
into quoted text yields double-quoting

Don't nest inserted content in Mail blockquotes. Perform a
BreakBlockquoteCommand if we're in
one and insert the incoming fragment between the split blockquotes.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Renamed from -> source and to -> destination. (WebCore::ReplaceSelectionCommand::doApply):

LayoutTests:

2008-11-10 Beth Dakin <Beth Dakin>

Rubber stamped by Justin Garcia.

New tests for <rdar://problem/4037481> REGRESSION (Mail): pasting
quoted text into quoted text yields double-quoting

editing/pasteboard/paste-blockquote-into-blockquote-2.html: Added.
editing/pasteboard/paste-blockquote-into-blockquote.html: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.checksum: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.png: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.txt: Added.
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.checksum: Added.
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.png: Added.
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.txt: Added.

Test with new results because of this patch:

platform/mac/editing/pasteboard/merge-end-blockquote- expected.checksum:
platform/mac/editing/pasteboard/merge-end-blockquote- expected.png:
platform/mac/editing/pasteboard/merge-end-blockquote- expected.txt:

1:47 PM Changeset in webkit [38272] by mrowe@apple.com

2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

Commit the current configuration of build.webkit.org.

1:45 PM Changeset in webkit [38271] by mrowe@apple.com

5 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/webkit

Commit the current configuration of build.webkit.org.

1:33 PM Changeset in webkit [38270] by andersca@apple.com

6 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Don't use individual ivars for each plug-in vtable function. Instead, get them from the plugin package.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
Plugins/WebNetscapePluginPackage.h:
Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView setWindowIfNecessary]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebNetscapePluginView createPluginScriptableObject]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView loadPluginRequest:]): (-[WebNetscapePluginView _createPlugin]): (-[WebNetscapePluginView _destroyPlugin]): (-[WebNetscapePluginView _printedPluginBitmap]):

1:00 PM Changeset in webkit [38269] by andersca@apple.com

5 edits
2 adds in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add a new WebBaseNetscapePluginView class.

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add a new WebBaseNetscapePluginView class.

Plugins/WebBaseNetscapePluginView.h: Added.
Plugins/WebBaseNetscapePluginView.mm: Added. (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]): (-[WebBaseNetscapePluginView handleMouseMoved:]):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView cut:]): (-[WebNetscapePluginView copy:]): (-[WebNetscapePluginView paste:]): (-[WebNetscapePluginView selectAll:]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):

12:25 PM Changeset in webkit [38268] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 22162: Remove cachedValueGetter from the JavaScriptCore API implementation
<https://bugs.webkit.org/show_bug.cgi?id=22162>

There is no more need for the cachedValueGetter hack now that we have
PropertySlot::setValue(), so we should remove it.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot):

12:20 PM Changeset in webkit [38267] by andersca@apple.com

17 edits
2 moves in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Rename WebBaseNetscapePluginView to WebNetscapePluginView.

StringsNotToBeLocalized.txt:
WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Rename WebBaseNetscapePluginView to WebNetscapePluginView.

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::setPlugin):
Plugins/WebBaseNetscapePluginView.h: Removed.
Plugins/WebBaseNetscapePluginView.mm: Removed.
Plugins/WebNetscapePluginEventHandler.h: (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
Plugins/WebNetscapePluginEventHandlerCarbon.h:
Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
Plugins/WebNetscapePluginEventHandlerCocoa.h:
Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
Plugins/WebNetscapePluginView.h: Copied from mac/Plugins/WebBaseNetscapePluginView.h.
Plugins/WebNetscapePluginView.mm: Copied from mac/Plugins/WebBaseNetscapePluginView.mm. (+[WebNetscapePluginView setCurrentPluginView:]): (+[WebNetscapePluginView currentPluginView]): (-[WebNetscapePluginView loadPluginRequest:]):
Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): (-[WebPluginDatabase destroyAllPluginInstanceViews]):
Plugins/npapi.mm: (pluginViewForInstance): (NPN_MarkedTextAbandoned): (NPN_MarkedTextSelectionChanged):
WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): (WebFrameLoaderClient::createPlugin):
WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
WebView/WebView.mm:

10:38 AM Changeset in webkit [38266] by Adam Roben

4 edits
1 add in trunk

Fix Bug 22158: Would like to turn on WebCore logging channels via an environment variable

WebCore:

Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable

<https://bugs.webkit.org/show_bug.cgi?id=22158>

Logging channels can now be enabled by setting the WebCoreLogLevel
environment variable to a hexadecimal number.

Reviewed by Anders Carlsson.

WebCore.vcproj/WebCore.vcproj: Added LoggingWin.cpp.
platform/win/LoggingWin.cpp: Copied from WebCore/platform/mac/LoggingMac.mm. (WebCore::initializeWithUserDefault): Read in the WebCoreLogLevel environment variable, parse its value as a hexadecimal number, and turn the channel on/off based on whether the mask bit is set. (WebCore::InitializeLoggingChannelsIfNecessary): Initialize each logging channel in turn.

WebKit/win:

Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable

<https://bugs.webkit.org/show_bug.cgi?id=22158>

Reviewed by Anders Carlsson.

WebView.cpp: (WebView::initWithFrame): Call WebCore's InitializeLoggingChannelsIfNecessary.

10:17 AM Changeset in webkit [38265] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22152: Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
<https://bugs.webkit.org/show_bug.cgi?id=22152>

With the recent change to adopt asType() style cast functions with
assertions instead of static_casts in many places, the assertion for
the asObject() call in JSCallbackObject::getOwnPropertySlot() has been
failing when using any nontrivial client of the JavaScriptCore API.
The cast isn't even necessary to call slot.setCustom(), so it should
be removed.

API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject::getOwnPropertySlot):

9:06 AM Changeset in webkit [38264] by Darin Adler

4 edits in trunk/WebCore

2008-11-10 Darin Adler <Darin Adler>

Reviewed by Adam Roben.

fix https://bugs.webkit.org/show_bug.cgi?id=22103 Changing fonts in preferences does not immediately update WebViews

This broke when the meaning of FrameView::invalidate changed.
I changed setNeedsReapplyStyles to no longer depend on invalidate.

dom/Document.cpp: (WebCore::Document::shouldScheduleLayout): Removed the part of this function that duplicated what's already in FrameView::needsLayout, since the copy here left out a few key things. For example, it didn't handle the fact that "needs reapply styles" counts as needing layout.

page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): This called FrameView::invalidate before. There were two things wrong with that. 1) It requested that the entire view repaint even if the style change didn't necessitate that. 2) FrameView::invalidate no longer causes any repainting at all in certain cases, because of Hyatt's changes to how widgets and the host window are involved in the repainting process. So call FrameView::scheduleRelayout instead, which is more precisely what we want and need here.

page/FrameView.cpp: (WebCore::FrameView::scheduleRelayout): Add a call to needsLayout here so that Document::shouldScheduleLayout doesn't have to replicate the logic that's in needsLayout and can instead rely on the fact that it was already called. (WebCore::FrameView::needsLayout): Tweaked the comments and formatting in this function.

9:03 AM Changeset in webkit [38263] by Darin Adler

2 edits in trunk/WebCore

2008-11-10 Darin Adler <Darin Adler>

Reviewed by Adam Roben.

speculative fix for <rdar://problem/5557243> crashes in Safari at WebCore::HTMLSelectElement::updateListBoxSelection + 280

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::updateListBoxSelection): Check index against size of vector before indexing into the vector.

7:55 AM Changeset in webkit [38262] by vestbo@webkit.org

2 edits in trunk

2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Distinguish between building from trunk and as part of Qt

7:42 AM Changeset in webkit [38261] by Darin Adler

4 edits in trunk/BugsSite

2008-11-10 Darin Adler <Darin Adler>

fix more of https://bugs.webkit.org/show_bug.cgi?id=21400 "Edit" links for patches in comments, review queue, review emails should be replaced by "Review Patch" links

globals.pl: Fix cases that are automatically generated, such as links in comments in bugs.

template/en/custom/attachment/created.html.tmpl: Fix the link on the "I just created an attachment" page.

template/en/custom/request/queue.html.tmpl: Fix the link in the queue page.

7:31 AM Changeset in webkit [38260] by Darin Adler

2 edits in trunk/BugsSite

2008-11-10 Darin Adler <Darin Adler>

template/en/custom/request/email.txt.tmpl: Send review links instead of edit links when flags are set on a bug.

7:03 AM Changeset in webkit [38259] by ap@webkit.org

3 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.

A few coding style fixes for AVLTree.

wtf/AVLTree.h: Moved to WTF namespace, Removed "KJS_" from include guards. (WTF::AVLTree::Iterator::start_iter): Fixed indentation

runtime/JSArray.cpp: Added "using namepace WTF".

6:37 AM Changeset in webkit [38258] by Simon Hausmann

3 edits in trunk/WebKit/qt

2008-11-10 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

To fit Qt API, scroll offset is a QPoint instead of a QSize.

Api/qwebframe.cpp: (QWebFrame::scrollOffset): (QWebFrame::setScrollOffset):
Api/qwebframe.h:

3:46 AM Changeset in webkit [38257] by Simon Hausmann

2 edits in trunk

2008-11-10 Morten Sørvig <msorvig@trolltech.com>

Reviewed by Simon Hausmann.

Make tests/auto/qwebframe compile on Qt/Mac.

3:46 AM Changeset in webkit [38256] by Simon Hausmann

3 edits in trunk/WebKit/qt

2008-11-10 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Fixed qdoc warnings by supplying function documentation.

3:45 AM Changeset in webkit [38255] by Simon Hausmann

1 edit
1 delete in trunk/WebKit/qt

2008-11-10 Tobias Koenig <tobias.koenig@trolltech.com>

Reviewed by Simon Hausmann.

Removed old and stale prf file that breaks the MingW build.

3:45 AM Changeset in webkit [38254] by Simon Hausmann

2 edits in trunk/WebCore

2008-11-10 Tom Cooksey <thomas.cooksey@trolltech.com>

Reviewed by Tor Arne Vestbø.

Fix QtWebkit build failure on arm.

pen.widthF() is a qreal, which means it's a float on arm.

3:45 AM Changeset in webkit [38253] by Simon Hausmann

3 edits in trunk/WebKit/qt

2008-11-10 Kavindra Palaraja <kdpalara@trolltech.com>

Reviewed by Simon Hausmann.

Clarify QWebFrame/View::setHTML docs with regards to relative URLs

3:45 AM Changeset in webkit [38252] by Simon Hausmann

2 edits in trunk/WebKit/qt

2008-11-10 Joerg Bornemann <joerg.bornemann@nokia.com>

Reviewed by Simon Hausmann

Don't define _CRT_RAND_S on Windows CE in the precompiled
header, to fix the CE build.

3:45 AM Changeset in webkit [38251] by Simon Hausmann

2 edits in trunk/WebCore

2008-11-10 Morten Sørvig <msorvig@trolltech.com>

Reviewed by Simon Hausmann.

Improve mouse wheel scolling on Qt/Cocoa.
Cocoa differs from Carbon (and other platforms I think) in that the
mouse wheel events we get have a much higher acceleration factor.

This submit switches over to scroll-per-pixel from scroll-per-line
for most of our scrolling views. This matches the native views
and works well with the increased acceleration.

Nov 9, 2008:

10:26 PM Changeset in webkit [38250] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-09 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Speculatively fix the non-AllInOne build.

runtime/NativeErrorConstructor.cpp:

5:28 PM Changeset in webkit [38249] by Darin Adler

15 edits
1 delete in trunk/JavaScriptCore

2008-11-09 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=22149 remove unused code from the parser

AllInOneFile.cpp: Removed nodes2string.cpp.
GNUmakefile.am: Ditto.
JavaScriptCore.exp: Ditto.
JavaScriptCore.pri: Ditto.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
JavaScriptCoreSources.bkl: Ditto.

VM/CodeBlock.h: Added include.

VM/Machine.cpp: (JSC::Machine::execute): Use the types from

DeclarationStacks as DeclarationStacks

rather than Node:: since "Node" really has little to do with it.

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Ditto.

jsc.cpp: (Options::Options): Removed prettyPrint option. (runWithScripts): Ditto. (printUsageStatement): Ditto. (parseArguments): Ditto. (jscmain): Ditto.

parser/Grammar.y: Removed use of obsolete ImmediateNumberNode.

parser/Nodes.cpp: (JSC::ThrowableExpressionData::emitThrowError): Use inline functions instead of direct member access for ThrowableExpressionData values. (JSC::BracketAccessorNode::emitCode): Ditto. (JSC::DotAccessorNode::emitCode): Ditto. (JSC::NewExprNode::emitCode): Ditto. (JSC::EvalFunctionCallNode::emitCode): Ditto. (JSC::FunctionCallValueNode::emitCode): Ditto. (JSC::FunctionCallResolveNode::emitCode): Ditto. (JSC::FunctionCallBracketNode::emitCode): Ditto. (JSC::FunctionCallDotNode::emitCode): Ditto. (JSC::PostfixResolveNode::emitCode): Ditto. (JSC::PostfixBracketNode::emitCode): Ditto. (JSC::PostfixDotNode::emitCode): Ditto. (JSC::DeleteResolveNode::emitCode): Ditto. (JSC::DeleteBracketNode::emitCode): Ditto. (JSC::DeleteDotNode::emitCode): Ditto. (JSC::PrefixResolveNode::emitCode): Ditto. (JSC::PrefixBracketNode::emitCode): Ditto. (JSC::PrefixDotNode::emitCode): Ditto. (JSC::ThrowableBinaryOpNode::emitCode): Ditto. (JSC::InstanceOfNode::emitCode): Ditto. (JSC::ReadModifyResolveNode::emitCode): Ditto. (JSC::AssignResolveNode::emitCode): Ditto. (JSC::AssignDotNode::emitCode): Ditto. (JSC::ReadModifyDotNode::emitCode): Ditto. (JSC::AssignBracketNode::emitCode): Ditto. (JSC::ReadModifyBracketNode::emitCode): Ditto. (JSC::statementListEmitCode): Take a const StatementVector instead of a non-const one. Also removed unused statementListPushFIFO. (JSC::ForInNode::emitCode): Inline functions instead of member access. (JSC::ThrowNode::emitCode): Ditto. (JSC::EvalNode::emitCode): Ditto. (JSC::FunctionBodyNode::emitCode): Ditto. (JSC::ProgramNode::emitCode): Ditto.

parser/Nodes.h: Removed unused includes and forward declarations. Removed Precedence enum. Made many more members private instead of protected or public. Removed unused NodeStack typedef. Moved the VarStack and FunctionStack typedefs from Node to ScopeNode. Made Node::emitCode pure virtual and changed classes that don't emit any code to inherit from ParserRefCounted rather than Node. Moved isReturnNode from Node to StatementNode. Removed the streamTo, precedence, and needsParensIfLeftmost functions from all classes. Removed the ImmediateNumberNode class and make NumberNode::setValue nonvirtual.

parser/nodes2string.cpp: Removed.

5:19 PM Changeset in webkit [38248] by cwzwarich@webkit.org

3 edits
2 adds in trunk

2008-11-09 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 19541: Null pointer in showModalDialog()
<https://bugs.webkit.org/show_bug.cgi?id=19541>

Add null frame->page() checks to JSDOMWindowBase::canShowModalDialog()
and JSDOMWindowBase::canShowModalDialogNow()C

WebCore:

bindings/js/JSDOMWindowBase.cpp: (WebCore::canShowModalDialog): (WebCore::canShowModalDialogNow):

LayoutTests:

fast/dom/null-page-show-modal-dialog-crash-expected.txt: Added.
fast/dom/null-page-show-modal-dialog-crash.html: Added.

5:04 PM Changeset in webkit [38247] by Darin Adler

6 edits
3 adds in trunk

JavaScriptCore:

2008-11-09 Darin Adler <Darin Adler>

Reviewed by Sam Weinig and Maciej Stachowiak.
Includes some work done by Chris Brichford.

fix https://bugs.webkit.org/show_bug.cgi?id=14886 Stack overflow due to deeply nested parse tree doing repeated string concatentation

Test: fast/js/large-expressions.html

1) Code generation is recursive, so takes stack proportional to the complexity

of the source code expression. Fixed by setting an arbitrary recursion limit
of 10,000 nodes.

2) Destruction of the syntax tree was recursive. Fixed by introducing a

non-recursive mechanism for destroying the tree.

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Initialize depth to 0. (JSC::CodeGenerator::emitThrowExpressionTooDeepException): Added. Emits the code to throw a "too deep" exception.
bytecompiler/CodeGenerator.h: (JSC::CodeGenerator::emitNode): Check depth and emit an exception if we exceed the maximum depth.

parser/Nodes.cpp: (JSC::NodeReleaser::releaseAllNodes): Added. To be called inside node destructors to avoid recursive calls to destructors for nodes inside this one. (JSC::NodeReleaser::release): Added. To be called inside releaseNodes functions. Also added releaseNodes functions and calls to releaseAllNodes inside destructors for each class derived from Node that has RefPtr to other nodes. (JSC::NodeReleaser::adopt): Added. Used by the release function. (JSC::NodeReleaser::adoptFunctionBodyNode): Added.

parser/Nodes.h: Added declarations of releaseNodes and destructors in all classes that needed it. Eliminated use of ListRefPtr and releaseNext, which are the two parts of an older solution to the non-recursive destruction problem that works only for lists, whereas the new solution works for other graphs. Changed ReverseBinaryOpNode to use BinaryOpNode as a base class to avoid some duplicated code.

LayoutTests:

2008-11-09 Alexey Proskuryakov <ap@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters

fast/loader/javascript-url-encoding-2-expected.txt:
fast/loader/javascript-url-encoding-2.html:

4:22 PM Changeset in webkit [38246] by Darin Adler

2 edits in trunk/WebCore

2008-11-09 Darin Adler <Darin Adler>

try to fix Windows build

platform/graphics/Color.cpp: For some reason MSVC doesn't follow the rules about needed a separate definition for static const integer data members. Until I get to the bottom of this, put the definitions inside an ifdef.

12:19 PM Changeset in webkit [38245] by Darin Adler

4 edits in trunk/WebKit/mac

2008-11-09 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

fix https://bugs.webkit.org/show_bug.cgi?id=15063 <rdar://problem/5452227> REGRESSION (r25151): Switching to a tab waiting for first data does not clear the window

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoadCompleted): Added comments, and got rid of a local variable to make this code match the code in the function below more closely. (WebFrameLoaderClient::provisionalLoadStarted): Added comments.

WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Improved comment.

WebView/WebFrameView.mm: (-[WebFrameView _scrollView]): Tweaked formatting. (-[WebFrameView initWithFrame:]): Ditto. (-[WebFrameView setFrameSize:]): Added a comment and tweaked formatting. (-[WebFrameView viewDidMoveToWindow]): Added. This is the change that fixes the bug. Calls setDrawsBackground:YES as appropriate since moving the view out of the window to switch to another view disrupts the special technique for showing the old page during the start of loading. This is the identical reason for the setFrameSize: method above, and the code is almost the same.

11:50 AM Changeset in webkit [38244] by ddkilzer@apple.com

6 edits in trunk/WebCore

BUILD FIX: Qt build broke after r38235.

Added HAVE(ACCESSIBILITY) header guards to platform implementation
source files.

page/gtk/AccessibilityObjectAtk.cpp: Added HAVE(ACCESSIBILITY) guards.
page/gtk/AccessibilityObjectWrapperAtk.cpp: Ditto.
page/qt/AccessibilityObjectQt.cpp: Ditto.
page/win/AccessibilityObjectWin.cpp: Ditto.
page/wx/AccessibilityObjectWx.cpp: Ditto.

11:08 AM Changeset in webkit [38243] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters

Test: fast/loader/javascript-url-encoding-2.html

platform/KURL.cpp: (WebCore::encodeRelativeString): Don't try to break down javascript URLs.

10:20 AM Changeset in webkit [38242] by Darin Adler

2 edits in trunk/WebCore

2008-11-09 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed and tweaked by Darin Adler.

platform/graphics/Color.cpp: Added definitions for the static data members in this class. Static data members need a definition, even when they are the simple integer constant kind that can be initialized in the header.

7:50 AM Changeset in webkit [38241] by Darin Adler

8 edits in trunk/LayoutTests

2008-11-09 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=22142 a few fast/canvas tests use non-standard HTML wrappers but don't need to

fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt: Fixed spelling error: "gradieints".

fast/canvas/gradient-addColorStop-with-invalid-color.html: Regenerated with make-js-test-wrappers script; removes the canvas element that was in here.
fast/canvas/linearGradient-infinite-values.html: Ditto.
fast/canvas/radialGradient-infinite-values.html: Ditto.

fast/canvas/resources/gradient-addColorStop-with-invalid-color.js: Fixed spelling error and changed code to use createElement to make a canvas element rather than using getElementById to find an existing canvas element.
fast/canvas/resources/linearGradient-infinite-values.js: Ditto.
fast/canvas/resources/radialGradient-infinite-values.js: Ditto.

4:56 AM Companies and Organizations that have contributed to WebKit edited by ddkilzer@webkit.org

Added reference to KSVG2 (diff)

2:36 AM Companies and Organizations that have contributed to WebKit edited by staikos@kde.org

(diff)

12:04 AM Companies and Organizations that have contributed to WebKit edited by mjs@apple.com

(diff)

12:02 AM Companies and Organizations that have contributed to WebKit created by mjs@apple.com

Nov 8, 2008:

11:36 PM WikiStart edited by mjs@apple.com

(diff)

8:11 PM Changeset in webkit [38240] by Antti Koivisto

3 edits
4 adds in trunk

WebCore:

2008-11-08 Antti Koivisto <Antti Koivisto>

Reviewed by Sam Weinig.

Fix https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache

Reset text decoder on flush so it does not pass through the BOM when it is reused.

Test: fast/encoding/css-cached-bom.html

loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::flush):

LayoutTests:

2008-11-08 Antti Koivisto <Antti Koivisto>

Reviewed by Sam Weinig.

Test for https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache

fast/encoding/css-cached-bom.html: Added.
fast/encoding/css-cached-bom-expected.txt: Added.
fast/encoding/resources/css-cached-bom-frame.html: Added.
fast/encoding/resources/utf-16-little-endian.css: Added.

7:14 PM Changeset in webkit [38239] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Send URL errors to stderr rather than stdout. While debugging wx DumpRenderTree,
it was causing these errors to end up in the page's text representation.

6:35 PM Changeset in webkit [38238] by kevino@webkit.org

8 edits in trunk

wx build fixes after addition of JSCore parser and bycompiler dirs.

5:09 PM Changeset in webkit [38237] by Simon Fraser

5 edits
4 adds in trunk

2008-11-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=21906

Override addFocusRingRects() in RenderTextControl to avoid
the RenderFlow behavior of recursing on descendent renderers.
RenderTextControl should only ever need a simple focus rect.

This fixes focus ring issues with transforms on text controls.

Test: fast/transforms/transformed-focused-text-input.html

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::addFocusRingRects):
rendering/RenderTextControl.h:

4:33 PM Changeset in webkit [38236] by timothy@apple.com

2 edits in trunk/WebCore

Make sure the icon thumbnail width/height is at least 1px in
the Web Inspector's resource panel.

<rdar://problem/5988888>

Reviewed by Tim Hatcher.

inspector/front-end/inspector.css:

11:42 AM Changeset in webkit [38235] by ddkilzer@apple.com

7 edits in trunk

Bug 22137: PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled

<https://bugs.webkit.org/show_bug.cgi?id=22137>

Reviewed by Darin Adler.

WebCore:

page/AccessibilityObject.h: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): Provide a default implementation when HAVE(ACCESSIBILITY) is false.
page/mac/AXObjectCacheMac.mm: Added HAVE(ACCESSIBILITY) guard.
page/mac/AccessibilityObjectMac.mm: Ditto.
page/mac/AccessibilityObjectWrapper.mm: Ditto.

WebKit/mac:

WebView/WebFrame.mm: (-[WebFrame _accessibilityTree]): Return nil if HAVE(ACCESSIBILITY) is false.

11:12 AM Changeset in webkit [38234] by mitz@apple.com

16 edits in trunk

WebCore:

Reviewed by Darin Adler.

WebCore part of adding WebPreferences for controlling databases and local storage

WebCore.base.exp: Exported Settings::setDatabasesEnabled() and Settings::setLocalStorageEnabled().
page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Changed to return 0 if local storage is disabled in settings. (WebCore::DOMWindow::openDatabase): Changed to return 0 if databases are disabled in settings.
page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_databasesEnabled and m_localStorageEnabled. (WebCore::Settings::setDatabasesEnabled): Added. (WebCore::Settings::setLocalStorageEnabled): Added.
page/Settings.h: (WebCore::Settings::databasesEnabled): Added. (WebCore::Settings::localStorageEnabled): Added.

WebKit/mac:

Reviewed by Darin Adler.

WebKit/mac part of adding WebPreferences for controlling databases and local storage

WebView/WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
WebView/WebPreferences.mm: (+[WebPreferences initialize]): Made databases and local storage enabled by default. (-[WebPreferences databasesEnabled]): Added. (-[WebPreferences setDatabasesEnabled:]): Added. (-[WebPreferences localStorageEnabled]): Added. (-[WebPreferences setLocalStorageEnabled:]): Added.
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Transfer the databases and local storage preferences to WebCore settings.

WebKit/win:

Reviewed by Darin Adler.

WebKit/win part of adding WebPreferences for controlling databases and local storage

Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled, databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Made databases and local storage enabled by default. (WebPreferences::setDatabasesEnabled): Added. (WebPreferences::databasesEnabled): Added. (WebPreferences::setLocalStorageEnabled): Added. (WebPreferences::localStorageEnabled): Added.
WebPreferences.h:
WebView.cpp: (WebView::notifyPreferencesChanged): Transfer the databases and local storage preferences to WebCore settings.

5:57 AM Changeset in webkit [38233] by staikos@webkit.org

1 edit in trunk/WebCore/ChangeLog-2008-08-10

Just adjusting email address in changelog.

Nov 7, 2008:

2:29 PM Changeset in webkit [38232] by alp@webkit.org

8 edits in trunk/WebCore

2008-11-07 Alp Toker <alp@nuanti.com>

Fix build with bleeding edge GTK+ versions. GTK+ and other libraries
now require that only their top-level header file is included.

Patch tested and still builds fine with older GTK+ versions (back to
2.8).

Future WebKit GTK+ contributions are required to adhere to this
policy.

platform/gtk/FileSystemGtk.cpp:
platform/gtk/KeyEventGtk.cpp:
platform/gtk/MouseEventGtk.cpp:
platform/gtk/WheelEventGtk.cpp:
platform/gtk/gtkdrawing.h:
plugins/gtk/gtk2xtbin.c:
plugins/gtk/gtk2xtbin.h:

1:34 PM Changeset in webkit [38231] by andersca@apple.com

2 edits in trunk/WebCore

2008-11-07 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker

Explicitly initialize the NPDrawingModelCoreAnimation.

bridge/npapi.h:

1:15 PM Changeset in webkit [38230] by cwzwarich@webkit.org

3 edits
3 adds in trunk

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21801: REGRESSION (r37821): YUI date formatting JavaScript puts the letter 'd' in place of the day
<https://bugs.webkit.org/show_bug.cgi?id=21801>

Fix the constant register check in the 'typeof' optimization in
CodeGenerator, which was completely broken after r37821.

JavaScriptCore:

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):

LayoutTests:

fast/js/resources/typeof-constant-string.js: Added.
fast/js/typeof-constant-string-expected.txt: Added.
fast/js/typeof-constant-string.html: Added.

12:41 PM Changeset in webkit [38229] by cwzwarich@webkit.org

4 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 22129: Move CTI::isConstant() to CodeBlock
<https://bugs.webkit.org/show_bug.cgi?id=22129>

VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
VM/CTI.h:
VM/CodeBlock.h: (JSC::CodeBlock::isConstant):

11:35 AM Changeset in webkit [38228] by alp@webkit.org

4 edits in trunk

2008-11-07 Alp Toker <alp@nuanti.com>

autotools fix. Always use the configured perl binary (which may be
different to the one in $PATH) when generating sources.

11:17 AM Changeset in webkit [38227] by Simon Fraser

8 edits in trunk/WebCore

2008-11-07 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=22122

Use a stack-based object to simplify the pushLayoutState/popLayoutState
code. LayoutStateMaintainer either pushes in the constructor, or allows
an explicit push() later. Both cases require an explicit pop().

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
rendering/RenderView.h: (WebCore::LayoutStateMaintainer::LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::~LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::pop): (WebCore::LayoutStateMaintainer::push): (WebCore::LayoutStateMaintainer::didPush):

10:07 AM Changeset in webkit [38226] by cwzwarich@webkit.org

4 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Change grammar.cpp to Grammar.cpp and grammar.h to Grammar.h in several
build scripts.

DerivedSources.make:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCoreSources.bkl:

9:48 AM Changeset in webkit [38225] by alp@webkit.org

3 edits in trunk/JavaScriptCore

2008-11-07 Alp Toker <alp@nuanti.com>

More grammar.cpp -> Grammar.cpp build fixes.

AllInOneFile.cpp:
GNUmakefile.am:

7:39 AM Changeset in webkit [38224] by vestbo@webkit.org

2 edits in trunk/WebCore

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Fix the QtWebKit build on Mac

7:01 AM Changeset in webkit [38223] by vestbo@webkit.org

2 edits in trunk/WebCore

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Don't allow Phonon's invisible video widget to keep the app running

6:47 AM Changeset in webkit [38222] by vestbo@webkit.org

3 edits in trunk/WebKit/qt

2008-11-07 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø and Simon Hausmann.

Added an option to allow printing the background color and images.
Mostly reworked from a patch by Holger.
This setting is enabled by default.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
Api/qwebsettings.h:

6:11 AM Changeset in webkit [38221] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-07 Simon Hausmann <Simon Hausmann>

Fix the build on case-sensitive file systems. grammar.y was renamed to
Grammar.y but Lexer.cpp includes grammar.h. The build bots didn't
notice this change because of stale files.

3:32 AM Changeset in webkit [38220] by Simon Hausmann

2 edits in trunk/WebCore

2008-11-07 Henrik Hartz <henrik.hartz@nokia.com>

Reviewed by Simon Hausmann.

Fix valgrind warning about uninitialized lastStop variable.

1:22 AM Changeset in webkit [38219] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Rename the m_nextGlobal, m_nextParameter, and m_nextConstant member
variables of CodeGenerator to m_nextGlobalIndex, m_nextParameterIndex,
and m_nextConstantIndex respectively. This is to distinguish these from
member variables like m_lastConstant, which are actually RefPtrs to
Registers.

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::addGlobalVar): (JSC::CodeGenerator::allocateConstants): (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::addParameter): (JSC::CodeGenerator::addConstant):
bytecompiler/CodeGenerator.h:

1:22 AM Changeset in webkit [38218] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Fix layout test brokenness following r38211.

page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Restore old Shift key behavior. We ignore Shift key state when matching access keys (which matches neither IE nor Firefox), and this patch made WebKit behave like Firefox inadvertently. This may or may not be a good thing, but it's certainly not something that should change by accident.

1:20 AM Applications using WebKit edited by barbarosa100@hotmail.com

Added DVDpedia, Bookpedia, CDpedia and Gamepedia as apps that use WebKit (diff)

12:59 AM Changeset in webkit [38217] by zecke@webkit.org

2 edits in trunk/LayoutTests

2008-11-07 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22039

Enable text only and succeeding fast tests for the gtk port

Enable the tests from the fast directory that succeed. Classify the
remaining tests from the fast directory.

platform/gtk/Skipped:

12:53 AM Changeset in webkit [38216] by zecke@webkit.org

2 edits in trunk/LayoutTests

2008-11-07 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22039

Skip every test on the Gtk+ platform

Add every test directory to the Skipped list in order to create
a baseline for the Gtk+ port.

platform/gtk/Skipped:

Nov 6, 2008:

11:41 PM Changeset in webkit [38215] by cwzwarich@webkit.org

2 edits in trunk

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Move the remaining files in the kjs subdirectory of JavaScriptCore to
a new parser subdirectory, and remove the kjs subdirectory entirely.

JavaScriptCore:

AllInOneFile.cpp:
DerivedSources.make:
GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.vcproj/jsc/jsc.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
VM/CodeBlock.h:
VM/ExceptionHelpers.cpp:
VM/SamplingTool.h:
bytecompiler/CodeGenerator.h:
jsc.pro:
jscore.bkl:
kjs: Removed.
kjs/NodeInfo.h: Removed.
kjs/Parser.cpp: Removed.
kjs/Parser.h: Removed.
kjs/ResultType.h: Removed.
kjs/SourceCode.h: Removed.
kjs/SourceProvider.h: Removed.
kjs/grammar.y: Removed.
kjs/keywords.table: Removed.
kjs/lexer.cpp: Removed.
kjs/lexer.h: Removed.
kjs/nodes.cpp: Removed.
kjs/nodes.h: Removed.
kjs/nodes2string.cpp: Removed.
parser: Added.
parser/Grammar.y: Copied from kjs/grammar.y.
parser/Keywords.table: Copied from kjs/keywords.table.
parser/Lexer.cpp: Copied from kjs/lexer.cpp.
parser/Lexer.h: Copied from kjs/lexer.h.
parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
parser/Nodes.cpp: Copied from kjs/nodes.cpp.
parser/Nodes.h: Copied from kjs/nodes.h.
parser/Parser.cpp: Copied from kjs/Parser.cpp.
parser/Parser.h: Copied from kjs/Parser.h.
parser/ResultType.h: Copied from kjs/ResultType.h.
parser/SourceCode.h: Copied from kjs/SourceCode.h.
parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
pcre/pcre.pri:
pcre/pcre_exec.cpp:
runtime/FunctionConstructor.cpp:
runtime/JSActivation.h:
runtime/JSFunction.h:
runtime/JSGlobalData.cpp:
runtime/JSGlobalObjectFunctions.cpp:
runtime/JSObject.cpp: (JSC::JSObject::toNumber):
runtime/RegExp.cpp:

WebCore:

ForwardingHeaders/kjs: Removed.
ForwardingHeaders/kjs/Parser.h: Removed.
ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
ForwardingHeaders/kjs/SourceCode.h: Removed.
ForwardingHeaders/kjs/SourceProvider.h: Removed.
ForwardingHeaders/parser: Added.
ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
bindings/js/StringSourceProvider.h:
bindings/js/WorkerScriptController.cpp:
bridge/NP_jsobject.cpp:
bridge/jni/jni_jsobject.mm:
bridge/testbindings.pro:
inspector/JavaScriptDebugServer.cpp:

WebKit/mac:

ForwardingHeaders/kjs: Removed.
ForwardingHeaders/kjs/SavedBuiltins.h: Removed.

11:26 PM Changeset in webkit [38214] by Antti Koivisto

2 edits in trunk/WebCore

2008-11-06 Antti Koivisto <Antti Koivisto>

Eh, this trivial last minute change was wrong.

loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText):

11:22 PM Changeset in webkit [38213] by Antti Koivisto

3 edits in trunk/WebCore

2008-11-06 Antti Koivisto <Antti Koivisto>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22093

Delaying the text decoding caused regression since the decoding
also determines the encoding in case of @charset rule.

Decode immediately in data() and keep the decoded string around
during the checkNotify().

loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText): (WebCore::CachedCSSStyleSheet::data):
loader/CachedCSSStyleSheet.h:

9:54 PM Changeset in webkit [38212] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22097
Expose MessageEvent constructor on WorkerContext

bindings/js/JSWorkerContext.cpp: (WebCore::jsWorkerContextMessageEvent): (WebCore::setJSWorkerContextMessageEvent):

9:52 PM Changeset in webkit [38211] by ap@webkit.org

8 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21107
<rdar://problem/6264219> New access key combination conflicts with VoiceOver

page/EventHandler.h:
page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::accessKeyModifiers):
page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::accessKeyModifiers):
page/win/EventHandlerWin.cpp: (WebCore::EventHandler::accessKeyModifiers):
page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::accessKeyModifiers): Access access key modifiers via a function, not a static variable.

page/mac/EventHandlerMac.mm: (WebCore::EventHandler::accessKeyModifiers): Use Ctrl when VoiceOver is enabled, because a conflict with Emacs-style key bindings is less troublesome than one with VO keys.

page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Also fix an access key matching bug introduced in r32424 - Any superset of specified modifier set invoked access keys. We can use simple equality comparison instead because CapsLock is not part of modifiers(), so it doesn't need to be ignored explicitly.

8:04 PM Changeset in webkit [38210] by andersca@apple.com

4 edits in trunk

WebCore:

2008-11-06 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=22115
NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL

Export _NPN_HasMethod and _NPN_HasProperty.

WebCore.NPAPI.exp:

WebKit/mac:

2008-11-06 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=22115
NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL

Initialize the browser funcs correctly.

Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

5:30 PM Changeset in webkit [38209] by barraclough@apple.com

6 edits in trunk/JavaScriptCore

2008-11-06 Gavin Barraclough barraclough@apple.com

Reviewed by Oliver Hunt.

Do not make a cti_* call to perform an op_call unless either:
(1) The codeblock for the function body has not been generated.
(2) The number of arguments passed does not match the callee arity.

~1% progression on sunspider --v8

VM/CTI.cpp: (JSC::CTI::compileOpCallInitializeCallFrame): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileSlowCases):
VM/CTI.h:
VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_op_construct_JSConstruct):
VM/Machine.h:
kjs/nodes.h:

5:11 PM Changeset in webkit [38208] by Simon Fraser

2 edits in trunk/WebCore

2008-11-06 Simon Fraser <Simon Fraser>

Reviewed by Antti Koivisto

https://bugs.webkit.org/show_bug.cgi?id=15678

Fix transformed menu selects to show the popup in the correct
location.

rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::showPopup):

4:55 PM Changeset in webkit [38207] by ddkilzer@apple.com

83 edits in trunk

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

WebCore:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

WebKit/mac:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

WebKitTools:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

4:47 PM Changeset in webkit [38206] by jchaffraix@webkit.org

4 edits in trunk/WebCore

2008-11-06 Julien Chaffraix <jchaffraix@pleyo.com>

Reviewed by Maciej Stachowiak.

Bug 21106: .in format discussed changes
https://bugs.webkit.org/show_bug.cgi?id=21106

Include the namespace into the interfaceName.

dom/make_names.pl: Do not append the namespace when using the interfaceName.
html/HTMLTagNames.in: Added namespace prefix for custom interfaceName.
svg/svgtags.in: Ditto.

4:18 PM Changeset in webkit [38205] by cwzwarich@webkit.org

35 edits
16 copies
2 adds
3 deletes in trunk

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Move the remaining files in the kjs subdirectory of JavaScriptCore to
a new parser subdirectory, and remove the kjs subdirectory entirely.

JavaScriptCore:

AllInOneFile.cpp:
DerivedSources.make:
GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.vcproj/jsc/jsc.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
VM/CodeBlock.h:
VM/ExceptionHelpers.cpp:
VM/SamplingTool.h:
bytecompiler/CodeGenerator.h:
jsc.pro:
jscore.bkl:
kjs: Removed.
kjs/NodeInfo.h: Removed.
kjs/Parser.cpp: Removed.
kjs/Parser.h: Removed.
kjs/ResultType.h: Removed.
kjs/SourceCode.h: Removed.
kjs/SourceProvider.h: Removed.
kjs/grammar.y: Removed.
kjs/keywords.table: Removed.
kjs/lexer.cpp: Removed.
kjs/lexer.h: Removed.
kjs/nodes.cpp: Removed.
kjs/nodes.h: Removed.
kjs/nodes2string.cpp: Removed.
parser: Added.
parser/Grammar.y: Copied from kjs/grammar.y.
parser/Keywords.table: Copied from kjs/keywords.table.
parser/Lexer.cpp: Copied from kjs/lexer.cpp.
parser/Lexer.h: Copied from kjs/lexer.h.
parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
parser/Nodes.cpp: Copied from kjs/nodes.cpp.
parser/Nodes.h: Copied from kjs/nodes.h.
parser/Parser.cpp: Copied from kjs/Parser.cpp.
parser/Parser.h: Copied from kjs/Parser.h.
parser/ResultType.h: Copied from kjs/ResultType.h.
parser/SourceCode.h: Copied from kjs/SourceCode.h.
parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
pcre/pcre.pri:
pcre/pcre_exec.cpp:
runtime/FunctionConstructor.cpp:
runtime/JSActivation.h:
runtime/JSFunction.h:
runtime/JSGlobalData.cpp:
runtime/JSGlobalObjectFunctions.cpp:
runtime/JSObject.cpp: (JSC::JSObject::toNumber):
runtime/RegExp.cpp:

WebCore:

ForwardingHeaders/kjs: Removed.
ForwardingHeaders/kjs/Parser.h: Removed.
ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
ForwardingHeaders/kjs/SourceCode.h: Removed.
ForwardingHeaders/kjs/SourceProvider.h: Removed.
ForwardingHeaders/parser: Added.
ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
bindings/js/StringSourceProvider.h:
bindings/js/WorkerScriptController.cpp:
bridge/NP_jsobject.cpp:
bridge/jni/jni_jsobject.mm:
bridge/testbindings.pro:
inspector/JavaScriptDebugServer.cpp:

WebKit/mac:

ForwardingHeaders/kjs: Removed.
ForwardingHeaders/kjs/SavedBuiltins.h: Removed.

4:17 PM Changeset in webkit [38204] by weinig@apple.com

2 edits in trunk/LayoutTests

2008-11-06 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Fix test that would fail if it had the wrong set of plugins.

plugins/plugin-javascript-access.html:

3:46 PM Changeset in webkit [38203] by ddkilzer@apple.com

83 edits in trunk

BUILD WAS NOT BROKEN: Rolling r38189 back in.

WebCore:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

WebKit/mac:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

WebKitTools:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

3:10 PM Changeset in webkit [38202] by ddkilzer@apple.com

83 edits in trunk

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebCore:

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebKit/mac:

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebKitTools:

BUILD FIX: Backed out r38189 since it apparently broke the world.

2:23 PM Changeset in webkit [38201] by ddkilzer@apple.com

1 edit in trunk/WebCore/loader/FrameLoader.cpp

Fix indentation.

2:16 PM Changeset in webkit [38200] by Chris Fleizach

8 edits
2 adds in trunk

Bug 22112: if a <body> has contenteditable=true, it should report a writable AXValue
https://bugs.webkit.org/show_bug.cgi?id=22112

2:03 PM Changeset in webkit [38199] by Adam Roben

2 edits in trunk/JavaScriptCore

Windows build fix after r38196

JavaScriptCore.vcproj/jsc/jsc.vcproj: Added bytecompiler/ to the include path.

1:55 PM Changeset in webkit [38198] by weinig@apple.com

2 edits in trunk/WebCore

2008-11-06 Sam Weinig <sam@webkit.org>

Reviewed by Alice Liu.

Fix failed assert at launch caused by unintialized data member on the mac.

platform/network/mac/NetworkStateNotifierMac.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):

1:47 PM Changeset in webkit [38197] by sfalken@apple.com

2 edits in trunk/WebCore

2008-11-06 Steve Falkenburg <sfalken@apple.com>

Fix failed assert at launch caused by unintialized data member.

Reviewed by Maciej Stachowiak.

platform/network/win/NetworkStateNotifierWin.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):

1:43 PM Changeset in webkit [38196] by cwzwarich@webkit.org

8 edits
3 moves
1 add in trunk/JavaScriptCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Create a new bytecompiler subdirectory of JavaScriptCore and move some
relevant files to it.

AllInOneFile.cpp:
GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
VM/CodeGenerator.cpp: Removed.
VM/CodeGenerator.h: Removed.
bytecompiler: Added.
bytecompiler/CodeGenerator.cpp: Copied from VM/CodeGenerator.cpp.
bytecompiler/CodeGenerator.h: Copied from VM/CodeGenerator.h.
bytecompiler/LabelScope.h: Copied from kjs/LabelScope.h.
jscore.bkl:
kjs/LabelScope.h: Removed.

1:35 PM Changeset in webkit [38195] by sullivan@apple.com

3 edits in trunk/WebKit/win

2008-11-06 John Sullivan <sullivan@apple.com>

Eliminated one of the two booleans tracking whether zoom was text-only, to avoid future problems.

Reviewed by Adam Roben

WebView.h: removed m_zoomMultiplierIsTextOnly

WebView.cpp: (WebView::WebView): removed initialization of m_zoomMultiplierIsTextOnly (WebView::setZoomMultiplier): use m_page->settings()->setZoomsTextOnly() instead of setting m_zoomMultiplierIsTextOnly (WebView::zoomMultiplier): use m_page->settings()->zoomsTextOnly() instead of reading m_zoomMultiplierIsTextOnly

1:22 PM Changeset in webkit [38194] by sullivan@apple.com

2 edits in trunk/WebKit/mac

2008-11-06 John Sullivan <sullivan@apple.com>

Fixed problem with switching between text-only zoom and full-content zoom

There were two booleans tracking whether zoom was text-only, one in WebCore settings
and one in WebViewPrivate. Fixed by eliminating the one in WebViewPrivate.

Reviewed by Adam Roben

WebView/WebView.mm: remove declaration of zoomMultiplierIsTextOnly instance variable in WebViewPrivate (-[WebViewPrivate init]): removed initialization of zoomMultiplierIsTextOnly (-[WebView textSizeMultiplier]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable (-[WebView _setZoomMultiplier:isTextOnly:]): update WebCore settings rather than WebViewPrivate instance variable (-[WebView _zoomMultiplier:]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable (-[WebView _realZoomMultiplierIsTextOnly]): return value from WebCore settings instead of accessing WebViewPrivate instance variable (-[WebView pageSizeMultiplier]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable

12:55 PM Changeset in webkit [38193] by Simon Fraser

4 edits
2 adds in trunk

2008-11-06 Simon Fraser <Simon Fraser>

Reviewed by Antti Koivisto

https://bugs.webkit.org/show_bug.cgi?id=22109
Make <input type="range"> work correctly with transforms

Test: fast/forms/slider-transformed.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):

Compute a correct local point when the event is retargeted

rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):

Compute m_initialClickPoint in slider-local coords, so that
deltas are computed correctly with transforms

(WebCore::RenderSlider::mouseEventIsInThumb):

Rather than computing an absolute bounds for the thumb,
convert the point to local coords and compare it with the border box.

12:36 PM Changeset in webkit [38192] by Adam Roben

2 edits in trunk/JavaScriptCore

Windows clean build fix after r38155

Rubberstamped by Cameron Zwarich.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update the post-build event for the move of create_hash_table out of kjs/.

12:35 PM Changeset in webkit [38191] by adele@apple.com

6 edits in trunk/WebKit/win

2008-11-06 Adele Peterson <adele@apple.com>

Reviewed by Adam Roben.

Add support for a WebKitZoomsTextOnly preference.

Interfaces/IWebPreferences.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp: (WebPreferences::setZoomsTextOnly): (WebPreferences::zoomsTextOnly):
WebPreferences.h:

WebView.cpp: (WebView::canMakeTextLarger): Consider the zoomsTextOnly setting when computing this. (WebView::makeTextLarger): ditto. (WebView::canMakeTextSmaller): ditto. (WebView::makeTextSmaller): ditto. (WebView::canMakeTextStandardSize): Don't consider the setting in this case since we need to reset both text zoom and page zoom regardless of the setting. (WebView::makeTextStandardSize): (WebView::notifyPreferencesChanged): Set the WebCore settings to match the WebPreference for WebKitZoomsTextOnly.

11:30 AM Changeset in webkit [38190] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22107

Bug uncovered during RVCT port in functions not used. get_lt() and
get_gt() takes only one argument - remove second argument where
applicable.

11:28 AM Changeset in webkit [38189] by ddkilzer@apple.com

83 edits in trunk

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)

WebCore:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

bindings/js/GCController.cpp: (WebCore::gcController): Changed to leak an object to avoid an exit-time destructor.
bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet): Ditto
bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::wrappers): Ditto
bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::wrappers): Ditto
bridge/runtime_root.cpp: (JSC::Bindings::rootObjectSet): Ditto
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removeProperty): Ditto
css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Ditto
css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Ditto
css/CSSStyleSelector.cpp: (WebCore::screenEval): Ditto (WebCore::printEval): Ditto
dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): Ditto (WebCore::isSVG11Feature): Ditto (WebCore::DOMImplementation::isXMLMIMEType): Ditto
dom/Document.cpp: (WebCore::Document::hasPrefixNamespaceMismatch): Ditto
dom/ScriptElement.cpp: (WebCore::isSupportedJavaScriptLanguage): Ditto
editing/ApplyStyleCommand.cpp: (WebCore::styleSpanClassString): Ditto
editing/HTMLInterchange.cpp: (WebCore::): Ditto
editing/IndentOutdentCommand.cpp: (WebCore::indentBlockquoteString): Ditto
editing/ReplaceSelectionCommand.cpp: (WebCore::isInterchangeNewlineNode): Ditto (WebCore::isInterchangeConvertedSpaceSpan): Ditto
editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Ditto (WebCore::nonBreakingSpaceString): Ditto
editing/markup.cpp: (WebCore::appendAttributeValue): Ditto (WebCore::appendEscapedContent): Ditto (WebCore::shouldAddNamespaceAttr): Ditto (WebCore::appendNamespace): Ditto (WebCore::appendStartMarkup): Ditto (WebCore::createMarkup): Ditto
html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::type): Ditto
html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName): Ditto (WebCore::inlineTagList): Ditto (WebCore::blockTagList): Ditto
html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::type): Ditto
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::type): Ditto
html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::type): Ditto
html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::type): Ditto
html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::type): Ditto
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::type): Ditto
html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Ditto (WebCore::HTMLParser::isHeaderTag): Ditto (WebCore::HTMLParser::isResidualStyleTag): Ditto (WebCore::HTMLParser::isAffectedByResidualStyle): Ditto
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::type): Ditto
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::type): Ditto
inspector/InspectorController.cpp: (WebCore::platform): Ditto
inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::shared): Ditto
inspector/JavaScriptProfile.cpp: (WebCore::profileCache): Ditto
inspector/JavaScriptProfileNode.cpp: (WebCore::profileNodeCache): Ditto
loader/FrameLoader.cpp: (WebCore::localSchemes): Ditto
loader/appcache/ApplicationCacheStorage.cpp: (WebCore::cacheStorage): Ditto
loader/archive/ArchiveFactory.cpp: (WebCore::archiveMIMETypes): Ditto
loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Ditto
page/EventHandler.cpp: (WebCore::EventHandler::dragState): Ditto
page/Frame.cpp: (WebCore::createRegExpForLabels): Ditto (WebCore::keepAliveSet): Ditto
page/Page.cpp: (WebCore::Page::groupName): Ditto
page/SecurityOrigin.cpp: (WebCore::isDefaultPortForProtocol): Ditto (WebCore::SecurityOrigin::databaseIdentifier): Ditto
page/mac/FrameMac.mm: (WebCore::regExpForLabels): Ditto
platform/KURL.cpp: (WebCore::blankURL): Ditto
platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName): Ditto
platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getSimilarFontPlatformData): Ditto (WebCore::FontCache::getLastResortFallbackFont): Ditto
platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarTheme::nativeTheme): Ditto
platform/mac/ThemeMac.mm: (WebCore::platformTheme): Ditto
platform/mac/ThreadCheck.mm: (WebCoreReportThreadViolation): Ditto
platform/network/NetworkStateNotifier.cpp: (WebCore::networkStateNotifier): Ditto
platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDataMap): Ditto (WebCore::getStreamResourceHandleMap): Ditto
platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Ditto
platform/text/TextEncoding.cpp: (WebCore::TextEncoding::isJapanese): Ditto
rendering/RenderBlock.cpp: (WebCore::continuationOutlineTable): Ditto
rendering/RenderCounter.cpp: (WebCore::counterMaps): Ditto
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto
rendering/RenderListItem.cpp: (WebCore::RenderListItem::markerText): Ditto
rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::renderScrollbarTheme): Ditto
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::systemFont): Ditto
rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto
rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::initialDashboardRegions): Ditto (WebCore::RenderStyle::noneDashboardRegions): Ditto
storage/LocalStorage.cpp: (WebCore::localStorageMap): Ditto
svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::rotateMode): Ditto
svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calcMode): Ditto (WebCore::SVGAnimationElement::attributeType): Ditto (WebCore::SVGAnimationElement::isAdditive): Ditto (WebCore::SVGAnimationElement::isAccumulated): Ditto
svg/SVGLangSpace.cpp: (WebCore::SVGLangSpace::xmlspace): Ditto
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::contentScriptType): Ditto (WebCore::SVGSVGElement::contentStyleType): Ditto
svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::type): Ditto (WebCore::SVGStyleElement::media): Ditto
svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::parseMappedAttribute): Ditto
svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::parseClockValue): Ditto (WebCore::SVGSMILElement::restart): Ditto (WebCore::SVGSMILElement::fill): Ditto (WebCore::SVGSMILElement::repeatCount): Ditto (WebCore::SVGSMILElement::notifyDependentsIntervalChanged): Ditto
svg/graphics/SVGResource.cpp: (WebCore::clientMap): Ditto
svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::draw): Ditto
xml/XMLHttpRequest.cpp: (WebCore::preflightResultCache): Ditto (WebCore::isSafeRequestHeader): Ditto (WebCore::isOnAccessControlResponseHeaderWhitelist): Ditto
xml/XPathExpressionNode.cpp: (WebCore::XPath::Expression::evaluationContext): Ditto
xml/XPathParser.cpp: (WebCore::XPath::isAxisName): Ditto (WebCore::XPath::isNodeTypeName): Ditto
xml/XPathValue.cpp: (WebCore::XPath::Value::toNodeSet): Ditto

WebKit/mac:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

History/WebBackForwardList.mm: (backForwardLists): Changed to leak an object to avoid an exit-time destructor.
History/WebHistoryItem.mm: (historyItemWrappers): Ditto
Misc/WebStringTruncator.m: (fontFromNSFont): Ditto
Plugins/WebBaseNetscapePluginStream.mm: (streams): Ditto
WebView/WebView.mm: (aeDescFromJSValue): Ditto

WebKitTools:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

Remove .o files from the exclude list that have had their exit-time destructors removed.

Scripts/check-for-exit-time-destructors:

11:04 AM Changeset in webkit [38188] by vestbo@webkit.org

3 edits in trunk/WebCore

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Remove a bunch of unused methods in the Qt media element implementation

10:47 AM Changeset in webkit [38187] by alp@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Cameron Zwarich.

https://bugs.webkit.org/show_bug.cgi?id=22033
[GTK] CTI/Linux r38064 crashes; JIT requires executable memory

Mark pages allocated by the FastMalloc mmap code path executable with
PROT_EXEC. This fixes crashes seen on CPUs and kernels that enforce
non-executable memory (like ExecShield on Fedora Linux) when the JIT
is enabled.

This patch does not resolve the issue on debug builds so affected
developers may still need to pass --disable-jit to configure.

wtf/TCSystemAlloc.cpp: (TryMmap): (TryDevMem): (TCMalloc_SystemRelease):

10:42 AM Changeset in webkit [38186] by Simon Fraser

11 edits
2 adds in trunk

2008-11-05 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=21870

Implement absoluteToLocal() to convert a point from absolute
to local coordinates, optionally taking transforms into account.

Use this to set offsetX/offsetY in mouse events, thus fixing
offsetX/offsetY in events on elements with transforms.

Test: fast/events/offsetX-offsetY.html

10:41 AM Changeset in webkit [38185] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-06 Peter Gal <galpeter@inf.u-szeged.hu>

Reviewed by Cameron Zwarich.

Bug 22099: Make the Qt port build the JSC shell in the correct place
<https://bugs.webkit.org/show_bug.cgi?id=22099>

Adjust include paths and build destination dir for the 'jsc' executable
in the Qt build.

jsc.pro:

10:41 AM Changeset in webkit [38184] by alp@webkit.org

2 edits in trunk/WebCore

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Cameron Zwarich.

https://bugs.webkit.org/show_bug.cgi?id=22067
[GTK] Sun Java plugin segfaults at PluginPackage::createPackage()

null-check symbols loaded from plugin modules, initialize the function
table (like Win already does) and update it with the latest
additions. Adjust whitespace for easy diff'ing with the Win port code
from which it was forked.

This fixes crashes with libnspr4.so and any other plugins that don't
provide the symbols we expect.

plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::load):

10:38 AM Changeset in webkit [38183] by Simon Hausmann

4 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Removed dead (and broken) code from an ancient Symbian port.

10:38 AM Changeset in webkit [38182] by Simon Hausmann

2 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Use QLibrary as PlatformModule when compiling with Qt for S60.

10:38 AM Changeset in webkit [38181] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Implemented the block allocation on Symbian through heap allocation.

Unfortunately there is no way to allocate virtual memory. The Posix
layer provides mmap() but no anonymous mapping. So this is a very slow
solution but it should work as a start.

10:38 AM Changeset in webkit [38180] by Simon Hausmann

2 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Compile fix for Symbian.
The snprintf function is defined in stdio.h, the inclusion
of snprintf.h inside this PLATFORM(SYMBIAN) block does not
compile.

10:36 AM Changeset in webkit [38179] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22047
GTK: Add support for multiple file selection in the file upload control

Implemented with GtkFileChooser.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runOpenPanel):

10:12 AM Changeset in webkit [38178] by Simon Hausmann

1 edit in trunk/JavaScriptCore/runtime/Collector.cpp

Removed misplaced fixme comment that doesn't belong there.
Noticed by Darin

10:03 AM Changeset in webkit [38177] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

Borrow some math functions from the MSVC port to the build with the
RVCT compiler.

10:03 AM Changeset in webkit [38176] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

Include strings.h for strncasecmp().
This is needed for compilation inside Symbian and it is also
confirmed by the man-page on Linux.

9:48 AM Changeset in webkit [38175] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Implemented currentThreadStackBase for Symbian.

9:48 AM Changeset in webkit [38174] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

RVCT does not support tm_gmtoff field, so disable that code just like
for MSVC.

9:47 AM Changeset in webkit [38173] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Use the GCC defines of the WTF_ALIGN* macros for the RVCT and the
MINSCW compiler.

9:42 AM Changeset in webkit [38172] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Define capabilities of the SYMBIAN platform. Some of the system
headers are actually dependent on RVCT.

9:42 AM Changeset in webkit [38171] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Add missing stddef.h header needed for compilation in Symbian.

8:50 AM Changeset in webkit [38170] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Define PLATFORM(UNIX) for S60. Effectively WebKit on S60 is compiled
on top of the Posix layer.

8:50 AM Changeset in webkit [38169] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Added SYMBIAN32 condition for defining PLATFORM(SYMBIAN).

8:39 AM Changeset in webkit [38168] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Added WINSCW compiler define for Symbian S60.

8:39 AM Changeset in webkit [38167] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Added COMPILER(RVCT) to detect the ARM RVCT compiler used in the Symbian environment.

8:38 AM Changeset in webkit [38166] by Simon Hausmann

2 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Disable webkit plugins for Symbian.

4:15 AM Changeset in webkit [38165] by vestbo@webkit.org

2 edits in trunk/WebCore

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Fix build break in debug mode when XSLT is not enabled

4:14 AM Changeset in webkit [38164] by vestbo@webkit.org

2 edits in trunk/WebCore

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Repaint video on UpdateRequest to prevent recursive painting

Calling QWidget::render() to update the video generates a paint
event that's then picked up by the event filter once more :(

We're really only interested in updates from Phonon, which we
get through the UpdateRequest for each new frame.

3:46 AM Changeset in webkit [38163] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2008-11-06 Simon Hausmann <Simon Hausmann>

Fix the Qt build, adjust include paths after move of jsc.pro.

2:21 AM Changeset in webkit [38162] by cwzwarich@webkit.org

6 edits
1 move in trunk/JavaScriptCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move kjs/Shell.cpp to the top level of the JavaScriptCore directory and
rename it to jsc.cpp to reflect the name of the binary compiled from it.

GNUmakefile.am:
JavaScriptCore.vcproj/jsc/jsc.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
jsc.cpp: Copied from kjs/Shell.cpp.
jsc.pro:
jscore.bkl:
kjs/Shell.cpp: Removed.

1:50 AM Changeset in webkit [38161] by Simon Hausmann

2 edits in trunk/WebKit/qt

2008-11-06 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø.

Added a unit tests for QWebFrame::metaData().

1:49 AM Changeset in webkit [38160] by Simon Hausmann

2 edits in trunk/WebKit/qt

2008-11-06 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø.

Improved documentation for QWebFrame::metaData().

1:49 AM Changeset in webkit [38159] by Simon Hausmann

3 edits in trunk/WebKit/qt

2008-11-05 Sriram Yadavalli <sriram.yadavalli@nokia.com>

Reviewed by Simon Hausmann.

Added QWebFrame::metaData() to provide a way in the public API
to retrieve the values of the <meta> tags.

See https://bugs.webkit.org/show_bug.cgi?id=22071

1:22 AM Changeset in webkit [38158] by cwzwarich@webkit.org

3 edits in trunk/WebCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the WebCore build for some platforms by changing build scripts to
account for the recent move of the create_hash_table script from the kjs
subdirectory of JavaScriptCore to the root directory.

WebCore.pro:
make-generated-sources.sh:

12:58 AM Changeset in webkit [38157] by alp@webkit.org

2 edits in trunk

2008-11-06 Alp Toker <alp@nuanti.com>

GTK build fix for r38155. create_hash_table was moved out of kjs/

GNUmakefile.am:

12:55 AM Changeset in webkit [38156] by cwzwarich@webkit.org

2 edits in trunk

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Correct the date on previous ChangeLogs.

ChangeLog:
JavaScriptCore/ChangeLog:

12:53 AM Changeset in webkit [38155] by cwzwarich@webkit.org

7 edits
2 moves in trunk

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move create_hash_table and jsc.pro out of the kjs directory and into the
root directory of JavaScriptCore.

JavaScriptCore:

DerivedSources.make:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
create_hash_table: Copied from kjs/create_hash_table.
jsc.pro: Copied from kjs/jsc.pro.
kjs/create_hash_table: Removed.
kjs/jsc.pro: Removed.
make-generated-sources.sh:

WebKit.pro:

12:18 AM Changeset in webkit [38154] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix a case-sensitivity issue in Mac forwarding headers. Strangely
enough, this does not always cause the build to break, even with a
case-sensitive filesystem.

ForwardingHeaders/runtime/Interpreter.h:

Nov 5, 2008:

11:28 PM Changeset in webkit [38153] by alp@webkit.org

2 edits in trunk/WebKitTools

2008-11-05 Alp Toker <alp@nuanti.com>

GTK build script tweak.

Make the path relative since it will appear in all -I compiler flags.
Long argument lists cause bizarre slowdowns in libtool and result
in huge build logs.

Scripts/webkitdirs.pm:

11:24 PM Changeset in webkit [38152] by cwzwarich@webkit.org

4 edits in trunk/JavaScriptGlue

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the JavaScriptGlue build. This wouldn't show up unless one was
doing a clean build, because changes in JavaScriptCore don't cause
anything in JavaScriptGlue to get rebuilt.

JSRun.cpp:
JSUtils.h:
JavaScriptGlue.cpp:

11:07 PM Changeset in webkit [38151] by ap@webkit.org

5 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=22083
MessageEvents cannot be used across threads

dom/Event.idl:
dom/MessageEvent.idl: Add a NoStaticTables attribute - MessageEvent is used in worker threads, so static tables won't work.

dom/MessagePort.cpp: (WebCore::MessagePort::EventData::EventData): (WebCore::MessagePort::EventData::~EventData): (WebCore::MessagePort::clone): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::startConversation): (WebCore::MessagePort::dispatchMessages):
dom/MessagePort.h: Don't create a MessageEvent until dispatch time - messages can be posted across threads, but MessageEvents are tied to the thread that they were created in.

11:04 PM Changeset in webkit [38150] by ap@webkit.org

6 edits
11 adds in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22066
Implement Worker global object

DerivedSources.make: Added WorkerLocation IDL and JSWorkerContext lookup table.

WebCore.xcodeproj/project.pbxproj: Only adding files to Mac project for now, as Worker support is still disabled by default.

bindings/js/JSDOMGlobalObject.cpp: (WebCore::toJSDOMGlobalObject): Implemented Worker case.

bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Ditto.

bindings/js/JSWorkerContext.cpp: Added.
bindings/js/JSWorkerContext.h: Added.
bindings/js/WorkerScriptController.cpp: Added.
bindings/js/WorkerScriptController.h: Added.
dom/WorkerContext.cpp: Added.
dom/WorkerContext.h: Added. Added an implementation of worker contexts.

dom/DedicatedWorker.cpp: (WebCore::DedicatedWorker::startLoad): Fixed a lifetime bug I saw on my tests. (WebCore::DedicatedWorker::notifyFinished): Create a thread. Currently, object ownership and lifetime is not clear at all.

dom/WorkerLocation.cpp: Added.
dom/WorkerLocation.h: Added.
dom/WorkerLocation.idl: Added. Added WorkerLocation, which is one of the objects available to workers.

dom/WorkerThread.cpp: Added. (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::start): (WebCore::WorkerThread::workerThreadStart): (WebCore::WorkerThread::workerThread):
dom/WorkerThread.h: Added. (WebCore::WorkerThread::create): Run some code in a worker thread (no message loop yet).

8:38 PM Changeset in webkit [38149] by alp@webkit.org

1 edit in trunk/WebKitTools/Scripts/webkitdirs.pm

Attempt to fix the GTK build bot after the latest kjs -> runtime move:
Remove the built products directory completely rather than using distclean.

7:26 PM Changeset in webkit [38148] by barraclough@apple.com

9 edits in trunk

JavaScriptCore:

2008-11-05 Gavin Barraclough <barraclough@apple.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=22094

Fix for bug where the callee incorrectly recieves the caller's lexical
global object as this, rather than its own. Implementation closely
follows the spec, passing jsNull, checking in the callee and replacing
with the global object where necessary.

VM/CTI.cpp: (JSC::CTI::compileOpCall):
VM/Machine.cpp: (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_call_eval):
runtime/JSCell.h: (JSC::JSValue::toThisObject):
runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject):
runtime/JSImmediate.h:

LayoutTests:

2008-11-05 Gavin Barraclough <barraclough@apple.com>

Reviewed by Maciej Stachowiak.

Previosly the test 'cross-site-this' checked that the second level deep method called
across frames recieved the correct this pointer, when no base object is provided.

Test updated so that it check that the code in the child frame, and both the first
and second functions called in the parent frame recieve the correct this values.

fast/frames/cross-site-this.html:
fast/frames/resources/cross-site-this-helper.html:

6:40 PM Changeset in webkit [38147] by Antti Koivisto

3 edits in trunk/WebCore

2008-11-05 Antti Koivisto <Antti Koivisto>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22093
Don't keep decoded stylesheet data in cache

<rdar://problem/6343588>

Don't keep decoded stylesheet string around in the cache. There are no sharing benefits and
performance benefits are negligible (no measured PLT impact). Reduces memory consumption of
style sheet data in cache by 2/3 in common case.

loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText): (WebCore::CachedCSSStyleSheet::data):
loader/CachedCSSStyleSheet.h:

6:02 PM Changeset in webkit [38146] by kevino@webkit.org

2 edits in trunk/JavaScriptCore

wx build fix after Operations.cpp move.

6:00 PM Changeset in webkit [38145] by ddkilzer@apple.com

11 edits in trunk/WebCore

Bug 21596: WebCore::Cache should use parsed Pragma and Cache-Control headers

<https://bugs.webkit.org/show_bug.cgi?id=21596>

Reviewed by Antti.

This patch adds real parsing for Pragma and Cache-Control headers
based on RFC 2616, Sections 2, 14.9 and 14.32. It also adds some
new String and StringImpl methods to assist with the parsing.

loader/Cache.cpp: (WebCore::Cache::dumpStats): Added. Convenience method for dumping stats outside of Safari.
loader/Cache.h: Declared dumpStats().

loader/CachedResource.cpp: (WebCore::CachedResource::mustRevalidate): Updated to use ResourceResponseBase::cacheControlDirectives() instead of substring matching of the entire Cache-Control header.

loader/loader.cpp: (WebCore::Loader::Host::didReceiveResponse): Used the local 'resource' variable instead of 'request->cachedResource()'.

platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::setHTTPHeaderField): Set m_haveParsedCacheControlHeader to false when a "Cache-Control" header is set. Ditto for m_haveParsedPragmaHeader and "Pragma". (WebCore::ResourceResponseBase::parsePragmaDirectives): Added. Provides parsed Pragma header directives. (WebCore::ResourceResponseBase::parseCacheControlDirectives): Added. Provides parsed Cache-Control header directives. (WebCore::isCacheHeaderSeparator): Added. Returns true if a character is a separator character per RFC 2616, Section 2.2, else returns false. (WebCore::isControlCharacter): Added. Returns true if a character is a control character per RFC 2616 Section 2.2, else returns false. (WebCore::trimToNextSeparator): Added. Returns a string truncated at the first separator character per isCacheHeaderSeparator(). (WebCore::parseCacheHeader): Added. This is the main parsing routine for both Cache-Control and Pragma headers. (WebCore::parseCacheControlDirectiveValues): Added. This splits certain Cache-Control directive values into a vector of strings.
platform/network/ResourceResponseBase.h: (WebCore::CacheControlDirectiveMap): Added. Typedef for a parsed Cache-Control header. (WebCore::PragmaDirectiveMap): Added. Typedef for a parsed Pragma header. (WebCore::ResourceResponseBase::parsePragmaDirectives): Added declaration. (WebCore::ResourceResponseBase::parseCacheControlDirectives): Ditto. (WebCore::ResourceResponseBase::m_haveParsedCacheControlHeader): Added. Boolean to describe when the "Cache-Control" header needs to be reparsed. (WebCore::ResourceResponseBase::m_haveParsedPragmaHeader): Added. Boolean to describe when the "Pragma" header needs to be reparsed. (WebCore::ResourceResponseBase::m_cacheControlDirectiveMap): Added. Cached map to hold parsed "Cache-Control" headers. (WebCore::ResourceResponseBase::m_pragmaDirectiveMap): Added. Cached map to hold parsed "Pragma" headers.

platform/text/PlatformString.h: (WebCore::String::find): Added. Returns the first match based on the character-matching function pointer passed in. (WebCore::String::removeCharacters): Added declaration. (WebCore::find): Added. Inline method that takes a character- matching function pointer. Called by StringImpl::find().
platform/text/String.cpp: (WebCore::String::removeCharacters): Added. Calls StringImpl::removeCharacters().
platform/text/StringImpl.cpp: (WebCore::StringImpl::removeCharacters): Added. Returns a string with all characters removed that match the character-matching function pointer passed in. If there is no change to the string, it returns itself. Based heavily on StringImpl::simplifyWhitespace(). (WebCore::StringImpl::find): Added. Calls WebCore::find().
platform/text/StringImpl.h: (WebCore::FindMatchFunctionPtr): Added. Typedef for a character- matching function pointer. (WebCore::StringImpl::removeCharacters): Added declaration. (WebCore::StringImpl::find): Ditto.

5:48 PM Changeset in webkit [38144] by justin.garcia@apple.com

4 edits
2 adds in trunk

WebCore:

2008-11-05 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break

As a rule, we don't allow merges out of blockquotes. In the bug, we are inserting a text node
between two blockquotes. Because the start merge moves the text node into a blockquote, when we
determine whether or not we should do the end merge, it incorrectly appears as though the end merge
is merging out of a blockquote. The fix is to determine whether or not we should do the end merge
before we do the start merge, so that the start merge doesn't effect our decision.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Initialize the new boolean. (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Moved code from doApply() here for clarity. (WebCore::ReplaceSelectionCommand::doApply): Set m_shouldMergeEnd before we do the start merge.
editing/ReplaceSelectionCommand.h: Added m_shouldMergeEnd.

LayoutTests:

2008-11-05 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break

editing/pasteboard/5480736-expected.txt: Added.
editing/pasteboard/5480736.html: Added.

5:08 PM Changeset in webkit [38143] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-11-05 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Keep track of which plug-in host architecture would be needed for a given plug-in package.

Plugins/WebNetscapePluginPackage.h:
Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]):
WebKitPrefix.h:

4:41 PM Changeset in webkit [38142] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Speculatively fix the Windows build, even though these changes may not
actually matter for anything in the build, because the Windows bots are
behind.

WebCore.vcproj/WebCore.vcproj:

4:30 PM Changeset in webkit [38141] by cwzwarich@webkit.org

3 edits in trunk/WebCore

2008-11-05 Cameron <zwarich@apple.com>

Not reviewed.

Fix the Qt build.

bridge/qt/qt_class.cpp:
bridge/qt/qt_runtime.h:

4:00 PM Changeset in webkit [38140] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the build for case-sensitive build systems and wxWindows.

JavaScriptCoreSources.bkl:
kjs/create_hash_table:

3:48 PM Changeset in webkit [38139] by cwzwarich@webkit.org

5 edits in trunk/JavaScriptCore

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the build for case-sensitive build systems.

JavaScriptCoreSources.bkl:
kjs/Shell.cpp:
runtime/Interpreter.cpp:
runtime/JSArray.cpp:

3:37 PM Changeset in webkit [38138] by cwzwarich@webkit.org

14 edits in trunk/JavaScriptCore

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the build for case-sensitive build systems.

API/JSBase.cpp:
API/JSObjectRef.cpp:
runtime/CommonIdentifiers.h:
runtime/Identifier.cpp:
runtime/InitializeThreading.cpp:
runtime/InternalFunction.h:
runtime/JSString.h:
runtime/Lookup.h:
runtime/PropertyNameArray.h:
runtime/PropertySlot.h:
runtime/StructureID.cpp:
runtime/StructureID.h:
runtime/UString.cpp:

3:21 PM Changeset in webkit [38137] by cwzwarich@webkit.org

95 edits
26 moves
5 deletes in trunk

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move more files to the runtime subdirectory of JavaScriptCore.

JavaScriptCore:

API/APICast.h:
API/JSBase.cpp:
API/JSCallbackObject.cpp:
API/JSClassRef.cpp:
API/JSClassRef.h:
API/JSStringRefCF.cpp:
API/JSValueRef.cpp:
API/OpaqueJSString.cpp:
API/OpaqueJSString.h:
AllInOneFile.cpp:
GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
VM/CodeBlock.h:
VM/CodeGenerator.cpp:
VM/Machine.cpp:
VM/RegisterFile.h:
debugger/Debugger.h:
kjs/SourceProvider.h:
kjs/TypeInfo.h: Removed.
kjs/collector.cpp: Removed.
kjs/collector.h: Removed.
kjs/completion.h: Removed.
kjs/create_hash_table:
kjs/identifier.cpp: Removed.
kjs/identifier.h: Removed.
kjs/interpreter.cpp: Removed.
kjs/interpreter.h: Removed.
kjs/lexer.cpp:
kjs/lexer.h:
kjs/lookup.cpp: Removed.
kjs/lookup.h: Removed.
kjs/nodes.cpp:
kjs/nodes.h:
kjs/operations.cpp: Removed.
kjs/operations.h: Removed.
kjs/protect.h: Removed.
kjs/regexp.cpp: Removed.
kjs/regexp.h: Removed.
kjs/ustring.cpp: Removed.
kjs/ustring.h: Removed.
pcre/pcre_exec.cpp:
profiler/CallIdentifier.h:
profiler/Profile.h:
runtime/ArrayConstructor.cpp:
runtime/ArrayPrototype.cpp:
runtime/ArrayPrototype.h:
runtime/Collector.cpp: Copied from kjs/collector.cpp.
runtime/Collector.h: Copied from kjs/collector.h.
runtime/CollectorHeapIterator.h:
runtime/Completion.h: Copied from kjs/completion.h.
runtime/ErrorPrototype.cpp:
runtime/Identifier.cpp: Copied from kjs/identifier.cpp.
runtime/Identifier.h: Copied from kjs/identifier.h.
runtime/InitializeThreading.cpp:
runtime/Interpreter.cpp: Copied from kjs/interpreter.cpp.
runtime/Interpreter.h: Copied from kjs/interpreter.h.
runtime/JSCell.h:
runtime/JSGlobalData.cpp:
runtime/JSGlobalData.h:
runtime/JSLock.cpp:
runtime/JSNumberCell.cpp:
runtime/JSNumberCell.h:
runtime/JSObject.cpp:
runtime/JSValue.h:
runtime/Lookup.cpp: Copied from kjs/lookup.cpp.
runtime/Lookup.h: Copied from kjs/lookup.h.
runtime/MathObject.cpp:
runtime/NativeErrorPrototype.cpp:
runtime/NumberPrototype.cpp:
runtime/Operations.cpp: Copied from kjs/operations.cpp.
runtime/Operations.h: Copied from kjs/operations.h.
runtime/PropertyMapHashTable.h:
runtime/Protect.h: Copied from kjs/protect.h.
runtime/RegExp.cpp: Copied from kjs/regexp.cpp.
runtime/RegExp.h: Copied from kjs/regexp.h.
runtime/RegExpConstructor.cpp:
runtime/RegExpObject.h:
runtime/RegExpPrototype.cpp:
runtime/SmallStrings.h:
runtime/StringObjectThatMasqueradesAsUndefined.h:
runtime/StructureID.cpp:
runtime/StructureID.h:
runtime/StructureIDTransitionTable.h:
runtime/SymbolTable.h:
runtime/TypeInfo.h: Copied from kjs/TypeInfo.h.
runtime/UString.cpp: Copied from kjs/ustring.cpp.
runtime/UString.h: Copied from kjs/ustring.h.
wrec/CharacterClassConstructor.h:
wrec/WREC.h:

WebCore:

ForwardingHeaders/kjs/collector.h: Removed.
ForwardingHeaders/kjs/completion.h: Removed.
ForwardingHeaders/kjs/identifier.h: Removed.
ForwardingHeaders/kjs/interpreter.h: Removed.
ForwardingHeaders/kjs/lookup.h: Removed.
ForwardingHeaders/kjs/operations.h: Removed.
ForwardingHeaders/kjs/protect.h: Removed.
ForwardingHeaders/kjs/ustring.h: Removed.
ForwardingHeaders/runtime/Collector.h: Copied from ForwardingHeaders/kjs/collector.h.
ForwardingHeaders/runtime/Completion.h: Copied from ForwardingHeaders/kjs/completion.h.
ForwardingHeaders/runtime/Identifier.h: Copied from ForwardingHeaders/kjs/identifier.h.
ForwardingHeaders/runtime/Interpreter.h: Copied from ForwardingHeaders/kjs/interpreter.h.
ForwardingHeaders/runtime/Lookup.h: Copied from ForwardingHeaders/kjs/lookup.h.
ForwardingHeaders/runtime/Operations.h: Copied from ForwardingHeaders/kjs/operations.h.
ForwardingHeaders/runtime/Protect.h: Copied from ForwardingHeaders/kjs/protect.h.
ForwardingHeaders/runtime/UString.h: Copied from ForwardingHeaders/kjs/ustring.h.
bindings/js/GCController.cpp:
bindings/js/JSCustomPositionCallback.h:
bindings/js/JSCustomPositionErrorCallback.h:
bindings/js/JSCustomSQLStatementCallback.h:
bindings/js/JSCustomSQLStatementErrorCallback.h:
bindings/js/JSCustomSQLTransactionErrorCallback.h:
bindings/js/JSCustomVoidCallback.h:
bindings/js/JSDOMBinding.h:
bindings/js/JSDOMWindowBase.h:
bindings/js/JSEventListener.h:
bindings/js/ScheduledAction.h:
bindings/js/ScriptController.cpp:
bindings/js/ScriptController.h:
bindings/objc/WebScriptObject.mm:
bindings/scripts/CodeGeneratorJS.pm:
bridge/NP_jsobject.cpp:
bridge/c/c_class.cpp:
bridge/jni/jni_class.cpp:
bridge/jni/jni_jsobject.mm:
bridge/npruntime.cpp:
bridge/runtime_root.h:
history/CachedPage.h:
html/CanvasRenderingContext2D.cpp:
html/HTMLCanvasElement.cpp:
inspector/InspectorController.cpp:
inspector/JavaScriptCallFrame.cpp:
page/Console.cpp:
page/Page.cpp:
platform/text/AtomicString.cpp:
platform/text/PlatformString.h:

WebKit/mac:

ForwardingHeaders/kjs/collector.h: Removed.
ForwardingHeaders/kjs/identifier.h: Removed.
ForwardingHeaders/kjs/interpreter.h: Removed.
ForwardingHeaders/kjs/lookup.h: Removed.
ForwardingHeaders/kjs/operations.h: Removed.
ForwardingHeaders/kjs/protect.h: Removed.
ForwardingHeaders/runtime/Interpreter.h: Copied from ForwardingHeaders/kjs/interpreter.h.
WebView/WebScriptDebugDelegate.mm:

WebKit/wx:

WebFrame.cpp:
WebView.cpp:

3:19 PM Changeset in webkit [38136] by andersca@apple.com

2 edits in trunk/WebKitTools

2008-11-05 Anders Carlsson <andersca@apple.com>

Fix 64-bit build.

DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):

12:51 PM Changeset in webkit [38135] by mitz@apple.com

2 edits in trunk/WebKit/win

Reviewed by John Sullivan.

make the {protocol,proxyType} argument of WebURLProtectionSpace::initWith{Proxy}Host actually work and fix assertion failures.

WebURLProtectionSpace.cpp: (WebURLProtectionSpace::initWithHost): The BString comparisons were applying the BString==BSTR operator to a right hand side that was actually a WCHAR string. Fixed by using BStrings on both sides. (WebURLProtectionSpace::initWithProxyHost): Ditto.

12:03 PM Changeset in webkit [38134] by weinig@apple.com

9 edits in trunk

WebCore:

2008-11-05 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Fix https://bugs.webkit.org/show_bug.cgi?id=22085
The Plugin JS object should expose item() and namedItem() methods to match Firefox

bindings/js/JSPluginCustom.cpp: (WebCore::JSPlugin::nameGetter):
plugins/Plugin.cpp: (WebCore::Plugin::namedItem):
plugins/Plugin.h:
plugins/Plugin.idl:

LayoutTests:

2008-11-05 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Update tests for https://bugs.webkit.org/show_bug.cgi?id=22085
The Plugin JS object should expose item() and namedItem() methods to match Firefox

fast/dom/Window/window-properties-expected.txt:
plugins/plugin-javascript-access-expected.txt:
plugins/plugin-javascript-access.html:

11:51 AM Changeset in webkit [38133] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2008-11-05 Geoffrey Garen <ggaren@apple.com>

Suggested by Darin Adler.

Removed two copy constructors that the compiler can generate for us
automatically.

VM/LabelID.h: (JSC::LabelID::setLocation): (JSC::LabelID::offsetFrom): (JSC::LabelID::ref): (JSC::LabelID::refCount):
kjs/LabelScope.h:

11:19 AM Changeset in webkit [38132] by ap@webkit.org

4 edits
2 adds in trunk

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=21060
Range#surroundContents incorrectly throws BAD_BOUNDARYPOINTS_ERR

Test: fast/dom/Range/surroundContents-check-boundary-points.html

dom/Range.cpp: (WebCore::Range::surroundContents): Fix BAD_BOUNDARYPOINTS_ERR checks.

10:42 AM Changeset in webkit [38131] by andersca@apple.com

2 edits in trunk/WebCore

2008-11-05 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Remove two global destructors from CoreTextController.

platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::collectCoreTextRunsForCharacters):

10:41 AM Changeset in webkit [38130] by darin@chromium.org

2 edits in trunk/WebCore

2008-11-05 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

CRASH at Scrollbar::invalidateRect due to null m_client
https://bugs.webkit.org/show_bug.cgi?id=22080

platform/Scrollbar.cpp: (WebCore::Scrollbar::isWindowActive): (WebCore::Scrollbar::invalidateRect):

10:30 AM Changeset in webkit [38129] by weinig@apple.com

17 edits in trunk

WebCore:

2008-11-04 Sam Weinig <sam@webkit.org>

Reviewed by Simon Hausmann.

Fix https://bugs.webkit.org/show_bug.cgi?id=21648
navigator.mimeTypes and navigator.plugins don't expose item and namedItem to JS

Also adds constructors for Plugin, PluginArray, MimeType and MimeTypeArray.

bindings/js/JSMimeTypeArrayCustom.cpp: (WebCore::JSMimeTypeArray::nameGetter):
bindings/js/JSPluginArrayCustom.cpp: (WebCore::JSPluginArray::nameGetter):
page/DOMWindow.idl:
plugins/MimeType.idl:
plugins/MimeTypeArray.cpp: (WebCore::MimeTypeArray::namedItem):
plugins/MimeTypeArray.h:
plugins/MimeTypeArray.idl:
plugins/Plugin.idl:
plugins/PluginArray.cpp: (WebCore::PluginArray::namedItem):
plugins/PluginArray.h:
plugins/PluginArray.idl:

LayoutTests:

2008-11-04 Sam Weinig <sam@webkit.org>

Reviewed by Simon Hausmann.

Update tests for https://bugs.webkit.org/show_bug.cgi?id=21648
navigator.mimeTypes and navigator.plugins don't expose item and namedItem to JS

fast/dom/Window/window-properties-expected.txt:
fast/js/global-constructors-expected.txt:
plugins/plugin-javascript-access-expected.txt:
plugins/plugin-javascript-access.html:

10:24 AM Changeset in webkit [38128] by andersca@apple.com

2 edits in trunk/JavaScriptCore

2008-11-05 Anders Carlsson <andersca@apple.com>

Fix Snow Leopard build.

JavaScriptCore.xcodeproj/project.pbxproj:

10:23 AM Changeset in webkit [38127] by sfalken@apple.com

2 edits in trunk/WebCore

2008-11-05 Steve Falkenburg <sfalken@apple.com>

Build fix.

plugins/PluginPackage.cpp:

10:22 AM Changeset in webkit [38126] by andersca@apple.com

4 edits
1 delete in trunk/WebKit

WebKit:

2008-11-05 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Remove WebPlugInStreamLoaderDelegate.h

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-05 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Remove WebPlugInStreamLoaderDelegate.h

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebPlugInStreamLoaderDelegate.h: Removed.

7:31 AM Changeset in webkit [38125] by Simon Hausmann

2 edits in trunk/WebCore

2008-11-05 Jeff Cook <cookiecaper@gmail.com>

Reviewed by Simon Hausmann and Tor Arne.

Fix crash in the Qt port when unloading swfdec and Flash 10
by reordering window destruction and plugin stop.

See https://bugs.webkit.org/show_bug.cgi?id=20779

7:31 AM Changeset in webkit [38124] by Simon Hausmann

4 edits in trunk/WebCore

2008-11-05 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø

Fix loading of Flash 10 in the Qt port by faking the toolkit to be Gtk.

Otherwise Flash refuses to load and function :(

7:31 AM Changeset in webkit [38123] by Simon Hausmann

5 edits in trunk/WebCore

2008-11-05 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø

Unify determineQuirks between the Qt and the Gtk PluginPackage.
Share the code for parsing the module version from the description.
This is currently used to determine Flash based quirks.

1:25 AM Changeset in webkit [38122] by mitz@apple.com

2687 edits
2 adds in trunk/LayoutTests

2008-11-05 Pierre-Olivier Latour <pol@apple.com>

Rubber-stamped by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21821

Another set of updated expected pixel results generated with the same
setup. Includes accessiblity/, animations/, css1/, css2.1/, css3/,
dom/ and editing/.

(file listing elided)

1:07 AM Changeset in webkit [38121] by mitz@apple.com

3868 edits
18 adds in trunk/LayoutTests

2008-11-05 Pierre-Olivier Latour <pol@apple.com>

Rubber-stamped by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21821

Imported more image bases for a representative set of pixel tests in order to
fully validate latest DRT and test script changes. These results were generated
by a release build of r38003 on an Intel iMac running Mac OS X 10.5.5 with
QuickTime 7.5.5.

(file listing elided)

12:45 AM Changeset in webkit [38120] by mitz@apple.com

2 edits in trunk/WebKit/mac

Tiger build fix

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stop]):

Nov 4, 2008:

5:44 PM Changeset in webkit [38119] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-11-04 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Don't leak the CALayer.

Plugins/WebBaseNetscapePluginView.h: Make the layer a RetainPtr.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView start]):

(-[WebBaseNetscapePluginView stop]):
Make sure to clear out the layer here.

4:58 PM Changeset in webkit [38118] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Steve Falkenburg.

Move dtoa.cpp and dtoa.h to the WTF Visual Studio project to reflect
their movement in the filesystem.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/WTF/WTF.vcproj:

4:49 PM Changeset in webkit [38117] by cwzwarich@webkit.org

12 edits
3 moves
1 delete in trunk

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move kjs/dtoa.h to the wtf subdirectory of JavaScriptCore, and remove
its unused forwarding header in WebKit/mac.

JavaScriptCore:

AllInOneFile.cpp:
GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
kjs/dtoa.cpp: Removed.
kjs/dtoa.h: Removed.
wtf/dtoa.cpp: Copied from kjs/dtoa.cpp.
wtf/dtoa.h: Copied from kjs/dtoa.h.

WebCore:

ForwardingHeaders/kjs/dtoa.h: Removed.
ForwardingHeaders/wtf/dtoa.h: Copied from ForwardingHeaders/kjs/dtoa.h.
css/CSSParser.cpp:
platform/text/String.cpp:
platform/text/StringImpl.cpp:

WebKit/mac:

ForwardingHeaders/kjs/dtoa.h: Removed.

4:45 PM Changeset in webkit [38116] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-11-04 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

More cleanup. Make a bunch of instance variables RetainPtrs.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView restartTimers]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView handleMouseMoved:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView scrollWheel:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView flagsChanged:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView didStart]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView pluginPackage]): (-[WebBaseNetscapePluginView setPluginPackage:]): (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]): (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView fini]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView userAgent]): (-[WebBaseNetscapePluginView getVariable:value:]): (-[WebBaseNetscapePluginView setVariable:value:]): (-[WebBaseNetscapePluginView _createPlugin]): (-[WebBaseNetscapePluginView _redeliverStream]):

4:24 PM Changeset in webkit [38115] by pam@chromium.org

5 edits
4 adds in trunk

2008-11-04 Jonathan Haas <myrdred@gmail.com>

Addiitonal tweaks and patch prep by Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Fixed an issue which could cause memory corruption using ToT libxml.
See https://bugs.webkit.org/show_bug.cgi?id=15715

Test: fast/xsl/xslt-nested-stylesheets.xml

xml/XSLImportRule.cpp: (WebCore::XSLImportRule::setXSLStyleSheet): Set parent rather than owner document
xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet): Initialize m_parentStyleSheet (WebCore::XSLStyleSheet::parseString): Make all child stylesheets use parent's dictionary (WebCore::XSLStyleSheet::setParentStyleSheet): Added
xml/XSLStyleSheet.h: Added m_parentStyleSheet member

2008-11-04 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Added test for crash resulting from nested stylesheets using certain
builds of libxml2. See https://bugs.webkit.org/show_bug.cgi?id=15715 .

fast/xsl/resources/xslt-nested-stylesheets0.xsl: Added.
fast/xsl/resources/xslt-nested-stylesheets1.xsl: Added.
fast/xsl/xslt-nested-stylesheets-expected.txt: Added.
fast/xsl/xslt-nested-stylesheets.xml: Added.

3:44 PM Changeset in webkit [38114] by cwzwarich@webkit.org

4 edits
1 move in trunk/JavaScriptCore

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move kjs/config.h to the top level of JavaScriptCore.

GNUmakefile.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
config.h: Copied from kjs/config.h.
kjs/config.h: Removed.

3:00 PM Changeset in webkit [38113] by Simon Fraser

2 edits in trunk/WebKitTools

2008-11-04 Simon Fraser <Simon Fraser>

Add AccessibilityObject.o to the exclude list for the
check for global destructors.

Scripts/check-for-exit-time-destructors:

2:40 PM Changeset in webkit [38112] by Simon Fraser

2 edits in trunk/WebCore

2008-11-04 Simon Fraser <Simon Fraser>

No review.

Improved buid fix: include MathExtras.h to get roundf on all platforms.

platform/graphics/FloatPoint.h:

2:08 PM Changeset in webkit [38111] by Darin Adler

2 edits in trunk/WebKitTools

2008-11-04 Darin Adler <Darin Adler>

Scripts/check-for-exit-time-destructors: Fix failures seen on the bot, but for some reason not on my computer.

12:55 PM Changeset in webkit [38110] by beidson@apple.com

10 edits in trunk

WebCore:

2008-11-04 Brady Eidson <beidson@apple.com>

Reviewed by John Sullivan

Add a simple "visited" method to HistoryItem for use by global history

WebCore.base.exp:

history/HistoryItem.cpp: (WebCore::HistoryItem::visited): Update the title on the item, set last visited time, and bump the visit count. All things that should happen when a url is visited again!
history/HistoryItem.h:

WebKit/mac:

2008-11-04 Brady Eidson <beidson@apple.com>

Reviewed by John Sullivan

Cleanup global history a tad.

Used to _addItemForURL always create a new item and merge it with a previous item if one existed.

It is more efficient and less complicated to update the previous item if one exists.

History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:]): (-[WebHistory _visitedURL:withTitle:]): Instead of calling the general purpose [WebHistoryPrivate addItem:] with a new history item, call the new special purposed visitedURL:withTitle:
History/WebHistoryInternal.h:

History/WebHistoryItem.mm: (-[WebHistoryItem _visitedWithTitle:]): Call "visited()" on the WebCore history item with the pertinent info.
History/WebHistoryItemInternal.h:

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory):

12:08 PM Changeset in webkit [38109] by andersca@apple.com

2 edits in trunk/WebKit/mac

2008-11-04 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=22065

Only create the plug-in stream loader when the stream is started.

Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::start):

11:43 AM Changeset in webkit [38108] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2008-11-04 Jan Michael Alonzo <jmalonzo@webkit.org>

Build fix. Not reviewed.

platform/graphics/FloatPoint.h: include math.h. reported by zdobersek in #webkit.

11:40 AM Changeset in webkit [38107] by darin@chromium.org

2 edits in trunk/WebCore

2008-11-04 Darin Fisher <darin@chromium.org>

Reviewed by Anders Carlsson.

No need to clobber all ResourceRequest fields in FrameLoader::reload()
https://bugs.webkit.org/show_bug.cgi?id=21949

loader/FrameLoader.cpp: (WebCore::FrameLoader::reload):

11:00 AM Changeset in webkit [38106] by Darin Adler

2 edits in trunk/WebCore

2008-11-04 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

storage/Database.cpp: (WebCore::databaseVersionKey): Tweaked formatting.

10:59 AM Changeset in webkit [38105] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-11-04 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

wtf/ThreadingNone.cpp: Tweak formatting.

10:58 AM Changeset in webkit [38104] by Darin Adler

8 edits in trunk/WebCore

2008-11-03 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=22061 create script to check for exit-time destructors

WebCore.xcodeproj/project.pbxproj: Added a script phase that runs the check-for-exit-time-destructors script.

html/HTMLAttributeNames.in: Removed some unused attribute names.

html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed code that sets the write-only m_pluginPage.
html/HTMLEmbedElement.h: Ditto.

platform/mac/CursorMac.mm: (WebCore::leakNamedCursor): Changed to return a Cursor&. (WebCore::pointerCursor): Changed to leak an object to avoid an exit-time destructor. (WebCore::crossCursor): Ditto. (WebCore::handCursor): Ditto. (WebCore::moveCursor): Ditto. (WebCore::verticalTextCursor): Ditto. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto. (WebCore::aliasCursor): Ditto. (WebCore::zoomInCursor): Ditto. (WebCore::zoomOutCursor): Ditto. (WebCore::copyCursor): Ditto. (WebCore::noneCursor): Ditto. (WebCore::progressCursor): Ditto. (WebCore::noDropCursor): Ditto. (WebCore::notAllowedCursor): Ditto. (WebCore::iBeamCursor): Ditto. (WebCore::waitCursor): Ditto. (WebCore::helpCursor): Ditto. (WebCore::eastResizeCursor): Ditto. (WebCore::northResizeCursor): Ditto. (WebCore::northEastResizeCursor): Ditto. (WebCore::northWestResizeCursor): Ditto. (WebCore::southResizeCursor): Ditto. (WebCore::southEastResizeCursor): Ditto. (WebCore::southWestResizeCursor): Ditto. (WebCore::westResizeCursor): Ditto. (WebCore::northSouthResizeCursor): Ditto. (WebCore::eastWestResizeCursor): Ditto. (WebCore::northEastSouthWestResizeCursor): Ditto. (WebCore::northWestSouthEastResizeCursor): Ditto. (WebCore::columnResizeCursor): Ditto. (WebCore::rowResizeCursor): Ditto. (WebCore::grabCursor): Ditto. (WebCore::grabbingCursor): Ditto.

storage/Database.cpp: (WebCore::guidMutex): Changed to leak an object to avoid an exit-time destructor. Also added a comment explaining why it's thread safe. (WebCore::guidToVersionMap): Ditto. (WebCore::guidToDatabaseMap): Ditto. (WebCore::Database::databaseInfoTableName): Ditto. (WebCore::databaseVersionKey): Ditto. (WebCore::Database::getVersionFromDatabase): Ditto. (WebCore::Database::setVersionInDatabase): Ditto. (WebCore::guidForOriginAndName): Ditto.
storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::tracker): Ditto. (WebCore::notificationMutex): Ditto. (WebCore::notificationQueue): Ditto. (WebCore::DatabaseTracker::notifyDatabasesChanged): Ditto.

10:57 AM Changeset in webkit [38103] by mitz@apple.com

1 edit
544 deletes in trunk/LayoutTests

2008-11-04 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

part of https://bugs.webkit.org/show_bug.cgi?id=21821 Removed pixel results in platform/mac-tiger that were only slightly different (within 1% tolerance) from the platform/mac results. Removed results in platform/mac-tiger where the results in platform/mac were also correct for Tiger.

(file listing elided)

10:57 AM Changeset in webkit [38102] by Darin Adler

2 edits in trunk/WebKit

2008-11-03 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=22061 create script to check for exit-time destructors

WebKit.xcodeproj/project.pbxproj: Added a script phase that runs the check-for-exit-time-destructors script.

10:57 AM Changeset in webkit [38101] by Darin Adler

11 edits in trunk/JavaScriptCore

2008-11-03 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=22061 create script to check for exit-time destructors

JavaScriptCore.exp: Changed to export functions rather than a global for the atomically initialized static mutex.

JavaScriptCore.xcodeproj/project.pbxproj: Added a script phase that runs the check-for-exit-time-destructors script.

wtf/MainThread.cpp: (WTF::mainThreadFunctionQueueMutex): Changed to leak an object rather than using an exit time destructor. (WTF::functionQueue): Ditto.
wtf/unicode/icu/CollatorICU.cpp: (WTF::cachedCollatorMutex): Ditto.

wtf/Threading.h: Changed other platforms to share the Windows approach where the mutex is internal and the functions are exported.
wtf/ThreadingGtk.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Ditto. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
wtf/ThreadingNone.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Ditto. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
wtf/ThreadingPthreads.cpp: (WTF::threadMapMutex): Changed to leak an object rather than using an exit time destructor. (WTF::lockAtomicallyInitializedStaticMutex): Mutex change. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto. (WTF::threadMap): Changed to leak an object rather than using an exit time destructor.
wtf/ThreadingQt.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Mutex change. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
wtf/ThreadingWin.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Added an assertion.

10:56 AM Changeset in webkit [38100] by Darin Adler

2 edits
1 copy in trunk/WebKitTools

2008-11-03 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=22061 create script to check for exit-time destructors

Scripts/check-for-exit-time-destructors: Added. Started as a copy of check-for-global-initializers.

Scripts/check-for-global-initializers: Added code to make this script rerun any time it's modified, and also to properly run again after the first time it reports an error.

10:55 AM Changeset in webkit [38099] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-11-04 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=22065

Remove some old, unused plug-in code.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView setVariable:value:]):

10:54 AM Changeset in webkit [38098] by Simon Fraser

43 edits in trunk

2008-11-04 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=21941

Rename absolutePosition() to localToAbsolute(), and add the ability
to optionally take transforms into account (which will eventually be the
default behavior).

8:22 AM Changeset in webkit [38097] by Simon Hausmann

9 edits in trunk

WebCore:

2008-11-03 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Add methods for getting and setting user data on History Item.
This change is limited to QT port only. Tests were added in
the patch for https://bugs.webkit.org/show_bug.cgi?id=21864.

Minor change by Simon: made the functions inline and added a missing
const.

WebKit/qt:

2008-10-24 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Add userData() and setUserData() to QWebHistoryItem.
Add setMaximumItemCount() and maximumItemCount() to QWebHistory.
Add currentItemIndex() to QWebHistory.

See also https://bugs.webkit.org/show_bug.cgi?id=21864

Small cleanup by Simon (docs and forward declaration of QWebHistoryItem in qwebframe.h)

6:15 AM Changeset in webkit [38096] by Adam Roben

2 edits in trunk/JavaScriptCore

Windows build fix

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update the location of JSStaticScopeObject.{cpp,h}.

4:49 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com

update (diff)

2:59 AM Changeset in webkit [38095] by cwzwarich@webkit.org

3 edits
1 move in trunk/JavaScriptCore

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Move AllInOneFile.cpp to the top level of JavaScriptCore.

AllInOneFile.cpp: Copied from kjs/AllInOneFile.cpp.
GNUmakefile.am:
JavaScriptCore.xcodeproj/project.pbxproj:
kjs/AllInOneFile.cpp: Removed.

2:46 AM Changeset in webkit [38094] by ap@webkit.org

103 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22030
Make EventNames usable from multiple threads

platform/text/AtomicString.cpp: (WebCore::stringTable): (WebCore::AtomicString::add): (WebCore::AtomicString::remove): (WebCore::AtomicString::find): (WebCore::AtomicString::init):
platform/text/AtomicString.h: Atomic string table is now per-thread. Individual strings cannot be shared between threads, so global AtomicString constants cannot be used from threads other than the main one.

dom/EventNames.cpp: (WebCore::EventNames::EventNames): (WebCore::eventNames): (WebCore::EventNames::init):
dom/EventNames.h: Made EventNames a ThreadSpecific struct. Individual event names are now accessed as eventNames().fooEvent, not EventNames::fooEvent. This makes EventNames usable from all threads.

<Many files>: Access event names via eventNames() function.

2:40 AM Changeset in webkit [38093] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Alexey Proskuryakov.

Add NodeInfo.h to the JavaScriptCore Xcode project.

JavaScriptCore.xcodeproj/project.pbxproj:

1:43 AM Changeset in webkit [38092] by cwzwarich@webkit.org

2 edits
4 deletes in trunk

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Reviewed by Mark Rowe.

Delete unused forwarding headers.

WebCore:

ForwardingHeaders/kjs/Activation.h: Removed.
ForwardingHeaders/kjs/Register.h: Removed.
ForwardingHeaders/kjs/RegisterID.h: Removed.

WebKit/mac:

ForwardingHeaders/kjs/string_object.h: Removed.

12:58 AM Changeset in webkit [38091] by cwzwarich@webkit.org

2 edits
1 copy
1 add
1 delete in trunk/JavaScriptGlue

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Reviewed by Mark Rowe.

Remove JavaScriptGlue forwarding headers that are no longer necessary,
and correct the path of the ExecState.h forwarding header.

ForwardingHeaders/kjs: Removed.
ForwardingHeaders/kjs/CTI.h: Removed.
ForwardingHeaders/kjs/ExecState.h: Removed.
ForwardingHeaders/kjs/JSValue.h: Removed.
ForwardingHeaders/kjs/PutPropertySlot.h: Removed.
ForwardingHeaders/kjs/ustring.h: Removed.
ForwardingHeaders/runtime: Added.
ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
config.h:

12:07 AM Changeset in webkit [38090] by cwzwarich@webkit.org

4 edits in trunk/WebCore

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix stupid typo in previous build fix.

bindings/js/JSStorageCustom.cpp:
bindings/scripts/CodeGeneratorJS.pm:
bridge/NP_jsobject.cpp:

Nov 3, 2008:

11:56 PM Changeset in webkit [38089] by cwzwarich@webkit.org

4 edits
1 move in trunk/WebCore

2008-11-03 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the build for all non-Mac platforms.

ForwardingHeaders/kjs/PropertyNameArray.h: Removed.
ForwardingHeaders/runtime/PropertyNameArray.h: Copied from ForwardingHeaders/kjs/PropertyNameArray.h.
bindings/js/JSStorageCustom.cpp:
bindings/scripts/CodeGeneratorJS.pm:
bridge/NP_jsobject.cpp:

11:33 PM Changeset in webkit [38088] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-11-03 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the wxWindows build.

bridge/c/c_instance.cpp:

11:10 PM Changeset in webkit [38087] by cwzwarich@webkit.org

83 edits
40 moves in trunk

2008-11-03 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Maciej Stachowiak.

Move more files into the runtime subdirectory of JavaScriptCore.

JavaScriptCore:

API/JSBase.cpp:
API/JSCallbackConstructor.cpp:
API/JSCallbackFunction.cpp:
API/JSClassRef.cpp:
API/OpaqueJSString.cpp:
GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
kjs/AllInOneFile.cpp:
kjs/ArgList.cpp: Removed.
kjs/ArgList.h: Removed.
kjs/Arguments.cpp: Removed.
kjs/Arguments.h: Removed.
kjs/BatchedTransitionOptimizer.h: Removed.
kjs/CollectorHeapIterator.h: Removed.
kjs/CommonIdentifiers.cpp: Removed.
kjs/CommonIdentifiers.h: Removed.
kjs/ExecState.cpp: Removed.
kjs/ExecState.h: Removed.
kjs/GetterSetter.cpp: Removed.
kjs/GetterSetter.h: Removed.
kjs/InitializeThreading.cpp: Removed.
kjs/InitializeThreading.h: Removed.
kjs/JSActivation.cpp: Removed.
kjs/JSActivation.h: Removed.
kjs/JSGlobalData.cpp: Removed.
kjs/JSGlobalData.h: Removed.
kjs/JSLock.cpp: Removed.
kjs/JSLock.h: Removed.
kjs/JSStaticScopeObject.cpp: Removed.
kjs/JSStaticScopeObject.h: Removed.
kjs/JSType.h: Removed.
kjs/PropertyNameArray.cpp: Removed.
kjs/PropertyNameArray.h: Removed.
kjs/ScopeChain.cpp: Removed.
kjs/ScopeChain.h: Removed.
kjs/ScopeChainMark.h: Removed.
kjs/SymbolTable.h: Removed.
kjs/Tracing.d: Removed.
kjs/Tracing.h: Removed.
runtime/ArgList.cpp: Copied from kjs/ArgList.cpp.
runtime/ArgList.h: Copied from kjs/ArgList.h.
runtime/Arguments.cpp: Copied from kjs/Arguments.cpp.
runtime/Arguments.h: Copied from kjs/Arguments.h.
runtime/BatchedTransitionOptimizer.h: Copied from kjs/BatchedTransitionOptimizer.h.
runtime/CollectorHeapIterator.h: Copied from kjs/CollectorHeapIterator.h.
runtime/CommonIdentifiers.cpp: Copied from kjs/CommonIdentifiers.cpp.
runtime/CommonIdentifiers.h: Copied from kjs/CommonIdentifiers.h.
runtime/ExecState.cpp: Copied from kjs/ExecState.cpp.
runtime/ExecState.h: Copied from kjs/ExecState.h.
runtime/GetterSetter.cpp: Copied from kjs/GetterSetter.cpp.
runtime/GetterSetter.h: Copied from kjs/GetterSetter.h.
runtime/InitializeThreading.cpp: Copied from kjs/InitializeThreading.cpp.
runtime/InitializeThreading.h: Copied from kjs/InitializeThreading.h.
runtime/JSActivation.cpp: Copied from kjs/JSActivation.cpp.
runtime/JSActivation.h: Copied from kjs/JSActivation.h.
runtime/JSGlobalData.cpp: Copied from kjs/JSGlobalData.cpp.
runtime/JSGlobalData.h: Copied from kjs/JSGlobalData.h.
runtime/JSLock.cpp: Copied from kjs/JSLock.cpp.
runtime/JSLock.h: Copied from kjs/JSLock.h.
runtime/JSStaticScopeObject.cpp: Copied from kjs/JSStaticScopeObject.cpp.
runtime/JSStaticScopeObject.h: Copied from kjs/JSStaticScopeObject.h.
runtime/JSType.h: Copied from kjs/JSType.h.
runtime/PropertyNameArray.cpp: Copied from kjs/PropertyNameArray.cpp.
runtime/PropertyNameArray.h: Copied from kjs/PropertyNameArray.h.
runtime/ScopeChain.cpp: Copied from kjs/ScopeChain.cpp.
runtime/ScopeChain.h: Copied from kjs/ScopeChain.h.
runtime/ScopeChainMark.h: Copied from kjs/ScopeChainMark.h.
runtime/SymbolTable.h: Copied from kjs/SymbolTable.h.
runtime/Tracing.d: Copied from kjs/Tracing.d.
runtime/Tracing.h: Copied from kjs/Tracing.h.

WebCore:

ForwardingHeaders/kjs/ArgList.h: Removed.
ForwardingHeaders/kjs/CollectorHeapIterator.h: Removed.
ForwardingHeaders/kjs/ExecState.h: Removed.
ForwardingHeaders/kjs/InitializeThreading.h: Removed.
ForwardingHeaders/kjs/JSGlobalData.h: Removed.
ForwardingHeaders/kjs/JSLock.h: Removed.
ForwardingHeaders/kjs/SymbolTable.h: Removed.
ForwardingHeaders/runtime/ArgList.h: Copied from ForwardingHeaders/kjs/ArgList.h.
ForwardingHeaders/runtime/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/CollectorHeapIterator.h.
ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
ForwardingHeaders/runtime/InitializeThreading.h: Copied from ForwardingHeaders/kjs/InitializeThreading.h.
ForwardingHeaders/runtime/JSGlobalData.h: Copied from ForwardingHeaders/kjs/JSGlobalData.h.
ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
bindings/js/GCController.cpp:
bindings/js/JSCustomPositionCallback.cpp:
bindings/js/JSCustomPositionErrorCallback.cpp:
bindings/js/JSCustomSQLStatementCallback.cpp:
bindings/js/JSCustomSQLStatementErrorCallback.cpp:
bindings/js/JSCustomSQLTransactionCallback.cpp:
bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
bindings/js/JSCustomVoidCallback.cpp:
bindings/js/JSCustomXPathNSResolver.cpp:
bindings/js/JSDOMWindowBase.cpp:
bindings/js/JSEventCustom.cpp:
bindings/js/JSEventListener.cpp:
bindings/js/JSNodeFilterCondition.cpp:
bindings/js/ScheduledAction.cpp:
bindings/js/ScriptController.cpp:
bindings/js/ScriptControllerMac.mm:
bindings/objc/WebScriptObject.mm:
bridge/NP_jsobject.cpp:
bridge/c/c_class.cpp:
bridge/c/c_instance.cpp:
bridge/c/c_runtime.cpp:
bridge/c/c_utility.cpp:
bridge/jni/jni_class.cpp:
bridge/jni/jni_instance.cpp:
bridge/jni/jni_jsobject.mm:
bridge/jni/jni_objc.mm:
bridge/jni/jni_runtime.cpp:
bridge/jni/jni_runtime.h:
bridge/jni/jni_utility.cpp:
bridge/npruntime.cpp:
bridge/objc/objc_instance.mm:
bridge/objc/objc_runtime.mm:
bridge/objc/objc_utility.mm:
bridge/runtime.cpp:
dom/Document.cpp:
dom/Node.cpp:
dom/NodeFilter.cpp:
dom/NodeIterator.cpp:
dom/TreeWalker.cpp:
history/CachedPage.cpp:
inspector/InspectorController.cpp:
inspector/JavaScriptCallFrame.cpp:
inspector/JavaScriptCallFrame.h:
inspector/JavaScriptDebugServer.cpp:
inspector/JavaScriptProfileNode.cpp:
loader/FrameLoader.cpp:
loader/icon/IconDatabase.cpp:
page/Console.cpp:
page/Page.cpp:
page/mac/FrameMac.mm:
plugins/PluginView.cpp:
plugins/gtk/PluginViewGtk.cpp:
plugins/qt/PluginViewQt.cpp:
plugins/win/PluginViewWin.cpp:
storage/Database.cpp:
xml/XMLHttpRequest.cpp:

WebKit/gtk:

webkit/webkitprivate.cpp:

WebKit/mac:

ForwardingHeaders/kjs/JSLock.h: Removed.
ForwardingHeaders/kjs/SymbolTable.h: Removed.
ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
Misc/WebCoreStatistics.mm:
Plugins/WebBaseNetscapePluginStream.mm:
Plugins/WebBaseNetscapePluginView.mm:
Plugins/WebPluginController.mm:
WebView/WebFrame.mm:
WebView/WebScriptDebugDelegate.mm:
WebView/WebView.mm:

WebKit/qt:

Api/qwebpage.cpp:

WebKit/win:

WebJavaScriptCollector.cpp:

11:01 PM Changeset in webkit [38086] by mitz@apple.com

4 edits in trunk/WebKit/win

Reviewed by Steve Falkenburg.

implement WebMutableURLRequest::setHTTPShouldHandleCookies()
add and implement WebMutableURLRequest::mutableCopy()

Interfaces/IWebURLRequest.idl:
WebMutableURLRequest.cpp: (WebMutableURLRequest::setHTTPShouldHandleCookies): (WebMutableURLRequest::mutableCopy):
WebMutableURLRequest.h:

10:38 PM Changeset in webkit [38085] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Fix the 64-bit build.

Pull the frequently-made check for drawingModel == NPDrawingModelQuickDraw out into a
helper function to avoid #ifdef'ing all of the new places that this check is made.

A few other #ifdef's are moved inside functions to allow their call sites to remain #ifdef-free,
and we rely on the compiler to optimise out the check (which will always be false in 64-bit) instead.

Plugins/WebBaseNetscapePluginView.mm:

(isDrawingModelQuickDraw):
(-[WebBaseNetscapePluginView fixWindowPort]):
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
(-[WebBaseNetscapePluginView updateAndSetWindow]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView tellQuickTimeToChill]):
(-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
(-[WebBaseNetscapePluginView _viewHasMoved]):

8:25 PM Changeset in webkit [38084] by alp@webkit.org

2 edits in trunk

2008-11-03 Alp Toker <alp@nuanti.com>

autotools distcleancheck fix. Add dolt-generated files and
webkitenumtypes.h to the list of files that need to be cleaned.
Unreviewed.

GNUmakefile.am:

8:00 PM Changeset in webkit [38083] by cwzwarich@webkit.org

1 edit
1 delete in trunk/WebCore

2008-11-03 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove the forwarding header for FunctionCallProfile, because it was
renamed to ProfileNode in r33466.

ForwardingHeaders/kjs/FunctionCallProfile.h: Removed.

6:32 PM Changeset in webkit [38082] by mitz@apple.com

2 edits in trunk/WebKitTools

2008-11-03 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.

https://bugs.webkit.org/show_bug.cgi?id=22054

DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):

4:33 PM Changeset in webkit [38081] by mjs@apple.com

2 edits in trunk/WebKit/mac

2008-11-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Kevin Decker.

fix release build (and unitialized variable for CG drawing model!)

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): initialize portState in all code paths

2:43 PM Changeset in webkit [38080] by weinig@apple.com

3 edits in trunk/JavaScriptCore

2008-11-03 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Move #define to turn on dumping StructureID statistics to StructureID.cpp so that
turning it on does not require a full rebuild.

runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics):
runtime/StructureID.h:

2:37 PM Changeset in webkit [38079] by Simon Fraser

3 edits
4 adds in trunk

2008-11-03 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=22026

When computing the bounds of the transparency layer, we need to
map the clipRect through the enclosing transform.

Test: fast/layers/opacity-transforms.html

rendering/RenderLayer.cpp: (WebCore::transparencyClipBox):

12:52 PM Changeset in webkit [38078] by kdecker@apple.com

5 edits in trunk

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=22053

This patch adds initial support for the NPDrawingModelCoreAnimation drawing model.

Plugins/WebBaseNetscapePluginView.h: Added _layer ivar.
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation. (-[WebBaseNetscapePluginView restorePortState:]): Ditto. (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): Slightly refactored a small block of code which with the PortState. Plug-ins using the NPDrawingModelCoreAnimation drawing model have no PortState. (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation (-[WebBaseNetscapePluginView updateAndSetWindow]): Ditto. (-[WebBaseNetscapePluginView setWindowIfNecessary]): Ditto. (-[WebBaseNetscapePluginView start]): If the plug-in is a plug-in using the Core Animation model, request a layer from it. (-[WebBaseNetscapePluginView drawRect:]): Return early for NPDrawingModelCoreAnimation plug-ins. (-[WebBaseNetscapePluginView getVariable:value:]): Tell plug-ins running on post-Tiger systems WebKit supports NPDrawingModelCoreAnimation. (-[WebBaseNetscapePluginView setVariable:value:]): Added the new NPDrawingModelCoreAnimation case, which initializes drawingMode. (-[WebBaseNetscapePluginView _viewHasMoved]): Reworded the conditional call to updateAndSetWindow to be specific to CoreGraphics and QuickDraw plug-ins.

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=22053

Added additional support needed for the NPDrawingModelCoreAnimation drawing model.

bridge/npapi.h:

12:47 PM Changeset in webkit [38077] by alp@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-03 Alp Toker <alp@nuanti.com>

Reviewed by Geoffrey Garen.

Fix warning when building on Darwin without JSC_MULTIPLE_THREADS
enabled.

kjs/InitializeThreading.cpp:

12:29 PM Changeset in webkit [38076] by alp@webkit.org

3 edits in trunk/WebKit/gtk

2008-11-03 Alp Toker <alp@nuanti.com>

Reviewed by Holger Freyther.

Deprecate flawed webkit_web_frame_new() function. This would never
have worked properly when used outside WebCore since Frame::create()
can only be called without an owner element once in the lifetime of a
Page and would result in assertions, leaks and an unusable WebView
instance.

Frame creation may be exposed in API some time later via the DOM
binding but probably not in the WebKit GTK+ core API.

webkit/webkitwebframe.cpp:
webkit/webkitwebframe.h:

11:15 AM Changeset in webkit [38075] by alp@webkit.org

2 edits in trunk/WebCore

2008-11-03 Xan Lopez <xan@gnome.org>

Reviewed by Alp Toker.

Update parseDataUrl() function in the libsoup http backend with
the one from the curl backend which has recent correctness and crash
fixes.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):

10:37 AM Changeset in webkit [38074] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2008-11-03 Alp Toker <alp@nuanti.com>

Reviewed by Holger Freyther.

Redundant scrollbars appear in frames where they shouldn't be visible
eg. embedded Google adverts.

Call setCanHaveScrollbars() when necessary. The Mac and Win ports
already have this but it was missing in FrameLoaderClientGtk.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

10:26 AM Changeset in webkit [38073] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2008-11-03 Alp Toker <alp@nuanti.com>

Rubber-stamped by Holger Freyther.

Sync WebKit GTK+ default UA version string to 528.5+. (We're still
doing this manually!)

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::composeUserAgent):

9:27 AM Changeset in webkit [38072] by alp@webkit.org

2 edits in trunk

2008-11-03 Alp Toker <alp@nuanti.com>

Rubber-stamped by Holger Freyther.

Do not enable RTTI or exceptions in debug builds, matching release
builds. They don't help much with debugging and significantly slow
down and increase the size of the debug build.

GNUmakefile.am:

9:11 AM Changeset in webkit [38071] by alp@webkit.org

2 edits in trunk/WebCore

2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=22041
Fix CURL crashes on the test suite

Fix segfault with setDefersLoading(). Do not call into curl when we
don't have a CURL handle.

It is attempted to defer the loading before the load has been
started (no curl handle was allocated yet). If that happens then
just remember that. ResourceHandleManager::startJob is already taking
care of this and in initResourceHandle the the downloading will
be paused if needed.

Fixes fast/loader/simultaneous-reloads-assert.html

platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):

8:50 AM Changeset in webkit [38070] by alp@webkit.org

2 edits in trunk/WebCore

2008-11-03 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=22041
Fix CURL crashes on the test suite

Do not send "no data" to WebCore in parseDataUrl().

Fixes assert on fast/tokenizer/image-empty-crash.html

platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):

7:59 AM Changeset in webkit [38069] by alp@webkit.org

2 edits in trunk

2008-11-03 Alp Toker <alp@nuanti.com>

Rubber-stamped by Holger Freyther.

Add mingw32 case to dolt for faster GTK+ Windows builds.

acinclude.m4:

Nov 2, 2008:

1:14 PM Changeset in webkit [38068] by pewtermoose@webkit.org

2 edits in trunk/JavaScriptCore

2008-11-02 Matt Lilek <webkit@mattlilek.com>

Reviewed by Cameron Zwarich.

Bug 22042: REGRESSION(r38066): ASSERTION FAILED: source in CodeBlock
<https://bugs.webkit.org/show_bug.cgi?id=22042>

Rename parameter name to avoid ASSERT.

VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock):

12:23 PM Changeset in webkit [38067] by christian@webkit.org

4 edits in trunk

2008-11-02 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther

https://bugs.webkit.org/show_bug.cgi?id=22009
HTML5 Video with GStreamer pulls gnome-vfs without using it.

configure.ac: Remove gnome-vfs from configure.ac, it's unused.

3:29 AM Changeset in webkit [38066] by cwzwarich@webkit.org

4 edits in trunk/JavaScriptCore

2008-11-02 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 22035: Remove the '_' suffix on constructor parameter names for structs
<https://bugs.webkit.org/show_bug.cgi?id=22035>

API/JSCallbackObject.h: (JSC::JSCallbackObject::JSCallbackObjectData::JSCallbackObjectData):
VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock):
wrec/WREC.h: (JSC::Quantifier::Quantifier):

Nov 1, 2008:

2:31 AM Changeset in webkit [38065] by abarth@webkit.org

6 edits
6 adds in trunk

WebCore:

2008-11-01 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Be sure to check the final URLs of requested resources to make sure we
don't get fooled by HTTP redirects.

https://bugs.webkit.org/show_bug.cgi?id=21963

Tests: http/tests/security/xss-DENIED-xsl-document-redirect.xml

http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml

dom/XMLTokenizerLibxml2.cpp: (WebCore::openFunc):
loader/DocLoader.cpp: (WebCore::DocLoader::canRequest): (WebCore::DocLoader::requestResource):
loader/DocLoader.h:
xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):

LayoutTests:

2008-11-01 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Test that we properly block non-same-origin redirects for these
esoteric loads.

https://bugs.webkit.org/show_bug.cgi?id=21963

http/tests/security/resources/xsl-using-document-redirect.xsl: Added.
http/tests/security/resources/xsl-using-external-entity-redirect.xsl: Added.
http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-document-expected.txt.
http/tests/security/xss-DENIED-xsl-document-redirect.xml: Added.
http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt.
http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml: Added.

12:21 AM Changeset in webkit [38064] by ap@webkit.org

10 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22001
AtomicStringImpl* keys of event listener maps can outlive their strings

Test: fast/events/destroyed-atomic-string.html

dom/MessagePort.cpp: (WebCore::MessagePort::addEventListener): (WebCore::MessagePort::removeEventListener): (WebCore::MessagePort::dispatchEvent):
dom/MessagePort.h:
loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::dispatchEvent):
loader/appcache/DOMApplicationCache.h:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::addEventListener): (WebCore::XMLHttpRequest::removeEventListener): (WebCore::XMLHttpRequest::dispatchEvent):
xml/XMLHttpRequest.h:
xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::addEventListener): (WebCore::XMLHttpRequestUpload::removeEventListener): (WebCore::XMLHttpRequestUpload::dispatchEvent):
xml/XMLHttpRequestUpload.h: Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).

12:11 AM Changeset in webkit [38063] by ap@webkit.org

22 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21998
Use JSDOMGlobalObject in EventListener-related bindings

dom/MessagePort.idl: Auto-generate bindings for onclose and onmessage.

bindings/scripts/CodeGeneratorJS.pm: Use JSDOMGlobalObject instead of JSDOMWindow in JS bindings for inline event handlers.

bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener):
bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::removeEventListener):
bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener): Use ScriptExecutionContext and JSDOMGlobalObject in bindings.

dom/EventTarget.h:
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::scriptExecutionContext):
dom/EventTargetNode.h:
dom/MessagePort.cpp:
dom/MessagePort.h: (WebCore::MessagePort::scriptExecutionContext):
loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::scriptExecutionContext):
loader/appcache/DOMApplicationCache.h:
svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::scriptExecutionContext):
svg/SVGElementInstance.h:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::scriptExecutionContext):
xml/XMLHttpRequest.h:
xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
xml/XMLHttpRequestUpload.h: Remove associatedFrame() method, and provide scriptExecutionContext() where it wasn't available yet.

Oct 31, 2008:

9:28 PM Changeset in webkit [38062] by Stephanie Lewis

2 edits in trunk/JavaScriptGlue

2008-10-31 Stephanie Lewis <Stephanie Lewis>

Fix build by including right files.

JSRun.cpp:

6:05 PM Changeset in webkit [38061] by cwzwarich@webkit.org

13 edits
2 moves in trunk

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Geoff Garen.

Rename SourceRange.h to SourceCode.h.

JavaScriptCore:

API/JSBase.cpp:
GNUmakefile.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
VM/CodeBlock.h:
kjs/SourceCode.h: Copied from kjs/SourceRange.h.
kjs/SourceRange.h: Removed.
kjs/grammar.y:
kjs/lexer.h:
kjs/nodes.cpp: (JSC::ForInNode::ForInNode):
kjs/nodes.h: (JSC::ThrowableExpressionData::setExceptionSourceCode):

WebCore:

ForwardingHeaders/kjs/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceRange.h.
ForwardingHeaders/kjs/SourceRange.h: Removed.
bindings/js/StringSourceProvider.h:
bridge/NP_jsobject.cpp:

5:35 PM Changeset in webkit [38060] by cwzwarich@webkit.org

10 edits in trunk

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
<https://bugs.webkit.org/show_bug.cgi?id=22019>

The JSC::Interpreter::shouldPrintExceptions() function is not used at
all in JavaScriptCore, so it should be moved to WebCore::Console, its
only user.

JavaScriptCore:

JavaScriptCore.exp:
kjs/interpreter.cpp:
kjs/interpreter.h:

WebCore:

WebCore.base.exp:
page/Console.cpp: (WebCore::printToStandardOut): (WebCore::Console::shouldPrintExceptions): (WebCore::Console::setShouldPrintExceptions):
page/Console.h:

WebKit/mac:

Misc/WebCoreStatistics.mm: (+[WebCoreStatistics shouldPrintExceptions]): (+[WebCoreStatistics setShouldPrintExceptions:]):

5:26 PM Changeset in webkit [38059] by christian@webkit.org

2 edits in trunk/WebKit/gtk

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=22018
enable-developer-extras doesn't toggle WebInspector

webkit/webkitwebview.cpp:

Add missing 'if' in notification for 'enable-developer-extras'.

4:35 PM Changeset in webkit [38058] by mitz@apple.com

12 edits in trunk

WebCore:

Reviewed by John Sullivan.

WebCore part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

dom/Document.cpp: (WebCore::Document::cookie): Added checking if cookies are disabled. (WebCore::Document::setCookie): Ditto.
page/Navigator.cpp: (WebCore::Navigator::cookieEnabled): Ditto.
page/Page.cpp: (WebCore::Page::Page): Initialize m_cookieEnabled to true.
page/Page.h: (WebCore::Page::cookieEnabled): Added. (WebCore::Page::setCookieEnabled): Added.

WebKit/mac:

Reviewed by John Sullivan.

WebKit/mac part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

WebView/WebView.mm: (-[WebView _cookieEnabled]): (-[WebView _setCookieEnabled:]):
WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by John Sullivan.

WebKit/win part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::setCookieEnabled): (WebView::cookieEnabled):
WebView.h:

4:25 PM Changeset in webkit [38057] by adele@apple.com

11 edits in trunk

WebCore:

2008-10-31 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

WebCore Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
https://bugs.webkit.org/show_bug.cgi?id=22008

platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon): Rename newIconForFile and newIconForFiles to createIconForFile and createIconForFiles.
platform/graphics/Icon.h: ditto.
platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): ditto.
platform/graphics/mac/IconMac.mm: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): ditto.
platform/graphics/qt/IconQt.cpp: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): ditto.
platform/wx/TemporaryLinkStubs.cpp: (Icon::createIconForFile): ditto. (Icon::createIconForFiles): ditto.
platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): Add creation of an icon for multiple files.

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): Improve icon creation code to match new code in Icon::createIconForFiles

WebKit/win:

2008-10-31 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

WebKit Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
https://bugs.webkit.org/show_bug.cgi?id=22008

WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel): Add support for mulitple file selection.

3:56 PM Changeset in webkit [38056] by andersca@apple.com

2 edits in trunk/WebKit

2008-10-31 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move WebNetscapePluginEventHandler classes to a subgroup of Netscape Plug-Ins.

WebKit.xcodeproj/project.pbxproj:

3:26 PM Changeset in webkit [38055] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Windows build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

3:18 PM Changeset in webkit [38054] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Remove the call to Interpreter::setShouldPrintExceptions() from the
GlobalObject constructor in the shell. The shouldPrintExceptions()
information is not used anywhere in JavaScriptCore, only in WebCore.

kjs/Shell.cpp: (GlobalObject::GlobalObject):

2:59 PM Changeset in webkit [38053] by kevino@webkit.org

4 edits in trunk

A couple wxMSW build fixes.

2:40 PM Changeset in webkit [38052] by cwzwarich@webkit.org

6 edits
7 moves in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move more files from the kjs subdirectory of JavaScriptCore to the
runtime subdirectory.

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
kjs/AllInOneFile.cpp:
kjs/RegExpConstructor.cpp: Removed.
kjs/RegExpConstructor.h: Removed.
kjs/RegExpMatchesArray.h: Removed.
kjs/RegExpObject.cpp: Removed.
kjs/RegExpObject.h: Removed.
kjs/RegExpPrototype.cpp: Removed.
kjs/RegExpPrototype.h: Removed.
runtime/RegExpConstructor.cpp: Copied from kjs/RegExpConstructor.cpp.
runtime/RegExpConstructor.h: Copied from kjs/RegExpConstructor.h.
runtime/RegExpMatchesArray.h: Copied from kjs/RegExpMatchesArray.h.
runtime/RegExpObject.cpp: Copied from kjs/RegExpObject.cpp.
runtime/RegExpObject.h: Copied from kjs/RegExpObject.h.
runtime/RegExpPrototype.cpp: Copied from kjs/RegExpPrototype.cpp.
runtime/RegExpPrototype.h: Copied from kjs/RegExpPrototype.h.

2:19 PM Changeset in webkit [38051] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Revert an incorrect portion of r38034.

profiler/ProfilerServer.mm:

2:19 PM Changeset in webkit [38050] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Fix the 64-bit build.

Disable strict aliasing in ProfilerServer.mm as it leads to the compiler being unhappy
with the common Obj-C idiom self = [super init];

JavaScriptCore.xcodeproj/project.pbxproj:

1:47 PM Changeset in webkit [38049] by cwzwarich@webkit.org

2 edits in trunk/WebKitTools

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Scripts/do-webcore-rename:

Add some renames to contemplate for the future.

1:44 PM Changeset in webkit [38048] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Change a header guard to match our coding style.

kjs/InitializeThreading.h:

12:59 PM Changeset in webkit [38047] by ggaren@apple.com

14 edits
1 add
2 deletes in trunk/JavaScriptCore

2008-10-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed a small bit of https://bugs.webkit.org/show_bug.cgi?id=21962
AST uses way too much memory

Removed a word from StatementNode by nixing LabelStack and turning it
into a compile-time data structure managed by CodeGenerator.

v8 tests and SunSpider, run by Gavin, report no change.

GNUmakefile.am:
JavaScriptCore.order:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
kjs/AllInOneFile.cpp:
JavaScriptCoreSources.bkl: I sure hope this builds!

VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::newLabelScope): (JSC::CodeGenerator::breakTarget): (JSC::CodeGenerator::continueTarget):
VM/CodeGenerator.h: Nixed the JumpContext system because it depended on a LabelStack in the AST, and it was a little cumbersome on the client side. Replaced with LabelScope, which tracks all break / continue information in the CodeGenerator, just like we track LabelIDs and other stacks of compile-time data.

kjs/LabelScope.h: Added. (JSC::LabelScope::): (JSC::LabelScope::LabelScope): (JSC::LabelScope::ref): (JSC::LabelScope::deref): (JSC::LabelScope::refCount): (JSC::LabelScope::breakTarget): (JSC::LabelScope::continueTarget): (JSC::LabelScope::type): (JSC::LabelScope::name): (JSC::LabelScope::scopeDepth): Simple abstraction for holding everything you might want to know about a break-able / continue-able scope.

kjs/LabelStack.cpp: Removed.
kjs/LabelStack.h: Removed.

kjs/grammar.y: No need to push labels at parse time -- we don't store LabelStacks in the AST anymore.

kjs/nodes.cpp: (JSC::DoWhileNode::emitCode): (JSC::WhileNode::emitCode): (JSC::ForNode::emitCode): (JSC::ForInNode::emitCode): (JSC::ContinueNode::emitCode): (JSC::BreakNode::emitCode): (JSC::SwitchNode::emitCode): (JSC::LabelNode::emitCode):
kjs/nodes.h: (JSC::StatementNode::): (JSC::LabelNode::): Use LabelScope where we used to use JumpContext. Simplified a bunch of code. Touched up label-related error messages a bit.

kjs/nodes2string.cpp: (JSC::LabelNode::streamTo): Updated for rename.

12:53 PM Changeset in webkit [38046] by cwzwarich@webkit.org

8 edits
2 copies in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22005: Move StructureIDChain into its own file
<https://bugs.webkit.org/show_bug.cgi?id=22005>

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
runtime/StructureID.cpp:
runtime/StructureID.h:
runtime/StructureIDChain.cpp: Copied from runtime/StructureID.cpp.
runtime/StructureIDChain.h: Copied from runtime/StructureID.h.

12:53 PM Changeset in webkit [38045] by Darin Adler

2 edits in trunk/WebKitTools

2008-10-31 Darin Adler <Darin Adler>

Requested by Mark Rowe.

Scripts/check-for-global-initializers: s/Web Kit/WebKit/.

12:44 PM Changeset in webkit [38044] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

2008-10-31 Steve Falkenburg <sfalken@apple.com>

Build fix.

JavaScriptCore.vcproj/jsc/jsc.vcproj:

12:35 PM Changeset in webkit [38043] by beidson@apple.com

1 edit in trunk/WebKit/mac/ChangeLog

Expand that name!

12:34 PM Changeset in webkit [38042] by beidson@apple.com

2 edits in trunk/WebKit/mac

2008-10-31 Brady Eidson <beidson@apple.com>

Reviewed by Darin

[WebHistory setLastVisitedTimeInterval:forItem] was internal to WebHistory.mm and
completely unused. Nuke it!

History/WebHistory.mm:

11:53 AM Changeset in webkit [38041] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

2008-10-31 Steve Falkenburg <sfalken@apple.com>

Build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

11:49 AM Changeset in webkit [38040] by timothy@apple.com

3 edits
2 adds in trunk

Emit the WillExecuteStatement debugger hook before the for loop body when the statement node for the body isn't a block. This allows breakpoints on those statements in the Web Inspector.

JavaScriptCore:

2008-10-31 Timothy Hatcher <timothy@apple.com>

Emit the WillExecuteStatement debugger hook before the for loop body
when the statement node for the body isn't a block. This allows
breakpoints on those statements in the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=22004

Reviewed by Darin Adler.

kjs/nodes.cpp: (JSC::ForNode::emitCode): Emit the WillExecuteStatement debugger hook before the statement node if isn't a block. Also emit the WillExecuteStatement debugger hook for the loop as the first op-code. (JSC::ForInNode::emitCode): Ditto.

WebCore:

2008-10-31 Timothy Hatcher <timothy@apple.com>

Add manual tests that check breakpoints on a blockless body of "for" loops.

https://bugs.webkit.org/show_bug.cgi?id=22004

Reviewed by Darin Adler.

manual-tests/inspector/debugger-pause-on-for-in-statements.html: Added.
manual-tests/inspector/debugger-pause-on-for-statements.html: Added.

11:45 AM Changeset in webkit [38039] by Darin Adler

2 edits in trunk/WebCore

2008-10-31 Darin Adler <Darin Adler>

fix build

platform/win/WCDataObject.cpp: Added missing include of "config.h".

11:08 AM Changeset in webkit [38038] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

Bug 21997: prepare-ChangeLog should filter out ChangeLog files

<https://bugs.webkit.org/show_bug.cgi?id=21997>

Reviewed by Darin Adler.

Scripts/prepare-ChangeLog: (generateFileList): Don't add ChangeLog files to %{$functionLists}. This prevents them from showing up in the new ChangeLog entry. They were already excluded from @{$changedFiles}.

10:59 AM Changeset in webkit [38037] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-31 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

fix storage leak seen on buildbot

Some other cleanup too. The storage leak was caused by the fact
that HashTraits<CallIdentifier>::needsDestruction was false, so
the call identifier objects didn't get deleted.

profiler/CallIdentifier.h:

Added a default constructor to create empty call identifiers.

Changed the normal constructor to use const UString&
to avoid extra copying and reference count thrash.

Removed the explicit copy constructor definition, since it's what
the compiler will automatically generate. (Rule of thumb: Either
you need both a custom copy constructor and a custom assignment
operator, or neither.)

Moved the CallIdentifier hash function out of the WTF namespace;
there's no reason to put it there.

Changed the CallIdentifier hash function to be a struct rather than
a specialization of the IntHash struct template. Having it be
a specialization made no sense, since CallIdentifier is not an integer,
and did no good.

Removed explicit definition of emptyValueIsZero in the hash traits,
since inheriting from GenericHashTraits already makes that false.

Removed explicit definition of emptyValue, instead relying on the
default constructor and GenericHashTraits.

Removed explicit definition of needsDestruction, because we want it
to have its default value: true, not false. This fixes the leak!

Changed constructDeletedValue and isDeletedValue to use a line number
of numeric_limits<unsigned>::max() to indicate a value is deleted.
Previously this used empty strings for the empty value and null strings
for the deleted value, but it's more efficient to use null for both.

10:56 AM Changeset in webkit [38036] by Darin Adler

2 edits in trunk/WebKit/win

2008-10-31 Darin Adler <Darin Adler>

try to fix build

WebView.cpp: (WebView::setCacheModel): Roll out the part of my last change that involved no longer using wkCopyFoundationCacheDirectory.

10:15 AM Changeset in webkit [38035] by Chris Fleizach

2 edits in trunk/WebKit/mac

Bug 22002: AX: scroll bars show should not appear in AX hierarchy when WebFrameView does not allow scrolling
https://bugs.webkit.org/show_bug.cgi?id=22002

3:17 AM Changeset in webkit [38034] by timothy@apple.com

2 edits in trunk/JavaScriptCore

Fixes console warnings about not having an autorelease pool.
Also fixes the build for Snow Leopard, by including individual
Foundation headers instead of Foundation.h.

https://bugs.webkit.org/show_bug.cgi?id=21995

Reviewed by Oliver Hunt.

profiler/ProfilerServer.mm: (-[ProfilerServer init]): Create a NSAutoreleasePool and drain it.

2:44 AM Changeset in webkit [38033] by ap@webkit.org

11 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21970
Make MessagePort event dispatch work in workers

bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener): (WebCore::JSDOMGlobalObject::jsEventListeners): (WebCore::JSDOMGlobalObject::jsInlineEventListeners): (WebCore::JSDOMGlobalObject::jsUnprotectedEventListeners): (WebCore::JSDOMGlobalObject::jsUnprotectedInlineEventListeners): (WebCore::JSDOMGlobalObject::setCurrentEvent): (WebCore::JSDOMGlobalObject::currentEvent): (WebCore::toJSDOMGlobalObject):
bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData): (WebCore::JSDOMWindowBase::~JSDOMWindowBase): (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
bindings/js/JSDOMWindowBase.h: Moved event listener tracking from JSDOMWindow to JSDOMGlobalObject.

bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::globalObject): (WebCore::JSUnprotectedEventListener::clearGlobalObject): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::globalObject): (WebCore::JSEventListener::clearGlobalObject): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::parseCode):
bindings/js/JSEventListener.h: (WebCore::JSUnprotectedEventListener::create): (WebCore::JSEventListener::create): (WebCore::JSLazyEventListener::create): Changed to use JSDOMGlobalObject and ScriptExecutionContext.

bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener): (WebCore::JSMessagePort::setOnmessage): (WebCore::JSMessagePort::setOnclose): Updated bindings to work with JSDOMGlobalObject. Next step is to make code generator emit such code, and stop using a custom implementation for JSMessagePort inline event handler getters and setters.

dom/Document.cpp: (WebCore::Document::virtualURL):
dom/Document.h:
dom/ScriptExecutionContext.h: Expose url() method on ScriptExecutionContext (necessary for compiling scripts in JSLazyEventListener).

1:18 AM Changeset in webkit [38032] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Speculative wxWindows build fix.

webcore-base.bkl:

12:42 AM Changeset in webkit [38031] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Speculative wxWindows build fix.

JavaScriptCoreSources.bkl:
jscore.bkl:

12:37 AM Changeset in webkit [38030] by cwzwarich@webkit.org

6 edits
2 moves in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Maciej Stachowiak.

Move VM/JSPropertyNameIterator.cpp and VM/JSPropertyNameIterator.h to
the runtime directory.

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
VM/JSPropertyNameIterator.cpp: Removed.
VM/JSPropertyNameIterator.h: Removed.
runtime/JSPropertyNameIterator.cpp: Copied from VM/JSPropertyNameIterator.cpp.
runtime/JSPropertyNameIterator.h: Copied from VM/JSPropertyNameIterator.h.

12:12 AM Changeset in webkit [38029] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Speculative wxWindows build fix.

jscore.bkl:

Oct 30, 2008:

11:13 PM Changeset in webkit [38028] by mrowe@apple.com

10 edits in trunk

Explicitly default to building for only the native architecture in debug and release builds.

Reviewed by Jon Homeycutt.

Configurations/DebugRelease.xcconfig:

10:56 PM Changeset in webkit [38027] by cwzwarich@webkit.org

26 edits
7 moves
3 adds in trunk

2008-10-30 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Create a debugger directory in JavaScriptCore and move the relevant
files to it.

JavaScriptCore:

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
VM/CodeBlock.cpp:
VM/CodeGenerator.h:
VM/Machine.cpp:
debugger: Added.
debugger/Debugger.cpp: Copied from kjs/debugger.cpp.
debugger/Debugger.h: Copied from kjs/debugger.h.
debugger/DebuggerCallFrame.cpp: Copied from kjs/DebuggerCallFrame.cpp.
debugger/DebuggerCallFrame.h: Copied from kjs/DebuggerCallFrame.h.
kjs/AllInOneFile.cpp:
kjs/DebuggerCallFrame.cpp: Removed.
kjs/DebuggerCallFrame.h: Removed.
kjs/Parser.cpp:
kjs/Parser.h:
kjs/debugger.cpp: Removed.
kjs/debugger.h: Removed.
kjs/interpreter.cpp:
kjs/nodes.cpp:
runtime/FunctionConstructor.cpp:
runtime/JSGlobalObject.cpp:

WebCore:

ForwardingHeaders/debugger: Added.
ForwardingHeaders/debugger/Debugger.h: Copied from ForwardingHeaders/kjs/debugger.h.
ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
ForwardingHeaders/kjs/debugger.h: Removed.
WebCore.pro:
bindings/js/ScriptController.cpp:
inspector/JavaScriptCallFrame.cpp:
inspector/JavaScriptCallFrame.h:
inspector/JavaScriptDebugServer.cpp:
inspector/JavaScriptDebugServer.h:

WebKit/mac:

ForwardingHeaders/debugger: Added.
ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
WebView/WebScriptDebugDelegate.mm:
WebView/WebScriptDebugger.h:
WebView/WebScriptDebugger.mm:

10:54 PM Changeset in webkit [38026] by timothy@apple.com

2 edits in trunk/SunSpider

Fix a bug where when V8's or UBENCH's test suite list file is missing
the error message is suggesting that SunSpider's list file is missing.

Reviewed by Sam Weinig.

sunspider: (loadTestsList): Fix the error message to use the right list name.

10:49 PM Changeset in webkit [38025] by timothy@apple.com

2 edits in trunk/WebCore

Fix 2 Windows theme bugs:
1) Checkboxes marked readonly were rendered incorrectly
2) If a button has focus and is pressed, it was rendered

as focused rather than pressed.

https://bugs.webkit.org/show_bug.cgi?id=21859

Reviewed by Dave Hyatt.

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineState): (WebCore::RenderThemeWin::determineButtonState):

10:36 PM Changeset in webkit [38024] by timothy@apple.com

4 edits in trunk

Add parentheses to fix some gcc warnings.

JavaScriptCore:

2008-10-30 Benjamin K. Stuhl <bks24@cornell.edu>

gcc 4.3.3/linux-x86 generates "suggest parentheses around && within

"

warnings; add some parentheses to disambiguate things. No functional
changes, so no tests.

https://bugs.webkit.org/show_bug.cgi?id=21973
Add parentheses to clean up some gcc warnings

Reviewed by Dan Bernstein.

wtf/ASCIICType.h: (WTF::isASCIIAlphanumeric): (WTF::isASCIIHexDigit):

WebCore:

2008-10-30 Benjamin K. Stuhl <bks24@cornell.edu>

gcc 4.3.3/linux-x86 generates "suggest parentheses around && within

"

warnings; add some parentheses to disambiguate things. No functional
changes, so no tests.

https://bugs.webkit.org/show_bug.cgi?id=21973
Add parentheses to clean up some gcc warnings

Reviewed by Dan Bernstein.

platform/graphics/Font.h: (WebCore::Font::treatAsZeroWidthSpace):

10:29 PM Changeset in webkit [38023] by timothy@apple.com

2 edits in trunk/WebCore

Added an explicit dependency on HashMap.h. It was getting pulled in via
<kjs/identifier.h> in the case of JSC, causing errors for the Chromium port.

Reviewed by Darin Adler.

platform/text/PlatformString.h:

10:24 PM Changeset in webkit [38022] by timothy@apple.com

3 edits
2 adds in trunk/JavaScriptCore

Adds ProfilerServer, which is a distributed notification listener
that allows starting and stopping the profiler remotely for use
in conjunction with the profiler's DTace probes.

https://bugs.webkit.org/show_bug.cgi?id=21719

Reviewed by Timothy Hatcher.

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Calls startProfilerServerIfNeeded.
profiler/ProfilerServer.h: Added.
profiler/ProfilerServer.mm: Added. (+[ProfilerServer sharedProfileServer]): (-[ProfilerServer init]): (-[ProfilerServer startProfiling]): (-[ProfilerServer stopProfiling]): (JSC::startProfilerServerIfNeeded):

9:09 PM Changeset in webkit [38021] by cwzwarich@webkit.org

2 edits in trunk/WebKitSite

2008-10-30 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Mark Rowe.

Update the link to Mac Subversion binaries.

building/tools.html:

8:43 PM Changeset in webkit [38020] by kevino@webkit.org

2 edits in trunk/JavaScriptCore

wx build fix after PropertyMap and StructureID merge.

8:39 PM Changeset in webkit [38019] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-30 Cameron Zwarich <zwarich@apple.com>

Reviewed by Mark Rowe.

Change the JavaScriptCore Xcode project to use relative paths for the
PCRE source files.

JavaScriptCore.xcodeproj/project.pbxproj:

6:56 PM Changeset in webkit [38018] by ddkilzer@apple.com

4 edits in trunk/WebCore

2008-10-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig

https://bugs.webkit.org/show_bug.cgi?id=21967

For some platforms the GeolocationService must be suspended and resumed.

page/Geolocation.cpp: (WebCore::Geolocation::clearWatch): now uses Geolocation::hasListeners() (WebCore::Geolocation::suspend): calls GeolocationService::suspend() if there are listeners (WebCore::Geolocation::resume): calls GeolocationService::resume() if there are listeners (WebCore::Geolocation::geolocationServicePositionChanged): now uses Geolocation::hasListeners()
page/Geolocation.h: (WebCore::Geolocation::hasListeners): Indicates of the Geolocation has interested GeolocationService listeners
platform/GeolocationService.h: (WebCore::GeolocationService::suspend): empty implementation (WebCore::GeolocationService::resume): empty implementation

6:54 PM Changeset in webkit [38017] by ddkilzer@apple.com

7 edits in trunk/WebCore

2008-10-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig

https://bugs.webkit.org/show_bug.cgi?id=21966

The Geolocation spec was updated on 10/27/2008. This brings WebCore up to date.
http://dev.w3.org/geo/api/spec-source.html

page/Geolocation.cpp: (WebCore::Geolocation::GeoNotifier::GeoNotifier): PositionOptions' timeout now unsigned
page/Geoposition.cpp: velocity is now called speed (WebCore::Geoposition::toString):
page/Geoposition.h: velocity is now called speed (WebCore::Geoposition::create): (WebCore::Geoposition::speed): (WebCore::Geoposition::Geoposition):
page/Geoposition.idl: velocity is now called speed
page/PositionOptions.h: timeout is now unsigned (WebCore::PositionOptions::create): (WebCore::PositionOptions::timeout): (WebCore::PositionOptions::setTimeout): (WebCore::PositionOptions::PositionOptions):
page/PositionOptions.idl: timeout is now unsigned long

5:12 PM Changeset in webkit [38016] by weinig@apple.com

12 edits
1 move
1 delete in trunk/JavaScriptCore

2008-10-30 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich and Geoffrey Garen.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21989
Merge PropertyMap and StructureID

Move PropertyMap code into StructureID in preparation for lazily creating the map on gets.
Make remove with transition explicit by adding removePropertyTransition.
Make the put/remove without transition explicit.
Make cache invalidation part of put/remove without transition.

1% speedup on SunSpider; 0.5% speedup on v8 suite.

GNUmakefile.am:
JavaScriptCore.exp:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
kjs/AllInOneFile.cpp:
kjs/identifier.h:
runtime/JSObject.cpp: (JSC::JSObject::removeDirect):
runtime/JSObject.h: (JSC::JSObject::putDirect):
runtime/PropertyMap.cpp: Removed.
runtime/PropertyMap.h: Removed.
runtime/PropertyMapHashTable.h: Copied from runtime/PropertyMap.h.
runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics): (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID): (JSC::StructureID::getEnumerablePropertyNames): (JSC::StructureID::addPropertyTransition): (JSC::StructureID::removePropertyTransition): (JSC::StructureID::toDictionaryTransition): (JSC::StructureID::changePrototypeTransition): (JSC::StructureID::getterSetterTransition): (JSC::StructureID::addPropertyWithoutTransition): (JSC::StructureID::removePropertyWithoutTransition): (JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger): (JSC::StructureID::checkConsistency): (JSC::StructureID::copyPropertyTable): (JSC::StructureID::get): (JSC::StructureID::put): (JSC::StructureID::remove): (JSC::StructureID::insertIntoPropertyMapHashTable): (JSC::StructureID::expandPropertyMapHashTable): (JSC::StructureID::createPropertyMapHashTable): (JSC::StructureID::rehashPropertyMapHashTable): (JSC::comparePropertyMapEntryIndices): (JSC::StructureID::getEnumerablePropertyNamesInternal):
runtime/StructureID.h: (JSC::StructureID::propertyStorageSize): (JSC::StructureID::isEmpty): (JSC::StructureID::get):

5:11 PM Changeset in webkit [38015] by justin.garcia@apple.com

3 edits
2 adds in trunk

WebCore:

2008-10-30 Justin Garcia <justin.garcia@apple.com>

Also handle preserved newlines.

editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):

LayoutTests:

2008-10-30 Justin Garcia <justin.garcia@apple.com>

Added another layout test for previous check-in.

editing/inserting/6104369-2-expected.txt: Added.
editing/inserting/6104369-2.html: Added.

4:46 PM Changeset in webkit [38014] by justin.garcia@apple.com

3 edits
2 adds in trunk

WebCore:

2008-10-30 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line

editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Don't store the endingSelection() in selection, just call endingSelection() in the few places it's needed. This function is cheap since it just returns a reference to a Selection instead of creating one. Don't store an affinity. In the one place that it was used, isLastVisiblePositionInNode(VisiblePosition(pos, affinity), topBlockquote), we now use visiblePos (in order to avoid VisiblePosition creation). Set pos after we delete the current selection (if there is one), and be consistent about what we set pos to. Before, we upstream()ed it if there was a selection to delete and left it alone otherwise. In fact... ...we need to use downstream() for pos so that when a caret is at the boundary between two nodes, pos is in the first node that we want to move. This fixes the bug, since it lets code that checks for the case where the caret is between text and a br work correctly.

LayoutTests:

2008-10-30 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line

editing/inserting/6104369-expected.txt: Added.
editing/inserting/6104369.html: Added.

4:36 PM Changeset in webkit [38013] by mitz@apple.com

2 edits in trunk/WebKitTools

2008-10-30 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

Fixed 64 bit build failure.

DumpRenderTree/mac/PixelDumpSupportMac.mm: (setupMainDisplayColorProfile): (createBitmapContextFromWebView):

3:16 PM Changeset in webkit [38012] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-30 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 21987: CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result register
<https://bugs.webkit.org/show_bug.cgi?id=21987>

CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result
register as ecx, but it should be tempReg1, which is ecx at all of its
callsites.

VM/CTI.cpp: (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):

2:22 PM Changeset in webkit [38011] by alp@webkit.org

2 edits in trunk

2008-10-30 Alp Toker <alp@nuanti.com>

https://bugs.webkit.org/show_bug.cgi?id=19395
doltlibtool bug with bash 3.0

autotools dolt build fix for bash version 3.0 and older. Remove
concatenation syntax from doltlibtool to support the older versions
which don't have '+='.

acinclude.m4:

2:17 PM Changeset in webkit [38010] by Darin Adler

2 edits in trunk/WebKit/win

2008-10-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21986 <rdar://problem/6294285> adopt CFURLCopySharedURLCache

WebView.cpp: (WebView::setCacheModel): Use CFURLCopySharedURLCache if present.

2:16 PM Changeset in webkit [38009] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-30 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Bug 21985: Opcodes should use eax as their destination register whenever possible
<https://bugs.webkit.org/show_bug.cgi?id=21985>

Change more opcodes to use eax as the register for their final result,
and change calls to emitPutResult() that pass eax to rely on the default
value of eax.

VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):

2:13 PM Changeset in webkit [38008] by mitz@apple.com

898 edits
8 adds in trunk/LayoutTests

2008-10-30 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21821

Imported new image bases for a representative set of pixel tests in order to
fully validate latest DRT and test script changes. These results were generated
by a release build of r38003 on an Intel iMac running Mac OS X 10.5.5 with
QuickTime 7.5.5.

(file listing elided)

1:52 PM Changeset in webkit [38007] by Darin Adler

1 edit in trunk/WebCore/ChangeLog

Fix mismerged change log.

1:45 PM Changeset in webkit [38006] by vestbo@webkit.org

3 edits in trunk/WebCore

2008-10-30 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Fix the Qt build.

https://bugs.webkit.org/show_bug.cgi?id=21969

1:24 PM Changeset in webkit [38005] by mitz@apple.com

2 edits in trunk/WebKit/win

Reviewed by Sam Weinig.

export WTFReportAssertionFailureWithMessage()

WebKit.vcproj/WebKit_debug.def:

1:06 PM Changeset in webkit [38004] by justin.garcia@apple.com

2 edits in trunk/WebCore

2008-10-30 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

More preparation for:
<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line

editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Added comments. Don't need to use newStartNode. If the startNode needs to change, change it. Afterwords, check to make sure that it hasn't left topBlockquote. This is slightly stricter than before, where we just made sure that it still had a topBlockquote. This doesn't really fix a bug, since we can't really get into a situation where we move to a different topBlockquote, but it simplifies the code.

12:18 PM Changeset in webkit [38003] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2008-10-30 Alp Toker <alp@nuanti.com>

Reviewed by Dave Hyatt.

Fix GIF animations. WebCore will not update animated GIFs if
the WebView is marked offscreen so we need to call
frameView->setParentVisible() when necessary like the Mac and Win
ports do. Regression was introduced around r37155 during the
HostWindow refactor.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

11:12 AM Changeset in webkit [38002] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-10-29 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::~WebNetscapePluginStream): (WebNetscapePluginStream::start):

8:34 AM ApplicationsGtk edited by pierre-luc.beaudoin@collabora.co.uk

Add Empathy to the list of apps (diff)

7:09 AM Changeset in webkit [38001] by alp@webkit.org

4 edits in trunk/WebCore

2008-10-30 Dirk Schulze <vbs85@gmx.de>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=21883
[CAIRO] globalAlpha has to be stored and restored

Cairo's globalAlpha has to be stored and reloaded on calling
save() and restore(). We use the power of GraphicsContextState for this.

platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState):
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::getAlpha):
platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

6:42 AM Changeset in webkit [38000] by alp@webkit.org

3 edits in trunk/WebKit/gtk

2008-10-30 Alp Toker <alp@nuanti.com>

Rubber-stamped by Holger Freyther.

Fix typo in recently added web inspector signal. dettach -> detach.

WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::detachWindow):
webkit/webkitwebinspector.cpp: (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):

6:01 AM Changeset in webkit [37999] by alp@webkit.org

1 edit in trunk/JavaScriptCore/VM/Machine.cpp

Back out redundant build fix attempt r37997. The correct fix is r37998.

5:37 AM Changeset in webkit [37998] by alp@webkit.org

1 edit in trunk/JavaScriptCore/VM/Machine.h

Try naming VoidPtrPair struct to fix old gcc/MSVC builds

3:45 AM Changeset in webkit [37997] by alp@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-30 Alp Toker <alp@nuanti.com>

Build fix attempt for older gcc on the trunk-mac-intel build bot
(error: initializer for scalar variable requires one element).

Modify the initializer syntax slightly with an additional comma.

VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_post_dec):

2:56 AM Changeset in webkit [37996] by alp@webkit.org

2 edits in trunk

2008-10-30 Alp Toker <alp@nuanti.com>

Rubber-stamped by Oliver Hunt.

autotools build system change to enable JIT features by default. Can
be disabled with --disable-jit (and is disabled automatically on
unsupported platforms).

configure.ac:

2:35 AM Changeset in webkit [37995] by alp@webkit.org

3 edits in trunk/JavaScriptCore

2008-10-30 Alp Toker <alp@nuanti.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=21571
VoidPtrPair breaks CTI on Linux

The VoidPtrPair return change made in r37457 does not work on Linux
since POD structs aren't passed in registers.

This patch uses a union to vectorize VoidPtrPair to a uint64_t and
matches Darwin/MSVC fixing CTI/WREC on Linux.

Alexey reports no measurable change in Mac performance with this fix.

VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_post_dec):
VM/Machine.h: (JSC::):

1:55 AM Changeset in webkit [37994] by ap@webkit.org

3 edits in trunk/WebCore

Finish landing the previous renaming, createInlineEventHandler->createInlineEventListener (the files remained unsaved in Xcode).

1:41 AM Changeset in webkit [37993] by ap@webkit.org

35 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Rename "attachedToEventTargetNode" to "isInline".

Inline (onXXX) attributes are used not just with event target nodes, but also with Window,
XMLHttpRequest, MessagePort et al.

Also renamed createHTMLEventHandler() (which was a leftover from earlier isHTMLEvent ->
attachedToEventTargetNode rename made for SVG) to createInlineEventListener().
And also renamed EventTargetNode, Document and Window "eventListenerForType" methods to
"inlineEventListenerForType", as they work with inline listeners.

bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::setOnmessage): (WebCore::JSMessagePort::setOnclose):
bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener): Pass a correct value for this argument - callers used to be confused, because they didn't consider themselves event target nodes. This doesn't affect behavior however, as the only difference between inline and non-inline event handlers is that the former treat "return false" as "event.preventDefault()", which is not important to any of these objects.

bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Assert that isInline is true instead of checking its value, as the constructor of this class always sets it to true.

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase): (WebCore::JSDOMWindowBase::findJSEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener): (WebCore::JSDOMWindowBase::jsInlineEventListeners): (WebCore::JSDOMWindowBase::jsUnprotectedInlineEventListeners):
bindings/js/JSDOMWindowBase.h:
bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSAbstractEventListener::isInline): (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSLazyEventListener::parseCode):
bindings/js/JSEventListener.h: (WebCore::JSAbstractEventListener::JSAbstractEventListener): (WebCore::JSUnprotectedEventListener::create): (WebCore::JSEventListener::create):
bindings/js/ScriptController.cpp: (WebCore::ScriptController::createInlineEventHandler):
bindings/js/ScriptController.h:
dom/Document.cpp: (WebCore::Document::setWindowInlineEventListenerForType): (WebCore::Document::windowInlineEventListenerForType): (WebCore::Document::removeWindowInlineEventListenerForType): (WebCore::Document::createEventListener): (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute):
dom/Document.h:
dom/EventListener.h: (WebCore::EventListener::isInline):
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::removeInlineEventListenerForType): (WebCore::EventTargetNode::setInlineEventListenerForType): (WebCore::EventTargetNode::setInlineEventListenerForTypeAndAttribute): (WebCore::EventTargetNode::inlineEventListenerForType): (WebCore::EventTargetNode::on*): (many methods) (WebCore::EventTargetNode::setOn*): (many methods)
dom/EventTargetNode.h:
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::parseMappedAttribute):
html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::parseMappedAttribute):
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute):
html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute):
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::mouseButtonListener):
page/DOMWindow.cpp: (WebCore::DOMWindow::setInlineEventListenerForType): (WebCore::DOMWindow::inlineEventListenerForType): (WebCore::DOMWindow::on*): (many methods) (WebCore::DOMWindow::setOn*): (many methods)
page/DOMWindow.h:
svg/SVGElement.cpp: (WebCore::SVGElement::parseMappedAttribute):
svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::on*): (many methods) (WebCore::SVGElementInstance::setOn*): (many methods)
svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute): Rename things, as described above.

1:24 AM Changeset in webkit [37992] by alp@webkit.org

6 edits in trunk

2008-10-30 Alp Toker <alp@nuanti.com>

Bump WebKit GTK+ version to 1.0.3.

Fix version comments for the web inspector added in r37982. Available
since 1.0.3, not 1.0.2.

Oct 29, 2008:

9:33 PM Changeset in webkit [37991] by oliver@apple.com

13 edits in trunk/JavaScriptCore

Initial work to reduce cost of JSNumberCell allocation

Reviewed by Geoffrey Garen

This does the initial work needed to bring more of number
allocation into CTI code directly, rather than just falling
back onto the slow paths if we can't guarantee that a number
cell can be reused.

Initial implementation only used by op_negate to make sure
it all works. In a negate heavy (though not dominated) test
it results in a 10% win in the non-reusable cell case.

8:38 PM Changeset in webkit [37990] by sfalken@apple.com

6 edits in trunk

JavaScriptCore:

2008-10-29 Steve Falkenburg <sfalken@apple.com>

<rdar://problem/6326563> Crash on launch

For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.

Exporting data from a DLL on Windows requires specifying declspec(dllimport) in the header used by
callers, but declspec(dllexport) when defined in the DLL implementation. By instead exporting
the explicit lock/unlock functions, we can avoid this.

Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.

Reviewed by Darin Adler.

wtf/Threading.h: (WTF::lockAtomicallyInitializedStaticMutex): (WTF::unlockAtomicallyInitializedStaticMutex):
wtf/ThreadingWin.cpp: (WTF::lockAtomicallyInitializedStaticMutex): (WTF::unlockAtomicallyInitializedStaticMutex):

WebKit/win:

2008-10-29 Steve Falkenburg <sfalken@apple.com>

<rdar://problem/6326563> Crash on launch

For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.

Exporting data from a DLL on Windows requires specifying declspec(dllimport) in the header used by
callers, but declspec(dllexport) when defined in the DLL implementation. By instead exporting
the explicit lock/unlock functions, we can avoid this.

Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.

Reviewed by Darin Adler.

WebKit.vcproj/WebKit.def:
WebKit.vcproj/WebKit_debug.def:

7:44 PM Changeset in webkit [37989] by weinig@apple.com

9 edits in trunk/JavaScriptCore

2008-10-29 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Remove direct use of PropertyMap.

JavaScriptCore.exp:
runtime/JSObject.cpp: (JSC::JSObject::mark): (JSC::JSObject::put): (JSC::JSObject::deleteProperty): (JSC::JSObject::getPropertyAttributes): (JSC::JSObject::removeDirect):
runtime/JSObject.h: (JSC::JSObject::getDirect): (JSC::JSObject::getDirectLocation): (JSC::JSObject::hasCustomProperties): (JSC::JSObject::JSObject): (JSC::JSObject::putDirect):
runtime/PropertyMap.cpp: (JSC::PropertyMap::get):
runtime/PropertyMap.h: (JSC::PropertyMap::isEmpty): (JSC::PropertyMap::get):
runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics):
runtime/StructureID.h: (JSC::StructureID::propertyStorageSize): (JSC::StructureID::get): (JSC::StructureID::put): (JSC::StructureID::remove): (JSC::StructureID::isEmpty):

6:38 PM Changeset in webkit [37988] by pewtermoose@webkit.org

2 edits in trunk/WebKit

2008-10-29 Matt Lilek <webkit@mattlilek.com>

Not reviewed, build fix.

WebKit.xcodeproj/project.pbxproj:

5:49 PM Changeset in webkit [37987] by andersca@apple.com

2 edits in trunk/WebKit/mac

2008-10-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove an unused forward class declaration.

Plugins/WebBaseNetscapePluginView.h:

5:46 PM Changeset in webkit [37986] by andersca@apple.com

7 edits
2 deletes in trunk/WebKit/mac

2008-10-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove WebBaseNetscapePluginViewInternal.h and WebBaseNetscapePluginViewPrivate.h.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginViewInternal.h: Removed.
Plugins/WebBaseNetscapePluginViewPrivate.h: Removed.
Plugins/WebNetscapePluginEventHandler.mm:
Plugins/WebNetscapePluginEventHandlerCarbon.mm:
Plugins/WebNetscapePluginEventHandlerCocoa.mm:
Plugins/npapi.mm:
WebView/WebHTMLView.mm:

4:52 PM Changeset in webkit [37985] by weinig@apple.com

6 edits
1 copy in trunk/JavaScriptCore

2008-10-29 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Rename and move the StructureID transition table to its own file.

GNUmakefile.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/StructureID.cpp: (JSC::StructureID::addPropertyTransition):
runtime/StructureID.h: (JSC::StructureID::):
runtime/StructureIDTransitionTable.h: Copied from runtime/StructureID.h. (JSC::StructureIDTransitionTableHash::hash): (JSC::StructureIDTransitionTableHash::equal):

4:47 PM Changeset in webkit [37984] by andersca@apple.com

8 edits
4 deletes in trunk/WebKit/mac

2008-10-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove WebNetscapePluginEmbeddedView, it adds nothing extra now.

Remove WebNetscapePlugInStreamLoaderClient since WebNetscapePluginStream is the client now.

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.mm:
Plugins/WebBaseNetscapePluginView.h:
Plugins/WebKitPluginContainerView.h:
Plugins/WebNetscapePluginEmbeddedView.h: Removed.
Plugins/WebNetscapePluginEmbeddedView.mm: Removed.
Plugins/WebNetscapePluginEventHandler.h:
WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): (WebFrameLoaderClient::createPlugin):
WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Removed.
WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Removed.
WebView/WebHTMLView.mm: (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):

3:53 PM Changeset in webkit [37983] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-10-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove the WebBaseNetscapePluginStream Objective-C object.

Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create):
Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

3:39 PM Changeset in webkit [37982] by zecke@webkit.org

13 edits
2 adds in trunk

2008-10-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Added all the files that need to be installed for the Inspector to
work.

WebCore/ChangeLog:
2008-10-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed and slightly changed by Holger Freyther.

Added all the files that need to be installed for the Inspector to
work.

GNUmakefile.am: Invoke the shell to get the files.

WebKit/gtk:
2008-10-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed and slightly changed by Holger Freyther.

Implemented a new WebKitWebInspector class to provide a GObject
API for the Web Inspector. Also implemented InspectorClient.

WebCoreSupport/InspectorClientGtk.cpp: (WebKit::notifyWebViewDestroyed): (WebKit::InspectorClient::InspectorClient): (WebKit::InspectorClient::inspectorDestroyed): (WebKit::InspectorClient::webViewDestroyed): (WebKit::InspectorClient::createPage): (WebKit::InspectorClient::showWindow): (WebKit::InspectorClient::closeWindow): (WebKit::InspectorClient::attachWindow): (WebKit::InspectorClient::detachWindow): (WebKit::InspectorClient::inspectedURLChanged):
WebCoreSupport/InspectorClientGtk.h:
webkit/webkit.h:
webkit/webkit-marshal.list:
webkit/webkitdefines.h:
webkit/webkitprivate.h:
webkit/webkitwebinspector.cpp: Added. (_WebKitWebInspectorPrivate::webkit_inspect_web_view_request_handled): (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init): (_WebKitWebInspectorPrivate::webkit_web_inspector_init): (_WebKitWebInspectorPrivate::webkit_web_inspector_finalize): (_WebKitWebInspectorPrivate::webkit_web_inspector_set_property): (_WebKitWebInspectorPrivate::webkit_web_inspector_get_property): (_WebKitWebInspectorPrivate::webkit_web_inspector_set_web_view):
webkit/webkitwebinspector.h: Added.
webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
webkit/webkitwebview.cpp:
webkit/webkitwebview.h:

3:27 PM Changeset in webkit [37981] by weinig@apple.com

4 edits in trunk/JavaScriptCore

2008-10-29 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21958
Pack bits in StructureID to reduce the size of each StructureID by 2 words.

runtime/PropertyMap.h: (JSC::PropertyMap::propertyMapSize):
runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics): Add additional size statistics when dumping. (JSC::StructureID::StructureID):
runtime/StructureID.h:

2:45 PM Changeset in webkit [37980] by darin@chromium.org

2 edits in trunk/WebCore

2008-10-29 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Darin Adler

Add MediaPlayerPrivateChromium to MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=21930

platform/graphics/MediaPlayer.cpp:

2:43 PM Changeset in webkit [37979] by justin.garcia@apple.com

2 edits in trunk/WebCore

2008-10-29 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

Some preparation for:
<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line

Added an early return to avoid a level of if-nesting. No other changes. We probably don't
need to rebalance whitespace before the early return but for now don't risk any change in behavior
I'll revisit that later.

editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):

2:21 PM Changeset in webkit [37978] by jhoneycutt@apple.com

3 edits in trunk/WebKit/win

2008-10-29 Jon Honeycutt <jhoneycutt@apple.com>

Export atomicallyInitializedStaticMutex.

Rubber-stamped by Steve Falkenburg.

WebKit.vcproj/WebKit.def:
WebKit.vcproj/WebKit_debug.def:

1:19 PM Changeset in webkit [37977] by zecke@webkit.org

3 edits in trunk

2008-10-29 Mike Hommey <glandium@debian.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=21884
Test presence and link against libpng.

GNUmakefile.am:
configure.ac:

1:13 PM Changeset in webkit [37976] by kevino@webkit.org

8 edits
1 add in trunk

wx build fixes after addition of runtime and ImageBuffer changes.

12:59 PM Changeset in webkit [37975] by beidson@apple.com

3 edits in trunk/WebKit/mac

2008-10-29 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

https://bugs.webkit.org/show_bug.cgi?id=21952

Address an outstanding FIXME by removing unused SPI

History/WebHistory.mm: (-[WebHistory _addItemForURL:title:]): Fold addItem: into this method

History/WebHistoryPrivate.h: Removed unused/unneccessary SPI

12:34 PM Changeset in webkit [37974] by jmalonzo@webkit.org

3 edits in trunk

2008-10-29 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Add --enable-optimizations to enable optimized builds. The default
is to enable it for release builds, and disabled for debug builds.
This option will allow builders to have a debug as well as
optimized builds.

GNUmakefile.am:
configure.ac:

9:38 AM Changeset in webkit [37973] by brettw@chromium.org

2 edits in trunk/WebCore

Allow Skia implementations to get text style changed notifications.

8:19 AM Web Inspector edited by dmitrykichenko@gmail.com

(diff)

8:18 AM Web Inspector edited by dmitrykichenko@gmail.com

The instructions here did not work for me but adding the key into … (diff)

8:02 AM Changeset in webkit [37972] by timothy@apple.com

3 edits
1 add in trunk

Emit the WillExecuteStatement debugger hook before the "else" body when there is no block for the "else" body. This allows breakpoints on those statements in the Web Inspector.

JavaScriptCore:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Emit the WillExecuteStatement debugger hook before the "else" body
when there is no block for the "else" body. This allows breakpoints
on those statements in the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=21944

Reviewed by Maciej Stachowiak.

kjs/nodes.cpp: (JSC::IfElseNode::emitCode): Emit the WillExecuteStatement debugger hook before the else node if isn't a block.

WebCore:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Add a manual test that checks breakpoints on a blockless body of
an "else" statement.

https://bugs.webkit.org/show_bug.cgi?id=21944

Reviewed by Maciej Stachowiak.

manual-tests/inspector/debugger-pause-on-else-statements.html: Added.

3:44 AM Changeset in webkit [37971] by ap@webkit.org

4 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21921
MessagePort messages are dispatched to documents that are not fully active

Covered by corrected fast/events/message-port-inactive-document.html

bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): Don't dispatch messages to contexts that are not fully active.

3:40 AM Changeset in webkit [37970] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Build fix.

JavaScriptCore.exp: Export HashTable::deleteTable().

3:37 AM Changeset in webkit [37969] by ap@webkit.org

6 edits in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21922
Expose MessagePort global constructor

Covered by existing dumper tests.

dom/MessagePort.idl:
page/DOMWindow.idl:

3:35 AM Changeset in webkit [37968] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21924
HashTable internal index is not always deleted

bindings/js/JSDOMBinding.cpp: (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap): Call deleteTable for HashTables that are being deleted.

3:31 AM Changeset in webkit [37967] by ap@webkit.org

3 edits in trunk/LayoutTests/platform/mac/svg/carto.net

Missed these files in an earlier check-in for <https://bugs.webkit.org/show_bug.cgi?id=21893>.

3:26 AM Changeset in webkit [37966] by ap@webkit.org

35 edits
2 adds in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21923
Create an abstraction for script execution context

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl: Added ScriptExecutionContext.{h,cpp}.

bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
bindings/js/JSAudioConstructor.h:
bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
bindings/js/JSImageConstructor.h:
bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
bindings/js/JSOptionConstructor.h:
bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
bindings/js/JSXMLHttpRequestConstructor.h: Pass ScriptExecutionContext instead of Document to make getDOMConstructor() happy. Since these objects can only work within documents now, it is immediately converted back to Document.

bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): (WebCore::JSMessageChannelConstructor::construct):
bindings/js/JSMessageChannelConstructor.h: (WebCore::JSMessageChannelConstructor::scriptExecutionContext): MessageChannel needs to be supported in workers right away, so the constructor operates with it directly.

dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::ActiveDOMObject): (WebCore::ActiveDOMObject::~ActiveDOMObject): (WebCore::ActiveDOMObject::contextDestroyed):
dom/ActiveDOMObject.h: (WebCore::ActiveDOMObject::scriptExecutionContext):
bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): (WebCore::markCrossHeapDependentObjectsForContext): Use ScriptExecutionContext instead of Document, now that ActiveDOMObject and MessagePort tracking is handled by ScriptExecutionContext.

bindings/js/JSDOMBinding.h: (WebCore::getDOMPrototype): Moved to JSDOMGlobalObject.

bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor): Moved to this file, as constructors live in JSDOMGlobalObject. Also, the two-argument version that used to be in JSDOMWindowBase.cpp need to be accessible to worker context implementation. (WebCore::scriptExecutionContext): Added a pure virtual method to access ScriptExecutionContext, implemented by subclasses.

bindings/js/JSDOMWindowBase.h:
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::scriptExecutionContext): Implement by returning the associated document. Note that this method currently gives bogus results after navigation - DOMWindow Frame reference is not zeroed out, so we get a document that is currently in the frame, not the one associated with this window.

bindings/js/JSDedicatedWorkerConstructor.cpp: Removed unnecessary include of DOMWindow.h.

bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): Call markActiveObjectsForContext() by its new name.

dom/DedicatedWorker.cpp: (WebCore::DedicatedWorker::DedicatedWorker): (WebCore::DedicatedWorker::document):
dom/DedicatedWorker.h:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::document):
xml/XMLHttpRequest.h: Added a document() function that upcasts ScriptExecutionContext, as these objects only work within documents currently (at least for XMLHttpRequest, this will change soon though).

dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): Moved active object and MessagePort tracking up to ScriptExecutionContext, to share code with workers.

dom/Document.h: (WebCore::Document::isDocument): (WebCore::Document::refScriptExecutionContext): (WebCore::Document::derefScriptExecutionContext): Inherit from ScriptExecutionContext.

dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):
dom/MessageChannel.h: (WebCore::MessageChannel::create): Use ScriptExecutionContext instead of Document.

dom/MessagePort.cpp: (WebCore::CloseMessagePortTimer::CloseMessagePortTimer): Make m_port a RefPtr, because MessagePort doesn't ref() itself when posting this event any more (this is a fix for an unrelated issue that was causing random crashes in layout tests). (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::associatedFrame): (WebCore::MessagePort::clone): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::startConversation): (WebCore::MessagePort::start): (WebCore::MessagePort::contextDestroyed): (WebCore::MessagePort::dispatchMessages):
dom/MessagePort.h: (WebCore::MessagePort::create): (WebCore::MessagePort::scriptExecutionContext): Use ScriptExecutionContext instead of Document. This is a step toward making MessagePort work in worker contexts - we need to also make some its method thread safe for cross-thread messaging, and make event dispatching thread safe.

dom/ScriptExecutionContext.cpp: Added.
dom/ScriptExecutionContext.h: Added. ActiveDOMObject and MessagePort tracking is moved from Document. It is debatable whether ScriptExecutionContext should be a parent of Document or DOMWindow, but as I'm just moving Document code, and it is Document that is the main context object in our implementation currently. Changing ScriptExecutionContext to be a parent of DOMWindow causes a number of bugs that seem non-trivial to fix, and isn't really a part of this task.

Oct 28, 2008:

11:01 PM Changeset in webkit [37965] by timothy@apple.com

1 edit in trunk/WebKit/win/Interfaces/IWebInspector.idl

Attempt to fix the Windows build.

10:28 PM Changeset in webkit [37964] by timothy@apple.com

1 edit in trunk/WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp

Attempt to fix the Windows build.

10:22 PM Changeset in webkit [37963] by alp@webkit.org

4 edits in trunk

2008-10-28 Alp Toker <alp@nuanti.com>

Fix builddir != srcdir builds after kjs -> runtime breakage. Sources
may now be generated in both kjs/ and runtime/.

Also sort the sources list for readability.

List newly-added ImageBufferData.h in build system.

9:47 PM Changeset in webkit [37962] by alp@webkit.org

2 edits in trunk/WebKitTools

2008-10-28 Alp Toker <alp@nuanti.com>

Fix GTK DRT following build breakage in r37928.

DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest): (main):

9:42 PM Changeset in webkit [37961] by timothy@apple.com

1 edit in trunk/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp

Attempt to fix the Windows build.

8:20 PM Changeset in webkit [37960] by alp@webkit.org

4 edits in trunk

2008-10-28 Alp Toker <alp@nuanti.com>

Reviewed by Cameron Zwarich.

Build fix attempt after kjs -> runtime rename.

De-list unused WebCore ForwardingHeaders to fix the dist target.

8:02 PM Changeset in webkit [37959] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Remove a duplicate includes directory.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

7:41 PM Changeset in webkit [37958] by cwzwarich@webkit.org

5 edits in trunk

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Attempt to fix the Windows build.

JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/jsc/jsc.vcproj:

WebCore:

WebCore.vcproj/WebCore.vcproj:

7:07 PM Changeset in webkit [37957] by justin.garcia@apple.com

5 edits in trunk

WebCore:

2008-10-28 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored

editing/Editor.cpp: (WebCore::Editor::ignoreSpelling): Remove misspelling markers from the word. (WebCore::Editor::learnSpelling): Added a FIXME about <rdar://problem/5396072>, which will probably require a change more complicated than just marking the learned word as misspelled. I'll address it with a separate patch.
editing/EditorCommand.cpp: (WebCore::executeIgnoreSpelling): Added. (WebCore::CommandEntry::): Added an entry for IgnoreSpelling.

WebKit/mac:

2008-10-28 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored

WebView/WebHTMLView.mm: IgnoreSpelling is now a WebCore command. That command handles calling back into WebKit to perform the cross platform work that was removed in this change.

6:54 PM Changeset in webkit [37956] by cwzwarich@webkit.org

77 edits
27 moves
2 adds in trunk

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Reviewed by Mark Rowe.

Move ForwardingHeaders to their correct location after the creation of
the runtime directory in JavaScriptCore.

WebCore:

ForwardingHeaders/kjs/ArrayPrototype.h: Removed.
ForwardingHeaders/kjs/BooleanObject.h: Removed.
ForwardingHeaders/kjs/CallData.h: Removed.
ForwardingHeaders/kjs/ConstructData.h: Removed.
ForwardingHeaders/kjs/DateInstance.h: Removed.
ForwardingHeaders/kjs/Error.h: Removed.
ForwardingHeaders/kjs/FunctionConstructor.h: Removed.
ForwardingHeaders/kjs/FunctionPrototype.h: Removed.
ForwardingHeaders/kjs/InternalFunction.h: Removed.
ForwardingHeaders/kjs/JSArray.h: Removed.
ForwardingHeaders/kjs/JSFunction.h: Removed.
ForwardingHeaders/kjs/JSGlobalObject.h: Removed.
ForwardingHeaders/kjs/JSNumberCell.h: Removed.
ForwardingHeaders/kjs/JSObject.h: Removed.
ForwardingHeaders/kjs/JSString.h: Removed.
ForwardingHeaders/kjs/JSValue.h: Removed.
ForwardingHeaders/kjs/ObjectPrototype.h: Removed.
ForwardingHeaders/kjs/PropertyMap.h: Removed.
ForwardingHeaders/kjs/PrototypeFunction.h: Removed.
ForwardingHeaders/kjs/StringObject.h: Removed.
ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
ForwardingHeaders/kjs/StringPrototype.h: Removed.
ForwardingHeaders/kjs/StructureID.h: Removed.
ForwardingHeaders/runtime: Added.
ForwardingHeaders/runtime/ArrayPrototype.h: Copied from ForwardingHeaders/kjs/ArrayPrototype.h.
ForwardingHeaders/runtime/BooleanObject.h: Copied from ForwardingHeaders/kjs/BooleanObject.h.
ForwardingHeaders/runtime/CallData.h: Copied from ForwardingHeaders/kjs/CallData.h.
ForwardingHeaders/runtime/ConstructData.h: Copied from ForwardingHeaders/kjs/ConstructData.h.
ForwardingHeaders/runtime/DateInstance.h: Copied from ForwardingHeaders/kjs/DateInstance.h.
ForwardingHeaders/runtime/Error.h: Copied from ForwardingHeaders/kjs/Error.h.
ForwardingHeaders/runtime/FunctionConstructor.h: Copied from ForwardingHeaders/kjs/FunctionConstructor.h.
ForwardingHeaders/runtime/FunctionPrototype.h: Copied from ForwardingHeaders/kjs/FunctionPrototype.h.
ForwardingHeaders/runtime/InternalFunction.h: Copied from ForwardingHeaders/kjs/InternalFunction.h.
ForwardingHeaders/runtime/JSArray.h: Copied from ForwardingHeaders/kjs/JSArray.h.
ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
ForwardingHeaders/runtime/JSGlobalObject.h: Copied from ForwardingHeaders/kjs/JSGlobalObject.h.
ForwardingHeaders/runtime/JSNumberCell.h: Copied from ForwardingHeaders/kjs/JSNumberCell.h.
ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
ForwardingHeaders/runtime/ObjectPrototype.h: Copied from ForwardingHeaders/kjs/ObjectPrototype.h.
ForwardingHeaders/runtime/PropertyMap.h: Copied from ForwardingHeaders/kjs/PropertyMap.h.
ForwardingHeaders/runtime/PrototypeFunction.h: Copied from ForwardingHeaders/kjs/PrototypeFunction.h.
ForwardingHeaders/runtime/StringObject.h: Copied from ForwardingHeaders/kjs/StringObject.h.
ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h.
ForwardingHeaders/runtime/StringPrototype.h: Copied from ForwardingHeaders/kjs/StringPrototype.h.
ForwardingHeaders/runtime/StructureID.h: Copied from ForwardingHeaders/kjs/StructureID.h.
bindings/js/JSCSSStyleDeclarationCustom.cpp:
bindings/js/JSCanvasRenderingContext2DCustom.cpp:
bindings/js/JSClipboardCustom.cpp:
bindings/js/JSConsoleCustom.cpp:
bindings/js/JSCustomPositionCallback.h:
bindings/js/JSCustomPositionErrorCallback.h:
bindings/js/JSCustomSQLStatementCallback.h:
bindings/js/JSCustomSQLStatementErrorCallback.h:
bindings/js/JSCustomSQLTransactionErrorCallback.h:
bindings/js/JSCustomVoidCallback.h:
bindings/js/JSCustomXPathNSResolver.h:
bindings/js/JSDOMBinding.cpp:
bindings/js/JSDOMBinding.h:
bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowBase.cpp:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSDOMWindowShell.cpp:
bindings/js/JSDatabaseCustom.cpp:
bindings/js/JSEventListener.cpp:
bindings/js/JSEventTarget.h:
bindings/js/JSHTMLDocumentCustom.cpp:
bindings/js/JSHistoryCustom.cpp:
bindings/js/JSInspectedObjectWrapper.cpp:
bindings/js/JSJavaScriptCallFrameCustom.cpp:
bindings/js/JSLocationCustom.cpp:
bindings/js/JSNodeFilterCondition.h:
bindings/js/JSQuarantinedObjectWrapper.cpp:
bindings/js/JSQuarantinedObjectWrapper.h:
bindings/js/JSXMLHttpRequestCustom.cpp:
bindings/js/JSXMLHttpRequestUploadCustom.cpp:
bindings/objc/WebScriptObject.mm:
bindings/objc/WebScriptObjectPrivate.h:
bindings/scripts/CodeGeneratorJS.pm:
bridge/NP_jsobject.cpp:
bridge/c/c_instance.cpp:
bridge/c/c_utility.cpp:
bridge/c/c_utility.h:
bridge/jni/jni_instance.cpp:
bridge/jni/jni_jsobject.h:
bridge/jni/jni_jsobject.mm:
bridge/jni/jni_runtime.cpp:
bridge/jni/jni_utility.cpp:
bridge/jni/jni_utility.h:
bridge/objc/objc_instance.mm:
bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:
bridge/objc/objc_utility.h:
bridge/objc/objc_utility.mm:
bridge/runtime.h:
bridge/runtime_array.cpp:
bridge/runtime_array.h:
bridge/runtime_method.cpp:
bridge/runtime_method.h:
bridge/runtime_object.cpp:
bridge/runtime_object.h:
bridge/runtime_root.cpp:
inspector/JavaScriptCallFrame.cpp:
inspector/JavaScriptProfile.cpp:
inspector/JavaScriptProfile.h:
inspector/JavaScriptProfileNode.cpp:
inspector/JavaScriptProfileNode.h:
loader/FrameLoader.cpp:
page/Console.cpp:
plugins/PluginView.cpp:
plugins/gtk/PluginViewGtk.cpp:
plugins/qt/PluginViewQt.cpp:
plugins/win/PluginViewWin.cpp:

WebKit/mac:

ForwardingHeaders/kjs/JSFunction.h: Removed.
ForwardingHeaders/kjs/JSObject.h: Removed.
ForwardingHeaders/kjs/JSString.h: Removed.
ForwardingHeaders/kjs/JSValue.h: Removed.
ForwardingHeaders/runtime: Added.
ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
WebView/WebScriptDebugDelegate.mm:
WebView/WebScriptDebugger.mm:
WebView/WebView.mm:

WebKit/win:

WebScriptCallFrame.h:

WebKit/wx:

WebFrame.cpp:
WebView.cpp:

5:57 PM Changeset in webkit [37955] by mitz@apple.com

2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

export WTF::atomicallyInitializedStaticMutex

JavaScriptCore.exp:

5:37 PM Changeset in webkit [37954] by adele@apple.com

2 edits in trunk/WebCore

2008-10-28 Adele Peterson <adele@apple.com>

Windows build fix. This removes Cairo include directories from non-Cairbo build configurations.

WebCore.vcproj/WebCore.vcproj:

5:20 PM Changeset in webkit [37953] by adele@apple.com

2 edits in trunk/WebCore

2008-10-28 Adele Peterson <adele@apple.com>

Build fix.

platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create):

5:12 PM Changeset in webkit [37952] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Roll out a mistaken attempt at fixing the GTK build in r37947.

GNUmakefile.am:

5:11 PM Changeset in webkit [37951] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2005-10-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Fixed CodeBlock dumping to accurately report constant register indices.

VM/CodeBlock.cpp: (JSC::CodeBlock::dump):

5:04 PM Changeset in webkit [37950] by alp@webkit.org

2 edits in trunk/WebKitTools

2008-10-28 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

Fix recently introduced double-free crashes in GTK DRT.

LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
were updated to call ->deref() but GTK DRT was still deleting
gLayoutTestController manually. This patch updates GTK to match the
other ports and resolves the memory allocation issues.

DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest):

4:36 PM Changeset in webkit [37949] by adele@apple.com

15 edits in trunk

WebCore:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

page/mac/WebCoreViewFactory.h:
platform/LocalizedStrings.h:
platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
platform/gtk/LocalizedStringsGtk.cpp: (WebCore::multipleFileUploadText):
platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth):
platform/mac/LocalizedStringsMac.mm: (WebCore::multipleFileUploadText):
platform/qt/Localizations.cpp: (WebCore::multipleFileUploadText):
platform/wx/LocalizedStringsWx.cpp: (WebCore::multipleFileUploadText):

WebKit:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

English.lproj/Localizable.strings: Updated with new string.

WebKit/mac:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory multipleFileUploadTextForNumberOfFiles:]): Added.

WebKit/win:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
"files" string for multifile uploads needs to be localized

WebCoreLocalizedStrings.cpp: (multipleFileUploadText):

4:10 PM Changeset in webkit [37948] by brettw@chromium.org

6 edits
3 adds in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21816

Remove platform ifdefs in ImageBuffer.h by moving platform specific code
into a new PlatformImageBuffer class. Move the static create function
into the header because it can be cross-platform. Initialization now
happens in the cunstructor which sets a flag that create uses to know
whether it should return null or not. I also made passing of IntSize
more consistent (always by reference).

This change also changes the ifdefs in GraphicsContext to allow Skia
ports to implement text drawing modes.

3:22 PM Changeset in webkit [37947] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the GTK build.

GNUmakefile.am:

3:14 PM Changeset in webkit [37946] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Another Qt build fix.

WebCore.pro:

3:04 PM Changeset in webkit [37945] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

More Qt build fixes.

JavaScriptCore.pri:

2:59 PM Changeset in webkit [37944] by alp@webkit.org

2 edits in trunk/WebKitTools

2008-10-28 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

Fix GTK DRT hang when running the tests.

Update output from the DRT tool to print an additional '#EOF' to match
breaking changes that were made in r37434.

DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):

2:52 PM Changeset in webkit [37943] by timothy@apple.com

1 edit in trunk/WebKit/win/WebInspector.cpp

Windows build fix.

2:43 PM Changeset in webkit [37942] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the Qt build, hopefully for real this time.

JavaScriptCore.pri:

2:42 PM Changeset in webkit [37941] by ddkilzer@apple.com

2 edits in trunk/WebCore

2008-10-28 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=21932
Add non-pointer constant lookups to SoftLinking.h

platform/mac/SoftLinking.h:

2:36 PM Changeset in webkit [37940] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the Qt build.

JavaScriptCore.pri:

2:26 PM Changeset in webkit [37939] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the Windows build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

2:06 PM Changeset in webkit [37938] by cwzwarich@webkit.org

17 edits
99 moves
1 add in trunk/JavaScriptCore

2008-10-28 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Create a runtime directory in JavaScriptCore and begin moving files to
it. This is the first step towards removing the kjs directory and
placing files in more meaningful subdirectories of JavaScriptCore.

API/JSBase.cpp:
API/JSCallbackConstructor.cpp:
API/JSCallbackConstructor.h:
API/JSCallbackFunction.cpp:
API/JSClassRef.cpp:
API/JSClassRef.h:
API/JSStringRefCF.cpp:
API/JSValueRef.cpp:
API/OpaqueJSString.cpp:
DerivedSources.make:
GNUmakefile.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
kjs/AllInOneFile.cpp:
kjs/ArrayConstructor.cpp: Removed.
kjs/ArrayConstructor.h: Removed.
kjs/ArrayPrototype.cpp: Removed.
kjs/ArrayPrototype.h: Removed.
kjs/BooleanConstructor.cpp: Removed.
kjs/BooleanConstructor.h: Removed.
kjs/BooleanObject.cpp: Removed.
kjs/BooleanObject.h: Removed.
kjs/BooleanPrototype.cpp: Removed.
kjs/BooleanPrototype.h: Removed.
kjs/CallData.cpp: Removed.
kjs/CallData.h: Removed.
kjs/ClassInfo.h: Removed.
kjs/ConstructData.cpp: Removed.
kjs/ConstructData.h: Removed.
kjs/DateConstructor.cpp: Removed.
kjs/DateConstructor.h: Removed.
kjs/DateInstance.cpp: Removed.
kjs/DateInstance.h: Removed.
kjs/DateMath.cpp: Removed.
kjs/DateMath.h: Removed.
kjs/DatePrototype.cpp: Removed.
kjs/DatePrototype.h: Removed.
kjs/Error.cpp: Removed.
kjs/Error.h: Removed.
kjs/ErrorConstructor.cpp: Removed.
kjs/ErrorConstructor.h: Removed.
kjs/ErrorInstance.cpp: Removed.
kjs/ErrorInstance.h: Removed.
kjs/ErrorPrototype.cpp: Removed.
kjs/ErrorPrototype.h: Removed.
kjs/FunctionConstructor.cpp: Removed.
kjs/FunctionConstructor.h: Removed.
kjs/FunctionPrototype.cpp: Removed.
kjs/FunctionPrototype.h: Removed.
kjs/GlobalEvalFunction.cpp: Removed.
kjs/GlobalEvalFunction.h: Removed.
kjs/InternalFunction.cpp: Removed.
kjs/InternalFunction.h: Removed.
kjs/JSArray.cpp: Removed.
kjs/JSArray.h: Removed.
kjs/JSCell.cpp: Removed.
kjs/JSCell.h: Removed.
kjs/JSFunction.cpp: Removed.
kjs/JSFunction.h: Removed.
kjs/JSGlobalObject.cpp: Removed.
kjs/JSGlobalObject.h: Removed.
kjs/JSGlobalObjectFunctions.cpp: Removed.
kjs/JSGlobalObjectFunctions.h: Removed.
kjs/JSImmediate.cpp: Removed.
kjs/JSImmediate.h: Removed.
kjs/JSNotAnObject.cpp: Removed.
kjs/JSNotAnObject.h: Removed.
kjs/JSNumberCell.cpp: Removed.
kjs/JSNumberCell.h: Removed.
kjs/JSObject.cpp: Removed.
kjs/JSObject.h: Removed.
kjs/JSString.cpp: Removed.
kjs/JSString.h: Removed.
kjs/JSValue.cpp: Removed.
kjs/JSValue.h: Removed.
kjs/JSVariableObject.cpp: Removed.
kjs/JSVariableObject.h: Removed.
kjs/JSWrapperObject.cpp: Removed.
kjs/JSWrapperObject.h: Removed.
kjs/MathObject.cpp: Removed.
kjs/MathObject.h: Removed.
kjs/NativeErrorConstructor.cpp: Removed.
kjs/NativeErrorConstructor.h: Removed.
kjs/NativeErrorPrototype.cpp: Removed.
kjs/NativeErrorPrototype.h: Removed.
kjs/NumberConstructor.cpp: Removed.
kjs/NumberConstructor.h: Removed.
kjs/NumberObject.cpp: Removed.
kjs/NumberObject.h: Removed.
kjs/NumberPrototype.cpp: Removed.
kjs/NumberPrototype.h: Removed.
kjs/ObjectConstructor.cpp: Removed.
kjs/ObjectConstructor.h: Removed.
kjs/ObjectPrototype.cpp: Removed.
kjs/ObjectPrototype.h: Removed.
kjs/PropertyMap.cpp: Removed.
kjs/PropertyMap.h: Removed.
kjs/PropertySlot.cpp: Removed.
kjs/PropertySlot.h: Removed.
kjs/PrototypeFunction.cpp: Removed.
kjs/PrototypeFunction.h: Removed.
kjs/PutPropertySlot.h: Removed.
kjs/SmallStrings.cpp: Removed.
kjs/SmallStrings.h: Removed.
kjs/StringConstructor.cpp: Removed.
kjs/StringConstructor.h: Removed.
kjs/StringObject.cpp: Removed.
kjs/StringObject.h: Removed.
kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
kjs/StringPrototype.cpp: Removed.
kjs/StringPrototype.h: Removed.
kjs/StructureID.cpp: Removed.
kjs/StructureID.h: Removed.
kjs/completion.h:
kjs/interpreter.h:
runtime: Added.
runtime/ArrayConstructor.cpp: Copied from kjs/ArrayConstructor.cpp.
runtime/ArrayConstructor.h: Copied from kjs/ArrayConstructor.h.
runtime/ArrayPrototype.cpp: Copied from kjs/ArrayPrototype.cpp.
runtime/ArrayPrototype.h: Copied from kjs/ArrayPrototype.h.
runtime/BooleanConstructor.cpp: Copied from kjs/BooleanConstructor.cpp.
runtime/BooleanConstructor.h: Copied from kjs/BooleanConstructor.h.
runtime/BooleanObject.cpp: Copied from kjs/BooleanObject.cpp.
runtime/BooleanObject.h: Copied from kjs/BooleanObject.h.
runtime/BooleanPrototype.cpp: Copied from kjs/BooleanPrototype.cpp.
runtime/BooleanPrototype.h: Copied from kjs/BooleanPrototype.h.
runtime/CallData.cpp: Copied from kjs/CallData.cpp.
runtime/CallData.h: Copied from kjs/CallData.h.
runtime/ClassInfo.h: Copied from kjs/ClassInfo.h.
runtime/ConstructData.cpp: Copied from kjs/ConstructData.cpp.
runtime/ConstructData.h: Copied from kjs/ConstructData.h.
runtime/DateConstructor.cpp: Copied from kjs/DateConstructor.cpp.
runtime/DateConstructor.h: Copied from kjs/DateConstructor.h.
runtime/DateInstance.cpp: Copied from kjs/DateInstance.cpp.
runtime/DateInstance.h: Copied from kjs/DateInstance.h.
runtime/DateMath.cpp: Copied from kjs/DateMath.cpp.
runtime/DateMath.h: Copied from kjs/DateMath.h.
runtime/DatePrototype.cpp: Copied from kjs/DatePrototype.cpp.
runtime/DatePrototype.h: Copied from kjs/DatePrototype.h.
runtime/Error.cpp: Copied from kjs/Error.cpp.
runtime/Error.h: Copied from kjs/Error.h.
runtime/ErrorConstructor.cpp: Copied from kjs/ErrorConstructor.cpp.
runtime/ErrorConstructor.h: Copied from kjs/ErrorConstructor.h.
runtime/ErrorInstance.cpp: Copied from kjs/ErrorInstance.cpp.
runtime/ErrorInstance.h: Copied from kjs/ErrorInstance.h.
runtime/ErrorPrototype.cpp: Copied from kjs/ErrorPrototype.cpp.
runtime/ErrorPrototype.h: Copied from kjs/ErrorPrototype.h.
runtime/FunctionConstructor.cpp: Copied from kjs/FunctionConstructor.cpp.
runtime/FunctionConstructor.h: Copied from kjs/FunctionConstructor.h.
runtime/FunctionPrototype.cpp: Copied from kjs/FunctionPrototype.cpp.
runtime/FunctionPrototype.h: Copied from kjs/FunctionPrototype.h.
runtime/GlobalEvalFunction.cpp: Copied from kjs/GlobalEvalFunction.cpp.
runtime/GlobalEvalFunction.h: Copied from kjs/GlobalEvalFunction.h.
runtime/InternalFunction.cpp: Copied from kjs/InternalFunction.cpp.
runtime/InternalFunction.h: Copied from kjs/InternalFunction.h.
runtime/JSArray.cpp: Copied from kjs/JSArray.cpp.
runtime/JSArray.h: Copied from kjs/JSArray.h.
runtime/JSCell.cpp: Copied from kjs/JSCell.cpp.
runtime/JSCell.h: Copied from kjs/JSCell.h.
runtime/JSFunction.cpp: Copied from kjs/JSFunction.cpp.
runtime/JSFunction.h: Copied from kjs/JSFunction.h.
runtime/JSGlobalObject.cpp: Copied from kjs/JSGlobalObject.cpp.
runtime/JSGlobalObject.h: Copied from kjs/JSGlobalObject.h.
runtime/JSGlobalObjectFunctions.cpp: Copied from kjs/JSGlobalObjectFunctions.cpp.
runtime/JSGlobalObjectFunctions.h: Copied from kjs/JSGlobalObjectFunctions.h.
runtime/JSImmediate.cpp: Copied from kjs/JSImmediate.cpp.
runtime/JSImmediate.h: Copied from kjs/JSImmediate.h.
runtime/JSNotAnObject.cpp: Copied from kjs/JSNotAnObject.cpp.
runtime/JSNotAnObject.h: Copied from kjs/JSNotAnObject.h.
runtime/JSNumberCell.cpp: Copied from kjs/JSNumberCell.cpp.
runtime/JSNumberCell.h: Copied from kjs/JSNumberCell.h.
runtime/JSObject.cpp: Copied from kjs/JSObject.cpp.
runtime/JSObject.h: Copied from kjs/JSObject.h.
runtime/JSString.cpp: Copied from kjs/JSString.cpp.
runtime/JSString.h: Copied from kjs/JSString.h.
runtime/JSValue.cpp: Copied from kjs/JSValue.cpp.
runtime/JSValue.h: Copied from kjs/JSValue.h.
runtime/JSVariableObject.cpp: Copied from kjs/JSVariableObject.cpp.
runtime/JSVariableObject.h: Copied from kjs/JSVariableObject.h.
runtime/JSWrapperObject.cpp: Copied from kjs/JSWrapperObject.cpp.
runtime/JSWrapperObject.h: Copied from kjs/JSWrapperObject.h.
runtime/MathObject.cpp: Copied from kjs/MathObject.cpp.
runtime/MathObject.h: Copied from kjs/MathObject.h.
runtime/NativeErrorConstructor.cpp: Copied from kjs/NativeErrorConstructor.cpp.
runtime/NativeErrorConstructor.h: Copied from kjs/NativeErrorConstructor.h.
runtime/NativeErrorPrototype.cpp: Copied from kjs/NativeErrorPrototype.cpp.
runtime/NativeErrorPrototype.h: Copied from kjs/NativeErrorPrototype.h.
runtime/NumberConstructor.cpp: Copied from kjs/NumberConstructor.cpp.
runtime/NumberConstructor.h: Copied from kjs/NumberConstructor.h.
runtime/NumberObject.cpp: Copied from kjs/NumberObject.cpp.
runtime/NumberObject.h: Copied from kjs/NumberObject.h.
runtime/NumberPrototype.cpp: Copied from kjs/NumberPrototype.cpp.
runtime/NumberPrototype.h: Copied from kjs/NumberPrototype.h.
runtime/ObjectConstructor.cpp: Copied from kjs/ObjectConstructor.cpp.
runtime/ObjectConstructor.h: Copied from kjs/ObjectConstructor.h.
runtime/ObjectPrototype.cpp: Copied from kjs/ObjectPrototype.cpp.
runtime/ObjectPrototype.h: Copied from kjs/ObjectPrototype.h.
runtime/PropertyMap.cpp: Copied from kjs/PropertyMap.cpp.
runtime/PropertyMap.h: Copied from kjs/PropertyMap.h.
runtime/PropertySlot.cpp: Copied from kjs/PropertySlot.cpp.
runtime/PropertySlot.h: Copied from kjs/PropertySlot.h.
runtime/PrototypeFunction.cpp: Copied from kjs/PrototypeFunction.cpp.
runtime/PrototypeFunction.h: Copied from kjs/PrototypeFunction.h.
runtime/PutPropertySlot.h: Copied from kjs/PutPropertySlot.h.
runtime/SmallStrings.cpp: Copied from kjs/SmallStrings.cpp.
runtime/SmallStrings.h: Copied from kjs/SmallStrings.h.
runtime/StringConstructor.cpp: Copied from kjs/StringConstructor.cpp.
runtime/StringConstructor.h: Copied from kjs/StringConstructor.h.
runtime/StringObject.cpp: Copied from kjs/StringObject.cpp.
runtime/StringObject.h: Copied from kjs/StringObject.h.
runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from kjs/StringObjectThatMasqueradesAsUndefined.h.
runtime/StringPrototype.cpp: Copied from kjs/StringPrototype.cpp.
runtime/StringPrototype.h: Copied from kjs/StringPrototype.h.
runtime/StructureID.cpp: Copied from kjs/StructureID.cpp.
runtime/StructureID.h: Copied from kjs/StructureID.h.

2:01 PM Changeset in webkit [37937] by ddkilzer@apple.com

2 edits in trunk/WebCore

2008-10-28 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=2192
Missing semi-colons in Geoposition.idl

page/Geoposition.idl: Add missing semi-colons

1:55 PM Changeset in webkit [37936] by adele@apple.com

7 edits
1 delete in trunk

WebKit:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

English.lproj/Localizable.strings: Updated.

WebKit/win:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

English.lproj: Removed.
English.lproj/Localizable.strings: Removed.
WebKit.vcproj/WebKit.vcproj: Updated to use Localizable.strings in the top directory, to share with the Mac.

WebKitTools:

2008-10-28 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

Specify which Localizable.strings to update since we don't always want to update the file in the same
directory where we're searching for the strings to localize.

Scripts/extract-localizable-strings:
Scripts/update-webkit-localizable-strings:

1:48 PM Changeset in webkit [37935] by timothy@apple.com

3 edits in trunk/WebCore/inspector/front-end/Images

Set svn:mime-type to image/png for the new images I just added.

1:42 PM Changeset in webkit [37934] by timothy@apple.com

2 edits in trunk/LayoutTests

Remove fast/profiler from the skipped list for Tiger since the fix
for <rdar://problem/6211578> should make things work.

<rdar://problem/6316530> Profiler tests fail on Tiger

Reviewed by Kevin McCullough.

platform/mac-tiger/Skipped:

1:42 PM Changeset in webkit [37933] by timothy@apple.com

114 edits
4 adds
1 delete in trunk

Make the JavaScript profiler opt-in, so it does not slow down JavaScript all the time.
Make the Profiles panel in the Web Inspector have an enable screen.
Profiling now needs to be enabled before console.profile() works.

WebCore:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Make the Profiles panel in the Web Inspector have an enable screen.
Profiling now needs to be enabled before console.profile() works.

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

English.lproj/localizedStrings.js: New strings.
WebCore.base.exp: New and changed exports.
WebCore.vcproj/WebCore.vcproj: Add the PanelEnablerView.js file.
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsProfiling): Call InspectorController:profilerEnabled.
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): Initialize the m_startProfiling Timer to call InspectorController::startUserInitiatedProfiling. (WebCore::InspectorController::startUserInitiatedProfilingSoon): Start a one-shot timer that calls InspectorController::startUserInitiatedProfiling. (WebCore::InspectorController::startUserInitiatedProfiling): Recompile all JavaScript and enable the profiler if the profiler was not enabled. (WebCore::InspectorController::stopUserInitiatedProfiling): Rearrange code for readability. (WebCore::InspectorController::enableProfiler): Recompile all the JavaScript functions if the skipRecompile argument is false. Call the profilerWasEnabled script function. (WebCore::InspectorController::disableProfiler): Recompile all the JavaScript functions. Call the profilerWasEnabled script function. (WebCore::InspectorController::disableDebugger): Set m_attachDebuggerWhenShown to false, so it won't be started later.
inspector/InspectorController.h: (WebCore::InspectorController::profilerEnabled): Return enabled() && m_profilerEnabled.
inspector/front-end/Images/debuggingButtons.png: Remove.
inspector/front-end/Images/enableButtons.png: Added.
inspector/front-end/Images/profilesSilhouette.png: Added.
inspector/front-end/Images/scriptsSilhouette.png: Added.
inspector/front-end/PanelEnablerView.js: Added. (WebInspector.PanelEnablerView): (WebInspector.PanelEnablerView.prototype._enableButtonCicked): Fire the "enable clicked" event so listeners can do their thing. (WebInspector.PanelEnablerView.prototype._windowResized): Test if the icon should be hidden.
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): Create the PanelEnablerView and the strings needed for it. (WebInspector.ProfilesPanel.prototype.get statusBarItems): Include the enableToggleButton. (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): Call reset and populateInterface. (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): Call reset. (WebInspector.ProfilesPanel.prototype.reset): Call _updateInterface. (WebInspector.ProfilesPanel.prototype.setRecordingProfile): Moved in the code, no changes. (WebInspector.ProfilesPanel.prototype._updateInterface): Update the toggle button and show/hide other buttons. Also show/hide the PanelEnablerView. (WebInspector.ProfilesPanel.prototype._enableProfiling): Call _toggleProfiling if not enabled. (WebInspector.ProfilesPanel.prototype._toggleProfiling): Call InspectorController's disableProfiler or enableProfiler.
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): Replace the overlay element with a PanelEnablerView. Replace the debuggingButton with the enableToggleButton. (WebInspector.ScriptsPanel.prototype.get statusBarItems): Replace the debuggingButton with the enableToggleButton. (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Hide/show the pauseOnExceptionButton when needed. Replace the overlay element with a PanelEnablerView. Replace the debuggingButton with the enableToggleButton. (WebInspector.ScriptsPanel.prototype._enableDebugging): Call _toggleDebugging when not enabled. (WebInspector.ScriptsPanel.prototype._toggleDebugging): Remove the call to _clearInterface, since reset is called from debuggerWasEnabled and debuggerWasDisabled.
inspector/front-end/View.js: Inherit from WebInspector.Object.
inspector/front-end/WebKit.qrc: Add the PanelEnablerView.js file.
inspector/front-end/inspector.css: New styles for the PanelEnablerView.
inspector/front-end/inspector.html: Add the PanelEnablerView.js file.
inspector/front-end/inspector.js: (WebInspector.profilerWasEnabled): Added. Calls the ProfilesPanel. (WebInspector.profilerWasDisabled): Ditto.
page/Console.cpp: (WebCore::Console::error): Remove null check for m_frame, since m_frame isn't used. (WebCore::Console::info): Ditto. (WebCore::Console::log): Ditto. (WebCore::Console::assertCondition): Ditto. (WebCore::Console::dirxml): Remove null check for m_frame and use this->page(). (WebCore::Console::count): Ditto. (WebCore::Console::profile): Return early if InspectorController::profilerEnabled is false. (WebCore::Console::profileEnd): Ditto. (WebCore::Console::warn): Remove null check for m_frame, since m_frame isn't used.
page/Settings.cpp: (WebCore::Settings::Settings): Remove initialization of m_didInitializeDeveloperExtrasEnabled. (WebCore::Settings::setDeveloperExtrasEnabled): Remove code that recompiled functions. Now just sets the member boolean.
page/Settings.h: Remove m_didInitializeDeveloperExtrasEnabled.

WebKit/mac:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Add WebInspector methods to enable the profiler.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

WebInspector/WebInspector.h:
WebInspector/WebInspector.mm: (-isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled. (-setJavaScriptProfilingEnabled:): Added. Call InspectorController's disableProfiler or enableProfiler methods.

WebKit/win:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Add IWebInspector methods to enable the profiler.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

WebInspector.cpp: (WebInspector::isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled. (WebInspector::setJavaScriptProfilingEnabled): Added. Call InspectorController's disableProfiler or enableProfiler methods.
WebInspector.h:

WebKitTools:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Add support for enabling the profiler, so the profiling tests can continue
work now that the profiler is not always enabled.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
DumpRenderTree/LayoutTestController.cpp: (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled. (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.

LayoutTests:

2008-10-28 Timothy Hatcher <timothy@apple.com>

Update profiler tests to opt-in to profiling and clean up the output.

https://bugs.webkit.org/show_bug.cgi?id=21927

<rdar://problem/6211578> Make the JavaScript profiler opt-in, so it
does not slow down JavaScript all the time

Reviewed by Darin Adler and Kevin McCullough.

fast/profiler/anonymous-event-handler-expected.txt:
fast/profiler/anonymous-event-handler.html:
fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
fast/profiler/anonymous-function-called-from-different-contexts.html:
fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
fast/profiler/anonymous-function-calls-built-in-functions.html:
fast/profiler/anonymous-function-calls-eval-expected.txt:
fast/profiler/anonymous-function-calls-eval.html:
fast/profiler/apply-expected.txt:
fast/profiler/apply.html:
fast/profiler/built-in-function-calls-anonymous-expected.txt:
fast/profiler/built-in-function-calls-anonymous.html:
fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
fast/profiler/built-in-function-calls-user-defined-function.html:
fast/profiler/call-expected.txt:
fast/profiler/call-nodelist-as-function-expected.txt:
fast/profiler/call-nodelist-as-function.html:
fast/profiler/call.html:
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt:
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
fast/profiler/compare-multiple-profiles-expected.txt:
fast/profiler/compare-multiple-profiles.html:
fast/profiler/constructor-expected.txt:
fast/profiler/constructor.html:
fast/profiler/dead-time-expected.txt:
fast/profiler/dead-time.html:
fast/profiler/document-dot-write-expected.txt:
fast/profiler/document-dot-write.html:
fast/profiler/event-handler-expected.txt:
fast/profiler/event-handler.html:
fast/profiler/execution-context-and-eval-on-same-line-expected.txt:
fast/profiler/execution-context-and-eval-on-same-line.html:
fast/profiler/heavy-view-expected.txt:
fast/profiler/heavy-view.html:
fast/profiler/inline-event-handler-expected.txt:
fast/profiler/inline-event-handler.html:
fast/profiler/many-calls-in-the-same-scope-expected.txt:
fast/profiler/many-calls-in-the-same-scope.html:
fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
fast/profiler/multiple-and-different-scoped-function-calls.html:
fast/profiler/multiple-frames-expected.txt:
fast/profiler/multiple-frames.html:
fast/profiler/nested-anonymous-functon-expected.txt:
fast/profiler/nested-anonymous-functon.html:
fast/profiler/nested-start-and-stop-profiler-expected.txt:
fast/profiler/nested-start-and-stop-profiler.html:
fast/profiler/no-execution-context-expected.txt:
fast/profiler/no-execution-context.html:
fast/profiler/one-execution-context-expected.txt:
fast/profiler/one-execution-context.html:
fast/profiler/profile-calls-in-included-file-expected.txt:
fast/profiler/profile-calls-in-included-file.html:
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt:
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
fast/profiler/profiling-from-a-nested-location-expected.txt:
fast/profiler/profiling-from-a-nested-location.html:
fast/profiler/resources/profiler-test-JS-resources.js: (endTest): Remove some whitespace. (insertGivenText): Hide the output of this method, sicne it is not important to the test. (insertNewText): Ditto. (printHeavyProfilesDataWithoutTime): Output plain text an not console.log. (printProfilesDataWithoutTime): Ditto. (printProfileNodeWithoutTime): Ditto.
fast/profiler/simple-event-call-expected.txt:
fast/profiler/simple-event-call.html:
fast/profiler/simple-no-level-change-expected.txt:
fast/profiler/simple-no-level-change.html:
fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
fast/profiler/start-and-stop-profiler-multiple-times.html:
fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt:
fast/profiler/start-and-stop-profiling-in-the-same-function.html:
fast/profiler/start-but-dont-stop-profiling-expected.txt:
fast/profiler/start-but-dont-stop-profiling.html:
fast/profiler/stop-profiling-after-setTimeout-expected.txt:
fast/profiler/stop-profiling-after-setTimeout.html:
fast/profiler/stop-then-function-call-expected.txt:
fast/profiler/stop-then-function-call.html:
fast/profiler/throw-exception-from-eval-expected.txt:
fast/profiler/throw-exception-from-eval.html:
fast/profiler/two-execution-contexts-expected.txt:
fast/profiler/two-execution-contexts.html:
fast/profiler/user-defined-function-calls-built-in-functions-expected.txt:
fast/profiler/user-defined-function-calls-built-in-functions.html:
fast/profiler/window-dot-eval-expected.txt:
fast/profiler/window-dot-eval.html:

1:42 PM Changeset in webkit [37932] by timothy@apple.com

11 edits in trunk

Rename a few methods related to attaching and detaching the debugger. Also adds stub methods for enabling and disabling the profiler.

WebCore:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Rename a few methods related to attaching and detaching the debugger. Also
adds stub methods for enabling and disabling the profiler.

Rename attachDebugger to enableDebugger.
Rename detachDebugger to disableDebugger.
Rename the debuggerAttached getter to debuggerEnabled.
Rename the debuggerAttached callback to debuggerWasEnabled.
Rename the debuggerDetached callback to debuggerWasDisabled.

Reviewed by Darin Adler.

WebCore.base.exp:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::close): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::pauseInDebugger): (WebCore::InspectorController::resumeDebugger): (WebCore::InspectorController::stepOverStatementInDebugger): (WebCore::InspectorController::stepIntoStatementInDebugger): (WebCore::InspectorController::stepOutOfFunctionInDebugger):
inspector/InspectorController.h: (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::debuggerEnabled):
inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
inspector/front-end/Object.js:
inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get statusBarItems): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDetached): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowResource): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
inspector/front-end/View.js:
inspector/front-end/inspector.css:
inspector/front-end/inspector.html:
inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.debuggerWasEnabled): (WebInspector.debuggerWasDisabled):

WebKit/mac:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Rename a few methods related to attaching and detaching the debugger.

Rename attachDebugger to enableDebugger.
Rename detachDebugger to disableDebugger.
Rename the debuggerAttached getter to debuggerEnabled.

Reviewed by Darin Adler.

WebInspector/WebInspector.mm: (-isDebuggingJavaScript): (-startDebuggingJavaScript:): (-stopDebuggingJavaScript:):

WebKit/win:

2008-10-27 Timothy Hatcher <timothy@apple.com>

Rename a few methods related to attaching and detaching the debugger.

Rename attachDebugger to enableDebugger.
Rename detachDebugger to disableDebugger.
Rename the debuggerAttached getter to debuggerEnabled.

Reviewed by Darin Adler.

WebInspector.cpp: (WebInspector::isDebuggingJavaScript): (WebInspector::toggleDebuggingJavaScript):

1:41 PM Changeset in webkit [37931] by timothy@apple.com

2 edits in trunk/WebCore

Fix an exception when searching the Resources panel while there
and resources queued to be added to the list.

Reviewed by Kevin McCullough.

inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.searchCanceled): Null check the _resourcesTreeElement property. (WebInspector.ResourcesPanel.prototype.performSearch): Ditto.

12:14 PM Changeset in webkit [37930] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-10-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed https://bugs.webkit.org/show_bug.cgi?id=21919
Sampler reports bogus time in op_enter during 3d-raytrace.js

Fixed a bug where we would pass the incorrect Instruction* during some
parts of CTI codegen.

VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
VM/SamplingTool.cpp: (JSC::SamplingTool::run):
wtf/Platform.h:

10:48 AM Changeset in webkit [37929] by kmccullough@apple.com

3 edits in trunk/JavaScriptCore

2008-10-28 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

-Removed unused includes.
Apparent .4% speedup in Sunspider

kjs/JSObject.cpp:
kjs/interpreter.cpp:

10:26 AM Changeset in webkit [37928] by Simon Fraser

13 edits
2 adds in trunk/WebKitTools

2008-10-28 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein

Primary changes in DumpRenderTree:

Ensure font smoothing is disabled (this is also called LCD anti-aliasing and is different from regular font CG anti-aliasing) as font-smoothing settings depends on the display and can also be changed by the user
Use a new cleared buffer for each test instead of the reusing same one to avoid potential result corruption across tests
Can now receive the expected pixel hash as a suffix to the test path or url as "path'hash"
Make sure hash is computed in a endian-independent way
Improve the code that sets/restores the screen color profile
Make the code more cross-platformy with std::string goodness
Added an "on-screen" mode where the snapshot will take into account surfaces on the window (like OpenGL content): this uses the new CG APIs on 10.5 or reading from the display framebuffer on 10.4. This mode is not active by default for performance reason, but must be explicitly activated from the test file using the new "testOnscreen()" JS API.

Primary changes in ImageDiff:

Provide a new comparison algorithm that is more tolerant to "acceptable" failures (i.e. very small differences in font rendering, which --threshold is not really good at handling)
Generate normalized intensity-only diff images

Primary changes in run-webkit-tests:

Take advantage of hashes for pixel tests which makes them much faster by minimizing image comparisons
Removed repaint options as these should be set from within test files using JS API
Replaced "threshold" option in by "tolerance" expressed in percents
Added more logging when in "verbose" mode

10:17 AM Changeset in webkit [37927] by mitz@apple.com

1 edit
12 moves
3 deletes in trunk/LayoutTests

2008-10-28 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21821

Ensure all baseline images are in the right location and delete the ones that aren't needed.

editing/inserting/5607069-1-expected.checksum: Removed.
editing/inserting/5607069-1-expected.png: Removed.
editing/pasteboard/paste-text-013-expected.png: Removed.
fast/css/invalid-percentage-property-expected.checksum: Removed.
fast/css/invalid-percentage-property-expected.png: Removed.
fast/css/text-align-expected.checksum: Removed.
fast/css/text-align-expected.png: Removed.
fast/selectors/lang-inheritance-expected.checksum: Removed.
fast/selectors/lang-inheritance-expected.png: Removed.
fast/selectors/lang-inheritance2-expected.checksum: Removed.
fast/selectors/lang-inheritance2-expected.png: Removed.
fast/selectors/lang-vs-xml-lang-expected.checksum: Removed.
fast/selectors/lang-vs-xml-lang-expected.png: Removed.
fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Removed.
fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Removed.
platform/mac/fast/css/invalid-percentage-property-expected.checksum: Copied from LayoutTests/fast/css/invalid-percentage-property-expected.checksum.
platform/mac/fast/css/invalid-percentage-property-expected.png: Copied from LayoutTests/fast/css/invalid-percentage-property-expected.png.
platform/mac/fast/css/text-align-expected.checksum: Copied from LayoutTests/fast/css/text-align-expected.checksum.
platform/mac/fast/css/text-align-expected.png: Copied from LayoutTests/fast/css/text-align-expected.png.
platform/mac/fast/selectors/lang-inheritance-expected.checksum: Copied from LayoutTests/fast/selectors/lang-inheritance-expected.checksum.
platform/mac/fast/selectors/lang-inheritance-expected.png: Copied from LayoutTests/fast/selectors/lang-inheritance-expected.png.
platform/mac/fast/selectors/lang-inheritance2-expected.checksum: Copied from LayoutTests/fast/selectors/lang-inheritance2-expected.checksum.
platform/mac/fast/selectors/lang-inheritance2-expected.png: Copied from LayoutTests/fast/selectors/lang-inheritance2-expected.png.
platform/mac/fast/selectors/lang-vs-xml-lang-expected.checksum: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-expected.checksum.
platform/mac/fast/selectors/lang-vs-xml-lang-expected.png: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-expected.png.
platform/mac/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum.
platform/mac/fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Copied from LayoutTests/fast/selectors/lang-vs-xml-lang-xhtml-expected.png.

9:18 AM Changeset in webkit [37926] by alp@webkit.org

3 edits in trunk/WebCore

2008-10-28 Alp Toker <alp@nuanti.com>

GTK+ build fix for older versions of Pango where PANGO_VERSION_CHECK
isn't defined.

platform/graphics/gtk/FontGtk.cpp: (WebCore::getDefaultPangoLayout):
platform/graphics/gtk/FontPlatformDataPango.cpp:

7:30 AM Changeset in webkit [37925] by alp@webkit.org

2 edits in trunk

2008-10-28 Mike Hommey <glandium@debian.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=21885
[GTK] libwebkit doesn't link against libpangoft2

Add pkg-config check for pangoft2 which provides
pango_fc_font_description_from_pattern() used in the FreeType font
backend.

configure.ac:

6:42 AM Changeset in webkit [37924] by ap@webkit.org

8 edits
3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21893
Character set is incorrect for external scripts in XHTML pages

<rdar://problem/6317451> Incorrect encoding for text in a popup at http://xpoint.ru/

Test: fast/encoding/external-script-charset.xhtml

Expose scriptCharset() function on all ScriptElements, and call it from XML tokenizer.

dom/ScriptElement.h:
dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::endElementNs):
dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
html/HTMLScriptElement.h:
svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::scriptCharset):
svg/SVGScriptElement.h:

5:53 AM Changeset in webkit [37923] by alp@webkit.org

6 edits in trunk

2008-10-28 Alp Toker <alp@nuanti.com>

Include copyright license files in the autotools dist target and
exclude unused zlib headers.

Change suggested by Mike Hommey.

Oct 27, 2008:

10:24 PM Changeset in webkit [37922] by weinig@apple.com

2 edits in trunk/WebCore

2008-10-27 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Clear the window shell when destroying a page to allow documents
which have no way of being reached anymore, to be torn down.

page/Frame.cpp: (WebCore::Frame::pageDestroyed):

8:06 PM Changeset in webkit [37921] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

8:05 PM Changeset in webkit [37920] by mrowe@apple.com

1 copy in tags/Safari-5525.26.6

New tag.

7:40 PM Changeset in webkit [37919] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2008-10-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Stop discarding CodeBlock samples that can't be charged to a specific
opcode. Instead, charge the relevant CodeBlock, and provide a footnote
explaining the situation.

This will help us tell which CodeBlocks are hot, even if we can't
identify specific lines of code within the CodeBlocks.

VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): (JSC::compareScopeSampleRecords): (JSC::SamplingTool::dump):

VM/SamplingTool.h: (JSC::ScopeSampleRecord::ScopeSampleRecord): (JSC::ScopeSampleRecord::~ScopeSampleRecord):

7:21 PM Changeset in webkit [37918] by Antti Koivisto

1 edit
1 add in trunk/WebKitSite

2008-10-27 Antti Koivisto <Antti Koivisto>

Add a file.

blog-files/squirrelfish-link-animated.svg: Added.

6:40 PM Changeset in webkit [37917] by andersca@apple.com

1 edit in trunk/WebKit/mac/Plugins/WebBaseNetscapePluginStream.h

Whoops, did not mean to commit this.

6:39 PM Changeset in webkit [37916] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Use the C++ stream object for JS requests as well.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView destroyStream:reason:]):

6:31 PM Changeset in webkit [37915] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Use the C++ stream object in WebBaseNetscapePluginView. Use a HashSet of RefPtrs to keep track of the streams.

Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::~WebNetscapePluginStream): (WebNetscapePluginStream::setPlugin): (WebNetscapePluginStream::startStream): (WebNetscapePluginStream::destroyStream): (WebNetscapePluginStream::destroyStreamWithReason): (WebNetscapePluginStream::cancelLoadAndDestroyStreamWithError): (WebNetscapePluginStream::deliverData):
Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView disconnectStream:]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

6:07 PM Changeset in webkit [37914] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Mitz Pettel.

Move code from dealloc and finalize to the WebNetscapePluginStream destructor.

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::~WebNetscapePluginStream): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):

6:01 PM Changeset in webkit [37913] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of WebNetscapePlugInStreamLoaderClient, the plug-in stream is its own client.

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView destroyStream:reason:]):

5:43 PM Changeset in webkit [37912] by andersca@apple.com

3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Change the Obj-C init methods to simply call WebNetscapePluginStream::create.

Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create):
Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (WebNetscapePluginStream::WebNetscapePluginStream): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):

5:18 PM Changeset in webkit [37911] by andersca@apple.com

4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Convert more code over to C++.

Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::plugin): (WebNetscapePluginStream::setRequestURL): Convert to C++.

Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::start): (WebNetscapePluginStream::stop): Ditto.

(WebNetscapePluginStream::startStreamWithResponse):
Ditto.

(-[WebBaseNetscapePluginStream startStreamWithResponse:]):
Call the C++ version.

(-[WebBaseNetscapePluginStream impl]):
New accessor for the C++ class.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView destroyStream:reason:]): Call the C++ methods.

4:48 PM Changeset in webkit [37910] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r37628.

4:47 PM Changeset in webkit [37909] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r37897.

4:25 PM Changeset in webkit [37908] by Antti Koivisto

1 edit
2 adds in trunk/WebKitSite

2008-10-27 Antti Koivisto <Antti Koivisto>

Add some svg files.

blog-files/cubes-7.svg: Added.
blog-files/number-morph.svg: Added.

3:57 PM Changeset in webkit [37907] by Darin Adler

2 edits in trunk/WebKit

2008-10-27 Darin Adler <Darin Adler>

StringsNotToBeLocalized.txt: Updated for recent changes.

3:15 PM Changeset in webkit [37906] by kevino@webkit.org

2 edits in trunk

Reviewed by Kevin Ollivier.

Update the active state as well as the focused state as both need to be true
for the caret to be drawn.

https://bugs.webkit.org/show_bug.cgi?id=21900

3:10 PM Changeset in webkit [37905] by Darin Adler

2 edits in trunk/BugsSite

2008-10-27 Darin Adler <Darin Adler>

template/en/custom/attachment/reviewform.html.tmpl: Leave out the comment if it's untouched.

3:07 PM Changeset in webkit [37904] by kevino@webkit.org

6 edits in trunk

wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.

2:45 PM Changeset in webkit [37903] by jmalonzo@webkit.org

2 edits in trunk/WebKit/gtk

2008-10-27 Michael Tross <michael@tross.org>

Reviewed by Alp Toker. Landed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=21827
[GTK] Fix memory leak in webkit_web_view_load_string

webkit/webkitwebview.cpp:

2:20 PM Changeset in webkit [37902] by Darin Adler

13 edits in trunk/WebCore

2008-10-27 Michael Knaup <michael.knaup@mac.com>

Reviewed and tweaked by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=8988

Bug 8988: Add support for Mozilla CSS custom cursors.
Added -webkit-grab and -webkit-grabbing cursor suppport
for the Mac, dummy implementations for other platforms.

css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Updated since the -webkit-grabbing cursor is now the last one.

css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.

css/CSSValueKeywords.in: Added -webkit-grab and -webkit-grabbing.

manual-tests/cursor.html: Added -webkit-zoom-in, webkit-zoom-out, -webkit-grab, and -webkit-grabbing.

page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.

platform/Cursor.h: Added grabCursor and grabbingCursor.

platform/gtk/CursorGtk.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/mac/CursorMac.mm: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/qt/CursorQt.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/win/CursorWin.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
platform/wx/CursorWx.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.

rendering/style/RenderStyleConstants.h: Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING. Also broke ECursor out into a single constant per line. Also added a couple of comments.

1:37 PM Changeset in webkit [37901] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2008-10-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Added a mutex around the SamplingTool's ScopeNode* map, to solve a crash
when sampling the v8 tests.

VM/SamplingTool.cpp: (JSC::SamplingTool::run): (JSC::SamplingTool::notifyOfScope):
VM/SamplingTool.h: Since new ScopeNodes can be created after the SamplingTools has begun sampling, reads and writes to / from the map need to be synchronized. Shark says this doesn't measurably increase sampling overhead.

1:07 PM Changeset in webkit [37900] by eric@webkit.org

2 edits in trunk/WebCore

2008-10-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

svg/SVGAnimatedTemplate.h: needed a HashMap define

12:49 PM Changeset in webkit [37899] by eric@webkit.org

3 edits
2 adds in trunk

Reviewed by Dave Hyatt.

Infinite recursion crash in WebCore::RenderSVGRoot::absoluteClippedOverflowRect on a <stop> element outside of a gradient block
https://bugs.webkit.org/show_bug.cgi?id=20400

Test: svg/custom/stop-crash.svg

WebCore.xcodeproj/project.pbxproj:
rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::absoluteClippedOverflowRect):

11:55 AM Changeset in webkit [37898] by andersca@apple.com

2 edits in trunk/WebCore

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

No need to call release if the connection is null.

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):

11:52 AM Changeset in webkit [37897] by andersca@apple.com

2 edits in trunk/WebCore

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/6322650> Crash in fast/loader/simultaneous-reloads-assert.html

Make sure to null check the NSURLConnection object.

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::setDefersLoading):

1:53 AM Changeset in webkit [37896] by ap@webkit.org

5 edits in trunk/WebCore

Fix non-Mac builds.

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCoreSources.bkl: Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.

12:59 AM Changeset in webkit [37895] by ap@webkit.org

10 edits
2 moves
2 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21886
window.HTMLOptionElement == "[object HTMLElementConstructor]" instead of HTMLOptionElementConstructor

Test: fast/dom/HTMLOptionElement/option-prototype.html

We now have separate objects for window.Option and window.HTMLOptionElement - the latter
"constructor" cannot be used to construct anything. This matches Firefox behavior.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseOption):
bindings/js/JSHTMLOptionElementConstructor.cpp: Removed.
bindings/js/JSHTMLOptionElementConstructor.h: Removed.
bindings/js/JSOptionConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.cpp.
bindings/js/JSOptionConstructor.h: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.h.
html/HTMLOptionElement.idl: Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.

html/HTMLOptionElement.idl: Generate a constructor.

Oct 25, 2008:

1:26 PM Changeset in webkit [37894] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

VM/Machine.cpp: (JSC::Machine::privateExecute): Provide a dummy value to the HostCallRecord in CTI non-sampling builds, to silence compiler warning.

1:21 PM Changeset in webkit [37893] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Windows build.

VM/SamplingTool.h: (JSC::SamplingTool::encodeSample): Explicitly cast bool to int, to silence compiler warning.

1:03 PM Changeset in webkit [37892] by ggaren@apple.com

3 edits in trunk/WebCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix Mac debug build on the buildbot.

platform/FileChooser.cpp: (WebCore::FileChooserClient::~FileChooserClient):
platform/FileChooser.h: Moved destructor to .cpp file, to avoid a weak exported symbol.

12:59 PM Changeset in webkit [37891] by ggaren@apple.com

16 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig, with Gavin Barraclough's help.

Fixed Sampling Tool:

Made CodeBlock sampling work with CTI
Improved accuracy by unifying most sampling data into a single 32bit word, which can be written / read atomically.
Split out three different #ifdefs for modularity: OPCODE_SAMPLING; CODEBLOCK_SAMPLING; OPCODE_STATS.
Improved reporting clarity
Refactored for code clarity

JavaScriptCore.exp: Exported another symbol.

VM/CTI.cpp: (JSC::CTI::emitCTICall): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
VM/CTI.h: Updated CTI codegen to use the unified SamplingTool interface for encoding samples. (This required passing the current vPC to a lot more functions, since the unified interface samples the current vPC.) Added hooks for writing the current CodeBlock* on function entry and after a function call, for the sake of the CodeBlock sampler. Removed obsolete hook for clearing the current sample inside op_end. Also removed the custom enum used to differentiate flavors of op_call, since the OpcodeID enum works just as well. (This was important in an earlier version of the patch, but now it's just cleanup.)

VM/CodeBlock.cpp: (JSC::CodeBlock::lineNumberForVPC):
VM/CodeBlock.h: Upated for refactored #ifdefs. Changed lineNumberForVPC to be robust against vPCs not recorded for exception handling, since the Sampler may ask for an arbitrary vPC.

VM/Machine.cpp: (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_construct_NotJSConstruct):
VM/Machine.h: (JSC::Machine::setSampler): (JSC::Machine::sampler): (JSC::Machine::jitCodeBuffer): Upated for refactored #ifdefs. Changed Machine to use SamplingTool helper objects to record movement in and out of host code. This makes samples a bit more precise.

VM/Opcode.cpp: (JSC::OpcodeStats::~OpcodeStats):
VM/Opcode.h: Upated for refactored #ifdefs. Added a little more padding, to accomodate our more verbose opcode names.

VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): Only count a sample toward our total if we actually record it. This solves cases where a CodeBlock will claim to have been sampled many times, with reported samples that don't match.

(JSC::SamplingTool::run): Read the current sample into a Sample helper
object, to ensure that the data doesn't change while we're analyzing it,
and to help decode the data. Only access the CodeBlock sampling hash
table if CodeBlock sampling has been enabled, so non-CodeBlock sampling
runs can operate with even less overhead.

(JSC::SamplingTool::dump): I reorganized this code a lot to print the
most important info at the top, print as a table, annotate and document
the stuff I didn't understand when I started, etc.

VM/SamplingTool.h: New helper classes, described above.

kjs/Parser.h:
kjs/Shell.cpp: (runWithScripts):
kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): Updated for new sampling APIs.

wtf/Platform.h: Moved sampling #defines here, since our custom is to put ENABLE #defines into Platform.h. Made explicit the fact that CODEBLOCK_SAMPLING depends on OPCODE_SAMPLING.

12:11 PM Changeset in webkit [37890] by kevino@webkit.org

2 edits in trunk/WebKit/wx

wx build fix.

8:22 AM Changeset in webkit [37889] by vestbo@webkit.org

4 edits in trunk

2008-10-25 Jade Han <jade.han@nokia.com>

Reviewed by Anders.

Enable custom properties for Qt runtime objects in QtWebKit

https://bugs.webkit.org/show_bug.cgi?id=21813

2:37 AM Changeset in webkit [37888] by jmalonzo@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>

JSC Build fix, not reviewed.

VM/CTI.cpp: add missing include stdio.h for debug builds

12:24 AM Changeset in webkit [37887] by jmalonzo@webkit.org

2 edits in trunk

2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: add '-' to Wl which was missed in r36845

GNUmakefile.am:

Oct 24, 2008:

11:58 PM Changeset in webkit [37886] by weinig@apple.com

2 edits in trunk/WebKit/win

2008-10-24 Sam Weinig <sam@webkit.org>

Yet another windows build fix.

WebCoreSupport/WebChromeClient.cpp:

11:39 PM Changeset in webkit [37885] by weinig@apple.com

2 edits in trunk/WebKit/qt

2008-10-24 Sam Weinig <sam@webkit.org>

Another Qt build fix.

WebCoreSupport/ChromeClientQt.cpp:

11:38 PM Changeset in webkit [37884] by weinig@apple.com

2 edits in trunk/WebKit/win

2008-10-24 Sam Weinig <sam@webkit.org>

Another windows build fix.

WebCoreSupport/WebChromeClient.cpp:

11:36 PM Changeset in webkit [37883] by weinig@apple.com

3 edits in trunk/WebCore

2008-10-24 Sam Weinig <sam@webkit.org>

Fix windows build.

page/Chrome.cpp:
page/Chrome.h:

11:31 PM Changeset in webkit [37882] by weinig@apple.com

2 edits in trunk/WebKit/gtk

2008-10-24 Sam Weinig <sam@webkit.org>

Fix the Gtk build.

WebCoreSupport/ChromeClientGtk.cpp:

11:29 PM Changeset in webkit [37881] by weinig@apple.com

2 edits in trunk/WebCore

2008-10-24 Sam Weinig <sam@webkit.org>

Fix Qt build.

platform/qt/FileChooserQt.cpp:

11:02 PM Changeset in webkit [37880] by weinig@apple.com

28 edits in trunk

WebCore:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

Move file choosing into WebKit ChromeClient.

loader/EmptyClients.h: (WebCore::EmptyChromeClient::runOpenPanel):
page/Chrome.cpp: (WebCore::Chrome::runOpenPanel):
page/Chrome.h:
page/ChromeClient.h:
page/mac/ChromeMac.mm:
platform/FileChooser.h:
platform/mac/FileChooserMac.mm:
platform/qt/FileChooserQt.cpp:
platform/win/FileChooserWin.cpp:
platform/wx/TemporaryLinkStubs.cpp:
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

WebKit/gtk:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runOpenPanel):
WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel):

WebKit/qt:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):
WebCoreSupport/ChromeClientQt.h:

WebKit/win:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel):
WebCoreSupport/WebChromeClient.h:

WebKit/wx:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::runOpenPanel):
WebKitSupport/ChromeClientWx.h:

9:48 PM Changeset in webkit [37879] by eric@webkit.org

1 edit
1 add in trunk/LayoutTests

Reviewed by Sam Weinig.

Add missing results.

fast/js/global-constructors-expected.txt: Added.

6:34 PM Changeset in webkit [37878] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix - add newIconForFiles stub.

6:15 PM Changeset in webkit [37877] by kevino@webkit.org

3 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Use the CGFont metrics APIs for more accurate measurements, and tweak the y
value the text is drawn at (it was a couple pixels off before because wx
internally adds to the y value.

https://bugs.webkit.org/show_bug.cgi?id=21853

5:09 PM Changeset in webkit [37876] by eric@webkit.org

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Get rid of a bonus ASSERT when using a null string as a regexp.
Specifically calling: RegularExpression::match() with String::empty()
will hit this ASSERT.
Chromium hits this, but I don't know of any way to make a layout test.

pcre/pcre_exec.cpp: (jsRegExpExecute):

4:46 PM Changeset in webkit [37875] by eric@webkit.org

9 edits
2 adds
1 delete in trunk

Reviewed by Sam Weinig.

Generate missing constructors and add test to prevent missing ones in the future
https://bugs.webkit.org/show_bug.cgi?id=21846

fast/dom/wrapper-classes-expected.txt results were incorrectly platform-specific
that test used to be platform-dependent, but isn't anymore

fast/dom/Window/window-properties-expected.txt:
fast/dom/wrapper-classes-expected.txt:
fast/js/global-constructors.html: Added.
fast/js/resources/global-constructors.js: Added.
platform/mac/fast/dom/wrapper-classes-expected.txt: Removed.

4:39 PM Changeset in webkit [37874] by ap@webkit.org

3 edits
3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21836
REGRESSION: Sign-in on Fancast.com causes crash in Webkit nightly

Test: http/tests/xmlhttprequest/detaching-frame.html

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Null check the window - even though XHR needs a context (AKA frame) to be serviced, the frame may be disconnected when dispatching the same callback that results in this function being called.

4:07 PM Changeset in webkit [37873] by andersca@apple.com

2 edits in trunk/WebKitTools

2008-10-24 Anders Carlsson <andersca@apple.com>

Try fixing the 64-bit build.

DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: (testGetProperty):

4:06 PM Changeset in webkit [37872] by andersca@apple.com

2 edits in trunk/WebKit/mac

2008-10-24 Anders Carlsson <andersca@apple.com>

Fix Tiger build.

WebView/WebUIDelegate.h:

4:04 PM Changeset in webkit [37871] by ddkilzer@apple.com

2 edits in trunk/WebCore

Gtk build fix.

platform/gtk/TemporaryLinkStubs.cpp: (WebCore::setFocusRingColorChangeFunction): Removed in r37858.

3:20 PM Changeset in webkit [37870] by mrowe@apple.com

2 edits in trunk/WebCore

<rdar://problem/6164952> Use constant kCGInterpolationMedium in GraphicsContextCG.cpp rather than hard-coded values.

Reviewed by Sam Weinig.

3:16 PM Changeset in webkit [37869] by andersca@apple.com

19 edits
2 adds in trunk

WebCore:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

WebCore.NPAPI.exp: Export _NPN_Construct.

bridge/NP_jsobject.cpp: (_NPN_Construct): Implement this.

bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::supportsConstruct): (JSC::Bindings::CInstance::invokeConstruct): Have this call the appropriate NPClass method.

bridge/npruntime.h: Add NPN_Construct.

bridge/npruntime_impl.h: Add _NPN_Construct.

bridge/runtime.h: (JSC::Bindings::Instance::supportsConstruct): (JSC::Bindings::Instance::invokeConstruct): New methods.

bridge/runtime_object.cpp: (JSC::callRuntimeConstructor): Call the native instance.

(JSC::RuntimeObjectImp::getConstructData):
Implement this.

bridge/runtime_object.h: Add new method declarations.

plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::load):
plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load): Initialize m_pluginFuncs.construct.

WebKit/mac:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

Set construct.

Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

WebKitTools:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testCallback): Fix a memory leak.

(testConstruct):
New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.

(pluginInvoke):
Handle testConstruct.

DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: (testGetProperty): Add objectPointer property.

(testEnumerate):
Only enumerate the two first properties.

(testConstruct):
Add a simple construct implementation that just returns the test object.

LayoutTests:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct

Add testcase.

plugins/netscape-construct-expected.txt: Added.
plugins/netscape-construct.html: Added.

3:16 PM Changeset in webkit [37868] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Suggested and rubber-stamped by Geoff Garen.

Fix a crash when opening Font Picker.

The change also hopefully fixes this bug, which I could never reproduce:
https://bugs.webkit.org/show_bug.cgi?id=20241
<rdar://problem/6290576> Safari crashes at JSValueUnprotect() when fontpicker view close

API/JSContextRef.cpp: (JSContextGetGlobalObject): Use lexical global object instead of dynamic one.

3:09 PM Changeset in webkit [37867] by adele@apple.com

3 edits in trunk/WebCore

2008-10-24 Adele Peterson <adele@apple.com>

Build fix.

platform/FileChooser.h: (WebCore::FileChooserClient::~FileChooserClient):
platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles):

2:51 PM Changeset in webkit [37866] by ddkilzer@apple.com

2 edits in trunk/WebCore

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Fix GTK build break.

Reviewed by David Kilzer.

GNUmakefile.am: Do not include .idl files whose generated files should not be compiled.

2:46 PM Changeset in webkit [37865] by ddkilzer@apple.com

2 edits in trunk/WebCore

Wx build fix.

platform/wx/TemporaryLinkStubs.cpp: (WebCore::setFocusRingColorChangeFunction): Removed in r37858.

2:44 PM Changeset in webkit [37864] by mrowe@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/6119711> Remove the dependency on Foundation's private COCOA_FORMAL_PROTOCOLS define.

Rubber-stamped by Tim Hatcher.

2:12 PM Changeset in webkit [37863] by adele@apple.com

23 edits
6 adds in trunk

WebCore:

2008-10-24 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.

This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
This is consistent with the direction HTML5 will be going in the future.

The initial implementation here will show "n files" as the text next to the control when multiple files are selected. You can view
the individual files in a tooltip for now. Improvements to this control will come later.

Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.
These FileList Files can also be sent in an XMLHTTPRequest.

manual-tests/post-multi-file-upload.html: Added.
manual-tests/resources/multiFileResources: Added.
manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
manual-tests/resources/multiFileResources/testFile1.html: Added.
manual-tests/resources/multiFileResources/testFile2.html: Added.
manual-tests/resources/multiFileResources/testFile3.html: Added.

WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute. (WebCore::HTMLInputElement::value): Added comments. The HTML5 spec says that value shouldn't apply for the file upload control, but we don't want to break the behavior for existing websites that may rely on this. (WebCore::HTMLInputElement::setValue): ditto. (WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead. (WebCore::HTMLInputElement::setFileListFromRenderer): Added.
html/HTMLInputElement.h:

page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.

page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.

platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::create): (WebCore::FileChooser::clear): (WebCore::FileChooser::chooseFile): (WebCore::FileChooser::chooseFiles): (WebCore::FileChooser::chooseIcon):
platform/FileChooser.h: (WebCore::FileChooser::filePaths): (WebCore::FileChooser::allowsMultipleFiles):

platform/graphics/Icon.h:
platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.

platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth): Updated to deal with new filenames vector.
platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth):
platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):

platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle): Removed unnecessary assertion. This can get hit when connectionDidFinishLoading and cancel both get called for the same ResourceHandle. This getting called twice has no negative effect.

rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::valueChanged): Calls setFileListFromRenderer. (WebCore::RenderFileUploadControl::allowsMultipleFiles): Added. (WebCore::RenderFileUploadControl::updateFromElement): Uses the new filenames call from FileChooser. (WebCore::RenderFileUploadControl::receiveDroppedFiles): Updated to support multiple files.
rendering/RenderFileUploadControl.h:

WebKit/mac:

2008-10-24 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

WebKit part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel): (-[WebOpenPanelResultListener chooseFilenames:]):
WebView/WebUIDelegate.h:

2:09 PM Changeset in webkit [37862] by Adam Roben

2 edits in trunk/WebKit/cf

Windows build fix

WebCoreSupport/WebInspectorClientCF.cpp: Define WTF_PLATFORM_CF manually. Normally this gets defined on Windows by including config.h, but Mac has no config.h for WebKit, so we can't do that here.

2:07 PM Changeset in webkit [37861] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Remove ScopeChainNode::bottom() and inline it into its only caller,
ScopeChainnode::globalObject().

kjs/JSGlobalObject.h: (JSC::ScopeChainNode::globalObject):
kjs/ScopeChain.h: (JSC::ScopeChain::bottom):

1:54 PM Changeset in webkit [37860] by ddkilzer@apple.com

2 edits in trunk/WebKit/wx

Build fix.

Reviewed by Greg Bolsinga.

WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::populateSetting): Changed

InspectorClient: to InspectorClientWx::. (WebCore::InspectorClientWx::storeSetting): Ditto. (WebCore::InspectorClientWx::removeSetting): Ditto.

1:44 PM Changeset in webkit [37859] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21862: Create JSFunction prototype property lazily
<https://bugs.webkit.org/show_bug.cgi?id=21862>

This is a 1.5% speedup on SunSpider and a 1.4% speedup on the V8
benchmark suite, including a 3.8% speedup on Earley-Boyer.

kjs/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
kjs/nodes.cpp: (JSC::FuncDeclNode::makeFunction): (JSC::FuncExprNode::makeFunction):

1:43 PM Changeset in webkit [37858] by pkasting@chromium.org

6 edits in trunk/WebCore

2008-10-23 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=21844
Remove setFocusRingColorChangeFunction.

page/Page.cpp: (WebCore::Page::Page):
platform/graphics/Color.h:
platform/graphics/mac/ColorMac.mm: (WebCore::focusRingColor):
platform/graphics/qt/GraphicsContextQt.cpp:
platform/graphics/win/ColorSafari.cpp:

1:32 PM Changeset in webkit [37857] by ddkilzer@apple.com

2 edits in trunk/WebCore

Build fix for Qt.

Reviewed by Greg.

WebCore.pro: Added missing *.idl files.

1:27 PM Changeset in webkit [37856] by timothy@apple.com

1 edit in trunk/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp

Fix the Windows build.

1:23 PM Changeset in webkit [37855] by Simon Fraser

2 edits in trunk/LayoutTests

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig

Add to the comment some new CSSRule types that are not yet tested.

fast/dom/wrapper-classes.html:

1:10 PM Changeset in webkit [37854] by ddkilzer@apple.com

20 edits
24 adds in trunk

JavaScriptCore:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0

WebCore:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

Test: geolocation/geolocation-not-implemented.html

DerivedSources.make:
GNUmakefile.am: Added Geolocation support
WebCore.pro: Added Geolocation support
WebCore.vcproj/WebCore.vcproj: Added Geolocation support
WebCore.xcodeproj/project.pbxproj: Added Geolocation support
WebCoreSources.bkl: Added Geolocation support
bindings/js/JSCustomPositionCallback.cpp: Added. (WebCore::JSCustomPositionCallback::JSCustomPositionCallback): (WebCore::JSCustomPositionCallback::handleEvent):
bindings/js/JSCustomPositionCallback.h: Added. (WebCore::JSCustomPositionCallback::create):
bindings/js/JSCustomPositionErrorCallback.cpp: Added. (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback): (WebCore::JSCustomPositionErrorCallback::handleEvent):
bindings/js/JSCustomPositionErrorCallback.h: Added. (WebCore::JSCustomPositionErrorCallback::create):
bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom (WebCore::markDOMObjectWrapper):
bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
bindings/js/JSGeolocationCustom.cpp: Added. (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation (WebCore::JSNavigator::mark):
dom/Document.cpp: (WebCore::Document::Document):
dom/Document.h: (WebCore::Document::setUsingGeolocation): (WebCore::Document::usingGeolocation):
loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation (WebCore::FrameLoader::canCachePage):
page/Geolocation.cpp: Added. (WebCore::Geolocation::GeoNotifier::GeoNotifier): (WebCore::Geolocation::GeoNotifier::timerFired): (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::clearWatch): (WebCore::Geolocation::stopUpdatingIfEmpty): (WebCore::Geolocation::sendErrorToOneShots): (WebCore::Geolocation::sendErrorToWatchers): (WebCore::Geolocation::sendPositionToOneShots): (WebCore::Geolocation::sendPositionToWatchers): (WebCore::Geolocation::handleError): (WebCore::Geolocation::geolocationServicePositionChanged): (WebCore::Geolocation::geolocationServiceErrorOccurred):
page/Geolocation.h: Added. (WebCore::Geolocation::create): (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::GeoNotifier::create):
page/Geolocation.idl: Added.
page/Geoposition.cpp: Added. (WebCore::Geoposition::toString):
page/Geoposition.h: Added. (WebCore::Geoposition::create): (WebCore::Geoposition::latitude): (WebCore::Geoposition::longitude): (WebCore::Geoposition::altitude): (WebCore::Geoposition::accuracy): (WebCore::Geoposition::altitudeAccuracy): (WebCore::Geoposition::heading): (WebCore::Geoposition::velocity): (WebCore::Geoposition::timestamp): (WebCore::Geoposition::Geoposition):
page/Geoposition.idl: Added.
page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): disconnect Geolocation (WebCore::Navigator::geolocation): accessor for Geolocation
page/Navigator.h: (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
page/Navigator.idl: accessor for Geolocation
page/PositionCallback.h: Added. (WebCore::PositionCallback::~PositionCallback):
page/PositionCallback.idl: Added.
page/PositionError.h: Added. (WebCore::PositionError::): (WebCore::PositionError::create): (WebCore::PositionError::code): (WebCore::PositionError::message): (WebCore::PositionError::PositionError):
page/PositionError.idl: Added.
page/PositionErrorCallback.h: Added. (WebCore::PositionErrorCallback::~PositionErrorCallback):
page/PositionErrorCallback.idl: Added.
page/PositionOptions.h: Added. (WebCore::PositionOptions::create): (WebCore::PositionOptions::enableHighAccuracy): (WebCore::PositionOptions::setEnableHighAccuracy): (WebCore::PositionOptions::timeout): (WebCore::PositionOptions::setTimeout): (WebCore::PositionOptions::PositionOptions):
page/PositionOptions.idl: Added.
platform/GeolocationService.cpp: Added. (WebCore::GeolocationService::GeolocationService): (WebCore::GeolocationService::positionChanged): (WebCore::GeolocationService::errorOccurred):
platform/GeolocationService.h: Added. (WebCore::GeolocationServiceClient::~GeolocationServiceClient): (WebCore::GeolocationServiceClient::geolocationServicePositionChanged): (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred): (WebCore::GeolocationService::~GeolocationService):

LayoutTests:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

Tests to verify Geolocation isn't implemented (so that it didn't leak into
WebCore for platforms that do not support it).

geolocation: Added.
geolocation/geolocation-not-implemented-expected.txt: Added.
geolocation/geolocation-not-implemented.html: Added.
geolocation/geolocation-test.js: Copied from LayoutTests/media/video-test.js. (reset): (hanged): (watchPositionAndEnd): (watchPosition._positionCallback): (watchPosition): (watchPositionTestAndEnd): (watchPositionAndFail): (watchPositionAndTest._positionCallback): (watchPositionAndTest): (getCurrentPositionAndEnd): (getCurrentPosition._positionCallback): (getCurrentPosition): (getCurrentPositionTestAndEnd): (getCurrentPositionAndFail): (getCurrentPositionAndTest._positionCallback): (getCurrentPositionAndTest): (endTest): (relativeURL):

12:59 PM Changeset in webkit [37853] by Simon Fraser

4 edits in trunk/LayoutTests

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21858

Add additional CSSRule types to the DOM-wrapper tests.

fast/dom/resources/wrapper-identity-base.js:
fast/dom/wrapper-identity-expected.txt:
platform/mac/fast/dom/objc-wrapper-identity-expected.txt:

12:32 PM Changeset in webkit [37852] by Simon Fraser

7 edits
1 add in trunk/WebCore

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21818

Add HashTraits for AtomicString so that AtomicString can be used as
the key for a HashMap or HashSet.

GNUmakefile.am: add AtomicStringHash.h
WebCore.vcproj/WebCore.vcproj: add AtomicStringHash.h
WebCore.xcodeproj/project.pbxproj: add AtomicStringHash.h
platform/text/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::isHashTableDeletedValue):

specialize DefaultHash for AtomicString to use AtomicStringHash

platform/text/AtomicStringHash.h: Added.
platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl):

compute the hash up-front for the empty string

platform/text/StringImpl.h: (WebCore::StringImpl::existingHash):

method to get the hash without a test and branch, for callers like
AtomicStringHash who can guarantee that the hash has already been computed.

12:15 PM Changeset in webkit [37851] by Simon Fraser

2 edits in trunk/WebCore

2008-10-24 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig

https://bugs.webkit.org/show_bug.cgi?id=21857

Add WebKitCSSKeyframeRule and WebKitCSSKeyframesRule to the
switch in _wrapCSSRule.

bindings/objc/DOMCSS.mm: (+[DOMCSSRule _wrapCSSRule:WebCore::]):

12:14 PM Changeset in webkit [37850] by Adam Roben

2 edits in trunk/WebCore

Windows build fix

plugins/PluginView.cpp:

12:10 PM Changeset in webkit [37849] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=21851 <rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height

Test: fast/replaced/percent-height-in-anonymous-block-widget.html

rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): Copied code added to RenderBox::destroy() in r36513 into this function.

LayoutTests:

Reviewed by Sam Weinig.

test for https://bugs.webkit.org/show_bug.cgi?id=21851 <rdar://problem/6304151> REGRESSION (r36513): Crash when removing a widget with percent height

fast/replaced/percent-height-in-anonymous-block-widget.html: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.checksum: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.png: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.txt: Added.

11:49 AM Changeset in webkit [37848] by timothy@apple.com

22 edits
4 adds in trunk

Add a mechanism to store and retrieve preferences for the Web Inspector.

WebCore:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Add a mechanism to ask the InspectorClient for key/value setting pairs.
These settings can be strings, numbers, booleans or string vectors. The
settings are also bridged to and from JavaScript.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCore.base.exp: Expose the String CFStringRef constructor.
inspector/InspectorClient.h: (WebCore::InspectorClient::populateSetting): Added, pure virtual. (WebCore::InspectorClient::storeSetting): Ditto. (WebCore::InspectorClient::removeSetting): Ditto.
inspector/InspectorController.cpp: (WebCore::setting): Calls InspectorController::setting and wraps the result in script types. (WebCore::setSetting): Calls InspectorController::setSetting after converting from script types. (WebCore::InspectorController::InspectorController): Increment a global static to track the number of live InspectorControllers. (WebCore::InspectorController::~InspectorController): Decrement the global static that tracks the number of live InspectorControllers. Delete the setting cache if there are no more live controllers. (WebCore::InspectorController::setting): Check the cache and return the setting from there, otherwise make a new Setting and ask the client to populate it. (WebCore::InspectorController::setSetting): Change the cache and ask the client to store it. (WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting to the InspectorController script class.
inspector/InspectorController.h: (WebCore::InspectorController::Setting::Setting): (WebCore::InspectorController::Setting::operator=): (WebCore::InspectorController::Setting::type): Return m_type. (WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct. (WebCore::InspectorController::Setting::stringVector): Return m_stringVector. Assert the type is correct. (WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double. Assert the type is correct. (WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer. Assert the type is correct. (WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean. Assert the type is correct. (WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right field and the type.
loader/EmptyClients.h: (WebCore::EmptyInspectorClient::populateSetting): Added, empty method. (WebCore::EmptyInspectorClient::storeSetting): Ditto. (WebCore::EmptyInspectorClient::removeSetting): Ditto.

WebKit:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebKit.xcodeproj/project.pbxproj: Add the new InspectorClientCF.cpp file.

WebKit/gtk:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::populateSetting): Not implemented. (WebKit::InspectorClient::storeSetting): Ditto. (WebKit::InspectorClient::removeSetting): Ditto.
WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCoreSupport/WebInspectorClient.h: Add the new methods and guard the ObjC parts of the header.

WebKit/qt:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): Not implemented. (WebCore::InspectorClientQt::storeSetting): Ditto. (WebCore::InspectorClientQt::removeSetting): Ditto.
WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Adam Roben.

WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
WebCoreSupport/WebInspectorClient.h: Add the new methods.

WebKit/wx:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClient::populateSetting): Not implemented. (WebCore::InspectorClient::storeSetting): Ditto. (WebCore::InspectorClient::removeSetting): Ditto.
WebKitSupport/InspectorClientWx.h:

11:19 AM Changeset in webkit [37847] by ddkilzer@apple.com

3 edits in trunk/WebKitTools

Bug 21850: svn-apply and svn-unapply should preserve patch line endings

<https://bugs.webkit.org/show_bug.cgi?id=21850>

Reviewed by Adam Roben.

Scripts/svn-apply: Save end-of-line characters when stripping them off each line of a patch so that they may be restored after processing the line.
Scripts/svn-unapply: Ditto.

11:10 AM Changeset in webkit [37846] by cwzwarich@webkit.org

2 edits in trunk/WebCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove some C-style casts.

html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

9:22 AM Changeset in webkit [37845] by Darin Adler

301 edits in trunk

JavaScriptCore:

2008-10-24 Darin Adler <Darin Adler>

finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

API/APICast.h:
API/JSCallbackConstructor.h:
API/JSCallbackFunction.cpp:
API/JSCallbackFunction.h:
API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:
API/JSContextRef.cpp:
API/JSObjectRef.cpp:
API/JSValueRef.cpp:
VM/CTI.cpp:
VM/CTI.h:
VM/CodeBlock.cpp:
VM/CodeBlock.h:
VM/CodeGenerator.cpp:
VM/CodeGenerator.h:
VM/ExceptionHelpers.cpp:
VM/ExceptionHelpers.h:
VM/JSPropertyNameIterator.cpp:
VM/JSPropertyNameIterator.h:
VM/Machine.cpp:
VM/Machine.h:
VM/Register.h:
kjs/ArgList.cpp:
kjs/ArgList.h:
kjs/Arguments.cpp:
kjs/Arguments.h:
kjs/ArrayConstructor.cpp:
kjs/ArrayPrototype.cpp:
kjs/BooleanConstructor.cpp:
kjs/BooleanConstructor.h:
kjs/BooleanObject.h:
kjs/BooleanPrototype.cpp:
kjs/CallData.cpp:
kjs/CallData.h:
kjs/ConstructData.cpp:
kjs/ConstructData.h:
kjs/DateConstructor.cpp:
kjs/DateInstance.h:
kjs/DatePrototype.cpp:
kjs/DatePrototype.h:
kjs/DebuggerCallFrame.cpp:
kjs/DebuggerCallFrame.h:
kjs/ErrorConstructor.cpp:
kjs/ErrorPrototype.cpp:
kjs/ExecState.cpp:
kjs/ExecState.h:
kjs/FunctionConstructor.cpp:
kjs/FunctionPrototype.cpp:
kjs/FunctionPrototype.h:
kjs/GetterSetter.cpp:
kjs/GetterSetter.h:
kjs/InternalFunction.h:
kjs/JSActivation.cpp:
kjs/JSActivation.h:
kjs/JSArray.cpp:
kjs/JSArray.h:
kjs/JSCell.cpp:
kjs/JSCell.h:
kjs/JSFunction.cpp:
kjs/JSFunction.h:
kjs/JSGlobalData.h:
kjs/JSGlobalObject.cpp:
kjs/JSGlobalObject.h:
kjs/JSGlobalObjectFunctions.cpp:
kjs/JSGlobalObjectFunctions.h:
kjs/JSImmediate.cpp:
kjs/JSImmediate.h:
kjs/JSNotAnObject.cpp:
kjs/JSNotAnObject.h:
kjs/JSNumberCell.cpp:
kjs/JSNumberCell.h:
kjs/JSObject.cpp:
kjs/JSObject.h:
kjs/JSStaticScopeObject.cpp:
kjs/JSStaticScopeObject.h:
kjs/JSString.cpp:
kjs/JSString.h:
kjs/JSValue.h:
kjs/JSVariableObject.h:
kjs/JSWrapperObject.h:
kjs/MathObject.cpp:
kjs/MathObject.h:
kjs/NativeErrorConstructor.cpp:
kjs/NumberConstructor.cpp:
kjs/NumberConstructor.h:
kjs/NumberObject.cpp:
kjs/NumberObject.h:
kjs/NumberPrototype.cpp:
kjs/ObjectConstructor.cpp:
kjs/ObjectPrototype.cpp:
kjs/ObjectPrototype.h:
kjs/PropertyMap.h:
kjs/PropertySlot.cpp:
kjs/PropertySlot.h:
kjs/RegExpConstructor.cpp:
kjs/RegExpConstructor.h:
kjs/RegExpMatchesArray.h:
kjs/RegExpObject.cpp:
kjs/RegExpObject.h:
kjs/RegExpPrototype.cpp:
kjs/Shell.cpp:
kjs/StringConstructor.cpp:
kjs/StringObject.cpp:
kjs/StringObject.h:
kjs/StringObjectThatMasqueradesAsUndefined.h:
kjs/StringPrototype.cpp:
kjs/StructureID.cpp:
kjs/StructureID.h:
kjs/collector.cpp:
kjs/collector.h:
kjs/completion.h:
kjs/grammar.y:
kjs/interpreter.cpp:
kjs/interpreter.h:
kjs/lookup.cpp:
kjs/lookup.h:
kjs/nodes.h:
kjs/operations.cpp:
kjs/operations.h:
kjs/protect.h:
profiler/ProfileGenerator.cpp:
profiler/Profiler.cpp:
profiler/Profiler.h: Use JSValue* instead of JSValuePtr.

JavaScriptGlue:

2008-10-24 Darin Adler <Darin Adler>

finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

JSObject.cpp: (nativeCallFunction):
JSUtils.cpp: (KJSValueToJSObject): (JSObjectKJSValue): (KJSValueToCFTypeInternal): (KJSValueToCFType):
JSUtils.h:
JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction):
JSValueWrapper.h:
UserObjectImp.cpp: (UserObjectImp::callAsFunction): (UserObjectImp::userObjectGetter): (UserObjectImp::getOwnPropertySlot): (UserObjectImp::put): (UserObjectImp::toPrimitive):
UserObjectImp.h: (UserObjectImp::createStructureID): Use JSValue* instead of JSValuePtr.

WebCore:

2008-10-24 Darin Adler <Darin Adler>

finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

bindings/js/JSAttrCustom.cpp:
bindings/js/JSCSSRuleCustom.cpp:
bindings/js/JSCSSStyleDeclarationCustom.cpp:
bindings/js/JSCSSValueCustom.cpp:
bindings/js/JSCanvasPixelArrayCustom.h:
bindings/js/JSCanvasRenderingContext2DCustom.cpp:
bindings/js/JSClipboardCustom.cpp:
bindings/js/JSConsoleCustom.cpp:
bindings/js/JSCustomSQLStatementCallback.cpp:
bindings/js/JSCustomSQLStatementErrorCallback.cpp:
bindings/js/JSCustomSQLTransactionCallback.cpp:
bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
bindings/js/JSCustomVoidCallback.cpp:
bindings/js/JSCustomVoidCallback.h:
bindings/js/JSCustomXPathNSResolver.cpp:
bindings/js/JSCustomXPathNSResolver.h:
bindings/js/JSDOMApplicationCacheCustom.cpp:
bindings/js/JSDOMBinding.cpp:
bindings/js/JSDOMBinding.h:
bindings/js/JSDOMWindowBase.cpp:
bindings/js/JSDOMWindowBase.h:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSDOMWindowCustom.h:
bindings/js/JSDOMWindowShell.cpp:
bindings/js/JSDOMWindowShell.h:
bindings/js/JSDatabaseCustom.cpp:
bindings/js/JSDedicatedWorkerCustom.cpp:
bindings/js/JSDocumentCustom.cpp:
bindings/js/JSElementCustom.cpp:
bindings/js/JSEventCustom.cpp:
bindings/js/JSEventListener.cpp:
bindings/js/JSEventTarget.cpp:
bindings/js/JSEventTarget.h:
bindings/js/JSEventTargetBase.h:
bindings/js/JSEventTargetNodeCustom.cpp:
bindings/js/JSHTMLAllCollection.h:
bindings/js/JSHTMLAppletElementCustom.cpp:
bindings/js/JSHTMLCollectionCustom.cpp:
bindings/js/JSHTMLDocumentCustom.cpp:
bindings/js/JSHTMLEmbedElementCustom.cpp:
bindings/js/JSHTMLFormElementCustom.cpp:
bindings/js/JSHTMLFrameElementCustom.cpp:
bindings/js/JSHTMLFrameSetElementCustom.cpp:
bindings/js/JSHTMLIFrameElementCustom.cpp:
bindings/js/JSHTMLInputElementCustom.cpp:
bindings/js/JSHTMLObjectElementCustom.cpp:
bindings/js/JSHTMLOptionsCollectionCustom.cpp:
bindings/js/JSHTMLSelectElementCustom.cpp:
bindings/js/JSHTMLSelectElementCustom.h:
bindings/js/JSHistoryCustom.cpp:
bindings/js/JSImageDataCustom.cpp:
bindings/js/JSInspectedObjectWrapper.cpp:
bindings/js/JSInspectedObjectWrapper.h:
bindings/js/JSInspectorCallbackWrapper.cpp:
bindings/js/JSInspectorCallbackWrapper.h:
bindings/js/JSJavaScriptCallFrameCustom.cpp:
bindings/js/JSLocationCustom.cpp:
bindings/js/JSMessagePortCustom.cpp:
bindings/js/JSMimeTypeArrayCustom.cpp:
bindings/js/JSNamedNodeMapCustom.cpp:
bindings/js/JSNamedNodesCollection.cpp:
bindings/js/JSNamedNodesCollection.h:
bindings/js/JSNavigatorCustom.cpp:
bindings/js/JSNodeCustom.cpp:
bindings/js/JSNodeFilterCondition.cpp:
bindings/js/JSNodeFilterCondition.h:
bindings/js/JSNodeFilterCustom.cpp:
bindings/js/JSNodeIteratorCustom.cpp:
bindings/js/JSNodeListCustom.cpp:
bindings/js/JSPluginArrayCustom.cpp:
bindings/js/JSPluginCustom.cpp:
bindings/js/JSPluginElementFunctions.cpp:
bindings/js/JSPluginElementFunctions.h:
bindings/js/JSQuarantinedObjectWrapper.cpp:
bindings/js/JSQuarantinedObjectWrapper.h:
bindings/js/JSRGBColor.cpp:
bindings/js/JSRGBColor.h:
bindings/js/JSSQLResultSetRowListCustom.cpp:
bindings/js/JSSQLTransactionCustom.cpp:
bindings/js/JSSVGElementInstanceCustom.cpp:
bindings/js/JSSVGLengthCustom.cpp:
bindings/js/JSSVGMatrixCustom.cpp:
bindings/js/JSSVGPathSegCustom.cpp:
bindings/js/JSSVGPathSegListCustom.cpp:
bindings/js/JSSVGPointListCustom.cpp:
bindings/js/JSSVGTransformListCustom.cpp:
bindings/js/JSStorageCustom.cpp:
bindings/js/JSStyleSheetCustom.cpp:
bindings/js/JSStyleSheetListCustom.cpp:
bindings/js/JSTextCustom.cpp:
bindings/js/JSTreeWalkerCustom.cpp:
bindings/js/JSXMLHttpRequestCustom.cpp:
bindings/js/JSXMLHttpRequestUploadCustom.cpp:
bindings/js/JSXSLTProcessorCustom.cpp:
bindings/js/ScheduledAction.cpp:
bindings/js/ScheduledAction.h:
bindings/js/ScriptController.cpp:
bindings/js/ScriptController.h:
bindings/objc/WebScriptObject.mm:
bindings/objc/WebScriptObjectPrivate.h:
bindings/scripts/CodeGeneratorJS.pm:
bridge/NP_jsobject.cpp:
bridge/c/c_instance.cpp:
bridge/c/c_instance.h:
bridge/c/c_runtime.cpp:
bridge/c/c_runtime.h:
bridge/c/c_utility.cpp:
bridge/c/c_utility.h:
bridge/jni/jni_instance.cpp:
bridge/jni/jni_instance.h:
bridge/jni/jni_jsobject.h:
bridge/jni/jni_jsobject.mm:
bridge/jni/jni_objc.mm:
bridge/jni/jni_runtime.cpp:
bridge/jni/jni_runtime.h:
bridge/jni/jni_utility.cpp:
bridge/jni/jni_utility.h:
bridge/objc/WebScriptObject.h:
bridge/objc/objc_class.h:
bridge/objc/objc_class.mm:
bridge/objc/objc_instance.h:
bridge/objc/objc_instance.mm:
bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:
bridge/objc/objc_utility.h:
bridge/objc/objc_utility.mm:
bridge/qt/qt_class.cpp:
bridge/qt/qt_class.h:
bridge/qt/qt_instance.cpp:
bridge/qt/qt_instance.h:
bridge/qt/qt_runtime.cpp:
bridge/qt/qt_runtime.h:
bridge/runtime.cpp:
bridge/runtime.h:
bridge/runtime_array.cpp:
bridge/runtime_array.h:
bridge/runtime_method.cpp:
bridge/runtime_method.h:
bridge/runtime_object.cpp:
bridge/runtime_object.h:
bridge/testqtbindings.cpp:
inspector/JavaScriptCallFrame.cpp:
inspector/JavaScriptCallFrame.h:
inspector/JavaScriptProfile.cpp:
inspector/JavaScriptProfile.h:
inspector/JavaScriptProfileNode.cpp:
inspector/JavaScriptProfileNode.h:
loader/FrameLoader.cpp:
loader/FrameLoader.h:
page/Console.cpp:
page/Console.h:
plugins/MimeTypeArray.h:
plugins/Plugin.h:
plugins/PluginArray.h:
plugins/PluginView.cpp:
xml/XMLHttpRequest.cpp: Use JSValue* instead of JSValuePtr.

WebKit/mac:

2008-10-24 Darin Adler <Darin Adler>

finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame _convertValueToObjcValue:]): (-[WebScriptCallFrame exception]): (-[WebScriptCallFrame evaluateWebScript:]):
WebView/WebView.mm: (aeDescFromJSValue): (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Use JSValue* instead of JSValuePtr.

WebKit/qt:

2008-10-24 Darin Adler <Darin Adler>

finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript): Use JSValue* instead of JSValuePtr.

WebKit/win:

2008-10-24 Darin Adler <Darin Adler>

finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString): (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): (WebScriptCallFrame::valueForVariable): (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
WebScriptCallFrame.h:
WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString): Use JSValue* instead of JSValuePtr.

WebKit/wx:

2008-10-24 Darin Adler <Darin Adler>

finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732

WebFrame.cpp: (wxWebFrame::RunScript): Use JSValue* instead of JSValuePtr.

7:43 AM Changeset in webkit [37844] by Simon Hausmann

2 edits in trunk/WebCore

2008-10-24 Simon Hausmann <Simon Hausmann>

Fix the Qt build.

6:55 AM QtWebKitTodo edited by Simon Hausmann

(diff)

6:54 AM QtWebKitTodo edited by Simon Hausmann

(diff)

6:42 AM Changeset in webkit [37843] by Simon Hausmann

5 edits in trunk/WebKit/qt

2008-10-23 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Invalid history entries could cause a crash in QT Webkit

12:39 AM Changeset in webkit [37842] by ddkilzer@apple.com

20 edits
24 deletes in trunk

Rolled out r37840 and r37841.

JavaScriptCore:

Rolled out r37840.

wtf/Platform.h:

WebCore:

Rolled out r37840 and r37841.

DerivedSources.make:
GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
bindings/js/JSCustomPositionCallback.cpp: Removed.
bindings/js/JSCustomPositionCallback.h: Removed.
bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
bindings/js/JSCustomPositionErrorCallback.h: Removed.
bindings/js/JSDOMBinding.cpp:
bindings/js/JSDOMBinding.h:
bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObjectWrapper):
bindings/js/JSGeolocationCustom.cpp: Removed.
bindings/js/JSNavigatorCustom.cpp:
dom/Document.cpp: (WebCore::Document::Document):
dom/Document.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):
page/Geolocation.cpp: Removed.
page/Geolocation.h: Removed.
page/Geolocation.idl: Removed.
page/Geoposition.cpp: Removed.
page/Geoposition.h: Removed.
page/Geoposition.idl: Removed.
page/Navigator.cpp: (WebCore::Navigator::disconnectFrame):
page/Navigator.h:
page/Navigator.idl:
page/PositionCallback.h: Removed.
page/PositionCallback.idl: Removed.
page/PositionError.h: Removed.
page/PositionError.idl: Removed.
page/PositionErrorCallback.h: Removed.
page/PositionErrorCallback.idl: Removed.
page/PositionOptions.h: Removed.
page/PositionOptions.idl: Removed.
platform/GeolocationService.cpp: Removed.
platform/GeolocationService.h: Removed.

LayoutTests:

Rolled out r37840.

geolocation/geolocation-not-implemented-expected.txt: Removed.
geolocation/geolocation-not-implemented.html: Removed.
geolocation/geolocation-test.js: Removed.

Oct 23, 2008:

10:39 PM Changeset in webkit [37841] by ddkilzer@apple.com

2 edits in trunk/WebCore

Attempt to fix GTK build.

GNUmakefile.am: Added new *.idl files that were missing.

10:05 PM Changeset in webkit [37840] by ddkilzer@apple.com

20 edits
25 adds in trunk

JavaScriptCore:

2008-10-23 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0

WebCore:

2008-10-23 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

Test: geolocation/geolocation-not-implemented.html

DerivedSources.make:
GNUmakefile.am: Added Geolocation support
WebCore.pro: Added Geolocation support
WebCore.vcproj/WebCore.vcproj: Added Geolocation support
WebCore.xcodeproj/project.pbxproj: Added Geolocation support
WebCoreSources.bkl: Added Geolocation support
bindings/js/JSCustomPositionCallback.cpp: Added. (WebCore::JSCustomPositionCallback::JSCustomPositionCallback): (WebCore::JSCustomPositionCallback::handleEvent):
bindings/js/JSCustomPositionCallback.h: Added. (WebCore::JSCustomPositionCallback::create):
bindings/js/JSCustomPositionErrorCallback.cpp: Added. (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback): (WebCore::JSCustomPositionErrorCallback::handleEvent):
bindings/js/JSCustomPositionErrorCallback.h: Added. (WebCore::JSCustomPositionErrorCallback::create):
bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom (WebCore::markDOMObjectWrapper):
bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
bindings/js/JSGeolocationCustom.cpp: Added. (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation (WebCore::JSNavigator::mark):
dom/Document.cpp: (WebCore::Document::Document):
dom/Document.h: (WebCore::Document::setUsingGeolocation): (WebCore::Document::usingGeolocation):
loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation (WebCore::FrameLoader::canCachePage):
page/Geolocation.cpp: Added. (WebCore::Geolocation::GeoNotifier::GeoNotifier): (WebCore::Geolocation::GeoNotifier::timerFired): (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::clearWatch): (WebCore::Geolocation::stopUpdatingIfEmpty): (WebCore::Geolocation::sendErrorToOneShots): (WebCore::Geolocation::sendErrorToWatchers): (WebCore::Geolocation::sendPositionToOneShots): (WebCore::Geolocation::sendPositionToWatchers): (WebCore::Geolocation::handleError): (WebCore::Geolocation::geolocationServicePositionChanged): (WebCore::Geolocation::geolocationServiceErrorOccurred):
page/Geolocation.h: Added. (WebCore::Geolocation::create): (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::GeoNotifier::create):
page/Geolocation.idl: Added.
page/Geoposition.cpp: Added. (WebCore::Geoposition::toString):
page/Geoposition.h: Added. (WebCore::Geoposition::create): (WebCore::Geoposition::latitude): (WebCore::Geoposition::longitude): (WebCore::Geoposition::altitude): (WebCore::Geoposition::accuracy): (WebCore::Geoposition::altitudeAccuracy): (WebCore::Geoposition::heading): (WebCore::Geoposition::velocity): (WebCore::Geoposition::timestamp): (WebCore::Geoposition::Geoposition):
page/Geoposition.idl: Added.
page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): disconnect Geolocation (WebCore::Navigator::geolocation): accessor for Geolocation
page/Navigator.h: (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
page/Navigator.idl: accessor for Geolocation
page/PositionCallback.h: Added. (WebCore::PositionCallback::~PositionCallback):
page/PositionCallback.idl: Added.
page/PositionError.h: Added. (WebCore::PositionError::): (WebCore::PositionError::create): (WebCore::PositionError::code): (WebCore::PositionError::message): (WebCore::PositionError::PositionError):
page/PositionError.idl: Added.
page/PositionErrorCallback.h: Added. (WebCore::PositionErrorCallback::~PositionErrorCallback):
page/PositionErrorCallback.idl: Added.
page/PositionOptions.h: Added. (WebCore::PositionOptions::create): (WebCore::PositionOptions::enableHighAccuracy): (WebCore::PositionOptions::setEnableHighAccuracy): (WebCore::PositionOptions::timeout): (WebCore::PositionOptions::setTimeout): (WebCore::PositionOptions::PositionOptions):
page/PositionOptions.idl: Added.
platform/GeolocationService.cpp: Added. (WebCore::GeolocationService::GeolocationService): (WebCore::GeolocationService::positionChanged): (WebCore::GeolocationService::errorOccurred):
platform/GeolocationService.h: Added. (WebCore::GeolocationServiceClient::~GeolocationServiceClient): (WebCore::GeolocationServiceClient::geolocationServicePositionChanged): (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred): (WebCore::GeolocationService::~GeolocationService):

LayoutTests:

2008-10-23 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475

Provide support for the Geolocation API

http://dev.w3.org/geo/api/spec-source.html

Tests to verify Geolocation isn't implemented (so that it didn't leak into
WebCore for platforms that do not support it).

geolocation: Added.
geolocation/geolocation-not-implemented-expected.txt: Added.
geolocation/geolocation-not-implemented.html: Added.
geolocation/geolocation-test.js: Added. (reset): (hanged): (watchPositionAndEnd): (watchPosition._positionCallback): (watchPosition): (watchPositionTestAndEnd): (watchPositionAndFail): (watchPositionAndTest._positionCallback): (watchPositionAndTest): (getCurrentPositionAndEnd): (getCurrentPosition._positionCallback): (getCurrentPosition): (getCurrentPositionTestAndEnd): (getCurrentPositionAndFail): (getCurrentPositionAndTest._positionCallback): (getCurrentPositionAndTest): (endTest): (relativeURL):

9:52 PM Changeset in webkit [37839] by alp@webkit.org

2 edits in trunk/WebCore

2008-10-23 Alp Toker <alp@nuanti.com>

Fix typo in comment in previous commit. GTK -> GLIB

platform/gtk/guriescape.c:

9:32 PM Changeset in webkit [37838] by alp@webkit.org

3 edits in trunk/WebCore

2008-10-23 Kalle Vahlman <kalle.vahlman@movial.com>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=21824
[GTK] FileSystem abstraction uses features from Glib 2.16

Wrap g_uri_unescape_string() to fix building with pre-2.16 Glib

platform/gtk/guriescape.c: (unescape_character): (_webcore_g_uri_unescape_segment): (_webcore_g_uri_unescape_string):
platform/gtk/guriescape.h:

8:44 PM Changeset in webkit [37837] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Fix Gtk build typo introduced in http://trac.webkit.org/changeset/37826.

GNUmakefile.am:

8:23 PM Changeset in webkit [37836] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

8:23 PM Changeset in webkit [37835] by mrowe@apple.com

1 copy in tags/Safari-5525.26.5

New tag.

6:04 PM Changeset in webkit [37834] by darin@chromium.org

2 edits in trunk/WebCore

2008-10-23 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

m_frame null checked but then dereferenced
https://bugs.webkit.org/show_bug.cgi?id=21845

This error was found using a static analysis tool, and so I do not know
how to produce a null m_frame on entry to this method. Hence, I have
not included a regression test.

page/EventHandler.cpp: (WebCore::EventHandler::allowDHTMLDrag): Add an early return.

5:18 PM Changeset in webkit [37833] by kmccullough@apple.com

2 edits in trunk/LayoutTests

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Rubber stamped by Mark Rowe.

-Skipping the profiler tests until we know why they fail on tiger:
<rdar://problem/6316530> Profiler tests fail on tiger

platform/mac-tiger/Skipped:

4:58 PM Changeset in webkit [37832] by ddkilzer@apple.com

5 edits in trunk

Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10

JavaScriptCore:

Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10

<https://bugs.webkit.org/show_bug.cgi?id=21832>

Reviewed by Sam Weinig.

pcre/dftables: Use imported tempfile() from File::Temp instead of 'new File::Temp' to make the script work with Perl 5.10.

WebKitTools:

Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10

<https://bugs.webkit.org/show_bug.cgi?id=21832>

Reviewed by Sam Weinig.

Scripts/bisect-builds: Use imported tempfile() from File::Temp instead of 'new File::Temp' to make the script work with Perl 5.10.
Scripts/sort-Xcode-project-file: Ditto.

3:29 PM Changeset in webkit [37831] by barraclough@apple.com

7 edits in trunk/JavaScriptCore

2008-10-23 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix hideous pathological case performance when looking up repatch info, bug #21727.

When repatching JIT code to optimize we look up records providing information about
the generated code (also used to track recsources used in linking to be later released).
The lookup was being performed using a linear scan of all such records.

(1) Split up the different types of reptach information. This means we can search them

separately, and in some cases should reduce their size.

(2) In the case of property accesses, search with a binary chop over the data.
(3) In the case of calls, pass a pointer to the repatch info into the relink function.

VM/CTI.cpp: (JSC::CTI::CTI): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile): (JSC::CTI::unlinkCall): (JSC::CTI::linkCall):
VM/CTI.h:
VM/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::unlinkCallers): (JSC::CodeBlock::derefStructureIDs):
VM/CodeBlock.h: (JSC::StructureStubInfo::StructureStubInfo): (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::setUnlinked): (JSC::CallLinkInfo::isLinked): (JSC::getStructureStubInfoReturnLocation): (JSC::binaryChop): (JSC::CodeBlock::addCaller): (JSC::CodeBlock::getStubInfo):
VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitResolve): (JSC::CodeGenerator::emitGetById): (JSC::CodeGenerator::emitPutById): (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitConstruct):
VM/Machine.cpp: (JSC::Machine::cti_vm_lazyLinkCall):

3:12 PM Changeset in webkit [37830] by kmccullough@apple.com

5 edits in trunk/LayoutTests

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Forgot to remove the tests from the skipped lists, this should have been
apart of the last checkin.

platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

3:10 PM Changeset in webkit [37829] by kmccullough@apple.com

39 edits
42 adds
2 deletes in trunk/LayoutTests

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=21817
Bug 21817: Manual profiler tests should be made into layout tests

Added the expected results for the profiler tests and removed the tests from the skipped list.
Also removed two tests that were accidentally checked in previously.
Also changed the text on the tests to be more apparent how to run them manually.

fast/profiler/anonymous-event-handler-expected.txt: Added.
fast/profiler/anonymous-event-handler.html:
fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Added.
fast/profiler/anonymous-function-called-from-different-contexts.html:
fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Added.
fast/profiler/anonymous-function-calls-built-in-functions.html:
fast/profiler/anonymous-function-calls-eval-expected.txt: Added.
fast/profiler/anonymous-function-calls-eval.html:
fast/profiler/apply-expected.txt: Added.
fast/profiler/apply.html:
fast/profiler/built-in-function-calls-anonymous-expected.txt: Added.
fast/profiler/built-in-function-calls-anonymous.html:
fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Added.
fast/profiler/built-in-function-calls-user-defined-function.html:
fast/profiler/call-expected.txt: Added.
fast/profiler/call-nodelist-as-function-expected.txt: Added.
fast/profiler/call-nodelist-as-function.html:
fast/profiler/call.html: Added.
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Added.
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
fast/profiler/compare-multiple-profiles-expected.txt: Added.
fast/profiler/compare-multiple-profiles.html:
fast/profiler/constructor-expected.txt: Added.
fast/profiler/constructor.html:
fast/profiler/dead-time-expected.txt: Added.
fast/profiler/dead-time.html:
fast/profiler/deep-recursion.html: Removed.
fast/profiler/document-dot-write-expected.txt: Added.
fast/profiler/document-dot-write.html:
fast/profiler/event-handler-expected.txt: Added.
fast/profiler/event-handler.html:
fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Added.
fast/profiler/execution-context-and-eval-on-same-line.html:
fast/profiler/heavy-view-expected.txt: Added.
fast/profiler/heavy-view.html:
fast/profiler/inline-event-handler-expected.txt: Added.
fast/profiler/inline-event-handler.html:
fast/profiler/many-calls-in-the-same-scope-expected.txt: Added.
fast/profiler/many-calls-in-the-same-scope.html: Added.
fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Added.
fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Added.
fast/profiler/multiple-and-different-scoped-function-calls.html:
fast/profiler/multiple-frames-expected.txt: Added.
fast/profiler/multiple-frames.html:
fast/profiler/multiple-windows.html: Removed.
fast/profiler/nested-anonymous-functon-expected.txt: Added.
fast/profiler/nested-anonymous-functon.html:
fast/profiler/nested-start-and-stop-profiler-expected.txt: Added.
fast/profiler/nested-start-and-stop-profiler.html:
fast/profiler/no-execution-context-expected.txt: Added.
fast/profiler/no-execution-context.html:
fast/profiler/one-execution-context-expected.txt: Added.
fast/profiler/one-execution-context.html:
fast/profiler/profile-calls-in-included-file-expected.txt: Added.
fast/profiler/profile-calls-in-included-file.html:
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Added.
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
fast/profiler/profiling-from-a-nested-location-expected.txt: Added.
fast/profiler/profiling-from-a-nested-location.html:
fast/profiler/simple-event-call-expected.txt: Added.
fast/profiler/simple-event-call.html:
fast/profiler/simple-no-level-change-expected.txt: Added.
fast/profiler/simple-no-level-change.html:
fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Added.
fast/profiler/start-and-stop-profiler-multiple-times.html:
fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Added.
fast/profiler/start-and-stop-profiling-in-the-same-function.html:
fast/profiler/start-but-dont-stop-profiling-expected.txt: Added.
fast/profiler/start-but-dont-stop-profiling.html:
fast/profiler/stop-profiling-after-setTimeout-expected.txt: Added.
fast/profiler/stop-profiling-after-setTimeout.html:
fast/profiler/stop-then-function-call-expected.txt: Added.
fast/profiler/stop-then-function-call.html:
fast/profiler/throw-exception-from-eval-expected.txt: Added.
fast/profiler/throw-exception-from-eval.html:
fast/profiler/two-execution-contexts-expected.txt: Added.
fast/profiler/two-execution-contexts.html:
fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Added.
fast/profiler/user-defined-function-calls-built-in-functions.html:
fast/profiler/window-dot-eval-expected.txt: Added.
fast/profiler/window-dot-eval.html:

2:56 PM Changeset in webkit [37828] by mitz@apple.com

4 edits
4 adds in trunk

WebCore:

Reviewed by Sam Weinig with no hesitation.

fix the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839 <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering

Test: fast/text/bidi-embedding-pop-and-push-same.html

platform/text/BidiResolver.h: (WebCore::BidiResolver::embed): Changed to only add the embedding operation to a vector of pending operations.

(WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Added. Moved the
code that used to be in the PDF case of embed() here, except the part
that sets the context.

(WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Added. Moved the
code that used to be in the non-PDF case of embed() here, except the
part the sets the context.

(WebCore::BidiResolver::commitExplicitEmbedding): Added. Processes the
explicit embedding operations in the vector by creating an updated
context and determining the old and new embedding levels. If the levels
are not the same, calls {lower,raise}ExplicitEmbeddingLevel(). Always
sets the context to the new one.

(WebCore::BidiResolver::createBidiRunsForLine): Added calls to
commitExplicitEmbedding() after calling embed() and after calling
increment().

rendering/bidi.cpp: (WebCore::bidiFirst): Added calls to commitExplicitEmbedding() because this function increments the resolver.

(WebCore::RenderBlock::skipLeadingWhitespace): Ditto.

LayoutTests:

Reviewed by Sam Weinig with no hesitation.

test for the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839 <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering

fast/text/bidi-embedding-pop-and-push-same.html: Added.
platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.

2:35 PM Changeset in webkit [37827] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Build fix.

2:24 PM Changeset in webkit [37826] by jmalonzo@webkit.org

3 edits
1 add in trunk/WebCore

2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix. Not reviewed.

Add DNSCurl and DNSSoup to the Gtk build

GNUmakefile.am:
platform/gtk/TemporaryLinkStubs.cpp:
platform/network/soup/DNSSoup.cpp: Copied from WebCore/platform/network/curl/DNSCurl.cpp. (WebCore::prefetchDNS):

2:17 PM Changeset in webkit [37825] by eric@webkit.org

3 edits in trunk/WebCore

Reviewed by Sam Weinig.

Un-break the Darwin build.

platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
platform/graphics/cg/ImageCG.cpp:

2:13 PM Changeset in webkit [37824] by darin@chromium.org

3 edits in trunk/WebCore

2008-10-23 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Fix forward decls to be struct instead of class.
https://bugs.webkit.org/show_bug.cgi?id=21838

rendering/style/StyleRareInheritedData.h:
rendering/style/StyleRareNonInheritedData.h:

1:36 PM Changeset in webkit [37823] by weinig@apple.com

2 edits in trunk/WebCore

2008-10-23 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Oliver Hunt.

platform/network/curl/ResourceRequest.h: A better implementation of CFURLRequest, rather than void*. This gives better compatibility with the WebKit.idl interface. (WebCore::ResourceRequest::cfURLRequest):

1:28 PM Changeset in webkit [37822] by kmccullough@apple.com

41 edits in trunk/LayoutTests

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=21817
Bug 21817: Manual profiler tests should be made into layout tests

Here are the changes to the tests. The most significant part is the change to profiler-test-JS-resources.js where endTest will now notify the layout test controller if it was waiting and call the print function to iterate over all of the profiles and log their structure.
Most of these tests changed to include the layoutTestController, use endTest() or call the print function directly if there was some reason that they could not use endTest().

fast/profiler/resources/profiler-test-JS-resources.js: (endTest): Stop any waits and print the profile information. (printHeavyProfilesDataWithoutTime): Print all profile information in heavy view, without time. (printProfilesDataWithoutTime): Print all profile information in tree view, without time. (printProfileNodeWithoutTime): Print a profile node's informmation and all of it's children's information.
fast/profiler/anonymous-event-handler.html:
fast/profiler/anonymous-function-called-from-different-contexts.html:
fast/profiler/anonymous-function-calls-built-in-functions.html:
fast/profiler/anonymous-function-calls-eval.html:
fast/profiler/apply.html:
fast/profiler/built-in-function-calls-anonymous.html:
fast/profiler/built-in-function-calls-user-defined-function.html:
fast/profiler/call-nodelist-as-function.html:
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
fast/profiler/compare-multiple-profiles.html:
fast/profiler/constructor.html:
fast/profiler/dead-time.html:
fast/profiler/deep-recursion.html:
fast/profiler/document-dot-write.html:
fast/profiler/event-handler.html:
fast/profiler/execution-context-and-eval-on-same-line.html:
fast/profiler/heavy-view.html:
fast/profiler/inline-event-handler.html:
fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
fast/profiler/multiple-and-different-scoped-function-calls.html:
fast/profiler/multiple-frames.html:
fast/profiler/nested-anonymous-functon.html:
fast/profiler/nested-start-and-stop-profiler.html:
fast/profiler/no-execution-context.html:
fast/profiler/one-execution-context.html:
fast/profiler/profile-calls-in-included-file.html:
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
fast/profiler/profiling-from-a-nested-location.html:
fast/profiler/simple-event-call.html:
fast/profiler/simple-no-level-change.html:
fast/profiler/start-and-stop-profiler-multiple-times.html:
fast/profiler/start-and-stop-profiling-in-the-same-function.html:
fast/profiler/start-but-dont-stop-profiling.html:
fast/profiler/stop-profiling-after-setTimeout.html:
fast/profiler/stop-then-function-call.html:
fast/profiler/throw-exception-from-eval.html:
fast/profiler/two-execution-contexts.html:
fast/profiler/user-defined-function-calls-built-in-functions.html:
fast/profiler/window-dot-eval.html:

12:59 PM Changeset in webkit [37821] by eric@webkit.org

3 edits in trunk/WebCore

2008-10-23 Mike Pinkerton <pinkerton@chromium.org>

Reviewed by Eric Seidel.

PLATFORM(CHROMIUM) uses CG the same way PLATFORM(MAC) does so fix
ifdefs to reflect that.

platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
platform/graphics/cg/ImageCG.cpp:

12:37 PM Changeset in webkit [37820] by pkasting@chromium.org

6 edits in trunk

JavaScriptCore:

2008-10-23 Peter Kasting <pkasting@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=21833
Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).

wtf/Platform.h:

WebCore:

2008-10-23 Peter Kasting <pkasting@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=21833
Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).

inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::close):
inspector/InspectorController.h:
page/Page.cpp: (WebCore::Page::Page):

12:24 PM Changeset in webkit [37819] by ddkilzer@apple.com

2 edits in trunk/JavaScriptCore

Bug 21831: Fix create_hash_table for Perl 5.10

<https://bugs.webkit.org/show_bug.cgi?id=21831>

Reviewed by Sam Weinig.

kjs/create_hash_table: Escaped square brackets so that Perl 5.10 doesn't try to use @nameEntries.

12:20 PM Changeset in webkit [37818] by Darin Adler

5 edits in trunk/LayoutTests

2008-10-23 Darin Adler <Darin Adler>

try to get buildbot green again

platform/gtk/Skipped: Added fast/profiler.
platform/mac/Skipped: Fixed typo: fast/profiler, not fast/profile.
platform/qt/Skipped: Added fast/profiler.
platform/win/Skipped: Fixed typo: fast/profiler, not fast/profile.

11:43 AM Changeset in webkit [37817] by kmccullough@apple.com

1 edit
43 copies
2 adds in trunk/LayoutTests

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Forgot to actually check these files in from last time :(

fast/profiler: Added.
fast/profiler/anonymous-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-event-handler.html.
fast/profiler/anonymous-function-called-from-different-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html.
fast/profiler/anonymous-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html.
fast/profiler/anonymous-function-calls-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html.
fast/profiler/apply.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-apply.html.
fast/profiler/built-in-function-calls-anonymous.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html.
fast/profiler/built-in-function-calls-user-defined-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html.
fast/profiler/call-nodelist-as-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-call-nodelist-as-function.html.
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html.
fast/profiler/compare-multiple-profiles.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-compare-multiple-profiles.html.
fast/profiler/constructor.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-constructor.html.
fast/profiler/dead-time.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-dead-time.html.
fast/profiler/deep-recursion.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-deep-recursion.html.
fast/profiler/document-dot-write.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-document-dot-write.html.
fast/profiler/event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-event-handler.html.
fast/profiler/execution-context-and-eval-on-same-line.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html.
fast/profiler/heavy-view.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-heavy-view.html.
fast/profiler/inline-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-inline-event-handler.html.
fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html.
fast/profiler/multiple-and-different-scoped-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html.
fast/profiler/multiple-frames.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-frames.html.
fast/profiler/multiple-windows.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-windows.html.
fast/profiler/nested-anonymous-functon.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-anonymous-functon.html.
fast/profiler/nested-start-and-stop-profiler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html.
fast/profiler/no-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-no-execution-context.html.
fast/profiler/one-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-one-execution-context.html.
fast/profiler/profile-calls-in-included-file.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profile-calls-in-included-file.html.
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html.
fast/profiler/profiling-from-a-nested-location.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html.
fast/profiler/resources: Added.
fast/profiler/resources/other-frame.html: Copied from ../WebCore/manual-tests/inspector/resources/other-frame.html.
fast/profiler/resources/other-window.html: Copied from ../WebCore/manual-tests/inspector/resources/other-window.html.
fast/profiler/resources/profiler-test-JS-resources.js: Copied from ../WebCore/manual-tests/inspector/resources/profiler-test-JS-resources.js.
fast/profiler/simple-event-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-event-call.html.
fast/profiler/simple-no-level-change.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-no-level-change.html.
fast/profiler/start-and-stop-profiler-multiple-times.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html.
fast/profiler/start-and-stop-profiling-in-the-same-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html.
fast/profiler/start-but-dont-stop-profiling.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html.
fast/profiler/stop-profiling-after-setTimeout.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html.
fast/profiler/stop-then-function-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-then-function-call.html.
fast/profiler/throw-exception-from-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-throw-exception-from-eval.html.
fast/profiler/two-execution-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-two-execution-contexts.html.
fast/profiler/user-defined-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html.
fast/profiler/window-dot-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-window-dot-eval.html.

11:33 AM Changeset in webkit [37816] by kmccullough@apple.com

4 edits
43 deletes in trunk

WebCore:

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=21817
Bug 21817: Manual profiler tests should be made into layout tests

-Moving the tests before diffing so that it's clear what changed.

manual-tests/inspector/profiler-test-anonymous-event-handler.html: Removed.
manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html: Removed.
manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html: Removed.
manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html: Removed.
manual-tests/inspector/profiler-test-apply.html: Removed.
manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html: Removed.
manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html: Removed.
manual-tests/inspector/profiler-test-call-nodelist-as-function.html: Removed.
manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Removed.
manual-tests/inspector/profiler-test-constructor.html: Removed.
manual-tests/inspector/profiler-test-dead-time.html: Removed.
manual-tests/inspector/profiler-test-deep-recursion.html: Removed.
manual-tests/inspector/profiler-test-document-dot-write.html: Removed.
manual-tests/inspector/profiler-test-event-handler.html: Removed.
manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html: Removed.
manual-tests/inspector/profiler-test-heavy-view.html: Removed.
manual-tests/inspector/profiler-test-inline-event-handler.html: Removed.
manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html: Removed.
manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html: Removed.
manual-tests/inspector/profiler-test-multiple-frames.html: Removed.
manual-tests/inspector/profiler-test-multiple-windows.html: Removed.
manual-tests/inspector/profiler-test-nested-anonymous-functon.html: Removed.
manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html: Removed.
manual-tests/inspector/profiler-test-no-execution-context.html: Removed.
manual-tests/inspector/profiler-test-one-execution-context.html: Removed.
manual-tests/inspector/profiler-test-profile-calls-in-included-file.html: Removed.
manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html: Removed.
manual-tests/inspector/profiler-test-simple-event-call.html: Removed.
manual-tests/inspector/profiler-test-simple-no-level-change.html: Removed.
manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html: Removed.
manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Removed.
manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Removed.
manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Removed.
manual-tests/inspector/profiler-test-stop-then-function-call.html: Removed.
manual-tests/inspector/profiler-test-throw-exception-from-eval.html: Removed.
manual-tests/inspector/profiler-test-two-execution-contexts.html: Removed.
manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html: Removed.
manual-tests/inspector/profiler-test-window-dot-eval.html: Removed.
manual-tests/inspector/resources/other-frame.html: Removed.
manual-tests/inspector/resources/other-window.html: Removed.
manual-tests/inspector/resources/profiler-test-JS-resources.js: Removed.

LayoutTests:

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=21817
Bug 21817: Manual profiler tests should be made into layout tests

-Moving the tests before diffing so that it's clear what changed.

platform/mac/Skipped: Skipping until the new files are in place.
platform/win/Skipped:
fast/profiler: Added.
fast/profiler/anonymous-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-event-handler.html.
fast/profiler/anonymous-function-called-from-different-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html.
fast/profiler/anonymous-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html.
fast/profiler/anonymous-function-calls-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html.
fast/profiler/apply.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-apply.html.
fast/profiler/built-in-function-calls-anonymous.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html.
fast/profiler/built-in-function-calls-user-defined-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html.
fast/profiler/call-nodelist-as-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-call-nodelist-as-function.html.
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html.
fast/profiler/compare-multiple-profiles.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-compare-multiple-profiles.html.
fast/profiler/constructor.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-constructor.html.
fast/profiler/dead-time.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-dead-time.html.
fast/profiler/deep-recursion.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-deep-recursion.html.
fast/profiler/document-dot-write.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-document-dot-write.html.
fast/profiler/event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-event-handler.html.
fast/profiler/execution-context-and-eval-on-same-line.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html.
fast/profiler/heavy-view.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-heavy-view.html.
fast/profiler/inline-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-inline-event-handler.html.
fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html.
fast/profiler/multiple-and-different-scoped-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html.
fast/profiler/multiple-frames.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-frames.html.
fast/profiler/multiple-windows.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-windows.html.
fast/profiler/nested-anonymous-functon.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-anonymous-functon.html.
fast/profiler/nested-start-and-stop-profiler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html.
fast/profiler/no-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-no-execution-context.html.
fast/profiler/one-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-one-execution-context.html.
fast/profiler/profile-calls-in-included-file.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profile-calls-in-included-file.html.
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html.
fast/profiler/profiling-from-a-nested-location.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html.
fast/profiler/resources: Added.
fast/profiler/resources/other-frame.html: Copied from ../WebCore/manual-tests/inspector/resources/other-frame.html.
fast/profiler/resources/other-window.html: Copied from ../WebCore/manual-tests/inspector/resources/other-window.html.
fast/profiler/resources/profiler-test-JS-resources.js: Copied from ../WebCore/manual-tests/inspector/resources/profiler-test-JS-resources.js.
fast/profiler/simple-event-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-event-call.html.
fast/profiler/simple-no-level-change.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-no-level-change.html.
fast/profiler/start-and-stop-profiler-multiple-times.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html.
fast/profiler/start-and-stop-profiling-in-the-same-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html.
fast/profiler/start-but-dont-stop-profiling.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html.
fast/profiler/stop-profiling-after-setTimeout.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html.
fast/profiler/stop-then-function-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-then-function-call.html.
fast/profiler/throw-exception-from-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-throw-exception-from-eval.html.
fast/profiler/two-execution-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-two-execution-contexts.html.
fast/profiler/user-defined-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html.
fast/profiler/window-dot-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-window-dot-eval.html.

10:52 AM Changeset in webkit [37815] by andersca@apple.com

3 edits in trunk/WebKitLibraries

2008-10-23 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Fix <rdar://problem/6306513> by adding a workaround for <rdar://problem/6304600>.

libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceTiger.a:

10:07 AM Changeset in webkit [37814] by abarth@webkit.org

2 edits in trunk/WebCore

2008-10-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21826

Add accessor for SecurityOrigin::m_domainWasSetInDOM.

page/SecurityOrigin.h: (WebCore::SecurityOrigin::domainWasSetInDOM):

9:49 AM Changeset in webkit [37813] by Adam Roben

3 edits in trunk/BugsSite

Fix Bug 21401: Comments field on "Review Patch" page should be initially filled with quoted patch

<https://bugs.webkit.org/show_bug.cgi?id=21401>

Reviewed by Dave Hyatt.

attachment.cgi: (edit): Retrieve the attachment data from the database instead of just its length. When the attachment is a patch, create a quotedpatch template variable that contains the patch data with each line prepended with "> ".
template/en/custom/attachment/reviewform.html.tmpl:
- Changed the comments field to have a monospace font
- Added an "Enter comments below:" caption above the comments field to make it clearer that this is where comments should go, now that the comments field is not initially empty
- Fill the comments field with the quoted patch

8:55 AM Changeset in webkit [37812] by Darin Adler

19 edits in trunk

JavaScriptCore:

2008-10-23 Darin Adler <Darin Adler>

roll out https://bugs.webkit.org/show_bug.cgi?id=21732 to remove the JSValuePtr class, to fix two problems

1) slowness under MSVC, since it doesn't handle a

class with a single pointer in it as efficiently
as a pointer

2) uninitialized pointers in Vector

JavaScriptCore.exp: Updated.

API/APICast.h: (toRef):
VM/CTI.cpp: (JSC::CTI::asInteger):
VM/CodeGenerator.cpp: (JSC::CodeGenerator::addConstant):
VM/CodeGenerator.h: (JSC::CodeGenerator::JSValueHashTraits::constructDeletedValue): (JSC::CodeGenerator::JSValueHashTraits::isDeletedValue):
VM/Machine.cpp: (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_vm_throw): Removed calls to payload functions.

VM/Register.h: (JSC::Register::Register): Removed overload for JSCell and call to payload function.

kjs/JSCell.h: Changed JSCell to derive from JSValue again. Removed JSValuePtr constructor. (JSC::asCell): Changed cast from reinterpret_cast to static_cast.

kjs/JSImmediate.h: Removed JSValuePtr class. Added typedef back.

kjs/JSValue.h: (JSC::JSValue::JSValue): Added empty protected inline constructor back. (JSC::JSValue::~JSValue): Same for destructor. Removed == and != operator for JSValuePtr.

kjs/PropertySlot.h: (JSC::PropertySlot::PropertySlot): Chnaged argument to const JSValue* and added a const_cast.

kjs/protect.h: Removed overloads and specialization for JSValuePtr.

JavaScriptGlue:

2008-10-23 Darin Adler <Darin Adler>

roll out https://bugs.webkit.org/show_bug.cgi?id=21732

JSValueWrapper.cpp: (JSValueWrapper::GetValue): Added missing call to .get().
JSValueWrapper.h: ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.

WebCore:

2008-10-23 Darin Adler <Darin Adler>

roll out https://bugs.webkit.org/show_bug.cgi?id=21732

bindings/js/ScheduledAction.h:
inspector/InspectorController.cpp: ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.

6:27 AM Changeset in webkit [37811] by Simon Hausmann

2 edits in trunk/WebKit/qt

2008-10-22 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

emit scrollRequested unconditionally when scrolling.

See https://bugs.webkit.org/show_bug.cgi?id=21790

6:26 AM Changeset in webkit [37810] by Simon Hausmann

2 edits in trunk/WebKit

Fix the ChangeLog after in r37761 I changed the wrong file accidentially.

6:18 AM Changeset in webkit [37809] by Simon Hausmann

2 edits in trunk/WebKit/qt

2008-10-23 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne.

Fix handling of mouse events when embedding QWebView into the
QGraphicsView.

QWebPage accepts or ignores events to indicate whether the web page
handled the event. However for QWebView to behave like a good widget
it should always accept the mouse events to indicate that it handled
them and that they should not be subject to event propagation.

The graphics view relies on acceptance of the initial mouse click to
make the embedded widget the focus item.

5:27 AM Changeset in webkit [37808] by Simon Hausmann

3 edits in trunk/WebCore

2008-10-23 Simon Hausmann <Simon Hausmann>

Fix the Qt build.

5:23 AM Changeset in webkit [37807] by ap@webkit.org

3 edits in trunk/LayoutTests

Reviewed by Maciej Stachowiak.

Fix fast/events/message-port.html to not be timing-dependent (it was failing on some bots).

fast/events/message-port.html:
fast/events/message-port-expected.txt:

3:15 AM Changeset in webkit [37806] by ap@webkit.org

10 edits
2 adds in trunk/WebCore

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=21825
JSDOMBinding should not blindly cast the global object to JSDOMWindow

bindings/js/JSDOMGlobalObject.cpp:
bindings/js/JSDOMGlobalObject.h:
GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl: Added JSDOMGlobalObject, a base class to be used by both Window and worker contexts.

bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMStructure): (WebCore::cacheDOMStructure): (WebCore::getCachedDOMConstructor): (WebCore::cacheDOMConstructor): Cast to JSDOMGlobalObject, as DOM objects live in DOM global objects.

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase):
bindings/js/JSDOMWindowBase.h:
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark): Moved constructor and structure tracking to JSDOMGlobalObject.

2:43 AM Changeset in webkit [37805] by abarth@webkit.org

7 edits
2 adds in trunk

WebCore:

2008-10-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21787

Update postMessage to send origin = "null" for non-serializable
origins to match latest spec. Merge SecurityOrigin::toString and
SecurityOrigin::toHTTPOrigin because they are now the same.

Test: http/tests/security/postMessage/data-url-sends-null-origin.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::outgoingOrigin): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::addHTTPOriginIfNeeded): (WebCore::FrameLoader::loadItem):
loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):
page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
page/SecurityOrigin.h:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):

LayoutTests:

2008-10-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21787

Add test coverage for postMessaging from a data URL.

http/tests/security/postMessage/data-url-sends-null-origin-expected.txt: Added.
http/tests/security/postMessage/data-url-sends-null-origin.html: Added.

Oct 22, 2008:

8:36 PM Changeset in webkit [37804] by oliver@apple.com

6 edits in trunk/JavaScriptCore

Really "fix" CTI mode on windows 2k3.

Reviewed my Maciej Stachowiak

This adds new methods fastMallocExecutable and fastFreeExecutable
to wrap allocation for cti code. This still just makes fastMalloc
return executable memory all the time, which will be fixed in a
later patch.

However in windows debug builds all executable allocations will be
allocated on separate executable pages, which should resolve any
remaining 2k3 issues. Conveniently the 2k3 bot will now also fail
if there are any fastFree vs. fastFreeExecutable errors.

7:53 PM Changeset in webkit [37803] by ddkilzer@apple.com

6 edits in trunk/WebCore

Bug 21781: WebCore::Settings should have a maximum decoded image size setting

<https://bugs.webkit.org/show_bug.cgi?id=21781>

Reviewed by Antti.

No tests since there is no change in behavior.

loader/CachedImage.cpp: (WebCore::CachedImage::maximumDecodedImageSize): Added. Returns WebCore::Settings::maximumDecodedImageSize() or 0 on error. (WebCore::CachedImage::data): Flag an error if the image being loaded is too big.
loader/CachedImage.h: (WebCore::CachedImage::maximumDecodedImageSize): Added declaration.
page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_maximumDecodedImageSize to the maximum value of size_t.
page/Settings.h: (WebCore::Settings::setMaximumDecodedImageSize): Added method. (WebCore::Settings::maximumDecodedImageSize): Ditto.

7:31 PM Changeset in webkit [37802] by cwzwarich@webkit.org

2 edits in trunk/LayoutTests

2008-10-22 Cameron Zwarich <zwarich@apple.com>

Reviewed by Kevin McCullough.

Check in changed test results for r37792.

fast/dom/Window/window-properties-expected.txt:

6:43 PM Changeset in webkit [37801] by Darin Adler

2 edits in trunk/WebCore

2008-10-22 Mike Pinkerton <pinkerton@chromium.org>

Reviewed by Dan Bernstein.
Landed and tweaked a bit by Darin Adler.

fix https://bugs.webkit.org/show_bug.cgi?id=21809

Remove PLATFORM(MAC) wrapping USE(ATSUI). It's redundant and inhibits
its use for PLATFORM(CHROMIUM) in the future.

platform/graphics/SimpleFontData.h:

5:49 PM Changeset in webkit [37800] by dsmith@webkit.org

3 edits
2 adds in trunk

WebCore:

2008-10-22 David Smith <catfish.man@gmail.com>

Reviewed by andersca.

https://bugs.webkit.org/show_bug.cgi?id=19974
getElementsByClassName not live enough

Test: fast/dom/getElementsByClassName/015.html

dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): call dispatchSubtreeModifiedEvent()

LayoutTests:

2008-10-22 David Smith <catfish.man@gmail.com>

Reviewed by andersca.

https://bugs.webkit.org/show_bug.cgi?id=19974
getElementsByClassName not live enough

fast/dom/getElementsByClassName/015-expected.txt: Added.
fast/dom/getElementsByClassName/015.html: Added.

5:11 PM Changeset in webkit [37799] by Darin Adler

42 edits in trunk

JavaScriptCore:

2008-10-22 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=21294 Bug 21294: Devirtualize getOwnPropertySlot()

A bit over 3% faster on V8 tests.

JavascriptCore.exp: Export leak-related functions..

API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructureID): Set HasStandardGetOwnPropertySlot since this class doesn't override getPropertySlot.
API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructureID): Ditto.

VM/ExceptionHelpers.cpp: (JSC::InterruptedExecutionError::InterruptedExecutionError): Use a structure that's created just for this class instead of trying to share a single "null prototype" structure.

VM/Machine.cpp: (JSC::Machine::cti_op_create_arguments_no_params): Rename Arguments::ArgumentsNoParameters to Arguments::NoParameters.

kjs/Arguments.h: Rename the enum from Arguments::ArgumentsParameters to Arguments::NoParametersType and the value from Arguments::ArgumentsNoParameters to Arguments::NoParameters. (JSC::Arguments::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot. (JSC::Arguments::Arguments): Added an assertion that there are no parameters.

kjs/DatePrototype.h: (JSC::DatePrototype::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

kjs/FunctionPrototype.h: (JSC::FunctionPrototype::createStructureID): Set HasStandardGetOwnPropertySlot since this class doesn't override getPropertySlot.
kjs/InternalFunction.h: (JSC::InternalFunction::createStructureID): Ditto.

kjs/JSArray.h: (JSC::JSArray::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

kjs/JSCell.h: Added declaration of fastGetOwnPropertySlot; a non-virtual version that uses the structure bit to decide whether to call the virtual version.

kjs/JSFunction.h: (JSC::JSFunction::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Initialize new structures; removed nullProtoStructureID.
kjs/JSGlobalData.h: Added new structures. Removed nullProtoStructureID.

kjs/JSGlobalObject.h: (JSC::JSGlobalObject::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

kjs/JSNotAnObject.h: (JSC::JSNotAnObjectErrorStub::JSNotAnObjectErrorStub): Use a structure that's created just for this class instead of trying to share a single "null prototype" structure. (JSC::JSNotAnObjectErrorStub::isNotAnObjectErrorStub): Marked this function virtual for clarity and made it private since no one should call it if they already have a pointer to this specific type. (JSC::JSNotAnObject::JSNotAnObject): Use a structure that's created just for this class instead of trying to share a single "null prototype" structure. (JSC::JSNotAnObject::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

kjs/JSObject.h: (JSC::JSObject::createStructureID): Added HasStandardGetOwnPropertySlot. (JSC::JSObject::inlineGetOwnPropertySlot): Added. Used so we can share code between getOwnPropertySlot and fastGetOwnPropertySlot. (JSC::JSObject::getOwnPropertySlot): Moved so that functions are above the functions that call them. Moved the guts of this function into inlineGetOwnPropertySlot. (JSC::JSCell::fastGetOwnPropertySlot): Added. Checks the HasStandardGetOwnPropertySlot bit and if it's set, calls inlineGetOwnPropertySlot, otherwise calls getOwnPropertySlot. (JSC::JSObject::getPropertySlot): Changed to call fastGetOwnPropertySlot. (JSC::JSValue::get): Changed to call fastGetOwnPropertySlot.

kjs/JSWrapperObject.h: Made constructor protected to emphasize that this class is only a base class and never instantiated.

kjs/MathObject.h: (JSC::MathObject::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
kjs/NumberConstructor.h: (JSC::NumberConstructor::createStructureID): Ditto.
kjs/RegExpConstructor.h: (JSC::RegExpConstructor::createStructureID): Ditto.
kjs/RegExpObject.h: (JSC::RegExpObject::createStructureID): Ditto.
kjs/StringObject.h: (JSC::StringObject::createStructureID): Ditto.

kjs/TypeInfo.h: Added HasStandardGetOwnPropertySlot flag and hasStandardGetOwnPropertySlot accessor function.

JavaScriptGlue:

2008-10-22 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=21294 Bug 21294: Devirtualize getOwnPropertySlot()

JSRun.cpp: (JSGlueGlobalObject::JSGlueGlobalObject): Moved constructor here. Set up flags in its new location in global object data, and set up a structure for UserObjectImp too. (JSRun::JSRun): Added code to give the JSGlueGlobalObject its own unique structure, rather than using the default one from JSGlobalObject.

JSRun.h: Made JSGlueGlobalObject take a structure ID. Also moved the data into a separate data object. And added userObjectStructure, a Structure to be used by UserObjectImp.

JSUtils.cpp: Removed unused sharedGlobalData global. (JSObjectKJSValue): Pass Structure in when creating UserObjectImp. (unprotectGlobalObject): Use JSGlueGLobalObject type specifically. (initializeGlobalObjectKey): Removed code to set up unused sharedGlobalData. (getThreadGlobalObject): Added. Shared by JSObjectKJSValue and getThreadGlobalExecState. Also now passes in a structure ID when creating the global object. (getThreadGlobalExecState): Changed to call getThreadGlobalObject.

UserObjectImp.cpp: (UserObjectImp::UserObjectImp): Changed to take a structure.
UserObjectImp.h: (UserObjectImp::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

WebCore:

2008-10-22 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=21294 Bug 21294: Devirtualize getOwnPropertySlot()

bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.

bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::JSInspectorCallbackWrapper::wrap): Change to use a unique structure for this class rather than sharing nullProtoStructureID, which no longer exists.

bindings/js/JSNamedNodesCollection.h: (WebCore::JSNamedNodesCollection::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
bindings/js/JSRGBColor.h: (WebCore::JSRGBColor::createStructureID): Ditto.

bindings/scripts/CodeGeneratorJS.pm: Added createStructureID functions for the wrappers, constructors, and prototypes in any case where they override getOwnPropertySlot, without HasStandardGetOwnPropertySlot.

bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructureID): Added. Returns a structure without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethod::createStructureID): Ditto.
bridge/runtime_array.h: (JSC::RuntimeArray::createStructureID): Ditto.
bridge/runtime_method.h: (JSC::RuntimeMethod::createStructureID): Ditto.
bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructureID): Ditto.

4:34 PM Changeset in webkit [37798] by Adam Roben

2 edits in trunk/WebCore

Bring Windows Cairo Port's font handling in line with CG.
http://bugs.webkit.org/show_bug.cgi?id=21812.

Reviewed by Adam Roben.

platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): Remove unnecessary special-case for Cairo TrueType font search. It should match CG in all font selections.

4:33 PM Changeset in webkit [37797] by Adam Roben

7 edits
1 add in trunk

WebCore:

2008-10-22 Brent Fulgham <bfulgham@gmail.com>

Correct build regressions in Cairo port for Windows.
http://bugs.webkit.org/show_bug.cgi?id=21724

Reviewed by Adam Roben.

WebCore.vcproj/WebCore.vcproj: Fixed include paths and post-build event for the Debug_Cairo and Release_Cairo configurations.
platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::GraphicsContext): Update to newer constructor signature.
platform/network/curl/DNSCurl.cpp: Added. (WebCore::prefetchDNS):
platform/network/curl/ResourceRequest.h:
platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarTheme::nativeTheme):

WebKit/win:

2008-10-22 Brent Fulgham <bfulgham@gmail.com>

Correct build regressions in Cairo port for Windows.
http://bugs.webkit.org/show_bug.cgi?id=21724

Reviewed by Adam Roben.

WebView.cpp: (WebView::notifyPreferencesChanged): Don't try to call setShouldPaintNativeControls when SafariTheme support is disabled, as that function doesn't exist in that case.

4:31 PM Changeset in webkit [37796] by beidson@apple.com

9 edits in trunk

LayoutTests:
2008-10-22 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben

<rdar://6261773> - autocomplete="off" doesn't work on Windows

Remove a skipped test that can now pass with proper DRT support

platform/win/Skipped: Remove security/autocomplete-cleared-on-back.html

WebKitTools:
2008-10-22 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben

<rdar://6261773> - autocomplete="off" doesn't work on Windows

Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows

DumpRenderTree/win/LayoutTestControllerWin.cpp:

WebKit/win:
2008-10-22 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben

Move elementDoesAutoComplete() to IWebFramePrivate so it is exposed for DRT to use

Interfaces/IWebFramePrivate.idl:

WebFrame.cpp: (WebFrame::elementDoesAutoComplete):
WebFrame.h:

WebHTMLRepresentation.cpp: (WebHTMLRepresentation::elementDoesAutoComplete):

4:19 PM Changeset in webkit [37795] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r37793.

4:12 PM Changeset in webkit [37794] by timothy@apple.com

1 edit in trunk/WebCore/inspector/front-end/ElementsTreeOutline.js

Add a license to ElementsTreeOutline.js that was left off when it was split out from ElementsPanel.js.

4:06 PM Changeset in webkit [37793] by beidson@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben

<rdar://6261773> - autocomplete="off" doesn't work on Windows

Visual Studio makes a poor decision regarding the combination of enums and bitfields, such that a
statement like "m_autocomplete = Off" followed by "return m_autocomplete == Off" would return "false"
instead of the much more correct "true."

In the past we have worked around this by declaring the bitfield member as an unsigned instead
of the enum type.

For more discussion, see http://trac.webkit.org/changeset/25329

html/HTMLInputElement.h: Work around insane Visual Studio enum issue *sigh*

4:05 PM Changeset in webkit [37792] by kmccullough@apple.com

1 edit in trunk/WebCore/ChangeLog

2008-10-22 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt and Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=19225
Bug 19225: JSProfiler: Create automated profiler tests

This change exports profiles on the console object so that they can be iterated over via JavaScript, and thus can be used in automated tests.

bindings/js/JSConsoleCustom.cpp: Get the profiles and return an array that JS can use. (WebCore::JSConsole::profiles):
inspector/InspectorController.h: Use the new typedef. (WebCore::InspectorController::profiles):
page/Console.cpp: Keep our own array of profile objects. (WebCore::Console::profileEnd):
page/Console.h: Ditto. (WebCore::Console::profiles):
page/Console.idl: Expose the profiles to JS.

4:04 PM Changeset in webkit [37791] by kmccullough@apple.com

6 edits in trunk/WebCore

2008-10-22 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt and Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=19225
Bug 19225: JSProfiler: Create automated profiler tests

This change exports profiles on the console object so that they can be iterated over via JavaScript, and thus can be used in automated tests.

bindings/js/JSConsoleCustom.cpp: Get the profiles and return an array that JS can use. (WebCore::JSConsole::profiles):
inspector/InspectorController.h: Use the new typedef. (WebCore::InspectorController::profiles):
page/Console.cpp: Keep our own array of profile objects. (WebCore::Console::profileEnd):
page/Console.h: Ditto. (WebCore::Console::profiles):
page/Console.idl: Expose the profiles to JS.

2:51 PM Changeset in webkit [37790] by hyatt@apple.com

11 edits in trunk/WebCore

2008-10-22 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21775

Convert buttons over to use the new Theme API on OS X.

Reviewed by Adam Roben

platform/LengthBox.h: (WebCore::LengthBox::LengthBox):
platform/Theme.cpp: (WebCore::Theme::controlBorder): (WebCore::Theme::controlPadding):
platform/Theme.h: (WebCore::Theme::controlFont): (WebCore::Theme::controlSize): (WebCore::Theme::minControlSize): (WebCore::Theme::controlRequiresPreWhiteSpace):
platform/mac/ThemeMac.h: (WebCore::ThemeMac::controlRequiresPreWhiteSpace):
platform/mac/ThemeMac.mm: (WebCore::checkboxSize): (WebCore::radioSize): (WebCore::buttonSizes): (WebCore::buttonMargins): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeMac::controlFont): (WebCore::ThemeMac::controlSize): (WebCore::ThemeMac::minControlSize): (WebCore::ThemeMac::controlBorder): (WebCore::ThemeMac::controlPadding): (WebCore::ThemeMac::inflateControlPaintRect): (WebCore::ThemeMac::paint):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::controlStatesForRenderer): (WebCore::RenderTheme::isDefault): (WebCore::RenderTheme::adjustRadioStyle):
rendering/RenderTheme.h: (WebCore::RenderTheme::setRadioSize):
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): (WebCore::menuListButtonSizes): (WebCore::RenderThemeMac::adjustMenuListStyle):
rendering/style/RenderStyle.h: (WebCore::InheritedFlags::paddingBox): (WebCore::InheritedFlags::setPaddingBox):

2:06 PM Changeset in webkit [37789] by cwzwarich@webkit.org

6 edits in trunk/JavaScriptCore

2008-10-22 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21803: Fuse op_jfalse with op_eq_null and op_neq_null
<https://bugs.webkit.org/show_bug.cgi?id=21803>

Fuse op_jfalse with op_eq_null and op_neq_null to make the new opcodes
op_jeq_null and op_jneq_null.

This is a 2.6% speedup on the V8 Raytrace benchmark, and strangely also
a 4.7% speedup on the V8 Arguments benchmark, even though it uses
neither of the two new opcodes.

VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitJumpIfTrue): (JSC::CodeGenerator::emitJumpIfFalse):
VM/Machine.cpp: (JSC::Machine::privateExecute):
VM/Opcode.h:

12:53 PM Changeset in webkit [37788] by Simon Fraser

1 edit
6 moves in trunk/LayoutTests

2008-10-22 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Moved tests from css3 to animations/transforms directories.

animations/change-keyframes-expected.txt: Renamed from LayoutTests/css3/change-keyframes-expected.txt.
animations/change-keyframes.html: Renamed from LayoutTests/css3/change-keyframes.html.
animations/keyframes-rule-expected.txt: Renamed from LayoutTests/css3/keyframes-rule-expected.txt.
animations/keyframes-rule.html: Renamed from LayoutTests/css3/keyframes-rule.html.
transforms/transform-value-types-expected.txt: Renamed from LayoutTests/css3/transform-value-types-expected.txt.
transforms/transform-value-types.html: Renamed from LayoutTests/css3/transform-value-types.html.

12:53 PM Changeset in webkit [37787] by Simon Hausmann

4 edits in trunk/WebKit/qt

2008-10-22 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

For public API, use the term boundingRect instead of boundingBox.

Api/qwebframe.cpp: (QWebHitTestResultPrivate::QWebHitTestResultPrivate): (QWebHitTestResult::boundingRect):
Api/qwebframe.h:
Api/qwebframe_p.h:

12:35 PM Changeset in webkit [37786] by Simon Fraser

5 edits
2 adds in trunk

2008-10-22 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt

Make sure that the AtomicString that identifies a set of animation keyframes
stays live by keeping a copy in the WebKitCSSKeyframesRule.

Also call styleSheetChanged() when the keyframes name changes, but
add an internal method that doesn't call styleSheetChanged() for use
during normal stylesheet parsing.

Test: animations/change-keyframes-name.html

css/CSSGrammar.y:
css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::setName):
css/WebKitCSSKeyframesRule.h: (WebCore::WebKitCSSKeyframesRule::setNameInternal):

11:32 AM Changeset in webkit [37785] by Darin Adler

2 edits in trunk/WebKitTools

2008-10-22 Darin Adler <Darin Adler>

Scripts/do-webcore-rename: More renaming plans.

10:43 AM Changeset in webkit [37784] by ap@webkit.org

6 edits in trunk/WebCore

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21791
WebCore JS bindings should be able to use non-static hash tables for properties

Add a map for HashTables to WebCore JS client data.

This makes property access noticeably slower, so it is an opt-in. For classes that need to be
supported in workers in forseeable future this is not critical.

bindings/js/JSDOMBinding.cpp: (WebCore::DOMObjectHashTableMap::get): (WebCore::DOMObjectHashTableMap::mapFor): (WebCore::getHashTableForGlobalData): (WebCore::DOMObjectWrapperMap::mapFor): WebCore client data is now a class that contains both a DOM wrapper map and a property hash table one.

bindings/js/JSDOMBinding.h: Added getHashTableForGlobalData() to query the hash table map.

bindings/scripts/CodeGeneratorJS.pm: If the class has a NoStaticTables attribute, use JSDOMBinding map to access its property hash tables.

dom/MessageChannel.idl:
dom/MessagePort.idl: Added NoStaticTables attribute.

9:47 AM Changeset in webkit [37783] by darin@chromium.org

2 edits in trunk/JavaScriptCore

2008-10-22 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is defined
https://bugs.webkit.org/show_bug.cgi?id=21757

PLATFORM(CHROMIUM) implies HAVE_ACCESSIBILITY

wtf/Platform.h:

9:16 AM Changeset in webkit [37782] by alp@webkit.org

2 edits in trunk/WebKit/gtk

2008-10-22 Alp Toker <alp@nuanti.com>

Build fix for older GTK+ versions where GTK_TYPE_TARGET_LIST isn't
defined.

webkit/webkitwebview.cpp:

7:24 AM Changeset in webkit [37781] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-22 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Correct opcode names in documentation.

VM/Machine.cpp: (JSC::Machine::privateExecute):

6:55 AM Changeset in webkit [37780] by alp@webkit.org

2 edits in trunk/WebCore

2008-10-22 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Timothy Hatcher.

Build failure because of missing include
https://bugs.webkit.org/show_bug.cgi?id=21765

Build failure fix for WebKit/GTK+; added missing
include (GOwnPtr.h)

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:

6:51 AM Changeset in webkit [37779] by alp@webkit.org

4 edits in trunk

2008-10-22 Alp Toker <alp@nuanti.com>

Reviewed by Adam Roben.

Fix crashes on older GTK+ versions (2.8). gtk_widget_style_get()
doesn't initialize values if the requested property doesn't exist, so
initialize the values to the documented defaults before calling it
where necessary. Additionally, avoid critical warnings by not calling
gtk_widget_style_get() when we know the property isn't available.

Note that this is an imported source file which doesn't follow the
WebKit coding style.

Avoid critical warnings on older GTK+ versions (2.8) by not checking
for GTK+ setting properties when we know they don't exist.

3:38 AM Changeset in webkit [37778] by alp@webkit.org

5 edits in trunk

2008-10-22 Alp Toker <alp@nuanti.com>

Fix build for Cairo 1.2.

1:22 AM Changeset in webkit [37777] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

12:56 AM Changeset in webkit [37776] by darin@chromium.org

3 edits in trunk/WebCore

2008-10-22 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

A little more PLATFORM(CHROMIUM) in WebCore
https://bugs.webkit.org/show_bug.cgi?id=21758

page/AccessibilityObject.h:
platform/graphics/Icon.h:

12:54 AM Changeset in webkit [37775] by abarth@webkit.org

3 edits in trunk/LayoutTests

2008-10-22 Jungshik Shin <jshin@chromium.org>

Reviewed by Alexey Proskuryakov.
Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=21581

Replace x-mac-cyrillic by windows-1256.

http/tests/misc/frame-default-enc-same-domain-expected.txt:
http/tests/misc/frame-default-enc-same-domain.html:

12:15 AM Changeset in webkit [37774] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

12:14 AM Changeset in webkit [37773] by mrowe@apple.com

1 copy in tags/Safari-5525.26.2

New tag.

Oct 21, 2008:

11:49 PM Changeset in webkit [37772] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Attempt to make the win2k3 bot be more useful for testing

RS=Maciej Stachowiak.

Force FastMalloc to make all allocated pages executable in
a vague hope this will allow the Win2k3 bot to be able to
run tests.

Filed Bug 21783: Need more granular control over allocation of executable memory
to cover a more granular version of this patch.

11:07 PM Changeset in webkit [37771] by ap@webkit.org

7 edits
2 adds in trunk

Reviewed by Darin Adler.

Test: fast/events/message-channel-gc-3.html

https://bugs.webkit.org/show_bug.cgi?id=21769
MessagePort should be GC protected if there are messages to be delivered

dom/MessagePort.h: Removed pending activity count. Now we track if a close event is pending, and check if the queue is non-empty. (WebCore::MessagePort::workerContext): Added a stub implementation for a cross-heap GC bug fix (below).

dom/MessagePort.cpp: (WebCore::CloseMessagePortTimer::fired): (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::queueCloseEvent): (WebCore::MessagePort::dispatchCloseEvent): (WebCore::MessagePort::hasPendingActivity): Track message and close event activity separately.

bindings/js/JSDOMBinding.cpp: (WebCore::markCrossHeapDependentObjectsForDocument): Fixed a bug in cross-heap GC that was causing same-heap ports to never be deleted.

wtf/MessageQueue.h: (WTF::::isEmpty): Added. Also added a warning for methods that return a snapshot of queue state, thus likely to cause race conditions.

8:10 PM Changeset in webkit [37770] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Sam Weinig.

remove unreachable code

platform/text/BidiResolver.h: (WebCore::::embed):

5:41 PM Changeset in webkit [37769] by sfalken@apple.com

2 edits in trunk/WebKitTools

2008-10-21 Steve Falkenburg <sfalken@apple.com>

Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.

Scripts/extract-localizable-strings:

5:22 PM Changeset in webkit [37768] by Beth Dakin

2 edits in trunk/WebCore

2008-10-21 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=20352
REGRESSION(r31030-31055): Choosing "Print window" from frame set
prints blank page
and corresponding: <rdar://problem/6142398>

viewHeight() and viewWidth() only return valuable information if we
are not printing. Everywhere else in the code, we make sure we are
not printing before we call these functions. Adding a check for
printing here fixes this bug, and framesets print again.

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):

5:16 PM Changeset in webkit [37767] by mrowe@apple.com

3 edits in branches/Safari-3-2-branch/WebKit/win

Merge r37489.

5:16 PM Changeset in webkit [37766] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r37704.

5:16 PM Changeset in webkit [37765] by mrowe@apple.com

8 edits in branches/Safari-3-2-branch

Merge r31577.

3:33 PM Changeset in webkit [37764] by Simon Hausmann

4 edits in trunk/WebKit/qt

2008-06-03 Siraj Razick <siraj.razick@collabora.co.uk>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=19374

Expose boundingBox value in QWebHitTestResult

Add API function QRect QWebHitResult::boundingBox() const

API docs by Ariya.

2:29 PM Changeset in webkit [37763] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-21 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

convert post-increment to pre-increment in a couple more places for speed

Speeds up V8 benchmarks a little on most computers. (But, strangely, slows
them down a little on my computer.)

kjs/nodes.cpp: (JSC::statementListEmitCode): Removed default argument, since we always want to specify this explicitly. (JSC::ForNode::emitCode): Tolerate ignoredResult() as the dst -- means the same thing as 0. (JSC::ReturnNode::emitCode): Ditto. (JSC::ThrowNode::emitCode): Ditto. (JSC::FunctionBodyNode::emitCode): Pass ignoredResult() so that we know we don't have to compute the result of function statements.

2:09 PM Changeset in webkit [37762] by pkasting@chromium.org

2 edits in trunk/JavaScriptCore

2008-10-21 Peter Kasting <pkasting@google.com>

Reviewed by Maciej Stachowiak.

Fix an include of a non-public header to use "" instead of <>.

API/JSProfilerPrivate.cpp:

10:27 AM Changeset in webkit [37761] by Simon Hausmann

2 edits in trunk/WebKit

2008-10-21 Yael <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

emit repaintRequested unconditionally when repaint is requested.

5:57 AM Changeset in webkit [37760] by Simon Hausmann

2 edits in trunk/WebCore

2008-10-21 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon.

Pixmap in canvas tag was not getting initialized.

See https://bugs.webkit.org/show_bug.cgi?id=21771

Oct 20, 2008:

11:08 PM Changeset in webkit [37759] by weinig@apple.com

10 edits in trunk

JavaScriptCore:

2008-10-20 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21766
REGRESSION: 12 JSC tests fail

The JSGlobalObject was mutating the shared nullProtoStructureID when
used in jsc. Instead of using nullProtoStructureID, use a new StructureID.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h: (JSC::::JSCallbackObject):
API/JSContextRef.cpp: (JSGlobalContextCreateInGroup):
kjs/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject):
kjs/Shell.cpp: (GlobalObject::GlobalObject): (jscmain):

JavaScriptGlue:

2008-10-20 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21766
REGRESSION: 12 JSC tests fail

The JSGlobalObject constructor no longer takes a JSGlobalData
as an argument.

JSRun.cpp: (JSRun::JSRun):
JSRun.h: (JSGlueGlobalObject::JSGlueGlobalObject):
JSUtils.cpp: (getThreadGlobalExecState):

11:01 PM Changeset in webkit [37758] by Simon Fraser

3 edits in trunk/WebCore

2008-10-20 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

Add a comment explaining layoutDelta(), and an assertion
that checks that delta changes were correctly paired during layout.

rendering/RenderView.cpp: (WebCore::RenderView::layout):
rendering/RenderView.h:

9:50 PM Changeset in webkit [37757] by timothy@apple.com

2 edits in trunk/WebCore

Make auto-complete only suggest properties that are valid syntax
when using dot-notation. Also when completing numeric properties,
the quotes are omitted inside the brackets.

https://bugs.webkit.org/show_bug.cgi?id=21760
https://bugs.webkit.org/show_bug.cgi?id=21761

Reviewed by Oliver Hunt.

inspector/front-end/Console.js: (WebInspector.Console.prototype.completions): Skip properties that are not valid identifies when using dot-notation. And omit the quotes when completing numbers in bracket-notation.

9:50 PM Changeset in webkit [37756] by timothy@apple.com

3 edits in trunk/WebCore

Fixes the Profiles panel in the Web Inspector, which was broken by
the JSValue base-class changes. Also renames some functions and
variables in JavaScriptProfileNode.cpp that where title case.

https://bugs.webkit.org/show_bug.cgi?id=21764

Reviewed by Oliver Hunt.

inspector/JavaScriptProfile.cpp: (WebCore::toJS): Use a JSObject pointer instead of JSValuePtr so the returned JSValuePtr will be treated as an object and not a value.
inspector/JavaScriptProfileNode.cpp: (WebCore::toJS): Ditto.

7:45 PM Changeset in webkit [37755] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-20 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Remove an untaken branch in CodeGenerator::emitJumpIfFalse(). This
function is never called with a backwards target LabelID, and there is
even an assertion to this effect at the top of the function body.

VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitJumpIfFalse):

7:14 PM Changeset in webkit [37754] by weinig@apple.com

19 edits in trunk

WebCore:

2008-10-20 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.

loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::detachedFromParent4):.
loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent):
loader/FrameLoaderClient.h:

WebKit/gtk:

2008-10-20 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.

WebCoreSupport/FrameLoaderClientGtk.cpp:
WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2008-10-20 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

WebKit/qt:

2008-10-20 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.

WebCoreSupport/FrameLoaderClientQt.cpp:
WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2008-10-20 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.

WebFrame.cpp:
WebFrame.h:

WebKit/wx:

2008-10-20 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.

WebKitSupport/FrameLoaderClientWx.cpp:
WebKitSupport/FrameLoaderClientWx.h:

6:22 PM Changeset in webkit [37753] by Antti Koivisto

2 edits in trunk/WebCore

2008-10-20 Antti Koivisto <Antti Koivisto>

Reviewed by Adele Peterson.

Fix https://bugs.webkit.org/show_bug.cgi?id=21763
REGRESSION (r36108-r36113): Can't load picture content on wired.com galleries
<rdar://problem/6285025

If we get 304 response we need to explicitly check if that completes the frame load.

No test case, simulating the condition is pretty difficult.

loader/loader.cpp: (WebCore::Loader::Host::didReceiveResponse):

6:05 PM Changeset in webkit [37752] by andersca@apple.com

2 edits in trunk/WebCore

2008-10-20 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Work around <rdar://problem/6301728>.

Don't assert that loads are deferred when we're using CFNetwork on Mac or Windows.

loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail):

5:20 PM Changeset in webkit [37751] by cwzwarich@webkit.org

1 edit in trunk/JavaScriptCore/ChangeLog

2008-10-20 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Update the ChangeLog for previous commit to contain meaningful
information.

ChangeLog

5:10 PM Changeset in webkit [37750] by cwzwarich@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-20 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

VM/Machine.cpp: (JSC::Machine::privateExecute):

3:47 PM Changeset in webkit [37749] by Beth Dakin

2 edits in trunk/WebCore

2008-10-20 Beth Dakin <Beth Dakin>

Reviewed by Adele Peterson.

Speculative fix for <rdar://problem/6242585> CrashTracer: [USER] 19
crashes in Safari at com.apple.WebCore
WebCore::ScrollView::visibleContentRect const + 153

d->m_view can be null and is null-checked at other points in the
code. The logs indicate that this crash occurs when closing a
window containing a PDF, so in case where we crash, the PDF's view
is probably already null. So the fix is to simply add a null-check.

page/Frame.cpp: (WebCore::Frame::selectionRect):

2:31 PM Changeset in webkit [37748] by adele@apple.com

2 edits in trunk/WebCore

2008-10-20 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Removed stray increment that would screw up any form with multiple files in it.

2:27 PM Changeset in webkit [37747] by weinig@apple.com

24 edits in trunk/JavaScriptCore

2008-10-16 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21683
Don't create intermediate StructureIDs for builtin objects

Second stage in reduce number of StructureIDs created when initializing the
JSGlobalObject.

Use putDirectWithoutTransition for the remaining singleton objects to reduce the number of StructureIDs create for about:blank from 132 to 73.

kjs/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
kjs/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
kjs/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
kjs/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
kjs/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
kjs/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
kjs/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
kjs/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype): (JSC::FunctionPrototype::addFunctionProperties):
kjs/FunctionPrototype.h: (JSC::FunctionPrototype::createStructureID):
kjs/InternalFunction.cpp:
kjs/InternalFunction.h: (JSC::InternalFunction::InternalFunction):
kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
kjs/JSObject.h:
kjs/MathObject.cpp: (JSC::MathObject::MathObject):
kjs/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
kjs/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
kjs/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
kjs/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
kjs/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
kjs/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
kjs/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
kjs/StructureID.cpp: (JSC::StructureID::dumpStatistics):
kjs/StructureID.h: (JSC::StructureID::setPrototypeWithoutTransition):

1:42 PM Changeset in webkit [37746] by weinig@apple.com

12 edits
2 copies in trunk/WebCore

2008-10-20 Sam Weinig <sam@webkit.org>

Rubber-stamped by David Hyatt.

Split LengthBox and LengthSize into their own files.

GNUmakefile.am:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/Length.h: (WebCore::Length::blend):
platform/LengthBox.h: Copied from platform/Length.h. (WebCore::LengthBox::LengthBox): (WebCore::LengthBox::nonZero):
platform/LengthSize.h: Copied from platform/Length.h. (WebCore::LengthSize::LengthSize): (WebCore::LengthSize::setWidth): (WebCore::LengthSize::setHeight): (WebCore::LengthSize::height):
platform/Theme.h:
rendering/style/FillLayer.h:
rendering/style/NinePieceImage.h: (WebCore::NinePieceImage::NinePieceImage):
rendering/style/RenderStyle.h:
rendering/style/StyleDashboardRegion.h:
rendering/style/StyleSurroundData.h:
rendering/style/StyleVisualData.h:

1:15 PM Changeset in webkit [37745] by mitz@apple.com

2 edits in trunk/WebCore

Mac build fix

WebCore.xcodeproj/project.pbxproj:

12:30 PM Changeset in webkit [37744] by alp@webkit.org

4 edits in trunk

2008-10-20 Alp Toker <alp@nuanti.com>

Fix autotools dist build target by listing recently added header
files only. Not reviewed.

12:27 PM Changeset in webkit [37743] by hyatt@apple.com

7 edits
1 add in trunk/WebCore

2008-10-20 David Hyatt <hyatt@apple.com>

Clean up some USE(NEW_THEME) ifdefs (I botched one of them and have broken non-Mac platforms). Also
refactor some of the code that I put in ThemeMac to be cross-platform, since it was in RenderTheme.cpp
originally.

ifdef some methods in RenderTheme.cpp also that are no longer needed with the new Theme.

Reviewed by Adam Roben

WebCore.xcodeproj/project.pbxproj:
platform/Theme.cpp: Added. (WebCore::Theme::controlSupportsBorder): (WebCore::Theme::controlSupportsPadding):
platform/Theme.h:
platform/mac/ThemeMac.h:
platform/mac/ThemeMac.mm:
rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle):
rendering/RenderTheme.h:

12:18 PM Changeset in webkit [37742] by hyatt@apple.com

7 edits in trunk/WebCore

2008-10-20 David Hyatt <hyatt@apple.com>

Rename LengthBox's members to have m_ in front of them.

Reviewed by Sam Weinig

css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForNinePieceImage): (WebCore::getPositionOffsetValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapNinePieceImage):
platform/Length.h: (WebCore::LengthBox::LengthBox): (WebCore::LengthBox::left): (WebCore::LengthBox::right): (WebCore::LengthBox::top): (WebCore::LengthBox::bottom): (WebCore::LengthBox::operator==): (WebCore::LengthBox::nonZero):
rendering/RenderObject.cpp: (WebCore::RenderObject::paintNinePieceImage): (WebCore::RenderObject::addDashboardRegions):
rendering/style/RenderStyle.cpp: (WebCore::positionedObjectMoved): (WebCore::RenderStyle::setClip): (WebCore::RenderStyle::noneDashboardRegions):
rendering/style/RenderStyle.h: (WebCore::InheritedFlags::left): (WebCore::InheritedFlags::right): (WebCore::InheritedFlags::top): (WebCore::InheritedFlags::bottom): (WebCore::InheritedFlags::clipLeft): (WebCore::InheritedFlags::clipRight): (WebCore::InheritedFlags::clipTop): (WebCore::InheritedFlags::clipBottom): (WebCore::InheritedFlags::marginTop): (WebCore::InheritedFlags::marginBottom): (WebCore::InheritedFlags::marginLeft): (WebCore::InheritedFlags::marginRight): (WebCore::InheritedFlags::paddingTop): (WebCore::InheritedFlags::paddingBottom): (WebCore::InheritedFlags::paddingLeft): (WebCore::InheritedFlags::paddingRight): (WebCore::InheritedFlags::setLeft): (WebCore::InheritedFlags::setRight): (WebCore::InheritedFlags::setTop): (WebCore::InheritedFlags::setBottom): (WebCore::InheritedFlags::setDashboardRegion): (WebCore::InheritedFlags::setClipLeft): (WebCore::InheritedFlags::setClipRight): (WebCore::InheritedFlags::setClipTop): (WebCore::InheritedFlags::setClipBottom): (WebCore::InheritedFlags::setMarginTop): (WebCore::InheritedFlags::setMarginBottom): (WebCore::InheritedFlags::setMarginLeft): (WebCore::InheritedFlags::setMarginRight): (WebCore::InheritedFlags::setPaddingTop): (WebCore::InheritedFlags::setPaddingBottom): (WebCore::InheritedFlags::setPaddingLeft): (WebCore::InheritedFlags::setPaddingRight):

12:03 PM Changeset in webkit [37741] by timothy@apple.com

3 edits in trunk/WebCore

Make the Resource panel perform graph updates atomically, so when resources
are added the graph and summary graph update at the same time.

https://bugs.webkit.org/show_bug.cgi?id=21755

Reviewed by Kevin McCullough.

inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get startTime): Return -1 if the _startTime property is undefined, null or 0. This allows callers to check for -1 and not the other values when there is no startTime yet. (WebInspector.Resource.prototype.get responseReceivedTime): Ditto. (WebInspector.Resource.prototype.get endTime): Ditto. (WebInspector.Resource.prototype.get duration): Remove an extra empty line. (WebInspector.Resource.prototype.get latency): Ditto. (WebInspector.Resource.prototype.get contentLength): Return 0 if the _duration property is undefined or null. This allows callers to always assume a number. (WebInspector.Resource.prototype.get expectedContentLength): Ditto. (WebInspector.Resource.prototype.get errors): Simplify the case where there is no _errors property yet. (WebInspector.Resource.prototype.set errors): Remove the check if the new value if the same as the previous value, since there is no work to guard. (WebInspector.Resource.prototype.get warnings): Simplify the case where there is no _warnings property yet. (WebInspector.Resource.prototype.set warnings): Remove the check if the new value if the same as the previous value, since there is no work to guard. (WebInspector.Resource.CompareByResponseReceivedTime): Add cases for when the responseReceivedTime is -1. (WebInspector.Resource.CompareByEndTime): Add cases for when the endTime is -1.
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get searchableViews): If a resource does not have a _resourcesTreeElement yet, exclude it from the searchable views. (WebInspector.ResourcesPanel.prototype.set calculator): Set _staleResource to _resources and call refresh to refresh the entire graph. (WebInspector.ResourcesPanel.prototype.set needsRefresh): Set a timeout if the panel is visible that calls refresh. (WebInspector.ResourcesPanel.prototype.refresh): Create the resource tree element and graph for a resource if it hasn't been created yet. If the boundaries changed during the first stale resource pass, do a full pass of all resources when updating the graphs. (WebInspector.ResourcesPanel.prototype.reset): Remove the legend items. (WebInspector.ResourcesPanel.prototype.addResource): Don't create the tree element and graph, these are now created during the first refresh. (WebInspector.ResourcesPanel.prototype.removeResource): Null check _resourcesTreeElement. (WebInspector.ResourcesPanel.prototype.addMessageToResource): Ditto. (WebInspector.ResourcesPanel.prototype.clearMessages): Ditto. (WebInspector.ResourcesPanel.prototype.refreshResource): Remove most of the work, just add the resource to the _staleResources and set needsRefresh. (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Null check _resourcesTreeElement. (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded): Remove code to clear the timeout used by the deleted _sortResourcesSoonIfNeeded. Remove call to removeChild since the insertBefore call will do it if needed. (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Remove code to clear the timeout used by the deleted _updateGraphDividersSoonIfNeeded. (WebInspector.ResourcesPanel.prototype._updateSummaryGraph): Remove code to clear the timeout used by the deleted _updateSummaryGraphSoon. No need to remove the totalLegendLabel, since all the legend items are removed in one pass right before. (WebInspector.ResourcesPanel.prototype._changeSortingFunction): Set the sortingFunction before the calculator so the correct sortingFunction is there when a refresh happens. (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphPercentages): Set start to 0 when the startTime is -1, since that looks best visually. Also set middle and end to the start and middle (respectfully) when startAtZero. This looks best visually. (WebInspector.ResourceGraph): Start the graph as hidden until the first refresh. (WebInspector.ResourceGraph.prototype.refresh): Remove the hidden class.

11:45 AM Changeset in webkit [37740] by hyatt@apple.com

3 edits in trunk/WebCore

2008-10-20 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21733

Make sure that the haveMetadata flag is set to true for generated images from image buffers, so that
no attempt is made to re-cache the frame from a non-existent image source.

Reviewed by Sam Weinig

platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage):

11:23 AM Changeset in webkit [37739] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by John Sullivan.

make hasARenderedDescendant() have internal linkage

editing/CompositeEditCommand.cpp: (WebCore::hasARenderedDescendant):

11:04 AM Changeset in webkit [37738] by alp@webkit.org

2 edits in trunk

2008-10-20 Alp Toker <alp@nuanti.com>

Partial GTK+/Win32 build fix. Lowercase library name to enable linking
when cross-compiling Windows binaries from Linux: -lWs2_32 -> -lws2_32

configure.ac:

10:57 AM Changeset in webkit [37737] by Chris Fleizach

3 edits
2 adds in trunk

Bug 21721: 1 crash in Safari at com.apple.WebCore • WebCore::RenderTableSection::numColumns const + 12

10:42 AM Changeset in webkit [37736] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-10-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Anders Carlsson.

VM/Machine.cpp: (JSC::Machine::tryCacheGetByID): Removed a redundant and sometimes incorrect cast, which started ASSERTing after Darin's last checkin.

10:40 AM Changeset in webkit [37735] by hyatt@apple.com

2 edits in trunk/WebCore

2008-10-20 David Hyatt <hyatt@apple.com>

Avoid some stderr spew from CG by checking if we have a decoder yet in ImageSourceCG.

Reviewed by Darin Adler

platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::repetitionCount): (WebCore::ImageSource::frameDurationAtIndex):

10:28 AM Changeset in webkit [37734] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2008-10-20 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Re-enable CTI, which I accidentally disabled while checking in fixes
to bytecode.

wtf/Platform.h:

10:10 AM Changeset in webkit [37733] by alp@webkit.org

2 edits in trunk/JavaScriptCore

2008-10-20 Alp Toker <alp@nuanti.com>

Rubber-stamped by Mark Rowe.

Typo fix in function name: mimimum -> minimum.

kjs/DateMath.cpp: (JSC::minimumYearForDST): (JSC::equivalentYearForDST):

10:06 AM Changeset in webkit [37732] by alp@webkit.org

9 edits in trunk

2008-10-20 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

Use pthread instead of GThread where possible in the GTK+ port. This
fixes issues with global initialisation, particularly on GTK+/Win32
where a late g_thread_init() will cause hangs.

Fix the pthread conditionals in the FTP code to correctly define
threadsafe *_r functions on Windows. Partly fixes the GTK+/Win32
build.

9:50 AM Changeset in webkit [37731] by hyatt@apple.com

15 edits in trunk/WebCore

2008-10-20 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21751

Convert checkboxes and radio buttons on OS X over to the new Theme API.

Reviewed by Adam Roben

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapFillSize):
platform/Length.h: (WebCore::LengthSize::LengthSize): (WebCore::LengthSize::operator==): (WebCore::LengthSize::width): (WebCore::LengthSize::height): (WebCore::LengthSize::setWidth): (WebCore::LengthSize::setHeight):
platform/Theme.h: (WebCore::Theme::controlSize): (WebCore::Theme::controlSupportsBorder): (WebCore::Theme::controlSupportsPadding): (WebCore::Theme::paint): (WebCore::Theme::inflateControlPaintRect):
platform/ThemeTypes.h: (WebCore::):
platform/mac/ThemeMac.h:
platform/mac/ThemeMac.mm: (WebCore::): (WebCore::controlSizeForFont): (WebCore::sizeFromFont): (WebCore::setControlSize): (WebCore::updateStates): (WebCore::inflateRect): (WebCore::checkboxSizes): (WebCore::checkboxMargins): (WebCore::checkboxSize): (WebCore::checkbox): (WebCore::paintCheckbox): (WebCore::radioSizes): (WebCore::radioMargins): (WebCore::radioSize): (WebCore::radio): (WebCore::paintRadio): (WebCore::ThemeMac::baselinePositionAdjustment): (WebCore::ThemeMac::controlSize): (WebCore::ThemeMac::controlSupportsBorder): (WebCore::ThemeMac::controlSupportsPadding): (WebCore::ThemeMac::inflateControlPaintRect): (WebCore::ThemeMac::paint):
rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize):
rendering/RenderObject.cpp: (WebCore::mustRepaintFillLayers):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::baselinePosition): (WebCore::RenderTheme::adjustRepaintRect): (WebCore::RenderTheme::controlStatesForRenderer): (WebCore::RenderTheme::isFocused):
rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect):
rendering/style/FillLayer.cpp: (WebCore::FillLayer::operator==):

9:48 AM Changeset in webkit [37730] by ggaren@apple.com

20 edits
2 adds in trunk

JavaScriptCore:

2008-10-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed https://bugs.webkit.org/show_bug.cgi?id=21735
Emit profiling instrumentation only if the Web Inspector's profiling
feature is enabled

22.2% speedup on empty function call benchmark.
2.9% speedup on v8 benchmark.
0.7% speedup on SunSpider.

Lesser but similar speedups in bytecode.

VM/CTI.cpp: (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): Nixed JITed profiler hooks. Profiler hooks now have their own opcodes. Added support for compiling profiler hook opcodes.

(JSC::CodeBlock::dump): Dump support for the new profiling opcodes.

VM/CodeGenerator.h:
VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitConstruct): Conditionally emit profiling hooks around call and construct, at the call site. (It's easier to get things right this way, if you have profiled code calling non-profiled code. Also, you get a slightly more accurate profile, since you charge the full cost of the call / construct operation to the callee.)

Also, fixed a bug where construct would fetch the ".prototype" property
from the constructor before evaluating the arguments to the constructor,
incorrectly allowing an "invalid constructor" exception to short-circuit
argument evaluation. I encountered this bug when trying to make
constructor exceptions work with profiling.

VM/Machine.cpp: (JSC::Machine::callEval): Removed obsolete profiler hooks.

(JSC::Machine::throwException): Added a check for an exception thrown
within a call instruction. We didn't need this before because the call
instruction would check for a valid call before involing the profiler.
(JSC::Machine::execute): Added a didExecute hook at the end of top-level
function invocation, since op_ret no longer does this for us.

(JSC::Machine::privateExecute): Removed obsolete profiler hooks. Added
profiler opcodes. Changed some ++vPC to vPC[x] notation, since the
latter is better for performance, and it makes reasoning about the
current opcode in exception handling much simpler.

(JSC::Machine::cti_op_call_NotJSFunction): Removed obsolete profiler
hooks.

(JSC::Machine::cti_op_create_arguments_no_params): Added missing
CTI_STACK_HACK that I noticed when adding CTI_STACK_HACK to the new
profiler opcode functions.

(JSC::Machine::cti_op_profile_will_call):
(JSC::Machine::cti_op_profile_did_call): The new profiler opcode
functions.

(JSC::Machine::cti_op_construct_NotJSConstruct): Removed obsolete profiler
hooks.

VM/Machine.h: (JSC::Machine::isCallOpcode): Helper for exception handling.

VM/Opcode.h: Declare new opcodes.

kjs/JSGlobalObject.h: (JSC::JSGlobalObject::supportsProfiling): Added virtual interface that allows WebCore to specify whether the target global object has the Web Inspector's profiling feature enabled.

profiler/Profiler.cpp: (JSC::Profiler::willExecute): (JSC::Profiler::didExecute): (JSC::Profiler::createCallIdentifier):
profiler/Profiler.h: Added support for invoking the profiler with an arbitrary JSValue*, and not a known object. We didn't need this before because the call instruction would check for a valid call before involing the profiler.

WebCore:

2008-10-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed https://bugs.webkit.org/show_bug.cgi?id=21735
Emit profiling instrumentation only if the Web Inspector's profiling
feature is enabled

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsProfiling):
bindings/js/JSDOMWindowBase.h: Implemented the interface for specifying whether a target global object has the Web Inspector's profiling feature enabled.

inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctionsSoon): (WebCore::JavaScriptDebugServer::didAddListener): (WebCore::JavaScriptDebugServer::didRemoveListener):
inspector/JavaScriptDebugServer.h: Exported an API for recompiling, used by the Settings object.

page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setDeveloperExtrasEnabled):
page/Settings.h: Recompile when the developer menu is enabled/disabled for the first time, to add/remove profiling hooks. In the future, with better Web Inspector UI, we can do this on a page-by-page basis, instead of a global basis.

LayoutTests:

2008-10-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Test for bugs fixed while working on https://bugs.webkit.org/show_bug.cgi?id=21735
Emit profiling instrumentation only if the Web Inspector's profiling
feature is enabled

fast/js/exception-thrown-from-new-expected.txt: Added.
fast/js/exception-thrown-from-new.html: Added.

9:42 AM Changeset in webkit [37729] by ap@webkit.org

2 edits in trunk/LayoutTests

Add Worker to the results - although it is just a stub right now, it is present in the list
of window properties.

fast/dom/Window/window-properties-expected.txt:

9:22 AM Changeset in webkit [37728] by Darin Adler

5 edits in trunk/JavaScriptCore

2008-10-20 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

get CTI working on Windows again

VM/CTI.cpp: (JSC::CTI::emitCTICall): Add an overload for functions that return JSObject*.
VM/CTI.h: Use JSValue* and JSObject* as return types for cti_op functions. Apparently, MSVC doesn't handle returning the JSValuePtr struct in a register. We'll have to look into this more.

VM/Machine.cpp: (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstructFast): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_vm_throw): Change these functions to return pointer types, and never JSValuePtr.
VM/Machine.h: Ditto.

9:09 AM Changeset in webkit [37727] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2008-10-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed some recent break-age in bytecode mode.

VM/CodeBlock.cpp: (JSC::CodeBlock::printStructureIDs): Fixed up an ASSERT caused by Gavin's last checkin. This is a temporary fix so I can keep on moving. I'll send email about what I think is an underlying problem soon.

VM/Machine.cpp: (JSC::Machine::privateExecute): Removed a redundant and sometimes incorrect cast, which started ASSERTing after Darin's last checkin.

8:54 AM Changeset in webkit [37726] by hyatt@apple.com

6 edits
2 moves in trunk/WebCore

2008-10-20 David Hyatt <hyatt@apple.com>

Move Length to platform/.

Reviewed by Adam Roben

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
platform/Length.cpp: Copied from rendering/Length.cpp.
platform/Length.h: Copied from rendering/Length.h.

8:39 AM Changeset in webkit [37725] by alp@webkit.org

4 edits in trunk/WebKit/gtk

2008-10-20 Alp Toker <alp@nuanti.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=21303
[GTK] Scrolling glitches

Implement a buffering scheme to avoid full repaints when scrolling
views or subframes significantly improving scrolling performance.

Improve rendering performance by coalescing large numbers of small
repaints.

Also fixes long-running issues with scrollbar positioning and frame
invalidation.

Rendering in the GTK+ port should be more similar to other ports after
these changes.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::repaint): (WebKit::ChromeClient::scroll):
WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::forceLayout):
webkit/webkitwebview.cpp:

8:29 AM Changeset in webkit [37724] by Darin Adler

2 edits in trunk/WebCore

2008-10-20 Darin Adler <Darin Adler>

try to fix Qt build

bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Add asObject calls. (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.

8:28 AM Changeset in webkit [37723] by Darin Adler

3 edits in trunk/WebCore

2008-10-20 Darin Adler <Darin Adler>

try to fix Qt build

bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::mark): Use JSValue* instead of JSValuePtr. (JSC::Bindings::QtField::valueFromInstance): Ditto.
bridge/qt/qt_instance.h: Ditto.

8:24 AM Changeset in webkit [37722] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-20 Darin Adler <Darin Adler>

another similar Windows build fix

VM/CTI.cpp: Changed return type to JSObject* instead of JSValuePtr.

8:19 AM Changeset in webkit [37721] by Darin Adler

3 edits in trunk/JavaScriptCore

2008-10-20 Darin Adler <Darin Adler>

try to fix Windows build

VM/CTI.cpp: Use JSValue* instead of JSValuePtr for ctiTrampoline.
VM/CTI.h: Ditto.

8:16 AM Changeset in webkit [37720] by Darin Adler

3 edits in trunk/WebCore

2008-10-20 Darin Adler <Darin Adler>

try to fix Tiger build

bridge/objc/objc_instance.mm: (ObjcInstance::invokeMethod): Add a const_cast to remove the unwanted volatile qualifier. (ObjcInstance::invokeDefaultMethod): Ditto. (ObjcInstance::getValueOfUndefinedField): Ditto.
bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcField::valueFromInstance): Ditto.

8:14 AM Changeset in webkit [37719] by ap@webkit.org

1 edit in trunk/WebCore/rendering/RenderLayer.cpp

Commit a file that was missing from the previous check-in.

8:13 AM Changeset in webkit [37718] by ap@webkit.org

24 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21750
Eliminate the notion of "temporary events"

We mark some events as temporary when dispatching, for the sole reason of
manually calling forgetDOMObject when done dispatching.

There doesn't seem to be any reason to call it manually, as JSEvent destructor
will do this automatically right away.

bindings/js/ScriptController.cpp:
bindings/js/ScriptController.h: Removed ScriptController::finishedWithEvent(), which was called after dispatching a temporary event.

dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
dom/EventTarget.h:
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchEvent): (WebCore::EventTargetNode::dispatchGenericEvent): (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): (WebCore::EventTargetNode::dispatchWindowEvent): (WebCore::EventTargetNode::dispatchUIEvent): (WebCore::EventTargetNode::dispatchKeyEvent): (WebCore::EventTargetNode::dispatchMouseEvent): (WebCore::EventTargetNode::dispatchWheelEvent): (WebCore::EventTargetNode::dispatchWebKitAnimationEvent): (WebCore::EventTargetNode::dispatchWebKitTransitionEvent): (WebCore::EventTargetNode::dispatchEventForType): (WebCore::EventTargetNode::dispatchProgressEvent): (WebCore::EventTargetNode::dispatchStorageEvent):
dom/EventTargetNode.h:
dom/MessagePort.cpp: (WebCore::MessagePort::dispatchMessages): (WebCore::MessagePort::dispatchCloseEvent): (WebCore::MessagePort::dispatchEvent):
dom/MessagePort.h:
editing/Editor.cpp: (WebCore::Editor::dispatchCPPEvent): (WebCore::dispatchEditableContentChangedEvents):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText):
loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::dispatchEvent): (WebCore::DOMApplicationCache::callListener):
loader/appcache/DOMApplicationCache.h:
page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::handleTextInputEvent):
page/FrameView.cpp: (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::updateOverflowStatus): (WebCore::FrameView::dispatchScheduledEvents):
page/FrameView.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::updateOverflowStatus):
svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::dispatchEvent):
svg/SVGElementInstance.h:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::dispatchReadyStateChangeEvent): (WebCore::XMLHttpRequest::dispatchXMLHttpRequestProgressEvent):
xml/XMLHttpRequest.h:
xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::dispatchEvent): (WebCore::XMLHttpRequestUpload::dispatchXMLHttpRequestProgressEvent):
xml/XMLHttpRequestUpload.h: Don't pass the tempEvent boolean around.

7:34 AM Changeset in webkit [37717] by ap@webkit.org

2 edits in trunk/WebKit/mac

Reviewed by Oliver Hunt.

<rdar://problem/6277777> REGRESSION (r36954): XMLHttpRequest not working when
certain WebView delegate actions are taken

WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]): Don't accidentally create a window shell if there is none yet.

4:32 AM Changeset in webkit [37716] by alp@webkit.org

2 edits in trunk/WebCore

2008-10-20 Alp Toker <alp@nuanti.com>

Remove unused includes only. Partial GTK+/Win build fix.

platform/graphics/gtk/SimpleFontDataPango.cpp:

2:24 AM Changeset in webkit [37715] by ap@webkit.org

4 edits
6 adds in trunk/WebCore

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=21705
Implement Web Workers client-side API

The implementation is experimental, and disabled by default. It doesn't quite match the
published draft, being influenced by further WHATWG discussions.

This only implements the client-side API, and does not actually create any threads or
global contexts yet.

DerivedSources.make: Added DedicatedWorker. SharedWorker is not implemented yet, as I'm still not sure if having separate classes for these helps at all.

WebCore.xcodeproj/project.pbxproj: Added new files.

bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseWorker): (WebCore::JSDOMWindowBase::put): (setJSDOMWindowBaseWorker): Added window.Worker constructor. Moved JSXSLTProcessorConstructor.h include out of ifdef to match prevailing style.

bindings/js/JSDedicatedWorkerConstructor.cpp: Added.
bindings/js/JSDedicatedWorkerConstructor.h: Added.
bindings/js/JSDedicatedWorkerCustom.cpp: Added. The implementation of event listeners are left custom intentionally, for easier implementation of listeners that are not tied to any Document in the future.

dom/DedicatedWorker.cpp: Added.
dom/DedicatedWorker.h: Added.
dom/DedicatedWorker.idl: Added. Added an implementation that can only load requested scripts for now.

12:29 AM Changeset in webkit [37714] by Darin Adler

4 edits in trunk/JavaScriptCore

2008-10-19 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

finish https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

VM/Machine.cpp: (JSC::Machine::cti_op_call_profiler): Use asFunction. (JSC::Machine::cti_vm_lazyLinkCall): Ditto. (JSC::Machine::cti_op_construct_JSConstructFast): Use asObject.

kjs/JSCell.h: Re-sort friend classes. Eliminate inheritance from JSValue. Changed cast in asCell from static_cast to reinterpret_cast. Removed JSValue::getNumber(double&) and one of JSValue::getObject overloads.

kjs/JSValue.h: Made the private constructor and destructor both non-virtual and also remove the definitions. This class can never be instantiated or derived.

Oct 19, 2008:

11:29 PM Changeset in webkit [37713] by Darin Adler

2 edits in trunk/WebCore

2008-10-19 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

fix assertion seen when opening inspector

bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot): Removed unneeded asObject cast.

10:58 PM Changeset in webkit [37712] by Darin Adler

12 edits in trunk/JavaScriptCore

2008-10-19 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Change JSValuePtr from a typedef into a class. This allows us to support
conversion from JSCell* to JSValuePtr even if JSCell isn't derived from
JSValue.

JavaScriptCore.exp: Updated symbols that involve JSValuePtr, since it's now a distinct type.

API/APICast.h: (toRef): Extract the JSValuePtr payload explicitly since we can't just cast any more.
VM/CTI.cpp: (JSC::CTI::asInteger): Ditto.

VM/CodeGenerator.cpp: (JSC::CodeGenerator::addConstant): Get at the payload directly. (JSC::CodeGenerator::emitLoad): Added an overload of JSCell* because otherwise classes derived from JSValue end up calling the bool overload instead of JSValuePtr.
VM/CodeGenerator.h: Ditto. Also update traits to use JSValue* and the payload functions.

VM/Register.h: Added a JSCell* overload and use of payload functions.

kjs/JSCell.h: (JSC::asCell): Use payload function. (JSC::JSValue::asCell): Use JSValue* instead of JSValuePtr. (JSC::JSValuePtr::JSValuePtr): Added. Constructor that takes JSCell* and creates a JSValuePtr.

kjs/JSImmediate.h: Added JSValuePtr class. Also updated makeValue and makeInt to work with JSValue* and the payload function.

kjs/JSValue.h: Added == and != operators for JSValuePtr. Put them here because eventually all the JSValue functions should go here except what's needed by JSImmediate. Also fix asValue to use JSValue* instead of JSValuePtr.

kjs/PropertySlot.h: Change constructor to take JSValuePtr.

kjs/protect.h: Update gcProtect functions to work with JSCell* as well as JSValuePtr. Also updated the ProtectedPtr<JSValuePtr> specialization to work more directly. Also changed all the call sites to use gcProtectNullTolerant.

8:49 PM Changeset in webkit [37711] by mitz@apple.com

10 edits
1 delete in trunk/WebCore

Rubber-stamped by Timothy Hatcher.

remove empty directories and correct the MIME type of inspector images

page/inspector: Removed.
page/inspector/Images: Removed.

8:43 PM Changeset in webkit [37710] by timothy@apple.com

2 edits in trunk/WebCore

Make the Web Inspector Resources panel open quicker and change graphs
faster. There was some accidental n^{2 logic at fault when updating the

graph boundaries.}

https://bugs.webkit.org/show_bug.cgi?id=21742

Reviewed by Darin Adler.

inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.set calculator): Return early for a null calculator. Remove the second argument passed to _refreshAllResources. (WebInspector.ResourcesPanel.prototype.refresh): Call updateBoundaries on the calculator for all the stale resources before calling refreshResource. Pass true for the first argument of refreshResource to skip the boundary update. (WebInspector.ResourcesPanel.prototype._updateGraphBoundariesIfNeeded): Remove the second argument passed to _refreshAllResources. (WebInspector.ResourcesPanel.prototype._refreshAllResourcesSoon): Remove the skipSort argument since every passed true, and it would be bad to pass false. (WebInspector.ResourcesPanel.prototype._refreshAllResources): Ditto. And if skipBoundaryUpdate is false, call updateBoundaries on the calculator for all the resources before calling refreshResource. Pass true for the first argument of refreshResource to skip the boundary update.

8:43 PM Changeset in webkit [37709] by timothy@apple.com

4 edits
7 adds in trunk/WebCore

Visually distinguish resources that loaded from the memory cache.

https://bugs.webkit.org/show_bug.cgi?id=14279

Reviewed by Dan Bernstein.

English.lproj/localizedStrings.js: New string.
inspector/front-end/Images/timelineHollowPillBlue.png: Added.
inspector/front-end/Images/timelineHollowPillGray.png: Added.
inspector/front-end/Images/timelineHollowPillGreen.png: Added.
inspector/front-end/Images/timelineHollowPillOrange.png: Added.
inspector/front-end/Images/timelineHollowPillPurple.png: Added.
inspector/front-end/Images/timelineHollowPillRed.png: Added.
inspector/front-end/Images/timelineHollowPillYellow.png: Added.
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceCalculator.prototype.computeBarGraphLabels): Add the "(from cache)" suffix to the tooltip. (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels): Add the "(from cache)" suffix to the tooltip. (WebInspector.ResourceGraph): Add the "resource-cached" class.
inspector/front-end/inspector.css: New styles to make the timeline bars use the hollow pill images.

8:43 PM Changeset in webkit [37708] by timothy@apple.com

2 edits in trunk/WebCore

Update the scroll position in the Resources panel when loading
a new page or toggling on small resource rows.

https://bugs.webkit.org/show_bug.cgi?id=20114

Reviewed by Darin Adler.

inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.reset): Scroll to the top, since all the resource are being removed. (WebInspector.ResourcesPanel.prototype.removeResource): Call _adjustScrollPosition in case the view is shorter and needs scrolled. (WebInspector.ResourcesPanel.prototype._toggleLargerResources): Ditto. (WebInspector.ResourcesPanel.prototype._adjustScrollPosition): Check the height of the sidebar against the scrollTop and height of the resourcesContainerElement. If the sidebar is shorter, scroll up so the last resource is at the bottom again.

8:43 PM Changeset in webkit [37707] by timothy@apple.com

5 edits
2 adds in trunk/WebCore

Show per resource times and sizes when hovering over the bar graph for a resource.

https://bugs.webkit.org/show_bug.cgi?id=14300
rdar://problem/5712802

Reviewed by Cameron Zwarich.

English.lproj/localizedStrings.js: Add new strings.
inspector/front-end/Images/graphLabelCalloutLeft.png: Added.
inspector/front-end/Images/graphLabelCalloutRight.png: Added.
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.refreshResource): Pass the calculator to the ResourceGraph.refresh function. (WebInspector.ResourceCalculator.prototype.computeBarGraphLabels): Default implementation returns the formatted value. (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels): Return discrete values for the latency and download times. Also generate a custom tooltip. (WebInspector.ResourceGraph): Add a mouseover event listener that calls refreshLabelPositions. (WebInspector.ResourceGraph.prototype.refreshLabelPositions): Added. Updates the label positions in case the bar has changed size. (WebInspector.ResourceGraph.prototype.refresh): Set the label text and tooltips.
inspector/front-end/inspector.css: New styles for the labels.

5:28 PM Changeset in webkit [37706] by Darin Adler

60 edits in trunk

JavaScriptCore:

2008-10-19 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Remove most uses of JSValue, which will be removed in a future patch.

VM/Machine.cpp: (JSC::fastToUInt32): Call toUInt32SlowCase function; no longer a member of JSValue.
kjs/JSNumberCell.h: (JSC::JSNumberCell::toInt32): Ditto. (JSC::JSNumberCell::toUInt32): Ditto.

kjs/JSValue.cpp: (JSC::toInt32SlowCase): Made a non-member function. (JSC::JSValue::toInt32SlowCase): Changed to call non-member function. (JSC::toUInt32SlowCase): More of the same. (JSC::JSValue::toUInt32SlowCase): Ditto.

kjs/JSValue.h: Moved static member function so they are no longer member functions at all.

VM/CTI.h: Removed forward declaration of JSValue.
VM/ExceptionHelpers.h: Ditto.
kjs/CallData.h: Ditto.
kjs/ConstructData.h: Ditto.
kjs/JSGlobalObjectFunctions.h: Ditto.
kjs/PropertyMap.h: Ditto.
kjs/StructureID.h: Ditto.
kjs/collector.h: Ditto.
kjs/completion.h: Ditto.

kjs/grammar.y: (JSC::makeBitwiseNotNode): Call new non-member toInt32 function. (JSC::makeLeftShiftNode): More of the same. (JSC::makeRightShiftNode): Ditto.

kjs/protect.h: Added a specialization for ProtectedPtr<JSValuePtr> so this can be used with JSValuePtr.

JavaScriptGlue:

2008-10-19 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Remove most uses of JSValue, which will be removed in a future patch.

JSValueWrapper.h: Use JSValuePtr instead of JSValue*.

WebCore:

2008-10-19 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Remove most uses of JSValue, which will be removed in a future patch.

bindings/js/JSCustomXPathNSResolver.h: Removed declaration of JSValue and used JSValuePtr instead.
bindings/js/JSEventTarget.h: Ditto.
bindings/js/JSNodeFilterCondition.h: Ditto.
bindings/js/ScheduledAction.h: Ditto.
bindings/js/ScriptController.h: Ditto.
bindings/objc/WebScriptObjectPrivate.h: Ditto.
bridge/c/c_utility.h: Ditto.
bridge/jni/jni_jsobject.h: Ditto.
bridge/jni/jni_utility.h: Ditto.
bridge/objc/WebScriptObject.h: Ditto.
dom/Traversal.h: Ditto.
inspector/InspectorController.cpp: Ditto.
inspector/JavaScriptProfile.h: Ditto.
inspector/JavaScriptProfileNode.h: Ditto.
loader/FrameLoader.h: Ditto.
page/Console.h: Ditto.
plugins/MimeTypeArray.h: Ditto.
plugins/Plugin.h: Ditto.
plugins/PluginArray.h: Ditto.
plugins/PluginView.cpp: (WebCore::getString): Ditto. (WebCore::PluginView::performRequest): Ditto.
plugins/gtk/PluginViewGtk.cpp: Ditto.
plugins/qt/PluginViewQt.cpp: Ditto.
plugins/win/PluginViewWin.cpp: Ditto.

bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject): Use JSValuePtr and JSObject* instead of JSValue*.
bridge/qt/qt_class.h: Ditto.
bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::mark): Ditto. (JSC::Bindings::QtInstance::invokeMethod): Ditto. (JSC::Bindings::QtInstance::defaultValue): Ditto. (JSC::Bindings::QtInstance::stringValue): Ditto. (JSC::Bindings::QtInstance::numberValue): Ditto. (JSC::Bindings::QtInstance::booleanValue): Ditto. (JSC::Bindings::QtInstance::valueOf): Ditto. (JSC::Bindings::QtField::valueFromInstance): Ditto. (JSC::Bindings::QtField::setValueToInstance): Ditto.
bridge/qt/qt_instance.h: Ditto.
bridge/qt/qt_runtime.cpp: Ditto. (JSC::Bindings::valueRealType): Ditto. (JSC::Bindings::convertValueToQVariant): Ditto. (JSC::Bindings::convertQVariantToValue): Ditto. (JSC::Bindings::findMethodIndex): Ditto. (JSC::Bindings::QtRuntimeMetaMethod::call): Ditto. (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): Ditto. (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Ditto. (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto. (JSC::Bindings::QtRuntimeConnectionMethod::call): Ditto. (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter): Ditto. (JSC::Bindings::QtArray::setValueAt): Ditto. (JSC::Bindings::QtArray::valueAt): Ditto.
bridge/qt/qt_runtime.h: Ditto.

bridge/testqtbindings.cpp: (main): Use JSValuePtr.

WebKit/mac:

2008-10-19 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Remove most uses of JSValue, which will be removed in a future patch.

WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Use JSValuePtr instead of JSValue.
WebView/WebScriptDebugger.h: Removed declaration of JSValue.

WebKit/qt:

2008-10-19 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Remove most uses of JSValue, which will be removed in a future patch.

Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript): Use JSValuePtr.

WebKit/win:

2008-10-19 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Remove most uses of JSValue, which will be removed in a future patch.

WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString): Use JSValuePtr. (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Ditto. (WebScriptCallFrame::valueForVariable): Put more code inside and ifdef. (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Ditto.
WebScriptCallFrame.h: Use JSValuePtr.

WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString): Use JSValuePtr.

WebKit/wx:

2008-10-19 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Remove most uses of JSValue, which will be removed in a future patch.

WebFrame.cpp: (wxWebFrame::RunScript): Use JSValuePtr.

9:58 AM Changeset in webkit [37705] by Darin Adler

80 edits in trunk

JavaScriptCore:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Tweak a little more to get closer to where we can make JSValuePtr a class.

API/APICast.h: (toJS): Change back to JSValue* here, since we're converting the pointer type.
VM/CTI.cpp: (JSC::CTI::unlinkCall): Call asPointer.
VM/CTI.h: Cast to JSValue* here, since it's a pointer cast.
kjs/DebuggerCallFrame.h: (JSC::DebuggerCallFrame::DebuggerCallFrame): Call noValue.
kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Call noValue.
kjs/JSImmediate.cpp: (JSC::JSImmediate::toObject): Remove unneeded const_cast.
kjs/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject): Call noValue.

JavaScriptGlue:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Tweak a little more to get closer to where we can make JSValuePtr a class.

JSObject.cpp: (nativeCallFunction): Call asObject.

JSUtils.cpp: (KJSValueToJSObject): Use JSValuePtr and asObject. (JSObjectKJSValue): Ditto. (KJSValueToCFTypeInternal): Ditto. (KJSValueToCFType): Ditto.
JSUtils.h: Ditto.

UserObjectImp.cpp: (UserObjectImp::callAsFunction): Use JSValuePtr and asObject. (UserObjectImp::userObjectGetter): Ditto. (UserObjectImp::getOwnPropertySlot): Ditto. (UserObjectImp::put): Ditto. (UserObjectImp::toPrimitive): Ditto.
UserObjectImp.h: Ditto.

WebCore:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Tweak a little more to get closer to where we can make JSValuePtr a class.

bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): Use asObject. (WebCore::constructAudio): Ditto.
bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter): Ditto.

bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toHTMLCanvasStyle): Use asString and asObject. (WebCore::JSCanvasRenderingContext2D::setFillColor): Ditto. (WebCore::JSCanvasRenderingContext2D::setStrokeColor): Ditto. (WebCore::JSCanvasRenderingContext2D::drawImage): Ditto. (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): Ditto. (WebCore::JSCanvasRenderingContext2D::setShadow): Ditto. (WebCore::JSCanvasRenderingContext2D::createPattern): Ditto.

bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent): Use JSValuePtr.

bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException): Use noValue.

bindings/js/JSDOMBinding.h: (WebCore::getDOMPrototype): Use asObject.

bindings/js/JSDOMWindowBase.cpp: (WebCore::showModalDialog): Use noValue. (jsDOMWindowBaseEvent): Use asObject. (jsDOMWindowBaseImage): Ditto. (jsDOMWindowBaseMessageChannel): Ditto. (jsDOMWindowBaseOption): Ditto. (jsDOMWindowBaseXMLHttpRequest): Ditto. (jsDOMWindowBaseAudio): Ditto. (jsDOMWindowBaseXSLTProcessor): Ditto. (WebCore::JSDOMWindowBase::childFrameGetter): Ditto. (WebCore::JSDOMWindowBase::indexGetter): Ditto. (WebCore::JSDOMWindowBase::namedItemGetter): Ditto. (WebCore::JSDOMWindowBase::getOwnPropertySlot): Ditto. (WebCore::JSDOMWindowBase::findJSEventListener): Ditto. (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): Ditto. (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener): Ditto. (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener): Ditto. (windowProtoFuncOpen): Use noValue. (WebCore::toJSDOMWindow): Use asObject.

bindings/js/JSDOMWindowCustom.cpp: (WebCore::setTimeoutOrInterval): Use asString. (WebCore::toDOMWindow): Use asObject.

bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): Use noValue. (WebCore::JSLazyEventListener::parseCode): Use asObject.

bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::JSHTMLCollection::nameGetter): Use asObject.
bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter): Ditto.
bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope): Ditto.
bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter): Ditto.
bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter): Ditto.
bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): Ditto. (WebCore::constructHTMLOptionElement): Ditto.
bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::remove): Ditto.
bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor): Ditto. (WebCore::constructImage): Ditto.
bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): Ditto.
bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::JSInspectorCallbackWrapper::wrap): Ditto.

bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate): Use noValue.

bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Use asObject. (WebCore::JSMessageChannelConstructor::construct): Ditto.
bindings/js/JSMimeTypeArrayCustom.cpp: (WebCore::JSMimeTypeArray::nameGetter): Ditto.
bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::nameGetter): Ditto.
bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::lengthGetter): Ditto. (WebCore::JSNamedNodesCollection::indexGetter): Ditto.
bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter): Ditto.
bindings/js/JSNodeListCustom.cpp: (WebCore::JSNodeList::nameGetter): Ditto.
bindings/js/JSPluginArrayCustom.cpp: (WebCore::JSPluginArray::nameGetter): Ditto.
bindings/js/JSPluginCustom.cpp: (WebCore::JSPlugin::nameGetter): Ditto.
bindings/js/JSPluginElementFunctions.cpp: (WebCore::runtimeObjectGetter): Ditto. (WebCore::runtimeObjectPropertyGetter): Ditto.
bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::asWrapper): Ditto. (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot): Ditto. (WebCore::JSQuarantinedObjectWrapper::construct): Ditto.
bindings/js/JSRGBColor.cpp: (jsRGBColorRed): Ditto. (jsRGBColorGreen): Ditto. (jsRGBColorBlue): Ditto.

bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item): Use noValue.

bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::nameGetter): Use asObject. (WebCore::JSStorage::deleteProperty): Ditto. (WebCore::JSStorage::customPut): Ditto.
bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetList::nameGetter): Ditto.
bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): Ditto.
bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::importStylesheet): Ditto. (WebCore::JSXSLTProcessor::transformToFragment): Ditto. (WebCore::JSXSLTProcessor::transformToDocument): Ditto.

bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Use noValue.
bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]): Ditto.

bindings/objc/WebScriptObject.mm: (-[WebScriptObject evaluateWebScript:]): Use JSValuePtr. (-[WebScriptObject valueForKey:]): Ditto. (-[WebScriptObject webScriptValueAtIndex:]): Ditto. (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]): Use asObject and asString.

bindings/scripts/CodeGeneratorJS.pm: Use asObject.

bridge/c/c_instance.h: Use JSValuePtr.
bridge/c/c_runtime.cpp: (JSC::Bindings::CField::setValueToInstance): Ditto.

bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant): Use asObject.

bridge/jni/jni_instance.cpp: (JavaInstance::booleanValue): Use JSValuePtr. (JavaInstance::invokeMethod): Ditto. And noValue.
bridge/jni/jni_jsobject.mm: (JavaJSObject::getSlot): Ditto. (JavaJSObject::convertValueToJObject): Ditto.
bridge/jni/jni_runtime.cpp: (JavaField::dispatchValueFromInstance): Ditto. (JavaField::valueFromInstance): Ditto. (JavaField::dispatchSetValueToInstance): Ditto. (JavaField::setValueToInstance): Ditto. (JavaArray::setValueAt): Ditto. (JavaArray::valueAt): Ditto.
bridge/jni/jni_runtime.h: Ditto.

bridge/jni/jni_utility.cpp: (JSC::Bindings::convertArrayInstanceToJavaArray): Take a JSArray* instead of a JSValue*. (JSC::Bindings::convertValueToJValue): Use asObject and asArray.

bridge/objc/objc_class.h: Use JSValuePtr.
bridge/objc/objc_instance.h: Ditto.
bridge/objc/objc_runtime.h: Ditto.

bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject): Use asObject.

bridge/objc/objc_utility.h: Use JSValuePtr.
bridge/objc/objc_utility.mm: (JSC::Bindings::convertValueToObjcValue): Use JSValuePtr and asObject. (JSC::Bindings::convertObjcValueToValue): Use jsUndefined() instead of 0.

bridge/runtime.cpp: (JSC::Bindings::Instance::getValueOfField): Use JSValuePtr. (JSC::Bindings::Instance::setValueOfField): Ditto.

bridge/runtime_array.cpp: (JSC::RuntimeArray::lengthGetter): Use JSValuePtr and asObject. (JSC::RuntimeArray::indexGetter): Ditto.
bridge/runtime_array.h: Ditto.
bridge/runtime_method.cpp: (JSC::RuntimeMethod::lengthGetter): Ditto. (JSC::callRuntimeMethod): Ditto.
bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::fallbackObjectGetter): Ditto. (JSC::RuntimeObjectImp::fieldGetter): Ditto. (JSC::RuntimeObjectImp::methodGetter): Ditto.

loader/FrameLoader.cpp: (WebCore::FrameLoader::executeScript): Use noValue.

page/Console.cpp: (WebCore::Console::trace): Use asInternalFunction.

WebKit/mac:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

next step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Tweak a little more to get closer to where we can make JSValuePtr a class.

WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame _convertValueToObjcValue:]): Use JSValuePtr. (-[WebScriptCallFrame exception]): Ditto. (-[WebScriptCallFrame evaluateWebScript:]): Ditto. And noValue.
WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger): Use new DebuggerCallFrame constructor that doesn't require explicitly passing an exception.
WebView/WebView.mm: (aeDescFromJSValue): Use JSValuePtr. (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.

9:41 AM Changeset in webkit [37704] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

lower the default button repaint frequency

rendering/RenderButton.cpp: (WebCore::RenderButton::styleDidChange): Changed the timer interval from 0.01 to 0.03.

12:56 AM Changeset in webkit [37703] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

12:55 AM Changeset in webkit [37702] by mrowe@apple.com

1 copy in tags/Safari-5525.26.1

New tag.

Oct 18, 2008:

11:46 PM Changeset in webkit [37701] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

11:32 PM Changeset in webkit [37700] by mitz@apple.com

2 edits in trunk/WebKit/win

build fix

WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString):

11:26 PM Changeset in webkit [37699] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Windows build fix

rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMediaFullscreenButton): (WebCore::RenderThemeSafari::paintMediaMuteButton): (WebCore::RenderThemeSafari::paintMediaPlayButton): (WebCore::RenderThemeSafari::paintMediaSeekBackButton): (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): (WebCore::RenderThemeSafari::paintMediaSliderThumb):

10:20 PM Changeset in webkit [37698] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-18 Darin Adler <Darin Adler>

fix non-all-in-one build

kjs/completion.h: (JSC::Completion::Completion): Add include of JSValue.h.

10:17 PM Changeset in webkit [37697] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

fix assertions I introduced with my casting changes

These were showing up as failures in the JavaScriptCore tests.

VM/Machine.cpp: (JSC::Machine::cti_op_instanceof): Remove the bogus asCell casting that was at the top of the function, and instead cast at the point of use. (JSC::Machine::cti_op_construct_NotJSConstruct): Moved the cast to object after checking the construct type.

9:31 PM Changeset in webkit [37696] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-18 Darin Adler <Darin Adler>

fix non-all-in-one build

kjs/JSGlobalObjectFunctions.h: Add include of JSImmedate.h (for now).

9:21 PM Changeset in webkit [37695] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-18 Darin Adler <Darin Adler>

fix build

kjs/interpreter.h: Include JSValue.h instead of JSImmediate.h.

9:19 PM Changeset in webkit [37694] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-18 Darin Adler <Darin Adler>

kjs/interpreter.h: Fix include of JSImmediate.h.

9:16 PM Changeset in webkit [37693] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-18 Darin Adler <Darin Adler>

fix non-all-in-one build

kjs/interpreter.h: Add include of JSImmedate.h.

9:06 PM Changeset in webkit [37692] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-18 Darin Adler <Darin Adler>

fix non-all-in-one build

kjs/ConstructData.h: Add include of JSImmedate.h (for now).

8:05 PM Changeset in webkit [37691] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-18 Darin Adler <Darin Adler>

try to fix Windows build

VM/Machine.cpp: (JSC::Machine::Machine): Use JSCell* type since MSVC seems to only allow calling ~JSCell directly if it's a JSCell*.

7:59 PM Changeset in webkit [37690] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch/WebKit/win

Merge r37661.

7:53 PM Changeset in webkit [37689] by mitz@apple.com

9 edits in trunk

WebCore:

Reviewed by Sam Weinig.

WebCore part of https://bugs.webkit.org/show_bug.cgi?id=21736 Long-dead decoded image data make up for most of the object cache's memory use over time

Add a cache setting for how long decoded image data should be allowed to
persist in memory after the image has died. By default, this is set to
0, which means "forever".

loader/Cache.cpp: (WebCore::Cache::Cache): Initialize m_deadDecodedDataDeletionInterval.
loader/Cache.h: (WebCore::Cache::setDeadDecodedDataDeletionInterval): Added a setter. (WebCore::Cache::deadDecodedDataDeletionInterval): Added a getter.
loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): Initialize the decoded data deletion timer. (WebCore::CachedImage::decodedDataDeletionTimerFired): Added. Destroys the decoded image data. (WebCore::CachedImage::addClient): Stop the timer if it is active. (WebCore::CachedImage::allClientsRemoved): Start the decoded data deletion timer.
loader/CachedImage.h:

WebKit/mac:

Reviewed by Sam Weinig.

WebKit/mac part of https://bugs.webkit.org/show_bug.cgi?id=21736 Long-dead decoded image data make up for most of the object cache's memory use over time

WebView/WebView.mm: (+[WebView _setCacheModel:]): In the primary web browser model, set the cache's dead decoded data deletion interval to 60 seconds.

WebKit/win:

2008-10-18 Dan Bernstein <mitz@apple.com>

Reviewed by Sam Weinig.

WebKit/win part of https://bugs.webkit.org/show_bug.cgi?id=21736 Long-dead decoded image data make up for most of the object cache's memory use over time

WebView.cpp: (WebView::setCacheModel): In the primary web browser model, set the cache's dead decoded data deletion interval to 60 seconds.

7:35 PM Changeset in webkit [37688] by mrowe@apple.com

3 edits in branches/Safari-3-2-branch/WebKit/mac

Merge r37606.

7:35 PM Changeset in webkit [37687] by mrowe@apple.com

3 edits in branches/Safari-3-2-branch/WebKit/mac

Merge r37598.

7:14 PM Changeset in webkit [37686] by Darin Adler

1 edit in trunk/WebCore/ChangeLog

Fix log typo.

7:12 PM Changeset in webkit [37685] by Darin Adler

2 edits in trunk/WebCore

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

fix https://bugs.webkit.org/show_bug.cgi?id=21645 REGRESSION (r37469-r37605): File Input not Uploaded in Multipart/Form-data Form

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Fix loop that goes through the FormDataList to go two at a time in a clearer way. My last patch screwed up the way it got form content from the items. This "two at a time" a confusing way to do things, which explains why I got it wrong last time through, but I decided to just fix it locally for now rather than changing the design of FormDataList.

6:52 PM Changeset in webkit [37684] by Darin Adler

261 edits in trunk

JavaScriptCore:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

next step on https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
changing JSValuePtr to be a class, and then eventually renaming it
to JSValue once that's done.

JavaScriptCore.exp: Update entry points, since some now take JSValue* instead of const JSValue*.

API/APICast.h:
API/JSCallbackConstructor.h:
API/JSCallbackFunction.cpp:
API/JSCallbackFunction.h:
API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:
API/JSContextRef.cpp:
API/JSObjectRef.cpp:
API/JSValueRef.cpp:
VM/CTI.cpp:
VM/CTI.h:
VM/CodeBlock.cpp:
VM/CodeBlock.h:
VM/CodeGenerator.cpp:
VM/CodeGenerator.h:
VM/ExceptionHelpers.cpp:
VM/ExceptionHelpers.h:
VM/JSPropertyNameIterator.cpp:
VM/JSPropertyNameIterator.h:
VM/Machine.cpp:
VM/Machine.h:
VM/Register.h:
kjs/ArgList.cpp:
kjs/ArgList.h:
kjs/Arguments.cpp:
kjs/Arguments.h:
kjs/ArrayConstructor.cpp:
kjs/ArrayPrototype.cpp:
kjs/BooleanConstructor.cpp:
kjs/BooleanConstructor.h:
kjs/BooleanObject.h:
kjs/BooleanPrototype.cpp:
kjs/CallData.cpp:
kjs/CallData.h:
kjs/ConstructData.cpp:
kjs/ConstructData.h:
kjs/DateConstructor.cpp:
kjs/DateInstance.h:
kjs/DatePrototype.cpp:
kjs/DebuggerCallFrame.cpp:
kjs/DebuggerCallFrame.h:
kjs/ErrorConstructor.cpp:
kjs/ErrorPrototype.cpp:
kjs/ExecState.cpp:
kjs/ExecState.h:
kjs/FunctionConstructor.cpp:
kjs/FunctionPrototype.cpp:
kjs/GetterSetter.cpp:
kjs/GetterSetter.h:
kjs/InternalFunction.h:
kjs/JSActivation.cpp:
kjs/JSActivation.h:
kjs/JSArray.cpp:
kjs/JSArray.h:
kjs/JSCell.cpp:
kjs/JSCell.h:
kjs/JSFunction.cpp:
kjs/JSFunction.h:
kjs/JSGlobalData.h:
kjs/JSGlobalObject.cpp:
kjs/JSGlobalObject.h:
kjs/JSGlobalObjectFunctions.cpp:
kjs/JSGlobalObjectFunctions.h:
kjs/JSImmediate.cpp:
kjs/JSImmediate.h:
kjs/JSNotAnObject.cpp:
kjs/JSNotAnObject.h:
kjs/JSNumberCell.cpp:
kjs/JSNumberCell.h:
kjs/JSObject.cpp:
kjs/JSObject.h:
kjs/JSStaticScopeObject.cpp:
kjs/JSStaticScopeObject.h:
kjs/JSString.cpp:
kjs/JSString.h:
kjs/JSValue.h:
kjs/JSVariableObject.h:
kjs/JSWrapperObject.h:
kjs/MathObject.cpp:
kjs/NativeErrorConstructor.cpp:
kjs/NumberConstructor.cpp:
kjs/NumberConstructor.h:
kjs/NumberObject.cpp:
kjs/NumberObject.h:
kjs/NumberPrototype.cpp:
kjs/ObjectConstructor.cpp:
kjs/ObjectPrototype.cpp:
kjs/ObjectPrototype.h:
kjs/PropertyMap.h:
kjs/PropertySlot.cpp:
kjs/PropertySlot.h:
kjs/RegExpConstructor.cpp:
kjs/RegExpConstructor.h:
kjs/RegExpMatchesArray.h:
kjs/RegExpObject.cpp:
kjs/RegExpObject.h:
kjs/RegExpPrototype.cpp:
kjs/Shell.cpp:
kjs/StringConstructor.cpp:
kjs/StringObject.cpp:
kjs/StringObject.h:
kjs/StringObjectThatMasqueradesAsUndefined.h:
kjs/StringPrototype.cpp:
kjs/StructureID.cpp:
kjs/StructureID.h:
kjs/collector.cpp:
kjs/collector.h:
kjs/completion.h:
kjs/grammar.y:
kjs/interpreter.cpp:
kjs/interpreter.h:
kjs/lookup.cpp:
kjs/lookup.h:
kjs/nodes.h:
kjs/operations.cpp:
kjs/operations.h:
kjs/protect.h:
profiler/ProfileGenerator.cpp: Replace JSValue* with JSValuePtr.

JavaScriptGlue:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

next step on https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
changing JSValuePtr to be a class, and then eventually renaming it
to JSValue once that's done.

JSObject.cpp:
JSValueWrapper.cpp:
UserObjectImp.cpp:
UserObjectImp.h: Replace JSValue* with JSValuePtr.

WebCore:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

next step on https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
changing JSValuePtr to be a class, and then eventually renaming it
to JSValue once that's done.

bindings/js/JSAttrCustom.cpp:
bindings/js/JSCSSRuleCustom.cpp:
bindings/js/JSCSSStyleDeclarationCustom.cpp:
bindings/js/JSCSSValueCustom.cpp:
bindings/js/JSCanvasPixelArrayCustom.h:
bindings/js/JSCanvasRenderingContext2DCustom.cpp:
bindings/js/JSClipboardCustom.cpp:
bindings/js/JSConsoleCustom.cpp:
bindings/js/JSCustomSQLStatementCallback.cpp:
bindings/js/JSCustomSQLStatementErrorCallback.cpp:
bindings/js/JSCustomSQLTransactionCallback.cpp:
bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
bindings/js/JSCustomVoidCallback.cpp:
bindings/js/JSCustomVoidCallback.h:
bindings/js/JSCustomXPathNSResolver.cpp:
bindings/js/JSDOMApplicationCacheCustom.cpp:
bindings/js/JSDOMBinding.cpp:
bindings/js/JSDOMBinding.h:
bindings/js/JSDOMWindowBase.cpp:
bindings/js/JSDOMWindowBase.h:
bindings/js/JSDOMWindowCustom.cpp:
bindings/js/JSDOMWindowCustom.h:
bindings/js/JSDOMWindowShell.cpp:
bindings/js/JSDOMWindowShell.h:
bindings/js/JSDatabaseCustom.cpp:
bindings/js/JSDocumentCustom.cpp:
bindings/js/JSElementCustom.cpp:
bindings/js/JSEventCustom.cpp:
bindings/js/JSEventListener.cpp:
bindings/js/JSEventTarget.cpp:
bindings/js/JSEventTargetBase.h:
bindings/js/JSEventTargetNodeCustom.cpp:
bindings/js/JSHTMLAllCollection.h:
bindings/js/JSHTMLAppletElementCustom.cpp:
bindings/js/JSHTMLCollectionCustom.cpp:
bindings/js/JSHTMLDocumentCustom.cpp:
bindings/js/JSHTMLEmbedElementCustom.cpp:
bindings/js/JSHTMLFormElementCustom.cpp:
bindings/js/JSHTMLFrameElementCustom.cpp:
bindings/js/JSHTMLFrameSetElementCustom.cpp:
bindings/js/JSHTMLIFrameElementCustom.cpp:
bindings/js/JSHTMLInputElementCustom.cpp:
bindings/js/JSHTMLObjectElementCustom.cpp:
bindings/js/JSHTMLOptionsCollectionCustom.cpp:
bindings/js/JSHTMLSelectElementCustom.cpp:
bindings/js/JSHTMLSelectElementCustom.h:
bindings/js/JSHistoryCustom.cpp:
bindings/js/JSImageDataCustom.cpp:
bindings/js/JSInspectedObjectWrapper.cpp:
bindings/js/JSInspectedObjectWrapper.h:
bindings/js/JSInspectorCallbackWrapper.cpp:
bindings/js/JSInspectorCallbackWrapper.h:
bindings/js/JSJavaScriptCallFrameCustom.cpp:
bindings/js/JSLocationCustom.cpp:
bindings/js/JSMessagePortCustom.cpp:
bindings/js/JSMimeTypeArrayCustom.cpp:
bindings/js/JSNamedNodeMapCustom.cpp:
bindings/js/JSNamedNodesCollection.cpp:
bindings/js/JSNamedNodesCollection.h:
bindings/js/JSNavigatorCustom.cpp:
bindings/js/JSNodeCustom.cpp:
bindings/js/JSNodeFilterCondition.cpp:
bindings/js/JSNodeFilterCustom.cpp:
bindings/js/JSNodeIteratorCustom.cpp:
bindings/js/JSNodeListCustom.cpp:
bindings/js/JSPluginArrayCustom.cpp:
bindings/js/JSPluginCustom.cpp:
bindings/js/JSPluginElementFunctions.cpp:
bindings/js/JSPluginElementFunctions.h:
bindings/js/JSQuarantinedObjectWrapper.cpp:
bindings/js/JSQuarantinedObjectWrapper.h:
bindings/js/JSRGBColor.cpp:
bindings/js/JSRGBColor.h:
bindings/js/JSSQLResultSetRowListCustom.cpp:
bindings/js/JSSQLTransactionCustom.cpp:
bindings/js/JSSVGElementInstanceCustom.cpp:
bindings/js/JSSVGLengthCustom.cpp:
bindings/js/JSSVGMatrixCustom.cpp:
bindings/js/JSSVGPathSegCustom.cpp:
bindings/js/JSSVGPathSegListCustom.cpp:
bindings/js/JSSVGPointListCustom.cpp:
bindings/js/JSSVGTransformListCustom.cpp:
bindings/js/JSStorageCustom.cpp:
bindings/js/JSStyleSheetCustom.cpp:
bindings/js/JSStyleSheetListCustom.cpp:
bindings/js/JSTextCustom.cpp:
bindings/js/JSTreeWalkerCustom.cpp:
bindings/js/JSXMLHttpRequestCustom.cpp:
bindings/js/JSXMLHttpRequestUploadCustom.cpp:
bindings/js/JSXSLTProcessorCustom.cpp:
bindings/js/ScheduledAction.cpp:
bindings/js/ScheduledAction.h:
bindings/js/ScriptController.cpp:
bindings/js/ScriptController.h:
bindings/objc/WebScriptObject.mm:
bindings/scripts/CodeGeneratorJS.pm:
bridge/NP_jsobject.cpp:
bridge/c/c_instance.cpp:
bridge/c/c_instance.h:
bridge/c/c_runtime.cpp:
bridge/c/c_runtime.h:
bridge/c/c_utility.cpp:
bridge/jni/jni_instance.cpp:
bridge/jni/jni_instance.h:
bridge/jni/jni_jsobject.mm:
bridge/jni/jni_objc.mm:
bridge/jni/jni_runtime.cpp:
bridge/jni/jni_runtime.h:
bridge/jni/jni_utility.cpp:
bridge/objc/objc_class.mm:
bridge/objc/objc_instance.h:
bridge/objc/objc_instance.mm:
bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:
bridge/objc/objc_utility.h:
bridge/objc/objc_utility.mm:
bridge/runtime.h:
bridge/runtime_array.cpp:
bridge/runtime_array.h:
bridge/runtime_method.cpp:
bridge/runtime_method.h:
bridge/runtime_object.cpp:
bridge/runtime_object.h:
inspector/JavaScriptCallFrame.cpp:
inspector/JavaScriptCallFrame.h:
inspector/JavaScriptProfile.cpp:
inspector/JavaScriptProfileNode.cpp:
loader/FrameLoader.cpp:
loader/FrameLoader.h:
page/Console.cpp:
page/Console.h:
plugins/MimeTypeArray.h:
plugins/Plugin.h:
plugins/PluginArray.h:
xml/XMLHttpRequest.cpp: Replace JSValue* with JSValuePtr.

4:46 PM Changeset in webkit [37683] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebKit/win

Export logging symbols in debug.

4:19 PM Changeset in webkit [37682] by Darin Adler

2 edits in trunk/JavaScriptCore

2008-10-18 Darin Adler <Darin Adler>

VM/Machine.cpp: (JSC::Machine::cti_op_call_eval): Removed stray parentheses from my last check-in.

4:08 PM Changeset in webkit [37681] by Darin Adler

70 edits in trunk

JavaScriptCore:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

first step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Remove casts from JSValue* to derived classes, replacing them with
calls to inline casting functions. These functions are also a bit
better than aidrect cast because they also do a runtime assertion.

Removed use of 0 as for JSValue*, changing call sites to use a
noValue() function instead.

Move things needed by classes derived from JSValue out of the class,
since the classes won't be deriving from JSValue any more soon.

I did most of these changes by changing JSValue to not be JSValue* any
more, then fixing a lot of the compilation problems, then rolling out
the JSValue change.

1.011x as fast on SunSpider (presumably due to some of the Machine.cpp changes)

API/APICast.h: Removed unneeded forward declarations.

API/JSCallbackObject.h: Added an asCallbackObject function for casting.
API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject::asCallbackObject): Added. (JSC::JSCallbackObject::getOwnPropertySlot): Use asObject. (JSC::JSCallbackObject::call): Use noValue. (JSC::JSCallbackObject::staticValueGetter): Use asCallbackObject. (JSC::JSCallbackObject::staticFunctionGetter): Ditto. (JSC::JSCallbackObject::callbackGetter): Ditto.

JavaScriptCore.exp: Updated.

JavaScriptCore.xcodeproj/project.pbxproj: Added RegExpMatchesArray.h.

VM/CTI.cpp: (JSC::CTI::asInteger): Added. For use casting a JSValue to an integer. (JSC::CTI::emitGetArg): Use asInteger. (JSC::CTI::emitGetPutArg): Ditto. (JSC::CTI::getConstantImmediateNumericArg): Ditto. Also use noValue. (JSC::CTI::emitInitRegister): Use asInteger. (JSC::CTI::getDeTaggedConstantImmediate): Ditto. (JSC::CTI::compileOpCallInitializeCallFrame): Ditto. (JSC::CTI::compileOpCall): Ditto. (JSC::CTI::compileOpStrictEq): Ditto. (JSC::CTI::privateCompileMainPass): Ditto. (JSC::CTI::privateCompileGetByIdProto): Ditto. (JSC::CTI::privateCompileGetByIdChain): Ditto. (JSC::CTI::privateCompilePutByIdTransition): Ditto.
VM/CTI.h: Rewrite the ARG-related macros to use C++ casts instead of C casts and get rid of some extra parentheses. Addd declaration of asInteger.

VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp): Use asString. (JSC::CodeGenerator::emitLoad): Use noValue. (JSC::CodeGenerator::findScopedProperty): Change globalObject argument to JSObject* instead of JSValue*. (JSC::CodeGenerator::emitResolve): Remove unneeded cast. (JSC::CodeGenerator::emitGetScopedVar): Use asCell. (JSC::CodeGenerator::emitPutScopedVar): Ditto.
VM/CodeGenerator.h: Changed out argument of findScopedProperty. Also change the JSValueMap to use PtrHash explicitly instead of getting it from DefaultHash.

VM/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::toPrimitive): Use noValue.
VM/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::next): Ditto.

VM/Machine.cpp: (JSC::fastIsNumber): Moved isImmediate check here instead of checking for 0 inside Heap::isNumber. Use asCell and asNumberCell. (JSC::fastToInt32): Ditto. (JSC::fastToUInt32): Ditto. (JSC::jsLess): Use asString. (JSC::jsLessEq): Ditto. (JSC::jsAdd): Ditto. (JSC::jsTypeStringForValue): Use asObject. (JSC::jsIsObjectType): Ditto. (JSC::jsIsFunctionType): Ditto. (JSC::inlineResolveBase): Use noValue. (JSC::Machine::callEval): Use asString. Initialize result to undefined, not 0. (JSC::Machine::Machine): Remove unneeded casts to JSCell*. (JSC::Machine::throwException): Use asObject. (JSC::Machine::debug): Remove explicit calls to the DebuggerCallFrame constructor. (JSC::Machine::checkTimeout): Use noValue. (JSC::cachePrototypeChain): Use asObject. (JSC::Machine::tryCachePutByID): Use asCell. (JSC::Machine::tryCacheGetByID): Use aCell and asObject. (JSC::Machine::privateExecute): Use noValue, asCell, asObject, asString, asArray, asActivation, asFunction. Changed code that creates call frames for host functions to pass 0 for the function pointer -- the call frame needs a JSFunction* and a host function object is not one. This was caught by the assertions in the casting functions. Also remove some unneeded casts in cases where two values are compared. (JSC::Machine::retrieveLastCaller): Use noValue. (JSC::Machine::tryCTICachePutByID): Use asCell. (JSC::Machine::tryCTICacheGetByID): Use aCell and asObject. (JSC::setUpThrowTrampolineReturnAddress): Added this function to restore the PIC-branch-avoidance that was recently lost. (JSC::Machine::cti_op_add): Use asString. (JSC::Machine::cti_op_instanceof): Use asCell and asObject. (JSC::Machine::cti_op_call_JSFunction): Use asFunction. (JSC::Machine::cti_op_call_NotJSFunction): Changed code to pass 0 for the function pointer, since we don't have a JSFunction. Use asObject. (JSC::Machine::cti_op_tear_off_activation): Use asActivation. (JSC::Machine::cti_op_construct_JSConstruct): Use asFunction and asObject. (JSC::Machine::cti_op_construct_NotJSConstruct): use asObject. (JSC::Machine::cti_op_get_by_val): Use asArray and asString. (JSC::Machine::cti_op_resolve_func): Use asPointer; this helps prepare us for a situation where JSValue is not a pointer. (JSC::Machine::cti_op_put_by_val): Use asArray. (JSC::Machine::cti_op_put_by_val_array): Ditto. (JSC::Machine::cti_op_resolve_global): Use asGlobalObject. (JSC::Machine::cti_op_post_inc): Change VM_CHECK_EXCEPTION_2 to VM_CHECK_EXCEPTION_AT_END, since there's no observable work done after that point. Also use asPointer. (JSC::Machine::cti_op_resolve_with_base): Use asPointer. (JSC::Machine::cti_op_post_dec): Change VM_CHECK_EXCEPTION_2 to VM_CHECK_EXCEPTION_AT_END, since there's no observable work done after that point. Also use asPointer. (JSC::Machine::cti_op_call_eval): Use asObject, noValue, and change VM_CHECK_EXCEPTION_ARG to VM_THROW_EXCEPTION_AT_END. (JSC::Machine::cti_op_throw): Change return value to a JSValue*. (JSC::Machine::cti_op_in): Use asObject. (JSC::Machine::cti_op_switch_char): Use asString. (JSC::Machine::cti_op_switch_string): Ditto. (JSC::Machine::cti_op_put_getter): Use asObject. (JSC::Machine::cti_op_put_setter): Ditto. (JSC::Machine::cti_vm_throw): Change return value to a JSValue*. Use noValue.
VM/Machine.h: Change return values of both cti_op_throw and cti_vm_throw to JSValue*.

VM/Register.h: Remove nullJSValue, which is the same thing as noValue(). Also removed unneeded definition of JSValue.

kjs/ArgList.h: Removed unneeded definition of JSValue.

kjs/Arguments.h: (JSC::asArguments): Added.

kjs/ArrayPrototype.cpp: (JSC::getProperty): Use noValue. (JSC::arrayProtoFuncToString): Use asArray. (JSC::arrayProtoFuncToLocaleString): Ditto. (JSC::arrayProtoFuncConcat): Ditto. (JSC::arrayProtoFuncPop): Ditto. Also removed unneeded initialization of the result, which is set in both sides of the branch. (JSC::arrayProtoFuncPush): Ditto. (JSC::arrayProtoFuncShift): Removed unneeded initialization of the result, which is set in both sides of the branch. (JSC::arrayProtoFuncSort): Use asArray.

kjs/BooleanObject.h: (JSC::asBooleanObject): Added.

kjs/BooleanPrototype.cpp: (JSC::booleanProtoFuncToString): Use asBooleanObject. (JSC::booleanProtoFuncValueOf): Ditto.

kjs/CallData.cpp: (JSC::call): Use asObject and asFunction.
kjs/ConstructData.cpp: (JSC::construct): Ditto.

kjs/DateConstructor.cpp: (JSC::constructDate): Use asDateInstance.

kjs/DateInstance.h: (JSC::asDateInstance): Added.

kjs/DatePrototype.cpp: (JSC::dateProtoFuncToString): Use asDateInstance. (JSC::dateProtoFuncToUTCString): Ditto. (JSC::dateProtoFuncToDateString): Ditto. (JSC::dateProtoFuncToTimeString): Ditto. (JSC::dateProtoFuncToLocaleString): Ditto. (JSC::dateProtoFuncToLocaleDateString): Ditto. (JSC::dateProtoFuncToLocaleTimeString): Ditto. (JSC::dateProtoFuncValueOf): Ditto. (JSC::dateProtoFuncGetTime): Ditto. (JSC::dateProtoFuncGetFullYear): Ditto. (JSC::dateProtoFuncGetUTCFullYear): Ditto. (JSC::dateProtoFuncToGMTString): Ditto. (JSC::dateProtoFuncGetMonth): Ditto. (JSC::dateProtoFuncGetUTCMonth): Ditto. (JSC::dateProtoFuncGetDate): Ditto. (JSC::dateProtoFuncGetUTCDate): Ditto. (JSC::dateProtoFuncGetDay): Ditto. (JSC::dateProtoFuncGetUTCDay): Ditto. (JSC::dateProtoFuncGetHours): Ditto. (JSC::dateProtoFuncGetUTCHours): Ditto. (JSC::dateProtoFuncGetMinutes): Ditto. (JSC::dateProtoFuncGetUTCMinutes): Ditto. (JSC::dateProtoFuncGetSeconds): Ditto. (JSC::dateProtoFuncGetUTCSeconds): Ditto. (JSC::dateProtoFuncGetMilliSeconds): Ditto. (JSC::dateProtoFuncGetUTCMilliseconds): Ditto. (JSC::dateProtoFuncGetTimezoneOffset): Ditto. (JSC::dateProtoFuncSetTime): Ditto. (JSC::setNewValueFromTimeArgs): Ditto. (JSC::setNewValueFromDateArgs): Ditto. (JSC::dateProtoFuncSetYear): Ditto. (JSC::dateProtoFuncGetYear): Ditto.

kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::thisObject): Use asObject. (JSC::DebuggerCallFrame::evaluate): Use noValue.
kjs/DebuggerCallFrame.h: Added a constructor that takes only a callFrame.

kjs/ExecState.h: (JSC::ExecState::clearException): Use noValue.

kjs/FunctionPrototype.cpp: (JSC::functionProtoFuncToString): Use asFunction. (JSC::functionProtoFuncApply): Use asArguments and asArray.

kjs/GetterSetter.cpp: (JSC::GetterSetter::getPrimitiveNumber): Use noValue.

kjs/GetterSetter.h: (JSC::asGetterSetter): Added.

kjs/InternalFunction.cpp: (JSC::InternalFunction::name): Use asString.

kjs/InternalFunction.h: (JSC::asInternalFunction): Added.

kjs/JSActivation.cpp: (JSC::JSActivation::argumentsGetter): Use asActivation.

kjs/JSActivation.h: (JSC::asActivation): Added.

kjs/JSArray.cpp: (JSC::JSArray::putSlowCase): Use noValue. (JSC::JSArray::deleteProperty): Ditto. (JSC::JSArray::increaseVectorLength): Ditto. (JSC::JSArray::setLength): Ditto. (JSC::JSArray::pop): Ditto. (JSC::JSArray::sort): Ditto. (JSC::JSArray::compactForSorting): Ditto.
kjs/JSArray.h: (JSC::asArray): Added.

kjs/JSCell.cpp: (JSC::JSCell::getJSNumber): Use noValue.

kjs/JSCell.h: (JSC::asCell): Added. (JSC::JSValue::asCell): Changed to not preserve const. Given the wide use of JSValue* and JSCell*, it's not really useful to use const. (JSC::JSValue::isNumber): Use asValue. (JSC::JSValue::isString): Ditto. (JSC::JSValue::isGetterSetter): Ditto. (JSC::JSValue::isObject): Ditto. (JSC::JSValue::getNumber): Ditto. (JSC::JSValue::getString): Ditto. (JSC::JSValue::getObject): Ditto. (JSC::JSValue::getCallData): Ditto. (JSC::JSValue::getConstructData): Ditto. (JSC::JSValue::getUInt32): Ditto. (JSC::JSValue::getTruncatedInt32): Ditto. (JSC::JSValue::getTruncatedUInt32): Ditto. (JSC::JSValue::mark): Ditto. (JSC::JSValue::marked): Ditto. (JSC::JSValue::toPrimitive): Ditto. (JSC::JSValue::getPrimitiveNumber): Ditto. (JSC::JSValue::toBoolean): Ditto. (JSC::JSValue::toNumber): Ditto. (JSC::JSValue::toString): Ditto. (JSC::JSValue::toObject): Ditto. (JSC::JSValue::toThisObject): Ditto. (JSC::JSValue::needsThisConversion): Ditto. (JSC::JSValue::toThisString): Ditto. (JSC::JSValue::getJSNumber): Ditto.

kjs/JSFunction.cpp: (JSC::JSFunction::argumentsGetter): Use asFunction. (JSC::JSFunction::callerGetter): Ditto. (JSC::JSFunction::lengthGetter): Ditto. (JSC::JSFunction::construct): Use asObject.

kjs/JSFunction.h: (JSC::asFunction): Added.

kjs/JSGlobalObject.cpp: (JSC::lastInPrototypeChain): Use asObject.

kjs/JSGlobalObject.h: (JSC::asGlobalObject): Added. (JSC::ScopeChainNode::globalObject): Use asGlobalObject.

kjs/JSImmediate.h: Added noValue, asPointer, and makeValue functions. Use rawValue, makeValue, and noValue consistently instead of doing reinterpret_cast in various functions.

kjs/JSNumberCell.h: (JSC::asNumberCell): Added. (JSC::JSValue::uncheckedGetNumber): Use asValue and asNumberCell. (JSC::JSValue::toJSNumber): Use asValue.

kjs/JSObject.cpp: (JSC::JSObject::put): Use asObject and asGetterSetter. (JSC::callDefaultValueFunction): Use noValue. (JSC::JSObject::defineGetter): Use asGetterSetter. (JSC::JSObject::defineSetter): Ditto. (JSC::JSObject::lookupGetter): Ditto. Also use asObject. (JSC::JSObject::lookupSetter): Ditto. (JSC::JSObject::hasInstance): Use asObject. (JSC::JSObject::fillGetterPropertySlot): Use asGetterSetter.

kjs/JSObject.h: (JSC::JSObject::getDirect): Use noValue. (JSC::asObject): Added. (JSC::JSValue::isObject): Use asValue. (JSC::JSObject::get): Removed unneeded const_cast. (JSC::JSObject::getPropertySlot): Use asObject. (JSC::JSValue::get): Removed unneeded const_cast. Use asValue, asCell, and asObject. (JSC::JSValue::put): Ditto. (JSC::JSObject::allocatePropertyStorageInline): Fixed spelling of "oldPropertStorage".

kjs/JSString.cpp: (JSC::JSString::getOwnPropertySlot): Use asObject.

kjs/JSString.h: (JSC::asString): Added. (JSC::JSValue::toThisJSString): Use asValue.

kjs/JSValue.h: Make PreferredPrimitiveType a top level enum instead of a member of JSValue. Added an asValue function that returns this. Removed overload of asCell for const. Use asValue instead of getting right at this.

kjs/ObjectPrototype.cpp: (JSC::objectProtoFuncIsPrototypeOf): Use asObject. (JSC::objectProtoFuncDefineGetter): Ditto. (JSC::objectProtoFuncDefineSetter): Ditto.

kjs/PropertySlot.h: (JSC::PropertySlot::PropertySlot): Take a const JSValue* so the callers don't have to worry about const. (JSC::PropertySlot::clearBase): Use noValue. (JSC::PropertySlot::clearValue): Ditto.

kjs/RegExpConstructor.cpp: (JSC::regExpConstructorDollar1): Use asRegExpConstructor. (JSC::regExpConstructorDollar2): Ditto. (JSC::regExpConstructorDollar3): Ditto. (JSC::regExpConstructorDollar4): Ditto. (JSC::regExpConstructorDollar5): Ditto. (JSC::regExpConstructorDollar6): Ditto. (JSC::regExpConstructorDollar7): Ditto. (JSC::regExpConstructorDollar8): Ditto. (JSC::regExpConstructorDollar9): Ditto. (JSC::regExpConstructorInput): Ditto. (JSC::regExpConstructorMultiline): Ditto. (JSC::regExpConstructorLastMatch): Ditto. (JSC::regExpConstructorLastParen): Ditto. (JSC::regExpConstructorLeftContext): Ditto. (JSC::regExpConstructorRightContext): Ditto. (JSC::setRegExpConstructorInput): Ditto. (JSC::setRegExpConstructorMultiline): Ditto. (JSC::constructRegExp): Use asObject.

kjs/RegExpConstructor.h: (JSC::asRegExpConstructor): Added.

kjs/RegExpObject.cpp: (JSC::regExpObjectGlobal): Use asRegExpObject. (JSC::regExpObjectIgnoreCase): Ditto. (JSC::regExpObjectMultiline): Ditto. (JSC::regExpObjectSource): Ditto. (JSC::regExpObjectLastIndex): Ditto. (JSC::setRegExpObjectLastIndex): Ditto. (JSC::callRegExpObject): Ditto.

kjs/RegExpObject.h: (JSC::asRegExpObject): Added.

kjs/RegExpPrototype.cpp: (JSC::regExpProtoFuncTest): Use asRegExpObject. (JSC::regExpProtoFuncExec): Ditto. (JSC::regExpProtoFuncCompile): Ditto. (JSC::regExpProtoFuncToString): Ditto.

kjs/StringObject.h: (JSC::StringObject::internalValue): Use asString. (JSC::asStringObject): Added.

kjs/StringPrototype.cpp: (JSC::stringProtoFuncReplace): Use asRegExpObject. (JSC::stringProtoFuncToString): Ue asStringObject. (JSC::stringProtoFuncMatch): Use asRegExpObject. (JSC::stringProtoFuncSearch): Ditto. (JSC::stringProtoFuncSplit): Ditto.

kjs/StructureID.cpp: (JSC::StructureID::getEnumerablePropertyNames): Use asObject. (JSC::StructureID::createCachedPrototypeChain): Ditto. (JSC::StructureIDChain::StructureIDChain): Use asCell and asObject.

kjs/collector.h: (JSC::Heap::isNumber): Removed null handling. This can only be called on valid cells. (JSC::Heap::cellBlock): Removed overload for const and non-const. Whether the JSCell* is const or not really should have no effect on whether you can modify the collector block it's in.

kjs/interpreter.cpp: (JSC::Interpreter::evaluate): Use noValue and noObject.

kjs/nodes.cpp: (JSC::FunctionCallResolveNode::emitCode): Use JSObject for the global object rather than JSValue. (JSC::PostfixResolveNode::emitCode): Ditto. (JSC::PrefixResolveNode::emitCode): Ditto. (JSC::ReadModifyResolveNode::emitCode): Ditto. (JSC::AssignResolveNode::emitCode): Ditto.

kjs/operations.h: (JSC::equalSlowCaseInline): Use asString, asCell, asNumberCell, (JSC::strictEqualSlowCaseInline): Ditto.

WebCore:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

first step of https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Update for change to make PreferredPrimitiveType no longer
a member of JSValue.

bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::defaultValue): Removed JSValue:: prefix.
bridge/jni/jni_instance.cpp: (JavaInstance::defaultValue): Ditto.
bridge/objc/objc_instance.mm: (ObjcInstance::defaultValue): Ditto.
bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::defaultValue): Ditto.
bridge/runtime.h: Ditto. Also removed typedef.

2:54 PM Changeset in webkit [37680] by Darin Adler

2 edits in trunk/WebCore

2008-10-18 Darin Adler <Darin Adler>

try to fix Windows build

rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintCheckbox): Explicitly qualify part name with SafariTheme namespace, since there is now an identically named constant in the ControlPart enum. (WebCore::RenderThemeSafari::paintButton): Ditto. (WebCore::RenderThemeSafari::paintTextField): Ditto. (WebCore::RenderThemeSafari::paintTextArea): Ditto. (WebCore::RenderThemeSafari::paintSearchField): Ditto. (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): Ditto. (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): Ditto. (WebCore::RenderThemeSafari::paintSearchFieldResultsButton): Ditto.

2:23 PM Changeset in webkit [37679] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2008-10-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Alp Toker.

[GTK] crash after selecting a file on an <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=21385

Follow Mac and Win's behaviors for Icon::paint

platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::paint): check if painting is enabled before painting the icon

2:44 AM Changeset in webkit [37678] by cwzwarich@webkit.org

5 edits in trunk/JavaScriptCore

2008-10-18 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 21702: Special op_create_activation for the case where there are no named parameters
<https://bugs.webkit.org/show_bug.cgi?id=21702>

This is a 2.5% speedup on the V8 Raytrace benchmark and a 1.1% speedup
on the V8 Earley-Boyer benchmark.

VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
VM/Machine.cpp: (JSC::Machine::cti_op_create_arguments_no_params):
VM/Machine.h:
kjs/Arguments.h: (JSC::Arguments::): (JSC::Arguments::Arguments):

1:44 AM Changeset in webkit [37677] by oliver@apple.com

2 edits in trunk/WebCore

2008-10-18 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Oliver Hunt.

Qt port build fix.

platform/qt/RenderThemeQt.h:

12:06 AM Changeset in webkit [37676] by jmalonzo@webkit.org

2 edits in trunk/WebKit/gtk

2008-10-17 Luke Kenneth Casson Leighton <lkcl@lkcl.net>

Reviewed by Mark Rowe. Landed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=20403
[Gtk] Segfault after a table with an iframe is attempted to be added twice to DOM model with javascript

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::frameLoaderDestroyed): (WebKit::FrameLoaderClient::detachedFromParent4):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed