Timeline
Jan 18, 2009:
- 11:15 PM Changeset in webkit [40024] by
-
- 13 edits1 delete in trunk/WebCore
2009-01-18 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23415
Remove FramePrivate
Minor PLT speedup.
- WebCore.base.exp:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/FrameLoader.cpp:
- page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::init): (WebCore::Frame::loader): (WebCore::Frame::view): (WebCore::Frame::setView): (WebCore::Frame::script): (WebCore::Frame::document): (WebCore::Frame::setDocument): (WebCore::Frame::settings): (WebCore::Frame::selection): (WebCore::Frame::editor): (WebCore::Frame::selectionGranularity): (WebCore::Frame::setSelectionGranularity): (WebCore::Frame::dragCaretController): (WebCore::Frame::animation): (WebCore::Frame::mark): (WebCore::Frame::setMark): (WebCore::Frame::setCaretVisible): (WebCore::Frame::clearCaretRectIfNeeded): (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::caretBlinkTimerFired): (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::zoomFactor): (WebCore::Frame::isZoomFactorTextOnly): (WebCore::Frame::shouldApplyTextZoom): (WebCore::Frame::shouldApplyPageZoom): (WebCore::Frame::setZoomFactor): (WebCore::Frame::setPrinting): (WebCore::Frame::setJSStatusBarText): (WebCore::Frame::setJSDefaultStatusBarText): (WebCore::Frame::jsStatusBarText): (WebCore::Frame::jsDefaultStatusBarText): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::Frame::needsReapplyStyles): (WebCore::Frame::reapplyStyles): (WebCore::Frame::isContentEditable): (WebCore::Frame::updateSecureKeyboardEntryIfActive): (WebCore::Frame::typingStyle): (WebCore::Frame::setTypingStyle): (WebCore::Frame::clearTypingStyle): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::keepAlive): (WebCore::Frame::cancelAllKeepAlive): (WebCore::Frame::clearDOMWindow): (WebCore::Frame::ownerElement): (WebCore::Frame::ownerRenderer): (WebCore::Frame::isDisconnected): (WebCore::Frame::setIsDisconnected): (WebCore::Frame::excludeFromTextSearch): (WebCore::Frame::setExcludeFromTextSearch): (WebCore::Frame::selectionBounds): (WebCore::Frame::selectionTextRects): (WebCore::Frame::isFrameSet): (WebCore::Frame::currentForm): (WebCore::Frame::forceLayout): (WebCore::Frame::sendScrollEvent): (WebCore::Frame::clearTimers): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::inViewSourceMode): (WebCore::Frame::setInViewSourceMode): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::markedTextMatchesAreHighlighted): (WebCore::Frame::setMarkedTextMatchesAreHighlighted): (WebCore::Frame::tree): (WebCore::Frame::setDOMWindow): (WebCore::Frame::domWindow): (WebCore::Frame::clearFormerDOMWindow): (WebCore::Frame::page): (WebCore::Frame::eventHandler): (WebCore::Frame::pageDestroyed): (WebCore::Frame::disconnectOwnerElement): (WebCore::Frame::documentAtPoint):
- page/Frame.h:
- page/FramePrivate.h: Removed.
- page/FrameTree.h:
- page/chromium/FrameChromium.cpp:
- page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect): (WebCore::Frame::selectionImage): (WebCore::Frame::snapshotDragImage): (WebCore::Frame::nodeImage): (WebCore::Frame::setUserStyleSheetLocation): (WebCore::Frame::setUserStyleSheet):
- page/qt/FrameQt.cpp: (WebCore::Frame::setUserStyleSheetLocation): (WebCore::Frame::setUserStyleSheet):
- page/win/FrameCGWin.cpp: (WebCore::Frame::nodeImage):
- page/win/FrameWin.cpp:
- 6:31 PM Changeset in webkit [40023] by
-
- 2 edits in trunk/WebKit/mac
Fix <https://bugs.webkit.org/show_bug.cgi?id=23414>.
Bug 23414: Reproducible crash accessing View menu with plugins disabled
Reviewed by Anders Carlsson.
- WebView/WebFrame.mm:
(-[WebFrame _canProvideDocumentSource]): Null-check the PluginData before using it.
- 9:14 AM Changeset in webkit [40022] by
-
- 2 edits in trunk/WebCore
2009-01-17 Eric Carlson <eric.carlson@apple.com>
Build fix for !ENABLE(VIDEO) following r40016.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb):
Jan 17, 2009:
- 8:30 PM Changeset in webkit [40021] by
-
- 2 edits in trunk/WebKit/win
Build fix.
- WebCoreSupport/WebDragClient.cpp: (WebDragClient::createDragImageForLink):
- 8:15 PM Changeset in webkit [40020] by
-
- 3 edits in trunk/WebCore
Build fix.
- 7:08 PM Changeset in webkit [40019] by
-
- 9 edits in trunk/WebCore
2009-01-17 David Hyatt <hyatt@apple.com>
Optimize isTextNode() the same way isElementNode() was optimized in an earlier checkin. isTextNode()
on Node is now non-virtual and just checks a bit that is set at construction time by Text.
Reviewed by Sam Weinig
- dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData):
- dom/CharacterData.h:
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::EventTargetNode):
- dom/EventTargetNode.h:
- dom/Node.cpp: (WebCore::Node::Node):
- dom/Node.h: (WebCore::Node::isTextNode): (WebCore::Node::isAttributeNode):
- dom/Text.cpp: (WebCore::Text::Text):
- dom/Text.h:
- 2:20 PM Changeset in webkit [40018] by
-
- 2 edits in trunk/LayoutTests/fast/dom
Fix failing CSS Selector layout test. Don't test first-letter in a text test, since that causes some of the selector text to be lost.
- 1:38 PM Changeset in webkit [40017] by
-
- 27 edits in trunk
WebCore:
2009-01-17 David Hyatt <hyatt@apple.com>
Change how backslashAsCurrencySymbol() works. Instead of forcing call sites to do the direct
replacement themselves, the exact transformation is instead done by the encoding (indirectly through
a method on Document).
These changes allow the fast case (where no replacement is needed) checks to be completely inlined for
a slight speedup, and also allow encodings to do future alterations to displayed string content without
having to patch call sites again.
Reviewed by Oliver Hunt
- WebCore.base.exp:
- dom/Document.cpp:
- dom/Document.h: (WebCore::Document::displayStringModifiedByEncoding): (WebCore::Document::displayBufferModifiedByEncoding):
- editing/Editor.cpp: (WebCore::Editor::addToKillRing):
- editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer): (WebCore::plainText):
- editing/TextIterator.h:
- html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::groupLabelText):
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::text):
- loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle):
- page/Chrome.cpp: (WebCore::displayString): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::setStatusbarText):
- page/Frame.cpp: (WebCore::Frame::shouldClose):
- page/Frame.h:
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::encode):
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::TextEncoding):
- platform/text/TextEncoding.h: (WebCore::TextEncoding::displayString): (WebCore::TextEncoding::displayBuffer):
- rendering/HitTestResult.cpp: (WebCore::displayString):
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::setTextInternal):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::finishText):
WebKit/mac:
2009-01-17 David Hyatt <hyatt@apple.com>
Eliminate dependencies on "backslashAsCurrencySymbol()" from WebKit, and make sure these alterations
are done in WebCore instead.
Reviewed by Oliver Hunt
- WebView/WebFrame.mm: (-[WebFrame _selectedString]): (-[WebFrame _stringForRange:]):
WebKit/win:
2009-01-17 David Hyatt <hyatt@apple.com>
Eliminate dependencies on backslashAsCurrencySymbol from WebKit.
Reviewed by Oliver Hunt
- WebFrame.cpp: (WebFrame::selectedString):
- 9:18 AM Changeset in webkit [40016] by
-
- 33 edits1 add in trunk
2009-01-17 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson
Complete <rdar://problem/6293969>
- DerivedSources.make: include mediaControlsQT.css for Mac build.
- WebCore.xcodeproj/project.pbxproj: add mediaControlsQT.css
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add MediaTimelineContainerPart, CSSValueMediaCurrentTimeDisplay, and CSSValueMediaTimeRemainingDisplay
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): include new media controller element styles
- css/CSSSelector.h: (WebCore::CSSSelector::): Ditto.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): include new media controller element styles
- css/CSSValueKeywords.in: add keywords for new media time display controls
- css/mediaControls.css: adjust css for new control elements
- css/mediaControlsQT.css: Added.
- platform/ThemeTypes.h: (WebCore::): add media time display controls to ControlPart
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm: pass controller style to WKSI functions
- rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): Added (WebCore::MediaTextDisplayElement::attachToParent): Added (WebCore::MediaTextDisplayElement::update): Added (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): Added (WebCore::MediaControlInputElement::MediaControlInputElement): Added (WebCore::MediaControlInputElement::hitTest): Added (WebCore::MediaControlTimelineElement::defaultEventHandler): Update the time display when dragging the thumb
- rendering/MediaControlElements.h: (WebCore::): Add MediaTextDisplayElement
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::createTimelineContainer): Added (WebCore::RenderMedia::createTimeline): Parent is now the timeline container (WebCore::RenderMedia::createCurrentTimeDisplay): Added (WebCore::RenderMedia::createTimeRemainingDisplay): Added (WebCore::RenderMedia::updateControls): Create new elements. Don't ever start the time update timer when the time display elements are not visible (WebCore::RenderMedia::formatTime): Handle negative times. Don't display 0 hours or minutes (WebCore::RenderMedia::updateTimeDisplay): Do nothing when the time display elements are not visible. Display time remaining as well as current time. (WebCore::RenderMedia::updateControlVisibility): Don't assume opacity should be set to 0 when visibility changes (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function as we can't assume that all controls are rectangular
- rendering/RenderMedia.h: Updated
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb): When slider is media timeline control, call element hitTest() method instead of assuming it is rectangular
- rendering/RenderSlider.h: make mouseEventIsInThumb virtual
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Deal with time display and timeline container
- rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaTimelineContainer): Updated (WebCore::RenderTheme::paintMediaCurrentTime): Added (WebCore::RenderTheme::paintMediaTimeRemaining): Added
- rendering/RenderThemeMac.h: Updated
- rendering/RenderThemeMac.mm: (WebCore::): (WebCore::mediaControllerTheme): (WebCore::RenderThemeMac::adjustSliderThumbSize): Call WebKitSystemInterface to get the thumb size when appropriate (WebCore::RenderThemeMac::paintMediaFullscreenButton): pass controller style to render function (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto (WebCore::RenderThemeMac::paintMediaTimelineContainer): Added (WebCore::RenderThemeMac::paintMediaCurrentTime): Added (WebCore::RenderThemeMac::paintMediaTimeRemaining): Added (WebCore::RenderThemeMac::extraMediaControlsStyleSheet): Added (WebCore::RenderThemeMac::hitTestMediaControlPart): Added
- rendering/style/RenderStyle.h: Updated (WebCore::):
2009-01-17 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson
Complete <rdar://problem/6293969>
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove UseSharedMediaUI
2009-01-17 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson
<rdar://problem/6293969>
Update media controls rendering results for new controls CSS.
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/media/video-display-toggle-expected.txt:
- 1:36 AM Changeset in webkit [40015] by
-
- 3 edits in trunk/WebCore
2009-01-17 David Hyatt <hyatt@apple.com>
Inline a few methods in FrameView for speed.
Reviewed by Oliver Hunt
- page/FrameView.cpp:
- page/FrameView.h: (WebCore::FrameView::layoutCount): (WebCore::FrameView::needsFullRepaint):
- 1:27 AM Changeset in webkit [40014] by
-
- 4 edits in trunk/WebCore
2009-01-17 David Hyatt <hyatt@apple.com>
Inline Document::documentElement(), since it is used by the (very hot) RenderObject::isRoot(). Split off
the code that fetches and caches the document element into a separate function and inline the part that
does the null check and the return of the already-cached element.
Reviewed by Oliver Hunt
- dom/Document.cpp: (WebCore::Document::cacheDocumentElement):
- dom/Document.h: (WebCore::Document::documentElement):
- 1:11 AM Changeset in webkit [40013] by
-
- 2 edits in trunk/WebCore
2009-01-17 David Hyatt <hyatt@apple.com>
Minor tweaks to RenderBox::styleChange to speed it up.
Reviewed by Oliver Hunt
- rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange):
- 12:41 AM Changeset in webkit [40012] by
-
- 4 edits in trunk/WebCore
2009-01-17 David Hyatt <hyatt@apple.com>
Inline FrameLoader::client().
Reviewed by Oliver Hunt
- WebCore.base.exp:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h: (WebCore::FrameLoader::client):
- 12:30 AM Changeset in webkit [40011] by
-
- 1 edit in trunk/WebCore/platform/graphics/Image.h
isNull() should be size().isEmpty(). Duh.
- 12:27 AM Changeset in webkit [40010] by
-
- 4 edits in trunk/WebCore
2009-01-17 David Hyatt <hyatt@apple.com>
Inline some Image methods for speed. Fix CachedImage's addClient method to just use isNull rather
than needlessly creating a rect.
Reviewed by Oliver Hunt
- loader/CachedImage.cpp: (WebCore::CachedImage::addClient):
- platform/graphics/Image.cpp:
- platform/graphics/Image.h: (WebCore::Image::isNull): (WebCore::Image::rect): (WebCore::Image::width): (WebCore::Image::height):
- 12:17 AM Changeset in webkit [40009] by
-
- 2 edits in trunk/WebCore
2009-01-17 David Hyatt <hyatt@apple.com>
Avoid using the non-inlined isVariable() when adding parsed values during CSS parsing.
Reviewed by Oliver Hunt
- css/CSSParserValues.cpp: (WebCore::CSSParserValueList::addValue):
- 12:04 AM Changeset in webkit [40008] by
-
- 3 edits in trunk/WebCore
2009-01-17 David Hyatt <hyatt@apple.com>
Inline Document::inPageCache(), since - because of animation code - it is now called every time
styles change on any element and so is now super-hot.
Reviewed by Oliver Hunt
- dom/Document.cpp:
- dom/Document.h: (WebCore::Document::inPageCache):
Jan 16, 2009:
- 11:17 PM Changeset in webkit [40007] by
-
- 16 edits in trunk/WebCore
2009-01-16 David Hyatt <hyatt@apple.com>
Take Font out of the GraphicsContext. Fonts are moderately expensive to both compare and to assign to.
The Font's presence in the GraphicsContext was making save/restore more expensive than it needed to be,
and was also causing expensive comparison checks to be made before doing alterations of the Font in the
GraphicsContext.
A font must now be passed as a parameter to all text drawing functions.
Reviewed by Oliver Hunt
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont): (WebCore::CanvasRenderingContext2D::drawTextInternal):
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawBidiText): (WebCore::GraphicsContext::drawHighlightForText):
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsContextPrivate.h:
- platform/graphics/qt/GraphicsContextQt.cpp:
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
- rendering/InlineTextBox.cpp: (WebCore::paintTextWithShadows): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
- rendering/InlineTextBox.h:
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintSelection):
- rendering/SVGInlineTextBox.h:
- svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):
- 10:54 PM Changeset in webkit [40006] by
-
- 2 edits in trunk/WebCore
2009-01-16 David Hyatt <hyatt@apple.com>
Fix a regression from the virtualContinuation()/continuation() split where I accidentally changed
two if statements.
Reviewed by Oliver Hunt
- rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::absoluteQuads):
- 10:36 PM Changeset in webkit [40005] by
-
- 3 edits in trunk/WebCore
2009-01-16 David Hyatt <hyatt@apple.com>
Fix a regression from my before/after optimization. Make sure the <q> element puts the document
into a mode where it will respect before/after rules, since <q> implicitly uses such rules.
Make sure view source mode documents also turn on before/after rules, since they are used there also.
Reviewed by Oliver Hunt
- html/HTMLElementFactory.cpp: (WebCore::quoteConstructor):
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
- 8:57 PM Changeset in webkit [40004] by
-
- 6 edits in trunk/JavaScriptCore
2009-01-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
On x86-64 jit, cache JSImmedate::TagMask & JSImmedate::TagTypeNumber in
registers, save reloading them every time they're used.
Draws x86-64 jit performance close to that of i386 jit.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::subPtr): (JSC::MacroAssembler::jnzPtr): (JSC::MacroAssembler::jzPtr):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOpSlowCase):
- jit/JITInlineMethods.h: (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber): (JSC::JIT::emitJumpIfImmediateInteger): (JSC::JIT::emitJumpIfNotImmediateInteger): (JSC::JIT::emitFastArithIntToImmNoCheck):
- 5:47 PM Changeset in webkit [40003] by
-
- 6 edits2 adds in trunk
Bug 23397: AXURL is not reported for <INPUT type="image"> elements
https://bugs.webkit.org/show_bug.cgi?id=23397
The AXURL of a <INPUT type="image"> element should be the URL of the image
- 5:14 PM Changeset in webkit [40002] by
-
- 2 edits in trunk/WebCore
2009-01-16 Adele Peterson <adele@apple.com>
Windows build fix.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::logCanCachePageDecision):
- 4:50 PM Changeset in webkit [40001] by
-
- 5 edits in trunk
<rdar://problem/6502511> Safari crashes if it's running while the desktop theme is changed.
This was caused by mismatched ENABLE definitions across WebCore and WebKit.
Several virtual methods were added to RenderTheme.h, conditionalized by ENABLE(VIDEO).
In addition to adding ENABLE_VIDEO to WebKit, this change also adds ENABLE_DATABASE and ENABLE_ICONDATABASE
to Windows WebCore/WebKit, and adds ENABLE_WORKERS, and several ENABLE_SVG_ flags to WebKit on Windows.
Our Windows ENABLE flags now match Mac.
Reviewed by Adele Peterson.
- 4:47 PM Changeset in webkit [40000] by
-
- 1 edit in trunk/WebCore/ChangeLog
40,000!
- 4:47 PM Changeset in webkit [39999] by
-
- 2 edits in trunk/WebKitTools
2009-01-16 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Darin Adler.
- Scripts/webkitdirs.pm: Added '--makeargs' parameter which can pass additional parameters to make command in QMake projects.
- 4:39 PM Changeset in webkit [39998] by
-
- 6 edits in trunk/JavaScriptCore
2009-01-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add support to x86-64 JIT for inline double precision arithmetic ops.
+5/6% on x86-64, JIT enabled, sunspider.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::addPtr):
- assembler/X86Assembler.h: (JSC::X86Assembler::movq_rr):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArithSlow_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArithSlow_op_mul): (JSC::JIT::compileFastArith_op_sub): (JSC::JIT::compileFastArithSlow_op_sub):
- parser/ResultType.h: (JSC::ResultType::isReusable): (JSC::ResultType::isInt32): (JSC::ResultType::definitelyIsNumber): (JSC::ResultType::mightBeNumber): (JSC::ResultType::isNotNumber): (JSC::ResultType::unknownType):
- 4:30 PM Changeset in webkit [39997] by
-
- 11 edits in trunk/WebCore
Reviewed by Justin Garcia.
Make surroundNodeRangeWithElement call insertNodeBefore implicitly
Make insertNodeBefore take PassRefPtr
Clean up the use of PassRefPtr vs. raw pointers a few places in the editing code.
https://bugs.webkit.org/show_bug.cgi?id=23389
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyTextDecorationStyle): (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/ApplyStyleCommand.h:
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt):
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::insertTab):
- editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::doApply):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::removeNodePreservingChildren): (WebCore::ReplacementFragment::insertNodeBefore): (WebCore::ReplacementFragment::removeInterchangeNodes): (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertNodeAfterAndUpdateNodesInserted): (WebCore::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted): (WebCore::ReplaceSelectionCommand::insertNodeBeforeAndUpdateNodesInserted):
- editing/ReplaceSelectionCommand.h:
- 4:15 PM Changeset in webkit [39996] by
-
- 3 edits2 adds in trunk
Bug 23393: TextField has AXTitle and AXTitleUIElement
https://bugs.webkit.org/show_bug.cgi?id=23393
A control that only has a label can have an AXTitle and an AXTitleUIElement.
It should only have the AXTitleUIElement
- 3:48 PM Changeset in webkit [39995] by
-
- 2 edits in trunk/WebCore
The correct build fix for all platforms.
- 3:39 PM Changeset in webkit [39994] by
-
- 2 edits in trunk/WebCore
Fix the Qt build.
- 3:34 PM Changeset in webkit [39993] by
-
- 8 edits in trunk/JavaScriptCore
2009-01-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Fixes for SamplingTool.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::storePtr):
- bytecode/SamplingTool.cpp: (JSC::SamplingTool::run): (JSC::SamplingTool::dump):
- bytecode/SamplingTool.h: (JSC::SamplingTool::encodeSample):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile):
- jit/JIT.h: (JSC::JIT::samplingToolTrackCodeBlock):
- jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITInlineMethods.h: (JSC::JIT::emitCTICall_internal):
- 3:28 PM Changeset in webkit [39992] by
-
- 7 edits in trunk/WebCore
2009-01-16 David Hyatt <hyatt@apple.com>
Add a new flag (similar to first-line and first-letter) to Document to track whether any before/after rules
are being used. If not, don't waste time probing for those pseudo element styles.
Reviewed by Sam Weinig
- css/CSSGrammar.y:
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h: (WebCore::Document::usesBeforeAfterRules): (WebCore::Document::setUsesBeforeAfterRules):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleDidChange):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines):
- 3:26 PM Changeset in webkit [39991] by
-
- 2 edits in trunk/WebCore
2009-01-16 Dmitry Titov <dimich@chromium.org>
Reviewed by Alp Toker.
https://bugs.webkit.org/show_bug.cgi?id=23394
Remove unnecessary calls to setDeferringTimers().
Use of this function was obsoleted by better handling of EINTR.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): removed setDeferringTimers calls.
- 3:14 PM Changeset in webkit [39990] by
-
- 3 edits in trunk/WebCore
2009-01-16 David Hyatt <hyatt@apple.com>
Fix badness with the cursor CSS property. For all links and form controls, resetting to a value of auto
was resulting in the creation of a cursor list. clearCursorList was creating a new list rather than just
nulling out the pointer. Since addCursor already lazily recreates the list, in the case of simple cursor types,
the clear method was wastefully creating a completely unnecessary list for all of these elements.
Also optimized the setting of simple cursor values to not alter the RenderStyle's cursor setting if it is already
set to the same value. Since this is the common case, it prevents a fault and copy of StyleInheritedData for
all links and form controls.
This is a PLT speedup.
Reviewed by Oliver Hunt
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::clearCursorList):
- 2:50 PM Changeset in webkit [39989] by
-
- 2 edits1 add in trunk/WebCore
2009-01-16 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23384
PLATFORM(CHROMIUM) needs to delegate BackForwardList.cpp methods to the embedder
- history/BackForwardList.h: (WebCore::BackForwardListClient::~BackForwardListClient): (WebCore::BackForwardList::setClient):
- history/BackForwardListChromium.cpp: Added.
- 2:34 PM Changeset in webkit [39988] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Decker and Adam Roben.
- fix a regression that resulted in a crash when plug-ins were disabled.
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Added a null check.
- 2:23 PM Changeset in webkit [39987] by
-
- 10 edits in trunk/WebCore
2009-01-16 David Hyatt <hyatt@apple.com>
Split continuation() into virtual and non-virtual versions so that the non-virtual version can
be used whereever possible. Eventually the virtual method can be eliminated completely.
Reviewed by Sam Weinig and Oliver Hunt
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::anchorElement):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::paint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
- rendering/RenderFlow.h: (WebCore::RenderFlow::virtualContinuation): (WebCore::RenderFlow::continuation):
- rendering/RenderInline.cpp: (WebCore::RenderInline::positionForCoordinates):
- rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::absoluteQuads): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::hoverAncestor): (WebCore::RenderObject::updateDragState): (WebCore::RenderObject::updateHitTestResult): (WebCore::RenderObject::getTextDecorationColors): (WebCore::RenderObject::adjustRectForOutlineAndShadow):
- rendering/RenderObject.h: (WebCore::RenderObject::virtualContinuation):
- 1:53 PM Changeset in webkit [39986] by
-
- 1 edit3 adds in trunk/LayoutTests
Reviewed by Alexey Proskuryakov.
Add toggle-styles test for editing.
https://bugs.webkit.org/show_bug.cgi?id=23366
This test demonstrates at least these 3 editing bugs:
https://bugs.webkit.org/show_bug.cgi?id=17733
https://bugs.webkit.org/show_bug.cgi?id=20215
https://bugs.webkit.org/show_bug.cgi?id=22810
- editing/execCommand/resources/toggle-styles.js: Added.
- editing/execCommand/toggle-styles-expected.txt: Added.
- editing/execCommand/toggle-styles.html: Added.
- 1:52 PM Changeset in webkit [39985] by
-
- 3 edits in trunk/WebCore
2009-01-16 David Hyatt <hyatt@apple.com>
Inline the methods of Font for obtaining metrics such as ascent, descent and line spacing.
Reviewed by ggaren
- platform/graphics/Font.cpp:
- platform/graphics/Font.h: (WebCore::Font::width): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::lineGap): (WebCore::Font::xHeight): (WebCore::Font::unitsPerEm): (WebCore::Font::spaceWidth):
- 1:51 PM Changeset in webkit [39984] by
-
- 6 edits in trunk
2009-01-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed <rdar://problem/6452301> REGRESSION: Latest WebKit nightlies
turn "c" into "" when stripping
c_ character
- wrec/WRECParser.cpp: (JSC::WREC::Parser::consumeEscape): Mimic a Firefox quirk when parsing control escapes inside character classes.
LayoutTests:
2009-01-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Added tests for <rdar://problem/6452301> REGRESSION: Latest WebKit
nightlies turn "c" into "" when stripping
c_ character
- fast/regex/malformed-escapes-expected.txt:
- fast/regex/resources/malformed-escapes.js:
- 1:48 PM Changeset in webkit [39983] by
-
- 3 edits in trunk/WebCore
2009-01-16 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23388
Remove FrameViewPrivate
Removes an indirection and is a small speedup on PLT.
- page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::reset): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::init): (WebCore::FrameView::clear): (WebCore::FrameView::didFirstLayout): (WebCore::FrameView::initScrollbars): (WebCore::FrameView::updateDefaultScrollbarState): (WebCore::FrameView::setCanHaveScrollbars): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layoutCount): (WebCore::FrameView::needsFullRepaint): (WebCore::FrameView::layoutRoot): (WebCore::FrameView::layout): (WebCore::FrameView::setMediaType): (WebCore::FrameView::mediaType): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject): (WebCore::FrameView::scrollRectIntoViewRecursively): (WebCore::FrameView::setScrollPosition): (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::beginDeferredRepaints): (WebCore::FrameView::endDeferredRepaints): (WebCore::FrameView::scheduleRelayout): (WebCore::FrameView::scheduleRelayoutOfSubtree): (WebCore::FrameView::layoutPending): (WebCore::FrameView::needsLayout): (WebCore::FrameView::unscheduleRelayout): (WebCore::FrameView::isTransparent): (WebCore::FrameView::setTransparent): (WebCore::FrameView::baseBackgroundColor): (WebCore::FrameView::setBaseBackgroundColor): (WebCore::FrameView::shouldUpdateWhileOffscreen): (WebCore::FrameView::setShouldUpdateWhileOffscreen): (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): (WebCore::FrameView::performPostLayoutTasks): (WebCore::FrameView::updateOverflowStatus): (WebCore::FrameView::dispatchScheduledEvents): (WebCore::FrameView::wasScrolledByUser): (WebCore::FrameView::setWasScrolledByUser): (WebCore::FrameView::paintContents): (WebCore::FrameView::setPaintRestriction): (WebCore::FrameView::isPainting): (WebCore::FrameView::setNodeToDraw):
- page/FrameView.h: (WebCore::FrameView::setIsVisuallyNonEmpty): Inline.
- 1:37 PM Changeset in webkit [39982] by
-
- 3 edits in trunk/WebCore
2009-01-14 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 23237: Some HTML constructors in HTMLElementFactory needs
an HTMLFormElement argument
- Added 'constructorNeedsFormElement' parameter to make_names.pl to account for HTML form elements.
- Added the new information to HTMLTagNames.in.
- dom/make_names.pl:
- html/HTMLTagNames.in:
- 1:25 PM Changeset in webkit [39981] by
-
- 10 edits in trunk/WebCore
2009-01-16 David Hyatt <hyatt@apple.com>
Eliminate a bunch of save/restore pairs from commonly used GraphicsContext methods. The most common reason
for needing save/restore in the line-drawing methods was antialiasing, so this has now been made part of
the cross-platform graphics state. By being able to query for the current antialiasing setting, antialiasing
can be temporarily changed and then restored back to the real value without needing to do a save/restore.
The line drawing code also set the fill color to the stroke color and relied on save/restore to prevent
a permanent mutation of the fill color in the CGContext. The new code just restores the fill color back
to its original value without doing the much more expensive save/restore.
Reviewed by Oliver Hunt
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShouldAntialias): (WebCore::GraphicsContext::shouldAntialias):
- platform/graphics/GraphicsContext.h:
- platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState):
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformShouldAntialias):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::setPlatformShouldAntialias):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformShouldAntialias):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShouldAntialias):
- platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setPlatformShouldAntialias):
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- 1:01 PM Changeset in webkit [39980] by
-
- 13 edits in trunk/WebCore
2009-01-16 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Clean up the bridge code and get rid of Field::name() and Method::name().
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod):
- bridge/c/c_runtime.cpp:
- bridge/c/c_runtime.h: (JSC::Bindings::CField::identifier): (JSC::Bindings::CMethod::identifier):
- bridge/jni/jni_class.cpp: (JavaClass::JavaClass):
- bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
- bridge/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance): (JavaMethod::methodID):
- bridge/jni/jni_runtime.h: (JSC::Bindings::JavaField::name): (JSC::Bindings::JavaMethod::name):
- bridge/objc/objc_class.mm: (JSC::Bindings::ObjcClass::methodsNamed):
- bridge/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
- bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcMethod::isFallbackMethod): (JSC::Bindings::ObjcMethod::selector):
- bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcMethod::ObjcMethod): (JSC::Bindings::ObjcMethod::getMethodSignature): (JSC::Bindings::ObjcField::ObjcField): (JSC::Bindings::ObjcField::valueFromInstance): (JSC::Bindings::ObjcField::setValueToInstance): (JSC::Bindings::callObjCFallbackObject):
- bridge/runtime.h:
- 12:54 PM Changeset in webkit [39979] by
-
- 3 edits in trunk/WebCore
2009-01-16 David Hyatt <hyatt@apple.com>
Optimize RenderText::styleDidChange. Don't call the base class, which does extra meaningless work.
Instead just do the one check we need to do (for a diff of layout) and mark dirty as appropriate.
Clean up the base class method also to just bail early if no m_parent is set instead of repeatedly checking
for the existence of m_parent in each if clause.
Reviewed by Darin Adler
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleDidChange):
- rendering/RenderText.cpp: (WebCore::RenderText::styleDidChange):
- 12:52 PM Changeset in webkit [39978] by
-
- 8 edits2 adds in trunk
Bug 23387: AX hierarchy is incorrect when iframes are present
https://bugs.webkit.org/show_bug.cgi?id=23387
AX hierarchy is incorrect when iframes are present
- 12:49 PM Changeset in webkit [39977] by
-
- 1 edit2 moves1 add in trunk/LayoutTests
2009-01-16 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=16001
Re-land layout test which didn't land as part of r39785
Move pixel results to platforms directory.
- editing/selection/extend-selection-bidi.html: Added.
- platform/mac/editing/selection/extend-selection-bidi-expected.checksum: Renamed from LayoutTests/editing/selection/extend-selection-bidi-expected.checksum.
- platform/mac/editing/selection/extend-selection-bidi-expected.png: Renamed from LayoutTests/editing/selection/extend-selection-bidi-expected.png.
- 12:44 PM Changeset in webkit [39976] by
-
- 2 edits in trunk/WebKitTools
2009-01-16 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Set the count to the right number of elements.
- DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: (testEnumerate):
- 10:54 AM Changeset in webkit [39975] by
-
- 3 edits in trunk/WebCore
2009-01-16 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/3541409> - Split up some back/forward cache decision making and add detailed logging to
better understand what the common disqualifiers are.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::canCachePage): Split off what will be per-frame decision making into canCacheSubframe. (WebCore::FrameLoader::logCanCachePageDecision): Detailed logging about why a page may not be considered for the back/forward cache. (WebCore::FrameLoader::logCanCacheFrameDecision): Same detailed logging on the per-frame basis. (WebCore::FrameLoader::commitProvisionalLoad): Move the m_client->canCachePage() call into canCachePageContainingThisFrame().
- loader/FrameLoader.h:
- 10:27 AM Changeset in webkit [39974] by
-
- 8 edits2 adds in trunk
Fixed https://bugs.webkit.org/show_bug.cgi?id=23088.
This was happening because I was calling setChanged() from inside updateRendering()
which causes an infinite loop. I fixed this by deferring the setChanged to the next
run loop iteration. That made it not infinite loop, but it still retriggers the
transition forever. The problem is that there is both an 'all' and specific transition
on 'opacity'. This tickled a bug in AnimationController which causes the opacity
transition to get constantly cancelled and then retriggered. The problem is that
the specific opacity transition has a duration of 0. I got rid of the logic to
flush out 0 duration transitions and it is no longer constantly triggered. The
logic to flush them was just an optimization, and you really need to keep them
around to make the logic to override earlier animations by later ones work. And there is
very little overhead in this case anyway, so the optimization was not that useful.
I made a LayoutTest from the original testcase which tests both the infinite
loop and constantly triggering animation cases.
- 10:06 AM Changeset in webkit [39973] by
-
- 3 edits2 adds in trunk
Bug 23385: crash at com.apple.WebCore • WebCore::HTMLAnchorElement::isKeyboardFocusable
https://bugs.webkit.org/show_bug.cgi?id=23385
Option-tabbing on page with image map links causes crash
- 9:13 AM Changeset in webkit [39972] by
-
- 2 edits in trunk/WebKit/qt
2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Simon Hausmann.
[Qt] Increase popup focus delay time to a sensible 500 ms.
- tests/qwebframe/tst_qwebframe.cpp:
- 7:44 AM Changeset in webkit [39971] by
-
- 7 edits in trunk/WebCore
2009-01-16 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fixes QString and 8-bit mix fixes.
Details: Make sure we use QLatin1String where appropriate (and don't
use QString when not necessary)
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::create):
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::platformInit):
- platform/qt/FileSystemQt.cpp: (WebCore::openTemporaryFile):
- platform/qt/LoggingQt.cpp: (WebCore::InitializeLoggingChannelsIfNecessary):
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
- plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
- 7:27 AM Changeset in webkit [39970] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- wrec/WRECParser.cpp: (JSC::WREC::Parser::parseParentheses): Removed unreachable code.
- 7:16 AM Changeset in webkit [39969] by
-
- 6 edits in trunk
2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Adam Roben.
When plugins are disabled, plugin data should not be available for
the page. This ensures that navigator.plugins would not see the
additional MIME types supported by the plugins.
- page/Page.cpp: (WebCore::Page::pluginData):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldUsePlugin):
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Adam Roben.
[Qt] Prevent crash if plugin data is NULL.
- WebCoreSupport/FrameLoaderClientQt.cpp: NULL check. (WebCore::FrameLoaderClientQt::objectContentType):
- 7:09 AM Changeset in webkit [39968] by
-
- 4 edits in trunk
Got rid of .idl file in Resources for bug https://bugs.webkit.org/show_bug.cgi?id=21421.
Also fixed the test case to work on ppc.
- 3:02 AM Changeset in webkit [39967] by
-
- 2 edits in trunk/WebKit/qt
2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Simon Hausmann.
[Qt] Per-line cursor movement tests depend on platform-specific font
metrics. Remove them to avoid test failures on different platforms.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements):
- 2:12 AM Changeset in webkit [39966] by
-
- 2 edits in trunk/WebKit/qt
2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Simon Hausmann.
http://www.qtsoftware.com/developer/task-tracker/index_html?id=219344&method=entry
[Qt] API documentation for QWebPage::WebAction enum.
- Api/qwebpage.cpp:
- 2:00 AM Changeset in webkit [39965] by
-
- 4 edits in trunk
2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Another attempt at fixing the Qt build.
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getInstance):
- Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):
- 12:35 AM Changeset in webkit [39964] by
-
- 2 edits in trunk/WebCore
2009-01-16 David Hyatt <hyatt@apple.com>
Fix for 1.85% PLT regression. Since asking if a frame is "complete" actually aggressively decodes
the frame, we add an optimization when advancing animations. If we have received all of the animated
image's data, then obviously we can go ahead and advance safely. This prevents the first draw of an image
from decoding two frames' worth of data in the case where all of the image's data has been received.
While this fixes the cached case, there could in fact be a regression on the uncached PLT from this change
as well. It's not immediately clear how that regression would be fixed, though, and it would likely be
a much smaller percentage of that overall uncached time.
Reviewed by Dan Bernstein
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::startAnimation):
- 12:01 AM Changeset in webkit [39963] by
-
- 6 edits in trunk
2009-01-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Fixed <rdar://problem/6471394> REGRESSION (r39164): Discarding quantifier
on assertion gives incorrect result (23075)
- pcre/pcre_compile.cpp: (compileBranch): Throw away an assertion if it's followed by a quantifier with a 0 minimum, to match SpiderMonkey, v8, and the ECMA spec.
- wrec/WRECParser.cpp: (JSC::WREC::Parser::parseParentheses): Fall back on PCRE for the rare case of an assertion with a quantifier with a 0 minimum, since we don't handle quantified subexpressions yet, and in this special case, we can't just throw away the quantifier.
LayoutTests:
2009-01-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Added a test for <rdar://problem/6471394> REGRESSION (r39164): Discarding
quantifier on assertion gives incorrect result (23075)
- fast/regex/quantified-assertions-expected.txt:
- fast/regex/resources/quantified-assertions.js:
Jan 15, 2009:
- 11:44 PM Changeset in webkit [39962] by
-
- 6 edits in trunk/WebCore
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=23349
Don't store obsolete caches in disk storage
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache):
- loader/ResourceLoader.h: Don't maintain m_wasLoadedFromApplicationCache, which was never used.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource): Assert that only implicit and dynamic resources can be added after the cache has been fully loaded and stored to disk database.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't remove non-newest caches from disk database, as this is now done whenever the cache becomes obsolete. (WebCore::ApplicationCacheGroup::setNewestCache): Remove an obsolete cache from disk storage.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupDestroyed): A cache group that has never been saved should not be remembered in m_cacheHostSet. Changed the check to no longer rely on savedNewestCachePointer.
- 10:52 PM Changeset in webkit [39961] by
-
- 4 edits in trunk/JavaScriptCore
2009-01-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add support in ResultType to track that the results of bitops
are always of type int32_t.
- parser/Nodes.cpp: (JSC::ReadModifyResolveNode::emitBytecode): (JSC::ReadModifyDotNode::emitBytecode): (JSC::ReadModifyBracketNode::emitBytecode):
- parser/Nodes.h: (JSC::ExpressionNode::): (JSC::BooleanNode::): (JSC::NumberNode::): (JSC::StringNode::): (JSC::PrePostResolveNode::): (JSC::TypeOfResolveNode::): (JSC::TypeOfValueNode::): (JSC::UnaryPlusNode::): (JSC::NegateNode::): (JSC::BitwiseNotNode::): (JSC::LogicalNotNode::): (JSC::MultNode::): (JSC::DivNode::): (JSC::ModNode::): (JSC::SubNode::): (JSC::LeftShiftNode::): (JSC::RightShiftNode::): (JSC::UnsignedRightShiftNode::): (JSC::LessNode::): (JSC::GreaterNode::): (JSC::LessEqNode::): (JSC::GreaterEqNode::): (JSC::InstanceOfNode::): (JSC::EqualNode::): (JSC::NotEqualNode::): (JSC::StrictEqualNode::): (JSC::NotStrictEqualNode::): (JSC::BitAndNode::): (JSC::BitOrNode::): (JSC::BitXOrNode::): (JSC::LogicalOpNode::):
- parser/ResultType.h: (JSC::ResultType::isInt32): (JSC::ResultType::isNotNumber): (JSC::ResultType::booleanType): (JSC::ResultType::numberType): (JSC::ResultType::numberTypeCanReuse): (JSC::ResultType::numberTypeCanReuseIsInt32): (JSC::ResultType::stringOrNumberTypeCanReuse): (JSC::ResultType::stringType): (JSC::ResultType::unknownType): (JSC::ResultType::forAdd): (JSC::ResultType::forBitOp): (JSC::OperandTypes::OperandTypes):
- 10:51 PM Changeset in webkit [39960] by
-
- 6 edits in trunk/JavaScriptCore
2009-01-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add support for integer addition, subtraction and multiplication
in JIT code on x86-64.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::mul32): (JSC::MacroAssembler::sub32): (JSC::MacroAssembler::joMul32): (JSC::MacroAssembler::joSub32):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArithSlow_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArithSlow_op_mul): (JSC::JIT::compileFastArith_op_sub): (JSC::JIT::compileFastArithSlow_op_sub):
- 8:53 PM Changeset in webkit [39959] by
-
- 5 edits in trunk
<rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type()
WebCore:
2009-01-15 Dimitri Dupuis-Latour <dupuislatour@apple.com>
<rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type();
Reviewed by Timothy Hatcher.
- css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText):
LayoutTests:
2009-01-15 Dimitri Dupuis-Latour <dupuislatour@apple.com>
Added testcases for all CSS3 pseudo-classes and pseudo-elements
<rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type();
Reviewed by Timothy Hatcher.
- fast/dom/css-selectorText-expected.txt:
- fast/dom/css-selectorText.html:
- 7:20 PM Changeset in webkit [39958] by
-
- 23 edits1 copy in trunk
2009-01-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
On x86-64 allow JSImmediate to encode 64-bit double precision values.
This patch only affects builds that set USE(ALTERNATE_JSIMMEDIATE).
- Updates the implementation of JSValuePtr
- and JSImmediate:: methods that operate on neumeric values to be be aware of the new representation. When this representation is in use, the class JSNumberCell is redundant and is compiled out.
The format of the new immediate representation is documented in JSImmediate.h.
- JavaScriptCore.exp:
- assembler/MacroAssembler.h: (JSC::MacroAssembler::subPtr):
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::subq_rr): (JSC::X86Assembler::movq_rr): (JSC::X86Assembler::ucomisd_rr): (JSC::X86Assembler::X86InstructionFormatter::twoByteOp64):
- interpreter/Interpreter.cpp: (JSC::Interpreter::cti_op_stricteq): (JSC::Interpreter::cti_op_nstricteq):
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArith_op_rshift): (JSC::JIT::compileFastArith_op_bitand): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp):
- jit/JITInlineMethods.h: (JSC::JIT::emitJumpIfBothJSCells): (JSC::JIT::emitJumpIfEitherNumber): (JSC::JIT::emitJumpIfNotEitherNumber): (JSC::JIT::emitJumpIfImmediateIntegerNumber): (JSC::JIT::emitJumpIfNotImmediateIntegerNumber): (JSC::JIT::emitJumpIfNotImmediateIntegerNumbers): (JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegerNumber): (JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegerNumbers): (JSC::JIT::emitFastArithDeTagImmediate): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::emitFastArithReTagImmediate): (JSC::JIT::emitFastArithIntToImmNoCheck):
- runtime/JSCell.h:
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
- runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject): (JSC::JSImmediate::toObject): (JSC::JSImmediate::toString):
- runtime/JSImmediate.h: (JSC::wtf_reinterpret_cast): (JSC::JSImmediate::isNumber): (JSC::JSImmediate::isIntegerNumber): (JSC::JSImmediate::isDoubleNumber): (JSC::JSImmediate::isPositiveIntegerNumber): (JSC::JSImmediate::areBothImmediateIntegerNumbers): (JSC::JSImmediate::makeInt): (JSC::JSImmediate::makeDouble): (JSC::JSImmediate::doubleValue): (JSC::doubleToBoolean): (JSC::JSImmediate::toBoolean): (JSC::JSImmediate::getTruncatedUInt32): (JSC::JSImmediate::makeOutOfIntegerRange): (JSC::JSImmediate::from): (JSC::JSImmediate::getTruncatedInt32): (JSC::JSImmediate::toDouble): (JSC::JSImmediate::getUInt32): (JSC::JSValuePtr::isInt32Fast): (JSC::JSValuePtr::isUInt32Fast): (JSC::JSValuePtr::areBothInt32Fast): (JSC::JSFastMath::canDoFastBitwiseOperations): (JSC::JSFastMath::xorImmediateNumbers): (JSC::JSFastMath::canDoFastRshift): (JSC::JSFastMath::canDoFastUrshift): (JSC::JSFastMath::rightShiftImmediateNumbers): (JSC::JSFastMath::canDoFastAdditiveOperations): (JSC::JSFastMath::addImmediateNumbers): (JSC::JSFastMath::subImmediateNumbers):
- runtime/JSNumberCell.cpp: (JSC::jsNumberCell):
- runtime/JSNumberCell.h: (JSC::createNumberStructure): (JSC::isNumberCell): (JSC::asNumberCell): (JSC::jsNumber): (JSC::JSValuePtr::isDoubleNumber): (JSC::JSValuePtr::getDoubleNumber): (JSC::JSValuePtr::isNumber): (JSC::JSValuePtr::uncheckedGetNumber): (JSC::jsNaN): (JSC::JSValuePtr::getNumber): (JSC::JSValuePtr::numberToInt32): (JSC::JSValuePtr::numberToUInt32):
- runtime/JSValue.h:
- runtime/NumberConstructor.cpp: (JSC::numberConstructorNegInfinity): (JSC::numberConstructorPosInfinity): (JSC::numberConstructorMaxValue): (JSC::numberConstructorMinValue):
- runtime/NumberObject.cpp: (JSC::constructNumber):
- runtime/NumberObject.h:
- runtime/Operations.h: (JSC::JSValuePtr::equal): (JSC::JSValuePtr::equalSlowCaseInline): (JSC::JSValuePtr::strictEqual): (JSC::JSValuePtr::strictEqualSlowCaseInline):
- wtf/Platform.h:
- 6:15 PM Changeset in webkit [39957] by
-
- 5 edits2 adds in trunk
WebCore:
2009-01-15 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6444148> Styling a selection that ends in a line break can sometimes style what's after the break
If the range to style ended at [node, 0] or inside node (and if for some reason the node didn't get split),
applyInlineStyle would style node.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Rename pastLast to pastEndNode, since it doesn't come from Range::pastLastNode() anymore. pastEndNode is the node after the last one that is fully selected, since the work done in the loop that follows should only be performed on fully selected nodes.
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Explicitly handle insertion into containers and after non-text nodes. Those were handled accidently before.
- editing/htmlediting.cpp: (WebCore::caretMaxOffset): In various places we call this with a container and expect to be given the number of children in that container, so I changed it to match that. RenderBR and RenderObject::caretMaxOffset() should also be eliminated since maxDeepOffset handles non-text nodes.
LayoutTests:
2009-01-15 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6444148> Styling a selection that ends in a line break can sometimes style what's after the break
- editing/execCommand/6444148-expected.txt: Added.
- editing/execCommand/6444148.html: Added.
- 4:53 PM Changeset in webkit [39956] by
-
- 4 edits in trunk/JavaScriptCore
2009-01-15 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
<rdar://problem/6045018>
REGRESSION (r34838): JavaScript objects appear to be leaked after loading google.com
Subtract the number of JSStrings cached in SmallStrings when calculating the
number of live JSObjects.
- runtime/Collector.cpp: (JSC::Heap::objectCount):
- runtime/SmallStrings.cpp: (JSC::SmallStrings::count):
- runtime/SmallStrings.h:
- 4:29 PM Changeset in webkit [39955] by
-
- 8 edits in trunk/WebCore
2009-01-15 Anders Carlsson <andersca@apple.com>
Reviewed by Geoffrey Garen.
Get rid of the dreaded BindingLanguage once and for all. Also get rid of Instance::getInstance.
- bridge/c/c_instance.h:
- bridge/jni/jni_instance.h:
- bridge/objc/objc_instance.h:
- bridge/qt/qt_instance.h:
- bridge/runtime.cpp:
- bridge/runtime.h:
- bridge/runtime_object.h:
- 4:24 PM Changeset in webkit [39954] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-15 Sam Weinig <sam@webkit.org>
Fix Qt build.
- runtime/Collector.cpp:
- 4:03 PM Changeset in webkit [39953] by
-
- 4 edits in trunk/WebCore
2009-01-15 David Hyatt <hyatt@apple.com>
Eliminate an extra virtual function call that occurs for every single RenderText by moving the SVG-specific
code that was placed into RenderText::styleDidChange into RenderSVGInlineText::styleDidChange.
Reviewed by Oliver Hunt
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::styleDidChange):
- rendering/RenderSVGInlineText.h:
- rendering/RenderText.cpp: (WebCore::RenderText::styleDidChange):
- 4:01 PM Changeset in webkit [39952] by
-
- 5 edits in trunk/WebCore
2009-01-15 Anders Carlsson <andersca@apple.com>
Another attempt at fixing the Qt build.
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getOwnPropertySlot): (JSC::Bindings::QtInstance::put):
- bridge/qt/qt_instance.h:
- bridge/runtime.h: (JSC::Bindings::Instance::getOwnPropertySlot): (JSC::Bindings::Instance::put):
- bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getOwnPropertySlot): (JSC::RuntimeObjectImp::put):
- 3:49 PM Changeset in webkit [39951] by
-
- 6 edits in trunk/JavaScriptCore
2009-01-15 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix crash seen running fast/canvas.
Make sure to mark the ScopeNode and CodeBlock being created
in the re-parse for exception information.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
- parser/Nodes.h: (JSC::ScopeNode::mark):
- runtime/Collector.cpp: (JSC::Heap::collect):
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- 3:48 PM Changeset in webkit [39950] by
-
- 4 edits in trunk/WebCore
2009-01-15 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Add QtInstance::getInstance and start using it.
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtRuntimeObjectImp::mark): (JSC::Bindings::QtRuntimeObjectImp::classInfo): (JSC::Bindings::): (JSC::Bindings::QtInstance::getInstance):
- bridge/qt/qt_instance.h:
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):
- 3:38 PM Changeset in webkit [39949] by
-
- 5 edits in trunk/WebCore
2009-01-15 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add the ability for Instance objects to override getOwnPropertySlot/put for runtime objects.
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getOwnPropertySlot): (JSC::Bindings::QtInstance::put):
- bridge/qt/qt_instance.h:
- bridge/runtime.h: (JSC::Bindings::Instance::getOwnPropertySlot): (JSC::Bindings::Instance::put):
- bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getOwnPropertySlot): (JSC::RuntimeObjectImp::put):
- 3:30 PM Changeset in webkit [39948] by
-
- 3 edits in trunk/WebCore
2009-01-15 Anders Carlsson <andersca@apple.com>
Fix the QT build.
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::createRuntimeObject):
- bridge/qt/qt_instance.h:
- 3:11 PM Changeset in webkit [39947] by
-
- 2 edits in trunk/WebCore
2009-01-15 David Hyatt <hyatt@apple.com>
Fix for <rdar://problem/6500278> REGRESSION: 3.5% of samples on iBench in WebCore::Frame::setZoomFactor
setZoomFactor was supposed to bail if both the zoom factor and mode were the same. The mode check was
buggy and doing the wrong thing.
Reviewed by Darin Adler
- page/Frame.cpp: (WebCore::Frame::setZoomFactor):
- 2:58 PM Changeset in webkit [39946] by
-
- 12 edits in trunk/WebCore
2009-01-15 Anders Carlsson <andersca@apple.com>
Reviewed by Geoffrey Garen.
Make Instance::createRuntimeObject a virtual function and override it for QtInstance.
- bindings/js/JSPluginElementFunctions.cpp: (WebCore::getRuntimeObject):
- bridge/c/c_utility.cpp: (JSC::Bindings::convertNPVariantToValue):
- bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
- bridge/jni/jni_jsobject.mm: (JavaJSObject::convertJObjectToValue):
- bridge/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaArray::valueAt):
- bridge/objc/objc_utility.mm: (JSC::Bindings::convertObjcValueToValue):
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getRuntimeObject): (JSC::Bindings::QtInstance::createRuntimeObject):
- bridge/qt/qt_instance.h:
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue): (JSC::Bindings::QtConnectionObject::execute):
- bridge/runtime.cpp: (JSC::Bindings::Instance::createRuntimeObject):
- bridge/runtime.h:
- 1:31 PM Changeset in webkit [39945] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-15 Craig Schlenter <craig.schlenter@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23347
Compilation of JavaScriptCore/wtf/ThreadingPthreads.cpp fails on Linux
- wtf/ThreadingPthreads.cpp: included limits.h as INT_MAX is defined there.
- 1:30 PM Changeset in webkit [39944] by
-
- 3 edits in trunk/WebCore
2009-01-15 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23354
Fix up graphics/chromium files to account for Uniscribe style scrubbing.
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::windowsCanHandleTextDrawing): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillNonBMPGlyphs):
- 1:24 PM Changeset in webkit [39943] by
-
- 2 edits in trunk/WebCore
2009-01-15 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23333
Adjust due to a name change that happened in a WebKit.
- svg/graphics/skia/SVGPaintServerPatternSkia.cpp: (WebCore::SVGPaintServerPattern::setup):
- 1:15 PM Changeset in webkit [39942] by
-
- 3 edits3 adds in trunk
Bug 23225: REGRESSION: Assertion failure in reparseInPlace() (m_sourceElements) at sfgate.com
<https://bugs.webkit.org/show_bug.cgi?id=23225> <rdar://problem/6487432>
Reviewed by Geoff Garen
Character position for open and closing brace was incorrectly referencing m_position to
record their position in a source document, however this is unsafe as BOMs may lead to
m_position being an arbitrary position from the real position of the current character.
- 12:52 PM Changeset in webkit [39941] by
-
- 1 edit8 adds in trunk/WebCore
2009-01-15 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23340
Add remaining bits of graphics/chromium.
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Added. (WebCore::scaleEmToUnits): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/chromium/SimpleFontDataLinux.cpp: Added. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Added. (WebCore::ThemeHelperWin::ThemeHelperWin): (WebCore::ThemeHelperWin::~ThemeHelperWin):
- platform/graphics/chromium/ThemeHelperChromiumWin.h: Added. (WebCore::ThemeHelperWin::): (WebCore::ThemeHelperWin::context): (WebCore::ThemeHelperWin::rect):
- platform/graphics/chromium/UniscribeHelper.cpp: Added. (WebCore::treatAsSpace): (WebCore::containsMissingGlyphs): (WebCore::setLogFontAndStyle): (WebCore::UniscribeHelper::UniscribeHelper): (WebCore::UniscribeHelper::~UniscribeHelper): (WebCore::UniscribeHelper::initWithOptionalLengthProtection): (WebCore::UniscribeHelper::width): (WebCore::UniscribeHelper::justify): (WebCore::UniscribeHelper::characterToX): (WebCore::UniscribeHelper::xToCharacter): (WebCore::UniscribeHelper::draw): (WebCore::UniscribeHelper::firstGlyphForCharacter): (WebCore::UniscribeHelper::fillRuns): (WebCore::UniscribeHelper::shape): (WebCore::UniscribeHelper::fillShapes): (WebCore::UniscribeHelper::fillScreenOrder): (WebCore::UniscribeHelper::adjustSpaceAdvances): (WebCore::UniscribeHelper::applySpacing): (WebCore::UniscribeHelper::advanceForItem):
- platform/graphics/chromium/UniscribeHelper.h: Added. (WebCore::UniscribeHelper::directionalOverride): (WebCore::UniscribeHelper::setDirectionalOverride): (WebCore::UniscribeHelper::inhibitLigate): (WebCore::UniscribeHelper::setInhibitLigate): (WebCore::UniscribeHelper::letterSpacing): (WebCore::UniscribeHelper::setLetterSpacing): (WebCore::UniscribeHelper::spaceWidth): (WebCore::UniscribeHelper::setSpaceWidth): (WebCore::UniscribeHelper::wordSpacing): (WebCore::UniscribeHelper::setWordSpacing): (WebCore::UniscribeHelper::setAscent): (WebCore::UniscribeHelper::init): (WebCore::UniscribeHelper::tryToPreloadFont): (WebCore::UniscribeHelper::Shaping::Shaping): (WebCore::UniscribeHelper::Shaping::glyphLength): (WebCore::UniscribeHelper::Shaping::charLength): (WebCore::UniscribeHelper::Shaping::effectiveAdvances): (WebCore::UniscribeHelper::nextWinFontData): (WebCore::UniscribeHelper::resetFontIndex):
- platform/graphics/chromium/UniscribeHelperTextRun.cpp: Added. (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): (WebCore::UniscribeHelperTextRun::tryToPreloadFont): (WebCore::UniscribeHelperTextRun::nextWinFontData): (WebCore::UniscribeHelperTextRun::resetFontIndex):
- platform/graphics/chromium/UniscribeHelperTextRun.h: Added.
- 11:54 AM Changeset in webkit [39940] by
-
- 2 edits in trunk/WebKit/win
2009-01-15 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21799
<rdar://problem/6310684> Crash in dumpFramesAsText() when running http/tests/security/cross-origin-xsl-BLOCKED.html
Return S_OK or E_FAIL based on the result from CreateInstance.
This was causing DumpRenderTree to not realize it had just gotten a null documentElement.
- DOMCoreClasses.cpp: Made all functions that return the result of CreateInstance consistent. (DOMNode::parentNode): (DOMNode::ownerDocument): (DOMNodeList::item): (DOMDocument::documentElement): (DOMDocument::createElement): (DOMDocument::getElementsByTagName): (DOMDocument::getElementsByTagNameNS): (DOMDocument::getElementById): (DOMDocument::getComputedStyle): (DOMDocument::createEvent): (DOMElement::style):
- 11:44 AM Changeset in webkit [39939] by
-
- 2 edits in trunk/WebCore
Fixed Windows project file after https://bugs.webkit.org/show_bug.cgi?id=21421
- 11:26 AM Changeset in webkit [39938] by
-
- 3 edits in tags/Safari-6528.10/WebKit/mac
Merge r39913.
- 11:25 AM Changeset in webkit [39937] by
-
- 2 edits in trunk/WebKit/mac
2009-01-15 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein
Fix problem where a URL visited as non-GET once is flagged as non-GET forever.
- History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): Always update the HTTPNonGet flag for all loads with an HTTP Method
- 11:25 AM Changeset in webkit [39936] by
-
- 2 edits in trunk/WebCore
2009-01-15 Aaron Boodman <aa@chromium.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=15279
Right clicking over text (or multiple spaces) auto selects the word
(or multiple spaces) under it, which is not a desirable effect for some
platforms.
- page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Don't select words on right-click on Chromium.
- 11:08 AM Changeset in webkit [39935] by
-
- 4 edits in trunk
Versioning.
- 10:52 AM Changeset in webkit [39934] by
-
- 1 copy in tags/Safari-6528.10
New tag.
- 1:27 AM Changeset in webkit [39933] by
-
- 2 edits in trunk/WebCore
2009-01-15 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23345
SharedBuffer.h should include wtf/OwnPtr.h
- platform/SharedBuffer.h:
Jan 14, 2009:
- 9:46 PM Changeset in webkit [39932] by
-
- 2 edits in trunk/WebCore
Bug 23338: Make "Streamline Inspector Source" build script check for a directory before using it
Reviewed by Timothy Hatcher.
- WebCore.xcodeproj/project.pbxproj: Check to see if "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector" exists before trying to change directories into it and then deleting, modifying and adding files to it.
- 9:40 PM Changeset in webkit [39931] by
-
- 4 edits in trunk/JavaScriptCore
Bug 23153: JSC build always touches JavaScriptCore/docs/bytecode.html
Reviewed by Darin Adler.
Instead of building bytecode.html into ${SRCROOT}/docs/bytecode.html, build it
into ${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/docs/bytecode.html.
Also fixes make-bytecode-docs.pl to actually generate documentation.
- DerivedSources.make: Changed bytecode.html to be built into local docs directory in ${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore.
- JavaScriptCore.xcodeproj/project.pbxproj: Added "/docs" to the end of the "mkdir -p" command so that the docs subdirectory is automatically created.
- docs/make-bytecode-docs.pl: Changed BEGIN_OPCODE to DEFINE_OPCODE so that documentation is actually generated.
- 9:24 PM Changeset in webkit [39930] by
-
- 10 edits in trunk
Reviewed by Kevin Ollivier.
Fixing wx compilation for wx 2.9/trunk.
- 9:05 PM Changeset in webkit [39929] by
-
- 2 edits in trunk/WebCore
wx build fix. Adding WebKitCSSMatrix.
- 7:27 PM Changeset in webkit [39928] by
-
- 2 edits in trunk/WebCore
Prospective build fix for Qt following r39922.
- 6:52 PM Changeset in webkit [39927] by
-
- 3 edits in trunk/LayoutTests
Updated layout test results after adding WebKitCSSMatrix (r39922)
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- 6:30 PM Changeset in webkit [39926] by
-
- 2 edits in trunk/WebCore
2009-01-14 Darin Adler <Darin Adler>
Fix debug build.
- bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor): Use ASSERT_UNUSED.
- 6:16 PM Changeset in webkit [39925] by
-
- 1 edit36 adds in trunk/LayoutTests
2009-01-14 Pierre-Olivier Latour <pol@apple.com>
Added missing reference images for pixel tests (generated on iMac Intel with 10.5.5 + QT 7.5.5).
- platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.checksum: Added.
- platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
- platform/mac/fast/events/pointer-events-2-expected.checksum: Added.
- platform/mac/fast/events/pointer-events-2-expected.png: Added.
- platform/mac/fast/events/pointer-events-expected.checksum: Added.
- platform/mac/fast/events/pointer-events-expected.png: Added.
- platform/mac/fast/media/mq-animation-expected.checksum: Added.
- platform/mac/fast/media/mq-animation-expected.png: Added.
- platform/mac/fast/media/mq-transform-01-expected.checksum: Added.
- platform/mac/fast/media/mq-transform-01-expected.png: Added.
- platform/mac/fast/media/mq-transform-02-expected.checksum: Added.
- platform/mac/fast/media/mq-transform-02-expected.png: Added.
- platform/mac/fast/media/mq-transform-03-expected.checksum: Added.
- platform/mac/fast/media/mq-transform-03-expected.png: Added.
- platform/mac/fast/media/mq-transform-04-expected.checksum: Added.
- platform/mac/fast/media/mq-transform-04-expected.png: Added.
- platform/mac/fast/media/mq-transition-expected.checksum: Added.
- platform/mac/fast/media/mq-transition-expected.png: Added.
- platform/mac/http/tests/security: Added.
- platform/mac/http/tests/security/dataTransfer-set-data-file-url-expected.checksum: Added.
- platform/mac/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
- platform/mac/http/tests/webarchive: Added.
- platform/mac/http/tests/webarchive/test-css-url-encoding-expected.checksum: Added.
- platform/mac/http/tests/webarchive/test-css-url-encoding-expected.png: Added.
- platform/mac/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.checksum: Added.
- platform/mac/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.png: Added.
- platform/mac/http/tests/webarchive/test-css-url-encoding-utf-8-expected.checksum: Added.
- platform/mac/http/tests/webarchive/test-css-url-encoding-utf-8-expected.png: Added.
- platform/mac/http/tests/webarchive/test-preload-resources-expected.checksum: Added.
- platform/mac/http/tests/webarchive/test-preload-resources-expected.png: Added.
- platform/mac/media/video-zoom-expected.checksum: Added.
- platform/mac/media/video-zoom-expected.png: Added.
- platform/mac/webarchive/test-css-url-resources-in-stylesheets-expected.checksum: Added.
- platform/mac/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
- platform/mac/webarchive/test-css-url-resources-inline-styles-expected.checksum: Added.
- platform/mac/webarchive/test-css-url-resources-inline-styles-expected.png: Added.
- 6:05 PM Changeset in webkit [39924] by
-
- 9 edits4 adds in trunk
WebCore:
2009-01-14 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
<rdar://problem/6247650> Update <input type="search"> for RenderThemeWin
No new tests added. In the future, we need to update DumpRenderTree to be able to run with different RenderThemes and
we'll need a separate set of results for different themes.
- css/themeWin.css: Renable search fields. Added new rules for sub-element placement.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::textBlockWidth): Consider margin set on the sub-elements when computing the desired width for the text block.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::supportsFocus): Treat SearchFieldPart the same as TextFieldPart. (WebCore::RenderThemeWin::determineState): ditto. (WebCore::RenderThemeWin::getClassicThemeData): ditto. (WebCore::RenderThemeWin::getThemeData): ditto. (WebCore::RenderThemeWin::paintSearchFieldCancelButton): Draw a scaled, vertically centered, version of the new artwork. (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): ditto. (WebCore::RenderThemeWin::paintSearchFieldResultsButton): ditto. (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle): Set the scaled width and height. (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle): ditto. (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle): ditto.
WebKit/win:
2009-01-14 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
<rdar://problem/6247650> Update <input type="search"> for RenderThemeWin
Added artwork.
- WebKit.vcproj/WebKit.rc:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/resource.h:
- WebKit.vcproj/searchCancel.png: Added.
- WebKit.vcproj/searchCancelPressed.png: Added.
- WebKit.vcproj/searchMagnifier.png: Added.
- WebKit.vcproj/searchMagnifierResults.png: Added.
- WebKitDLL.cpp:(loadResourceIntoBuffer):
- 5:53 PM Changeset in webkit [39923] by
-
- 2 edits in trunk/WebCore
2009-01-14 Alp Toker <alp@nuanti.com>
GTK+ build fix following r39922.
Add WebKitCSSMatrix to the build system.
- GNUmakefile.am:
- 5:29 PM Changeset in webkit [39922] by
-
- 8 edits7 adds in trunk
Implemented 2D WebKitCSSMatrix
https://bugs.webkit.org/show_bug.cgi?id=21421
- 4:55 PM Changeset in webkit [39921] by
-
- 2 edits in trunk/WebCore
2009-01-14 Michael Moss <mmoss@chromium.org>
Reviewed by Eric Seidel.
Workaround a skia limitation on repeated patterns, and remove extra
transformations applied to pattern.
https://bugs.webkit.org/show_bug.cgi?id=23332
Fixes:
LayoutTests/fast/canvas/patternfill-repeat.html
LayoutTests/svg/W3C-SVG-1.1/pservers-grad-06-b.svg
- platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::createPlatformPattern):
- 4:31 PM Changeset in webkit [39920] by
-
- 5 edits in trunk/WebKit/mac
2009-01-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement InvokeDefault, Construct, GetProperty and SetProperty.
Fully implement marshalValue.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvokeDefault): (WKPCConstruct): (WKPCGetProperty): (WKPCSetProperty):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::getProperty): (WebKit::NetscapePluginInstanceProxy::setProperty): (WebKit::NetscapePluginInstanceProxy::marshalValue): (WebKit::NetscapePluginInstanceProxy::demarshalValue):
- Plugins/Hosted/WebKitPluginClient.defs:
- 4:26 PM Changeset in webkit [39919] by
-
- 2 edits in trunk/WebCore
Fix https://bugs.webkit.org/show_bug.cgi?id=23334
Bug 23334: Compile failure in XMLTokenizerLibxml2.cpp
Include wtf/UnusedParam.h to get UNUSED_PARAM.
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::hackAroundLibXMLEntityBug):
- 3:50 PM Changeset in webkit [39918] by
-
- 4 edits1 delete in trunk/WebCore
2009-01-14 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23333
Platform code fixes. These compensate for changes in platform
callbacks from WebKit and minor API tweaks.
I enumerated a few below.
- platform/graphics/chromium/FontCacheChromiumWin.cpp: fontExists has been gone since r34794.
- platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
(WebCore::FrameData::clear):
r39751 changes this api to take and return a bool.
(WebCore::Image::drawPattern):
- platform/graphics/skia/PathSkia.cpp: (WebCore::Path::apply): (WebCore::boundingBoxForCurrentStroke): (WebCore::Path::strokeContains):
- svg/graphics/skia/RenderPathSkia.cpp: Removed due to r39805.
- 3:40 PM Changeset in webkit [39917] by
-
- 2 edits in trunk/JavaScriptCore
Build fix for Qt from Dmitry Titov.
- 3:37 PM Changeset in webkit [39916] by
-
- 4 edits in trunk/WebKit/mac
2009-01-14 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Demarshal arguments and pass them to the JS call.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvoke):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): (WebKit::NetscapePluginInstanceProxy::demarshalValues):
- 3:22 PM Changeset in webkit [39915] by
-
- 1 edit1 copy1 move3 adds in trunk/LayoutTests
2009-01-14 Darin Adler <Darin Adler>
Reviewed by Beth Dakin.
Try to fix regression test failures seen on Leopard; possibly new to 10.5.6.
- http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Removed. This test has enough Mac specifics in it that I don't think it makes sense to have cross-platform results.
- platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Copied from http/tests/misc/willCacheResponse-delegate-callback-expected.txt.
- platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Copied from http/tests/misc/willCacheResponse-delegate-callback-expected.txt. Updated with non-Tiger results. The order of delegate calls has changed.
- 3:19 PM Changeset in webkit [39914] by
-
- 2 edits in trunk/WebKitTools
BUILD FIX: Use COM API on Windows in LayoutTestController::setIconDatabaseEnabled()
Rubber-stamped by Alice Liu.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setIconDatabaseEnabled): Use COM API to get the shared WebIconDatabase.
- 2:26 PM Changeset in webkit [39913] by
-
- 3 edits in trunk/WebKit/mac
<rdar://problem/6496520> REGRESSION: In Mail, a crash occurs when attempting to display a mail message
Move WebArchive and WebResource to use the same approach for initializing themselves on the main thread
that WebView uses.
Reviewed by Timothy Hatcher.
- WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]): Use _webkit_performSelectorOnMainThread:withObject:.
(-[WebArchive _initWithArguments:]):
- WebView/WebResource.mm:
(-[WebResource _initWithArguments:]): Unbox the BOOL argument.
- 2:22 PM Changeset in webkit [39912] by
-
- 8 edits2 adds in trunk
2009-01-14 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Eric Seidel.
<https://bugs.webkit.org/show_bug.cgi?id=16829>
Implement NPN_SetException()
This mirrors the implementation in the obj-c bindings.
Test: plugins/netscape-throw-exception.html
- bridge/NP_jsobject.cpp: (_NPN_SetException):
- bridge/c/c_instance.cpp: (JSC::Bindings::getExceptionString): (JSC::Bindings::CInstance::setGlobalException): (JSC::Bindings::CInstance::moveGlobalExceptionToExecState): (JSC::Bindings::CInstance::invokeMethod): (JSC::Bindings::CInstance::invokeDefaultMethod): (JSC::Bindings::CInstance::invokeConstruct): (JSC::Bindings::CInstance::getPropertyNames):
- bridge/c/c_instance.h:
- 2:18 PM Changeset in webkit [39911] by
-
- 1 edit1 move in trunk/LayoutTests
Disabling webarchive/test-link-rel-icon.html due to various buildbot failures
Bug 23331: LayoutTests/webarchive/test-link-rel-icon.html fails in different ways on buildbots
<https://bugs.webkit.org/show_bug.cgi?id=23331>
- webarchive/test-link-rel-icon.html: Removed.
- webarchive/test-link-rel-icon.html-disabled: Renamed from LayoutTests/webarchive/test-link-rel-icon.html.
- 2:14 PM Changeset in webkit [39910] by
-
- 7 edits3 adds in trunk
Bug 22903: REGRESSION (r36267): visiting this site reliably crashes WebKit nightly
Reviewed by Cameron Zwarich
EvalCodeBlock's do not reference the functions that are declared inside the eval
code, this means that simply marking the EvalCodeBlock through the global object
is insufficient to mark the declared functions. This patch corrects this by
explicitly marking the CodeBlocks of all the functions declared in the cached
EvalNode.
- 1:58 PM Changeset in webkit [39909] by
-
- 2 edits in trunk/WebCore
2009-01-14 Pierre-Olivier Latour <pol@apple.com>
Fixed build warning when LIBXML_VERSION >= 20627.
- dom/XMLTokenizerLibxml2.cpp: (WebCore::hackAroundLibXMLEntityBug):
- 1:57 PM Changeset in webkit [39908] by
-
- 8 edits in trunk/JavaScriptCore
2009-01-14 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23312
Implement MessageQueue::waitForMessageTimed()
Also fixed ThreadCondition::timedWait() to take absolute time, as discussed on webkit-dev.
Win32 version of timedWait still has to be implemented.
- wtf/MessageQueue.h: (WTF::MessageQueueWaitResult: new enum for the result of MessageQueue::waitForMessageTimed. (WTF::MessageQueue::waitForMessage): (WTF::MessageQueue::waitForMessageTimed): New method.
- wtf/Threading.h:
- wtf/ThreadingGtk.cpp: (WTF::ThreadCondition::timedWait): changed to use absolute time instead of interval.
- wtf/ThreadingNone.cpp: (WTF::ThreadCondition::timedWait): ditto.
- wtf/ThreadingPthreads.cpp: (WTF::ThreadCondition::timedWait): ditto.
- wtf/ThreadingQt.cpp: (WTF::ThreadCondition::timedWait): ditto.
- wtf/ThreadingWin.cpp: (WTF::ThreadCondition::timedWait): ditto. The actual Win32 code is still to be implemented.
- 1:48 PM Changeset in webkit [39907] by
-
- 2 edits in trunk/WebKitTools
2009-01-13 Dmitry Titov <dimich@chromium.org>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=23304
Fix svn-apply to match svn-unapply to recognize added files in 'git diff' patches.
- Scripts/svn-apply: Added a check (similar to svn-unapply) to recognize added files.
- 1:24 PM Changeset in webkit [39906] by
-
- 3 edits in trunk/WebKitTools
BUILD FIX: Implement LayoutTestController::setIconDatabaseEnabled(bool) for GTK
- DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Added call to reset the icon database to match Mac and Windows ports.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setIconDatabaseEnabled): Implemented stub method.
- 1:13 PM Changeset in webkit [39905] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=23326
Resources are never deleted from application cache disk database
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::openDatabase): Create a trigger that deletes resources when a cache is deleted. Note that this change doesn't require bumping schema version. We should consider switching to foreign keys and cascade delete instead of triggers in the future. (WebCore::ApplicationCacheStorage::remove): Added a comment explaining why it's sufficient to only remove the cache itself. (WebCore::ApplicationCacheStorage::empty): Don't delete from CacheResources, now that this is done automatically when a cache is deleted.
- 1:08 PM Changeset in webkit [39904] by
-
- 12 edits3 adds in trunk
Bug 22795: favicons should be saved to webarchives
Reviewed by Darin Adler.
WebCore:
Test: webarchive/test-link-rel-icon.html
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Do not add favicon URLs to the list since no ArchiveResource or CachedResource is ever created for them.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Handle favicons as a special case for all main resources.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::close): Actually close the SQLite database so that isOpen() returns false when called. Added an ASSERT() for good measure.
WebKitTools:
- DumpRenderTree/LayoutTestController.cpp: (setIconDatabaseEnabledCallback): Added. (setJavaScriptProfilingEnabledCallback): Realphabetized. (LayoutTestController::staticFunctions): Added entry for calling LayoutTestController.setIconDatabaseEnabled(bool) from JavaScript.
- DumpRenderTree/LayoutTestController.h: (setIconDatabaseEnabledCallback): Added declaration. (setJavaScriptProfilingEnabledCallback): Realphabetized.
- DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Disable the icon database before each test.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setIconDatabaseEnabled): Added. (LayoutTestController::setJavaScriptProfilingEnabled): Realphabetized.
- DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Disable the icon database before each test.
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setIconDatabaseEnabled): Added.
LayoutTests:
Note that this test case contains a workaround for Bug 21026 and
<rdar://problem/6240826> which may be removed once that is fixed.
- webarchive/resources/favicon.ico: Copied from LayoutTests/fast/images/resources/favicon.ico.
- webarchive/test-link-rel-icon-expected.webarchive: Added.
- webarchive/test-link-rel-icon.html: Added.
- 11:52 AM Changeset in webkit [39903] by
-
- 8 edits24 adds in trunk/WebCore
2009-01-14 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23328
Upstream remaining files from platform/chromium/
- platform/chromium/CursorChromium.cpp: (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
- platform/chromium/DragDataRef.h: Added.
- platform/chromium/DragImageChromium.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
- platform/chromium/DragImageRef.h:
- platform/chromium/KeyCodeConversion.h: Added.
- platform/chromium/KeyCodeConversionGtk.cpp: Added. (WebCore::windowsKeyCodeForKeyEvent):
- platform/chromium/KeyboardCodes.h: Added.
- platform/chromium/KeyboardCodesPosix.h: Added. (WebCore::):
- platform/chromium/KeyboardCodesWin.h: Added. (WebCore::):
- platform/chromium/Language.cpp: Added. (WebCore::defaultLanguage):
- platform/chromium/LinkHashChromium.cpp: Added. (WebCore::visitedLinkHash):
- platform/chromium/MimeTypeRegistryChromium.cpp: Added. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::getMIMETypeForPath): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): (WebCore::MIMETypeRegistry::isJavaAppletMIMEType): (WebCore::dummyHashSet): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
- platform/chromium/PasteboardChromium.cpp: Added. (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
- platform/chromium/PasteboardPrivate.h:
- platform/chromium/PlatformCursor.h: Added. (WebCore::PlatformCursor::): (WebCore::PlatformCursor::PlatformCursor): (WebCore::PlatformCursor::customImage): (WebCore::PlatformCursor::hotSpot): (WebCore::PlatformCursor::type):
- platform/chromium/PlatformKeyboardEventChromium.cpp: Added. (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- platform/chromium/PlatformScreenChromium.cpp: Added. (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
- platform/chromium/PlatformWidget.h:
- platform/chromium/PopupMenuChromium.cpp: Added. (WebCore::PopupListBox::selectedIndex): (WebCore::PopupListBox::numItems): (WebCore::PopupListBox::setBaseWidth): (WebCore::PopupListBox::setTextOnIndexChange): (WebCore::PopupListBox::setAcceptOnAbandon): (WebCore::PopupListBox::): (WebCore::PopupListBox::ListItem::ListItem): (WebCore::PopupListBox::PopupListBox): (WebCore::PopupListBox::~PopupListBox): (WebCore::PopupListBox::disconnectClient): (WebCore::PopupListBox::scrollToRevealSelection): (WebCore::constructRelativeMouseEvent): (WebCore::constructRelativeWheelEvent): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::~PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::hidePopup): (WebCore::PopupContainer::layout): (WebCore::PopupContainer::handleMouseDownEvent): (WebCore::PopupContainer::handleMouseMoveEvent): (WebCore::PopupContainer::handleMouseReleaseEvent): (WebCore::PopupContainer::handleWheelEvent): (WebCore::PopupContainer::handleKeyEvent): (WebCore::PopupContainer::hide): (WebCore::PopupContainer::paint): (WebCore::PopupContainer::paintBorder): (WebCore::PopupContainer::isInterestedInEventForKey): (WebCore::PopupContainer::show): (WebCore::PopupContainer::setTextOnIndexChange): (WebCore::PopupContainer::setAcceptOnAbandon): (WebCore::PopupContainer::refresh): (WebCore::PopupListBox::handleMouseDownEvent): (WebCore::PopupListBox::handleMouseMoveEvent): (WebCore::PopupListBox::handleMouseReleaseEvent): (WebCore::PopupListBox::handleWheelEvent): (WebCore::PopupListBox::isInterestedInEventForKey): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::hostWindow): (WebCore::PopupListBox::invalidateRect): (WebCore::stripLeadingWhiteSpace): (WebCore::PopupListBox::typeAheadFind): (WebCore::PopupListBox::paint): (WebCore::PopupListBox::paintRow): (WebCore::PopupListBox::getRowFont): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::pointToRowIndex): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::setOriginalIndex): (WebCore::PopupListBox::getRowHeight): (WebCore::PopupListBox::getRowBounds): (WebCore::PopupListBox::invalidateRow): (WebCore::PopupListBox::scrollToRevealRow): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::adjustSelectedIndex): (WebCore::PopupListBox::updateFromElement): (WebCore::PopupListBox::layout): (WebCore::PopupListBox::clear): (WebCore::PopupListBox::isPointInBounds): (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
- platform/chromium/PopupMenuChromium.h: Added. (WebCore::PopupContainer::listBox):
- platform/chromium/PopupMenuPrivate.h: Added.
- platform/chromium/SSLKeyGeneratorChromium.cpp: Added. (WebCore::supportedKeySizes):
- platform/chromium/ScrollbarThemeChromium.cpp: Added. (WebCore::ScrollbarTheme::nativeTheme): (WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium): (WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium): (WebCore::ScrollbarThemeChromium::themeChanged): (WebCore::ScrollbarThemeChromium::hasThumb): (WebCore::ScrollbarThemeChromium::backButtonRect): (WebCore::ScrollbarThemeChromium::forwardButtonRect): (WebCore::ScrollbarThemeChromium::trackRect): (WebCore::ScrollbarThemeChromium::paintTrackBackground): (WebCore::ScrollbarThemeChromium::paintTickmarks): (WebCore::ScrollbarThemeChromium::paintScrollCorner): (WebCore::ScrollbarThemeChromium::shouldCenterOnThumb): (WebCore::ScrollbarThemeChromium::buttonSize):
- platform/chromium/ScrollbarThemeChromium.h: Added. (WebCore::ScrollbarThemeChromium::hasButtons):
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added. (WebCore::ScrollbarThemeChromium::scrollbarThickness): (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit): (WebCore::initMozState): (WebCore::paintScrollbarWidget): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintButton): (WebCore::ScrollbarThemeChromium::paintThumb):
- platform/chromium/ScrollbarThemeChromiumWin.cpp:
- platform/chromium/SearchPopupMenuChromium.cpp: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::enabled): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
- platform/chromium/SharedTimerChromium.cpp: Added. (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
- platform/chromium/TemporaryLinkStubs.cpp: Added. (WebCore::signedPublicKeyAndChallengeString): (WebCore::getSupportedKeySizes): (WebCore::KURL::fileSystemPath): (WebCore::SharedBuffer::createWithContentsOfFile): (WTF::scheduleDispatchFunctionsOnMainThread):
- 11:40 AM Changeset in webkit [39902] by
-
- 1 edit6 adds in trunk/WebCore
2009-01-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23321
Upstream more bits of graphics/chromium.
- platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT): (WebCore::FontPlatformData::hashTableDeletedFontValue): (WebCore::FontPlatformData::scriptFontProperties):
- platform/graphics/chromium/FontPlatformDataChromiumWin.h: Added. (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hfont): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::scriptCache): (WebCore::FontPlatformData::RefCountedHFONT::create): (WebCore::FontPlatformData::RefCountedHFONT::hfont): (WebCore::FontPlatformData::RefCountedHFONT::hash): (WebCore::FontPlatformData::RefCountedHFONT::operator==): (WebCore::FontPlatformData::RefCountedHFONT::RefCountedHFONT):
- platform/graphics/chromium/FontPlatformDataLinux.cpp: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setupPaint): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isFixedPitch):
- platform/graphics/chromium/FontPlatformDataLinux.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
- platform/graphics/chromium/FontUtilsChromiumWin.cpp: Added. (WebCore::): (WebCore::FontMap::getAscent): (WebCore::FontMap::FontData::FontData): (WebCore::getFontFamilyForScript): (WebCore::getFallbackFamily): (WebCore::getDerivedFontData): (WebCore::getStyleFromLogfont):
- platform/graphics/chromium/FontUtilsChromiumWin.h: Added. (WebCore::):
- 11:37 AM Changeset in webkit [39901] by
-
- 2 edits in trunk/WebKit/mac
2009-01-14 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Fix crash I ran into while printing. I was unable to reproduce it, but also,
it's clear there's no guarantee that the frame will be non-zero in this case,
so it seems fine to check it.
- WebView/WebHTMLView.mm: (-[WebHTMLView reapplyStyles]): Check frame for zero and don't do anything with it if it's zero.
- 11:25 AM Changeset in webkit [39900] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove errant WARNING from WebCore/ChangeLog.
- 11:23 AM Changeset in webkit [39899] by
-
- 1 edit9 adds in trunk/WebCore
2009-01-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23325
Upstream even more graphics/chromium bits.
WARNING: NO TEST CASES ADDED OR CHANGED
- platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: Added. (WebCore::fillEmptyGlyphs): (WebCore::initSpaceGlyph): (WebCore::fillBMPGlyphs): (WebCore::fillNonBMPGlyphs): (WebCore::GlyphPage::fill):
- platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Added. (WebCore::GlyphPage::fill):
- platform/graphics/chromium/IconChromiumLinux.cpp: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::createIconForFile): (WebCore::Icon::createIconForFiles): (WebCore::Icon::paint):
- platform/graphics/chromium/IconChromiumMac.cpp: Added. (WebCore::Icon::createIconForFile): (WebCore::Icon::createIconForFiles): (WebCore::Icon::~Icon): (WebCore::Icon::paint):
- platform/graphics/chromium/IconChromiumWin.cpp: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::createIconForFile): (WebCore::Icon::createIconForFiles): (WebCore::Icon::paint):
- platform/graphics/chromium/ImageBufferData.h: Added.
- platform/graphics/chromium/ImageChromiumMac.mm: Added. (WebCore::Image::loadPlatformResource): (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData):
- platform/graphics/chromium/MediaPlayerPrivateChromium.h: Added.
- platform/graphics/chromium/PlatformIcon.h: Added.
- 11:11 AM Changeset in webkit [39898] by
-
- 1 edit2 adds in trunk/WebCore
2009-01-14 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23323
Upstream platform/text/chromium/
- platform/text/chromium: Added.
- platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: Added. (WebCore::currentTextBreakLocaleID):
- 11:07 AM Changeset in webkit [39897] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-14 Dean McNamee <deanm@chromium.org>
Reviewed by Darin Adler and Oliver hunt.
Correctly match allocation functions by implementing a custom deref().
- runtime/ByteArray.h: (JSC::ByteArray::deref): (JSC::ByteArray::ByteArray):
- 11:02 AM Changeset in webkit [39896] by
-
- 1 edit1 move1 add in trunk/WebCore
2009-01-14 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23324
Move platform/chromium/EditorChromium.cpp into editing/chromium/
- editing/chromium: Added.
- editing/chromium/EditorChromium.cpp: Copied from platform/chromium/EditorChromium.cpp.
- platform/chromium/EditorChromium.cpp: Removed.
- 10:56 AM Changeset in webkit [39895] by
-
- 4 edits in trunk
Update copyright year in version resources.
- 10:34 AM Changeset in webkit [39894] by
-
- 2 edits in trunk/WebCore
2009-01-14 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23320
Make it possible to use notImplemented outside of the WebCore namespace
- platform/NotImplemented.h:
- 10:23 AM Changeset in webkit [39893] by
-
- 3 edits4 adds in trunk
WebCore:
2009-01-14 Nigel Tao <nigel.tao.gnome@gmail.com>
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=22476 Check that the document's SecurityOrigin canLoadLocalResources, when pages try to put NSFilenamesPboardtype data on the clipboard, by calling event.dataTransfer.setData('URL', 'file:///foo/bar');
Tests: http/tests/security/dataTransfer-set-data-file-url.html
platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html
- platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::setData):
LayoutTests:
2009-01-14 Nigel Tao <nigel.tao.gnome@gmail.com>
Reviewed by Darin Adler.
- tests for https://bugs.webkit.org/show_bug.cgi?id=22476 Added tests that calling dataTransfer.setData('URL', aFileUrl) only puts NSFilenamesPboardtype data on the clipboard if called from a locally served page.
- http/tests/security/dataTransfer-set-data-file-url-expected.txt: Added.
- http/tests/security/dataTransfer-set-data-file-url.html: Added.
- platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.txt: Added.
- platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html: Added.
- 10:18 AM Changeset in webkit [39892] by
-
- 14 edits in trunk
Reviewed by John Sullivan.
- update copyright
- Info.plist:
JavaScriptGlue:
Reviewed by John Sullivan.
- update copyright
- Info.plist:
WebCore:
Reviewed by John Sullivan.
- update copyright
- Info.plist:
WebKit/mac:
Reviewed by John Sullivan.
- update copyright
- Info.plist:
WebKit/win:
Reviewed by John Sullivan.
- update copyright
- WebKit.resources/Info.plist:
- WebKit.vcproj/WebKit.rc:
WebKitTools:
Reviewed by John Sullivan.
- update copyright
- DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist:
- WebKitLauncher/Info.plist:
- 9:58 AM Changeset in webkit [39891] by
-
- 3 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23316
Application cache updating always fails with an assertion
Test: http/tests/appcache/update-cache.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Correctly handle the case where multiple caches survive the last DocumentLoader destruction, preventing a crash in release builds. (WebCore::ApplicationCacheGroup::setNewestCache): Removed a bogus assertion.
- 9:19 AM Changeset in webkit [39890] by
-
- 4 edits in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23313
appcache/offline-access.html fails frequently
- http/tests/appcache/resources/offline-access-frame.html: Make sure that the test runs, even if the cache update finishes before we install event listeners.
- http/tests/appcache/offline-access-expected.txt:
- http/tests/appcache/offline-access.html: Don't dump frame content, as it is timing dependent.
- 5:56 AM Changeset in webkit [39889] by
-
- 2 edits in trunk/WebKit/qt
2009-01-14 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Tor Arne Vestbø.
[Qt] Unit tests for text selection and editing actions of QWebPage.
The following are tested:
- the actions are not NULL
- the actions are disabled when contentEditable is false
- the actions are enabled when contentEditable is true
- 5:48 AM Changeset in webkit [39888] by
-
- 2 edits in trunk/WebKit/qt
2009-01-14 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix failing assertion when pressing an extra mouse button on a
QWebView.
Mice with more than three buttons - for example with a dedicated
"back" button - can generate Qt::XButton1 or Button2.
WebCore::MouseButton contains only Left, Middle and Right, so in
Qt's PlatformMouseEvent we map to NoButton, resulting in a mouse
press or release even with no button set. That triggers an assertion
in EventTargetNode::dispatchMouseEvent requiring that either a button
is set or it is just a mouse move event, which is correct.
In QWebPage decide not to dispatch such mouse events where we cannot
map the mouse button to a WebCore::MouseButton.
- 5:34 AM Changeset in webkit [39887] by
-
- 2 edits in trunk/WebKit/qt
2009-01-14 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
http://www.qtsoftware.com/developer/task-tracker/index_html?id=241144&method=entry
[Qt] Create actions for text selection and editing for QWebPage.
Also properly disable and enable them when contentEditable is toggled.
- Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateEditorActions): (QWebPage::action):
- 4:39 AM Changeset in webkit [39886] by
-
- 2 edits in trunk/WebKit/qt
2009-01-14 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
[Qt] Unit tests for cursor movements. The following are tested:
- the actions are not NULL
- the actions are disabled when contentEditable is false
- the actions are enabled when contentEditable is true
- the cursor moves properly when the actions are triggered
- tests/qwebpage/tst_qwebpage.cpp: (CursorTrackedPage::CursorTrackedPage): (CursorTrackedPage::selectedText): (CursorTrackedPage::selectionStartOffset): (CursorTrackedPage::selectionEndOffset): (CursorTrackedPage::isSelectionCollapsed): (tst_QWebPage::cursorMovements):
- 1:02 AM Changeset in webkit [39885] by
-
- 2 edits in trunk/WebCore
Release build fix.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeUpdatedType): Use ASSERT_UNUSED.
Jan 13, 2009:
- 11:17 PM Changeset in webkit [39884] by
-
- 7 edits5 adds in trunk
Reviewed by Anders Carlsson.
Test: http/tests/appcache/xhr-foreign-resource.html
https://bugs.webkit.org/show_bug.cgi?id=23256
Implement application cache foreign entries
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Removed a misplaced check for foreign resources that prevented them from being loaded altogether.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): If a document that was loaded from appcache should be associated with a different cache, mark the resource as foreign in the original cache and start over.
- loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::addType): This function can now be called after a cache is stored, so it no longer asserts the opposite.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupForURL): Fix database pass to correctly ignore in-memory caches that were already rejected. (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto. (WebCore::ApplicationCacheStorage::storeUpdatedType): Added a function that updates type of an already stored cached resource.
- loader/appcache/ApplicationCacheStorage.h: Added storeUpdatedType().
- 11:14 PM Changeset in webkit [39883] by
-
- 1 edit7 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23286
Add a test for non-ASCII URIs in application cache
- http/tests/appcache/cyrillic-uri-expected.txt: Added.
- http/tests/appcache/cyrillic-uri.html: Added.
- http/tests/appcache/resources/cyrillic-uri-form.html: Added.
- http/tests/appcache/resources/cyrillic-uri.manifest: Added.
- http/tests/appcache/resources/intercept: Added.
- http/tests/appcache/resources/intercept/.htaccess: Added.
- http/tests/appcache/resources/print-uri.php: Added.
- 5:44 PM Changeset in webkit [39882] by
-
- 5 edits in trunk
2009-01-13 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler and Oliver Hunt.
<rdar://problem/6489314> REGRESSION: Business widget's front side
fails to render correctly when flipping widget
The problem here is that parseInt was parsing NaN as 0. This patch
corrects that by parsing NaN as NaN. This matches our old behavior
and Firefox.
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
LayoutTests:
2009-01-13 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler and Oliver Hunt.
Updated test and results for <rdar://problem/6489314> REGRESSION:
Business widget's front side fails to render correctly when
flipping widget
parseInt(NaN) should be NaN.
- fast/js/numeric-conversion-expected.txt:
- fast/js/resources/numeric-conversion.js:
- 5:24 PM Changeset in webkit [39881] by
-
- 6 edits in trunk/WebCore
Fix the Tiger WebCore build after r39880.
- editing/Editor.cpp:
(WebCore::Editor::markBadGrammar):
- loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):
- platform/mac/WebCoreObjCExtras.mm:
(WebCoreObjCFinalizeOnMainThread):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::schedule):
(WebCore::ResourceHandle::unschedule):
- 4:16 PM Changeset in webkit [39880] by
-
- 17 edits in trunk/WebCore
2009-01-13 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23102: turn on unused parameter warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=23102
Last step: Turn on the warning and fix the last few instances.
- Configurations/Base.xcconfig: Removed -Wno-unused-parameter from WARNING_CFLAGS_BASE, so the unused parameter warning will fire.
- bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseMessageChannel): Separate the version for use when CHANNEL_MESSAGING is turned off, so we can omit the argument names. It would be better to not even have this property in that case, rather than having the function return undefined, but I don't know how to do that with the bindings script.
- bindings/scripts/CodeGeneratorJS.pm: Leave out argument names in functions where they're not used (the SVG context, and the property name in the index getter). Use UNUSED_PARAM where arguments are sometimes not used.
- bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::put): Use UNUSED_PARAM for non-QT.
- css/MediaQueryEvaluator.cpp: (WebCore::animationMediaFeatureEval): Omit argument names for style and frame. (WebCore::transitionMediaFeatureEval): Ditto. (WebCore::transform_2dMediaFeatureEval): Ditto. (WebCore::transform_3dMediaFeatureEval): Ditto.
- dom/make_names.pl: Leave out the createdByParser property name in cases where it's not used.
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Separate the version for the Mac platform so we can omit the argument names.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::contentsSizeChanged): Removed argument name.
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::shouldUsePluginDocument): Commented out argument name.
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didReceiveResponse): Use ASSERT_UNUSED. (WebCore::IconFetcher::didReceiveData): Ditto. (WebCore::IconFetcher::didFinishLoading): Ditto. (WebCore::IconFetcher::didFail): Ditto.
- platform/KURL.cpp: (WebCore::assertProtocolIsGood): Separate out the NDEBUG version so we can omit the argument names.
- platform/Timer.cpp: (WebCore::TimerHeapIterator::checkConsistency): Use ASSERT_UNUSED.
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::offsetAt): Use UNUSED_PARAM in the non-WIN case. (WebCore::GlyphBuffer::add): Use UNUSED_PARAM in the non-CAIRO case.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear): Removed argument name.
- rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent): Use UNUSED_PARAM when SVG_FILTERS is not enabled. (WebCore::finishRenderSVGContent): Ditto.
- 4:15 PM Changeset in webkit [39879] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Implementation of two argument canDoFastAdditiveOperations does not correlate well with reality.
- runtime/JSImmediate.h: (JSC::JSFastMath::canDoFastAdditiveOperations):
- 3:40 PM ApplicationsGtk edited by
- fixed Empathy's link label (diff)
- 2:47 PM Changeset in webkit [39878] by
-
- 2 edits in trunk/WebCore
Implemented https://bugs.webkit.org/show_bug.cgi?id=23298
Simple fix to convertToLength to catch style==null cases
- css/CSSStyleSelector.cpp: (WebCore::convertToLength):
- 2:36 PM Changeset in webkit [39877] by
-
- 5 edits2 adds in trunk
WebKitTools:
2009-01-13 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add NPRuntime test.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testNPRuntime):
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_GetValue):
LayoutTests:
2009-01-13 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add NPRuntime test.
- plugins/npruntime-expected.txt: Added.
- plugins/npruntime.html: Added.
- 1:15 PM Changeset in webkit [39876] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
Speculative fix for an Uninitialized Memory Read (UMR)
seen by purify in chormium's equivalent V8 file.
- bindings/js/JSSVGPODTypeWrapper.h: (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo):
- 12:55 PM Changeset in webkit [39875] by
-
- 1 edit4 adds in trunk/WebCore
2009-01-13 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Land portions of platform/graphics/chromium.
https://bugs.webkit.org/show_bug.cgi?id=23297
- platform/graphics/chromium/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::EOTStream::EOTStream): (WebCore::EOTStream::read): (WebCore::readEmbedProc): (WebCore::createUniqueFontName): (WebCore::createFontCustomPlatformData):
- platform/graphics/chromium/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
- platform/graphics/chromium/FontLinux.cpp: Added. (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
- platform/graphics/chromium/FontPlatformData.h: Added.
- 12:44 PM Changeset in webkit [39874] by
-
- 2 edits in trunk/WebKit/qt
2009-01-08 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
Update webview with the intersected rect.
In ChromeClientQt::repaint, view should be updated with the
intersected rect, not the whole windowRect;
This generally is not a problem for normal viewport setup where
viewport size is the same as the qwebview widget size. However, if we
set the viewport size smaller than qwebkit widget, we will see
unwanted painting outside the viewport.
- 12:43 PM Changeset in webkit [39873] by
-
- 2 edits in trunk/WebKit/qt
2009-01-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Tor Arne Vestbø.
[Qt] Missing piece from my previous commit:
Disable and enable the cursor navigation actions when contentEditable
is changed.
- Api/qwebpage.cpp: (QWebPagePrivate::updateEditorActions):
- 12:24 PM Changeset in webkit [39872] by
-
- 2 edits in trunk/WebCore
Don't copy DOMStringList.idl into the framework bundle.
Rubber-stamped by Oliver Hunt.
- WebCore.xcodeproj/project.pbxproj:
- 12:22 PM WebKit Team edited by
- (diff)
- 12:07 PM Changeset in webkit [39871] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=23290
Fix JSImmediate::isImmediate(src) to !src->isCell()
Reviewed by Darin Adler.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- 12:07 PM Changeset in webkit [39870] by
-
- 2 edits in trunk/WebKit/qt
2009-01-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Tor Arne Vestbø.
[Qt] Create actions for cursor navigation for QWebPage.
Also properly disable and enable them when contentEditable is toggled.
- Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPage::action):
- 11:26 AM Changeset in webkit [39869] by
-
- 5 edits in trunk/WebKit/mac
2009-01-12 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Add a bunch of methods to WebKitPluginClient.defs, and implement them.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::fromUTF8WithLatin1Fallback): If the length isn't specified, get it by calling strlen.
(WKPCEvaluate):
Evaluate doesn't take any arguments.
(WKPCGetIntIdentifier):
Call _NPN_GetIntIdentifier.
(identifierFromServerIdentifier):
New helper function that returns a JSC Identifier from an NPIdentifier.
(WKPCInvoke):
Call identifierFromServerIdentifier.
(WKPCRemoveProperty):
(WKPCHasProperty):
(WKPCHasMethod):
Call NetscapePluginInstanceProxy.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::removeProperty): (WebKit::NetscapePluginInstanceProxy::hasProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod):
- Plugins/Hosted/WebKitPluginClient.defs: Add new definitions.
- 11:25 AM Changeset in webkit [39868] by
-
- 2 edits in trunk/WebCore
2009-01-13 Christian Dywan <christian@twotoasts.de>
Build fix, StorageEvent is only defined if we have DOM_STORAGE
- dom/Document.cpp: (WebCore::Document::createEvent): Conditionalize StorageEvent
- 11:17 AM Changeset in webkit [39867] by
-
- 2 edits in trunk/WebKit/mac
2009-01-13 Anders Carlsson <andersca@apple.com>
Fix build.
- WebView/WebView.mm: (-[WebView _initWithArguments:]):
- 11:13 AM Changeset in webkit [39866] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-13 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23281
Fix the Chromium Win build.
Need to use PLATFORM(WIN_OS) instead of PLATFORM(WIN).
Moved GTK and WX up in #if sequence because they could come with WIN_OS too,
while they have their own implementation even on Windows.
- wtf/CurrentTime.cpp: (WTF::currentTime):
- 10:12 AM Changeset in webkit [39865] by
-
- 7 edits in trunk/WebKit
Adds a workaround for the flip4mac installer plugin decoding a WebView from a NIB on a secondary thread.
<rdar://problem/6489788> New WebKit thread checks break installation of flip4mac (thread violation)
Reviewed by Darin Adler.
- Misc/WebKitVersionChecks.h: Add WEBKIT_FIRST_VERSION_WITHOUT_WEBVIEW_INIT_THREAD_WORKAROUND.
- Misc/WebNSObjectExtras.h: Add _webkit_performSelectorOnMainThread:withObject:.
- Misc/WebNSObjectExtras.mm: (-[NSObject _webkit_performSelectorWithArguments:]): Renamed from _webkit_getPropertyWithArguments. Passes the optional object to the selector. (-[NSObject _webkit_performSelectorOnMainThread:withObject:]): Renamed from _webkit_getPropertyOnMainThread:. Put the optional object into the arguments dictionary. (-[NSObject _webkit_getPropertyOnMainThread:]): Call _webkit_performSelectorOnMainThread with a nil object.
- WebView/WebResource.mm: (-[WebResource _ignoreWhenUnarchiving]): Use _cmd instead of making the selector again. (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): Use the new _webkit_performSelectorOnMainThread:withObject: method instead of performSelectorOnMainThread.
- WebView/WebView.mm: (-[WebView _initWithArguments:]): Added. Pulls arguments out of the dictionary and calls the right init method. (needsWebViewInitThreadWorkaround): Checks if the thead is not the main thread and if we are in the Installer bundle. (-[WebView initWithFrame:frameName:groupName:]): Call needsWebViewInitThreadWorkaround and use _webkit_performSelectorOnMainThread to call _initWithArguments: passing the frame, frameName and groupName. (-[WebView initWithCoder:]): Ditto, except pass the coder to _initWithArguments:.
- 9:59 AM Changeset in webkit [39864] by
-
- 2 edits in trunk/WebCore
2009-01-13 Darin Adler <Darin Adler>
Reviewed by Adele Peterson.
Bug 23277: space bar scrolls the page when typed in any text field
https://bugs.webkit.org/show_bug.cgi?id=23277
rdar://problem/6490249
There's already a regression test for this, since bug 16421 was the same problem, but on
Mac. The regression test is fast/events/space-scroll-event.html, so I won't write a new one.
This bug doesn't affect Mac because the canEdit check in -[WebHTMLView insertText:] prevents
a text input event from being generated at all. That difference may in itself be a bug, but
the only symptom is that you get text input events in more cases on platforms other than Mac.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent): Return whether the event's default was handled, not the result of the dispatchEvent function, which indicates only whether the default behavior was prevented, not if the default behavior did some insertion. This fix makes it so the keyboard event handler can detect that no space was inserted and know that the space bar keypress event can be treated as a scrolling command. (WebCore::EventHandler::defaultKeyboardEventHandler): Handle the keypress event, not the keydown event. Without the change above, making this change would have restored the old behavior, reintroducing bug 22913 where the space bar doesn't scroll at all on Windows.
- 9:58 AM Changeset in webkit [39863] by
-
- 6 edits in trunk/WebKit/qt
2009-01-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Based on patch by Yael Aharon <yael.aharon@nokia.com>
Make the QWebSettings functions for setting the path for the local
storage database private QtWebkit API, including the ability to
associated a QWebPage with a named page group.
- 9:24 AM Changeset in webkit [39862] by
-
- 2 edits in trunk/WebCore
2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
[Qt] Make sure media elements dispatch the 'loaded' event
We assume that when Phonon goes into paused state that we have the
complete media file. Once we do media loading ourselves we can
distinguish between loading the first frame and the complete media.
- 8:48 AM Changeset in webkit [39861] by
-
- 1 edit27 adds in trunk/WebCore
2009-01-13 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
Landing portions of platform/chromium/, taken from here:
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/
- platform/chromium/ChromiumBridge.h: Added.
- platform/chromium/ChromiumDataObject.cpp: Added. (WebCore::ChromiumDataObject::clear): (WebCore::ChromiumDataObject::hasData):
- platform/chromium/ChromiumDataObject.h: Added. (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ClipboardChromium.cpp: Added. (WebCore::): (WebCore::clipboardTypeFromMIMEType): (WebCore::ClipboardChromium::ClipboardChromium): (WebCore::ClipboardChromium::create): (WebCore::ClipboardChromium::clearData): (WebCore::ClipboardChromium::clearAllData): (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::setData): (WebCore::ClipboardChromium::types): (WebCore::ClipboardChromium::setDragImage): (WebCore::ClipboardChromium::setDragImageElement): (WebCore::ClipboardChromium::createDragImage): (WebCore::imageToMarkup): (WebCore::getCachedImage): (WebCore::writeImageToDataObject): (WebCore::ClipboardChromium::declareAndWriteDragImage): (WebCore::ClipboardChromium::writeURL): (WebCore::ClipboardChromium::writeRange): (WebCore::ClipboardChromium::hasData):
- platform/chromium/ClipboardChromium.h: Added. (WebCore::ClipboardChromium::~ClipboardChromium): (WebCore::ClipboardChromium::dataObject):
- platform/chromium/ClipboardUtilitiesChromium.cpp: Added. (WebCore::replaceNewlinesWithWindowsStyleNewlines): (WebCore::replaceNBSPWithSpace): (WebCore::urlToMarkup):
- platform/chromium/ClipboardUtilitiesChromium.h: Added.
- platform/chromium/ContextMenuChromium.cpp: Added. (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemWithAction): (WebCore::ContextMenu::itemAtIndex): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::platformDescription): (WebCore::ContextMenu::releasePlatformDescription):
- platform/chromium/ContextMenuItemChromium.cpp: Added. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled): (WebCore::ContextMenuItem::enabled):
- platform/chromium/CursorChromium.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
- platform/chromium/DragDataChromium.cpp: Added. (WebCore::containsHTML): (WebCore::DragData::createClipboard): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::containsColor): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::asFragment): (WebCore::DragData::asColor):
- platform/chromium/EditorChromium.cpp: Added. (WebCore::Editor::newGeneralClipboard):
- platform/chromium/FileChooserChromium.cpp: Added. (WebCore::FileChooser::basenameForWidth):
- platform/chromium/FileSystemChromium.cpp: Added. (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists):
- platform/chromium/FileSystemChromiumLinux.cpp: Added. (WebCore::pathGetFileName):
- platform/chromium/FileSystemChromiumMac.mm: Added. (WebCore::pathGetFileName):
- platform/chromium/FileSystemChromiumWin.cpp: Added. (WebCore::pathGetFileName):
- platform/chromium/FramelessScrollView.cpp: Added. (WebCore::FramelessScrollView::~FramelessScrollView): (WebCore::FramelessScrollView::invalidateScrollbarRect): (WebCore::FramelessScrollView::isActive): (WebCore::FramelessScrollView::invalidateRect): (WebCore::FramelessScrollView::hostWindow): (WebCore::FramelessScrollView::windowClipRect): (WebCore::FramelessScrollView::paintContents): (WebCore::FramelessScrollView::contentsResized): (WebCore::FramelessScrollView::visibleContentsResized):
- platform/chromium/FramelessScrollView.h: Added. (WebCore::FramelessScrollView::FramelessScrollView): (WebCore::FramelessScrollView::client): (WebCore::FramelessScrollView::setClient):
- platform/chromium/FramelessScrollViewClient.h: Added.
- platform/chromium/ScrollbarThemeChromiumWin.cpp: Added. (WebCore::): (WebCore::ScrollbarThemeChromium::scrollbarThickness): (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintButton): (WebCore::ScrollbarThemeChromium::paintThumb): (WebCore::ScrollbarThemeChromium::getThemeState): (WebCore::ScrollbarThemeChromium::getThemeArrowState): (WebCore::ScrollbarThemeChromium::getClassicThemeState):
- platform/chromium/SoundChromiumPosix.cpp: Added. (WebCore::systemBeep):
- platform/chromium/SoundChromiumWin.cpp: Added. (WebCore::systemBeep):
- platform/chromium/SystemTimeChromium.cpp: Added. (WebCore::currentTime): (WebCore::userIdleTime):
- platform/chromium/WidgetChromium.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setCursor): (WebCore::Widget::paint): (WebCore::Widget::setFocus): (WebCore::Widget::setIsSelected): (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
- platform/chromium/WindowsVersion.cpp: Added. (WebCore::isVistaOrNewer):
- platform/chromium/WindowsVersion.h: Added.
- 8:38 AM Changeset in webkit [39860] by
-
- 2 edits in trunk/WebCore
2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
[Qt] Add more verbose error output when loading NPAPI plugins
- 8:17 AM Changeset in webkit [39859] by
-
- 2 edits in trunk/WebCore
2009-01-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix crash in the Qt port when deleting a popup from within a
JavaScript onchange handler.
- 6:58 AM Changeset in webkit [39858] by
-
- 2 edits in trunk/WebCore
[GIO] Make sure to untef the GFile and the GInputStream on destruction
Make sure to call cleanupGioOperation from the ResourceHandleInternal
d'tor. Change the signature of cleanupGioOperation so we can do the
cleanup of GIO next to the cleanup of SOUP.
- 6:58 AM Changeset in webkit [39857] by
-
- 2 edits in trunk/WebCore
[GIO] Attach the ResourceHandle to the GObject and get it from the GObject
https://bugs.webkit.org/show_bug.cgi?id=23116 discussed with Benjamin Otte
Sometimes it is not possible to cancel a pending GIO operation and the
callback might be invoked with a pointer to an already destructed
ResourceHandle. To avoid this issue we will attach the ResourceHandle
to the GObject* and in the callback attempt to get the ResourceHandle
from the GObject*. If no ResourceHandle is attached we silently fail
as the cleanup has been already done.
- 6:58 AM Changeset in webkit [39856] by
-
- 2 edits in trunk/WebCore
[GIO] Invoke cleanupGioOperation before calling didFail to avoid crashes
https://bugs.webkit.org/show_bug.cgi?id=23116
The ResourceHandle becomes invalid (e.g. got destructed) from within
the invocation of didFail. Avoid this by cleaning up everything before
calling didFail and simply return afterwards.
This is happening with many tests from dom/html/level2/html e.g.
LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
- 6:57 AM Changeset in webkit [39855] by
-
- 2 edits in trunk/WebKit/gtk
2009-01-13 Alexander V. Butenko <alex@digiqube.com>
Reviewed by Holger Freyther.
Fix crash on WebView dispose stage.
Add null checks to webkit_web_view_set_scroll_adjustments and
webkit_web_view_get_accessible as they get called from within
the dispose.
- webkit/webkitwebview.cpp:
- 6:51 AM Changeset in webkit [39854] by
-
- 7 edits1 move2 adds2 deletes in trunk/WebCore
2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
Change how themes adjust mediaControls.css to match html4/quicks.css
Instead of providing the full style sheet, the themes provide extra
overrides to the default style defined in UserAgentStyleSheetsData.
Also, merge WebKitResources.qrc and WebCoreResources.qrc to speed up
build time for the Qt port.
- 12:11 AM Changeset in webkit [39853] by
-
- 2 edits in trunk/WebKit/win
Build fix.
- WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString):
Jan 12, 2009:
- 11:54 PM Changeset in webkit [39852] by
-
- 6 edits in trunk/WebKitTools
Use the modern spelling of WebKit.
- Scripts/find-extra-includes:
- Scripts/report-include-statistics:
- Scripts/run-webkit-app:
- Scripts/svn-unapply:
- Scripts/update-webkit:
- 8:51 PM Changeset in webkit [39851] by
-
- 38 edits in trunk
2009-01-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Make the JSImmediate interface private.
All manipulation of JS values should be through the JSValuePtr class, not by using JSImmediate
directly. The key missing methods on JSValuePtr are:
- isCell() - check for values that are JSCell*s, and as such where asCell() may be used.
- isInt32Fast() getInt32Fast() - fast check/access for integer immediates.
- isUInt32Fast() getUInt32Fast() - ditto for unsigned integer immediates.
The JIT is allowed full access to JSImmediate, since it needs to be able to directly
manipulate JSValuePtrs. The Interpreter is provided access to perform operations directly
on JSValuePtrs through the new JSFastMath interface.
No performance impact.
- API/JSCallbackObjectFunctions.h: (JSC::::toNumber):
- API/JSValueRef.cpp: (JSValueIsEqual): (JSValueIsStrictEqual):
- JavaScriptCore.exp:
- bytecode/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):
- bytecompiler/BytecodeGenerator.cpp: (JSC::keyForImmediateSwitch):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue): (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
- interpreter/Interpreter.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAdd): (JSC::jsIsObjectType): (JSC::cachePrototypeChain): (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_add): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_mul): (JSC::Interpreter::cti_op_get_by_val): (JSC::Interpreter::cti_op_get_by_val_byte_array): (JSC::Interpreter::cti_op_sub): (JSC::Interpreter::cti_op_put_by_val): (JSC::Interpreter::cti_op_put_by_val_array): (JSC::Interpreter::cti_op_put_by_val_byte_array): (JSC::Interpreter::cti_op_negate): (JSC::Interpreter::cti_op_div): (JSC::Interpreter::cti_op_eq): (JSC::Interpreter::cti_op_lshift): (JSC::Interpreter::cti_op_bitand): (JSC::Interpreter::cti_op_rshift): (JSC::Interpreter::cti_op_bitnot): (JSC::Interpreter::cti_op_neq): (JSC::Interpreter::cti_op_urshift): (JSC::Interpreter::cti_op_call_eval): (JSC::Interpreter::cti_op_throw): (JSC::Interpreter::cti_op_is_undefined): (JSC::Interpreter::cti_op_stricteq): (JSC::Interpreter::cti_op_nstricteq): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_vm_throw):
- interpreter/Interpreter.h: (JSC::Interpreter::isJSArray): (JSC::Interpreter::isJSString): (JSC::Interpreter::isJSByteArray):
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileMainPass):
- jit/JIT.h: (JSC::JIT::isStrictEqCaseHandledInJITCode):
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_rshift): (JSC::JIT::compileFastArith_op_bitand): (JSC::JIT::compileFastArith_op_mod):
- jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::compileOpCall):
- jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateInt): (JSC::JIT::isOperandConstantImmediateInt):
- parser/Nodes.cpp: (JSC::processClauseList):
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
- runtime/BooleanPrototype.cpp: (JSC::booleanProtoFuncValueOf):
- runtime/Collector.cpp: (JSC::Heap::protect): (JSC::Heap::unprotect): (JSC::Heap::heap):
- runtime/JSByteArray.cpp: (JSC::JSByteArray::getOwnPropertySlot):
- runtime/JSByteArray.h: (JSC::JSByteArray::getIndex):
- runtime/JSCell.cpp:
- runtime/JSCell.h: (JSC::JSValuePtr::isNumberCell): (JSC::JSValuePtr::asCell): (JSC::JSValuePtr::isNumber):
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
- runtime/JSImmediate.h: (JSC::js0): (JSC::jsImpossibleValue): (JSC::JSValuePtr::toInt32): (JSC::JSValuePtr::toUInt32): (JSC::JSValuePtr::isCell): (JSC::JSValuePtr::isInt32Fast): (JSC::JSValuePtr::getInt32Fast): (JSC::JSValuePtr::isUInt32Fast): (JSC::JSValuePtr::getUInt32Fast): (JSC::JSValuePtr::makeInt32Fast): (JSC::JSValuePtr::areBothInt32Fast): (JSC::JSFastMath::canDoFastBitwiseOperations): (JSC::JSFastMath::equal): (JSC::JSFastMath::notEqual): (JSC::JSFastMath::andImmediateNumbers): (JSC::JSFastMath::xorImmediateNumbers): (JSC::JSFastMath::orImmediateNumbers): (JSC::JSFastMath::canDoFastRshift): (JSC::JSFastMath::canDoFastUrshift): (JSC::JSFastMath::rightShiftImmediateNumbers): (JSC::JSFastMath::canDoFastAdditiveOperations): (JSC::JSFastMath::addImmediateNumbers): (JSC::JSFastMath::subImmediateNumbers): (JSC::JSFastMath::incImmediateNumber): (JSC::JSFastMath::decImmediateNumber):
- runtime/JSNumberCell.h: (JSC::JSValuePtr::asNumberCell): (JSC::jsNumber): (JSC::JSValuePtr::uncheckedGetNumber): (JSC::JSNumberCell::toInt32): (JSC::JSNumberCell::toUInt32): (JSC::JSValuePtr::toJSNumber): (JSC::JSValuePtr::getNumber): (JSC::JSValuePtr::numberToInt32): (JSC::JSValuePtr::numberToUInt32):
- runtime/JSObject.h: (JSC::JSValuePtr::isObject): (JSC::JSValuePtr::get): (JSC::JSValuePtr::put):
- runtime/JSValue.cpp: (JSC::JSValuePtr::toInteger): (JSC::JSValuePtr::toIntegerPreserveNaN):
- runtime/JSValue.h:
- runtime/Operations.cpp: (JSC::JSValuePtr::equalSlowCase): (JSC::JSValuePtr::strictEqualSlowCase):
- runtime/Operations.h: (JSC::JSValuePtr::equal): (JSC::JSValuePtr::equalSlowCaseInline): (JSC::JSValuePtr::strictEqual): (JSC::JSValuePtr::strictEqualSlowCaseInline):
- runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt):
- runtime/Structure.cpp: (JSC::Structure::createCachedPrototypeChain):
WebCore:
2009-01-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Deprecate JSValuePtr::getNumber() - two ways to get a number should be enough.
- bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
WebKit/mac:
2009-01-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Deprecate JSValuePtr::getNumber() - two ways to get a number should be enough.
- WebView/WebView.mm: (aeDescFromJSValue):
- 6:33 PM Changeset in webkit [39850] by
-
- 2 edits in trunk/WebKit/win
2009-01-12 Brady Eidson <beidson@apple.com>
Reviewed by NOBODY (OOPS!).
<rdar://problem/6490446> - Crash when going back to a cached page
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::savePlatformDataToCachedPage): ENABLE(CFNETWORK) needed to be USE(CFNETWORK)
- 5:09 PM Changeset in webkit [39849] by
-
- 4 edits in trunk/WebCore
I added a common getElapsedTime() function to AnimationBase which uses a combination of
the techniques from KeyframeAnimation and AnimationBase to compute elapsedTime in all
states.
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::progress): (WebCore::AnimationBase::getElapsedTime):
- page/animation/AnimationBase.h:
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate):
- 4:22 PM Changeset in webkit [39848] by
-
- 3 edits2 adds in trunk
Correct scrolldelay units (s -> ms)
- 4:20 PM Changeset in webkit [39847] by
-
- 2 edits in trunk/WebCore
2009-01-12 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
In RenderBox::repaintLayerRectsForImage(), the repaint rect does not have
to be computed in absolute coordintes. Instead, we compute a repaintRect
relative to the RenderObject, which can repaint itself.
- rendering/RenderBox.cpp: (WebCore::RenderBox::repaintLayerRectsForImage):
- 4:15 PM Changeset in webkit [39846] by
-
- 2 edits in trunk/WebCore
2009-01-12 David Hyatt <hyatt@apple.com>
Apply the same idea as the previous fix but for matched declarations.
Reviewed by Dan Bernstein
- css/CSSStyleSelector.h:
- 4:15 PM Changeset in webkit [39845] by
-
- 17 edits in trunk
WebCore:
2009-01-12 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6468274> - Track Non-get requests in global history
- WebCore.base.exp:
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
- history/HistoryItem.h: (WebCore::HistoryItem::lastVisitWasHTTPNonGet): (WebCore::HistoryItem::setLastVisitWasHTTPNonGet):
WebKit/mac:
2009-01-12 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6468274> - Track Non-get requests in global history
- History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
- History/WebHistoryInternal.h:
- History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem _lastVisitWasHTTPNonGet]):
- History/WebHistoryItemPrivate.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Only pass the method through if it was an HTTP load
WebKit/win:
2009-01-12 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6468274> - Track Non-get requests in global history
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):
- WebHistory.cpp: (WebHistory::addItem):
- WebHistory.h:
- Interfaces/IWebHistoryItemPrivate.idl:
- WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::dictionaryRepresentation): (WebHistoryItem::lastVisitWasHTTPNonGet): (WebHistoryItem::setLastVisitWasHTTPNonGet):
- WebHistoryItem.h:
- 3:49 PM Changeset in webkit [39844] by
-
- 2 edits in trunk/WebKit/wx
wx build fix. JSValue* -> JSValuePtr.
- 3:47 PM Changeset in webkit [39843] by
-
- 5 edits in trunk/WebCore
!ENABLE(SVG_FONTS) build fix. Move defaultUnitsPerEm into a non-SVG header so it can be used by all builds.
- 3:41 PM Changeset in webkit [39842] by
-
- 2 edits in trunk/WebCore
wx build typo fix.
- 3:39 PM Changeset in webkit [39841] by
-
- 2 edits in trunk/JavaScriptCore
Since platform date time functions have moved to JSC, now the wx port JSC needs to depend on wx.
- 3:18 PM Changeset in webkit [39840] by
-
- 5 edits in trunk/WebKit/mac
2009-01-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Move marshalling into NetscapePluginInstanceProxy.
Add support for marshallin strings.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::marshalValue):
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 3:01 PM Changeset in webkit [39839] by
-
- 2 edits in trunk/WebCore
2009-01-12 David Hyatt <hyatt@apple.com>
Make sure the set of matched rules has a reserved capacity of 32. This prevents remalloc thrash as
elements are matched, since the Vector is shrinking and growing over and over. 1% PLT speedup.
Reviewed by Oliver Hunt
- css/CSSStyleSelector.h:
- 2:37 PM Changeset in webkit [39838] by
-
- 2 edits in trunk/WebCore
2009-01-12 David Hyatt <hyatt@apple.com>
Optimize Element::attributeChanged to just check if accessibility is enabled up front before looking at the
two accessibility-related attributes. This avoids the rest of the code for all attributes on the PLT.
Tiny speedup.
Reviewed by Oliver Hunt
- dom/Element.cpp: (WebCore::Element::attributeChanged):
- 2:34 PM Changeset in webkit [39837] by
-
- 2 edits in trunk/WebCore
2009-01-12 David Hyatt <hyatt@apple.com>
Optimize the retrieval of line height. If the document is not using any first-line rules, just immediately
default to the normal case. Tiny speedup on PLT.
Reviewed by Oliver Hunt
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::lineHeight):
- 2:25 PM Changeset in webkit [39836] by
-
- 5 edits in trunk/WebKit/mac
2009-01-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement WKPCInvoke.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::idForObject): (WebKit::NetscapePluginInstanceProxy::invoke):
- Plugins/Hosted/WebKitPluginClient.defs:
- 2:15 PM QtWebKitTodo edited by
- (diff)
- 2:15 PM Changeset in webkit [39835] by
-
- 2 edits in trunk/WebCore
2009-01-12 David Hyatt <hyatt@apple.com>
Fix 0.6% regression in PLT. Make sure not to waste time updating NSScrollView's can blit on scroll state
in the ScrollView constructor, since this is always going to be properly updated by FrameView anyway.
Reviewed by Oliver Hunt
- platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView):
- 1:42 PM Changeset in webkit [39834] by
-
- 12 edits in trunk/WebCore
2009-01-12 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Merge layoutDelta into LayoutState. This requires that we
push even when layoutState is disabled, so that layoutDelta
can still be stored.
- 1:38 PM Changeset in webkit [39833] by
-
- 5 edits in trunk/WebKit/mac
2009-01-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Move marshalling code to NetscapePluginInstanceProxy. Add support for marshalling JS objects.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::marshalValue):
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 1:31 PM Changeset in webkit [39832] by
-
- 2 edits in trunk/WebCore
2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
Reviewed by Holger Freyther.
[Qt] Build fix after turning the fontCache to a singleton
https://bugs.webkit.org/show_bug.cgi?id=23253
Add a stub implementation for WebCore::fontCache() and FontCache::FontCache().
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::fontCache): (WebCore::FontCache::FontCache):
- 1:07 PM Changeset in webkit [39831] by
-
- 5 edits2 adds in trunk
2009-01-12 Eric Roman <eroman@chromium.org>
Reviewed by Darin Adler.
Fix some bugs with Selection::appendTrailingWhitespace().
https://bugs.webkit.org/show_bug.cgi?id=23232
Test: editing/selection/doubleclick-whitespace-crash.html
- editing/Selection.cpp: (WebCore::makeSearchRange): (WebCore::Selection::appendTrailingWhitespace):
2009-01-12 Eric Roman <eroman@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23232
- editing/selection/doubleclick-whitespace-crash-expected.txt: Added.
- editing/selection/doubleclick-whitespace-crash.html: Added.
- editing/selection/doubleclick-whitespace-expected.txt:
- editing/selection/doubleclick-whitespace.html:
- 12:26 PM Changeset in webkit [39830] by
-
- 1 edit5 adds in trunk/WebCore
2009-01-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add the first pieces of platform/graphics/chromium
https://bugs.webkit.org/show_bug.cgi?id=23257
- platform/graphics/chromium/ColorChromium.cpp: Added. (WebCore::focusRingColor):
- platform/graphics/chromium/FontCacheChromiumWin.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::isStringASCII): (WebCore::LookupAltName): (WebCore::FontCodepage::): (WebCore::FontCodepage::if): (WebCore::createFontIndirectAndGetWinName): (WebCore::fontContainsCharacter): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::alternateFamilyName): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::toGDIFontWeight): (WebCore::FontCache::getGenericFontForScript): (WebCore::FillLogFont): (WebCore::FontCache::fontExists): (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): (WebCore::traitsInFamilyEnumProc): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/FontCacheLinux.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::alternateFamilyName): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData): (WebCore::FontCache::getGenericFontForScript):
- platform/graphics/chromium/FontChromiumWin.cpp: Added. (WebCore::windowsCanHandleTextDrawing): (WebCore::skiaDrawText): (WebCore::PaintSkiaText): (WebCore::Font::drawGlyphs): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- 11:25 AM Changeset in webkit [39829] by
-
- 3 edits6 adds in trunk/WebCore
2009-01-12 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23254
Upstream page/chromium/
- page/chromium/AXObjectCacheChromium.cpp: Added. (WebCore::AXObjectCache::detachWrapper): (WebCore::AXObjectCache::attachWrapper): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postNotificationToElement): (WebCore::AXObjectCache::handleFocusedUIElementChanged):
- page/chromium/AccessibilityObjectChromium.cpp:
- page/chromium/AccessibilityObjectWrapper.h:
- page/chromium/ChromeClientChromium.h: Added.
- page/chromium/DragControllerChromium.cpp: Added. (WebCore::DragController::dragOperation): (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::maxDragImageSize): (WebCore::DragController::cleanupAfterSystemDrag):
- page/chromium/EventHandlerChromium.cpp: Added. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::createDraggingClipboard): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::accessKeyModifiers):
- page/chromium/FrameChromium.cpp: Added. (WebCore::computePageRectsForFrame): (WebCore::Frame::dragImageForSelection):
- page/chromium/FrameChromium.h: Added.
- 11:10 AM Changeset in webkit [39828] by
-
- 4 edits in trunk/WebCore
2008-01-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22936
Fix uninitialized memory read error, reported by Purify.
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): Added initializer for
m_unitsPerEm using cDefaultUnitsPerEm constant.
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::unitsPerEm): Replaced literal value with
the constant.
- svg/SVGFontFaceElement.h: Added cDefaultUnitsPerEm constant.
- 7:50 AM Changeset in webkit [39827] by
-
- 2 edits in trunk/WebCore
Do not set fixedLayoutSize for anything other than the mainframe during
the transition as this is a page level state like the viewportSize.
- 5:03 AM Changeset in webkit [39826] by
-
- 2 edits in trunk/WebKit/qt
2009-01-12 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
[Qt] Ensure that we're always notified of navigation actions for local anchors
FrameLoader::checkNavigationPolicy() does not notify us if the request has
been checked before (which happens for local anchors), but in the case of
our clients not accepting the navigation request we do want to be notified
again later on, so we clear the lastCheckedRequest flag.
- 4:51 AM Changeset in webkit [39825] by
-
- 2 edits in trunk/WebKit/qt
2009-01-12 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Tor Arne Vestbø.
Build fix: use qobject_cast which does not rely on RTTI. This fixes the
unit test when building it with a version of Qt (e.g. Qt/Embedded)
configured without RTTI.
- tests/qwebframe/tst_qwebframe.cpp:
- 3:10 AM Changeset in webkit [39824] by
-
- 2 edits in trunk/LayoutTests
Update test results.
- fast/dom/Window/window-properties-expected.txt: Remove appcache dynamic entries methods.
- 2:46 AM Changeset in webkit [39823] by
-
- 18 edits in trunk
WebCore:
2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
Reviewed by Darin Adler.
Bug 22861: Turn the FontCache into a singleton
https://bugs.webkit.org/show_bug.cgi?id=22861
- Added fontCache() to get the global FontCache.
- Made all the methods in FontCache instance method.
- Changed FontCache:: to fontCache()-> in WebCore.
- WebCore.base.exp: Now export fontCache().
- css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::CSSFontSelector): (WebCore::CSSFontSelector::~CSSFontSelector): (WebCore::CSSFontSelector::addFontFaceRule): (WebCore::fontDataForGenericFamily):
- platform/graphics/Font.cpp: (WebCore::Font::glyphDataForCharacter):
- platform/graphics/FontCache.cpp: (WebCore::fontCache): (WebCore::FontCache::FontCache):
- platform/graphics/FontCache.h:
- platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters): (WebCore::FontFallbackList::setPlatformFont):
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::~SimpleFontData):
- platform/graphics/mac/FontCacheMac.mm: (WebCore::fontCacheATSNotificationCallback):
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::smallCapsFontData):
- platform/graphics/win/FontCacheWin.cpp: (WebCore::getCJKCodePageMasks):
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::containsCharacters):
WebKit/mac:
2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
Reviewed by Darin Adler.
Bug 22861: Turn the FontCache into a singleton
https://bugs.webkit.org/show_bug.cgi?id=22861
- Misc/WebCoreStatistics.mm: (+[WebCoreStatistics cachedFontDataCount]): (+[WebCoreStatistics cachedFontDataInactiveCount]): (+[WebCoreStatistics purgeInactiveFontData]): Redirected all the static calls to the global FontCache instance.
WebKit/win:
2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
Reviewed by Darin Adler.
Bug 22861: Turn the FontCache into a singleton
https://bugs.webkit.org/show_bug.cgi?id=22861
- WebCoreStatistics.cpp: (WebCoreStatistics::cachedFontDataCount): (WebCoreStatistics::cachedFontDataInactiveCount): (WebCoreStatistics::purgeInactiveFontData): Redirected all the static calls to the global FontCache instance.
- 1:58 AM QtWebKitJournal edited by
- (diff)
- 1:41 AM Changeset in webkit [39822] by
-
- 2 edits in trunk/WebKit/qt
2009-01-12 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
When the QWebView is disabled context menus implemented in JavaScript should not pop up.
Just like in QWidget::event() we have to check for the disabled state and
ignore context menu events.
- 1:36 AM Changeset in webkit [39821] by
-
- 2 edits in trunk/WebKit/qt
2009-01-12 Simon Hausmann <simon.hausmann@nokia.com
Reviewed by Tor Arne Vestbø.
Fix QWebView appearance when showed uninitialized without page.
Only set WA_OpaquePaintEvent if we have a page set that will actually
paint the entire contents, otherwise the optimization does not apply
as we do not have a paintEvent() implementation and Qt has to fill the
view with its default background instead.
- 1:12 AM Changeset in webkit [39820] by
-
- 2 edits in trunk/WebKit/qt
2009-01-11 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Tor Arne Vestbø.
Do not create a QVariant from QObject* directly, use the
template-specialized function.
- tests/qwebframe/tst_qwebframe.cpp: (MyQObject::myOverloadedSlot):
Jan 11, 2009:
- 11:48 PM Changeset in webkit [39819] by
-
- 10 edits3 copies4 adds in trunk
WebCore:
2009-01-11 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
https://bugs.webkit.org/show_bug.cgi?id=23247
Also fix problems where partially parsed paths will still have an effect
rather than failing parsing and being ignored.
Test: dom/path-segments.html
- platform/graphics/Path.h: (WebCore::Path::swap): Added.
- svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): Removed unneeded special case for empty string. (WebCore::PathBuilder::build): Changed to not modify the path if parsing fails. (WebCore::SVGPathSegListBuilder::build): Changed to not modify the segment list if parsing fails. (WebCore::SVGPathSegListBuilder::svgMoveTo): Put the path element into the vector, not directly into the segment list. (WebCore::SVGPathSegListBuilder::svgLineTo): Ditto. (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): Ditto. (WebCore::SVGPathSegListBuilder::svgLineToVertical): Ditto. (WebCore::SVGPathSegListBuilder::svgCurveToCubic): Ditto. (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): Ditto. (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): Ditto. (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): Ditto. (WebCore::SVGPathSegListBuilder::svgArcTo): Ditto. (WebCore::SVGPathSegListBuilder::svgClosePath): Ditto.
- svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth): Set y2 to y2, not to y.
WebKitTools:
2009-01-11 Darin Adler <Darin Adler>
- Scripts/make-js-test-wrappers: Updated so it won't overwrite tests in the svg/dom directory that aren't using standard wrappers.
LayoutTests:
2009-01-11 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
https://bugs.webkit.org/show_bug.cgi?id=23247
Also fix problems where partially parsed paths will still have an effect
rather than failing parsing and being ignored.
Renamed the path-parser.html test to fuzz-path-parser.html, since it's a fuzz test,
to make room for a non-fuzz test of the path parser.
- platform/mac/svg/custom/path-bad-data-expected.txt: Updated results, since the old ones were based on incorrect path parsing behavior.
- svg/dom/fuzz-path-parser-expected.txt: Copied from svg/dom/path-parser-expected.txt. Also updated because the parser no longer tolerates extra characters at the end of the string, which it was doing by accident.
- svg/dom/fuzz-path-parser.html: Copied from svg/dom/path-parser.html.
- svg/dom/path-parser-expected.txt: Replaced fuzz test results with new test results.
- svg/dom/path-parser.html: Replaced fuzz test with a new test.
- svg/dom/path-segments-expected.txt: Added.
- svg/dom/path-segments.html: Added.
- svg/dom/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
- svg/dom/resources/path-parser.js: Added. Mostly, this test shows that we are processing the path while parsing it, which is a bug. This test would be much more useful if that was fixed. But it also shows that we were incorrectly tolerating extra characters after the path, which is now fixed.
- svg/dom/resources/path-segments.js: Added.
- 11:44 PM Changeset in webkit [39818] by
-
- 41 edits in trunk/WebCore
2009-01-11 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 23102: turn on unused parameter warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=23102
Fourth step: Remove arguments entirely in the many cases where they are not
needed at all. This step is a little less mechanical than the earlier ones.
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating the regular expression, since we already specify a-zA-Z in our expression.
- dom/Document.cpp: (WebCore::Document::databaseThread): Don't pass in the document when creating a DatabaseThread.
- dom/Element.cpp: (WebCore::Element::createRareData): Don't pass the element when creating an ElementRareData. (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle. (WebCore::Element::recalcStyle): Ditto.
- dom/ElementRareData.h: Remove the unused Element* from the constructor and the resetComputedStyle function.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent. (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument. (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
- dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.
- editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function. (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused start and end arguments. (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start and end to pushDownTextDecorationStyleAroundNode.
- editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the unused start and end arguments from pushDownTextDecorationStyleAroundNode.
- editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.
- html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): Removed unused Document* argument. (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.
- html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.
- page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.
- page/DragController.cpp: (WebCore::DragController::dragIsMove): Removed unused DragData argument. (WebCore::DragController::performDrag): Call concludeEditDrag rather than concludeDrag. (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove. (WebCore::DragController::concludeEditDrag): Renamed to make it clear this should only be called for edit drags. Removed the action mask argument. Also changed dragIsMove call sites to not pass dragData.
- page/DragController.h: Updated for above changes and tweaked comment format.
- page/Frame.cpp: (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive when creating regular expressions for clarity. Call match instead of search, since both do the same thing except for with negative start offsets, and none used here are negative. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
- page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.
- page/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetHeadingLevel): Removed unused object argument. (AXAttributedStringAppendText): Ditto. (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.
- page/mac/FrameMac.mm: (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive when creating regular expressions for clarity. Call match instead of search, since both do the same thing except for with negative start offsets, and none used here are negative. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
- platform/graphics/SegmentedFontData.cpp: (WebCore::SegmentedFontData::containsCharacter): Added. (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters instead of just the first one, using containsCharacter.
- platform/graphics/SegmentedFontData.h: Made more members private. Added containsCharacter function member.
- platform/mac/DragImageMac.mm: (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of DragImageRef for clarity, since this is platform-specific code. (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused variable warning. (WebCore::scaleDragImage): Ditto. (WebCore::dissolveDragImageToFraction): Ditto. (WebCore::createDragImageFromImage): Ditto. (WebCore::createDragImageIconForCachedImage): Ditto.
- platform/mac/WebFontCache.mm: (acceptableChoice): Removed the unused weight-related arguments. (betterChoice): Ditto. (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.
- platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory because we'd rather get a link error rather than a runtime error if we use it for anything, and right now it's not used.
- platform/text/RegularExpression.cpp: Removed unused private data, including pattern, lastMatchString, lastMatchOffsets, lastMatchCount, and lastMatchPos. Made the RegularExpression::Private::regex be private and use an accessor function to get at it. (WebCore::RegularExpression::RegularExpression): Removed the const char* version of the constructor because it's not any more efficient. Changed the boolean constructor argument to use TextCaseSensitivity instead to make it less likely we'll use it wrong. (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr, just use plain old assignment on it. The only reason we do this instead of using the compiler generated assignment operator is that we want the Private structure to be internal to the .cpp file. (WebCore::RegularExpression::match): Added a null check so we won't crash if we fail to compile the regular expression. Removed the code to handle multiple match strings, since that was unused.
- platform/text/RegularExpression.h: Changed the case sensitivity argument to use TextCaseSensitivity and not have a default value. Removed the default constructor, and the pattern, match, and pos functions.
- platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from Page.h, because we should eventually use it in all the places where we have an argument to control case sensitivity, starting with the functions in this class.
- platform/text/mac/ShapeArabic.c: (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though this is code borrowed from ICU, this seems like a simple safe change to make. (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.
- rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath): Removed the unused style argument. Also removed the type check. The argument already has the correct type, so it's not helpful to upcast it and then check its type again, unless we have some reason to believe the type is not reliable. And we don't.
- rendering/RenderPath.h: Removed the RenderStyle* argument to the constructor. Also removed the explicit declaration of the destructor. It's not helpful or needed.
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to make it clear that just returning an empty rect is not a good implementation. Removed the argument names to get rid of the warning.
- rendering/RenderTreeAsText.cpp: (WebCore::printBorderStyle): Removed the unused RenderObject argument. (WebCore::operator<<): Updated for the change to printBorderStyle function.
- storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
- storage/DatabaseThread.h: Ditto.
- storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
- storage/LocalStorage.h: Ditto.
- svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception code location to dispatchGenericEvent.
- svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::dispatchEvent): Ditto.
- svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h. (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to the RenderPath constructor.
- svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.
- xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource): Removed unused sourceNode argument. (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.
- 11:34 PM Changeset in webkit [39817] by
-
- 5 edits in trunk/JavaScriptCore
2009-01-11 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Add initializeThreading to key places in JS API to ensure that
UString is properly initialized.
- API/JSContextRef.cpp: (JSContextGroupCreate): (JSGlobalContextCreate):
- API/JSObjectRef.cpp: (JSClassCreate):
- API/JSStringRef.cpp: (JSStringCreateWithCharacters): (JSStringCreateWithUTF8CString):
- API/JSStringRefCF.cpp: (JSStringCreateWithCFString):
- 11:21 PM Changeset in webkit [39816] by
-
- 4 edits1 move in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23165
Disable application cache dynamic entries support.
- 7:19 PM Changeset in webkit [39815] by
-
- 5 edits in trunk/JavaScriptCore
2009-01-11 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Separate out BaseString information from UString::Rep and make all baseString access go through
a member function, so that it may be used for something else (in the future) in the BaseString
case.
- runtime/SmallStrings.cpp: (JSC::SmallStringsStorage::rep): (JSC::SmallStringsStorage::SmallStringsStorage): (JSC::SmallStrings::SmallStrings): (JSC::SmallStrings::mark): Adjust to account for the changes in UString and put the UString in place in SmallStringsStorage to aid in locality of reference among the UChar[] and UString::Rep's.
- runtime/SmallStrings.h:
- runtime/UString.cpp: (JSC::initializeStaticBaseString): (JSC::initializeUString): (JSC::UString::Rep::create): (JSC::UString::Rep::destroy): (JSC::UString::Rep::checkConsistency): (JSC::expandCapacity): (JSC::UString::expandPreCapacity): (JSC::concatenate): (JSC::UString::append): (JSC::UString::operator=):
- runtime/UString.h: (JSC::UString::Rep::baseIsSelf): (JSC::UString::Rep::setBaseString): (JSC::UString::Rep::baseString): (JSC::UString::Rep::): (JSC::UString::Rep::null): (JSC::UString::Rep::empty): (JSC::UString::Rep::data): (JSC::UString::cost): Separate out the items out used by base strings from those used in Rep's that only point to base strings. (This potentially saves 24 bytes per Rep.)
- 7:17 PM Changeset in webkit [39814] by
-
- 2 edits in trunk/LayoutTests
2009-01-11 Darin Adler <Darin Adler>
- fast/frames/frame-deep-nested-resize-expected.txt: This time for sure.
- 6:07 PM Changeset in webkit [39813] by
-
- 2 edits in trunk/LayoutTests
2009-01-11 Darin Adler <Darin Adler>
Fix failure of new test seen on buildbots.
- fast/frames/frame-deep-nested-resize-expected.txt: Updated newlines to match what DumpRenderTree generates on Mac. I believe Adam generated his results under Qt DumpRenderTree. If so, then the Qt version will need to change to match the Mac version, since all the expected results were generated on Mac.
- 4:54 PM Changeset in webkit [39812] by
-
- 3 edits2 adds in trunk
Correct coordinate transformation for deeply nested frames on resizing. This
fixes https://bugs.webkit.org/show_bug.cgi?id=20766.
- 3:55 PM Changeset in webkit [39811] by
-
- 2 edits in trunk/WebCore
Tiger build fix. The connection parameter is still used on Tiger in this method.
- platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
- 2:01 PM Changeset in webkit [39810] by
-
- 14 edits in trunk/WebCore
2009-01-11 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23102: turn on unused parameter warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=23102
Third step: Deal with cases of arguments used only in assertions.
- dom/MessagePort.cpp: (WebCore::MessagePortCloseEventTask::performTask): Use ASSERT_UNUSED.
- dom/Worker.cpp: (WebCore::Worker::notifyFinished): Ditto.
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished): Ditto.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::verifySchemaVersion): Ditto.
- loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveData): Since loader and size are only used when logging, use UNUSED_PARAM when logging is disabled.
- platform/mac/WidgetMac.mm: (WebCore::Widget::beforeMouseDown): Use ASSERT_UNUSED.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Use the argument since it's probably a tiny bit more efficient and gets rid of the unused argument warning.
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::createInlineBox): Use ASSERT_UNUSED.
- rendering/RenderObject.cpp: (WebCore::RenderObject::createInlineBox): Ditto.
- rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineBox): Use UNUSED_PARAM. I couldn't use ASSERT_UNUSED because it's a single assertion, but it's the only use for two different arguments.
- rendering/RenderText.cpp: (WebCore::RenderText::createInlineBox): Use ASSERT_UNUSED.
- rendering/RenderThemeMac.mm: (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): Ditto.
- 1:58 PM Changeset in webkit [39809] by
-
- 5 edits in trunk/JavaScriptCore
2009-01-11 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23239: improve handling of unused arguments in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=23239
- runtime/DatePrototype.cpp: Moved LocaleDateTimeFormat enum outside #if so we can use this on all platforms. Changed valueOf to share the same function with getTime, since the contents of the two are identical. Removed a FIXME since the idea isn't really specific enough or helpful enough to need to sit here in the source code. (JSC::formatLocaleDate): Changed the Mac version of this function to take the same arguments as the non-Mac version so the caller doesn't have to special-case the two platforms. Also made the formatString array be const; before the characters were, but the array was a modifiable global variable. (JSC::dateProtoFuncToLocaleString): Changed to call the new unified version of formatLocaleDate and remove the ifdef. (JSC::dateProtoFuncToLocaleDateString): Ditto. (JSC::dateProtoFuncToLocaleTimeString): Ditto.
- runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::toObject): Use the new ASSERT_UNUSED instead of the old UNUSED_PARAM.
- runtime/RegExp.cpp: (JSC::RegExp::RegExp): Changed to only use UNUSED_PARAM when the parameter is actually unused.
- wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease): Changed to only use UNUSED_PARAM when the parameter is actually unused. (TCMalloc_SystemCommit): Changed to omit the argument names instead of using UNUSED_PARAM.
- 1:42 PM Changeset in webkit [39808] by
-
- 4 edits in trunk/LayoutTests/platform/mac
Set the svn:mime-type property of recently-added PNG files to image/png.
- 1:22 PM Changeset in webkit [39807] by
-
- 5 edits4 adds in trunk
2009-01-11 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt
Fix CanvasRenderingContext2D::transform to do a pre-multiply,
rather than a post-multiply into m_transform. This bug did not affect
drawing, but did cause m_transform to be incorrect, which impacted
willDraw(), and isPointInPath.
Test: fast/canvas/canvas-incremental-repaint-2.html
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::transform):
- 12:05 PM Changeset in webkit [39806] by
-
- 9 edits in trunk/WebCore
2009-01-11 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23102: turn on unused parameter warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=23102
Second step: Fix simple Objective-C cases where we need to use UNUSED_PARAM.
That's because you can't omit an argument name in Objective-C methods.
- bindings/objc/DOMObject.mm: (-[DOMObject copyWithZone:]): Use UNUSED_PARAM. Also rename argument to include the word "unused" so we don't just start using it without removing the macro.
- bindings/objc/WebScriptObject.mm: (+[WebUndefined allocWithZone:]): Ditto. (-[WebUndefined initWithCoder:]): Ditto. (-[WebUndefined encodeWithCoder:]): Ditto. (-[WebUndefined copyWithZone:]): Ditto.
- page/mac/WebDashboardRegion.m: (-[WebDashboardRegion copyWithZone:]): Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::mainThreadSetNeedsDisplay): Omit argument name. (-[WebCoreMovieObserver loadStateChanged:]): Use UNUSED_PARAM as above. (-[WebCoreMovieObserver rateChanged:]): Ditto. (-[WebCoreMovieObserver sizeChanged:]): Ditto. (-[WebCoreMovieObserver timeChanged:]): Ditto. (-[WebCoreMovieObserver didEnd:]): Ditto. (-[WebCoreMovieObserver newImageAvailable:]): Ditto.
- platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]): Ditto. (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): Ditto.
- platform/mac/SharedTimerMac.mm: (-[WebCorePowerNotifier didWake:]): Ditto.
- platform/mac/WebCoreKeyGenerator.m: (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): Ditto.
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Ditto. (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): Ditto. (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Ditto. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto. (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto. (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
- 11:59 AM Changeset in webkit [39805] by
-
- 12 edits5 deletes in trunk/WebCore
2009-01-11 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
Move platform dependent strokeContains back to RenderPath, Path and delete
unneeded Code in svg.
RenderPath clean-up for strokeContains
https://bugs.webkit.org/show_bug.cgi?id=22957
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/Path.h:
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::strokeContains):
- platform/graphics/cg/PathCG.cpp: (WebCore::Path::strokeContains):
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains):
- rendering/RenderPath.cpp: (WebCore::RenderPath::strokeContains):
- svg/graphics/cairo/RenderPathCairo.cpp: Removed.
- svg/graphics/cg/CgSupport.cpp: Removed.
- svg/graphics/cg/CgSupport.h: Removed.
- svg/graphics/cg/RenderPathCg.cpp: Removed.
- svg/graphics/cg/SVGPaintServerPatternCg.cpp:
- svg/graphics/cg/SVGResourceMaskerCg.mm:
- svg/graphics/qt/RenderPathQt.cpp: Removed.
- 11:59 AM Changeset in webkit [39804] by
-
- 2 edits in trunk
2009-01-11 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
Bump version to 1.1.0 since we are breaking ABI and adding new
major features.
- configure.ac:
- 11:57 AM Changeset in webkit [39803] by
-
- 2 edits in trunk/WebKit/gtk
2009-01-11 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
Use NULL instead of 0 when dealing with pointers, as agreed for
the coding style of the WebKit GTK port for its GTK+ specific
files.
- webkit/webkitwebview.cpp:
- 11:55 AM Changeset in webkit [39802] by
-
- 7 edits in trunk/WebKit/gtk
2009-01-11 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
Add padding to the class structs to avoid breaking ABI each time
we add stuff there.
- webkit/webkitnetworkrequest.h:
- webkit/webkitwebbackforwardlist.h:
- webkit/webkitwebhistoryitem.h:
- webkit/webkitwebnavigationaction.h:
- webkit/webkitwebpolicydecision.h:
- webkit/webkitwebview.h:
- 11:47 AM Changeset in webkit [39801] by
-
- 2 edits in trunk/WebCore
[GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase.lut.h
make distcheck pass by adding JSWorkerContextBase.lut.h to the
CLEANFILES that will be cleaned on a make distclean.
- 11:47 AM Changeset in webkit [39800] by
-
- 2 edits in trunk/JavaScriptCore
build fix
- 11:12 AM Changeset in webkit [39799] by
-
- 2 edits in trunk/JavaScriptCore
Bug 23128: get/put_by_val need to respecialise in the face of ByteArray
Reviewed by Darin Adler and Anders Carlsson
Restructure the code slightly, and add comments per Darin's suggestions
- 10:56 AM Changeset in webkit [39798] by
-
- 2 edits in trunk/JavaScriptCore
Fix exception check for string indexing
Reviewed by Anders Carlsson.
Whoops, I accidentally removed an exception check from fast the
fast path for string indexing when i originally landed the
byte array logic.
- 8:54 AM Changeset in webkit [39797] by
-
- 1 edit in trunk/WebKit/win/WebDownloadCFNet.cpp
attempt to fix win build
- 8:48 AM Changeset in webkit [39796] by
-
- 3 edits in trunk/JavaScriptCore
Bug 23128: get/put_by_val need to respecialise in the face of ByteArray
<https://bugs.webkit.org/show_bug.cgi?id=23128>
Reviewed by Anders Carlsson.
Fairly simple patch, add specialised versions of cti_op_get/put_by_val
that assume ByteArray, thus avoiding a few branches in the case of bytearray
manipulation.
No effect on SunSpider. 15% win on the original testcase.
- 3:06 AM Changeset in webkit [39795] by
-
- 3 edits in trunk/WebCore
2009-01-11 Zalan Bujtas <zbujtas@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=23235
Build fix for non-VIDEO builds.
- rendering/RenderTheme.cpp:
- rendering/RenderTheme.h:
- 3:03 AM Changeset in webkit [39794] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix Windows build.
- wtf/CurrentTime.cpp: Added a definition of msPerSecond (previously, this code was in DateMath.cpp, with constant definition in DateTime.h)
- 2:36 AM Changeset in webkit [39793] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-11 Alexey Proskuryakov <ap@webkit.org>
Try to fix Windows build.
- wtf/CurrentTime.cpp: Include <sys/types.h> and <sys/timeb.h>, as MSDN says to.
- 2:27 AM Changeset in webkit [39792] by
-
- 2 edits in trunk/WebCore
2009-01-11 Gabriella Toth <gtoth@inf.u-szeged.hu>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=19287
return value of malloc() is not checked in npruntime.cpp
Checking whether malloc can allocate memory or not. If it can't, CRASH macro is invoked
(like in fastMalloc).
- bridge/npruntime.cpp: (_NPN_GetStringIdentifier): (_NPN_GetIntIdentifier): (NPN_InitializeVariantWithStringCopy): (_NPN_CreateObject):
- 2:24 AM Changeset in webkit [39791] by
-
- 7 edits in trunk
2009-01-11 Glenn Wilson <gwilson@google.com>
Reviewed by Darin Adler.
Changes radio buttons so they can be 'checked' even if they
don't have the name attribute set.
Test: fast/html/select-unnamed-radio.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler):
- 1:48 AM Changeset in webkit [39790] by
-
- 3 edits in trunk/LayoutTests
2009-01-11 tony chang <tony@chromium.org>
Reviewed by Darin Adler.
Remove svn:eol-style native from some utf16 files so
windows-svn doesn't alter them on checkout.
- fast/xsl/xslt-enc16.xml: remove svn:eol-style
- fast/xsl/xslt-enc16to16.xml: remove svn:eol-style
- 1:44 AM Changeset in webkit [39789] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog date.
- 1:43 AM Changeset in webkit [39788] by
-
- 2 edits in trunk/WebKitTools
2009-01-11 Robert Blaut <webkit@blaut.biz>
Reviewed by Eric Seidel.
<https://bugs.webkit.org/show_bug.cgi?id=23134>
Update bisect-builds for Safari 3.2 to prevent crashes
- Scripts/bisect-builds: Added Safari 3.2 and the corresponding minimal revision, r37348.
- 1:40 AM Changeset in webkit [39787] by
-
- 3 edits4 adds in trunk/LayoutTests
2009-01-11 Jungshik Shin <jshin@chromium.org>
Reviewed by Alexey Proskuryakov
- Make fast/encoding/char-encoding test work with Chromium by replacing 'data:' with 'file:' pointing to resources/dummy.html (an empty file).
- Put old Mac encodings in a separate char-encoding-mac.html to make it possible to to skip it.
- Factor out common functions in char-encoding.html and char-encoding-mac.html and put them in char-encoding-utils.js
- fast/encoding/char-encoding-mac-expected.txt: Added.
- fast/encoding/char-encoding-mac.html: Added.
- fast/encoding/char-encoding.html:
- fast/encoding/resources/char-encoding-utils.js: Added.
- fast/encoding/resources/dummy.html: Added.
- 1:36 AM Changeset in webkit [39786] by
-
- 2 edits in trunk/WebCore
2008-12-18 Bernhard Rosenkraenzer <bero@arklinux.ch>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22205
Fix compatibility with bison 2.4, partially based on older patch by
Priit Laes <amd@store20.com>
- WebCore/css/CSSGrammar.y: Made compatible with bison 2.4
- 1:18 AM Changeset in webkit [39785] by
-
- 3 edits3 adds in trunk
2009-01-11 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=16001
Incorrect assumption that selection is always contiguous LTR.
Test: editing/selection/extend-selection-bidi.html
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::fillLineSelectionGap): Make this function not assume a contiguous visual LTR selection range.
- 12:14 AM Changeset in webkit [39784] by
-
- 57 edits3 adds4 deletes in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23207
Moved currentTime() to from WebCore to WTF.
- 12:06 AM Changeset in webkit [39783] by
-
- 3 edits in trunk/WebCore
2009-01-11 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
Make ScheduledAction (Timeout callback) able to execute the callback under WorkerContext.
Part of 'Timers in Workers' work.
https://bugs.webkit.org/show_bug.cgi?id=23223
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): new method that takes WorkerContext. (WebCore::ScheduledAction::executeFunctionInContext): Executes a JSFunction in proper context with 'this' object.
- bindings/js/ScheduledAction.h:
Jan 10, 2009:
- 11:45 PM Changeset in webkit [39782] by
-
- 7 edits in trunk/WebCore
2009-01-10 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23210
Make it easier for ports to define custom UI for media controls
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement): call theme()->styleSheetForMediaControls to get the media controller style sheet
- rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::hitTest): Added
- rendering/MediaControlElements.h: Updated
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function so control elements don't necessarily have to be rectangular
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::styleSheetForMediaControls): Added (WebCore::RenderTheme::hitTestMediaControlPart): Added
- rendering/RenderTheme.h: Updated
- 6:47 PM Changeset in webkit [39781] by
-
- 4 edits4 adds in trunk
2009-01-10 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
We need to disable LayoutState when an object has transforms,
because LayoutState is not transform-aware and therefore
repaint rects can be computed incorrectly.
Test: fast/repaint/transform-disable-layoutstate.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
- 4:05 PM Changeset in webkit [39780] by
-
- 7 edits5 deletes in trunk
Revert 39779.
- 3:16 PM Changeset in webkit [39779] by
-
- 7 edits5 adds in trunk
WebCore:
2009-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
We shouldn't update the document pointer of inactive windows. This
behavior differs slightly from Firefox, I'd argue that this behavior is
more correct (we both differ from IE). The HTML 5 spec is a bit in flux
on this point.
Test: http/tests/security/xss-inactive-closure.html
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::updateDocument):
- bindings/js/ScriptController.h:
LayoutTests:
2009-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Test that we don't do goofy things with the document pointer after
navigation.
- fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
- fast/dom/Window/dom-access-from-closure-window-expected.txt:
- http/tests/security/resources/childWithButton.html: Added.
- http/tests/security/resources/xss-inactive-closure-child-2.html: Added.
- http/tests/security/resources/xss-inactive-closure-child.html: Added.
- http/tests/security/xss-inactive-closure-expected.txt: Added.
- http/tests/security/xss-inactive-closure.html: Added.
- 2:03 PM Changeset in webkit [39778] by
-
- 2 edits in trunk/WebKit/mac
2009-01-10 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/5845089> REGRESSION (r30044): Mail custom stationery missing images
because of change to -[HTMLObjectElement data]
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Added a thread violation check because I saw this being done off the main thread while testing Mail, and it caused problems. Put all the one time initialization under a single guard to make things just a little faster other times, and to make it clearer which things are one-time. Added a call to the new patchMailRemoveAttributesMethod function. (-[WebView initWithFrame:frameName:groupName:]): Added a thread violation check here too, because I assumed it would be slightly better to have a public method name in the violation message. This calls commonInitialization later, so it will hit that one eventually. (objectElementDataAttribute): Added. Just returns the value of the "data" attribute. (recursivelyRemoveMailAttributes): Added. Patch to an internal Mail method that in turn patches a WebKit method and removes the patch again on the way out. (patchMailRemoveAttributesMethod): Added. On Leopard only, checks the Mail version, and then applies the patch that fixes this bug.
Jan 9, 2009:
- 7:46 PM Changeset in webkit [39777] by
-
- 3 edits1 delete in trunk/WebCore
[QT] Make SharedTimer use QBasicTimer
Kill the SharedTimerQt.h and the usage of signal and slots
by using QBasicTimer.
- 7:46 PM Changeset in webkit [39776] by
-
- 2 edits in trunk/WebKit/gtk
2009-01-09 Benjamin Otte <otte@gnome.org>
Reviewed by Holger Freyther.
make the finalize function the dispose function. Not releasing held
objects in dispose can cause crashers later.
- webkit/webkitwebview.cpp:
- 7:46 PM Changeset in webkit [39775] by
-
- 2 edits in trunk/WebKit/gtk
2009-01-09 Benjamin Otte <otte@gnome.org>
Reviewed by Holger Freyther.
Remove broken code that uses a fallback. The previous code did 2
policy decisions which caused crashes.
Download is still notImplemented();
- webkit/webkitwebpolicydecision.cpp: (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download):
- 7:46 PM Changeset in webkit [39774] by
-
- 2 edits in trunk/WebCore
2009-01-09 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Holger Freyther.
[CURL] POST without body becomes GET
https://bugs.webkit.org/show_bug.cgi?id=23182
Make sure that method is always set to POST even when the body is
empty. Cleaned up httpBody null check.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST):
- 6:00 PM Changeset in webkit [39773] by
-
- 2 edits in trunk/WebCore
Build fix.
- 5:12 PM Changeset in webkit [39772] by
-
- 2 edits in trunk/WebCore
2009-01-09 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix infinite recursion in clientPaddingLeft and clientPaddingRight. This changes the code back to
how it was before RenderTextControlSingleLine was split out from RenderTextControl.
No test added since this code is only exercised when trying to place a search field's recent searches popup menu.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- 4:41 PM Changeset in webkit [39771] by
-
- 6 edits in trunk
WebCore:
2009-01-09 Darin Adler <Darin Adler>
Reviewed by Jon Honeycutt.
Bug 22913: REGRESSION: Space bar doesn't scroll on windows
https://bugs.webkit.org/show_bug.cgi?id=22913
rdar://problem/6479834
- page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): Added code to call defaultSpaceEventHandler. (WebCore::EventHandler::defaultSpaceEventHandler): Added. Scrolls down or up based on the shift key.
- page/EventHandler.h: Added defaultSpaceEventHandler.
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformScroll): Return false, because this function does not scroll. In an earlier version of this patch, I used this to prevent the patch from affecting the Mac, but I decided to use #if instead.
WebKit/win:
2009-01-09 Darin Adler <Darin Adler>
Reviewed by Jon Honeycutt.
Bug 22913: REGRESSION: Space bar doesn't scroll on windows
https://bugs.webkit.org/show_bug.cgi?id=22913
rdar://problem/6479834
- WebView.cpp: (WebView::keyPress): Removed code to handle space bar here; put it in WebCore instead.
- 4:38 PM Changeset in webkit [39770] by
-
- 2 edits in trunk/LayoutTests
2009-01-09 Sam Weinig <sam@webkit.org>
Check in correct results for failing test.
- fast/dom/Window/window-properties-expected.txt:
- 4:14 PM Changeset in webkit [39769] by
-
- 13 edits in trunk
2009-01-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Stage two of converting JSValue from a pointer to a class type.
Remove the class JSValue. The functionallity has been transitioned
into the wrapper class type JSValuePtr.
The last stage will be to rename JSValuePtr to JSValue, remove the
overloaded -> operator, and switch operations on JSValuePtrs from
using '->' to use '.' instead.
- API/APICast.h:
- JavaScriptCore.exp:
- runtime/JSCell.h: (JSC::asCell): (JSC::JSValuePtr::asCell): (JSC::JSValuePtr::isNumber): (JSC::JSValuePtr::isString): (JSC::JSValuePtr::isGetterSetter): (JSC::JSValuePtr::isObject): (JSC::JSValuePtr::getNumber): (JSC::JSValuePtr::getString): (JSC::JSValuePtr::getObject): (JSC::JSValuePtr::getCallData): (JSC::JSValuePtr::getConstructData): (JSC::JSValuePtr::getUInt32): (JSC::JSValuePtr::getTruncatedInt32): (JSC::JSValuePtr::getTruncatedUInt32): (JSC::JSValuePtr::mark): (JSC::JSValuePtr::marked): (JSC::JSValuePtr::toPrimitive): (JSC::JSValuePtr::getPrimitiveNumber): (JSC::JSValuePtr::toBoolean): (JSC::JSValuePtr::toNumber): (JSC::JSValuePtr::toString): (JSC::JSValuePtr::toObject): (JSC::JSValuePtr::toThisObject): (JSC::JSValuePtr::needsThisConversion): (JSC::JSValuePtr::toThisString): (JSC::JSValuePtr::getJSNumber):
- runtime/JSImmediate.h: (JSC::JSValuePtr::isUndefined): (JSC::JSValuePtr::isNull): (JSC::JSValuePtr::isUndefinedOrNull): (JSC::JSValuePtr::isBoolean): (JSC::JSValuePtr::getBoolean): (JSC::JSValuePtr::toInt32): (JSC::JSValuePtr::toUInt32):
- runtime/JSNumberCell.h: (JSC::JSValuePtr::uncheckedGetNumber): (JSC::JSValuePtr::toJSNumber):
- runtime/JSObject.h: (JSC::JSValuePtr::isObject): (JSC::JSValuePtr::get): (JSC::JSValuePtr::put):
- runtime/JSString.h: (JSC::JSValuePtr::toThisJSString):
- runtime/JSValue.cpp: (JSC::JSValuePtr::toInteger): (JSC::JSValuePtr::toIntegerPreserveNaN): (JSC::JSValuePtr::toInt32SlowCase): (JSC::JSValuePtr::toUInt32SlowCase):
- runtime/JSValue.h: (JSC::JSValuePtr::makeImmediate): (JSC::JSValuePtr::immediateValue): (JSC::JSValuePtr::JSValuePtr): (JSC::JSValuePtr::operator->): (JSC::JSValuePtr::operator bool): (JSC::JSValuePtr::operator==): (JSC::JSValuePtr::operator!=): (JSC::JSValuePtr::encode): (JSC::JSValuePtr::decode): (JSC::JSValuePtr::toFloat): (JSC::JSValuePtr::asValue): (JSC::operator==): (JSC::operator!=):
WebCore:
2009-01-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Delete references to JSValue, removing this class.
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::self):
- bindings/js/ScriptCallStack.h:
- 3:42 PM Changeset in webkit [39768] by
-
- 1 edit6 adds in trunk/WebCore
2009-01-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add svg/graphics/skia files.
https://bugs.webkit.org/show_bug.cgi?id=23147
- svg/graphics/skia/RenderPathSkia.cpp: Added. (WebCore::RenderPath::strokeContains):
- svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Added. (WebCore::SVGPaintServerPattern::setup):
- svg/graphics/skia/SVGPaintServerSkia.cpp: Added. (WebCore::SVGPaintServer::draw): (WebCore::SVGPaintServer::teardown): (WebCore::SVGPaintServer::renderPath):
- svg/graphics/skia/SVGResourceFilterSkia.cpp: Added. (WebCore::SVGResourceFilter::createPlatformData): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
- svg/graphics/skia/SVGResourceMaskerSkia.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
- 3:04 PM Changeset in webkit [39767] by
-
- 1 edit2 adds in trunk/WebCore
2009-01-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add SkiaFontWin to platform/graphics/chromium
https://bugs.webkit.org/show_bug.cgi?id=23215
- platform/graphics/skia/SkiaFontWin.cpp: Added. (WebCore::CachedOutlineKey::CachedOutlineKey): (WebCore::operator==): (WebCore::CachedOutlineKeyHash::hash): (WebCore::CachedOutlineKeyHash::equal): (WebCore::FIXEDToSkScalar): (WebCore::deleteOutline): (WebCore::addPolyCurveToPath): (WebCore::getPathForGlyph): (WebCore::SkiaWinOutlineCache::lookupOrCreatePathForGlyph): (WebCore::SkiaWinOutlineCache::removePathsForFont):
- platform/graphics/skia/SkiaFontWin.h: Added.
- 2:55 PM Changeset in webkit [39766] by
-
- 1 edit3 adds in trunk/WebCore
2009-01-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add PlatformContextSkia and PlatformGraphics.h to platform/graphics/skia
https://bugs.webkit.org/show_bug.cgi?id=23215
- platform/graphics/skia/PlatformContextSkia.cpp: Added. (PlatformContextSkia::State::State): (PlatformContextSkia::State::~State): (PlatformContextSkia::State::applyAlpha): (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::~PlatformContextSkia): (PlatformContextSkia::setCanvas): (PlatformContextSkia::save): (PlatformContextSkia::restore): (PlatformContextSkia::drawRect): (PlatformContextSkia::setupPaintCommon): (PlatformContextSkia::setupPaintForFilling): (PlatformContextSkia::setupPaintForStroking): (PlatformContextSkia::setDrawLooper): (PlatformContextSkia::setMiterLimit): (PlatformContextSkia::setAlpha): (PlatformContextSkia::setLineCap): (PlatformContextSkia::setLineJoin): (PlatformContextSkia::setPorterDuffMode): (PlatformContextSkia::setFillColor): (PlatformContextSkia::getDrawLooper): (PlatformContextSkia::getStrokeStyle): (PlatformContextSkia::setStrokeStyle): (PlatformContextSkia::setStrokeColor): (PlatformContextSkia::getStrokeThickness): (PlatformContextSkia::setStrokeThickness): (PlatformContextSkia::getTextDrawingMode): (PlatformContextSkia::setTextDrawingMode): (PlatformContextSkia::setUseAntialiasing): (PlatformContextSkia::fillColor): (PlatformContextSkia::beginPath): (PlatformContextSkia::addPath): (PlatformContextSkia::setFillRule): (PlatformContextSkia::setGradient): (PlatformContextSkia::setPattern): (PlatformContextSkia::setDashPathEffect): (PlatformContextSkia::paintSkPaint): (PlatformContextSkia::bitmap): (PlatformContextSkia::isPrinting):
- platform/graphics/skia/PlatformContextSkia.h: Added. (PlatformContextSkia::currentPath): (PlatformContextSkia::canvas): (PlatformContextSkia::gdk_skia):
- platform/graphics/skia/PlatformGraphics.h: Added.
- 2:35 PM Changeset in webkit [39765] by
-
- 2 edits in trunk/WebCore
2009-01-09 Anders Carlsson <andersca@apple.com>
Fix build.
- WebCore.LP64.exp:
- 2:34 PM Changeset in webkit [39764] by
-
- 1 edit1 add in trunk/WebCore
2009-01-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add TransformationMatrixSkia to platform/graphics/skia
https://bugs.webkit.org/show_bug.cgi?id=23215
- platform/graphics/skia/TransformationMatrixSkia.cpp: Added. (WebCore::TransformationMatrix::TransformationMatrix): (WebCore::TransformationMatrix::setMatrix): (WebCore::TransformationMatrix::map): (WebCore::TransformationMatrix::mapRect): (WebCore::TransformationMatrix::isIdentity): (WebCore::TransformationMatrix::reset): (WebCore::TransformationMatrix::scale): (WebCore::TransformationMatrix::rotate): (WebCore::TransformationMatrix::translate): (WebCore::TransformationMatrix::shear): (WebCore::TransformationMatrix::det): (WebCore::TransformationMatrix::inverse): (WebCore::TransformationMatrix::operator SkMatrix): (WebCore::TransformationMatrix::operator==): (WebCore::TransformationMatrix::operator*=): (WebCore::TransformationMatrix::operator*): (WebCore::TransformationMatrix::a): (WebCore::TransformationMatrix::setA): (WebCore::TransformationMatrix::b): (WebCore::TransformationMatrix::setB): (WebCore::TransformationMatrix::c): (WebCore::TransformationMatrix::setC): (WebCore::TransformationMatrix::d): (WebCore::TransformationMatrix::setD): (WebCore::TransformationMatrix::e): (WebCore::TransformationMatrix::setE): (WebCore::TransformationMatrix::f): (WebCore::TransformationMatrix::setF):
- 2:33 PM Changeset in webkit [39763] by
-
- 10 edits3 copies3 adds in trunk/WebKit/win
2009-01-09 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=23092
Separate CFNetwork-specific code in WebKit.dll into separate
implementation files. Create cURL stub files to be populated
with new implementation in a future bug report.
- WebCookieManager.cpp: Move CFNetwork-specific routines to the new WebCookieManagerCFNet.cpp file. (WebCookieManager::Release):
- WebCookieManagerCFNet.cpp: Copied from WebCookieManager.cpp. (WebCookieManager::cookieStorage):
- WebCookieManagerCurl.cpp: Added. (WebCookieManager::cookieStorage): (WebCookieManager::setCookieStorage):
- WebCoreSupport/WebFrameLoaderClient.cpp: Conditionalize two methods in this file. (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::savePlatformDataToCachedPage):
- WebDownload.cpp: Move CFNetwork-specific logic to the new WebDownloadCFNet.cpp (WebDownload::bundleExtension): (WebDownload::bundleMagicNumber): (WebDownload::bundlePathForTargetPath): (WebDownload::extractResumeDataFromBundle): Made static class method so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp (WebDownload::appendResumeDataToBundle): Made static class method so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
- WebDownload.h:
- WebDownloadCFNet.cpp: Copied from WebDownload.cpp. (WebDownload::initToResumeWithBundle): (WebDownload::setDestination): (didFailCallback):
- WebDownloadCurl.cpp: Added. (WebDownload::init): (WebDownload::initWithRequest): (WebDownload::initToResumeWithBundle): (WebDownload::start): (WebDownload::cancel): (WebDownload::cancelForResume): (WebDownload::deletesFileUponFailure): (WebDownload::setDeletesFileUponFailure): (WebDownload::setDestination): (WebDownload::cancelAuthenticationChallenge): (WebDownload::continueWithoutCredentialForAuthenticationChallenge): (WebDownload::useCredential):
- WebKit.vcproj/WebKit.vcproj: Modify Apple targets to exclude the new cURL files. Modify Cairo targets to exclude CFNet files.
- WebMutableURLRequest.cpp: Conditionalize the single method with a CFNetwork-speicic call. (WebMutableURLRequest::mutableCopy):
- WebURLAuthenticationChallenge.cpp: Conditionalize one line that causes build problems for cURL. This will be removed later. (WebURLAuthenticationChallenge::initWithProtectionSpace):
- WebURLAuthenticationChallengeSender.cpp:
- WebURLAuthenticationChallengeSenderCFNet.cpp: Copied from WebURLAuthenticationChallengeSender.cpp. (WebURLAuthenticationChallengeSender::useCredential):
- WebURLAuthenticationChallengeSenderCurl.cpp: Added. (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge): (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge): (WebURLAuthenticationChallengeSender::useCredential):
- WebURLResponse.cpp: Exclude WebKitSystemInterface when compiling for the cURL target.
- 2:21 PM Changeset in webkit [39762] by
-
- 3 edits4 adds in trunk
Reviewed by Darin Adler.
<rdar://problem/6477502> Repro crash reloading page using HTML5 AppCache on Windows
Test: http/tests/appcache/reload.html
On Windows, reloading resulted in the following sequence of events:
1) A new main resource loader was created and associated with the cache. Its document loader
was not associated with the cache yet.
2) The old document loader was destroyed, and since it was the last one, ApplicationCacheGroup
teardown started, with newestCache being zeroed out.
3) The new document loader was associated with the cache group, and cache update started.
4) Since newestCache was null, this caused many problems.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Improve comments and assertions, no functional changes. (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the cache group if its newest cache pointer is already saved for teardown. Note that the cache pointer validity is ensured by MainResourceLoader that holds a reference to it.
- 2:20 PM Changeset in webkit [39761] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Darin Adler.
Fix many appcache tests on Windows by making synchronous XMLHttpRequest throw on cache miss.
- WebFrame.cpp: (WebFrame::cannotShowURLError): Implement, so that synchronous XHR can raise exceptions, as needed for AppCache tests. I do not know why this error was not implemented.
- 2:12 PM Changeset in webkit [39760] by
-
- 2 edits8 adds in trunk/WebCore
2009-01-09 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23214
Upstream platform/network/chromium/
- platform/network/chromium/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::sourceHandle):
- platform/network/chromium/AuthenticationChallengeChromium.cpp: Added. (WebCore::AuthenticationChallenge::platformCompare):
- platform/network/chromium/CookieJarChromium.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
- platform/network/chromium/DNSChromium.cpp: Added. (WebCore::prefetchDNS):
- platform/network/chromium/NetworkStateNotifierChromium.cpp: Added. (WebCore::NetworkStateNotifier::updateState): (WebCore::NetworkStateNotifier::NetworkStateNotifier):
- platform/network/chromium/NetworkStateNotifierPrivate.h: Added.
- platform/network/chromium/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
- platform/network/chromium/ResourceRequest.h: Added. (WebCore::ResourceRequest::): (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::frame): (WebCore::ResourceRequest::setFrame): (WebCore::ResourceRequest::setTargetType): (WebCore::ResourceRequest::targetType): (WebCore::ResourceRequest::originPid): (WebCore::ResourceRequest::setOriginPid): (WebCore::ResourceRequest::securityInfo): (WebCore::ResourceRequest::setSecurityInfo): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::getSecurityInfo): (WebCore::ResourceResponse::setSecurityInfo): (WebCore::ResourceResponse::isContentFiltered): (WebCore::ResourceResponse::setIsContentFiltered): (WebCore::ResourceResponse::doUpdateResourceResponse):
- 1:44 PM Changeset in webkit [39759] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
fix tyop in Changelog
- 1:42 PM Changeset in webkit [39758] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
- fixed <rdar://problem/6234347> Add/change conditional key bindings for changing paragraph- and character-level writing direction (to match NSTextView)
- WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Added code to validate makeBaseWritingDirectionLeftToRight: and makeBaseWritingDirectionRightToLeft:. (writingDirectionKeyBindingsEnabled): Changed this function to always return YES, except on Tiger and Leopard. (-[WebHTMLView makeBaseWritingDirectionLeftToRight:]): Renamed changeBaseWritingDirectionToLTR: to this. (-[WebHTMLView makeBaseWritingDirectionRightToLeft:]): Renamed changeBaseWritingDirectionToRTL: to this. (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Now calls makeBaseWritingDirectionLeftToRight:. (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Now calls makeBaseWritingDirectionRightToLeft:.
- WebView/WebView.mm: Added makeBaseWritingDirectionLeftToRight and makeBaseWritingDirectionRightToLeft to FOR_EACH_RESPONDER_SELECTOR.
- 1:01 PM Changeset in webkit [39757] by
-
- 4 edits in trunk/WebKit/win
2009-01-09 Darin Adler <Darin Adler>
Reviewed and landed by Adele Peterson.
Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
https://bugs.webkit.org/show_bug.cgi?id=23160
- Interfaces/IWebViewPrivate.idl: Added setMemoryCacheDelegateCallsEnabled.
- WebView.cpp: (WebView::setMemoryCacheDelegateCallsEnabled): Ditto.
- WebView.h: Ditto.
- 12:53 PM Changeset in webkit [39756] by
-
- 19 edits in trunk/WebKitSite
2009-01-09 William Siegrist <wsiegrist@apple.com>
Reviewed by David Kilzer
Update URLs which go through redirects by changing bugs.webkit.org URLs to use https and removing /projects/webkit from Trac URLs.
Replace tabs in bugpriorities.html with spaces.
- 12:17 PM Changeset in webkit [39755] by
-
- 3 edits in trunk/JavaScriptCore
2009-01-09 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
Adjustment to previous patch. Remove call to initilizeThreading from JSGlobalCreate
and fix jsc.cpp instead.
- 11:42 AM Changeset in webkit [39754] by
-
- 2 edits in trunk/LayoutTests
2009-01-09 Joel Weinberger <jww@cs.berkeley.edu>
Reviewed by Darin Adler.
Landed by Adam Barth.
The test intended to test reload, but reference reload in one place and
replace in another. This makes them consistent.
- http/tests/security/resources/xss-DENIED-assign-location-reload-attacker.html:
- 11:12 AM Changeset in webkit [39753] by
-
- 3 edits in trunk/WebKit/qt
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Documentation fixes, remove duplicated docs, document missing
parameters and return values.
- 10:47 AM Changeset in webkit [39752] by
-
- 10 edits in trunk/JavaScriptCore
2009-01-09 Sam Weinig <sam@webkit.org>
Roll r39720 back in with a working interpreted mode.
- 10:46 AM Changeset in webkit [39751] by
-
- 7 edits in trunk/WebCore
2009-01-09 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=22995
Fix flaky image animation by resetting the metadata for a frame when
we get new data for that frame. This fixes animations that halted
when the next frame of the animation wasn't complete by the time the
current frame's duration expired.
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::dataChanged):
- platform/graphics/BitmapImage.h: (WebCore::FrameData::~FrameData):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::FrameData::clear):
- platform/graphics/cg/ImageCG.cpp: (WebCore::FrameData::clear):
- platform/graphics/qt/ImageQt.cpp: (WebCore::FrameData::clear):
- platform/graphics/wx/ImageWx.cpp: (WebCore::FrameData::clear):
- 10:28 AM Changeset in webkit [39750] by
-
- 1 add in trunk/JavaScriptCore/wtf/PtrAndFlags.h
Whoops, include actual file the the forwarding headers point to.
- 9:58 AM Changeset in webkit [39749] by
-
- 2 edits in trunk/WebCore
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Swap the .h and the .cpp output in the Qt build for the
UserAgentStyleSheetData files, to put the definition in the .cpp file
and the declaration in the header file.
- 9:54 AM Changeset in webkit [39748] by
-
- 2 adds in trunk
include files missed in last commit.
- 9:53 AM Changeset in webkit [39747] by
-
- 13 edits in trunk
2009-01-09 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
Added a template to make the pointer and flags combination
in UString more readable and less error prone.
- 9:47 AM Changeset in webkit [39746] by
-
- 2 edits in trunk/WebKit/qt
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix linking against QtWebKit on Windows, by defining the EXPORT macros
_exactly_ the same way as in qglobal.h, depending on QT_NODLL,
QT_MAKEDLL and QT_SHARED.
- 8:51 AM Changeset in webkit [39745] by
-
- 2 edits in trunk/WebCore
2009-01-09 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
Prevent qmake from generating duplicate rules for embedded stylesheets
The STYLESHEETS_EMBED variable used to contain only one file name, but
now that it is a list of files we need to change it to be a dependency
for the stylesheet generator instead of the input.
- 5:03 AM Changeset in webkit [39744] by
-
- 4 edits in trunk
WebCore:
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix qmake warning about missing test function, a contains() call was
missing.
WebKit/qt:
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Remove qwebnetworkinterface.h from WEBKIT_API_HEADERS as it's not
public Qt 4.4/4.5 API.
- 4:32 AM Changeset in webkit [39743] by
-
- 2 edits in trunk/LayoutTests
- fast/dom/Window/window-properties-expected.txt: Forgot to commit this with r39699, too.
- 4:16 AM Changeset in webkit [39742] by
-
- 2 edits in trunk/WebKit/qt
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Qt build fix, remove qcookiejar.h from the API headers and
therefore HEADERS. It's not part of the API and it moc shouldn't be
called on it.
- 3:10 AM Changeset in webkit [39741] by
-
- 4 edits in trunk
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Add the Qt API headers to HEADERS, too, for improved completion in IDEs.
- 1:42 AM Changeset in webkit [39740] by
-
- 3 edits in trunk/WebCore
2009-01-09 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix deref's of string happening on two different threads.
No observable change in behavior, so no test. However, there are asserts
being added for https://bugs.webkit.org/show_bug.cgi?id=23175 which
will detect this issue while running the normal worker tests.
- dom/WorkerThread.cpp: (WebCore::WorkerThreadStartupData::create): (WebCore::WorkerThreadStartupData::WorkerThreadStartupData): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
- dom/WorkerThread.h:
- 12:12 AM Changeset in webkit [39739] by
-
- 2 edits in trunk/LayoutTests
2009-01-08 Gavin Barraclough <barraclough@apple.com>
RS by Oliver Hunt.
Looks like this should have been updated with r39699.
- fast/js/global-constructors-expected.txt:
- 12:11 AM Changeset in webkit [39738] by
-
- 11 edits in trunk/JavaScriptCore
2009-01-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Encode immediates in the low word of JSValuePtrs, on x86-64.
On 32-bit platforms a JSValuePtr may represent a 31-bit signed integer.
On 64-bit platforms, if USE(ALTERNATE_JSIMMEDIATE) is defined, a full
32-bit integer may be stored in an immediate.
Presently USE(ALTERNATE_JSIMMEDIATE) uses the same encoding as the default
immediate format - the value is left shifted by one, so a one bit tag can
be added to indicate the value is an immediate. However this means that
values must be commonly be detagged (by right shifting by one) before
arithmetic operations can be performed on immediates. This patch modifies
the formattting so the the high bits of the immediate mark values as being
integer.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::not32): (JSC::MacroAssembler::orPtr): (JSC::MacroAssembler::zeroExtend32ToPtr): (JSC::MacroAssembler::jaePtr): (JSC::MacroAssembler::jbPtr): (JSC::MacroAssembler::jnzPtr): (JSC::MacroAssembler::jzPtr):
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::notl_r): (JSC::X86Assembler::testq_i32r):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArith_op_rshift): (JSC::JIT::compileFastArith_op_bitand): (JSC::JIT::compileFastArithSlow_op_bitand): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArithSlow_op_mod): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
- jit/JITInlineMethods.h: (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmNum): (JSC::JIT::emitJumpSlowCaseIfNotImmNum): (JSC::JIT::emitJumpSlowCaseIfNotImmNums): (JSC::JIT::emitFastArithDeTagImmediate): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::emitFastArithReTagImmediate): (JSC::JIT::emitFastArithImmToInt): (JSC::JIT::emitFastArithIntToImmNoCheck): (JSC::JIT::emitTagAsBoolImmediate):
- jit/JITPropertyAccess.cpp: (JSC::resizePropertyStorage): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- runtime/JSImmediate.h: (JSC::JSImmediate::isNumber): (JSC::JSImmediate::isPositiveNumber): (JSC::JSImmediate::areBothImmediateNumbers): (JSC::JSImmediate::xorImmediateNumbers): (JSC::JSImmediate::rightShiftImmediateNumbers): (JSC::JSImmediate::canDoFastAdditiveOperations): (JSC::JSImmediate::addImmediateNumbers): (JSC::JSImmediate::subImmediateNumbers): (JSC::JSImmediate::makeInt): (JSC::JSImmediate::toBoolean):
- wtf/Platform.h:
Jan 8, 2009:
- 9:41 PM Changeset in webkit [39737] by
-
- 10 edits in trunk/JavaScriptCore
2009-01-08 Sam Weinig <sam@webkit.org>
Revert r39720. It broke Interpreted mode.
- 7:45 PM Changeset in webkit [39736] by
-
- 13 edits in trunk
WebCore:
Reviewed by Adam Roben.
- use native glyph support in Core Graphics when available
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Changed to use drawGDIGlyphs() only if native glyph support is not available or stroking is required. Changed to pass the font's useGDI() flag to wkSetCGContextFontRenderingStyle to request the use of native glyphs.
- platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): Added a call to wkSetFontPlatformInfo to attach the LOGFONT to the CGFont.
- platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::platformDataInit): Ditto.
WebKit/win:
Reviewed by Adam Roben.
- WebPreferences changes to support Core Graphics native glyph drawing
- Interfaces/IWebPreferencesPrivate.idl: Added font smoothing contrast getter and setter.
- WebPreferenceKeysPrivate.h: Added WebKitFontSmoothingContrastPreferenceKey.
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Initialized WebKitFontSmoothingContrastPreferenceKey to 2. (WebPreferences::setFloatValue): Added. (WebPreferences::setFontSmoothing): Changed to map FontSmoothingTypeWindows to FontSmoothingTypeMedium. (WebPreferences::fontSmoothingContrast): Added. (WebPreferences::setFontSmoothingContrast): Added. Calls wkSetFontSmoothingContrast().
- WebPreferences.h:
WebKitLibraries:
Reviewed by Adam Roben.
- WebKitSystemInterface changes to support Core Graphics native glyph drawing
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 7:12 PM Changeset in webkit [39735] by
-
- 2 edits in trunk/WebKit/win
<rdar://problem/6474244> REGRESSION(39561-39603): Heap corruption when saving passwords?
Reviewed by Adam Roben.
- WebView.cpp: (WebViewWndProc): Hold a ref to the WebView inside the WNDPROC, since it could go away in an event handler.
- 5:51 PM Changeset in webkit [39734] by
-
- 2 edits in trunk/WebCore
2009-01-08 Peter Kasting <pkasting@google.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=22929
Fix memory regression when decoding large animated GIFs.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear):
- 5:41 PM Changeset in webkit [39733] by
-
- 3 edits in trunk/WebKit/mac
2009-01-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add and implement WKPCGetStringIdentifier.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetStringIdentifier):
- Plugins/Hosted/WebKitPluginClient.defs:
- 5:36 PM Changeset in webkit [39732] by
-
- 1 edit in trunk/WebCore/ChangeLog
Correct my changelog error.
2009-01-08 Scott Violet <sky@chromium.org>
Reviewed by Eric Seidel (and Adam Barth).
Fix Images to return their file extension
http://code.google.com/p/chromium/issues/detail?id=5827
- platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::filenameExtension):
- 5:22 PM Changeset in webkit [39731] by
-
- 2 edits in trunk/WebCore
2009-01-08 Berend-Jan Wever <sky@chromium.org>
Reviewed by Adam Barth.
Fix Images to return their file extension
http://code.google.com/p/chromium/issues/detail?id=5827
- platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::filenameExtension):
- 5:18 PM Changeset in webkit [39730] by
-
- 1 edit2 adds in trunk/WebCore
2009-01-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add PathSkia and PatternSkia implementations to WebCore
https://bugs.webkit.org/show_bug.cgi?id=23200
- platform/graphics/skia/PathSkia.cpp: Added. (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::isEmpty): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::convertPathPoints): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::debugString): (WebCore::boundingBoxForCurrentStroke): (WebCore::Path::strokeBoundingRect):
- platform/graphics/skia/PatternSkia.cpp: Added. (WebCore::shaderRule): (WebCore::Pattern::createPlatformPattern):
- 5:06 PM Changeset in webkit [39729] by
-
- 2 edits2 adds in trunk/WebCore
2009-01-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add ImageSourceSkia to platform/graphics/skia
https://bugs.webkit.org/show_bug.cgi?id=23200
ImageSourceSkia is mostly a hack to support our
ICO decoder model. See ImageSourceSkia.h for more
explanation. Eventually we'd like to make our ICO
decoder lazy.
- platform/graphics/ImageSource.h: mark m_decoder as protected
- platform/graphics/skia/ImageSourceSkia.cpp: Added. (WebCore::createDecoder): (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear): (WebCore::ImageSource::initialized): (WebCore::ImageSource::setData): (WebCore::ImageSource::isSizeAvailable): (WebCore::ImageSource::size): (WebCore::ImageSource::frameSizeAtIndex): (WebCore::ImageSource::repetitionCount): (WebCore::ImageSource::frameCount): (WebCore::ImageSource::createFrameAtIndex): (WebCore::ImageSource::frameIsCompleteAtIndex): (WebCore::ImageSource::frameDurationAtIndex): (WebCore::ImageSource::frameHasAlphaAtIndex): (WebCore::ImageSourceSkia::setData): (WebCore::ImageSource::filenameExtension):
- platform/graphics/skia/ImageSourceSkia.h: Added.
- 4:54 PM Changeset in webkit [39728] by
-
- 1 edit2 adds in trunk/WebCore
2009-01-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add NativeImageSkia (PlatformImagePtr) to platform/graphics/skia
https://bugs.webkit.org/show_bug.cgi?id=23200
- platform/graphics/skia/NativeImageSkia.cpp: Added. (NativeImageSkia::NativeImageSkia): (NativeImageSkia::decodedSize): (NativeImageSkia::hasResizedBitmap): (NativeImageSkia::resizedBitmap): (NativeImageSkia::shouldCacheResampling):
- platform/graphics/skia/NativeImageSkia.h: Added. (NativeImageSkia::setDataComplete): (NativeImageSkia::isDataComplete):
- 4:41 PM Changeset in webkit [39727] by
-
- 1 edit2 adds in trunk/WebCore
2009-01-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add ImageBufferSkia and ImageSkia files.
https://bugs.webkit.org/show_bug.cgi?id=23200
For now we've left BitmapImage and BitmapImageSingleFrameSkia
implementations in the ImageSkia file (like ImageCG has), but
we intend to break them out into their own files.
- platform/graphics/skia/ImageBufferSkia.cpp: Added. (WebCore::ImageBufferData::ImageBufferData): (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::~ImageBuffer): (WebCore::ImageBuffer::context): (WebCore::ImageBuffer::image): (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData): (WebCore::ImageBuffer::toDataURL):
- platform/graphics/skia/ImageSkia.cpp: Added. (WebCore::): (WebCore::FrameData::clear): (WebCore::Image::loadPlatformResource): (WebCore::Image::drawPattern): (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::draw): (WebCore::BitmapImageSingleFrameSkia::draw): (WebCore::BitmapImageSingleFrameSkia::create):
- 4:30 PM Changeset in webkit [39726] by
-
- 2 edits in trunk/WebCore
2009-01-08 James Robinson <jamesr@google.com>
Reviewed by Mark Rowe.
Landed by Pamela Greene.
WebCore::Event::timeStamp() is a simple accessor and should be const
- dom/Event.h: (WebCore::Event::timeStamp):
- 3:44 PM Changeset in webkit [39725] by
-
- 6 edits in trunk/WebCore
2009-01-08 Antti Koivisto <Antti Koivisto>
Reviewed by Oliver Hunt.
Fix <rdar://problem/6467206>
Resources loaded from the memory cache do not get correctly inserted into the DocLoader resource map (22994)
Use CachedResourceHandle in document resource map so resources get updated correctly when using
using cache validation conditionals.
- loader/Cache.cpp: (WebCore::Cache::evict):
- loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setAutoLoadImages): (WebCore::DocLoader::removeCachedResource):
- loader/DocLoader.h: (WebCore::DocLoader::cachedResource): (WebCore::DocLoader::allCachedResources):
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::getSubresources):
- loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
- 3:36 PM Changeset in webkit [39724] by
-
- 4 edits in trunk
Versioning.
- 3:35 PM Changeset in webkit [39723] by
-
- 1 copy in tags/Safari-6528.9
New tag.
- 3:07 PM Changeset in webkit [39722] by
-
- 2 edits in trunk/WebKit/mac
2009-01-08 Stephanie Lewis <slewis@gmail.com>
Fix Tiger build.
- WebView/WebTextIterator.mm:
- 3:00 PM Changeset in webkit [39721] by
-
- 6 edits in trunk/WebKit/mac
2009-01-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add basic support for evaluating scripts.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::fromUTF8WithLatin1Fallback): (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): (WKPCReleaseObject): (marshalValue): (WKPCEvaluate):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::releaseObject): (WebKit::NetscapePluginInstanceProxy::evaluate):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 2:51 PM Changeset in webkit [39720] by
-
- 10 edits in trunk/JavaScriptCore
2009-01-08 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23197
Delay creating the PCVector until an exception is thrown
Part of <rdar://problem/6469060>
Don't store exception information for a CodeBlock until first exception is thrown
- Change the process for re-parsing/re-generating bytecode for exception information to use data from the original CodeBlock (offsets of GlobalResolve instructions) to aid in creating an identical instruction stream on re-parse, instead of padding interchangeable opcodes, which would result in different JITed code.
- Fix bug where the wrong ScopeChainNode was used when re-parsing/regenerating from within some odd modified scope chains.
- Lazily create the pcVector by re-JITing the regenerated CodeBlock and stealing the the pcVector from it.
Saves ~2MB on Membuster head.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset): (JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
- bytecode/CodeBlock.h: (JSC::JITCodeRef::JITCodeRef): (JSC::GlobalResolveInfo::GlobalResolveInfo): (JSC::CodeBlock::getBytecodeIndex): (JSC::CodeBlock::addGlobalResolveInstruction): (JSC::CodeBlock::addGlobalResolveInfo): (JSC::CodeBlock::addFunctionRegisterInfo): (JSC::CodeBlock::hasExceptionInfo): (JSC::CodeBlock::pcVector): (JSC::EvalCodeBlock::EvalCodeBlock): (JSC::EvalCodeBlock::baseScopeDepth):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitResolve): (JSC::BytecodeGenerator::emitGetScopedVar):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::setRegeneratingForExceptionInfo):
- interpreter/Interpreter.cpp: (JSC::bytecodeOffsetForPC): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveLastCaller): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_call_NotJSFunction): (JSC::Interpreter::cti_op_resolve): (JSC::Interpreter::cti_op_construct_NotJSConstruct): (JSC::Interpreter::cti_op_resolve_func): (JSC::Interpreter::cti_op_resolve_skip): (JSC::Interpreter::cti_op_resolve_global): (JSC::Interpreter::cti_op_resolve_with_base): (JSC::Interpreter::cti_op_throw): (JSC::Interpreter::cti_op_in): (JSC::Interpreter::cti_vm_throw):
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- parser/Nodes.cpp: (JSC::EvalNode::generateBytecode): (JSC::EvalNode::bytecodeForExceptionInfoReparse): (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
- parser/Nodes.h:
- 2:06 PM Changeset in webkit [39719] by
-
- 1 edit1 add in trunk/WebCore
2009-01-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add a cleaned-up GraphicsContextSkia implementation to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=23191
- platform/graphics/skia/GraphicsContextSkia.cpp: Added. (WebCore::): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::clearPlatformShadow): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineDash): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformTextDrawingMode): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::setUseAntialiasing): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate):
- 1:51 PM Changeset in webkit [39718] by
-
- 1 edit2 adds in trunk/WebCore
2009-01-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add two more files for platform/graphics/skia.
https://bugs.webkit.org/show_bug.cgi?id=23191
- platform/graphics/skia/GradientSkia.cpp: Added. (WebCore::Gradient::platformDestroy): (WebCore::F2B): (WebCore::makeSkColor): (WebCore::totalStopsNeeded): (WebCore::fillStops): (WebCore::compareStops): (WebCore::Gradient::platformGradient): (WebCore::Gradient::fill):
- platform/graphics/skia/GraphicsContextPlatformPrivate.h: Copied from WebCore/bindings/js/ScriptValue.h. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::context):
- 1:27 PM Changeset in webkit [39717] by
-
- 10 edits in trunk
WebCore:
2009-01-08 David Hyatt <hyatt@apple.com>
Fix for <rdar://problem/6465682> REGRESSION: In Mail, can't force a message to auto scroll.
Make scrollRectIntoViewRecursively call out to the HostWindow to continue the recursive scroll for
any scrollable views that may contain a WebView. Does nothing on platforms other than the Mac, but
might eventually be of interest to other platforms.
Reviewed by Oliver Hunt
- WebCore.base.exp:
- page/Chrome.cpp: (WebCore::Chrome::scrollRectIntoView):
- page/Chrome.h:
- page/ChromeClient.h: (WebCore::ChromeClient::scrollRectIntoView):
- platform/HostWindow.h:
- platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively):
WebKit/mac:
2009-01-08 David Hyatt <hyatt@apple.com>
Fix for <rdar://problem/6465682> REGRESSION: In Mail, can't force a message to auto scroll
Add a new ChromeClient method for handling exposure of scrolled rects.
Reviewed by Oliver Hunt
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scrollRectIntoView):
- 1:12 PM Changeset in webkit [39716] by
-
- 4 edits in trunk/WebCore
No need to make this part of HostWindow and moreover HostWindow should
not have any reference to non-platform parts of WebCore.
- 12:59 PM Changeset in webkit [39715] by
-
- 3 edits in trunk/WebKit/mac
2009-01-08 Darin Adler <Darin Adler>
Reviewed by Tim Hatcher.
Bug 23185: add a currentRange method to the WebTextIterator SPI
https://bugs.webkit.org/show_bug.cgi?id=23185
rdar://problem/6455834
I also noticed a garbage-collection-related threading issue that I fixed, and
that the SPI for getting text was unnecessarily inefficient, so I fixed that too.
- WebView/WebTextIterator.h: Moved currentNode and currentText into a "deprecated" category. Added currentTextPointer and currentTextLength.
- WebView/WebTextIterator.mm: Changed m_textIterator into an OwnPtr, and also used _textIterator to be consistent with ObjC rather than C++ naming. (+[WebTextIteratorPrivate initialize]): Added. Calls WebCoreObjCFinalizeOnMainThread, since the finalize method here works with main-thread only WebCore objects. (-[WebTextIterator initWithRange:]): Changed since _textIterator is an OwnPtr now. (-[WebTextIterator advance]): Changed name of m_textIterator. Removed null assertion, since I don't think it provides much value. (-[WebTextIterator atEnd]): Ditto. (-[WebTextIterator currentRange]): Added. (-[WebTextIterator currentTextPointer]): Added. (-[WebTextIterator currentTextLength]): Added. (-[WebTextIterator currentNode]): Did same as above, but also put into new category. (-[WebTextIterator currentText]): Ditto.
- 12:19 PM Changeset in webkit [39714] by
-
- 11 edits in trunk
2009-01-08 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Simplify Mac interfaces for drawing media controller elements
<rdar://problem/6293969>
- WebCore.base.exp: update for changed WebKitSystemInterface media controller functions
- platform/mac/WebCoreSystemInterface.h: Ditto
- platform/mac/WebCoreSystemInterface.mm: Ditto
- rendering/MediaControlElements.h: (WebCore::): Add MediaControlElements enum
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaFullscreenButton): update for changed WebKitSystemInterface media controller functions (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto
2009-01-08 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele Peterson.
Simplify Mac interfaces for drawing media controller elements
<rdar://problem/6293969>
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Update for changes to media controller functions
- 11:45 AM Changeset in webkit [39713] by
-
- 8 edits in trunk/WebCore
2009-01-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Commit the right files this time! (Instead of the ugly unfixed ones.)
https://bugs.webkit.org/show_bug.cgi?id=23191
- platform/graphics/skia/BitmapImageSingleFrameSkia.h:
- platform/graphics/skia/FloatPointSkia.cpp:
- platform/graphics/skia/FloatRectSkia.cpp:
- platform/graphics/skia/IntPointSkia.cpp:
- platform/graphics/skia/IntRectSkia.cpp: (WebCore::IntRect::operator SkRect):
- platform/graphics/skia/SkiaUtils.cpp: (WebCore::): (WebCore::WebCoreCompositeToSkiaComposite): (WebCore::SkPMColorToWebCoreColor): (WebCore::IntersectRectAndRegion): (WebCore::ClipRectToCanvas): (WebCore::SkPathContainsPoint): (WebCore::scratchContext):
- platform/graphics/skia/SkiaUtils.h: (WebCore::WebCoreFloatToSkScalar): (WebCore::WebCoreDoubleToSkScalar):
- 10:58 AM Changeset in webkit [39712] by
-
- 1 edit8 adds in trunk/WebCore
2009-01-08 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add the first few files from platform/graphics/skia
https://bugs.webkit.org/show_bug.cgi?id=23191
These are all pretty simple.
Eventually BitmapImageSingleFrameSkia might grow a .cpp file, for now it's just a header.
SkiaUtils needs to die, but that can come later, no need to block up-streaming now.
- platform/graphics/skia/BitmapImageSingleFrameSkia.h: Added. (WebCore::BitmapImageSingleFrameSkia::isBitmapImage): (WebCore::BitmapImageSingleFrameSkia::size): (WebCore::BitmapImageSingleFrameSkia::destroyDecodedData): (WebCore::BitmapImageSingleFrameSkia::decodedSize): (WebCore::BitmapImageSingleFrameSkia::nativeImageForCurrentFrame): (WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
- platform/graphics/skia/FloatPointSkia.cpp: Copied from WebCore/platform/graphics/mac/FloatPointMac.mm. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator SkPoint):
- platform/graphics/skia/FloatRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator SkRect):
- platform/graphics/skia/IntPointSkia.cpp: Copied from WebCore/platform/graphics/win/IntPointWin.cpp. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator SkIPoint): (WebCore::IntPoint::operator SkPoint):
- platform/graphics/skia/IntRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp. (WebCore::IntRect::operator SkIRect): (WebCore::IntRect::operator SkRect): (WebCore::IntRect::IntRect):
- platform/graphics/skia/SkiaUtils.cpp: Added. (WebCore::WebCorePointToSkiaPoint): (WebCore::WebCoreRectToSkiaRect): (WebCore::): (WebCore::WebCoreCompositeToSkiaComposite): (WebCore::InvScaleByte): (WebCore::SkPMColorToColor): (WebCore::SkPMColorToWebCoreColor): (WebCore::IntersectRectAndRegion): (WebCore::ClipRectToCanvas): (WebCore::SkPathContainsPoint): (WebCore::scratchContext):
- platform/graphics/skia/SkiaUtils.h: Added. (WebCore::WebCoreFloatToSkScalar): (WebCore::WebCoreDoubleToSkScalar):
- 10:24 AM Changeset in webkit [39711] by
-
- 8 edits4 adds in trunk
2009-01-08 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Dan Bernstein.
Fixed CSS Transitions with zero-duration but non-zero-delay not starting or ending properly.
Also updated AnimationController::numberOfActiveAnimations() which now returns the number of "active" animations,
instead of simply the "running" ones.
Tests: transitions/zero-duration-with-non-zero-delay-end.html
transitions/zero-duration-with-non-zero-delay-start.html
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::animationTimerFired):
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):
Added layout tests for CSS Transitions with zero-duration but non-zero-delay.
Also updated the layout test for DRT API numberOfActiveAnimations() which now returns the number of "active" animations,
instead of simply the running ones.
- animations/animation-controller-drt-api-expected.txt:
- animations/animation-controller-drt-api.html:
- platform/win/Skipped:
- transitions/zero-duration-with-non-zero-delay-end-expected.txt: Added.
- transitions/zero-duration-with-non-zero-delay-end.html: Added.
- transitions/zero-duration-with-non-zero-delay-start-expected.txt: Added.
- transitions/zero-duration-with-non-zero-delay-start.html: Added.
- 9:50 AM Changeset in webkit [39710] by
-
- 2 edits in trunk/WebKitSite
2009-01-08 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adele Petersen.
Landed by Pamela Greene.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=23139
Remove links to no-longer-existing Drosera project.
Also, clean up references to wiki in the nav.inc file.
- nav.inc: Correct paths to wiki, swap Drosera for Web Inspector.
- 9:05 AM Changeset in webkit [39709] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
<rdar://problem/6477501> Repro crash loading HTML5 AppCache manifest directly
The crash happened whenever a cached resource was downloaded, as opposed to used directly.
No test, as downloading cannot be tested automatically.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Cancel downloads that do not have an associated ResourceHandle, such as downloads from the application cache. Activity window shows "The URL can't be shown", and the frame remains empty.
- 8:47 AM Changeset in webkit [39708] by
-
- 4 edits1 add in trunk/JavaScriptCore
2009-01-08 Jian Li <jianli@chromium.org>
Reviewed by Alexey Proskuryakov.
Add Win32 implementation of ThreadSpecific.
https://bugs.webkit.org/show_bug.cgi?id=22614
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- wtf/ThreadSpecific.h: (WTF::ThreadSpecific::ThreadSpecific): (WTF::ThreadSpecific::~ThreadSpecific): (WTF::ThreadSpecific::get): (WTF::ThreadSpecific::set): (WTF::ThreadSpecific::destroy):
- wtf/ThreadSpecificWin.cpp: Added. (WTF::ThreadSpecificThreadExit):
- wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint):
- 7:58 AM Changeset in webkit [39707] by
-
- 3 edits in trunk/JavaScriptCore
2009-01-08 Justin McPherson <justin.mcpherson@nokia.com>
Reviewed by Simon Hausmann.
Fix compilation with Qt on NetBSD.
- 7:51 AM Changeset in webkit [39706] by
-
- 4 edits in trunk
Don't set the minimumFontSize and minimumLogicalFontSize as these are
just for accessibility and should be left up to the client application.
- 7:50 AM Changeset in webkit [39705] by
-
- 2 edits in trunk/WebCore
2009-01-08 Justin McPherson <justin.mcpherson@nokia.com>
Reviewed by Simon Hausmann.
Fix the Qt build on older X11 systems with special X paths
needed for NPAPI.
- 7:21 AM Changeset in webkit [39704] by
-
- 4 edits in trunk/WebKit/qt
2009-01-08 Kavindra Palaraja <kdpalara@trolltech.com>
Reviewed by Simon Hausmann.
Small fixes to the API documentation, missing 4.5 tags and
undocumented parameters.
- 7:04 AM Changeset in webkit [39703] by
-
- 2 edits in trunk/WebCore
Windows build fix after r39699
- DerivedSources.cpp: Added JSDOMStringList.cpp.
- 5:47 AM Changeset in webkit [39702] by
-
- 2 edits in trunk/WebCore
2009-01-08 Kent Hansen <khansen@trolltech.com>
Reviewed by Simon Hausmann.
Fix copy & paste of images in the Qt port.
Store the QPixmap itself in the mimedata, not a QPixmap* converted to bool.
- 4:33 AM Changeset in webkit [39701] by
-
- 2 edits in trunk/WebCore
2009-01-08 Hiroyuki Ikezoe <poincare@ikezoe.net>
Reviewed by Holger Freyther.
Invoke pango_coverage_get with each Unicode character.
- platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::containsCharacters):
- 4:32 AM Changeset in webkit [39700] by
-
- 3 edits in trunk/WebKit/gtk
Add webkit_web_view_reload_bypass_cache.
- 3:54 AM Changeset in webkit [39699] by
-
- 15 edits8 adds in trunk
Reviewed by Darin Adler.
Part one of
https://bugs.webkit.org/show_bug.cgi?id=23165
Add support for application cache dynamic entries
Test: http/tests/appcache/dynamic-entries-no-cache.html
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl: Added new files.
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem): Added binding for hasItem(). Like other DOMApplicationCache methods, it needs to be custom to resolve relative URLs correctly.
- bindings/js/JSDOMStringListCustom.cpp: Added.
- dom/DOMStringList.cpp: Added.
- dom/DOMStringList.h: Added.
- dom/DOMStringList.idl: Added. Added an implementation of DOM 3 Core DOMStringList interface, which is returned by DOMApplicationCache items attribute.
- dom/StaticStringList.cpp: Added.
- dom/StaticStringList.h: Added. An implementation of DOMStringList that makes a snapshot (for DOMApplicationCache, this matches Firefox, as the spec doesn't say whether the returned list should be live or not).
- loader/appcache/ApplicationCache.h: Added a list of pending dynamic entry actions, to be used in the near future.
- loader/appcache/DOMApplicationCache.idl: Updated for spec changes. Instead of length attribute and item(), we now have an items attribute that returns a DOMStringList, and a hasItem convenience method.
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::items): (WebCore::DOMApplicationCache::hasItem):
- loader/appcache/DOMApplicationCache.h: Added implementations of items attribute and hasItem() (note that underlying ApplicationCache methods are still unimplemented though).
- page/DOMWindow.idl: Expose a DOMStringList global constructor.
Jan 7, 2009:
- 10:15 PM Changeset in webkit [39698] by
-
- 2 edits in trunk/WebKit/win
2009-01-07 Jon Honeycutt <jhoneycutt@apple.com>
Fix a crash with querying a WebView for its global history item when
its associated Page has no global history item.
Reviewed by Dan Bernstein.
- WebView.cpp: (WebView::globalHistoryItem): If the Page has no global history item, report 0.
- 5:46 PM Changeset in webkit [39697] by
-
- 14 edits in trunk/JavaScriptCore
2009-01-07 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
<rdar://problem/6469060> Don't store exception information for a CodeBlock until first exception is thrown
Don't initially store exception information (lineNumber/expressionRange/getByIdExcecptionInfo)
in CodeBlocks blocks. Instead, re-parse for the data on demand and cache it then.
One important change that was needed to make this work was to pad op_get_global_var with nops to
be the same length as op_resolve_global, since one could be replaced for the other on re-parsing,
and we want to keep the offsets bytecode offsets the same.
1.3MB improvement on Membuster head.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): Update op_get_global_var to account for the padding. (JSC::CodeBlock::dumpStatistics): Add more statistic dumping. (JSC::CodeBlock::CodeBlock): Initialize m_exceptionInfo. (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): Re-parses the CodeBlocks associated SourceCode and steals the ExceptionInfo from it. (JSC::CodeBlock::lineNumberForBytecodeOffset): Creates the exception info on demand. (JSC::CodeBlock::expressionRangeForBytecodeOffset): Ditto. (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset): Ditto.
- bytecode/CodeBlock.h: (JSC::CodeBlock::numberOfExceptionHandlers): Updated to account for m_exceptionInfo indirection. (JSC::CodeBlock::addExceptionHandler): Ditto. (JSC::CodeBlock::exceptionHandler): Ditto. (JSC::CodeBlock::clearExceptionInfo): Ditto. (JSC::CodeBlock::addExpressionInfo): Ditto. (JSC::CodeBlock::addGetByIdExceptionInfo): Ditto. (JSC::CodeBlock::numberOfLineInfos): Ditto. (JSC::CodeBlock::addLineInfo): Ditto. (JSC::CodeBlock::lastLineInfo): Ditto.
- bytecode/Opcode.h: Change length of op_get_global_var to match op_resolve_global.
- bytecode/SamplingTool.cpp: (JSC::SamplingTool::dump): Add comment indicating why it is okay not to pass a CallFrame.
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): Clear the exception info after generation for Function and Eval Code when not in regenerate for exception info mode. (JSC::BytecodeGenerator::BytecodeGenerator): Initialize m_regeneratingForExceptionInfo to false. (JSC::BytecodeGenerator::emitGetScopedVar): Pad op_get_global_var with 2 nops.
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::setRegeneratingForExcpeptionInfo): Added.
- interpreter/Interpreter.cpp: (JSC::Interpreter::throwException): Pass the CallFrame to exception info accessors. (JSC::Interpreter::privateExecute): Ditto. (JSC::Interpreter::retrieveLastCaller): Ditto. (JSC::Interpreter::cti_op_new_error): Ditto.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): Pass the current bytecode offset instead of hard coding the line number, the stub will do the accessing if it gets called.
- parser/Nodes.cpp: (JSC::ProgramNode::emitBytecode): Moved. (JSC::ProgramNode::generateBytecode): Moved. (JSC::EvalNode::create): Moved. (JSC::EvalNode::bytecodeForExceptionInfoReparse): Added. (JSC::FunctionBodyNode::generateBytecode): Rename reparse to reparseInPlace. (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse): Addded.
- parser/Nodes.h: (JSC::ScopeNode::features): Added getter.
- parser/Parser.cpp: (JSC::Parser::reparseInPlace): Renamed from reparse.
- parser/Parser.h: (JSC::Parser::reparse): Added. Re-parses the passed in Node into a new Node.
- runtime/ExceptionHelpers.cpp: (JSC::createUndefinedVariableError): Pass along CallFrame. (JSC::createInvalidParamError): Ditto. (JSC::createNotAConstructorError): Ditto. (JSC::createNotAFunctionError): Ditto. (JSC::createNotAnObjectError): Ditto.
- 5:37 PM Changeset in webkit [39696] by
-
- 7 edits in trunk/WebCore
This completes the removal of dependencies on WebKit from the platform code
- 5:28 PM Changeset in webkit [39695] by
-
- 2 edits in trunk/WebKitTools
2009-01-07 Glenn Wilson <gwilson@chromium.org>
Reviewed by Eric Seidel.
Changed DumpRenderTree to re-enable Javascript in web preferences on every test.
This fixes the case when a user mistakenly disables Javascript, and all layout tests crash.
- DumpRenderTree/mac/DumpRenderTree.mm: (testStringByEvaluatingJavaScriptFromString): (setDefaultsToConsistentValuesForTesting):
- 4:27 PM Changeset in webkit [39694] by
-
- 7 edits in trunk/WebCore
2008-01-07 Peter Kasting <pkasting@google.com>
Reviewed by Sam Weinig.
Fix errors while decoding GIFs by not calling setData() repeatedly
when it's not necessary. Pushes the responsibility for calling
setData() after clear() into the ImageSource which presumably knows
better than BitmapImage what needs to be done.
NOTE: The above bug is mainly about a memory regression, which this
patch does not fix.
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
- platform/graphics/ImageSource.h:
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::clear):
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear):
- platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear):
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear):
- 4:23 PM Changeset in webkit [39693] by
-
- 3 edits2 adds in trunk
WebCore:
2009-01-07 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6355786> Find fails for queries that contain a line break
- editing/TextIterator.cpp: (WebCore::findPlainText): Allow find with queries that contain newlines.
LayoutTests:
2009-01-07 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6355786> Find fails for queries that contain a line break
- editing/execCommand/6355786-expected.txt: Added.
- editing/execCommand/6355786.html: Added.
- 4:00 PM Changeset in webkit [39692] by
-
- 1 edit in trunk/WebCore/ChangeLog
2009-01-07 Dean Jackson <dino@apple.com>
Typo in ChangeLog. Don't want to offend mitz.
- 3:56 PM Changeset in webkit [39691] by
-
- 3 edits2 adds in trunk
2009-01-07 Dean Jackson <dino@apple.com>
Reviewed by Dan Berstein.
Allow removal of inline shorthand properties for
animation, transition and transform origin. Also
add getter for shorthand animation property.
Test: fast/css/transform-inline-style-remove.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
Getter for animation property shorthand
(WebCore::initShorthandMap):
Adds initialisation for transform-origin, animation and transition
- 3:43 PM Changeset in webkit [39690] by
-
- 3 edits in trunk/WebCore
2009-01-07 Benjamin Otte <otte@gnome.org>
Reviewed by Holger Freyther.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::parseDataUrl): (WebCore::ResourceHandle::startData): keep track of the idle handler we add and remove it in the destructor
- 3:24 PM Changeset in webkit [39689] by
-
- 5 edits in trunk
Implement LayoutTestController::numberOfActiveAnimations for Gtk+.
Add private API to WebKitWebFrame to get the information. The
implementation is coming from WebFrame.mm.
- 3:02 PM Changeset in webkit [39688] by
-
- 9 edits4 moves in trunk/WebCore
2009-01-07 Dean Jackson <dino@apple.com>
Reviewed by Darin Adler.
Finish renaming of AffineTransform to TransformationMatrix, this
time ensuring that the platform implementations get the correct
name. Also, clean up some whitespace cruft in old content.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/cairo/AffineTransformCairo.cpp: Removed.
- platform/graphics/cairo/TransformationMatrixCairo.cpp: Copied from WebCore/platform/graphics/cairo/AffineTransformCairo.cpp.
- platform/graphics/cg/AffineTransformCG.cpp: Removed.
- platform/graphics/cg/TransformationMatrixCG.cpp: Copied from WebCore/platform/graphics/cg/AffineTransformCG.cpp.
- platform/graphics/qt/AffineTransformQt.cpp: Removed.
- platform/graphics/qt/TransformationMatrixQt.cpp: Copied from WebCore/platform/graphics/qt/AffineTransformQt.cpp.
- platform/graphics/transforms/TransformationMatrix.cpp:
- platform/graphics/transforms/TransformationMatrix.h:
- platform/graphics/wx/AffineTransformWx.cpp: Removed.
- platform/graphics/wx/TransformationMatrixWx.cpp: Copied from WebCore/platform/graphics/wx/AffineTransformWx.cpp.
- webcore-wx.bkl:
- 2:57 PM Changeset in webkit [39687] by
-
- 3 edits in trunk/LayoutTests
2009-01-07 Pierre-Olivier Latour <pol@apple.com>
Improve DRT API existence test in animation-test-helpers.js & transition-test-helpers.js.
- animations/animation-test-helpers.js:
- transitions/transition-test-helpers.js:
- 2:33 PM Changeset in webkit [39686] by
-
- 2 edits in trunk/WebCore
2009-01-07 Anders Carlsson <andersca@apple.com>
Another build fix.
- WebCore.LP64.exp:
- 2:30 PM Changeset in webkit [39685] by
-
- 3 edits in trunk/WebKit/mac
2009-01-07 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Fix build.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::idForObject):
- 2:03 PM Changeset in webkit [39684] by
-
- 5 edits in trunk/WebKit/mac
2009-01-07 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Add a way for a plug-in to get a reference to the Window JS object.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetWindowNPObject): Call the appropriate instance.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: Add object ID counter.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy): Clear the object ID map.
(WebKit::NetscapePluginInstanceProxy::idForObject):
New method that returns a unique ID for a given JS object.
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
Return the object ID for the window JS object.
- Plugins/Hosted/WebKitPluginClient.defs: Add GetWindowNPObject.
- 12:24 PM Changeset in webkit [39683] by
-
- 4 edits in trunk/WebCore
2008-12-16 David Hyatt <hyatt@apple.com>
Make Safari RSS behave nicely with full page zoom. Need to add a new value to enable resetting of zoom
back to the document-level default.
Reviewed by Darin Adler
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- 7:58 AM Changeset in webkit [39682] by
-
- 3 edits in trunk/WebKit/win
Fix Bug 22262: Clicking close ("X") button in docked Web Inspector clears Web Inspector but doesn't close it
<https://bugs.webkit.org/show_bug.cgi?id=22262>
<rdar://problem/6371873>
Reviewed by Darin Adler.
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::WebInspectorClient): Initialize new member. (WebInspectorClient::showWindow): Moved code from here to showWindowWithoutNotifications. (WebInspectorClient::closeWindow): Moved code from here to closeWindowWithoutNotifications.
(WebInspectorClient::attachWindow):
(WebInspectorClient::detachWindow):
Record whether or not we should be attached, then close and reopen the
window without notifying the InspectorController. Code that was in
these functions moved to showWindowWithoutNotifications and
closeWindowWithoutNotifications, respectively.
(WebInspectorClient::closeWindowWithoutNotifications): Added. Code
came from closeWindow and detachWindow.
(WebInspectorClient::showWindowWithoutNotifications): Added. Code came
from showWindow and attachWindow.
- WebCoreSupport/WebInspectorClient.h: Added {close,show}WindowWithoutNotifications and m_shouldAttachWhenShown.
- 7:40 AM Changeset in webkit [39681] by
-
- 12 edits in trunk
WebCore:
2009-01-07 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
https://bugs.webkit.org/show_bug.cgi?id=23160
- WebCore.base.exp: Added Page::setMemoryCacheClientCallsEnabled.
- inspector/InspectorController.cpp: (WebCore::InspectorController::didLoadResourceFromMemoryCache): Updated to take a CachedResource so that there's no extra work the caller has to do when the inspector is disabled.
- inspector/InspectorController.h: Ditto.
- loader/DocumentLoader.h: Added recordMemoryCacheLoadForFutureClientNotification, takeMemoryCacheLoadsForClientNotification, and m_resourcesLoadedFromMemoryCacheForClientNotification.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache): Streamlined code so less work is done when there's no inspector or client call needed. Added code to check areMemoryCacheClientCallsEnabled and if it's false, use recordMemoryCacheLoadForFutureClientNotification. (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Added.
- loader/FrameLoader.h: Ditto.
- page/Page.cpp: (WebCore::Page::Page): Initialize m_areMemoryCacheClientCallsEnabled to be compatible with old behavior. (WebCore::Page::setMemoryCacheClientCallsEnabled): Added.
- page/Page.h: Added setMemoryCacheClientCallsEnabled, areMemoryCacheClientCallsEnabled, and m_areMemoryCacheClientCallsEnabled.
WebKit/mac:
2009-01-07 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
https://bugs.webkit.org/show_bug.cgi?id=23160
- WebView/WebView.mm: (-[WebView setMemoryCacheDelegateCallsEnabled:]): Added. (-[WebView areMemoryCacheDelegateCallsEnabled]): Added
- WebView/WebViewPrivate.h: Ditto.
- 7:35 AM Changeset in webkit [39680] by
-
- 4 edits in trunk/WebKit/qt
Add Qt API to QWebHitTestResult::isScrollBar method
- 7:35 AM Changeset in webkit [39679] by
-
- 3 edits in trunk/WebKit/qt
Add Qt API for QWebFrame::scrollBarGeometry method
- 7:24 AM Changeset in webkit [39678] by
-
- 7 edits in trunk
Fix unused variable warnings
- 7:15 AM Changeset in webkit [39677] by
-
- 9 edits in trunk
2009-01-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Simon Hausmann.
Qt build fix after r39670.
- bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject):
- bridge/qt/qt_class.h:
- bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::mark): (JSC::Bindings::QtInstance::invokeMethod): (JSC::Bindings::QtInstance::defaultValue): (JSC::Bindings::QtInstance::stringValue): (JSC::Bindings::QtInstance::numberValue): (JSC::Bindings::QtInstance::booleanValue): (JSC::Bindings::QtInstance::valueOf): (JSC::Bindings::QtField::valueFromInstance): (JSC::Bindings::QtField::setValueToInstance):
- bridge/qt/qt_instance.h:
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::valueRealType): (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue): (JSC::Bindings::findMethodIndex): (JSC::Bindings::QtRuntimeMetaMethod::call): (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): (JSC::Bindings::QtRuntimeConnectionMethod::call): (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter): (JSC::Bindings::::setValueAt): (JSC::Bindings::::valueAt):
- bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethod::createStructure):
2009-01-07 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Simon Hausmann.
Qt build fix after r39670.
- Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
- 2:01 AM QtWebKitJournal edited by
- (diff)
- 2:01 AM QtWebKitJournal edited by
- (diff)
- 2:00 AM QtWebKitJournal edited by
- (diff)
- 2:00 AM QtWebKitJournal edited by
- (diff)
- 12:45 AM Changeset in webkit [39676] by
-
- 2 edits in trunk/WebKit/qt
2009-01-06 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Holger Freyther.
Allow building QtWebKit statically (within Qt).
http://trolltech.com/developer/task-tracker/index_html?id=211273&method=entry
- Api/qwebkitglobal.h:
- 12:16 AM Changeset in webkit [39675] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-06 Gavin Barraclough <baraclough@apple.com>
Reviewed by Maciej Stachowiak.
Replace accidentally removed references in BytecodeGenerator, deleting these
will be hindering the sharing of constant numbers and strings.
The code to add a new constant (either number or string) to their respective
map works by attempting to add a null entry, then checking the result of the
add for null. The first time, this should return the null (or noValue).
The code checks for null (to see if this is the initial add), and then allocates
a new number / string object. This code relies on the result returned from
the add to the map being stored as a reference, such that the allocated object
will be stored in the map, and will be resused if the same constant is encountered
again. By failing to use a reference we will be leaking GC object for each
additional entry added to the map. As GC objects they should be clollected,
be we should no be allocatin them in the first place.
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
- 12:07 AM Changeset in webkit [39674] by
-
- 2 edits in trunk/WebCore
2009-01-06 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6391734> SnowLeopard: Crash doing Copy Image from context menu
Can't create an automated test case for specific contextual menu items yet and
a normal Copy doesn't cause a crash.
- platform/mac/PasteboardMac.mm: (WebCore::fileWrapperForImage): The SharedBuffer may not have platform data. It may, for example, have a purgeable or regular buffer.
Jan 6, 2009:
- 11:41 PM Changeset in webkit [39673] by
-
- 3 edits in trunk/JavaScriptCore
<rdar://problem/6040850> JavaScript register file should use VirtualAlloc on Windows
Reviewed by Gavin Barraclough.
Fairly simple, just reserve 4Mb of address space for the
register file, and then commit one section at a time. We
don't release committed memory as we drop back, but then
mac doesn't either so this probably not too much of a
problem.
- 11:24 PM Changeset in webkit [39672] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23142
ThreadGlobalData leaks seen on buildbot
- wtf/ThreadSpecific.h: (WTF::ThreadSpecific::destroy): Temporarily reset the thread specific value to make getter work on Mac OS X.
- wtf/Platform.h: Touch this file again to make sure all Windows builds use the most recent version of ThreadSpecific.h.
- 10:29 PM Changeset in webkit [39671] by
-
- 2 edits in trunk/WebCore
Fix <https://bugs.webkit.org/show_bug.cgi?id=23157>.
Bug 23157: Crashes on Acid 3
Reviewed by Geoff Garen.
- dom/Document.cpp:
(WebCore::Document::recalcStyle): Null-check the frame.
- 9:11 PM Changeset in webkit [39670] by
-
- 297 edits in trunk
2009-01-05 Gavin Barraclough <baraclough@apple.com>
Reviewed by Oliver Hunt.
Replace all uses of JSValue* with a new smart pointer type, JSValuePtr.
A JavaScript value may be a heap object or boxed primitive, represented by a
pointer, or may be an unboxed immediate value, such as an integer. Since a
value may dynamically need to contain either a pointer value or an immediate,
we encode immediates as pointer values (since all valid JSCell pointers are
allocated at alligned addesses, unaligned addresses are available to encode
immediates). As such all JavaScript values are represented using a JSValue*.
This implementation is encumbered by a number of constraints. It ties the
JSValue representation to the size of pointer on the platform, which, for
example, means that we currently can represent different ranges of integers
as immediates on x86 and x86-64. It also prevents us from overloading the
to-boolean conversion used to test for noValue() - effectively forcing us
to represent noValue() as 0. This would potentially be problematic were we
to wish to encode integer values differently (e.g. were we to use the v8
encoding, where pointers are tagged with 1 and integers with 0, then the
immediate integer 0 would conflict with noValue()).
This patch replaces all usage of JSValue* with a new class, JSValuePtr,
which encapsulates the pointer. JSValuePtr maintains the same interface as
JSValue*, overloading operator-> and operator bool such that previous
operations in the code on variables of type JSValue* are still supported.
In order to provide a ProtectPtr<> type with support for the new value
representation (without using the internal JSValue type directly), a new
ProtectJSValuePtr type has been added, equivalent to the previous type
ProtectPtr<JSValue>.
This patch is likely the first in a sequence of three changes. With the
value now encapsulated it will likely make sense to migrate the functionality
from JSValue into JSValuePtr, such that the internal pointer representation
need not be exposed. Through migrating the functionality to the wrapper
class the existing JSValue should be rendered redundant, and the class is
likely to be removed (the JSValuePtr now wrapping a pointer to a JSCell).
At this stage it will likely make sense to rename JSValuePtr to JSValue.
- API/APICast.h: (toJS): (toRef):
- API/JSBase.cpp: (JSEvaluateScript):
- API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
- API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
- API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
- API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
- API/JSCallbackObjectFunctions.h: (JSC::::asCallbackObject): (JSC::::put): (JSC::::hasInstance): (JSC::::call): (JSC::::staticValueGetter): (JSC::::staticFunctionGetter): (JSC::::callbackGetter):
- API/JSContextRef.cpp:
- API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrototype): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex):
- API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueIsEqual): (JSValueIsStrictEqual): (JSValueIsInstanceOfConstructor): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject): (JSValueProtect): (JSValueUnprotect):
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp: (JSC::valueToSourceString): (JSC::constantName): (JSC::CodeBlock::dump):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getConstant): (JSC::CodeBlock::addUnexpectedConstant): (JSC::CodeBlock::unexpectedConstant):
- bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::get):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::addConstant): (JSC::BytecodeGenerator::addUnexpectedConstant): (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitLoadJSV): (JSC::BytecodeGenerator::emitGetScopedVar): (JSC::BytecodeGenerator::emitPutScopedVar): (JSC::BytecodeGenerator::emitNewError): (JSC::keyForImmediateSwitch):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue): (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
- debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
- debugger/DebuggerCallFrame.h: (JSC::DebuggerCallFrame::DebuggerCallFrame): (JSC::DebuggerCallFrame::exception):
- interpreter/CallFrame.cpp: (JSC::CallFrame::thisValue):
- interpreter/CallFrame.h: (JSC::ExecState::setException): (JSC::ExecState::exception): (JSC::ExecState::exceptionSlot): (JSC::ExecState::hadException):
- interpreter/Interpreter.cpp: (JSC::fastIsNumber): (JSC::fastToInt32): (JSC::fastToUInt32): (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAddSlowCase): (JSC::jsAdd): (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::jsIsFunctionType): (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::inlineResolveBase): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::resolveBaseAndFunc): (JSC::isNotObject): (JSC::Interpreter::callEval): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::execute): (JSC::Interpreter::checkTimeout): (JSC::Interpreter::createExceptionScope): (JSC::cachePrototypeChain): (JSC::Interpreter::tryCachePutByID): (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments): (JSC::Interpreter::retrieveCaller): (JSC::Interpreter::retrieveLastCaller): (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::returnToThrowTrampoline): (JSC::Interpreter::cti_op_convert_this): (JSC::Interpreter::cti_op_add): (JSC::Interpreter::cti_op_pre_inc): (JSC::Interpreter::cti_op_loop_if_less): (JSC::Interpreter::cti_op_loop_if_lesseq): (JSC::Interpreter::cti_op_get_by_id_generic): (JSC::Interpreter::cti_op_get_by_id): (JSC::Interpreter::cti_op_get_by_id_second): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_op_get_by_id_proto_list_full): (JSC::Interpreter::cti_op_get_by_id_proto_fail): (JSC::Interpreter::cti_op_get_by_id_array_fail): (JSC::Interpreter::cti_op_get_by_id_string_fail): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_del_by_id): (JSC::Interpreter::cti_op_mul): (JSC::Interpreter::cti_op_call_NotJSFunction): (JSC::Interpreter::cti_op_resolve): (JSC::Interpreter::cti_op_construct_NotJSConstruct): (JSC::Interpreter::cti_op_get_by_val): (JSC::Interpreter::cti_op_resolve_func): (JSC::Interpreter::cti_op_sub): (JSC::Interpreter::cti_op_put_by_val): (JSC::Interpreter::cti_op_put_by_val_array): (JSC::Interpreter::cti_op_lesseq): (JSC::Interpreter::cti_op_loop_if_true): (JSC::Interpreter::cti_op_negate): (JSC::Interpreter::cti_op_resolve_base): (JSC::Interpreter::cti_op_resolve_skip): (JSC::Interpreter::cti_op_resolve_global): (JSC::Interpreter::cti_op_div): (JSC::Interpreter::cti_op_pre_dec): (JSC::Interpreter::cti_op_jless): (JSC::Interpreter::cti_op_not): (JSC::Interpreter::cti_op_jtrue): (JSC::Interpreter::cti_op_post_inc): (JSC::Interpreter::cti_op_eq): (JSC::Interpreter::cti_op_lshift): (JSC::Interpreter::cti_op_bitand): (JSC::Interpreter::cti_op_rshift): (JSC::Interpreter::cti_op_bitnot): (JSC::Interpreter::cti_op_resolve_with_base): (JSC::Interpreter::cti_op_mod): (JSC::Interpreter::cti_op_less): (JSC::Interpreter::cti_op_neq): (JSC::Interpreter::cti_op_post_dec): (JSC::Interpreter::cti_op_urshift): (JSC::Interpreter::cti_op_bitxor): (JSC::Interpreter::cti_op_bitor): (JSC::Interpreter::cti_op_call_eval): (JSC::Interpreter::cti_op_throw): (JSC::Interpreter::cti_op_next_pname): (JSC::Interpreter::cti_op_typeof): (JSC::Interpreter::cti_op_is_undefined): (JSC::Interpreter::cti_op_is_boolean): (JSC::Interpreter::cti_op_is_number): (JSC::Interpreter::cti_op_is_string): (JSC::Interpreter::cti_op_is_object): (JSC::Interpreter::cti_op_is_function): (JSC::Interpreter::cti_op_stricteq): (JSC::Interpreter::cti_op_nstricteq): (JSC::Interpreter::cti_op_to_jsnumber): (JSC::Interpreter::cti_op_in): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_op_switch_char): (JSC::Interpreter::cti_op_switch_string): (JSC::Interpreter::cti_op_del_by_val): (JSC::Interpreter::cti_op_new_error): (JSC::Interpreter::cti_vm_throw):
- interpreter/Interpreter.h: (JSC::Interpreter::isJSArray): (JSC::Interpreter::isJSString):
- interpreter/Register.h: (JSC::Register::): (JSC::Register::Register): (JSC::Register::jsValue): (JSC::Register::getJSValue):
- jit/JIT.cpp: (JSC::): (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h: (JSC::): (JSC::JIT::execute):
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_rshift): (JSC::JIT::compileFastArithSlow_op_rshift):
- jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
- jit/JITInlineMethods.h: (JSC::JIT::emitGetVirtualRegister): (JSC::JIT::getConstantOperand): (JSC::JIT::isOperandConstant31BitImmediateInt): (JSC::JIT::emitPutJITStubArgFromVirtualRegister): (JSC::JIT::emitInitRegister):
- jit/JITPropertyAccess.cpp: (JSC::resizePropertyStorage): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- jsc.cpp: (functionPrint): (functionDebug): (functionGC): (functionVersion): (functionRun): (functionLoad): (functionReadline): (functionQuit):
- parser/Nodes.cpp: (JSC::NullNode::emitBytecode): (JSC::ArrayNode::emitBytecode): (JSC::FunctionCallValueNode::emitBytecode): (JSC::FunctionCallResolveNode::emitBytecode): (JSC::VoidNode::emitBytecode): (JSC::ConstDeclNode::emitCodeSingle): (JSC::ReturnNode::emitBytecode): (JSC::processClauseList): (JSC::EvalNode::emitBytecode): (JSC::FunctionBodyNode::emitBytecode): (JSC::ProgramNode::emitBytecode):
- profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::addParentForConsoleStart):
- profiler/Profiler.cpp: (JSC::Profiler::willExecute): (JSC::Profiler::didExecute): (JSC::Profiler::createCallIdentifier):
- profiler/Profiler.h:
- runtime/ArgList.cpp: (JSC::ArgList::slowAppend):
- runtime/ArgList.h: (JSC::ArgList::at): (JSC::ArgList::append):
- runtime/Arguments.cpp: (JSC::Arguments::put):
- runtime/Arguments.h: (JSC::Arguments::createStructure): (JSC::asArguments):
- runtime/ArrayConstructor.cpp: (JSC::callArrayConstructor):
- runtime/ArrayPrototype.cpp: (JSC::getProperty): (JSC::putProperty): (JSC::arrayProtoFuncToString): (JSC::arrayProtoFuncToLocaleString): (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncConcat): (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncReverse): (JSC::arrayProtoFuncShift): (JSC::arrayProtoFuncSlice): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
- runtime/BooleanConstructor.cpp: (JSC::callBooleanConstructor): (JSC::constructBooleanFromImmediateBoolean):
- runtime/BooleanConstructor.h:
- runtime/BooleanObject.h: (JSC::asBooleanObject):
- runtime/BooleanPrototype.cpp: (JSC::booleanProtoFuncToString): (JSC::booleanProtoFuncValueOf):
- runtime/CallData.cpp: (JSC::call):
- runtime/CallData.h:
- runtime/Collector.cpp: (JSC::Heap::protect): (JSC::Heap::unprotect): (JSC::Heap::heap): (JSC::Heap::collect):
- runtime/Collector.h:
- runtime/Completion.cpp: (JSC::evaluate):
- runtime/Completion.h: (JSC::Completion::Completion): (JSC::Completion::value): (JSC::Completion::setValue): (JSC::Completion::isValueCompletion):
- runtime/ConstructData.cpp: (JSC::construct):
- runtime/ConstructData.h:
- runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::callDate): (JSC::dateParse): (JSC::dateNow): (JSC::dateUTC):
- runtime/DateInstance.h: (JSC::asDateInstance):
- runtime/DatePrototype.cpp: (JSC::dateProtoFuncToString): (JSC::dateProtoFuncToUTCString): (JSC::dateProtoFuncToDateString): (JSC::dateProtoFuncToTimeString): (JSC::dateProtoFuncToLocaleString): (JSC::dateProtoFuncToLocaleDateString): (JSC::dateProtoFuncToLocaleTimeString): (JSC::dateProtoFuncValueOf): (JSC::dateProtoFuncGetTime): (JSC::dateProtoFuncGetFullYear): (JSC::dateProtoFuncGetUTCFullYear): (JSC::dateProtoFuncToGMTString): (JSC::dateProtoFuncGetMonth): (JSC::dateProtoFuncGetUTCMonth): (JSC::dateProtoFuncGetDate): (JSC::dateProtoFuncGetUTCDate): (JSC::dateProtoFuncGetDay): (JSC::dateProtoFuncGetUTCDay): (JSC::dateProtoFuncGetHours): (JSC::dateProtoFuncGetUTCHours): (JSC::dateProtoFuncGetMinutes): (JSC::dateProtoFuncGetUTCMinutes): (JSC::dateProtoFuncGetSeconds): (JSC::dateProtoFuncGetUTCSeconds): (JSC::dateProtoFuncGetMilliSeconds): (JSC::dateProtoFuncGetUTCMilliseconds): (JSC::dateProtoFuncGetTimezoneOffset): (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetMilliSeconds): (JSC::dateProtoFuncSetUTCMilliseconds): (JSC::dateProtoFuncSetSeconds): (JSC::dateProtoFuncSetUTCSeconds): (JSC::dateProtoFuncSetMinutes): (JSC::dateProtoFuncSetUTCMinutes): (JSC::dateProtoFuncSetHours): (JSC::dateProtoFuncSetUTCHours): (JSC::dateProtoFuncSetDate): (JSC::dateProtoFuncSetUTCDate): (JSC::dateProtoFuncSetMonth): (JSC::dateProtoFuncSetUTCMonth): (JSC::dateProtoFuncSetFullYear): (JSC::dateProtoFuncSetUTCFullYear): (JSC::dateProtoFuncSetYear): (JSC::dateProtoFuncGetYear):
- runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
- runtime/ErrorConstructor.cpp: (JSC::callErrorConstructor):
- runtime/ErrorPrototype.cpp: (JSC::errorProtoFuncToString):
- runtime/ExceptionHelpers.cpp: (JSC::createInterruptedExecutionException): (JSC::createError): (JSC::createStackOverflowError): (JSC::createUndefinedVariableError): (JSC::createErrorMessage): (JSC::createInvalidParamError): (JSC::createNotAConstructorError): (JSC::createNotAFunctionError):
- runtime/ExceptionHelpers.h:
- runtime/FunctionConstructor.cpp: (JSC::callFunctionConstructor):
- runtime/FunctionPrototype.cpp: (JSC::callFunctionPrototype): (JSC::functionProtoFuncToString): (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall):
- runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
- runtime/GetterSetter.cpp: (JSC::GetterSetter::toPrimitive): (JSC::GetterSetter::getPrimitiveNumber):
- runtime/GetterSetter.h: (JSC::asGetterSetter):
- runtime/InitializeThreading.cpp:
- runtime/InternalFunction.h: (JSC::InternalFunction::createStructure): (JSC::asInternalFunction):
- runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot): (JSC::JSActivation::put): (JSC::JSActivation::putWithAttributes): (JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h: (JSC::JSActivation::createStructure): (JSC::asActivation):
- runtime/JSArray.cpp: (JSC::storageSize): (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::getPropertyNames): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::mark): (JSC::JSArray::sort): (JSC::JSArray::compactForSorting): (JSC::JSArray::checkConsistency): (JSC::constructArray):
- runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::createStructure): (JSC::asArray):
- runtime/JSCell.cpp: (JSC::JSCell::put): (JSC::JSCell::getJSNumber):
- runtime/JSCell.h: (JSC::asCell): (JSC::JSValue::asCell): (JSC::JSValue::toPrimitive): (JSC::JSValue::getPrimitiveNumber): (JSC::JSValue::getJSNumber):
- runtime/JSFunction.cpp: (JSC::JSFunction::call): (JSC::JSFunction::argumentsGetter): (JSC::JSFunction::callerGetter): (JSC::JSFunction::lengthGetter): (JSC::JSFunction::getOwnPropertySlot): (JSC::JSFunction::put): (JSC::JSFunction::construct):
- runtime/JSFunction.h: (JSC::JSFunction::createStructure): (JSC::asFunction):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::put): (JSC::JSGlobalObject::putWithAttributes): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::createStructure): (JSC::JSGlobalObject::GlobalPropertyInfo::GlobalPropertyInfo): (JSC::asGlobalObject): (JSC::Structure::prototypeForLookup):
- runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::decode): (JSC::globalFuncEval): (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat): (JSC::globalFuncIsNaN): (JSC::globalFuncIsFinite): (JSC::globalFuncDecodeURI): (JSC::globalFuncDecodeURIComponent): (JSC::globalFuncEncodeURI): (JSC::globalFuncEncodeURIComponent): (JSC::globalFuncEscape): (JSC::globalFuncUnescape): (JSC::globalFuncJSCPrint):
- runtime/JSGlobalObjectFunctions.h:
- runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject): (JSC::JSImmediate::toObject): (JSC::JSImmediate::prototype): (JSC::JSImmediate::toString):
- runtime/JSImmediate.h: (JSC::JSImmediate::isImmediate): (JSC::JSImmediate::isNumber): (JSC::JSImmediate::isPositiveNumber): (JSC::JSImmediate::isBoolean): (JSC::JSImmediate::isUndefinedOrNull): (JSC::JSImmediate::isNegative): (JSC::JSImmediate::isEitherImmediate): (JSC::JSImmediate::isAnyImmediate): (JSC::JSImmediate::areBothImmediate): (JSC::JSImmediate::areBothImmediateNumbers): (JSC::JSImmediate::andImmediateNumbers): (JSC::JSImmediate::xorImmediateNumbers): (JSC::JSImmediate::orImmediateNumbers): (JSC::JSImmediate::rightShiftImmediateNumbers): (JSC::JSImmediate::canDoFastAdditiveOperations): (JSC::JSImmediate::addImmediateNumbers): (JSC::JSImmediate::subImmediateNumbers): (JSC::JSImmediate::incImmediateNumber): (JSC::JSImmediate::decImmediateNumber): (JSC::JSImmediate::makeValue): (JSC::JSImmediate::makeInt): (JSC::JSImmediate::makeBool): (JSC::JSImmediate::makeUndefined): (JSC::JSImmediate::makeNull): (JSC::JSImmediate::intValue): (JSC::JSImmediate::uintValue): (JSC::JSImmediate::boolValue): (JSC::JSImmediate::rawValue): (JSC::JSImmediate::trueImmediate): (JSC::JSImmediate::falseImmediate): (JSC::JSImmediate::undefinedImmediate): (JSC::JSImmediate::nullImmediate): (JSC::JSImmediate::zeroImmediate): (JSC::JSImmediate::oneImmediate): (JSC::JSImmediate::impossibleValue): (JSC::JSImmediate::toBoolean): (JSC::JSImmediate::getTruncatedUInt32): (JSC::JSImmediate::from): (JSC::JSImmediate::getTruncatedInt32): (JSC::JSImmediate::toDouble): (JSC::JSImmediate::getUInt32): (JSC::jsNull): (JSC::jsBoolean): (JSC::jsUndefined): (JSC::JSValue::isUndefined): (JSC::JSValue::isNull): (JSC::JSValue::isUndefinedOrNull): (JSC::JSValue::isBoolean): (JSC::JSValue::getBoolean): (JSC::JSValue::toInt32): (JSC::JSValue::toUInt32): (JSC::toInt32): (JSC::toUInt32):
- runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::toPrimitive): (JSC::JSNotAnObject::getPrimitiveNumber): (JSC::JSNotAnObject::put):
- runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
- runtime/JSNumberCell.cpp: (JSC::JSNumberCell::toPrimitive): (JSC::JSNumberCell::getPrimitiveNumber): (JSC::JSNumberCell::getJSNumber): (JSC::jsNumberCell): (JSC::jsNaN):
- runtime/JSNumberCell.h: (JSC::JSNumberCell::createStructure): (JSC::asNumberCell): (JSC::jsNumber): (JSC::JSValue::toJSNumber):
- runtime/JSObject.cpp: (JSC::JSObject::mark): (JSC::JSObject::put): (JSC::JSObject::putWithAttributes): (JSC::callDefaultValueFunction): (JSC::JSObject::getPrimitiveNumber): (JSC::JSObject::defaultValue): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::lookupGetter): (JSC::JSObject::lookupSetter): (JSC::JSObject::hasInstance): (JSC::JSObject::toNumber): (JSC::JSObject::toString): (JSC::JSObject::fillGetterPropertySlot):
- runtime/JSObject.h: (JSC::JSObject::getDirect): (JSC::JSObject::getDirectLocation): (JSC::JSObject::offsetForLocation): (JSC::JSObject::locationForOffset): (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::createStructure): (JSC::asObject): (JSC::JSObject::prototype): (JSC::JSObject::setPrototype): (JSC::JSObject::inlineGetOwnPropertySlot): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::getPropertySlot): (JSC::JSObject::get): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::toPrimitive): (JSC::JSValue::get): (JSC::JSValue::put): (JSC::JSObject::allocatePropertyStorageInline):
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::toPrimitive): (JSC::JSPropertyNameIterator::getPrimitiveNumber):
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::next):
- runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::put): (JSC::JSStaticScopeObject::putWithAttributes):
- runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::JSStaticScopeObject): (JSC::JSStaticScopeObject::createStructure):
- runtime/JSString.cpp: (JSC::JSString::toPrimitive): (JSC::JSString::getPrimitiveNumber): (JSC::JSString::getOwnPropertySlot):
- runtime/JSString.h: (JSC::JSString::createStructure): (JSC::asString):
- runtime/JSValue.h: (JSC::JSValuePtr::makeImmediate): (JSC::JSValuePtr::immediateValue): (JSC::JSValuePtr::JSValuePtr): (JSC::JSValuePtr::operator->): (JSC::JSValuePtr::hasValue): (JSC::JSValuePtr::operator==): (JSC::JSValuePtr::operator!=): (JSC::JSValuePtr::encode): (JSC::JSValuePtr::decode): (JSC::JSValue::asValue): (JSC::noValue): (JSC::operator==): (JSC::operator!=):
- runtime/JSVariableObject.h: (JSC::JSVariableObject::symbolTablePut): (JSC::JSVariableObject::symbolTablePutWithAttributes):
- runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::mark):
- runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
- runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h: (JSC::lookupPut):
- runtime/MathObject.cpp: (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRandom): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
- runtime/MathObject.h: (JSC::MathObject::createStructure):
- runtime/NativeErrorConstructor.cpp: (JSC::callNativeErrorConstructor):
- runtime/NumberConstructor.cpp: (JSC::numberConstructorNaNValue): (JSC::numberConstructorNegInfinity): (JSC::numberConstructorPosInfinity): (JSC::numberConstructorMaxValue): (JSC::numberConstructorMinValue): (JSC::callNumberConstructor):
- runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
- runtime/NumberObject.cpp: (JSC::NumberObject::getJSNumber): (JSC::constructNumberFromImmediateNumber):
- runtime/NumberObject.h:
- runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToString): (JSC::numberProtoFuncToLocaleString): (JSC::numberProtoFuncValueOf): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToPrecision):
- runtime/ObjectConstructor.cpp: (JSC::constructObject): (JSC::callObjectConstructor):
- runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncValueOf): (JSC::objectProtoFuncHasOwnProperty): (JSC::objectProtoFuncIsPrototypeOf): (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): (JSC::objectProtoFuncPropertyIsEnumerable): (JSC::objectProtoFuncToLocaleString): (JSC::objectProtoFuncToString):
- runtime/ObjectPrototype.h:
- runtime/Operations.cpp: (JSC::equal): (JSC::equalSlowCase): (JSC::strictEqual): (JSC::strictEqualSlowCase): (JSC::throwOutOfMemoryError):
- runtime/Operations.h: (JSC::equalSlowCaseInline): (JSC::strictEqualSlowCaseInline):
- runtime/PropertySlot.cpp: (JSC::PropertySlot::functionGetter):
- runtime/PropertySlot.h: (JSC::PropertySlot::PropertySlot): (JSC::PropertySlot::getValue): (JSC::PropertySlot::putValue): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setValue): (JSC::PropertySlot::setCustom): (JSC::PropertySlot::setCustomIndex): (JSC::PropertySlot::slotBase): (JSC::PropertySlot::setBase): (JSC::PropertySlot::):
- runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect): (JSC::ProtectedPtr::ProtectedPtr): (JSC::ProtectedPtr::operator JSValuePtr): (JSC::ProtectedJSValuePtr::ProtectedJSValuePtr): (JSC::ProtectedJSValuePtr::get): (JSC::ProtectedJSValuePtr::operator JSValuePtr): (JSC::ProtectedJSValuePtr::operator->): (JSC::::ProtectedPtr): (JSC::::~ProtectedPtr): (JSC::::operator): (JSC::ProtectedJSValuePtr::~ProtectedJSValuePtr): (JSC::ProtectedJSValuePtr::operator=): (JSC::operator==): (JSC::operator!=):
- runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::getBackref): (JSC::RegExpConstructor::getLastParen): (JSC::RegExpConstructor::getLeftContext): (JSC::RegExpConstructor::getRightContext): (JSC::regExpConstructorDollar1): (JSC::regExpConstructorDollar2): (JSC::regExpConstructorDollar3): (JSC::regExpConstructorDollar4): (JSC::regExpConstructorDollar5): (JSC::regExpConstructorDollar6): (JSC::regExpConstructorDollar7): (JSC::regExpConstructorDollar8): (JSC::regExpConstructorDollar9): (JSC::regExpConstructorInput): (JSC::regExpConstructorMultiline): (JSC::regExpConstructorLastMatch): (JSC::regExpConstructorLastParen): (JSC::regExpConstructorLeftContext): (JSC::regExpConstructorRightContext): (JSC::RegExpConstructor::put): (JSC::setRegExpConstructorInput): (JSC::setRegExpConstructorMultiline): (JSC::constructRegExp): (JSC::callRegExpConstructor):
- runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure): (JSC::asRegExpConstructor):
- runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::put):
- runtime/RegExpObject.cpp: (JSC::regExpObjectGlobal): (JSC::regExpObjectIgnoreCase): (JSC::regExpObjectMultiline): (JSC::regExpObjectSource): (JSC::regExpObjectLastIndex): (JSC::RegExpObject::put): (JSC::setRegExpObjectLastIndex): (JSC::RegExpObject::test): (JSC::RegExpObject::exec): (JSC::callRegExpObject):
- runtime/RegExpObject.h: (JSC::RegExpObject::createStructure): (JSC::asRegExpObject):
- runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncTest): (JSC::regExpProtoFuncExec): (JSC::regExpProtoFuncCompile): (JSC::regExpProtoFuncToString):
- runtime/StringConstructor.cpp: (JSC::stringFromCharCodeSlowCase): (JSC::stringFromCharCode): (JSC::callStringConstructor):
- runtime/StringObject.cpp: (JSC::StringObject::put):
- runtime/StringObject.h: (JSC::StringObject::createStructure): (JSC::asStringObject):
- runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncToString): (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncConcat): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSlice): (JSC::stringProtoFuncSplit): (JSC::stringProtoFuncSubstr): (JSC::stringProtoFuncSubstring): (JSC::stringProtoFuncToLowerCase): (JSC::stringProtoFuncToUpperCase): (JSC::stringProtoFuncLocaleCompare): (JSC::stringProtoFuncBig): (JSC::stringProtoFuncSmall): (JSC::stringProtoFuncBlink): (JSC::stringProtoFuncBold): (JSC::stringProtoFuncFixed): (JSC::stringProtoFuncItalics): (JSC::stringProtoFuncStrike): (JSC::stringProtoFuncSub): (JSC::stringProtoFuncSup): (JSC::stringProtoFuncFontcolor): (JSC::stringProtoFuncFontsize): (JSC::stringProtoFuncAnchor): (JSC::stringProtoFuncLink):
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::changePrototypeTransition): (JSC::Structure::createCachedPrototypeChain):
- runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::setPrototypeWithoutTransition): (JSC::Structure::storedPrototype):
JavaScriptGlue:
2009-01-05 Gavin Barraclough <baraclough@apple.com>
Rubber Stamped by Oliver Hunt.
Replace all uses of JSValue* with new wrapper class, JSValuePtr.
See JavaScriptCore/ChangeLog for more detailed description.
- JSObject.cpp: (nativeCallFunction):
- JSUtils.cpp: (KJSValueToJSObject): (JSObjectKJSValue): (KJSValueToCFTypeInternal): (KJSValueToCFType):
- JSUtils.h:
- JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction):
- JSValueWrapper.h:
- UserObjectImp.cpp: (UserObjectImp::callAsFunction): (UserObjectImp::userObjectGetter): (UserObjectImp::getOwnPropertySlot): (UserObjectImp::put): (UserObjectImp::toPrimitive):
- UserObjectImp.h: (UserObjectImp::createStructure):
WebCore:
2009-01-05 Gavin Barraclough <baraclough@apple.com>
Rubber Stamped by Oliver Hunt.
Replace all uses of JSValue* with new wrapper class, JSValuePtr.
See JavaScriptCore/ChangeLog for more detailed description.
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
- bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter): (WebCore::JSCSSStyleDeclaration::customPut):
- bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
- bindings/js/JSCanvasPixelArrayCustom.h: (WebCore::JSCanvasPixelArray::getByIndex): (WebCore::JSCanvasPixelArray::indexSetter):
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toJS): (WebCore::toHTMLCanvasStyle): (WebCore::JSCanvasRenderingContext2D::strokeStyle): (WebCore::JSCanvasRenderingContext2D::setStrokeStyle): (WebCore::JSCanvasRenderingContext2D::fillStyle): (WebCore::JSCanvasRenderingContext2D::setFillStyle): (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow): (WebCore::JSCanvasRenderingContext2D::createPattern): (WebCore::JSCanvasRenderingContext2D::putImageData): (WebCore::JSCanvasRenderingContext2D::fillText): (WebCore::JSCanvasRenderingContext2D::strokeText):
- bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::types): (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profiles):
- bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
- bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
- bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
- bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
- bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent): (WebCore::toVoidCallback):
- bindings/js/JSCustomVoidCallback.h:
- bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create): (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSCustomXPathNSResolver.h:
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMBinding.cpp: (WebCore::jsStringOrNull): (WebCore::jsOwnedStringOrNull): (WebCore::jsStringOrUndefined): (WebCore::jsStringOrFalse): (WebCore::valueToStringWithNullCheck): (WebCore::valueToStringWithUndefinedOrNullCheck): (WebCore::reportException): (WebCore::reportCurrentException): (WebCore::setDOMException): (WebCore::objectToStringFunctionGetter):
- bindings/js/JSDOMBinding.h: (WebCore::getDOMObjectWrapper): (WebCore::getDOMNodeWrapper): (WebCore::toJS):
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): (WebCore::showModalDialog): (jsDOMWindowBaseCrypto): (jsDOMWindowBaseEvent): (jsDOMWindowBaseImage): (jsDOMWindowBaseMessageChannel): (jsDOMWindowBaseOption): (jsDOMWindowBaseXMLHttpRequest): (jsDOMWindowBaseAudio): (jsDOMWindowBaseWorker): (jsDOMWindowBaseXSLTProcessor): (setJSDOMWindowBaseEvent): (setJSDOMWindowBaseAudio): (setJSDOMWindowBaseImage): (setJSDOMWindowBaseMessageChannel): (setJSDOMWindowBaseOption): (setJSDOMWindowBaseWorker): (setJSDOMWindowBaseXMLHttpRequest): (setJSDOMWindowBaseXSLTProcessor): (WebCore::JSDOMWindowBase::childFrameGetter): (WebCore::JSDOMWindowBase::indexGetter): (WebCore::JSDOMWindowBase::namedItemGetter): (WebCore::JSDOMWindowBase::getOwnPropertySlot): (WebCore::JSDOMWindowBase::put): (WebCore::JSDOMWindowBase::clear): (windowProtoFuncOpen): (windowProtoFuncShowModalDialog): (windowProtoFuncNotImplemented): (WebCore::JSDOMWindowBase::setReturnValueSlot): (WebCore::JSDOMWindowBase::installTimeout): (WebCore::toJS): (WebCore::toJSDOMWindow):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::lookupGetter): (WebCore::JSDOMWindow::lookupSetter): (WebCore::JSDOMWindow::setLocation): (WebCore::JSDOMWindow::postMessage): (WebCore::setTimeoutOrInterval): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::clearTimeout): (WebCore::JSDOMWindow::setInterval): (WebCore::JSDOMWindow::clearInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): (WebCore::toDOMWindow): (WebCore::nonCachingStaticCloseFunctionGetter): (WebCore::nonCachingStaticBlurFunctionGetter): (WebCore::nonCachingStaticFocusFunctionGetter): (WebCore::nonCachingStaticPostMessageFunctionGetter):
- bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customPut):
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::put): (WebCore::JSDOMWindowShell::putWithAttributes): (WebCore::JSDOMWindowShell::lookupGetter): (WebCore::JSDOMWindowShell::lookupSetter): (WebCore::toJS):
- bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
- bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::JSDocument::setLocation): (WebCore::toJS):
- bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNode): (WebCore::JSElement::setAttributeNS): (WebCore::JSElement::setAttributeNodeNS): (WebCore::toJSNewlyCreated):
- bindings/js/JSEventCustom.cpp: (WebCore::JSEvent::clipboardData): (WebCore::toJS):
- bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::eventParameterName): (WebCore::JSLazyEventListener::parseCode):
- bindings/js/JSEventTarget.cpp: (WebCore::toJS):
- bindings/js/JSEventTarget.h:
- bindings/js/JSEventTargetBase.h:
- bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener):
- bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionOptions): (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
- bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::createStructure):
- bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::customPut): (WebCore::JSHTMLAppletElement::nameGetter):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::nameGetter): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem): (WebCore::toJS):
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all): (WebCore::JSHTMLDocument::setAll): (WebCore::JSHTMLDocument::open): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln):
- bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::customPut): (WebCore::JSHTMLEmbedElement::nameGetter):
- bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
- bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::JSHTMLFrameElement::setSrc): (WebCore::JSHTMLFrameElement::setLocation):
- bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
- bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc):
- bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::selectionStart): (WebCore::JSHTMLInputElement::selectionEnd):
- bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::customPut): (WebCore::JSHTMLObjectElement::nameGetter):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::length): (WebCore::JSHTMLOptionsCollection::setLength): (WebCore::JSHTMLOptionsCollection::indexSetter): (WebCore::JSHTMLOptionsCollection::add): (WebCore::JSHTMLOptionsCollection::remove):
- bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove): (WebCore::selectIndexSetter): (WebCore::JSHTMLSelectElement::indexSetter):
- bindings/js/JSHTMLSelectElementCustom.h:
- bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter): (WebCore::JSHistory::customPut):
- bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
- bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
- bindings/js/JSInspectedObjectWrapper.h: (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
- bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::JSInspectorCallbackWrapper::wrap): (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
- bindings/js/JSInspectorCallbackWrapper.h: (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate): (WebCore::JSJavaScriptCallFrame::thisObject): (WebCore::JSJavaScriptCallFrame::type): (WebCore::JSJavaScriptCallFrame::scopeChain):
- bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter): (WebCore::JSLocation::customPut): (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString):
- bindings/js/JSMessageChannelConstructor.h:
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSMimeTypeArrayCustom.cpp: (WebCore::JSMimeTypeArray::nameGetter):
- bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::nameGetter):
- bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::lengthGetter): (WebCore::JSNamedNodesCollection::indexGetter):
- bindings/js/JSNamedNodesCollection.h: (WebCore::JSNamedNodesCollection::createStructure):
- bindings/js/JSNavigatorCustom.cpp: (WebCore::needsYouTubeQuirk): (WebCore::JSNavigator::appVersion):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild): (WebCore::createWrapper): (WebCore::toJSNewlyCreated): (WebCore::toJS):
- bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::JSNodeFilterCondition): (WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSNodeFilterCondition.h: (WebCore::JSNodeFilterCondition::create):
- bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::acceptNode): (WebCore::toNodeFilter):
- bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::nextNode): (WebCore::JSNodeIterator::previousNode):
- bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList): (WebCore::JSNodeList::nameGetter):
- bindings/js/JSPluginArrayCustom.cpp: (WebCore::JSPluginArray::nameGetter):
- bindings/js/JSPluginCustom.cpp: (WebCore::JSPlugin::nameGetter):
- bindings/js/JSPluginElementFunctions.cpp: (WebCore::runtimeObjectGetter): (WebCore::runtimeObjectPropertyGetter): (WebCore::runtimeObjectCustomPut): (WebCore::callPlugin):
- bindings/js/JSPluginElementFunctions.h:
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::asWrapper): (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter): (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot): (WebCore::JSQuarantinedObjectWrapper::put): (WebCore::JSQuarantinedObjectWrapper::construct): (WebCore::JSQuarantinedObjectWrapper::hasInstance): (WebCore::JSQuarantinedObjectWrapper::call):
- bindings/js/JSQuarantinedObjectWrapper.h: (WebCore::JSQuarantinedObjectWrapper::createStructure):
- bindings/js/JSRGBColor.cpp: (WebCore::getJSRGBColor): (jsRGBColorRed): (jsRGBColorGreen): (jsRGBColorBlue):
- bindings/js/JSRGBColor.h: (WebCore::JSRGBColor::createStructure):
- bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
- bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::convertToSpecifiedUnits):
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::rotateFromVector): (WebCore::JSSVGMatrix::flipX): (WebCore::JSSVGMatrix::flipY): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
- bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
- bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::JSSVGPathSegList::clear): (WebCore::JSSVGPathSegList::initialize): (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem): (WebCore::JSSVGPathSegList::appendItem):
- bindings/js/JSSVGPointListCustom.cpp: (WebCore::finishGetter): (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult): (WebCore::JSSVGPointList::clear): (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
- bindings/js/JSSVGTransformListCustom.cpp: (WebCore::finishGetter): (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult): (WebCore::JSSVGTransformList::clear): (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::nameGetter): (WebCore::JSStorage::deleteProperty): (WebCore::JSStorage::customPut):
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
- bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetList::nameGetter):
- bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated):
- bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::parentNode): (WebCore::JSTreeWalker::firstChild): (WebCore::JSTreeWalker::lastChild): (WebCore::JSTreeWalker::nextSibling): (WebCore::JSTreeWalker::previousSibling): (WebCore::JSTreeWalker::previousNode): (WebCore::JSTreeWalker::nextNode):
- bindings/js/JSWorkerContextBase.cpp: (WebCore::JSWorkerContextBase::put):
- bindings/js/JSWorkerContextBase.h:
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::self): (WebCore::JSWorkerContext::setSelf): (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::setRequestHeader): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::getResponseHeader): (WebCore::JSXMLHttpRequest::overrideMimeType): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener): (WebCore::JSXMLHttpRequest::responseText):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::importStylesheet): (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument): (WebCore::JSXSLTProcessor::setParameter): (WebCore::JSXSLTProcessor::getParameter): (WebCore::JSXSLTProcessor::removeParameter):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::initialize):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::getString): (WebCore::ScriptValue::isNull): (WebCore::ScriptValue::isUndefined):
- bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::jsValue):
- bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject webScriptValueAtIndex:]): (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
- bindings/objc/WebScriptObjectPrivate.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_HasMethod): (_NPN_Construct):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod): (JSC::Bindings::CInstance::invokeDefaultMethod): (JSC::Bindings::CInstance::invokeConstruct): (JSC::Bindings::CInstance::defaultValue): (JSC::Bindings::CInstance::stringValue): (JSC::Bindings::CInstance::numberValue): (JSC::Bindings::CInstance::booleanValue): (JSC::Bindings::CInstance::valueOf):
- bridge/c/c_instance.h:
- bridge/c/c_runtime.cpp: (JSC::Bindings::CField::valueFromInstance): (JSC::Bindings::CField::setValueToInstance):
- bridge/c/c_runtime.h:
- bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant): (JSC::Bindings::convertNPVariantToValue):
- bridge/c/c_utility.h:
- bridge/jni/jni_instance.cpp: (JavaInstance::stringValue): (JavaInstance::numberValue): (JavaInstance::booleanValue): (JavaInstance::invokeMethod): (JavaInstance::defaultValue): (JavaInstance::valueOf):
- bridge/jni/jni_instance.h:
- bridge/jni/jni_jsobject.h:
- bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::getSlot): (JavaJSObject::convertValueToJObject): (JavaJSObject::convertJObjectToValue):
- bridge/jni/jni_objc.mm: (JSC::Bindings::dispatchJNICall):
- bridge/jni/jni_runtime.cpp: (JavaArray::convertJObjectToArray): (JavaField::dispatchValueFromInstance): (JavaField::valueFromInstance): (JavaField::dispatchSetValueToInstance): (JavaField::setValueToInstance): (JavaArray::setValueAt): (JavaArray::valueAt):
- bridge/jni/jni_runtime.h:
- bridge/jni/jni_utility.cpp: (JSC::Bindings::convertArrayInstanceToJavaArray): (JSC::Bindings::convertValueToJValue):
- bridge/jni/jni_utility.h:
- bridge/objc/WebScriptObject.h:
- bridge/objc/objc_class.h:
- bridge/objc/objc_class.mm: (JSC::Bindings::ObjcClass::fallbackObject):
- bridge/objc/objc_instance.h:
- bridge/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField): (ObjcInstance::defaultValue): (ObjcInstance::stringValue): (ObjcInstance::numberValue): (ObjcInstance::booleanValue): (ObjcInstance::valueOf):
- bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
- bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcField::valueFromInstance): (JSC::Bindings::convertValueToObjcObject): (JSC::Bindings::ObjcField::setValueToInstance): (JSC::Bindings::ObjcArray::setValueAt): (JSC::Bindings::ObjcArray::valueAt): (JSC::Bindings::ObjcFallbackObjectImp::put): (JSC::Bindings::callObjCFallbackObject): (JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
- bridge/objc/objc_utility.h:
- bridge/objc/objc_utility.mm: (JSC::Bindings::convertValueToObjcValue): (JSC::Bindings::convertNSStringToString): (JSC::Bindings::convertObjcValueToValue):
- bridge/runtime.cpp: (JSC::Bindings::Instance::getValueOfField): (JSC::Bindings::Instance::setValueOfField):
- bridge/runtime.h: (JSC::Bindings::Class::fallbackObject): (JSC::Bindings::Instance::getValueOfUndefinedField): (JSC::Bindings::Instance::setValueOfUndefinedField): (JSC::Bindings::Instance::invokeDefaultMethod): (JSC::Bindings::Instance::invokeConstruct): (JSC::Bindings::Instance::valueOf):
- bridge/runtime_array.cpp: (JSC::RuntimeArray::lengthGetter): (JSC::RuntimeArray::indexGetter): (JSC::RuntimeArray::put):
- bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
- bridge/runtime_method.cpp: (JSC::RuntimeMethod::lengthGetter): (JSC::callRuntimeMethod):
- bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
- bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::fallbackObjectGetter): (JSC::RuntimeObjectImp::fieldGetter): (JSC::RuntimeObjectImp::methodGetter): (JSC::RuntimeObjectImp::put): (JSC::RuntimeObjectImp::defaultValue): (JSC::callRuntimeObject): (JSC::callRuntimeConstructor):
- bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructure):
- inspector/InspectorController.cpp:
- inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::evaluate):
- inspector/JavaScriptCallFrame.h:
- inspector/JavaScriptProfile.cpp: (WebCore::toJS):
- inspector/JavaScriptProfile.h:
- inspector/JavaScriptProfileNode.cpp: (WebCore::toJS):
- inspector/JavaScriptProfileNode.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection):
WebKit/mac:
2009-01-05 Gavin Barraclough <baraclough@apple.com>
Rubber Stamped by Oliver Hunt.
Replace all uses of JSValue* with new wrapper class, JSValuePtr.
See JavaScriptCore/ChangeLog for more detailed description.
- WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
- WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame _convertValueToObjcValue:]): (-[WebScriptCallFrame exception]): (-[WebScriptCallFrame evaluateWebScript:]):
- WebView/WebView.mm: (aeDescFromJSValue): (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
- 5:59 PM Changeset in webkit [39669] by
-
- 16 edits2 adds in trunk
2009-01-06 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
Added new API on AnimationController::numberOfActiveAnimations() to be used by DRT.
Test: animations/animation-controller-drt-api.html
- WebCore.base.exp:
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::numberOfActiveAnimations): (WebCore::AnimationController::numberOfActiveAnimations):
- page/animation/AnimationController.h:
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations): (WebCore::CompositeAnimation::numberOfActiveAnimations):
- page/animation/CompositeAnimation.h:
Exposed through WebFrame private interface the new WebCore API AnimationController::numberOfActiveAnimations() to be used by DRT.
- WebView/WebFrame.mm: (-[WebFrame _numberOfActiveAnimations]):
- WebView/WebFramePrivate.h:
Added new JS API numberOfActiveAnimations() that returns the number of active CSS transitions & animations.
This effectively exposes the new AnimationController::numberOfActiveAnimations() API from WebCore.
- DumpRenderTree/LayoutTestController.cpp: (numberOfActiveAnimationsCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::numberOfActiveAnimations):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::numberOfActiveAnimations):
Reviewed by Darin Adler.
Added layout test for new DRT API numberOfActiveAnimations().
- animations/animation-controller-drt-api-expected.txt: Added.
- animations/animation-controller-drt-api.html: Added.
- platform/win/Skipped:
- 5:07 PM Changeset in webkit [39668] by
-
- 2 edits4 adds in trunk/WebCore
Reviewed by Gavin Barraclough.
Upstream 3 more files to get the WebCore-Chromium build a bit further.
- WebCore.scons:
- page/chromium/AccessibilityObjectChromium.cpp: Added. (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
- page/chromium/AccessibilityObjectWrapper.h: Added. (WebCore::AccessibilityObjectWrapper::~AccessibilityObjectWrapper): (WebCore::AccessibilityObjectWrapper::attached): (WebCore::AccessibilityObjectWrapper::accessibilityObject): (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):
- platform/chromium/PasteboardPrivate.h: Added. (WebCore::PasteboardPrivate::):
- 4:35 PM Changeset in webkit [39667] by
-
- 9 edits4 adds in trunk
I added calls beginAnimationUpdate() and endAnimationUpdate() calls
to AnimationController. These are called by Document at the start
and end of the recalcStyle cycle. Right now, I'm just using the
beginAnimationUpdate() method to reset an animation time value.
The first time the animation time is accessed after this reset I set
it to the currentTime. So all animations in that cycle get the same
start time.
The test cases checked in test this, but in the case of the 'left'
test it actually doesn't make any difference in most cases. This is
because values are clamped to whole pixels, so the start times would
have to be pretty far off for the test to fail using the old
currentTime() model. Still, under really heavy load, it's possible for
the test to fail without these changes.
The 'transform' test is another story. It animates to the full resolution
of a floating point number, so the test fails miserably without this
fix.
- 3:15 PM Changeset in webkit [39666] by
-
- 3 edits in trunk/WebCore
2009-01-06 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Nikolas Zimmermann.
Bug 22858: Simplify make_names.pl code for avoiding multiple definitions or inclusions
https://bugs.webkit.org/show_bug.cgi?id=22858
I had introduced an awkward situation using hasCustomJSWrapper and
sometimes boolean parameter in order to ensure JS wrapper generated once
or header included once.
Simplified the code by using a %seenTag hash to detect multiple definitions
or inclusions and skipping it.
Also cleaned up a bit make_names.pl by using more explicit names and moving
code to where it belongs.
- dom/make_names.pl:
- html/HTMLTagNames.in: Necessary changes that were not detected by the previous syntax but will be required for autogenerating HTMLElementFactory.
- 2:58 PM Changeset in webkit [39665] by
-
- 9 edits in trunk/WebKit/win
2009-01-06 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a way for application to provide custom, full frame, views for certain MIME types.
- Interfaces/IWebEmbeddedView.idl: Add loading related methods.
- Interfaces/IWebViewPrivate.idl: Add new registerEmbeddedViewMIMEType method.
- WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::didReceiveResponse): (EmbeddedWidget::didReceiveData): (EmbeddedWidget::didFinishLoading): (EmbeddedWidget::didFail): Implement these and call the IEmbeddedView methods.
- WebCoreSupport/EmbeddedWidget.h: Inherit from PluginManualLoader.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::redirectDataToPlugin): Handle the case where the widget is an EnbeddedWidget.
(WebFrameLoaderClient::shouldUsePluginDocument):
Have this call WebView::shouldUseEmbeddedView.
- WebView.cpp: (WebView::canShowMIMEType): Have this call WebView::shouldUseEmbeddedView.
(WebView::registerEmbeddedViewMIMEType):
Add the MIME type to the set.
(WebView::shouldUseEmbeddedView):
Given a MIME type, returns whether an embedded view should be used or not.
- 2:57 PM Changeset in webkit [39664] by
-
- 3 edits in trunk/WebCore
2009-01-06 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a way for frame loader clients to always create a PluginDocument, regardless of
the real document MIME type.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::shouldUsePlugin):
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::shouldUsePluginDocument):
- 2:19 PM Changeset in webkit [39663] by
-
- 4 edits12 adds in trunk
2009-01-06 Dean Jackson <dino@apple.com>
Reviewed by Dave Hyatt.
Extend Media Queries to cover transitions,
animations, transform-2d and transform-3d
http://webkit.org/specs/MediaQueriesExtensions.html
Note that the implementation uses -webkit- prefixes
even though the spec doesn't have them.
https://bugs.webkit.org/show_bug.cgi?id=22494
Tests: fast/media/mq-animation.html
fast/media/mq-transform-01.html
fast/media/mq-transform-02.html
fast/media/mq-transform-03.html
fast/media/mq-transform-04.html
fast/media/mq-transition.html
- css/MediaFeatureNames.h:
- css/MediaQueryEvaluator.cpp: (WebCore::animationMediaFeatureEval): (WebCore::transitionMediaFeatureEval): (WebCore::transform_2dMediaFeatureEval): (WebCore::transform_3dMediaFeatureEval):
- 1:56 PM Changeset in webkit [39662] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-01-06 Justin Garcia <justin.garcia@apple.com>
Reviewed by Oliver Hunt.
Tests for:
<rdar://problem/4059423> DOM operations performed on editable HTML can cause a crash later during Undo (19703)
A few more may able to be written after <rdar://problem/6468156> is fixed.
- editing/undo/4059423-1-expected.txt: Added.
- editing/undo/4059423-1.html: Added.
- editing/undo/4059423-2-expected.txt: Added.
- editing/undo/4059423-2.html: Added.
- 1:50 PM Changeset in webkit [39661] by
-
- 2 edits1 add in trunk/WebCore
Reviewed by Oliver Hunt.
Bring the Chromium-WebCore build closer to building
by upstreaming PlatformWidget.h add adding the JSC
plugin bridge files to the build.
- WebCore.scons:
- platform/chromium/PlatformWidget.h: Added.
- 12:33 PM Changeset in webkit [39660] by
-
- 5 edits in trunk
<https://bugs.webkit.org/show_bug.cgi?id=23085> [jsfunfuzz] Over released ScopeChainNode
<rdar://problem/6474110>
Reviewed by Cameron Zwarich
So this delightful bug was caused by our unwind code using a ScopeChain to perform
the unwind. The ScopeChain would ref the initial top of the scope chain, then deref
the resultant top of scope chain, which is incorrect.
This patch removes the dependency on ScopeChain for the unwind, and i've filed
<https://bugs.webkit.org/show_bug.cgi?id=23144> to look into the unintuitive
ScopeChain behaviour.
- 12:16 PM Changeset in webkit [39659] by
-
- 2 edits in trunk/WebCore
Build fix only, no review.
Bring the Chromium-WebCore build back closer to building
by adding files from recent commits.
- WebCore.scons:
- 11:49 AM Changeset in webkit [39658] by
-
- 2 edits in trunk/JavaScriptCore
Hopeful Windows crash-on-launch fix
- wtf/Platform.h: Force a world rebuild by touching this file.
- 10:19 AM Changeset in webkit [39657] by
-
- 2 edits in trunk/JavaScriptCore
Build fix by building ByteArray.cpp as well
- 10:12 AM Changeset in webkit [39656] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/6474973> REGRESSION: PLT ~2% slower due to 39465 (consolidate thread data)
I could not reproduce the slowdown on my PowerPC test machine, but the change should bring
performance back.
- platform/ThreadGlobalData.cpp: (WebCore::threadGlobalData): Don't use AtomicallyInitializedStatic. Prior to r39465, it was only used for cached converters, which was necessary because the first access to ICU or TEC one could happen on a secondary thread, but now they are all initialized from ThreadGlobalData constructor.
- 9:08 AM Changeset in webkit [39655] by
-
- 3 edits in trunk/WebKit/qt
Update the documentation to reflect when these API changes will land in
upstream Qt
- 8:14 AM Changeset in webkit [39654] by
-
- 2 edits in trunk/WebCore
2009-01-06 David Smith <catfish.man@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23129
Devirtualize Node::childNodes().
- 8:13 AM Changeset in webkit [39653] by
-
- 2 edits in trunk/JavaScriptCore
Speculative build fix for Gtk+
- 6:54 AM Changeset in webkit [39652] by
-
- 3 edits in trunk/WebKit/win
BUILD FIX (r39641): Try to fix WebIconDatabase build errors #4
- WebIconDatabase.cpp: (WebIconDatabase::isEnabled): Added 'WebIconDatabase::' to method signature. (Another copy-paste error.) (WebIconDatabase::setEnabled): Ditto.
- WebIconDatabase.h: (WebIconDatabase::startUpIconDatabase): Make private again. (WebIconDatabase::shutDownIconDatabase): Ditto.
- 6:49 AM Changeset in webkit [39651] by
-
- 2 edits in trunk/WebCore
2009-01-06 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed build fix.
Fix the Qt build with Qt 4.4.x, the HTTP-only cookie support was
added in Qt 4.5.
- 6:38 AM Changeset in webkit [39650] by
-
- 2 edits in trunk/WebCore
2009-01-06 Zalan Bujtas <zbujtas@gmail.com>
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=23133
Fix SVG disabled build. Move 'pointer-events' from SVGCSSPropertyNames.in to
CSSPropertyNames.in and move PointerEvents functions out of #if ENABLE(SVG)
NOTE: Property name fixes landed as part of r39648.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EPointerEvents):
- css/CSSPropertyNames.in:
- css/SVGCSSPropertyNames.in:
- 6:29 AM Changeset in webkit [39649] by
-
- 3 edits in trunk/WebKit/win
BUILD FIX (r39641): Try to fix build errors #3
Try to fix the following (more specific) build errors:
WebIconDatabase.cpp
..\WebIconDatabase.cpp(255) : error C2248: 'WebIconDatabase::shutDownIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
..\WebIconDatabase.cpp(255) : error C2352: 'WebIconDatabase::shutDownIconDatabase' : illegal call of non-static member function
...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
..\WebIconDatabase.cpp(258) : error C2248: 'WebIconDatabase::startUpIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
..\WebIconDatabase.cpp(258) : error C2352: 'WebIconDatabase::startUpIconDatabase' : illegal call of non-static member function
...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
- WebIconDatabase.cpp: (setEnabled): Get instance of shared WebIconDatabase, then call startUp/shutDown methods on it.
- WebIconDatabase.h: (WebIconDatabase::startUpIconDatabase): Make protected again. (WebIconDatabase::shutDownIconDatabase): Ditto.
- 6:06 AM Changeset in webkit [39648] by
-
- 3 edits in trunk/WebCore
BUILD FIX (r39634): Fix build for non-SVG builds (Wx)
- css/CSSPropertyNames.in: Added 'pointer-events'.
- css/SVGCSSPropertyNames.in: Commented out pointer-events since it's now a plain CSS property.
- 5:59 AM Changeset in webkit [39647] by
-
- 3 edits in trunk/WebKit/win
BUILD FIX (r39641): Try to fix build errors again
Try to fix the following build errors:
WebIconDatabase.cpp
..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
- WebIconDatabase.cpp: (setEnabled): Add class prefix to startUpIconDatabase() and shutDownIconDatabase().
- WebIconDatabase.h: (WebIconDatabase::startUpIconDatabase): Make private again. (WebIconDatabase::shutDownIconDatabase): Ditto.
- 5:45 AM Changeset in webkit [39646] by
-
- 2 edits in trunk/WebKit/win
BUILD FIX (r39641): Try to fix build error
Try to fix the following build errors:
WebIconDatabase.cpp
..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
- WebIconDatabase.h: (WebIconDatabase::startUpIconDatabase): Make protected. (WebIconDatabase::shutDownIconDatabase): Ditto.
- 5:07 AM Changeset in webkit [39645] by
-
- 2 edits in trunk/WebKit/win
BUILD FIX (r39641): Fix more silly errors
Fixes the following compilation errors:
WebIconDatabase.cpp
..\WebIconDatabase.cpp(85) : error C2065: 'standardPrefs' : undeclared identifier
..\WebIconDatabase.cpp(85) : error C2227: left of '->iconDatabaseLocation' must point to class/struct/union/generic type
type is unknown-type
..\WebIconDatabase.cpp(241) : error C2575: 'isEnabled' : only member functions and bases can be virtual
..\WebIconDatabase.cpp(248) : error C2575: 'setEnabled' : only member functions and bases can be virtual
..\WebIconDatabase.cpp(253) : error C3861: 'shutDownIconDatabase': identifier not found
..\WebIconDatabase.cpp(256) : error C3861: 'startUpIconDatabase': identifier not found
- WebIconDatabase.cpp: (WebIconDatabase::startUpIconDatabase): Redeclare standardPrefs since this was in init() but not in this method after it was extracted from init(). (isEnabled): Don't use "virtual" in method implementation (silly copy-paste error). (setEnabled): Ditto.
- 4:40 AM Changeset in webkit [39644] by
-
- 2 edits in trunk/WebKit/win
BUILD FIX (r39641): Remove STDMETHODCALLTYPE from method declarations in IWebIconDatabase.idl
- Interfaces/IWebIconDatabase.idl: Removed "STDMETHODCALLTYPE" from silly copy-paste error in two method declarations.
- 1:35 AM Changeset in webkit [39643] by
-
- 2 edits in trunk/WebCore
2009-01-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Lars Knoll.
Added support for HTTP-only cookies to the Qt build.
Jan 5, 2009:
- 11:39 PM Changeset in webkit [39642] by
-
- 3 edits in trunk/WebCore
2009-01-05 David Smith <catfish.man@gmail.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23084
Avoid redundant AtomicString conversions
- dom/Node.cpp: Create an AtomicString early to avoid converting twice (WebCore::Node::getElementsByTagNameNS):
- dom/QualifiedName.h: Use the appropriate AtomicString constructor instead of converting from a String
- 10:13 PM Changeset in webkit [39641] by
-
- 8 edits in trunk/WebKit
WebKit/mac:
2009-01-05 David Kilzer <ddkilzer@apple.com>
Add SPI to enable, disable and check state of WebIconDatabase
Reviewed by Darin Adler & Timothy Hatcher.
Add -[WebIconDatabase isEnabled] and -[WebIconDatabase setEnabled:]
SPI to make it possible to enable, disable and check the state of
the icon database.
- Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Extracted code into -_startUpIconDatabase. (-[WebIconDatabase iconForURL:withSize:cache:]): Switched to use -isEnabled instead of -_isEnabled. (-[WebIconDatabase iconURLForURL:]): Ditto. (-[WebIconDatabase retainIconForURL:]): Ditto. (-[WebIconDatabase releaseIconForURL:]): Ditto. (-[WebIconDatabase isEnabled]): Renamed from -_isEnabled in WebInternal category. (-[WebIconDatabase setEnabled:]): Added. Takes care of changing the enabled/disabled state of the icon database. (-[WebIconDatabase removeAllIcons]): Switched to use -isEnabled instead of -_isEnabled. (-[WebIconDatabase _startUpIconDatabase]): Added. Extrated from -init. (-[WebIconDatabase _shutDownIconDatabase]): Added. Remove observers when the icon database is disabled.
- Misc/WebIconDatabaseInternal.h: Added declarations for -_startUpIconDatabase and -_shutDownIconDatabase.
- Misc/WebIconDatabasePrivate.h: Added declarations for -isEnabled and -setEnabled:.
WebKit/win:
2009-01-05 David Kilzer <ddkilzer@apple.com>
Add API to enable, disable and check state of WebIconDatabase
Reviewed by Darin Adler & Timothy Hatcher.
Add WebIconDatabase::isEnabled() and WebIconDatabase::setEnabled()
API to make it possible to enable, disable and check the state of
the icon database.
- Interfaces/IWebIconDatabase.idl: Declared isEnabled() and setEnabled() methods.
- WebIconDatabase.cpp: (WebIconDatabase::init): Extracted code into startUpIconDatabase(). (WebIconDatabase::startUpIconDatabase): Added. Extracted from init(). (WebIconDatabase::shutDownIconDatabase): Added. Method is empty since there is nothing to do yet on Windows. (isEnabled): Added. (setEnabled): Added.
- WebIconDatabase.h: Added method declarations.
- 9:37 PM Changeset in webkit [39640] by
-
- 4 edits in trunk/WebCore
2009-01-05 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Add an assertion that clip rects are being used when painting with the same
rootLayer that they were computed with.
Fix two issues detected by the assertion:
RenderLayer::updateClipRects() should not unconditionally update the clip rects
on its parent, but stop when reaching rootLayer (just like calculateClipRects()).
We need to pass the temporaryClipRects flag down through reflection painting
to handle the case of nested reflections.
Also use temporary clip rects in RenderTreeAsText, since that code does not
reset the painting root for transformed layers, so cached clip rects will not
match those used for painting.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::updateClipRects): (WebCore::RenderLayer::clearClipRects):
- rendering/RenderLayer.h:
- rendering/RenderTreeAsText.cpp: (WebCore::writeLayers):
- 9:15 PM Changeset in webkit [39639] by
-
- 2 edits in trunk/WebCore
Fix the Qt build
- 9:12 PM Changeset in webkit [39638] by
-
- 2 edits in trunk/WebCore
Fix the build some more.
- platform/graphics/cairo/AffineTransformCairo.cpp:
(WebCore::TransformationMatrix::TransformationMatrix):
- 8:20 PM Changeset in webkit [39637] by
-
- 2 edits in trunk/WebCore
Fix gtk build
- 8:08 PM Changeset in webkit [39636] by
-
- 3 edits in trunk/WebKit/mac
2009-01-05 Brady Eidson <beidson@apple.com>
Reviewed by Jon Honeycutt
Expose setting the last-visit-was-failure flag on a history items in preparation for <rdar://problem/6173319>
- History/WebHistoryItem.mm: (-[WebHistoryItem _setLastVisitWasFailure:]):
- History/WebHistoryItemPrivate.h:
- 7:00 PM Changeset in webkit [39635] by
-
- 141 edits2 moves in trunk/WebCore
2009-01-05 Dean Jackson <dino@apple.com>
Reviewed by Darin Adler.
Rename AffineTransform to TransformationMatrix in
preparation for future enhancements (non-affine matrices)
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- platform/graphics/transforms/AffineTransform.cpp: Removed.
- platform/graphics/transforms/AffineTransform.h: Removed.
- platform/graphics/transforms/TransformationMatrix.cpp: Copied from WebCore/platform/graphics/transforms/AffineTransform.cpp.
- platform/graphics/transforms/TransformationMatrix.h: Copied from WebCore/platform/graphics/transforms/AffineTransform.h.
- lots of other files with s/AffineTransform/TransformationMatrix/g
- 6:35 PM Changeset in webkit [39634] by
-
- 43 edits5 adds in trunk
2008-01-05 Dean Jackson <dino@apple.com>
Reviewed by David Hyatt.
Implement 'pointer-events' for HTML content. This involved
adding a new value 'auto' which behaves as 'visiblePainted'
in SVG content.
Moved the property out of the SVG CSS code and into
the general CSS (both parsing and RenderStyle).
Changes to the hit testing functionality of the Render tree,
specifically the nodeAtPoint methods. Where they used to
test for visibility, they now use a helper function defined
on base classes (RenderObject and InlineBox) that checks both
visibility and pointer-events.
Tests: fast/events/pointer-events-2.html
fast/events/pointer-events.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EPointerEvents):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- manual-tests/pointer-events.html: Added.
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
- rendering/InlineBox.h: (WebCore::InlineBox::visibleToHitTesting):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
- rendering/PointerEventsHitRules.cpp: (WebCore::PointerEventsHitRules::PointerEventsHitRules):
- rendering/PointerEventsHitRules.h: (WebCore::PointerEventsHitRules::):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
- rendering/RenderObject.h: (WebCore::RenderObject::visibleToHitTesting):
- rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtPoint):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint):
- rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
- rendering/style/RenderStyle.h: (WebCore::): (WebCore::InheritedFlags::setBitDefaults): (WebCore::InheritedFlags::pointerEvents): (WebCore::InheritedFlags::setPointerEvents): (WebCore::InheritedFlags::initialPointerEvents):
- rendering/style/RenderStyleConstants.h: (WebCore::):
- rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::setBitDefaults):
- rendering/style/SVGRenderStyleDefs.h:
- css/CSSValueKeywords.in:
- css/SVGCSSValueKeywords.in:
- 5:50 PM Changeset in webkit [39633] by
-
- 1 edit in trunk/WebCore/DerivedSources.cpp
Build fix from 39625
- 5:37 PM Changeset in webkit [39632] by
-
- 2 edits in trunk/JavaScriptCore
Fix Wx build.
- 5:34 PM Changeset in webkit [39631] by
-
- 4 edits in trunk/JavaScriptCore
2009-01-05 Oliver Hunt <oliver@apple.com>
Windows build fixes
Rubber-stamped by Alice Liu.
- interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter):
- runtime/ByteArray.cpp: (JSC::ByteArray::create):
- runtime/ByteArray.h:
- 5:27 PM Changeset in webkit [39630] by
-
- 3 edits in trunk/WebKit/win
2009-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Jon Honeycutt.
Pass more information in the property bag passed to embeddedViewWithArguments.
- Interfaces/IWebUIDelegatePrivate.idl: Declare new keys.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Pass the base URL, MIME type and the containing element to embeddedViewWithArguments.
- 5:16 PM Changeset in webkit [39629] by
-
- 2 edits in trunk/WebKit/win
2009-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler, Jon Honeycutt.
Add a templatized COMVariant constructor so we can make COMVariants out of
everything that has a COMVariantSetter specialization.
Add a COMVariantSetter specialization for COMVariant.
- COMVariantSetter.h: (COMVariant::COMVariant):
- 5:04 PM Changeset in webkit [39628] by
-
- 2 edits2 adds in trunk/WebKit/win
2009-01-05 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Oliver Hunt.
Removes the WebKitGraphics files from the Cairo build, as well
as excluding their link definitions. These are not used outside
of Safari, and should not be part of the 'Redistributable API.'
- WebKit.vcproj/WebKit.vcproj: Update *_Cairo targets to exclude the WebKitGraphics.cpp/.h files.
- WebKit.vcproj/WebKit_Cairo.def: Added. File without Safari link definitions.
- WebKit.vcproj/WebKit_Cairo_debug.def: Added. File without Safari link definitions.
- 4:19 PM Changeset in webkit [39627] by
-
- 2 edits in trunk/WebKit/win
2009-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Jon Honeycutt.
Add a simple, memory managed, wrapper around a VARIANT struuct.
- COMVariantSetter.h: (COMVariant::COMVariant): (COMVariant::~COMVariant): (COMVariant::operator=): (COMVariant::copyTo): (COMVariant::variantType):
- 4:06 PM Changeset in webkit [39626] by
-
- 2 edits in trunk/WebCore
Fix Cairo/Gtk build
- 3:57 PM Changeset in webkit [39625] by
-
- 23 edits1 copy1 move4 adds3 deletes in trunk
CanvasPixelArray performance is too slow
<https://bugs.webkit.org/show_bug.cgi?id=23123>
Reviewed by Gavin Barraclough
JavaScriptCore:
The fix to this is to devirtualise get and put in a manner similar to
JSString and JSArray. To do this I've added a ByteArray implementation
and JSByteArray wrapper to JSC. We can then do vptr comparisons to
devirtualise the calls.
This devirtualisation improves performance by 1.5-2x in my somewhat ad
hoc tests.
WebCore:
Remove the WebCore CanvasPixelArray implementation and replace
CPA usage with JSC::ByteArray. Replace the JSCanvasPixelArray
wrapper with an explicitly instantiated JSByteArray put on the
JSImageData object as an ordinary ReadOnly, DontDelete property.
- 3:36 PM Changeset in webkit [39624] by
-
- 2 edits in trunk/WebKit/win
2009-01-05 Adele Peterson <adele@apple.com>
Windows build fix.
- WebCoreSupport/WebChromeClient.cpp:
- 3:32 PM Changeset in webkit [39623] by
-
- 3 edits in trunk/WebKit/win
2009-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Make it possible to have per value variant types.
- COMPropertyBag.h: (::Read): Call variantType here, passing in the value.
(::GetPropertyInfo):
Ditto.
- COMVariantSetter.h: (COMVariantSetterBase::variantType): Add COMVariantSetterBase, whose variantType implementation just returns the VariantType variable. Make all existing classes inherit from COMVariantSetterBase.
- 3:31 PM Changeset in webkit [39622] by
-
- 2 edits in trunk/WebKit/mac
Another blind mac build fix
- 3:18 PM Changeset in webkit [39621] by
-
- 2 edits in trunk/WebKit/mac
Blind mac build fix
- 3:11 PM Changeset in webkit [39620] by
-
- 2 edits in trunk/WebKit/mac
Fix mac build
- 3:09 PM Changeset in webkit [39619] by
-
- 2 edits in trunk/WebKit/win
Fix win build
- 3:08 PM Changeset in webkit [39618] by
-
- 2 edits in trunk/WebKit/gtk
Fix build
- 2:53 PM Changeset in webkit [39617] by
-
- 26 edits in trunk
Add new API for contentsSizeChanged which Qt will introduce
- 2:27 PM Changeset in webkit [39616] by
-
- 2 edits in trunk/WebCore
2009-01-05 Anders Carlsson <andersca@apple.com>
Build fix.
- plugins/PluginView.h: (WebCore::PluginManualLoader::~PluginManualLoader):
- 2:25 PM Changeset in webkit [39615] by
-
- 4 edits in trunk
Fix ChangeLogs to reflect work done by Torchmobile
- 2:02 PM Changeset in webkit [39614] by
-
- 3 edits in trunk/WebKit/win
2009-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Use the ManualLoader class instead of assuming that the manual loader
is a plug-in view.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::redirectDataToPlugin):
- WebCoreSupport/WebFrameLoaderClient.h:
- 1:46 PM Changeset in webkit [39613] by
-
- 3 edits in trunk/WebCore
2009-01-05 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Add an abstract PluginManualLoader class and make PluginView inherit from it.
Add some error checking that currently exists in WebKit (but not for long!)
- plugins/PluginView.cpp: (WebCore::PluginView::didReceiveResponse): (WebCore::PluginView::didReceiveData): (WebCore::PluginView::didFinishLoading): (WebCore::PluginView::didFail):
- plugins/PluginView.h:
- 1:33 PM Changeset in webkit [39612] by
-
- 3 edits in trunk/LayoutTests
2009-01-05 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Fix failing set-colors test.
- fast/canvas/resources/set-colors.js: Change the CMYK test cases to use the black channel only.
- fast/canvas/set-colors-expected.txt: Updated. The old version I checked in accidentally expected failure for the bug I fixed. Also need new results for the CMYK test cases.
- 1:14 PM Changeset in webkit [39611] by
-
- 8 edits in trunk
Fixes QWebFrame::setScrollBarPolicy(..) to actually work. Also happens
to fix 192 layout tests that were previously failing for Qt.
- 11:53 AM Changeset in webkit [39610] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
Fix platforms that don't have Workers enabled.
- platform/ThreadGlobalData.cpp: (WebCore::threadGlobalData): Create ThreadGlobalData in two stages, so that EventNames constructor can access the just-created atomic string table. This matches what happens in ThreadSpecific case.
- 11:50 AM Changeset in webkit [39609] by
-
- 3 edits1 copy3 adds in trunk
WebCore:
2009-01-05 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23109: REGRESSION: Backwards search in a long document matches incorrectly
https://bugs.webkit.org/show_bug.cgi?id=23109
Test: fast/text/find-backwards.html
- editing/TextIterator.cpp: (WebCore::SearchBuffer::append): Fix incorrect size passed to memcpy. (WebCore::SearchBuffer::search): Handle case where we have an empty buffer but we're at a break; must not try to search because ICU will give us an error. Fix incorrect size passed to memcpy and memmove. (WebCore::findPlainText): Fix case where we found a match and need to search again because we want to find the last match. We need to try again without adding any more text or handling the break before moving on.
LayoutTests:
2009-01-05 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23109: REGRESSION: Backwards search in a long document matches incorrectly
https://bugs.webkit.org/show_bug.cgi?id=23109
- fast/text/find-backwards-expected.txt: Added.
- fast/text/find-backwards.html: Added.
- fast/text/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
- fast/text/resources/find-backwards.js: Added.
- 11:45 AM Changeset in webkit [39608] by
-
- 2 edits in trunk/WebCore
Fix the Qt build
- 11:13 AM Changeset in webkit [39607] by
-
- 2 edits in trunk/WebCore
Suggested by Dave Levin.
Mac release build fix.
- WebCore.base.exp: Remove ThreadGlobalData::eventNames(), which is now inline.
- 10:24 AM Changeset in webkit [39606] by
-
- 2 edits in trunk/WebCore
2009-01-05 Darin Adler <Darin Adler>
- dom/Document.cpp: Fix build. Oops again.
- 10:19 AM Changeset in webkit [39605] by
-
- 2 edits in trunk/WebCore
2009-01-05 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Fix hang whenever following an anchor.
- dom/Document.cpp: (WebCore::Document::findAnchor): Oops!
- 10:13 AM Changeset in webkit [39604] by
-
- 6 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23073
<rdar://problem/6471129> Workers crash on Windows Release builds
- wtf/ThreadSpecific.h: (WTF::ThreadSpecific::destroy): Changed to clear the pointer only after data object destruction is finished - otherwise, WebCore::ThreadGlobalData destructor was re-creating the object in order to access atomic string table. (WTF::ThreadSpecific::operator T*): Symmetrically, set up the per-thread pointer before data constructor is called.
- wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint): Remove a Windows-only hack to finalize a thread - pthreadVC2 is a DLL, so it gets thread detached messages, and cleans up thread specific data automatically. Besides, this code wasn't even compiled in for some time now.
WebCore:
- platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData):
- platform/ThreadGlobalData.h: (WebCore::ThreadGlobalData::eventNames): Now that ThreadSpecific sets up the pointer before invoking data constructor, we can initialize EventNames right away.
- 9:32 AM Changeset in webkit [39603] by
-
- 13 edits in trunk/WebCore
2009-01-05 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Bug 23106: HTMLFormCollection::namedItem ignores caseSensitive argument
https://bugs.webkit.org/show_bug.cgi?id=23106
This led me to a bunch of dead code. It turns out that HTML collections
were carrying the case-insensitive code just so they could be used to
find anchors, something we can do more simply and efficiently without
creating a DOM HTMLCollection object.
No behavior change. Just adding a new function findAnchor function and
removing some dead code.
- dom/Document.cpp: (WebCore::Document::findAnchor): Added.
- dom/Document.h: Ditto.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::accessKey): Take and return AtomicString references for better efficiency. (WebCore::HTMLAnchorElement::setAccessKey): Ditto. (WebCore::HTMLAnchorElement::charset): Ditto. (WebCore::HTMLAnchorElement::setCharset): Ditto. (WebCore::HTMLAnchorElement::coords): Ditto. (WebCore::HTMLAnchorElement::setCoords): Ditto. (WebCore::HTMLAnchorElement::setHref): Ditto. (WebCore::HTMLAnchorElement::hreflang): Ditto. (WebCore::HTMLAnchorElement::setHreflang): Ditto. (WebCore::HTMLAnchorElement::name): Ditto. (WebCore::HTMLAnchorElement::setName): Ditto. (WebCore::HTMLAnchorElement::rel): Ditto. (WebCore::HTMLAnchorElement::setRel): Ditto. (WebCore::HTMLAnchorElement::rev): Ditto. (WebCore::HTMLAnchorElement::setRev): Ditto. (WebCore::HTMLAnchorElement::shape): Ditto. (WebCore::HTMLAnchorElement::setShape): Ditto. (WebCore::HTMLAnchorElement::setTarget): Ditto. (WebCore::HTMLAnchorElement::type): Ditto. (WebCore::HTMLAnchorElement::setType): Ditto.
- html/HTMLAnchorElement.h: Ditto.
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): Changed argument to an AtomicString and removed the caseSensitive boolean, since we're now always case sensitive. (WebCore::HTMLCollection::namedItem): Ditto. (WebCore::HTMLCollection::nextNamedItem): Ditto.
- html/HTMLCollection.h: Ditto.
- html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::getNamedItem): Ditto. (WebCore::HTMLFormCollection::getNamedFormItem): Ditto. (WebCore::HTMLFormCollection::nextNamedItemInternal): Ditto. (WebCore::HTMLFormCollection::namedItem): Ditto. (WebCore::HTMLFormCollection::nextNamedItem): Ditto.
- html/HTMLFormCollection.h: Ditto.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::namedItem): Ditto.
- html/HTMLSelectElement.h: Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Use the new findAnchor function.
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::internalLinkElement): Ditto.
- 9:29 AM Changeset in webkit [39602] by
-
- 7 edits3 adds in trunk
WebCore:
2009-01-05 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Bug 23104: minor mistakes in init functions for animation and transition events
https://bugs.webkit.org/show_bug.cgi?id=23104
Test: fast/events/init-events.html
Also fixed two StorageEvent problems the test case uncovered:
Made document.createEvent("StorageEvent") work.
Allow null values for StorageEvent.oldValue and StorageEvent.newValue.
- dom/Document.cpp: (WebCore::Document::createEvent): Sorted alphabetically by the name of the event class. Added StorageEvent.
- dom/UIEvent.idl: Fixed typo in a comment.
- dom/WebKitAnimationEvent.cpp: (WebCore::WebKitAnimationEvent::initWebKitAnimationEvent): Use all the arguments.
- dom/WebKitTransitionEvent.cpp: (WebCore::WebKitTransitionEvent::initWebKitTransitionEvent): Ditto.
- storage/StorageEvent.idl: Use the ConvertNullToNullString keyword on the arguments to initStorageEvent so it can create events with null values for the oldValue and newValue, just like the real storage events. Note that the properties already had ConvertNullStringTo=Null, so this is just the other half of that.
LayoutTests:
2009-01-05 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
Bug 23104: minor mistakes in init functions for animation and transition events
https://bugs.webkit.org/show_bug.cgi?id=23104
- fast/events/init-events-expected.txt: Added.
- fast/events/init-events.html: Added.
- fast/events/resources/init-events.js: Added.
- 9:26 AM Changeset in webkit [39601] by
-
- 192 edits in trunk/WebCore
2009-01-05 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
Bug 23102: turn on unused parameter warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=23102
First step: Fix the simple cases where we can just remove an argument name.
Also made a few more things protected and private.
- many files
- 9:21 AM Changeset in webkit [39600] by
-
- 8 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23115
Create a version of ASSERT for use with otherwise unused variables
- wtf/Assertions.h: Added ASSERT_UNUSED.
- jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutablePool::systemRelease):
- runtime/Collector.cpp: (JSC::Heap::destroy): (JSC::Heap::heapAllocate):
- runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::toPrimitive): (JSC::JSNotAnObject::getPrimitiveNumber): (JSC::JSNotAnObject::toBoolean): (JSC::JSNotAnObject::toNumber): (JSC::JSNotAnObject::toString): (JSC::JSNotAnObject::getOwnPropertySlot): (JSC::JSNotAnObject::put): (JSC::JSNotAnObject::deleteProperty): (JSC::JSNotAnObject::getPropertyNames):
- wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease): Use it in some places that used other idioms for this purpose.
WebCore:
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::verifySchemaVersion): Use the new ASSERT_UNUSED macro.
- 9:18 AM Changeset in webkit [39599] by
-
- 2 edits in trunk/WebCore
Non-Mac build fix.
- loader/appcache/ApplicationCacheStorage.cpp: Include wtf/StringExtras.h for snprintf.
- 9:15 AM Changeset in webkit [39598] by
-
- 2 edits in trunk/WebCore
Remove unnecessary methods from EmptyFrameLoaderClient
- 12:55 AM Changeset in webkit [39597] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23077
Make application cache use SQLite built-in user_version
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::verifySchemaVersion): Changed to track versions with PRAGMA user_version.
- loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::): Used the occasion to get rid of the hole in bitmask that was a leftover from opportunistic cache entries.
- 12:39 AM Changeset in webkit [39596] by
-
- 3 edits in trunk/WebCore
2009-01-04 David Smith <catfish.man@gmail.com>
Reviewed by Oliver Hunt.
Avoid redundant AtomicString conversions
- dom/Node.cpp: (WebCore::Node::getElementsByTagName): Pass starAtom instead of "*" (WebCore::Node::getElementsByTagNameNS): Take an AtomicString for the namespace URI (WebCore::Node::isDefaultNamespace): Ditto (WebCore::Node::lookupPrefix): Ditto (WebCore::Node::lookupNamespacePrefix): Ditto
- dom/Node.h: Ditto
Jan 4, 2009:
- 11:25 PM Changeset in webkit [39595] by
-
- 4 edits3 adds in trunk
WebCore:
2009-01-04 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 23105: canvas setFillColor function ignores alpha argument
https://bugs.webkit.org/show_bug.cgi?id=23105
Test: fast/canvas/set-colors.html
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFillColor): Pass alpha value through instead of ignoring it and always passing 1.
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): Fix spelling of transparent in comments. (WebCore::CanvasStyle::applyFillColor): Ditto.
LayoutTests:
2009-01-04 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 23105: canvas setFillColor function ignores alpha argument
https://bugs.webkit.org/show_bug.cgi?id=23105
- fast/canvas/resources/set-colors.js: Added.
- fast/canvas/set-colors-expected.txt: Added.
- fast/canvas/set-colors.html: Added.
- 9:41 PM Changeset in webkit [39594] by
-
- 2 edits in trunk/WebCore
2009-01-04 Darin Adler <Darin Adler>
Bug 23086: REGRESSION(r39540/r39541): Windows build fails due to ICU errors
https://bugs.webkit.org/show_bug.cgi?id=23086
- editing/TextIterator.cpp: Check UCONFIG_NO_COLLATION and don't compile in the new search path if it's 0.
- 4:18 PM Changeset in webkit [39593] by
-
- 3 edits in trunk/JavaScriptCore
2009-01-04 Alice Liu <alice.liu@apple.com>
<rdar://problem/6341776> Merge m_transitionCount and m_offset in Structure.
Reviewed by Darin Adler.
- runtime/Structure.cpp: (JSC::Structure::Structure): Remove m_transitionCount (JSC::Structure::addPropertyTransitionToExistingStructure): No need to wait until after the assignment to offset to assert if it's notFound; move it up. (JSC::Structure::addPropertyTransition): Use method for transitionCount instead of m_transitionCount. Remove line that maintains the m_transitionCount. (JSC::Structure::changePrototypeTransition): Remove line that maintains the m_transitionCount. (JSC::Structure::getterSetterTransition): Remove line that maintains the m_transitionCount.
- runtime/Structure.h: Changed s_maxTransitionLength and m_offset from size_t to signed char. m_offset will never become greater than 64 because the structure transitions to a dictionary at that time. (JSC::Structure::transitionCount): method to replace the data member
- 1:09 PM Changeset in webkit [39592] by
-
- 4 edits4 adds in trunk
Don't install internal headers in WebKit framework
Reviewed by Darin Adler.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Remove roles from internal headers so they're not installed.
WebKitTools:
Since WebHTMLRepresentationInternal.h and WebTypesInternal.h are
no longer installed in WebKit.framework/PrivateHeaders, use the
special relationship of DumpRenderTree within the WebKit source
tree to include the internal headers through relative paths.
Created the concept of mac/InternalHeaders to hide the ugly
paths.
- DumpRenderTree/mac/Configurations/Base.xcconfig: Added mac/InternalHeaders to HEADER_SEARCH_PATHS.
- DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Added.
- DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h: Added.
- 12:14 PM Changeset in webkit [39591] by
-
- 4 edits in trunk
Fixed change log entry dates.
- 11:57 AM Changeset in webkit [39590] by
-
- 2 edits in trunk/WebCore
Don't install *.idl and *.in files as resources
Reviewed by Oliver Hunt.
Don't install these files as resources in the WebCore framework:
- WMLAttributeNames.in
- WMLTagNames.in
- WorkerContext.idl
- WorkerLocation.idl
- WorkerNavigator.idl
- WebCore.xcodeproj/project.pbxproj: Removed resources.
- 11:10 AM Changeset in webkit [39589] by
-
- 3 edits in trunk/LayoutTests
2009-01-04 Simon Fraser <Simon Fraser>
Fix the expected image to account for a typo fix done on 2008-12-23.
- platform/mac/fast/transforms/identity-matrix-expected.checksum:
- platform/mac/fast/transforms/identity-matrix-expected.png:
- 10:38 AM Changeset in webkit [39588] by
-
- 3 edits4 adds in trunk
2009-01-04 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
If an object gets a Layout hint, and the style change will result in
the creation of a RenderLayer, then we need to repaint the old position
of the object. This was done for transform, but we have to test opacity too.
Test: fast/repaint/create-layer-repaint.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
- 10:24 AM Changeset in webkit [39587] by
-
- 2 edits in trunk/WebCore
2009-01-04 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23103: Safari's auto-fill no longer works for <select> elements
https://bugs.webkit.org/show_bug.cgi?id=23103
rdar://problem/6472061
- bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:]): Implemented this.
- 10:23 AM Changeset in webkit [39586] by
-
- 4 edits in trunk
Fixed change log entry dates.
- 10:00 AM Changeset in webkit [39585] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-04 Darin Adler <Darin Adler>
Reviewed by David Kilzer.
Bug 15114: Provide compile-time assertions for sizeof(UChar), sizeof(DeprecatedChar), etc.
https://bugs.webkit.org/show_bug.cgi?id=15114
- wtf/unicode/Unicode.h: Assert size of UChar. There is no DeprecatedChar any more.
- 9:39 AM Changeset in webkit [39584] by
-
- 4 edits in trunk/WebKit/qt
Add new API to QWebHitTestResult to return a rect for the smallest enclosing
block element of the hit test
- 9:28 AM Changeset in webkit [39583] by
-
- 2 edits in trunk/WebKit/win
Make the apple windows port build with the new fixedLayoutSize feature
- 9:26 AM Changeset in webkit [39582] by
-
- 2 edits in trunk/WebKit/gtk
Make the gtk port build with the new fixedLayoutSize feature
- 9:25 AM Changeset in webkit [39581] by
-
- 9 edits3 adds in trunk
Make the qt port build and work with the new fixedLayoutSize feature
- 9:25 AM Changeset in webkit [39580] by
-
- 10 edits in trunk/WebCore
Add fixedLayoutSize feature to ScrollView to allow for controlling the
layout beyond the constraint of the current viewports dynamic size
- 6:26 AM Changeset in webkit [39579] by
-
- 2 edits in trunk/LayoutTests
2009-01-04 Darin Adler <Darin Adler>
Suggested by Dan Bernstein.
- platform/mac/editing/selection/move-left-right-expected.txt: Remove WARNING lines that are no longer showing up. Dan said he didn't know why we were seeing those before and why they're gone now, but it's good that they're gone.
- 6:12 AM Changeset in webkit [39578] by
-
- 2 edits in trunk/LayoutTests
2009-01-03 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23095: REGRESSION: fast/text/find-case-folding.html regression test failing when ICU used for text search
https://bugs.webkit.org/show_bug.cgi?id=23095
- fast/text/find-case-folding.html: Work around this ICU bug in the test for now. Later we might want to work around it in our search code instead, or in addition, if we can figure out how to do that.
Jan 3, 2009:
- 10:19 PM Changeset in webkit [39577] by
-
- 3 edits in trunk/JavaScriptCore
2009-01-03 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Change the pcVector from storing native code pointers to storing offsets
from the base pointer. This will allow us to generate the pcVector on demand
for exceptions.
- bytecode/CodeBlock.h: (JSC::PC::PC): (JSC::getNativePCOffset): (JSC::CodeBlock::getBytecodeIndex):
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- 7:22 PM Changeset in webkit [39576] by
-
- 7 edits in trunk
Bug 23091: Some webarchive http tests intermittently fail due to Connection/Keep-Alive header differences
Reviewed by Darin Adler.
WebKitTools:
- DumpRenderTree/mac/DumpRenderTree.mm: (normalizeHTTPResponseHeaderFields): Remove Keep-Alive and Connection headers from webarchive results.
LayoutTests:
Updated test results after removing Keep-Alive and Connection
headers from webarchive tests.
- http/tests/webarchive/test-css-url-encoding-expected.webarchive:
- http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive:
- http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive:
- http/tests/webarchive/test-preload-resources-expected.webarchive:
- 12:00 PM Applications using WebKit edited by
- formatting correction (diff)
- 11:59 AM Applications using WebKit edited by
- Added Google Chrome (diff)
- 11:52 AM Changeset in webkit [39575] by
-
- 7 edits in trunk/WebKit/gtk
[GTK] Fix the reference counting of WebKitWebFrames
The ownership is the following: WebKitWebView owns a WebCore::Page.
WebKitWebView is creating one WebKitWebFrame which will be the
mainFrame of the WebCore::Page (having the reference on the Frame).
The FrameLoaderClient has the reference of the WebKitWebFrame for
the main frame and also any other frame. This means when the
WebCore::Frame goes away the FrameLoaderClient will go away which
will normally remove the last reference of the WebKitWebFrame. Because
an API user might have g_object_ref'ed the WebKitWebFrame null
checks had to be added to WebKitWebFrame.
For WebCore::Frames created by the FrameLoaderClient the ownership
will be passed down to the FrameTree, the WebKitWebFrame is not holding
a reference to the WebCore::Frame.
Do not g_object_unref the mainFrame in the destructor of the
WebKitWebFrame as this will happen from within the WebCore::Page
destruction. Do not hold a reference to the WebCore::Frame (circle) in
WebKitWebFrame, add null checks as the WebCore::Frame might have gone
away. Do not keep track of the FrameLoaderClient in the private
structures as it was mostly unusued.
- 8:48 AM Changeset in webkit [39574] by
-
- 4 edits4 adds in trunk
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=22660
SVG elements that are moved are nor fully invalidated/earsed
Mark the SVG root as needing a layout when its position changes.
Tests: svg/custom/circle-move-invalidation.svg
- 12:21 AM Changeset in webkit [39573] by
-
- 2 edits in trunk/WebCore
Build fix.
- loader/FrameLoader.h:
Jan 2, 2009:
- 9:23 PM Changeset in webkit [39572] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- 8:36 PM Changeset in webkit [39571] by
-
- 7 edits3 adds in trunk
Build fix. Include FrameState.h
- 7:08 PM Changeset in webkit [39570] by
-
- 2 edits in trunk/WebKit/gtk
Build fix. Include FrameState.h
- 6:35 PM Changeset in webkit [39569] by
-
- 2 edits in trunk/WebCore
2009-01-02 Cary Clark <caryclark@google.com>
Reviewed and landed by Darin Adler.
Bug 22963: write icons before reading them
https://bugs.webkit.org/show_bug.cgi?id=22963
Reverse the order in the icon database main thread loop to
write the pending icons to the database before trying
to read any requested icons. This ensures that a requested icon
has the correct data when read.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::syncThreadMainLoop):
- 6:33 PM Changeset in webkit [39568] by
-
- 2 edits in trunk/WebCore
2009-01-02 Darin Adler <Darin Adler>
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): One small thing I forgot in my last check-in. This cuts down on the number of hash table operations during loading.
- 6:27 PM Changeset in webkit [39567] by
-
- 3 edits in trunk/WebCore
2009-01-02 Dmitry Titov <dimich@chromium.org>
Reviewed and landed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=23025
DOMTimer lifetime cleanup: timeoutMap methods on Document now do not delete the timer.
Instead, all 3 places that delete timers do it directly calling 'delete' and then timer's dtor removes the ID from the timeoutMap.
Note that in case the context is destroyed and timers are deleted at once, the check in ~DOMTimer() prevents
unnecessary HashMap remove in case the Document is being destroyed.
- bindings/js/DOMTimer.cpp: (WebCore::DOMTimer::~DOMTimer): removes the id from the timeoutMap. (WebCore::DOMTimer::install): (WebCore::DOMTimer::removeById): simply uses 'delete this'. (WebCore::DOMTimer::fired): same. (WebCore::DOMTimer::contextDestroyed): same.
- dom/Document.cpp: (WebCore::Document::removeTimeout): now it only removes the id from the map, does not delete the timer.
- 6:04 PM Changeset in webkit [39566] by
-
- 10 edits in trunk
WebCore:
2009-01-02 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears
inside its web view when resizing its window
https://bugs.webkit.org/show_bug.cgi?id=23072
rdar://problem/6368028
The first attempt at fixing this did not work.
This time I was able to reproduce the bug and test the fix.
Bug 11212: REGRESSION: Activity window doesn't always list all files until refresh
https://bugs.webkit.org/show_bug.cgi?id=11212
rdar://problem/4959702
I had to fix this second bug because otherwise the WebKit code to trigger the first
fix didn't run.
Also fixes memory use that kept growing as we maintained a set of all URLs loaded in
a particular frame. Bad idea! It's bad enough that we do it for each document, but
the old version kept the set around forever as you moved from one document to the next.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): Change this so that we allow turning off scrolling when the quirk is enabled. We just don't allow turning it on. This fixes one of the two problems with the initial patch; the other fix is in WebKit.
- loader/DocumentLoader.h: Moved didTellClientAboutLoad and haveToldClientAboutLoad here from FrameLoader. The old way meant that a given frame would forever remember the URL of any resources loaded in that frame and never send any "loaded from cache" client calls about those URLs.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Removed call to didTellCientAboutLoad. This is now handled by dispatchWillSendRequest, which is safer since that's the actual function that tells the client about the load. (WebCore::FrameLoader::loadedResourceFromMemoryCache): Changed calls to haveToldClientAboutLoad and didTellClientAboutLoad to call the document loader. Also removed the call in the case where we don't load from the cache, since dispatchWillSendRequest now takes care of it. (WebCore::FrameLoader::dispatchWillSendRequest): Put calls to didTellClientAboutLoad here. Call it both on the URL we pass in and the URL the client returns; we won't tell the client about either if it's loaded from the memory cache.
- loader/FrameLoader.h: Removed didTellClientAboutLoad, haveToldClientAboutLoad, and m_urlsClientKnowsAbout.
- loader/SubresourceLoader.cpp: Removed unneeded load function that called didTellClientAboutLoad. That's now taken care of in dispatchWillSendRequest.
- loader/SubresourceLoader.h: Removed load function. Also made all members private except for create and clearClient.
WebKit/mac:
2009-01-02 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears
inside its web view when resizing its window
https://bugs.webkit.org/show_bug.cgi?id=23072
rdar://problem/6368028
The first attempt at fixing this did not work.
This time I was able to reproduce the bug and test the fix.
- WebCoreSupport/WebFrameLoaderClient.mm: (applyAppleDictionaryApplicationQuirkNonInlinePart): Changed the arguments and function names around a bit to make even less code at the call site. (applyAppleDictionaryApplicationQuirk): Put the check for whether this is the Dictionary application in here. (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): Put a call to applyAppleDictionaryApplicationQuirk here. This was a case I had missed before, when the script is cached. This fixes one of the two problems with the initial patch; the other fix is in WebCore. (WebFrameLoaderClient::dispatchWillSendRequest): Changed the applyAppleDictionaryApplicationQuirk call here to work the new simpler way.
- WebView/WebView.mm: Had to add an include due to changes in WebCore header includes.
- 5:13 PM Changeset in webkit [39565] by
-
- 7 edits in trunk/LayoutTests/platform/mac/fast
Set the svn:mime-type property of recently-added PNG files to image/png.
- 5:06 PM Changeset in webkit [39564] by
-
- 3 edits5 adds in trunk
2009-01-02 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Fix GIF animation by ensuring that the signature of
startAnimation() in the base class matches the method in BitmapImage.
Test: fast/backgrounds/animated-gif-as-background.html
- platform/graphics/Image.h: (WebCore::Image::startAnimation):
- 4:25 PM Changeset in webkit [39563] by
-
- 14 edits2 adds in trunk
2009-01-02 David Smith <catfish.man@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22699
Enable NodeList caching for getElementsByTagName
- wtf/HashFunctions.h: Moved the definition of PHI here and renamed to stringHashingStartValue
WebCore:
2009-01-02 David Smith <catfish.man@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22699
Enable NodeList caching for getElementsByTagName
test: fast/dom/getelementsbytagnamens-mixed-namespaces.html
- dom/Document.cpp: (WebCore::FormElementKeyHash::hash): Use WTF::stringHashingStartValue
- dom/Node.cpp: (WebCore::Node::getElementsByTagNameNS): Ensure rare data and add a node list cache (WebCore::NodeListsNodeData::invalidateCaches): Invalidate the tag name node list cache as well as the others (WebCore::NodeListsNodeData::isEmpty): Check the tag name node list cache as well as the others
- dom/NodeRareData.h: Add m_tagNodeListCaches
- dom/QualifiedName.cpp:
- dom/QualifiedName.h: Move QNameHash to the header, make it work on QualifiedNames, and rename to QualifiedNameHash
- dom/StyledElement.cpp: (WebCore::MappedAttributeHash::hash): Use WTF::stringHashingStartValue
- dom/TagNodeList.cpp: (WebCore::TagNodeList::TagNodeList): Add a NodeList cache argument
- dom/TagNodeList.h: (WebCore::TagNodeList::create): Add a NodeList cache argument
- platform/text/StringHash.h: (WebCore::CaseFoldingHash::hash): Use WTF::stringHashingStartValue
- platform/text/TextEncodingRegistry.cpp: (WebCore::TextEncodingNameHash::hash): Use WTF::stringHashingStartValue
LayoutTests:
2009-01-02 David Smith <catfish.man@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22699
Enable NodeList caching for getElementsByTagName
- fast/dom/getelementsbytagnamens-mixed-namespaces-expected.txt: Added.
- fast/dom/getelementsbytagnamens-mixed-namespaces.html: Added.
- 4:02 PM Changeset in webkit [39562] by
-
- 3 edits2 adds in trunk
2009-01-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler
Fix for https://bugs.webkit.org/show_bug.cgi?id=23066 & <rdar://problem/6028417>
Full Page Zoom: a <video> element that doesn't include width/height attribute does not scale
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::calcReplacedWidth): Multiply aspect ratio width by style()->effectiveZoom() (WebCore::RenderVideo::calcReplacedHeight): Multiply aspect ratio height by style()->effectiveZoom()
2009-01-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler
https://bugs.webkit.org/show_bug.cgi?id=23066 & <rdar://problem/6028417>
Full Page Zoom: a <video> element that doesn't include width/height attribute does not scale
Add test for <video> zoom with and without width/height attributes
- media/video-zoom.html: Added.
- platform/mac/media/video-zoom-expected.txt: Added.
- 2:19 PM Changeset in webkit [39561] by
-
- 4 edits in trunk/WebCore
BUILD FIX (r39552): Add mediaControls.css to other build files
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 1:52 PM Changeset in webkit [39560] by
-
- 2 edits in trunk/WebCore
Try to fix Wx build after r39427
- platform/graphics/wx/PathWx.cpp: (WebCore::Path::strokeBoundingRect): Added stub.
- 1:47 PM Changeset in webkit [39559] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele Peterson.
<rdar://problem/6471356> Failed assertion on quit
- platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::~ThreadGlobalData): Only assert that empty string are all removed on secondary threads.
- 1:25 PM Changeset in webkit [39558] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to fix Qt Linux build after r39553
- wtf/RandomNumberSeed.h: Include <sys/time.h> for gettimeofday(). Include <sys/types.h> and <unistd.h> for getpid().
- 1:22 PM Changeset in webkit [39557] by
-
- 3 edits in trunk/WebCore
2009-01-02 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Use an OwnPtr for m_chromeClient.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::~SVGImage): (WebCore::SVGImage::dataChanged):
- svg/graphics/SVGImage.h:
- 1:10 PM Changeset in webkit [39556] by
-
- 21 edits in trunk
Bug 23081: These files are no longer part of the KDE libraries
Reviewed by Darin Adler.
Removed "This file is part of the KDE libraries" comment from
source files. Added or updated Apple copyrights as well.
- parser/Lexer.h:
- wtf/HashCountedSet.h:
- wtf/RetainPtr.h:
- wtf/VectorTraits.h:
WebCore:
No tests since there are only changes to comments.
- bridge/testbindings.cpp:
- html/HTMLEntityNames.gperf:
- loader/Cache.h:
- loader/CachedCSSStyleSheet.h:
- loader/CachedResourceClient.h:
- loader/CachedResourceClientWalker.cpp:
- loader/CachedResourceClientWalker.h:
- loader/CachedScript.cpp:
- loader/CachedScript.h:
- loader/CachedXBLDocument.cpp:
- loader/CachedXBLDocument.h:
- loader/CachedXSLStyleSheet.cpp:
- loader/CachedXSLStyleSheet.h:
- rendering/GapRects.h:
- xml/XMLSerializer.cpp:
- 1:04 PM Changeset in webkit [39555] by
-
- 30 edits24 adds in trunk
2009-01-02 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Repaints inside of an SVGImage were thrown on the floor,
which broke incremental painting due to loading, or SVG animation.
Fix this by assigning the SVGImage a ChromeClient subclass that passes
along repaints via a new method on ImageObserver, which also takes
a rect parameter for the changed rect, allowing incremental repaints.
Fix RenderImage::imageChanged to take advantage of this changedRect to
only repaint the changed parts of the image.
This also enables incremental painting for canvas-as-image, so
add tests for that too.
Tests: fast/backgrounds/animated-svg-as-background.html
fast/backgrounds/animated-svg-as-mask.html
fast/canvas/canvas-as-image-incremental-repaint.html
fast/canvas/canvas-as-image.html
fast/images/animated-svg-as-image.html
- 12:59 PM Changeset in webkit [39554] by
-
- 38 edits in trunk/JavaScriptCore
Bug 23080: Remove last vestiges of KJS references
Reviewed by Darin Adler.
Also updated Apple copyright statements.
- DerivedSources.make: Changed bison "kjsyy" prefix to "jscyy".
- GNUmakefile.am: Ditto.
- JavaScriptCore.pri: Ditto. Also changed KJSBISON to JSCBISON and kjsbison to jscbison.
- JavaScriptCoreSources.bkl: Changed JSCORE_KJS_SOURCES to JSCORE_JSC_SOURCES.
- jscore.bkl: Ditto.
- create_hash_table: Updated copyright and removed old comment.
- parser/Grammar.y: Changed "kjsyy" prefix to "jscyy" prefix.
- parser/Lexer.cpp: Ditto. Also changed KJS_DEBUG_LEX to JSC_DEBUG_LEX. (jscyylex): (JSC::Lexer::lex):
- parser/Parser.cpp: Ditto. (JSC::Parser::parse):
- pcre/dftables: Changed "kjs_pcre_" prefix to "jsc_pcre_".
- pcre/pcre_compile.cpp: Ditto. (getOthercaseRange): (encodeUTF8): (compileBranch): (calculateCompiledPatternLength):
- pcre/pcre_exec.cpp: Ditto. (matchRef): (getUTF8CharAndIncrementLength): (match):
- pcre/pcre_internal.h: Ditto. (toLowerCase): (flipCase): (classBitmapForChar): (charTypeForChar):
- pcre/pcre_tables.cpp: Ditto.
- pcre/pcre_ucp_searchfuncs.cpp: Ditto. (jsc_pcre_ucp_othercase):
- pcre/pcre_xclass.cpp: Ditto. (getUTF8CharAndAdvancePointer): (jsc_pcre_xclass):
- runtime/Collector.h: Updated header guards using the clean-header-guards script.
- runtime/CollectorHeapIterator.h: Added missing header guard.
- runtime/Identifier.h: Updated header guards.
- runtime/JSFunction.h: Fixed end-of-namespace comment.
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): Renamed "kjsprint" debug function to "jscprint". Changed implementation method from globalFuncKJSPrint() to globalFuncJSCPrint().
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncJSCPrint): Renamed from globalFuncKJSPrint().
- runtime/JSGlobalObjectFunctions.h: Ditto.
- runtime/JSImmediate.h: Updated header guards.
- runtime/JSLock.h: Ditto.
- runtime/JSType.h: Ditto.
- runtime/JSWrapperObject.h: Ditto.
- runtime/Lookup.h: Ditto.
- runtime/Operations.h: Ditto.
- runtime/Protect.h: Ditto.
- runtime/RegExp.h: Ditto.
- runtime/UString.h: Ditto.
- tests/mozilla/js1_5/Array/regress-157652.js: Changed "KJS" reference in comment to "JSC".
- wrec/CharacterClassConstructor.cpp: Change "kjs_pcre_" function prefixes to "jsc_pcre_". (JSC::WREC::CharacterClassConstructor::put): (JSC::WREC::CharacterClassConstructor::flush):
- wtf/unicode/Unicode.h: Change "KJS_" header guard to "WTF_".
- wtf/unicode/icu/UnicodeIcu.h: Ditto.
- wtf/unicode/qt4/UnicodeQt4.h: Ditto.
- 12:17 PM Changeset in webkit [39553] by
-
- 3 edits in trunk/JavaScriptCore
Make randomNumber generate 253 values instead of 232 (or 231 for rand() platforms)
Reviewed by Maciej Stachowiak
- 10:33 AM Changeset in webkit [39552] by
-
- 5 edits1 add in trunk/WebCore
2009-01-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler
Pull media controls css out of html4.css into separate file. Don't generate
wml, svg, or media css globals unless the feature is enabled.
- DerivedSources.make:
Don't include css for unused features.
- WebCore.xcodeproj/project.pbxproj:
include mediaControls.css
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
don't parse or add media css unless VIDEO feature is enabled and the target
element is video or audio
- css/html4.css:
moved media controls css to mediaControls.css
- css/mediaControls.css: Added.
- 10:11 AM Changeset in webkit [39551] by
-
- 2 edits in trunk/JavaScriptCore
Remove declaration for JSC::Identifier::initializeIdentifierThreading()
Reviewed by Alexey Proskuryakov.
- runtime/Identifier.h: (JSC::Identifier::initializeIdentifierThreading): Removed declaration since the implementation was removed in r34412.
- 9:44 AM Changeset in webkit [39550] by
-
- 2 edits6 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23076
Add tests for application cache manifest parse failures
- http/tests/appcache/resources/.htaccess:
- http/tests/appcache/resources/wrong-content-type.manifest: Added.
- http/tests/appcache/resources/wrong-signature.manifest: Added.
- http/tests/appcache/wrong-content-type-expected.txt: Added.
- http/tests/appcache/wrong-content-type.html: Added.
- http/tests/appcache/wrong-signature-expected.txt: Added.
- http/tests/appcache/wrong-signature.html: Added.
- 7:18 AM Changeset in webkit [39549] by
-
- 2 edits in trunk/WebKit/mac
2009-01-02 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin Adler.
Bug 23060: REGRESSION (r38629): Cannot scroll a WebHTMLView using Home/End/Page up/Page down
<https://bugs.webkit.org/show_bug.cgi?id=23060>
<rdar://problem/6467830>
After r38629, all keyboard events get sent by Editor to the EditorClient, even
if the selection is not editable. If the event's command is unsupported by
WebHTMLView, WebHTMLView mistakenly thinks that the event was handled when it
was not. When using the page up / page down keys, the events generated are of
the form scrollPageUp rather than movePageUp, so they are unsupported by
WebHTMLView and cause this bug to occur.
- WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]):
- 3:12 AM Changeset in webkit [39548] by
-
- 8 edits4 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23022
Fix multiple issues with appcache online whitelist handling
Test: http/tests/appcache/online-whitelist.html
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::isURLInOnlineWhitelist): Test whitelist entries as prefixes, making it possible to use them for CGI invocation (as required by HTML5).
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Re-ordered checks, so that resources that are cached, but are also listed in online whitelist are loaded from the cache. This is required by HTML5, although Firefox doesn't match.
- loader/appcache/ManifestParser.cpp: (WebCore::parseManifest):
- loader/appcache/ManifestParser.h:
- loader/appcache/ApplicationCache.h: (WebCore::ApplicationCache::onlineWhitelist):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): (WebCore::ApplicationCacheStorage::loadCache): Changed online whitelist to be a vector of URLs, which is better suited for the new algorithm.
- 1:27 AM Changeset in webkit [39547] by
-
- 10 edits in trunk
WebCore:
2009-01-02 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears inside its web view when resizing its window
https://bugs.webkit.org/show_bug.cgi?id=23072
rdar://problem/6368028
- WebCore.base.exp: Updated.
- WebCore.xcodeproj/project.pbxproj: Mark HTMLHeadElement.h Private so it can be used in WebKit.
- dom/Document.cpp: (WebCore::Document::Document): Initialize m_frameElementsShouldIgnoreScrolling to false.
- dom/Document.h: Added setFrameElementsShouldIgnoreScrolling, frameElementsShouldIgnoreScrolling, and m_frameElementsShouldIgnoreScrolling.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): Don't allow changes to the scrolling attribute to affect the scrolling mode if frameElementsShouldIgnoreScrolling() returns true. This is only triggered on Mac OS X when running the Dictionary application.
WebKit:
2009-01-02 Darin Adler <Darin Adler>
- StringsNotToBeLocalized.txt: Updated.
WebKit/mac:
2009-01-02 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears inside its web view when resizing its window
https://bugs.webkit.org/show_bug.cgi?id=23072
rdar://problem/6368028
- WebCoreSupport/WebFrameLoaderClient.mm: (isAppleDictionaryApplication): Added. (applyAppleDictionaryApplicationQuirk): Added. Under the right conditions, sets a flag to ask HTMLFrameElementBase to ignore the scrolling attribute. (WebFrameLoaderClient::dispatchWillSendRequest): Call the two functions above to apply the quirk when the relevant script is loaded.
- 1:25 AM Changeset in webkit [39546] by
-
- 17 edits4 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23036
<rdar://problem/6451666> Implement AppCache fallback entries (23036)
Test: http/tests/appcache/fallback.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Use fallback entries if normal loading fails.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Do not prevent normal loading for resources that match fallback namespaces - they are only loaded from the cache if that fails. (WebCore::DocumentLoader::getApplicationCacheFallbackResource): Get a fallback entry for resource from associated appcache, or from passed in one, if any. (WebCore::DocumentLoader::scheduleLoadFallbackResourceFromApplicationCache): If a fallback entry for resourse exists, add it to pending substitute loads.
- loader/DocumentLoader.h: Added new functions for loading fallback data for resources.
- loader/ResourceLoader.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache): This function is called when normal loading fails (which includes network failures, 4xx and 5xx responses, and cross-origin redirects) to load appcache fallback data instead. It can use either the cache that is associated with the browsing context, or a custom one if association is yet to take place. (WebCore::ResourceLoader::willSendRequest): Try using fallback data. (WebCore::ResourceLoader::didReceiveResponse): Ditto. (WebCore::ResourceLoader::didFail): Ditto.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): Locate an appropriate cache and load fallback data from it if loading fails. The browsing context may still be associated with its previous document here, so the cache to load from must be passed explicitly. (WebCore::MainResourceLoader::didFail): Ditto. (WebCore::MainResourceLoader::load): Remove unnecessary check and FIXME.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::setFallbackURLs): (WebCore::ApplicationCache::urlMatchesFallbackNamespace):
- loader/appcache/ApplicationCache.h: (WebCore::ApplicationCache::fallbackURLs):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupForURL): (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): (WebCore::ApplicationCacheStorage::store): (WebCore::ApplicationCacheStorage::loadCache): (WebCore::ApplicationCacheStorage::storeCopyOfCache):
- loader/appcache/ApplicationCacheStorage.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
- loader/appcache/ApplicationCacheGroup.h: Implement fallback map saving and loading, pass it to the cache.
- loader/appcache/ManifestParser.h: Use a correct data structure for fallback map - keys are matched by prefix, so HAshMap cannot be used.
- loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Fix bugs in fallback section parsing.
Jan 1, 2009:
- 11:49 PM Changeset in webkit [39545] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6450530> WebCore::FontPlatformData should not leak
Reviewed by Dan Bernstein.
Whoops, previous patch should also have fixed the font referencing in
the constructor.
- 11:46 PM Changeset in webkit [39544] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6450530> WebCore::FontPlatformData should not leak
Reviewed by Dan Bernstein.
Make sure we only adopt the new font, rather than re-referencing (and so leaking).
- 10:09 PM Changeset in webkit [39543] by
-
- 3 edits in trunk/LayoutTests
2009-01-01 Darin Adler <Darin Adler>
Add one more String.replace test case that I should have included in that last check-in.
- fast/js/resources/string-replace-3.js: Added test case that covers more of the cases where $0-$99 are used but are actually valid.
- fast/js/string-replace-3-expected.txt: Added new result.
- 9:56 PM Changeset in webkit [39542] by
-
- 5 edits in trunk
2009-01-01 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
String.replace does not support $& replacement metacharacter when search term is not a RegExp
<https://bugs.webkit.org/show_bug.cgi?id=21431>
<rdar://problem/6274993>
Test: fast/js/string-replace-3.html
- runtime/StringPrototype.cpp: (JSC::substituteBackreferences): Added a null check here so we won't try to handle $$-$9 backreferences when the search term is a string, not a RegExp. Added a check for 0 so we won't try to handle $0 or $00 as a backreference. (JSC::stringProtoFuncReplace): Added a call to substituteBackreferences.
LayoutTests:
2009-01-01 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
String.replace does not support $& replacement metacharacter when search term is not a RegExp
<https://bugs.webkit.org/show_bug.cgi?id=21431>
<rdar://problem/6274993>
- fast/js/resources/string-replace-3.js: Added test cases to cover replace with non-regexp and to cover "$0" and "$00".
- fast/js/string-replace-3-expected.txt: Added new results.
- 8:47 PM Changeset in webkit [39541] by
-
- 3 edits1 delete in trunk
WebCore:
2009-01-01 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23071: REGRESSION (r39536): New test failures after committing patch in bug 23051 (ICU search)
https://bugs.webkit.org/show_bug.cgi?id=23071
Also fix some things that Dan suggested during review of the ICU search patch that I forgot
the first time around.
- editing/TextIterator.cpp: Use ICU search on all platforms that use ICU, now that we've double checked it works everywhere, removing HAVE_ICU_SEARCH entirely. Removed unused m_atBreak data member from the non-ICU code path. (WebCore::TextIterator::TextIterator): Move null check up. (WebCore::TextIterator::handleTextBox): Fix mistake that made the iterator include collapsed whitespace. This was left over from an earlier version of the patch. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Move null check up.
LayoutTests:
2009-01-01 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Turn on the regression test for ICU search on Mac OS X Tiger too.
It was already on for Windows (by accident, failing), but now WebCore has been changed
so it should work fine on all platforms using ICU, which includes both of those.
- platform/mac-tiger/editing/execCommand: Removed.
- platform/mac-tiger/editing/execCommand/findString-diacriticals-expected.txt: Removed.
- 7:06 PM Changeset in webkit [39540] by
-
- 9 edits in trunk/JavaScriptCore
2009-01-01 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Allow 32-bit integers to be stored in JSImmediates, on x64-bit.
Presently the top 32-bits of a 64-bit JSImmediate serve as a sign extension of a 31-bit
int stored in the low word (shifted left by one, to make room for a tag). In the new
format, the top 31-bits serve as a sign extension of a 32-bit int, still shifted left by
one.
The new behavior is enabled using a flag in Platform.h, 'WTF_USE_ALTERNATE_JSIMMEDIATE'.
When this is set the constants defining the range of ints allowed to be stored as
JSImmediate values is extended. The code in JSImmediate.h can safely operate on either
format. This patch updates the JIT so that it can also operate with the new format.
~2% progression on x86-64, with & without the JIT, on sunspider & v8 tests.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::addPtr): (JSC::MacroAssembler::orPtr): (JSC::MacroAssembler::or32): (JSC::MacroAssembler::rshiftPtr): (JSC::MacroAssembler::rshift32): (JSC::MacroAssembler::subPtr): (JSC::MacroAssembler::xorPtr): (JSC::MacroAssembler::xor32): (JSC::MacroAssembler::move): (JSC::MacroAssembler::compareImm64ForBranch): (JSC::MacroAssembler::compareImm64ForBranchEquality): (JSC::MacroAssembler::jePtr): (JSC::MacroAssembler::jgePtr): (JSC::MacroAssembler::jlPtr): (JSC::MacroAssembler::jlePtr): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jnzSubPtr): (JSC::MacroAssembler::joAddPtr): (JSC::MacroAssembler::jzSubPtr):
- assembler/X86Assembler.h: (JSC::X86Assembler::addq_rr): (JSC::X86Assembler::orq_ir): (JSC::X86Assembler::subq_ir): (JSC::X86Assembler::xorq_rr): (JSC::X86Assembler::sarq_CLr): (JSC::X86Assembler::sarq_i8r): (JSC::X86Assembler::cmpq_ir):
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArithSlow_op_lshift): (JSC::JIT::compileFastArith_op_rshift): (JSC::JIT::compileFastArithSlow_op_rshift): (JSC::JIT::compileFastArith_op_bitand): (JSC::JIT::compileFastArithSlow_op_bitand): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArithSlow_op_mod): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArithSlow_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArithSlow_op_mul): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArithSlow_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArithSlow_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArithSlow_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::compileFastArithSlow_op_pre_dec): (JSC::JIT::compileBinaryArithOp):
- jit/JITInlineMethods.h: (JSC::JIT::getConstantOperand): (JSC::JIT::getConstantOperandImmediateInt): (JSC::JIT::isOperandConstantImmediateInt): (JSC::JIT::isOperandConstant31BitImmediateInt): (JSC::JIT::emitFastArithDeTagImmediate): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::emitFastArithReTagImmediate): (JSC::JIT::emitFastArithImmToInt): (JSC::JIT::emitFastArithIntToImmNoCheck):
- runtime/JSImmediate.h: (JSC::JSImmediate::isPositiveNumber): (JSC::JSImmediate::isNegative): (JSC::JSImmediate::rightShiftImmediateNumbers): (JSC::JSImmediate::canDoFastAdditiveOperations): (JSC::JSImmediate::makeValue): (JSC::JSImmediate::makeInt): (JSC::JSImmediate::makeBool): (JSC::JSImmediate::intValue): (JSC::JSImmediate::rawValue): (JSC::JSImmediate::toBoolean): (JSC::JSImmediate::from):
- wtf/Platform.h:
- 6:21 PM Changeset in webkit [39539] by
-
- 13 edits in trunk/LayoutTests/platform/mac/fast
Set the svn:mime-type property of recently-added PNG files to image/png.
- 6:07 PM Changeset in webkit [39538] by
-
- 7 edits4 adds in trunk
2009-01-01 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler, Oliver Hunt
Enable incremental painting of canvas. This turns incremental painting
back on, and fixes issues with stroke width and miters, calling willDraw()
for strokeText and fillText, and taking shadows into account.
Test: fast/canvas/canvas-incremental-repaint.html
- 5:08 PM Changeset in webkit [39537] by
-
- 4 edits in trunk/WebCore
2008-12-29 Konstantin Käfer <kkaefer@gmail.com>
Reviewed by Tim Hatcher.
Fix for https://bugs.webkit.org/show_bug.cgi?id=17229
<rdar://problem/5732829> Inspector should show properties of all JS objects in Console
Prints objects not as plain text but makes them expandable so that
they can be inspected.
- inspector/front-end/Console.js: (): added a parameter "inline" to the WebInspector.Console._format function which indicates
whether the object is printed in the context of another string (with console.log()) or
as sole element.
(.): objects and DOM nodes are now printed in an expandable form when they are printed alone
(i.e. not in the context of a console.log() string) so that they can be inspected.
- inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection.prototype.set title): Allow DOM Nodes as title instead of strings
in that case, the Node is inserted into the title instead of the string value of the passed
object. This is used for displaying linkified titles, for example when inspecting DOM nodes,
the syntax highlighted HTML representation is shown instead of the plain source code.
- inspector/front-end/inspector.css: correct the offsetParent for the expandable object inspector.
- 1:19 PM Changeset in webkit [39536] by
-
- 3 edits7 adds in trunk
WebCore:
2009-01-01 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23051: web page searching should use ICU's search so it can ignore diacritical differences
https://bugs.webkit.org/show_bug.cgi?id=23051
rdar://problem/3574497
Test: editing/execCommand/findString-diacriticals.html
- editing/TextIterator.cpp: Changed the CircularSearchBuffer class to have a new name, since it doesn't always use a circular buffer any more. Changed the interface so it can work well in the new chunky comparison mode for ICU search, and also added private data members for both the ICU-search and non-ICU-search code paths. (WebCore::TextIterator::TextIterator): Use the versions of the Range functions that don't take an exception code. (WebCore::TextIterator::handleTextBox): Added a special case to handle the position of a collapsed-away space better. This is not needed for search mechanism, but was helpful in an earlier version of this patch, and is still an improvement. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Use the versions of the Range functions that don't take an exception code. (WebCore::CharacterIterator::range): Ditto. (WebCore::characterSubrange): Added. Helper function used in both places below where we want to convert a range and character offsets into a subrange. (WebCore::WordAwareIterator::advance): Use the versions of the Range functions that don't take an exception code. (WebCore::createSearcher): Added. (WebCore::searcher): Added. (WebCore::lockSearcher): Added. (WebCore::unlockSearcher): Added. (WebCore::SearchBuffer::SearchBuffer): Added. (WebCore::SearchBuffer::~SearchBuffer): Added. (WebCore::SearchBuffer::append): Added. (WebCore::SearchBuffer::atBreak): Added. (WebCore::SearchBuffer::reachedBreak): Added. (WebCore::SearchBuffer::search): Added. (WebCore::SearchBuffer::length): Added. (WebCore::TextIterator::subrange): Changed to call the characterSubrange function above. (WebCore::TextIterator::rangeFromLocationAndLength): Use the versions of the Range functions that don't take an exception code. Also tweak some other details of the code. (WebCore::isAllCollapsibleWhitespace): Added. (WebCore::collapsedToBoundary): Added. (WebCore::findPlainText): Rewrote to use new interface and streamline the logic a bit.
Add the relevant files in the icu directory. As icu/README says, the "icu"
directory is really just for Mac OS X, where we have the ICU library but not
the headers installed. It should be moved inside platform/mac at some point
to make this more clear (and the copy in JavaScriptCore should be moved
somewhere similar for the same reason).
- icu/unicode/ucoleitr.h: Added.
- icu/unicode/usearch.h: Added.
LayoutTests:
2009-01-01 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23051: web page searching should use ICU's search so it can ignore diacritical differences
https://bugs.webkit.org/show_bug.cgi?id=23051
rdar://problem/3574497
Currently this is only activated on the Mac platform, not including Tiger.
- editing/execCommand/findString-diacriticals-expected.txt: Added. Expect failure.
- editing/execCommand/findString-diacriticals.html: Added.
- platform/mac-tiger/editing/execCommand: Added.
- platform/mac-tiger/editing/execCommand/findString-diacriticals-expected.txt: Added. Expect failure.
- platform/mac/editing/execCommand/findString-diacriticals-expected.txt: Added. Expect success.
- 12:34 AM Changeset in webkit [39535] by
-
- 2 edits in trunk/WebCore
CrashTracer: [REGRESSION] 1090 crashes in Safari at com.apple.JavaScriptCore: KJS::JSGlobalObject::stopTimeoutCheck + 0
<rdar://problem/5821130>
Reviewed by Cameron Zwarich.
This was caused by a plugin instance calling into JS code that removed the plugin
object. This fix is to cache the global object locally in a ProtectedPtr so we don't
need to rely on the continued existence of the plugin instance.
- 12:22 AM Changeset in webkit [39534] by
-
- 7 edits in trunk
[jsfunfuzz] Assertion + incorrect behaviour with dynamically created local variable in a catch block
<https://bugs.webkit.org/show_bug.cgi?id=23063>
Reviewed by Cameron Zwarich
Eval inside a catch block attempts to use the catch block's static scope in
an unsafe way by attempting to add new properties to the scope. This patch
fixes this issue simply by preventing the catch block from using a static
scope if it contains an eval.
Dec 31, 2008:
- 6:33 PM Changeset in webkit [39533] by
-
- 5 edits in trunk
[jsfunfuzz] Computed exception offset wrong when first instruction is attempt to resolve deleted eval
<https://bugs.webkit.org/show_bug.cgi?id=23062>
Reviewed by Gavin Barraclough.
This was caused by the expression information for the initial resolve of
eval not being emitted. If this resolve was the first instruction that
could throw an exception the information search would fail leading to an
assertion failure. If it was not the first throwable opcode the wrong
expression information would used.
Fix is simply to emit the expression info.
- 9:52 AM Changeset in webkit [39532] by
-
- 12 edits in trunk/WebKit/gtk
Add section information for View, Frame, Settings, HistoryItem, BackForwardList, WindowFeatures and Inspector
Add section information and informal examples for WebKitWebView,
WebKitWebFrame, WebKitWebSettings, WebKitWebNetworkRequest,
WebKitWebWindowFeatures, WebKitWebHistoryItem,
WebKitWebBackForwardList and WebKitWebInspector.
- 9:31 AM Changeset in webkit [39531] by
-
- 2 edits in trunk/WebKitTools
2008-12-31 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
Prevent TestNetscapePlugin from installing system-wide.
- GNUmakefile.am:
- 9:12 AM Changeset in webkit [39530] by
-
- 2 edits in trunk/WebCore
2008-12-31 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
MinGW build failure.
- platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::containsCharacters):
- 8:52 AM Changeset in webkit [39529] by
-
- 2 edits in trunk/WebKitTools
2008-12-31 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
Move WebKitWebView's size allocation into a proper place.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest):
- 8:37 AM Changeset in webkit [39528] by
-
- 2 edits in trunk/WebCore
2008-12-31 Alexander V. Butenko <alex@digiqube.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22750
[gtk] webkit up to r39121 crash on image urls like
http:///sitename.com
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start):
- 8:17 AM Changeset in webkit [39527] by
-
- 2 edits in trunk/WebCore
2008-12-31 Hiroyuki Ikezoe <poincare@ikezoe.net>
Reviewed by Holger Freyther.
- platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::determinePitch): Do not invoke isFixedPitch() when the font is a custom font.
- 4:32 AM Changeset in webkit [39526] by
-
- 2 edits in trunk/WebCore
More work on Bug 3781: Animation via canvas could be faster
<https://bugs.webkit.org/show_bug.cgi?id=3781>
Reviewed by Cameron Zwarich
Make use of the fast path parsing of color strings that Color
uses. This improves performance of '#rgb', '#rrggbb', etc and
named (eg. 'green') colors.
Improves frame rate of test by around 40%
- 2:17 AM Changeset in webkit [39525] by
-
- 3 edits2 adds in trunk
2008-12-31 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver Hunt.
Bug 23054: Caching of global lookups occurs even when the global object has become a dictionary
<https://bugs.webkit.org/show_bug.cgi?id=23054>
<rdar://problem/6469905>
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobal): Do not cache lookup if the global object has transitioned to a dictionary. (JSC::Interpreter::cti_op_resolve_global): Do not cache lookup if the global object has transitioned to a dictionary.
LayoutTests:
- fast/js/pic/delete-global-object-expected.txt: Added.
- fast/js/pic/delete-global-object.html: Added.
Dec 30, 2008:
- 10:49 PM Changeset in webkit [39524] by
-
- 7 edits3 adds in trunk
<https://bugs.webkit.org/show_bug.cgi?id=23049> [jsfunfuzz] With blocks do not correctly protect their scope object
<rdar://problem/6469742> Crash in JSC::TypeInfo::hasStandardGetOwnPropertySlot() running jsfunfuzz
Reviewed by Darin Adler
The problem that caused this was that with nodes were not correctly protecting
the final object that was placed in the scope chain. We correct this by forcing
the use of a temporary register (which stops us relying on a local register
protecting the scope) and changing the behaviour of op_push_scope so that it
will store the final scope object.
- 9:16 PM Changeset in webkit [39523] by
-
- 6 edits in trunk/LayoutTests
2008-12-30 Simon Fraser <Simon Fraser>
Fix spurious test failures by rounding floating point values to
mask math differences between machines.
- transitions/transform-op-list-match-expected.txt:
- transitions/transform-op-list-match.html:
- transitions/transform-op-list-no-match-expected.txt:
- transitions/transform-op-list-no-match.html:
- transitions/transition-test-helpers.js: (roundNumber):
- 4:11 PM Changeset in webkit [39522] by
-
- 5 edits4 adds in trunk
2008-12-30 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Rather than doing a repaint() inside of computeAbsoluteRepaintRect()
when there is a reflection, compute the location of the rect inside
the reflection and take the union of the unreflected and reflected rects.
Test: fast/repaint/reflection-redraw.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
- rendering/RenderObject.cpp: (WebCore::RenderObject::reflectedRect):
- rendering/RenderObject.h:
- 4:07 PM Changeset in webkit [39521] by
-
- 5 edits3 adds in trunk
2008-12-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Sam Weinig.
Bug 23037: Parsing and reparsing disagree on automatic semicolon insertion
<https://bugs.webkit.org/show_bug.cgi?id=23037>
<rdar://problem/6467124>
Parsing and reparsing disagree about automatic semicolon insertion, so that a
function like
function() { a = 1, }
is parsed as being syntactically valid but gets a syntax error upon reparsing.
This leads to an assertion failure in Parser::reparse(). It is not that big of
an issue in practice, because in a Release build such a function will return
'undefined' when called.
In this case, we are not following the spec and it should be a syntax error.
However, unless there is a newline separating the ',' and the '}', WebKit would
not treat it as a syntax error in the past either. It would be a bit of work to
make the automatic semicolon insertion match the spec exactly, so this patch
changes it to match our past behaviour.
The problem is that even during reparsing, the Lexer adds a semicolon at the
end of the input, which confuses allowAutomaticSemicolon(), because it is
expecting either a '}', the end of input, or a terminator like a newline.
- parser/Lexer.cpp: (JSC::Lexer::Lexer): Initialize m_isReparsing to false. (JSC::Lexer::lex): Do not perform automatic semicolon insertion in the Lexer if we are in the middle of reparsing. (JSC::Lexer::clear): Set m_isReparsing to false.
- parser/Lexer.h: (JSC::Lexer::setIsReparsing): Added.
- parser/Parser.cpp: (JSC::Parser::reparse): Call Lexer::setIsReparsing() to notify the Lexer of reparsing.
LayoutTests:
- fast/js/reparsing-semicolon-insertion-expected.txt: Added.
- fast/js/reparsing-semicolon-insertion.html: Added.
- fast/js/resources/reparsing-semicolon-insertion.js: Added.
- 2:30 PM Changeset in webkit [39520] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Adele Peterson.
- fix <rdar://problem/6469944> REGRESSION(3.2.1-ToT): Repro crash in WebCore::HTMLInputElement::updatePlaceholderVisibility opening http://billshrink.com
Test: fast/forms/placeholder-non-textfield.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Only call updatePlaceholderVisibility() when the placeholder attribute changes if the element is a text field.
LayoutTests:
Reviewed by Adele Peterson.
- test for <rdar://problem/6469944> REGRESSION(3.2.1-ToT): Repro crash in WebCore::HTMLInputElement::updatePlaceholderVisibility opening http://billshrink.com
- fast/forms/placeholder-non-textfield-expected.txt: Added.
- fast/forms/placeholder-non-textfield.html: Added.
- 11:24 AM Changeset in webkit [39519] by
-
- 2 edits in trunk/WebKitSite
2008-12-30 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Darin Adler.
Landed by Pamela Greene.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22908.
Update website so that newbies are told they must set the
WebKitOutputDir to get a valid build.
- building/build.html: Add language (and link) indicating the importance of setting the WebKitOutputDir variable, as well as a link to instructions on how to do so.
- 4:19 AM Changeset in webkit [39518] by
-
- 3 edits in trunk/WebCore
First step of Bug 3781: Animation via canvas could be faster
Reviewed by Antti Koivisto.
Amortise the cost of calling repaint by coalescing repaint rects
while the canvas is drawn to. In a later step we'll stop calling
repaint() directly, and instead have all dirty canvases repaint
at the end of JS execution.
- 3:08 AM Changeset in webkit [39517] by
-
- 3 edits in trunk/WebCore
2008-12-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Antti Koivisto.
Bug 22931: Using the inspector with purgeable resources leads to assertion failures
<https://bugs.webkit.org/show_bug.cgi?id=22931>
Change InspectorResource::sourceString() so that it doesn't attempt to
unsafely get the data of a purgeable CachedResource.
- inspector/InspectorController.cpp: (WebCore::InspectorResource::sourceString): Attempt to make a purgeable resource unpurgeable, and if this not possible, return an empty string.
- loader/CachedResource.h: Make InspectorResource a friend of CachedResource.
Dec 29, 2008:
- 11:54 PM Changeset in webkit [39516] by
-
- 2 edits in trunk/JavaScriptCore
Yet another attempt to fix Tiger.
Reviewed by NOBODY(Build fix)
- 11:46 PM Changeset in webkit [39515] by
-
- 2 edits in trunk/JavaScriptCore
Tiger build fix (correct this time)
Reviewed by NOBODY(build fix)
- 11:46 PM Changeset in webkit [39514] by
-
- 5 edits in trunk/WebCore
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23023
Remove incomplete support for opportunistic appcache entries
No change in behavior, thus no test.
- loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::Type): Removed Opportunistic bit, will re-use when schema version changes.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
- loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::dumpType):
- 11:42 PM Changeset in webkit [39513] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Rubber-stamped by Alexey Proskuryakov.
Revert r39509, because kjsyydebug is used in the generated code if YYDEBUG is 1.
- parser/Grammar.y:
- 11:39 PM Changeset in webkit [39512] by
-
- 2 edits in trunk/JavaScriptCore
Tiger build fix
Reviewed by NOBODY(build fix)
- 11:33 PM Changeset in webkit [39511] by
-
- 2 edits in trunk/WebCore
2008-12-29 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
Add arcTo support for Cairo. This is needed by Canvas.
Cairo has no native support for arcTo. We have to make our
own implementation.
[Canvas] Cairo needs arcTo
https://bugs.webkit.org/show_bug.cgi?id=23003
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArcTo):
- 11:21 PM Changeset in webkit [39510] by
-
- 3 edits in trunk/JavaScriptCore
<rdar://problem/6358108> Insecure randomness in Math.random() leads to user tracking
Reviewed by Mark Rowe
Switch to arc4random on PLATFORM(DARWIN), this is ~1.5x slower than random(), but the
it is still so fast that there is no fathomable way it could be a bottleneck for anything.
randomNumber is called in two places
- During form submission where it is called once per form
- Math.random in JSC. For this difference to show up you have to be looping on a cached local copy of random, for a large (>10000) calls.
No change in SunSpider.
- 10:15 PM Changeset in webkit [39509] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Rubber-stamped by Sam Weinig.
Remove unused kjsyydebug #define.
- parser/Grammar.y:
- 10:15 PM Changeset in webkit [39508] by
-
- 3 edits3 adds in trunk
Bug 23030: Cannot setTransform with a non-invertible ctm
Reviewed by Cameron Zwarich.
Removed a series of unnecessary and incorrect checks for an invertible
transform.
Test: fast/canvas/canvas-set-properties-with-non-invertible-ctm.html
- 9:37 PM Changeset in webkit [39507] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver Hunt and Sam Weinig.
Bug 23029: REGRESSION (r39337): jsfunfuzz generates identical test files
<https://bugs.webkit.org/show_bug.cgi?id=23029>
<rdar://problem/6469185>
The unification of random number generation in r39337 resulted in random()
being initialized on Darwin, but rand() actually being used. Fix this by
making randomNumber() use random() instead of rand() on Darwin.
- wtf/RandomNumber.cpp: (WTF::randomNumber):
- 9:10 PM Changeset in webkit [39506] by
-
- 2 edits in trunk/WebCore
2008-12-29 Josh Roesslein <jroesslein@gmail.com>
Reviewed by Oliver Hunt.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22968
Context menu rendering error when full page zoomed
- 7:00 PM Changeset in webkit [39505] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-29 Sam Weinig <sam@webkit.org>
Fix buildbots.
- runtime/Structure.cpp:
- 6:05 PM Changeset in webkit [39504] by
-
- 3 edits in trunk/WebCore
2008-12-29 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add some basic memory statistic logging for Node.
- dom/Node.cpp: (WebCore::Node::dumpStatistics): (WebCore::Node::Node): (WebCore::Node::~Node): (WebCore::Node::setDocument):
- dom/Node.h:
- 6:03 PM Changeset in webkit [39503] by
-
- 3 edits in trunk/WebCore
2008-12-29 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove one use of DeprecatedPtrList.
- css/CSSRuleList.cpp: (WebCore::CSSRuleList::~CSSRuleList): (WebCore::CSSRuleList::length): (WebCore::CSSRuleList::item): (WebCore::CSSRuleList::deleteRule): (WebCore::CSSRuleList::append): (WebCore::CSSRuleList::insertRule):
- css/CSSRuleList.h: Change m_lstCSSRules from using DeprecatedPtrList to a Vector. I measured no performance change and was comforted by the fact that we use a Vector for StyleList, which serves the exact same purpose.
- 4:28 PM Changeset in webkit [39502] by
-
- 4 edits in trunk/JavaScriptCore
2008-12-29 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Patch for https://bugs.webkit.org/show_bug.cgi?id=23026
Move the deleted offsets vector into the PropertyMap
Saves 3 words per Structure.
- runtime/PropertyMapHashTable.h:
- runtime/Structure.cpp: (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::fromDictionaryTransition): (JSC::Structure::copyPropertyTable): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::rehashPropertyMapHashTable):
- runtime/Structure.h: (JSC::Structure::propertyStorageSize):
- 1:42 PM Changeset in webkit [39501] by
-
- 2 edits in trunk/WebCore
2008-12-29 Adele Peterson <adele@apple.com>
Reviewed by Brady Eidson.
Fix for https://bugs.webkit.org/show_bug.cgi?id=21797
<rdar://problem/6310682> REGRESSION: Crash in CFHTTPCookieStorageCopy beneath WebCore::cookies() when
running fast/dom/document-attribute-js-null.html and http/tests/security/cookies/create-document.html
Return early if the document is trying to get or set a cookie with an empty cookie url.
- dom/Document.cpp: (WebCore::Document::cookie): (WebCore::Document::setCookie):
- 12:30 PM Changeset in webkit [39500] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
Index: LayoutTests/ChangeLog
===================================================================
--- LayoutTests/ChangeLog (revision 39499)
+++ LayoutTests/ChangeLog (working copy)
@@ -1,3 +1,12 @@
+2008-12-29 Alexey Proskuryakov <ap@webkit.org>
+
+ Reviewed by NOBODY (OOPS!).
+
+ Fix Windows svn update - replace a file with a semicolon in its name with an Apache rewrite.
+
+ * http/tests/appcache/resources/.htaccess: Added.
+ * http/tests/appcache/resources/UNKNOWN_SECTION:: Removed.
+
2008-12-29 Glenn Wilson <gwilson@chromium.org>
Reviewed by Darin Adler.
Index: LayoutTests/http/tests/appcache/resources/.htaccess
===================================================================
--- LayoutTests/http/tests/appcache/resources/.htaccess (revision 0)
+++ LayoutTests/http/tests/appcache/resources/.htaccess (revision 0)
@@ -0,0 +1,2 @@
+RewriteEngine on
+RewriteRule UNKNOWN_SECTION: simple.txt [L,NS]
Index: LayoutTests/http/tests/appcache/resources/UNKNOWN_SECTION:
===================================================================
- 11:22 AM Changeset in webkit [39499] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-29 Glenn Wilson <gwilson@chromium.org>
Reviewed by Darin Adler.
Landed by Pamela Greene.
Added new layout tests verifying that using a locally-scoped
variable in an event handler of a form takes precedence over
names of items in that form.
- fast/forms/var-name-conflict-in-form-event-handler-expected.txt: Added.
- fast/forms/var-name-conflict-in-form-event-handler.html: Added.
- 3:08 AM Changeset in webkit [39498] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver Hunt.
Change code using m_body.get() as a boolean to take advantage of the
implicit conversion of RefPtr to boolean.
- runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction):
Dec 28, 2008:
- 5:35 PM Changeset in webkit [39497] by
-
- 2 edits in trunk/WebCore
2008-12-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Sam Weinig.
Bug 23016: JavaScriptDebugServer::recompileAllJSFunctions() should not execute JS while reparsing all functions
<https://bugs.webkit.org/show_bug.cgi?id=23016>
<rdar://problem/6425077>
JavaScriptDebugServer::recompileAllJSFunctions() calls sourceParsed() while
reparsing all JS functions, which will execute JS in the inspector. Depending
on the order in which functions are recompiled, a function could have a new
body but other functions that have not been recompiled could have an optimized
(in the sense of inline caching) call to it, bypassing the check of whether or
not there is generated bytecode. This leads to a crash caused by accessing
indices off of a null pointer.
To fix the problem, simply delay calling sourceParsed() until after all functions
have been reparsed. The crash isn't 100% reproducible, but on the one test case
I have, this makes it impossible to reproduce after a large number of attempts,
when it used to happen every few attempts.
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
- 4:25 PM Changeset in webkit [39496] by
-
- 3 edits in trunk/WebCore
Rubber-stamped by Antti Koivisto.
Oops, remove some last minute ASSERTS that are obviously wrong.
- 4:16 PM Changeset in webkit [39495] by
-
- 10 edits1 add in trunk/WebCore
Reviewed by Antti Koivisto.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23015
Don't rely on HTMLFormControlElement in RenderTextControl.
Introduce an abstract FormControlElement class, containing the
valueMatchesRenderer/setValueMatchesRenderer, the only HTMLFormControlElement
specific methods that RenderTextControl relies on.
This makes it possible for WML to reuse RenderTextControl.
RenderTextControlSingleLine still relies on HTMLInputElement,
this will change if WMLInputElement is introduced.
- 1:33 PM Changeset in webkit [39494] by
-
- 3 edits in trunk/WebCore
2008-12-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin Adler.
Bug 23006: Many Loader::Host member functions are not safe to use reentrantly
<https://bugs.webkit.org/show_bug.cgi?id=23006>
<rdar://problem/6216106>
Many Loader::Host member functions set m_processingResource to true when they
begin processing a resource and set it to false when they are done. Thanks to
JavaScript and the web inspector, almost anything can happen during the
processing of a resource, including these functions being called reentrantly,
which is unsafe due to this way of using m_processingResource.
This can theoretically cause a Loader::Host to be used after it is freed,
because when Loader::servedPendingRequests() is called, it will free Hosts
that have m_processingResource set to false.
To fix this, we replace m_processingResource with m_numResourcesProcessing,
which is incremented and decremented using a helper object, ProcessingResource.
There are no occurrences of crashes caused by this bug that are reproducible
by multiple people, but this fixes the problem of m_processingResource being
set to false while a Host is still alive.
- loader/loader.cpp: (WebCore::Loader::Host::Host): (WebCore::Loader::Host::didFinishLoading): Change to use ProcessingResource instead of manually setting m_processingResource. (WebCore::Loader::Host::didFail): Ditto. (WebCore::Loader::Host::didReceiveData): Ditto.
- loader/loader.h: (WebCore::Loader::Host::ProcessingResource::ProcessingResource): Added. (WebCore::Loader::Host::ProcessingResource::~ProcessingResource): Added. (WebCore::Loader::Host::processingResource): Change to use m_numResourcesProcessing instead of just getting m_processingResource.
- 11:40 AM Changeset in webkit [39493] by
-
- 3 edits2 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23007
REGRESSION: Timer-related crash when closing Web Inspector
Test: fast/dom/Window/remove-timeout-crash.html
- bindings/js/DOMTimer.cpp: (WebCore::DOMTimer::fired): Besides deleting the timer, make sure to remove it from a Document map.
- 9:19 AM Changeset in webkit [39492] by
-
- 3 edits4 adds in trunk
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=23012
Bring application cache manifest parsing up to date
Test: http/tests/appcache/manifest-parsing.html
- loader/appcache/ManifestParser.cpp: (WebCore::Mode): Added a constant for unknown sections, which are ignored when parsing. This is necessary for future extensions. (WebCore::parseManifest): Parse unknown sections correctly. Ignore trailing tokens in supported sections.
- 9:12 AM Changeset in webkit [39491] by
-
- 9 edits2 moves7 adds in trunk/LayoutTests
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=23009
Add a test for application cache offline operation
- http/tests/resources/network-simulator.php: A proxy script to simulate a network connection that can go offline, using an infinite redirect loop in offline mode to generate an error.
- http/tests/appcache/offline-access-expected.txt: Added.
- http/tests/appcache/offline-access.html: Added.
- http/tests/appcache/resources/offline-access-frame.html: Added.
- http/tests/appcache/resources/offline-access.js: Added.
- http/tests/appcache/resources/offline-access.manifest: Added. Test that an application loads successfully from cache.
- http/tests/resources: Added.
- http/tests/resources/portabilityLayer.php: Copied from LayoutTests/http/tests/xmlhttprequest/resources/portabilityLayer.php.
- http/tests/resources/reset-temp-file.php: Copied from LayoutTests/http/tests/xmlhttprequest/resources/reset-temp-file.php.
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html:
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html:
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html:
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php:
- http/tests/xmlhttprequest/resources/portabilityLayer.php: Removed.
- http/tests/xmlhttprequest/resources/reset-temp-file.php: Removed.
- http/tests/appcache/resources/fail-on-update.php: Moved some common scripts from xmlhttprequest/resources/ to resources/
- 5:54 AM Changeset in webkit [39490] by
-
- 13 edits4 adds in trunk/WebCore
Reviewed by Darin Adler.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22996
RenderTextControl heavily depends on HTMLInputElement & HTMLTextAreaElement.
It handles multi & single line text control rendering in one class. Split up
in two new classes: RenderTextControlSingleLine & RenderTextControlMultiLine.
This has several benefits - code is more readable now, the memory usage
for RenderTextControlMultiLine is reduced, as all stuff related to search fields
lives in RenderTextControlSingleLine, and it's easier to introduce an
abstraction for input/textarea-like elements for other HTML flavours like WML.
- 2:05 AM Changeset in webkit [39489] by
-
- 8 edits in trunk/WebCore
2008-12-28 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22755
Prepare to add create/remove timeout methods to JSWorkerContext by moving
timer-specific code from JSDOMWindowBase to DOMTimer.
Moved everything JS-related from DOMTimer to ScheduledAction.
Now ScheduledAction is what it wanted to be all the time: a JS engine-specific
container for timer callback that knows how to invoke it.
DOMTimer is not anymore JS-specific.
This is mostly moving the code around. No intended functional changes.
- bindings/js/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::install): (WebCore::DOMTimer::removeById): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::stop):
- bindings/js/DOMTimer.h:
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::installTimeout): (WebCore::JSDOMWindowBase::removeTimeout):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
- dom/Document.cpp: (WebCore::Document::addTimeout):
- 12:52 AM Changeset in webkit [39488] by
-
- 3 edits2 adds in trunk
2008-12-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver Hunt.
Bug 22840: REGRESSION (r38349): Gmail doesn't load with profiling enabled
<https://bugs.webkit.org/show_bug.cgi?id=22840>
<rdar://problem/6468077>
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitNewArray): Add an assertion that the range of registers passed to op_new_array is sequential. (JSC::BytecodeGenerator::emitCall): Correct the relocation of registers when emitting profiler hooks so that registers aren't leaked. Also, add an assertion that the 'this' register is always ref'd (because it is), remove the needless protection of the 'this' register when relocating, and add an assertion that the range of registers passed to op_call for function call arguments is sequential. (JSC::BytecodeGenerator::emitConstruct): Correct the relocation of registers when emitting profiler hooks so that registers aren't leaked. Also, add an assertion that the range of registers passed to op_construct for function call arguments is sequential.
LayoutTests:
- fast/profiler/call-register-leak-expected.txt: Added.
- fast/profiler/call-register-leak.html: Added.
Dec 27, 2008:
- 6:54 PM Changeset in webkit [39487] by
-
- 13 edits1 add in trunk/JavaScriptCore
<rdar://problem/6467376> Race condition in WTF::currentThread can lead to a thread using two different identifiers during its lifetime
If a newly-created thread calls WTF::currentThread() before WTF::createThread calls establishIdentifierForPthreadHandle
then more than one identifier will be used for the same thread. We can avoid this by adding some extra synchronization
during thread creation that delays the execution of the thread function until the thread identifier has been set up, and
an assertion to catch this problem should it reappear in the future.
Reviewed by Alexey Proskuryakov.
- wtf/Threading.cpp: Added.
(WTF::NewThreadContext::NewThreadContext):
(WTF::threadEntryPoint):
(WTF::createThread): Add cross-platform createThread function that delays the execution of the thread function until
after the thread identifier has been set up.
- wtf/Threading.h:
- wtf/ThreadingGtk.cpp:
(WTF::establishIdentifierForThread):
(WTF::createThreadInternal):
- wtf/ThreadingNone.cpp:
(WTF::createThreadInternal):
- wtf/ThreadingPthreads.cpp:
(WTF::establishIdentifierForPthreadHandle):
(WTF::createThreadInternal):
- wtf/ThreadingQt.cpp:
(WTF::identifierByQthreadHandle):
(WTF::establishIdentifierForThread):
(WTF::createThreadInternal):
- wtf/ThreadingWin.cpp:
(WTF::storeThreadHandleByIdentifier):
(WTF::createThreadInternal):
Add Threading.cpp to the build.
- GNUmakefile.am:
- JavaScriptCore.pri:
- JavaScriptCore.scons:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- JavaScriptCoreSources.bkl:
- 12:30 AM Changeset in webkit [39486] by
-
- 2 edits in trunk/LayoutTests
Suggested by Dave Levin.
Another attempt to fix the failing XHR tests on Tiger buildbot: make file_put_contents
portable implementation return a result.
- http/tests/xmlhttprequest/resources/portabilityLayer.php:
Dec 26, 2008:
- 1:31 PM Changeset in webkit [39485] by
-
- 2 edits in trunk/LayoutTests
2008-12-26 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Remove ensureTrailingSlash from appcache test.
- http/tests/appcache/resources/fail-on-update.php:
- 1:19 PM Changeset in webkit [39484] by
-
- 2 edits in trunk/WebCore
2008-12-26 Zalan Bujtas <zbujtas@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22999
Check if database thread exists.
- storage/Database.cpp: (WebCore::Database::openAndVerifyVersion): (WebCore::Database::markAsDeletedAndClose): (WebCore::Database::tableNames):
- 1:01 PM Changeset in webkit [39483] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-26 Sam Weinig <sam@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove unused method.
- runtime/Structure.h: Remove mutableTypeInfo.
- 12:00 PM Changeset in webkit [39482] by
-
- 6 edits in trunk/LayoutTests
2008-12-26 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Attempt to fix the failiing XHR tests on tiger buildbot.
Remove the no longer needed ensureTrailingSlash function.
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php:
- http/tests/xmlhttprequest/resources/portabilityLayer.php: Make sys_get_temp_dir() return "/tmp" when it can't find the temp directory through other means.
- http/tests/xmlhttprequest/resources/reset-temp-file.php:
- 11:54 AM Changeset in webkit [39481] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Sam Weinig.
- fix <rdar://problem/6467608> lastVisitWasFailure flag persists in global history after a successful visit
- History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:wasFailure:]): Changed to always update the wasFailure flag on the HistoryItem.
- 11:05 AM Changeset in webkit [39480] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Anders Carlsson.
Fix a layout test that was broken by the previous appcache commit
(it only passed every other time as a result).
- http/tests/appcache/fail-on-update.html:
- 10:59 AM Changeset in webkit [39479] by
-
- 5 edits in trunk/LayoutTests
2008-12-26 Simon Fraser <Simon Fraser>
Update more svg-as-image test results affected by the fix
for SVGImage drawing.
- platform/mac/fast/borders/svg-as-border-image-2-expected.checksum:
- platform/mac/fast/borders/svg-as-border-image-2-expected.png:
- platform/mac/fast/borders/svg-as-border-image-expected.checksum:
- platform/mac/fast/borders/svg-as-border-image-expected.png:
- 10:52 AM Changeset in webkit [39478] by
-
- 3 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23001
A call to applicationCache.update() from a cached event listener should be ignored
Test: http/tests/appcache/idempotent-update.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Only reset m_status after dispatching events.
- 9:40 AM Changeset in webkit [39477] by
-
- 4 edits16 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22997
ASSERTION FAILED: !m_resources.contains(url) in ApplicationCache::addResource()
Tests: http/tests/appcache/top-frame-1.html
http/tests/appcache/top-frame-2.html
http/tests/appcache/top-frame-3.html
http/tests/appcache/top-frame-4.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheForMainRequest): Fixed one more instance of top level frame being used for caching purposes.
- 3:03 AM Changeset in webkit [39476] by
-
- 3 edits in trunk/LayoutTests
2008-12-26 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22950
Added more logging to reset-temp-file to help expose potential issues that could cause test failures (on the tiger buildbot).
If there are issues in reset-temp-file, they are printed from the test access-control-basic-allow-preflight-cache.html
- http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html:
- http/tests/xmlhttprequest/resources/reset-temp-file.php:
- 12:46 AM Changeset in webkit [39475] by
-
- 2 edits in trunk/WebCore
2008-12-26 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22987
Fix for broken test editing/execCommand/5763082.html
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::mergeIdenticalElements): Used local RefPtr to hold onto function parameter across multiple calls.
Dec 25, 2008:
- 1:12 PM Changeset in webkit [39474] by
-
- 7 edits5 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22993
Application cache shouldn't be inherited by subframes
<rdar://problem/6284708> AppCache crashes in ApplicationCacheResource::addType()
This crash happened because main resource for subframe was looked up in top frame's
appcache. If not for the spec change, it could have been fixed by preventing the load
altogether.
Test: http/tests/appcache/foreign-iframe-main.html
I intend to write additional tests for the behavior change.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
- loader/DocumentLoader.h: (WebCore::DocumentLoader::applicationCache):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::load):
- loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::associatedCache): Removed DocumentLoader::topLevelApplicationCache(), and changed callers accordingly.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL): Removed checks for the frame being top-level one, now that subframes are cached independently.
- 6:18 AM Changeset in webkit [39473] by
-
- 6 edits in trunk/WebCore
2008-12-25 Antti Koivisto <Antti Koivisto>
Reviewed by Oliver Hunt.
<rdar://problem/6465669> Frequent !isPurgeable() assertion in WebCore::CachedResource::addClient
Disallow turning resources that are being revalidated to purgable state.
No test, the condition is difficult to produce in DRT.
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::allClientsRemoved):
- loader/CachedImage.cpp: (WebCore::CachedImage::destroyDecodedData):
- loader/CachedResource.cpp: (WebCore::CachedResource::isSafeToMakePurgeable): (WebCore::CachedResource::makePurgeable):
- loader/CachedResource.h:
- loader/CachedScript.cpp: (WebCore::CachedScript::destroyDecodedData):
- 2:55 AM Changeset in webkit [39472] by
-
- 2 edits in trunk/WebCore
Qt build fix.
- WebCore.pro: Added ThreadGlobalData.cpp.
Dec 24, 2008:
- 9:26 PM Changeset in webkit [39471] by
-
- 3 edits in trunk/WebKitTools
Move the guts of determineCurrentSVNRevision to VCSUtils as svnRevisionForDirectory,
and make it work for git too.
Reviewed by Timothy Hatcher.
- Scripts/VCSUtils.pm:
- Scripts/webkitdirs.pm:
- 4:42 PM Changeset in webkit [39470] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.base.exp: Remove a symbol from the export file now that it is no longer generated.
- 1:39 PM Changeset in webkit [39469] by
-
- 7 edits in trunk/LayoutTests
2008-12-24 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt
Update more svg-as-image test results affected by the fix
for SVGImage drawing.
- platform/mac/fast/images/svg-as-background-expected.checksum:
- platform/mac/fast/images/svg-as-background-expected.png:
- platform/mac/fast/images/svg-as-image-expected.checksum:
- platform/mac/fast/images/svg-as-image-expected.png:
- platform/mac/fast/images/svg-as-relative-image-expected.checksum:
- platform/mac/fast/images/svg-as-relative-image-expected.png:
- transforms/2d/compound-transforms-vs-containers.html:
- 10:08 AM Changeset in webkit [39468] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix a typo in ChangeLog.
- 10:06 AM Changeset in webkit [39467] by
-
- 3 edits2 moves in trunk/LayoutTests
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22982
http/tests/navigation/post-goback-repost-policy.html fails on Tiger
Change resources that are accessed with POST form .html to .php. I don't know why Apache 2.0
had no problem with this.
- http/tests/navigation/post-goback-repost-policy.html:
- http/tests/navigation/resources/goback-with-policydelegate.html: Removed.
- http/tests/navigation/resources/goback-with-policydelegate.php: Copied from LayoutTests/http/tests/navigation/resources/goback-with-policydelegate.html.
- http/tests/navigation/resources/post-target-policy-test.html: Removed.
- http/tests/navigation/resources/post-target-policy-test.php: Copied from LayoutTests/http/tests/navigation/resources/post-target-policy-test.html.
- 4:44 AM Changeset in webkit [39466] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix to find addSubresourceURL
This is needed to compile on WebKit/Gtk+
Dec 23, 2008:
- 11:46 PM Changeset in webkit [39465] by
-
- 17 edits2 adds in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22980
WebCore uses more thread specific keys than it really needs
Consolidated ThreadSpecific data into a single ThreadGlobalData structure.
- 10:27 PM Google Summer of Code 2008 edited by
- (diff)
- 10:12 PM Changeset in webkit [39464] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.xcodeproj/project.pbxproj: CSSPropertyNames.h is a generated file so it needs to be explicitly copied
into the PrivateHeaders directory, rather than relying on the automatic copying of headers which runs before the
derived sources are generated.
- 9:23 PM Changeset in webkit [39463] by
-
- 5 edits4 adds in trunk
2008-12-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
If the document element has opacity, we need to erase the view background to
white before painting.
Test: fast/backgrounds/opacity-on-document-element.html
- rendering/RenderView.cpp: (WebCore::rendererObscuresBackground):
- 9:19 PM Changeset in webkit [39462] by
-
- 17 edits in trunk
2008-12-23 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Fix SVGImage painting by ensuring that the SVGImage resizes its FrameView correctly.
Otherwise the FrameView is left at 0x0, and nothing paints.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw):
- 8:39 PM Changeset in webkit [39461] by
-
- 16 edits1 copy in tags/Safari-6528.8/WebKit
Merge r39455.
- 8:39 PM Changeset in webkit [39460] by
-
- 1 edit in tags/Safari-6528.8/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
Disable our custom OTHER_CFLAGS until the build issues are resolved.
- 8:39 PM Changeset in webkit [39459] by
-
- 2 edits in tags/Safari-6528.8/WebKit/mac
Merge r39452.
- 7:51 PM Changeset in webkit [39458] by
-
- 4 edits in trunk
Versioning.
- 7:28 PM Changeset in webkit [39457] by
-
- 1 copy in tags/Safari-6528.8
New tag.
- 1:42 PM Changeset in webkit [39456] by
-
- 52 edits in trunk/WebCore
2008-12-23 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
- improve robustness of undo/redo in HTML editing to fix the following bugs <https://bugs.webkit.org/show_bug.cgi?id=19703> Crash in WebCore::InsertNodeBeforeCommand::doUnapply() <rdar://problem/4059423> DOM operations performed on editable HTML can cause a crash later during Undo
Major categories of improvements:
1) Added null checks.
2) Eliminated type casts without corresponding type checks.
3) Avoided possible infinite loops by building up lists of nodes to operate on
before starting to make DOM changes.
4) Use more RefPtr.
No test at this time, but test cases should follow in separate patches.
- WebCore.xcodeproj/project.pbxproj: Set the role of CSSPropertyNames.h to Private so it can be used in other Private headers, specifically editing ones.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::locateCousinList): Adopt parentElement. (WebCore::CSSStyleSelector::locateSharedStyle): Ditto. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
- dom/Element.cpp: (WebCore::Element::cloneElement): Added.
- dom/Element.h: Added cloneElement and an implementation of parentElement.
- dom/Node.h: Moved parentElement from here to Element.h and changed its implementation so it will return 0 when the parent is not an element (document, document fragment, etc.).
- editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand): Made parent be an Element. Moved assertions from doApply in here. (WebCore::AppendNodeCommand::doApply): Simplified to just a single unchecked appendChild call. (WebCore::AppendNodeCommand::doUnapply): Simplified to just a single remove call.
- editing/AppendNodeCommand.h: Updated.
- editing/ApplyStyleCommand.cpp: (WebCore::createStyleSpanElement): Eliminate casting by creating an element in a more direct way with new instead of createElementNS. (WebCore::ApplyStyleCommand::ApplyStyleCommand): Use PassRefPtr. (WebCore::ApplyStyleCommand::removeCSSStyle): Use CSSPropertyID. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Use cloneElement.
- editing/ApplyStyleCommand.h:
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Use Element* and cloneElement.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyledElement): Use PassRefPtr and unsigned. (WebCore::CompositeEditCommand::removeStyledElement): Ditto. (WebCore::CompositeEditCommand::insertNodeBefore): Ditto. (WebCore::CompositeEditCommand::insertNodeAfter): Ditto. (WebCore::CompositeEditCommand::insertNodeAt): Ditto. (WebCore::CompositeEditCommand::appendNode): Ditto. (WebCore::CompositeEditCommand::removeChildrenInRange): Ditto. Also use a vector to make the list of children in case removing them has side effects. (WebCore::CompositeEditCommand::removeNode): Ditto. (WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto. (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Ditto. (WebCore::CompositeEditCommand::splitTextNode): Ditto. (WebCore::CompositeEditCommand::splitElement): Ditto. (WebCore::CompositeEditCommand::mergeIdenticalElements): Ditto. (WebCore::CompositeEditCommand::wrapContentsInDummySpan): Ditto. (WebCore::CompositeEditCommand::splitTextNodeContainingElement): Ditto. (WebCore::CompositeEditCommand::joinTextNodes): Ditto. (WebCore::CompositeEditCommand::inputText): Ditto. (WebCore::CompositeEditCommand::insertTextIntoNode): Ditto. (WebCore::CompositeEditCommand::deleteTextFromNode): Ditto. (WebCore::CompositeEditCommand::replaceTextInNode): Ditto. (WebCore::CompositeEditCommand::insertNodeAtTabSpanPosition): Ditto. (WebCore::CompositeEditCommand::removeCSSProperty): Ditto. (WebCore::CompositeEditCommand::removeNodeAttribute): Ditto. Implement by calling setNodeAttribute instead of with its own SimpleEditCommand. (WebCore::CompositeEditCommand::setNodeAttribute): Ditto. (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto. (WebCore::CompositeEditCommand::appendBlockPlaceholder): Ditto. (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded): Ditto. (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Ditto. Don't bother using an undoable operation to put the break element into the paragraph element because there's no need to split them and redo this when doing undo/redo. (WebCore::CompositeEditCommand::moveParagraphs): Ditto. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto.
- editing/CompositeEditCommand.h: Ditto.
- editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Use unsigned. (WebCore::DeleteFromTextNodeCommand::doApply): Eliminated inappropriate assertions. (WebCore::DeleteFromTextNodeCommand::doUnapply): Ditto.
- editing/DeleteFromTextNodeCommand.h:
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode): Use PassRefPtr. (WebCore::DeleteSelectionCommand::deleteTextFromNode): Ditto.
- editing/DeleteSelectionCommand.h:
- editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::FormatBlockCommand): Use AtomicString. (WebCore::FormatBlockCommand::doApply): Use Element.
- editing/FormatBlockCommand.h:
- editing/IndentOutdentCommand.cpp: (WebCore::createIndentBlockquoteElement): Use new to create the element instead of calling a function so we have a more specific type. (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Use RefPtr and Element. (WebCore::IndentOutdentCommand::indentRegion): Ditto. (WebCore::IndentOutdentCommand::outdentParagraph): Ditto.
- editing/IndentOutdentCommand.h:
- editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Use unsigned. Added an assertion. (WebCore::InsertIntoTextNodeCommand::doApply): Eliminated inappropriate assertions. (WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
- editing/InsertIntoTextNodeCommand.h:
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::insertNodeAfterPosition): Use Element. (WebCore::InsertLineBreakCommand::insertNodeBeforePosition): Ditto.
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Use Element.
- editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Moved assertions here from doApply. (WebCore::InsertNodeBeforeCommand::doApply): Eliminated inappropriate assertions. Added a null check. (WebCore::InsertNodeBeforeCommand::doUnapply): Simplified to just a single remove call.
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Use Element and cloneElement.
- editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::doApply): Eliminated inappropriate assertions. Added some runtime checks. Don't store anything in m_offset. (WebCore::JoinTextNodesCommand::doUnapply): Ditto.
- editing/JoinTextNodesCommand.h:
- editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): Moved an assertion here from doApply. (WebCore::MergeIdenticalElementsCommand::doApply): Eliminated inappropriate assertions. Added a null check. Changed implementation to use remove to avoid null parent issue. Use a vector of nodes to avoid possible infinite loop if mutation happens while iterating. (WebCore::MergeIdenticalElementsCommand::doUnapply): Ditto.
- editing/ModifySelectionListLevel.cpp: (WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange): Use Element*. (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
- editing/ModifySelectionListLevel.h:
- editing/RemoveCSSPropertyCommand.cpp: (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): Use PassRefPtr and CSSPropertyID. Also renamed m_decl to m_style. (WebCore::RemoveCSSPropertyCommand::doApply): Eliminated inappropriate assertions. (WebCore::RemoveCSSPropertyCommand::doUnapply): Ditto.
- editing/RemoveNodeAttributeCommand.cpp: Removed contents of this file. To be deleted. Use SetNodeAttributeCommand instead.
- editing/RemoveNodeAttributeCommand.h: Ditto.
- editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::RemoveNodeCommand): Moved assertions here from doApply. Don't initialize m_refChild here; rather do it in doApply. (WebCore::RemoveNodeCommand::doApply): Eliminated inappropriate assertions. Added checks and streamlined implementation. (WebCore::RemoveNodeCommand::doUnapply): Ditto.
- editing/RemoveNodeCommand.h:
- editing/RemoveNodePreservingChildrenCommand.cpp: (WebCore::RemoveNodePreservingChildrenCommand::doApply): Use a vector.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering): Removed now-unneeded cast.
- editing/SetNodeAttributeCommand.cpp: (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand): Use AtomicString. Removed assertion that prevents us from using this to remove an attribute. (WebCore::SetNodeAttributeCommand::doApply): Eliminated inappropriate assertions. (WebCore::SetNodeAttributeCommand::doUnapply): Ditto.
- editing/SetNodeAttributeCommand.h:
- editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::SplitElementCommand): Moved assertion here from doApply. (WebCore::SplitElementCommand::doApply): Check some more invariants and use a vector to avoid possible infinite loops. (WebCore::SplitElementCommand::doUnapply): Ditto.
- editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::SplitTextNodeCommand): Moved assertions and comment here from doApply. (WebCore::SplitTextNodeCommand::doApply): Check for null and failures when applying. (WebCore::SplitTextNodeCommand::doUnapply): Ditto.
- editing/SplitTextNodeContainingElementCommand.cpp: (WebCore::SplitTextNodeContainingElementCommand::doApply): Use Element.
- editing/WrapContentsInDummySpanCommand.cpp: (WebCore::WrapContentsInDummySpanCommand::doApply): Check for null and ignore failures. Don't reuse the dummy span. Simplified logic. (WebCore::WrapContentsInDummySpanCommand::doUnapply): Ditto.
- editing/htmlediting.cpp: (WebCore::isBlock): Make sure this returns true only for elements. (WebCore::enclosingBlock): Return an Element*. (WebCore::enclosingTableCell): Ditto. (WebCore::enclosingList): Return an HTMLElement*. (WebCore::outermostEnclosingList): Return an HTMLElement*. (WebCore::createDefaultParagraphElement): Return an HTMLElement*. (WebCore::createBreakElement): Return an HTMLElement*. (WebCore::createOrderedListElement): Return an HTMLElement*. (WebCore::createUnorderedListElement): Return an HTMLElement*. (WebCore::createListItemElement): Return an HTMLElement*. (WebCore::createHTMLElement): Return an HTMLElement*.
- editing/htmlediting.h:
- editing/markup.cpp: (WebCore::createFragmentFromText): Use createBreakElement and use Element*.
- page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::targetNode): Use parentElement.
- 1:40 PM Changeset in webkit [39455] by
-
- 16 edits1 add in trunk/WebKit
WebKit:
2008-12-23 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
- fix https://bugs.webkit.org/show_bug.cgi?id=22976 crash due to Mail's use of WebArchive and WebResource on non-main thread
- StringsNotToBeLocalized.txt: Updated.
- WebKit.xcodeproj/project.pbxproj: Added new file WebNSObjectExtras.mm and existing file WebResourceInternal.h.
WebKit/mac:
2008-12-23 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov (a slightly earlier version).
- fix https://bugs.webkit.org/show_bug.cgi?id=22976 crash due to Mail's use of WebArchive and WebResource on non-main thread
- Misc/WebKitLogging.h: Improved comments for ASSERT_MAIN_THREAD. Got rid of WebKitRunningOnMainThread function, which was just a cover for pthread_main_np.
- Misc/WebKitLogging.m: Ditto.
- Misc/WebKitVersionChecks.h: Added a version after which we won't do the main thread workaround.
- Misc/WebNSObjectExtras.h: Added a new method, _webkit_getPropertyOnMainThread:, which performs a selector on the main thread, waits for it to complete, and then returns the value on the caller thread.
- Misc/WebNSObjectExtras.mm: Added.
- WebView/WebArchive.mm: (-[WebArchive init]): Added WebCoreThreadViolationCheck. (-[WebArchive initWithMainResource:subresources:subframeArchives:]): Perform initialization on main thread if needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck. (-[WebArchive initWithData:]): Added WebCoreThreadViolationCheck. (-[WebArchive mainResource]): Get property on main thread if needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck. (-[WebArchive subresources]): Ditto. (-[WebArchive subframeArchives]): Ditto. (-[WebArchive data]): Ditto. (-[WebArchive _initWithCoreLegacyWebArchive:]): Added WebCoreThreadViolationCheck. (-[WebArchive _coreLegacyWebArchive]): Ditto. (-[WebArchive _initWithArguments:]): Added. Used to implement the cross-thread version of initWithMainResource above.
- WebView/WebResource.mm: (-[WebResource initWithCoder:]): Added WebCoreThreadViolationCheck. (-[WebResource data]): Get property on main thread if needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck. (-[WebResource URL]): Ditto. (-[WebResource MIMEType]): Ditto. (-[WebResource textEncodingName]): Ditto. (-[WebResource frameName]): Ditto. (-[WebResource _ignoreWhenUnarchiving]): Ditto. (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): Perform initialization on main thread if needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck. (-[WebResource _suggestedFilename]): Added. Helper for _fileWrapperRepresentation. (-[WebResource _fileWrapperRepresentation]): Rewrote to use methods instead of getting at coreResource directly. (-[WebResource _response]): Get property on main thread if needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck. (-[WebResource _stringValue]): Ditto. (+[WebResource _needMailThreadWorkaroundIfCalledOffMainThread]): Added. (-[WebResource _initWithArguments:]): Added. Used to implement the cross-thread version of _initWithData above.
- WebView/WebResourceInternal.h: Changed to include WebResourcePrivate.h since internal clients have access to the SPI as well as the API. Added definition of MAIL_THREAD_WORKAROUND and the needMainThreadWorkaround helper function.
- Misc/WebIconDatabase.mm: Removed include of now-defunct FoundationExtras.h file. This probably fixes clean builds.
- WebCoreSupport/WebIconDatabaseClient.mm: Ditto.
- WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebResourcePrivate.h, since it's not actually used.
- WebView/WebDataSource.mm: Ditto.
- WebView/WebHTMLRepresentation.mm: Ditto.
- 12:28 PM Changeset in webkit [39454] by
-
- 3 edits in trunk/WebCore
2008-12-23 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- dom/Node.h: Tweak comments and order of bits that Sam moved here last night.
- dom/Node.cpp: Ditto.
- 11:01 AM Changeset in webkit [39453] by
-
- 8 edits23 adds in trunk
WebCore:
2008-12-22 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 11106: Some XMLHttpRequest URI resolving tests fail
https://bugs.webkit.org/show_bug.cgi?id=11106
Use the ScriptExecutionContext to resolve the URI when calling open in JavaScript.
The previous code was using the containing DOMWindow to do so which would fail for
XMLHttpRequest object being passed between iframe.
Tests: http/tests/xmlhttprequest/uri-resolution-opera-open-004.html
http/tests/xmlhttprequest/uri-resolution-opera-open-005.html
http/tests/xmlhttprequest/uri-resolution-opera-open-006.html
http/tests/xmlhttprequest/uri-resolution-opera-open-007.html
http/tests/xmlhttprequest/uri-resolution-opera-open-008.html
http/tests/xmlhttprequest/uri-resolution-opera-open-009.html
http/tests/xmlhttprequest/uri-resolution-opera-open-010.html
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): Use the ScriptExecutionContext to resolve the URL.
- dom/Document.cpp: (WebCore::Document::virtualCompleteURL): Virtual method added to avoid performance hit on completeURL call.
- dom/Document.h:
- dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::completeURL): Non-virtual method that wrap the call to the virtual call.
- dom/WorkerContext.cpp: (WebCore::WorkerContext::virtualCompleteURL): Pure virtual method.
- dom/WorkerContext.h:
LayoutTests:
2008-12-22 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Test case for bug 11106: Some XMLHttpRequest URI resolving tests fail
https://bugs.webkit.org/show_bug.cgi?id=11106
These tests are borrowed from Opera's test case suite (http://tc.labs.opera.com/apis/XMLHttpRequest).
They correspond to open/004.html - open/010.html which were previously failing.
- http/tests/xmlhttprequest/resources/test-uri-resolution.txt: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-004-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-005-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-006-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-007-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-008-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-009-iframe.html: Added.
- http/tests/xmlhttprequest/resources/uri-resolution-opera-open-010-iframe.html: Added.
- http/tests/xmlhttprequest/test-uri-resolution.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-004-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-004.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-005-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-005.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-006-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-006.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-007-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-007.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-008-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-008.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-009-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-009.html: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-010-expected.txt: Added.
- http/tests/xmlhttprequest/uri-resolution-opera-open-010.html: Added.
- 9:25 AM Changeset in webkit [39452] by
-
- 2 edits in trunk/WebKit/mac
2008-12-23 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- fix https://bugs.webkit.org/show_bug.cgi?id=22979 crash seen in -[WebView drawsBackground] when quitting <rdar://problem/6464601>
- WebView/WebView.mm: (-[WebView drawsBackground]): Added comment and a null check for _private.
- 9:22 AM Changeset in webkit [39451] by
-
- 3 edits in trunk/WebCore
2008-12-23 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=22978 a couple tweaks to the new strokeBoundingRect functions
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::strokeBoundingRect): Only create a GraphicsContext if the applier is non-null.
- platform/graphics/cg/PathCG.cpp: (WebCore::putBytesNowhere): Added. (WebCore::createScratchContext): Changed to use a "/dev/null" type function to discard bytes rather than using a data object. This eliminates the possibility that memory will be used if someone draws into the scratch context by accident. Also moved to the top of the file; it was in a slightly strange place before. (WebCore::Path::strokeBoundingRect): Only create a GraphicsContext if the applier is non-null. Simplify the empty path special case.
Dec 22, 2008:
- 11:08 PM Changeset in webkit [39450] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Fix rounding / bounds / signed comparison bug in ExecutableAllocator.
ExecutableAllocator::alloc assumed that m_freePtr would be aligned. This was
not always true, since the first allocation from an additional pool would not
be rounded up. Subsequent allocations would be unaligned, and too much memory
could be erroneously allocated from the pool, when the size requested was
available, but the size rounded up to word granularity was not available in the
pool. This may result in the value of m_freePtr being greater than m_end.
Under these circumstances, the unsigned check for space will always pass,
resulting in pointers to memory outside of the arena being returned, and
ultimately segfaulty goodness when attempting to memcpy the hot freshly jitted
code from the AssemblerBuffer.
https://bugs.webkit.org/show_bug.cgi?id=22974
... and probably many, many more.
- jit/ExecutableAllocator.h: (JSC::ExecutablePool::alloc): (JSC::ExecutablePool::roundUpAllocationSize): (JSC::ExecutablePool::ExecutablePool): (JSC::ExecutablePool::poolAllocate):
- 7:05 PM Changeset in webkit [39449] by
-
- 5 edits in trunk/WebCore
2008-12-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Save a word in all Elements by moving the 5 loose bits to Node,
where we had 16 spare.
- dom/Element.cpp: (WebCore::Element::Element):
- dom/Element.h:
- dom/Node.cpp: (WebCore::Node::Node):
- dom/Node.h:
- 6:14 PM Changeset in webkit [39448] by
-
- 6 edits2 adds in trunk/WebCore
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22972
Add WML <meta> element support. All needed functionality is present
in Document::processHttpEquiv, already covered by tests.
- 5:55 PM Changeset in webkit [39447] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Darin Adler.
Don't reference specific layout tests in comments.
- 5:31 PM Changeset in webkit [39446] by
-
- 2 edits in trunk/WebCore
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22965
Add WML <head> element support. Doesn't require a WMLHeadElement.
No functional behaviour, as we already created a WMLElement for headTag, by default.
It's just cleaner to list <head> in WMLTagNames, forwarding to a WMLElement constructor.
- 5:29 PM Changeset in webkit [39445] by
-
- 3 edits3 adds in trunk
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22971
Fix regression caused by the HTMLFormElement refactorization.
File form elements without a name have to be included in multipart/form-data
submission. Cover this behaviour with a new test case.
- 5:06 PM Changeset in webkit [39444] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6438298> Bump schema version for app cache
Reviewed by Alexey Proskuryakov.
- loader/appcache/ApplicationCacheStorage.cpp: Increment SchemaVersion from 2 to 3.
- 4:49 PM Changeset in webkit [39443] by
-
- 2 edits in trunk/WebCore
Use Deque in CSSStyleSheet::addSubresourceStyleURLs()
Reviewed by Darin Adler.
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Replaced use of ListHashSet with more efficient Deque.
- 4:25 PM Changeset in webkit [39442] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
Fix obvious crash fix for WML enabled builds.
- 4:00 PM Changeset in webkit [39441] by
-
- 46 edits16 adds in trunk
Bug 11850: Webarchive fails to save images referenced in CSS
Reviewed by Darin Adler.
WebCore:
This entry contains two parts since the tests for adding a
completeURL() method to StyleSheet and CSSStyleSheet (part 1) depend
on Bug 11850 being fixed (part 2).
--
Tests: http/tests/webarchive/test-css-url-encoding-shift-jis.html
http/tests/webarchive/test-css-url-encoding-utf-8.html
http/tests/webarchive/test-css-url-encoding.html
Added completeURL() methods to StyleSheet and CSSStyleSheet that
match the behavior of Document::completeURL(). Most notably,
CSSStyleSheet::completeURL() uses the charset of the stylesheet
(if it exists) to construct URLs, just like Document::completeURL().
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Use CSSStyleSheet::completeURL(). (WebCore::CSSParser::parseContent): Ditto. (WebCore::CSSParser::parseFillImage): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseBorderImage): Ditto.
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::completeURL): Added.
- css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::completeURL): Added declaration.
- css/StyleSheet.cpp: (WebCore::StyleSheet::completeURL): Added.
- css/StyleSheet.h: (WebCore::StyleSheet::completeURL): Added declaration.
- dom/Document.cpp: (WebCore::Document::completeURL): Added comment referring to the new completeURL() methods in StyleSheet and CSSStyleSheet.
--
Tests: webarchive/test-css-url-resources-in-stylesheets.html
webarchive/test-css-url-resources-inline-styles.html
Walk stylesheets and inline style attributes for url() references
when building a list of URLs to include in a webarchive. Note that
not all URLs found this way will be included in the webarchive if
they were not used (and thus not downloaded) when laying out the
page.
The key method for CSS stylesheets is
CSSStyleSheet::addSubresourceStyleURLs() which iterates over all
CSSStyleSheet objects recursively referenced from its own stylesheet
through @import rules. Starting with the CSSRule objects in each
sheet and continuing down through the CSSMutableStyleDeclaration and
CSSValue objects, addSubresourceStyleURLs() methods are called to
gather URLs.
For inline style attributes in HTML DOM elements,
StyledElement::addSubresourceAttributeURLs() calls
CSSMutableStyleDeclaration::addSubresourceStyleURLs() to gather URLs
from each element, hence the need to call
addSubresourceAttributeURLs() on superclasses when the method is
implemented on the element class itself.
- css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added.
- css/CSSBorderImageValue.h: (WebCore::CSSBorderImageValue::addSubresourceStyleURLs): Added declaration.
- css/CSSFontFaceRule.cpp: (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added.
- css/CSSFontFaceRule.h: (WebCore::CSSFontFaceRule::addSubresourceStyleURLs): Added declaration.
- css/CSSFontFaceSrcValue.cpp: (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added.
- css/CSSFontFaceSrcValue.h: (WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs): Added declaration.
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::addSubresourceStyleURLs): Added.
- css/CSSImportRule.h: (WebCore::CSSImportRule::addSubresourceStyleURLs): Added declaration.
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added. Iterates over m_properties vector of CSSProperty objects calling addSubresourceStyleURLs() on each property's CSSValue object.
- css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::addSubresourceStyleURLs): Added declaration.
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added.
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::addSubresourceStyleURLs): Added declaration.
- css/CSSReflectValue.cpp: (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added.
- css/CSSReflectValue.h: (WebCore::CSSReflectValue::addSubresourceStyleURLs): Added declaration.
- css/CSSRule.h: (WebCore::CSSRule::addSubresourceStyleURLs): Added. Virtual method with empty implementation that's overridden by subclasses as needed.
- css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added.
- css/CSSStyleRule.h: (WebCore::CSSStyleRule::addSubresourceStyleURLs): Added declaration.
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated to call CSSRule::addSubresourceStyleURLs on each rule to extract URLs. Removed unneeded baseURL parameter now that the completeURL() method exists.
- css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Updated declaration.
- css/CSSValue.h: (WebCore::CSSValue::addSubresourceStyleURLs): Added. Virtual method with empty implementation that's overridden by subclasses as needed.
- css/CSSValueList.cpp: (WebCore::CSSValueList::addSubresourceStyleURLs): Added. Iterates over m_values vector of CSSValue objects calling addSubresourceStyleURLs() on each.
- css/CSSValueList.h: (WebCore::CSSValueList::addSubresourceStyleURLs): Added declaration.
- css/StyleSheet.h: (WebCore::StyleSheet::addSubresourceStyleURLs): Updated declaration to remove unneeded baseURL parameter.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::addSubresourceAttributeURLs): Fixed to use the StyleBase::baseURL() method to get the stylesheet's URL instead of calling Document::completeURL().
- dom/StyledElement.cpp: (WebCore::StyledElement::addSubresourceAttributeURLs): Added method to extract URLs from inline style declarations.
- dom/StyledElement.h: (WebCore::StyledElement::addSubresourceAttributeURLs): Added declaration.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Call addSubresourceAttributeURLs() in superclass to extract URLs from inline style declarations.
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.
LayoutTests:
The first set of files below tests that URLs are encoded properly
based on the charset of the stylesheet. Normally this behavior may
only be tested by looking at web server logs with manual tests, but
webarchives represent this information in such a way that they may
be tested by DumpRenderTree. Note that these tests depend on Bug
11850 being fixed, so it's not possible to separate them.
The second set of files below tests that all types of resources
referenced by url() in CSS stylesheets are now saved in webarchives.
- http/tests/webarchive/resources/.htaccess: Added.
- http/tests/webarchive/resources/apple.gif: Copied from LayoutTests/fast/canvas/resources/apple.gif.
- http/tests/webarchive/resources/test-no-charset.css: Added.
- http/tests/webarchive/resources/test-shift-jis.css: Added.
- http/tests/webarchive/resources/test-utf-8.css: Added.
- http/tests/webarchive/test-css-url-encoding-expected.webarchive: Added.
- http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive: Added.
- http/tests/webarchive/test-css-url-encoding-shift-jis.html: Added.
- http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive: Added.
- http/tests/webarchive/test-css-url-encoding-utf-8.html: Added.
- http/tests/webarchive/test-css-url-encoding.html: Added.
- webarchive/resources/Ahem.ttf: Copied from LayoutTests/fast/css/resources/Ahem.ttf.
- webarchive/test-css-url-resources-in-stylesheets-expected.webarchive: Added.
- webarchive/test-css-url-resources-in-stylesheets.html: Added.
- webarchive/test-css-url-resources-inline-styles-expected.webarchive: Added.
- webarchive/test-css-url-resources-inline-styles.html: Added.
- 1:21 PM Changeset in webkit [39440] by
-
- 8 edits in trunk/JavaScriptCore
2008-12-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Rename all uses of the term "repatch" to "patch".
- assembler/MacroAssembler.h: (JSC::MacroAssembler::DataLabelPtr::patch): (JSC::MacroAssembler::DataLabel32::patch): (JSC::MacroAssembler::Jump::patch): (JSC::MacroAssembler::PatchBuffer::PatchBuffer): (JSC::MacroAssembler::PatchBuffer::setPtr): (JSC::MacroAssembler::loadPtrWithAddressOffsetPatch): (JSC::MacroAssembler::storePtrWithAddressOffsetPatch): (JSC::MacroAssembler::storePtrWithPatch): (JSC::MacroAssembler::jnePtrWithPatch):
- assembler/X86Assembler.h: (JSC::X86Assembler::patchAddress): (JSC::X86Assembler::patchImmediate): (JSC::X86Assembler::patchPointer): (JSC::X86Assembler::patchBranchOffset):
- interpreter/Interpreter.cpp: (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_put_by_id): (JSC::Interpreter::cti_op_get_by_id): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_vm_dontLazyLinkCall):
- jit/JIT.cpp: (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::linkCall): (JSC::JIT::compileOpCall):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- 1:20 PM Changeset in webkit [39439] by
-
- 2 edits in trunk/WebCore
2008-12-22 Dhananjoy Chutia <dhanrd@gmail.com>
Reviewed by David Kilzer.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22959
Memory leak fixes for WebKit+soup
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback):
- 11:19 AM Changeset in webkit [39438] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
<rdar://problem/6449588> REGRESSION (r38279-r38280): Minimize them remaximize a window with a flash plugin, plugin doesn't resume at full speed
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): Deminiaturizing should restart timers, not stop timers.
- 10:16 AM Changeset in webkit [39437] by
-
- 4 edits5 adds in trunk
Reviewed by Darin Adler.
<rdar://problem/6277060> ASSERTION FAILED: !m_cacheBeingUpdated if the manifest is not available
Tests: http/tests/appcache/404-manifest.html
http/tests/appcache/fail-on-update.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::stopLoading): Removed the incorrect assertion.
- loader/appcache/ApplicationCacheGroup.h: Added an explanation of somewhat nonintuitive m_currentHandle handling.
- 8:00 AM Changeset in webkit [39436] by
-
- 13 edits8 adds in trunk
Reviewed by Alexey Proskuryakov & George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22961
Add WML <fieldset> element support.
Unlike HTML's <fieldset> element, WML doesn't provide a <legend> child element
to describe the <fieldset>. WML instead offers a 'title' attribute on the <fieldset>
element. To integrate within the existing RenderFieldset code, we just create an
internal <insertedLegend> element as first child for a WML <fieldset> element, containing
the title attribute value.
- 6:28 AM Changeset in webkit [39435] by
-
- 2 edits in trunk/JavaScriptCore
Build fix after r39428
- jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase): Added a missing MacroAssembler::
Dec 21, 2008:
- 11:31 PM Changeset in webkit [39434] by
-
- 6 edits in trunk/LayoutTests
2008-12-21 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Attempted fix for 4 failing XMLHttpReuqest tests on Tiger:
access-control-basic-allow-preflight-cache-invalidation-by-header.html
access-control-basic-allow-preflight-cache-invalidation-by-method.html
access-control-basic-allow-preflight-cache-timeout.html
access-control-basic-allow-preflight-cache.html
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php:
- http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php:
- http/tests/xmlhttprequest/resources/portabilityLayer.php:
- http/tests/xmlhttprequest/resources/reset-temp-file.php:
- 6:57 PM Changeset in webkit [39433] by
-
- 2 edits in trunk/WebCore
Not reviewed. Try to fix clean Mac builds, set role=private for FormDataBuilder.h
- 6:22 PM Changeset in webkit [39432] by
-
- 80 edits in trunk
Rubber-stamped by George Staikos.
Unify all TorchMobile copyright lines. Consolidate in a single line, as requested by Mark Rowe, some time ago.
- 6:04 PM Changeset in webkit [39431] by
-
- 16 edits17 adds in trunk
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22638
Add POST method support to WMLGoElement. GET & POST over HTTP
covered by a new set of WML HTTP layout tests.
Tests: http/tests/wml/go-task-get-method-accept-charset.html
http/tests/wml/go-task-get-method.html
http/tests/wml/go-task-post-method-accept-charset.html
http/tests/wml/go-task-post-method.html
- 5:45 PM Changeset in webkit [39430] by
-
- 9 edits2 adds in trunk/WebCore
Reviewed by Darin Adler and George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22949
Refactor HTMLFormElement to share a maximum level of code between HTMLFormElement & WMLGoElement.
Create a new helper class 'FormDataBuilder', which is hold as member variable in those classes.
It encapsulates all functionality needed to generate a FormData object, usable for HTML/WML form
submission, including boundary string generation, multi-part form handling etc.
No functional changes, no test cases affected.
WMLGoElement will be converted in a follow-up patch.
- 5:42 PM Changeset in webkit [39429] by
-
- 4 edits in trunk/JavaScriptCore
Rubber-stamped by George Staikos.
Fix copyright of the new RandomNumber* files.
- 5:00 PM Changeset in webkit [39428] by
-
- 9 edits in trunk/JavaScriptCore
2008-12-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt & Cameron Zwarich.
Add support for call and property access repatching on x86-64.
No change in performance on current configurations (2x impovement on v8-tests with JIT enabled on x86-64).
- assembler/MacroAssembler.h: (JSC::MacroAssembler::DataLabelPtr::repatch): (JSC::MacroAssembler::DataLabelPtr::operator X86Assembler::JmpDst): (JSC::MacroAssembler::DataLabel32::repatch): (JSC::MacroAssembler::RepatchBuffer::addressOf): (JSC::MacroAssembler::add32): (JSC::MacroAssembler::sub32): (JSC::MacroAssembler::loadPtrWithAddressOffsetRepatch): (JSC::MacroAssembler::storePtrWithAddressOffsetRepatch): (JSC::MacroAssembler::jePtr): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jnePtrWithRepatch): (JSC::MacroAssembler::differenceBetween):
- assembler/X86Assembler.h: (JSC::X86Assembler::addl_im): (JSC::X86Assembler::subl_im): (JSC::X86Assembler::cmpl_rm): (JSC::X86Assembler::movq_rm_disp32): (JSC::X86Assembler::movq_mr_disp32): (JSC::X86Assembler::repatchPointer): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp32):
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::linkCall): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReferenceForTrampoline):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compilePutByIdSlowCase): (JSC::resizePropertyStorage): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- wtf/Platform.h:
- 3:44 PM Changeset in webkit [39427] by
-
- 14 edits1 add in trunk/WebCore
2008-12-21 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler, Nikolas Zimmermann.
Move the the platform dependent strokeBBox functionality out of RenderPath
into Path with strokeBoundingRect.
RenderPath clean-up for strokeBoundingBox
https://bugs.webkit.org/show_bug.cgi?id=22902
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsContext.h:
- platform/graphics/Path.h:
- platform/graphics/StrokeStyleApplier.h: Added. (WebCore::StrokeStyleApplier::~StrokeStyleApplier):
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::strokeBoundingRect):
- platform/graphics/cg/PathCG.cpp: (WebCore::createScratchContext): (WebCore::scratchContext): (WebCore::Path::strokeBoundingRect):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::pen):
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeBoundingRect):
- rendering/RenderPath.cpp: (WebCore::StrokeBoundingRectStyleApplier::StrokeBoundingRectStyleApplier): (WebCore::StrokeBoundingRectStyleApplier::strokeStyle): (WebCore::RenderPath::relativeBBox):
- rendering/RenderPath.h:
- svg/graphics/cairo/RenderPathCairo.cpp:
- svg/graphics/cg/RenderPathCg.cpp:
- svg/graphics/qt/RenderPathQt.cpp:
- 6:49 AM Changeset in webkit [39426] by
-
- 4 edits in trunk/WebKit/gtk
2008-12-21 Xan Lopez <xan@gnome.org>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=16092
[GTK] Middle-mouse click should allow opening a URL in a new tab
Add mouse button and keyboard state modifiers info to navigation action.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- webkit/webkitwebnavigationaction.cpp: (_WebKitWebNavigationActionPrivate::): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_button): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_modifier_state):
- webkit/webkitwebnavigationaction.h:
Dec 20, 2008:
- 2:41 PM Changeset in webkit [39425] by
-
- 4 edits1 add in trunk/WebKit/win
Reviewed by Ada Chan.
- expose the new allItems() method via a new IWebHistoryPrivate interface
- Interfaces/IWebHistoryPrivate.idl: Added.
- Interfaces/WebKit.idl: Added IWebHistoryPrivate.idl.
- WebHistory.cpp: (WebHistory::QueryInterface): Added IWebHistoryPrivate. (WebHistory::allItems):
- WebHistory.h:
- 12:52 PM Changeset in webkit [39424] by
-
- 3 edits in trunk/WebCore
Fix typo "CSSAferRuleValue" to "CSSAfterRuleValue"
- html/PreloadScanner.cpp: (WebCore::PreloadScanner::tokenizeCSS):
- html/PreloadScanner.h: (WebCore::PreloadScanner::CSSState):
- 2:26 AM Changeset in webkit [39423] by
-
- 3 edits in trunk/WebCore
Reviewed by Geoff Garen.
<rdar://problem/6454076> Random crashes on JS raytracer
No test, because the crash is not readily reproducible.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::empty):
- platform/text/StringImpl.h: Made empty string per-thread.
- 2:11 AM Changeset in webkit [39422] by
-
- 8 edits in trunk/JavaScriptCore
2008-12-20 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Port optimized property access generation to the MacroAssembler.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::AbsoluteAddress::AbsoluteAddress): (JSC::MacroAssembler::DataLabelPtr::repatch): (JSC::MacroAssembler::DataLabel32::DataLabel32): (JSC::MacroAssembler::DataLabel32::repatch): (JSC::MacroAssembler::Label::operator X86Assembler::JmpDst): (JSC::MacroAssembler::Jump::repatch): (JSC::MacroAssembler::JumpList::empty): (JSC::MacroAssembler::RepatchBuffer::link): (JSC::MacroAssembler::add32): (JSC::MacroAssembler::and32): (JSC::MacroAssembler::sub32): (JSC::MacroAssembler::loadPtrWithAddressRepatch): (JSC::MacroAssembler::storePtrWithAddressRepatch): (JSC::MacroAssembler::push): (JSC::MacroAssembler::ja32): (JSC::MacroAssembler::jePtr): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jnePtrWithRepatch): (JSC::MacroAssembler::align): (JSC::MacroAssembler::differenceBetween):
- assembler/X86Assembler.h: (JSC::X86Assembler::movl_rm_disp32): (JSC::X86Assembler::movl_mr_disp32): (JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp32): (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
- jit/JIT.cpp: (JSC::ctiRepatchCallByReturnAddress): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compilePutByIdSlowCase): (JSC::resizePropertyStorage): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- wtf/RefCounted.h: (WTF::RefCountedBase::addressOfCount):
Dec 19, 2008:
- 7:18 PM Changeset in webkit [39421] by
-
- 11 edits4 adds in trunk
2008-12-19 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=16562
[gtk] Implement WebPolicyDelegate methods
Original work by Pierre-Luc Beaudoin. Final touches by Gustavo
Noronha.
This implements the delegates methods of WebPolicyDelegate.
Since Gtk+/C doesn't have delegate methods, they are replaced with
signals.
A new object WebKitWebPolicyDecision allows the browser to delay its
response in certain cases. WebKitWebNavigationAction contains the
information about what caused a navigation request.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::FrameLoaderClient::~FrameLoaderClient): (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClient::cancelPolicyCheck): (WebKit::FrameLoaderClient::canShowMIMEType):
- WebCoreSupport/FrameLoaderClientGtk.h:
- webkit/webkit.h:
- webkit/webkitdefines.h:
- webkit/webkitprivate.cpp: (WebKit::kit): (WebKit::core):
- webkit/webkitprivate.h:
- webkit/webkitwebnavigationaction.cpp: Added. (_WebKitWebNavigationActionPrivate::): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_init): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_finalize): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_reason): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_reason): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_original_uri): (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_original_uri):
- webkit/webkitwebnavigationaction.h: Added.
- webkit/webkitwebpolicydecision.cpp: Added. (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_class_init): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_init): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_new): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_use): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_ignore): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download): (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_cancel):
- webkit/webkitwebpolicydecision.h: Added.
- 6:35 PM Changeset in webkit [39420] by
-
- 2 edits in trunk/LayoutTests
2008-12-19 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
Enable more tests for testing on Gtk+ port.
- platform/gtk/Skipped:
- 6:04 PM Changeset in webkit [39419] by
-
- 7 edits in trunk/WebCore
2008-12-19 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Replace some uses of HardRetain etc with RetainPtr.
- platform/mac/DragImageMac.mm:
- platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createCFData):
- rendering/RenderThemeMac.mm:
- svg/graphics/cg/SVGResourceFilterCg.mm: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
- svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
- svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm: (WebCore::SVGResourceFilterPlatformDataMac::SVGResourceFilterPlatformDataMac):
- 5:39 PM Changeset in webkit [39418] by
-
- 2 edits in trunk/WebKit/win
2008-12-19 Geoffrey Garen <ggaren@apple.com>
Build fix.
- WebHistory.cpp: (WebHistory::allItems):
- 4:31 PM Changeset in webkit [39417] by
-
- 6 edits in trunk/WebKit
WebKit/mac:
2008-12-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler, Adele Peterson, Brady Eidson.
Added SPI for getting an unsorted vector of all items in history.
- History/WebHistory.h:
- History/WebHistory.mm: (-[WebHistory allItems]):
WebKit/win:
2008-12-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler, Adele Peterson, Brady Eidson.
Added SPI for getting an unsorted vector of all items in history.
- WebHistory.cpp: (WebHistory::orderedItemsLastVisitedOnDay): (WebHistory::allItems):
- WebHistory.h:
- 4:28 PM Changeset in webkit [39416] by
-
- 10 edits2 adds in trunk
Reviewed by Kevin Ollivier.
Add Context Menu support to wx bindings.
https://bugs.webkit.org/show_bug.cgi?id=22675
- 4:03 PM Changeset in webkit [39415] by
-
- 2 edits in trunk/WebKitTools
2008-12-19 David Levin <levin@chromium.org>
Reviewed by Mark Rowe.
Make the git diff command used for preparing the change log avoid using any external diff tools.
- Scripts/prepare-ChangeLog:
- 2:54 PM Changeset in webkit [39414] by
-
- 2 edits in trunk/WebCore
2008-12-19 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler.
Temporary band-aide fix for <rdar://problem/6372481> In Gmail, a
crash occurs at
AccessibilityTable::isTableExposableThroughAccessibility() when
attempting to create a link in a rich text message
We need to disable Accessibility Tables until we get this fixed for
real to prevent rampant crashing.
- page/AccessibilityTable.cpp: (WebCore::AccessibilityTable::AccessibilityTable):
- 2:44 PM Changeset in webkit [39413] by
-
- 3 edits4 adds in trunk
2008-12-19 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
When the document element is transformed, we need to paint
the view background to avoid unpainted areas.
Test: fast/transforms/transformed-document-element.html
- rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
- 1:37 PM Changeset in webkit [39412] by
-
- 2 edits in trunk/WebKitSite
2008-12-19 Dean Jackson <dino@apple.com>
Media queries that return <integer> but are really boolean
are restricted to 0 and 1. This is in line with other
media features.
- specs/MediaQueriesExtensions.html:
- 1:19 PM Changeset in webkit [39411] by
-
- 2 edits in trunk/WebCore
Fix build.
- WebCore.vcproj/WebCore.vcproj:
- 11:10 AM Changeset in webkit [39410] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-19 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22612
Add test to verify type enforcement in DOM setters.
Resubmitting corrected copies; first submission had patching errors.
- fast/dom/setter-type-enforcement-expected.txt: Added.
- fast/dom/setter-type-enforcement.html: Added.
- 10:52 AM Changeset in webkit [39409] by
-
- 6 edits in trunk
wx build fixes after recent changes.
- 10:34 AM Changeset in webkit [39408] by
-
- 2 edits in trunk/WebCore
[GTK] Fix make distcheck again
These files were moved to WebCore/platform/animation
and WebCore/platform/graphics/transforms.
- 8:54 AM Changeset in webkit [39407] by
-
- 2 edits in trunk
2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Use ustar tar format for WebKit/GTK+'s make dist target, so that
storing files whose filenames are > 99 is possible.
- configure.ac:
- 8:53 AM Changeset in webkit [39406] by
-
- 2 edits in trunk/WebCore
2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Fix AtomicString usage, so that building works.
- platform/network/soup/ResourceHandleSoup.cpp:
- 8:47 AM Changeset in webkit [39405] by
-
- 4 edits in trunk
JavaScriptCore:
2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Added file which was missing to the javascriptcore_sources
variable, so that it shows up in the tarball created by `make
dist'.
- GNUmakefile.am:
WebKitTools
2008-12-19 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Added files which were missing from the TestNetscapePlugin
directory to the SOURCES variable, so that they will be
distributed in a make dist.
- GNUMakefile.am:
- 8:35 AM Changeset in webkit [39404] by
-
- 2 edits in trunk
[GTK] Build fix by defining WTF_USE_JIT_STUB_ARGUMENT_VA_LIST
Fix the jit compilation on i*686 on Linux by using the va_list
to pass arguments to the CTI. This is done on the MAC as well
and sunspider and javascriptcore seem to work with that.
- 7:32 AM Changeset in webkit [39403] by
-
- 2 edits in trunk/WebCore
Windows build fix on older versions of CFNetwork after r39393
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::highestSupportedCFURLConnectionClientVersion): Changed preprocessor directives not to leave in unreachable code on old versions of CFNetwork.
- 4:45 AM Changeset in webkit [39402] by
-
- 2 edits in trunk/WebCore
2008-12-19 Antti Koivisto <Antti Koivisto>
Comment fix.
- platform/PurgeableBuffer.h:
- 3:27 AM Changeset in webkit [39401] by
-
- 2 edits in trunk/JavaScriptCore
Build fix when building JS API tests with a c89 c compiler
Do not use C++ style comments and convert them to C comments.
- 3:26 AM Changeset in webkit [39400] by
-
- 2 edits in trunk/WebCore
[GTK] Build fix by adding the new files
- 2:41 AM Changeset in webkit [39399] by
-
- 4 edits in trunk
2008-12-19 Jade Han <jade.han@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Allow conversion of JavaScript Number and Boolean types to Qt types
- 2:05 AM Changeset in webkit [39398] by
-
- 4 edits in trunk/WebCore
2008-12-19 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Holger Freyther.
Implement ImageDecoder::filenameExtension() for Qt
- 1:14 AM Changeset in webkit [39397] by
-
- 1 edit in trunk/WebCore/WebCore.pro
Fix the Qt build after r39378
- 1:03 AM Changeset in webkit [39396] by
-
- 9 edits in trunk/WebCore
2008-12-18 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Implement ImageSource::filenameExtension for Cario
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::filenameExtension):
- platform/image-decoders/ImageDecoder.h:
- platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::filenameExtension):
- platform/image-decoders/gif/GIFImageDecoder.h: (WebCore::GIFImageDecoder::filenameExtension):
- platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::filenameExtension):
- platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::filenameExtension):
- platform/image-decoders/png/PNGImageDecoder.h: (WebCore::PNGImageDecoder::filenameExtension):
- platform/image-decoders/xbm/XBMImageDecoder.h: (WebCore::XBMImageDecoder::filenameExtension):
- 12:52 AM Changeset in webkit [39395] by
-
- 1 edit in trunk/JavaScriptCore/wtf/Platform.h
Fix build break in Platform.h
- 12:19 AM Changeset in webkit [39394] by
-
- 2 edits in trunk/WebKit/qt
2008-12-18 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Tor Arne Vestbø.
When Web Inspector is launched without an associated node,
call show() instead of inspect().
