Context Navigation

platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): Changed glyph stroking to fill and stroke each glyph as a separate path, instead of all glyphs as a single path. This matches what CGContextShowGlyphsWithAdvances() does, and has comparable performance.

6:47 PM Changeset in webkit [41888] by dino@apple.com

2 edits in trunk/WebCore

2009-03-20 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser

Build fix for ENABLE(3D_RENDERING)

rendering/RenderObject.h: (WebCore::makeMatrixRenderable):

6:29 PM Changeset in webkit [41887] by jmalonzo@webkit.org

4 edits in trunk

2009-03-20 Mike Hommey <glandium@debian.org>

Reviewed by Gavin Barraclough. Landed by Jan Alonzo.

Enable JIT on x86-64
https://bugs.webkit.org/show_bug.cgi?id=24724

Enable JIT on x86-64 gtk+

configure.ac:
JavaScriptCore/GNUmakefile.am:

6:18 PM Changeset in webkit [41886] by jmalonzo@webkit.org

2 edits in trunk/JavaScriptCore

2009-03-20 Mike Hommey <glandium@debian.org>

Reviewed by Mark Rowe. Committed by Jan Alonzo.

Use the proper definition of RETURN_PAIR on !MSVC

The other version is actually a work around for a quirk in the windows
ABI, so checking whether we're under MSVC is more a appropriate check for
it. It also happens this workaround is not 64-bits safe, so we also error
out on x86-64 MSVC.

Thanks Gavin Barraclough.

jit/JITStubs.h:

5:57 PM Changeset in webkit [41885] by adele@apple.com

2 edits in trunk/WebKit/mac

2009-03-20 Adele Peterson <adele@apple.com>

Build fix.

Reviewed by Darin Adler.

WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]):

5:15 PM Changeset in webkit [41884] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2009-03-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed a JavaScriptCore crash on the Windows buildbot.

bytecompiler/BytecodeGenerator.h: Reduced the AST recursion limit. Apparently, Windows has small stacks.

4:46 PM Changeset in webkit [41883] by levin@chromium.org

2 edits
1 add in trunk/LayoutTests

2009-03-20 Tony Chang <tony@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24679

Change the layout test from using a data: URL to using a file:///
URL for the iframe. If DRT's frame loader has
AllowLocalLoadsForLocalOnly, then it's not possible to load an image
from disk into the iframe. Since this test is about D&D, not
local load checks, switch to a local file that doesn't have this
problem.

This should fix the test on win DRT as well.

fast/events/resources/standalone-image-drag-to-editable-frame.html: Added.
fast/events/standalone-image-drag-to-editable.html:

4:46 PM Changeset in webkit [41882] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-20 Dave Moore <davemoore@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24705

A bug in the V8 bindings is preventing chromium from setting the href on the
location object...any attempt throws a security error, not just for javascript
protocol

page/Location.idl:

4:46 PM Changeset in webkit [41881] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-20 Craig Schlenter <craig.schlenter@gmail.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24608

Include stdio.h needed for printf on gcc 4.4.0

platform/KURLGoogle.cpp:

4:46 PM Changeset in webkit [41880] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-20 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24577

Don't let comments at the end of an event handler
break the event handler.

No change in behavior, so no test.

bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getWrappedListenerFunction):

4:45 PM Changeset in webkit [41879] by levin@chromium.org

18 edits in trunk

JavaScriptCore:

2009-03-20 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24535

Fixes missing line terminator character (;) after macro call.
It is common practice to add the trailing ";" where macros are substituted
and not where they are defined with #define.
This change is consistent with other macro declarations across webkit,
and it also solves compilation failure with symbian compilers.

runtime/UString.cpp:
wtf/Assertions.h:

WebCore:

2009-03-20 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24535

Fixes missing line terminator character (;) after macro call.
It is common practice to add the trailing ";" where macros are substituted
and not where they are defined with #define.
This change is consistent with other macro declarations across webkit,
and it also solves compilation failure with symbian compilers.

No change in behavior, so no test.

bindings/js/JSDOMWindowShell.cpp:
bindings/js/JSEventListener.cpp:
bindings/js/JSImageConstructor.cpp:
bindings/js/JSInspectedObjectWrapper.cpp:
bindings/js/JSInspectorCallbackWrapper.cpp:
bindings/js/JSNamedNodesCollection.cpp:
bindings/js/JSNodeFilterCondition.cpp:
bindings/js/JSOptionConstructor.cpp:
bindings/js/JSQuarantinedObjectWrapper.cpp:
bindings/js/JSRGBColor.cpp:
bindings/js/JSWorkerContextBase.cpp:
bindings/js/JSXMLHttpRequestConstructor.cpp:
bindings/js/JSXSLTProcessorConstructor.cpp:
bindings/scripts/CodeGeneratorJS.pm:

4:45 PM Changeset in webkit [41878] by levin@chromium.org

3 edits in trunk/WebCore

2009-03-20 Mike Belshe <mike@belshe.com>

Reviewed by Dimitri Glazkov and Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24324

Make the minimum timer configurable for different platforms.

page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::fired):
page/DOMTimer.h: (WebCore::DOMTimer::minTimerInterval): (WebCore::DOMTimer::setMinTimerInterval):

4:45 PM Changeset in webkit [41877] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-20 Dean McNamee <deanm@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22834

Make sure to consistently match new/delete and fastMalloc/fastFree.

css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::adoptSelectorVector): (WebCore::CSSSelectorList::deleteSelectors):

4:41 PM Changeset in webkit [41876] by mitz@apple.com

7 edits
4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix https://bugs.webkit.org/show_bug.cgi?id=23739 <rdar://problem/6556371> REGRESSION (r36513): iframe isn't sized properly upon load

rendering/RenderBlock.cpp: (WebCore::RenderBlock::percentHeightDescendants): Added this accessor.
rendering/RenderBlock.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): Extended the check for children that flex to include other descendants with percent height which is relative to the cell.

LayoutTests:

Reviewed by Dave Hyatt.

test, updated test and results for https://bugs.webkit.org/show_bug.cgi?id=23739 <rdar://problem/6556371> REGRESSION (r36513): iframe isn't sized properly upon load

fast/replaced/percent-height-in-anonymous-block-in-table.html: Added.
fast/replaced/table-percent-height-expected.txt:
fast/replaced/table-percent-height.html:
platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.checksum: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt: Added.

4:29 PM Changeset in webkit [41875] by dimich@chromium.org

1 edit
1 add in trunk/LayoutTests

2009-03-20 Dmitry Titov <dimich@chromium.org>

Fix broken LayoutTest/http/tests/workers/text-encoding.html.
Forgot to add a new file with the previous patch.

http/tests/workers/resources/subworker-encoded.php: Added.

4:24 PM Changeset in webkit [41874] by darin@chromium.org

2 edits
1 add
1 delete in trunk/LayoutTests

2009-03-20 Alpha Lam <hclam@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24721

The test in this change is just to verify a no crash. Full tree
dump is not necessary, so change to test to dumpAsText and update
the affected test results.

fast/block/float/crash-on-absolute-positioning-expected.txt: Added.
fast/block/float/crash-on-absolute-positioning.html:
platform/mac/fast/block/float/crash-on-absolute-positioning-expected.txt: Removed.

4:03 PM Changeset in webkit [41873] by jmalonzo@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>

Not reviewed. Fix style issues with my previous commit (r41866) as
suggested by Holger in https://bugs.webkit.org/show_bug.cgi?id=24493

tests/testwebhistoryitem.c: (test_webkit_web_history_item_get_data): (test_webkit_web_history_item_alternate_title):

3:56 PM Changeset in webkit [41872] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2009-03-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

A little cleanup in the RegisterFile code.

Moved large inline functions out of the class declaration, to make it
more readable.

Switched over to using the roundUpAllocationSize function to avoid
duplicate code and subtle bugs.

Renamed m_maxCommitted to m_commitEnd, to match m_end.

Renamed allocationSize to commitSize because it's the chunk size for
committing memory, not allocating memory.

SunSpider reports no change.

interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::shrink): (JSC::RegisterFile::grow):
jit/ExecutableAllocator.h: (JSC::roundUpAllocationSize):

3:52 PM Changeset in webkit [41871] by dimich@chromium.org

16 edits in trunk

WebCore:

2009-03-20 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24706
Remove ScriptExecutionContext::encoding() since Workers do not need it.
WorkerContext::encoding() is simply removed, while Document::encoding()
made non-virtual and private. Workers use UTF-8 now except when instructed
otherwise by http header. Also updated test.

dom/Document.h: Made encoding() non-virtual and private.
dom/ScriptExecutionContext.h: removed encoding().

workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
workers/WorkerContext.cpp: removed encoding() implementation. (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::completeURL):
workers/WorkerContext.h: removed encoding() (WebCore::WorkerContext::create):
workers/WorkerContextProxy.h:
workers/WorkerImportScriptsClient.cpp: (WebCore::WorkerImportScriptsClient::didReceiveData):
workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerContext):
workers/WorkerMessagingProxy.h:
workers/WorkerThread.cpp: (WebCore::WorkerThreadStartupData::create): (WebCore::WorkerThreadStartupData::WorkerThreadStartupData): (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
workers/WorkerThread.h: In all these, removed storing encoding and 'inheriting' it from the parent. Instead, they are all using UTF-8 now.

LayoutTests:

2009-03-20 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24706
Remove ScriptExecutionContext::encoding() since Workers do not need it.
WorkerContext::encoding() is simply removed, while Document::encoding()
made non-virtual and private. Workers use UTF-8 now except when instructed
otherwise by http header. Updated test.
Also, added test for encoding used by importScripts().

http/tests/workers/resources/subworker-encoded.php: Added.
http/tests/workers/resources/worker-encoded.php:
http/tests/workers/text-encoding-expected.txt:
http/tests/workers/text-encoding.html:

3:40 PM Changeset in webkit [41870] by timothy@apple.com

15 edits in trunk

Change how threading exceptions are checked so they are reported by what round they were added.

WebCore:

2009-03-20 Timothy Hatcher <timothy@apple.com>

Change how threading exceptions are checked so they are reported
by what round they were added. That way WebKit can decided the
behavior per-round based on linked-on-or-after checks.

<rdar://problem/6626741&6648478&6635474&6674079>

Reviewed by Darin Adler.

WebCore.base.exp: Export the new symbols.
bindings/objc/DOMAbstractView.mm: Use the new WebCoreThreadViolationCheckRoundOne macro.
bindings/scripts/CodeGeneratorObjC.pm: Ditto.
platform/ThreadCheck.h:
platform/mac/ThreadCheck.mm: (WebCore::readThreadViolationBehaviorFromUserDefaults): Refactor how the default is read. (WebCore::setDefaultThreadViolationBehavior): Take a round argument. (WebCore::reportThreadViolation): Ditto. (WebCoreReportThreadViolation): Ditto.

WebKit:

2009-03-20 Timothy Hatcher <timothy@apple.com>

Change how threading exceptions are checked so they are reported
by what round they were added. That way WebKit can decided the
behavior per-round based on linked-on-or-after checks.

<rdar://problem/6626741&6648478&6635474&6674079>

Reviewed by Darin Adler.

History/WebBackForwardList.mm: Use the new WebCoreThreadViolationCheckRoundOne macro.
History/WebHistoryItem.mm: Ditto.
Misc/WebIconDatabase.mm: Ditto.

WebView/WebArchive.mm: Use the new WebCoreThreadViolationCheckRoundTwo macro.
WebView/WebResource.mm: Ditto. (+[WebResource _needMailThreadWorkaroundIfCalledOffMainThread]): Check Mail's bundle version to truly decide if it is an old Mail client.
WebView/WebView.mm: Ditto.

Misc/WebKitVersionChecks.h: Add a new linked-on-or-after version define.
WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): Set the default thread violation behavior per-round based on difference version checks and the Mail workaround check.

3:25 PM Changeset in webkit [41869] by andersca@apple.com

2 edits in trunk/WebKitTools

2009-03-20 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Only release the result NPVariant if the call to NPN_Invoke was successful.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testNPRuntime):

1:31 PM Changeset in webkit [41868] by ggaren@apple.com

2 edits in trunk/WebCore

2009-03-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed up an out-of-date comment.

bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customPut):

1:25 PM Changeset in webkit [41867] by Darin Adler

2 edits in trunk/WebKit/mac

2009-03-20 Darin Adler <Darin Adler>

Reviewed by Timothy Hatcher.

WebView/WebTextIterator.h: Improved comments to point out some of the pitfalls of this SPI.

1:23 PM Changeset in webkit [41866] by jmalonzo@webkit.org

3 edits
1 add in trunk

2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>

Reviewed by Holger Freyther.

[GTK] Misc patches for WebKitWebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=24493

Added build support for build the WebKitWebHistoryItem unit test.

GNUmakefile.am:

2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>

Reviewed by Holger Freyther.

[GTK] Misc patches for WebKitWebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=24493

Add unit test for WebKitWebHistoryItem

tests/testwebhistoryitem.c: Added. (web_history_item_fixture_setup): (web_history_item_fixture_teardown): (test_webkit_web_history_item_get_data): (test_webkit_web_history_item_alternate_title): (main):

12:56 PM Changeset in webkit [41865] by Beth Dakin

4 edits
4 adds in trunk

WebCore:

2009-03-20 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=20909 REGRESSION
(r35318): A press release at pfizer.com does not display correctly

and corresponding - <rdar://problem/6680073>

rendering/RenderObject.cpp: (WebCore::RenderObject::invalidateContainerPrefWidths):
rendering/RenderObject.h: (WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

2009-03-20 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Test for https://bugs.webkit.org/show_bug.cgi?id=20909 REGRESSION
(r35318): A press release at pfizer.com does not display correctly

and corresponding - <rdar://problem/6680073>

http/tests/misc/generated-content-inside-table.html: Added.
platform/mac/http/tests/misc/generated-content-inside-table-expected.checksum: Added.
platform/mac/http/tests/misc/generated-content-inside-table-expected.png: Added.
platform/mac/http/tests/misc/generated-content-inside-table-expected.txt: Added.

12:45 PM Changeset in webkit [41864] by jmalonzo@webkit.org

3 edits
1 copy
1 move in trunk

2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>

Reviewed by Holger Freyther.

Separate gtk unit tests
https://bugs.webkit.org/show_bug.cgi?id=24039

Build the unit tests accordingly.

GNUmakefile.am:

2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>

Reviewed by Holger Freyther.

Separate gtk unit tests
https://bugs.webkit.org/show_bug.cgi?id=24039

Split the current single-file unit test to make it more
modularized and manageable in the future as more unit tests are
written.

tests/main.c: Removed.
tests/testwebbackforwardlist.c: Copied from WebKit/gtk/tests/main.c. (main):
tests/testwebframe.c: Copied from WebKit/gtk/tests/main.c. (main):

11:45 AM Changeset in webkit [41863] by eric@webkit.org

19 edits in trunk/WebCore

Reviewed by Justin Garcia.

maxDeepOffset is confusing and should be removed
https://bugs.webkit.org/show_bug.cgi?id=24586

Abstract some hard-to-read (but shared) logic into a new renderedAsNonInlineTableOrHR function.
Add first/lastDeepEditingPositionForNode Position creation functions
and deploy them to places we used to call maxDeepOffset.

Rename Position::atStart and atEnd to atStartOfTree atEndOfTree
Add a new Position::atFirst/atLastEditingPositionForNode() and use these
to replace a few more callers for maxDeepOffset()

Rename maxDeepOffset to lastEditingOffsetForNode (so that we mere mortals have some clue what it does)

"Editing positions" are confusing because they have one
of two behaviors, depending on if the container node is ignored
by editing (if editingIgnoresContent(node) returns true) or not.
Positions referring to nodes ignored by editing are
neighbor-relative (they are before or after the node) where as
positions reffering to other nodes are container-relative
(they are between two child nodes of the container, identified
by the offset() member). I will be fixing this confusion in
future patches. These renames hopefully make the current behavior clearer.

dom/Position.cpp: (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::atFirstEditingPositionForNode): (WebCore::Position::atLastEditingPositionForNode): (WebCore::Position::atStartOfTree): (WebCore::Position::atEndOfTree): (WebCore::Position::previousCharacterPosition): (WebCore::Position::nextCharacterPosition): (WebCore::Position::upstream): (WebCore::Position::isCandidate): (WebCore::firstDeepEditingPositionForNode): (WebCore::lastDeepEditingPositionForNode):
dom/Position.h:
dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): (WebCore::PositionIterator::increment): (WebCore::PositionIterator::decrement): (WebCore::PositionIterator::atEnd): (WebCore::PositionIterator::atEndOfNode):
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
editing/DeleteSelectionCommand.cpp: (WebCore::isTableCellEmpty): (WebCore::DeleteSelectionCommand::removeNode): (WebCore::DeleteSelectionCommand::handleGeneralDelete):
editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling):
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
editing/TypingCommand.cpp: (WebCore::TypingCommand::forwardDeleteKeyPressed):
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::left): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::right):
editing/VisibleSelection.cpp: (WebCore::VisibleSelection::selectionFromContentsOfNode): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
editing/htmlediting.cpp: (WebCore::nextVisuallyDistinctCandidate): (WebCore::previousVisuallyDistinctCandidate): (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot): (WebCore::lastOffsetForEditing): (WebCore::isFirstPositionAfterTable): (WebCore::isLastPositionBeforeTable): (WebCore::positionBeforeNode): (WebCore::positionAfterNode): (WebCore::enclosingEmptyListItem): (WebCore::caretMaxOffset):
editing/htmlediting.h:
editing/visible_units.cpp: (WebCore::renderedAsNonInlineTableOrHR): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::startOfEditableContent): (WebCore::endOfEditableContent):
page/AccessibilityObject.cpp: (WebCore::endOfStyleRange):
page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRange):
rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):

10:32 AM Changeset in webkit [41862] by dimich@chromium.org

3 edits
2 copies
3 adds in trunk/WebCore

2009-03-20 Dmitry Titov <dimich@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24689
Add (upstream) V8 bindings for Workers. Mostly style cleaning.

bindings/v8/WorkerContextExecutionProxy.cpp: Added.
bindings/v8/WorkerContextExecutionProxy.h: Added.
bindings/v8/WorkerScriptController.cpp: Added.
bindings/v8/WorkerScriptController.h: Added.
bindings/v8/V8Index.h: Added. This is just a wrapper for v8_index.h, like V8Proxy.h
bindings/v8/V8Proxy.h: Added domObjectMap() function that wraps GetDOMObjectMap().
bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::callListenerFunction): TrackEvent() renamed trackEvent()

10:27 AM Changeset in webkit [41861] by ariya@webkit.org

3 edits in trunk/WebKit/qt

2009-03-20 Erik L. Bunce <elbunce@xendom.com>

Reviewed by Tor Arne Vestbø.

Fix QWebPage::WebActions action states to more closely match when they are
actually applicable and remove erroneous documentation.

Most WebActions implemented using editor commands now use the Editor::Command::isEnabled() to control their availability.
SelectAll is always enabled (since it's editor command is).
SetTextDirection{} family of WebActions are available when canEdit() is true and not just canEditRichly().

Fix and clarify documentation about the availability of various web actions.

Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateEditorActions):
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textSelection):

9:39 AM Changeset in webkit [41860] by eric@webkit.org

3 edits in trunk/WebCore

2009-03-20 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

Fix for LayoutTests/fast/canvas/canvas-text-alignment.html
on chromium/skia. The problem was that the gradient matrix
for text was being applied twice. Fixed by reverting some of
https://bugs.webkit.org/show_bug.cgi?id=23957, so that skiaDrawText
is no longer responsible for measuring the text and scaling up
the gradient matrix. Instead, the text bounding box is passed
in from SVGPaintServerGradient. I didn't make this change for CG,
since it uses a different method (the gradient is drawn using the
text as a pre-rendered mask).
https://bugs.webkit.org/show_bug.cgi?id=24687

platform/graphics/skia/SkiaFontWin.cpp: (WebCore::skiaDrawText):
svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):

7:50 AM Changeset in webkit [41859] by Darin Adler

2 edits in trunk/WebKit/mac

2009-03-20 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Use a better technique to handle finding out if something responds to a selector
in WebHTMLView's doCommandBySelector method.

WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]): Removed unneeded check for 0 coreFrame; this is already handled by coreCommandBySelector: so doesn't need to be checked twice. Got rid of initial value for eventWasHandled boolean to make it more clear. Use WebResponderChainSink to find out if a command is handled rather than walking the responder chain explicitly. (-[WebResponderChainSink initWithResponderChain:]): Added. (-[WebResponderChainSink detach]): Added. (-[WebResponderChainSink receivedUnhandledCommand]): Added. (-[WebResponderChainSink noResponderFor:]): Added. (-[WebResponderChainSink doCommandBySelector:]): Added.

4:09 AM Changeset in webkit [41858] by timothy@apple.com

1 edit in trunk/WebKit/mac/WebView/WebView.mm

Fix the Tiger build, round two.

3:54 AM Changeset in webkit [41857] by timothy@apple.com

1 edit in trunk/WebKit/mac/WebView/WebView.mm

Fix the Tiger build.

3:07 AM Changeset in webkit [41856] by xan@webkit.org

3 edits in trunk/WebCore

2009-03-20 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Holger Freyther.

There seems to be some rounding error in cairo (or in how we use
cairo) with some fonts, like DejaVu Sans Mono, which makes cairo
report a height smaller than ascent + descent, which is wrong and
confuses WebCore's layout system. Workaround this while we figure
out what's going on.

platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):

1:16 AM Changeset in webkit [41855] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24122
<rdar://problem/6674179>
REGRESSION: DOM Range extractContents/deleteContents failures seen on Moxiecode tests

Test: fast/dom/Range/deleted-range-endpoints.html

dom/Range.cpp: (WebCore::Range::processContents): Set the final range in accordance to the specification.

Mar 19, 2009:

10:57 PM Changeset in webkit [41854] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed <rdar://problem/6033712> -- a little bit of hardening in the Collector.

SunSpider reports no change. I also verified in the disassembly that
we end up with a single compare to constant.

runtime/Collector.cpp: (JSC::Heap::heapAllocate):

9:31 PM Changeset in webkit [41853] by timothy@apple.com

2 edits in trunk/WebKit/mac

Remove #ifndef BUILDING_ON_TIGER around code that schedules runloop modes
for Page, so the new RunLoopTimer in WebCore always gets a default mode.
Fixes the layout test failures on the Tiger build bots.

Reviewed by Mark Rowe.

WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView scheduleInRunLoop:forMode:]): (-[WebView unscheduleFromRunLoop:forMode:]):

9:28 PM Changeset in webkit [41852] by ggaren@apple.com

4 edits
1 move in trunk

JavaScriptCore:

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich and Oliver Hunt.

Fixed <rdar://problem/6406045> REGRESSION: Stack overflow on PowerPC on
fast/workers/use-machine-stack.html (22531)

Dialed down the re-entry allowance to 64 (from 128).

On a 512K stack, this leaves about 64K for other code on the stack while
JavaScript is running. Not perfect, but it solves our crash on PPC.

Different platforms may want to dial this down even more.

Also, substantially shrunk BytecodeGenerator. Since we allocate one on
the stack in order to throw a stack overflow exception -- well, let's
just say the old code had an appreciation for irony.

SunSpider reports no change.

bytecompiler/BytecodeGenerator.h:
interpreter/Interpreter.h: (JSC::):

LayoutTests:

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich and Oliver Hunt.

Re-enabled this test, since it no longer crashes when JavaScriptCore is
compiled in non-JIT mode.

fast/workers/use-machine-stack.html: Copied from fast/workers/use-machine-stack.html-disabled.
fast/workers/use-machine-stack.html-disabled: Removed.

7:04 PM Changeset in webkit [41851] by cwzwarich@webkit.org

3 edits
3 adds in trunk

2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 24350: REGRESSION: Safari 4 breaks SPAW wysiwyg editor multiple instances
<https://bugs.webkit.org/show_bug.cgi?id=24350>
<rdar://problem/6674182>

The SPAW editor's JavaScript assumes that toString() on a function
constructed with the Function constructor produces a function with
a newline after the opening brace.

JavaScriptCore:

runtime/FunctionConstructor.cpp: (JSC::constructFunction): Add a newline after the opening brace of the function's source code.

LayoutTests:

fast/js/function-constructor-newline-after-brace-expected.txt: Added.
fast/js/function-constructor-newline-after-brace.html: Added.
fast/js/resources/function-constructor-newline-after-brace.js: Added.

6:50 PM Changeset in webkit [41850] by mrowe@apple.com

1 edit
3 moves
6 adds in trunk/LayoutTests

Fix fast/text/Geeza-Pro-vertical-metrics-adjustment.html on Leopard by moving the results in to the location
that run-webkit-tests currently looks for them.

Reviewed by Stephanie Lewis.

5:52 PM Changeset in webkit [41849] by ggaren@apple.com

5 edits in trunk

JavaScriptCore:

2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 23771: REGRESSION (r36016): JSObjectHasProperty freezes on global class without kJSClassAttributeNoAutomaticPrototype
<https://bugs.webkit.org/show_bug.cgi?id=23771>
<rdar://problem/6561016>

API/tests/testapi.c: (main): Add a test for this bug.
runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resetPrototype): Don't set the prototype of the last object in the prototype chain to the object prototype when the object prototype is already the last object in the prototype chain.

LayoutTests:

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed <rdar://problem/6279213> Regular expression run-time complexity
limit too low for long inputs (21485)

Added a test for a complex regexp match that should succeed, and one
that should fail.

fast/js/regexp-overflow-expected.txt:
fast/js/resources/regexp-overflow.js:

5:44 PM Changeset in webkit [41848] by mrowe@apple.com

3 edits
1 copy
1 add in trunk/LayoutTests

Update test results for changes in handling of CMYK.

Reviewed by Sam Weinig.

fast/canvas/resources/set-colors.js:
fast/canvas/set-colors-expected.txt:
platform/mac-leopard/fast/canvas/set-colors-expected.txt: Copied from LayoutTests/fast/canvas/set-colors-expected.txt.

5:16 PM Changeset in webkit [41847] by andersca@apple.com

3 edits in trunk/WebCore

2009-03-19 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6682554> Flash content not being rendered (Shockwave Flash 10.0 r22)

If calling updateWidget for some reason resulted in another widget being added to m_widgetUpdateSet, then
that object would never be updated.

page/FrameView.cpp: (WebCore::FrameView::updateWidgets): Factor the widget updating code out into this method. Return true if the update set is empty.

(WebCore::FrameView::performPostLayoutTasks):
Loop over the update set multiple times until all widgets have been updated or until we reach the cap.

page/FrameView.h:

5:03 PM Changeset in webkit [41846] by cwzwarich@webkit.org

3 edits in trunk/JavaScriptCore

2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 23771: REGRESSION (r36016): JSObjectHasProperty freezes on global class without kJSClassAttributeNoAutomaticPrototype
<https://bugs.webkit.org/show_bug.cgi?id=23771>
<rdar://problem/6561016>

API/tests/testapi.c: (main): Add a test for this bug.
runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resetPrototype): Don't set the prototype of the last object in the prototype chain to the object prototype when the object prototype is already the last object in the prototype chain.

4:45 PM Changeset in webkit [41845] by timothy@apple.com

6 edits
2 adds in trunk

Make the defered data loading timer honor the Page's scheduled runloop pairs.
Introduces a new RunLoopTimer class that has an API mimicking Timer but
allows it to be scheduled with one or more SchedulePairs.

<rdar://problem/6687342> -[WebView scheduleInRunLoop:forMode:] has no affect on timers

Reviewed by Darin Adler.

WebCore.xcodeproj/project.pbxproj: Adds the new RunLoopTimer.{cpp,h} files.
loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::handleDataLoadNow): Use the MainResourceLoaderTimer typedef. (WebCore::MainResourceLoader::startDataLoadTimer): Added. Start the timer and on Mac platforms also schedule with the Page's SchedulePairs. (WebCore::MainResourceLoader::handleDataLoadSoon): Call startDataLoadTimer(). (WebCore::MainResourceLoader::setDefersLoading): Ditto.
loader/MainResourceLoader.h:
platform/cf/RunLoopTimerCF.cpp: Added. (WebCore::RunLoopTimerBase::~RunLoopTimerBase): (WebCore::timerFired): (WebCore::RunLoopTimerBase::start): (WebCore::RunLoopTimerBase::schedule): (WebCore::RunLoopTimerBase::stop): (WebCore::RunLoopTimerBase::isActive):
platform/RunLoopTimer.h: Added. (WebCore::RunLoopTimerBase::RunLoopTimerBase): (WebCore::RunLoopTimerBase::startRepeating): (WebCore::RunLoopTimerBase::startOneShot): (WebCore::RunLoopTimer::RunLoopTimer): (WebCore::RunLoopTimer::fired):

2:08 PM Changeset in webkit [41844] by kov@webkit.org

2 edits in trunk/WebKitTools

2009-03-19 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Mark Rowe.

Make determinePassedArchitecture always consume the --32-bit
option, also in non-AppleMacWebkit platforms. Solution pointed out
by Mark Rowe.

Scripts/webkitdirs.pm:

1:47 PM Changeset in webkit [41843] by hyatt@apple.com

1 add in trunk/WebKitSite/blog-files/scrollbarpicture.png

Adding scrollbar images for blog post.

1:32 PM Changeset in webkit [41842] by ggaren@apple.com

7 edits in trunk

JavaScriptCore:

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed <rdar://problem/6603562> REGRESSION (Safari 4): regular expression
pattern size limit lower than Safari 3.2, other browsers, breaks SAP (14873)

Bumped the pattern size limit to 1MB, and standardized it between PCRE
and WREC. (Empirical testing says that we can easily compile a 1MB regular
expression without risking a hang. Other browsers support bigger regular
expressions, but also hang.)

SunSpider reports no change.

I started with a patch posted to Bugzilla by Erik Corry (erikcorry@google.com).

pcre/pcre_internal.h: (put3ByteValue): (get3ByteValue): (put3ByteValueAndAdvance): (putLinkValueAllowZero): (getLinkValueAllowZero): Made PCRE's "LINK_SIZE" (the number of bytes used to record jumps between bytecodes) 3, to accomodate larger potential jumps. Bumped PCRE's "MAX_PATTERN_SIZE" to 1MB. (Technically, at this LINK_SIZE, we can support even larger patterns, but we risk a hang during compilation, and it's not clear that such large patterns are important on the web.)

wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp): Match PCRE's maximum pattern size, to avoid quirks between platforms.

LayoutTests:

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Made two layout tests less agressive, to accomodate a change I made
for <rdar://problem/6603562> REGRESSION (Safari 4): regular expression
pattern size limit lower than Safari 3.2, other browsers, breaks SAP (14873)

fast/js/regexp-charclass-crash-expected.txt:
fast/js/regexp-charclass-crash.html: Explicitly limit the number of iterations in the test loop. Otherwise, regular expression engines supporting very long patterns take a very very very long time to run this test.

fast/js/resources/regexp-overflow.js: Made the "too big" regexp in this test even bigger, to match our new limit.

12:56 PM Changeset in webkit [41841] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-03-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24702
Upstream miscellaneous bindings changes.

bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): Changed to call lower-case evaluate.
bindings/v8/ScriptCallStack.h: Added an extra include.

12:14 PM Changeset in webkit [41840] by Simon Fraser

3 edits
4 adds in trunk

2009-03-19 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24686

When hit testing a RenderLayer whose parent lives in a preserves-3D hierarchy,
we need to compare the computed z-offset with the depth-test z-offset before
deciding that such a RenderLayer was hit. This fixes an issue, tested by the
3d-point-mapping-overlapping.html test, where the child of a transformed element
is found by hit testing, even when some other element with greater Z overlaps
them both.

Improved the code by adding a utility method, isHitCandidate(), which computes and tests
z-depth when necessary.

Tests: transforms/3d/point-mapping/3d-point-mapping-coplanar.html

transforms/3d/point-mapping/3d-point-mapping-overlapping.html

rendering/RenderLayer.cpp: (WebCore::isHitCandidate): (WebCore::RenderLayer::hitTestLayer):

9:43 AM Changeset in webkit [41839] by Dimitri Glazkov

2 edits
1 add in trunk/WebCore

2009-03-19 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24456
Split ColorChromium.cpp into Mac & Windows variants.
Remove Chromium Dependency on platform/graphics/mac/ColorMac.mm since we
ultimately need to take a different approach. For now, createCGColor()
is copied from ColorMac.mm.

No observable change in behavior, so no test.

platform/graphics/chromium/ColorChromium.cpp: (WebCore::focusRingColor):
platform/graphics/chromium/ColorChromiumMac.mm: Added.

9:36 AM Changeset in webkit [41838] by Dimitri Glazkov

1 edit in trunk/WebCore/ChangeLog

Fix WebCore/ChangeLog entry, add missing reviewer line.

9:35 AM Changeset in webkit [41837] by Dimitri Glazkov

2 edits in trunk/LayoutTests

2009-03-19 Scott Violet <sky@google.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24678
Transitions tests somewhat flakey on Chromium.

Modifies transitions/transition-end-event-helpers.js to only process
results once.

transitions/transition-end-event-helpers.js:

9:29 AM Changeset in webkit [41836] by Dimitri Glazkov

1 edit
1 add in trunk/WebCore

2009-03-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24675
Unforking frontend: add custom InspectorController methods
implementation.

bindings/v8/custom/V8InspectorControllerCustom.cpp: Added.

9:26 AM Changeset in webkit [41835] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-03-19 Jay Campan <jcampan@google.com>

https://bugs.webkit.org/show_bug.cgi?id=24625
Adding an accessor to the currently selected index in the PopupMenuChromium.
This is required for implementing the deletion of an autocomplete entry in Chromium.

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::selectedIndex):
platform/chromium/PopupMenuChromium.h:

9:09 AM Changeset in webkit [41834] by darin@chromium.org

2 edits in trunk/WebCore

2009-03-19 Evan Stade <estade@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24526
Improve windows skia text stroking.

Test: LayoutTests/svg/custom/struct-use-09-b.svg

platform/graphics/skia/SkiaFontWin.cpp: Close the path representing each font glyph polygon, rather than only closing the path once per letter. This fixes stroking for letters with multiple polygons, such as 'A' or 'D'. (WebCore::getPathForGlyph): (WebCore::skiaDrawText):

9:06 AM Changeset in webkit [41833] by Simon Hausmann

3 edits in trunk/WebKit/qt

Oops, bail out last patch, that was incorrect.

8:59 AM Changeset in webkit [41832] by Simon Hausmann

3 edits in trunk/WebKit/qt

2009-03-19 Laurent Montel <montel@kde.org>

Reviewed by Simon Hausmann.

Another fix for pedantic compilation in QtWebKit

(patch from qt-copy)

8:16 AM Changeset in webkit [41831] by Simon Hausmann

3 edits in trunk/WebKit/qt

2009-03-19 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Fixes pedantic compilation in QtWebKit.

There are no semi-colons after namespace declarations.

8:16 AM Changeset in webkit [41830] by Simon Hausmann

2 edits in trunk/WebKit/qt

2009-03-19 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Removed obsolete warning about Flash and other plugins.

8:16 AM Changeset in webkit [41829] by Simon Hausmann

2 edits in trunk/WebKit/qt

2009-03-19 Paul Olav Tvete <paul.tvete@nokia.com>

Reviewed by Simon Hausmann.

Properly escape tooltip text

ManualTest: http://xkcd.com/554/

8:08 AM Changeset in webkit [41828] by Simon Hausmann

6 edits in trunk/WebCore

2009-03-19 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fixed support for doing calls from JavaScript into NPAPI Plugins for the Qt port on Windows.

Removed dead code for distinguishing between Widget and PluginView in the Qt port.

1:06 AM Changeset in webkit [41827] by mrowe@apple.com

3 edits in trunk/WebKitTools

Work around <rdar://problem/6698023> by activating fonts from disk.

Reviewed by Oliver Hunt.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Copy fonts into DumpRenderTree.resources

in the built products directory.

DumpRenderTree/mac/DumpRenderTree.mm:

(activateFonts): Activate the fonts from disk.

12:55 AM Changeset in webkit [41826] by cwzwarich@webkit.org

4 edits
3 adds in trunk

2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 24596: ASSERT in JSC::PropertySlot::slotBase @ iGoogle homepage
<https://bugs.webkit.org/show_bug.cgi?id=24596>
<rdar://problem/6686493>

JSDOMWindow::customGetOwnPropertySlot() does an access check after calling
JSGlobalObject::getOwnPropertySlot(). This causes the PropertySlot to be
set twice, once to the value that is illegal to access, and then to undefined
This causes an assertion failure in property access caching code.

The fix is to do the access check before calling JSGlobalObject::getOwnPropertySlot().

WebCore:

bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customGetOwnPropertySlot):

LayoutTests:

http/tests/security/cross-frame-access-get-custom-property-cached-expected.txt: Added.
http/tests/security/cross-frame-access-get-custom-property-cached.html: Added.
http/tests/security/resources/cross-frame-access-get-custom-property-cached-iframe.html: Added.
http/tests/security/resources/cross-frame-access.js: (shouldBeUndefined):

12:32 AM Changeset in webkit [41825] by ap@webkit.org

7 edits
3 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24676
Simple cross-origin requests shouldn't dispatch upload progress events

Test: http/tests/xmlhttprequest/simple-cross-origin-progress-events.html

loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck): Added a comment explaining the somewhat unexpected behavior of this function.

xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::hasListeners):
xml/XMLHttpRequestUpload.h: Report whether there are any event listeners registered.

xml/XMLHttpRequest.h: Added m_uploadEventsAllowed.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest): Set m_uploadEventsAllowed flag. (WebCore::XMLHttpRequest::makeSameOriginRequest): Ditto. (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest): Ditto. (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): Set request body - it can be non-empty for POST requests. (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight): Set m_uploadEventsAllowed flag. (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): Ditto. (WebCore::XMLHttpRequest::abort): Only dispatch upload progress events if allowed. (WebCore::XMLHttpRequest::networkError): Ditto. (WebCore::XMLHttpRequest::abortError): Ditto. (WebCore::XMLHttpRequest::didSendData): Ditto.

Mar 18, 2009:

11:18 PM Changeset in webkit [41824] by darin@chromium.org

2 edits in trunk/WebCore

2009-03-18 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24398
Fix a crash when loading a svg file in Chromium's test_shell and
then reloading the page.

history/BackForwardListChromium.cpp: (WebCore::BackForwardList::BackForwardList): (WebCore::BackForwardList::close):

11:04 PM BuildingGtk edited by arthur.webkid@gmail.com

WebKitGTK doesn't depend on curl anymore. (diff)

9:42 PM Changeset in webkit [41823] by adachan@apple.com

2 edits in trunk/JavaScriptCore

Rolling out r41818 since it broke the windows build.
Error: ..\..\runtime\DatePrototype.cpp(30) : fatal error C1083: Cannot open include file: 'langinfo.h': No such file or directory

runtime/DatePrototype.cpp: (JSC::formatLocaleDate):

6:54 PM Changeset in webkit [41822] by mrowe@apple.com

2 edits in trunk/LayoutTests

Skip plugins/netscape-throw-exception.html due to <rdar://problem/6530010>.

Reviewed by Sam Weinig.

platform/mac-snowleopard/Skipped:

6:29 PM Changeset in webkit [41821] by mrowe@apple.com

1 edit
1 move in trunk/LayoutTests

Disable pluginDocumentView-deallocated-dataSource.html as it has not tested
what it was designed to test for some time, and is failing on some machines.
Fixing the test is tracked by <https://bugs.webkit.org/show_bug.cgi?id=24690>.

Rubber-stamped by Dan Bernstein.

platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled: Renamed from LayoutTests/platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html.

5:57 PM Changeset in webkit [41820] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-18 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

WebKit side of <rdar://problem/6688244>.

Try reinitializing the vendor port if it's invalid.

Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):

5:49 PM Changeset in webkit [41819] by mrowe@apple.com

8 edits in trunk

<rdar://problem/6693300> Don't rely on printf from TestNetscapePlugIn appearing in test results

Reviewed by Dan Bernstein.

Switch from using printf to using the NPAPI to invoke console.log so that plug-in messages appear
in test results even when the plug-in's stdout differs from DumpRenderTree's stdout.

DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(log): Invoke console.log via the NPAPI.
(NPP_Destroy): Call log instead of printf.
(NPP_SetWindow): Ditto.
(handleEventCarbon): Ditto.
(handleEventCocoa): Ditto.
(NPP_HandleEvent): Pass the instance in to the event handler.

Update test results for change to address <rdar://problem/6693300>.

plugins/mouse-events-expected.txt:
plugins/netscape-destroy-plugin-script-objects-expected.txt:
plugins/netscape-plugin-setwindow-size-2-expected.txt:
plugins/netscape-plugin-setwindow-size-expected.txt:
plugins/open-and-close-window-with-plugin-expected.txt:

4:21 PM Changeset in webkit [41818] by kov@webkit.org

2 edits in trunk/JavaScriptCore

2009-03-18 Gustavo Noronha Silva <Gustavo Noronha Silva> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24674
Crashes in !PLATFORM(MAC)'s formatLocaleDate, in very specific situations

Make sure strftime never returns 2-digits years to avoid ambiguity and
a crash.

runtime/DatePrototype.cpp: (JSC::formatLocaleDate):

4:09 PM Changeset in webkit [41817] by sfalken@apple.com

4 edits in trunk/WebKit/win

Add webViewClosing to private UI delegate.

Reviewed by Adam Roben.

Interfaces/IWebUIDelegatePrivate.idl:
Interfaces/WebKit.idl:
WebView.cpp: (WebView::close):

1:41 PM Changeset in webkit [41816] by eric.carlson@apple.com

2 edits in trunk/WebCore

2009-03-18 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix for <rdar://problem/6685235>
<video> element poster cannot be set dynamically if not originally set up in HTML

Allocate the media engine immediately so the plug-in proxy is available for
scripting right away.

platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer):

1:33 PM Changeset in webkit [41815] by Beth Dakin

3 edits in trunk/LayoutTests

2009-03-18 Beth Dakin <Beth Dakin>

Rubber-stamped by Dan Bernstein.

Updating test to reflect our joy.

fast/dom/offset-parent-positioned-and-inline-expected.txt:
fast/dom/offset-parent-positioned-and-inline.html:

1:30 PM Changeset in webkit [41814] by Beth Dakin

3 edits
2 adds in trunk

WebCore:

2009-03-18 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Fix for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326):
Popup menu appears at the wrong location on page at http://
www.signonsandiego.com/

This was a regression from http://trac.webkit.org/changeset/40769,
which changed the base class of RenderInline to
RenderBoxModelObject rather than RenderBox.

rendering/RenderObject.cpp: (WebCore::RenderObject::offsetParent): offsetParent should return a RenderBoxModelObject rather than just a RenderBox, which is more restrictive.

LayoutTests:

2009-03-18 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Test for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326):
Popup menu appears at the wrong location on page at http://
www.signonsandiego.com/

fast/dom/offset-parent-positioned-and-inline-expected.txt: Added.
fast/dom/offset-parent-positioned-and-inline.html: Added.

1:15 PM Changeset in webkit [41813] by andersca@apple.com

4 edits in trunk

WebCore:

2009-03-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6504776>
CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore â¢ WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ...

Return early in case calling the client ends up spinning the run loop and completing/cancelling the load.

loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didCancel):

WebKit/mac:

2009-03-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6504776>
CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore â¢ WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ...

If the m_pluginView member was zeroed out as a result of making a call into the plug-in, the pluginFunctionCallDepth would be off
causing the plug-in never to be stopped. Simplify the code by using a RAII object.

Plugins/WebBaseNetscapePluginStream.mm: (PluginStopDeferrer::PluginStopDeferrer): (PluginStopDeferrer::~PluginStopDeferrer): (WebNetscapePluginStream::startStream): (WebNetscapePluginStream::wantsAllStreams): (WebNetscapePluginStream::destroyStream):

1:08 PM Changeset in webkit [41812] by levin@chromium.org

1 edit
1 add in trunk/WebCore

2009-03-18 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24664
Upstreaming v8 collection.h

No change in behavior, so no test.

bindings/v8/V8Collection.h: Added.

1:02 PM Changeset in webkit [41811] by weinig@apple.com

5 edits in trunk

WebCore:

2009-03-18 Sam Weinig <sam@webkit.org>

Reviewed by Simon Fraser.

Fix for https://bugs.webkit.org/show_bug.cgi?id=23966
REGRESSION: Custom arrow navigation functionality doesn't work at dropular.net
<rdar://problem/6589657>

Match the CSSOM spec for getClientRects and getBoundingClientRect by
returning a 0x0 rect at the correct top/left position for empty inline
boxes.

rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::absoluteQuads):

LayoutTests:

2009-03-18 Sam Weinig <sam@webkit.org>

Reviewed by Simon Fraser.

Update test results for https://bugs.webkit.org/show_bug.cgi?id=23966
REGRESSION: Custom arrow navigation functionality doesn't work at dropular.net
<rdar://problem/6589657>

fast/dom/getBoundingClientRect-expected.txt:
fast/dom/getClientRects-expected.txt:

11:02 AM Changeset in webkit [41810] by ap@webkit.org

1 edit
20 adds in trunk/LayoutTests

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24670
Add tests for XHR progress events during cross-origin requests.

http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt: Added.
http/tests/xmlhttprequest/redirect-cross-origin-2.html: Added.
http/tests/xmlhttprequest/redirect-cross-origin-expected.txt: Added.
http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt: Added.
http/tests/xmlhttprequest/redirect-cross-origin-post-sync-expected.txt: Added.
http/tests/xmlhttprequest/redirect-cross-origin-post-sync.html: Added.
http/tests/xmlhttprequest/redirect-cross-origin-post.html: Added.
http/tests/xmlhttprequest/redirect-cross-origin-sync-double-expected.txt: Added.
http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html: Added.
http/tests/xmlhttprequest/redirect-cross-origin-sync-expected.txt: Added.
http/tests/xmlhttprequest/redirect-cross-origin-sync.html: Added.
http/tests/xmlhttprequest/redirect-cross-origin.html: Added.
http/tests/xmlhttprequest/simple-cross-origin-denied-events-expected.txt: Added.
http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt: Added.
http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync-expected.txt: Added.
http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync.html: Added.
http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html: Added.
http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync-expected.txt: Added.
http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync.html: Added.
http/tests/xmlhttprequest/simple-cross-origin-denied-events.html: Added.

10:41 AM Changeset in webkit [41809] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-18 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

Match the changes done for windows in the bug
https://bugs.webkit.org/show_bug.cgi?id=24530.

No change in behavior, so no test.

rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):

8:58 AM Changeset in webkit [41808] by krit@webkit.org

2 edits in trunk/WebCore

2009-03-18 Dirk Schulze <krit@webkit.org>

Reviewed by Holger Freyther.

Added support for SVG's stroked texts to Qt.

[Qt] SVGs stroked text support missing
https://bugs.webkit.org/show_bug.cgi?id=24262

platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):

1:15 AM Changeset in webkit [41807] by mrowe@apple.com

2 edits in trunk/WebCore

Fix fast/encoding/char-decoding.html with recent ICU.

Reviewed by Alexey Proskuryakov.

platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::decode): Look for gb18030 case-insensitively,
as newer versions of ICU use GB18030 as the canonical name.

12:24 AM Changeset in webkit [41806] by oliver@apple.com

6 edits
1 add in trunk

<rdar://problem/6692138> REGRESSION (Safari 4): Incorrect function return value when using IE "try ... finally" memory leak work-around (24654)
<https://bugs.webkit.org/show_bug.cgi?id=24654>

Reviewed by Cameron Zwarich.

If the return value for a function is in a local register we need
to copy it before executing any finalisers, otherwise it is possible
for the finaliser to clobber the result.

Mar 17, 2009:

11:00 PM Changeset in webkit [41805] by levin@chromium.org

3 edits in trunk/WebCore

2009-03-17 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24662
Chromium build fixes.

Bug https://bugs.webkit.org/show_bug.cgi?id=24663 tracks
the invalid implementation of ScriptCallStack.

No change in behavior, so no test.

bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::drawRect):

10:14 PM Changeset in webkit [41804] by mrowe@apple.com

2 edits in trunk/WebKitTools

Use the normal search rules for tests inside the platform directory.

Reviewed by Oliver Hunt.

This allows tests inside the platform directory to have different results
on different versions of Mac OS X.

Scripts/run-webkit-tests:

9:58 PM Changeset in webkit [41803] by mrowe@apple.com

3 edits in trunk/LayoutTests

Update layout test to avoid depending on formatting of -[NSAttributedString description].

Rubber-stamped by Dan Bernstein.

The attributes aren't important to the test.

platform/mac/fast/text/attributed-substring-from-range-001-expected.txt:
platform/mac/fast/text/attributed-substring-from-range-001.html:

9:34 PM Changeset in webkit [41802] by mrowe@apple.com

6 edits
5 copies
10 moves
1 add in trunk/LayoutTests

Land updated results for tests involving Geeza Pro.

Rubber-stamped by Dan Bernstein.

platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum.
platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png.
platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt.
platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum.
platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum.
platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png.
platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt.
platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum.
platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.png.
platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt.
platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.checksum.
platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.png.
platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.txt.
platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
platform/mac/fast/text/international/bidi-neutral-run-expected.txt:

8:54 PM Changeset in webkit [41801] by mrowe@apple.com

3 edits
2 deletes in trunk/LayoutTests

Move the results out of platform/mac since they're a cross-platform progression,
and non-Mac platforms are already skipping the tests.

Rubber-stamped by Dan Bernstein.

fast/dom/Window/window-properties-expected.txt:
fast/dom/navigator-detached-no-crash-expected.txt:
platform/mac/fast/dom/Window/window-properties-expected.txt: Removed.
platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.

8:54 PM Changeset in webkit [41800] by mrowe@apple.com

2 edits
1 copy in trunk/LayoutTests

Update layout test results now that the test passes.

Rubber-stamped by Sam Weinig.

fast/xsl/mozilla-tests-expected.txt:
platform/mac-leopard/fast/xsl/mozilla-tests-expected.txt: Copied from LayoutTests/fast/xsl/mozilla-tests-expected.txt.

7:53 PM Changeset in webkit [41799] by mrowe@apple.com

1 edit
4 copies
1 add in trunk/LayoutTests

Add platform-specific layout test results to accommodate geolocation.

Reviewed by Sam Weinig.

platform/mac-leopard/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-expected.txt.
platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt.
platform/mac/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-expected.txt.
platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt.

7:53 PM Changeset in webkit [41798] by mrowe@apple.com

2 edits
1 delete in trunk/LayoutTests

Remove geolocation-not-implemented.html.

Reviewed by Sam Weinig.

geolocation/geolocation-not-implemented-expected.txt: Removed.
geolocation/geolocation-not-implemented.html: Removed.
geolocation/geolocation-test.js: Removed.
platform/gtk/Skipped:

7:53 PM Changeset in webkit [41797] by mrowe@apple.com

3 edits
2 copies
4 moves
3 adds in trunk/LayoutTests

Update layout test results to accommodate the updated Unicode text segmentation rules.

Rubber-stamped by Sam Weinig.

platform/mac-leopard/css1/text_properties/text_transform-expected.checksum: Renamed from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.checksum.
platform/mac-leopard/css1/text_properties/text_transform-expected.png: Renamed from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.png.
platform/mac-leopard/css1/text_properties/text_transform-expected.txt: Copied from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.txt.
platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.checksum: Renamed from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.checksum.
platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Renamed from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.png.
platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt.
platform/mac/css1/text_properties/text_transform-expected.txt:
platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt:

5:58 PM Changeset in webkit [41796] by ddkilzer@apple.com

2 edits in trunk/WebCore

2009-03-17 David Carson <dacarson@apple.com>

Reviewed by David Hyatt.

Add anchor elements to the simple style sheet so that applications that
are using WebKit just for simple text and links will also take advantage
of the fast path.

css/CSSStyleSelector.cpp: (WebCore::elementCanUseSimpleDefaultStyle):

5:54 PM Changeset in webkit [41795] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

resolve-ChangeLogs should not die on unmerged non-ChangeLog files

Reviewed by Adam Roben.

Fixes the following bug in resolve-ChangeLogs:

Use of uninitialized value in -e at ./WebKitTools/Scripts/resolve-ChangeLogs line 132.
Died at ./WebKitTools/Scripts/resolve-ChangeLogs line 164.

Scripts/resolve-ChangeLogs: (findUnmergedChangeLogs): Check the result of findChangeLog() to make sure we don't add undef values to the list of files being returned.

5:42 PM Changeset in webkit [41794] by Darin Adler

5 edits in trunk

WebCore:

2009-03-17 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

<rdar://problem/6687005> Need support for new move-left/right selectors.

editing/EditorCommand.cpp: (WebCore::executeMoveToLeftEndOfLine): Added. (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Added. (WebCore::executeMoveToRightEndOfLine): Added. (WebCore::executeMoveToRightEndOfLineAndModifySelection): Added. Added command entries for the functions above.

WebKit/mac:

2009-03-17 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

<rdar://problem/6687005> Need support for new move-left/right selectors.

WebView/WebHTMLView.mm: Added the four new selectors to the command-forwarding list.
WebView/WebView.mm: Ditto.

5:06 PM Changeset in webkit [41793] by Darin Adler

2 edits in trunk/WebKit/mac

2009-03-17 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 24477: REGRESSION (r41467): Page Down key scrolls two pages
https://bugs.webkit.org/show_bug.cgi?id=24477
rdar://problem/6674184

WebView/WebHTMLView.mm: (responderChainRespondsToSelector): Added. (-[WebHTMLView doCommandBySelector:]): Set eventWasHandled based on whether we can find a responder that responds to this selector rather than always assuming the selector will not be handled.

4:44 PM Changeset in webkit [41792] by eric@webkit.org

77 edits
3 adds in trunk

2009-03-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

Put the padding inside scrollbars on textareas.
https://bugs.webkit.org/show_bug.cgi?id=24370

Put the padding inside the scrollbars on textareas. This is done by moving the
overflow from the shadowNode to the RenderTextControlMultiline. As a result,
all of the scroll handing methods that RenderTextControl overrides can be moved
down into RenderTextControlSingleLine since RenderTextControlMultiline can now
just use RenderBlock's versions. This also allows RenderTextControlMultiLine to
no longer need a custom layout method since the shadowNode can now just size
like a regular DIV.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange): (WebCore::RenderTextControl::selection): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::hitInnerTextElement):
rendering/RenderTextControl.h:
rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint): (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
rendering/RenderTextControlMultiLine.h:
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::autoscroll): (WebCore::RenderTextControlSingleLine::scrollWidth): (WebCore::RenderTextControlSingleLine::scrollHeight): (WebCore::RenderTextControlSingleLine::scrollLeft): (WebCore::RenderTextControlSingleLine::scrollTop): (WebCore::RenderTextControlSingleLine::setScrollLeft): (WebCore::RenderTextControlSingleLine::setScrollTop): (WebCore::RenderTextControlSingleLine::scroll):
rendering/RenderTextControlSingleLine.h:
rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::positionForPoint): (WebCore::TextControlInnerTextElement::createRenderer):

4:34 PM Changeset in webkit [41791] by Darin Adler

5 edits in trunk/WebCore

2009-03-17 Darin Adler <Darin Adler>

Reviewed by David Hyatt.

Bug 24517: REGRESSION (r41552): innerHTML does an updateLayout -- unneeded and can be slow
https://bugs.webkit.org/show_bug.cgi?id=24517

editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::enable): Added a call to updateRendering, since determining whether to display the delete button involves style and updateRendering also updates style (should probably be named updateStyle, in fact). Not needed to fix this bug, but would have prevented the crash that led to this bug in the first place.

editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand): Get rid of unneeded null check. All frames have delete button controllers.
editing/Editor.cpp: (WebCore::Editor::rangeForPoint): Ditto.

editing/markup.cpp: (WebCore::appendStartMarkup): Changed a "&" to a "&&" so that generating markup doesn't depend on renderers at all when the convertBlocksToInlines boolean is false. This allows us to omit the call to updateLayoutIgnorePendingStylesheets in the createMarkup function that's called by innerHTML. (WebCore::MarkupAccumulator::appendMarkup): Turned this into a class with a member function. Added a feature where the accumulator will skip a node. Moved arguments that don't change during recursion into an object. This function still is a bit inefficient, since it creates a new HashMap at every level as it recurses, but for now I did not tackle that. Also replaced the onlyIncludeChildren boolean with EChildrenOnly for consistency and clarity. (WebCore::createMarkup): Removed the call to updateLayoutIgnorePendingStylesheets. Instead of calling disable/enable on the delete button controller's container element, pass it in to the markup accumulator as a node to skip.

3:24 PM Changeset in webkit [41790] by kov@webkit.org

2 edits in trunk/WebKitTools

2009-03-17 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Simon Fraser.

Fix the usage of the $architecture variable for non-Apple-Mac
ports.

Scripts/webkitdirs.pm:

3:17 PM Changeset in webkit [41789] by eric@webkit.org

5 edits in trunk/WebCore

2009-03-17 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24651
Skia does not always render text fill/stroke pattern/gradient/color correctly

Changes Skia's font rendering to only render gradient/pattern if current
color space indicates the gradient/pattern should be used.
This is covered by LayoutTests/fast/canvas/canvas-text-alignment.html .

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::strokeColorSpace): (WebCore::GraphicsContext::fillColorSpace):
platform/graphics/GraphicsContext.h: (WebCore::):
platform/graphics/GraphicsContextPrivate.h:
platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText):

3:05 PM Changeset in webkit [41788] by adele@apple.com

5 edits
4 adds in trunk

WebCore:

2009-03-17 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=24655
<rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message

Test: editing/inserting/6633727.html

This changes does a few things:
1) Renames pos to insertionPosition.
2) Eliminates "startNode". It doesn't work well to consider the node separately from the insertionPosition.

The insertionPosition gets updated at various times, and it seems likely that startNode can get out of sync.

3) Before building up a list of ancestors to move around when we insert the new block, make sure to use the deepest

representation of the insertionPosition, so all ancestor nodes are correctly included.

editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):

LayoutTests:

2009-03-17 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=24655
<rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message

editing/inserting/6633727.html: Added.
platform/mac/editing/inserting/6633727-expected.checksum: Added.
platform/mac/editing/inserting/6633727-expected.png: Added.
platform/mac/editing/inserting/6633727-expected.txt: Added.

Updated results. The behavior for these tests doesn't change, but the render tree is slightly different.

platform/mac/editing/inserting/insert-div-021-expected.txt:
platform/mac/editing/style/block-styles-007-expected.txt:

2:48 PM Changeset in webkit [41787] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Fix the build.

Plugins/Hosted/HostedNetscapePluginStream.mm:

1:16 PM Changeset in webkit [41786] by kevino@webkit.org

2 edits
3 adds
3 deletes in trunk/WebCore

Reviewed by Kevin Ollivier.

https://bugs.webkit.org/show_bug.cgi?id=24115
Introduce platform independent stubs for plugins.

1:14 PM Changeset in webkit [41785] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

Bug 24645: bisect-builds script doesn't work with Safari 4 Public Beta (version string)

<https://bugs.webkit.org/show_bug.cgi?id=24645>

Reviewed by Mark Rowe.

Scripts/bisect-builds: (makeNightlyList): Added checks for Safari 4 Public Beta on Tiger and Leopard.

1:13 PM Changeset in webkit [41784] by ddkilzer@apple.com

1 edit in trunk/WebKit/mac/ChangeLog

Fixed ChangeLog date.

1:09 PM Changeset in webkit [41783] by ddkilzer@apple.com

8 edits in trunk/WebKit/mac

Use -[NSURLResponse(WebCoreURLResponse) _webcore_MIMEType] consistently

Reviewed by Darin Adler.

WebKit r30323 added -_webcore_MIMEType to fix issues with
incorrect MIME types in NS[HTTP]URLResponse objects. However,
uses of -[NSURLResponse MIMEType] still persist in WebKit that
should be switched to use -_webcore_MIMEType. Note that
-[WebDataSource _responseMIMEType] calls back into WebCore to
get the MIME type from the ResourceResponse object, which has
already retrieved it via -_webcore_MIMEType.

Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::didReceiveResponse): Use -_webcore_MIMEType.
Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::didReceiveResponse): Ditto.
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginView:receivedData:]): Ditto.
Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]): Ditto.
WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation _isDisplayingWebArchive]): Use -[WebDataSource _responseMIMEType] instead.
WebView/WebPDFRepresentation.m: (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Ditto.
WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): Ditto.

1:01 PM Changeset in webkit [41782] by Simon Fraser

8 edits in trunk/WebCore

2009-03-17 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24632

Fix repaint issues when composited layers come and go (only applies
when ACCELERATED_COMPOSITING is turned on).

rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer):
rendering/RenderLayer.h: (WebCore::RenderLayer::mustOverlayCompositedLayers): (WebCore::RenderLayer::setMustOverlayCompositedLayers):
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking):
rendering/RenderLayerBacking.h:

Move what used to be the 'forceCompositingLayer' flag from RenderLayerBacking
to RenderLayer, because we don't want the side-effects of creating RenderLayerBacking
when setting this flag.

rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): When a RenderLayer flips into or out of compositing mode, compute a repaint rect relative to the containerForRepaint, and repaint it.

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
Call layer->setMustOverlayCompositedLayers() rather than setForcedCompositingLayer().

(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):

rendering/RenderLayerCompositor.h:

Rename requiresCompositingLayerForTransform() to requiresCompositingForTransform()
and make it a class static method to match requiresCompositingForAnimation(). Both
now take RenderObjects, rathern than RenderLayers.

rendering/style/RenderStyle.h: (WebCore::InheritedFlags::hasTransformRelatedProperty): Minor tidyup using convenience methods added in an earlier commit.

12:42 PM Changeset in webkit [41781] by Darin Adler

2 edits in trunk/WebCore

2009-03-17 Darin Adler <Darin Adler>

Earlier version reviewed by Adele Peterson.

Bug 24304: REGRESSION (r39864): Hitting the space bar to select an <input type=radio>
or push an <input type=button> or <button> causes the page to scroll down.

Would be best to add a regression test for Windows eventually; tested that this has
no effect on the Mac OS X platform.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Added FIXMEs and tweaked formatting. Use the code that calls the base class's defaultEventHandler early only in the cases where it's needed: keydown and keypress events in text fields. In other cases, do the more typical thing and call the default handler only at the end of the function. This function already had code to make sure the keypress event for space never gets through, but it was running too late since the scrolling code was moved into the base class default event handler.

12:24 PM Changeset in webkit [41780] by Simon Fraser

18 edits in trunk

2009-03-17 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24396

config.h: Add WTF_USE_ACCELERATED_COMPOSITING, defined to 0 for now, and add some comments to make the #ifdefs more readable.

css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform): Add a comment to mention that we don't flatten the matrix.

css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval): Have the 'transform-3d' media query evaluate to 'true' if 3d-rendering is supported.

platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform): No need for the #ifdef here. If we don't support 3d, we will have already flattened the matrix.

platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::makeAffine):
platform/graphics/transforms/TransformationMatrix.h: New method to convert the matrix to an affine matrix by throwing a way the non-affine parts.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::currentTransform):
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateLayerTransform): If 3d rendering is not supported, convert the matrix to an affine matrix which can be rendered, and used for hit testing.

rendering/RenderLayerCompositor.cpp: Change the name of the exported symbol that webkitdirs.pm uses to know if 3d rendering is supported. There is no other 3d-rendering-specific symbol we can sniff.

rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer): Only take perspective into account if 3d rendering is supported.

rendering/RenderObject.h: (WebCore::makeMatrixRenderable): Utility method that flattens a matrix if 3d rendering is not supported.

12:22 PM Changeset in webkit [41779] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix. Fix typo after mouse wheel changes.

11:57 AM Changeset in webkit [41778] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/fast/repaint/subtree-root-clip-expected.txt

Update failing layout test after float painting fix.

11:26 AM Changeset in webkit [41777] by Darin Adler

2 edits in trunk/WebCore

2009-03-17 Darin Adler <Darin Adler>

inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::isEqual): Fix build, remove stray parenthesis.

11:22 AM Changeset in webkit [41776] by kov@webkit.org

4 edits in trunk

2009-03-17 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Mark Rowe.

Enable HTML5 media elements support by default in the GTK+ port.

configure.ac:

WebKitTools:

2009-03-17 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Mark Rowe.

Enable HTML5 media elements support by default also for the GTK+
port.

Scripts/build-webkit:

11:16 AM Changeset in webkit [41775] by Darin Adler

2 edits in trunk/WebCore

2009-03-17 Darin Adler <Darin Adler>

Fix crash seen right away when running run-webkit-tests.

inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::isEqual): Restore assertion to its behavior pre-refactoring. Also tweaked formatting a bit.

11:06 AM Changeset in webkit [41774] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by Darin Adler.

HTMLSelectElement::add() doesn't look at exception code returned from insertBefore(), so
it doesn't need to zero it out before calling.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): Removed "ec = 0" line.

11:01 AM Changeset in webkit [41773] by mitz@apple.com

14 edits
2 adds in trunk

WebCore:

Reviewed by Adam Roben.

WebCore part of adding a mechanism for controlling the caching of responses through WebFrameLoaderClient

Mac already has such a mechanism, and this adds one for CFNetwork ports.

WebCore.vcproj/WebCore.vcproj: Added EmptyClients.h and ResourceLoaderCFNet.cpp.

loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::shouldCacheResponse): Added an implementation that always returns true.

loader/FrameLoaderClient.h: Declared shouldCacheResponse().

loader/ResourceLoader.h: Ditto.

loader/cf/ResourceLoaderCFNet.cpp: Added. (WebCore::ResourceLoader::shouldCacheResponse): Added. Calls through to FrameLoaderClient::shouldCacheResponse().

platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::shouldCacheResponse): Added an implementation that always returns true.

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willCacheResponse): Added a call to ResourceHandleClient::shouldCacheResponse(). If the client returns false, return 0, which will prevent CFNetwork from caching the response.

WebKit/win:

Reviewed by Adam Roben.

WebKit part of adding a mechanism for controlling the caching of responses through WebFrameLoaderClient

Interfaces/IWebResourceLoadDelegatePrivate.idl: Added the IWebResourceLoadDelegatePrivate3 interface, containing the new delegate method shouldCacheResponse().

Interfaces/IWebURLRequest.idl: Added the isEqual() method.

WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldCacheResponse): Implemented this new FrameLoaderDelegate method by calling through to the resource load delegate, if it implements shouldCacheResponse(), and returning true otherwise.

WebCoreSupport/WebFrameLoaderClient.h:

WebMutableURLRequest.cpp: (WebMutableURLRequest::isEqual): Added. (WebMutableURLRequest::setValue): Implemented.

WebMutableURLRequest.h: Declared isEqual().

10:57 AM Changeset in webkit [41772] by ap@webkit.org

7 edits
8 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=13287
Cannot change SELECT to a dynamically created option

Tests: fast/forms/add-and-remove-option.html

fast/forms/add-remove-option-modification-event.html
fast/forms/add-selected-option.html
fast/forms/select-cache-desynchronization.html

dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): Increment DOM tree version. This will happen when dispatching DOMSubtreeModified again, but the version should be incremented for event listeners to have an up to date view of the DOM. (WebCore::dispatchChildRemovalEvents): Ditto.

html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::insertedIntoTree): Make sure that the select element knows about its new selected option.

html/HTMLOptionElement.h: Use insertedIntoTree() instead of insertedIntoDocument(), because DOM also needs to be updated for forms that are not in document yet. Similar problems exist for node removing, but removedFromTree() is called at a wrong time, so those problems cannot be fixed without deeper refactoring.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setRecalcListItems): Reset m_activeSelectionAnchorIndex - it doesn't make sense to keep the anchor after programmatically changing the selection, and keeping it was causing a failure in fast/forms/listbox-selection.html.

html/HTMLSelectElement.h: Removed overrides for ContainerNode methods that only called base class versions.

10:47 AM Changeset in webkit [41771] by sfalken@apple.com

2 edits in trunk/WebCore

<rdar://problem/6690324> Accessing FTP sites reads unallocated memory, can result in garbled entries or crashes

Reviewed by Darin Adler.

loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine): Assign CString to a local while we hold pointers into it.

10:36 AM Changeset in webkit [41770] by hyatt@apple.com

1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog comment.

10:30 AM Changeset in webkit [41769] by hyatt@apple.com

5 edits
4 adds in trunk

WebCore:

2009-03-16 David Hyatt <hyatt@apple.com>

<rdar://problem/6648411> REGRESSION: Layout of page is wrong at http://www.popcap.com/

Make sure that the initial shouldPaint check that looks at enclosingLayers properly skips over
layers that don't paint themselves. This is done by adding a new boolean parameter to enclosingLayer
so that RenderObjects can walk up the enclosing layer chain and skip any layers that don't paint
themselves.

Reviewed by Darin Adler.

Added fast/block/float/overlapping-floats-with-overflow-hidden.html

WebCore.base.exp:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverhangingFloats):
rendering/RenderObject.cpp: (WebCore::RenderObject::enclosingSelfPaintingLayer):
rendering/RenderObject.h:

LayoutTests:

2009-03-16 David Hyatt <hyatt@apple.com>

<rdar://problem/6648411> REGRESSION: Layout of page is wrong at http://www.popcap.com/

Make sure that the initial shouldPaint check that looks at enclosingLayers properly skips over
layers that don't paint themselves. This is done by adding a new enclosingSelfPaintingLayer method
so that RenderObjects can walk up the enclosing layer chain and skip any layers that don't paint
themselves.

Reviewed by Darin Adler.

fast/block/float/overlapping-floats-with-overflow-hidden.html: Added.
platform/mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.checksum: Added.
platform/mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.png: Added.
platform/mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Added.

10:25 AM Changeset in webkit [41768] by xan@webkit.org

3 edits in trunk/WebCore

2009-03-17 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24592
[GTK] Crash in FcPatternHash

Style fixes.

platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::operator=):
platform/graphics/gtk/FontPlatformDataPango.cpp:

10:24 AM Changeset in webkit [41767] by xan@webkit.org

3 edits in trunk/WebCore

2009-03-17 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24592
[GTK] Crash in FcPatternHash

Sanitize memory management in pango fonts.

Release memory allocated by FontPlatformDataPango in its own
destructor instead of doing it from other classes, and add copy
constructor and '=' operator to be able to track referenced
objects properly.

platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::FontPlatformData):
platform/graphics/gtk/SimpleFontDataPango.cpp:

10:02 AM Changeset in webkit [41766] by Darin Adler

9 edits
3 adds in trunk

WebCore:

2009-03-17 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Bug 24624: Crash in imageLoadEventTimerFired after adoptNode used on <img>,
seen with inspector, which uses adoptNode
https://bugs.webkit.org/show_bug.cgi?id=24624
rdar://problem/6422850

Test: fast/dom/HTMLImageElement/image-load-cross-document.html

dom/Document.cpp: (WebCore::Document::Document): Removed m_imageLoadEventTimer. (WebCore::Document::detach): Removed m_imageLoadEventDispatchSoonList and m_imageLoadEventDispatchingList. (WebCore::Document::implicitClose): Called ImageLoader::dispatchPendingLoadEvents instead of dispatchImageLoadEventsNow.

dom/Document.h: Removed ImageLoader, dispatchImageLoadEventSoon, dispatchImageLoadEventsNow, removeImage, m_imageLoadEventDispatchSoonList, m_imageLoadEventDispatchingList, m_imageLoadEventTimer, and imageLoadEventTimerFired.

loader/ImageLoader.cpp: (WebCore::loadEventSender): Added. Returns the single global ImageLoadEventSender object used privately as the target of the load event timer. (WebCore::ImageLoader::~ImageLoader): Call ImageLoadEventSender::cancelLoadEvent rather than Document::removeImage. (WebCore::ImageLoader::setImage): Use m_element directly, not element(). (WebCore::ImageLoader::updateFromElement): Ditto. Also name the local variable document instead of doc. (WebCore::ImageLoader::notifyFinished): Call ImageLoadEventSender::dispatchLoadEventSoon rather than Document::dispatchImageLoadEventSoon. (WebCore::ImageLoader::dispatchPendingLoadEvent): Added. Handles the common logic about when load events can be dispatched so that dispatchLoadEvent only has to have the specific part for each derived class. This includes a check that the document is attached, which used to be handled by having documents empty out the image load event vectors in the detach function. (WebCore::ImageLoader::dispatchPendingLoadEvents): Added. Calls the appropriate function on the ImageLoadEventSender, which avoids the need to have that class be public in the ImageLoader header. (WebCore::ImageLoadEventSender::ImageLoadEventSender): Added. Has the code that was previously in the Document constructor. (WebCore::ImageLoadEventSender::dispatchLoadEventSoon): Added. Has the code that was previously in Document::dispatchImageLoadEventSoon. (WebCore::ImageLoadEventSender::cancelLoadEvent): Added. Has the code that was previously in Document::removeImage. (WebCore::ImageLoadEventSender::dispatchPendingLoadEvents): Added. Has the code that was previously in Document::dispatchImageLoadEventsNow. (WebCore::ImageLoadEventSender::timerFired): Added. Calls dispatchPendingLoadEvents.

loader/ImageLoader.h: Improved comments. Made the virtual functions private or protected rather than public. Added static dispatchPendingLoadEvents function for use by Document and private dispatchPendingLoadEvent function for use by ImageLoadEventSender. Made setLoadingImage private and eliminated setHaveFiredLoadEvent since that can all be done inside the class without any member functions.

html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent): Removed logic to check whether a load event already fired and whether image() is 0. These are now both base class responsibilities.
svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::dispatchLoadEvent): Ditto.
wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::dispatchLoadEvent): Ditto.

LayoutTests:

2009-03-17 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Bug 24624: Crash in imageLoadEventTimerFired after adoptNode used on <img>,
seen with inspector, which uses adoptNode
https://bugs.webkit.org/show_bug.cgi?id=24624
rdar://problem/6422850

This test has one significant disadvantage. When it fails, the crash typically
occurs during a subsequent test, not this one. It would be great if someone figured
out at some point how to improve that.

fast/dom/HTMLImageElement/image-load-cross-document-expected.txt: Added.
fast/dom/HTMLImageElement/image-load-cross-document.html: Added.
fast/dom/HTMLImageElement/resources/image-load-subframe.html: Added.

9:17 AM Changeset in webkit [41765] by Dimitri Glazkov

11 edits in trunk/WebCore

2009-03-17 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24623
Refactor ConsoleMessage to use ScriptFuncitonCall and eliminate JSC
dependencies.

bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Added uint and ScriptString-taking methods.
bindings/js/ScriptFunctionCall.h:
bindings/js/ScriptObjectQuarantine.cpp: (WebCore::quarantineValue): Added generic ScriptValue quarantine helper.
bindings/js/ScriptObjectQuarantine.h:
bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isEqual): Added.
bindings/js/ScriptValue.h:
inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): Added. (WebCore::ConsoleMessage::isEqual): Changed to use ScriptValue::isEqual.
inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::incrementCount): Added.
inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): Changed to use ConsoleMessage::addToConsole. (WebCore::InspectorController::populateScriptObjects): Ditto.
inspector/InspectorController.h:

9:06 AM Changeset in webkit [41764] by kevino@webkit.org

9 edits in trunk

Reviewed by Mark Rowe.

Move BUILDING_ON_* defines into Platform.h to make them available to other ports.
Also tweak the defines so that they work with the default values set by
AvailabilityMacros.h.

https://bugs.webkit.org/show_bug.cgi?id=24630

8:40 AM Changeset in webkit [41763] by kov@webkit.org

2 edits in trunk

2009-03-17 Mike Hommey <glandium@debian.org>

Reviewed by Holger Freyther.

Do not export cti* symbols.
See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=519924.

autotools/symbols.filter:

7:43 AM Changeset in webkit [41762] by xan@webkit.org

4 edits in trunk/WebCore

2009-03-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24592
[GTK] Crash in FcPatternHash

Sanitize memory management in gtk fonts.

Release memory allocated by FontPlatformDataGtk in its own
destructor instead of doing it from other classes, and add copy
constructor and '=' operator to be able to track referenced
objects properly.

platform/graphics/gtk/FontPlatformData.h:
platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformDestroy):

6:22 AM Changeset in webkit [41761] by ariya@webkit.org

2 edits in trunk/WebCore

2009-03-17 Ariya Hidayat <ariya.hidayat@nokia.com>

Build fix for Qt < 4.5.

As reported by Yael Aharon <yael.aharon@nokia.com>

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine):

5:08 AM QtWebKitTodo edited by ariya@webkit.org

(diff)

2:15 AM Changeset in webkit [41760] by oliver@apple.com

3 edits in trunk/WebKitTools

Fix coverage builds

Reviewed by Alexey Proskuryakov

Make coverage testing more reliable by ensuring --coverage does not
clobber configuration settings, and by removing the unnecessary
dependency on matplotlib.

12:29 AM Changeset in webkit [41759] by ap@webkit.org

8 edits
2 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24614
Access control checks are different in cached and uncached cases

Test: http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html

loader/CrossOriginAccessControl.cpp: (WebCore::isOnAccessControlSimpleRequestMethodWhitelist): Factored out simple method check for use in both cached and uncached cases. In cached case, an old definition that omitted HEAD was still used. (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Check that content type has an allowed value. This is needed in all call sites. Also changed to compare MIME type, not content type. (WebCore::isSimpleCrossOriginAccessRequest): Use the above methods.

loader/CrossOriginAccessControl.h: Expose isOnAccessControlSimpleRequestMethodWhitelist.

loader/CrossOriginPreflightResultCache.cpp: (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod): (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders): Use the new checks for simple method and header.

12:23 AM Changeset in webkit [41758] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-03-16 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24638
[GTK] HTML5 media tags do not work

Remove the blacklisting of the media/ directory, now that we have
a working MediaPlayer; skip only the tests that are still failing
because MediaPlayerPrivateGStreamer is not completely implemented.

platform/gtk/Skipped:

12:11 AM Changeset in webkit [41757] by kov@webkit.org

3 edits in trunk/WebCore

2009-03-16 Gustavo Noronha Silva <Gustavo Noronha Silva> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24638
[GTK] HTML5 media tags do not work

Add a repaint-requested signal to the video sink, and use it to
call MediaPlayerPrivate::repaint, so that the video actually
plays.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func): (webkit_video_sink_render): (webkit_video_sink_class_init):

12:02 AM Changeset in webkit [41756] by kov@webkit.org

2 edits in trunk/WebCore

2009-03-16 Gustavo Noronha Silva <Gustavo Noronha Silva> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24638
[GTK] HTML5 media tags do not work

Work-around the fact that gst_element_query_duration returns true even
though it is unable to figure out the duration when in stream (push)
mode.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):

Mar 16, 2009:

6:26 PM Changeset in webkit [41755] by mrowe@apple.com

2 edits in trunk/LayoutTests

Skip media tests that are currently failing.

Rubber-stamped by Adele Peterson.

platform/mac-snowleopard/Skipped:

5:10 PM Changeset in webkit [41754] by Darin Adler

2 edits in trunk/WebCore

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Kevin Decker.

<rdar://problem/6642742> Top Sites malfunction when switching text zoom mode

page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): Don’t do anything if the frame is currently showing a non-HTML view.

4:55 PM Changeset in webkit [41753] by mrowe@apple.com

2 edits in trunk/LayoutTests

Skip a test that is currently crashing.

Rubber-stamped by Beth Dakin.

platform/mac-snowleopard/Skipped:

4:55 PM Changeset in webkit [41752] by mrowe@apple.com

7 edits in trunk/LayoutTests

Update test results for six accessibility tests.

Rubber-stamped by Beth Dakin.

platform/mac/accessibility/lists-expected.txt:
platform/mac/accessibility/table-attributes-expected.txt:
platform/mac/accessibility/table-detection-expected.txt:
platform/mac/accessibility/table-sections-expected.txt:
platform/mac/accessibility/table-with-aria-role-expected.txt:
platform/mac/accessibility/table-with-rules-expected.txt:

4:55 PM Changeset in webkit [41751] by mrowe@apple.com

1 edit
1 copy
37 moves
1 add in trunk/LayoutTests

Move platform-specific acessibility tests and results into platform/mac.

Rubber-stamped by Beth Dakin.

platform/mac/accessibility/accesskey-expected.txt: Renamed from LayoutTests/accessibility/accesskey-expected.txt.
platform/mac/accessibility/accesskey.html: Renamed from LayoutTests/accessibility/accesskey.html.
platform/mac/accessibility/aria-describedby-on-input-expected.txt: Renamed from LayoutTests/accessibility/aria-describedby-on-input-expected.txt.
platform/mac/accessibility/aria-labelledby-on-input-expected.txt: Renamed from LayoutTests/accessibility/aria-labelledby-on-input-expected.txt.
platform/mac/accessibility/aria-range-expected.txt: Renamed from LayoutTests/accessibility/aria-range-expected.txt.
platform/mac/accessibility/aria-range-value-expected.txt: Renamed from LayoutTests/accessibility/aria-range-value-expected.txt.
platform/mac/accessibility/aria-range-value.html: Renamed from LayoutTests/accessibility/aria-range-value.html.
platform/mac/accessibility/aria-range.html: Renamed from LayoutTests/accessibility/aria-range.html.
platform/mac/accessibility/aria-roles-expected.txt: Renamed from LayoutTests/accessibility/aria-roles-expected.txt.
platform/mac/accessibility/aria-slider-expected.txt: Renamed from LayoutTests/accessibility/aria-slider-expected.txt.
platform/mac/accessibility/aria-slider.html: Renamed from LayoutTests/accessibility/aria-slider.html.
platform/mac/accessibility/aria-spinbutton-expected.txt: Renamed from LayoutTests/accessibility/aria-spinbutton-expected.txt.
platform/mac/accessibility/aria-spinbutton.html: Renamed from LayoutTests/accessibility/aria-spinbutton.html.
platform/mac/accessibility/bounds-for-range-expected.txt: Renamed from LayoutTests/accessibility/bounds-for-range-expected.txt.
platform/mac/accessibility/bounds-for-range.html: Renamed from LayoutTests/accessibility/bounds-for-range.html.
platform/mac/accessibility/content-editable-expected.txt: Renamed from LayoutTests/accessibility/content-editable-expected.txt.
platform/mac/accessibility/content-editable.html: Renamed from LayoutTests/accessibility/content-editable.html.
platform/mac/accessibility/document-attributes-expected.txt: Renamed from LayoutTests/accessibility/document-attributes-expected.txt.
platform/mac/accessibility/document-attributes.html: Renamed from LayoutTests/accessibility/document-attributes.html.
platform/mac/accessibility/document-links-expected.txt: Renamed from LayoutTests/accessibility/document-links-expected.txt.
platform/mac/accessibility/document-links.html: Renamed from LayoutTests/accessibility/document-links.html.
platform/mac/accessibility/double-title-expected.txt: Renamed from LayoutTests/accessibility/double-title-expected.txt.
platform/mac/accessibility/double-title.html: Renamed from LayoutTests/accessibility/double-title.html.
platform/mac/accessibility/frame-with-title-expected.txt: Renamed from LayoutTests/accessibility/frame-with-title-expected.txt.
platform/mac/accessibility/frame-with-title.html: Renamed from LayoutTests/accessibility/frame-with-title.html.
platform/mac/accessibility/image-map1-expected.txt: Renamed from LayoutTests/accessibility/image-map1-expected.txt.
platform/mac/accessibility/image-map2-expected.txt: Renamed from LayoutTests/accessibility/image-map2-expected.txt.
platform/mac/accessibility/input-image-url-expected.txt: Renamed from LayoutTests/accessibility/input-image-url-expected.txt.
platform/mac/accessibility/input-image-url.html: Renamed from LayoutTests/accessibility/input-image-url.html.
platform/mac/accessibility/internal-link-anchors-expected.txt: Renamed from LayoutTests/accessibility/internal-link-anchors-expected.txt.
platform/mac/accessibility/internal-link-anchors.html: Renamed from LayoutTests/accessibility/internal-link-anchors.html.
platform/mac/accessibility/internal-link-anchors2-expected.txt: Renamed from LayoutTests/accessibility/internal-link-anchors2-expected.txt.
platform/mac/accessibility/legend-expected.txt: Renamed from LayoutTests/accessibility/legend-expected.txt.
platform/mac/accessibility/plugin-expected.txt: Renamed from LayoutTests/accessibility/plugin-expected.txt.
platform/mac/accessibility/radio-button-group-members-expected.txt: Renamed from LayoutTests/accessibility/radio-button-group-members-expected.txt.
platform/mac/accessibility/resources/cake.png: Copied from LayoutTests/accessibility/resources/cake.png.
platform/mac/accessibility/resources/test.swf: Renamed from LayoutTests/accessibility/resources/test.swf.
platform/mac/accessibility/table-one-cell-expected.txt: Renamed from LayoutTests/accessibility/table-one-cell-expected.txt.

4:30 PM Changeset in webkit [41750] by Darin Adler

7 edits in trunk/WebKit

WebKit:

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

English.lproj/Localizable.strings: Updated.
StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit/mac:

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”

WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagParagraphDirectionMenu]): Changed string here, but only post-Leopard, since we want this to match the Mac OS X menu on Tiger and Leopard. (-[WebViewFactory contextMenuItemTagSelectionDirectionMenu]): Changed string here.

WebKit/win:

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”

For now, change only the localized strings, not the terminology in the code.

WebCoreLocalizedStrings.cpp: (WebCore::contextMenuItemTagWritingDirectionMenu): Changed string here. (WebCore::contextMenuItemTagTextDirectionMenu): And here.

4:15 PM Changeset in webkit [41749] by Darin Adler

3 edits
2 adds in trunk

WebCore:

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 24629: moving forward or backward a paragraph fails at edge of document
https://bugs.webkit.org/show_bug.cgi?id=24629
rdar://problem/6544413

Test: editing/selection/move-paragraph-document-edges.html

editing/visible_units.cpp: (WebCore::previousParagraphPosition): Use the last result from previousLinePosition rather than going all the way back to what was originally passed in when we hit exception cases like null or not moving. This correctly inherits the behavior of previousLinePosition when we are in a paragraph at the edge of a document. (WebCore::nextParagraphPosition): Ditto.

LayoutTests:

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 24629: moving forward or backward a paragraph fails at edge of document
https://bugs.webkit.org/show_bug.cgi?id=24629
rdar://problem/6544413

editing/selection/move-paragraph-document-edges-expected.txt: Added.
editing/selection/move-paragraph-document-edges.html: Added.

3:41 PM Changeset in webkit [41748] by Darin Adler

3 edits in trunk/WebCore

2009-03-16 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 24619: RenderObject::selectionStartEnd does not need to be a virtual function
https://bugs.webkit.org/show_bug.cgi?id=24619

rendering/RenderObject.h: Remove virtual keyword from selectionStartEnd declaration.
rendering/RenderView.h: Ditto.

3:37 PM Changeset in webkit [41747] by christian@webkit.org

4 edits in trunk/WebKit/gtk

2009-03-16 Christian Dywan <christian@twotoasts.de>

Reviewed by Adam Roben.

[gtk] API implementation: url and title
http://bugs.webkit.org/show_bug.cgi?id=14807

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
webkit/webkitwebview.cpp:
webkit/webkitwebview.h: Implement "title" and "uri" properties as well as according functions. "uri" always reflects the current location including navigation inside the same page. title-changed is deprecated.

3:19 PM Changeset in webkit [41746] by pkasting@chromium.org

10 edits in trunk/WebCore

2009-03-16 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24368
DOM scroll events should be based off the actual number of wheel
ticks, not off the number of lines scrolled. This matches IE.

dom/Node.cpp: (WebCore::Node::dispatchWheelEvent):
dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):
dom/WheelEvent.h: (WebCore::WheelEvent::create):
platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::wheelTicksX): (WebCore::PlatformWheelEvent::wheelTicksY):
platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/qt/WheelEventQt.cpp:
platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/wx/MouseWheelEventWx.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

3:07 PM Changeset in webkit [41745] by Simon Fraser

3 edits in trunk/WebCore

2009-03-16 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

Clean up a few issues in the Animation code:

page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine): Whitespace

(WebCore::AnimationBase::willNeedService):
Don't round to float, use std::max

page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::startTimeResponse): Fix erroneously copied line to null out m_lastResponseWaiter.

2:58 PM Changeset in webkit [41744] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-16 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

Don't mig_deallocate random data in case an instance proxy method returns false.

Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke): (WKPCInvokeDefault): (WKPCGetProperty): (WKPCEnumerate):

2:49 PM Changeset in webkit [41743] by andersca@apple.com

2 edits in trunk/WebKitTools

2009-03-16 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler and John Sullivan.

When a plug-in instance is torn down, all plug-in objects will first be invalidated and then deallocated.
Since objects can be deallocated in any order, it is not safe to call NPN_ReleaseObject on member variables.

Instead, just zero out the member variable in invalidate.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvalidate): (pluginDeallocate):

2:34 PM Changeset in webkit [41742] by hyatt@apple.com

63 edits in trunk

WebCore:

2009-03-12 David Hyatt <hyatt@apple.com>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=13632

Overflow scrolling needs to account for the bottom/right padding on the object itself as well
as for bottom/right margins on children.

Existing tests cover this.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition):

LayoutTests:

2009-03-16 David Hyatt <hyatt@apple.com>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=13632

Overflow scrolling needs to account for the bottom/right padding on the object itself as well
as for bottom/right margins on children.

platform/mac/fast/body-propagation/overflow/002-expected.checksum:
platform/mac/fast/body-propagation/overflow/002-expected.png:
platform/mac/fast/body-propagation/overflow/002-expected.txt:
platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum:
platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
platform/mac/fast/body-propagation/overflow/002-xhtml-expected.txt:
platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum:
platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
platform/mac/fast/body-propagation/overflow/003-declarative-expected.txt:
platform/mac/fast/body-propagation/overflow/003-expected.checksum:
platform/mac/fast/body-propagation/overflow/003-expected.png:
platform/mac/fast/body-propagation/overflow/003-expected.txt:
platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum:
platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
platform/mac/fast/body-propagation/overflow/003-xhtml-expected.txt:
platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum:
platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
platform/mac/fast/body-propagation/overflow/004-declarative-expected.txt:
platform/mac/fast/body-propagation/overflow/004-expected.checksum:
platform/mac/fast/body-propagation/overflow/004-expected.png:
platform/mac/fast/body-propagation/overflow/004-expected.txt:
platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum:
platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
platform/mac/fast/body-propagation/overflow/004-xhtml-expected.txt:
platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum:
platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
platform/mac/fast/body-propagation/overflow/007-declarative-expected.txt:
platform/mac/fast/body-propagation/overflow/007-expected.checksum:
platform/mac/fast/body-propagation/overflow/007-expected.png:
platform/mac/fast/body-propagation/overflow/007-expected.txt:
platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum:
platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
platform/mac/fast/body-propagation/overflow/007-xhtml-expected.txt:
platform/mac/fast/forms/basic-textareas-expected.txt:
platform/mac/fast/forms/input-disabled-color-expected.txt:
platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
platform/mac/fast/overflow/003-expected.checksum:
platform/mac/fast/overflow/003-expected.png:
platform/mac/fast/overflow/003-expected.txt:
platform/mac/fast/overflow/004-expected.checksum:
platform/mac/fast/overflow/004-expected.png:
platform/mac/fast/overflow/007-expected.checksum:
platform/mac/fast/overflow/007-expected.png:
platform/mac/fast/overflow/007-expected.txt:
platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.txt:
platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
platform/mac/fast/replaced/width100percent-textarea-expected.png:
platform/mac/fast/replaced/width100percent-textarea-expected.txt:
platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt:
platform/mac/tables/mozilla/bugs/bug83786-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:

2:19 PM Changeset in webkit [41741] by weinig@apple.com

3 edits
2 adds in trunk

WebCore:

2009-03-16 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for <rdar://problem/6320555>
Add an upper limit for setting HTMLSelectElement.length.

Test: fast/forms/select-max-length.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption): (WebCore::HTMLSelectElement::setLength):

LayoutTests:

2009-03-16 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Test for <rdar://problem/6320555>
Add an upper limit for setting HTMLSelectElement.length.

fast/forms/select-max-length-expected.txt: Added.
fast/forms/select-max-length.html: Added.

1:56 PM Changeset in webkit [41740] by eric@webkit.org

2 edits in trunk/WebKitTools

Reviewed by Sam Weinig.

REGRESSION: undo-iframe-location-change.html is failing on the buildbots
https://bugs.webkit.org/show_bug.cgi?id=24626

Added a call to [[webview undoManager] removeAllActions]
to make sure anything left on the undo stack after one test
will not affect any later test.

DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):

1:09 PM Changeset in webkit [41739] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-16 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6633944>
REGRESSION (Safari 4 PB): Many crashes in Flip4Mac involving loading the plugin

Defer loading while calling webPlugInInitialize since it can end up spinning the run loop.

Plugins/WebPluginController.mm: (-[WebPluginController addPlugin:]):

1:03 PM Changeset in webkit [41738] by Adam Roben

4 edits in trunk/WebKit/win

Add IWebFramePrivate::isDisplayingStandaloneImage

This uses the same logic that -[WebFrame _isDisplayingStandaloneImage]
uses.

Reviewed by Darin Adler.

Interfaces/IWebFramePrivate.idl: Added isDisplayingStandaloneImage.

WebFrame.cpp: (WebFrame::isDisplayingStandaloneImage): Added. Returns true if our Document is an image document.

WebFrame.h: Added isDisplayingStandaloneImage.

12:56 PM Changeset in webkit [41737] by eric.carlson@apple.com

2 edits in trunk/WebCore

2009-03-16 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6686721> Media document crash in 64-bit WebKit

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): QTMovieContentViewClass is only used when rendering inline with old versions of QuickTime, so don't look for it when we are in a media document.

12:55 PM Changeset in webkit [41736] by pam@chromium.org

3 edits in trunk/LayoutTests

2009-03-16 Pamela Greene <pam@chromium.org>

Reviewed by Dimitri Glazkov.

Remove test dependency on precise window location and size. It's not
clear to me why these vary, but they're not what the test is checking,
so it need not depend on them in any case.
https://bugs.webkit.org/show_bug.cgi?id=24170

fast/dom/Window/window-lookup-precedence-expected.txt:
fast/dom/Window/window-lookup-precedence.html:

11:54 AM Changeset in webkit [41735] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-16 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix <rdar://problem/6622601>

Make sure to update both the window frame and the plug-in frame.

Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView addWindowObservers]):

9:47 AM Changeset in webkit [41734] by Dimitri Glazkov

9 edits in trunk/WebCore

2009-03-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24590
Refactor InspectorDOMStorageResource to use ScriptFunctionCall.

bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Added method for bool argument.
bindings/js/ScriptFunctionCall.h: Ditto, also cleaned up.
bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject): Added Storage helper.
bindings/js/ScriptObjectQuarantine.h: Ditto.
inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): Changed to use bind method. (WebCore::InspectorController::resetScriptObjects): Changed to use unbind method. (WebCore::InspectorController::didUseDOMStorage): Changed to use isSameHostAndType and bind methods.
inspector/InspectorController.h: Removed add/remove methods for DOM storage.
inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource): (WebCore::InspectorDOMStorageResource::isSameHostAndType): Added. (WebCore::InspectorDOMStorageResource::bind): Added. (WebCore::InspectorDOMStorageResource::unbind): Added.
inspector/InspectorDOMStorageResource.h:

9:13 AM Changeset in webkit [41733] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-16 Mike Belshe <mike@belse.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24580
Fix query() to match KURL behavior, this time with the code that
compiles.

platform/KURLGoogle.cpp: (WebCore::KURL::query): Fix copy/paste mistake.

12:39 AM Changeset in webkit [41732] by ap@webkit.org

12 edits
3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21752
REGRESSION: referencing XHR constructor for a not yet loaded frame permanently breaks it

Test: fast/dom/Window/window-early-properties-xhr.html

For some transitions, the Window object is not replaced, but Document is. When this happened,
window.document property was updated, but references to Document kept in cached constructors
were not.

bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): (WebCore::JSAudioConstructor::document): (WebCore::JSAudioConstructor::mark):
bindings/js/JSAudioConstructor.h:
bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor): (WebCore::JSImageConstructor::document): (WebCore::JSImageConstructor::mark):
bindings/js/JSImageConstructor.h:
bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): (WebCore::JSMessageChannelConstructor::scriptExecutionContext): (WebCore::JSMessageChannelConstructor::mark):
bindings/js/JSMessageChannelConstructor.h:
bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor): (WebCore::JSOptionConstructor::document): (WebCore::JSOptionConstructor::mark):
bindings/js/JSOptionConstructor.h:
bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext): (WebCore::JSXMLHttpRequestConstructor::mark):
bindings/js/JSXMLHttpRequestConstructor.h: Changed cached constructors to keep a reference to Window, not Document.

12:12 AM Changeset in webkit [41731] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24549
Impose a limit on Access-Control-Max-Age value

loader/CrossOriginPreflightResultCache.cpp: (WebCore::CrossOriginPreflightResultCacheItem::parse):

Mar 15, 2009:

7:04 PM Changeset in webkit [41730] by bolsinga@apple.com

2 edits in trunk/WebCore

2009-03-15 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

<rdar://problem/6668875> Normalize Geolocation results

platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):

6:02 PM Changeset in webkit [41729] by bolsinga@apple.com

2 edits in trunk/WebCore

2009-03-15 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

Update ::toString format as suggested by Darin Adler.

page/Geoposition.cpp: (WebCore::Geoposition::toString):

5:31 PM Changeset in webkit [41728] by Simon Fraser

3 edits in trunk/JavaScriptCore

2009-03-15 Simon Fraser <Simon Fraser>

Revert r41718 because it broke DumpRenderTree on Tiger.

JavaScriptCorePrefix.h:
wtf/Platform.h:

4:55 PM Changeset in webkit [41727] by ddkilzer@apple.com

2 edits in trunk/WebCore

<rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.

Reviewed by Darin Adler.

Yet another case where we would trigger extended encoding loading needlessly.

platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encodingForFormSubmission):

4:41 PM Changeset in webkit [41726] by Simon Fraser

2 edits in trunk/WebCore

2009-03-15 Simon Fraser <Simon Fraser>

Build fix: no review.

rendering/style/ContentData.h:

4:32 PM Changeset in webkit [41725] by ddkilzer@apple.com

9 edits in trunk/WebCore

Bug 24542: Improve ContentData encapsulation

<https://bugs.webkit.org/show_bug.cgi?id=24542>

Reviewed by Simon Fraser.

No tests since there is no change in behavior.

rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): Used getter methods instead of data members on ContentData class. Used isImage() convenience method.
rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent): Ditto.

rendering/style/ContentData.cpp: (WebCore::ContentData::clear): Extracted code into deleteContent() method. (WebCore::ContentData::dataEquivalent): Added. Extracted code from StyleRareNonInheritedData::contentDataEquivalent(). (WebCore::ContentData::deleteContent): Added. Used by setter methods.
rendering/style/ContentData.h: Made m_type, m_content and m_next private. (WebCore::ContentData::isCounter): Added. (WebCore::ContentData::isImage): Added. (WebCore::ContentData::isNone): Added. (WebCore::ContentData::isText): Added. (WebCore::ContentData::type): Added. (WebCore::ContentData::dataEquivalent): Added. (WebCore::ContentData::image): Added. (WebCore::ContentData::setImage): Added. (WebCore::ContentData::text): Added. (WebCore::ContentData::setText): Added. (WebCore::ContentData::counter): Added. (WebCore::ContentData::setCounter): Added. (WebCore::ContentData::next): Added. (WebCore::ContentData::setNext): Added.

rendering/style/CounterContent.h: (WebCore::operator!=): Removed. (WebCore::operator==): Renamed operator!=() and reversed its logic after extracting code from StyleRareNonInheritedData::contentDataEquivalent() to create ContentData::dataEquivalent().

rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setContent): Used new getters and setters on ContentData class. Changed first argument from a StringImpl* to a PassRefPtr<StrimgImpl>. Used isText() convenience method.
rendering/style/RenderStyle.h: (WebCore::RenderStyle::setContent): Updated declaration.
rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Extracted most logic in while() loop into ContentData::dataEquivalent().

3:39 PM Changeset in webkit [41724] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.1.3

Tagging 1.1.3.

3:26 PM Changeset in webkit [41723] by xan@webkit.org

2 edits in trunk

2009-03-15 Xan Lopez <xlopez@igalia.com>

Bump version to 1.1.3 for release and fix soversion
calculation (oops). Thanks to Frederik Himpe for pointing this
out.

configure.ac:

1:15 PM Changeset in webkit [41722] by xan@webkit.org

2 edits in trunk/PlanetWebKit

2009-03-15 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Mark Rowe.

config.ini: fix my blog's feed address.

11:51 AM Changeset in webkit [41721] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.1.2

Tagging 1.1.2.

10:40 AM Changeset in webkit [41720] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-15 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Anders Carlsson.

Fix default policy decision to be ignore, on MIME checks, if
WebKit doesn't know how to handle the MIME type. The documentation
is already correct, and this was an oversight when the policy
decision code was first committed. Since 1.1.2 will be the first
release to support download, there is no practical change in
behavior.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):

10:40 AM Changeset in webkit [41719] by kov@webkit.org

2 edits in trunk/WebCore

2009-03-15 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=24602
[Gtk] Searching in thepiratebay.org doesn't work with more than 1 word

Reintroduce the URI into the soup message after having set it in
the KURL, on redirects, to make sure it is properly encoded. This
fixes bad request problems when servers give bad URIs on their
response's Location header.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):

10:23 AM Changeset in webkit [41718] by kevino@webkit.org

3 edits in trunk/JavaScriptCore

Non-Apple Mac ports build fix. Move defines for the BUILDING_ON_ macros into
Platform.h so that they're defined for all ports building on Mac, and tweak
the definitions of those macros based on Mark Rowe's suggestions to accomodate
cases where the values may not be <= to the .0 release for that version.

8:30 AM Changeset in webkit [41717] by xan@webkit.org

4 edits in trunk

2009-03-15 Xan Lopez <xlopez@igalia.com>

Bump version and libtool version for release.

configure.ac:

WebKit/gtk:

2009-03-15 Xan Lopez <xlopez@igalia.com>

NEWS: update for 1.1.2.

4:26 AM Changeset in webkit [41716] by ap@webkit.org

1 edit in trunk/LayoutTests/editing/selection/5354455-2.html

Committing LayoutTests/editing/selection/5354455-2.html that was supposed to be in previous check-in.

2:22 AM Changeset in webkit [41715] by ap@webkit.org

6 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19737
No cursor and paste not enabled right clicking text field/area

Test: fast/events/right-click-focus.html

page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMousePressEvent): Take normal code path for right clicks (we were taking it for Ctrl-clicks anyway).

1:56 AM Changeset in webkit [41714] by ap@webkit.org

1 edit
2 moves
2 adds in trunk/LayoutTests

Suggested by Mark Rowe.

Move results for security/block-test.html to their correct locations. Results for other
platforms will need to be generated.

platform/mac-leopard/security/block-test-expected.txt: Removed.
platform/mac-tiger/security: Added.
platform/mac-tiger/security/block-test-expected.txt: Copied from LayoutTests/security/block-test-expected.txt.
platform/mac/security: Added.
platform/mac/security/block-test-expected.txt: Copied from LayoutTests/platform/mac-leopard/security/block-test-expected.txt.
security/block-test-expected.txt: Removed.

1:42 AM Changeset in webkit [41713] by ap@webkit.org

5 edits
2 adds in trunk

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=23949
HTMLSelectElement is in inconsistent state when handling mutation events

Test: fast/forms/mutation-event-recalc.html

dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::appendChild): Call childrenChanged() before dispatching modification events, not after.

html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::insertBefore): (WebCore::HTMLOptGroupElement::replaceChild): (WebCore::HTMLOptGroupElement::removeChild): (WebCore::HTMLOptGroupElement::appendChild): (WebCore::HTMLOptGroupElement::removeChildren):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): (WebCore::HTMLSelectElement::remove): (WebCore::HTMLSelectElement::insertBefore): (WebCore::HTMLSelectElement::replaceChild): (WebCore::HTMLSelectElement::removeChild): (WebCore::HTMLSelectElement::appendChild): (WebCore::HTMLSelectElement::removeChildren): Remove calls to recalcSelectOptions(). It is too late to recalc now, after mutation events were already dispatched.

1:23 AM Changeset in webkit [41712] by mitz@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Adele Peterson.

fix <rdar://problem/6607773> WebKit should support the "Default" paragraph writing direction -- or at least validate the menu item appropriately

Made WebHTMLView validate user interface items with the selector
-makeBaseWritingDirectionNatural: by returning NO and, if the item is
a menu item, setting its state to "off".

Strictly speaking, since -makeBaseWritingDirectionNatural: is never
valid for WebViews, WebHTMLView should not need to respond to it and
validate it, however because other responders respond to all three
-makeBaseWritingDirection*: messages and set the menu item state, having
WebHTMLView do the same makes application developers' lives easier.

WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView makeBaseWritingDirectionNatural:]):

1:16 AM Changeset in webkit [41711] by ap@webkit.org

3 edits in trunk/LayoutTests

Add svn:executable property to recently added cgi scripts.

http/tests/xmlhttprequest/resources/access-control-basic-options-not-supported.cgi:
http/tests/xmlhttprequest/resources/access-control-basic-whitelist-request-headers.cgi:

Mar 14, 2009:

8:23 PM Changeset in webkit [41710] by mrowe@apple.com

1 edit
2 adds in trunk/LayoutTests

Skip two tests that are failing.

Rubber-stamped by Dan Bernstein.

platform/mac-snowleopard/Skipped: Added.

7:55 PM Changeset in webkit [41709] by bolsinga@apple.com

2 edits in trunk/WebCore

2009-03-14 Greg Bolsinga <bolsinga@apple.com>

<rdar://problem/6683465>

Geolocation has to be able to handle NULL Frames.

Reviewed by Mark Rowe

6:58 PM Changeset in webkit [41708] by bolsinga@apple.com

2 edits in trunk/WebCore

2009-03-14 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

Geoposition::toString was missing the Coordinates after the update.

page/Geoposition.cpp: (WebCore::Geoposition::toString):

4:44 PM Changeset in webkit [41707] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Mark Rowe.

[Gtk] Build fix - pass a Coordinate to Geoposition::create
https://bugs.webkit.org/show_bug.cgi?id=24603

Gtk build fix per r41650
https://bugs.webkit.org/show_bug.cgi?id=24506
Geolocation in Safari differs from the spec, no Coordinates attribute on Position

Pass a Coordinate to Geoposition::create.

platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::updatePosition):

4:14 PM Changeset in webkit [41706] by jmalonzo@webkit.org

3 edits in trunk/WebKit/gtk

2009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK] use of confirm dialog (yes/no) causes segfault
https://bugs.webkit.org/show_bug.cgi?id=20940

Change the script-confirm marshaller from OBJECT,STRING,BOOLEAN to
OBJECT,STRING,POINTER

webkit/webkitwebview.cpp:
webkitmarshal.list:

3:02 PM Changeset in webkit [41705] by xan@webkit.org

2 edits in trunk/LayoutTests

2009-03-14 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

Remove two now working tests from GTK's Skipped list.

platform/gtk/Skipped:

1:22 PM Changeset in webkit [41704] by xan@webkit.org

2 edits in trunk

2009-03-14 Xan Lopez <xlopez@igalia.com>

No review, build fix.

Split clean rules to make distcheck pass.

GNUmakefile.am:

5:50 AM Changeset in webkit [41703] by mrowe@apple.com

21 edits
20 copies
7 adds in trunk/LayoutTests

Update layout test results to accommodate slight changes in error messages in the latest version of libxml2.

Rubber-stamped by Oliver Hunt.

fast/dom/getElementsByClassName/011-expected.txt:
fast/parser/external-entities-expected.txt:
platform/mac-leopard/fast/dom/getElementsByClassName/011-expected.txt: Copied from LayoutTests/fast/dom/getElementsByClassName/011-expected.txt.
platform/mac-leopard/fast/invalid/missing-end-tag-expected.checksum: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.checksum.
platform/mac-leopard/fast/invalid/missing-end-tag-expected.png: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.png.
platform/mac-leopard/fast/invalid/missing-end-tag-expected.txt: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.txt.
platform/mac-leopard/fast/parser/external-entities-expected.txt: Copied from LayoutTests/fast/parser/external-entities-expected.txt.
platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.checksum: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum.
platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.png: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.png.
platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.txt.
platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.checksum: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum.
platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png.
platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt.
platform/mac-leopard/svg/custom/junk-data-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.checksum.
platform/mac-leopard/svg/custom/junk-data-expected.png: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.png.
platform/mac-leopard/svg/custom/junk-data-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.txt.
platform/mac-leopard/svg/custom/missing-xlink-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.checksum.
platform/mac-leopard/svg/custom/missing-xlink-expected.png: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.png.
platform/mac-leopard/svg/custom/missing-xlink-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.txt.
platform/mac-leopard/svg/hixie/error/012-expected.checksum: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.checksum.
platform/mac-leopard/svg/hixie/error/012-expected.png: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.png.
platform/mac-leopard/svg/hixie/error/012-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.txt.
platform/mac/fast/invalid/missing-end-tag-expected.checksum:
platform/mac/fast/invalid/missing-end-tag-expected.png:
platform/mac/fast/invalid/missing-end-tag-expected.txt:
platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum:
platform/mac/fast/parser/xhtml-alternate-entities-expected.png:
platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum:
platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png:
platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
platform/mac/svg/custom/junk-data-expected.checksum:
platform/mac/svg/custom/junk-data-expected.png:
platform/mac/svg/custom/junk-data-expected.txt:
platform/mac/svg/custom/missing-xlink-expected.checksum:
platform/mac/svg/custom/missing-xlink-expected.png:
platform/mac/svg/custom/missing-xlink-expected.txt:
platform/mac/svg/hixie/error/012-expected.checksum:
platform/mac/svg/hixie/error/012-expected.png:
platform/mac/svg/hixie/error/012-expected.txt:

5:19 AM Changeset in webkit [41702] by mrowe@apple.com

8 edits
25 copies
8 moves
5 adds
1 delete in trunk

Change the layout test result search policy for Mac OS X to fit better with the idea of
newer OS versions improving on previous OS versions.

Reviewed by Dan Bernstein.

The results for the latest version of Mac OS X are placed in the "mac" directory. The
results for older versions of Mac OS X are structured as a series of overlays. When
running on Leopard, the results in "mac-leopard" are searched before those in "mac".
When running on Tiger, the results in "mac-tiger" are searched before those in
"mac-leopard" and "mac".

Scripts/run-webkit-tests:

5:02 AM Changeset in webkit [41701] by ap@webkit.org

3 edits
6 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24545
Make cross-site XHR simple request definition match current spec draft

Tests: http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type.html

http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html

loader/CrossOriginAccessControl.cpp: (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Added Content-Language. (WebCore::isSimpleCrossOriginAccessRequest): Added HEAD. Restricted content types to those that could be sent via form submission.

4:56 AM Changeset in webkit [41700] by ap@webkit.org

3 edits
4 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=15172
object fallback - empty string for first argument of setAttributeNS does not work like null

https://bugs.webkit.org/show_bug.cgi?id=24548
createElementNS("", name) should create an element in null namespace

Tests: fast/dom/createElementNS-empty-namespace.html

fast/dom/setAttributeNS-empty-namespace.html

dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): Convert empty namespaces to null.

4:54 AM Changeset in webkit [41699] by xan@webkit.org

2 edits in trunk/PlanetWebKit

2009-03-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24591
Add my blog to Planet WebKit

Add my blog to the planet.

config.ini:

Mar 13, 2009:

11:17 PM Changeset in webkit [41698] by mrowe@apple.com

10 edits in trunk

Take advantage of the ability of recent versions of Xcode to easily switch the active
architecture.

Rubber-stamped by Dan Bernstein.

Configurations/DebugRelease.xcconfig:

11:17 PM Changeset in webkit [41697] by mrowe@apple.com

4 edits in trunk

Remove rarely used Makefile targets from the Makefile.

There are many situations in which the targets don't work as expected,
and their primary use is addressed by having the build system default
to building the appropriate architecture.

11:17 PM Changeset in webkit [41696] by mrowe@apple.com

8 edits in trunk/WebKitTools

Remove the --64-bit argument from scripts in favor of them detecting when 64-bit should be preferred.

Reviewed by Timothy Hatcher.

The scripts will automatically target 64-bit if the system and hardware support it. This can be
overridden by passing --32-bit to individual scripts, or using set-webkit-configuration --32-bit
to make the override persistent.

Scripts/build-webkit: Remove architecture-related code.
Scripts/gdb-safari: Remove architecture-related code, and clean up how the environment variables are passed to gdb.
Scripts/run-javascriptcore-tests: Remove architecture-related code.
Scripts/run-safari: Ditto.
Scripts/run-webkit-tests: Ditto.
Scripts/set-webkit-configuration: Handle the --32-bit and --64-bit arguments. The --32-bit argument will set the

architecture preference to the 32-bit architecture of the machine. The --64-bit argument will remove any architecture
override that is in effect so that 64-bit support will be automatically detected.

Scripts/webkitdirs.pm: Add auto-detection of the best architecture for the machine, and the ability to override the

auto-detection.

11:17 PM Changeset in webkit [41695] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Prevent AllInOneFile.cpp and ProfileGenerator.cpp from rebuilding unnecessarily when
switching between building in Xcode and via build-webkit.

Reviewed by David Kilzer.

build-webkit passes FEATURE_DEFINES to xcodebuild, resulting in it being present in the
Derived Sources build settings. When building in Xcode, this setting isn't present so
Xcode reruns the script build phases. This results in a new version of TracingDtrace.h
being generated, and the files that include it being rebuilt.

JavaScriptCore.xcodeproj/project.pbxproj: Don't regenerate TracingDtrace.h if it is

already newer than the input file.

5:53 PM Changeset in webkit [41694] by dimich@chromium.org

2 edits in trunk/WebCore

2009-03-13 John Abd-El-Malek <jam@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24593
Added requestorID so we can track the request to its WebView without using frame (which was removed).

platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::requestorID): (WebCore::ResourceRequest::setRequestorID): (WebCore::ResourceRequest::setTargetType): (WebCore::ResourceRequest::policyURL): (WebCore::ResourceRequest::setPolicyURL): (WebCore::ResourceRequest::requestorPid): (WebCore::ResourceRequest::setRequestorPid):

4:07 PM Changeset in webkit [41693] by Dimitri Glazkov

1 edit
2 adds in trunk/WebCore

2009-03-13 Mike Belshe <mike@belshe.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24561
Add custom V8 bindings for HTMLElementCanvas, Location.

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Added.
bindings/v8/custom/V8LocationCustom.cpp: Added.

3:47 PM Changeset in webkit [41692] by eric@webkit.org

5 edits in trunk/WebCore

2009-03-13 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24584

Fix transparent text rendering on Chromium. FontChromiumWin
was calling beginTransparencyLayer()/endTransparencyLayer(), with
a TransparencyWin inside to do GDI ClearType rendering over an
opaque background. TransparencyWin does its special sauce
in the destructor, but it was being called too late to be used
correctly in the layer. Put the special sauce into a new function,
composite(), and call that explicitly instead.

platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::~TransparencyWin): (WebCore::TransparencyWin::composite): (WebCore::TransparencyWin::init):
platform/graphics/chromium/TransparencyWin.h:
rendering/RenderThemeChromiumWin.cpp: (WebCore::):

3:46 PM Changeset in webkit [41691] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-13 Mike Belshe <mike@belshe.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24562
Add custom implementation for getCSSCanvasContext to V8 bindings.

bindings/v8/custom/V8DocumentCustom.cpp: Added new method.

3:43 PM Changeset in webkit [41690] by eric@webkit.org

1 edit
8 adds in trunk/LayoutTests

2009-03-13 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Add tests for various types of textareas. Tests in both
quirks and standards modes. Although only the standards
modes tests fit in the pixel results.
https://bugs.webkit.org/show_bug.cgi?id=24370

fast/forms/basic-textareas.html: Added.
platform/mac/fast/forms/basic-textareas-expected.checksum: Added.
platform/mac/fast/forms/basic-textareas-expected.png: Added.
platform/mac/fast/forms/basic-textareas-expected.txt: Added.

3:42 PM Changeset in webkit [41689] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-13 Mike Belshe <mike@belse.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24580
Fix query() to match KURL behavior.

platform/KURLGoogle.cpp: (WebCore::KURL::query): remove extra logic around question mark.

3:32 PM Changeset in webkit [41688] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker and Geoffrey Garen.

<rdar://problem/6590384>
REGRESSION (Safari 3-4): Tiger-only Crash occurs at WebView hostWindow () after reloading a set of tabs then quitting

When we're doing fast teardown, plug-in views can be destroyed from -[WebView dealloc]'s [super dealloc] call,
and thus calling -[WebView hostWindow] will crash since _private is nil.

WebView/WebView.mm: (-[WebView hostWindow]):

3:20 PM Changeset in webkit [41687] by Chris Fleizach

3 edits
2 adds in trunk

Bug 24474: AX: in multi-body tables, asking for a cell at a specific coordinate can return nil
https://bugs.webkit.org/show_bug.cgi?id=24474

3:01 PM WebKit Team edited by ojan@chromium.org

(diff)

3:00 PM Changeset in webkit [41686] by dimich@chromium.org

4 edits in trunk/WebCore

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24589
Upstream changes to V8 event listeners (Chromium r11133) in order to
fix worker functionality break in Chromium.

bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): (WebCore::V8AbstractEventListener::handleEvent):
bindings/v8/V8AbstractEventListener.h:
bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent):

2:53 PM WebKit Team edited by Dimitri Glazkov

Ego-tuning. (diff)

2:52 PM Changeset in webkit [41685] by dimich@chromium.org

2 edits in trunk/JavaScriptCore

2009-03-13 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

Resolved name conflict with globally defined tzname in Symbian.
Replaced with different name instead of using namespace qualifier
(appeared to be less clumsy).

runtime/DateMath.cpp:

2:48 PM WebKit Team edited by pam@chromium.org

(diff)

2:45 PM WebKit Team edited by abarth@webkit.org

(diff)

2:31 PM Changeset in webkit [41684] by Dimitri Glazkov

11 edits
5 copies
1 add in trunk/WebCore

2009-03-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24524
Introduce ScriptObject and ScriptFunctionCall abstractions.

GNUmakefile.am: Added ScriptObject and ScriptFunctionCall to project.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
WebCoreSources.bkl: Ditto.
bindings/js/ScriptFunctionCall.cpp: Added.
bindings/js/ScriptFunctionCall.h: Added.
bindings/js/ScriptObject.cpp: Added.
bindings/js/ScriptObject.h: Added.
bindings/js/ScriptObjectQuarantine.cpp: Added.
bindings/js/ScriptObjectQuarantine.h: Added.
inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): Changed to use InspectorDatabaseResource::bind. (WebCore::InspectorController::resetScriptObjects): Changed to use InspectorDatabaseResource::unbind. (WebCore::InspectorController::didOpenDatabase): Changed to use InspectorDatabaseResource::unbind.
inspector/InspectorController.h: Removed addScriptDatabaseResource and removeScriptDatabaseResource declarations.
inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind): Added. (WebCore::InspectorDatabaseResource::unbind): Added.
inspector/InspectorDatabaseResource.h: Added bind and unbind declarations.

2:26 PM Changeset in webkit [41683] by pkasting@chromium.org

4 edits in trunk/WebCore

2009-03-13 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24467
Make Skia drawRect() and stroke behavior match CG.

This makes drawRect() ignore the stroke width (like CG does), and
adds a warning comment about that to the appropriate header.

It also eliminates some hacky code in Skia's stroke preparation,
which tried to adjust odd-width strokes to fall on pixel boundaries.
Not only did this not match CG, it wouldn't necessarily work right,
because there could be other transforms (e.g. full-page zoom) that
would affect the stroke before it reached the device pixel level.

platform/graphics/GraphicsContext.h:
platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillRect):
platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::drawRect): (PlatformContextSkia::setupPaintForStroking):

1:45 PM Changeset in webkit [41682] by dimich@chromium.org

2 edits in trunk/WebCore

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24583
Need to change scope of constructor and destructor of V8ObjectEventListener from private
to protected so that they could be used in its derived class V8WorkerContextEventListener.

bindings/v8/V8ObjectEventListener.h:

12:53 PM Changeset in webkit [41681] by andersca@apple.com

3 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <andersca@apple.com>

And yet another attempt...

Plugins/WebNetscapePluginEventHandlerCocoa.h: (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler):
Plugins/WebNetscapePluginEventHandlerCocoa.mm:

12:52 PM Changeset in webkit [41680] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <andersca@apple.com>

Another attempt at fixing the build.

Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):

12:39 PM Changeset in webkit [41679] by andersca@apple.com

3 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <andersca@apple.com>

Try to fix the SL build.

Plugins/WebNetscapePluginEventHandlerCocoa.h:
Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::keyDown):

12:13 PM Changeset in webkit [41678] by levin@chromium.org

1 edit
8 moves in trunk/WebCore

2009-03-13 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24579
Many V8*Event* files are misplaced.

This code is infrastructure for supporting the bindings and thus should
be in the bindings/v8 directory.

bindings/v8/V8AbstractEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.cpp.
bindings/v8/V8AbstractEventListener.h: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.h.
bindings/v8/V8LazyEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.cpp.
bindings/v8/V8LazyEventListener.h: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.h.
bindings/v8/V8ObjectEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.cpp.
bindings/v8/V8ObjectEventListener.h: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.h.
bindings/v8/V8WorkerContextEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.cpp.
bindings/v8/V8WorkerContextEventListener.h: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.h.

12:06 PM Changeset in webkit [41677] by adele@apple.com

9 edits
4 adds in trunk

WebCore:

2009-03-13 Adele Peterson <adele@apple.com>

Reviewed by Justin Garcia.

Fix for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content

Test: editing/pasteboard/5089327.html

Handle spans being pasted within a quoted region in the same way we handle "paste as quotation" content.

editing/ReplaceSelectionCommand.cpp: (WebCore::handleStyleSpansBeforeInsertion): (WebCore::ReplaceSelectionCommand::handleStyleSpans):

LayoutTests:

2009-03-13 Adele Peterson <adele@apple.com>

Reviewed by Justin Garcia.

Tests for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content

editing/pasteboard/5089327.html: Added.
platform/mac/editing/pasteboard/5089327-expected.checksum: Added.
platform/mac/editing/pasteboard/5089327-expected.png: Added.
platform/mac/editing/pasteboard/5089327-expected.txt: Added.

Updated colors for pasted content.

platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.checksum:
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.checksum:
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.png:

11:57 AM Changeset in webkit [41676] by andersca@apple.com

2 edits in trunk/WebKitExamplePlugins

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Update to match new API.

NetscapeInputMethodPlugin/main.m: (NPP_New): (NPP_Destroy): (NPP_SetWindow): (handleDraw): (invalidatePlugin): (handleFocusChanged): (handleMouseMoved): (handleMouseDown): (handleTextFieldKeyDown): (handleTextInput): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):

11:56 AM Changeset in webkit [41675] by bolsinga@apple.com

14 edits
3 adds in trunk

2009-03-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=24505

WebGeolocation is a wrapper around WebCore::Geolocation. It mimics the
coding style set by WebSecurityOrigin.

WebChromeClient now calls the private UI delegate method
-webView:frame:requestGeolocationPermission:securityOrigin:

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestGeolocationPermissionForFrame):
WebCoreSupport/WebGeolocation.mm: Added. (WebCore::if): (-[WebGeolocation shouldClearCache]): (-[WebGeolocation setIsAllowed:]): (-[WebGeolocation dealloc]):
WebCoreSupport/WebGeolocationInternal.h: Added.
WebCoreSupport/WebGeolocationPrivate.h: Added.
WebView/WebUIDelegatePrivate.h:

2009-03-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=24505

Add WebGeolocation, a wrapper around WebCore::Geolocation. It mimics the
coding style set by WebSecurityOrigin.

WebKit.xcodeproj/project.pbxproj:

2009-03-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=24505

Geolocation now requests permission from the Chrome asynchronously.
The Chrome is passed the Geolocation object, and the Chrome sets the permission
on the Geolocation. Geolocation also tracks if the Chrome should clear its cache
of SecurityOrigins with geolocation permission. This is so that the GeolocationService
can inform the Chrome of its request, and the Chrome is also free to implement its
own policy.

WebCore.base.exp:
WebCore.xcodeproj/project.pbxproj:
page/Chrome.cpp: (WebCore::Chrome::requestGeolocationPermissionForFrame):
page/Chrome.h:
page/ChromeClient.h: (WebCore::ChromeClient::requestGeolocationPermissionForFrame):
page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::displayChallengeIfNecessary): (WebCore::Geolocation::geolocationServicePositionChanged):
page/Geolocation.h: (WebCore::Geolocation::isAllowed): (WebCore::Geolocation::setShouldClearCache): (WebCore::Geolocation::shouldClearCache): (WebCore::Geolocation::):

11:44 AM Changeset in webkit [41674] by andersca@apple.com

12 edits
1 delete in trunk

WebCore:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API

Add a NPCocoaEventTextInput event type. Remove the text input variables.

bridge/npapi.h: (_NPCocoaEvent::):

WebKit:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API

Remove nptextinput.h

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API

Replace the text input API with a simpler API that uses a separate text input window.

Plugins/WebNetscapePluginEventHandlerCocoa.h:
Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa): Initialize m_keyEventHandler to 0.

(WebNetscapePluginEventHandlerCocoa::keyDown):
If the plug-in returns 0 from NPP_HandleEvent, pass the event to the TSM machinery.

(WebNetscapePluginEventHandlerCocoa::focusChanged):
Install/remove the key event handler as needed.

(WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
Get the text and send a TextInput event.

Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: Remove the old text input API.

(-[WebNetscapePluginView inputContext]):
Always return nil here.

Plugins/npapi.mm:
Plugins/nptextinput.h: Removed.

WebKitTools:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API

Add a case statement for NPCocoaEventTextInput.

DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (handleEventCocoa):

11:18 AM Changeset in webkit [41673] by kdecker@apple.com

2 edits in trunk/WebCore

Reviewed by Anders.

<rdar://problem/6630340> REGRESSION (39114-39115): Unity Web Player no longer works if Flip4Mac is also installed

The code assumed if we have a plug-in that supports "application/x-oleobject" we should always prefer the object tag
over of an embed tag. That assumption can cause the Mac platform to load the wrong plug-in, as Flip4Mac claims supports
for x-oleobject.

rendering/RenderPartObject.cpp: (WebCore::shouldUseEmbedDescendant): Made the Mac platform always return true here.

10:57 AM WebKit Team edited by abarth@webkit.org

(diff)

10:47 AM WebKit Team edited by dimich@chromium.org

(diff)

10:45 AM Changeset in webkit [41672] by pam@chromium.org

2 edits
3 adds in trunk/LayoutTests

2009-03-13 Pamela Greene <pam@chromium.org>

Reviewed by Darin Fisher.

Add tests for window property lookup precedence in the presence of
conflicting names in a child frame and in a named document element.

https://bugs.webkit.org/show_bug.cgi?id=24170

fast/dom/Window/resources/window-properties.js: Added.
fast/dom/Window/window-lookup-precedence-expected.txt: Added.
fast/dom/Window/window-lookup-precedence.html: Added.
fast/js/resources/js-test-pre.js: (shouldEvaluateTo): Added. Compares expected values of various types.

10:32 AM Changeset in webkit [41671] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24559
Need to port JSC fix (r41565) to V8 in order to fix layout test onload-single-line-comment.html.

bindings/v8/custom/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):

10:32 AM Changeset in webkit [41670] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24557
This is to support running multiple workers in a single worker process in chromium.

bindings/v8/custom/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent): Add locker to v8 event listener of worker context.

10:09 AM Changeset in webkit [41669] by pam@chromium.org

3 edits in trunk/LayoutTests

2009-03-13 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test cases to ensure that DOM constructors have higher lookup
precedence than a document element with the same name.

https://bugs.webkit.org/show_bug.cgi?id=24520

fast/dom/dom-constructors-expected.txt:
fast/dom/dom-constructors.html:

9:52 AM WebKit Team edited by pam@chromium.org

(diff)

9:20 AM Changeset in webkit [41668] by pam@chromium.org

1 edit
3 adds in trunk/LayoutTests

2009-03-13 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add a test to check that the JS wrapper for the document in an
inner frame is created in the correct context when it's accessed
from the outer frame first.

https://bugs.webkit.org/show_bug.cgi?id=24564

fast/dom/resources/wrapper-context-inner.html: Added.
fast/dom/wrapper-context-expected.txt: Added.
fast/dom/wrapper-context.html: Added.

9:11 AM WebKit Team edited by treat@kde.org

Update with new reviewers and affiliations (diff)

6:25 AM Changeset in webkit [41667] by ap@webkit.org

3 edits
6 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24575
XHR response is incorrect after a network error.

Tests: http/tests/xmlhttprequest/cross-site-denied-response-sync-2.html

http/tests/xmlhttprequest/cross-site-denied-response-sync.html
http/tests/xmlhttprequest/cross-site-denied-response.html

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::networkError): Call internalAbort() to fully reset the request. (WebCore::XMLHttpRequest::didFailRedirectCheck): No need to call internalAbort() here. Note that since internalAbort() can drop GC protection, it is not safe to use the object after this call. (WebCore::XMLHttpRequest::didReceiveData): Check that the request wasn't aborted, and return early if it was. This can happen during sync requests, as the loader does not know that it was aborted, and just synthesizes all callbacks.

5:57 AM Changeset in webkit [41666] by ap@webkit.org

2 edits in trunk/LayoutTests

Updating results after the fix for bug 3547.

fast/loader/xmlhttprequest-missing-file-exception-expected.txt: The status text for a failed local file load is no longer "OK", which is good.

4:06 AM Changeset in webkit [41665] by ap@webkit.org

5 edits
4 adds in trunk

2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=3547
XMLHttpRequest.statusText returns always "OK"

Covered by existing tests (which now pass on all platforms but Mac).

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::statusText): Return ResourceResponse status text. It is now up to each platform to correctly set the status text or set it to "OK" to retain current behavior.

3:05 AM Changeset in webkit [41664] by ap@webkit.org

2 edits in trunk/WebCore

2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24349
[QT] HTTP status text is never set

Set HTTP status text to the reason phrase attribute of QNetworkReply.

platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

Mar 12, 2009:

11:23 PM Changeset in webkit [41663] by mitz@apple.com

2 edits in trunk/LayoutTests

Skipped file fix

platform/mac-tiger/Skipped:

11:07 PM Changeset in webkit [41662] by Simon Fraser

2 edits in trunk/WebCore

2009-03-12 Simon Fraser <Simon Fraser>

Reviewed by Mark Rowe

<rdar://problem/6622300>: Reproducible crash on
<http://www.editgrid.com/explore/tnc/dave/FusionChart%3A_Candlestick>

Prevent CSSStyleSheet::checkLoaded() writing to freed memory when it gets
deleted from under itself. The sheetLoaded() notification can allow scripts
to run via HTMLTokenizer::executeScriptsWaitingForStylesheets(),
which can cause the last ref to the CSSStyleSheet to be released.

css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):

10:28 PM Changeset in webkit [41661] by kevino@webkit.org

4 edits in trunk

wx build fix. Let DerivedSources.make know we want database APIs.

8:33 PM Changeset in webkit [41660] by mrowe@apple.com

5 edits in trunk/JavaScriptCore

<rdar://problem/6548446> TCMalloc_SystemRelease should use madvise rather than re-mmaping span of pages

wtf/FastMalloc.cpp:

(WTF::mergeDecommittedStates): If either of the spans has been released to the system, release the other
span as well so that the flag in the merged span is accurate.

wtf/Platform.h:
wtf/TCSystemAlloc.cpp: Track decommitted spans when using MADV_FREE_REUSABLE / MADV_FREE_REUSE.

(TCMalloc_SystemRelease): Use madvise with MADV_FREE_REUSABLE when it is available.
(TCMalloc_SystemCommit): Use madvise with MADV_FREE_REUSE when it is available.

wtf/TCSystemAlloc.h:

8:10 PM Changeset in webkit [41659] by treat@webkit.org

2 edits in trunk/WebCore

2009-03-12 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=24498
Fix the Qt port to use the same algorithm for drawing dashed and dotted
borders as the other ports. This makes the Qt port pixel-for-pixel perfect
compared to border drawing with Apple's canonical mac port and much closer
to konqueror and firefox behavior.

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine):

5:15 PM Changeset in webkit [41658] by mitz@apple.com

2 edits in trunk/LayoutTests

Reviewed by Anders Carlsson.

skip editing/selection/word-thai.html on Tiger because it has an older version of Unicode.

platform/mac-tiger/Skipped:

4:05 PM Changeset in webkit [41657] by eric@webkit.org

5 edits in trunk

Reviewed by Justin Garcia.

Clean up DOMSelection to use some helper functions
making the code smaller, and less error-prone.
https://bugs.webkit.org/show_bug.cgi?id=19221

I tried moving DOMSelection off of rangeCompliantEquivalent
but failed. VisibleSelection holds positions like (table, 1) to mean
"after the table".

page/DOMSelection.cpp: (WebCore::DOMSelection::visibleSelection): (WebCore::anchorPosition): (WebCore::focusPosition): (WebCore::basePosition): (WebCore::extentPosition): (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::extentOffset):
page/DOMSelection.h:

3:47 PM Changeset in webkit [41656] by dimich@chromium.org

2 edits in trunk/WebCore

2009-03-12 Dmitry Titov <dimich@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24563
Change ResourceRequest to be a struct rather then a class to match other declarations.

platform/network/chromium/ResourceRequest.h:

3:15 PM Changeset in webkit [41655] by andersca@apple.com

1 edit in trunk/WebKit/mac/ChangeLog

Add Mark.

3:13 PM Changeset in webkit [41654] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Mike Thole.

Fix <rdar://problem/6624105>.

Make sure to process incoming messages for the NSEventTrackingRunLoopMode as well.

Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):

3:05 PM Changeset in webkit [41653] by levin@chromium.org

2 edits in trunk/LayoutTests

2009-03-12 Aaron Boodman <aa@chromium.org>

Reviewed by Dave Hyatt.

Bug 16348: @font-face does not affect the default style
<https://bugs.webkit.org/show_bug.cgi?id=16348>

fast/css/font-face-default-font.html: Handle the default font being either 'Times' or 'Times New Roman'.

3:05 PM Changeset in webkit [41652] by levin@chromium.org

4 edits
1 copy in trunk/WebCore

2009-03-12 David Levin <levin@chromium.org>

Reviewed by Darin Fisher.

Bug 24530: width100percent-searchfield.html should be fixed for chromium.
<https://bugs.webkit.org/show_bug.cgi?id=24530>

Compensate for r39924 in chromium, which broke LayoutTests/fast/replaced/width100percent-searchfield.html

css/themeChromiumWin.css: Added. Overrides the changes to start supporting input[type="search"] on Windows (since Chromium doesn't do anything special for this).

rendering/RenderThemeChromiumWin.cpp: (WebCore::supportsFocus): (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumWin::determineState): (WebCore::RenderThemeChromiumWin::getThemeData):

3:01 PM Changeset in webkit [41651] by pam@chromium.org

1 edit
2 adds in trunk/LayoutTests

2009-03-12 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add a test to check that an invalid second argument of
window.postMessage is ignored. Note that this is probably not the
correct behavior according to the HTML5 spec, so this test will
need to be changed once we support that.

https://bugs.webkit.org/show_bug.cgi?id=24523

fast/dom/Window/window-postmessage-args-expected.txt: Added.
fast/dom/Window/window-postmessage-args.html: Added.

2:21 PM Changeset in webkit [41650] by bolsinga@apple.com

14 edits
3 adds in trunk/WebCore

2009-03-12 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=24506
Geolocation in Safari differs from the spec, no Coordinates attribute on Position

Get up to date.

DerivedSources.make:
GNUmakefile.am:
WebCore.pro:
WebCore.scons:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionOptions):
page/Coordinates.cpp: Added. (WebCore::Coordinates::toString):
page/Coordinates.h: Added. (WebCore::Coordinates::create): (WebCore::Coordinates::latitude): (WebCore::Coordinates::longitude): (WebCore::Coordinates::altitude): (WebCore::Coordinates::accuracy): (WebCore::Coordinates::altitudeAccuracy): (WebCore::Coordinates::heading): (WebCore::Coordinates::speed): (WebCore::Coordinates::Coordinates):
page/Coordinates.idl: Added.
page/Geoposition.cpp: (WebCore::Geoposition::toString):
page/Geoposition.h: (WebCore::Geoposition::create): (WebCore::Geoposition::coords): (WebCore::Geoposition::Geoposition):
page/Geoposition.idl:
page/PositionOptions.h: (WebCore::PositionOptions::create): (WebCore::PositionOptions::maximumAge): (WebCore::PositionOptions::setMaximumAge): (WebCore::PositionOptions::PositionOptions):
platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):

2:10 PM Changeset in webkit [41649] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-03-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24496
Fix console logging of non-string values by coercing the argument to
a string, for V8 bindings.

Test: fast/js/console-non-string-values.html

bindings/v8/ScriptValue.cpp: Added toString method. (WebCore::ScriptValue::toString):
bindings/v8/ScriptValue.h: Added PlatformString, ScriptState includes

and toString declaration.

2:08 PM Changeset in webkit [41648] by darin@chromium.org

2 edits in trunk/WebCore

2009-03-12 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Eliminate ChromiumBridge::uiResourceProtocol
https://bugs.webkit.org/show_bug.cgi?id=24558

platform/chromium/ChromiumBridge.h:

1:44 PM Changeset in webkit [41647] by bolsinga@apple.com

2 edits in trunk/WebCore

2009-03-12 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Missing breaks in switch statement
https://bugs.webkit.org/show_bug.cgi?id=24556

platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):

1:39 PM Changeset in webkit [41646] by darin@chromium.org

2 edits in trunk/WebCore

2009-03-12 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24554
Remove some unused functions from ChromiumBridge.

platform/chromium/ChromiumBridge.h:

1:29 PM Changeset in webkit [41645] by eric@webkit.org

4 edits
2 adds in trunk

Reviewed by Darin Fisher and Justin Garcia.

Safari crashes during drag and drop in Google presentations
due to mutation event handlers removing DOM content during insertNode
https://bugs.webkit.org/show_bug.cgi?id=22634

Added a bunch of "null" checks to make sure nodes are still
in the document before we operate on them. This is an
inelegant solution, but it's the best we have for now.

Test: editing/selection/crash-on-drag-with-mutation-events.html

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):

1:11 PM Changeset in webkit [41644] by Simon Fraser

3 edits
4 adds in trunk

2009-03-12 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=24508

Fix updating of text field with placeholder text when value is set
by ensuring that updatePlaceholderVisibility() is called after
the value has been updated, not before.

Test: fast/forms/placeholder-set-value.html

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue):

12:52 PM Changeset in webkit [41643] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=24525
REGRESSION: Inspector window doesn't close when inspected page is
destroyed. This is a revert of r41158, which became unnecessary when
InspectorController became ref-counted in r41462.

inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): Reset m_inspectedPage

after calling close().

(WebCore::InspectorController::stopUserInitiatedProfiling): Remove

m_inspectedPage check guard around profile logic.

12:41 PM Changeset in webkit [41642] by pkasting@chromium.org

6 edits in trunk

WebCore:

2009-03-12 Peter Kasting <pkasting@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24502
Make horizontal scrolling on Windows always go the correct direction.

platform/PlatformWheelEvent.h:
platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/win:

2009-03-12 Peter Kasting <pkasting@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24502
Make horizontal scrolling on Windows always go the correct direction.

WebView.cpp: (WebView::mouseWheel): (WebViewWndProc):
WebView.h:

12:36 PM Changeset in webkit [41641] by andersca@apple.com

3 edits in trunk/WebKit/mac

2009-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

WebKit side of <rdar://problem/6607801>

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy): Pass a requestID to _WKPCDestroyPluginInstance and wait until we get a reply back.

Plugins/Hosted/WebKitPluginHost.defs: Add requestID parameter.

12:34 PM Changeset in webkit [41640] by Dimitri Glazkov

5 edits
2 adds in trunk

WebCore:

2009-03-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24496
Fix console logging of non-string values by coercing the argument to
a string.

Test: fast/js/console-non-string-values.html

bindings/js/ScriptValue.cpp: Removed PlatformString include.
bindings/js/ScriptValue.h: Added toString method. (WebCore::ScriptValue::toString):
page/Console.cpp: (WebCore::getFirstArgumentAsString): Changed firstArgumentAsString method to use

ScriptValue::toString.

(WebCore::Console::addMessage): added extra ScriptState argument to callsite.
(WebCore::Console::count): Ditto.

LayoutTests:

2009-03-12 Simon Fraser <Simon Fraser>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24496
Test for logging non-string values.

fast/js/console-non-string-values-expected.txt: Added.
fast/js/console-non-string-values.html: Added.

12:32 PM Changeset in webkit [41639] by kov@webkit.org

3 edits in trunk/WebKit/gtk

2009-03-12 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24553
[GTK] Improvements to WebKitDownload

Rename 'state' to 'status' to match the naming in the frame
loader rework that we plan to land soonish, and make it a
property, for the same reason.

webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::): (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_get_property): (_WebKitDownloadPrivate::webkit_download_set_property): (_WebKitDownloadPrivate::webkit_download_class_init): (_WebKitDownloadPrivate::webkit_download_init): (_WebKitDownloadPrivate::webkit_download_start): (_WebKitDownloadPrivate::webkit_download_cancel): (_WebKitDownloadPrivate::webkit_download_set_destination_uri): (_WebKitDownloadPrivate::webkit_download_get_status): (_WebKitDownloadPrivate::webkit_download_set_status): (_WebKitDownloadPrivate::webkit_download_received_data): (_WebKitDownloadPrivate::webkit_download_finished_loading): (_WebKitDownloadPrivate::webkit_download_error):
webkit/webkitdownload.h:

12:32 PM Changeset in webkit [41638] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-12 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24553
[GTK] Improvements to WebKitDownload

Improved documentation for the download-requested signal, to make
its usage clear.

webkit/webkitwebview.cpp:

12:27 PM Changeset in webkit [41637] by Simon Fraser

3 edits
4 adds in trunk

2009-03-12 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24552

Hit testing involving normal flow, self-painting layers (e.g. reflections)
was broken because it was not null-testing the result of hitTestLayer(),
so bailing early with a nil hit layer.

Test: fast/layers/normal-flow-hit-test.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):

11:33 AM Changeset in webkit [41636] by pam@chromium.org

3 edits in trunk/LayoutTests

2009-03-12 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test cases to make sure window.location and window.navigator
have higher lookup precedence than a DOM element with that ID.

https://bugs.webkit.org/show_bug.cgi?id=24522

fast/dom/Window/window-special-properties-expected.txt:
fast/dom/Window/window-special-properties.html:

11:30 AM Changeset in webkit [41635] by kdecker@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _unloadWithShutdown:]): Simply a small SUPPORT_CFM code block.

11:20 AM Changeset in webkit [41634] by kdecker@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

Fixed: <rdar://problem/5815862> Opening a subclassed NSWindow from a Safari plugin causes Safari to crash on Quit

This fix addresses crashes in both Silverlight and ChemDraw. This type of crash would occur because AppKit still
had a reference to open windows that the plugin created (which no longer exist).

Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _unloadWithShutdown:]): Do not unload the plug-in bundle on browser shutdown.

11:08 AM Changeset in webkit [41633] by Dimitri Glazkov

1 edit
2 deletes in trunk/WebCore

2009-03-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Cameron Zwarich.

Removed zero-sized files, left over from improperly applied patch.

platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Removed.
platform/graphics/chromium/ThemeHelperChromiumWin.h: Removed.

11:04 AM Changeset in webkit [41632] by treat@webkit.org

2 edits in trunk/JavaScriptCore

2009-03-12 Adam Treat <adam.treat@torchmobile.com>

Reviewed by NOBODY (Build fix).

Include string.h for strlen usage.

wtf/Threading.cpp:

10:24 AM Changeset in webkit [41631] by pam@chromium.org

1 edit
2 adds in trunk/LayoutTests

2009-03-12 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Add a test to make sure GC doesn't drop XHR wrappers too soon.
https://bugs.webkit.org/show_bug.cgi?id=24528

fast/dom/xmlhttprequest-gc-expected.txt: Added.
fast/dom/xmlhttprequest-gc.html: Added.

9:35 AM Changeset in webkit [41630] by treat@webkit.org

2 edits in trunk/WebCore

2009-03-12 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

Do not ignore alpha color in optimization. Hard to believe, but there
are websites that fill the entire page with a tiled image consisting of
nothing but a 100% transparent 1x1 image. <cough>orbitz.com</cough>

platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):

9:22 AM Changeset in webkit [41629] by Adam Roben

2 edits in trunk/WebKit/win

Implement DOMHTMLDocument::title

Reviewed by Dan Bernstein.

DOMHTMLClasses.cpp: (DOMHTMLDocument::title): Call through to WebCore::Document (with obligatory COM error checking/type conversions).

8:28 AM Changeset in webkit [41628] by ddkilzer@apple.com

1 edit in trunk/WebKitTools/ChangeLog

Fixed ChangeLog date.

8:26 AM Changeset in webkit [41627] by ddkilzer@apple.com

2 edits in trunk/JavaScriptCore

Add NO_RETURN attribute to runInteractive() when not using readline

Reviewed by Darin Adler.

jsc.cpp: (runInteractive): If the readline library is not used, this method will never return, thus the NO_RETURN attribute is needed to prevent a gcc warning.

8:01 AM Changeset in webkit [41626] by Adam Roben

3 edits in trunk/JavaScriptCore

Adopt setThreadNameInternal on Windows

Also changed a Windows-only assertion about thread name length to an
all-platform log message.

Reviewed by Adam Treat.

wtf/Threading.cpp: (WTF::createThread): Warn if the thread name is longer than 31 characters, as Visual Studio will truncate names longer than that length.

wtf/ThreadingWin.cpp: (WTF::setThreadNameInternal): Renamed from setThreadName and changed to always operate on the current thread. (WTF::initializeThreading): Changed to use setThreadNameInternal. (WTF::createThreadInternal): Removed call to setThreadName. This is now handled by threadEntryPoint and setThreadNameInternal.

8:00 AM Changeset in webkit [41625] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-12 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=24541
Scrolling with home and end keys not always works

Also make page up and page down keys be handled by the webview key
event code, so that they also work in cases where the GTK+
scrollbars don't handle them directly, like in the bugzill's patch
review page.

webkit/webkitwebview.cpp:

8:00 AM Changeset in webkit [41624] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-12 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=24541
Scrolling with home and end keys not always works

Make home and end keys behave more consistently for scrolling the
view.

webkit/webkitwebview.cpp:

7:46 AM Changeset in webkit [41623] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

Bug 24378: resolve-ChangeLogs should use git status or svn status to find and fix unmerged ChangeLogs

<https://bugs.webkit.org/show_bug.cgi?id=24378>

Reviewed by Adam Roben.

Scripts/resolve-ChangeLogs: If -ffix-merged is not passed

and no file or directory names are specified on the command-line
then try to find unmerged ChangeLog files based on 'svn stat' or
'git diff'. Added global $isGit and $isSVN variables so that
isGit() and isSVN() only have to be called once.
(findUnmergedChangeLogs): Added.

6:18 AM Changeset in webkit [41622] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-12 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=24254
[GTK] spacebar doesn't scroll down

Make spacebar and shift+spacebar scroll like page up and down
respectively would.

webkit/webkitwebview.cpp:

5:42 AM Changeset in webkit [41621] by jchaffraix@webkit.org

11 edits in trunk/WebCore

2009-03-12 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 24110: cloneNode should call cloneElement and not the reverse

Splitted the code from cloneNode into cloneElementWithChildren and cloneElementWithChildren. Now cloneNode calls one of the 2 previous methods.

Renamed cloneElement to cloneElementWithoutChildren as it was the previous behaviour.

Moved cloneNode to the Element private section so that WebCore callers cannot use it.

Removed Element::cloneNode usage through WebCore.

dom/Element.cpp: (WebCore::Element::cloneNode): Moved to Element's private section and it now calls the two next methods. (WebCore::Element::cloneElementWithChildren): Added. (WebCore::Element::cloneElementWithoutChildren): Renamed from cloneElement to avoid ambiguity.
dom/Element.h:

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Changed call to cloneElement to call to cloneElementWithoutChildren.
editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Ditto.
editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Ditto.
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::doApply): Ditto.
editing/markup.cpp: (WebCore::createFragmentFromText): Ditto.
svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildShadowTree): Ditto. (WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.

4:08 AM Changeset in webkit [41620] by krit@webkit.org

2 edits in trunk/WebCore

2009-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Fixed a crash on the 1x1 pixel check for background image in gtk.
We need to load the image first and need to be sure that the image
is not null before checking the type.

platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor):

1:46 AM Changeset in webkit [41619] by xan@webkit.org

5 edits in trunk/WebCore

2009-03-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24544
Rename setUrl to setURL

Use proper case for setUrl method, rename it to setURL.

platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt):
platform/network/ResourceResponseBase.h:
platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::headerCallback):
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage): (WebCore::queryInfoCallback):

12:58 AM Changeset in webkit [41618] by xan@webkit.org

2 edits in trunk/WebCore

2009-03-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24519
[GTK] Use two argument KURL ctor in ResourceHandleSoup

Use two argument KURL ctor, the single argument ctor expects its
input to be the output of a previous KURL::parse call, which is
not the case here.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage): (WebCore::queryInfoCallback):

12:41 AM Changeset in webkit [41617] by jhoneycutt@apple.com

2 edits in trunk/WebCore

2009-03-11 Jon Honeycutt <jhoneycutt@apple.com>

Fix for <rdar://6418681>
https://bugs.webkit.org/show_bug.cgi?id=22644

Reviewed by Steve Falkenburg.

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted): Add the Citrix ICA Client plug-in to the blacklist; it requires a Mozilla-based browser.

12:26 AM Changeset in webkit [41616] by oliver@apple.com

2 edits in trunk/WebCore

Build fix

Mar 11, 2009:

11:39 PM Changeset in webkit [41615] by oliver@apple.com

6 edits
3 adds in trunk

<rdar://problem/6673852> Widget "Simple World Clock" does not display with Safari 4

Reviewed by Adele Peterson.

A number of dashboard widgets rely on canvas failing silently when given invalid
colors for gradient stops, but both the spec and firefox throw exceptions here.
So we work around this by creating a dashboard quirk that will only suppress the
exception in dashboard compatibility mode.

Test: fast/canvas/canvas-gradient-addStop-error.html

11:02 PM Changeset in webkit [41614] by ddkilzer@apple.com

2 edits in trunk/WebKit/mac

Remove duplicate header include

Rubber-stamped by Mark Rowe.

WebView/WebView.mm: Remove duplicate #include <runtime/InitializeThreading.h>. Also realphabetized lowercase #include statements.

10:14 PM Changeset in webkit [41613] by ddkilzer@apple.com

8 edits in trunk

Clarify comments regarding order of FEATURE_DEFINES

Rubber-stamped by Mark Rowe.

JavaScriptCore:

Configurations/JavaScriptCore.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync.

WebCore:

Configurations/WebCore.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync.

WebKit/mac:

Configurations/WebKit.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync.

WebKitTools:

Scripts/build-webkit: Added warning about keeping FEATURE_DEFINES in order and the consequences when they are not.

9:39 PM Changeset in webkit [41612] by mrowe@apple.com

2 edits in tags/Safari-6530.3/WebKit/mac

Merge r41592.

9:37 PM Changeset in webkit [41611] by mrowe@apple.com

7 edits
2 copies in tags/Safari-6530.3

Merge r41576.

9:27 PM Changeset in webkit [41610] by kov@webkit.org

2 edits in trunk/WebCore

2009-03-11 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24515
[GTK] soup backend should use GMappedFile instead of mmap directly

Rewrite mmap code used to upload files to use GMappedFile, so that
it is platform-independent.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):

9:06 PM Changeset in webkit [41609] by mrowe@apple.com

4 edits in trunk

Versioning.

9:05 PM Changeset in webkit [41608] by mrowe@apple.com

1 copy in tags/Safari-6530.3

New tag.

8:39 PM Changeset in webkit [41607] by mitz@apple.com

8 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

WTF support for fixing <rdar://problem/3919124> Thai text selection in Safari is incorrect

wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added. Returns whether the character has Unicode line breaking property value SA ("Complex Context").
wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added an implementation that always returns false.

WebCore:

Reviewed by Darin Adler.

WebCore part of fixing <rdar://problem/3919124> Thai text selection in Safari is incorrect

Test: platform/mac/editing/selection/word-thai.html

Tested on Mac, but should work on all ICU platforms (or more precisely
on all platforms that implement
WTF::Unicode::hasLineBreakingPropertyComplexContext() correctly).

editing/TextIterator.cpp: (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator): Added. (WebCore::BackwardsCharacterIterator::range): Added. (WebCore::BackwardsCharacterIterator::advance): Added.

editing/TextIterator.h: Added BackwardsCharacterIterator with the minimal functionality required for this patch. (WebCore::BackwardsCharacterIterator::atEnd): Added.

editing/visible_units.cpp: (WebCore::firstNonComplexContextLineBreak): Added this helper function that returns the index of the first character in the string whose Unicode line breaking property value is not SA ("Complex Context"), or the length of the string if there is no such character. (WebCore::lastNonComplexContextLineBreak): Added this helper function that returns the index of the last character in the string whose Unicode line breaking property value is not SA ("Complex Context"), or -1 if there is no such character. (WebCore::previousBoundary): Changed the signature of the search function to include an offset parameter. Renamed the 'exception' local variable to 'ec' and changed its type to ExceptionCode. Extend the string forwards until the first character with Unicode line breaking property value other than SA. This gives the boundary search function enough context in the forward direction. Changed to use a BackwardsCharacterIterator for translating the backwards offset into a position. (WebCore::nextBoundary): Changed the signature of the search function to include an offset parameter. Extend the string backwards until the first character with Unicode line breaking property value other than SA. This gives the boundary search function enough context in the backwards direction. Restricted the workaround for <rdar://5192593> only to the line break case, because it was causing an extra character to be selected following a word that ended with a combining mark. (WebCore::startWordBoundary): Added an offset parameter. Check that going backwards from the given offset, there is a character with Unicode line breaking property value other than SA, and otherwise return 0 to request more context. (WebCore::endWordBoundary): Similar, but in reverse. (WebCore::previousWordPositionBoundary): Similar. (WebCore::nextWordPositionBoundary): Similar. (WebCore::startSentenceBoundary): Updated for the new search function signature. (WebCore::endSentenceBoundary): Ditto. (WebCore::previousSentencePositionBoundary): Ditto. (WebCore::nextSentencePositionBoundary): Ditto.

LayoutTests:

Reviewed by Darin Adler.

test for <rdar://problem/3919124> Thai text selection in Safari is incorrect

platform/mac/editing/selection/word-thai-expected.txt: Added.
platform/mac/editing/selection/word-thai.html: Added.

6:29 PM Changeset in webkit [41606] by Darin Adler

6 edits in trunk/WebCore

2009-03-11 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Don't use "::" in thread names because it is ugly!

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Use "WebCore: " instead of "WebCore::".
platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::loaderRunLoop): Call this "WebCore: CFNetwork Loader" to make it clear this is a WebCore-created thread.
storage/DatabaseThread.cpp: (WebCore::DatabaseThread::start): Use "WebCore: " instead of "WebCore::".
storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::start): Use "WebCore: " instead of "WebCore::".
workers/WorkerThread.cpp: (WebCore::WorkerThread::start): Use "WebCore: " instead of "WebCore::".

6:26 PM Changeset in webkit [41605] by Darin Adler

8 edits in trunk/JavaScriptCore

2009-03-11 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Give threads names on platforms with pthread_setname_np.

wtf/Threading.cpp: (WTF::NewThreadContext::NewThreadContext): Initialize thread name. (WTF::threadEntryPoint): Call setThreadNameInternal. (WTF::createThread): Pass thread name.

wtf/Threading.h: Added new comments, setThreadNameInternal.

wtf/ThreadingGtk.cpp: (WTF::setThreadNameInternal): Added. Empty.
wtf/ThreadingNone.cpp: (WTF::setThreadNameInternal): Added. Empty.
wtf/ThreadingPthreads.cpp: (WTF::setThreadNameInternal): Call pthread_setname_np when available.
wtf/ThreadingQt.cpp: (WTF::setThreadNameInternal): Added. Empty.
wtf/ThreadingWin.cpp: (WTF::setThreadNameInternal): Added. Empty.

5:53 PM Changeset in webkit [41604] by mrowe@apple.com

2 edits in trunk/WebCore

<rdar://problem/6653286> WebCore's implementation of screenIsMonochrome is needlessly complex

Rubber-stamped by Darin Adler.

platform/mac/PlatformScreenMac.mm:

(WebCore::screenIsMonochrome): Return false.

5:51 PM Changeset in webkit [41603] by Simon Fraser

2 edits in trunk/WebCore

2009-03-11 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24531

Make sure that AnimationControllerPrivate::getAnimatedStyleForRenderer() never
returns a null style if it has a valid renderer, which could happen if a
CompositeAnimation existed, but wasn't running any animations or transitions.

page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):

4:25 PM Changeset in webkit [41602] by Beth Dakin

3 edits
4 adds in trunk

WebCore:

2009-03-11 Beth Dakin <Beth Dakin>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
top value on position:relative child not calculated correctly if
parent has percentage height

and corresponding - <rdar://problem/6172925>

rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetY):

LayoutTests:

2009-03-11 Beth Dakin <Beth Dakin>

Reviewed by Dan Bernstein.

Test for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
top value on position:relative child not calculated correctly if
parent has percentage height

and corresponding - <rdar://problem/6172925>

fast/css/percent-top-value-with-relative-position.html: Added.
platform/mac/fast/css/percent-top-value-with-relative-position-expected.checksum: Added.
platform/mac/fast/css/percent-top-value-with-relative-position-expected.png: Added.
platform/mac/fast/css/percent-top-value-with-relative-position-expected.txt: Added.

2:54 PM Changeset in webkit [41601] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-11 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Implement ScriptValue::hasNoValue for V8.
https://bugs.webkit.org/show_bug.cgi?id=24507

bindings/v8/ScriptValue.h: (WebCore::ScriptValue::hasNoValue):

2:54 PM Changeset in webkit [41600] by levin@chromium.org

5 edits
2 copies
7 adds in trunk/WebCore

2009-03-11 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 24459: Add v8 bindings for event.
<https://bugs.webkit.org/show_bug.cgi?id=24459>

Adding custom event bindings.

bindings/v8/custom/V8AbstractEventListener.cpp: Added.
bindings/v8/custom/V8AbstractEventListener.h: Added.
bindings/v8/custom/V8AttrCustom.cpp: Fixed messed up copyright header.
bindings/v8/custom/V8CustomEventListener.cpp: Added.
bindings/v8/custom/V8CustomEventListener.h: Replaced forwarding header with the real implementation.
bindings/v8/custom/V8ElementCustom.cpp:
bindings/v8/custom/V8LazyEventListener.cpp: Added.
bindings/v8/custom/V8LazyEventListener.h: Added.
bindings/v8/custom/V8ObjectEventListener.cpp: Added.
bindings/v8/custom/V8ObjectEventListener.h: Added.
bindings/v8/custom/V8WorkerContextEventListener.cpp: Added.
bindings/v8/custom/V8WorkerContextEventListener.h: Added.

2:40 PM Changeset in webkit [41599] by darin@chromium.org

3 edits in trunk/WebCore

2009-03-11 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24521
Add some missing includes for the non-JSC build.

platform/text/PlatformString.h: added OwnPtr.h
xml/XMLHttpRequest.cpp: added SecurityOrigin.h

2:17 PM Changeset in webkit [41598] by pam@chromium.org

1 edit
2 adds in trunk/LayoutTests

2009-03-11 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test for potential crash in window.frames.length
These files were accidentally left out of r41459.

https://bugs.webkit.org/show_bug.cgi?id=24339

fast/dom/Window/window-collection-length-no-crash-expected.txt: Added.
fast/dom/Window/window-collection-length-no-crash.html: Added.

1:58 PM Changeset in webkit [41597] by andersca@apple.com

8 edits in trunk/WebKit/mac

2009-03-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebKit side of <rdar://problem/6656147>.

Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Pass the requestID to _WKPHInstantiatePlugin.

Plugins/Hosted/NetscapePluginHostProxy.mm: Pass the requestID to setCurrentReply.

Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::setCurrentReply): Store the reply in a map with the requestID as the key.

(WebKit::NetscapePluginInstanceProxy::waitForReply):
Wait for a reply that matches the given requestID.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Initialize member variables.

(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
Delete all requests.

(WebKit::NetscapePluginInstanceProxy::print):
Pass the requestID to _WKPHPluginInstancePrint.

(WebKit::NetscapePluginInstanceProxy::loadRequest):
Rename m_currentRequestID to m_currentURLRequestID.

(WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
Process requests until we find a reply with the right requestID.

(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
Pass a requestID to the _WKPH function.

(WebKit::NetscapePluginInstanceProxy::nextRequestID):
Ditto.

Plugins/Hosted/ProxyInstance.mm: Pass a requestID to the _WKPH functions.

Plugins/Hosted/WebKitPluginClient.defs:
Plugins/Hosted/WebKitPluginHost.defs: Add requestID parameters.

1:41 PM Changeset in webkit [41596] by Simon Fraser

2 edits in trunk/WebCore

2009-03-11 Simon Fraser <Simon Fraser>

Fix Scons build. Patch from Alexander Guy.

WebCore.scons:

1:39 PM Changeset in webkit [41595] by Adam Roben

3 edits in trunk/WebKit/win

Export functions needed by ThreadSpecific from WebKit

Reviewed by John Sullivan.

WebKit.vcproj/WebKit.def:
WebKit.vcproj/WebKit_debug.def: Export WTF::tlsKeyCount and WTF::tlsKeys.

1:39 PM Changeset in webkit [41594] by Adam Roben

4 edits in trunk/JavaScriptCore

Change the Windows implementation of ThreadSpecific to use functions instead of extern globals

This will make it easier to export ThreadSpecific from WebKit.

Reviewed by John Sullivan.

API/JSBase.cpp: (JSEvaluateScript): Touched this file to force ThreadSpecific.h to be copied into $WebKitOutputDir.

wtf/ThreadSpecific.h: Replaced g_tls_key_count with tlsKeyCount() and g_tls_keys with tlsKeys().

(WTF::::ThreadSpecific):
(WTF::::~ThreadSpecific):
(WTF::::get):
(WTF::::set):
(WTF::::destroy):
Updated to use the new functions.

wtf/ThreadSpecificWin.cpp: (WTF::tlsKeyCount): (WTF::tlsKeys): Added.

(WTF::ThreadSpecificThreadExit): Changed to use the new functions.

12:45 PM Changeset in webkit [41593] by Simon Fraser

3 edits in trunk/LayoutTests

2009-03-11 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24366

Make this test more reliable by only calling runAnimationTest() once
the animation starts, not before some setTimeout().

animations/change-keyframes-name-expected.txt:
animations/change-keyframes-name.html:

12:09 PM Changeset in webkit [41592] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-11 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6620064>.

Plugins/WebPluginContainerPrivate.h:

12:04 PM Changeset in webkit [41591] by Simon Fraser

6 edits in trunk/LayoutTests

2009-03-11 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24266

Land new expected results for transform-absolute-in-positioned-container.html,
and new pixel results for reflection-masks.html. Both are progressions.

platform/mac/fast/reflections/reflection-masks-expected.checksum:
platform/mac/fast/reflections/reflection-masks-expected.png:
platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.checksum:
platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.png:
platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:

12:00 PM Changeset in webkit [41590] by Simon Fraser

4 edits
4 adds in trunk

2009-03-11 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=23093

When the cancel button in the search field is shown or hidden,
we need to explicitly setStyle() on the cancel button's renderer,
to ensure that repaint happens. Changing the style without telling
the renderer won't work.

Test: fast/repaint/search-field-cancel.html

rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createCancelButtonStyle): (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
rendering/RenderTextControlSingleLine.h:

10:58 AM Changeset in webkit [41589] by pam@chromium.org

3 edits in trunk/LayoutTests

2009-03-11 Marc-André Decoste <mad@chromium.org>

Reviewed by Eric Seidel.

Fixed the positions of the list boxes so that the size of their
rendering doesn't affect the test coordinates.
https://bugs.webkit.org/show_bug.cgi?id=24006

fast/forms/option-mouseevents-expected.txt:
fast/forms/option-mouseevents.html:

9:05 AM Changeset in webkit [41588] by ap@webkit.org

4 edits
2 adds in trunk

2009-03-11 Hironori Bono <hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=15790
Ligatures aren't accounted for when manipulating VisiblePositions

Changed cursorMovementIterator rules to prevent a cursor from moving in the middle of an
Indic ligature which uses a virama sign.

Test: editing/deleting/skip-virama-001.html

platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator):

8:46 AM Changeset in webkit [41587] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=24513
REGRESSION: Cursor movement doesn't work on Tiger (ICU 3.2)

Fixes existing tests on Tiger.

platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Use characterBreakIterator on Tiger (like we used to do).

7:53 AM Changeset in webkit [41586] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Only run code in dispose once per instance.

webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):

7:53 AM Changeset in webkit [41585] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Call deref() on our internal HistoryItem on dispose, as we always
acquire it with a releaseRef() call to a PassRefPtr, which passes
ownership.

webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):

7:52 AM Changeset in webkit [41584] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

return foo? foo : NULL == return foo

webkit/webkitwebhistoryitem.cpp: (WebKit::core):

5:27 AM Changeset in webkit [41583] by jmalonzo@webkit.org

8 edits in trunk

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487

Enable http/tests/security/cross-frame-access-private-browsing.html test.

platform/gtk/Skipped:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487

Add private browsing option "enable-private-browsing" to WebKitWebSettings.

webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
webkit/webkitwebview.cpp:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487

Also reset WebSettings to its default state for JavaScript
profiling, Developer Extras and Private Browsing before running
the test (can be after each test but we want to be consistent with
other ports in this regard)

DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): (runTest):
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setPrivateBrowsingEnabled):

5:06 AM Changeset in webkit [41582] by jmalonzo@webkit.org

3 edits in trunk/WebKit/gtk

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK] BackForward history leak?
https://bugs.webkit.org/show_bug.cgi?id=19528

Don't ref the history items when returning the back/forward list
Added test_webkit_web_history_item_lifetime test case for this.

tests/main.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): Style fix. (test_webkit_web_back_forward_list_add_item): Style fix. (main):
webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):

4:58 AM Changeset in webkit [41581] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

<rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled

platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Correct selector name in instancesRespondToSelector.

4:57 AM Changeset in webkit [41580] by jmalonzo@webkit.org

2 edits in trunk

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Fix make clean targets
https://bugs.webkit.org/show_bug.cgi?id=24450

Fix 'make' clean targets. We shouldn't be removing DerivedSources
if it's only clean. Only remove it if it's distclean or
maintainer-clean. Also remove build-related auxillary files on
dist/maintainer clean.

GNUmakefile.am:

4:52 AM Changeset in webkit [41579] by jmalonzo@webkit.org

7 edits in trunk

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther

[GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
https://bugs.webkit.org/show_bug.cgi?id=2260

pangoft2 is also used in directfb builds so use it for all targets

configure.ac:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther

[GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
https://bugs.webkit.org/show_bug.cgi?id=2260

Add missing stdio.h include to get the build going

plugins/gtk/PluginPackageGtk.cpp:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
https://bugs.webkit.org/show_bug.cgi?id=2260

Add plugin support only for X11 builds

DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):
GNUmakefile.am:

Mar 10, 2009:

11:46 PM Changeset in webkit [41578] by justin.garcia@apple.com

2 edits in trunk/WebCore

2009-03-10 Justin Garcia <justin.garcia@apple.com>

Reviewed by Ken Kocienda.

dom/Range.cpp: (WebCore::Range::addLineBoxRects): If the range ended at [div, 0], addLineBoxRects would include rects for the divs contents. Set the correct RenderObject to stop at.

11:28 PM Changeset in webkit [41577] by ap@webkit.org

5 edits in trunk

Reviewed by Sam Weinig.

<rdar://problem/6123770> Restrict access to document.cookie when making a cross-site XHR

WebCore:

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Removed an incorrect comment about cookie support. Firefox doesn't expose cookies on responseXML at all, and there are security concerns with exposing them for cross-origin requests, so it's not clear if we want to change anything here.

LayoutTests:

http/tests/security/cookies/xmlhttprequest.html: We don't expose cookies for documents retrieved via XMLHttpRequest. Added a check to make sure that we don't forget about cross- origin restrictions if we ever decide to change that.

http/tests/xmlhttprequest/resources/get-set-cookie.cgi: While at it, fixed a broken check for Set-Cookie2.

10:43 PM Changeset in webkit [41576] by Simon Fraser

7 edits
2 adds in trunk

2009-03-10 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24503

Fix hit testing of absolutely positioned single line text controls by
ensuring that we set result.innerNode() correctly. If the hit node is
a descendant of the inner text element or if it is the <input> itself,
then we say we hit the innerTextElement.

Rename hitInnerTextBlock() to hitInnerTextElement() to match the
'innerTextElement' terminology used elsewhere.

Assert that if renderer()->hitTest() returns false, no-one set
result.innerNode().

Test: fast/forms/search-abs-pos-cancel-button.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hitInnerTextElement):
rendering/RenderTextControl.h:
rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):

9:03 PM Changeset in webkit [41575] by mrowe@apple.com

4 edits in branches/Safari-6528

Versioning.

9:01 PM Changeset in webkit [41574] by mrowe@apple.com

1 copy in tags/Safari-6528.17

New tag.

7:20 PM Changeset in webkit [41573] by Antti Koivisto

2 edits in trunk/WebCore

2009-03-10 Antti Koivisto <Antti Koivisto>

Reviewed by Mark Rowe.

<rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.

Another case where we would trigger extended encoding loading needlessly.

platform/text/TextEncoding.cpp: (WebCore::TextEncoding::isNonByteBasedEncoding):

5:19 PM Changeset in webkit [41572] by mrowe@apple.com

13 edits in branches/Safari-6528

Merge r41190.

5:19 PM Changeset in webkit [41571] by mrowe@apple.com

10 edits
3 adds in branches/Safari-6528

Merge r41232.

5:08 PM Changeset in webkit [41570] by justin.garcia@apple.com

1 edit in trunk/WebCore/page/Frame.cpp

Fix build.

5:05 PM Changeset in webkit [41569] by Beth Dakin

118 edits
4 adds in trunk

WebCore:

2009-03-10 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for <rdar://problem/6624769> REGRESSION (Safari 4 PB): No
scroll bar appears for long line of text with NOWRAP set

This is a regression from http://trac.webkit.org/changeset/32226
I talked with Dan about the original change, and we decided that
the best fix was to remove his small potential-optimization that
only created a separate line box for whitespace under certain
circumstances. This new code will always create a separate line
box.

rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

2009-03-10 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Test changes for <rdar://problem/6624769> REGRESSION (Safari 4 PB):
No scroll bar appears for long line of text with NOWRAP set

New test:

fast/inline/long-wrapped-line.html: Added.
platform/mac/fast/inline/long-wrapped-line-expected.checksum: Added.
platform/mac/fast/inline/long-wrapped-line-expected.png: Added.
platform/mac/fast/inline/long-wrapped-line-expected.txt: Added.

These tests all have changed results from the patch. Now trailing
whitespace always has its own linebox instead of sometimes sharing
a linebox with text.

platform/mac/editing/deleting/5206311-1-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
platform/mac/editing/deleting/delete-block-table-expected.txt:
platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
platform/mac/editing/deleting/delete-to-select-table-expected.txt:
platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
platform/mac/editing/deleting/forward-delete-expected.txt:
platform/mac/editing/execCommand/5482023-expected.txt:
platform/mac/editing/execCommand/boldSelection-expected.txt:
platform/mac/editing/execCommand/italicizeByCharacter-expected.txt:
platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.txt:
platform/mac/editing/execCommand/print-expected.txt:
platform/mac/editing/execCommand/selectAll-expected.txt:
platform/mac/editing/execCommand/strikethroughSelection-expected.txt:
platform/mac/editing/input/emacs-ctrl-o-expected.txt:
platform/mac/editing/inserting/12882-expected.txt:
platform/mac/editing/inserting/editable-html-element-expected.txt:
platform/mac/editing/inserting/insert-div-019-expected.txt:
platform/mac/editing/inserting/insert-div-020-expected.txt:
platform/mac/editing/inserting/insert-div-021-expected.txt:
platform/mac/editing/inserting/insert-div-022-expected.txt:
platform/mac/editing/inserting/insert-div-023-expected.txt:
platform/mac/editing/inserting/insert-div-024-expected.txt:
platform/mac/editing/inserting/insert-div-025-expected.txt:
platform/mac/editing/inserting/insert-div-027-expected.txt:
platform/mac/editing/inserting/typing-003-expected.txt:
platform/mac/editing/pasteboard/4989774-expected.txt:
platform/mac/editing/pasteboard/5028447-expected.txt:
platform/mac/editing/pasteboard/merge-end-3-expected.txt:
platform/mac/editing/pasteboard/paste-table-003-expected.txt:
platform/mac/editing/pasteboard/paste-text-012-expected.txt:
platform/mac/editing/pasteboard/paste-text-013-expected.txt:
platform/mac/editing/pasteboard/paste-text-014-expected.txt:
platform/mac/editing/selection/4947387-expected.txt:
platform/mac/editing/selection/4983858-expected.txt:
platform/mac/editing/selection/5081257-1-expected.txt:
platform/mac/editing/selection/5081257-2-expected.txt:
platform/mac/editing/selection/5136696-expected.txt:
platform/mac/editing/selection/5234383-1-expected.txt:
platform/mac/editing/selection/5234383-2-expected.txt:
platform/mac/editing/selection/7152-1-expected.txt:
platform/mac/editing/selection/7152-2-expected.txt:
platform/mac/editing/selection/after-line-wrap-expected.txt:
platform/mac/editing/selection/click-start-of-line-expected.txt:
platform/mac/editing/selection/drag-in-iframe-expected.txt:
platform/mac/editing/selection/editable-html-element-expected.txt:
platform/mac/editing/selection/editable-non-editable-crash-expected.txt:
platform/mac/editing/selection/end-of-document-expected.txt:
platform/mac/editing/selection/extend-by-character-003-expected.txt:
platform/mac/editing/selection/extend-by-character-005-expected.txt:
platform/mac/editing/selection/extend-by-word-002-expected.txt:
platform/mac/editing/selection/mixed-editability-1-expected.txt:
platform/mac/editing/selection/move-by-character-003-expected.txt:
platform/mac/editing/selection/move-by-character-005-expected.txt:
platform/mac/editing/selection/select-all-001-expected.txt:
platform/mac/editing/selection/select-all-002-expected.txt:
platform/mac/editing/selection/select-all-003-expected.txt:
platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
platform/mac/editing/style/apple-style-editable-mix-expected.txt:
platform/mac/editing/style/create-block-for-style-001-expected.txt:
platform/mac/editing/style/create-block-for-style-002-expected.txt:
platform/mac/editing/style/create-block-for-style-003-expected.txt:
platform/mac/editing/style/create-block-for-style-004-expected.txt:
platform/mac/editing/style/create-block-for-style-005-expected.txt:
platform/mac/editing/style/create-block-for-style-006-expected.txt:
platform/mac/editing/style/create-block-for-style-007-expected.txt:
platform/mac/editing/style/create-block-for-style-008-expected.txt:
platform/mac/editing/style/create-block-for-style-009-expected.txt:
platform/mac/editing/style/create-block-for-style-010-expected.txt:
platform/mac/editing/style/create-block-for-style-011-expected.txt:
platform/mac/editing/style/create-block-for-style-012-expected.txt:
platform/mac/editing/style/create-block-for-style-013-expected.txt:
platform/mac/editing/style/relative-font-size-change-001-expected.txt:
platform/mac/editing/style/relative-font-size-change-002-expected.txt:
platform/mac/editing/style/relative-font-size-change-003-expected.txt:
platform/mac/editing/style/relative-font-size-change-004-expected.txt:
platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
platform/mac/editing/undo/undo-combined-delete-expected.txt:
platform/mac/editing/undo/undo-delete-boundary-expected.txt:
platform/mac/editing/undo/undo-delete-expected.txt:
platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
platform/mac/editing/undo/undo-forward-delete-expected.txt:
platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt:
platform/mac/fast/clip/outline-overflowClip-expected.txt:
platform/mac/fast/forms/negativeLineHeight-expected.txt:
platform/mac/fast/forms/textAreaLineHeight-expected.txt:
platform/mac/fast/forms/textarea-rows-cols-expected.txt:
platform/mac/fast/lists/drag-into-marker-expected.txt:
platform/mac/fast/parser/comment-in-textarea-expected.txt:
platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
platform/mac/fast/repaint/inline-outline-repaint-expected.txt:
platform/mac/fast/repaint/selection-after-delete-expected.txt:
platform/mac/fast/repaint/selection-after-remove-expected.txt:
platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
platform/mac/fast/text/trailing-white-space-expected.txt:
platform/mac/fast/text/whitespace/pre-wrap-line-test-expected.txt:
platform/mac/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
platform/mac/fast/text/whitespace/tab-character-basics-expected.txt:
platform/mac/http/tests/navigation/anchor-goback-expected.txt:
platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
platform/mac/http/tests/navigation/post-goback2-expected.txt:
platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
platform/mac/http/tests/navigation/success200-goback-expected.txt:
platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:

4:57 PM Changeset in webkit [41568] by weinig@apple.com

3 edits in trunk/WebCore

2009-03-10 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6166844>
https://bugs.webkit.org/show_bug.cgi?id=24495

Use same rule for loading java applets as we do for images.

html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer):
loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):

4:23 PM Changeset in webkit [41567] by justin.garcia@apple.com

1 edit in trunk/WebCore/page/Frame.h

Fix the build.

3:59 PM Changeset in webkit [41566] by justin.garcia@apple.com

5 edits in trunk/WebCore

2009-03-10 Justin Garcia <justin.garcia@apple.com>

Reviewed by David Kilzer.

Get rid of revealCaret and use revealSelection instead.

WebCore.base.exp:
editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
page/Frame.cpp: (WebCore::Frame::revealSelection):
page/Frame.h:

3:48 PM Changeset in webkit [41565] by cwzwarich@webkit.org

3 edits
5 adds in trunk

2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 24291: REGRESSION (r38635): Single line JavaScript comment prevents HTML button click handler execution
<https://bugs.webkit.org/show_bug.cgi?id=24291>
<rdar://problem/6663472>

Add an extra newline to the end of the body of the program text constructed
by the Function constructor for parsing. This allows single line comments to
be handled correctly by the parser.

JavaScriptCore:

runtime/FunctionConstructor.cpp: (JSC::constructFunction):

LayoutTests:

fast/events/onload-single-line-comment-expected.txt: Added.
fast/events/onload-single-line-comment.html: Added.
fast/js/function-constructor-single-line-comment-expected.txt: Added.
fast/js/function-constructor-single-line-comment.html: Added.
fast/js/resources/function-constructor-single-line-comment.js: Added.

2:46 PM Changeset in webkit [41564] by sfalken@apple.com

2 edits in trunk/WebKit/win

<rdar://problem/6662167> When clicking in Top Sites search field, WebHistory::findIndex fails causing crash in BookmarksSearcher::collectHistorySearchResults

Round CFAbsoluteDates to the nearest second when converting to/from the Windows DATE format.

This corrects for inaccuracies introduced by round-tripping between DATE (day based) and CFAbsoluteDate (second based).
The WebKit COM API on Windows uses DATE, while our history storage uses CFAbsoluteTime. This could lead to WebKit
saying there was browsing history for a particular day, and then return no history items when we requested a
list of sites visited that day.

Reviewed by Ada Chan.

MarshallingHelpers.cpp: (MarshallingHelpers::DATEToCFAbsoluteTime): (MarshallingHelpers::CFAbsoluteTimeToDATE):

12:49 PM Changeset in webkit [41563] by cwzwarich@webkit.org

3 edits
2 adds in trunk

2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 23736: WebKit Crashes on http://g-conquest.fr/~server2
<https://bugs.webkit.org/show_bug.cgi?id=23736>
<rdar://problem/6560278>

Before replacing the document, FrameLoader::executeIfJavaScriptURL()
should call stopAllLoaders(), just like continueLoadAfterNavigationPolicy().

WebCore:

loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):

LayoutTests:

http/tests/misc/javascript-url-stop-loaders-expected.txt: Added.
http/tests/misc/javascript-url-stop-loaders.html: Added.

12:31 PM Changeset in webkit [41562] by Darin Adler

4 edits
2 adds in trunk

WebCore:

2009-03-10 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Bug 24494: crash when deleting at end of document and merging paragraphs
https://bugs.webkit.org/show_bug.cgi?id=24494
rdar://problem/6571537

Test: editing/deleting/merge-at-end-of-document.html

dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Split out assertion. It's better not to use && in assertions since we'd like to know which condition is failing.

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null check before calling compareBoundaryPoints, since a 0 for the node is ambiguous and so the function doesn't know which value to return.

LayoutTests:

2009-03-10 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Bug 24494: crash when deleting at end of document and merging paragraphs
https://bugs.webkit.org/show_bug.cgi?id=24494
rdar://problem/6571537

editing/deleting/merge-at-end-of-document-expected.txt: Added.
editing/deleting/merge-at-end-of-document.html: Added.

11:46 AM Changeset in webkit [41561] by krit@webkit.org

5 edits in trunk/WebCore

2009-03-10 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel. Math checked by Oliver Hunt.

Implement the Cairo version of the checkForSolidColor() method. This halfes the
time to draw on 1x1 px background images.
I added two new calls to Color for the pixel manipulation on cairo_surface's.
They are neede to premultiply/unpremultiply the colors of the surface.

[CAIRO] Introduce single-pixel image optimizations
https://bugs.webkit.org/show_bug.cgi?id=17284

platform/graphics/Color.cpp: (WebCore::colorFromPremultipliedARGB): (WebCore::premultipliedARGBFromColor):
platform/graphics/Color.h:
platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor):

11:38 AM Changeset in webkit [41560] by treat@webkit.org

2 edits in trunk/WebKit/qt

2009-03-10 Adam Treat <adam.treat@torchmobile.com>

Build fix for Qt after r41555.

Api/qwebpage.cpp: (QWebPage::acceptNavigationRequest):

11:22 AM Changeset in webkit [41559] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Use g_hash_table_new_full so we can save the manual unref on the
values when removing them from the table.

webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):

10:34 AM Changeset in webkit [41558] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Use 'if (foo)' instead of 'if (foo != NULL)', per coding style
guidelines.

webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_history_item_remove): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children):

10:00 AM Changeset in webkit [41557] by xan@webkit.org

4 edits in trunk/WebKit

WebKit/mac:

2009-03-10 Xan Lopez <xlopez@igalia.com>

Build fix, no review.

WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]):

WebKit/qt:

2009-03-10 Xan Lopez <xlopez@igalia.com>

Build fix, no review.

Api/qwebpage.cpp: (QWebPage::inputMethodQuery):

9:38 AM Changeset in webkit [41556] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

Correct return value to false instead of NULL.

webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):

9:23 AM Changeset in webkit [41555] by darin@chromium.org

5 edits in trunk/WebCore

2009-03-06 Darin Fisher <darin@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24437

Add support for registering noAccess URL schemes:
1- Add FrameLoader::registerURLSchemeAsNoAccess, and have SecurityOrigin check
that list upon construction (similar to how isLocal is implemented).
2- Make InspectorController call grantUniversalAccess on its Document's
SecurityOrigin at the time when windowScriptObjectAvailable is called.

This enables content such as the inspector to be loaded from a custom (non-file)
URL, which is how Chromium loads the inspector. It also allows other URL schemes
to be treated like data: URLs, which Chromium utilizes for its various HTML-based
UI panels.

inspector/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable):
loader/FrameLoader.cpp: (WebCore::localSchemes): (WebCore::noAccessSchemes): (WebCore::FrameLoader::loadItem):
loader/FrameLoader.h:
page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::isLocal):

9:19 AM Changeset in webkit [41554] by xan@webkit.org

2 edits in trunk/WebCore

2009-03-10 Xan Lopez <xlopez@igalia.com>

Build fix, no review

page/mac/AccessibilityObjectWrapper.mm: (textMarkerForVisiblePosition): (visiblePositionForTextMarker):

9:10 AM Changeset in webkit [41553] by xan@webkit.org

30 edits in trunk/WebCore

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24491
Rename posOffset to m_offset, get rid of accessor

As suggested in dom/Position.h, this patch gets rid of the
'offset()' accessor and renames posOffset to m_offset. I've used
m_offset instead of offset to follow the style guide lines, since
Position is still a class and not a structure. If the long term
plan is still to make it a structure it would be pretty easy to
just s/m_offset/offset/ globally when that is achieved.

dom/Position.cpp: (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::atStart): (WebCore::Position::atEnd): (WebCore::Position::renderedOffset): (WebCore::Position::isCandidate): (WebCore::Position::inRenderedText): (WebCore::Position::isRenderedCharacter): (WebCore::Position::rendersInDifferentPosition): (WebCore::Position::leadingWhitespacePosition): (WebCore::Position::debugPosition): (WebCore::Position::formatForDebugger):
dom/Position.h: (WebCore::Position::Position):
dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator):
dom/Range.cpp:
dom/RangeBoundaryPoint.h: (WebCore::RangeBoundaryPoint::position): (WebCore::RangeBoundaryPoint::set): (WebCore::RangeBoundaryPoint::setOffset): (WebCore::RangeBoundaryPoint::setToChild): (WebCore::RangeBoundaryPoint::setToStart): (WebCore::RangeBoundaryPoint::setToEnd): (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyInlineStyleToRange): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::nodeFullySelected): (WebCore::ApplyStyleCommand::nodeFullyUnselected): (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): (WebCore::ApplyStyleCommand::joinChildTextNodes):
editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::positionOutsideTabSpan): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): (WebCore::CompositeEditCommand::deleteInsignificantText): (WebCore::CompositeEditCommand::removePlaceholderAt): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForNodeRemoval): (WebCore::updatePositionForTextRemoval): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace):
editing/Editor.cpp: (WebCore::Editor::setComposition): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::getCompositionSelection):
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::performTrivialReplace): (WebCore::InsertTextCommand::input): (WebCore::InsertTextCommand::insertTab):
editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::debugPosition): (WebCore::makeRange): (WebCore::setStart): (WebCore::setEnd):
editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange): (WebCore::makeSearchRange): (WebCore::VisibleSelection::debugPosition): (WebCore::VisibleSelection::showTreeForThis):
editing/htmlediting.cpp: (WebCore::comparePositions): (WebCore::rangeCompliantEquivalent): (WebCore::isFirstPositionAfterTable): (WebCore::isLastPositionBeforeTable):
editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::startPositionForLine): (WebCore::startOfLine): (WebCore::endPositionForLine): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph):
page/AccessibilityObject.cpp: (WebCore::updateAXLineStartForVisiblePosition):
page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
page/DOMSelection.cpp: (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::extentOffset):
page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::indexForVisiblePosition):
rendering/RenderTreeAsText.cpp: (WebCore::writeSelection):

7:46 AM Changeset in webkit [41552] by Darin Adler

3 edits
2 adds in trunk

WebCore:

2009-03-10 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
https://bugs.webkit.org/show_bug.cgi?id=23564
rdar://problem/6537238

Test: fast/dom/HTMLElement/innerHTML-selection-crash.html

editing/markup.cpp: (WebCore::createMarkup): Added updateLayoutIgnorePendingStylesheets call to the one of the two overloads of this function that wasn't calling it. This fixes this crash and other possible crashes inside innerHTML.

LayoutTests:

2009-03-10 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
https://bugs.webkit.org/show_bug.cgi?id=23564
rdar://problem/6537238

fast/dom/HTMLElement/innerHTML-selection-crash-expected.txt: Added.
fast/dom/HTMLElement/innerHTML-selection-crash.html: Added.

7:10 AM Changeset in webkit [41551] by ap@webkit.org

16 edits
2 deletes in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24285
Text resource loading checks for BOM twice

This removes TextDecoder class, since its only purpose was to check for BOM, which is
already done in TextResourceDecoder. Callers that use TextEncoding::decode() won't get
BOM checked, but I didn't find any cases where it would significantly change behavior.

GNUmakefile.am:
WebCore.pro:
WebCore.scons:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl: Remove TextDecoder.{h,cpp}.

platform/text/TextDecoder.cpp: Removed.
platform/text/TextDecoder.h: Removed.

loader/TextResourceDecoder.h: Instead of a TextDecoder object, keep TextEncoding and TextCodec separately.

loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder): Updated for m_encoding being a member. (WebCore::TextResourceDecoder::setEncoding): Ditto. (WebCore::TextResourceDecoder::checkForBOM): Removed a FIXME saying that a BOM could override even a user-chosen encoding - this is how it already worked due to TextDecoder checking for BOM again. Made this function return the detected BOM length. (WebCore::TextResourceDecoder::decode): Skip the BOM if it was found at the beginning of a text resource. (WebCore::TextResourceDecoder::flush): Reset m_checkedForBOM, so that re-decoding the same resource again (as frequently done by CachedResource subclasses) will skip the BOM correctly.

platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode): Use TextCodec directly without a TextDecoder wrapper. This means that this method no longer checks for BOM, which was a counter-intuitive feature.

loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::setEncoding): (WebCore::CachedScript::encoding): (WebCore::CachedScript::script):
loader/CachedScript.h:
loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Use TextResourceDecoder, as TextEncoding::decode() no longer checks for BOM. A side effect of this is that these resources will now be subject to encoding auto-detection.

loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
page/Page.cpp: (WebCore::Page::userStyleSheet): Be sure to flush TextResourceDecoder, pushing any remaining bytes out, and making the decoder re-usable (for repeated decoding of the same resource).

platform/text/TextEncodingRegistry.h: Updated comments for newTextCodec().

5:58 AM Changeset in webkit [41550] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24488
An assertion failure when updating an offline application cache after emptying caches

Emptying appcache cannot be performed automatically, so no test.

loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk storage, even if the application wasn't updated server side.

2:44 AM Changeset in webkit [41549] by oliver@apple.com

19 edits
9 adds in trunk

<rdar://problem/6425807> Implement WorkerUtils.importScripts()
<https://bugs.webkit.org/show_bug.cgi?id=22721>

Reviewed by Alexey Proskuryakov

Implement importScripts, currently uses a series of synchronous loads
to fetch the scripts, but this is simpler than a synchronous load of
multiple loads in parallel. In future we'll want to switch to parallel
loading, but this will do for now.

Test: http/tests/workers/worker-importScripts.html

1:11 AM Changeset in webkit [41548] by ap@webkit.org

9 edits
4 adds in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24462
Move cross-origin access control code out of XMLHttpRequest

Step 1: move preflight result cache and access control helper functions.

No change in behavior, so no test.

GNUmakefile.am:
WebCore.pro:
WebCore.scons:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
loader/CrossOriginAccessControl.cpp: Added. (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): (WebCore::isSimpleCrossOriginAccessRequest): (WebCore::createAllowedCrossOriginResponseHeadersSet): (WebCore::isOnAccessControlResponseHeaderWhitelist): (WebCore::passesAccessControlCheck):
loader/CrossOriginAccessControl.h: Added.
loader/CrossOriginPreflightResultCache.cpp: Added. (WebCore::parseAccessControlMaxAge): (WebCore::addToAccessControlAllowList): (WebCore::parseAccessControlAllowList): (WebCore::CrossOriginPreflightResultCacheItem::parse): (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod): (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders): (WebCore::CrossOriginPreflightResultCacheItem::allowsRequest): (WebCore::CrossOriginPreflightResultCache::shared): (WebCore::CrossOriginPreflightResultCache::appendEntry): (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
loader/CrossOriginPreflightResultCache.h: Added. (WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem): (WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest): (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
xml/XMLHttpRequest.h:

12:46 AM Changeset in webkit [41547] by ap@webkit.org

5 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19797
Bring the list of forbidden headers in sync with XMLHttpRequest spec draft

Added new checks to http/tests/xmlhttprequest/set-dangerous-headers.html.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Added all headers from XMLHttpRequest 2 draft.

12:03 AM Changeset in webkit [41546] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Adele Peterson.

fix https://bugs.webkit.org/show_bug.cgi?id=23975 <rdar://problem/6593610> REGRESSION: Scrollbar arrow not repainted

rendering/RenderLayer.cpp: (WebCore::RenderLayer::invalidateScrollbarRect): Corrected the vertical scrollbar rect calculation.

Mar 9, 2009:

10:50 PM Changeset in webkit [41545] by Simon Fraser

3 edits
4 adds in trunk

2009-03-09 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein, Oliver Hunt

https://bugs.webkit.org/show_bug.cgi?id=24475

When repainting replaced elements, need to union the selection
and overflow rects because either may extend outside the other.

Test: fast/repaint/transform-replaced-shadows.html

rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::clippedOverflowRectForRepaint):

6:09 PM Changeset in webkit [41544] by oliver@apple.com

5 edits
3 adds in trunk

Bug 24447: REGRESSION (r41508): Google Maps does not complete initialization
<rdar://problem/6657774>

Reviewed by Gavin Barraclough

r41508 actually exposed a pre-existing bug where we were not invalidating the result
register cache at jump targets. This causes problems when condition loads occur in an

expression -- namely through the ?: and

operators. This patch corrects these issues

by marking the target of all forward jumps as being a jump target, and then clears the
result register cache when ever it starts generating code for a targeted instruction.

I do not believe it is possible to cause this class of failure outside of a single
expression, and expressions only provide forward branches, so this should resolve this
entire class of bug. That said i've included a test case that gets as close as possible
to hitting this bug with a back branch, to hopefully prevent anyone from introducing the
problem in future.

5:38 PM Changeset in webkit [41543] by Stephanie Lewis

2 edits in trunk/WebCore

2009-03-09 Stephanie Lewis <Stephanie Lewis>

Fix build.

editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::markAllMisspellingsAndBadGrammarInRanges):

5:22 PM Changeset in webkit [41542] by darin@chromium.org

2 edits in trunk/WebCore

2009-03-09 Kim Christensen <kimworking@gmail.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24276
Dropdown / select boxes do not consider the windows task bar in Chromium.

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup):

3:49 PM Changeset in webkit [41541] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.1.1

Tagging WebKitGTK+'s 1.1.1 release.

3:40 PM Changeset in webkit [41540] by kov@webkit.org

1 add in releases/WebKitGTK

Creating a place to tag WebKitGTK+ releases.

3:34 PM Changeset in webkit [41539] by weinig@apple.com

2 edits
14 deletes in trunk/LayoutTests

2009-03-09 Sam Weinig <sam@webkit.org>

Roll out r41393. It has been causing failures on the bots for about a week.

fast/block/float/resources/se_arrow.png: Removed.
fast/block/float/resources/yinyang.png: Removed.
fast/block/float/t0905-c414-flt-fit-01-d-g.html: Removed.
fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Removed.
fast/block/float/t0905-c5526-flthw-00-c-g.html: Removed.
platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Removed.
platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Removed.
platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Removed.
platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Removed.

3:20 PM Changeset in webkit [41538] by mitz@apple.com

4 edits
2 adds in trunk

WebCore:

Reviewed by Adele Peterson and Dave Hyatt.

fix <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has misaligned edit fields

Test: fast/forms/legend-display-none.html

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Change the display property of legend elements to 'block' unless it is 'none'.
css/html4.css: Do not force the display property of legend elements to 'block' using CSS, because that prevents style rules from setting it to 'none'.

LayoutTests:

Reviewed by Adele Peterson and Dave Hyatt.

test for <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has misaligned edit fields

fast/forms/legend-display-none-expected.txt: Added.
fast/forms/legend-display-none.html: Added.

2:01 PM Changeset in webkit [41537] by levin@chromium.org

3 edits
2 adds in trunk

WebCore:

2009-03-09 Alpha Lam <hclam@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23024

Fix an incorrect criteria in the if statement that leaves references to
deleted floating objects in RenderBlock.

Test: fast/block/float/crash-on-absolute-positioning.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):

LayoutTests:

2009-03-09 Alpha Lam <hclam@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23024

Added regression test for a bug that causes crashes.

fast/block/float/crash-on-absolute-positioning.html: Added.
platform/mac/fast/block/float/crash-on-absolute-positioning-expected.txt: Added.

2:01 PM Changeset in webkit [41536] by levin@chromium.org

3 edits
1 add in trunk/JavaScriptCore

2009-03-09 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

Bug 23175: String and UString should be able to share a UChar* buffer.
<https://bugs.webkit.org/show_bug.cgi?id=23175>

Add CrossThreadRefCounted.

wtf/CrossThreadRefCounted.h: Added. (WTF::CrossThreadRefCounted::create): (WTF::CrossThreadRefCounted::isShared): (WTF::CrossThreadRefCounted::dataAccessMustBeThreadSafe): (WTF::CrossThreadRefCounted::mayBePassedToAnotherThread): (WTF::CrossThreadRefCounted::CrossThreadRefCounted): (WTF::CrossThreadRefCounted::~CrossThreadRefCounted): (WTF::CrossThreadRefCounted::ref): (WTF::CrossThreadRefCounted::deref): (WTF::CrossThreadRefCounted::release): (WTF::CrossThreadRefCounted::copy): (WTF::CrossThreadRefCounted::threadSafeDeref):
wtf/RefCounted.h:
wtf/Threading.h: (WTF::ThreadSafeSharedBase::ThreadSafeSharedBase): (WTF::ThreadSafeSharedBase::derefBase): (WTF::ThreadSafeShared::ThreadSafeShared): (WTF::ThreadSafeShared::deref):

12:48 PM Changeset in webkit [41535] by eric@webkit.org

2 edits in trunk/WebCore

2009-03-09 Mike Belshe <mike@belshe.com>

Reviewed by Eric Seidel.

Unify JSC/V8 idl file.
https://bugs.webkit.org/show_bug.cgi?id=24424

page/Location.idl:

12:48 PM Changeset in webkit [41534] by eric@webkit.org

2 edits in trunk/WebCore

2009-03-09 Mike Belshe <mike@belshe.com>

Reviewed by Eric Seidel.

Unify JSC/V8 for History.idl.

page/History.idl:

12:48 PM Changeset in webkit [41533] by eric@webkit.org

2 edits in trunk/WebCore

2009-03-09 Mike Belshe <mike@belshe.com>

Reviewed by Eric Seidel.

Unify JSC/V8 implementations of DOMWindow.idl.

page/DOMWindow.idl:

11:39 AM Changeset in webkit [41532] by andersca@apple.com

8 edits in trunk/WebKit/mac

2009-03-09 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

WebKit side of <rdar://problem/6530007>

Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEnumerate): Call NetscapePluginInstanceProxy::enumerate.

Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate): Enumerate the JS object and serialize its values.

Plugins/Hosted/ProxyInstance.h:
Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::getPropertyNames): Ask the plug-in host to get the property names and deserialize them.

Plugins/Hosted/WebKitPluginClient.defs:
Plugins/Hosted/WebKitPluginHost.defs:

11:06 AM Changeset in webkit [41531] by Simon Fraser

16 edits in trunk/WebCore

2009-03-09 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24163

Implement mapping of FloatQuads through 3D transforms.

Removed the redundant localToContainerQuad() methods, which can now
shared code with the old mapLocalToAbsolutePoint(), which was
renamed to mapLocalToContainer(). This can now convert a point,
and optionally a FloatQuad, which are carried along in the TransformState.

Optimized TransformState to reduce to simple FloatPoint.move()
if there are no transforms, and to heap-allocate a transform only if
necessary to accumulate transforms (when using preserve-3d).

Tested by 3d point mapping tests, and the inspector highlight (which now shows
the correct quads for 3d-transformed elements).

10:01 AM Changeset in webkit [41530] by Simon Fraser

3 edits
2 adds in trunk

2009-03-09 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24433

During hit testing with transforms, if a layer has backface-visibility: hidden,
we need to check for it whether or not the layer has a transform, because it
might be an ancestor that is transformed.

Test: transforms/3d/hit-testing/backface-no-transform-hit-test.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):

9:53 AM Changeset in webkit [41529] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-03-09 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt and Cameron Zwarich

https://bugs.webkit.org/show_bug.cgi?id=24440

The sublayer added to WebHTMLView to host accelerated compositing layers needs to
be a subclass of NSView which allows context menu clicks through.

WebView/WebHTMLView.mm: (-[WebLayerHostingView rightMouseDown:]): (-[WebHTMLView attachRootLayer:]):

9:37 AM Changeset in webkit [41528] by treat@webkit.org

4 edits in trunk

2009-03-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=24353
Allow to overrule default build options for Qt build.

WebCore.pro: Allow to overrule ENABLE_VIDEO and ENABLE_NETSCAPE_PLUGIN_API
JavaScriptCore.pri: Allow to overrule ENABLE_JIT

9:32 AM Changeset in webkit [41527] by treat@webkit.org

2 edits in trunk/WebCore

2009-03-09 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=24463
WebCore::qstring is detaching and copying twice for every single
WebCore::TextRun that is processed and drawn. This elevates this method
to one of the top-ten most expensive methods in all of QtWebKit according
to profiling. This changes the method so that QString only detaches
when absolutely necessary.

platform/graphics/qt/FontQt.cpp: (WebCore::qstring): (WebCore::fixSpacing): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):

Mar 7, 2009:

11:29 PM Changeset in webkit [41526] by zecke@webkit.org

2 edits in trunk/LayoutTests

2009-03-08 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber-stamped by Mark Rowe.

[Gtk] Skip failing tests that require the eventSender.

The Gtk+ platform is lacking an implementation of the
eventSender. We will enable the tests once there is an
implementation of that class.

platform/gtk/Skipped:

10:36 PM Changeset in webkit [41525] by mrowe@apple.com

33 edits
2 adds in trunk

Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
Frame.h no longer needs to include it. This cuts the size of the symbols
for a debug build by around 3%.

Reviewed by Oliver Hunt.

dom/Element.cpp:

(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):

editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):

editing/SelectionController.cpp:

(WebCore::SelectionController::setSelection):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::gotoAnchor):

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):

page/Frame.cpp:

(WebCore::Frame::revealSelection):
(WebCore::Frame::revealCaret):

page/Frame.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::getRectToExpose):
(WebCore::RenderLayer::autoscroll):

rendering/RenderLayer.h:
rendering/ScrollBehavior.cpp: Added.

(WebCore::):

rendering/ScrollBehavior.h: Added.

(WebCore::):
(WebCore::ScrollAlignment::getVisibleBehavior):
(WebCore::ScrollAlignment::getPartialBehavior):
(WebCore::ScrollAlignment::getHiddenBehavior):

Add the new files to the build systems:

GNUmakefile.am:
WebCore.base.exp:
WebCore.pro:
WebCore.scons:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:

Add includes that were previously pulled in by way of RenderLayer.h from Frame.h:

dom/Clipboard.cpp:
editing/EditorCommand.cpp:
editing/InsertLineBreakCommand.cpp:
editing/TypingCommand.cpp:
html/HTMLFormControlElement.cpp:
loader/archive/cf/LegacyWebArchive.cpp:
loader/icon/IconLoader.cpp:
page/animation/AnimationController.cpp:
rendering/RenderSlider.cpp:
rendering/RenderTextControl.cpp:

WebKit/mac:

Plugins/WebNetscapePluginView.mm:
WebView/WebFrame.mm:

(-[WebFrame _scrollDOMRangeToVisible:]):
(-[WebFrame _insertParagraphSeparatorInQuotedContent]):
(-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):

WebView/WebHTMLView.mm:

(-[WebHTMLView jumpToSelection:]):
(-[WebHTMLView centerSelectionInVisibleArea:]):

WebKit/win:

WebView.cpp:

(WebView::centerSelectionInVisibleArea):

8:44 PM Changeset in webkit [41524] by mrowe@apple.com

9 edits in trunk/WebCore

Push the include of Frame.h out of RenderView.h and down to those files
that need it. This cuts the size of symbols for RenderFoo object files
by around 15% in a debug build.

Reviewed Dan Bernstein.

bindings/objc/DOM.mm:
rendering/RenderFileUploadControl.cpp:
rendering/RenderInline.cpp:
rendering/RenderObject.cpp:
rendering/RenderReplaced.cpp:
rendering/RenderText.cpp:
rendering/RenderView.cpp:

(WebCore::RenderView::zoomFactor):

rendering/RenderView.h:

8:18 PM Changeset in webkit [41523] by mrowe@apple.com

12 edits in trunk/WebCore

Remove some unnecessary or redundant includes from files related to the JS bindings.
This cuts the size of the symbols for a debug build by around 3%.

Rubber-stamped by Dan Bernstein.

bindings/js/JSCustomPositionCallback.cpp:
bindings/js/JSCustomPositionErrorCallback.cpp:
bindings/js/JSCustomSQLStatementCallback.cpp:
bindings/js/JSCustomSQLStatementErrorCallback.cpp:
bindings/js/JSCustomSQLTransactionCallback.cpp:
bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
bindings/js/JSCustomVoidCallback.cpp:
bindings/js/JSCustomXPathNSResolver.cpp:
bindings/js/JSDocumentCustom.cpp:
bindings/js/JSPluginElementFunctions.cpp:
bindings/js/JSSVGPODTypeWrapper.h:

8:17 PM Changeset in webkit [41522] by zecke@webkit.org

9 edits in trunk

[gtk+] Implement LayoutTestController::setJavaScriptProfilingEnabled

setJavaScriptProfilingEnabled is implemented by enabling the
developer extras using the WebKitWebSettings and adding the
JavaScript Profiling option to the WebKitWebInspector.

4:21 PM Changeset in webkit [41521] by cwzwarich@webkit.org

5 edits in trunk/WebCore

2009-03-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Remove the unused methods previousHistoryItem(), setPreviousHistoryItem()
and provisionalHistoryItem() from FrameLoader.

WebCore.base.exp:
WebCore.order:
loader/FrameLoader.cpp: (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::loadItem):
loader/FrameLoader.h:

12:35 PM Changeset in webkit [41520] by kov@webkit.org

3 edits in trunk/WebCore

2009-03-08 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Implement proper logging for the GTK+ port, inspired by the one in
Qt. We use the WEBKIT_DEBUG environment variable which was already
being used to decide whether to setup a logger for soup or not.

platform/gtk/LoggingGtk.cpp: (WebCore::getChannelFromName): (WebCore::InitializeLoggingChannelsIfNecessary):
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):

6:01 AM Changeset in webkit [41519] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Build fix.

Reviewed by NOBODY(Build fix)

3:47 AM Changeset in webkit [41518] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Bug 24268: RuntimeArray is not a fully implemented JSArray
<https://bugs.webkit.org/show_bug.cgi?id=24268>

Reviewed by Cameron Zwarich.

Don't cast a type to JSArray, just because it reportsArray as a supertype
in the JS type system. Doesn't appear feasible to create a testcase
unfortunately as setting up the failure conditions requires internal access
to JSC not present in DRT.

Mar 7, 2009:

4:05 PM Changeset in webkit [41517] by mitz@apple.com

13 edits in trunk

WebCore:

Reviewed by Mark Rowe.

WebCore part of removing build-time and run-time support for legacy versions of CFNetwork and Core Graphics

platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::platformDataInit):
platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): (WebCore::httpBodyFromRequest):
platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didSendBodyData): (WebCore::shouldUseCredentialStorageCallback): (WebCore::ResourceHandle::start):
platform/network/win/CookieJarCFNetWin.cpp: (WebCore::filterCookies):

WebKit/win:

Reviewed by Mark Rowe.

WebKit part of removing build-time and run-time support for legacy versions of CFNetwork and Core Graphics

WebView.cpp: (WebView::setCacheModel):

WebKitLibraries:

Reviewed by Mark Rowe.

WebKitSystemInterface part of removing build-time and run-time support for legacy versions of CFNetwork and Core Graphics

win/include/WebKitSystemInterface/WebKitSystemInterface.h:
win/lib/WebKitSystemInterface.lib:
win/lib/WebKitSystemInterface_debug.lib:

2:16 PM Changeset in webkit [41516] by jmalonzo@webkit.org

2 edits in trunk/LayoutTests

2009-03-07 Jan Michael Alonzo <jmalonzo@webkit.org>

Updated Skipped list per r41464. Not reviewed.
This should remove the warnings that come up everytime we run the gtk layout tests.
http://trac.webkit.org/changeset/41464

The ff. tests have been moved to fast/css/getComputedStyle in the Skipped list:

fast/css/computed-style-without-renderer.html
fast/css/computed-style.html
fast/css/getComputedStyle-border-box.html

The ff. test has been removed from the Skipped list:

fast/css/marginComputedStyle.html

platform/gtk/Skipped:

2:15 PM Changeset in webkit [41515] by jmalonzo@webkit.org

2 edits in trunk/LayoutTests

2009-03-07 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubber-stamped by Holger Freyther.

Remove fast/canvas/gradient-empty-path.html from the skipped
list as it was removed by r39288.

platform/gtk/Skipped:

2:15 PM Changeset in webkit [41514] by jmalonzo@webkit.org

2 edits in trunk/LayoutTests

2009-03-07 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Enable http security, plugins and ssl tests
https://bugs.webkit.org/show_bug.cgi?id=24393

Enable http tests for security, plugins and ssl, skipping tests
that are failing/crashing.

platform/gtk/Skipped:

2:15 PM Changeset in webkit [41513] by jmalonzo@webkit.org

4 edits in trunk

2009-03-07 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Enable http history tests
https://bugs.webkit.org/show_bug.cgi?id=24394

Get the index of the current item from the list of (history) items
to print before adding the back history items to the list. This
will make the 'curr' pointer point to the correct item in the
actual results, therefore, passing some of the http/tests/history
tests.

DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpBackForwardListForWebView):

2009-03-07 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Enable http history tests
https://bugs.webkit.org/show_bug.cgi?id=24394

Enable http/tests/history, adding failing tests to the Skipped list.

platform/gtk/Skipped:

1:28 PM Changeset in webkit [41512] by mitz@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Alexey Proskuryakov.

fix a bug where debug builds were clearing the HTML5 application cache on application termination

WebView/WebView.mm: (-[WebView _close]): Call -[WebCache setDisabled:YES] instead of -[WebCache empty].

11:46 AM Changeset in webkit [41511] by adele@apple.com

5 edits
2 adds in trunk

WebCore:

2009-03-07 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=24444
No multiple JS property for <input type="file" multiple />

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::multiple): (WebCore::HTMLInputElement::setMultiple):
html/HTMLInputElement.h:
html/HTMLInputElement.idl:

LayoutTests:

2009-03-07 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Test for https://bugs.webkit.org/show_bug.cgi?id=24444
No multiple JS property for <input type="file" multiple />

fast/forms/input-multiple-expected.txt: Added.
fast/forms/input-multiple.html: Added.

10:42 AM Changeset in webkit [41510] by treat@webkit.org

2 edits in trunk/WebKit/qt

2009-03-07 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Cameron Zwarich.

These methods are clearly returning the wrong values as the two were
returning swapped information.

Api/qwebpage.cpp: (QWebPage::totalBytes): (QWebPage::bytesReceived):

4:03 AM Changeset in webkit [41509] by xan@webkit.org

3 edits in trunk/WebCore

2009-03-07 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24358
[GTK] Scrollbars not clipped correctly

ScrollView scrollbars in subframes are *not* native, so take that
into account again.

platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::getLocationInParentWindow): (ScrollbarGtk::frameRectsChanged): (ScrollbarGtk::paint):
platform/gtk/ScrollbarGtk.h:

Mar 6, 2009:

8:58 PM Changeset in webkit [41508] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

2009-03-06 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

When preforming an op_mov, preserve any existing register mapping.

~0.5% progression on v8 tests x86-64.

jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):

4:26 PM Changeset in webkit [41507] by pkasting@chromium.org

3 edits in trunk/WebCore

2009-03-06 Peter Kasting <pkasting@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24405
Horizontal scrolling on Windows was reversed from Mac (and intuition).

platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

4:15 PM Changeset in webkit [41506] by mrowe@apple.com

4 edits in tags/Safari-6530.2

Versioning.

3:47 PM Changeset in webkit [41505] by pkasting@chromium.org

5 edits in trunk/WebCore

2009-03-06 Peter Kasting <pkasting@google.com>

Reviewed by Sam Weinig.

Convert some C-style casts to static_cast<>()s.

platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/wx/MouseWheelEventWx.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

3:05 PM Changeset in webkit [41504] by mrowe@apple.com

4 edits in trunk

Versioning.

3:03 PM Changeset in webkit [41503] by mrowe@apple.com

1 copy in tags/Safari-6530.2

New tag.

3:01 PM Changeset in webkit [41502] by Darin Adler

3 edits in trunk/LayoutTests

2009-03-06 Darin Adler <Darin Adler>

Fixed broken test I just landed for bug 24422.

fast/dom/location-new-window-no-crash-expected.txt: Updated.
fast/dom/resources/location-new-window-no-crash.js: Added code to make the window opening and closing work in DumpRenderTree.

2:12 PM Changeset in webkit [41501] by adele@apple.com

2 edits in trunk/WebCore

2009-03-06 Adele Peterson <adele@apple.com>

Reviewed by Oliver Hunt.

Fix for <rdar://problem/6607524> REGRESSION (Safari 3-4): I can't tab back to the URL field in an empty window (key loop is broken)

I haven't been able to make a test for this since the problem is not reproducible within an empty iframe.

page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): We used to ensure that every html document had a body element. That is no longer true, so we should return the document element for a truly empty document.

1:32 PM Changeset in webkit [41500] by darin@chromium.org

3 edits in trunk/WebCore

2009-03-06 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24306

Adding a flag to ResourceRequestBase to indicate whether or not upload
progress notifications are needed for a resource. This is useful to
avoid sending these notifications when there are no consumers
(especially in the Chromium case where IPC is involved).

platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::reportUploadProgress): (WebCore::ResourceRequestBase::setReportUploadProgress): (WebCore::ResourceRequestBase::ResourceRequestBase):
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):

1:21 PM Changeset in webkit [41499] by dimich@chromium.org

13 edits
7 adds in trunk

WebCore:

2009-03-04 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24150
Add virtual ScriptExecutionContext::encoding()

Test: http/tests/workers/text-encoding.html

dom/Document.cpp: (WebCore::Document::encoding):
dom/Document.h: (WebCore::Document::inputEncoding): (WebCore::Document::charset): (WebCore::Document::characterSet): Add new virtual method and route DOM synonym functions on Document through it.

dom/ScriptExecutionContext.h:
workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::encoding): (WebCore::WorkerContext::completeURL): Added comment on why this is different from Document::completeURL
workers/WorkerContext.h: (WebCore::WorkerContext::create):
workers/WorkerContextProxy.h:
workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerContext):
workers/WorkerMessagingProxy.h:
workers/WorkerThread.cpp: (WebCore::WorkerThreadStartupData::create): (WebCore::WorkerThreadStartupData::WorkerThreadStartupData): (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
workers/WorkerThread.h: All of the above route the 'encoding' parameter of parent context to the new instance of WorkerContext - from Worker::notifyFinished() via WorkerMessagingProxy through WorkerThread through WorkerThreadStartupData and into constructor of WorkerContext.

LayoutTests:

2009-03-04 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24150
Add virtual ScriptExecutionContext::encoding()

Test to verify how the text encoding in workers is used.
Script decoding and url completion is checked, with and
w/o http 'Content-Type: ...;charset=...' header.

http/tests/workers/resources/worker-encoded.php: Added.
http/tests/workers/resources/xhr-query-utf8.php: Added.
http/tests/workers/resources/xhr-response.php: Added.
http/tests/workers/text-encoding-expected.txt: Added.
http/tests/workers/text-encoding.html: Added.

12:43 PM Changeset in webkit [41498] by pkasting@chromium.org

2 edits in trunk/WebCore

2009-03-06 Peter Kasting <pkasting@google.com>

Build bustage fix.

dom/Node.cpp: (WebCore::Node::dispatchWheelEvent):

12:17 PM Changeset in webkit [41497] by eric.carlson@apple.com

2 edits in trunk/WebCore

2009-03-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): Delay callback while setting up movieview.

12:08 PM Changeset in webkit [41496] by justin.garcia@apple.com

13 edits in trunk

WebCore:

2009-03-06 Douglas R. Davidson <ddavidso@apple.com>

Reviewed by Justin Garcia.

https://bugs.webkit.org/show_bug.cgi?id=24108

Update spelling and grammar checking to use the new combined text
checking (with automatic language identification) on Snow Leopard.
Tested manually in Mail and Safari; automated tests to come later.

editing/Editor.cpp: (WebCore::findFirstMisspellingOrBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::guessesForMisspelledOrUngrammaticalRange): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar):
editing/Editor.h:
loader/EmptyClients.h: (WebCore::EmptyEditorClient::checkSpellingAndGrammarOfParagraph):
page/EditorClient.h:
page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):
platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

WebKit/mac:

2009-03-06 Douglas R. Davidson <ddavidso@apple.com>

Reviewed by Justin Garcia.

https://bugs.webkit.org/show_bug.cgi?id=24108

Update spelling and grammar checking to use the new combined text
checking (with automatic language identification) on Snow Leopard.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkSpellingAndGrammarOfParagraph):

11:52 AM Changeset in webkit [41495] by pkasting@chromium.org

10 edits in trunk/WebCore

2009-03-06 Peter Kasting <pkasting@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24407
Windows scroll amount was too small, and wheel scroll distance
conversion code was overly complex.

page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent):
platform/PlatformWheelEvent.h: (WebCore::):
platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
platform/Scrollbar.h:
platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/qt/WheelEventQt.cpp:
platform/win/WheelEventWin.cpp: (WebCore::horizontalScrollChars): (WebCore::verticalScrollLines): (WebCore::PlatformWheelEvent::PlatformWheelEvent):
platform/wx/MouseWheelEventWx.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

11:18 AM Changeset in webkit [41494] by treat@webkit.org

2 edits in trunk/WebKitTools

2009-03-06 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

When building QtWebKit in release mode make sure that QT_SHARED is defined
otherwise none of the public API will be exported. This leads to missing
symbols and link errors if hidden-visibility is used.

Scripts/webkitdirs.pm:

11:14 AM Changeset in webkit [41493] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-06 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Roben.

Generate valid bindings with HTML5 database support disabled.

inspector/InspectorController.idl: Added feature guard around databaseTableNames definition.

11:06 AM Changeset in webkit [41492] by xan@webkit.org

2 edits in trunk/WebCore

2009-03-04 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24358
[GTK] Scrollbars not clipped correctly

Do not take into account the case of being a ScrollView scrollbar,
since those are native in our case.

platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::frameRectsChanged):

11:06 AM Changeset in webkit [41491] by xan@webkit.org

4 edits in trunk/WebCore

2009-03-04 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24358
[GTK] Scrollbars not clipped correctly

Move Widget::paint to ScrollbarGtk::paint, since it's scrollbar
specific and it's our only Widget anyway.

platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::paint):
platform/gtk/ScrollbarGtk.h:
platform/gtk/WidgetGtk.cpp:

11:06 AM Changeset in webkit [41490] by xan@webkit.org

2 edits in trunk/WebCore

2009-03-04 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24358
[GTK] Scrollbars not clipped correctly

Use correct clip rectangle and apply coordinate translation needed
for non-ScrollView scrollbars.

We were ignoring the clip rectangle passed as parameter, which is
wrong in the case of non coalesced expose events. This, in turn,
uncovers the fact that we were not applying coordinate translation
to our position.

platform/gtk/WidgetGtk.cpp: (WebCore::Widget::paint):

11:05 AM Changeset in webkit [41489] by Adam Roben

2 edits in trunk/WebKitTools

Change the isCygwin check in update-webkit to isAppleWinWebKit

This matches a similar check in build-webkit, and is more correct.

Reviewed by Alexey Proskuryakov.

Scripts/update-webkit: Only call update-webkit-auxiliary-libs if isAppleWinWebKit is true.

11:05 AM Changeset in webkit [41488] by Adam Roben

2 edits in trunk/WebKitTools

Make update-webkit-support-libs fail if WebKitSupportLibrary.zip is present but out of date

Reviewed by Alexey Proskuryakov.

Scripts/update-webkit-support-libs: Changed to use dieAndInstructToDownload when the zip file doesn't exist. Added an MD5 check to make sure the file is up-to-date. If it is out of date, print an error message and quit. (sub dieAndInstructToDownload): Added. Prints an error message and quits with an error.

11:03 AM Changeset in webkit [41487] by eric.carlson@apple.com

2 edits in trunk/WebCore

2009-03-06 Eric Carlson <eric.carlson@apple.com>

Build fix, no review

platform/graphics/chromium/MediaPlayerPrivateChromium.h: fix setSize declaration

10:55 AM Changeset in webkit [41486] by eric.carlson@apple.com

14 edits in trunk/WebCore

2009-03-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=22790
Bug 22790: [Transforms] MediaPlayer::setRect() makes no sense with transforms
Replace media engine setRect with setSize since they don't use about the
position anyway.

platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setSize): Changed from setRect. (WebCore::MediaPlayer::setSize): Ditto.
platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::size): Changed from rect().

platform/graphics/MediaPlayerPrivate.h: Changed setRect to setSize.

platform/graphics/chromium/MediaPlayerPrivateChromium.h: Ditto.

platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_size instead of m_rect (WebCore::MediaPlayerPrivate::setSize): Changed from setRect (WebCore::MediaPlayerPrivate::paint): update comment
platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: m_rect -> m_size.

platform/graphics/mac/MediaPlayerPrivateQTKit.h: m_rect
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_rect. (WebCore::MediaPlayerPrivate::createQTMovieView): setRect-> setSize. (WebCore::MediaPlayerPrivate::setSize): Changed from setRect (WebCore::MediaPlayerPrivate::paint): Call view:setFrame: when in a media document so the movie is drawn in the correct location.

platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
platform/graphics/qt/MediaPlayerPrivatePhonon.h:

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer): Call setSize instead of setRect.

10:55 AM Changeset in webkit [41485] by cmarrin@apple.com

3 edits in trunk/LayoutTests

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24363

Fixed test and fixed expected results to reflect the fix

9:22 AM Changeset in webkit [41484] by Darin Adler

3 edits
3 adds in trunk

WebCore:

2009-03-06 Darin Adler <Darin Adler>

Reviewed by Darin Fisher.

Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
https://bugs.webkit.org/show_bug.cgi?id=24422
rdar://problem/6402208

Test: fast/dom/location-new-window-no-crash.html

The issue here is empty (or null) URLs. I picked the "schedule navigation" bottleneck
to add some checks for empty URLs. We could also put the empty URL checks at some
other bottleneck level and add more assertions over time. I tried adding a few more
assertions to functions like loadURL and hit them while running the regression tests,
so it's probably going to be a bit tricky to clean this up throughout the loader.

loader/FrameLoader.cpp: (WebCore::ScheduledRedirection::ScheduledRedirection): Explicitly marked this struct immutable by making all its members const. Added assertions about the arguments, including that the URL is not empty. Initialized one uninitialized member in one of the constructors. (WebCore::FrameLoader::scheduleHTTPRedirection): Added an early exit to make this a no-op if passed an empty URL. (WebCore::FrameLoader::scheduleLocationChange): Ditto. (WebCore::FrameLoader::scheduleRefresh): Ditto.

LayoutTests:

2009-03-06 Darin Adler <Darin Adler>

Reviewed by Darin Fisher.

Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
https://bugs.webkit.org/show_bug.cgi?id=24422
rdar://problem/6402208

The new test manipulates all the properties of the location object on a new window which
has no location yet. I tested Firefox too and added comments about how its behavior differs
from WebKit. At some point we may want to tweak our behavior to be a bit closer to theirs,
or check IE's behavior or if HTML 5 or some other W3 specification has something to say
about this, but for now the main purpose of the test is to verify we don't crash.

fast/dom/location-new-window-no-crash-expected.txt: Added.
fast/dom/location-new-window-no-crash.html: Added.
fast/dom/resources/location-new-window-no-crash.js: Added.

8:35 AM Changeset in webkit [41483] by kov@webkit.org

2 edits in trunk/WebCore

2009-03-06 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24423
Use new soup_message_body_set_accumulate API in soup backend

Disable accumulating chunks for request_body on file uploads,
using the new soup API.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):

8:35 AM Changeset in webkit [41482] by kov@webkit.org

2 edits in trunk/WebCore

2009-03-06 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24423
Use new soup_message_body_set_accumulate API in soup backend

Replace use of deprecated SOUP_MESSAGE_OVERWRITE_CHUNKS flag with
the new soup_message_body_set_accumulate API in soup.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::ResourceHandle::startHttp):

7:54 AM Changeset in webkit [41481] by kov@webkit.org

3 edits in trunk/WebCore

2009-03-06 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24051
Soup backend needs content sniffing capabilities

Perform content sniffing when using soup, so that we have a chance
of figuring out the Content-Type of the file if it's not sent by
the server.

platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::gotChunkCallback):

7:42 AM Changeset in webkit [41480] by Darin Adler

2 edits in trunk/LayoutTests

2009-03-06 Darin Adler <Darin Adler>

fast/dom/Window/window-properties-expected.txt: Updated for recent addition of canPlayType.

5:27 AM Changeset in webkit [41479] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-05 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Olliej.

https://bugs.webkit.org/show_bug.cgi?id=24295
webkit_web_back_forward_list_add_item needs a Since tag

Add missing Since tag to webkit_web_back_forward_list_add_item
documentation.

webkit/webkitwebbackforwardlist.cpp:

5:24 AM Changeset in webkit [41478] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-05 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24417
[GTK] WebKitDownload's _cancel and _dispose methods may emit warnings

NULL-check for timer on _cancel and _dispose, to avoid bad
warnings.

webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_cancel):

3:13 AM Changeset in webkit [41477] by ap@webkit.org

6 edits
2 adds in trunk

2009-03-06 Hironori Bono <hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24342
Cannot insert a Thai character after a Thai prepend character when using ICU 4.0

This change creates a new break iterator "cursorMovementIterator" for
moving cursors and use it when moving an input cursor.
In "TextBreakIteratorICU.cpp", this break iterator uses custom ruleset
based on the one of ICU 3.8.
On the other hand, in "TextBreakIteratorQt.cpp", this break iterator
just calls the characterBreakIterator() function.

Test: editing/inserting/insert-thai-characters-001.html

platform/text/TextBreakIterator.h: Added a new function cursorMovementIterator().
platform/text/TextBreakIteratorICU.cpp: Implemented the cursorMovementIterator() function for ICU. (WebCore::setUpIteratorWithRules): Ditto. (WebCore::cursorMovementIterator): Ditto.
platform/text/qt/TextBreakIteratorQt.cpp: Implemented the cursorMovementIterator() function for Qt. (WebCore::cursorMovementIterator): Ditto.
rendering/RenderText.cpp: Call the cursorMovementIterator() function when moving an input cursor. (WebCore::RenderText::previousOffset): Ditto. (WebCore::RenderText::nextOffset): Ditto.

Mar 5, 2009:

11:28 PM Changeset in webkit [41476] by ap@webkit.org

5 edits
3 adds in trunk

Reviewed by Oliver Hunt.

<rdar://problem/6621701> Safari 4 Beta Breaks XMLHttpRequest Response Text With Special
Characters (a compatibility issue with widgets).

Test: http/tests/xmlhttprequest/broken-xml-encoding.html

Revert part of an Acid 3 fix - now we are no longer strict when decoding XMLHttpRequest XML
responses.

loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder): (WebCore::TextResourceDecoder::decode): (WebCore::TextResourceDecoder::flush):
loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::useLenientXMLDecoding): Don't stop on XML decoding errors if useLenientXMLDecoding() was called.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Don't stop on XML decoding errors. This behavior is now limited to other kinds of XML content.

11:17 PM Changeset in webkit [41475] by ddkilzer@apple.com

4 edits in trunk

JavaScriptCore:

2009-03-05 Simone Fiorentino <simone.fiorentino@consulenti.fastweb.it>

Bug 24382: request to add SH4 platform

<https://bugs.webkit.org/show_bug.cgi?id=24382>

Reviewed by David Kilzer.

wtf/Platform.h: Added support for SH4 platform.

WebCore:

2009-03-05 Simone Fiorentino <simone.fiorentino@consulenti.fastweb.it>

Bug 24382: request to add SH4 platform

<https://bugs.webkit.org/show_bug.cgi?id=24382>

Reviewed by David Kilzer.

platform/text/AtomicString.cpp: (WebCore::equal): Aligned memory access on SH4 platform.

11:02 PM Changeset in webkit [41474] by barraclough@apple.com

4 edits in trunk/JavaScriptCore

2009-03-05 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Writes of constant values to SF registers should be made with direct memory
writes where possible, rather than moving the value via a hardware register.

~3% win on SunSpider tests on x86, ~1.5% win on v8 tests on x86-64.

assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::storePtr):
assembler/X86Assembler.h: (JSC::X86Assembler::movq_i32m):
jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):

9:15 PM Changeset in webkit [41473] by darin@chromium.org

2 edits in trunk/WebCore

2009-03-05 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Simon Fraser.

Fix for https://bugs.webkit.org/show_bug.cgi?id=24215

Gears expects an object tag with display:none to instantiate the plugin,
so we add a workaround to make this work and fix Gears on WebKit trunk.

html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):

9:13 PM Changeset in webkit [41472] by darin@chromium.org

2 edits in trunk/WebCore

2009-03-05 Avi Drissman <avi@chromium.org>

Reviewed by Darin Fisher.

Need to have Chromium Mac match Safari Mac's accesskey handling
https://bugs.webkit.org/show_bug.cgi?id=24404

page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::accessKeyModifiers): Share access key modifiers with Mac Safari when building for the Mac.

8:12 PM Changeset in webkit [41471] by Simon Fraser

3 edits
2 adds in trunk

2009-03-05 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24412

Fix crash when hit-testing elements with -webkit-transform-style: preserve-3d
but no transform. We need to make localTransformState if we see preserve-3d.
Also need to call update3DTransformedDescendantStatus() before we test
m_has3DTransformedDescendant.

Test: transforms/3d/hit-testing/hit-preserves-3d.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):

8:12 PM Changeset in webkit [41470] by justin.garcia@apple.com

1 edit in trunk/LayoutTests/platform/mac/editing/input/text-input-controller-expected.txt

When we replace a bit of selected text with a string of the same length, we now send a selection change notification. The selection endpoints aren't changing their positions in the DOM or their offsets in the document, but they're probably changing visually (unless the text is fixed width), so it seems right to send the notification.

On the other hand, this happens during a setMarkedText call, which shouldn't even touch the selection. But that's a different (and known) bug.

6:40 PM Changeset in webkit [41469] by eric@webkit.org

8 edits in trunk/WebCore

Reviewed by David Hyatt.

Changes to RenderLayer destruction to hopefully help catch an elusive crasher
https://bugs.webkit.org/show_bug.cgi?id=24409

Added a new RenderBoxModelObject::destroyLayer() call which is
now the only way which RenderLayers should ever be destroyed.
This ensures that the pointer to the layer is cleared in the
RenderObject after destruction, allowing us to ASSERT in the
RenderBoxModelObject destructor.

rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::destroyLayer): (WebCore::RenderBoxModelObject::destroy): (WebCore::RenderBoxModelObject::styleDidChange):
rendering/RenderBoxModelObject.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::destroy): (WebCore::RenderLayer::removeOnlyThisLayer):
rendering/RenderLayer.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):

6:35 PM Changeset in webkit [41468] by eric@webkit.org

5 edits in trunk/WebCore

Reviewed by David Hyatt.

Remove old, unused IE 5.5 scrollbar-* CSS properties.
Sort the unimplemented getComputedStyle properties so it's
easier to see which ones actually need implementation.

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):

5:42 PM Changeset in webkit [41467] by adele@apple.com

2 edits in trunk/WebKit/mac

2009-03-05 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=24079
<rdar://problem/6611233> REGRESSION (r39549): Page loads cannot be interrupted with Command-. or Escape
<rdar://problem/6636563> Ctrl-tab shortcut doesn't switch tabs when focus is in text field

WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]): If WebKit does not support the command, we need to pass the selector to super. In this case, we'll consider the event not to be handled. This is not perfect because in theory, [super doCommandBySelector:] can do some action that would cause WebKit to need to consider the event handled. But in practice, I've found no example of that happening and causing broken behavior.

5:25 PM Changeset in webkit [41466] by justin.garcia@apple.com

2 edits in trunk/WebCore/editing

Make changes to previous checkin from the code review.

5:00 PM Changeset in webkit [41465] by justin.garcia@apple.com

49 edits in trunk

WebCore:

2009-03-05 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

WebViewDidChangeSelectionNotifications weren't being sent for commands that change the selection's position
within the document without changing its position in the DOM. For example, pressing return in (caret marked by ^{):

<div contentEditable="true"><div>}Hello</div></div>
Undo was being enabled, shouldDeleteDOMRange called, etc. when doing no-op deletes (a delete in an empty document
for example).

Changes to layout tests demonstrate fix.

editing/EditCommand.cpp: (WebCore::EditCommand::apply): Don't call applyEditing for a TypingCommand. The TypingCommand knows whether or not it did work that needs to be applied.
editing/Editor.cpp: (WebCore::Editor::appliedEditing): Moved code (but did not alter) to changeSelectionAfterCommand. (WebCore::Editor::unappliedEditing): Ditto. (WebCore::Editor::reappliedEditing): Ditto. (WebCore::Editor::changeSelectionAfterCommand): Moved code from *appliedEditing into here. Also call out to EditorClient::respondToChangedSelection() for commands that changed the selection's position in the document even if they did not change it's position in the DOM. Any TypingCommand that gets this far changed it's position in the document.
editing/Editor.h:
editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): Removed unused m_appliedEditing. (WebCore::TypingCommand::typingAddedToOpenCommand): Always apply editing. We won't get this far if we don't need to. (WebCore::TypingCommand::deleteKeyPressed): Don't do any of the things that only make sense for Range selections, like adding to the killring and responding to a change in selections if the delete was a no-op. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
editing/TypingCommand.h:

LayoutTests:

2009-03-05 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

WebViewDidChangeSelectionNotification isn't always called.
Undo was enabled, shouldDeleteDOMRange was called, etc. for no-op backward and forward deletes.

platform/mac/editing/deleting/delete-4038408-fix-expected.txt:
platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
platform/mac/editing/deleting/delete-br-002-expected.txt:
platform/mac/editing/deleting/delete-br-004-expected.txt:
platform/mac/editing/deleting/delete-br-005-expected.txt:
platform/mac/editing/deleting/delete-br-006-expected.txt:
platform/mac/editing/deleting/delete-br-009-expected.txt:
platform/mac/editing/deleting/delete-br-010-expected.txt:
platform/mac/editing/deleting/delete-hr-expected.txt:
platform/mac/editing/deleting/delete-tab-004-expected.txt:
platform/mac/editing/deleting/forward-delete-expected.txt:
platform/mac/editing/deleting/merge-into-empty-block-1-expected.txt:
platform/mac/editing/deleting/merge-into-empty-block-2-expected.txt:
platform/mac/editing/inserting/editing-empty-divs-expected.txt:
platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
platform/mac/editing/inserting/insert-br-004-expected.txt:
platform/mac/editing/inserting/insert-br-005-expected.txt:
platform/mac/editing/inserting/insert-br-006-expected.txt:
platform/mac/editing/inserting/insert-br-008-expected.txt:
platform/mac/editing/inserting/insert-div-006-expected.txt:
platform/mac/editing/inserting/insert-div-008-expected.txt:
platform/mac/editing/inserting/insert-div-010-expected.txt:
platform/mac/editing/inserting/insert-div-011-expected.txt:
platform/mac/editing/inserting/insert-div-013-expected.txt:
platform/mac/editing/inserting/insert-div-015-expected.txt:
platform/mac/editing/inserting/insert-div-019-expected.txt:
platform/mac/editing/inserting/insert-div-021-expected.txt:
platform/mac/editing/inserting/insert-paragraph-01-expected.txt:
platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
platform/mac/editing/inserting/insert-paragraph-05-expected.txt:
platform/mac/editing/inserting/insert-tab-004-expected.txt:
platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
platform/mac/editing/inserting/line-break-expected.txt:
platform/mac/editing/pasteboard/3976872-expected.txt:
platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
platform/mac/editing/pasteboard/paste-text-010-expected.txt:
platform/mac/editing/style/block-style-006-expected.txt:
platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
platform/mac/editing/undo/undo-combined-delete-expected.txt:
platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
platform/mac/editing/undo/undo-forward-delete-expected.txt:

4:35 PM Changeset in webkit [41464] by eric@webkit.org

1 edit
35 moves
4 adds
1 delete in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Move all of the fast/css/*computed* tests into fast/css/getComputedStyle
in preparation for adding a bunch more getComputedStyle tests.

fast/css/getComputedStyle/computed-style-display-none-expected.txt: Renamed from LayoutTests/fast/css/computed-style-display-none-expected.txt.
fast/css/getComputedStyle/computed-style-display-none.html: Renamed from LayoutTests/fast/css/computed-style-display-none.html.
fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/fast/css/computed-style-expected.txt.
fast/css/getComputedStyle/computed-style-negative-top-expected.txt: Renamed from LayoutTests/fast/css/computed-style-negative-top-expected.txt.
fast/css/getComputedStyle/computed-style-negative-top.html: Renamed from LayoutTests/fast/css/computed-style-negative-top.html.
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/fast/css/computed-style-without-renderer-expected.txt.
fast/css/getComputedStyle/computed-style-without-renderer.html: Renamed from LayoutTests/fast/css/computed-style-without-renderer.html.
fast/css/getComputedStyle/computed-style.html: Renamed from LayoutTests/fast/css/computed-style.html.
fast/css/getComputedStyle/getComputedStyle-background-position-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-background-position-expected.txt.
fast/css/getComputedStyle/getComputedStyle-background-position.html: Renamed from LayoutTests/fast/css/getComputedStyle-background-position.html.
fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-background-size-expected.txt.
fast/css/getComputedStyle/getComputedStyle-background-size.html: Renamed from LayoutTests/fast/css/getComputedStyle-background-size.html.
fast/css/getComputedStyle/getComputedStyle-border-box-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-box-expected.txt.
fast/css/getComputedStyle/getComputedStyle-border-box.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-box.html.
fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-image-expected.txt.
fast/css/getComputedStyle/getComputedStyle-border-image.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-image.html.
fast/css/getComputedStyle/getComputedStyle-border-spacing-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-spacing-expected.txt.
fast/css/getComputedStyle/getComputedStyle-border-spacing.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-spacing.html.
fast/css/getComputedStyle/getComputedStyle-borderRadius-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-borderRadius-expected.txt.
fast/css/getComputedStyle/getComputedStyle-borderRadius.html: Renamed from LayoutTests/fast/css/getComputedStyle-borderRadius.html.
fast/css/getComputedStyle/getComputedStyle-relayout-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-relayout-expected.txt.
fast/css/getComputedStyle/getComputedStyle-relayout.html: Renamed from LayoutTests/fast/css/getComputedStyle-relayout.html.
fast/css/getComputedStyle/getComputedStyle-transform-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-transform-expected.txt.
fast/css/getComputedStyle/getComputedStyle-transform.html: Renamed from LayoutTests/fast/css/getComputedStyle-transform.html.
fast/css/getComputedStyle/getComputedStyle-zIndex-auto-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-zIndex-auto-expected.txt.
fast/css/getComputedStyle/getComputedStyle-zIndex-auto.html: Renamed from LayoutTests/fast/css/getComputedStyle-zIndex-auto.html.
fast/css/marginComputedStyle.html: Removed.
platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/computed-style-expected.txt.
platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/computed-style-without-renderer-expected.txt.
platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.checksum: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.checksum.
platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.png: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.png.
platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.txt.
platform/qt/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/computed-style-expected.txt.
platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/computed-style-without-renderer-expected.txt.
platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/win/fast/css/computed-style-expected.txt.
platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/win/fast/css/computed-style-without-renderer-expected.txt.

3:18 PM Changeset in webkit [41463] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-03-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Roben.

Eliminate a ref-counting leak in InspectorController.

inspector/InspectorController.h: Made constructor private, added static create method.
page/Page.cpp: (WebCore::Page::Page): Change initializer to use static create method.

2:58 PM Changeset in webkit [41462] by Dimitri Glazkov

11 edits
2 adds in trunk/WebCore

2009-03-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24355
Add InspectorController.idl and convert InspectorController.cpp to use
JSC bindings.

DerivedSources.make: Added InspectorController.idl
WebCore.xcodeproj/project.pbxproj: Added idl, bindings files.
bindings/js/JSInspectorControllerCustom.cpp: Added.
bindings/scripts/CodeGeneratorJS.pm: Added Array to no-header types.
inspector/InspectorController.cpp: Removed hand-rolled bindings.
inspector/InspectorController.h: Added platform and addSourceToFrame methods.
inspector/InspectorController.idl: Added.
page/Page.h: Changed member to RefPtr since InspectorController is now ref-counted.

2:56 PM Changeset in webkit [41461] by eric.carlson@apple.com

10 edits
2 adds
24 deletes in trunk

2009-03-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24400
Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
media element attributes

Test: media/video-loop.html

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::loadInternal): (WebCore::HTMLMediaElement::setNetworkState): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::playInternal): (WebCore::HTMLMediaElement::loop): (WebCore::HTMLMediaElement::setLoop): (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): (WebCore::HTMLMediaElement::endedPlayback): (WebCore::HTMLMediaElement::updatePlayState):
html/HTMLMediaElement.h:
html/HTMLMediaElement.idl:

2009-03-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24400
Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
media element attributes

media/loopend-limits-expected.txt: Removed.
media/loopend-limits.html: Removed.
media/loopstart-limits-expected.txt: Removed.
media/loopstart-limits.html: Removed.
media/video-dom-end-expected.txt: Removed.
media/video-dom-end.html: Removed.
media/video-dom-loopcount-expected.txt: Removed.
media/video-dom-loopcount.html: Removed.
media/video-dom-loopend-expected.txt: Removed.
media/video-dom-loopend.html: Removed.
media/video-dom-loopstart-expected.txt: Removed.
media/video-dom-loopstart.html: Removed.
media/video-dom-start-expected.txt: Removed.
media/video-dom-start.html: Removed.
media/video-end-expected.txt: Removed.
media/video-end.html: Removed.
media/video-loop.html: Added, test for new "loop" attribute.
media/video-loopcount-expected.txt: Removed.
media/video-loopcount.html: Removed.
media/video-loopend-expected.txt: Removed.
media/video-loopend.html: Removed.
media/video-loopstart-expected.txt: Removed.
media/video-loopstart.html: Removed.
media/video-seek-past-end-paused-expected.txt: Updated for loop changes, add more tests.
media/video-seek-past-end-paused.html: Ditto.
media/video-seek-past-end-playing-expected.txt: Ditto.
media/video-seek-past-end-playing.html: Ditto.
media/video-start-expected.txt: Removed.
media/video-start.html: Removed.

2:16 PM Changeset in webkit [41460] by sfalken@apple.com

2 edits in trunk/WebCore

<rdar://problem/6651112> Safari asks about re-posting a form even when page is cached

Reviewed by Ada Chan.

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::willLoadFromCache): Ported from Mac version.

2:11 PM Changeset in webkit [41459] by pam@chromium.org

1 edit in trunk/LayoutTests/ChangeLog

2009-03-05 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test for potential crash in window.frames.length
https://bugs.webkit.org/show_bug.cgi?id=24339

fast/dom/Window/window-collection-length-no-crash-expected.txt: Added.
fast/dom/Window/window-collection-length-no-crash.html: Added.

12:37 PM Changeset in webkit [41458] by hyatt@apple.com

3 edits in trunk/WebCore

2009-03-05 David Hyatt <hyatt@apple.com>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=24248

Make sure painting of overflow controls checks that visibility:visible is set on the block before
painting. Pixel tests caught this regression.

Make sure resizer painting pushes a clip of the corner rect. It was relying on the clip layers happened
to do to their bounds (which had nothing to do with overflow).

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintResizer):

11:58 AM Changeset in webkit [41457] by treat@webkit.org

2 edits in trunk/WebCore

2009-03-05 Yong Li <yong.li@torchmobile.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24386
A faster implementation of extractMIMETypeFromMediaType.

platform/network/HTTPParsers.cpp: (WebCore::extractMIMETypeFromMediaType):

11:58 AM Changeset in webkit [41456] by treat@webkit.org

2 edits in trunk/WebCore

2009-03-05 Yong Li <yong.li@torchmobile.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=24392
Do not get the current time for unless we're doing PRELOAD_DEBUG as this
can be unnecessarily expensive.

html/PreloadScanner.cpp: (WebCore::PreloadScanner::write):

11:39 AM Changeset in webkit [41455] by Simon Fraser

4 edits in trunk/WebCore

2009-03-04 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24327

When mapping points and hit testing through transforms, work
correctly when acclerated animations of transforms are running.

Tested by LayoutTests/animations/animation-hit-test-transform.html,
which only failed when ACCELERATED_COMPOSITING was turned on.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::currentTransform):
rendering/RenderLayer.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):

11:17 AM Changeset in webkit [41454] by darin@chromium.org

2 edits in trunk/WebCore

2009-03-05 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24391
Frame.cpp uses JSC specific includes

page/Frame.cpp:

10:40 AM Changeset in webkit [41453] by kov@webkit.org

2 edits in trunk/WebCore

2009-03-05 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24389
WebKitGTK+ crashes when cancelling plugin loads

Remove bogus calls to the client's didFinishLoading method from
our ResourceHandle::cancel implementation. Calling
didFinishLoading here is mostly inoffensive for most loads, but
causes crashes when plugin loads are cancelled.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::cancel):

10:34 AM Changeset in webkit [41452] by sfalken@apple.com

2 edits in trunk/WebCore

2009-03-05 Steve Falkenburg <sfalken@apple.com>

Windows build fix.

WebCore.vcproj/QTMovieWin.vcproj:

10:16 AM Changeset in webkit [41451] by treat@webkit.org

2 edits in trunk/WebCore

2009-03-05 Adam Treat <adam.treat@torchmobile.com>

Build fix for when ENABLE_NETSCAPE_PLUGIN_API = 0. The method
ScriptController::jsObjectForPluginElement(HTMLPlugInElement*); is not
protected by an #if and uses HTMLPlugInElement so it must be included.

bindings/js/ScriptController.cpp:

9:34 AM Changeset in webkit [41450] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-05 Dimitri Glazkov <Dimitri Glazkov>

GTK Build fix.

inspector/ConsoleMessage.h: Use proper header.

9:14 AM Changeset in webkit [41449] by Dimitri Glazkov

8 edits
8 adds in trunk/WebCore

2009-03-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24376
Split InspectorController.cpp file into separate classes.

GNUmakefile.am: Modified to include new files.
WebCore.pro: Ditto.
WebCore.scons: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
WebCoreSources.bkl: Ditto.
inspector/ConsoleMessage.cpp: Added.
inspector/ConsoleMessage.h: Added.
inspector/InspectorController.cpp:
inspector/InspectorDOMStorageResource.cpp: Added.
inspector/InspectorDOMStorageResource.h: Added.
inspector/InspectorDatabaseResource.cpp: Added.
inspector/InspectorDatabaseResource.h: Added.
inspector/InspectorResource.cpp: Added.
inspector/InspectorResource.h: Added.

9:12 AM Changeset in webkit [41448] by eric.carlson@apple.com

4 edits in trunk/WebCore

2009-03-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24387
Remove media element bufferingRate attribute. No test necessary as there
were none for this attribute.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Don't initialize m_bufferingRate. (WebCore::HTMLMediaElement::loadInternal): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::progressEventTimerFired): Don't calculate m_bufferingRate.
html/HTMLMediaElement.h: Remove m_bufferingRate.
html/HTMLMediaElement.idl: Ditto.

4:47 AM Changeset in webkit [41447] by xan@webkit.org

3 edits in trunk/WebCore

2009-03-05 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24377
[GTK] Comply better with coding style guidelines in ResourceHandleSoup

Use C++ booleans, 0 instead of NULL, prefix boolean variables with
'is', do not use 'else if' if the previous if had a return, delete
trailing whitespace, etc.

platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::fillResponseFromMessage): (WebCore::restartedCallback): (WebCore::finishedCallback): (WebCore::parseDataUrl): (WebCore::ensureSessionIsInitialized): (WebCore::ResourceHandle::startHttp): (WebCore::reportUnknownProtocolError): (WebCore::ResourceHandle::start): (WebCore::cleanupGioOperation): (WebCore::closeCallback): (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback): (WebCore::ResourceHandle::startGio):

2:06 AM Changeset in webkit [41446] by ariya@webkit.org

2 edits in trunk/WebKit/qt

2009-03-05 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] NPAPI plugins are supported, adjust the API documentation.

Api/qwebsettings.cpp:

12:05 AM Changeset in webkit [41445] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

Fix the build.

Sprinkle "static" around NumberConstructor.cpp in order to please the compiler.

runtime/NumberConstructor.cpp:

(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):

Mar 4, 2009:

11:28 PM Changeset in webkit [41444] by mrowe@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/6206172> Adoption of new Cocoa API for dictionary contextual menu

Reviewed by Dan Bernstein.

WebView/WebHTMLView.mm:

(-[WebHTMLView _lookUpInDictionaryFromMenu:]):

10:04 PM Changeset in webkit [41443] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

<rdar://problem/6354858> FastMallocZone's enumeration code reports fragmented administration space

Reviewed by Oliver Hunt.

The handling of MALLOC_ADMIN_REGION_RANGE_TYPE in FastMalloc's zone was incorrect. It was attempting
to record the memory containing and individual span as an administrative region, when all memory
allocated via MetaDataAlloc should in fact be recorded. This was causing memory regions allocated
via MetaDataAlloc to appear as "VM_ALLOCATE ?" in vmmap output. They are now correctly reported as
"MALLOC_OTHER" regions associated with the JavaScriptCore FastMalloc zone.

Memory is allocated via MetaDataAlloc from two locations: PageHeapAllocator, and TCMalloc_PageMap{2,3}.
These two cases are handled differently.

PageHeapAllocator is extended to keep a linked list of memory regions that it has allocated. The
first object in an allocated region contains the link to the previously allocated region. To record
the administrative regions of a PageHeapAllocator we can simply walk the linked list and record
each allocated region we encounter.

TCMalloc_PageMaps allocate memory via MetaDataAlloc to store each level of the radix tree. To record
the administrative regions of a TCMalloc_PageMap we walk the tree and record the storage used for nodes
at each position rather than the nodes themselves.

A small performance improvement is achieved by coalescing adjacent memory regions inside the PageMapMemoryUsageRecorder
so that fewer calls in to the range recorder are necessary. We further reduce the number of calls to the
range recorder by aggregating the in-use ranges of a given memory region into a local buffer before recording
them with a single call. A similar approach is also used by AdminRegionRecorder.

wtf/FastMalloc.cpp:

(WTF::PageHeapAllocator::Init):
(WTF::PageHeapAllocator::New):
(WTF::PageHeapAllocator::recordAdministrativeRegions):
(WTF::TCMallocStats::FreeObjectFinder::isFreeObject):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::~PageMapMemoryUsageRecorder):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::recordPendingRegions):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::AdminRegionRecorder):
(WTF::TCMallocStats::AdminRegionRecorder::recordRegion):
(WTF::TCMallocStats::AdminRegionRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::recordPendingRegions):
(WTF::TCMallocStats::AdminRegionRecorder::~AdminRegionRecorder):
(WTF::TCMallocStats::FastMallocZone::enumerate):
(WTF::TCMallocStats::FastMallocZone::FastMallocZone):
(WTF::TCMallocStats::FastMallocZone::init):

wtf/TCPageMap.h:

(TCMalloc_PageMap2::visitValues):
(TCMalloc_PageMap2::visitAllocations):
(TCMalloc_PageMap3::visitValues):
(TCMalloc_PageMap3::visitAllocations):

7:10 PM Changeset in webkit [41442] by oliver@apple.com

2 edits
2 adds in trunk/SunSpider

Added a few more tests to ubench

RS=Gavin Barraclough

Adding a couple of test to cover too few and too many arguments. This
is needed to prevent regressions in all call paths from my current refactoring.

6:36 PM Changeset in webkit [41441] by Simon Fraser

2 edits in trunk/WebCore

2009-03-04 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=24328

If an element has backface-visibility: hidden, hit testing should not
hit the back sides of elements. Test for that by inverting the accumulated
transform and looking at the z vector.

Tested by transforms/3d/hit-testing/backface-hit-test.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):

6:11 PM Changeset in webkit [41440] by Simon Fraser

1 edit
21 adds in trunk/LayoutTests

2009-03-04 Simon Fraser <Simon Fraser>

Rubber-stamped by Eric Seidel.

New layout tests for point mapping and hit testing through 3d transforms.
Not run by default yet.

platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt: Added.
platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
transforms/3d/cssmatrix-3d-interface-expected.txt: Added.
transforms/3d/cssmatrix-3d-interface.xhtml: Added.
transforms/3d/hit-testing/backface-hit-test.html: Added.
transforms/3d/point-mapping/3d-point-mapping-2.html: Added.
transforms/3d/point-mapping/3d-point-mapping-deep.html: Added.
transforms/3d/point-mapping/3d-point-mapping-origins.html: Added.
transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html: Added.
transforms/3d/point-mapping/3d-point-mapping.html: Added.
transforms/3d/point-mapping/point-mapping-helpers.js: Added. (mousemoved): (dispatchEvent): (clicked): (log): (runTest):

5:13 PM Changeset in webkit [41439] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

2009-03-04 Eric Carlson <eric.carlson@apple.com>

Correct bogus result checked in as part of r41432.

media/video-can-play-type-expected.txt:

4:57 PM Changeset in webkit [41438] by eric@webkit.org

2 edits in trunk/WebCore

2009-03-04 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

r41362 mistakenly added functions "RenderThemeWin::" into
RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
them to void return types. This patch switches them back to ints.

https://bugs.webkit.org/show_bug.cgi?id=24360

rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):

4:57 PM Changeset in webkit [41437] by eric@webkit.org

3 edits in trunk/WebCore

2009-03-04 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: change some metrics to better match Windows after
r41416. Aesthetically this may be worse, but web-compat is king.

Also, the previous code had an off by one error when drawing
scrollbars which caused the scrollbar to overflow it's bounds by 1px
at the right and bottom edges.

https://bugs.webkit.org/show_bug.cgi?id=24369

rendering/RenderThemeChromiumLinux.cpp: (WebCore::): (WebCore::RenderThemeChromiumLinux::systemFont):
platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::paintTrackPiece):

3:48 PM Changeset in webkit [41436] by pam@chromium.org

1 edit
2 adds in trunk/LayoutTests

2009-03-04 Pamela Greene <pam@chromium.org>

Reviewed by Darin Fisher.

Add test to ensure that window.frames is self-referential
https://bugs.webkit.org/show_bug.cgi?id=24341

fast/dom/Window/window-frames-self-referential-expected.txt: Added.
fast/dom/Window/window-frames-self-referential.html: Added.

2:58 PM Changeset in webkit [41435] by eric@webkit.org

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Add an ASSERT to better demonstrate the cause of the crash in
https://bugs.webkit.org/show_bug.cgi?id=23736

loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader):

2:29 PM Changeset in webkit [41434] by levin@chromium.org

3 edits
5 adds in trunk

WebCore:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<https://bugs.webkit.org/show_bug.cgi?id=24337>

Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html

http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html

loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willCacheResponse): An identifier is only asssigned if resource load callbacks are done. So don't send willCacheResponse which uses identifier if resource load callbacks aren't being sent.

LayoutTests:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<https://bugs.webkit.org/show_bug.cgi?id=24337>

http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt: Added.
http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html: Added.
http/tests/xmlhttprequest/workers/resources/xmlhttprequest-file-not-found.js: Added. (log): (done):
http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found-expected.txt: Added.
http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html: Added.

2:29 PM Changeset in webkit [41433] by levin@chromium.org

4 edits
4 adds in trunk

WebCore:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
<https://bugs.webkit.org/show_bug.cgi?id=24330>

Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html

dom/ExceptionCode.cpp: (WebCore::xmlHttpRequestExceptionNames): Added missing ABORT_ERR whose absence caused an assert.

loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): Add more logic to handle the termination case for sync xhr.

LayoutTests:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
<https://bugs.webkit.org/show_bug.cgi?id=24330>

Added test to verify to terminate a worker while it is doing a synchronous xhr.
It does not verify that the exception is a ABORT_ERR because I couldn't figure out a way
to actually do this.

http/tests/xmlhttprequest/workers/abort-exception-assert-expected.txt: Added.
http/tests/xmlhttprequest/workers/abort-exception-assert.html: Added.
http/tests/xmlhttprequest/workers/resources/endless-response.php: Copied from LayoutTests/http/tests/xmlhttprequest/resources/endlessxml.php.
http/tests/xmlhttprequest/workers/resources/endless-sync-xhr.js: Added.

2:21 PM Changeset in webkit [41432] by eric.carlson@apple.com

8 edits
2 adds in trunk

2009-03-04 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=24364
Add support for HTMLMediaElement canPlayType method. Make
MediaPlayer::supportsType take a ContentType instead of a
separate mime type and codecs parameter.

Test: media/video-can-play-type.html

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method. (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType. (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type. (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
html/HTMLMediaElement.h: Add prototype.
html/HTMLMediaElement.idl: Ditto.
platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type. (WebCore::MediaPlayer::supportsType): Ditto.
platform/graphics/MediaPlayer.h:

2009-03-04 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=24364
Test HTMLMediaElement canPlayType method.

media/video-can-play-type-expected.txt: Added.
media/video-can-play-type.html: Added.

2:01 PM Changeset in webkit [41431] by Antti Koivisto

7 edits in trunk

JavaScriptCore:

2009-03-04 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24359
Repaint throttling mechanism

Set ENABLE_REPAINT_THROTTLING to 0 by default.

wtf/Platform.h:

WebCore:

2009-03-04 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24359
Repaint throttling mechanism

Excessive repainting can slow down page loadind. This implements a timer
based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not
enabled by default.

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkCompleted):
page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::handleTextInputEvent):
page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::reset): (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::beginDeferredRepaints): (WebCore::FrameView::endDeferredRepaints): (WebCore::FrameView::checkStopDelayingDeferredRepaints): (WebCore::FrameView::doDeferredRepaints): (WebCore::FrameView::updateDeferredRepaintDelay): (WebCore::FrameView::resetDeferredRepaintDelay): (WebCore::FrameView::adjustedDeferredRepaintDelay): (WebCore::FrameView::deferredRepaintTimerFired): (WebCore::FrameView::paintContents):
page/FrameView.h:

1:53 PM Changeset in webkit [41430] by weinig@apple.com

9 edits in trunk/WebCore

2009-03-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Antti Koivisto.

Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.

dom/Document.cpp: (WebCore::Document::Document):
dom/Document.h: (WebCore::Document::haveStylesheetsLoaded):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
loader/Cache.cpp: (WebCore::Cache::requestResource):
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
loader/DocLoader.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::endIfNotLoadingMainResource): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::loadItem):
loader/FrameLoader.h:

1:24 PM Changeset in webkit [41429] by kmccullough@apple.com

6 edits in trunk/LayoutTests

2009-03-04 Kevin McCullough <kmccullough@apple.com>

Build bot fix.

fast/profiler/many-calls-in-the-same-scope-expected.txt:
fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
fast/profiler/nested-start-and-stop-profiler-expected.txt:
fast/profiler/profile-calls-in-included-file-expected.txt:

12:57 PM Changeset in webkit [41428] by xan@webkit.org

8 edits
2 moves in trunk

2009-03-02 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Add WebKitSoupAuthDialog files to build.

GNUmakefile.am:

WebCore:

2009-03-02 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Remove WebKitSoupAuthDialog files from build and stop using it.

GNUmakefile.am:
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):
platform/network/soup/webkit-soup-auth-dialog.c: Removed.
platform/network/soup/webkit-soup-auth-dialog.h: Removed.

WebKit/gtk:

2009-03-02 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Add WebKitSoupAuthDialog and add it to the session in webkit_init.

webkit/webkitprivate.cpp: (currentToplevelCallback): (webkit_init):
webkit/webkitsoupauthdialog.c: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (free_authData): (set_password_callback): (response_callback): (table_add_entry): (show_auth_dialog): (find_password_callback): (session_authenticate): (attach):
webkit/webkitsoupauthdialog.h: Added.

11:58 AM Changeset in webkit [41427] by Simon Fraser

3 edits
4 adds in trunk

2009-03-04 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24361

Reinstate code that sets result.innerNode when hitTest() returns true,
but never filled in the innerNode. Fixes hit testing of generated content.

Test: fast/css-generated-content/hit-test-generated-content.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):

11:56 AM Changeset in webkit [41426] by abarth@webkit.org

18 edits in trunk

WebCore:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

WebCore.base.exp:
dom/Document.cpp: (WebCore::Document::initSecurityContext):
page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
page/Settings.h: (WebCore::Settings::allowUniversalAccessFromFileURLs):

WebKit/mac:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowUniversalAccessFromFileURLs]): (-[WebPreferences setAllowUniversalAccessFromFileURLs:]):
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/qt:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):

WebKit/win:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::allowUniversalAccessFromFileURLs): (WebPreferences::setAllowUniversalAccessFromFileURLs):
WebPreferences.h:
WebView.cpp: (WebView::notifyPreferencesChanged):

10:25 AM Changeset in webkit [41425] by beidson@apple.com

2 edits in trunk/WebCore

2009-03-04 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.

I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
consolidated some of the various decision making pieces of the Cache into the new method
FrameLoader::cachePolicy().

Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader
is reloading. If it is, we'd evict any existing resource then recreate it. Quick looks uses the
same URL for this image every time and expects it to be reloaded with each new card.

The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
is "ReloadIgnoringCacheData". This check was lost in the consolidation to the new method.

loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible condition for returning CachePolicyReload.

9:59 AM Changeset in webkit [41424] by timothy@apple.com

2 edits in trunk/WebCore

English.lproj/localizedStrings.js: Update strings to include "DATABASES", "LOCAL STORAGE" and "SESSION STORAGE".

9:59 AM Changeset in webkit [41423] by timothy@apple.com

2 edits in trunk/WebCore

Fix a regression where the Web Inspector console would not animate
in or out correctly.

Reviewed by Anders Carlsson.

inspector/front-end/inspector.css: Move a z-index to a child element to get the correct stacking order during the animation.

9:56 AM Changeset in webkit [41422] by hyatt@apple.com

5 edits
4 adds in trunk

WebCore:

2009-03-03 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.

Make sure to factor clear deltas into y position estimates. Also avoid doing the comparison of
the final position against the y position estimate until after the clear has happened. This gets rid
of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.

Reviewed by Dan Bernstein

Added fast/block/float/nested-clearance.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::getClearDelta):
rendering/RenderBlock.h:

LayoutTests:

2009-03-03 David Hyatt <hyatt@apple.com>

Test case for https://bugs.webkit.org/show_bug.cgi?id=24201

Reviewed by Dan Bernstein

fast/block/float/nested-clearance.html: Added.
platform/mac/fast/block/float/nested-clearance-expected.checksum: Added.
platform/mac/fast/block/float/nested-clearance-expected.png: Added.
platform/mac/fast/block/float/nested-clearance-expected.txt: Added.

9:39 AM Changeset in webkit [41421] by abarth@webkit.org

3 edits in trunk/WebKit/qt

2009-03-03 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24340

Expose AllowUniversalAccessFromFileUrls to Qt clients.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
Api/qwebsettings.h:

6:42 AM Changeset in webkit [41420] by Simon Hausmann

8 edits in trunk/WebCore

2009-03-02 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

Improvement to 3d transformations rendering in QtWebKit. QTransform is used
instead of QMatrix. This allows perspective transformations since QTransform is
a true 3x3 matrix.

6:21 AM Changeset in webkit [41419] by Simon Hausmann

3 edits in trunk/WebCore

2009-02-24 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=24151
Fix Qt/S60 build break

1:56 AM BuildingGtk edited by oszi@inf.u-szeged.hu

(diff)

1:54 AM QtWebKitTodo edited by Simon Hausmann

(diff)

Mar 3, 2009:

11:20 PM Changeset in webkit [41418] by darin@chromium.org

2 edits in trunk/WebCore

2009-03-03 Mike Belshe <mike@belshe.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=21939
Uninitialized ExceptionCode in DOMWindow::postMessage

dom/MessagePort.cpp: (WebCore::MessagePort::postMessage):

10:49 PM Changeset in webkit [41417] by ddkilzer@apple.com

11 edits in trunk

<rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase

Reviewed by Mark Rowe.

JavaScriptCore:

Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger. Updated HAVE_DTRACE to use REAL_PLATFORM_NAME.

WebCore:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
sure various build phase scripts work with the installhdrs build
phase.

Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
Configurations/WebCore.xcconfig: Added JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in the "Generate Derived Sources" script. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.

WebCore.xcodeproj/project.pbxproj:
Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
Made "Generate Derived Sources" work for the installhdrs build phase. Also simplified setting of CREATE_HASH_TABLE by using JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.

WebKit:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.

WebKit.xcodeproj/project.pbxproj:
Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
Removed UMBRELLA_FRAMEWORKS_DIR from the Debug and Release targets since it's no longer needed after defining WEBCORE_PRIVATE_HEADERS_DIR in WebKit.xcconfig.

WebKit/mac:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.

Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
Configurations/WebKit.xcconfig: Added WEBCORE_PRIVATE_HEADERS_DIR variable to remove definition of UMBRELLA_FRAMEWORKS_DIR for Debug and Release builds in the Xcode project file. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.

10:09 PM Changeset in webkit [41416] by darin@chromium.org

6 edits
2 moves in trunk/WebCore

2009-03-02 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: Switch to using Skia to render widgets.

In order to sandbox the Chromium renderer on Linux we need to remove
the X connection. GTK cannot render without an X connection so, for
now, we render widgets ourselves.

Previously didn't use anti-alias fonts in order to match Windows font
rendering exactly. This was helpful when bootstrapping our layout
tests. Now, however, we are ready to enable it.

https://bugs.webkit.org/show_bug.cgi?id=24244

platform/chromium/ScrollbarThemeChromium.cpp: (WebCore::ScrollbarThemeChromium::buttonSize):
platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::scrollbarThickness): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintButton): (WebCore::ScrollbarThemeChromium::paintThumb):
platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::~PlatformContextSkia):
platform/graphics/skia/PlatformContextSkia.h:
rendering/RenderThemeChromiumGtk.cpp: Removed.
rendering/RenderThemeChromiumGtk.h: Removed.
rendering/RenderThemeChromiumLinux.cpp: Added.
rendering/RenderThemeChromiumLinux.h: Added.

9:39 PM Changeset in webkit [41415] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix return types.

Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg

bindings/v8/V8Binding.h: (WebCore::toInt32): change return type to int (WebCore::toFloat): change return type to float.

5:10 PM Changeset in webkit [41414] by andersca@apple.com

7 edits in trunk

WebCore:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Null check NPStream before dereferencing it.

plugins/PluginView.cpp: (WebCore::PluginView::destroyStream):

WebKitTools:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Add destroyNullStream test function to the test plug-in.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (destroyNullStream): (pluginInvoke):

LayoutTests:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Update tests.

plugins/destroy-stream-twice-expected.txt:
plugins/destroy-stream-twice.html:

5:06 PM Changeset in webkit [41413] by eric.carlson@apple.com

117 edits in trunk/LayoutTests

2009-03-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24294
Bug 24294: Improve media layout test logging

Make all media layout tests log the condition that is being tested,
success or failure, plus observed value when a test condition fails
so it is possible to see exactly what failed without having to hack
the test source. Consolidate some of the logic in the shared JavaScript file.

media/audio-constructor-expected.txt:
media/audio-constructor-src-expected.txt:
media/audio-constructor-src.html:
media/audio-constructor.html:
media/audio-mpeg-supported-expected.txt:
media/audio-mpeg-supported.html:
media/broken-video-expected.txt:
media/broken-video.html:
media/constructors-expected.txt:
media/constructors.html:
media/loopend-limits-expected.txt:
media/loopstart-limits-expected.txt:
media/progress-event-expected.txt:
media/progress-event-total-expected.txt:
media/progress-event-total.html:
media/progress-event.html:
media/remove-from-document-expected.txt:
media/remove-from-document-no-load-expected.txt:
media/remove-from-document-no-load.html:
media/remove-from-document.html:
media/unsupported-rtsp-expected.txt:
media/unsupported-rtsp.html:
media/unsupported-tracks-expected.txt:
media/unsupported-tracks.html:
media/video-append-source-expected.txt:
media/video-append-source.html:
media/video-autoplay-expected.txt:
media/video-autoplay.html:
media/video-buffered-expected.txt:
media/video-buffered.html:
media/video-controls-expected.txt:
media/video-controls-transformed-expected.txt:
media/video-controls-transformed.html:
media/video-controls.html:
media/video-currentTime-expected.txt:
media/video-currentTime-set.html:
media/video-currentTime-set2-expected.txt:
media/video-currentTime-set2.html:
media/video-currentTime.html:
media/video-dom-autoplay-expected.txt:
media/video-dom-autoplay.html:
media/video-dom-end-expected.txt:
media/video-dom-end.html:
media/video-dom-loopcount-expected.txt:
media/video-dom-loopcount.html:
media/video-dom-loopend-expected.txt:
media/video-dom-loopend.html:
media/video-dom-loopstart-expected.txt:
media/video-dom-loopstart.html:
media/video-dom-src-expected.txt:
media/video-dom-src.html:
media/video-dom-start-expected.txt:
media/video-dom-start.html:
media/video-end-expected.txt:
media/video-end.html:
media/video-error-abort-expected.txt:
media/video-error-abort.html:
media/video-error-does-not-exist-expected.txt:
media/video-error-does-not-exist.html:
media/video-load-networkState-expected.txt:
media/video-load-networkState.html:
media/video-load-readyState-expected.txt:
media/video-load-readyState.html:
media/video-loopcount-expected.txt:
media/video-loopcount.html:
media/video-loopend-expected.txt:
media/video-loopend.html:
media/video-loopstart-expected.txt:
media/video-loopstart.html:
media/video-muted-expected.txt:
media/video-muted.html:
media/video-no-autoplay-expected.txt:
media/video-no-autoplay.html:
media/video-pause-empty-events-expected.txt:
media/video-pause-empty-events.html:
media/video-play-empty-events-expected.txt:
media/video-play-empty-events.html:
media/video-play-pause-events-expected.txt:
media/video-play-pause-events.html:
media/video-poster-expected.txt:
media/video-poster.html:
media/video-seek-past-end-paused-expected.txt:
media/video-seek-past-end-paused.html:
media/video-seek-past-end-playing-expected.txt:
media/video-seek-past-end-playing.html:
media/video-seekable-expected.txt:
media/video-seekable.html:
media/video-seeking-expected.txt:
media/video-seeking.html:
media/video-size-expected.txt:
media/video-size.html:
media/video-source-expected.txt:
media/video-source-media-expected.txt:
media/video-source-media.html:
media/video-source-type-expected.txt:
media/video-source-type-params-expected.txt:
media/video-source-type-params.html:
media/video-source-type.html:
media/video-source.html:
media/video-src-change-expected.txt:
media/video-src-change.html:
media/video-src-expected.txt:
media/video-src-remove-expected.txt:
media/video-src-remove.html:
media/video-src-set-expected.txt:
media/video-src-set.html:
media/video-src-source-expected.txt:
media/video-src-source.html:
media/video-src.html:
media/video-start-expected.txt:
media/video-start.html:
media/video-test.js: (test): (testExpected): (waitForEvent._eventCallback): (waitForEvent): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (logResult):
media/video-volume-expected.txt:
media/video-volume.html:
media/video-width-height-expected.txt:
media/video-width-height.html:

4:44 PM Changeset in webkit [41412] by eric.carlson@apple.com

3 edits in trunk/WebCore

2009-03-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix for <rdar://problem/6641045>
Don't call QTKit to get movie properties until movie metadata has been loaded.

platform/graphics/mac/MediaPlayerPrivateQTKit.h: (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable. (WebCore::MediaPlayerPrivate::play): Ditto. (WebCore::MediaPlayerPrivate::pause): Ditto. (WebCore::MediaPlayerPrivate::duration): Ditto. (WebCore::MediaPlayerPrivate::currentTime): Ditto. (WebCore::MediaPlayerPrivate::seek): Ditto. (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto. (WebCore::MediaPlayerPrivate::paused): Ditto. (WebCore::MediaPlayerPrivate::seeking): Ditto. (WebCore::MediaPlayerPrivate::naturalSize): Ditto. (WebCore::MediaPlayerPrivate::hasVideo): Ditto. (WebCore::MediaPlayerPrivate::setVolume): Ditto. (WebCore::MediaPlayerPrivate::setRate): Ditto. (WebCore::MediaPlayerPrivate::dataRate): Ditto. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. (WebCore::MediaPlayerPrivate::totalBytes): Ditto.

4:38 PM Changeset in webkit [41411] by kmccullough@apple.com

2 edits
2 adds in trunk/LayoutTests

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6031674> JSProfiler: Multiple anonymous functions get
the same entry in profiler if called from same function

This no longer happens but I thought I'd make a test case anyway.

fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Added.
fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Added.
fast/profiler/resources/profiler-test-JS-resources.js: (anotherAnonymousFunction):

4:08 PM Changeset in webkit [41410] by kmccullough@apple.com

2 edits in trunk/WebCore

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Spelling fix.

page/Console.cpp: (WebCore::Console::profile):

3:30 PM Changeset in webkit [41409] by ddkilzer@apple.com

4 edits in trunk/WebKit

Remove last vestiges of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR from WebKit

Reviewed by Adam Roben.

Use of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR was removed in r37465
since NPAPI headers had migrated from JavaScriptCore to WebCore
before that.

WebKit:

WebKit.xcodeproj/project.pbxproj: Removed JAVASCRIPTCORE_PRIVATE_HEADERS_DIR build setting from from Debug and Release configurations.

WebKit/mac:

Configurations/WebKit.xcconfig: Removed definition of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR used in Production builds.

2:57 PM Changeset in webkit [41408] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=23657
Remove Database API callback IDLs from the project.
They were removed in r40633.

WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.

2:47 PM Changeset in webkit [41407] by kmccullough@apple.com

5 edits
2 adds in trunk

JavaScriptCore:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

profiler/Profiler.cpp: (JSC::Profiler::startProfiling): assert if there is not title to ensure we don't start profiling without one.

WebCore:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

page/Console.cpp: (WebCore::Console::profile): If there is no title assume this is a user initiated profile and give it the next incremented title name.

LayoutTests:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

fast/profiler/profile-with-no-title-expected.txt: Added.
fast/profiler/profile-with-no-title.html: Added.

2:27 PM Changeset in webkit [41406] by timothy@apple.com

1 edit in trunk/WebCore/ChangeLog

Add bug URLs for my last commit.

2:25 PM Changeset in webkit [41405] by pam@chromium.org

1 edit
6 deletes in trunk/LayoutTests

2009-03-03 Pamela Greene <pam@chromium.org>

Remove junk files that must have been accidentally committed.
Submitted without review.

fast/block/float/t0905-c414-flt-fit-01-d-g.html.orig: Removed.
fast/block/float/t0905-c414-flt-fit-01-d-g.html.rej: Removed.
fast/block/float/t0905-c5525-fltblck-00-d-ag.html.orig: Removed.
fast/block/float/t0905-c5525-fltblck-00-d-ag.html.rej: Removed.
fast/block/float/t0905-c5526-flthw-00-c-g.html.orig: Removed.
fast/block/float/t0905-c5526-flthw-00-c-g.html.rej: Removed.

2:24 PM Changeset in webkit [41404] by timothy@apple.com

8 edits
1 add in trunk/WebCore

Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
the console code and refactored things to have fewer code paths and duplication.

Reviewed by Kevin McCullough.

Test: manual-tests/inspector/console-dir.html

bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject to fix an ASSERT about using a wrapper from the wrong ExecState.
bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto. (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
inspector/front-end/Console.js: (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat. When forceObjectFormat is true, the only formatter used is _formatobject. (WebInspector.Console.prototype._formatvalue): Remove the inline argument. (WebInspector.Console.prototype._formatstring): Ditto. (WebInspector.Console.prototype._formatregexp): Ditto. (WebInspector.Console.prototype._formatarray): Ditto. (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor. (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph. (WebInspector.Console.prototype._formaterror): Remove the inline argument. (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter. (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline. (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat. (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments. (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
inspector/front-end/inspector.css: Tweak styles to look and work correctly.
inspector/front-end/utilities.js: (Object.type): Return "node" for Node objects. (Object.describe): Handle the "node" type.
page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types. (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
page/Console.h: (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.

1:07 PM Changeset in webkit [41403] by Dimitri Glazkov

3 edits
2 adds in trunk

WebCore:

2009-03-03 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop.

Makes sure a node is in the document during a move before using it.

Test: fast/events/crash-on-mutate-during-drop.html

editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):

LayoutTests:

2009-03-03 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop

Makes sure we don't crash during dnd with DOM mutation event listener
that mutates the document on drop.

fast/events/crash-on-mutate-during-drop-expected.txt: Added.
fast/events/crash-on-mutate-during-drop.html: Added.

11:53 AM Changeset in webkit [41402] by Dimitri Glazkov

4 edits in trunk/WebCore

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows.
Files that were omitted by mistake in the latest patch
that was landed.

loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):
platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):

11:48 AM Changeset in webkit [41401] by kov@webkit.org

12 edits
2 adds in trunk

2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Adding new files related to WebKitDownload to the GTK+ port.

GNUmakefile.am:

WebCore:

2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Make the Soup backend able to handle requests without a frame,
since we may have such things now that we support downloads.

platform/network/ResourceHandleInternal.h:
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start):

WebKit/gtk:

2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Implement download, and provide a nice object wrapping the
download process. Initial work done by Marco Barisione and
Pierre-Luc Beaudoin for Collabora.

WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::downloadURL):
WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::download): (WebKit::FrameLoaderClient::startDownload):
webkit/webkit.h:
webkit/webkitdefines.h:
webkit/webkitdownload.cpp: Added. (_WebKitDownloadPrivate::): (_WebKitDownloadPrivate::webkit_download_dispose): (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_get_property): (_WebKitDownloadPrivate::webkit_download_set_property): (_WebKitDownloadPrivate::webkit_download_class_init): (_WebKitDownloadPrivate::webkit_download_init): (_WebKitDownloadPrivate::webkit_download_new): (_WebKitDownloadPrivate::webkit_download_open_stream_for_uri): (_WebKitDownloadPrivate::webkit_download_close_stream): (_WebKitDownloadPrivate::webkit_download_start): (_WebKitDownloadPrivate::webkit_download_cancel): (_WebKitDownloadPrivate::webkit_download_get_uri): (_WebKitDownloadPrivate::webkit_download_get_network_request): (_WebKitDownloadPrivate::webkit_download_set_response): (_WebKitDownloadPrivate::webkit_download_get_suggested_filename): (_WebKitDownloadPrivate::webkit_download_get_destination_uri): (_WebKitDownloadPrivate::webkit_download_set_destination_uri): (_WebKitDownloadPrivate::webkit_download_get_state): (_WebKitDownloadPrivate::webkit_download_get_total_size): (_WebKitDownloadPrivate::webkit_download_get_current_size): (_WebKitDownloadPrivate::webkit_download_get_progress): (_WebKitDownloadPrivate::webkit_download_get_elapsed_time): (_WebKitDownloadPrivate::webkit_download_received_data): (_WebKitDownloadPrivate::webkit_download_finished_loading): (_WebKitDownloadPrivate::webkit_download_error): (_WebKitDownloadPrivate::DownloadClient::DownloadClient): (_WebKitDownloadPrivate::DownloadClient::didReceiveResponse): (_WebKitDownloadPrivate::DownloadClient::didReceiveData): (_WebKitDownloadPrivate::DownloadClient::didFinishLoading): (_WebKitDownloadPrivate::DownloadClient::didFail): (_WebKitDownloadPrivate::DownloadClient::wasBlocked): (_WebKitDownloadPrivate::DownloadClient::cannotShowURL):
webkit/webkitdownload.h: Added.
webkit/webkitprivate.h:
webkit/webkitwebview.cpp:
webkitmarshal.list:

11:29 AM Changeset in webkit [41400] by andersca@apple.com

3 edits in trunk/WebKit/mac

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6633834>.

Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Create a new plug-in instance if the plug-in host has crashed.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invalidate): Add a null check for the plug-in host proxy.

11:18 AM Changeset in webkit [41399] by Dimitri Glazkov

2 edits
4 copies
1 add in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24331
Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.

bindings/v8/custom/V8AttrCustom.cpp: Added.
bindings/v8/custom/V8CustomBinding.cpp: Added.
bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
bindings/v8/custom/V8ElementCustom.cpp: Added.
bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.

11:08 AM Changeset in webkit [41398] by beidson@apple.com

15 edits
3 adds in trunk

WebCore:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6616664> - Quick looks of various file types is broken

In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
for non-HTTP loads when the underlying ResourceRequest changed. Unfortunately it was a little
overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.

Partially reverted behavior to always set the mainDocumentURL in situations when we would've
before that patch.

loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):

platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setMainDocumentURL):

WebKitTools:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

Support layout test covering <rdar://problem/6616664>

Change NSURLRequest/IWebURLRequest dumping to include the mainDocumentURL

DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURLRequest _drt_descriptionSuitableForTestResult]): Return both the request URL and the mainDocumentURL.

DumpRenderTree/win/ResourceLoadDelegate.cpp: (descriptionSuitableForTestResult): Return both the request URL and the mainDocumentURL.

LayoutTests:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

Layout test covering <rdar://problem/6616664> - Quick looks of various file types is broken

Added to test the changes:

fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
fast/loader/main-document-url-for-non-http-loads.html: Added.
fast/loader/resources/subframe-notify-done.html: Added.

Updated the following for the new info from dumpResourceLoadCallbacks():

http/tests/misc/window-dot-stop-expected.txt:
http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
platform/mac-leopard/security/block-test-expected.txt:
platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
security/block-test-expected.txt:
webarchive/loading/test-loading-archive-expected.txt:

10:55 AM Changeset in webkit [41397] by cmarrin@apple.com

2 edits in trunk/WebCore

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24256

Added a WebCoreForceSoftwareAnimation flag.

10:48 AM Changeset in webkit [41396] by cmarrin@apple.com

11 edits
2 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24257

Added prototype properties for several classes with constructors that
were missing them, including the one mentioned in the bug.

10:46 AM Changeset in webkit [41395] by ariya@webkit.org

3 edits in trunk/WebKit/qt

2009-03-03 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

[Qt] Create and update the action for SelectAll.

Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateEditorActions): (QWebPage::action):
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textSelection):

10:38 AM Changeset in webkit [41394] by Dimitri Glazkov

1 edit
4 adds in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24321
Add V8 bindings headers.

bindings/v8/V8Binding.h: Added.
bindings/v8/V8Proxy.h: Added.
bindings/v8/custom/V8CustomBinding.h: Added.
bindings/v8/custom/V8CustomEventListener.h: Added.

10:33 AM Changeset in webkit [41393] by Dimitri Glazkov

1 edit
20 adds in trunk/LayoutTests

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=23482
Add the following CSS 2.1 tests, with YinYang character (U+262F)
and SouthEast Arrow (U+2798) replaced by png images,
to fast/block/float. Leftward white arrow (U+21E6) is also
replaced by an ASCII-equivalent of '<-'.

css2.1/t0905-c414-flt-fit-01-d-g.html
css2.1/t0905-c5525-fltblck-00-d-ag.html
css2.1/t0905-c5526-flthw-00-c-g.html

On platforms where no font covers those characters (e.g. Windows),
the above tests can be skipped and the new tests can be used, instead.
They're equivalent in terms of what they test.

fast/block/float/resources/se_arrow.png: Added.
fast/block/float/resources/yinyang.png: Added.
fast/block/float/t0905-c414-flt-fit-01-d-g.html: Copied from LayoutTests/css2.1/t0905-c414-flt-fit-01-d-g.html.
fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Copied from LayoutTests/css2.1/t0905-c5525-fltblck-00-d-ag.html.
fast/block/float/t0905-c5526-flthw-00-c-g.html: Copied from LayoutTests/css2.1/t0905-c5526-flthw-00-c-g.html.
platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Added.
platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Added.
platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Added.
platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Added.
platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Added.
platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Added.

10:21 AM Changeset in webkit [41392] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23803
Fix an 'off-by-1' error in ChromiumWin's font fallback.

platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::getFontDataForCharacters):

10:20 AM Changeset in webkit [41391] by Dimitri Glazkov

1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog dates.

10:18 AM Changeset in webkit [41390] by Dimitri Glazkov

2 edits
2 moves
1 add in trunk/WebCore

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows: Part 1

Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype from platform/graphics/win because both Windows port and Chromium Windows port will use them.
Adjust WebCore.vcproj accordingly.

WebCore.vcproj/WebCore.vcproj:
platform/graphics/opentype: Added.
platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
platform/graphics/win/OpenTypeUtilities.cpp: Removed.
platform/graphics/win/OpenTypeUtilities.h: Removed.

10:10 AM Changeset in webkit [41389] by Simon Fraser

6 edits in trunk/WebCore

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24312

Take 3D transforms into account when hit testing:

Maintain a bit on each RenderLayer that is set when the layer has 3d descendants, so that we know when to fall into the slow hit testing path.

Make a ref-counted HitTestingTransformState, which is used to store an accumulated transform, and the hit test point, and hitTestRect in the plane of the ancestor non-3d ('flattening') layer.

It's ref-counted so we can heap allocate it (to avoid stack bloat),
and avoid copying when hitTestLayer calls itself after applying the transform.

Add logic to hitTestLayer to depth-test just direct descendants, if any have 3D transforms, or to do deep depth-testing when traversing a preserves-3d hierarchy. When hit, layers compute a z-offset from the ancestor flattening layer, which allows for correct depth testing.

The existing early-return codepath is unaffected when there are no 3d transforms
and no preserve-3d.

9:54 AM Changeset in webkit [41388] by brettw@chromium.org

1 edit in trunk/WebCore/ChangeLog

Fix typo in ChangeLog from last commit.

9:52 AM Changeset in webkit [41387] by Simon Fraser

4 edits in trunk/WebCore

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24312

Factor the code that compute a transform relative to the container
into RenderObject::transformFromContainer().

rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToAbsolutePoint): (WebCore::RenderBox::mapAbsoluteToLocalPoint):
rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):
rendering/RenderObject.h:

9:50 AM Changeset in webkit [41386] by brettw@chromium.org

2 edits in trunk/WebCore

2009-03-02 Brett Wilson <brettw@chromium.org>

Fix uninitialized memory reads in the Chromium Windows transparency
code that were identified by Purify,

Reviewed by Darin Disher.

platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers): (WebCore::TransparencyWin::initializeNewContext):

9:43 AM Changeset in webkit [41385] by Simon Fraser

2 edits in trunk/WebCore

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24317

Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
the superclass found a node, otherwise we set the innerNode of the
HitTestResult, but don't actually report that we found a hit.

rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):

9:31 AM Changeset in webkit [41384] by kov@webkit.org

1 edit in trunk/WebCore/ChangeLog

Fixing bug number for last ChangeLog entry; thanks to Ariya for
catching this problem.

9:26 AM Changeset in webkit [41383] by kov@webkit.org

3 edits
1 add in trunk/WebCore

2009-03-03 Onne Gorter <onne.gorter@avinity.net>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=27385
resizing plugins does not work, because the plugin never gets informed

Make gtk plugins resize correctly, by sending them the setwindow event
correctly. Also ensure that all plugin eventing is done with correct
locking/calling. Mostly copied from mac implementation.

manual test: manual-tests/gtk/plugin-resize-scroll.html

plugins/PluginView.h:
plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::dispatchNPEvent): ensure locking/calling for NPEvents (WebCore::PluginView::updatePluginWidget): if something changed, let setNPWindowIfNeeded handle it (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): ensure calling conventions (WebCore::PluginView::setNPWindowRect): just pass control to setNPWindowIfNeeded (WebCore::PluginView::setNPWindowIfNeeded): event the plugin correctly of new window (WebCore::PluginView::init): init through the new setup

8:45 AM Changeset in webkit [41382] by ap@webkit.org

1 edit
2 adds in trunk/LayoutTests

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=4343
XMLHttpRequest doesn't work in a JavaScript-created window

The problem was fixed a while ago (r34506), just adding a test.

http/tests/xmlhttprequest/request-from-popup-expected.txt: Added.
http/tests/xmlhttprequest/request-from-popup.html: Added.

8:44 AM Changeset in webkit [41381] by ap@webkit.org

1 edit in trunk/WebCore/ChangeLog

Adding bug URL and title to ChangeLog for a recent check-in.

8:06 AM Changeset in webkit [41380] by darin@chromium.org

3 edits in trunk/WebCore

2009-03-03 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

dom/Document.idl:
html/HTMLCanvasElement.idl:

Mar 2, 2009:

10:15 PM Changeset in webkit [41379] by Simon Fraser

3 edits
2 adds in trunk

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson

https://bugs.webkit.org/show_bug.cgi?id=24313

If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
HitTestResult, then it had better well return |true|. And m_innerBlock
could never have been set as the hit node by the superclass, because
the superclass knows nothing about m_innerBlock.

Test: fast/forms/input-hit-test-border.html

rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):

6:24 PM Changeset in webkit [41378] by weinig@apple.com

8 edits in trunk

JavaScriptCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

Configurations/JavaScriptCore.xcconfig:

WebCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

Configurations/WebCore.xcconfig:

WebKit/mac:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

Configurations/WebKit.xcconfig:

WebKitTools:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

Scripts/build-webkit:

6:12 PM Changeset in webkit [41377] by eric@webkit.org

2 edits in trunk/WebCore

2009-03-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

Fix https://bugs.webkit.org/show_bug.cgi?id=24307
Null out m_highlightedNode on hideHighlight().
Ran WebCore/manual-tests/inspector/highlight-nodes.html.

inspector/InspectorController.cpp: (WebCore::InspectorController::hideHighlight):

5:51 PM Changeset in webkit [41376] by andersca@apple.com

5 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

WebKit part of <rdar://problem/6638658>.

Plugins/Hosted/NetscapePluginHostManager.h:
Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::createPropertyListFile): Spawn the plug-in host and wait for it to create the property list.

Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage createPropertyListFile]): Factor code out into a new method.

(-[WebBasePluginPackage pListForPath:createFile:]):
Call the newly added createPropertyListFile method.

Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage createPropertyListFile]): Tell the plug-in host manager to create a property list file for us.

5:47 PM Changeset in webkit [41375] by weinig@apple.com

13 edits
2 adds in trunk

WebCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6507404> Add Geolocation support.

This is not yet turned on for any Mac platform.

WebCore.xcodeproj/project.pbxproj:
page/Chrome.cpp: (WebCore::Chrome::shouldAllowGeolocationForFrame):
page/Chrome.h:
page/ChromeClient.h: (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document will not be alive at this point. (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and return a PERMISSION_DENIED if not. (WebCore::Geolocation::watchPosition): Ditto. (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether to allow geolocation and cache the result.
page/Geolocation.h: (WebCore::Geolocation::):
platform/GeolocationService.cpp:
platform/GeolocationService.h: (WebCore::GeolocationService::~GeolocationService): (WebCore::GeolocationService::stopUpdating):
platform/mac/GeolocationServiceMac.h: Added. (WebCore::GeolocationServiceMac::lastPosition): (WebCore::GeolocationServiceMac::lastError):
platform/mac/GeolocationServiceMac.mm: Added. (WebCore::GeolocationService::create): (WebCore::GeolocationServiceMac::GeolocationServiceMac): (WebCore::GeolocationServiceMac::~GeolocationServiceMac): (WebCore::GeolocationServiceMac::startUpdating): (WebCore::GeolocationServiceMac::stopUpdating): (WebCore::GeolocationServiceMac::suspend): (WebCore::GeolocationServiceMac::resume): (WebCore::GeolocationServiceMac::positionChanged): (WebCore::GeolocationServiceMac::errorOccurred): (-[WebCoreCoreLocationObserver initWithCallback:]): (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]): (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):

WebKit/mac:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6507404> Add Geolocation support.

This is not yet turned on for any Mac platform.

Add SPI to ask the embedding application whether to allow
Geolocation for an origin.

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldAllowGeolocationForFrame):
WebView/WebUIDelegatePrivate.h:

5:36 PM Changeset in webkit [41374] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Fix PowerPC build.

Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]):

5:36 PM UsingGitWithWebKit edited by ojan@chromium.org

(diff)

4:20 PM Changeset in webkit [41373] by andersca@apple.com

1 edit in trunk/WebKit/mac/ChangeLog

Fix tyop

4:14 PM Changeset in webkit [41372] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan, Ada Chan.

Factor loading code out into its own method and get rid of a bunch of goots.

Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage load]):

4:00 PM Changeset in webkit [41371] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Build fix.

Plugins/WebNetscapeDeprecatedFunctions.h:

3:58 PM Changeset in webkit [41370] by andersca@apple.com

2 edits in trunk/WebKit

2009-03-02 Anders Carlsson <andersca@apple.com>

WebNetscapePluginPackage.mm is an Objective-C++ file.

WebKit.xcodeproj/project.pbxproj:

3:53 PM Changeset in webkit [41369] by andersca@apple.com

3 edits
1 move in trunk/WebKit

WebKit:

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm

Plugins/WebNetscapePluginPackage.m: Removed.
Plugins/WebNetscapePluginPackage.mm: Copied from mac/Plugins/WebNetscapePluginPackage.m.

3:29 PM Changeset in webkit [41368] by kevino@webkit.org

11 edits in trunk

Build fixes for wxWidgets Mac trunk build.

3:25 PM Changeset in webkit [41367] by kevino@webkit.org

2 edits in trunk/WebCore

wxGTK missing header build fix.

1:55 PM Changeset in webkit [41366] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Adam Roben.

fix https://bugs.webkit.org/show_bug.cgi?id=21811 REGRESSION: Windows Build Not Selecting Proper Font

platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): Added back code to verify that the created HFONT has the requested face name.

1:38 PM Changeset in webkit [41365] by timothy@apple.com

2 edits in trunk/WebCore

Fixes a regression caused by splitting the input and output of console commands.

https://bugs.webkit.org/show_bug.cgi?id=24293

Reviewed by Kevin McCullough.

inspector/front-end/Console.js: (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.

1:38 PM Changeset in webkit [41364] by timothy@apple.com

4 edits in trunk/WebCore

Make exception messages and logged Error objects display consistently.

https://bugs.webkit.org/show_bug.cgi?id=18983

Reviewed by Adam Roben.

English.lproj/localizedStrings.js: Remove a string for line numbers.
inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Pass the exception boolean to the ConsoleCommandResult constructor and don't pass level. (WebInspector.Console.prototype._formatnode): Fix a className typo. (WebInspector.Console.prototype._formaterror): Add an error-message classed span around the message to show in red and remove the console-message-url class from the link so it doesn't float right. Instead enclose the link in parentheses and use displayNameForURL to shorten the URL in the link. (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify how line numbers are shown since link underlining a string with parentheses looks bad. (WebInspector.ConsoleCommandResult): Take an exception boolean flag instead of a level and get line and URL based on that flag.
inspector/front-end/inspector.css: Tweaks to the styles.

1:38 PM Changeset in webkit [41363] by timothy@apple.com

2 edits in trunk/WebKitTools

Allow for multiline quoted text in JavaScript files when looking for function names.

https://bugs.webkit.org/show_bug.cgi?id=24296

Reviewed by David Kilzer.

Scripts/prepare-ChangeLog:

11:16 AM Changeset in webkit [41362] by levin@chromium.org

10 edits in trunk/WebCore

2009-03-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

Bug 24048: extra windows button padding doesn't apply when there's no appearance
<https://bugs.webkit.org/show_bug.cgi?id=24048>

Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.

No tests added as existing tests already cover this behavior.

rendering/RenderButton.cpp: (WebCore::RenderButton::setupInnerStyle):
rendering/RenderTheme.cpp:
rendering/RenderTheme.h: (WebCore::RenderTheme::buttonInternalPaddingLeft): (WebCore::RenderTheme::buttonInternalPaddingRight): (WebCore::RenderTheme::buttonInternalPaddingTop):
rendering/RenderThemeChromiumGtk.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
rendering/RenderThemeChromiumGtk.h:
rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
rendering/RenderThemeChromiumWin.h:
rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
rendering/RenderThemeWin.h:

10:26 AM Changeset in webkit [41361] by treat@webkit.org

5 edits in trunk

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

Add three new drt helper functions that enable all of the tests in
LayoutTests/animation/* and LayoutTests/transitions/* to now pass.

Api/qwebframe.cpp: (qt_drt_pauseAnimation): (qt_drt_pauseTransitionOfProperty): (qt_drt_numberOfActiveAnimations):

DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations):
DumpRenderTree/qt/jsobjects.h:

8:55 AM Changeset in webkit [41360] by treat@webkit.org

2 edits in trunk/WebKit/qt

2009-03-02 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=21230
On X11 match the behavior of Firefox and also copy the url to the
clipboard selection when the action Copy Link Location is executed.

Api/qwebpage.cpp: (QWebPage::triggerAction):

8:30 AM Changeset in webkit [41359] by treat@webkit.org

2 edits in trunk/WebCore

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Build fix for Qt port. Remove unnecessary assert.

platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):

7:37 AM Changeset in webkit [41358] by treat@webkit.org

9 edits in trunk/WebCore

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24227
Ensure that the checkForSolidColor() optimization is correctly triggered
for all cases of drawPattern. Currently, the optimization was not triggered
when the check had not been previously performed via a request for the
image's NativeImagePtr.

Implement the Qt version of the checkForSolidColor() method. Combined with
the bug fix this reduces the time it takes to draw a repeating background
of a 1x1 image from ~50msecs to ~0msecs on my machine.

platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):

6:56 AM Changeset in webkit [41357] by kov@webkit.org

4 edits in trunk

2009-03-02 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix; adding missing files to EXTRA_DIST, so that
they show up in the tarball.

GNUmakefile.am:

6:38 AM QtWebKitTodo edited by Simon Hausmann

(diff)

6:38 AM Changeset in webkit [41356] by krit@webkit.org

1 edit in trunk/WebCore/ChangeLog

2009-03-02 Dirk Schulze <krit@webkit.org>

Just a correction of the ChangeLog. Removed Ariya Hidayat
from the reviewing process.

6:22 AM Changeset in webkit [41355] by krit@webkit.org

2 edits in trunk/WebCore

2009-03-02 Dirk Schulze <krit@webkit.org>

Reviewed by Holger Freyther, rubber-stamped by Ariya Hidayat.

Added putImageData to Qt.

[Qt] lacks putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186

platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):

5:26 AM Changeset in webkit [41354] by Adam Roben

2 edits in trunk/WebKitTools

Windows build fix after r41349

DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::getChildrenWithRange):

12:22 AM Changeset in webkit [41353] by timothy@apple.com

2 edits in trunk/WebCore

Show exception messages again when evaluating bad expressions in the
Web Inspector's console.

https://bugs.webkit.org/show_bug.cgi?id=19890

Reviewed by Oliver Hunt.

bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState): Fix the order in which the exception is set and cleared now that the exception is stored in the shared GlobalData, not per ExecState.

12:22 AM Changeset in webkit [41352] by timothy@apple.com

3 edits
1 add in trunk/WebCore

Make input in the Web Inspector console print before any output
that might be added by the called function.

https://bugs.webkit.org/show_bug.cgi?id=19931

Reviewed by Oliver Hunt.

inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Add the command message before evaluating the result. Associate the originating command to the result, so if they are adjacent there is no divider. (WebInspector.ConsoleCommand): No longer take a result. (WebInspector.ConsoleCommand.prototype.toMessageElement): Result code removed since it isn't used now. (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage. (WebInspector.ConsoleCommandResult.prototype.toMessageElement): Call the ConsoleMessage toMessageElement and add a style class.
inspector/front-end/inspector.css: Add a new style class for adjacent results to hide the divider. Also tweak the position of the disclosure triangle for objects to not use the left margin.

Mar 1, 2009:

9:46 PM Changeset in webkit [41351] by timothy@apple.com

1 edit in trunk/WebKitTools/DumpRenderTree/mac/AccessibilityUIElementMac.mm

Fix the Mac build.

8:18 PM Changeset in webkit [41350] by ddkilzer@apple.com

4 edits in trunk/JavaScriptCore

<rdar://problem/6635688> Move HAVE_DTRACE check to Base.xcconfig

Reviewed by Mark Rowe.

Configurations/Base.xcconfig: Set HAVE_DTRACE Xcode variable based on PLATFORM_NAME and MAC_OS_X_VERSION_MAJOR. Also define it as a preprocessor macro by modifying GCC_PREPROCESSOR_DEFINITIONS.
JavaScriptCore.xcodeproj/project.pbxproj: Changed "Generate DTrace header" script phase to check for HAVE_DTRACE instead of MACOSX_DEPLOYMENT_TARGET.
wtf/Platform.h: Removed definition of HAVE_DTRACE macro since it's defined in Base.xcconfig now.

6:55 PM Changeset in webkit [41349] by Chris Fleizach

6 edits in trunk

Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
<https://bugs.webkit.org/show_bug.cgi?id=24282>

4:45 PM Changeset in webkit [41348] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-03-01 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebKit side of <rdar://problem/6449689>

Pass the visible name to the plug-in host.

Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):

4:41 PM Changeset in webkit [41347] by levin@chromium.org

19 edits in trunk

2009-03-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
<https://bugs.webkit.org/show_bug.cgi?id=24251>

Make RenderObject::positionForCoordinate non-virtual and
RenderObject::positionForPoint virtual in preparation for
removing positionFor* from RenderObject/RenderText.

page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint):
rendering/RenderBR.cpp: (WebCore::RenderBR::positionForPoint):
rendering/RenderBR.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPoint):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
rendering/RenderBox.h:
rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint):
rendering/RenderInline.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::positionForCoordinates): (WebCore::RenderObject::positionForPoint):
rendering/RenderObject.h:
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint):
rendering/RenderReplaced.h:
rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint):
rendering/RenderSVGInlineText.h:
rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
rendering/RenderText.h:

4:41 PM Changeset in webkit [41346] by levin@chromium.org

4 edits in trunk/WebCore

2009-03-01 Larry Ewing <lewing@novell.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24080
NPN_GetValue casting to the wrong type and writing outside bounds

Make sure to cast the value to the correct type so that only
memory owned by the value is written to.

plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic):
plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): (PluginView::getValue):

4:41 PM Changeset in webkit [41345] by levin@chromium.org

9 edits in trunk/WebCore

2009-03-01 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24197 and
https://bugs.webkit.org/show_bug.cgi?id=23512

The Windows version of cgColor() is conditionally compiled using
!PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
can use the OS X version instead of the Windows version.

Also rename cgColor() -> createCGColor()

No observable change in behavior, so no test.

platform/graphics/Color.h:
platform/graphics/cg/ColorCG.cpp: (WebCore::createCGColor):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
platform/graphics/mac/ColorMac.mm: (WebCore::createCGColor):
platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::setLayerBorderColor): (WebCore::setLayerBackgroundColor): (WebCore::GraphicsLayerCA::setBackgroundColor):
platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawFocusRing):
svg/graphics/filters/cg/SVGFEHelpersCg.mm: (WebCore::ciColor):

1:09 PM Changeset in webkit [41344] by levin@chromium.org

17 edits
9 adds in trunk

WebCore:

2009-03-01 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24271: XMLHttpRequest needs js bindings for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=24271>

Tests: http/tests/xmlhttprequest/workers/methods-async.html

http/tests/xmlhttprequest/workers/methods.html

bindings/js/JSWorkerContextBase.cpp: (WebCore::JSWorkerContextBase::getOwnPropertySlot): (jsWorkerContextBaseXMLHttpRequest): (setJSWorkerContextBaseXMLHttpRequest): Expose XMLHttpRequest to Workers.

bindings/js/JSWorkerContextBase.h:

bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): (WebCore::constructXMLHttpRequest): (WebCore::JSXMLHttpRequestConstructor::mark): Removed the dependencies on Document.

bindings/js/JSXMLHttpRequestConstructor.h: (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
dom/EventException.idl:
dom/EventListener.idl: Chnage to have the NoStaticTables attribute since they are used from XHR.

loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): Fixed identifier to be unsigned long.

loader/WorkerThreadableLoader.h:
workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.

xml/XMLHttpRequestUpload.cpp:

xml/XMLHttpRequest.idl:
xml/XMLHttpRequestException.idl:
xml/XMLHttpRequestProgressEvent.idl:
xml/XMLHttpRequestUpload.idl: Chnage to have the NoStaticTables attribute since they are used from XHR.

LayoutTests:

2009-03-01 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24271: XMLHttpRequest needs js bindings for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=24271>

Some sanity checks for xhr done from workers. These are the same as
tests done for normal workers.

http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
http/tests/xmlhttprequest/workers/methods-async.html: Added.
http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
http/tests/xmlhttprequest/workers/methods.html: Added.
http/tests/xmlhttprequest/workers/resources/methods-async.js: Added. (onmessage): (log): (done): (onReqAbort): (onSyncReqError): (start): (processStateChange):
http/tests/xmlhttprequest/workers/resources/methods.cgi: Copied from LayoutTests/http/tests/xmlhttprequest/methods.cgi.
http/tests/xmlhttprequest/workers/resources/methods.js: Added. (log): (done):

12:14 PM Changeset in webkit [41343] by timothy@apple.com

1 edit in trunk/JavaScriptCore/parser/Nodes.h

Build fix. Add isBlock() back since there was a new client since the patch was made.

11:37 AM Applications using WebKit edited by todd.ditchendorf@gmail.com

(diff)

11:35 AM Changeset in webkit [41342] by timothy@apple.com

4 edits
5 adds in trunk

JavaScriptCore:

2009-03-01 Horia Olaru <olaru@adobe.com>

By looking in grammar.y there are only a few types of statement nodes
on which the debugger should stop.

Removed isBlock and isLoop virtual calls. No need to emit debug hooks in
the "statementListEmitCode" method as long as the necessary hooks can be
added in each "emitCode".

https://bugs.webkit.org/show_bug.cgi?id=21073

Reviewed by Kevin McCullough.

parser/Nodes.cpp: (JSC::ConstStatementNode::emitBytecode): (JSC::statementListEmitCode): (JSC::EmptyStatementNode::emitBytecode): (JSC::ExprStatementNode::emitBytecode): (JSC::VarStatementNode::emitBytecode): (JSC::IfNode::emitBytecode): (JSC::IfElseNode::emitBytecode): (JSC::DoWhileNode::emitBytecode): (JSC::WhileNode::emitBytecode): (JSC::ForNode::emitBytecode): (JSC::ForInNode::emitBytecode): (JSC::ContinueNode::emitBytecode): (JSC::BreakNode::emitBytecode): (JSC::ReturnNode::emitBytecode): (JSC::WithNode::emitBytecode): (JSC::SwitchNode::emitBytecode): (JSC::LabelNode::emitBytecode): (JSC::ThrowNode::emitBytecode): (JSC::TryNode::emitBytecode):
parser/Nodes.h:

WebCore:

2009-03-01 Horia Olaru <olaru@adobe.com>

Adding manual debugger test cases for bug.

https://bugs.webkit.org/show_bug.cgi?id=21073

Reviewed by Kevin McCullough.

manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
manual-tests/inspector/debugger-step-on-for-statements.html: Added.
manual-tests/inspector/debugger-step-on-while-statements.html: Added.
manual-tests/inspector/resources/loop-statements.js: Added.

11:22 AM Changeset in webkit [41341] by jmalonzo@webkit.org

7 edits in trunk

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Added API to get the response mime type from a frame. We need this
so we can decide if we need to dump the frame as text or its
render tree

webkit/webkitprivate.h:
webkit/webkitwebframe.cpp:

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Determine the frame's response and decide whether to dump as text
or the render tree

DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):

2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Enable http tests, excluding tests/folders that fail or untested

platform/gtk/Skipped:

11:21 AM Changeset in webkit [41340] by jmalonzo@webkit.org

4 edits in trunk/WebKitTools

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Implement dumping of WebKitWebBackForwardList and its history
items.

DumpRenderTree/gtk/DumpRenderTree.cpp: (compareHistoryItems): (dumpHistoryItem): (dumpBackForwardListForWebView): (dump): (runTest):
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearBackForwardList):
DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (BackForwardItem::invoke):

11:21 AM Changeset in webkit [41339] by jmalonzo@webkit.org

4 edits in trunk/WebKit/gtk

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Create a WebKitWebHistoryItem for each WebCore::HistoryItem when
necessary.
Add necessary API additions for us to be able to dump a WebKitWebHistoryItem

webkit/webkitprivate.h:
webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children): (WebKit::core): (WebKit::kit):

11:02 AM Changeset in webkit [41338] by mitz@apple.com

4 edits
2 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts

Test: fast/events/scroll-during-zoom-change.html

dom/Document.cpp: (WebCore::Document::recalcStyle): Pause scheduled events during style reclaculation. Changes to the zoom property result in scroll events being generated during style recalc, and those events need to be deferred until the render tree is consistent.
page/FrameView.cpp: (WebCore::FrameView::layout): Changed to account for a case in which the post-layout tasks trigger a nested layout, which reactivates the post-layout task timer.

LayoutTests:

Reviewed by Darin Adler.

test for <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts

fast/events/scroll-during-zoom-change-expected.txt: Added.
fast/events/scroll-during-zoom-change.html: Added.

11:00 AM Changeset in webkit [41337] by christian@webkit.org

4 edits in trunk/WebKit/gtk

2009-03-01 Christian Dywan <christian@twotoasts.de>

Reviewed by Holger Freyther.

webkit/webkitprivate.h:
webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):
webkit/webkitwebview.h: Implement 'encoding' and 'custom-encoding' properties as well as webkit_web_view_get_encoding.

10:47 AM Changeset in webkit [41336] by christian@webkit.org

2 edits in trunk/WebKitTools

2009-02-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Holger Freyther.

Set the resolution for the default screen to 72.0.
This way, setting font sizes results in expected values.

DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):

8:53 AM Changeset in webkit [41335] by timothy@apple.com

3 edits in trunk/WebCore

Alphabetically sort scripts in the Script's panel file popup menu.

https://bugs.webkit.org/show_bug.cgi?id=23395

Reviewed by Timothy Hatcher.

inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
inspector/front-end/utilities.js: (insertionIndexForObjectInListSortedByFunction): (indexOfObjectInListSortedByFunction):

8:42 AM Changeset in webkit [41334] by timothy@apple.com

3 edits in trunk/WebCore

Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
when creating databases, localStorage or sessionStorage. Changing document.domain
should have no affect on databases, localStorage and sessionStorage in Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=23844

Reviewed by Timothy Hatcher.

inspector/InspectorController.cpp: (WebCore::InspectorController::addDOMStorageScriptResource): (WebCore::InspectorController::didUseDOMStorage):
storage/Database.cpp: (WebCore::Database::openDatabase):

8:22 AM Changeset in webkit [41333] by kov@webkit.org

2 edits in trunk/WebCore

2009-03-01 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Avoid leaking errors when reporting GIO errors.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback):

8:21 AM Changeset in webkit [41332] by kov@webkit.org

2 edits in trunk/WebCore

2009-03-01 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Fixes crash when the GIO backend is given the URI for a directory.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::networkErrorForFile):

8:04 AM Changeset in webkit [41331] by kov@webkit.org

2 edits in trunk/WebKit/gtk

Simple wording fix for the NEWS file.

7:39 AM Changeset in webkit [41330] by christian@webkit.org

2 edits in trunk

2009-03-01 Christian Dywan <christian@twotoasts.de>

configure.ac: Bump GTK port version to 1.1.1.

7:38 AM Changeset in webkit [41329] by kov@webkit.org

1 edit
1 add in trunk/WebKit/gtk

2009-03-01 Xan Lopez <xan@gnome.org>

Add NEWS file to track progress between releases.

NEWS: Added.

7:29 AM Changeset in webkit [41328] by kov@webkit.org

2 edits in trunk/WebKitTools

2009-02-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Adds a WebKitMakeArguments environment variable to enable passing
of arguments such as '-j2' to make for the autotools build.

Scripts/webkitdirs.pm:

7:28 AM Changeset in webkit [41327] by kov@webkit.org

2 edits in trunk/WebKitTools

2009-02-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Add a GTK+-only option to enable GNOME Keyring when building.

Scripts/build-webkit:

Feb 28, 2009:

10:21 PM Changeset in webkit [41326] by jmalonzo@webkit.org

2 edits in trunk/WebKitTools

2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=24076

Refactor gtk lib detection and put it in builtDylibPathForName

Scripts/webkitdirs.pm:

9:28 PM Changeset in webkit [41325] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-02-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix V8 custom binding scrubbing error.

Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
Test: traversal/exception-forwarding.html
TesT: traversal/stay-within-root.html

bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8): Ditto.

8:27 PM Changeset in webkit [41324] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-02-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix V8 custom binding scrubbing error.

Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html

WebCore.xcodeproj/project.pbxproj:
bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName): Remove dubious checks, left over from

incomplete conversion of parameter from pointer to pass-by-ref.

(WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
(WebCore::NAMED_PROPERTY_SETTER): Ditto.

6:47 PM Changeset in webkit [41323] by mitz@apple.com

3 edits in trunk/LayoutTests

correct a color profile mismatch in expected pixel results

platform/mac/fast/gradients/background-clipped-expected.checksum:
platform/mac/fast/gradients/background-clipped-expected.png:

12:29 PM Changeset in webkit [41322] by christian@webkit.org

2 edits in trunk/WebCore

Add a ref to the ResourceHandle in startHttp so we can keep it
alive untill all callbacks have been executed, and unref it when
soup tells us it's done with the SoupMessage (in
finishedCallback). Fixes a number of crashes when calling
didReceiveData whould crash because of the handle dying.

12:12 PM Changeset in webkit [41321] by christian@webkit.org

2 edits in trunk/WebKitTools

Use the new webkit_web_view_load_uri to open URIs.

12:04 PM Changeset in webkit [41320] by christian@webkit.org

2 edits in trunk/WebKit/gtk

webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a

locale path is passed for compatibility, since we used to support that.

6:43 AM Changeset in webkit [41319] by kov@webkit.org

2 edits in trunk/WebCore

2009-02-28 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24226
[SOUP] HTTP status text is never set

Set HTTP status text to SoupMessage reason_phrase.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):

2:01 AM Changeset in webkit [41318] by mitz@apple.com

2 edits in trunk/WebCore

fix malformed project file

WebCore.xcodeproj/project.pbxproj:

1:44 AM Changeset in webkit [41317] by mitz@apple.com

4 edits
4 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

fix https://bugs.webkit.org/show_bug.cgi?id=23848 <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de

Test: fast/layers/inline-dirty-z-order-lists.html

rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): Moved the code that dirties a layer's and its stacking context's z-order lists when the layer's z-index or visibility change from here...
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that it will apply to RenderInline too.

LayoutTests:

Reviewed by Oliver Hunt.

test for https://bugs.webkit.org/show_bug.cgi?id=23848 <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de

fast/layers/inline-dirty-z-order-lists.html: Added.
platform/mac/fast/layers/inline-dirty-z-order-lists-expected.checksum: Added.
platform/mac/fast/layers/inline-dirty-z-order-lists-expected.png: Added.
platform/mac/fast/layers/inline-dirty-z-order-lists-expected.txt: Added.

12:45 AM Changeset in webkit [41316] by alice.liu@apple.com

2 edits in trunk/WebKit/mac

2009-02-27 Alice Liu <alice.liu@apple.com>

Fix <rdar://problem/6531265> REGRESSION (r39185): adding ".jpeg"
extension to images that already have .jpg extension

Reviewed by Oliver Hunt.

WebView/WebHTMLView.mm: (-[NSString matchesExtensionEquivalent:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Relax the check for the proper extension to allow for known equivalents, special-cased in matchesExtensionEquivalent function.

12:06 AM Changeset in webkit [41315] by ap@webkit.org

4 edits in trunk/WebCore

Reviewed by David Hyatt.

Don't include TextResourceDecoder.h in Document.h

This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.

Feb 27, 2009:

7:44 PM Changeset in webkit [41314] by kov@webkit.org

2 edits in trunk

2009-02-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix. Adding the WebKit/gtk/webkitmarshal.list
file to EXTRA_DIST to fix make dist.

GNUmakefile.am:

6:21 PM Changeset in webkit [41313] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-02-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by David Hyatt.

Automatically ignore empty requests to avoid crashing. This fixes
the crash in fast/loader/empty-embed-src-attribute.html.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):

5:28 PM Changeset in webkit [41312] by levin@chromium.org

3 edits
4 adds in trunk

WebCore:

2009-02-27 Matt Pennig <pennig@apple.com>

Reviewed by David Hyatt.

Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
"Fixed elements have 0 as an offsetLeft property"

Code also brings offsetLeft/Top in full conformance with the spec.
Added two tests, one for fixed-position elements, and one for <html>.

Tests: fast/dom/Element/fixed-position-offset-parent.html

fast/dom/Element/offsetLeft-offsetTop-html.html

rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::offsetLeft): (WebCore::RenderBoxModelObject::offsetTop):

LayoutTests:

2009-02-27 Matt Pennig <pennig@apple.com>

Reviewed by David Hyatt.

Added two tests:

Tests offsetParent, offsetLeft and offsetTop on fixed-position elements.
Tests offsetLeft and offsetTop on static and positioned <html> elements.

fast/dom/Element/fixed-position-offset-parent-expected.txt: Added.
fast/dom/Element/fixed-position-offset-parent.html: Added.
fast/dom/Element/offsetLeft-offsetTop-html-expected.txt: Added.
fast/dom/Element/offsetLeft-offsetTop-html.html: Added.

5:13 PM Changeset in webkit [41311] by dino@apple.com

1 edit
2 adds in trunk/LayoutTests

2009-02-27 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser

Pixel tests for previous commit
https://bugs.webkit.org/show_bug.cgi?id=24252

platform/mac/transforms/no_transform_hit_testing-expected.checksum: Added.
platform/mac/transforms/no_transform_hit_testing-expected.png: Added.

5:07 PM Changeset in webkit [41310] by dino@apple.com

1 add in trunk/LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.txt

Forgot -expected file from last commit :(

5:05 PM Changeset in webkit [41309] by dino@apple.com

3 edits
1 add in trunk

2009-02-27 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

renderer()->hasTransform() returns true for elements
with perspective, but no transform, so test for transform
when hit testing. This fixes ASSERT from
https://bugs.webkit.org/show_bug.cgi?id=24252

Test: transforms/no_transform_hit_testing.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):

4:01 PM Changeset in webkit [41308] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-02-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

Fix scrubbing error -- a reversed condition.

bindings/v8/ScriptValue.h: (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.

3:46 PM Changeset in webkit [41307] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

3:39 PM Changeset in webkit [41306] by mrowe@apple.com

1 copy in tags/Safari-5525.28.3

New tag.

3:29 PM Changeset in webkit [41305] by levin@chromium.org

4 edits in trunk/WebCore

2009-02-27 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Add confirmMessageFromWorkerObject to WorkerObjectProxy.
https://bugs.webkit.org/show_bug.cgi?id=24152

workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
workers/WorkerMessagingProxy.h:
workers/WorkerObjectProxy.h:

2:46 PM Changeset in webkit [41304] by andersca@apple.com

9 edits in trunk/WebCore

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227
because it leads to assertion failures in the Mac port.

platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):

2:37 PM Changeset in webkit [41303] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

<rdar://problem/6631436>
CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit • WebKit::NetscapePluginInstanceProxy::addValueToArray + 55

Port the NPN_Evaluate code over from WebCore instead of using the frame loader.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate):

2:24 PM Changeset in webkit [41302] by abarth@webkit.org

1 edit in trunk/WebKit/win/WebPreferenceKeysPrivate.h

Remove mysterious @ sign to fix Windows build.

2:15 PM Changeset in webkit [41301] by abarth@webkit.org

1 edit in trunk/WebKit/win/WebView.cpp

Attempt to fix Windows build.

1:58 PM Changeset in webkit [41300] by andersca@apple.com

5 edits in trunk/WebKit/mac

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

WebKit side of <rdar://problem/6626814>.

Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvokeDefault): Make InvokeDefault async.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): Handle passing NPObjects back to the plug-in host.

Plugins/Hosted/ProxyInstance.h: (WebKit::ProxyInstance::objectID): Add objectID getter.

Plugins/Hosted/WebKitPluginClient.defs: Make InvokeDefault a simpleroutine.

1:53 PM Changeset in webkit [41299] by timothy@apple.com

2 edits in trunk/WebKit/mac

Fixes an exception by null checking the WebResource before adding it to
the subresources array.

<rdar://problem/5950769> Bug in [WebDataSource subresources] can throw an exception

Reviewed by Geoff Garen and Anders Carlsson.

WebView/WebDataSource.mm: (-[WebDataSource subresources]): Null check the WebResource before adding it.

1:01 PM Changeset in webkit [41298] by timothy@apple.com

2 edits in trunk/WebKit/mac

Adds a workaround for Automator creating a WebView from a secondary thread.

<rdar://problem/6631951> REGRESSION (Safari 4 Beta): Automator crash on
secondary thread beneath -[WebView initWithFrame:frameName:groupName:]

Reviewed by Geoff Garen.

WebView/WebView.mm: (needsWebViewInitThreadWorkaround): Check for com.apple.Automator.

12:52 PM Changeset in webkit [41297] by abarth@webkit.org

17 edits in trunk

WebCore:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20249

Add a preference to allow universal access from local URLs to mitigate
some attacks. Some clients still want to allow this access, so we
expose this as a preference.

WebCore.base.exp:
dom/Document.cpp: (WebCore::Document::initSecurityContext):
page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin):
page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
page/Settings.h: (WebCore::Settings::allowUniversalAccessFromFileUrls):

WebKit/mac:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preference to reduce the power of file:// URLs.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowUniversalAccessFromFileUrls]): (-[WebPreferences setAllowUniversalAccessFromFileUrls:]):
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preference to reduce the power of file:// URLs.

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::allowUniversalAccessFromFileUrls): (WebPreferences::setAllowUniversalAccessFromFileUrls):
WebPreferences.h:
WebView.cpp: (WebView::notifyPreferencesChanged):

12:47 PM Changeset in webkit [41296] by treat@webkit.org

2 edits in trunk/WebCore

2009-02-27 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24229
If an image has no alpha channel there is no reason to use SourceOver.

platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):

12:42 PM Changeset in webkit [41295] by treat@webkit.org

9 edits in trunk/WebCore

2009-02-27 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24227
Ensure that the checkForSolidColor() optimization is correctly triggered
for all cases of drawPattern. Currently, the optimization was not triggered
when the check had not been previously performed via a request for the
image's NativeImagePtr.

Implement the Qt version of the checkForSolidColor() method. Combined with
the bug fix this reduces the time it takes to draw a repeating background
of a 1x1 image from ~50msecs to ~0msecs on my machine.

platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):

12:35 PM Changeset in webkit [41294] by krit@webkit.org

2 edits in trunk/WebCore

2009-02-27 Dirk Schulze <krit@webkit.org>

Reviewed by Zack Rusin.

Added support for gradients and pattern on Fonts for Qt.

[Qt] gradients and patterns for FontQt
https://bugs.webkit.org/show_bug.cgi?id=24243

platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):

12:02 PM Changeset in webkit [41293] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-02-27 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson

https://bugs.webkit.org/show_bug.cgi?id=24242

setCursor(), and resetCursorRects() on Tiger, were using global, not local
coordinates for elementAtPoint:

WebView/WebHTMLView.mm: (resetCursorRects): (setCursor):

11:50 AM Changeset in webkit [41292] by levin@chromium.org

3 edits in trunk/LayoutTests

2009-02-27 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24213: Web Worker: Worker4 test: onmessage will never be called
<https://bugs.webkit.org/show_bug.cgi?id=24213>

fast/workers/worker-terminate-expected.txt:
fast/workers/worker-terminate.html: Added a log entry to the onmessage handler for worker4 to make it visible that the handler was called and removed the terminate call that happened outside of onmessage.

11:50 AM Changeset in webkit [41291] by levin@chromium.org

2 edits in trunk/WebCore

2009-02-27 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
https://bugs.webkit.org/show_bug.cgi?id=24113

workers/WorkerMessagingProxy.cpp:

11:29 AM Changeset in webkit [41290] by timothy@apple.com

1 add in trunk/WebCore/inspector/front-end/DOMStorageDataGrid.js

Commit a missing file.

10:56 AM Changeset in webkit [41289] by timothy@apple.com

5 edits in trunk/WebCore

Added a refresh button to storage views.

https://bugs.webkit.org/show_bug.cgi?id=24040

Reviewed by Timothy Hatcher.

inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView): (WebInspector.DatabaseTableView.prototype.get statusBarItems): (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.get statusBarItems): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.showDatabase): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
inspector/front-end/inspector.css:

10:28 AM Changeset in webkit [41288] by timothy@apple.com

7 edits in trunk/WebCore

Added support for editing/deleting localStorage and sessionStorage items
directly from Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=23866.

Reviewed by Timothy Hatcher.

WebCore.vcproj/WebCore.vcproj:
inspector/front-end/DOMStorageDataGrid.js: Added. (WebInspector.DOMStorageDataGrid): (WebInspector.DOMStorageDataGrid.prototype._ondblclick): (WebInspector.DOMStorageDataGrid.prototype._startEditing): (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.hide): (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.get statusBarItems): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.css:
inspector/front-end/inspector.html:

9:42 AM Changeset in webkit [41287] by brettw@chromium.org

7 edits
2 adds in trunk/WebCore

Fix Windows transparency for the Chromium port. Implement a helper
class for handling transparency on Windows. It allows semitransparent
ClearType and semitransparent form controls by making new layers in the
background.

It also replaces the "ThemeHelper" which allows better
scaling and transforms on Windows form controls. In addition to the
functionality that the ThemeHelper did, but additionally handles the
antialiasing properly so that the form controls aren't composited on a
white square.

https://bugs.webkit.org/show_bug.cgi?id=24101

Reviewed by Eric Seidel.

8:23 AM Changeset in webkit [41286] by Dimitri Glazkov

1 edit
2 adds in trunk/WebCore

2009-02-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24211
Add ScheduledAction for V8.

bindings/v8/ScheduledAction.cpp: Added. (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::~ScheduledAction): (WebCore::ScheduledAction::execute):
bindings/v8/ScheduledAction.h: Added. (WebCore::ScheduledAction::ScheduledAction):

6:59 AM Changeset in webkit [41285] by treat@webkit.org

2 edits in trunk/WebCore

2009-02-27 Zack Rusin <zack@kde.org>

Reviewed by Nikolas Zimmermann.

Qt: be more reasonable about scrolled lines

cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
irritating. so lets scroll vertically by the Qt set number of lines * Qt default
single step scroll

platform/qt/WheelEventQt.cpp:

3:30 AM Changeset in webkit [41284] by jmalonzo@webkit.org

4 edits in trunk/WebKit/gtk

2009-02-27 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24221
[GTK] Do not emit load-finished when being disposed

webkit_web_view_stop_load() is called from dispose() on
WebKitWebView. This eventually calls postProgressFinishedNotification
in FrameLoaderClientGtk, which emits load-finished. Add
a 'disposing' flag to WebView that we can check here, so
we avoid emitting signals on objects on their way to be
destroyed. This fixes a bunch of critical warnings when
closing a loading WebView.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::postProgressFinishedNotification):
webkit/webkitprivate.h:
webkit/webkitwebview.cpp:

3:18 AM Changeset in webkit [41283] by jmalonzo@webkit.org

10 edits in trunk

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu):
platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::setSubMenu):
platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
platform/gtk/WidgetGtk.cpp: (WebCore::Widget::retainPlatformWidget):
platform/network/soup/ResourceHandleSoup.cpp:

WebKit/gtk:

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

webkit/webkitwebview.cpp:

WebKitTools:

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):

3:12 AM Changeset in webkit [41282] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebKit/mac

Merge r41070.

3:12 AM Changeset in webkit [41281] by mrowe@apple.com

13 edits in branches/Safari-3-2-branch

Merge r41190.

3:12 AM Changeset in webkit [41280] by mrowe@apple.com

1 edit in branches/Safari-3-2-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Bump version number.

12:20 AM Changeset in webkit [41279] by krit@webkit.org

3 edits in trunk/WebCore

2009-02-26 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Added support for Gradients and Patterns on filled or stroked Fonts
in Cairo. I also added support for globalAlpha on FontCairo.

[CAIRO] SVG/Canvas fonts miss gradients/pattern support
https://bugs.webkit.org/show_bug.cgi?id=18617

html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):

Feb 26, 2009:

8:00 PM Changeset in webkit [41278] by adele@apple.com

5 edits in trunk/LayoutTests

2009-02-26 Adele Peterson <adele@apple.com>

Reviewed by Alice Liu.

Make the success/failure of this test more obvious.

editing/selection/designmode-no-caret.html:
platform/mac/editing/selection/designmode-no-caret-expected.checksum:
platform/mac/editing/selection/designmode-no-caret-expected.png:
platform/mac/editing/selection/designmode-no-caret-expected.txt:

7:32 PM Changeset in webkit [41277] by barraclough@apple.com

6 edits in trunk

JavaScriptCore:

2009-02-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Fix bug #23614. Switches on double precision values were incorrectly
truncating the scrutinee value. E.g.:

switch (1.1) { case 1: print("FAIL"); }

Was resulting in FAIL.

interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
jit/JITStubs.cpp: (JSC::JITStubs::cti_op_switch_imm):

LayoutTests:

2009-02-26 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Geoff Garen.

Layout test for bug #23614.

fast/js/resources/switch-behaviour.js:
fast/js/switch-behaviour-expected.txt:

5:15 PM Changeset in webkit [41276] by adele@apple.com

8 edits in trunk

WebKit/mac:

2009-02-26 Adele Peterson <adele@apple.com>

Reviewed by Geoff Garen.

Fix for <rdar://problem/6618166>
https://bugs.webkit.org/show_bug.cgi?id=24216
(REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message

During a series of firstResponder changes, at some point while the WebHTMLView was losing first responder status,
we incorrectly marked the page as active, and then when the WebHTMLView became first responder again, setActive did nothing.
This change restores behavior from before r36919 to check if the WebHTMLView is in the middle of losing first responder when calling setActive.

In addition to updating editing/selection/designmode-no-caret.html results, I also made sure the test cases that were
fixed in r36919 and r38570 are still fixed.

WebView/WebHTMLView.mm: (-[WebHTMLView resignFirstResponder]): Keep track if we're in the process of resigning first responder. (-[WebHTMLView _isResigningFirstResponder]): Added.
WebView/WebHTMLViewInternal.h:
WebView/WebView.mm: (-[WebView _updateFocusedAndActiveStateForFrame:]): Don't set the page to be active if the document view is currently resigning first responder.

LayoutTests:

2009-02-26 Adele Peterson <adele@apple.com>

Reviewed by Geoff Garen.

Updating results for <rdar://problem/6618166>
https://bugs.webkit.org/show_bug.cgi?id=24216
(REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message

We changed these results shortly after r36919, but the original result is actually correct.
The test's text indicates that we expect a caret to be placed in this case.

platform/mac/editing/selection/designmode-no-caret-expected.checksum:
platform/mac/editing/selection/designmode-no-caret-expected.png:
platform/mac/editing/selection/designmode-no-caret-expected.txt:

5:09 PM Changeset in webkit [41275] by barraclough@apple.com

4 edits in trunk/JavaScriptCore

2009-02-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Integer Immediate representation need not be canonical in x86 JIT code.
On x86-64 we already have loosened the requirement that the int immediate
representation in canonical, we should bring x86 into line.

This patch is a minor (~0.5%) improvement on sunspider & v8-tests, and
should reduce memory footoprint (reduces JIT code size).

jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileSlowCases):
jit/JIT.h: (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber):
jit/JITArithmetic.cpp: (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp):

4:20 PM Changeset in webkit [41274] by darin@chromium.org

7 edits in trunk/WebCore

2009-02-26 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23957

Fix for SVG gradient and pattern text for Chromium/skia.
Added accessors for the fill and stroke gradients to
GraphicsContext. Changed the paintSkiaText function to take a
GraphicsContext, so we can check for gradients/patterns.
Changed the skiaDrawText function to set the SkPaint shader
correctly, and to scale up the gradient shader matrix to
encompass the entire text string. Also offset each glyph
separately, rather than transforming the canvas, so that the
gradient/pattern stays fixed relative to the text origin.

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::getFillGradient): (WebCore::GraphicsContext::getStrokeGradient): (WebCore::GraphicsContext::getFillPattern): (WebCore::GraphicsContext::getStrokePattern):
platform/graphics/GraphicsContext.h:
platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw):
platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleTextDrawing): (WebCore::skiaDrawText): (WebCore::paintSkiaText):
platform/graphics/skia/SkiaFontWin.h:

3:29 PM Changeset in webkit [41273] by Dimitri Glazkov

1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog entry

3:27 PM Changeset in webkit [41272] by Dimitri Glazkov

1 edit
4 adds in trunk/WebCore

2009-02-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

http://codereview.chromium.org/27217
Add custom V8 bindings for Navigator, Clipboard, Document, and Node.

bindings/v8/custom/V8ClipboardCustom.cpp: Added. (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8DocumentCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8NavigatorCustom.cpp: Added. (WebCore::ACCESSOR_GETTER):
bindings/v8/custom/V8NodeCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):

3:00 PM Changeset in webkit [41271] by kov@webkit.org

2 edits in trunk/WebCore

2009-02-26 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix for building with GNOME Keyring enabled.

platform/network/soup/webkit-soup-auth-dialog.c: (show_auth_dialog):

2:45 PM Changeset in webkit [41270] by kov@webkit.org

7 edits
2 adds in trunk

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=16947
[GTK] Missing HTTP Auth challenge

Add HTTP authentication dialog with optional GNOME Keyring
storage.

GNUmakefile.am:
platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::currentToplevelCallback): (WebCore::ResourceHandle::startHttp): (WebCore::ResourceHandle::start):
platform/network/soup/webkit-soup-auth-dialog.c: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (free_authData): (set_password_callback): (response_callback): (show_auth_dialog): (find_password_callback): (session_authenticate): (attach):
platform/network/soup/webkit-soup-auth-dialog.h: Added.

1:11 PM Changeset in webkit [41269] by eric@webkit.org

3 edits in trunk/WebCore

2009-02-25 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>

Reviewed by Dave Hyatt.

After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
started failing because Ojan's new code was now *correctly* calling through to
SVG asking for the closest text offset in the last line box, instead of
just returning the offset at the end of the last line box when clicking below a box.

But! The SVG code was wrong, in that it returned the character offset of the last
character when you asked for a character offset after the end of the box, instead
it should return the offset *after* the last character. This patch fixes
that behavior by reordering the last two clauses in svgCharacterHitsPosition.

The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
to document what's wrong. I've also cleaned up the code a bit so it's clearer
what it is doing (which also makes more obvious what's wrong with it).

rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForCoordinates):
rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter): (WebCore::SVGInlineTextBox::closestCharacterToPosition): (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):

12:40 PM Changeset in webkit [41268] by darin@chromium.org

3 edits in trunk/WebCore

2009-02-26 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Minor cleanup of ChromiumBridge:
Removing unused matchesMIMEType method and s/Javascript/JavaScript/

platform/chromium/ChromiumBridge.h:
platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):

12:36 PM Changeset in webkit [41267] by hyatt@apple.com

3 edits
4 adds in trunk

WebCore:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig

Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including
the line-height below the descent.

Added fast/inline/vertical-align-text-bottom.html

rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::verticalPosition):

LayoutTests:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig

Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including
the line-height below the descent.

fast/inline/vertical-align-text-bottom.html: Added.
platform/mac/fast/inline/vertical-align-text-bottom-expected.checksum: Added.
platform/mac/fast/inline/vertical-align-text-bottom-expected.png: Added.
platform/mac/fast/inline/vertical-align-text-bottom-expected.txt: Added.

12:11 PM Changeset in webkit [41266] by krit@webkit.org

12 edits
5 deletes in trunk

2009-02-26 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
just to implement this three methods to support SVG Masking now.

Make SVG Masking platform aware
https://bugs.webkit.org/show_bug.cgi?id=19243

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.

LayoutTests:
Corrected some tests after the new SVG Masking implementation for Mac.

Make SVG Masking platform aware
https://bugs.webkit.org/show_bug.cgi?id=19243

platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
svg/custom/mask-excessive-malloc.svg:

12:09 PM Changeset in webkit [41265] by treat@webkit.org

5 edits
3 adds in trunk

2009-02-26 Yong Li <yong.li@torchmobile.com>

Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.

Test: http/tests/misc/slow-preload-cancel.html

https://bugs.webkit.org/show_bug.cgi?id=24133
Clear all pending preloads in the DocLoader object when we decide to
cancel its all requests.

loader/DocLoader.cpp: (WebCore::DocLoader::clearPendingPreloads):
loader/DocLoader.h:
loader/loader.cpp: (WebCore::Loader::cancelRequests):

12:07 PM Changeset in webkit [41264] by andersca@apple.com

5 edits in trunk/WebKit/mac

2009-02-25 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Fix <rdar://problem/6623697>.

Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::print): Ask the plug-in host to print, create a CGImage of the returned bytes and draw the image into the passed in context.

Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]): When printing, call NetscapePluginInstanceProxy::print.

Plugins/Hosted/WebKitPluginHost.defs:

11:43 AM Changeset in webkit [41263] by Dimitri Glazkov

1 edit
3 adds in trunk/WebCore

2009-02-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24182
Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.

bindings/v8/custom/V8NodeFilterCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8NodeIteratorCustom.cpp: Added. (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8TreeWalkerCustom.cpp: Added. (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):

11:40 AM Changeset in webkit [41262] by ap@webkit.org

4 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23500
KURL::parse() incorrectly compares its result to original string

platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.

11:35 AM Changeset in webkit [41261] by Dimitri Glazkov

1 edit
1 add in trunk/WebCore

2009-02-26 Ojan Vafai <ojan@chromium.org>

Reviewed by Kevin McCullough.

Manual test for inspector node highlighting.

manual-tests/inspector/highlight-nodes.html: Added.

11:32 AM Changeset in webkit [41260] by darin@chromium.org

2 edits in trunk/WebCore

2009-02-16 Anantanarayanan Iyengar <ananta@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=23973
ScrollView::scrollContents can be invoked during view shutdown. In
this scenario the FrameView::hostWindow method can return NULL, which
indicates that the frame/page is being destroyed. This causes a crash
when we try to dereference a NULL hostWindow pointer. Fix is to add a
NULL check for this.

platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):

11:11 AM Changeset in webkit [41259] by Dimitri Glazkov

3 edits
2 adds in trunk

WebCore:

2009-02-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24003
Fix a crash caused by unsafe type conversion.

Test: fast/block/positioning/absolute-in-inline-rtl-4.html

rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues):

LayoutTests:

2009-02-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24003
Fix a crash caused by unsafe type conversion.

fast/block/positioning/absolute-in-inline-rtl-4-expected.txt: Added.
fast/block/positioning/absolute-in-inline-rtl-4.html: Added.

10:59 AM Changeset in webkit [41258] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-02-26 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=24202
Have drawNodeHighlight clip instead of clearing. This makes it work for
both Safari and Chromium since Chromium draws the inspector highlighting
in the same buffer as the page.

inspector/InspectorController.cpp: (WebCore::quadToPath): (WebCore::drawOutlinedQuad): (WebCore::drawOutlinedQuadWithClip): (WebCore::drawHighlightForBox):

10:45 AM Changeset in webkit [41257] by hyatt@apple.com

3 edits
4 adds in trunk

WebCore:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein & Darin Adler

Make sure the border/padding are properly omitted at the start of an inline that is a continuation.

Added fast/inline/inline-continuation-borders.html

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):

LayoutTests:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein & Darin Adler

Make sure the border/padding are properly omitted at the start of an inline that is a continuation.

fast/inline/inline-continuation-borders.html: Added.
platform/mac/fast/inline/inline-continuation-borders-expected.checksum: Added.
platform/mac/fast/inline/inline-continuation-borders-expected.png: Added.
platform/mac/fast/inline/inline-continuation-borders-expected.txt: Added.

10:30 AM Changeset in webkit [41256] by ap@webkit.org

4 edits in trunk/WebKit

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24024
REGRESSION (r39845): Assertion failure in -[WebHistoryItem dictionaryRepresentation] when
archiving a submission to about:blank

I don't know how to make an automated test for this bug.

History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
WebHistory.cpp: (WebHistory::visitedURL): Account for the fact that HTTP method may be non-empty for non-HTTP requests.

10:21 AM Changeset in webkit [41255] by Simon Fraser

2 edits in trunk/WebCore

2009-02-26 Simon Fraser <Simon Fraser>

Build fix, no review.

Try to fix the wx build after r41218.

WebCoreSources.bkl:

10:19 AM Changeset in webkit [41254] by pam@chromium.org

1 edit
2 adds in trunk/LayoutTests

2009-02-25 Pamela Greene <pam@chromium.org>

Reviewed by Darin Fisher.

Add test that custom DOM properties survive garbage collection.
https://bugs.webkit.org/show_bug.cgi?id=24142

fast/dom/Window/customized-property-survives-gc-expected.txt: Added.
fast/dom/Window/customized-property-survives-gc.html: Added.

10:17 AM Changeset in webkit [41253] by ap@webkit.org

4 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19527
ASSERTION FAILED: containerA && containerB

Test: fast/dom/Range/bug-19527.html

dom/Range.cpp: (WebCore::Range::isPointInRange): (WebCore::Range::comparePoint): Bring the behavior in line with current Firefox, making it impossible for these methods to pass a null container to compareBoundaryPoints().

9:08 AM Changeset in webkit [41252] by zecke@webkit.org

2 edits in trunk/JavaScriptCore

2009-02-26 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24099
ARM Compiler Warnings in pcre_exec.cpp

pcre/pcre_exec.cpp: (match):

8:48 AM Changeset in webkit [41251] by zecke@webkit.org

3 edits
1 add in trunk

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=16947
[GTK] Missing HTTP Auth challenge

Take marshallers to be built from a manually maintained list
instead of grepping the sources.

It's much faster, especially so now that we want to add
marshallers from WebCore too. A system to only take into account
the modified files when generating the marshallers from sources
could be hacked, but I think it's overkill considering how rarely
a new marshaller is added.

8:40 AM Changeset in webkit [41250] by zecke@webkit.org

1 edit in trunk/WebKit/gtk/ChangeLog

Fix the ChangeLog s/frame/content.

I should have read more about the bug history and should have
done the substitution before landing.

8:33 AM Changeset in webkit [41249] by zecke@webkit.org

2 edits in trunk/WebKit/gtk

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24193
[GTK] Checkbuttons not activated with space

Do not swallow key events with GtkIMContext for non-editable
frames (FIXME: I don't think frame is the right name here).

WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleInputMethodKeydown):

8:27 AM Changeset in webkit [41248] by zecke@webkit.org

2 edits in trunk/WebKit/gtk

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24103
[GTK] Use correct return value for WebView button-release handler

We are returning whatever the core code tells us it did, but this
does not play well with the GTK+ model. GTK+ in general expects it
will see a button-release if it saw a button-press and no
motion/leave/etc events in between. EventHandler.cpp will, in some
cases, not handle press but handle release, confusing the parent
container of the WebView.

As a workaround return always FALSE for button-release (this is
the same than the Windows port does).

webkit/webkitwebview.cpp:

8:21 AM Changeset in webkit [41247] by zecke@webkit.org

4 edits in trunk/WebKit/gtk

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=17585
[gtk] get|set encoding api

Add functions to get and set a custom encoding an a view.

webkit/webkitprivate.h:
webkit/webkitwebview.cpp: (webkit_web_view_set_custom_encoding): (webkit_web_view_get_custom_encoding):
webkit/webkitwebview.h:

8:14 AM Changeset in webkit [41246] by zecke@webkit.org

2 edits in trunk/WebCore

Make font-variant:small-caps work properly (bug #20358)

Set the computed size of the small caps font data rather than the specified size
so that the small-caps text is rendered smaller

6:13 AM Changeset in webkit [41245] by treat@webkit.org

2 edits in trunk/WebCore

2009-02-26 Benjamin Meyer <benjamin.meyer@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=24062
QNetworkCookieJar expects the url and not the policy url. Sending the
policy url will cause QNetworkCookieJar to behave incorrectly. One
example would be a cookie that does not have a path or domain.
QNetworkCookieJar will use the url it is given to fill in default values.
This allows setting cookies on the url of the main frame from an iFrame
when the cookie should be set on the url of the iFrame.

Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do

platform/qt/CookieJarQt.cpp: (WebCore::setCookies):

3:09 AM Changeset in webkit [41244] by staikos@webkit.org

3 edits in trunk/WebCore

2009-02-26 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

make WebKit/Qt compile with SVG disabled

WebCore.pro:
platform/graphics/qt/FontPlatformDataQt.cpp:

Feb 25, 2009:

11:04 PM Changeset in webkit [41243] by cwzwarich@webkit.org

3 edits
3 adds in trunk

2009-02-25 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Gavin Barraclough.

Bug 24086: Regression (r40993): WebKit crashes after logging in to lists.zenbe
<https://bugs.webkit.org/show_bug.cgi?id=24086>
<rdar://problem/6625111>

The numeric sort optimization in r40993 generated bytecode for a function
without generating JIT code. This breaks an assumption in some parts of
the JIT's function calling logic that the presence of a CodeBlock implies
the existence of JIT code.

In order to fix this, we simply generate JIT code whenever we check whether
a function is a numeric sort function. This only incurs an additional cost
in the case when the function is a numeric sort function, in which case it
is not expensive to generate JIT code for it.

JavaScriptCore:

runtime/ArrayPrototype.cpp: (JSC::isNumericCompareFunction):

LayoutTests:

fast/js/resources/sort-no-jit-code-crash.js: Added.
fast/js/sort-no-jit-code-crash-expected.txt: Added.
fast/js/sort-no-jit-code-crash.html: Added.

8:31 PM Changeset in webkit [41242] by kov@webkit.org

2 edits in trunk/WebCore

2009-02-25 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix. Add WebCore/workers to the list of paths
searched by the bindings generator perl script.

GNUmakefile.am:

7:45 PM Changeset in webkit [41241] by weinig@apple.com

2 edits in trunk/WebCore

2009-02-25 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Add canvas to the list of RenderObjects that can mark a page as
visually not empty.

rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):

6:19 PM Changeset in webkit [41240] by eric.carlson@apple.com

2 edits in trunk/WebCore

2009-02-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dave Hyatt.

rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer as RenderMedia with controls always has a layer.

6:12 PM Changeset in webkit [41239] by Simon Fraser

3 edits in trunk/WebKitTools

2009-02-25 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

Fix spew about a WebView being deallocated while key value observers are
still registered with it by making sure that we always stop observing
_isUsingAcceleratedCompositing in -[DumpRenderTreeWindow close].

DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree):
DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow close]):

5:24 PM Changeset in webkit [41238] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Simon Fraser.

fix https://bugs.webkit.org/show_bug.cgi?id=24130 <rdar://problem/6618196> Paint very slow when horizontally resizing

Test: fast/gradients/background-clipped.html

rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the destination rectangle passed to drawTiledImage() with the dirty rectangle. This makes it more likely for the destination rect to be contained in a single tile rect, which results in a faster code path being taken down the road (just drawing a single tile instead of tiling).

LayoutTests:

Reviewed by Simon Fraser.

test for https://bugs.webkit.org/show_bug.cgi?id=24130 <rdar://problem/6618196> Paint very slow when horizontally resizing

fast/gradients/background-clipped.html: Added.
platform/mac/fast/gradients/background-clipped-expected.checksum: Added.
platform/mac/fast/gradients/background-clipped-expected.png: Added.
platform/mac/fast/gradients/background-clipped-expected.txt: Added.

4:35 PM Changeset in webkit [41237] by eric@webkit.org

8 edits in trunk

2009-02-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Fix test regressions from positionForCoordinates patch.
https://bugs.webkit.org/show_bug.cgi?id=24148

rendering/RenderBlock.cpp: (WebCore::positionForPointWithInlineChildren): Remove ASSERT that placeholder text codepath is hitting.

4:27 PM Changeset in webkit [41236] by Chris Fleizach

21 edits
2 adds in trunk

Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
https://bugs.webkit.org/show_bug.cgi?id=24143

When an AX object is marked dirty, do not create AX elements while going up the parent chain.
Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
Make sure the AXObjectWrapper's have an object before calling them
In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists

4:16 PM Changeset in webkit [41235] by Beth Dakin

2 edits in trunk/WebCore

2009-02-25 Beth Dakin <Beth Dakin>

Reviewed by Geoff Garen.

Re-working of <rdar://problem/6487249> repro crash in
WebCore::CSSParser::parseFillImage copying entire contents of this
page
-and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172

Fixes a bunch of layout test failures I caused!

css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage):

3:59 PM Changeset in webkit [41234] by Dimitri Glazkov

1 edit
8 adds in trunk/WebCore

2009-02-25 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24174
Add more V8 custom bindings.

bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added. (WebCore::hasCSSPropertyNamePrefix): (WebCore::cssPropertyName): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER):
bindings/v8/custom/V8DOMStringListCustom.cpp: Added. (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8EventCustom.cpp: Added. (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER):
bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added. (WebCore::NAMED_PROPERTY_DELETER): (WebCore::NAMED_PROPERTY_SETTER): (WebCore::NAMED_PROPERTY_GETTER):
bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER):
bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added. (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
bindings/v8/custom/V8NodeListCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER):
bindings/v8/custom/V8StyleSheetListCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER):

3:52 PM Changeset in webkit [41233] by Dimitri Glazkov

6 edits in trunk/WebCore

2009-02-25 Scott Violet <sky@google.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24171
Provides a RenderTheme method for getting the scroll bar size and
changes RenderListBox to use it. RenderTheme returns a size of regular,
and Mac's override to return small. Changes ScrollbarThemeChromium to
use the scrollbarsize of the scrollbar when getting the size
instead of passing in no-args.

platform/chromium/ScrollbarThemeChromium.cpp: (WebCore::ScrollbarThemeChromium::trackRect): (WebCore::ScrollbarThemeChromium::buttonSize):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::createScrollbar):
rendering/RenderTheme.h: (WebCore::RenderTheme::scrollbarControlSizeForPart):
rendering/RenderThemeChromiumMac.h: (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
rendering/RenderThemeMac.h: (WebCore::RenderThemeMac::scrollbarControlSizeForPart):

3:44 PM Changeset in webkit [41232] by ggaren@apple.com

12 edits
3 adds in trunk

JavaScriptCore:

2009-02-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/6611174> REGRESSION (r36701): Unable to select
messages on hotmail (24052)

The bug was that for-in enumeration used a cached prototype chain without
validating that it was up-to-date.

This led me to refactor prototype chain caching so it was easier to work
with and harder to get wrong.

After a bit of inlining, this patch is performance-neutral on SunSpider
and the v8 benchmarks.

interpreter/Interpreter.cpp: (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID):
jit/JITStubs.cpp: (JSC::JITStubs::tryCachePutByID): (JSC::JITStubs::tryCacheGetByID): (JSC::JITStubs::cti_op_get_by_id_proto_list): Use the new refactored goodness. See lines beginning with "-" and smile.

runtime/JSGlobalObject.h: (JSC::Structure::prototypeForLookup): A shout out to const.

runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::next): We can use a pointer comparison to see if our cached structure chain is equal to the object's structure chain, since in the case of a cache hit, we share references to the same structure chain.

runtime/Operations.h: (JSC::countPrototypeChainEntriesAndCheckForProxies): Use the new refactored goodness.

runtime/PropertyNameArray.h: (JSC::PropertyNameArray::PropertyNameArray): (JSC::PropertyNameArray::setShouldCache): (JSC::PropertyNameArray::shouldCache): Renamed "cacheable" to "shouldCache" to communicate that the client is specifying a recommendation, not a capability.

runtime/Structure.cpp: (JSC::Structure::Structure): No need to initialize a RefPtr. (JSC::Structure::getEnumerablePropertyNames): Moved some code into helper functions.

(JSC::Structure::prototypeChain): New centralized accessor for a prototype
chain. Revalidates on every access, since the objects in the prototype
chain may have mutated.

(JSC::Structure::isValid): Helper function for revalidating a cached
prototype chain.

(JSC::Structure::getEnumerableNamesFromPropertyTable):
(JSC::Structure::getEnumerableNamesFromClassInfoTable): Factored out of
getEnumerablePropertyNames.

runtime/Structure.h:

runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain):
runtime/StructureChain.h: (JSC::StructureChain::create): No need for structureChainsAreEqual, since we use pointer equality now. Refactored StructureChain to make a little more sense and eliminate special cases for null prototypes.

LayoutTests:

2009-02-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Added a test for <rdar://problem/6611174> REGRESSION (r36701): Unable to
select messages on hotmail (24052)

fast/js/for-in-cached-expected.txt: Added.
fast/js/for-in-cached.html: Added.
fast/js/resources/for-in-cached.js: Added. (forIn):

2:58 PM Changeset in webkit [41231] by Beth Dakin

3 edits
2 adds in trunk

WebCore:

2009-02-25 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for <rdar://problem/6487249> repro crash in
WebCore::CSSParser::parseFillImage copying entire contents of this
page
-and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172

css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Null-check m_styleSheet

LayoutTests:

2009-02-25 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Test for <rdar://problem/6487249> repro crash in
WebCore::CSSParser::parseFillImage copying entire contents of this
page
-and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172

editing/pasteboard/copy-crash-with-extraneous-attribute-expected.txt: Added.
editing/pasteboard/copy-crash-with-extraneous-attribute.html: Added.

1:37 PM Changeset in webkit [41230] by treat@webkit.org

2 edits in trunk/WebCore

2009-02-25 Adam Treat <adam.treat@torchmobile.com>

Fix the Qt build.

WebCore.pro:

12:59 PM Changeset in webkit [41229] by Simon Fraser

2 edits in trunk/WebKit/mac

2009-02-25 Simon Fraser <Simon Fraser>

Build fix with ACCELERATED_COMPOSITING turned on.

I missed a spot in my last commit in renaming to
_stoppedAcceleratedCompositingForFrame:

WebView/WebHTMLView.mm: (-[WebHTMLView close]):

12:45 PM Changeset in webkit [41228] by treat@webkit.org

2 edits in trunk/WebKitTools

2009-02-25 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Alexey Proskuryakov.

Do not queue the calls to 'DumpRenderTree::dump()' as this can result
in more than one call as a test that calls 'notifyDone()' can then be
subsequently fully loaded and initiate a second dump. Also make sure
to stop any existing page load that is happening before running the next
test. Combined this serves to produce 217 more passing tests for the
Qt port or roughly 5% at this point.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open):

12:39 PM Changeset in webkit [41227] by jmalonzo@webkit.org

3 edits in trunk/WebCore

2009-02-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix. Not reviewed.

Add files to the build per r41218.
Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp

GNUmakefile.am:
page/DOMWindow.cpp:

12:29 PM Changeset in webkit [41226] by kov@webkit.org

2 edits in trunk/WebCore

2009-02-25 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24043
When faced with URLs with unsupported protocol on Gtk port,
report the error through an idle function and return true, so
a proper resource handle is created.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::reportUnknownProtocolError): (WebCore::ResourceHandle::start):

12:22 PM Changeset in webkit [41225] by sfalken@apple.com

16 edits in trunk/WebCore

Windows build fix.
Use struct to forward declare ResourceRequest.

history/HistoryItem.h:
inspector/InspectorController.h:
loader/DocumentThreadableLoader.h:
loader/FrameLoaderClient.h:
loader/MainResourceLoader.h:
loader/SubresourceLoader.h:
loader/SubresourceLoaderClient.h:
loader/ThreadableLoader.h:
loader/WorkerThreadableLoader.h:
platform/CrossThreadCopier.h:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleClient.h:
platform/network/ResourceRequestBase.h:
platform/network/cf/ResourceRequestCFNet.h:
xml/XMLHttpRequest.h:

12:12 PM Changeset in webkit [41224] by Simon Fraser

10 edits in trunk

2009-02-25 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=23854

Make an observable property, _isUsingAcceleratedCompositing, on
WebView that DumpRenderTree can use to specialize behavior.

This is implemented via a count of Frames that are using
accelerated compositing.

11:56 AM Changeset in webkit [41223] by alp@webkit.org

4 edits in trunk/WebKit/win

2009-02-25 Andreia Gaita <shana@jitted.com>

Reviewed by Alp Toker.

Update Win def files with recent JavaScriptCore API additions.

WebKit.vcproj/WebKit.def:
WebKit.vcproj/WebKit_Cairo.def:
WebKit.vcproj/WebKit_debug.def:

11:50 AM Changeset in webkit [41222] by sfalken@apple.com

3 edits in trunk/WebCore

Partial Windows build fix.

DerivedSources.cpp:
WebCore.vcproj/WebCore.vcproj:

11:43 AM Changeset in webkit [41221] by krit@webkit.org

2 edits in trunk/WebCore

2009-02-25 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Ported arcTo to Qt. Qt has no native support for arcTo. This changes
calculate the behavior of arcTo and draws it with lineTo and arc.

[QT] implement Canvas arcTo
https://bugs.webkit.org/show_bug.cgi?id=23873

platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo):

11:29 AM Changeset in webkit [41220] by Simon Fraser

2 edits in trunk/WebCore

2009-02-25 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

Remove idl files from Resources, and sort.

WebCore.xcodeproj/project.pbxproj:

11:11 AM Changeset in webkit [41219] by sfalken@apple.com

2 edits in trunk/JavaScriptCore

Use timeBeginPeriod to enable timing resolution greater than 16ms in command line jsc for Windows.
Allows more accurate reporting of benchmark times via command line jsc.exe. Doesn't affect WebKit's use of JavaScriptCore.

Reviewed by Adam Roben.

jsc.cpp: (main):

11:09 AM Changeset in webkit [41218] by cmarrin@apple.com

15 edits
6 adds in trunk

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=23943

Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
the window object. Also added WebKitPoint object, which is passed in and out
of these functions.

10:06 AM Changeset in webkit [41217] by levin@chromium.org

3 edits in trunk/WebCore

2009-02-25 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
https://bugs.webkit.org/show_bug.cgi?id=24145

platform/CrossThreadCopier.cpp:
platform/CrossThreadCopier.h:

10:06 AM Changeset in webkit [41216] by levin@chromium.org

8 edits in trunk/WebCore

2009-02-25 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23688: ThreadableLoader needs a sync implementation for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=23688>

No observable change in behavior, so no test.

loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::loadResourceSynchronously):
loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::clearClient): (WebCore::ThreadableLoaderClientWrapper::done): (WebCore::ThreadableLoaderClientWrapper::didFinishLoading): (WebCore::ThreadableLoaderClientWrapper::didFail): (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck): (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper): Expose whether the loader is done (based on what callbacks were done).

loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::loadResourceSynchronously): Each loader is given its own mode so that only its callbacks get through the run loop.

The xhr spec says that the readystatechange events are synchronous, so in the case of a
nested sync xhr no readystatechange events should be fired for the outer xhr.

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):

loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create): (WebCore::WorkerThreadableLoader::done):

workers/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::WorkerRunLoop):
workers/WorkerRunLoop.h: (WebCore::WorkerRunLoop::createUniqueId): Simple method to create a uniqueId on demand with respect to the run loop.

workers/WorkerThread.h:

10:06 AM Changeset in webkit [41215] by levin@chromium.org

10 edits in trunk

WebCore:

2009-02-25 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
<https://bugs.webkit.org/show_bug.cgi?id=24089>

Make threadable loader callbacks to happen during the sync load call.

Changes the behavior of sync xhr for insecure redirects in two ways:
+ Sends an error event instead of an abort event (which is the same as async xhr's behavior).
+ Throws a network exception which is what other browsers do and what the spec
says to do (http://www.w3.org/TR/XMLHttpRequest/).

loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
loader/DocumentThreadableLoader.h:
loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::loadResourceSynchronously):
loader/ThreadableLoader.h:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::loadRequestSynchronously): (WebCore::XMLHttpRequest::loadRequestAsynchronously): (WebCore::XMLHttpRequest::didFail): (WebCore::XMLHttpRequest::didFailRedirectCheck):
xml/XMLHttpRequest.h:

LayoutTests:

2009-02-25 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
<https://bugs.webkit.org/show_bug.cgi?id=24089>

Modified the test to account for behavior change and output more information to better detect
future changes in behavior.

http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt:
http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html:

9:55 AM Changeset in webkit [41214] by cmarrin@apple.com

5 edits
8 adds in trunk

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23368

Added logic to correctly hit test accelerated layers.

9:01 AM Changeset in webkit [41213] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24067
REGRESSION: Crash in WebCore::Document::initSecurityContext

The crash started to happen when we removed a check for frame->document() being null.
However, the original document shouldn't be null here, because it is needed to alias
security origins. So, this patch fixes the crash by correcting security origin behavior.

Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
This tests for not crashing, and for inheriting the domain from the document being replaced.
Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
domain to remove a prefix from.

loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before clearing the frame, so that Document::initSecurityContext() could access the old one.

8:58 AM Changeset in webkit [41212] by darin@chromium.org

2 edits in trunk/WebCore

2009-02-25 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24066

Items in drop-downs were not painted correctly. Makes sure the
PopupListBox invalidates in the coordinates of the window as this is
FramelessScrollView::invalidateRect paints to.

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::invalidateRow):

8:14 AM QtWebKitContrib edited by henrique@bastos.net

added Zack Rusin's irc nickname (diff)

6:12 AM Changeset in webkit [41211] by treat@webkit.org

8 edits
3 adds in trunk

2009-02-25 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Zack Rusin.

https://bugs.webkit.org/show_bug.cgi?id=24158
Implement the queue*() methods of the layoutTestController and begin
implementing the dump of the back/forward list. This results in 2% more
tests passing as well as 23 currently skipped tests now passing.

DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::dumpBackForwardList): (WebCore::DumpRenderTree::dump):
DumpRenderTree/qt/DumpRenderTree.h:
DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/jsobjects.cpp: (findFrameNamed): (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript):
DumpRenderTree/qt/jsobjects.h: (LayoutTestController::shouldDumpBackForwardList): (LayoutTestController::dumpBackForwardList):

4:12 AM Changeset in webkit [41210] by Simon Hausmann

2 edits in trunk/WebKit/qt

2009-02-25 Kavindra Palaraja <kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Fix the documentation for the linkHovered signal.

Api/qwebpage.cpp:

Feb 24, 2009:

10:18 PM Changeset in webkit [41209] by Simon Fraser

6 edits
13 adds in trunk

2009-02-24 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson

https://bugs.webkit.org/show_bug.cgi?id=15081

Make display:none work for applet, emebed and object elements
by calling rendererIsNeeded() on superclasses.

Tests: fast/replaced/applet-display-none.html

fast/replaced/embed-display-none.html
fast/replaced/object-display-none.html

html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::rendererIsNeeded):
html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsNeeded):
html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):

6:50 PM Changeset in webkit [41208] by Simon Fraser

24 edits
2 adds in trunk/WebCore

2009-02-24 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24137

Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
taking perspective and transform-style: preserve-3d into account.

In order to support transform-style: preserve-3d, which keeps elements in a
3d space, we have to carry along an accumulated matrix in TransformState.
We also need to apply the perspective from the parent, if any, with the
appropriate origin.

6:38 PM Changeset in webkit [41207] by weinig@apple.com

3 edits
2 adds in trunk

WebCore:

2009-02-24 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
Regression (r40837): JavaScript image popup doesn't work

Make the getClientRects and getBoundingClientRect methods return rects
relative to the viewport.

Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html

dom/Element.cpp: (WebCore::Element::getClientRects): (WebCore::Element::getBoundingClientRect):

LayoutTests:

2009-02-24 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Test for https://bugs.webkit.org/show_bug.cgi?id=23990
Regression (r40837): JavaScript image popup doesn't work

fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport-expected.txt: Added.
fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html: Added.

5:46 PM Changeset in webkit [41206] by eric@webkit.org

2 edits in trunk/WebCore

2009-02-24 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

SVG pages don't have a body or an html element!
Don't return early if there is no body.

editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):

5:34 PM Changeset in webkit [41205] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/fast/block/float/033-expected.txt

Update some layout test results from my previous checkin.

5:33 PM Changeset in webkit [41204] by hyatt@apple.com

3 edits in trunk/LayoutTests/platform/mac/fast/repaint

Update some layout test results from my previous checkin.

5:21 PM Changeset in webkit [41203] by hyatt@apple.com

18 edits
8 adds in trunk

WebCore:

2009-02-23 David Hyatt <hyatt@apple.com>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden

This patch reworks the painting of overflow. There is now the concept of a "self-painting layer." All
layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
reflections or masks).

If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
The only difference is that the clip has to be pushed and popped when painting the object's children.

The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case. With
the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
use the new functions.

Hit testing has also been patched to check the overflow clip rect first before recurring into children.

Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
yet, and scrollbar hit testing was already there anyway. Now the two code paths are more symmetrical.

Masks are now treated like normal flow layers (just like reflections).

A couple of test cases have been added to fast/overflow to test the stacking order.

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint): (WebCore::InlineFlowBox::paint):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::floatRect): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents):
rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::pushContentsClip): (WebCore::RenderBox::popContentsClip):
rendering/RenderBox.h: (WebCore::RenderBox::paintObject):
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
rendering/RenderBoxModelObject.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
rendering/RenderLayer.h:
rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintObject): (WebCore::RenderTable::nodeAtPoint):
rendering/RenderTable.h:
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint):
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): (WebCore::RenderTableRow::paint):
rendering/RenderTableRow.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::paintObject): (WebCore::RenderTableSection::nodeAtPoint):
rendering/RenderTableSection.h:
rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::writeLayers):

LayoutTests:

2009-02-24 David Hyatt <hyatt@apple.com>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden

This patch reworks the painting of overflow. There is now the concept of a "self-painting layer." All
layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
reflections or masks).

If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
The only difference is that the clip has to be pushed and popped when painting the object's children.

The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case. With
the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
use the new functions.

Hit testing has also been patched to check the overflow clip rect first before recurring into children.

Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
yet, and scrollbar hit testing was already there anyway. Now the two code paths are more symmetrical.

Masks are now treated like normal flow layers (just like reflections).

A couple of test cases have been added to fast/overflow to test the stacking order.

fast/overflow/overflow-float-stacking.html: Added.
fast/overflow/overflow-stacking.html: Added.
platform/mac/fast/overflow/overflow-float-stacking-expected.checksum: Added.
platform/mac/fast/overflow/overflow-float-stacking-expected.png: Added.
platform/mac/fast/overflow/overflow-float-stacking-expected.txt: Added.
platform/mac/fast/overflow/overflow-stacking-expected.checksum: Added.
platform/mac/fast/overflow/overflow-stacking-expected.png: Added.
platform/mac/fast/overflow/overflow-stacking-expected.txt: Added.

5:05 PM Changeset in webkit [41202] by levin@chromium.org

2 edits in trunk/WebCore

2009-02-24 David Levin <levin@chromium.org>

Reviewed by NOBODY (build fix).

Attempted build fix for wx-mac.

WebCoreSources.bkl:

4:54 PM Changeset in webkit [41201] by Simon Fraser

2 edits in trunk/LayoutTests

2009-02-24 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=24135

Update the expected value after testcase change.

fast/events/offsetX-offsetY-expected.txt:

4:46 PM Changeset in webkit [41200] by levin@chromium.org

3 edits in trunk/WebCore

2009-02-24 David Levin <levin@chromium.org>

Reviewed by NOBODY (build fix).

Attempted build fixes for qt-linux and wx-mac.

WebCore.pro:
webcore-base.bkl:

4:32 PM Changeset in webkit [41199] by weinig@apple.com

2 edits in trunk/WebCore

2009-02-24 Ojan Vafai <ojan@chromium.org>

Reviewed by Sam Weinig

Fix null pointer error. If the node is the Document, then ownerDocument()
returns null, document() does not.

editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):

4:20 PM Changeset in webkit [41198] by levin@chromium.org

3 edits in trunk/WebCore

2009-02-24 Jian Li <jianli@chromium.org>

Reviewed by NOBODY (attempted build fixes).

Fix build break for Windows and Linux.

GNUmakefile.am:
WebCore.vcproj/WebCore.vcproj:

4:18 PM Changeset in webkit [41197] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-02-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24131
Fix-up COM/RefCounted dichotomy in Chromium port.

page/chromium/AccessibilityObjectWrapper.h: (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added explicit setting of recount.

4:13 PM Changeset in webkit [41196] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-02-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24141
Add clarity to V8 interceptor helper function.

bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor. (WebCore::NAMED_PROPERTY_SETTER): Ditto. (WebCore::INDEXED_PROPERTY_GETTER): Ditto. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.

3:57 PM Changeset in webkit [41195] by Simon Fraser

2 edits in trunk/WebCore

2009-02-24 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

Minor numeric cleanup: convert float literals to doubles.

platform/graphics/transforms/RotateTransformOperation.cpp: (WebCore::RotateTransformOperation::blend):

3:22 PM Changeset in webkit [41194] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-02-24 Mark Mentovai <mark@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24139
Add missing include.

bindings/v8/ScriptInstance.h:

3:16 PM Changeset in webkit [41193] by levin@chromium.org

8 edits
20 moves
1 add in trunk/WebCore

2009-02-24 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Move worker related files from dom directory to worker directory under WebCore.
https://bugs.webkit.org/show_bug.cgi?id=24123

DerivedSources.make:
GNUmakefile.am:
WebCore.pro:
WebCore.scons:
WebCore.vcproj/MigrateIDLAndScripts:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
workers/Worker.h: Renamed from WebCore/dom/Worker.h.
workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.

2:57 PM Changeset in webkit [41192] by Simon Fraser

3 edits in trunk/WebCore

2009-02-24 Simon Fraser <Simon Fraser>

Fix build when ACCELERATED_COMPOSITING is turned on
(overflowList() -> normalFlowList()).

rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::hasNonCompositingContent): (WebCore::RenderLayerBacking::paintIntoLayer):
rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): (WebCore::RenderLayerCompositor::layerHas3DContent):

2:28 PM Changeset in webkit [41191] by eric@webkit.org

8 edits
12 adds
5 deletes in trunk

2009-02-05 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>

Reviewed by Dave Hyatt.

Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
around divs inside editable regions.
https://bugs.webkit.org/show_bug.cgi?id=23605

Fix clicks outside editable regions from focusing the editable region.
https://bugs.webkit.org/show_bug.cgi?id=23607

Removed editing/selection/contenteditable-click-outside.html as it's
not as useful as our new tests.

Clean up RenderBlock::positionForCoordinates to remove dead code,
duplicate code, and generally make it more readable.

Tests: editing/selection/click-in-margins-inside-editable-div.html

editing/selection/click-in-padding-with-multiple-line-boxes.html
editing/selection/click-outside-editable-div.html

editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
rendering/RenderBlock.cpp: (WebCore::positionForPointRespectingEditingBoundaries): (WebCore::positionForPointWithInlineChildren): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::updateFirstLetter):

2:22 PM Changeset in webkit [41190] by weinig@apple.com

13 edits in trunk

WebCore:

2009-02-24 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Related to <rdar://problem/6590295>
Allow disabling javascript: urls.

WebCore.base.exp:
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute):
loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):
page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setJavaScriptURLsAreAllowed): (WebCore::Page::javaScriptURLsAreAllowed):
page/Page.h:

WebKit/mac:

2009-02-24 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Related to <rdar://problem/6590295>
Allow disabling javascript: urls.

WebView/WebView.mm: (-[WebView _setJavaScriptURLsAreAllowed:]):
WebView/WebViewPrivate.h:

WebKit/win:

2009-02-24 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Related to <rdar://problem/6590295>
Allow disabling javascript: urls.

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::setJavaScriptURLsAreAllowed):
WebView.h:

2:19 PM Changeset in webkit [41189] by Simon Fraser

4 edits in trunk

2009-02-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24135

Round the FloatPoint returned by absoluteToLocal(), rather than
truncating it.

dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):

1:34 PM Changeset in webkit [41188] by Beth Dakin

5 edits
4 adds in trunk

WebCore:

2009-02-24 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION:
Ordered list item marker misaligned when line height is not 1.2
-and corresponding <rdar://problem/6602506>

This is a regression from http://trac.webkit.org/changeset/40880
where createInlineBox was taken off of RenderObject and moved to
RenderBox. The problem was that the RenderBox version still needs
to be virtual because there is still an existing implementation in
RenderListMarker.

rendering/RenderBox.h:
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::createInlineBox):
rendering/RenderListMarker.h:

LayoutTests:

2009-02-24 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

Test for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION:
Ordered list item marker misaligned when line height is not 1.2
-and corresponding <rdar://problem/6602506>

fast/lists/list-marker-with-line-height.html: Added.
platform/mac/fast/lists/list-marker-with-line-height-expected.checksum: Added.
platform/mac/fast/lists/list-marker-with-line-height-expected.png: Added.
platform/mac/fast/lists/list-marker-with-line-height-expected.txt: Added.

12:47 PM Changeset in webkit [41187] by Adam Roben

3 edits in trunk/WebKit/win

Windows build fix

WebKit.vcproj/WebKit.def:
WebKit.vcproj/WebKit_debug.def: Export WTF::ThreadCondition::timedWait.

12:23 PM Changeset in webkit [41186] by Dimitri Glazkov

1 edit
6 adds in trunk/WebCore

2009-02-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24128
Upstream more V8 custom bindings: constructors, XSLTProcessor.

bindings/v8/custom/V8DOMParserConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8MessageChannelConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):

11:46 AM Changeset in webkit [41185] by treat@webkit.org

2 edits in trunk/LayoutTests

2009-02-24 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Simon Fraser.

Adding these tests back in and removing from the Skipped list as
these tests are all now passing on my machine as of latest revision.

platform/qt/Skipped:

10:54 AM Changeset in webkit [41184] by levin@chromium.org

6 edits in trunk/WebCore

2009-02-24 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
<https://bugs.webkit.org/show_bug.cgi?id=24090>

No observable change in behavior, so no test.

dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): (WebCore::WorkerMessagingProxy::postTaskToWorkerContext): Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.

(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):

dom/WorkerMessagingProxy.h:
loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::create):
loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck): (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation): Changed these methods to post task using a mode.

loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create):

10:17 AM Changeset in webkit [41183] by treat@webkit.org

2 edits in trunk/WebKitTools

2009-02-24 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Alexey Proskuryakov.

Don't print out that you are generating new results if you are not in fact
generating new results and disable generating new results by default for
the all ports other than the canonical Apple Mac port since this can litter
the source directory with hundreds of new results since other ports
are not as up to date.

Scripts/run-webkit-tests:

8:33 AM Changeset in webkit [41182] by mrowe@apple.com

4 copies
1 add in releases/Apple/Safari 4 Public Beta

Tag the Safari 4 Public Beta release.

This release consists of JavaScriptCore-x528.15, JavaScriptGlue-x528.15, WebCore-x528.16 and WebKit-x528.16.

8:23 AM Changeset in webkit [41181] by treat@webkit.org

2 edits in trunk/WebKitTools

2009-02-24 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Cameron Zwarich.

The Qt port does not support these yet nor does the nm check work with
QMake based build.

Scripts/webkitdirs.pm:

8:12 AM Changeset in webkit [41180] by treat@webkit.org

2 edits in trunk/LayoutTests

2009-02-24 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Cameron Zwarich.

Remove tests from the Qt Skipped list that no longer even exist.

platform/qt/Skipped:

7:23 AM Changeset in webkit [41179] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2009-02-24 Geoffrey Garen <ggaren@apple.com>

Build fix?

GNUmakefile.am:

5:42 AM Changeset in webkit [41178] by ap@webkit.org

3 edits
4 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24091
<rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache

Test: http/tests/appcache/access-via-redirect.php

loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with, not the original one.

5:26 AM Changeset in webkit [41177] by mrowe@apple.com

2 edits in trunk/JavaScriptGlue

<rdar://problem/6407844> JavaScriptGlue should use -Os rather than -O2

Rubber-stamped by Dan Bernstein.

Configurations/Base.xcconfig:

4:35 AM Changeset in webkit [41176] by mrowe@apple.com

11 edits in trunk

<rdar://problem/6259220> Rename AVAILABLE_AFTER_WEBKIT_VERSION_3_1 (etc.) to match the other macros

Reviewed by Oliver Hunt.

API/JSBasePrivate.h:
API/JSContextRef.h:
API/JSObjectRef.h:
API/WebKitAvailability.h:

Carbon/CarbonUtils.h:
Carbon/HIWebView.h:
Plugins/WebPlugin.h:
Plugins/WebPluginViewFactory.h:
WebView/WebUIDelegate.h:

2:21 AM Changeset in webkit [41175] by ap@webkit.org

2 edits in trunk/LayoutTests

Reviewed by Mark Rowe ("awesome!").

Make test for <https://bugs.webkit.org/show_bug.cgi?id=15707> more reliable.

fast/dom/onload-open.html: Added waitUntilDone().

1:44 AM Changeset in webkit [41174] by levin@chromium.org

3 edits in trunk/WebCore

2009-02-24 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
https://bugs.webkit.org/show_bug.cgi?id=24112

bindings/js/WorkerScriptController.cpp:
dom/WorkerContext.cpp:

1:39 AM Changeset in webkit [41173] by mrowe@apple.com

2 edits in trunk/WebKit/mac

2009-02-24 Peter Ammon <pammon@apple.com>

Reviewed by Mark Rowe.

Fix <rdar://problem/6251410> Services can modify non-editable content in Safari

WebView/WebHTMLView.mm: (-[WebHTMLView validRequestorForSendType:returnType:]): Return self only if we can handle both the send and return type. We should also handle a nil send or return type by ignoring the argument and returning whether we can handle the other type passed in.

1:22 AM Changeset in webkit [41172] by jmalonzo@webkit.org

4 edits in trunk

[Gtk] add options for 3D transforms and HTML5 channel messaging to the build
https://bugs.webkit.org/show_bug.cgi?id=24072

Reviewed by Alexey Proskuryakov.

Add options for toggling 3D transforms and HTML5 channel messaging
support on or off.

Also fix the web-workers option. It should be web-workers and not workers.

configure.ac:

Allow toggling of 3D transforms and HTML5 channel messaging
support for the Autotools (Gtk) build.

Also add '--gtk' in the build-webkit help doc and fix autotools
option for web-workers support.

Scripts/build-webkit:

12:57 AM Changeset in webkit [41171] by levin@chromium.org

2 edits in trunk/LayoutTests

2009-02-24 David Levin <levin@chromium.org>

Reviewed by Dave Hyatt.

Update expected results due to better results introduced by r41090.

platform/mac/media/video-layer-crash-expected.txt:

Feb 23, 2009:

11:47 PM Changeset in webkit [41170] by Antti Koivisto

2 edits in trunk/WebCore

2009-02-23 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver Hunt.

<rdar://problem/6613796> Extended text codecs registered on webview creation

Comparing a text encoding with string "GBK" ended up constructing
TextEncoding("GBK") which in turn initialized all extended
text codecs.

platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decode):

8:29 PM Changeset in webkit [41169] by weinig@apple.com

2 edits in trunk/WebCore

2009-02-23 Sam Weinig <sam@webkit.org>

Fix Qt build.

bridge/qt/qt_runtime.cpp: (JSC::Bindings::valueRealType):

7:58 PM Changeset in webkit [41168] by ggaren@apple.com

22 edits in trunk/JavaScriptCore

2009-02-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Next step in splitting JIT functionality out of the Interpreter class:
Moved vptr storage from Interpreter to JSGlobalData, so it could be shared
between Interpreter and JITStubs, and moved the *Trampoline JIT stubs
into the JITStubs class. Also added a VPtrSet class to encapsulate vptr
hacks during JSGlobalData initialization.

SunSpider says 0.4% faster. Meh.

JavaScriptCore.exp:
JavaScriptCore.xcodeproj/project.pbxproj:
interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
interpreter/Interpreter.h:
jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
jit/JIT.h: (JSC::JIT::compileCTIMachineTrampolines):
jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePatchGetArrayLength):
jit/JITStubs.cpp: (JSC::JITStubs::JITStubs): (JSC::JITStubs::tryCacheGetByID): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_is_string):
jit/JITStubs.h: (JSC::JITStubs::ctiArrayLengthTrampoline): (JSC::JITStubs::ctiStringLengthTrampoline): (JSC::JITStubs::ctiVirtualCallPreLink): (JSC::JITStubs::ctiVirtualCallLink): (JSC::JITStubs::ctiVirtualCall):
runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush):
runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncApply):
runtime/JSArray.h: (JSC::isJSArray):
runtime/JSByteArray.h: (JSC::asByteArray): (JSC::isJSByteArray):
runtime/JSCell.h:
runtime/JSFunction.h:
runtime/JSGlobalData.cpp: (JSC::VPtrSet::VPtrSet): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::create): (JSC::JSGlobalData::sharedInstance):
runtime/JSGlobalData.h:
runtime/JSString.h: (JSC::isJSString):
runtime/Operations.h: (JSC::jsLess): (JSC::jsLessEq):
wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp):

6:57 PM Changeset in webkit [41167] by mrowe@apple.com

1 edit in tags/Safari-6530.1/WebCore/page/AccessibilityTable.cpp

Work around <rdar://problem/6610801>.

5:47 PM Changeset in webkit [41166] by mrowe@apple.com

5 edits
1 add in tags/Safari-6530.1/WebKit/mac

Merge r41148.

5:46 PM Changeset in webkit [41165] by mrowe@apple.com

1 add in tags/Safari-6530.1/WebKit/mac/Plugins/Hosted/WebTextInputWindowController.m

Merge r41124.

5:46 PM Changeset in webkit [41164] by mrowe@apple.com

1 edit in tags/Safari-6530.1/WebKit/mac/ChangeLog

Merge r41124.

5:45 PM Changeset in webkit [41163] by mrowe@apple.com

3 edits in tags/Safari-6530.1/WebKit

Merge r41123.

5:21 PM Changeset in webkit [41162] by jchaffraix@webkit.org

5 edits
2 adds in trunk

WebCore:

2009-02-23 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)

The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
element created with createElement could have a wrong nodeName (createElement sets the string as the
localName without checking for a prefix).

The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
and will always succeed.
Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
to ensure that).

Test: fast/dom/cloneNode.html

dom/Element.cpp: (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will always return an element.

html/HTMLElement.cpp:
html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.

LayoutTests:

2009-02-23 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Test for bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)

fast/dom/cloneNode-expected.txt: Added.
fast/dom/cloneNode.html: Added.

4:53 PM Changeset in webkit [41161] by mrowe@apple.com

1 copy in tags/Safari-6530.1

New tag.

4:29 PM Changeset in webkit [41160] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Bug 23787: Allow JIT to generate SSE2 code if using GCC
<https://bugs.webkit.org/show_bug.cgi?id=23787>

Reviewed by Oliver Hunt
Contributed by Csaba Osztrogonac

GCC version of the cpuid check.

4:04 PM Changeset in webkit [41159] by Dimitri Glazkov

1 edit
12 adds in trunk/WebCore

2009-02-23 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24109
Upstream V8 Script abstractions, all except ScriptController.

bindings/v8/ScriptCachedFrameData.h: Added. (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore): (WebCore::ScriptCachedFrameData::clear): (WebCore::ScriptCachedFrameData::domWindow):
bindings/v8/ScriptCallFrame.cpp: Added. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::argumentAt):
bindings/v8/ScriptCallFrame.h: Added. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber): (WebCore::ScriptCallFrame::argumentCount):
bindings/v8/ScriptCallStack.cpp: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at):
bindings/v8/ScriptCallStack.h: Added. (WebCore::ScriptCallStack::size):
bindings/v8/ScriptInstance.cpp: Added. (WebCore::V8ScriptInstance::V8ScriptInstance): (WebCore::V8ScriptInstance::~V8ScriptInstance): (WebCore::V8ScriptInstance::instance): (WebCore::V8ScriptInstance::clear): (WebCore::V8ScriptInstance::set):
bindings/v8/ScriptInstance.h: Added. (WebCore::V8ScriptInstance::create):
bindings/v8/ScriptSourceCode.h: Added. (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::isEmpty): (WebCore::ScriptSourceCode::source): (WebCore::ScriptSourceCode::url): (WebCore::ScriptSourceCode::startLine):
bindings/v8/ScriptState.h: Added. (WebCore::ScriptState::hadException): (WebCore::ScriptState::setException): (WebCore::ScriptState::exception):
bindings/v8/ScriptString.h: Added. (WebCore::ScriptString::ScriptString): (WebCore::ScriptString::operator String): (WebCore::ScriptString::isNull): (WebCore::ScriptString::size): (WebCore::ScriptString::operator=): (WebCore::ScriptString::operator+=):
bindings/v8/ScriptValue.cpp: Added. (WebCore::ScriptValue::getString):
bindings/v8/ScriptValue.h: Added. (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::operator=): (WebCore::ScriptValue::operator==): (WebCore::ScriptValue::operator!=): (WebCore::ScriptValue::isNull): (WebCore::ScriptValue::isUndefined): (WebCore::ScriptValue::clear): (WebCore::ScriptValue::~ScriptValue): (WebCore::ScriptValue::v8Value):

3:20 PM Changeset in webkit [41158] by treat@webkit.org

2 edits in trunk/WebCore

2009-02-23 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24106
The Qt port is crashing on exit because the tear down procedure involves
the WebCore::InspectorController trying to access the JS execution context
for a page that is being deleted. This patch amends the inspector so
that it does not try and access the execution context of the WebCore::Page
in the midst of deletion.

inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::stopUserInitiatedProfiling):

2:37 PM Changeset in webkit [41157] by levin@chromium.org

8 edits in trunk/WebCore

2009-02-23 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
<https://bugs.webkit.org/show_bug.cgi?id=24088>

No observable change in behavior, so no test.

loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create):
loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidFailRedirectCheck): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
loader/WorkerThreadableLoader.h:
xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
xml/XMLHttpRequest.h:

2:37 PM Changeset in webkit [41156] by levin@chromium.org

7 edits in trunk

JavaScriptCore:

2009-02-23 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
<https://bugs.webkit.org/show_bug.cgi?id=24047>

wtf/MessageQueue.h: (WTF::MessageQueue::infiniteTime): Allows for one to call waitForMessageFilteredWithTimeout and wait forever.

(WTF::MessageQueue::alwaysTruePredicate):
(WTF::MessageQueue::waitForMessage):
Made waitForMessage call waitForMessageFilteredWithTimeout, so that there is less
duplicate code.

(WTF::MessageQueue::waitForMessageFilteredWithTimeout):

wtf/ThreadingQt.cpp: (WTF::ThreadCondition::timedWait):
wtf/ThreadingWin.cpp: (WTF::ThreadCondition::timedWait): Made these two implementations consistent with the pthread and gtk implementations. Currently, the time calculations would overflow when passed large values.

WebCore:

2009-02-23 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
<https://bugs.webkit.org/show_bug.cgi?id=24047>

Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
using only MessageQueue::waitForMessageFilteredWithTimeout instead
of three different MessageQueue methods.

No observable change in behavior, so no test.

dom/WorkerRunLoop.cpp: (WebCore::ModePredicate::operator()): Minor clean-up to able to pass a const ref point for ModePredicate into runInMode. (WebCore::WorkerRunLoop::runInMode):
dom/WorkerRunLoop.h:

2:08 PM Changeset in webkit [41155] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-02-23 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen and Darin Adler.

WebKit side of <rdar://problem/6613151>.

Make sure to vm_deallocate all memory we get from MIG callbacks.

Plugins/Hosted/NetscapePluginHostProxy.mm: (DataDeallocator::DataDeallocator): (DataDeallocator::~DataDeallocator): Add a simple deallocator class.

(WKPCStatusText):
(WKPCLoadURL):
(WKPCBooleanAndDataReply):
(WKPCEvaluate):
(WKPCGetStringIdentifier):
(WKPCInvoke):
(WKPCInvokeDefault):
(WKPCConstruct):
(WKPCSetProperty):
Use the new deallocator class.

12:40 PM Changeset in webkit [41154] by hyatt@apple.com

4 edits in trunk/WebCore

2009-02-23 David Hyatt <hyatt@apple.com>

In preparation for making layers for multicol objects (so that they can properly split child layers
into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
of RenderLayer to use the term "normal flow" instead.

Reviewed by Cameron Zwarich

rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::enclosingCompositingLayer): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::dirtyNormalFlowList): (WebCore::RenderLayer::updateNormalFlowList): (WebCore::RenderLayer::collectLayers): (WebCore::RenderLayer::updateLayerListsIfNeeded): (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::styleChanged):
rendering/RenderLayer.h: (WebCore::RenderLayer::isNormalFlowOnly): (WebCore::RenderLayer::normalFlowList):
rendering/RenderTreeAsText.cpp: (WebCore::writeLayers):

12:16 PM Changeset in webkit [41153] by hyatt@apple.com

4 edits
4 adds in trunk

WebCore:

2009-02-23 David Hyatt <hyatt@apple.com>

Fix the stacking order for column rules in multi-column layout. Column rules should paint as part of the background of an element, just
after all other components of the background have been painted. This allows negative z-index children to still paint on top of the
column rules (rather than ending up above the background of the box but behind the column rules).

Reviewed by Eric Seidel

Added fast/multicol/column-rules-stacking.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnRules): (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintObject):
rendering/RenderBlock.h:

LayoutTests:

2009-02-23 David Hyatt <hyatt@apple.com>

Fix the stacking order for column rules in multi-column layout. Column rules should paint as part of the background of an element, just
after all other components of the background have been painted. This allows negative z-index children to still paint on top of the
column rules (rather than ending up above the background of the box but behind the column rules).

Reviewed by Eric Seidel

fast/multicol/column-rules-stacking.html: Added.
platform/mac/fast/multicol/column-rules-stacking-expected.checksum: Added.
platform/mac/fast/multicol/column-rules-stacking-expected.png: Added.
platform/mac/fast/multicol/column-rules-stacking-expected.txt: Added.

12:11 PM Changeset in webkit [41152] by treat@webkit.org

3 edits in trunk/WebCore

2009-02-23 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Hyatt.

No testcases have been added or modified since this patch should not result in
a behavior change for ports that have layout tests enabled.

Currently, the implementation of GraphicsContext::drawLineForText amongst
the various ports differ in that some of them are honoring the context's
strokeStyle when drawing a text-decoration and some of them are not.
For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
but the Cairo implementation does and has an explicit workaround that
sets the strokeStyle() temporarily.

This patch fixes so that all ports are consistent by explicitly making sure
to set the GraphicsContext strokeStyle to SolidStroke whenever
painting the text-decoration of an InlineFlowBox or InlineTextBox as these
should always use a solid stroke.

This patch addresses these bugs:
https://bugs.webkit.org/show_bug.cgi?id=19364
https://bugs.webkit.org/show_bug.cgi?id=15659

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration):

11:52 AM Changeset in webkit [41151] by treat@webkit.org

4 edits in trunk/WebKit/qt

2009-02-23 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24094
Make sure to empty the cache on exit to get rid of superfluous leak messages
for CachedResource's in order to keep the leak messages accurate. This
is analagous to what the Mac port is doing on application exit when all
WebView's have been closed.

Api/qwebpage.cpp: (QWebPagePrivate::_q_cleanupLeakMessages): (QWebPage::QWebPage):
Api/qwebpage.h:
Api/qwebpage_p.h:

11:35 AM Changeset in webkit [41150] by Dimitri Glazkov

3 edits
3 adds in trunk/WebCore

2009-02-23 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24098
Bugs in ClipboardChromium

Fixes the following bugs in ClipboardChromium:

It's possible for the extension to be empty, resulting in a bad file name, for example, 'foo.' or just '.'.
We weren't restricting the size of the file to MAX_PATH.
We weren't removing characters that are invalid for file system names.

platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
platform/chromium/ClipboardChromium.h:
platform/chromium/ClipboardChromiumLinux.cpp: Added. (WebCore::ClipboardChromium::validateFileName):
platform/chromium/ClipboardChromiumMac.cpp: Added. (WebCore::ClipboardChromium::validateFileName):
platform/chromium/ClipboardChromiumWin.cpp: Added. (WebCore::isInvalidFileCharacter): (WebCore::ClipboardChromium::validateFileName):

9:48 AM Changeset in webkit [41149] by Dimitri Glazkov

2 edits in trunk/JavaScriptCore

2009-02-23 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=24096
PLATFORM(MAC)->PLATFORM(CF) since we want to use the CF functions in Chrome on OS X.

wtf/CurrentTime.cpp:

9:20 AM Changeset in webkit [41148] by andersca@apple.com

5 edits in trunk/WebKit/mac

2009-02-23 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6450656>.

Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::insertText): Add insert text which just calls the new WKPH function.

Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView inputContext]): Get the input context from the shared input panel.

(-[WebHostedNetscapePluginView keyDown:]):
Let the shared input panel have a go at the event first.

Plugins/Hosted/WebKitPluginHost.defs: Add new InsertText function.

8:19 AM Changeset in webkit [41147] by Simon Hausmann

4 edits in trunk

2009-02-23 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Simon Hausmann.

Fix the Copyright notices in a few files

7:08 AM Changeset in webkit [41146] by kov@webkit.org

2 edits
3 adds in trunk

2009-02-23 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24011
KURL's setPort doesn't unset port if 0 is given

Adding regression tests for change done on KURL's setPort in
r41076. It is worth noting that Firefox doesn't render this test
correctly since it raises an exception when javascript tries to
change the iframe's contentWindow.location.port, though other
properties are modifiable.

fast/loader/location-port-expected.txt: Added.
fast/loader/location-port.html: Added.
fast/loader/resources/location-port-iframe.html: Added.

Also added bug URL to the WebCore entry for the r41076 change.

6:46 AM Changeset in webkit [41145] by ap@webkit.org

708 edits in trunk/LayoutTests/dom/xhtml/level3/core

Rubber-stamped by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

(Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

Committing dom/xhtml/level3.

6:23 AM Changeset in webkit [41144] by ap@webkit.org

723 edits in trunk/LayoutTests/dom/xhtml/level2

Rubber-stamped by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

(Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

Committing dom/xhtml/level2.

6:03 AM Changeset in webkit [41143] by ap@webkit.org

238 edits in trunk/LayoutTests/dom/xhtml/level1/core

Rubber-stamped by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

(Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

Committing dom/xhtml/level1.

5:56 AM Changeset in webkit [41142] by ap@webkit.org

721 edits in trunk/LayoutTests/dom/html/level2

Rubber-stamped by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

(Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

Committing dom/html/level2.

5:34 AM Changeset in webkit [41141] by ap@webkit.org

238 edits in trunk/LayoutTests/dom/html/level1/core

Rubber-stamped by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

(Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

Committing dom/html/level1.

5:27 AM Changeset in webkit [41140] by ap@webkit.org

66 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

(Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

First part: dom/svg.

3:24 AM Changeset in webkit [41139] by christian@webkit.org

8 edits in trunk

Allow retrieving the Soup session and modify the code to take
into account users changing features on it.

https://bugs.webkit.org/show_bug.cgi?id=22624
[SOUP][GTK] Need API to get SoupSession from WebKit.

3:15 AM Changeset in webkit [41138] by christian@webkit.org

9 edits in trunk

Remove CURL support in the Gtk port, the HTTP backend is SOUP now.

https://bugs.webkit.org/show_bug.cgi?id=22624
[SOUP][GTK] Need API to get SoupSession from WebKit.

2:00 AM Changeset in webkit [41137] by jmalonzo@webkit.org

3 edits in trunk/WebKit/gtk

2009-02-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Mark Rowe.

[GTK] Back / Forward history menus are flipped
https://bugs.webkit.org/show_bug.cgi?id=22694

Don't call g_list_reverse when returning the back or forward list.

tests/main.c: (test_webkit_web_back_forward_list_order): (main):
webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):

1:44 AM Changeset in webkit [41136] by ap@webkit.org

6 edits
2 adds in trunk

Reviewed by Mark Rowe.

Test: fast/dom/empty-hash-and-search.html

https://bugs.webkit.org/show_bug.cgi?id=21147
hash property returns incorrect value for links w/o hash

Make hash() and search() behavior for empty and missing parts match IE and Firefox.

platform/KURL.cpp: (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref(). (WebCore::KURL::prettyURL): Append the query with the question mark.

page/Location.cpp: (WebCore::Location::search): Return an empty string if query is empty or missing. (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.

dom/WorkerLocation.cpp: (WebCore::WorkerLocation::search): (WebCore::WorkerLocation::hash): Match document.location fixes above.

html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::hash): (WebCore::HTMLAnchorElement::search): Return an empty string for empty and missing parts.

1:21 AM Changeset in webkit [41135] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20184
SELECT with no name generates invalid query string

Test: fast/forms/select-no-name.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.

1:10 AM Changeset in webkit [41134] by ap@webkit.org

2 edits in trunk/WebCore

Apply review comments for the previous check-in (forgot to save the file, oops).

dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):

1:03 AM Changeset in webkit [41133] by ap@webkit.org

3 edits
3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=15707
Crash when manipulating document from within an iframe onload function

Test: fast/dom/onload-open.html

dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and the current node, because anything can happen when dispatching events.

12:58 AM Changeset in webkit [41132] by mrowe@apple.com

2 edits in trunk/WebKit/mac

Fix the build after r41126.

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):

12:52 AM Changeset in webkit [41131] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=18970
Numerically named input fields cause document.forms loop problems

Test: fast/forms/numeric-input-name.html

bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the latter overrides properties.

12:44 AM Changeset in webkit [41130] by ap@webkit.org

11 edits in trunk/WebCore

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24059
Tokenizer::write() return value is never used

dom/Tokenizer.h:
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
dom/XMLTokenizer.h:
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
html/HTMLTokenizer.h:
loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::write):
loader/ImageDocument.cpp: (WebCore::ImageTokenizer::write):
loader/MediaDocument.cpp: (WebCore::MediaTokenizer::write):
loader/PluginDocument.cpp: (WebCore::PluginTokenizer::write):
loader/TextDocument.cpp: (WebCore::TextTokenizer::write): Made write() return void, not bool.

Feb 22, 2009:

10:22 PM Changeset in webkit [41129] by mitz@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

fix <rdar://problem/5966123> REGRESSION (r30741): Generic Sun Applet loading logo appears half off screen

WebCoreSupport/WebFrameLoaderClient.mm: Correct a copy & paste error in r30741, and assign the height value, rather than the width, to the "height" parameter.

4:53 PM Changeset in webkit [41128] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2009-02-22 Geoffrey Garen <ggaren@apple.com>

Build fix?

GNUmakefile.am:

4:34 PM Changeset in webkit [41127] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2009-02-22 Geoffrey Garen <ggaren@apple.com>

Build fix.

GNUmakefile.am:

3:26 PM Changeset in webkit [41126] by ggaren@apple.com

40 edits
2 copies in trunk

JavaScriptCore:

2009-02-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Next step in splitting JIT functionality out of the Interpreter class:
Created a JITStubs class and renamed Interpreter::cti_* to JITStubs::cti_*.

Also, moved timeout checking into its own class, located in JSGlobalData,
so both the Interpreter and the JIT could have access to it.

JavaScriptCore.exp:
JavaScriptCore.pri:
JavaScriptCore.scons:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptCoreSources.bkl:
interpreter/CallFrame.h:
interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter): (JSC::Interpreter::privateExecute):
interpreter/Interpreter.h:
interpreter/Register.h:
jit/JIT.cpp: (JSC::): (JSC::JIT::emitTimeoutCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
jit/JIT.h:
jit/JITArithmetic.cpp: (JSC::JIT::compileFastArithSlow_op_lshift): (JSC::JIT::compileFastArithSlow_op_rshift): (JSC::JIT::compileFastArithSlow_op_bitand): (JSC::JIT::compileFastArithSlow_op_mod): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArithSlow_op_post_inc): (JSC::JIT::compileFastArithSlow_op_post_dec): (JSC::JIT::compileFastArithSlow_op_pre_inc): (JSC::JIT::compileFastArithSlow_op_pre_dec): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArith_op_sub): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::compileFastArithSlow_op_add): (JSC::JIT::compileFastArithSlow_op_mul):
jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
jit/JITStubs.cpp: (JSC::JITStubs::tryCachePutByID): (JSC::JITStubs::tryCacheGetByID): (JSC::JITStubs::cti_op_convert_this): (JSC::JITStubs::cti_op_end): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_timeout_check): (JSC::JITStubs::cti_register_file_check): (JSC::JITStubs::cti_op_loop_if_less): (JSC::JITStubs::cti_op_loop_if_lesseq): (JSC::JITStubs::cti_op_new_object): (JSC::JITStubs::cti_op_put_by_id_generic): (JSC::JITStubs::cti_op_get_by_id_generic): (JSC::JITStubs::cti_op_put_by_id): (JSC::JITStubs::cti_op_put_by_id_second): (JSC::JITStubs::cti_op_put_by_id_fail): (JSC::JITStubs::cti_op_get_by_id): (JSC::JITStubs::cti_op_get_by_id_second): (JSC::JITStubs::cti_op_get_by_id_self_fail): (JSC::JITStubs::cti_op_get_by_id_proto_list): (JSC::JITStubs::cti_op_get_by_id_proto_list_full): (JSC::JITStubs::cti_op_get_by_id_proto_fail): (JSC::JITStubs::cti_op_get_by_id_array_fail): (JSC::JITStubs::cti_op_get_by_id_string_fail): (JSC::JITStubs::cti_op_instanceof): (JSC::JITStubs::cti_op_del_by_id): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_new_func): (JSC::JITStubs::cti_op_call_JSFunction): (JSC::JITStubs::cti_op_call_arityCheck): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall): (JSC::JITStubs::cti_op_push_activation): (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_create_arguments): (JSC::JITStubs::cti_op_create_arguments_no_params): (JSC::JITStubs::cti_op_tear_off_activation): (JSC::JITStubs::cti_op_tear_off_arguments): (JSC::JITStubs::cti_op_profile_will_call): (JSC::JITStubs::cti_op_profile_did_call): (JSC::JITStubs::cti_op_ret_scopeChain): (JSC::JITStubs::cti_op_new_array): (JSC::JITStubs::cti_op_resolve): (JSC::JITStubs::cti_op_construct_JSConstruct): (JSC::JITStubs::cti_op_construct_NotJSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_resolve_func): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_lesseq): (JSC::JITStubs::cti_op_loop_if_true): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_resolve_base): (JSC::JITStubs::cti_op_resolve_skip): (JSC::JITStubs::cti_op_resolve_global): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_jless): (JSC::JITStubs::cti_op_not): (JSC::JITStubs::cti_op_jtrue): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_resolve_with_base): (JSC::JITStubs::cti_op_new_func_exp): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_less): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_new_regexp): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_op_throw): (JSC::JITStubs::cti_op_get_pnames): (JSC::JITStubs::cti_op_next_pname): (JSC::JITStubs::cti_op_push_scope): (JSC::JITStubs::cti_op_pop_scope): (JSC::JITStubs::cti_op_typeof): (JSC::JITStubs::cti_op_is_undefined): (JSC::JITStubs::cti_op_is_boolean): (JSC::JITStubs::cti_op_is_number): (JSC::JITStubs::cti_op_is_string): (JSC::JITStubs::cti_op_is_object): (JSC::JITStubs::cti_op_is_function): (JSC::JITStubs::cti_op_stricteq): (JSC::JITStubs::cti_op_nstricteq): (JSC::JITStubs::cti_op_to_jsnumber): (JSC::JITStubs::cti_op_in): (JSC::JITStubs::cti_op_push_new_scope): (JSC::JITStubs::cti_op_jmp_scopes): (JSC::JITStubs::cti_op_put_by_index): (JSC::JITStubs::cti_op_switch_imm): (JSC::JITStubs::cti_op_switch_char): (JSC::JITStubs::cti_op_switch_string): (JSC::JITStubs::cti_op_del_by_val): (JSC::JITStubs::cti_op_put_getter): (JSC::JITStubs::cti_op_put_setter): (JSC::JITStubs::cti_op_new_error): (JSC::JITStubs::cti_op_debug): (JSC::JITStubs::cti_vm_throw):
jit/JITStubs.h: (JSC::):
runtime/JSFunction.h:
runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
runtime/JSGlobalData.h:
runtime/JSGlobalObject.cpp:
runtime/JSGlobalObject.h:
runtime/TimeoutChecker.cpp: Copied from interpreter/Interpreter.cpp. (JSC::TimeoutChecker::TimeoutChecker): (JSC::TimeoutChecker::reset): (JSC::TimeoutChecker::didTimeOut):
runtime/TimeoutChecker.h: Copied from interpreter/Interpreter.h. (JSC::TimeoutChecker::setTimeoutInterval): (JSC::TimeoutChecker::ticksUntilNextCheck): (JSC::TimeoutChecker::start): (JSC::TimeoutChecker::stop):

WebCore:

2009-02-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore changes to timeout checking.

bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): (WebCore::JSDOMWindowBase::commonJSGlobalData):
bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent):
bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext):
bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::forbidExecution):
bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_Construct):
bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval):

2:37 AM Changeset in webkit [41125] by mrowe@apple.com

2 edits in trunk/WebKitTools

Fix assertion failures in editing/pasteboard/paste-RTFD.html and editing/pasteboard/paste-TIFF.html in 64-bit.

Reviewed by Oliver Hunt.

DumpRenderTree/mac/DumpRenderTree.mm:

(swizzleAllMethods): When adding a new method to a class, use the implementation and type of the new method rather
than of an arbitrary existing method on the class.

Feb 21, 2009:

11:32 AM Changeset in webkit [41124] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-02-21 Anders Carlsson <andersca@apple.com>

Fix build.

Plugins/Hosted/WebTextInputWindowController.m:

11:20 AM Changeset in webkit [41123] by andersca@apple.com

3 edits
2 adds in trunk/WebKit

..:

2009-02-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add new files.

WebKit.xcodeproj/project.pbxproj:

../mac:

2009-02-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add a shared floating text input window implementation, to be used by the hosted plug-in view.

Plugins/Hosted/WebTextInputWindowController.h: Added.
Plugins/Hosted/WebTextInputWindowController.m: Added.

1:25 AM Changeset in webkit [41122] by dimich@chromium.org

3 edits
12 adds in trunk

WebCore:
2009-02-21 Hironori Bono <hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23786
[Chromium] line-break characters in a complex text are treated as zero-width spaces

This change prevents the UniscribeHelper class from treating the line-break characters
as whitespaces.

platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::adjustSpaceAdvances): Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces, so does when Chromium renders a simple text.

LayoutTests:
2009-02-21 Hironori Bono <hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23786
[Chromium] line-break characters in a complex text are treated as zero-width spaces

Added tests which verifies line-break characters in a complex text are treated as defined in CSS 2.1.

fast/text/international/bidi-linebreak-001.html: Added.
fast/text/international/bidi-linebreak-002.html: Added.
fast/text/international/bidi-linebreak-003.html: Added.
platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum: Added.
platform/mac/fast/text/international/bidi-linebreak-001-expected.png: Added.
platform/mac/fast/text/international/bidi-linebreak-001-expected.txt: Added.
platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum: Added.
platform/mac/fast/text/international/bidi-linebreak-002-expected.png: Added.
platform/mac/fast/text/international/bidi-linebreak-002-expected.txt: Added.
platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum: Added.
platform/mac/fast/text/international/bidi-linebreak-003-expected.png: Added.
platform/mac/fast/text/international/bidi-linebreak-003-expected.txt: Added.

Feb 20, 2009:

6:05 PM Changeset in webkit [41121] by kdecker@apple.com

2 edits in trunk/WebKit/mac

Reviewed by andersca.

<rdar://problem/6496140> Safari sometimes hangs in WKSetMetadataURL for several seconds after downloading a file

Spawn a background thread for WKSetMetadataURL because this function will not return until mds has journaled the data
we are trying to set. Depending on what other I/O is going on, it can take some time.

Misc/WebNSFileManagerExtras.m: Import pthread.h and FoundationExtras.h (setMetaData): Added. Calls WKSetMetadataURL(). (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Call setMetaData on a background thread

4:15 PM Changeset in webkit [41120] by jchaffraix@webkit.org

15 edits in trunk/WebCore

2009-02-20 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Alexey Proskuryakov.

Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore

Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
unneeded.

It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
enables us to use some generated QualifiedName.

bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
dom/Document.cpp: (WebCore::Document::setTitle):
dom/XMLTokenizer.cpp: (WebCore::createXHTMLParserErrorHeader): (WebCore::XMLTokenizer::insertErrorMessageBlock):
editing/CompositeEditCommand.cpp: (WebCore::createBlockPlaceholderElement):
editing/htmlediting.cpp: (WebCore::createTabSpanElement):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setLength):
loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::appendEntry): (WebCore::FTPDirectoryTokenizer::createTDForFilename): (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): (WebCore::FTPDirectoryTokenizer::createBasicDocument):
loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure):
loader/MediaDocument.cpp: (WebCore::MediaTokenizer::createDocumentStructure):
loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
page/Frame.cpp: (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::styleForSelectionStart): Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.

xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
page/DragController.cpp: (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.

1:19 PM Changeset in webkit [41119] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24060
Fix up to accommodate for CanvasPixelArray return.

platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::getImageData): Added an extra data() to call. (WebCore::ImageBuffer::putImageData): Ditto.

1:12 PM Changeset in webkit [41118] by eric.carlson@apple.com

3 edits in trunk/WebCore

2009-02-19 Eric Carlson <eric.carlson@apple.com>

Simon Fraser

https://bugs.webkit.org/show_bug.cgi?id=24042
Bug 24042: MediaPlayer should cache plug-in proxy

The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
MediaPlayer will always have created the private media player object before
the plug-in is instantiated and calls back with the proxy object. This is not
true on all platforms because of threading latency, so MediaPlayer should
cache the plug-in proxy so it can pass it to the media engine at a later time.

platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods. (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto. (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto. (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy. (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine. (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
platform/graphics/MediaPlayer.h: Declare m_playerProxy.

1:10 PM Changeset in webkit [41117] by eric.carlson@apple.com

3 edits in trunk/WebCore

2009-02-20 Eric Carlson <eric.carlson@apple.com>

Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24063
Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Rename m_loadRestrictions to m_Restrictions. Initialize m_internalCall. (WebCore::HTMLMediaElement::loadTimerFired): Increment m_internalCall around call to load(). (WebCore::HTMLMediaElement::load): Call loadInternal if restrictions check out. (WebCore::HTMLMediaElement::loadInternal): New, guts of old load() (WebCore::HTMLMediaElement::setNetworkState): Fix bug introduced in r40943 (WebCore::HTMLMediaElement::play): Call playInternal if restrictions check out. (WebCore::HTMLMediaElement::playInternal): New, guts of old play() (WebCore::HTMLMediaElement::pause): Call pauseInternal if restrictions check out. (WebCore::HTMLMediaElement::pauseInternal): New, guts of old pause() (WebCore::HTMLMediaElement::togglePlayState): Call playInternal/pauseInternal (WebCore::HTMLMediaElement::deliverNotification): Remove unnecessary white space.
html/HTMLMediaElement.h: Rename m_loadRestrictions to m_Restrictions, add m_internalCall, add RequireUserGestureRateChangeRestriction.

1:08 PM Changeset in webkit [41116] by darin@chromium.org

2 edits in trunk/WebCore

2009-02-20 Darin Fisher <darin@chromium.org>

Fix build bustage in FileSystemWin.cpp.

Need to return CString() instead of 0 since there are now two CString
constructors that take a pointer type.

platform/win/FileSystemWin.cpp: (WebCore::openTemporaryFile):

12:55 PM Changeset in webkit [41115] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-02-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23999
Change license headers to accurately reflect code history.

platform/ContentType.cpp:
platform/ContentType.h:

12:52 PM Changeset in webkit [41114] by weinig@apple.com

2 edits in trunk/LayoutTests

2009-02-20 Sam Weinig <sam@webkit.org>

fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: Update results.

12:36 PM Changeset in webkit [41113] by Dimitri Glazkov

13 edits
2 adds in trunk/WebCore

2009-02-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=23999
Split off MIME type parsing into its own class.

GNUmakefile.am: Added ContentType sources.
WebCore.pro: Ditto.
WebCore.scons: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
WebCoreSources.bkl: Ditto.
html/HTMLMediaElement.cpp: Changed to use ContentType. (WebCore::HTMLMediaElement::selectMediaURL):
platform/ContentType.cpp: Added. (WebCore::ContentType::ContentType): (WebCore::ContentType::parameter): (WebCore::ContentType::type):
platform/ContentType.h: Added. (WebCore::ContentType::raw):
platform/MIMETypeRegistry.cpp:
platform/MIMETypeRegistry.h:
platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load):
rendering/style/ContentData.h: Renamed ContentType to StyleContentType.
rendering/style/RenderStyleConstants.h: Ditto. (WebCore::):

12:32 PM Changeset in webkit [41112] by zecke@webkit.org

3 edits in trunk/WebCore

2009-02-20 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed build fix.

Use CString() instead of 0.

platform/gtk/FileSystemGtk.cpp: (WebCore::openTemporaryFile):
platform/qt/FileSystemQt.cpp: (WebCore::openTemporaryFile):

12:10 PM Changeset in webkit [41111] by kov@webkit.org

2 edits in trunk/WebCore

2009-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

When dealing with local files, use a path instead of an URI. GFile
has problems decoding URIs with percent signs on them.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):

11:41 AM Changeset in webkit [41110] by kov@webkit.org

2 edits in trunk/WebCore

2009-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Protect the ResourceHandle instance from being destroyed by
didReceiveData inside the GIO readCallback call, so that
cancelling caused by scripts is handled correctly.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::readCallback):

11:27 AM Changeset in webkit [41109] by ddkilzer@apple.com

2 edits in trunk/WebCore

Make IconDatabaseNone.cpp compile with -Wunused and pass check-for-exit-time-destructors

Reviewed by Sam Weinig.

loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Use DEFINE_STATIC_LOCAL(). (WebCore::IconDatabase::open): Commented out unused parameter. (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto. (WebCore::IconDatabase::iconForPageURL): Ditto. (WebCore::IconDatabase::iconURLForPageURL): Ditto. (WebCore::IconDatabase::defaultIcon): Ditto. (WebCore::IconDatabase::retainIconForPageURL): Ditto. (WebCore::IconDatabase::releaseIconForPageURL): Ditto. (WebCore::IconDatabase::setIconDataForIconURL): Ditto. (WebCore::IconDatabase::setIconURLForPageURL): Ditto. (WebCore::IconDatabase::setEnabled): Ditto. (WebCore::IconDatabase::pageURLMappingCount): Added stub. (WebCore::IconDatabase::retainedPageURLCount): Ditto. (WebCore::IconDatabase::iconRecordCount): Ditto. (WebCore::IconDatabase::iconRecordCountWithData): Ditto.

8:27 AM Changeset in webkit [41108] by ddkilzer@apple.com

30 edits in trunk/WebKitSite

Bug 23983: Remove illegal HTML tags from Sunspider web pages

<https://bugs.webkit.org/show_bug.cgi?id=23983>

Reviewed by Alexey Proskuryakov.

perf/sunspider-0.9/3d-cube.html: Removed </link> tag.
perf/sunspider-0.9/3d-morph.html: Ditto.
perf/sunspider-0.9/3d-raytrace.html: Ditto.
perf/sunspider-0.9/access-binary-trees.html: Ditto.
perf/sunspider-0.9/access-fannkuch.html: Ditto.
perf/sunspider-0.9/access-nbody.html: Ditto.
perf/sunspider-0.9/access-nsieve.html: Ditto.
perf/sunspider-0.9/bitops-3bit-bits-in-byte.html: Ditto.
perf/sunspider-0.9/bitops-bits-in-byte.html: Ditto.
perf/sunspider-0.9/bitops-bitwise-and.html: Ditto.
perf/sunspider-0.9/bitops-nsieve-bits.html: Ditto.
perf/sunspider-0.9/controlflow-recursive.html: Ditto.
perf/sunspider-0.9/crypto-aes.html: Ditto.
perf/sunspider-0.9/crypto-md5.html: Ditto.
perf/sunspider-0.9/crypto-sha1.html: Ditto.
perf/sunspider-0.9/date-format-tofte.html: Ditto.
perf/sunspider-0.9/date-format-xparb.html: Ditto.
perf/sunspider-0.9/math-cordic.html: Ditto.
perf/sunspider-0.9/math-partial-sums.html: Ditto.
perf/sunspider-0.9/math-spectral-norm.html: Ditto.
perf/sunspider-0.9/regexp-dna.html: Ditto.
perf/sunspider-0.9/string-base64.html: Ditto.
perf/sunspider-0.9/string-fasta.html: Ditto.
perf/sunspider-0.9/string-tagcloud.html: Ditto.
perf/sunspider-0.9/string-unpack-code.html: Ditto.
perf/sunspider-0.9/string-validate-input.html: Ditto.
perf/sunspider-0.9/sunspider-driver.html: Ditto.
perf/sunspider-0.9/sunspider-results.html: Removed </link> and </input> tags.
perf/sunspider-0.9/sunspider.html: Removed </link> tag.

8:23 AM Changeset in webkit [41107] by ddkilzer@apple.com

2 edits in trunk/WebCore

Add comment to generated code when shadowing a built-in object

Reviewed by Sam Weinig.

bindings/scripts/CodeGeneratorJS.pm: Added comment to generated code output.

7:34 AM Changeset in webkit [41106] by darin@chromium.org

2 edits in trunk/WebCore

2009-02-20 Avi Drissman <avi@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24036
Keyboard events need disambiguation on the Linux platform too.

platform/chromium/PlatformKeyboardEventChromium.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):

7:31 AM Changeset in webkit [41105] by darin@chromium.org

3 edits in trunk/WebCore

2009-02-19 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24046

Several improvements to CString:
1- Make it possible to initialize a CString from a CStringBuffer
2- Make it possible to get a CStringBuffer from a CString
3- Change CStringBuffer::data() to return a const pointer to ward off mutation
4- Remove unused releaseBuffer() methods.
5- Make CStringBuffer::create() private to force consumers to get a CStringBuffer from a CString.

platform/text/CString.cpp: (WebCore::CString::init): (WebCore::CString::mutableData): (WebCore::CString::newUninitialized): (WebCore::CString::copyBufferIfNeeded):
platform/text/CString.h: (WebCore::CStringBuffer::data): (WebCore::CStringBuffer::length): (WebCore::CStringBuffer::create): (WebCore::CStringBuffer::mutableData): (WebCore::CString::CString): (WebCore::CString::buffer):

5:25 AM Changeset in webkit [41104] by kov@webkit.org

2 edits in trunk/JavaScriptCore

2009-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix after r41100.

GNUmakefile.am:

5:14 AM Changeset in webkit [41103] by oliver@apple.com

7 edits in trunk

<rdar://problem/6606660> 2==null returns true in 64bit jit

Reviewed by Mark Rowe

Code for op_eq_null and op_neq_null was incorrectly performing
a 32bit compare, which truncated the type tag from an integer
immediate, leading to incorrect behaviour.

Feb 19, 2009:

11:23 PM Changeset in webkit [41102] by dimich@chromium.org

8 edits in trunk/WebCore

2009-02-19 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24017
Remove some usage of Document in Worker.

dom/WorkerContext.h: (WebCore::WorkerContext::userAgent):
dom/Document.cpp: (WebCore::Document::userAgent):
dom/Document.h:
dom/ScriptExecutionContext.h: Added virtual ScriptExecutionContext::userAgent(const KURL&). Document implementation uses FrameLoader::userAgent and WorkerContext receives the string on creation and stores it in a member.

dom/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
dom/Worker.h: (WebCore::Worker::create): Instead of Document the Worker constructor now gets a ScriptExecutionContext. Start using some methods on SEC (like completeURL() and userAgent()). For others, explicitly case to Document and add a FIXME. Remove Worker::document() too.

10:20 PM Changeset in webkit [41101] by kov@webkit.org

2 edits in trunk/WebCore

2009-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Rubber-stamped by Holger Freyther.

Do not set httpStatus to SOUP_STATUS_OK when serving local files
to match other ports' behavior, fixing xmlhttprequest test
regressions.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::queryInfoCallback):

10:04 PM Changeset in webkit [41100] by ggaren@apple.com

9 edits
2 copies in trunk/JavaScriptCore

2009-02-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

First step in splitting JIT functionality out of the Interpreter class:
Created JITStubs.h/.cpp, and moved Interpreter::cti_* into JITStubs.cpp.

Functions that the Interpreter and JITStubs share moved to Operations.h/.cpp.

GNUmakefile.am:
JavaScriptCore.pri:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase): (JSC::Interpreter::checkTimeout): (JSC::Interpreter::privateExecute):
interpreter/Interpreter.h:
jit/JITStubs.cpp: Copied from interpreter/Interpreter.cpp. (JSC::Interpreter::cti_op_resolve_base):
jit/JITStubs.h: Copied from interpreter/Interpreter.h.
runtime/Operations.cpp: (JSC::jsAddSlowCase): (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::jsIsFunctionType):
runtime/Operations.h: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAdd): (JSC::cachePrototypeChain): (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::resolveBase):

6:02 PM Changeset in webkit [41099] by mrowe@apple.com

4 edits in branches/Safari-6528

Versioning.

6:02 PM Changeset in webkit [41098] by mrowe@apple.com

1 copy in tags/Safari-6528.16

New tag.

5:54 PM Changeset in webkit [41097] by mrowe@apple.com

2 edits in branches/Safari-6528/WebCore

Merge r41091.

5:41 PM Changeset in webkit [41096] by mitz@apple.com

9 edits in trunk

WebCore:

Reviewed by Sam Weinig.

WebCore part of fixing https://bugs.webkit.org/show_bug.cgi?id=24027 Do not send loader callbacks during CSS styling

Undo the iChat-specific quirk added in
<http://trac.webkit.org/changeset/41071>. Instead, always suspend memory
cache client callbacks during attach() and recalcStyle().

WebCore.base.exp: Removed Settings::setNeedsIChatMemoryCacheCallsQuirk().
dom/ContainerNode.cpp: (WebCore::ContainerNode::suspendPostAttachCallbacks): Disable memory cache client callbacks and remember to enable them afterwards if needed. (WebCore::ContainerNode::resumePostAttachCallbacks): Re-enable memory cache client callbacks if they were disabled in suspendPostAttachCallbacks(). (WebCore::ContainerNode::attach): Use suspendPostAttachCallbacks() and resumePostAttachCallbacks().
dom/ContainerNode.h: Made suspendPostAttachCallbacks() and resumePostAttachCallbacks() non-static.
dom/Document.cpp: (WebCore::Document::dispatchImageLoadEventsNow): Reverted iChat-specific workaround.
page/Settings.cpp: Removed m_needsIChatMemoryCacheCallsQuirk and related code. (WebCore::Settings::Settings):
page/Settings.h:

WebKit/mac:

Reviewed by Sam Weinig.

WebKit part of fixing https://bugs.webkit.org/show_bug.cgi?id=24027 Do not send loader callbacks during CSS styling

WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Reverted the iChat-specific quirk added in <http://trac.webkit.org/changeset/41071>.

5:38 PM Changeset in webkit [41095] by zecke@webkit.org

2 edits in trunk/WebCore

2009-02-19 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed build fix.

Build fix after r41092. Make the memoryUsage method
public. It will be shadowed by cf/mac and for curl/soup/qt
the implementation from ResourceResponseBase will be used.

platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::memoryUsage):

5:23 PM Changeset in webkit [41094] by Beth Dakin

3 edits in trunk/WebCore

2009-02-19 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Fix for <rdar://problem/6077775> Should be able to specify
inactive ::selection color

This patch makes the ::selction pseudo-element work with
the :window-inactive pseudo type. This was, a user can specify a
different ::selection style when a window is inactive.

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
rendering/RenderObject.cpp: (WebCore::RenderObject::selectionBackgroundColor): (WebCore::RenderObject::selectionForegroundColor):

4:38 PM Changeset in webkit [41093] by weinig@apple.com

9 edits
3 adds in trunk

WebCore:

2009-02-19 Sam Weinig <sam@webkit.org>

Reviewed by Beth Dakin.

Patch for https://bugs.webkit.org/show_bug.cgi?id=24044
Update querySelector/querySelectorAll to match the latest spec

Update querySelector and querySelectorAll to match the latest version
of the Selectors API spec. We now stringify null and undefined to "null"
and "undefined" respectively instead of to "".

Test: fast/dom/SelectorAPI/undefined-null-stringify.html

dom/Document.idl:
dom/DocumentFragment.idl:
dom/Element.idl:

LayoutTests:

2009-02-19 Sam Weinig <sam@webkit.org>

Reviewed by Beth Dakin.

Tests for https://bugs.webkit.org/show_bug.cgi?id=24044
Update querySelector/querySelectorAll to match the latest spec

fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:
fast/dom/SelectorAPI/dumpNodeList-expected.txt:
fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt:
fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: Updated. We now fail 17 tests due to not throwing an exception when no arguments are passed to querySelector or querySelectorAll.
fast/dom/SelectorAPI/resources/undefined-null-stringify.js: Added.
fast/dom/SelectorAPI/undefined-null-stringify-expected.txt: Added.
fast/dom/SelectorAPI/undefined-null-stringify.html: Added.

4:31 PM Changeset in webkit [41092] by Dimitri Glazkov

5 edits in trunk/WebCore

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=23732
Rework CachedResource overhead accounting to allow platforms to diverge
in numbers.

loader/CachedResource.cpp: (WebCore::CachedResource::overheadSize): Changed to ask ResourceResponse for its size and to use actual URL size.
platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::size): Added default size method.
platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::size): Added Win/CF size method
platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::size): Added Mac size method.

3:53 PM Changeset in webkit [41091] by andersca@apple.com

2 edits in trunk/WebCore

2009-02-19 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Fix for <rdar://problem/6604968>

On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
after the call to -[NSView displayRectIgnoringOpacity:inContext:].

platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):

2:52 PM Changeset in webkit [41090] by hyatt@apple.com

8 edits
4 adds in trunk

WebCore:

2009-02-19 David Hyatt <hyatt@apple.com>

Fix a bug where reflections didn't work properly if opacity was < 1. Make sure that replaced elements
also consider reflections to be part of their visual overflow. This had already been done for blocks
and lines, but it wasn't being done yet for replaced elements.

Also make sure that when the object being reflected has opacity < 1 that we don't end up popping the outer
transparency layer early. Since the reflected object paints twice, we don't want to end the transparency
layer it pushed until we're done painting the real object (rather than the reflection).

Reviewed by Dan Bernstein

Added fast/reflections/reflection-masks-opacity.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::layout):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect):
rendering/RenderReplaced.h:

LayoutTests:

2009-02-19 David Hyatt <hyatt@apple.com>

Fix a bug where reflections didn't work properly if opacity was < 1. Make sure that replaced elements
also consider reflections to be part of their visual overflow. This had already been done for blocks
and lines, but it wasn't being done yet for replaced elements.

Also make sure that when the object being reflected has opacity < 1 that we don't end up popping the outer
transparency layer early. Since the reflected object paints twice, we don't want to end the transparency
layer it pushed until we're done painting the real object (rather than the reflection).

Reviewed by Dan Bernstein

fast/reflections/reflection-masks-opacity.html: Added.
platform/mac/fast/reflections/reflection-direction-expected.txt:
platform/mac/fast/reflections/reflection-masks-expected.txt:
platform/mac/fast/reflections/reflection-masks-opacity-expected.checksum: Added.
platform/mac/fast/reflections/reflection-masks-opacity-expected.png: Added.
platform/mac/fast/reflections/reflection-masks-opacity-expected.txt: Added.

2:51 PM Changeset in webkit [41089] by barraclough@apple.com

14 edits in trunk/JavaScriptCore

2009-02-19 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix for x86-64. Where the JavaScriptCore text segment lies outside
a 2gb range of the heap containing JIT generated code, callbacks
from JIT code to the stub functions in Interpreter will be incorrectly
linked.

No performance impact on Sunspider, 1% regression on v8-tests,
due to a 3% regression on richards.

assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Call::Call): (JSC::AbstractMacroAssembler::Jump::link): (JSC::AbstractMacroAssembler::Jump::linkTo): (JSC::AbstractMacroAssembler::CodeLocationJump::relink): (JSC::AbstractMacroAssembler::CodeLocationCall::relink): (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToFunction): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive): (JSC::AbstractMacroAssembler::differenceBetween):
assembler/MacroAssembler.h: (JSC::MacroAssembler::tailRecursiveCall): (JSC::MacroAssembler::makeTailRecursiveCall):
assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::call):
assembler/MacroAssemblerX86Common.h:
assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::call): (JSC::MacroAssemblerX86_64::moveWithPatch): (JSC::MacroAssemblerX86_64::branchPtrWithPatch): (JSC::MacroAssemblerX86_64::storePtrWithPatch):
assembler/X86Assembler.h: (JSC::X86Assembler::jmp_r): (JSC::X86Assembler::linkJump): (JSC::X86Assembler::patchJump): (JSC::X86Assembler::patchCall): (JSC::X86Assembler::linkCall): (JSC::X86Assembler::patchAddress):
interpreter/Interpreter.cpp: (JSC::Interpreter::tryCTICachePutByID):
jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
jit/JIT.h:
jit/JITArithmetic.cpp: (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp):
jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompilePutByIdReplace):

2:35 PM Changeset in webkit [41088] by levin@chromium.org

3 edits in trunk/WebCore

2009-02-19 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23980: WorkerRunLoop needs a way to run in a given mode similar to CFRunLoopInMode.
<https://bugs.webkit.org/show_bug.cgi?id=23980>

WorkerRunLoop has the ability to run in a mode which filters the tasks to be run.

When WorkerRunLoop::runInMode is called, only task for that mode will run.
When WorkerRunLoop::run is called (or the default mode is used), then all tasks will run regardless of their posted mode.

Here's a demonstration of the api:

RefPtr<NameResolution> nameResolution = NameResolution::create(workerRunLoop);

Internally nameResolution will do workerRunLoop.postTaskForMode(task, "MyCoolMode")
for any tasks that need to be run during this loop.
nameResolution->setTaskMode("MyCoolMode");

nameResolution->start();
while (!nameResolution->done()) {

Only tasks which are posted for "MyCoolMode" will run.
workerRunLoop.runInMode(context, "MyCoolMode");

}

No observable change in behavior, so no test.

dom/WorkerRunLoop.cpp: (WebCore::ModePredicate::ModePredicate): (WebCore::ModePredicate::operator()): (WebCore::WorkerRunLoop::WorkerRunLoop): (WebCore::WorkerRunLoop::~WorkerRunLoop): (WebCore::WorkerRunLoop::setSharedTimer): (WebCore::WorkerRunLoop::resetSharedTimer): (WebCore::WorkerRunLoop::run): (WebCore::WorkerRunLoop::runInMode): (WebCore::WorkerRunLoop::postTask): (WebCore::WorkerRunLoop::postTaskForMode):
dom/WorkerRunLoop.h: (WebCore::WorkerRunLoop::Task::create): (WebCore::WorkerRunLoop::Task::mode): (WebCore::WorkerRunLoop::Task::performTask): (WebCore::WorkerRunLoop::Task::Task):

2:13 PM Changeset in webkit [41087] by dimich@chromium.org

3 edits in trunk/LayoutTests

2009-02-19 Jay Campan <jcampan@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23959
LayoutTests/fast/dom/navigator-detached-no-crash.html may fail with other JS engines.

fast/dom/navigator-detached-no-crash-expected.txt:
fast/dom/navigator-detached-no-crash.html:

1:41 PM Changeset in webkit [41086] by christian@webkit.org

2 edits in trunk

Add GLIB_LIBS to unit test library flags.

Rubber-stamped by Holger Freyther.

1:36 PM Changeset in webkit [41085] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24034
Fix up Selection->VisibleSelection change.

page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): Renamed Selection to VisibleSelection.

1:33 PM Changeset in webkit [41084] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24041
Correct Skia type conversion issues, fix Chromium Linux build.

platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs): changed parameters to RGBA32, not WebCore::Color.

12:35 PM Changeset in webkit [41083] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2009-02-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Simplified .call and .apply in preparation for optimizing them. Also,
a little cleanup.

runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall): No need to do any specific conversion on 'this' -- op_convert_this will do it if necessary.

runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject): Slightly relaxed the rules on toThisObject to allow for 'undefined', which can be passed through .call and .apply.

12:12 PM Changeset in webkit [41082] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-02-19 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20531
Chromium-part follow-up to the patch landed in r40636
for bug 20531.
Remove a static member function alternateFamilyName
from Chromium's Win/Linux ports of FontCache. In r40636,
alternateFamilyName was customized using #ifdef PLATFORM(WIN_OS).
So, there's no more need for the static member function per
platform.

platform/graphics/chromium/FontCacheChromiumWin.cpp:
platform/graphics/chromium/FontCacheLinux.cpp:

11:40 AM Changeset in webkit [41081] by levin@chromium.org

3 edits in trunk/JavaScriptCore

2009-02-19 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23976: MessageQueue needs a way to wait for a message that satisfies an arbitrary criteria.
<https://bugs.webkit.org/show_bug.cgi?id=23976>

wtf/Deque.h: (WTF::Deque<T>::findIf):
wtf/MessageQueue.h: (WTF::MessageQueue<T>::waitForMessageFiltered):

11:20 AM Changeset in webkit [41080] by Simon Fraser

3 edits in trunk/WebCore

2009-02-19 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

Call documentWillBecomeInactive() from Document::detach to ensure that
media elements are shut down, because they may be kept alive by references
from JS past document teardown.

documentWillBecomeInactive() calls renderView()->willMoveOffscreen(), so no
need to do that in detach() as well.

We no longer need to call documentWillBecomeInactive() from ~Page() (which
was added for <https://bugs.webkit.org/show_bug.cgi?id=21116>), since this
supersedes that change.

dom/Document.cpp: (WebCore::Document::detach):
page/Page.cpp: (WebCore::Page::~Page):

11:19 AM Changeset in webkit [41079] by Dimitri Glazkov

3 edits in trunk/LayoutTests

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24012
Clarify objective of the test and clean up.

fast/forms/inline-ignored-on-legend-expected.txt:
fast/forms/inline-ignored-on-legend.html:

11:14 AM Changeset in webkit [41078] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24028
Fix up Skia path changes.

platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::strokePath): Removed illegal indirection.
platform/graphics/skia/PathSkia.cpp: (WebCore::boundingBoxForCurrentStroke): Changed call name.

7:37 AM Changeset in webkit [41077] by kov@webkit.org

2 edits in trunk/WebCore

2009-02-19 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

Ignore ports on local URLs. This fixes a regression in
fast/loader/file-URL-with-port-number.html

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):

7:18 AM Changeset in webkit [41076] by kov@webkit.org

2 edits in trunk/WebCore

2009-02-19 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

Make setPort remove port if 0 is given to it, as promised by the
comment in KURL's header.

platform/KURL.cpp: (WebCore::KURL::setPort):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed