⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 12, 2014:

11:46 PM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
11:39 PM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
2:48 PM Changeset in webkit [174642] by Simon Fraser
  • 2 edits in trunk/Tools

Page not fully rendered in iOS DRT snapshots
​https://bugs.webkit.org/show_bug.cgi?id=137638

Reviewed by Tim Horton.

In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
to ensure that the page has laid out and is rendered by the time we take
the snapshot.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
(-[DumpRenderTree _webThreadInvoked]): Moved.
(-[DumpRenderTree _waitForWebThreadThenDump]):
(dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
relies on dispatch_async too, and the inner block won't complete until the outer block
has completed.
(dumpTestResults): Move the guts of dump() here.
(runTest): Whitespace.

11:48 AM Changeset in webkit [174641] by ap@apple.com
  • 4 edits in trunk

Adding svn:ignore so that .pyc files don't show up as new.

Source/JavaScriptCore:

  • inspector/scripts/codegen: Added property svn:ignore.

Tools:

  • Scripts/webkitpy/xcode: Added property svn:ignore.
5:55 AM Changeset in webkit [174640] by mkwst@chromium.org
  • 4 edits
    10 adds in trunk

Referrer Policy: Update <meta name="referrer"> values to match the spec
​https://bugs.webkit.org/show_bug.cgi?id=137635

Reviewed by Jochen Eisinger.

Source/WebCore:

The Referrer Policy specification ([Working Draft][WD], [Editor's
draft[ED]) defines different keywords than we originally
implemented. We should support them in the interests of clarity and
interoperability with other browsers implementing the specification.

[WD]: ​http://www.w3.org/TR/referrer-policy/#referrer-policy-delivery-meta
[ED]: ​http://w3c.github.io/webappsec/specs/referrer-policy/#referrer-policy-delivery-meta

This patch is a port of Blink's ​https://codereview.chromium.org/607433002/

Tests: http/tests/security/referrer-policy-conflicting-policies.html

http/tests/security/referrer-policy-https-no-referrer-when-downgrade.html
http/tests/security/referrer-policy-https-no-referrer.html
http/tests/security/referrer-policy-https-unsafe-url.html
http/tests/security/referrer-policy-no-referrer-when-downgrade.html
http/tests/security/referrer-policy-no-referrer.html

  • dom/Document.cpp:

(WebCore::Document::processReferrerPolicy):

LayoutTests:

  • http/tests/security/referrer-policy-https-no-referrer-expected.txt: Added.
  • http/tests/security/referrer-policy-https-no-referrer-when-downgrade-expected.txt: Added.
  • http/tests/security/referrer-policy-https-no-referrer-when-downgrade.html: Added.
  • http/tests/security/referrer-policy-https-no-referrer.html: Added.
  • http/tests/security/referrer-policy-https-unsafe-url-expected.txt: Added.
  • http/tests/security/referrer-policy-https-unsafe-url.html: Added.
  • http/tests/security/referrer-policy-invalid-expected.txt: Update the error message with new keywords.
  • http/tests/security/referrer-policy-no-referrer-expected.txt: Added.
  • http/tests/security/referrer-policy-no-referrer-when-downgrade-expected.txt: Added.
  • http/tests/security/referrer-policy-no-referrer-when-downgrade.html: Added.
  • http/tests/security/referrer-policy-no-referrer.html: Added.
2:32 AM Changeset in webkit [174639] by svillar@igalia.com
  • 3 edits in trunk/Source/WebKit2

[SOUP] [WK2] WebProcess and NetworkProcess initialization clears cache contents
​https://bugs.webkit.org/show_bug.cgi?id=137489

Reviewed by Carlos Garcia Campos.

Temporarily set the SoupCache's maximum size to a huge value
before calling soup_cache_load() so that the cache is not shrinked
to the default value.

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

2:18 AM Changeset in webkit [174638] by Carlos Garcia Campos
  • 18 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r174632 - [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
​https://bugs.webkit.org/show_bug.cgi?id=137485

Reviewed by Sergio Villar Senin.

Source/WebCore:

Use GThreadSafeMainLoopSource for GStreamer sources, since they
can be used from different threads. Also update GMutexLocker
usages, since it's now a template.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkTimeoutCallback):
(webkitVideoSinkRender):
(unlockBufferMutex):
(webkitVideoSinkUnlockStop):
(webkitVideoSinkStart):

  • platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::createReadBuffer):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(StreamingClient::handleNotifyFinished):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

Source/WTF:

We made GMainLoopSource thread safe, but in most of the cases we
know the sources are used by a single thread, which has an impact
in the performance (mutex, GCancellable, etc.). The new class
GThreadSafeMainLoopSource inherits from GMainLoopSource overriding
the new virtual methods and calling the parent for the common code.
GMutexLocker now supports recursive mutexes, it's a template that
can wrap a GMutex or a GRecMutex. GThreadSafeMainLoopSource uses a
recursive mutex using the new GMutexLocker API.

  • wtf/PlatformEfl.cmake: Add new file to compilation.
  • wtf/PlatformGTK.cmake: Ditto.
  • wtf/gobject/GMainLoopSource.cpp:

(WTF::GMainLoopSource::GMainLoopSource):
(WTF::GMainLoopSource::~GMainLoopSource):
(WTF::GMainLoopSource::cancel):
(WTF::GMainLoopSource::schedule):
(WTF::GMainLoopSource::scheduleAfterDelay):
(WTF::GMainLoopSource::prepareVoidCallback):
(WTF::GMainLoopSource::finishVoidCallback):
(WTF::GMainLoopSource::voidCallback):
(WTF::GMainLoopSource::prepareBoolCallback):
(WTF::GMainLoopSource::finishBoolCallback):
(WTF::GMainLoopSource::boolCallback):
(WTF::GMainLoopSource::socketCallback):
(WTF::GMainLoopSource::cancelWithoutLocking): Deleted.

  • wtf/gobject/GMainLoopSource.h:
  • wtf/gobject/GMutexLocker.h:

(WTF::MutexWrapper<GMutex>::lock):
(WTF::MutexWrapper<GMutex>::unlock):
(WTF::MutexWrapper<GRecMutex>::lock):
(WTF::MutexWrapper<GRecMutex>::unlock):
(WTF::GMutexLocker::GMutexLocker):
(WTF::GMutexLocker::lock):
(WTF::GMutexLocker::unlock):

  • wtf/gobject/GThreadSafeMainLoopSource.cpp: Added.

(WTF::GThreadSafeMainLoopSource::GThreadSafeMainLoopSource):
(WTF::GThreadSafeMainLoopSource::~GThreadSafeMainLoopSource):
(WTF::GThreadSafeMainLoopSource::cancel):
(WTF::GThreadSafeMainLoopSource::schedule):
(WTF::GThreadSafeMainLoopSource::scheduleAfterDelay):
(WTF::GThreadSafeMainLoopSource::prepareVoidCallback):
(WTF::GThreadSafeMainLoopSource::finishVoidCallback):
(WTF::GThreadSafeMainLoopSource::voidCallback):
(WTF::GThreadSafeMainLoopSource::prepareBoolCallback):
(WTF::GThreadSafeMainLoopSource::finishBoolCallback):
(WTF::GThreadSafeMainLoopSource::boolCallback):

  • wtf/gobject/GThreadSafeMainLoopSource.h: Added.

Tools:

Update GMainLoopSource tests. Most of the tests are now run twice,
first with a GMainLoopSource and then with a
GThreadSafeMainLoopSource, since both should have the same
behaviour. The threading test uses GThreadSafeMainLoopSource and
the delete on destroy test uses GMainLoopSource. The tests
themselves haven't changed, since there's no change in behaviour.

  • TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:

(TestWebKitAPI::GMainLoopSourceTest::source):
(TestWebKitAPI::basicRescheduling):
(TestWebKitAPI::TEST):
(TestWebKitAPI::reentrantRescheduling):
(TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
(TestWebKitAPI::basicDestroyCallbacks):
(TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
(TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):

1:35 AM Changeset in webkit [174637] by commit-queue@webkit.org
  • 9 edits
    9 adds in trunk

Support activation behavior of link element
​https://bugs.webkit.org/show_bug.cgi?id=137597

Patch by Dhi Aurrahman <​diorahman@rockybars.com> on 2014-10-12
Reviewed by Benjamin Poulain.

Source/WebCore:

Support activation behavior of link elements as defined in [1],
i.e. to follow the hyperlink created by the link element when it is fully active.

[1] ​https://html.spec.whatwg.org/multipage/semantics.html#the-link-element

Tests: fast/dom/html-link-element-activation-behavior-on-element-click.html

fast/dom/html-link-element-activation-behavior-on-mouse-click.html
fast/dom/html-link-element-activation-behavior-url-is-null.html

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::triggerActivationBehavior):

  • dom/MouseEvent.h:
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::isLinkClick): Deleted.

  • html/HTMLAnchorElement.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::defaultEventHandler):
(WebCore::HTMLLinkElement::handleClick):

  • html/HTMLLinkElement.h:
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

LayoutTests:

Add test cases for link element activation behavior.

  • fast/dom/html-link-element-activation-behavior-on-element-click-expected.txt: Added.
  • fast/dom/html-link-element-activation-behavior-on-element-click.html: Added.
  • fast/dom/html-link-element-activation-behavior-on-mouse-click-expected.txt: Added.
  • fast/dom/html-link-element-activation-behavior-on-mouse-click.html: Added.
  • fast/dom/html-link-element-activation-behavior-url-is-null-expected.txt: Added.
  • fast/dom/html-link-element-activation-behavior-url-is-null.html: Added.
  • fast/dom/resources/html-link-element-activation-behavior-on-element-click-step1.html: Added.
  • fast/dom/resources/html-link-element-activation-behavior-on-mouse-click-step1.html: Added.
  • fast/dom/resources/html-link-element-activation-behavior-target.html: Added.
12:15 AM Changeset in webkit [174636] by ryuan.choi@gmail.com
  • 12 edits
    11 adds
    1 delete in trunk

[EFL] Introduce EWebKit_Extension
​https://bugs.webkit.org/show_bug.cgi?id=134921

Reviewed by Gyuyoung Kim.

Source/WebKit2:

EWebKit2 does not provide the functionality to extend WebProcess.
Although there is ewk_context_new_with_injected_bundle_path() in ewebkit2 APIs,
application developers can not make bundle object without touching WK APIs
which ewebkit2 does not expose.

This patch introduces EWebKit_Extension, basic structure for the extension of WebProcess.

  • PlatformEfl.cmake:

Added files for the EWebKit_Extension and install them properly.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
(bundlePathForExtension):
(EwkContext::create):
(EwkContext::getInjectedBundleInitializationUserData):
(EwkContext::setMessageFromInjectedBundleCallback):
(ewk_context_new_with_extensions_path):
Deleted because ewebkit2 does not have a way to make injected bundle.
Instead, Ewk_Extension will cover the same functionalities.
(ewk_context_new_with_injected_bundle_path): Deleted.

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext::extensionsPath):

  • UIProcess/API/efl/tests/InjectedBundle/injected_bundle_sample.cpp: Removed.
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::extensionSample):
(EWK2UnitTest::EWK2UnitTestEnvironment::injectedBundleSample): Renamed injectedBundleSample to extensionSample.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
  • UIProcess/API/efl/tests/extensions/extension_sample.cpp: Copied from Source/WebKit2/UIProcess/API/efl/tests/InjectedBundle/injected_bundle_sample.cpp.
  • UIProcess/API/efl/tests/test_ewk2_context.cpp: Renamed ewk_context_new_with_injected_bundle_path to ewk_context_new_with_extensions_path.

(TEST_F):

  • WebProcess/InjectedBundle/API/efl/EWebKit_Extension.h: Added.
  • WebProcess/InjectedBundle/API/efl/ewk_extension.cpp: Added.

(EwkExtension::append):
(EwkExtension::remove):
(ewk_extension_client_add):
(ewk_extension_client_del):

  • WebProcess/InjectedBundle/API/efl/ewk_extension.h: Added.
  • WebProcess/InjectedBundle/API/efl/ewk_extension_private.h: Added.

(EwkExtension::EwkExtension):
(EwkExtension::~EwkExtension):

  • WebProcess/efl/ExtensionManagerEfl.cpp: Added.

(WebKit::ExtensionManagerEfl::shared):
(WebKit::ExtensionManagerEfl::ExtensionManagerEfl):
(WebKit::ExtensionManagerEfl::initialize):

  • WebProcess/efl/ExtensionManagerEfl.h: Added.
  • WebProcess/efl/WebInjectedBundleMainEfl.cpp: Added.

(WKBundleInitialize):

  • efl/ewebkit2-extension.pc.in: Added.

Tools:

  • MiniBrowser/efl/main.c: Added x option to test extension path.

(window_create):
(elm_main):

  • Scripts/webkitpy/common/config/watchlist:

Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.

  • Scripts/webkitpy/style/checker.py:

Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.

Oct 11, 2014:

11:07 AM Changeset in webkit [174635] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Mark some more tests as sometimes passing.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
10:27 AM Changeset in webkit [174634] by Simon Fraser
  • 2 edits in trunk/Tools

After r174628 we send the test process a SIGTERM before the SIGKILL.

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.serial_test_kill_process):

9:22 AM Changeset in webkit [174633] by commit-queue@webkit.org
  • 10 edits in trunk

[EFL] Enable WebP support.
​https://bugs.webkit.org/show_bug.cgi?id=136156

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2014-10-11
Reviewed by Gyuyoung Kim.

.:

Add WebP package finding rule.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add WebP library and inlcude path to WebCore path for WK2 Efl.
No new tests since existing feature is just enabled for WK2 Efl.

  • PlatformEfl.cmake:

Source/WTF:

Enable WTF_USE_WEBP macro for WK2 Efl.

  • wtf/Platform.h:

Tools:

Include libwebp-dev package to support WebP for WK2 Efl.

  • efl/install-dependencies:

LayoutTests:

Clarify skipped webp test for Webkit EFL.

  • platform/efl/TestExpectations:
12:08 AM Changeset in webkit [174632] by Carlos Garcia Campos
  • 18 edits
    2 adds in trunk

[GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
​https://bugs.webkit.org/show_bug.cgi?id=137485

Reviewed by Sergio Villar Senin.

Source/WebCore:

Use GThreadSafeMainLoopSource for GStreamer sources, since they
can be used from different threads. Also update GMutexLocker
usages, since it's now a template.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkTimeoutCallback):
(webkitVideoSinkRender):
(unlockBufferMutex):
(webkitVideoSinkUnlockStop):
(webkitVideoSinkStart):

  • platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::createReadBuffer):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(StreamingClient::handleNotifyFinished):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

Source/WTF:

We made GMainLoopSource thread safe, but in most of the cases we
know the sources are used by a single thread, which has an impact
in the performance (mutex, GCancellable, etc.). The new class
GThreadSafeMainLoopSource inherits from GMainLoopSource overriding
the new virtual methods and calling the parent for the common code.
GMutexLocker now supports recursive mutexes, it's a template that
can wrap a GMutex or a GRecMutex. GThreadSafeMainLoopSource uses a
recursive mutex using the new GMutexLocker API.

  • wtf/PlatformEfl.cmake: Add new file to compilation.
  • wtf/PlatformGTK.cmake: Ditto.
  • wtf/gobject/GMainLoopSource.cpp:

(WTF::GMainLoopSource::GMainLoopSource):
(WTF::GMainLoopSource::~GMainLoopSource):
(WTF::GMainLoopSource::cancel):
(WTF::GMainLoopSource::schedule):
(WTF::GMainLoopSource::scheduleAfterDelay):
(WTF::GMainLoopSource::prepareVoidCallback):
(WTF::GMainLoopSource::finishVoidCallback):
(WTF::GMainLoopSource::voidCallback):
(WTF::GMainLoopSource::prepareBoolCallback):
(WTF::GMainLoopSource::finishBoolCallback):
(WTF::GMainLoopSource::boolCallback):
(WTF::GMainLoopSource::socketCallback):
(WTF::GMainLoopSource::cancelWithoutLocking): Deleted.

  • wtf/gobject/GMainLoopSource.h:
  • wtf/gobject/GMutexLocker.h:

(WTF::MutexWrapper<GMutex>::lock):
(WTF::MutexWrapper<GMutex>::unlock):
(WTF::MutexWrapper<GRecMutex>::lock):
(WTF::MutexWrapper<GRecMutex>::unlock):
(WTF::GMutexLocker::GMutexLocker):
(WTF::GMutexLocker::lock):
(WTF::GMutexLocker::unlock):

  • wtf/gobject/GThreadSafeMainLoopSource.cpp: Added.

(WTF::GThreadSafeMainLoopSource::GThreadSafeMainLoopSource):
(WTF::GThreadSafeMainLoopSource::~GThreadSafeMainLoopSource):
(WTF::GThreadSafeMainLoopSource::cancel):
(WTF::GThreadSafeMainLoopSource::schedule):
(WTF::GThreadSafeMainLoopSource::scheduleAfterDelay):
(WTF::GThreadSafeMainLoopSource::prepareVoidCallback):
(WTF::GThreadSafeMainLoopSource::finishVoidCallback):
(WTF::GThreadSafeMainLoopSource::voidCallback):
(WTF::GThreadSafeMainLoopSource::prepareBoolCallback):
(WTF::GThreadSafeMainLoopSource::finishBoolCallback):
(WTF::GThreadSafeMainLoopSource::boolCallback):

  • wtf/gobject/GThreadSafeMainLoopSource.h: Added.

Tools:

Update GMainLoopSource tests. Most of the tests are now run twice,
first with a GMainLoopSource and then with a
GThreadSafeMainLoopSource, since both should have the same
behaviour. The threading test uses GThreadSafeMainLoopSource and
the delete on destroy test uses GMainLoopSource. The tests
themselves haven't changed, since there's no change in behaviour.

  • TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:

(TestWebKitAPI::GMainLoopSourceTest::source):
(TestWebKitAPI::basicRescheduling):
(TestWebKitAPI::TEST):
(TestWebKitAPI::reentrantRescheduling):
(TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
(TestWebKitAPI::basicDestroyCallbacks):
(TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
(TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):

Oct 10, 2014:

8:43 PM Changeset in webkit [174631] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve appearance of alpha color swatches
​https://bugs.webkit.org/show_bug.cgi?id=137627

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-10
Reviewed by Timothy Hatcher.

This improves the sizes. The color-swatch size is 1em x 1em,
which ends up being 11px, and thus there is still an imbalance.
However on both 1x and 2x displays this looks more even.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.css:

(.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch):

8:41 PM Changeset in webkit [174630] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: assert always logs undefined instead of the desired string
​https://bugs.webkit.org/show_bug.cgi?id=137632

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-10
Reviewed by Timothy Hatcher.

  • UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.dispatch):
Fix the assert log to include the method name.

7:00 PM Changeset in webkit [174629] by dburkart@apple.com
  • 2 edits in trunk/Tools

Fix fat-fingered function name in git-add-reviewer.

Unreviewed.

  • Scripts/git-add-reviewer:

(getConfigValue):

6:09 PM Changeset in webkit [174628] by dfarler@apple.com
  • 4 edits in trunk/Tools

[iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
​https://bugs.webkit.org/show_bug.cgi?id=137528

Reviewed by Simon Fraser.

Catch SIGINT and SIGTERM signals in the LayoutTestRelay
and SIGKILL the paired simulator app before exiting cleanly.

webkitpy only uses SIGKILL to kill processes which you cannot
catch. Send SIGTERM to the process and give it chance to do
its thing before sending SIGKILL. Sending a SIGKILL to an already
dead PID is safe.

  • LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
  • LayoutTestRelay/LayoutTestRelay/LTRelayController.m:

(-[LTRelayController finish]):

  • LayoutTestRelay/LayoutTestRelay/main.m:

(receivedSignal):
(main):

5:59 PM Changeset in webkit [174627] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Make these animation tests not timeout if hit testing fails.

  • animations/animation-hit-test-transform.html:
  • animations/animation-hit-test.html:
5:03 PM Changeset in webkit [174626] by dfarler@apple.com
  • 2 edits in trunk/Tools

[iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
​https://bugs.webkit.org/show_bug.cgi?id=137527

Reviewed by Simon Fraser.

NSFileHandle doesn't notify of EOF in its readability handler.
Use a dispatch_source_t and an event handler that is called when reading is possible.
In the handler block, do a run-of-the-mill read(2) from standard input and
detect EOF in the usual way by checking that zero bytes were read.

Once an EOF is received, the FIFOs are disconnected, the simulator app
is killed, and the relay exits with status 0.

  • LayoutTestRelay/LayoutTestRelay/LTRelayController.m:

(-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
(-[LTRelayController didDisconnect]):
(-[LTRelayController didConnect]):
(-[LTRelayController launchApp]):
Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
confusion with this new dispatch source, called "standardInputDispatchSource".
(-[LTRelayController finish]): Added.
(-[LTRelayController readFileHandle:]): Deleted.

4:49 PM Changeset in webkit [174625] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Crash on facebook.com
​https://bugs.webkit.org/show_bug.cgi?id=137562

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2014-10-10
Reviewed by Chris Dumez.

Crash occurs on the facebook.com when the webview is resized
after the <select> item is clicked but no item is chosen.
This crash is just caused by the reference of invalidated variable.
From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
on MiniBrowser is called.
As a result, just set ewk_menu to NULL in order to prevent crash condition.

  • MiniBrowser/efl/main.c:

(on_popup_menu_hide):

4:46 PM Changeset in webkit [174624] by ap@apple.com
  • 2 edits in trunk/Tools

A small wording change for clarity.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:

(MetricsBubbleView.prototype._update):

4:32 PM Changeset in webkit [174623] by Chris Dumez
  • 10 edits in trunk/Source

Use is<>() / downcast<>() for Image subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137625

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for Image subclasses.

Source/WebCore:

No new tests, no behavior change.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::createImage):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h:
  • platform/mac/DragImageMac.mm:

(WebCore::createDragImageFromImage):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::embeddedContentBox):

  • svg/graphics/SVGImage.h:

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginSnapshotTimerFired):

4:29 PM Changeset in webkit [174622] by ap@apple.com
  • 8 edits
    2 adds in trunk/Tools

Dashboard metrics page should have EWS statistics
​https://bugs.webkit.org/show_bug.cgi?id=137626

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:

(BubbleQueue): Put shortName in the object, so that it's actually useful.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:

(BubbleQueueServer): Re-ordered queues to match bubble order.
(BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
(BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:

Added analysis for bubble queues.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:

(buildBubbleQueuesTable): Build the UI.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:

Added JS sources to load.

  • QueueStatusServer/app.yaml: To update app version.
  • QueueStatusServer/handlers/processingtimesjson.py: Added.
  • QueueStatusServer/main.py: Added a handler for processing-times-json.
4:24 PM Changeset in webkit [174621] by dbates@webkit.org
  • 6 edits
    4 deletes in trunk/Source/WebKit

Remove unused classes WebRender{Node, Layer}
​https://bugs.webkit.org/show_bug.cgi?id=137628

Reviewed by Simon Fraser.

We no longer make use of the WebKit1-specific classes WebRenderNode and WebRenderLayer.
For completeness, there is a WebKit2 analogue of WebRenderLayer by the same name.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Configurations/WebKitLegacy.xcconfig: Remove file WebRenderNode.mm from the list

of excluded source files when building for iOS.

  • WebKit.exp: Remove symbol for WebRenderLayer.
  • WebKit.mac.exp: Remove symbol for WebRenderNode.
  • WebView/WebRenderLayer.h: Removed.
  • WebView/WebRenderLayer.mm: Removed.
  • WebView/WebRenderNode.h: Removed.
  • WebView/WebRenderNode.mm: Removed.
4:15 PM Changeset in webkit [174620] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

Mark compositing/rtl/rtl-fixed-overflow-scrolled.html as [ Failure ] on mac-wk1 platforms.

  • platform/mac-wk1/TestExpectations:
4:06 PM Changeset in webkit [174619] by Chris Dumez
  • 38 edits in trunk/Source

Use is<>() / downcast<>() for RenderElement
​https://bugs.webkit.org/show_bug.cgi?id=137622

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for RenderElement and clean up the
surrounding code.

Source/WebCore:

No new tests, no behavior change.

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computeRenderStyleForProperty):

  • dom/Node.cpp:

(WebCore::Node::materializeRareData):

  • dom/Position.cpp:

(WebCore::isNonTextLeafChild):
(WebCore::searchAheadForBetterMatch):

  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::didRecalcStyle):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):

  • editing/htmlediting.cpp:

(WebCore::isEmptyTableCell):

  • rendering/InlineIterator.h:

(WebCore::bidiNextShared):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::getFirstLetter):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::layout):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::rendererRemovedFromTree):
(WebCore::RenderCounter::rendererSubtreeAttached):
(showCounterRendererTree):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::findNextLayer):
(WebCore::RenderElement::layout):

  • rendering/RenderElement.h:

(WebCore::RenderObject::isRenderLayerModelObject):
(WebCore::RenderObject::isBoxModelObject):
(WebCore::RenderObject::isRenderBlock):
(WebCore::RenderObject::isRenderBlockFlow):
(WebCore::RenderObject::isRenderReplaced):
(WebCore::RenderObject::isRenderInline):
(WebCore::RenderObject::style):
(WebCore::RenderObject::firstLineStyle):
(WebCore::ContainerNode::renderer):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::computeChildrenStyleInRegion):
(WebCore::RenderNamedFlowFragment::setObjectStyleInRegion):
(WebCore::RenderNamedFlowFragment::restoreRegionObjectsOriginalStyle):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::clearNeedsLayout):
(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::collectAnnotatedRegions):

  • rendering/RenderVTTCue.cpp:

(WebCore::RenderVTTCue::initializeLayoutParameters):
(WebCore::RenderVTTCue::repositionGenericCue):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::addChild):

  • rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::addChild):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::rebuildTokenContent):
(WebCore::RenderMathMLOperator::updateStyle):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::addChild):
(WebCore::RenderMathMLRoot::layout):

  • rendering/mathml/RenderMathMLToken.cpp:

(WebCore::RenderMathMLToken::addChild):
(WebCore::RenderMathMLToken::updateTokenContent):
(WebCore::RenderMathMLToken::updateStyle):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::layout):

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::findPreviousAndNextAttributes):
(WebCore::RenderSVGText::subtreeStyleDidChange):
(WebCore::updateFontInAllDescendants):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::layoutChildren):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForForSubtree):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForTextRenderer):

  • rendering/svg/SVGTextLayoutAttributesBuilder.h:
  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
(WebCore::SVGTextMetricsBuilder::walkTree):
(WebCore::SVGTextMetricsBuilder::buildMetricsAndLayoutAttributes):

  • rendering/svg/SVGTextMetricsBuilder.h:
  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::createGlyphToPathTranslator):
(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::pauseAnimation):
(WebFrame::pauseTransition):

4:04 PM Changeset in webkit [174618] by Simon Fraser
  • 1 edit
    215 adds in trunk/LayoutTests

iOS Simulator results for fast/events tests.

  • platform/ios-simulator/fast/events/*: Added
4:04 PM Changeset in webkit [174617] by Simon Fraser
  • 1 edit
    37 adds in trunk/LayoutTests

iOS Simulator results for fast/dynamic tests.

  • platform/ios-simulator/fast/dynamic/*: Added
4:04 PM Changeset in webkit [174616] by Simon Fraser
  • 2 edits
    188 adds in trunk/LayoutTests

iOS Simulator results for fast/css3-text, fast/doctypes, fast/dom tests.
Skip fast/DeviceOrientation, fast/dom/shadow and some other failing tests.

  • platform/ios-simulator/fast/css3-text/*: Added.
  • platform/ios-simulator/fast/doctypes/*: Added.
  • platform/ios-simulator/fast/dom/*: Added.
3:38 PM Changeset in webkit [174615] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: CSS minification should not strip whitespace around calc +/- binary operators
​https://bugs.webkit.org/show_bug.cgi?id=137624

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-10
Reviewed by Timothy Hatcher.

Be careful when stripping whitespace around "+". We want to strip for
selectors "a + b" but not for calc expressions "calc(1px + 2px)".

This is not a perfect solution, but it does a good job. It may still break
with more complex calc expressions, like "calc(1px + calc())" but this
handles the basics.

  • Scripts/copy-user-interface-resources-dryrun.rb: Added.
  • Scripts/cssmin.py:

(cssminify):

3:29 PM Changeset in webkit [174614] by dino@apple.com
  • 1 edit
    1 copy
    1 move
    1 delete in trunk/LayoutTests

RenderMathMLUnderOver adds spacing to the child operator indefinitely when resizing the window.
​https://bugs.webkit.org/show_bug.cgi?id=137330

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2014-10-10
Reviewed by Simon Fraser.

Change the layout with resize test of the MathML underover object from being render tree test
to be reference test. The render test was failing on WK2 because it was doing window resizing
and view zooming. The new test rely solely on forcing the layout synchronously by resizing the
math container <div> element.

  • mathml/opentype/munderover-layout-resize-expected.html: Added.
  • mathml/opentype/munderover-layout-resize.html: Added.
  • mathml/opentype/munderover-window-resize-expected.txt: Removed.
  • mathml/opentype/munderover-window-resize.html: Removed.
2:23 PM Changeset in webkit [174613] by benjamin@webkit.org
  • 25 edits
    2 adds in trunk

Update :nth-child(An+B of selector-list) to the latest specification
​https://bugs.webkit.org/show_bug.cgi?id=137593

Reviewed by Andreas Kling.

Source/WebCore:

Following my implementation feedback on :nth-child(An+B of selector-list),
the CSS WG decided to change the definition such that the current element on which
the selector is matched must also match the selector list in :nth-child().

This patch updates the implementation accordingly.

Test: fast/selectors/nth-child-of-chained-3.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::matchSelectorList):

  • css/SelectorChecker.h:
  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChildOf):

LayoutTests:

  • fast/selectors/nth-child-of-chained-3-expected.txt: Added.
  • fast/selectors/nth-child-of-chained-3.html: Added.

This is an interesting new case with the new definition. Since the initial
element must also match the selector, it is now possible to fail even
if the combination An+B can match anything.

  • fast/css/nth-child-of-classname-expected.html:
  • fast/css/nth-child-of-classname.html:
  • fast/css/nth-child-of-compound-selector-expected.html:
  • fast/css/nth-child-of-compound-selector.html:
  • fast/css/nth-child-of-tagname-expected.html:
  • fast/css/nth-child-of-tagname.html:
  • fast/selectors/nth-child-of-backtracking-adjacent-2.html:
  • fast/selectors/nth-child-of-backtracking-adjacent.html:
  • fast/selectors/nth-child-of-basics-2-expected.txt:
  • fast/selectors/nth-child-of-basics-2.html:
  • fast/selectors/nth-child-of-basics-expected.txt:
  • fast/selectors/nth-child-of-basics.html:
  • fast/selectors/nth-child-of-chained-2-expected.txt:
  • fast/selectors/nth-child-of-chained-2.html:
  • fast/selectors/nth-child-of-complex-selectors-expected.txt:
  • fast/selectors/nth-child-of-complex-selectors.html:
  • fast/selectors/nth-child-of-never-matching-selector-expected.txt:
  • fast/selectors/nth-child-of-never-matching-selector.html:
  • fast/selectors/nth-child-of-selector-list-expected.txt:
  • fast/selectors/nth-child-of-selector-list.html:

Updating the test and tests result for the new definition.

2:10 PM Changeset in webkit [174612] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Update a Mavericks-specific baseline.

  • platform/mac-mavericks/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
1:33 PM Changeset in webkit [174611] by ap@apple.com
  • 3 edits in trunk/Tools

REGRESSION: Commit queue doesn't process rollouts
​https://bugs.webkit.org/show_bug.cgi?id=137623

Reviewed by Tim Horton.

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/handlers/updateworkitems.py:

(UpdateWorkItems._work_items_from_request):

1:30 PM Changeset in webkit [174610] by commit-queue@webkit.org
  • 10 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r174606.
​https://bugs.webkit.org/show_bug.cgi?id=137621

broke a JSC test (Requested by estes on #webkit).

Reverted changeset:

"Various arguments optimisations in codegen fail to account
for arguments being in lexical record"
​https://bugs.webkit.org/show_bug.cgi?id=137617
​http://trac.webkit.org/changeset/174606

1:20 PM Changeset in webkit [174609] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Skip some tests that timeout every time.

  • platform/mac/TestExpectations:
12:59 PM Changeset in webkit [174608] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Re-enable some compositing/rtl/ tests that acquired correct baselines in r174589

  • platform/mac/TestExpectations:
12:41 PM Changeset in webkit [174607] by aestes@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

Only run platform/mac/editing/input/undo-grouping-on-text-insertion.html on Yosemite

  • platform/mac-mavericks/TestExpectations: Added.
  • platform/mac/TestExpectations:
12:18 PM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
12:03 PM Changeset in webkit [174606] by oliver@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Various arguments optimisations in codegen fail to account for arguments being in lexical record
​https://bugs.webkit.org/show_bug.cgi?id=137617

Reviewed by Michael Saboff.

Rework the way we track |arguments| references so that we don't try
to use the |arguments| reference on the stack if it's not safe.

To do this without nuking performance it was necessary to update
the parser to track modification of the |arguments| reference
itself.

  • bytecode/CodeBlock.cpp:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::willResolveToArguments):
(JSC::BytecodeGenerator::uncheckedLocalArgumentsRegister):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::uncheckedRegisterForArguments): Deleted.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::hasSafeLocalArgumentsRegister):

  • bytecompiler/NodesCodegen.cpp:

(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::getArgumentByVal):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::ArrayPatternNode::emitDirectBinding):

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::existingArguments):

  • parser/Nodes.h:

(JSC::ScopeNode::modifiesArguments):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):

  • parser/Parser.h:

(JSC::Scope::getCapturedVariables):

  • parser/ParserModes.h:
11:32 AM Changeset in webkit [174605] by clopez@igalia.com
  • 3 edits
    1 add in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Mark and report test failing after r137615 and r174540.
  • platform/gtk/mathml/opentype/munderover-window-resize-expected.txt: Added. Rebaseline after r174540.
  • platform/gtk/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Rebaseline after r174540.
11:16 AM Changeset in webkit [174604] by Simon Fraser
  • 2 edits in trunk/Tools

Fix syntax error after r174601.

  • Scripts/run-javascriptcore-tests:
11:02 AM Changeset in webkit [174603] by Chris Dumez
  • 48 edits in trunk/Source/WebCore

Drop RENDER_OBJECT_TYPE_CASTS() for a lot of RenderObject subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137594

Reviewed by Darin Adler.

Drop RENDER_OBJECT_TYPE_CASTS() for RenderObject subclasses that no
longer needed it or that required very few changes to do so. This will
make sure developers start using is<>() / downcast<>() for those
classes.

No new tests, no behavior change.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::titleUIElement):

  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::didAttachRenderers):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshot):
(WebCore::HTMLPlugInImageElement::checkSnapshotStatus):

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::addSearchResult):
(WebCore::SearchInputType::didSetValueByUserEdit):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerTextElement::renderer):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):

  • page/FrameView.cpp:

(WebCore::FrameView::isInChildFrameWithFrameFlattening):

  • rendering/RenderButton.h:
  • rendering/RenderCounter.h:
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFullScreen.h:
  • rendering/RenderGrid.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderIFrame.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::contentsBox):

  • rendering/RenderMedia.h:
  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::attachQuote):

  • rendering/RenderQuote.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderSearchField.h:
  • rendering/RenderSnapshottedPlugIn.h:
  • rendering/RenderTableCaption.h:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

  • rendering/RenderVideo.cpp:

(WebCore::rendererPlaceholder):

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::updateCounterIfNeeded):

  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGGradientStop.h:
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp:

(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):

  • rendering/svg/RenderSVGTextPath.h:
  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/RenderSVGViewportContainer.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow):
(WebCore::SVGRenderSupport::checkForSVGRepaintDuringLayout):
(WebCore::updateObjectBoundingBox):
(WebCore::layoutSizeOfNearestViewportChanged):
(WebCore::SVGRenderSupport::transformToRootChanged):
(WebCore::SVGRenderSupport::rendererHasSVGShadow):
(WebCore::SVGRenderSupport::setRendererHasSVGShadow):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::beginTextPathLayout):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::getBBox):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::currentViewportSize):

10:51 AM Changeset in webkit [174602] by Chris Dumez
  • 9 edits in trunk/Source

Use is<>() / downcast<>() for GraphicsLayer subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137595

Reviewed by Darin Adler.

Use is<>() / downcast<>() for GraphicsLayer subclasses and clean up the
surrounding code.

Source/WebCore:

No new tests, no behavior change.

  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::Highlight::Highlight):
(WebCore::ServicesOverlayController::Highlight::fadeIn):
(WebCore::ServicesOverlayController::Highlight::fadeOut):

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::removeFromParent):
(WebCore::GraphicsLayerCA::setMaskLayer):
(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateMaskLayer):
(WebCore::GraphicsLayerCA::replicatedLayerRoot):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
(WebCore::GraphicsLayerCA::propagateLayerChangeToReplicas):
(WebCore::GraphicsLayerCA::fetchCloneLayers):

  • platform/graphics/ca/GraphicsLayerCA.h:

Source/WebKit2:

  • WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::layerForTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::shadowLayerForTransientZoom):

10:47 AM Changeset in webkit [174601] by msaboff@apple.com
  • 3 edits in trunk/Tools

Add ability to select tarfile name in run-jsc-stress-tests
​https://bugs.webkit.org/show_bug.cgi?id=137614

Reviewed by Mark Hahnenberg.

Added optional file name argument to the --tarball option.

  • Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first

extra test given after the options wont be used for the optional tarball file name.

  • Scripts/run-jsc-stress-tests:
10:42 AM Changeset in webkit [174600] by Simon Fraser
  • 1 edit
    53 adds in trunk/LayoutTests

iOS Simulator results for fast/css-generated-content, css-grid-layout tests.

  • platform/ios-simulator/fast/css-generated-content/*: Added.
  • platform/ios-simulator/fast/css-grid-layout/*: Added.
10:42 AM Changeset in webkit [174599] by Simon Fraser
  • 1 edit
    265 adds in trunk/LayoutTests

iOS Simulator results for fast/css tests.

  • platform/ios-simulator/fast/css/*: Added
10:42 AM Changeset in webkit [174598] by Simon Fraser
  • 2 edits
    48 adds in trunk/LayoutTests

iOS Simulator results for fast/box-shadow, box-sizing, canvas, clip and compact tests.

  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/fast/box-shadow/*
  • platform/ios-simulator/fast/box-sizing/*: Added.
  • platform/ios-simulator/fast/canvas/*: Added.
  • platform/ios-simulator/fast/clip/*: Added.
  • platform/ios-simulator/fast/compact/*: Added.
10:42 AM Changeset in webkit [174597] by Simon Fraser
  • 1 edit
    60 adds in trunk/LayoutTests

iOS Simulator results for fast/borders tests.

  • platform/ios-simulator/fast/borders/*: Added
10:42 AM Changeset in webkit [174596] by Simon Fraser
  • 1 edit
    69 adds in trunk/LayoutTests

iOS Simulator results for fast/body-propagation tests.

  • platform/ios-simulator/fast/body-propagation/*: Added
10:42 AM Changeset in webkit [174595] by Simon Fraser
  • 1 edit
    295 adds in trunk/LayoutTests

iOS Simulator results for fast/block tests.

  • platform/ios-simulator/fast/block/*: Added
10:42 AM Changeset in webkit [174594] by Simon Fraser
  • 2 edits
    30 adds in trunk/LayoutTests

Skip fast/animation in the iOS Simulator.
Add results for fast/backgrounds

  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/fast/backgrounds/*: Added.
10:35 AM Changeset in webkit [174593] by Chris Dumez
  • 2 edits in trunk/Tools

Unreviewed, update my information in contributors.json

Use my preferred first name and update my expertise areas.

  • Scripts/webkitpy/common/config/contributors.json:
10:26 AM Changeset in webkit [174592] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix debug build on EFL after r174584
​https://bugs.webkit.org/show_bug.cgi?id=137613

Patch by Pascal Jacquemart <​p.jacquemart@samsung.com> on 2014-10-10
Reviewed by Christophe Dumez.

  • UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):

10:08 AM Changeset in webkit [174591] by aestes@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add a mac-mountainlion result for delete-autocorrected-word-2.html.

  • platform/mac-mountainlion/platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt: Added.
9:38 AM Changeset in webkit [174590] by aestes@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

[Mountain Lion] Fix global-constructors-attributes.html

Get rid of the platform/mac-wk2/ result since it's identical to the platform/mac/ version.

  • platform/mac-wk2/js/dom/global-constructors-attributes-expected.txt: Removed.
9:25 AM Changeset in webkit [174589] by aestes@apple.com
  • 1 edit
    10 adds in trunk/LayoutTests

Fixes for additional Mavericks test failures.

  • platform/mac-mavericks/compositing/fixed-image-loading-expected.txt: Added.
  • platform/mac-mavericks/compositing/rtl/rtl-fixed-expected.png: Added.
  • platform/mac-mavericks/compositing/rtl/rtl-fixed-expected.txt: Added.
  • platform/mac-mavericks/compositing/rtl/rtl-fixed-overflow-expected.png: Added.
  • platform/mac-mavericks/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
  • platform/mac-mavericks/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
  • platform/mac-mavericks/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/mac-mavericks/fast/repaint/selection-gap-fixed-child-expected.txt: Added.
  • platform/mac-mavericks/fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
8:53 AM Changeset in webkit [174588] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Some more Mac TestExpectation tweaking.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
8:49 AM Changeset in webkit [174587] by Chris Dumez
  • 34 edits in trunk/Source

Use is<>() / downcast<>() for RenderBoxModelObject
​https://bugs.webkit.org/show_bug.cgi?id=137587

Reviewed by Mihnea Ovidenie.

Use is<>() / downcast<>() for RenderBoxModelObject and clean up the
surrounding code.

Source/WebCore:

No new tests, no behavior change.

  • accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::renderBoxModelObject):
(WebCore::isInlineWithContinuation):
(WebCore::firstChildConsideringContinuation):
(WebCore::lastChildHasContinuation):
(WebCore::AccessibilityRenderObject::nextSibling):
(WebCore::AccessibilityRenderObject::widget):
(WebCore::AccessibilityRenderObject::renderObjectIsObservable):
(WebCore::AccessibilityRenderObject::observableObject):
(WebCore::msaaRoleForRenderer):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable):

  • dom/Node.cpp:

(WebCore::Node::renderBox):
(WebCore::Node::renderBoxModelObject):

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementInfo):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

  • page/PrintContext.cpp:

(WebCore::enclosingBoxModelObject):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::freezeAtTime):

  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::startAnimation):
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::endAnimation):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::startAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):

  • page/ios/FrameIOS.mm:

(WebCore::Frame::overflowScrollPositionChangedForNode):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects):

  • rendering/InlineBox.h:

(WebCore::InlineBox::boxModelObject):

  • rendering/InlineElementBox.h:

(WebCore::InlineElementBox::renderer):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::renderer):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildToContinuation):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::addChildToContinuation):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::destroy):
(WebCore::RenderObject::offsetParent):

  • rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::base):

Source/WebKit/mac:

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView invalidatePluginContentRect:]):

  • WebView/WebRenderLayer.mm:

(-[WebRenderLayer initWithWebFrame:]):

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::renderer):
(WebKit::PluginView::invalidateRect):

8:34 AM Changeset in webkit [174586] by aestes@apple.com
  • 1 edit
    2 moves
    3 adds in trunk/LayoutTests

Fix some Mavericks test failures caused by r174585.

  • platform/mac-mavericks/fast/css/resize-corner-tracking-expected.txt: Added.
  • platform/mac-mavericks/fast/events/shadow-event-path-2-expected.txt: Added.
  • platform/mac-mavericks/platform/mac/fast/text/systemFont-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.txt.
  • platform/mac-mavericks/platform/mac/fast/text/vertical-no-sideways-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.txt.
7:36 AM Changeset in webkit [174585] by aestes@apple.com
  • 592 edits
    590 copies
    2 moves
    105 adds
    6 deletes in trunk/LayoutTests

Added Yosemite expected results and TestExpections to platform/mac/.

To-be-overwritten files in platform/mac/ were first moved to platform/mac-mavericks/.

  • platform/mac-mavericks/accessibility/aria-readonly-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-readonly-expected.txt.
  • platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Copied from LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt.
  • platform/mac-mavericks/compositing/contents-opaque/control-layer-expected.txt: Copied from LayoutTests/platform/mac/compositing/contents-opaque/control-layer-expected.txt.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-161-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-161-expected.png.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-19b-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.png.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-23-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.png.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-24-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.png.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-64-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.png.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-68-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.png.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-69-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.png.
  • platform/mac-mavericks/css3/selectors3/html/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-161-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-161-expected.png.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.png.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-23-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.png.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-24-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.png.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-64-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.png.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-68-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.png.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-69-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.png.
  • platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-161-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-161-expected.png.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-19b-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.png.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-23-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-23-expected.png.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-24-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-24-expected.png.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-64-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-64-expected.png.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-68-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-68-expected.png.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-69-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-69-expected.png.
  • platform/mac-mavericks/css3/selectors3/xml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt.
  • platform/mac-mavericks/editing/input/caret-at-the-edge-of-input-expected.txt: Copied from LayoutTests/platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt.
  • platform/mac-mavericks/editing/input/reveal-caret-of-multiline-input-expected.txt: Copied from LayoutTests/platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt.
  • platform/mac-mavericks/editing/inserting/4960120-1-expected.png: Copied from LayoutTests/platform/mac/editing/inserting/4960120-1-expected.png.
  • platform/mac-mavericks/editing/inserting/4960120-1-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/4960120-1-expected.txt.
  • platform/mac-mavericks/editing/inserting/before-after-input-element-expected.png: Copied from LayoutTests/platform/mac/editing/inserting/before-after-input-element-expected.png.
  • platform/mac-mavericks/editing/inserting/before-after-input-element-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/before-after-input-element-expected.txt.
  • platform/mac-mavericks/editing/pasteboard/4641033-expected.png: Copied from LayoutTests/platform/mac/editing/pasteboard/4641033-expected.png.
  • platform/mac-mavericks/editing/pasteboard/4806874-expected.png: Copied from LayoutTests/platform/mac/editing/pasteboard/4806874-expected.png.
  • platform/mac-mavericks/editing/pasteboard/4806874-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/4806874-expected.txt.
  • platform/mac-mavericks/editing/pasteboard/4944770-1-expected.png: Copied from LayoutTests/platform/mac/editing/pasteboard/4944770-1-expected.png.
  • platform/mac-mavericks/editing/pasteboard/4944770-2-expected.png: Copied from LayoutTests/platform/mac/editing/pasteboard/4944770-2-expected.png.
  • platform/mac-mavericks/editing/pasteboard/drop-text-without-selection-expected.png: Copied from LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.png.
  • platform/mac-mavericks/editing/pasteboard/drop-text-without-selection-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt.
  • platform/mac-mavericks/editing/pasteboard/input-field-1-expected.png: Copied from LayoutTests/platform/mac/editing/pasteboard/input-field-1-expected.png.
  • platform/mac-mavericks/editing/pasteboard/input-field-1-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/input-field-1-expected.txt.
  • platform/mac-mavericks/editing/pasteboard/pasting-tabs-expected.png: Copied from LayoutTests/platform/mac/editing/pasteboard/pasting-tabs-expected.png.
  • platform/mac-mavericks/editing/pasteboard/pasting-tabs-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/pasting-tabs-expected.txt.
  • platform/mac-mavericks/editing/selection/3690703-2-expected.png: Copied from LayoutTests/platform/mac/editing/selection/3690703-2-expected.png.
  • platform/mac-mavericks/editing/selection/3690703-2-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-2-expected.txt.
  • platform/mac-mavericks/editing/selection/3690703-expected.png: Copied from LayoutTests/platform/mac/editing/selection/3690703-expected.png.
  • platform/mac-mavericks/editing/selection/3690703-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-expected.txt.
  • platform/mac-mavericks/editing/selection/3690719-expected.png: Copied from LayoutTests/platform/mac/editing/selection/3690719-expected.png.
  • platform/mac-mavericks/editing/selection/3690719-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690719-expected.txt.
  • platform/mac-mavericks/editing/selection/4397952-expected.png: Copied from LayoutTests/platform/mac/editing/selection/4397952-expected.png.
  • platform/mac-mavericks/editing/selection/4397952-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4397952-expected.txt.
  • platform/mac-mavericks/editing/selection/4895428-3-expected.png: Copied from LayoutTests/platform/mac/editing/selection/4895428-3-expected.png.
  • platform/mac-mavericks/editing/selection/4895428-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4895428-3-expected.txt.
  • platform/mac-mavericks/editing/selection/4975120-expected.png: Copied from LayoutTests/platform/mac/editing/selection/4975120-expected.png.
  • platform/mac-mavericks/editing/selection/4975120-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4975120-expected.txt.
  • platform/mac-mavericks/editing/selection/5240265-expected.png: Copied from LayoutTests/platform/mac/editing/selection/5240265-expected.png.
  • platform/mac-mavericks/editing/selection/caret-before-select-expected.png: Copied from LayoutTests/platform/mac/editing/selection/caret-before-select-expected.png.
  • platform/mac-mavericks/editing/selection/drag-select-1-expected.png: Copied from LayoutTests/platform/mac/editing/selection/drag-select-1-expected.png.
  • platform/mac-mavericks/editing/selection/drag-select-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/drag-select-1-expected.txt.
  • platform/mac-mavericks/editing/selection/replaced-boundaries-3-expected.png: Copied from LayoutTests/platform/mac/editing/selection/replaced-boundaries-3-expected.png.
  • platform/mac-mavericks/editing/selection/replaced-boundaries-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/replaced-boundaries-3-expected.txt.
  • platform/mac-mavericks/editing/selection/select-across-readonly-input-1-expected.png: Copied from LayoutTests/platform/mac/editing/selection/select-across-readonly-input-1-expected.png.
  • platform/mac-mavericks/editing/selection/select-across-readonly-input-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/select-across-readonly-input-1-expected.txt.
  • platform/mac-mavericks/editing/selection/select-across-readonly-input-2-expected.png: Copied from LayoutTests/platform/mac/editing/selection/select-across-readonly-input-2-expected.png.
  • platform/mac-mavericks/editing/selection/select-across-readonly-input-2-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/select-across-readonly-input-2-expected.txt.
  • platform/mac-mavericks/editing/selection/select-across-readonly-input-3-expected.png: Copied from LayoutTests/platform/mac/editing/selection/select-across-readonly-input-3-expected.png.
  • platform/mac-mavericks/editing/selection/select-across-readonly-input-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/select-across-readonly-input-3-expected.txt.
  • platform/mac-mavericks/editing/selection/select-across-readonly-input-4-expected.png: Copied from LayoutTests/platform/mac/editing/selection/select-across-readonly-input-4-expected.png.
  • platform/mac-mavericks/editing/selection/select-across-readonly-input-4-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/select-across-readonly-input-4-expected.txt.
  • platform/mac-mavericks/editing/selection/select-across-readonly-input-5-expected.png: Copied from LayoutTests/platform/mac/editing/selection/select-across-readonly-input-5-expected.png.
  • platform/mac-mavericks/editing/selection/select-across-readonly-input-5-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/select-across-readonly-input-5-expected.txt.
  • platform/mac-mavericks/editing/selection/select-box-expected.png: Copied from LayoutTests/platform/mac/editing/selection/select-box-expected.png.
  • platform/mac-mavericks/editing/selection/select-element-paragraph-boundary-expected.png: Copied from LayoutTests/platform/mac/editing/selection/select-element-paragraph-boundary-expected.png.
  • platform/mac-mavericks/editing/selection/select-from-textfield-outwards-expected.png: Copied from LayoutTests/platform/mac/editing/selection/select-from-textfield-outwards-expected.png.
  • platform/mac-mavericks/editing/selection/select-from-textfield-outwards-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/select-from-textfield-outwards-expected.txt.
  • platform/mac-mavericks/editing/selection/selection-button-text-expected.png: Copied from LayoutTests/platform/mac/editing/selection/selection-button-text-expected.png.
  • platform/mac-mavericks/editing/selection/selection-button-text-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/selection-button-text-expected.txt.
  • platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt.
  • platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt.
  • platform/mac-mavericks/fast/block/lineboxcontain/block-with-ideographs-expected.png: Copied from LayoutTests/platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.png.
  • platform/mac-mavericks/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Copied from LayoutTests/platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt.
  • platform/mac-mavericks/fast/block/margin-collapse/103-expected.png: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/103-expected.png.
  • platform/mac-mavericks/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/103-expected.txt.
  • platform/mac-mavericks/fast/block/positioning/inline-block-relposition-expected.png: Copied from LayoutTests/platform/mac/fast/block/positioning/inline-block-relposition-expected.png.
  • platform/mac-mavericks/fast/block/positioning/inline-block-relposition-expected.txt: Copied from LayoutTests/platform/mac/fast/block/positioning/inline-block-relposition-expected.txt.
  • platform/mac-mavericks/fast/css/continuationCrash-expected.png: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.png.
  • platform/mac-mavericks/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
  • platform/mac-mavericks/fast/css/css2-system-fonts-expected.png: Copied from LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.png.
  • platform/mac-mavericks/fast/css/css2-system-fonts-expected.txt: Copied from LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt.
  • platform/mac-mavericks/fast/css/font-family-pictograph-expected.txt: Copied from LayoutTests/platform/mac/fast/css/font-family-pictograph-expected.txt.
  • platform/mac-mavericks/fast/css/input-search-padding-expected.png: Copied from LayoutTests/platform/mac/fast/css/input-search-padding-expected.png.
  • platform/mac-mavericks/fast/css/line-height-expected.png: Copied from LayoutTests/platform/mac/fast/css/line-height-expected.png.
  • platform/mac-mavericks/fast/css/line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/css/line-height-expected.txt.
  • platform/mac-mavericks/fast/css/margin-top-bottom-dynamic-expected.png: Copied from LayoutTests/platform/mac/fast/css/margin-top-bottom-dynamic-expected.png.
  • platform/mac-mavericks/fast/css/margin-top-bottom-dynamic-expected.txt: Copied from LayoutTests/platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt.
  • platform/mac-mavericks/fast/css/resize-corner-tracking-expected.png: Copied from LayoutTests/platform/mac/fast/css/resize-corner-tracking-expected.png.
  • platform/mac-mavericks/fast/css/rtl-ordering-expected.png: Copied from LayoutTests/platform/mac/fast/css/rtl-ordering-expected.png.
  • platform/mac-mavericks/fast/css/rtl-ordering-expected.txt: Copied from LayoutTests/platform/mac/fast/css/rtl-ordering-expected.txt.
  • platform/mac-mavericks/fast/css/text-input-with-webkit-border-radius-expected.png: Copied from LayoutTests/platform/mac/fast/css/text-input-with-webkit-border-radius-expected.png.
  • platform/mac-mavericks/fast/css/text-input-with-webkit-border-radius-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt.
  • platform/mac-mavericks/fast/css/text-overflow-input-expected.png: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.png.
  • platform/mac-mavericks/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
  • platform/mac-mavericks/fast/css/text-transform-select-expected.png: Copied from LayoutTests/platform/mac/fast/css/text-transform-select-expected.png.
  • platform/mac-mavericks/fast/css/text-transform-select-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-transform-select-expected.txt.
  • platform/mac-mavericks/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Copied from LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png.
  • platform/mac-mavericks/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
  • platform/mac-mavericks/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png.
  • platform/mac-mavericks/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt.
  • platform/mac-mavericks/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Copied from LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png.
  • platform/mac-mavericks/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt.
  • platform/mac-mavericks/fast/dom/isindex-001-expected.png: Copied from LayoutTests/platform/mac/fast/dom/isindex-001-expected.png.
  • platform/mac-mavericks/fast/dom/isindex-001-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-001-expected.txt.
  • platform/mac-mavericks/fast/dom/isindex-002-expected.png: Copied from LayoutTests/platform/mac/fast/dom/isindex-002-expected.png.
  • platform/mac-mavericks/fast/dom/isindex-002-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-002-expected.txt.
  • platform/mac-mavericks/fast/dynamic/008-expected.png: Copied from LayoutTests/platform/mac/fast/dynamic/008-expected.png.
  • platform/mac-mavericks/fast/dynamic/008-expected.txt: Copied from LayoutTests/platform/mac/fast/dynamic/008-expected.txt.
  • platform/mac-mavericks/fast/dynamic/positioned-movement-with-positioned-children-expected.png: Copied from LayoutTests/platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.png.
  • platform/mac-mavericks/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Copied from LayoutTests/platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.txt.
  • platform/mac-mavericks/fast/encoding/denormalised-voiced-japanese-chars-expected.txt: Copied from LayoutTests/platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt.
  • platform/mac-mavericks/fast/events/context-no-deselect-expected.png: Copied from LayoutTests/platform/mac/fast/events/context-no-deselect-expected.png.
  • platform/mac-mavericks/fast/events/context-no-deselect-expected.txt: Copied from LayoutTests/platform/mac/fast/events/context-no-deselect-expected.txt.
  • platform/mac-mavericks/fast/forms/001-expected.png: Copied from LayoutTests/platform/mac/fast/forms/001-expected.png.
  • platform/mac-mavericks/fast/forms/001-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/001-expected.txt.
  • platform/mac-mavericks/fast/forms/003-expected.png: Copied from LayoutTests/platform/mac/fast/forms/003-expected.png.
  • platform/mac-mavericks/fast/forms/003-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/003-expected.txt.
  • platform/mac-mavericks/fast/forms/004-expected.png: Copied from LayoutTests/platform/mac/fast/forms/004-expected.png.
  • platform/mac-mavericks/fast/forms/004-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/004-expected.txt.
  • platform/mac-mavericks/fast/forms/HTMLOptionElement_label01-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label01-expected.png.
  • platform/mac-mavericks/fast/forms/HTMLOptionElement_label01-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt.
  • platform/mac-mavericks/fast/forms/HTMLOptionElement_label02-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label02-expected.png.
  • platform/mac-mavericks/fast/forms/HTMLOptionElement_label02-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt.
  • platform/mac-mavericks/fast/forms/HTMLOptionElement_label03-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label03-expected.png.
  • platform/mac-mavericks/fast/forms/HTMLOptionElement_label04-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label04-expected.png.
  • platform/mac-mavericks/fast/forms/HTMLOptionElement_label04-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt.
  • platform/mac-mavericks/fast/forms/HTMLOptionElement_label05-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label05-expected.png.
  • platform/mac-mavericks/fast/forms/HTMLOptionElement_label05-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt.
  • platform/mac-mavericks/fast/forms/basic-buttons-expected.png: Copied from LayoutTests/platform/mac/fast/forms/basic-buttons-expected.png.
  • platform/mac-mavericks/fast/forms/basic-buttons-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-buttons-expected.txt.
  • platform/mac-mavericks/fast/forms/basic-inputs-expected.png: Copied from LayoutTests/platform/mac/fast/forms/basic-inputs-expected.png.
  • platform/mac-mavericks/fast/forms/basic-inputs-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-inputs-expected.txt.
  • platform/mac-mavericks/fast/forms/basic-selects-expected.png: Copied from LayoutTests/platform/mac/fast/forms/basic-selects-expected.png.
  • platform/mac-mavericks/fast/forms/basic-selects-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-selects-expected.txt.
  • platform/mac-mavericks/fast/forms/basic-textareas-expected.png: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-expected.png.
  • platform/mac-mavericks/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt.
  • platform/mac-mavericks/fast/forms/basic-textareas-quirks-expected.png: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.png.
  • platform/mac-mavericks/fast/forms/basic-textareas-quirks-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt.
  • platform/mac-mavericks/fast/forms/blankbuttons-expected.png: Copied from LayoutTests/platform/mac/fast/forms/blankbuttons-expected.png.
  • platform/mac-mavericks/fast/forms/blankbuttons-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/blankbuttons-expected.txt.
  • platform/mac-mavericks/fast/forms/box-shadow-override-expected.png: Copied from LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.png.
  • platform/mac-mavericks/fast/forms/box-shadow-override-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.txt.
  • platform/mac-mavericks/fast/forms/button-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-align-expected.png.
  • platform/mac-mavericks/fast/forms/button-cannot-be-nested-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-cannot-be-nested-expected.png.
  • platform/mac-mavericks/fast/forms/button-cannot-be-nested-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-cannot-be-nested-expected.txt.
  • platform/mac-mavericks/fast/forms/button-default-title-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-default-title-expected.png.
  • platform/mac-mavericks/fast/forms/button-default-title-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-default-title-expected.txt.
  • platform/mac-mavericks/fast/forms/button-generated-content-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-generated-content-expected.png.
  • platform/mac-mavericks/fast/forms/button-generated-content-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-generated-content-expected.txt.
  • platform/mac-mavericks/fast/forms/button-positioned-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.png.
  • platform/mac-mavericks/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
  • platform/mac-mavericks/fast/forms/button-sizes-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.png.
  • platform/mac-mavericks/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
  • platform/mac-mavericks/fast/forms/button-style-color-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-style-color-expected.png.
  • platform/mac-mavericks/fast/forms/button-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-style-color-expected.txt.
  • platform/mac-mavericks/fast/forms/button-table-styles-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-table-styles-expected.png.
  • platform/mac-mavericks/fast/forms/button-table-styles-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-table-styles-expected.txt.
  • platform/mac-mavericks/fast/forms/button-text-transform-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-text-transform-expected.png.
  • platform/mac-mavericks/fast/forms/button-text-transform-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-text-transform-expected.txt.
  • platform/mac-mavericks/fast/forms/button-white-space-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-white-space-expected.png.
  • platform/mac-mavericks/fast/forms/button-white-space-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-white-space-expected.txt.
  • platform/mac-mavericks/fast/forms/control-clip-expected.png: Copied from LayoutTests/platform/mac/fast/forms/control-clip-expected.png.
  • platform/mac-mavericks/fast/forms/control-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-expected.txt.
  • platform/mac-mavericks/fast/forms/control-clip-overflow-expected.png: Copied from LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.png.
  • platform/mac-mavericks/fast/forms/control-clip-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.txt.
  • platform/mac-mavericks/fast/forms/control-restrict-line-height-expected.png: Copied from LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.png.
  • platform/mac-mavericks/fast/forms/control-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt.
  • platform/mac-mavericks/fast/forms/disabled-select-change-index-expected.png: Copied from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.png.
  • platform/mac-mavericks/fast/forms/disabled-select-change-index-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt.
  • platform/mac-mavericks/fast/forms/encoding-test-expected.png: Copied from LayoutTests/platform/mac/fast/forms/encoding-test-expected.png.
  • platform/mac-mavericks/fast/forms/encoding-test-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/encoding-test-expected.txt.
  • platform/mac-mavericks/fast/forms/fieldset-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/fieldset-align-expected.png.
  • platform/mac-mavericks/fast/forms/fieldset-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/fieldset-align-expected.txt.
  • platform/mac-mavericks/fast/forms/file/file-input-direction-expected.png: Copied from LayoutTests/platform/mac/fast/forms/file/file-input-direction-expected.png.
  • platform/mac-mavericks/fast/forms/file/file-input-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file/file-input-direction-expected.txt.
  • platform/mac-mavericks/fast/forms/file/file-input-disabled-expected.png: Copied from LayoutTests/platform/mac/fast/forms/file/file-input-disabled-expected.png.
  • platform/mac-mavericks/fast/forms/file/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file/file-input-disabled-expected.txt.
  • platform/mac-mavericks/fast/forms/file/input-file-re-render-expected.png: Copied from LayoutTests/platform/mac/fast/forms/file/input-file-re-render-expected.png.
  • platform/mac-mavericks/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file/input-file-re-render-expected.txt.
  • platform/mac-mavericks/fast/forms/floating-textfield-relayout-expected.png: Copied from LayoutTests/platform/mac/fast/forms/floating-textfield-relayout-expected.png.
  • platform/mac-mavericks/fast/forms/form-element-geometry-expected.png: Copied from LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.png.
  • platform/mac-mavericks/fast/forms/form-element-geometry-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt.
  • platform/mac-mavericks/fast/forms/formmove3-expected.png: Copied from LayoutTests/platform/mac/fast/forms/formmove3-expected.png.
  • platform/mac-mavericks/fast/forms/formmove3-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/formmove3-expected.txt.
  • platform/mac-mavericks/fast/forms/hidden-listbox-expected.png: Copied from LayoutTests/platform/mac/fast/forms/hidden-listbox-expected.png.
  • platform/mac-mavericks/fast/forms/hidden-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/hidden-listbox-expected.txt.
  • platform/mac-mavericks/fast/forms/input-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-align-expected.png.
  • platform/mac-mavericks/fast/forms/input-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-align-expected.txt.
  • platform/mac-mavericks/fast/forms/input-appearance-bkcolor-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-bkcolor-expected.png.
  • platform/mac-mavericks/fast/forms/input-appearance-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-bkcolor-expected.txt.
  • platform/mac-mavericks/fast/forms/input-appearance-default-bkcolor-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png.
  • platform/mac-mavericks/fast/forms/input-appearance-default-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt.
  • platform/mac-mavericks/fast/forms/input-appearance-disabled-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-disabled-expected.png.
  • platform/mac-mavericks/fast/forms/input-appearance-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-disabled-expected.txt.
  • platform/mac-mavericks/fast/forms/input-appearance-focus-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-focus-expected.png.
  • platform/mac-mavericks/fast/forms/input-appearance-focus-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-focus-expected.txt.
  • platform/mac-mavericks/fast/forms/input-appearance-height-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-height-expected.png.
  • platform/mac-mavericks/fast/forms/input-appearance-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-height-expected.txt.
  • platform/mac-mavericks/fast/forms/input-appearance-preventDefault-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.png.
  • platform/mac-mavericks/fast/forms/input-appearance-preventDefault-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.txt.
  • platform/mac-mavericks/fast/forms/input-appearance-readonly-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-readonly-expected.png.
  • platform/mac-mavericks/fast/forms/input-appearance-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-readonly-expected.txt.
  • platform/mac-mavericks/fast/forms/input-appearance-selection-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-selection-expected.png.
  • platform/mac-mavericks/fast/forms/input-appearance-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-selection-expected.txt.
  • platform/mac-mavericks/fast/forms/input-appearance-visibility-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-visibility-expected.png.
  • platform/mac-mavericks/fast/forms/input-appearance-visibility-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-visibility-expected.txt.
  • platform/mac-mavericks/fast/forms/input-appearance-width-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-width-expected.png.
  • platform/mac-mavericks/fast/forms/input-appearance-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-width-expected.txt.
  • platform/mac-mavericks/fast/forms/input-baseline-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-baseline-expected.png.
  • platform/mac-mavericks/fast/forms/input-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-baseline-expected.txt.
  • platform/mac-mavericks/fast/forms/input-button-sizes-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.png.
  • platform/mac-mavericks/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
  • platform/mac-mavericks/fast/forms/input-disabled-color-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.png.
  • platform/mac-mavericks/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
  • platform/mac-mavericks/fast/forms/input-double-click-selection-gap-bug-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png.
  • platform/mac-mavericks/fast/forms/input-double-click-selection-gap-bug-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt.
  • platform/mac-mavericks/fast/forms/input-field-text-truncated-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-field-text-truncated-expected.png.
  • platform/mac-mavericks/fast/forms/input-field-text-truncated-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-field-text-truncated-expected.txt.
  • platform/mac-mavericks/fast/forms/input-first-letter-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-first-letter-expected.png.
  • platform/mac-mavericks/fast/forms/input-placeholder-visibility-1-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-1-expected.png.
  • platform/mac-mavericks/fast/forms/input-placeholder-visibility-1-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt.
  • platform/mac-mavericks/fast/forms/input-placeholder-visibility-3-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-3-expected.png.
  • platform/mac-mavericks/fast/forms/input-placeholder-visibility-3-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt.
  • platform/mac-mavericks/fast/forms/input-readonly-autoscroll-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-autoscroll-expected.png.
  • platform/mac-mavericks/fast/forms/input-readonly-autoscroll-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-autoscroll-expected.txt.
  • platform/mac-mavericks/fast/forms/input-readonly-dimmed-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.png.
  • platform/mac-mavericks/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
  • platform/mac-mavericks/fast/forms/input-readonly-empty-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-empty-expected.png.
  • platform/mac-mavericks/fast/forms/input-readonly-empty-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-empty-expected.txt.
  • platform/mac-mavericks/fast/forms/input-spaces-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-spaces-expected.png.
  • platform/mac-mavericks/fast/forms/input-spaces-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-spaces-expected.txt.
  • platform/mac-mavericks/fast/forms/input-table-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-table-expected.png.
  • platform/mac-mavericks/fast/forms/input-table-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-table-expected.txt.
  • platform/mac-mavericks/fast/forms/input-text-click-inside-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-inside-expected.png.
  • platform/mac-mavericks/fast/forms/input-text-click-inside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-inside-expected.txt.
  • platform/mac-mavericks/fast/forms/input-text-click-outside-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-outside-expected.png.
  • platform/mac-mavericks/fast/forms/input-text-click-outside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-outside-expected.txt.
  • platform/mac-mavericks/fast/forms/input-text-double-click-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-double-click-expected.png.
  • platform/mac-mavericks/fast/forms/input-text-double-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-double-click-expected.txt.
  • platform/mac-mavericks/fast/forms/input-text-drag-down-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-drag-down-expected.png.
  • platform/mac-mavericks/fast/forms/input-text-drag-down-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-drag-down-expected.txt.
  • platform/mac-mavericks/fast/forms/input-text-option-delete-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-option-delete-expected.png.
  • platform/mac-mavericks/fast/forms/input-text-option-delete-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-option-delete-expected.txt.
  • platform/mac-mavericks/fast/forms/input-text-scroll-left-on-blur-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png.
  • platform/mac-mavericks/fast/forms/input-text-scroll-left-on-blur-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt.
  • platform/mac-mavericks/fast/forms/input-text-self-emptying-click-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-self-emptying-click-expected.png.
  • platform/mac-mavericks/fast/forms/input-text-self-emptying-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-self-emptying-click-expected.txt.
  • platform/mac-mavericks/fast/forms/input-text-word-wrap-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.png.
  • platform/mac-mavericks/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
  • platform/mac-mavericks/fast/forms/input-type-text-min-width-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-type-text-min-width-expected.png.
  • platform/mac-mavericks/fast/forms/input-type-text-min-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-type-text-min-width-expected.txt.
  • platform/mac-mavericks/fast/forms/input-value-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-value-expected.png.
  • platform/mac-mavericks/fast/forms/input-value-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-value-expected.txt.
  • platform/mac-mavericks/fast/forms/input-width-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-width-expected.png.
  • platform/mac-mavericks/fast/forms/input-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-width-expected.txt.
  • platform/mac-mavericks/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
  • platform/mac-mavericks/fast/forms/listbox-hit-test-zoomed-expected.png: Copied from LayoutTests/platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png.
  • platform/mac-mavericks/fast/forms/listbox-scrollbar-incremental-load-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-scrollbar-incremental-load-expected.txt.
  • platform/mac-mavericks/fast/forms/listbox-width-change-expected.png: Copied from LayoutTests/platform/mac/fast/forms/listbox-width-change-expected.png.
  • platform/mac-mavericks/fast/forms/listbox-width-change-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-width-change-expected.txt.
  • platform/mac-mavericks/fast/forms/menulist-clip-expected.png: Copied from LayoutTests/platform/mac/fast/forms/menulist-clip-expected.png.
  • platform/mac-mavericks/fast/forms/menulist-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-clip-expected.txt.
  • platform/mac-mavericks/fast/forms/menulist-deselect-update-expected.png: Copied from LayoutTests/platform/mac/fast/forms/menulist-deselect-update-expected.png.
  • platform/mac-mavericks/fast/forms/menulist-deselect-update-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-deselect-update-expected.txt.
  • platform/mac-mavericks/fast/forms/menulist-no-overflow-expected.png: Copied from LayoutTests/platform/mac/fast/forms/menulist-no-overflow-expected.png.
  • platform/mac-mavericks/fast/forms/menulist-no-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-no-overflow-expected.txt.
  • platform/mac-mavericks/fast/forms/menulist-option-wrap-expected.png: Copied from LayoutTests/platform/mac/fast/forms/menulist-option-wrap-expected.png.
  • platform/mac-mavericks/fast/forms/menulist-option-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-option-wrap-expected.txt.
  • platform/mac-mavericks/fast/forms/menulist-restrict-line-height-expected.png: Copied from LayoutTests/platform/mac/fast/forms/menulist-restrict-line-height-expected.png.
  • platform/mac-mavericks/fast/forms/menulist-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-restrict-line-height-expected.txt.
  • platform/mac-mavericks/fast/forms/menulist-style-color-expected.png: Copied from LayoutTests/platform/mac/fast/forms/menulist-style-color-expected.png.
  • platform/mac-mavericks/fast/forms/menulist-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-style-color-expected.txt.
  • platform/mac-mavericks/fast/forms/menulist-width-change-expected.png: Copied from LayoutTests/platform/mac/fast/forms/menulist-width-change-expected.png.
  • platform/mac-mavericks/fast/forms/menulist-width-change-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-width-change-expected.txt.
  • platform/mac-mavericks/fast/forms/minWidthPercent-expected.png: Copied from LayoutTests/platform/mac/fast/forms/minWidthPercent-expected.png.
  • platform/mac-mavericks/fast/forms/minWidthPercent-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/minWidthPercent-expected.txt.
  • platform/mac-mavericks/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-rtl-expected.png.
  • platform/mac-mavericks/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-rtl-expected.txt.
  • platform/mac-mavericks/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/mac-mavericks/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/mac-mavericks/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png.
  • platform/mac-mavericks/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt.
  • platform/mac-mavericks/fast/forms/option-script-expected.png: Copied from LayoutTests/platform/mac/fast/forms/option-script-expected.png.
  • platform/mac-mavericks/fast/forms/option-script-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/option-script-expected.txt.
  • platform/mac-mavericks/fast/forms/option-strip-whitespace-expected.png: Copied from LayoutTests/platform/mac/fast/forms/option-strip-whitespace-expected.png.
  • platform/mac-mavericks/fast/forms/option-strip-whitespace-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/option-strip-whitespace-expected.txt.
  • platform/mac-mavericks/fast/forms/option-text-clip-expected.png: Copied from LayoutTests/platform/mac/fast/forms/option-text-clip-expected.png.
  • platform/mac-mavericks/fast/forms/option-text-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/option-text-clip-expected.txt.
  • platform/mac-mavericks/fast/forms/placeholder-position-expected.png: Copied from LayoutTests/platform/mac/fast/forms/placeholder-position-expected.png.
  • platform/mac-mavericks/fast/forms/placeholder-position-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/placeholder-position-expected.txt.
  • platform/mac-mavericks/fast/forms/placeholder-pseudo-style-expected.png: Copied from LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.png.
  • platform/mac-mavericks/fast/forms/placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt.
  • platform/mac-mavericks/fast/forms/plaintext-mode-2-expected.png: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.png.
  • platform/mac-mavericks/fast/forms/plaintext-mode-2-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.txt.
  • platform/mac-mavericks/fast/forms/search-cancel-button-style-sharing-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search-cancel-button-style-sharing-expected.png.
  • platform/mac-mavericks/fast/forms/search-cancel-button-style-sharing-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt.
  • platform/mac-mavericks/fast/forms/search-display-none-cancel-button-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search-display-none-cancel-button-expected.png.
  • platform/mac-mavericks/fast/forms/search-display-none-cancel-button-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-display-none-cancel-button-expected.txt.
  • platform/mac-mavericks/fast/forms/search-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search-rtl-expected.png.
  • platform/mac-mavericks/fast/forms/search-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-rtl-expected.txt.
  • platform/mac-mavericks/fast/forms/search-styled-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search-styled-expected.png.
  • platform/mac-mavericks/fast/forms/search-styled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-styled-expected.txt.
  • platform/mac-mavericks/fast/forms/search-vertical-alignment-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search-vertical-alignment-expected.png.
  • platform/mac-mavericks/fast/forms/search-vertical-alignment-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-vertical-alignment-expected.txt.
  • platform/mac-mavericks/fast/forms/search/search-size-with-decorations-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search/search-size-with-decorations-expected.png.
  • platform/mac-mavericks/fast/forms/search/search-size-with-decorations-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search/search-size-with-decorations-expected.txt.
  • platform/mac-mavericks/fast/forms/searchfield-heights-expected.png: Copied from LayoutTests/platform/mac/fast/forms/searchfield-heights-expected.png.
  • platform/mac-mavericks/fast/forms/searchfield-heights-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/searchfield-heights-expected.txt.
  • platform/mac-mavericks/fast/forms/select-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-align-expected.png.
  • platform/mac-mavericks/fast/forms/select-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-align-expected.txt.
  • platform/mac-mavericks/fast/forms/select-background-none-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-background-none-expected.png.
  • platform/mac-mavericks/fast/forms/select-baseline-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-baseline-expected.png.
  • platform/mac-mavericks/fast/forms/select-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-baseline-expected.txt.
  • platform/mac-mavericks/fast/forms/select-block-background-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-block-background-expected.png.
  • platform/mac-mavericks/fast/forms/select-block-background-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-block-background-expected.txt.
  • platform/mac-mavericks/fast/forms/select-change-listbox-size-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-size-expected.png.
  • platform/mac-mavericks/fast/forms/select-change-listbox-size-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-size-expected.txt.
  • platform/mac-mavericks/fast/forms/select-change-listbox-to-popup-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-to-popup-expected.png.
  • platform/mac-mavericks/fast/forms/select-change-listbox-to-popup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt.
  • platform/mac-mavericks/fast/forms/select-change-popup-to-listbox-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.png.
  • platform/mac-mavericks/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
  • platform/mac-mavericks/fast/forms/select-disabled-appearance-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-disabled-appearance-expected.png.
  • platform/mac-mavericks/fast/forms/select-disabled-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-disabled-appearance-expected.txt.
  • platform/mac-mavericks/fast/forms/select-empty-option-height-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-empty-option-height-expected.png.
  • platform/mac-mavericks/fast/forms/select-item-background-clip-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-item-background-clip-expected.png.
  • platform/mac-mavericks/fast/forms/select-item-background-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-item-background-clip-expected.txt.
  • platform/mac-mavericks/fast/forms/select-list-box-with-height-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-list-box-with-height-expected.png.
  • platform/mac-mavericks/fast/forms/select-list-box-with-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-list-box-with-height-expected.txt.
  • platform/mac-mavericks/fast/forms/select-listbox-multiple-no-focusring-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.png.
  • platform/mac-mavericks/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt.
  • platform/mac-mavericks/fast/forms/select-overflow-scroll-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-overflow-scroll-expected.txt.
  • platform/mac-mavericks/fast/forms/select-overflow-scroll-inherited-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-overflow-scroll-inherited-expected.txt.
  • platform/mac-mavericks/fast/forms/select-selected-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.png.
  • platform/mac-mavericks/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
  • platform/mac-mavericks/fast/forms/select-writing-direction-natural-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-writing-direction-natural-expected.png.
  • platform/mac-mavericks/fast/forms/select-writing-direction-natural-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-writing-direction-natural-expected.txt.
  • platform/mac-mavericks/fast/forms/select/optgroup-rendering-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select/optgroup-rendering-expected.png.
  • platform/mac-mavericks/fast/forms/select/optgroup-rendering-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select/optgroup-rendering-expected.txt.
  • platform/mac-mavericks/fast/forms/stuff-on-my-optgroup-expected.png: Copied from LayoutTests/platform/mac/fast/forms/stuff-on-my-optgroup-expected.png.
  • platform/mac-mavericks/fast/forms/tabbing-input-iframe-expected.png: Copied from LayoutTests/platform/mac/fast/forms/tabbing-input-iframe-expected.png.
  • platform/mac-mavericks/fast/forms/tabbing-input-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/tabbing-input-iframe-expected.txt.
  • platform/mac-mavericks/fast/forms/targeted-frame-submission-expected.png: Copied from LayoutTests/platform/mac/fast/forms/targeted-frame-submission-expected.png.
  • platform/mac-mavericks/fast/forms/targeted-frame-submission-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/targeted-frame-submission-expected.txt.
  • platform/mac-mavericks/fast/forms/text-style-color-expected.png: Copied from LayoutTests/platform/mac/fast/forms/text-style-color-expected.png.
  • platform/mac-mavericks/fast/forms/text-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/text-style-color-expected.txt.
  • platform/mac-mavericks/fast/forms/textAreaLineHeight-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.png.
  • platform/mac-mavericks/fast/forms/textAreaLineHeight-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.txt.
  • platform/mac-mavericks/fast/forms/textarea-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-align-expected.png.
  • platform/mac-mavericks/fast/forms/textarea-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-align-expected.txt.
  • platform/mac-mavericks/fast/forms/textarea-placeholder-pseudo-style-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.png.
  • platform/mac-mavericks/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt.
  • platform/mac-mavericks/fast/forms/textarea-placeholder-visibility-1-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.png.
  • platform/mac-mavericks/fast/forms/textarea-placeholder-visibility-1-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt.
  • platform/mac-mavericks/fast/forms/textarea-placeholder-visibility-2-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.png.
  • platform/mac-mavericks/fast/forms/textarea-placeholder-visibility-2-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt.
  • platform/mac-mavericks/fast/forms/textarea-scroll-height-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-scroll-height-expected.png.
  • platform/mac-mavericks/fast/forms/textarea-scrollbar-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-scrollbar-expected.png.
  • platform/mac-mavericks/fast/forms/textarea-scrollbar-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-scrollbar-expected.txt.
  • platform/mac-mavericks/fast/forms/textarea-scrolled-type-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.png.
  • platform/mac-mavericks/fast/forms/textarea-scrolled-type-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.txt.
  • platform/mac-mavericks/fast/forms/textarea-setinnerhtml-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-setinnerhtml-expected.png.
  • platform/mac-mavericks/fast/forms/textarea-setinnerhtml-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-setinnerhtml-expected.txt.
  • platform/mac-mavericks/fast/forms/textfield-focus-ring-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textfield-focus-ring-expected.png.
  • platform/mac-mavericks/fast/forms/textfield-focus-ring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-focus-ring-expected.txt.
  • platform/mac-mavericks/fast/forms/textfield-outline-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textfield-outline-expected.png.
  • platform/mac-mavericks/fast/forms/textfield-outline-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-outline-expected.txt.
  • platform/mac-mavericks/fast/forms/textfield-overflow-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textfield-overflow-expected.png.
  • platform/mac-mavericks/fast/forms/textfield-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-overflow-expected.txt.
  • platform/mac-mavericks/fast/forms/validation-message-appearance-expected.png: Copied from LayoutTests/platform/mac/fast/forms/validation-message-appearance-expected.png.
  • platform/mac-mavericks/fast/forms/validation-message-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/validation-message-appearance-expected.txt.
  • platform/mac-mavericks/fast/forms/visual-hebrew-text-field-expected.png: Copied from LayoutTests/platform/mac/fast/forms/visual-hebrew-text-field-expected.png.
  • platform/mac-mavericks/fast/forms/visual-hebrew-text-field-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/visual-hebrew-text-field-expected.txt.
  • platform/mac-mavericks/fast/frames/take-focus-from-iframe-expected.png: Copied from LayoutTests/platform/mac/fast/frames/take-focus-from-iframe-expected.png.
  • platform/mac-mavericks/fast/frames/take-focus-from-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/take-focus-from-iframe-expected.txt.
  • platform/mac-mavericks/fast/hidpi/resize-corner-hidpi-expected.png: Copied from LayoutTests/platform/mac/fast/hidpi/resize-corner-hidpi-expected.png.
  • platform/mac-mavericks/fast/hidpi/resize-corner-hidpi-expected.txt: Copied from LayoutTests/platform/mac/fast/hidpi/resize-corner-hidpi-expected.txt.
  • platform/mac-mavericks/fast/html/details-no-summary4-expected.png: Copied from LayoutTests/platform/mac/fast/html/details-no-summary4-expected.png.
  • platform/mac-mavericks/fast/html/details-no-summary4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-no-summary4-expected.txt.
  • platform/mac-mavericks/fast/html/details-open-javascript-expected.png: Copied from LayoutTests/platform/mac/fast/html/details-open-javascript-expected.png.
  • platform/mac-mavericks/fast/html/details-open-javascript-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open-javascript-expected.txt.
  • platform/mac-mavericks/fast/html/details-open2-expected.png: Copied from LayoutTests/platform/mac/fast/html/details-open2-expected.png.
  • platform/mac-mavericks/fast/html/details-open2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open2-expected.txt.
  • platform/mac-mavericks/fast/html/details-open4-expected.png: Copied from LayoutTests/platform/mac/fast/html/details-open4-expected.png.
  • platform/mac-mavericks/fast/html/details-open4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open4-expected.txt.
  • platform/mac-mavericks/fast/html/details-replace-summary-child-expected.png: Copied from LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.png.
  • platform/mac-mavericks/fast/html/details-replace-summary-child-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.txt.
  • platform/mac-mavericks/fast/html/details-replace-text-expected.png: Copied from LayoutTests/platform/mac/fast/html/details-replace-text-expected.png.
  • platform/mac-mavericks/fast/html/details-replace-text-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-text-expected.txt.
  • platform/mac-mavericks/fast/html/keygen-expected.png: Copied from LayoutTests/platform/mac/fast/html/keygen-expected.png.
  • platform/mac-mavericks/fast/html/keygen-expected.txt: Copied from LayoutTests/platform/mac/fast/html/keygen-expected.txt.
  • platform/mac-mavericks/fast/images/image-controls-basic-expected.png: Copied from LayoutTests/platform/mac/fast/images/image-controls-basic-expected.png.
  • platform/mac-mavericks/fast/images/image-controls-basic-expected.txt: Copied from LayoutTests/platform/mac/fast/images/image-controls-basic-expected.txt.
  • platform/mac-mavericks/fast/lists/dynamic-marker-crash-expected.png: Copied from LayoutTests/platform/mac/fast/lists/dynamic-marker-crash-expected.png.
  • platform/mac-mavericks/fast/lists/dynamic-marker-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/lists/dynamic-marker-crash-expected.txt.
  • platform/mac-mavericks/fast/overflow/overflow-x-y-expected.png: Copied from LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.png.
  • platform/mac-mavericks/fast/overflow/overflow-x-y-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.txt.
  • platform/mac-mavericks/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Copied from LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png.
  • platform/mac-mavericks/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt.
  • platform/mac-mavericks/fast/overflow/scrollRevealButton-expected.png: Copied from LayoutTests/platform/mac/fast/overflow/scrollRevealButton-expected.png.
  • platform/mac-mavericks/fast/overflow/scrollRevealButton-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/scrollRevealButton-expected.txt.
  • platform/mac-mavericks/fast/parser/document-write-option-expected.png: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.png.
  • platform/mac-mavericks/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
  • platform/mac-mavericks/fast/parser/entity-comment-in-textarea-expected.png: Copied from LayoutTests/platform/mac/fast/parser/entity-comment-in-textarea-expected.png.
  • platform/mac-mavericks/fast/parser/entity-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/entity-comment-in-textarea-expected.txt.
  • platform/mac-mavericks/fast/parser/open-comment-in-textarea-expected.png: Copied from LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.png.
  • platform/mac-mavericks/fast/parser/open-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.txt.
  • platform/mac-mavericks/fast/repaint/control-clip-expected.png: Copied from LayoutTests/platform/mac/fast/repaint/control-clip-expected.png.
  • platform/mac-mavericks/fast/repaint/control-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/control-clip-expected.txt.
  • platform/mac-mavericks/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
  • platform/mac-mavericks/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt.
  • platform/mac-mavericks/fast/repaint/search-field-cancel-expected.png: Copied from LayoutTests/platform/mac/fast/repaint/search-field-cancel-expected.png.
  • platform/mac-mavericks/fast/repaint/search-field-cancel-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/search-field-cancel-expected.txt.
  • platform/mac-mavericks/fast/repaint/subtree-root-skipped-expected.png: Copied from LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.png.
  • platform/mac-mavericks/fast/repaint/subtree-root-skipped-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.txt.
  • platform/mac-mavericks/fast/replaced/replaced-breaking-expected.png: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.png.
  • platform/mac-mavericks/fast/replaced/replaced-breaking-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt.
  • platform/mac-mavericks/fast/replaced/replaced-breaking-mixture-expected.png: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-mixture-expected.png.
  • platform/mac-mavericks/fast/replaced/replaced-breaking-mixture-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt.
  • platform/mac-mavericks/fast/replaced/width100percent-button-expected.png: Copied from LayoutTests/platform/mac/fast/replaced/width100percent-button-expected.png.
  • platform/mac-mavericks/fast/replaced/width100percent-button-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/width100percent-button-expected.txt.
  • platform/mac-mavericks/fast/replaced/width100percent-menulist-expected.png: Copied from LayoutTests/platform/mac/fast/replaced/width100percent-menulist-expected.png.
  • platform/mac-mavericks/fast/replaced/width100percent-menulist-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/width100percent-menulist-expected.txt.
  • platform/mac-mavericks/fast/selectors/064-expected.png: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.png.
  • platform/mac-mavericks/fast/selectors/064-expected.txt: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.txt.
  • platform/mac-mavericks/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Copied from LayoutTests/platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.png.
  • platform/mac-mavericks/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt.
  • platform/mac-mavericks/fast/table/003-expected.png: Copied from LayoutTests/platform/mac/fast/table/003-expected.png.
  • platform/mac-mavericks/fast/table/003-expected.txt: Copied from LayoutTests/platform/mac/fast/table/003-expected.txt.
  • platform/mac-mavericks/fast/table/append-cells2-expected.png: Copied from LayoutTests/platform/mac/fast/table/append-cells2-expected.png.
  • platform/mac-mavericks/fast/table/append-cells2-expected.txt: Copied from LayoutTests/platform/mac/fast/table/append-cells2-expected.txt.
  • platform/mac-mavericks/fast/table/colspanMinWidth-expected.png: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-expected.png.
  • platform/mac-mavericks/fast/table/colspanMinWidth-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-expected.txt.
  • platform/mac-mavericks/fast/table/colspanMinWidth-vertical-expected.png: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.png.
  • platform/mac-mavericks/fast/table/colspanMinWidth-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.txt.
  • platform/mac-mavericks/fast/table/remove-td-display-none-expected.png: Copied from LayoutTests/platform/mac/fast/table/remove-td-display-none-expected.png.
  • platform/mac-mavericks/fast/table/remove-td-display-none-expected.txt: Copied from LayoutTests/platform/mac/fast/table/remove-td-display-none-expected.txt.
  • platform/mac-mavericks/fast/table/spanOverlapRepaint-expected.png: Copied from LayoutTests/platform/mac/fast/table/spanOverlapRepaint-expected.png.
  • platform/mac-mavericks/fast/table/spanOverlapRepaint-expected.txt: Copied from LayoutTests/platform/mac/fast/table/spanOverlapRepaint-expected.txt.
  • platform/mac-mavericks/fast/table/text-field-baseline-expected.png: Copied from LayoutTests/platform/mac/fast/table/text-field-baseline-expected.png.
  • platform/mac-mavericks/fast/table/text-field-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/table/text-field-baseline-expected.txt.
  • platform/mac-mavericks/fast/text/atsui-rtl-override-selection-expected.png: Copied from LayoutTests/platform/mac/fast/text/atsui-rtl-override-selection-expected.png.
  • platform/mac-mavericks/fast/text/atsui-rtl-override-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/text/atsui-rtl-override-selection-expected.txt.
  • platform/mac-mavericks/fast/text/backslash-to-yen-sign-euc-expected.png: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png.
  • platform/mac-mavericks/fast/text/backslash-to-yen-sign-euc-expected.txt: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt.
  • platform/mac-mavericks/fast/text/backslash-to-yen-sign-expected.txt: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-expected.txt.
  • platform/mac-mavericks/fast/text/complex-text-opacity-expected.png: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png.
  • platform/mac-mavericks/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.txt.
  • platform/mac-mavericks/fast/text/drawBidiText-expected.png: Copied from LayoutTests/platform/mac/fast/text/drawBidiText-expected.png.
  • platform/mac-mavericks/fast/text/drawBidiText-expected.txt: Copied from LayoutTests/platform/mac/fast/text/drawBidiText-expected.txt.
  • platform/mac-mavericks/fast/text/emphasis-expected.txt: Copied from LayoutTests/platform/mac/fast/text/emphasis-expected.txt.
  • platform/mac-mavericks/fast/text/fallback-traits-fixup-expected.txt: Copied from LayoutTests/platform/mac/fast/text/fallback-traits-fixup-expected.txt.
  • platform/mac-mavericks/fast/text/indic-expected.txt: Copied from LayoutTests/platform/mac/fast/text/indic-expected.txt.
  • platform/mac-mavericks/fast/text/international/003-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/003-expected.txt.
  • platform/mac-mavericks/fast/text/international/bidi-listbox-atsui-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-listbox-atsui-expected.png.
  • platform/mac-mavericks/fast/text/international/bidi-listbox-atsui-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt.
  • platform/mac-mavericks/fast/text/international/bidi-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-listbox-expected.txt.
  • platform/mac-mavericks/fast/text/international/bidi-menulist-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-menulist-expected.txt.
  • platform/mac-mavericks/fast/text/international/bidi-mirror-he-ar-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png.
  • platform/mac-mavericks/fast/text/international/bidi-mirror-he-ar-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt.
  • platform/mac-mavericks/fast/text/international/bold-bengali-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bold-bengali-expected.txt.
  • platform/mac-mavericks/fast/text/international/complex-character-based-fallback-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/complex-character-based-fallback-expected.png.
  • platform/mac-mavericks/fast/text/international/complex-character-based-fallback-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/complex-character-based-fallback-expected.txt.
  • platform/mac-mavericks/fast/text/international/danda-space-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/danda-space-expected.png.
  • platform/mac-mavericks/fast/text/international/danda-space-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/danda-space-expected.txt.
  • platform/mac-mavericks/fast/text/international/hindi-whitespace-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/hindi-whitespace-expected.png.
  • platform/mac-mavericks/fast/text/international/hindi-whitespace-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/hindi-whitespace-expected.txt.
  • platform/mac-mavericks/fast/text/international/khmer-selection-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/khmer-selection-expected.png.
  • platform/mac-mavericks/fast/text/international/khmer-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/khmer-selection-expected.txt.
  • platform/mac-mavericks/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png.
  • platform/mac-mavericks/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
  • platform/mac-mavericks/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/synthesized-italic-vertical-latin-expected.txt.
  • platform/mac-mavericks/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png.
  • platform/mac-mavericks/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt.
  • platform/mac-mavericks/fast/text/international/wrap-CJK-001-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/wrap-CJK-001-expected.txt.
  • platform/mac-mavericks/fast/text/justify-ideograph-complex-expected.txt: Copied from LayoutTests/platform/mac/fast/text/justify-ideograph-complex-expected.txt.
  • platform/mac-mavericks/fast/text/justify-ideograph-simple-expected.txt: Copied from LayoutTests/platform/mac/fast/text/justify-ideograph-simple-expected.txt.
  • platform/mac-mavericks/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/text/justify-ideograph-vertical-expected.txt.
  • platform/mac-mavericks/fast/text/khmer-lao-font-expected.txt: Copied from LayoutTests/platform/mac/fast/text/khmer-lao-font-expected.txt.
  • platform/mac-mavericks/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Copied from LayoutTests/platform/mac/fast/text/midword-break-before-surrogate-pair-2-expected.txt.
  • platform/mac-mavericks/fast/text/textIteratorNilRenderer-expected.png: Copied from LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.png.
  • platform/mac-mavericks/fast/text/textIteratorNilRenderer-expected.txt: Copied from LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.txt.
  • platform/mac-mavericks/fast/text/updateNewFont-expected.txt: Copied from LayoutTests/platform/mac/fast/text/updateNewFont-expected.txt.
  • platform/mac-mavericks/fast/transforms/transformed-focused-text-input-expected.png: Copied from LayoutTests/platform/mac/fast/transforms/transformed-focused-text-input-expected.png.
  • platform/mac-mavericks/fast/transforms/transformed-focused-text-input-expected.txt: Copied from LayoutTests/platform/mac/fast/transforms/transformed-focused-text-input-expected.txt.
  • platform/mac-mavericks/http/tests/navigation/javascriptlink-frames-expected.png: Copied from LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.png.
  • platform/mac-mavericks/http/tests/navigation/javascriptlink-frames-expected.txt: Copied from LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt.
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt.
  • platform/mac-mavericks/mathml/opentype/large-operators-expected.txt: Copied from LayoutTests/platform/mac/mathml/opentype/large-operators-expected.txt.
  • platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Copied from LayoutTests/platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt.
  • platform/mac-mavericks/mathml/opentype/vertical-expected.txt: Copied from LayoutTests/platform/mac/mathml/opentype/vertical-expected.txt.
  • platform/mac-mavericks/media/audio-controls-rendering-expected.png: Copied from LayoutTests/platform/mac/media/audio-controls-rendering-expected.png.
  • platform/mac-mavericks/media/audio-controls-rendering-expected.txt: Copied from LayoutTests/platform/mac/media/audio-controls-rendering-expected.txt.
  • platform/mac-mavericks/media/controls-strict-expected.png: Copied from LayoutTests/platform/mac/media/controls-strict-expected.png.
  • platform/mac-mavericks/media/controls-strict-expected.txt: Copied from LayoutTests/platform/mac/media/controls-strict-expected.txt.
  • platform/mac-mavericks/media/video-controls-rendering-expected.txt: Copied from LayoutTests/platform/mac/media/video-controls-rendering-expected.txt.
  • platform/mac-mavericks/media/video-display-toggle-expected.txt: Copied from LayoutTests/platform/mac/media/video-display-toggle-expected.txt.
  • platform/mac-mavericks/media/video-no-audio-expected.png: Copied from LayoutTests/platform/mac/media/video-no-audio-expected.png.
  • platform/mac-mavericks/media/video-no-audio-expected.txt: Copied from LayoutTests/platform/mac/media/video-no-audio-expected.txt.
  • platform/mac-mavericks/media/video-volume-slider-expected.txt: Copied from LayoutTests/platform/mac/media/video-volume-slider-expected.txt.
  • platform/mac-mavericks/platform/mac/editing/input/devanagari-ligature-expected.txt: Copied from LayoutTests/platform/mac/editing/input/devanagari-ligature-expected.txt.
  • platform/mac-mavericks/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Renamed from LayoutTests/platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt.
  • platform/mac-mavericks/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Renamed from LayoutTests/platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt.
  • platform/mac-mavericks/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt.
  • platform/mac-mavericks/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt.
  • platform/mac-mavericks/platform/mac/scrollbars/key-window-not-first-responder-expected.txt: Copied from LayoutTests/platform/mac/scrollbars/key-window-not-first-responder-expected.txt.
  • platform/mac-mavericks/plugins/mouse-click-plugin-clears-selection-expected.txt: Copied from LayoutTests/platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt.
  • platform/mac-mavericks/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png.
  • platform/mac-mavericks/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt.
  • platform/mac-mavericks/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png.
  • platform/mac-mavericks/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt.
  • platform/mac-mavericks/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png.
  • platform/mac-mavericks/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt.
  • platform/mac-mavericks/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png.
  • platform/mac-mavericks/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt.
  • platform/mac-mavericks/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png.
  • platform/mac-mavericks/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt.
  • platform/mac-mavericks/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png.
  • platform/mac-mavericks/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt.
  • platform/mac-mavericks/svg/custom/inline-svg-in-xhtml-expected.png: Copied from LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.png.
  • platform/mac-mavericks/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt.
  • platform/mac-mavericks/svg/hixie/mixed/003-expected.png: Copied from LayoutTests/platform/mac/svg/hixie/mixed/003-expected.png.
  • platform/mac-mavericks/svg/hixie/mixed/003-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/mixed/003-expected.txt.
  • platform/mac-mavericks/svg/text/bidi-text-query-expected.png: Copied from LayoutTests/platform/mac/svg/text/bidi-text-query-expected.png.
  • platform/mac-mavericks/svg/text/bidi-text-query-expected.txt: Copied from LayoutTests/platform/mac/svg/text/bidi-text-query-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug1188-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1188-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug12384-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug12384-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug138725-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug138725-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug18359-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug18359-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug24200-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug24200-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug2479-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug2479-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug28928-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug28928-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug29326-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug29326-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug30559-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug30559-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug30692-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug4382-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4382-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug4527-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug46368-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug46368-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug51037-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51037-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug51727-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51727-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug52505-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug52505-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug52506-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug52506-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug55545-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug55545-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug59354-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug59354-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug60749-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug60749-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug68912-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug68912-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug7342-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug7342-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug96334-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug96334-expected.txt.
  • platform/mac-mavericks/tables/mozilla/bugs/bug99948-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug99948-expected.txt.
  • platform/mac-mavericks/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt.
  • platform/mac-mavericks/tables/mozilla/core/margins-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/core/margins-expected.txt.
  • platform/mac-mavericks/tables/mozilla/dom/tableDom-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/dom/tableDom-expected.txt.
  • platform/mac-mavericks/tables/mozilla/other/move_row-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/other/move_row-expected.txt.
  • platform/mac-mavericks/tables/mozilla_expected_failures/bugs/bug1725-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt.
  • platform/mac-mavericks/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt.
  • platform/mac-mavericks/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt.
  • platform/mac-mavericks/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt.
  • platform/mac-mavericks/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt.
  • platform/mac-mavericks/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt.
  • platform/mac-mavericks/transforms/2d/hindi-rotated-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/hindi-rotated-expected.txt.
  • platform/mac-mavericks/transforms/2d/zoom-menulist-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/zoom-menulist-expected.txt.
  • platform/mac-mavericks/transforms/3d/general/perspective-non-layer-expected.txt: Copied from LayoutTests/platform/mac/transforms/3d/general/perspective-non-layer-expected.txt.
  • platform/mac-wk2/TestExpectations:
  • platform/mac-wk2/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt.
  • platform/mac/TestExpectations:
  • platform/mac/accessibility/aria-readonly-expected.txt:
  • platform/mac/accessibility/roles-exposed-expected.txt:
  • platform/mac/compositing/contents-opaque/control-layer-expected.txt:
  • platform/mac/compositing/fixed-image-loading-expected.txt: Copied from LayoutTests/platform/mac/compositing/contents-opaque/control-layer-expected.txt.
  • platform/mac/compositing/geometry/ancestor-overflow-change-expected.txt: Copied from LayoutTests/platform/mac/compositing/contents-opaque/control-layer-expected.txt.
  • platform/mac/compositing/geometry/composited-in-columns-expected.txt: Added.
  • platform/mac/compositing/rtl/rtl-fixed-expected.txt: Added.
  • platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
  • platform/mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/mac/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.png: Added.
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/mac/editing/input/devanagari-ligature-expected.txt:
  • platform/mac/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
  • platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/mac/editing/input/undo-grouping-on-text-insertion-expected.txt: Added.
  • platform/mac/editing/input/undo-grouping-on-text-insertion.html: Added.
  • platform/mac/editing/inserting/4960120-1-expected.png:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.png:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/pasteboard/4641033-expected.png:
  • platform/mac/editing/pasteboard/4806874-expected.png:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/4944770-1-expected.png:
  • platform/mac/editing/pasteboard/4944770-2-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.png:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.png:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.png:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.png:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.png:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4397952-expected.png:
  • platform/mac/editing/selection/4397952-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.png:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.png:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/5240265-expected.png:
  • platform/mac/editing/selection/caret-before-select-expected.png:
  • platform/mac/editing/selection/drag-select-1-expected.png:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/mac/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.png:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.png:
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.png:
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.png:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.png:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-box-expected.png:
  • platform/mac/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/editing/selection/selection-button-text-expected.png:
  • platform/mac/editing/selection/selection-button-text-expected.txt:
  • platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
  • platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.png:
  • platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt:
  • platform/mac/fast/block/margin-collapse/103-expected.png:
  • platform/mac/fast/block/margin-collapse/103-expected.txt:
  • platform/mac/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/mac/fast/css/continuationCrash-expected.png:
  • platform/mac/fast/css/continuationCrash-expected.txt:
  • platform/mac/fast/css/css2-system-fonts-expected.png:
  • platform/mac/fast/css/css2-system-fonts-expected.txt:
  • platform/mac/fast/css/font-family-pictograph-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.png:
  • platform/mac/fast/css/line-height-expected.png:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/mac/fast/css/resize-corner-tracking-expected.png:
  • platform/mac/fast/css/resize-corner-tracking-expected.txt: Added.
  • platform/mac/fast/css/rtl-ordering-expected.png:
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.png:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/css/text-transform-select-expected.png:
  • platform/mac/fast/css/text-transform-select-expected.txt:
  • platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/mac/fast/dom/isindex-001-expected.png:
  • platform/mac/fast/dom/isindex-001-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.png:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/dynamic/008-expected.png:
  • platform/mac/fast/dynamic/008-expected.txt:
  • platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.png:
  • platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.png:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/events/shadow-event-path-2-expected.txt: Added.
  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/001-expected.txt:
  • platform/mac/fast/forms/003-expected.png:
  • platform/mac/fast/forms/003-expected.txt:
  • platform/mac/fast/forms/004-expected.png:
  • platform/mac/fast/forms/004-expected.txt:
  • platform/mac/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/mac/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/mac/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/mac/fast/forms/HTMLOptionElement_label05-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt:
  • platform/mac/fast/forms/basic-buttons-expected.png:
  • platform/mac/fast/forms/basic-buttons-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.png:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/basic-selects-expected.png:
  • platform/mac/fast/forms/basic-selects-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac/fast/forms/blankbuttons-expected.png:
  • platform/mac/fast/forms/blankbuttons-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/button-align-expected.png:
  • platform/mac/fast/forms/button-cannot-be-nested-expected.png:
  • platform/mac/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/mac/fast/forms/button-default-title-expected.png:
  • platform/mac/fast/forms/button-default-title-expected.txt:
  • platform/mac/fast/forms/button-generated-content-expected.png:
  • platform/mac/fast/forms/button-generated-content-expected.txt:
  • platform/mac/fast/forms/button-positioned-expected.png:
  • platform/mac/fast/forms/button-positioned-expected.txt:
  • platform/mac/fast/forms/button-sizes-expected.png:
  • platform/mac/fast/forms/button-sizes-expected.txt:
  • platform/mac/fast/forms/button-style-color-expected.png:
  • platform/mac/fast/forms/button-style-color-expected.txt:
  • platform/mac/fast/forms/button-table-styles-expected.png:
  • platform/mac/fast/forms/button-table-styles-expected.txt:
  • platform/mac/fast/forms/button-text-transform-expected.png:
  • platform/mac/fast/forms/button-text-transform-expected.txt:
  • platform/mac/fast/forms/button-white-space-expected.png:
  • platform/mac/fast/forms/button-white-space-expected.txt:
  • platform/mac/fast/forms/control-clip-expected.png:
  • platform/mac/fast/forms/control-clip-expected.txt:
  • platform/mac/fast/forms/control-clip-overflow-expected.png:
  • platform/mac/fast/forms/control-clip-overflow-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/disabled-select-change-index-expected.png:
  • platform/mac/fast/forms/disabled-select-change-index-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.png:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/file/file-input-direction-expected.png:
  • platform/mac/fast/forms/file/file-input-direction-expected.txt:
  • platform/mac/fast/forms/file/file-input-disabled-expected.png:
  • platform/mac/fast/forms/file/file-input-disabled-expected.txt:
  • platform/mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/mac/fast/forms/file/input-file-re-render-expected.txt:
  • platform/mac/fast/forms/floating-textfield-relayout-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/formmove3-expected.png:
  • platform/mac/fast/forms/formmove3-expected.txt:
  • platform/mac/fast/forms/hidden-listbox-expected.png:
  • platform/mac/fast/forms/hidden-listbox-expected.txt:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.png:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.png:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.png:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.png:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.png:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.txt:
  • platform/mac/fast/forms/input-button-sizes-expected.png:
  • platform/mac/fast/forms/input-button-sizes-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-field-text-truncated-expected.png:
  • platform/mac/fast/forms/input-field-text-truncated-expected.txt:
  • platform/mac/fast/forms/input-first-letter-expected.png:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.png:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.png:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.png:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.png:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.png:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.png:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.png:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.png:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.png:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.png:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.png:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-type-text-min-width-expected.png:
  • platform/mac/fast/forms/input-type-text-min-width-expected.txt:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/input-width-expected.png:
  • platform/mac/fast/forms/input-width-expected.txt:
  • platform/mac/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/mac/fast/forms/listbox-bidi-align-expected.txt:
  • platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/mac/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
  • platform/mac/fast/forms/listbox-width-change-expected.png:
  • platform/mac/fast/forms/listbox-width-change-expected.txt:
  • platform/mac/fast/forms/menulist-clip-expected.png:
  • platform/mac/fast/forms/menulist-clip-expected.txt:
  • platform/mac/fast/forms/menulist-deselect-update-expected.png:
  • platform/mac/fast/forms/menulist-deselect-update-expected.txt:
  • platform/mac/fast/forms/menulist-no-overflow-expected.png:
  • platform/mac/fast/forms/menulist-no-overflow-expected.txt:
  • platform/mac/fast/forms/menulist-option-wrap-expected.png:
  • platform/mac/fast/forms/menulist-option-wrap-expected.txt:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/menulist-style-color-expected.png:
  • platform/mac/fast/forms/menulist-style-color-expected.txt:
  • platform/mac/fast/forms/menulist-width-change-expected.png:
  • platform/mac/fast/forms/menulist-width-change-expected.txt:
  • platform/mac/fast/forms/minWidthPercent-expected.png:
  • platform/mac/fast/forms/minWidthPercent-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.png:
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
  • platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/option-script-expected.png:
  • platform/mac/fast/forms/option-script-expected.txt:
  • platform/mac/fast/forms/option-strip-whitespace-expected.png:
  • platform/mac/fast/forms/option-strip-whitespace-expected.txt:
  • platform/mac/fast/forms/option-text-clip-expected.png:
  • platform/mac/fast/forms/option-text-clip-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.png:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.png:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/search/search-size-with-decorations-expected.png:
  • platform/mac/fast/forms/search/search-size-with-decorations-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.png:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-align-expected.png:
  • platform/mac/fast/forms/select-align-expected.txt:
  • platform/mac/fast/forms/select-background-none-expected.png:
  • platform/mac/fast/forms/select-baseline-expected.png:
  • platform/mac/fast/forms/select-baseline-expected.txt:
  • platform/mac/fast/forms/select-block-background-expected.png:
  • platform/mac/fast/forms/select-block-background-expected.txt:
  • platform/mac/fast/forms/select-change-listbox-size-expected.png:
  • platform/mac/fast/forms/select-change-listbox-size-expected.txt:
  • platform/mac/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/mac/fast/forms/select-change-popup-to-listbox-expected.png:
  • platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
  • platform/mac/fast/forms/select-disabled-appearance-expected.png:
  • platform/mac/fast/forms/select-disabled-appearance-expected.txt:
  • platform/mac/fast/forms/select-empty-option-height-expected.png:
  • platform/mac/fast/forms/select-item-background-clip-expected.png:
  • platform/mac/fast/forms/select-item-background-clip-expected.txt:
  • platform/mac/fast/forms/select-list-box-with-height-expected.png:
  • platform/mac/fast/forms/select-list-box-with-height-expected.txt:
  • platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.png:
  • platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
  • platform/mac/fast/forms/select-overflow-scroll-expected.txt:
  • platform/mac/fast/forms/select-overflow-scroll-inherited-expected.txt:
  • platform/mac/fast/forms/select-selected-expected.png:
  • platform/mac/fast/forms/select-selected-expected.txt:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/mac/fast/forms/select/optgroup-rendering-expected.png:
  • platform/mac/fast/forms/select/optgroup-rendering-expected.txt:
  • platform/mac/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/targeted-frame-submission-expected.png:
  • platform/mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/mac/fast/forms/text-style-color-expected.png:
  • platform/mac/fast/forms/text-style-color-expected.txt:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.txt:
  • platform/mac/fast/forms/textarea-align-expected.png:
  • platform/mac/fast/forms/textarea-align-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.png:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac/fast/forms/textarea-scrollbar-expected.png:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.png:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.png:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.png:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.png:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.png:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/hidpi/resize-corner-hidpi-expected.png:
  • platform/mac/fast/hidpi/resize-corner-hidpi-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.png:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.png:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open2-expected.png:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open4-expected.png:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-replace-summary-child-expected.png:
  • platform/mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/mac/fast/html/details-replace-text-expected.png:
  • platform/mac/fast/html/details-replace-text-expected.txt:
  • platform/mac/fast/html/keygen-expected.png:
  • platform/mac/fast/html/keygen-expected.txt:
  • platform/mac/fast/images/image-controls-basic-expected.png:
  • platform/mac/fast/images/image-controls-basic-expected.txt:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.png:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.txt:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/mac/fast/overflow/scrollRevealButton-expected.png:
  • platform/mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/mac/fast/parser/document-write-option-expected.png:
  • platform/mac/fast/parser/document-write-option-expected.txt:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.png:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/mac/fast/repaint/control-clip-expected.png:
  • platform/mac/fast/repaint/control-clip-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.png:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/repaint/selection-gap-fixed-child-expected.txt: Added.
  • platform/mac/fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
  • platform/mac/fast/repaint/subtree-root-skipped-expected.png:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/width100percent-button-expected.png:
  • platform/mac/fast/replaced/width100percent-button-expected.txt:
  • platform/mac/fast/replaced/width100percent-menulist-expected.png:
  • platform/mac/fast/replaced/width100percent-menulist-expected.txt:
  • platform/mac/fast/selectors/064-expected.png:
  • platform/mac/fast/selectors/064-expected.txt:
  • platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.png:
  • platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
  • platform/mac/fast/table/003-expected.png:
  • platform/mac/fast/table/003-expected.txt:
  • platform/mac/fast/table/append-cells2-expected.png:
  • platform/mac/fast/table/append-cells2-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.png:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/fast/table/remove-td-display-none-expected.png:
  • platform/mac/fast/table/remove-td-display-none-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.png:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.png:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/text/atsui-rtl-override-selection-expected.png:
  • platform/mac/fast/text/atsui-rtl-override-selection-expected.txt:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/mac/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/drawBidiText-expected.png:
  • platform/mac/fast/text/drawBidiText-expected.txt:
  • platform/mac/fast/text/emphasis-expected.txt:
  • platform/mac/fast/text/fallback-traits-fixup-expected.txt:
  • platform/mac/fast/text/indic-expected.txt:
  • platform/mac/fast/text/international/003-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-expected.txt:
  • platform/mac/fast/text/international/bidi-menulist-expected.txt:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac/fast/text/international/bold-bengali-expected.txt:
  • platform/mac/fast/text/international/complex-character-based-fallback-expected.png:
  • platform/mac/fast/text/international/complex-character-based-fallback-expected.txt:
  • platform/mac/fast/text/international/danda-space-expected.png:
  • platform/mac/fast/text/international/danda-space-expected.txt:
  • platform/mac/fast/text/international/hindi-whitespace-expected.png:
  • platform/mac/fast/text/international/hindi-whitespace-expected.txt:
  • platform/mac/fast/text/international/khmer-selection-expected.png:
  • platform/mac/fast/text/international/khmer-selection-expected.txt:
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/mac/fast/text/international/synthesized-italic-vertical-latin-expected.txt:
  • platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/mac/fast/text/justify-ideograph-complex-expected.txt:
  • platform/mac/fast/text/justify-ideograph-simple-expected.txt:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.txt:
  • platform/mac/fast/text/khmer-lao-font-expected.txt:
  • platform/mac/fast/text/midword-break-before-surrogate-pair-2-expected.txt:
  • platform/mac/fast/text/systemFont-expected.txt: Added.
  • platform/mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/text/updateNewFont-expected.txt:
  • platform/mac/fast/text/vertical-no-sideways-expected.txt: Added.
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt: Added.
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/mathml/opentype/large-operators-expected.txt:
  • platform/mac/mathml/opentype/munderover-window-resize-expected.png: Added.
  • platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.png: Added.
  • platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
  • platform/mac/mathml/opentype/vertical-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-strict-expected.png:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-no-audio-expected.png:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-volume-slider-expected.txt:
  • platform/mac/platform/mac/accessibility/form-control-value-settable-expected.txt: Removed.
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Removed.
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.
  • platform/mac/platform/mac/fast/text/systemFont-expected.txt: Removed.
  • platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.png: Removed.
  • platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt: Removed.
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/mac/scrollbars/key-window-not-first-responder-expected.txt:
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/svg/text/bidi-text-query-expected.png:
  • platform/mac/svg/text/bidi-text-query-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/mac/tables/mozilla/core/margins-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/mac/transforms/2d/hindi-rotated-expected.txt:
  • platform/mac/transforms/2d/zoom-menulist-expected.txt:
  • platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
7:05 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
5:49 AM Changeset in webkit [174584] by commit-queue@webkit.org
  • 11 edits
    7 deletes in trunk/Source/WebKit2

[SOUP] Remove custom URI schemes implementation
​https://bugs.webkit.org/show_bug.cgi?id=128169

Patch by Pascal Jacquemart <​p.jacquemart@samsung.com> on 2014-10-10
Reviewed by Carlos Garcia Campos.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/soup/WKAPICastSoup.h:
  • UIProcess/API/C/soup/WKContextSoup.cpp: Removed.
  • UIProcess/API/C/soup/WKSoupRequestManager.cpp: Removed.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveURIRequest): Deleted.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/soup/WebSoupRequestManagerClient.cpp: Removed.
  • UIProcess/soup/WebSoupRequestManagerProxy.cpp: Removed.
  • UIProcess/soup/WebSoupRequestManagerProxy.messages.in: Removed.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

  • WebProcess/soup/WebSoupRequestManager.cpp: Removed.
  • WebProcess/soup/WebSoupRequestManager.messages.in: Removed.
5:15 AM Changeset in webkit [174583] by zandobersek@gmail.com
  • 10 edits
    1 delete in trunk/Source/WebCore

Remove CrossThreadTask
​https://bugs.webkit.org/show_bug.cgi?id=137570

Reviewed by Darin Adler.

Replace uses of CrossThreadTask with C++11 lambdas. The initializations
of cross-thread copies are rather verbose at the moment, but should look
better once we can switch to using C++14 init capture for lambdas.

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):

  • WebCore.order:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CrossThreadTask.h: Removed.
  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailAccessControlCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::~MainThreadBridge): Deleted.
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Deleted.
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadDestroy): Deleted.
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCancel): Deleted.
(WebCore::workerGlobalScopeDidSendData): Deleted.
(WebCore::workerGlobalScopeDidReceiveResponse): Deleted.
(WebCore::workerGlobalScopeDidReceiveData): Deleted.
(WebCore::workerGlobalScopeDidFinishLoading): Deleted.
(WebCore::workerGlobalScopeDidFail): Deleted.
(WebCore::workerGlobalScopeDidFailAccessControlCheck): Deleted.
(WebCore::workerGlobalScopeDidFailRedirectCheck): Deleted.

  • loader/WorkerThreadableLoader.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeRequestFromCache):
(WebCore::MemoryCache::removeRequestFromSessionCaches):
(WebCore::MemoryCache::removeRequestFromCacheImpl): Deleted.
(WebCore::MemoryCache::removeRequestFromSessionCachesImpl): Deleted.
(WebCore::MemoryCache::crossThreadRemoveRequestFromCache): Deleted.
(WebCore::MemoryCache::crossThreadRemoveRequestFromSessionCaches): Deleted.

  • loader/cache/MemoryCache.h:
3:52 AM Changeset in webkit [174582] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

Fix perl scripts to run with env on Linux
​https://bugs.webkit.org/show_bug.cgi?id=137601

Patch by Adrien Destugues <​pulkomandy@gmail.com> on 2014-10-10
Reviewed by Csaba Osztrogonác.

Use of arguments in #! is nonstandard and does not behave the same on
different systems. Linux would look for an executable named "perl -w"
"use warnings;" does the same things in a more portable way.

  • Scripts/commit-log-editor:
  • Scripts/num-cpus:
  • Scripts/prepare-ChangeLog:
  • Scripts/run-launcher:
  • Scripts/svn-create-patch:
3:27 AM Changeset in webkit [174581] by zandobersek@gmail.com
  • 16 edits in trunk/Source/WebCore

Avoid defaulting to capture-by-value for C++11 lambdas in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=137565

Reviewed by Darin Adler.

C++11 lambas should avoid defaulting to capturing used variables by value as that
can lead to unintended captures that, in worst cases, result in lambdas that are
not self-contained and end up operating on dangling pointers.

Explicitly stating the variables that are to be copied by value can also serve as
a checklist of variables that are actually intented for use in the lambda body.

  • Modules/quota/StorageErrorCallback.cpp:

(WebCore::StorageErrorCallback::CallbackTask::CallbackTask):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::~Database):
(WebCore::Database::runTransaction):
(WebCore::Database::scheduleTransactionCallback):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):

  • Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::clear):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):

  • bindings/js/JSCallbackData.h:

(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):

  • bindings/js/JSDOMGlobalObjectTask.cpp:

(WebCore::JSGlobalObjectTask::JSGlobalObjectTask):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):

  • dom/StringCallback.cpp:

(WebCore::StringCallback::scheduleCallback):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::abort):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::postListenerTask):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
(WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::enqueueEvent):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):

3:25 AM Changeset in webkit [174580] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[jhbuild] We should be able to disable wiping on configuration change
​https://bugs.webkit.org/show_bug.cgi?id=137446

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-10-10
Reviewed by Csaba Osztrogonác.

The default behaviour isn't changed, wiping on configuration change feature can be disabled with
setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
or passing --no-wipe-on-change command line option.

  • Scripts/update-webkit-libs-jhbuild:
2:34 AM Changeset in webkit [174579] by zandobersek@gmail.com
  • 6 edits
    1 delete in trunk/Source/WebCore

Remove MainThreadTask
​https://bugs.webkit.org/show_bug.cgi?id=137563

Reviewed by Darin Adler.

Replace the remaining uses of MainThreadTask with C++11 lambdas.
Remove the MainThreadTask header from the build.

  • WebCore.order:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/MainThreadTask.h: Removed.
  • platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownloadManager::downloadThread):
(WebCore::CurlDownload::didReceiveHeader):
(WebCore::CurlDownload::didReceiveData):

2:21 AM Changeset in webkit [174578] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.6

Merge r174422 - [GTK] Make forwarding headers generation depend on source code
​https://bugs.webkit.org/show_bug.cgi?id=137394

Reviewed by Philippe Normand.

Source/WebKit2:

Only run generate-forwarding-headers.pl when source code changes
and use a different target for the symlinks.

  • PlatformGTK.cmake:

Tools:

  • TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
  • TestWebKitAPI/PlatformGTK.cmake: Only run

generate-forwarding-headers.pl when source code changes.

  • WebKitTestRunner/PlatformGTK.cmake: Ditto.
2:20 AM Changeset in webkit [174577] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r174326 - [GTK] Do not generate a symlink in derived sources for every header in WebCore/bindings/gobject
​https://bugs.webkit.org/show_bug.cgi?id=137389

Reviewed by Martin Robinson.

We only need a symlink for static sources that are included in
public generated headers, because they are added with as
<webkitdom/WebKitDOMFoo.h> so they need to be inside a webkitdom
directory. Also use proper targets and commands to create the
symlinks only when needed instead of for every build.

  • PlatformGTK.cmake:
2:19 AM Changeset in webkit [174576] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Tools

Merge r174310 - [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
​https://bugs.webkit.org/show_bug.cgi?id=137391

Reviewed by Martin Robinson.

Add a custom command to only re-generate
webkit2gtk-tests-resources.gresource when any of its dependencies changes.

  • TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2:16 AM Changeset in webkit [174575] by Carlos Garcia Campos
  • 5 edits
    2 deletes in releases/WebKitGTK/webkit-2.6/Source

Merge r174103 - [GTK] Move GtkPopupMenu implementation to WebPopupMenuProxyGtk
​https://bugs.webkit.org/show_bug.cgi?id=137193

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Remove GtkPopupMenu from platform.

  • PlatformGTK.cmake:
  • platform/gtk/GtkPopupMenu.cpp: Removed.
  • platform/gtk/GtkPopupMenu.h: Removed.

Source/WebKit2:

GtkPopupMenu was in platform only to have a common implementation to
be shared with WebKit1. Now that it's only used by
WebPopupMenuProxyGtk in WebKit2, we can simplify the code by
merging the implementation directly into WebPopupMenuProxyGtk.

  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk):
(WebKit::WebPopupMenuProxyGtk::~WebPopupMenuProxyGtk):
(WebKit::WebPopupMenuProxyGtk::populatePopupMenu):
(WebKit::WebPopupMenuProxyGtk::showPopupMenu):
(WebKit::WebPopupMenuProxyGtk::hidePopupMenu):
(WebKit::WebPopupMenuProxyGtk::typeAheadFind):
(WebKit::WebPopupMenuProxyGtk::resetTypeAheadFindState):
(WebKit::WebPopupMenuProxyGtk::selectItemCallback):
(WebKit::WebPopupMenuProxyGtk::keyPressEventCallback):

  • UIProcess/gtk/WebPopupMenuProxyGtk.h:

(WebKit::WebPopupMenuProxyGtk::setCurrentlySelectedMenuItem):

2:14 AM Changeset in webkit [174574] by Carlos Garcia Campos
  • 2 edits
    2 deletes in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r174059 - [GTK] Remove MainFrameScrollbarGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=137211

Reviewed by Philippe Normand.

This was only used by WebKit1.

  • PlatformGTK.cmake:
  • platform/gtk/MainFrameScrollbarGtk.cpp: Removed.
  • platform/gtk/MainFrameScrollbarGtk.h: Removed.
2:12 AM Changeset in webkit [174573] by Carlos Garcia Campos
  • 7 edits
    2 deletes in releases/WebKitGTK/webkit-2.6

Merge r174058 - [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=137209

Reviewed by Philippe Normand.

Source/WebCore:

IntPointGtk is unused and IntRectGtk is only required by GTK+2 and
only used when building with GTK+2 in GtkInputMethodFilter.cpp
that can be easily replaced.

  • PlatformGTK.cmake:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/gtk/IntPointGtk.cpp: Removed.
  • platform/graphics/gtk/IntRectGtk.cpp: Removed.
  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::setCursorRect):

Tools:

  • TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp

from the WebCore test sources.

1:40 AM Changeset in webkit [174572] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r174055 - Unreviewed. Move sources not using GTK+ from WebCorePlatformGTK_SOURCES to WebCore_SOURCES.

  • PlatformGTK.cmake:
1:39 AM Changeset in webkit [174571] by Carlos Garcia Campos
  • 1 edit
    1 move in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r174044 - Unreviewed. Move RenderThemeGtk.h from platform/gtk to rendering.

I forgot to move this file in r173111.

  • rendering/RenderThemeGtk.h: Renamed from Source/WebCore/platform/gtk/RenderThemeGtk.h.
1:38 AM Changeset in webkit [174570] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r174043 - [ATK] WebKitAccessibleWrapperAtk should not depend on GTK
​https://bugs.webkit.org/show_bug.cgi?id=137177

Reviewed by Martin Robinson.

It's used to get the web view widget, but there's no GtkWidget in
the web process and platformPageClient is always NULL.

  • PlatformGTK.cmake: Move accessibility sources to the WebCore

sources list.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkParentOfRootObject): Remove code to get view GtkWidget.

  • editing/atk/FrameSelectionAtk.cpp: Remove unneeded header include.
1:36 AM Changeset in webkit [174569] by Carlos Garcia Campos
  • 2 edits
    2 deletes in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r174042 - [GTK] Remove unused GtkPluginWidget
​https://bugs.webkit.org/show_bug.cgi?id=137176

Reviewed by Csaba Osztrogonác.

It was only used by WebKit1.

  • PlatformGTK.cmake:
  • platform/gtk/GtkPluginWidget.cpp: Removed.
  • platform/gtk/GtkPluginWidget.h: Removed.
1:34 AM Changeset in webkit [174568] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r174041 - [cairo] GraphicsContext should not depend on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=137175

Reviewed by Martin Robinson.

Remove the unused methods depending on GDK and simplify
GraphicsContext::drawFocusRing() using only cairo API.

  • PlatformGTK.cmake: Move GraphicsContextCairo.cpp to the webcore sources.
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawFocusRing): Iterate the rectangles
instead of creating a region for the rectangles and call gdk_cairo_region().
(WebCore::GraphicsContext::setGdkExposeEvent): Deleted.
(WebCore::GraphicsContext::gdkExposeEvent): Deleted.
(WebCore::GraphicsContext::gdkWindow): Deleted.

  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:

(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

1:32 AM Changeset in webkit [174567] by commit-queue@webkit.org
  • 14 edits
    1 copy
    5 adds in trunk

[ATK] Changing the mapping of ARIA rowheader and columnheader into respective ATK roles.
​https://bugs.webkit.org/show_bug.cgi?id=136150

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2014-10-10
Reviewed by Chris Fleizach.

Source/WebCore:

Expose ColumnHeaderRole and RowHeaderRole objects into ATK.

Test: accessibility/table-roles-hierarchy.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
Platforms based on ATK: added distinction of roles for the <th> elements.

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::determineAccessibilityRole):
Platforms based on ATK: the return value is determined in the ancestor.

  • accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
In addition to CellRole also included ColumnHeaderRole and RowHeaderRole.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):
Changing the mapping of ARIA rowheader and columnheader into respective ATK roles.
(getInterfaceMaskFromObject):
In addition to CellRole also included ColumnHeaderRole and RowHeaderRole.

LayoutTests:

Minor changes in the roles-exposed test to check the mapping of rowheader and columnheader.
As a result of changes in the code test also shows the changes for the <th> element.
Changes expectations so that they cover propoer mapping of RowHeaderRole and ColumnHeaderRole.

  • accessibility/aria-tables-expected.txt:
  • accessibility/roles-exposed.html:
  • accessibility/table-roles-hierarchy-expected.txt: Added.
  • accessibility/table-roles-hierarchy.html: Added.
  • platform/efl/accessibility/roles-exposed-expected.txt: Added.
  • platform/efl/accessibility/table-attributes-expected.txt:
  • platform/efl/accessibility/table-cells-expected.txt:
  • platform/efl/accessibility/table-detection-expected.txt:
  • platform/gtk/accessibility/roles-exposed-expected.txt: Added.
  • platform/gtk/accessibility/table-attributes-expected.txt:
  • platform/gtk/accessibility/table-cells-expected.txt:
  • platform/gtk/accessibility/table-sections-expected.txt:
  • platform/mac/accessibility/aria-tables-expected.txt: Copied from LayoutTests/accessibility/aria-tables-expected.txt.
  • platform/mac/accessibility/table-roles-hierarchy-expected.txt: Added.
1:22 AM Changeset in webkit [174566] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r174499 - [GTK] Use the PageLoadState observer also to monitor title and estimated load progress
​https://bugs.webkit.org/show_bug.cgi?id=136997

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView): Remove implementation of
didReceiveTitleForFrame, didStartProgress, didChangeProgress and
didFinishProgress.
(didReceiveTitleForFrame): Deleted.
(didChangeProgress): Deleted.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_estimated_load_progress): Return the value
directly from the PageLoadState object, since we don't need to
cache the value anymore.
(webkitWebViewSetTitle): Deleted.
(webkitWebViewSetEstimatedLoadProgress): Deleted.

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
1:03 AM Changeset in webkit [174565] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.6

Merge r174497 - Race condition with WebKitWebView:is-loading after starting page load
​https://bugs.webkit.org/show_bug.cgi?id=136692

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Use PageLoadState::Observer to update both is-loading and uri
properties, instead of manually update them. This ensures that our
web view is always in sync with the WebPageProxy so that
webkit_web_view_is_loading() returns true right after requesting
any load. We still need to manually set the is-loading property
only in the case where we delay the emission of the load-changed
signals when waiting for the main resource. The bahaviour is a bit
different but still consistent with what our API documentation says.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView): Remove
didSameDocumentNavigationForFrame implementation, since we are
already notified about the URL change by the PageLoadState::Observer.
(didSameDocumentNavigationForFrame): Deleted.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetIsLoading): No longer update the URI when
changing the is-loading property.
(webkitWebViewConstructed): Crate a PageLoadStateObserver and add
it to the PageLoadState.
(webkitWebViewDispose): Remove the PageLoadStateObserver from the PageLoadState.
(webkitWebViewEmitLoadChanged): Add isDelayedEvent parameter to
update the is-loading property accordingly when emitting the
delayed events.
(webkitWebViewEmitDelayedLoadEvents): Pass true as isDelayedEvent
parameter of webkitWebViewEmitLoadChanged().
(webkitWebViewLoadChanged): Pass false as isDelayedEvent parameter
of webkitWebViewEmitLoadChanged().
(webkitWebViewLoadFailed):
(webkitWebViewLoadFailedWithTLSErrors):
(webkitWebViewUpdateURI): Deleted.

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:

Tools:

  • TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:

(loadChangedCallback): Only check is-loading is false when load
has finished if the load didn't fail due to a cancellation.
(loadFailedCallback): Only check is-loading is false if the load
didn't fail due to a cancellation.

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::loadURI): Check is-loading is true and active URI is
the requested one rigth after requesting the load.
(WebViewTest::loadHtml): Ditto.
(WebViewTest::loadPlainText): Ditto.
(WebViewTest::loadBytes): Ditto.
(WebViewTest::loadRequest): Ditto.
(WebViewTest::loadAlternateHTML): Ditto.
(WebViewTest::goBack): Ditto.
(WebViewTest::goForward): Ditto.
(WebViewTest::goToBackForwardListItem): Ditto.

1:01 AM Changeset in webkit [174564] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r174507 - [X11] Plugin process crashes in NetscapePlugin::platformPostInitialize()
​https://bugs.webkit.org/show_bug.cgi?id=137426

Reviewed by Darin Adler.

For some reason flash crashes when NPP_GetValue is called with
NPPVpluginCancelSrcStream, but only in windowed mode. Not calling
NPP_GetValue and unconditionally loading the source URL in the
browser fixes the crash and plugins work normally. We can handle
this particular case with a new quirk.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::determineQuirks): Add
DoNotCancelSrcStreamInWindowedMode quirk if it's flash plugin.

  • Shared/Plugins/PluginQuirks.h: Add

DoNotCancelSrcStreamInWindowedMode quirk.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::shouldLoadSrcURL): Return early if plugin
is windowed and DoNotCancelSrcStreamInWindowedMode quirk is present.

Oct 9, 2014:

11:56 PM Changeset in webkit [174563] by Carlos Garcia Campos
  • 11 edits in trunk/Source/WebCore

MediaPlayer should use a reference for the MediaPlayerClient
​https://bugs.webkit.org/show_bug.cgi?id=137552

Reviewed by Darin Adler.

The MediaPlayer client is set on constructor by HTMLMediaElement
and cleared on HTMLMediaElement destructor that also frees the
MediaPlayer object. Since the client will never be null while the
MediaPlayer player is alive, we can use a reference and remove all
the unneeded null checks. The member has also been renamed to m_client.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::MediaPlayer):
(WebCore::MediaPlayer::~MediaPlayer):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::inMediaDocument):
(WebCore::MediaPlayer::currentPlaybackTargetIsWirelessChanged):
(WebCore::MediaPlayer::networkStateChanged):
(WebCore::MediaPlayer::readyStateChanged):
(WebCore::MediaPlayer::volumeChanged):
(WebCore::MediaPlayer::muteChanged):
(WebCore::MediaPlayer::timeChanged):
(WebCore::MediaPlayer::sizeChanged):
(WebCore::MediaPlayer::repaint):
(WebCore::MediaPlayer::durationChanged):
(WebCore::MediaPlayer::rateChanged):
(WebCore::MediaPlayer::playbackStateChanged):
(WebCore::MediaPlayer::firstVideoFrameAvailable):
(WebCore::MediaPlayer::characteristicChanged):
(WebCore::MediaPlayer::keyAdded):
(WebCore::MediaPlayer::keyError):
(WebCore::MediaPlayer::keyMessage):
(WebCore::MediaPlayer::keyNeeded):
(WebCore::MediaPlayer::referrer):
(WebCore::MediaPlayer::userAgent):
(WebCore::MediaPlayer::graphicsDeviceAdapter):
(WebCore::MediaPlayer::cachedResourceLoader):
(WebCore::MediaPlayer::addAudioTrack):
(WebCore::MediaPlayer::removeAudioTrack):
(WebCore::MediaPlayer::addTextTrack):
(WebCore::MediaPlayer::removeTextTrack):
(WebCore::MediaPlayer::addVideoTrack):
(WebCore::MediaPlayer::removeVideoTrack):
(WebCore::MediaPlayer::outOfBandTrackSources):
(WebCore::MediaPlayer::shouldWaitForResponseToAuthenticationChallenge):
(WebCore::MediaPlayer::handlePlaybackCommand):
(WebCore::MediaPlayer::sourceApplicationIdentifier):
(WebCore::MediaPlayer::doesHaveAttribute):
(WebCore::MediaPlayer::mediaPlayerNetworkInterfaceName):
(WebCore::MediaPlayer::getRawCookies):
(WebCore::MediaPlayer::setWirelessVideoPlaybackDisabled): Deleted.
(WebCore::MediaPlayer::audioSourceProvider): Deleted.
(WebCore::MediaPlayer::engineDescription): Deleted.
(WebCore::MediaPlayer::notifyTrackModeChanged): Deleted.
(WebCore::MediaPlayer::totalFrameDelay): Deleted.
(WebCore::MediaPlayerFactorySupport::callRegisterMediaEngine): Deleted.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayer::create):
(WebCore::MediaPlayer::platformVolumeConfigurationRequired):
(WebCore::MediaPlayer::client):
(WebCore::MediaPlayer::mediaPlayerClient): Deleted.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::preferredRenderingMode):
(WebCore::MediaPlayerPrivateAVFoundation::setUpVideoRendering):
(WebCore::MediaPlayerPrivateAVFoundation::prepareForRendering):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeDisplayLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeAudioRenderer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideoCaps):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::didEnd):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
(WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::prepareForRendering):
(WebCore::MediaPlayerPrivateQTKit::sawUnsupportedTracks):

11:45 PM Changeset in webkit [174562] by mihnea@adobe.com
  • 5 edits in trunk/Source/WebCore

[CSSRegions] Make RenderFlowThread::regionAtBlockOffset const
​https://bugs.webkit.org/show_bug.cgi?id=137555

Reviewed by David Hyatt.

Make the method const and remove autoGenerateRegionsToBlockOffset method as it
is not used by region-based multicolumn code. Also removed the RegionAutoGenerationPolicy
parameter in the process and the call sites. Make const some of the methods that call
regionAtBlockOffset.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent):
(WebCore::RenderFlowThread::pageLogicalTopForOffset):
(WebCore::RenderFlowThread::pageLogicalWidthForOffset):
(WebCore::RenderFlowThread::pageLogicalHeightForOffset):
(WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::computedRegionRangeForBox):

  • rendering/RenderFlowThread.h:
  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::regionAtBlockOffset):
(WebCore::RenderMultiColumnFlowThread::mapFromFlowToRegion):
(WebCore::RenderMultiColumnFlowThread::physicalTranslationFromFlowToRegion):
(WebCore::RenderMultiColumnFlowThread::autoGenerateRegionsToBlockOffset): Deleted.

  • rendering/RenderMultiColumnFlowThread.h:
11:21 PM Changeset in webkit [174561] by bshafiei@apple.com
  • 6 edits in tags/Safari-601.1.3/Source/WebCore

Roll out r174405. <rdar://problem/18603925>

11:13 PM Changeset in webkit [174560] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.3

New tag.

10:53 PM Changeset in webkit [174559] by commit-queue@webkit.org
  • 9 edits in trunk/Source/JavaScriptCore

Web Inspector: Remove unused generator code
​https://bugs.webkit.org/show_bug.cgi?id=137564

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-09
Reviewed by Brian Burg.

  • inspector/scripts/codegen/generate_backend_dispatcher_header.py:

(BackendDispatcherHeaderGenerator.generate_output): Deleted.

  • inspector/scripts/codegen/generate_backend_dispatcher_implementation.py:

(BackendDispatcherImplementationGenerator.generate_output):

  • inspector/scripts/codegen/generate_frontend_dispatcher_header.py:

(FrontendDispatcherHeaderGenerator.generate_output):

  • inspector/scripts/codegen/generate_frontend_dispatcher_implementation.py:

(FrontendDispatcherImplementationGenerator.generate_output):

  • inspector/scripts/codegen/generate_protocol_types_header.py:

(ProtocolTypesHeaderGenerator.generate_output):

  • inspector/scripts/codegen/generate_protocol_types_implementation.py:

(ProtocolTypesImplementationGenerator.generate_output):
inputFilename is now handled by the generic generator base class.

  • inspector/scripts/codegen/models.py:

(Framework.fromString):
(Frameworks):

  • inspector/scripts/generate-inspector-protocol-bindings.py:

The WTF framework is unused. Remove unexpected frameworks.

9:21 PM Changeset in webkit [174558] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for FontData subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137591

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for FontData subclasses.

No new tests, no behavior change.

  • platform/graphics/FontData.h:
  • platform/graphics/FontGlyphs.cpp:

(WebCore::FontGlyphs::releaseFontData):
(WebCore::FontGlyphs::determinePitch):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

  • platform/graphics/SegmentedFontData.h:

(isType):

  • platform/graphics/SimpleFontData.h:

(isType):

8:57 PM Changeset in webkit [174557] by Simon Fraser
  • 1 edit
    8 moves in trunk/LayoutTests

Rename some tests that oddly had -html.html suffixes.

  • platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-composited-expected.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-composited-html-expected.html.
  • platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-composited.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-composited-html.html.
  • platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity-expected.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity-html-expected.png.
  • platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity-html-expected.txt.
  • platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity-html.html.
  • platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed-expected.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed-html-expected.png.
  • platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed-html-expected.txt.
  • platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed-html.html.
8:50 PM Changeset in webkit [174556] by aestes@apple.com
  • 8 edits in trunk/Tools

Teach webkitpy about OS X Yosemite
​https://bugs.webkit.org/show_bug.cgi?id=137585

Reviewed by Simon Fraser.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo._determine_mac_version):

  • Scripts/webkitpy/common/system/platforminfo_unittest.py:

(TestPlatformInfo.test_os_version):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):

  • Scripts/webkitpy/port/builders.py:
  • Scripts/webkitpy/port/mac.py:

(MacPort):

  • Scripts/webkitpy/port/mac_unittest.py:

(test_versions):
(test_baseline_search_path):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.test_baseline_directory):
(TestRebaselineExpectations.test_rebaseline_expectations):

8:45 PM Changeset in webkit [174555] by rniwa@webkit.org
  • 5 edits in trunk/Websites/perf.webkit.org

New perf dashboard UI tries to fetch commits all the time
​https://bugs.webkit.org/show_bug.cgi?id=137592

Reviewed by Andreas Kling.

Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
no reported commits as they are all going to fail.

Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
of commits sorted chronologically by time.

  • public/include/manifest.php:
  • public/v2/app.js:

(App.CommitsViewerComponent.commitsChanged):

  • public/v2/data.js:

(FetchCommitsForTimeRange):
(FetchCommitsForTimeRange._cachedCommitsByRepository):

  • public/v2/manifest.js:

(App.Repository):

8:34 PM Changeset in webkit [174554] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Revert part of r174543 that broke grid layout tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::specifiedValueForGridTrackBreadth):

8:25 PM Changeset in webkit [174553] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Tweak some Mac test expectations.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
6:41 PM Changeset in webkit [174552] by Simon Fraser
  • 15 edits
    1 move
    2 adds
    1 delete in trunk/LayoutTests

Mac TestExpectations cleanup.

Re-enable tests that now pass. Mark skipped tests as [ Failure ] when possible,
and rebaseline some tests.

  • perf/nested-combined-selectors-expected.txt: Added.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
  • platform/mac/editing/spelling/autocorrection-delete-expected.txt:
  • platform/mac/editing/spelling/autocorrection-in-textarea-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt:
  • platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt:
  • platform/mac/editing/spelling/autocorrection-simple-expected.txt:
  • platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt:
  • platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt:
  • platform/mac/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Renamed from LayoutTests/platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt.
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-zoom-controls-expected.txt:
  • platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Removed.
5:53 PM Changeset in webkit [174551] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Skip webgl tests in the iOS Simulator.

  • platform/ios-simulator/TestExpectations:
5:53 PM Changeset in webkit [174550] by Simon Fraser
  • 2 edits
    95 adds in trunk/LayoutTests

iOS Simulator results for webaudio tests.

  • platform/ios-simulator/webaudio/*: Added
5:53 PM Changeset in webkit [174549] by Simon Fraser
  • 1 edit
    31 adds in trunk/LayoutTests

iOS Simulator results for webarchive tests.

  • platform/ios-simulator/webarchive/*: Added
5:53 PM Changeset in webkit [174548] by Simon Fraser
  • 1 edit
    3 adds in trunk/LayoutTests

iOS Simulator and generic results for userscripts tests.

  • platform/ios-simulator/userscripts/user-script-plugin-document-expected.txt: Added.
  • userscripts/script-run-at-end-expected.txt: Added.
5:53 PM Changeset in webkit [174547] by Simon Fraser
  • 1 edit
    19 adds in trunk/LayoutTests

iOS Simulator results (many of which are failures) for transitions tests.

  • platform/ios-simulator/transitions/*: Added
5:53 PM Changeset in webkit [174546] by Simon Fraser
  • 1 edit
    29 adds in trunk/LayoutTests

iOS Simulator results for transforms tests.

  • platform/ios-simulator/transforms/*: Added
5:53 PM Changeset in webkit [174545] by Simon Fraser
  • 1 edit
    948 adds in trunk/LayoutTests

iOS Simulator results for tables tests.

  • platform/ios-simulator/tables/*: Added
5:52 PM Changeset in webkit [174544] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Denote some crashing SVG tests.

  • platform/ios-simulator/TestExpectations:
5:19 PM Changeset in webkit [174543] by dino@apple.com
  • 3 edits
    2 adds in trunk

Computed style for clip is wrong with respect to auto
​https://bugs.webkit.org/show_bug.cgi?id=137567

Reviewed by Simon Fraser.

Source/WebCore:

Make sure that the computed style of clip returns the
correct value when the input is "auto", or in this
case "rect(auto, auto, auto, auto)". Before this
patch it returned "rect(0px, 0px, 0px, 0px)" which
was completely wrong.

Test: fast/css/computed-clip-with-auto-rect.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::autoOrZoomAdjustedValue): Helper function to make the correct keyword or length.
(WebCore::specifiedValueForGridTrackBreadth): It can use the helper too.
(WebCore::ComputedStyleExtractor::propertyValue): If the
top/right/bottom/left is "auto", add that identifier
to the output rectangle.

LayoutTests:

Test that an input of clip: rect(auto, auto, auto, auto)
is the same on the way out.

  • fast/css/computed-clip-with-auto-rect-expected.txt: Added.
  • fast/css/computed-clip-with-auto-rect.html: Added.
4:55 PM Changeset in webkit [174542] by Chris Dumez
  • 11 edits in trunk/Source/WebCore

Use RenderObject::firstChildSlow() / lastChildSlow() less
​https://bugs.webkit.org/show_bug.cgi?id=137573

Reviewed by Andreas Kling.

Use RenderObject::firstChildSlow() / lastChildSlow() less by using
tighter typing at call sites whenever possible to be able to call the
faster RenderElement::firstChild() / lastChild() instead.

This patch also uses more references instead of pointers when possible.

No new tests, no behavior change.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::firstChildIsInlineContinuation):
(WebCore::AccessibilityRenderObject::previousSibling):
(WebCore::lastChildHasContinuation):
(WebCore::AccessibilityRenderObject::nextSibling):

  • page/FrameView.cpp:

(WebCore::countRenderedCharactersInRenderObjectWithThreshold):
(WebCore::FrameView::renderedCharactersExceed):

  • rendering/RenderElement.h:
  • rendering/RenderRuby.cpp:

(WebCore::isAnonymousRubyInlineBlock):
(WebCore::isRubyBeforeBlock):
(WebCore::isRubyAfterBlock):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForForSubtree):
(WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements):
(WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap):

  • rendering/svg/SVGTextLayoutAttributesBuilder.h:
  • svg/SVGTextPositioningElement.cpp:

(WebCore::SVGTextPositioningElement::elementFromRenderer):

  • svg/SVGTextPositioningElement.h:
4:50 PM Changeset in webkit [174541] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for Win EWS bots.

  • testing/Internals.idl: Move enum declaration to the top of the file.
4:48 PM Changeset in webkit [174540] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Source/WebCore:
RenderMathMLUnderOver adds spacing to the child operator indefinitely when resizing the window.
​https://bugs.webkit.org/show_bug.cgi?id=137330

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2014-10-09
Reviewed by Darin Adler.

The layout for the <mundercover> math object happens in two separate passes. The first pass runs
the layout for the two children and then calculates the maximum child width. It then sets the
stretch size for the math operator child. And finally it runs the second layout pass by calling
the base class layout() function. The base class function then runs the layout for the children
rendering blocks. In the operator child function computePreferredLogicalWidths(), the stretch
size is used to adjust the width (or the height) of the operator. Then it adds the leading and
trailing spaces and the total will be the operator child width.

When resizing or zooming the window, the render objects are just invalidated but marked as 'needs-
Layout'. The problem is happening because the stretch size of the math operator is not reset
before running the layout. The old logical width (or height) of the the math operator child which
is equal to the stretch size plus the leading and trailing spaces for is compared with the glyph
size if the old logical width ( or height) is larger, it is set to be the stretch size. When it
is used again because of invalidation, new leading and trailing spaces are included in the new
logical width. So with every zooming-in or out or window resizing, new leading and trailing
spaces are added to the logical width of the math operator child or the math <munderober> object.

Ensure the stretch size of the math operator render object is reset before running its layout.
Running the layout means either the page is just loaded or it's invalidated which means, no
layout stall data should be used.

Test: mathml/opentype/munderover-window-resize.html

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::resetStretchSize):

  • rendering/mathml/RenderMathMLOperator.h:

resetStretchSize() sets the stretch size to its original value when the class is created.

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::layout):
Make sure the operator stretch size is reset before calling its layout. Also make sure the new
maximum stretch size to the operator objects that were invalid and needsLayout.

LayoutTests:
RenderMathMLUnderOver adds spacing to the child operator indefinitely when zooming or resizing the window.
​https://bugs.webkit.org/show_bug.cgi?id=137330

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2014-10-09
Reviewed by Darin Adler, Daniel Bates.

When the alignment is center, which is the common case for math, changing the size of
an object affects the position of this object also. We need to confirm that zooming or
resizing the window should not affect the rectangle of the over/under math object operator.

  • mathml/opentype/munderover-window-resize-expected.txt: Added.
  • mathml/opentype/munderover-window-resize.html: Added.

New test with many under and over math objects. After loading the page, the window is resized and
the view is zoomed in and out to make sure the layout of these under and over objects were not changed.

  • platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt:

This test was wrong because of the spacing issue. The page has two <mover> math objects at the beginning.
Each of them has an <mspace> child. The width of the first <mspace> is 1em while the width of the second
<mspace> is 2em. The font size is 10pt. So it is expected to have the first one 10 pixels and the second
to be 20 pixels. In the test, the width of the first is 22 and the width of the second is 32.
I do expect this test to fail on other platforms since they have the same mistake which is now fixed. I am
going to submit the mac expected version only and when it fails I am going to collect the result and submit
another patch for the other platforms expected files.

4:29 PM Changeset in webkit [174539] by dburkart@apple.com
  • 4 edits
    2 adds in trunk/Tools

Add Mac OS Yosemite dashboard support.

Rubber-stamped by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Yosemite@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4:16 PM Changeset in webkit [174538] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Add Babak to contributors.json and add historical email addresses for some contributors
​https://bugs.webkit.org/show_bug.cgi?id=137546

Reviewed by Christophe Dumez.

contributors.json is used to analyze historical commit data and change logs.

Add back historical email addresses for some contributors and also add Babak (Shafiei).

  • Scripts/webkitpy/common/config/contributors.json:
3:34 PM Changeset in webkit [174537] by dino@apple.com
  • 2 edits
    69 adds in trunk/LayoutTests

Import W3C @supports tests
​https://bugs.webkit.org/show_bug.cgi?id=137569
<rdar://problem/18601076>

Reviewed by Simon Fraser.

Import the tests from ​https://test.csswg.org/source/css-conditional-3/

We currently fail 2 tests, tracked in TestExpectations.

  • TestExpectations:
  • css3/conditional/w3c/LICENSE: Added.
  • css3/conditional/w3c/at-supports-001-expected.html: Added.
  • css3/conditional/w3c/at-supports-001.html: Added.
  • css3/conditional/w3c/at-supports-002-expected.html: Added.
  • css3/conditional/w3c/at-supports-002.html: Added.
  • css3/conditional/w3c/at-supports-003-expected.html: Added.
  • css3/conditional/w3c/at-supports-003.html: Added.
  • css3/conditional/w3c/at-supports-004-expected.html: Added.
  • css3/conditional/w3c/at-supports-004.html: Added.
  • css3/conditional/w3c/at-supports-005-expected.html: Added.
  • css3/conditional/w3c/at-supports-005.html: Added.
  • css3/conditional/w3c/at-supports-006-expected.html: Added.
  • css3/conditional/w3c/at-supports-006.html: Added.
  • css3/conditional/w3c/at-supports-007-expected.html: Added.
  • css3/conditional/w3c/at-supports-007.html: Added.
  • css3/conditional/w3c/at-supports-008-expected.html: Added.
  • css3/conditional/w3c/at-supports-008.html: Added.
  • css3/conditional/w3c/at-supports-009-expected.html: Added.
  • css3/conditional/w3c/at-supports-009.html: Added.
  • css3/conditional/w3c/at-supports-010-expected.html: Added.
  • css3/conditional/w3c/at-supports-010.html: Added.
  • css3/conditional/w3c/at-supports-011-expected.html: Added.
  • css3/conditional/w3c/at-supports-011.html: Added.
  • css3/conditional/w3c/at-supports-012-expected.html: Added.
  • css3/conditional/w3c/at-supports-012.html: Added.
  • css3/conditional/w3c/at-supports-013-expected.html: Added.
  • css3/conditional/w3c/at-supports-013.html: Added.
  • css3/conditional/w3c/at-supports-014-expected.html: Added.
  • css3/conditional/w3c/at-supports-014.html: Added.
  • css3/conditional/w3c/at-supports-015-expected.html: Added.
  • css3/conditional/w3c/at-supports-015.html: Added.
  • css3/conditional/w3c/at-supports-016-expected.html: Added.
  • css3/conditional/w3c/at-supports-016.html: Added.
  • css3/conditional/w3c/at-supports-017-expected.html: Added.
  • css3/conditional/w3c/at-supports-017.html: Added.
  • css3/conditional/w3c/at-supports-018-expected.html: Added.
  • css3/conditional/w3c/at-supports-018.html: Added.
  • css3/conditional/w3c/at-supports-019-expected.html: Added.
  • css3/conditional/w3c/at-supports-019.html: Added.
  • css3/conditional/w3c/at-supports-020-expected.html: Added.
  • css3/conditional/w3c/at-supports-020.html: Added.
  • css3/conditional/w3c/at-supports-021-expected.html: Added.
  • css3/conditional/w3c/at-supports-021.html: Added.
  • css3/conditional/w3c/at-supports-022-expected.html: Added.
  • css3/conditional/w3c/at-supports-022.html: Added.
  • css3/conditional/w3c/at-supports-023-expected.html: Added.
  • css3/conditional/w3c/at-supports-023.html: Added.
  • css3/conditional/w3c/at-supports-024-expected.html: Added.
  • css3/conditional/w3c/at-supports-024.html: Added.
  • css3/conditional/w3c/at-supports-025-expected.html: Added.
  • css3/conditional/w3c/at-supports-025.html: Added.
  • css3/conditional/w3c/at-supports-026-expected.html: Added.
  • css3/conditional/w3c/at-supports-026.html: Added.
  • css3/conditional/w3c/at-supports-027-expected.html: Added.
  • css3/conditional/w3c/at-supports-027.html: Added.
  • css3/conditional/w3c/at-supports-028-expected.html: Added.
  • css3/conditional/w3c/at-supports-028.html: Added.
  • css3/conditional/w3c/at-supports-029-expected.html: Added.
  • css3/conditional/w3c/at-supports-029.html: Added.
  • css3/conditional/w3c/at-supports-030-expected.html: Added.
  • css3/conditional/w3c/at-supports-030.html: Added.
  • css3/conditional/w3c/at-supports-031-expected.html: Added.
  • css3/conditional/w3c/at-supports-031.html: Added.
  • css3/conditional/w3c/at-supports-032-expected.html: Added.
  • css3/conditional/w3c/at-supports-032.html: Added.
  • css3/conditional/w3c/at-supports-033-expected.html: Added.
  • css3/conditional/w3c/at-supports-033.html: Added.
3:33 PM Changeset in webkit [174536] by dino@apple.com
  • 43 edits in trunk

Remove ENABLE_CSS3_CONDITIONAL_RULES
​https://bugs.webkit.org/show_bug.cgi?id=137571

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

We have good enough support for @supports that
it should be a consistent part of the platform. Remove
the compile-time guard.

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.exp.in:
  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJS):

  • bindings/objc/DOMCSS.mm:

(kitClass):

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSupportsCondition):
(WebCore::CSSParser::detectAtToken):
(WebCore::CSSParser::detectSupportsToken):
(WebCore::CSSParser::realLex):

  • css/CSSParser.h:
  • css/CSSRule.h:
  • css/CSSRule.idl:
  • css/CSSSupportsRule.cpp:
  • css/CSSSupportsRule.h:
  • css/CSSSupportsRule.idl:
  • css/DOMWindowCSS.cpp:
  • css/DOMWindowCSS.h:
  • css/DOMWindowCSS.idl:
  • css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collect):

  • css/RuleSet.cpp:

(WebCore::RuleSet::addChildRules):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleSupports::StyleRuleSupports):

  • css/StyleRule.h:

(WebCore::toStyleRuleSupports):

  • css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):

  • inspector/InspectorStyleSheet.cpp:

(flattenSourceData):
(WebCore::asCSSRuleList):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::css):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

LayoutTests:

Unskipping tests.

  • platform/ios-sim/Skipped:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
3:14 PM Changeset in webkit [174535] by benjamin@webkit.org
  • 29 edits
    28 adds
    2 deletes in trunk

Add the baseline implementation of :not(selectorList)
​https://bugs.webkit.org/show_bug.cgi?id=137548

Reviewed by Andreas Kling.

Source/WebCore:

This patch extend the pseudo class :not() to support the new definition
in CSS Selectors level 4.

Instead of supporting a single simple selector, :not() now support
an arbitrary selector list, excepted pseudo elements.

One side effect of this change is :visited and :link are no longer supported
inside :not(). The reason has to do with complexity and performance.
Since :not() and :matches() can have arbitrary selector list, keeping track of
:visited and :link can have many combination superposing, some valid, some invalid.

Supporting :visited and :link should be possible by chaning the way we handle
them for style resolution, but given the limited use cases for such features
I'll wait to see if there is any interest before changing everything.

This patch only covers SelectorChecker to keep things simple. The CSS JIT
will come later.

Tests: fast/css/not-basics.html

fast/css/parsing-css-not-1.html
fast/css/parsing-css-not-2.html
fast/css/parsing-css-not-3.html
fast/css/parsing-css-not-4.html
fast/css/parsing-css-not-5.html
fast/css/parsing-css-not-6.html
fast/css/parsing-css-not-7.html
fast/css/parsing-css-not-8.html
fast/css/parsing-css-not-9.html
fast/css/parsing-css-nth-child-of-4.html
fast/selectors/not-basics.html
fast/selectors/not-nested.html
fast/selectors/not-selector-list.html

  • css/CSSGrammar.y.in:

Rename selectorListDoesNotMatchAnyPseudoElement() to selectorListDoesNotMatchAnyPseudoElement()
since both :not() and :nth-child(An+B of selectorList) have the same requirements at the moment.

  • css/CSSParserValues.cpp:

(WebCore::selectorListMatchesPseudoElement):
The patch adding :matches() introduced the possibility of putting pseudo element
arbitrary deep in a sequence of nested :matches(). Since this case is forbidded
by :not() and :nth-child(An+B of selectorList), selectorListMatchesPseudoElement()
now becomes recursive to find those pseudo elements.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):
CSSOM for the extended :not().

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::determineLinkMatchType):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
Disable the new capabilities from the JIT for now.

LayoutTests:

There are 3 big kind of changes to the tests:
1) The new implementation intentionally breaks :not() of :visited and :link.

Some test for the basic :not(:link) and :not(:visited) are consequently failing.

2) Some tests were ensuring that :not() only support simple selectors, those are

becoming irrelevant.

3) New test for the feature.

This patch intentionally breaks :not(:link). The test fast/history/link-inside-not.html
time out since it is waiting for the link to match.

  • fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Removed.
  • fast/css/invalid-not-with-simple-selector-sequence.html: Removed.

This test originally came from IEtestcenter. None of it is useful, all the "invalid"
cases are now fully functional selectors.

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:

Parsing and CSS OM tests for the new :not().

  • fast/css/parsing-css-matches-5-expected.txt:
  • fast/css/parsing-css-matches-5.html:
  • fast/css/parsing-css-matches-6-expected.txt:
  • fast/css/parsing-css-matches-6.html:
  • fast/css/parsing-css-matches-7-expected.txt:
  • fast/css/parsing-css-matches-7.html:
  • fast/css/parsing-css-matches-8-expected.txt:
  • fast/css/parsing-css-matches-8.html:

Update the tests of :matches() to account for the extended :not().

  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt:

Some cases covered by this test are now valid. The test is kept as is for
its historical value, but all the FAIL cover valid use cases in Level 4.

  • platform/mac/css3/selectors3/html/css3-modsel-61-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-83-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-61-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-83-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-61-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-83-expected.txt:
  • platform/mac/fast/selectors/061-expected.txt:
  • platform/mac/fast/selectors/083-expected.txt:

Those tests are changing because of the breakage of :link and :visited.

  • fast/css/not-basics-expected.html: Added.
  • fast/css/not-basics.html: Added.

Basic use cases of the extended :not() that should always style correctly.

  • fast/css/parsing-css-not-1-expected.txt: Added.
  • fast/css/parsing-css-not-1.html: Added.
  • fast/css/parsing-css-not-2-expected.txt: Added.
  • fast/css/parsing-css-not-2.html: Added.
  • fast/css/parsing-css-not-3-expected.txt: Added.
  • fast/css/parsing-css-not-3.html: Added.
  • fast/css/parsing-css-not-4-expected.txt: Added.
  • fast/css/parsing-css-not-4.html: Added.
  • fast/css/parsing-css-not-5-expected.txt: Added.
  • fast/css/parsing-css-not-5.html: Copied from LayoutTests/fast/css/parsing-css-matches-5.html.
  • fast/css/parsing-css-not-6-expected.txt: Added.
  • fast/css/parsing-css-not-6.html: Copied from LayoutTests/fast/css/parsing-css-matches-6.html.
  • fast/css/parsing-css-not-7-expected.txt: Copied from LayoutTests/fast/css/parsing-css-matches-7-expected.txt.
  • fast/css/parsing-css-not-7.html: Copied from LayoutTests/fast/css/parsing-css-matches-7.html.
  • fast/css/parsing-css-not-8-expected.txt: Copied from LayoutTests/fast/css/parsing-css-matches-8-expected.txt.
  • fast/css/parsing-css-not-8.html: Copied from LayoutTests/fast/css/parsing-css-matches-8.html.
  • fast/css/parsing-css-not-9-expected.txt: Added.
  • fast/css/parsing-css-not-9.html: Copied from LayoutTests/fast/css/parsing-css-matches-8.html.

Parsing of :not(). A lot of them were inspired by Yusuke Suzuki's test suite
for :matches(). A lot of test case apply to :not(), the main difference is that
pseudo elements must fail inside :not().

  • fast/css/parsing-css-nth-child-of-4-expected.txt: Added.
  • fast/css/parsing-css-nth-child-of-4.html: Added.

With the introduction of :matches(), it is possible to have arbitrarily deep pseudo elements.
The tests for :not() cover the case fixed with this patch, this addition covers :nth-child(of).

  • fast/selectors/not-basics-expected.txt: Added.
  • fast/selectors/not-basics.html: Added.
  • fast/selectors/not-nested-expected.txt: Added.
  • fast/selectors/not-nested.html: Added.
  • fast/selectors/not-selector-list-expected.txt: Added.
  • fast/selectors/not-selector-list.html: Added.

Test coverage for the new features.

3:09 PM Changeset in webkit [174534] by Lucas Forschler
  • 2 edits in trunk/Tools

Add Mac OS Yosemite webkit build infrastructure.

This patch adds 15 bots to our build.webkit.org configuration.
We are matching the current Mavericks machines 1:1.

This patch includes some minor spacing changes to the buildslaves section to make everything similar.

Reviewed by Matt Hanson.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
2:42 PM Changeset in webkit [174533] by Simon Fraser
  • 1 edit
    899 adds in trunk/LayoutTests

iOS Simulator results for svg tests.

  • platform/ios-simulator/svg/*: Added
2:42 PM Changeset in webkit [174532] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Skip some storage tests for iOS Simulator.

  • platform/ios-simulator/TestExpectations:
2:42 PM Changeset in webkit [174531] by Simon Fraser
  • 1 edit
    5 adds in trunk/LayoutTests

iOS Simulator results for sputnkik tests.

  • platform/ios-simulator/sputnkik/*: Added
2:42 PM Changeset in webkit [174530] by Simon Fraser
  • 1 edit
    2 adds in trunk/LayoutTests

iOS Simulator results for security tests.

  • platform/ios-simulator/security/*: Added
2:42 PM Changeset in webkit [174529] by Simon Fraser
  • 1 edit
    3 adds in trunk/LayoutTests

iOS Simulator results for scrollingcoordinator tests.

  • platform/ios-simulator/scrollingcoordinator/*: Added
2:42 PM Changeset in webkit [174528] by Simon Fraser
  • 2 edits
    10 adds in trunk/LayoutTests

iOS Simulator results for scrollbars tests.

  • platform/ios-simulator/scrollbars/*: Added
2:42 PM Changeset in webkit [174527] by Simon Fraser
  • 1 edit
    13 adds in trunk/LayoutTests

iOS Simulator results for mathml tests.

  • platform/ios-simulator/mathml/*: Added
2:10 PM Changeset in webkit [174526] by dburkart@apple.com
  • 2 edits in trunk/Tools

Don't use backticks when running commands, as we run into sh-related
interpolation issues. Also, fix our usage of system() to properly
retrieve the status code.
​https://bugs.webkit.org/show_bug.cgi?id=137541

Reviewed by Darin Adler.

  • Scripts/git-add-reviewer:

(interactive):
(nonInteractive):
(requireCleanWorkTree):
(cherryPick):
(commit):
(addReviewerToFile):
(head):
(isAncestor):
(toCommit):
(changeLogsForCommit):
(resetToCommit):
(getConfigValue):
(runCommandWithOutput):

1:56 PM Changeset in webkit [174525] by timothy_horton@apple.com
  • 7 edits in trunk

Add a WebKit1 preference for selection services
​https://bugs.webkit.org/show_bug.cgi?id=137498
<rdar://problem/18572699>

Reviewed by Simon Fraser.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences serviceControlsEnabled]):
(-[WebPreferences setServiceControlsEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Add and plumb the preference.

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController awakeFromNib]):
Turn on image and selection services in the Legacy WebKit MiniBrowser.

1:53 PM Changeset in webkit [174524] by timothy_horton@apple.com
  • 21 edits
    2 adds
    2 deletes in trunk/Source

Move ServicesOverlayController to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=137416
<rdar://problem/18546283>

Reviewed by Anders Carlsson.

Move ServicesOverlayController from WebKit2 to WebCore, as it can be used by both Legacy WebKit and WebKit2.

  • Platform/Logging.h:

Move Services logging channel to WebCore.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::handleTelephoneNumberClick):
(WebKit::WebChromeClient::handleSelectionServiceClick):
(WebKit::WebChromeClient::hasRelevantSelectionServices):
Implement services-related ChromeClient callbacks.
Clicks are forwarded to WebPageMac where they do what they used to;
hasRelevantSelectionServices is implemented as it was when it lived
inside ServicesOverlayController.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::selectedTelephoneNumberRangesChanged): Deleted.
(WebKit::WebEditorClient::selectionRectsDidChange): Deleted.

  • WebProcess/WebCoreSupport/WebEditorClient.h:

Remove WebEditorClient overrides for now-removed functions.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
Forward serviceControlsEnabled setting to WebCore.

(WebKit::WebPage::servicesOverlayController): Deleted.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::serviceControlsEnabled): Deleted.

  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp:

(WebCore::Editor::scanSelectionForTelephoneNumbers):

  • editing/SelectionRectGatherer.cpp:

(WebCore::SelectionRectGatherer::Notifier::~Notifier):
Notify ServicesOverlayController of changes via Page instead of EditorClient.

  • page/ChromeClient.h:

(WebCore::ChromeClient::handleTelephoneNumberClick):
(WebCore::ChromeClient::handleSelectionServiceClick):
(WebCore::ChromeClient::hasRelevantSelectionServices):
Add ChromeClient functions for services actions.

  • page/EditorClient.h:

(WebCore::EditorClient::selectedTelephoneNumberRangesChanged): Deleted.
(WebCore::EditorClient::selectionRectsDidChange): Deleted.
Remove EditorClient functions for notifying ServicesOverlayController of changes,
because it lives in WebCore proper now.

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(WebCore::Page::servicesOverlayController):
Keep a ServicesOverlayController on Page.

  • page/PageOverlay.cpp:

(WebCore::PageOverlay::mouseEvent):
Use windowToContents instead of rootViewToContents; events come in in window coordinates.

  • page/PageOverlayController.cpp:

(WebCore::PageOverlayController::updateSettingsForLayer):
Get Settings from MainFrame, not Page.

  • page/Settings.in:

Add servicesControlsEnabled setting.

  • page/mac/ServicesOverlayController.h: Renamed from Source/WebKit2/WebProcess/WebPage/ServicesOverlayController.h.
  • page/mac/ServicesOverlayController.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm.

Moved from WebKit2. Mostly mechanical changes, plus:

  • Use windowToContents instead of rootViewToContents; events come in in window coordinates.
  • Cut off rebuild* if serviceControlsEnabled setting is false
  • Don't create the overlay if serviceControlsEnabled setting is false
  • Send click events via ChromeClient.
  • Tie our lifetime to MainFrame instead of Page, and get lots of things from MainFrame instead.
  • platform/Logging.h:

Add Services logging channel (moved from WebKit2).

1:51 PM Changeset in webkit [174523] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix: Revert r174378

Roll back this change, as it didn't fix the EWS builders, and has only
served to make Windows builds take forever.

  • WebCore.vcxproj/WebCoreGenerated.make: Don't delete all generated content

every time we build.

1:20 PM Changeset in webkit [174522] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r174504.

Missing header include.

  • rendering/svg/SVGTextQuery.cpp:
12:52 PM Changeset in webkit [174521] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

Get the patch scripts running on Haiku
​https://bugs.webkit.org/show_bug.cgi?id=137559

Patch by Adrien Destugues <​pulkomandy@gmail.com> on 2014-10-09
Reviewed by Benjamin Poulain.

Use /usr/bin/env instead of hardcoding path to perl.
Declare haiku platform in platforminfo.py to avoid check-webkit-style
failure.

  • Scripts/commit-log-editor:
  • Scripts/num-cpus:
  • Scripts/prepare-ChangeLog:
  • Scripts/run-launcher:
  • Scripts/svn-create-patch:
  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo._determine_os_name):

12:26 PM Changeset in webkit [174520] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Disable tests for more unsupported features in iOS Simulator.

  • platform/ios-simulator/TestExpectations:
12:26 PM Changeset in webkit [174519] by Simon Fraser
  • 2 edits
    70 adds in trunk/LayoutTests

iOS Simulator results for ietestcenter tests.
Skip fullscreen and gamepad tests.

  • platform/ios-simulator/ietestcenter/*: Added
12:25 PM Changeset in webkit [174518] by Simon Fraser
  • 1 edit
    7 adds in trunk/LayoutTests

iOS Simulator results for fonts tests.

  • platform/ios-simulator/fonts/*: Added
12:16 PM Changeset in webkit [174517] by mmaxfield@apple.com
  • 5 edits in trunk/Source

Remove second-to-last client of WebFontCache
​https://bugs.webkit.org/show_bug.cgi?id=137550

Reviewed by Darin Adler.

Source/WebCore:

No new tests because no behavior change.

  • WebCore.exp.in:
  • platform/graphics/FontCache.h: Allow migration of client to getCachedFontData()

Source/WebKit/mac:

Use FontCache::getCachedFontData() instead of WebFontCache.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _addToStyle:fontA:fontB:]):

12:05 PM Changeset in webkit [174516] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

[Mac] Spending too much time mapping desired font families to available ones
​https://bugs.webkit.org/show_bug.cgi?id=137539

Reviewed by Darin Adler.

While profiling the load of weather.com, I noticed that we are spending
quite a bit of time trying to map the font family requested to a font
that is available on the system. The process involves:

  1. Doing a linear search of all the installed font families and do a case-insensitive string comparison for each of them until we find a match,
  2. Then, if we don't find a match, do another linear search of the fonts' postscript names this time and do again a case-insensitive string comparison for each of them.

This process is costly and the fonts requested by weather.com are not
available, causing us to do 2 linear searches and a lot of string
comparisons (accounting for ~2% of the WebProcess CPU time for the page
load). As a result, we end up spending ~90ms in
internalFontWithFamily() when loading weather.com.

This patch introduces a cache for the mapping between desired font
families and available font families. This cuts the time spent in
internalFontWithFamily() in half (~45ms). The cache gets invalidated
when fonts are installed / uninstalled on the system so we don't break
that scenario. The cache is also limited in size to avoid using too
much memory.

No new tests, but manual testing making sure the cache gets invalidated
when installing a font on the system.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::invalidateFontCache):

  • platform/mac/WebFontCache.h:
  • platform/mac/WebFontCache.mm:

(desiredFamilyToAvailableFamilyDictionary):
(rememberDesiredFamilyToAvailableFamilyMapping):
(+[WebFontCache internalFontWithFamily:traits:weight:size:]):
(+[WebFontCache invalidate]):

11:43 AM Changeset in webkit [174515] by betravis@adobe.com
  • 4 edits in trunk

[CSS Font Loading] Decrement the font loading count before notifying callbacks
​https://bugs.webkit.org/show_bug.cgi?id=137401

Reviewed by Alexey Proskuryakov.

Source/WebCore:

In the callbacks, it should appear that font load has completed. This is
accessed through loading(), which relies on the current number of
fonts loading via JS and CSS.

Unskipping the failing test http/tests/webfont/fontloader-loading-attribute.html
test which tests this.

  • css/FontLoader.cpp:

(WebCore::LoadFontCallback::notifyLoaded):

LayoutTests:

  • platform/mac/TestExpectations: Unskip the test this bug was causing to fail.
11:41 AM Changeset in webkit [174514] by Simon Fraser
  • 1 edit
    1214 adds in trunk/LayoutTests

iOS Simulator results for editing tests.

  • platform/ios-simulator/editing/*: Added
11:38 AM Changeset in webkit [174513] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix after r174506.

We no longer needed to dereference as it is a reference instead of a
pointer now.

  • page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

11:16 AM Changeset in webkit [174512] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Crash in CFURLDownloadClient.didFail if the download has a null resumeData
​https://bugs.webkit.org/show_bug.cgi?id=137551

Reviewed by David Kilzer.

CFDataGetBytePtr() and CFDataGetLength() crash if passed a null value.

  • Shared/Downloads/ios/DownloadIOS.mm:

(WebKit::setUpDownloadClient):

11:10 AM Changeset in webkit [174511] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Enable ARM64 disassembler for all platforms
​https://bugs.webkit.org/show_bug.cgi?id=137560

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-10-09
Reviewed by Michael Saboff.

Remove PLATFORM conditions from around WTF_USE_ARM64_DISASSEMBLER since
the ARM64 disassembler has no platform dependencies anymore.

  • wtf/Platform.h:
10:34 AM Changeset in webkit [174510] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: DOM Storage Editing is broken in many ways, frustrating
​https://bugs.webkit.org/show_bug.cgi?id=137547

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-09
Reviewed by Timothy Hatcher.

  • UserInterface/Models/DOMStorageObject.js:

(WebInspector.DOMStorageObject.prototype.getEntries): Deleted.
When getting entires, populate the model object with these keys/values
so we can accurately detect duplicates in editing.

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype.determineNextCell):
(WebInspector.DataGrid.prototype.moveToNextCell):
When the users uses "Enter" to commit, stop editing.

(WebInspector.DataGrid.prototype._editingCommitted):
Fix title property accessor. This is not a map. This fixes an exception
when showing context menus on editable data grid rows.

  • UserInterface/Views/DOMStorageContentView.js:

(WebInspector.DOMStorageContentView.prototype.cleanup):
(WebInspector.DOMStorageContentView.prototype.restoreOriginalValues):
(WebInspector.DOMStorageContentView.prototype._editingCallback):
Completely rewrite editing here. As soon as an edit is made, enter
an uncommitted state with the original key/value. When a commit is
allowed, update as appropriate based on the original values.

10:01 AM Changeset in webkit [174509] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix compiler warning on noreturn function
​https://bugs.webkit.org/show_bug.cgi?id=137558

Patch by Adrien Destugues <​pulkomandy@gmail.com> on 2014-10-09
Reviewed by Darin Adler.

The function is marked "noreturn", but the stub implementation does
return. No new tests: function is never called. Only fixes a warning.

  • heap/HeapStatistics.cpp:

(JSC::HeapStatistics::exitWithFailure):

10:01 AM Changeset in webkit [174508] by Bruno de Oliveira Abinader
  • 1 edit
    2 adds in trunk/LayoutTests

Re-add tests for :enabled with Anchor, Area & Link elements
​https://bugs.webkit.org/show_bug.cgi?id=137557

Reviewed by Darin Adler.

The CSS selector :enabled should not match Anchor, Area & Link elements
with 'href' attribute set. This re-adds the related layout tests with
updated results.

  • fast/css/css-selector-enabled-links-expected.txt: Added.
  • fast/css/css-selector-enabled-links.html: Added.
9:58 AM Changeset in webkit [174507] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[X11] Plugin process crashes in NetscapePlugin::platformPostInitialize()
​https://bugs.webkit.org/show_bug.cgi?id=137426

Reviewed by Darin Adler.

For some reason flash crashes when NPP_GetValue is called with
NPPVpluginCancelSrcStream, but only in windowed mode. Not calling
NPP_GetValue and unconditionally loading the source URL in the
browser fixes the crash and plugins work normally. We can handle
this particular case with a new quirk.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::determineQuirks): Add
DoNotCancelSrcStreamInWindowedMode quirk if it's flash plugin.

  • Shared/Plugins/PluginQuirks.h: Add

DoNotCancelSrcStreamInWindowedMode quirk.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::shouldLoadSrcURL): Return early if plugin
is windowed and DoNotCancelSrcStreamInWindowedMode quirk is present.

9:45 AM Changeset in webkit [174506] by Chris Dumez
  • 51 edits in trunk/Source

Use is<>() / downcast<>() for Widget subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137549

Reviewed by Darin Adler.

Use is<>() / downcast<>() for Widget subclasses and clean up the
surrounding code.

Source/WebCore:

No new tests, no behavior change.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityObject.cpp:

(WebCore::appendAccessibilityObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::documentFrameView):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginScriptObjectFromPluginViewBase):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::appendFormData):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::canProcessDrag):
(WebCore::HTMLPlugInElement::isKeyboardFocusable):
(WebCore::HTMLPlugInElement::isUserObservable):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::checkSizeChangeForSnapshotting):
(WebCore::HTMLPlugInImageElement::subframeLoaderDidCreatePlugIn):

  • html/HTMLPlugInImageElement.h:
  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin):

  • page/DragController.cpp:

(WebCore::DragController::operationForLoad):

  • page/EventHandler.cpp:

(WebCore::EventHandler::subframeForTargetNode):
(WebCore::EventHandler::handleWheelEvent):

  • page/EventHandler.h:
  • page/Frame.cpp:

(WebCore::Frame::frameForWidget):

  • page/FrameView.cpp:

(WebCore::FrameView::hasCustomScrollbars):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
(WebCore::FrameView::removeChild):

  • page/FrameView.h:
  • page/Page.cpp:

(WebCore::Page::pluginViews):

  • page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):

  • page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::removeChild):
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

  • platform/ScrollView.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::root):
Uninline as root() because Widget::root() returns a FrameView now and
it is impossible to include FrameView.h in Scrollbar.h without causing
a cycle.

  • platform/Scrollbar.h:
  • platform/Widget.cpp:

(WebCore::Widget::root):
Use tighter typing and return a FrameView instead of a ScrollView.

(WebCore::Widget::removeFromParent):

  • platform/Widget.h:
  • platform/efl/WidgetEfl.cpp:

(WebCore::Widget::setCursor):

  • platform/gtk/PlatformScreenGtk.cpp:
  • platform/gtk/WidgetGtk.cpp:

(WebCore::Widget::setCursor):

  • platform/mac/PlatformScreenMac.mm:

(WebCore::displayFromWidget):

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::setCursor):

  • platform/win/WidgetWin.cpp:

(WebCore::Widget::setCursor):

  • plugins/PluginViewBase.h:
  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paintIntoTransformedContext):
(WebCore::PluginView::paintWindowedPluginIntoContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::snapshot):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
(WebCore::RenderEmbeddedObject::nodeAtPoint):
(WebCore::RenderEmbeddedObject::scroll):

  • rendering/RenderFrameBase.h:

(WebCore::RenderFrameBase::childView):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::layerWillBeDestroyed):
(WebCore::RenderLayerBacking::updateConfiguration):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/RenderWidget.cpp:

(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
(WebCore::RenderWidget::paintContents):
(WebCore::RenderWidget::setOverlapTestResult):
(WebCore::RenderWidget::updateWidgetPosition):
(WebCore::RenderWidget::nodeAtPoint):
(WebCore::RenderWidget::embeddedContentBox):

Source/WebKit/mac:

  • WebView/WebRenderNode.mm:

(copyRenderNode):

  • WebView/WebView.mm:

(-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):

Source/WebKit/win:

  • WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::frameRectsChanged):

Source/WebKit2:

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

9:31 AM WebKitGTK/2.4.x edited by philip.chimento@gmail.com
Adding as per comment on ​https://bugs.webkit.org/show_bug.cgi?id=137385 (diff)
9:18 AM Changeset in webkit [174505] by Carlos Garcia Campos
  • 10 edits in trunk/Source/WebCore

Layering violation: MediaPlayer should not reference/use FrameView
​https://bugs.webkit.org/show_bug.cgi?id=21562

Reviewed by Darin Adler.

Remove FrameView dependency from MediaPlayer.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerIsInMediaDocument): Check if
the element document is a media document.

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::MediaPlayer): Remove m_frameView initialization.
(WebCore::MediaPlayer::inMediaDocument): Use the MediaPlayerClient
to check if the media player is in a media document.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerIsInMediaDocument):
(WebCore::MediaPlayer::setFrameView): Deleted.
(WebCore::MediaPlayer::frameView): Deleted.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::preferredRenderingMode):
Do not check if the media player has a frame view, checking whether it's visible
is enough.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

Remove unneeded header include.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Ditto.
  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::~RenderVideo): Do not call MediaPlayer::setFrameView().
(WebCore::RenderVideo::updatePlayer): Ditto.

9:17 AM Changeset in webkit [174504] by Chris Dumez
  • 30 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for RenderBlockFlow
​https://bugs.webkit.org/show_bug.cgi?id=137545

Reviewed by Darin Adler.

Use is<>() / downcast<>() for RenderBlockFlow and clean up the
surrounding code.

No new tests, no behavior change.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • dom/Element.cpp:

(WebCore::Element::renderNamedFlowFragment):
(WebCore::Element::webkitGetRegionFlowRanges):

  • editing/Editor.cpp:

(WebCore::Editor::hasBidiSelection):

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForRegionHighlight):
(WebCore::buildObjectForElementInfo):

  • rendering/EllipsisBox.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::innerTextIfTruncated):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::marginOffsetForSelfCollapsingBlock):
(WebCore::RenderBlockFlow::marginValuesForChild):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::marginBeforeEstimateForChild):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):
(WebCore::RenderBlockFlow::mustDiscardMarginBeforeForChild):
(WebCore::RenderBlockFlow::mustDiscardMarginAfterForChild):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::moveAllChildrenIncludingFloatsTo):
(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlockFlow::adjustForBorderFit):
(WebCore::getHeightForLineCount):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderElement::isRenderNamedFlowFragmentContainer):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::createLineBoxes):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeFlowChildInfo):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::expandClipRectForRegionAndReflection):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::evacuateAndDestroy):
(WebCore::RenderMultiColumnFlowThread::processPossibleSpannerDescendant):
(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted):

  • rendering/RenderMultiColumnFlowThread.h:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset):
(WebCore::RenderMultiColumnSet::columnGap):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::fragmentContainer):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::adjustComputedFontSizesOnBlocks):
(WebCore::RenderObject::resetTextAutosizing):
(WebCore::RenderObject::showLineTreeForThis):
(WebCore::RenderObject::showRenderSubTreeAndMark):

  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):
(WebCore::RenderText::ensureLineBoxes):
(WebCore::RenderText::simpleLineLayout):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):
(WebCore::RootInlineBox::blockFlow):

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::computeTextBoundingBox):
(WebCore::SimpleLineLayout::computeTextFirstRunLocation):
(WebCore::SimpleLineLayout::collectTextAbsoluteRects):
(WebCore::SimpleLineLayout::collectTextAbsoluteQuads):

  • rendering/svg/SVGTextQuery.cpp:

(WebCore::flowBoxForRenderer):

8:59 AM Changeset in webkit [174503] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Ensure that inline assembly Thunk functions don't conflict with the section designations of the compiler
​https://bugs.webkit.org/show_bug.cgi?id=137434

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-10-09
Reviewed by Michael Saboff.

The ARM64 version of the defineUnaryDoubleOpWrapper macro in
ThunkGenerators.cpp contains inline assembly with .text assembler
directive followed by a static variable declaration. This macro gets
expanded several times afterwards, however, only during the compilation
of the first expansion does gcc insert a .data assembler directive
before the assembled version of the static variable. Thus, only the
first variable gets allocated in the .data section, all the others
remain in .text. If JavaScriptCore is built as a shared library then
this causes a segmentation fault during dynamic linking.

This patch puts a .previous directive at the end of the inline assembly
to ensure that the assumptions of the compiler about the sections are
not broken and the following variable goes to the right place.

  • jit/ThunkGenerators.cpp:
12:34 AM Changeset in webkit [174502] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Netscape plugin API symbol used outside feature guards
​https://bugs.webkit.org/show_bug.cgi?id=137385

Patch by Philip Chimento <​philip.chimento@gmail.com> on 2014-10-09
Reviewed by Philippe Normand.

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::unload): Add guards for Netscape Plugin
API around symbol, so that it compiles OK when the API is not
available.

Oct 8, 2014:

11:50 PM Changeset in webkit [174501] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

StyleQueue should throw a PatchIsNotValid exception to achieve
consistency with CommitQueue and EWS
​https://bugs.webkit.org/show_bug.cgi?id=137500

Patch by Jake Nielsen <​jacob_nielsen@apple.com> on 2014-10-08
Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/tool/bot/stylequeuetask.py:

Adds a call to validate() in run().
(StyleQueueTask.run):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

Adds a return False in the patch is not valid exception statement.
(AbstractEarlyWarningSystem.review_patch):

  • Scripts/webkitpy/tool/commands/queues.py:

Adds a return False in the patch is not valid exception statement in
commit queue, and adds an except statement to catch PatchIsNotValid
exceptions in style queue.
(CommitQueue.process_work_item):
(StyleQueue.review_patch):

11:48 PM Changeset in webkit [174500] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

11:37 PM Changeset in webkit [174499] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Use the PageLoadState observer also to monitor title and estimated load progress
​https://bugs.webkit.org/show_bug.cgi?id=136997

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView): Remove implementation of
didReceiveTitleForFrame, didStartProgress, didChangeProgress and
didFinishProgress.
(didReceiveTitleForFrame): Deleted.
(didChangeProgress): Deleted.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_estimated_load_progress): Return the value
directly from the PageLoadState object, since we don't need to
cache the value anymore.
(webkitWebViewSetTitle): Deleted.
(webkitWebViewSetEstimatedLoadProgress): Deleted.

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
11:34 PM Changeset in webkit [174498] by mihnea@adobe.com
  • 6 edits in trunk/Source/WebCore

[CSSRegions]Remove unused parameter in adjustRegionBoundsFromFlowThreadPortionRect
​https://bugs.webkit.org/show_bug.cgi?id=137518

Reviewed by Andrei Bucur.

This method is used only by region code in accelerated compositing.
The first parameter for the method was introduced with the intent to be used for multicolumn,
but without being actually used in multicolumn code. Also make the method const.
No new tests as no change in functionality.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::adjustRegionBoundsFromFlowThreadPortionRect):

  • rendering/RenderRegion.h:
11:33 PM Changeset in webkit [174497] by Carlos Garcia Campos
  • 7 edits in trunk

Race condition with WebKitWebView:is-loading after starting page load
​https://bugs.webkit.org/show_bug.cgi?id=136692

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Use PageLoadState::Observer to update both is-loading and uri
properties, instead of manually update them. This ensures that our
web view is always in sync with the WebPageProxy so that
webkit_web_view_is_loading() returns true right after requesting
any load. We still need to manually set the is-loading property
only in the case where we delay the emission of the load-changed
signals when waiting for the main resource. The bahaviour is a bit
different but still consistent with what our API documentation says.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView): Remove
didSameDocumentNavigationForFrame implementation, since we are
already notified about the URL change by the PageLoadState::Observer.
(didSameDocumentNavigationForFrame): Deleted.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetIsLoading): No longer update the URI when
changing the is-loading property.
(webkitWebViewConstructed): Crate a PageLoadStateObserver and add
it to the PageLoadState.
(webkitWebViewDispose): Remove the PageLoadStateObserver from the PageLoadState.
(webkitWebViewEmitLoadChanged): Add isDelayedEvent parameter to
update the is-loading property accordingly when emitting the
delayed events.
(webkitWebViewEmitDelayedLoadEvents): Pass true as isDelayedEvent
parameter of webkitWebViewEmitLoadChanged().
(webkitWebViewLoadChanged): Pass false as isDelayedEvent parameter
of webkitWebViewEmitLoadChanged().
(webkitWebViewLoadFailed):
(webkitWebViewLoadFailedWithTLSErrors):
(webkitWebViewUpdateURI): Deleted.

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:

Tools:

  • TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:

(loadChangedCallback): Only check is-loading is false when load
has finished if the load didn't fail due to a cancellation.
(loadFailedCallback): Only check is-loading is false if the load
didn't fail due to a cancellation.

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::loadURI): Check is-loading is true and active URI is
the requested one rigth after requesting the load.
(WebViewTest::loadHtml): Ditto.
(WebViewTest::loadPlainText): Ditto.
(WebViewTest::loadBytes): Ditto.
(WebViewTest::loadRequest): Ditto.
(WebViewTest::loadAlternateHTML): Ditto.
(WebViewTest::goBack): Ditto.
(WebViewTest::goForward): Ditto.
(WebViewTest::goToBackForwardListItem): Ditto.

11:26 PM Changeset in webkit [174496] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

[Mac] Show repaint counters in tile coverage map.
<​https://webkit.org/b/137544>

Reviewed by Simon Fraser.

Add repaint counters to the tile layers in the "tiled scrolling
indicator" display. This will be helpful for diagnosing issues with
excessive tile repaints outside the visible viewport.

  • platform/graphics/ca/TileController.cpp:

(WebCore::TileController::setNeedsDisplayInRect):

  • platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::drawTileMapContents):

9:07 PM Changeset in webkit [174495] by Simon Fraser
  • 4 edits in trunk/LayoutTests

Remove some more passing tests from TestExpectations.

  • TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
7:50 PM Changeset in webkit [174494] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Another unreviewed build fix after r174475.

Don't try to insert a duplicated row into build_commits as it results in a database constraint error.

This has been caught by a test in /api/report. I don't know why I thought all tests were passing.

  • public/include/report-processor.php:
6:51 PM Changeset in webkit [174493] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r174480. Broke iOS build.

  • rendering/RenderObject.cpp:

(WebCore::includeNonFixedHeight):

6:49 PM Changeset in webkit [174492] by Simon Fraser
  • 1 edit
    951 adds in trunk/LayoutTests

iOS Simulator results for css3 tests.

  • platform/ios-simulator/css3/*: Added
6:49 PM Changeset in webkit [174491] by Simon Fraser
  • 1 edit
    753 adds in trunk/LayoutTests

iOS Simulator results for css2.1 tests.

  • platform/ios-simulator/css2.1/*: Added
6:48 PM Changeset in webkit [174490] by Simon Fraser
  • 1 edit
    116 adds in trunk/LayoutTests

iOS Simulator results for css1 tests.

  • platform/ios-simulator/css1/basic/containment-expected.txt: Added.
  • platform/ios-simulator/css1/basic/contextual_selectors-expected.txt: Added.
  • platform/ios-simulator/css1/basic/grouping-expected.txt: Added.
  • platform/ios-simulator/css1/basic/id_as_selector-expected.txt: Added.
  • platform/ios-simulator/css1/basic/inheritance-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/acid_test-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_bottom-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_bottom_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_bottom_width-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_bottom_width_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_color-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_color_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_left-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_left_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_left_width-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_left_width_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_right-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_right_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_right_width-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_right_width_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_style-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_style_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_top-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_top_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_top_width-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_top_width_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_width-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/border_width_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/clear-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/clear_float-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/float-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/float_elements_in_series-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/float_margin-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/float_on_text_elements-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/height-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/margin-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/margin_bottom-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/margin_bottom_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/margin_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/margin_left-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/margin_left_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/margin_right-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/margin_right_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/margin_top-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/margin_top_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/padding-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/padding_bottom-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/padding_bottom_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/padding_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/padding_left-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/padding_left_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/padding_right-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/padding_right_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/padding_top-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/padding_top_inline-expected.txt: Added.
  • platform/ios-simulator/css1/box_properties/width-expected.txt: Added.
  • platform/ios-simulator/css1/cascade/cascade_order-expected.txt: Added.
  • platform/ios-simulator/css1/cascade/important-expected.txt: Added.
  • platform/ios-simulator/css1/classification/display-expected.txt: Added.
  • platform/ios-simulator/css1/classification/list_style-expected.txt: Added.
  • platform/ios-simulator/css1/classification/list_style_image-expected.txt: Added.
  • platform/ios-simulator/css1/classification/list_style_position-expected.txt: Added.
  • platform/ios-simulator/css1/classification/list_style_type-expected.txt: Added.
  • platform/ios-simulator/css1/classification/white_space-expected.txt: Added.
  • platform/ios-simulator/css1/color_and_background/background-expected.txt: Added.
  • platform/ios-simulator/css1/color_and_background/background_attachment-expected.txt: Added.
  • platform/ios-simulator/css1/color_and_background/background_color-expected.txt: Added.
  • platform/ios-simulator/css1/color_and_background/background_image-expected.txt: Added.
  • platform/ios-simulator/css1/color_and_background/background_position-expected.txt: Added.
  • platform/ios-simulator/css1/color_and_background/background_repeat-expected.txt: Added.
  • platform/ios-simulator/css1/color_and_background/color-expected.txt: Added.
  • platform/ios-simulator/css1/conformance/forward_compatible_parsing-expected.txt: Added.
  • platform/ios-simulator/css1/font_properties/font-expected.txt: Added.
  • platform/ios-simulator/css1/font_properties/font_family-expected.txt: Added.
  • platform/ios-simulator/css1/font_properties/font_size-expected.txt: Added.
  • platform/ios-simulator/css1/font_properties/font_style-expected.txt: Added.
  • platform/ios-simulator/css1/font_properties/font_variant-expected.txt: Added.
  • platform/ios-simulator/css1/font_properties/font_weight-expected.txt: Added.
  • platform/ios-simulator/css1/formatting_model/canvas-expected.txt: Added.
  • platform/ios-simulator/css1/formatting_model/floating_elements-expected.txt: Added.
  • platform/ios-simulator/css1/formatting_model/height_of_lines-expected.txt: Added.
  • platform/ios-simulator/css1/formatting_model/horizontal_formatting-expected.txt: Added.
  • platform/ios-simulator/css1/formatting_model/inline_elements-expected.txt: Added.
  • platform/ios-simulator/css1/formatting_model/replaced_elements-expected.txt: Added.
  • platform/ios-simulator/css1/formatting_model/vertical_formatting-expected.txt: Added.
  • platform/ios-simulator/css1/pseudo/anchor-expected.txt: Added.
  • platform/ios-simulator/css1/pseudo/firstletter-expected.txt: Added.
  • platform/ios-simulator/css1/pseudo/firstline-expected.txt: Added.
  • platform/ios-simulator/css1/pseudo/multiple_pseudo_elements-expected.txt: Added.
  • platform/ios-simulator/css1/pseudo/pseudo_elements_in_selectors-expected.txt: Added.
  • platform/ios-simulator/css1/text_properties/letter_spacing-expected.txt: Added.
  • platform/ios-simulator/css1/text_properties/line_height-expected.txt: Added.
  • platform/ios-simulator/css1/text_properties/text_align-expected.txt: Added.
  • platform/ios-simulator/css1/text_properties/text_decoration-expected.txt: Added.
  • platform/ios-simulator/css1/text_properties/text_indent-expected.txt: Added.
  • platform/ios-simulator/css1/text_properties/text_transform-expected.txt: Added.
  • platform/ios-simulator/css1/text_properties/vertical_align-expected.txt: Added.
  • platform/ios-simulator/css1/text_properties/word_spacing-expected.txt: Added.
  • platform/ios-simulator/css1/units/color_units-expected.txt: Added.
  • platform/ios-simulator/css1/units/length_units-expected.txt: Added.
  • platform/ios-simulator/css1/units/percentage_units-expected.txt: Added.
  • platform/ios-simulator/css1/units/urls-expected.txt: Added.
6:14 PM Changeset in webkit [174489] by mmaxfield@apple.com
  • 12 edits
    4 adds in trunk

Inline ruby does not get justified correctly
​https://bugs.webkit.org/show_bug.cgi?id=137421

Source/WebCore:

Patch by Myles C. Maxfield <​litherum@gmail.com> on 2014-10-08
Reviewed by Dave Hyatt.

We justify text in two passes: one counts expansion opportunities within a line,
and the other doles out widths and expansion amounts to constituent inline boxes.
This patch simply modifies both passes to descend into ruby bases. Once it has
done so, we then re-layout the ruby run with the newly found width.

Tests: fast/ruby/ruby-justification-hittest.html

fast/ruby/ruby-justification.html

  • rendering/InlineBox.h:

(WebCore::InlineBox::setExpansion): updateRubyForJustifiedText() has to set the
expansion for an inline box, so make setExpansion() public.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::updateRubyForJustifiedText): Given values that have already been
computed in computeInlineDirectionPositionsForSegment(), adjust the widths and
expansion values for all the various pieces of ruby.
(WebCore::computeExpansionForJustifiedText): Call updateRubyForJustifiedText() if
necessary.
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment): When
counting expansion opportunities in a line, include ruby bases.

  • rendering/RenderRubyRun.h: Fix grammar in comment.
  • rendering/RenderText.cpp:

(WebCore::RenderText::stringView): Give default arguments to function.

  • rendering/RenderText.h: Ditto.

LayoutTests:

Reviewed by Dave Hyatt.

Test that ruby gets spaces inside the ruby base, and that hit testing the
ruby base gives us correct answers.

  • fast/ruby/ruby-justification-expected.html: Added.
  • fast/ruby/ruby-justification-hittest-expected.txt: Added.
  • fast/ruby/ruby-justification-hittest.html: Added.
  • fast/ruby/ruby-justification.html: Added.
  • platform/mac/fast/ruby/bopomofo-rl-expected.txt: Ruby text gets the CSS

property text-align: justify, which worked prior to this patch. However, this
patch now justifies ruby bases, so now if there is text that is both a ruby
base and ruby text (such as ruby in ruby) it correctly gets justified. This
test does such, and therefore needs to be rebaselined.

6:05 PM Changeset in webkit [174488] by Simon Fraser
  • 2 edits
    317 adds in trunk/LayoutTests

New baselines for iOS compositing tests.

  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/compositing/absolute-inside-out-of-view-fixed-expected.txt: Added.
  • platform/ios-simulator/compositing/animation/filling-animation-overlap-at-end-expected.txt: Added.
  • platform/ios-simulator/compositing/animation/filling-animation-overlap-expected.txt: Added.
  • platform/ios-simulator/compositing/animation/layer-for-filling-animation-expected.txt: Added.
  • platform/ios-simulator/compositing/animation/state-at-end-event-transform-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/backface-visibility-flip-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/backface-visibility-in-3dtransformed-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/border-radius-no-backing-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/child-layer-no-backing-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/filter-no-backing-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/inline-block-no-backing-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/masked-child-no-backing-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/no-backing-for-clip-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/no-backing-for-perspective-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/replaced-child-no-backing-expected.txt: Added.
  • platform/ios-simulator/compositing/backing/whitespace-nodes-no-backing-expected.txt: Added.
  • platform/ios-simulator/compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
  • platform/ios-simulator/compositing/checkerboard-expected.txt: Added.
  • platform/ios-simulator/compositing/clip-child-by-non-stacking-ancestor-expected.txt: Added.
  • platform/ios-simulator/compositing/color-matching/image-color-matching-expected.txt: Added.
  • platform/ios-simulator/compositing/color-matching/pdf-image-match-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/ancestor-clipped-in-paginated-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/clipped-in-paginated-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/composited-columns-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/composited-columns-vertical-rl-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/composited-in-paginated-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/composited-in-paginated-rl-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/composited-in-paginated-writing-mode-rl-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/composited-lr-paginated-repaint-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/composited-nested-columns-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/composited-rl-paginated-repaint-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/hittest-composited-in-paginated-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/rotated-in-paginated-expected.txt: Added.
  • platform/ios-simulator/compositing/columns/untransformed-composited-in-paginated-expected.txt: Added.
  • platform/ios-simulator/compositing/compositing-visible-descendant-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/background-clip-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/background-color-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/body-background-painted-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/body-background-skipped-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/control-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/filter-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/hidden-with-visible-child-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/hidden-with-visible-text-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/layer-opacity-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/layer-transform-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-opaque/visibility-hidden-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-scale/animating-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-scale/rounded-contents-scale-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-scale/scaled-ancestor-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-scale/simple-scale-expected.txt: Added.
  • platform/ios-simulator/compositing/contents-scale/z-translate-expected.txt: Added.
  • platform/ios-simulator/compositing/direct-image-compositing-expected.txt: Added.
  • platform/ios-simulator/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
  • platform/ios-simulator/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
  • platform/ios-simulator/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
  • platform/ios-simulator/compositing/fixed-image-loading-expected.txt: Added.
  • platform/ios-simulator/compositing/generated-content-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/abs-position-inside-opacity-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/ancestor-overflow-change-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/bounds-clipped-composited-child-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/bounds-ignores-hidden-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/clip-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/clip-inside-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/clipping-foreground-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/composited-html-size-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/composited-in-columns-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/fixed-in-composited-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/fixed-position-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/flipped-writing-mode-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/outline-change-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/partial-layout-update-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/root-layer-update-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/tall-page-composited-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/iframe-content-flipping-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/iframe-size-to-zero-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/iframe-src-change-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/nested-iframe-scrolling-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/overlapped-iframe-iframe-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/overlapped-nested-iframes-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/page-cache-layer-tree-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/resizer-expected.txt: Added.
  • platform/ios-simulator/compositing/iframes/scrolling-iframe-expected.txt: Added.
  • platform/ios-simulator/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
  • platform/ios-simulator/compositing/images/direct-image-background-color-expected.txt: Added.
  • platform/ios-simulator/compositing/images/direct-image-object-fit-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/animation-overlap-with-children-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/fixed-position-and-transform-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/fixed-position-transformed-into-view-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/fixed-position-under-transform-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/no-compositing-for-sticky-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-animation-container-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-animation-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-child-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-clipping-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-transformed-3d-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-transformed-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-transforms-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/rotate3d-overlap-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/stacking-context-overlap-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/translatez-overlap-expected.txt: Added.
  • platform/ios-simulator/compositing/masks/direct-image-mask-expected.txt: Added.
  • platform/ios-simulator/compositing/masks/mask-layer-size-expected.txt: Added.
  • platform/ios-simulator/compositing/masks/masked-ancestor-expected.txt: Added.
  • platform/ios-simulator/compositing/masks/multiple-masks-expected.txt: Added.
  • platform/ios-simulator/compositing/masks/simple-composited-mask-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow-trumps-transform-style-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/ancestor-overflow-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/automatically-opt-into-composited-scrolling-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/clip-descendents-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/nested-scrolling-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/overflow-auto-with-touch-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/overflow-overlay-with-touch-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/overflow-positioning-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/overflow-scroll-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/overflow-scrollbar-layer-positions-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/parent-overflow-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/remove-overflow-crash2-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/resize-painting-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/scrollbar-painting-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/scrolling-without-painting-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/textarea-scroll-touch-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added.
  • platform/ios-simulator/compositing/overflow/updating-scrolling-content-expected.txt: Added.
  • platform/ios-simulator/compositing/plugins/composited-plugin-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/animation-inside-reflection-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/direct-image-object-fit-reflected-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/nested-reflection-anchor-point-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/nested-reflection-animated-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/nested-reflection-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/nested-reflection-on-overflow-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/nested-reflection-opacity-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/nested-reflection-size-change-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/nested-reflection-transition-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/reflection-in-composited-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/reflection-on-composited-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/reflection-opacity-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/reflection-ordering-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/reflection-positioning-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/reflection-positioning2-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/simple-composited-reflections-expected.txt: Added.
  • platform/ios-simulator/compositing/reflections/transform-inside-reflection-expected.txt: Added.
  • platform/ios-simulator/compositing/regions/fixed-in-named-flow-clip-descendant-expected.txt: Added.
  • platform/ios-simulator/compositing/regions/fixed-in-named-flow-expected.txt: Added.
  • platform/ios-simulator/compositing/regions/fixed-in-named-flow-from-abs-in-named-flow-expected.txt: Added.
  • platform/ios-simulator/compositing/regions/fixed-in-named-flow-from-outflow-expected.txt: Added.
  • platform/ios-simulator/compositing/regions/fixed-in-named-flow-got-transformed-parent-expected.txt: Added.
  • platform/ios-simulator/compositing/regions/fixed-in-named-flow-lost-transformed-parent-expected.txt: Added.
  • platform/ios-simulator/compositing/regions/fixed-in-named-flow-overlap-composited-expected.txt: Added.
  • platform/ios-simulator/compositing/regions/fixed-in-named-flow-transformed-parent-expected.txt: Added.
  • platform/ios-simulator/compositing/regions/fixed-transformed-in-named-flow-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/become-overlay-composited-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/composited-document-element-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/content-into-overflow-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/fixed-background-scroll-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/layer-repaint-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/layer-repaint-rects-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/opacity-between-absolute-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/opacity-between-absolute2-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/overflow-into-content-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/page-scale-repaint-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/positioned-movement-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/resize-repaint-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-absolute-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-fixed-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.
  • platform/ios-simulator/compositing/rtl/rtl-relative-expected.txt: Added.
  • platform/ios-simulator/compositing/shadows/shadow-drawing-expected.txt: Added.
  • platform/ios-simulator/compositing/sibling-positioning-expected.txt: Added.
  • platform/ios-simulator/compositing/text-on-large-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/tiled-layers-hidpi-expected.txt: Added.
  • platform/ios-simulator/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Added.
  • platform/ios-simulator/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/ios-simulator/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/ios-simulator/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/ios-simulator/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
  • platform/ios-simulator/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
  • platform/ios-simulator/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
  • platform/ios-simulator/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
  • platform/ios-simulator/compositing/tiling/tile-cache-zoomed-expected.txt: Added.
  • platform/ios-simulator/compositing/tiling/tiled-layer-resize-expected.txt: Added.
  • platform/ios-simulator/compositing/transitions/scale-transition-no-start-expected.txt: Added.
  • platform/ios-simulator/compositing/transitions/singular-scale-transition-expected.txt: Added.
  • platform/ios-simulator/compositing/visibility/layer-visible-content-expected.txt: Added.
  • platform/ios-simulator/compositing/visibility/visibility-composited-expected.txt: Added.
  • platform/ios-simulator/compositing/visibility/visibility-composited-transforms-expected.txt: Added.
  • platform/ios-simulator/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/2d-transformed-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/3d-transform-style-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/3d-transformed-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/animated-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/animated-from-none-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/clipped-by-viewport-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/clipped-visible-rect-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/flipped-preserve-3d-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/iframe-and-layers-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/iframe-no-layers-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/nested-transform-expected.txt: Added.
  • platform/ios-simulator/compositing/visible-rect/scrolled-expected.txt: Added.
  • platform/ios-simulator/compositing/webgl/webgl-background-color-expected.txt: Added.
  • platform/ios-simulator/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt: Added.
  • platform/ios-simulator/compositing/webgl/webgl-reflection-expected.txt: Added.
6:05 PM Changeset in webkit [174487] by Simon Fraser
  • 1 edit
    11 adds in trunk/LayoutTests

Some animation test results for the iOS Simulator build.

  • platform/ios-simulator/animations/3d/change-transform-in-end-event-expected.txt: Added.
  • platform/ios-simulator/animations/3d/matrix-transform-type-animation-expected.txt: Added.
  • platform/ios-simulator/animations/3d/state-at-end-event-transform-expected.txt: Added.
  • platform/ios-simulator/animations/additive-transform-animations-expected.txt: Added.
  • platform/ios-simulator/animations/cross-fade-border-image-source-expected.txt: Added.
  • platform/ios-simulator/animations/cross-fade-list-style-image-expected.txt: Added.
  • platform/ios-simulator/animations/cross-fade-webkit-mask-box-image-expected.txt: Added.
  • platform/ios-simulator/animations/cross-fade-webkit-mask-image-expected.txt: Added.
  • platform/ios-simulator/animations/state-at-end-event-expected.txt: Added.
5:19 PM Changeset in webkit [174486] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Unreviewed build fix after r174477.

  • init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.

Also fixed a syntax error that we were missing "," after line that declared build_commit column.

  • public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.

This is necessary for baseline and target values manually added via admin pages.

5:12 PM Changeset in webkit [174485] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

PopupMenus should indicate if they are using a custom rendering
​https://bugs.webkit.org/show_bug.cgi?id=137543
<rdar://problem/18544212>

Reviewed by Beth Dakin.

On Yosemite there is an animation as a popup menu closes. We can't use
this when there is a custom rendering, since the animation doesn't match
the final result. Implement this by hooking into the existing code
for hiding the arrows during animation - a WebKitSystemInterface update
will implement the other side.

  • platform/mac/WebCoreSystemInterface.h: Rename parameter to be more clear.
  • platform/mac/WebCoreSystemInterface.mm:
  • rendering/RenderMenuList.cpp:

(RenderMenuList::menuStyle): We need to check that we are a native-looking
button, not just something with appearance.

5:08 PM Changeset in webkit [174484] by Joseph Pecoraro
  • 4 edits
    2 adds in trunk/Source/WebInspectorUI

Web Inspector: CSS Pretty Printing fails to put space between value functions around ending parenthesis
​https://bugs.webkit.org/show_bug.cgi?id=137415

Reviewed by Timothy Hatcher.

Add a space after a closing parenthesis if we are still inside a property.
This adds space between space separated function lists such as
-webkit-transform:foo(...)bar(...). Also add a test for keyframe syntax.

  • Tools/PrettyPrinting/CodeMirrorFormatters.js:
  • Tools/PrettyPrinting/css-tests/keyframes-expected.css: Added.
  • Tools/PrettyPrinting/css-tests/keyframes.css: Added.
  • Tools/PrettyPrinting/index.html:
  • UserInterface/Views/CodeMirrorFormatters.js:
5:08 PM Changeset in webkit [174483] by Joseph Pecoraro
  • 4 edits
    2 adds in trunk/Source/WebInspectorUI

Web Inspector: CSS Pretty Printing fails to put space between rgb(...) and numbers in minified gradients
​https://bugs.webkit.org/show_bug.cgi?id=137414

Reviewed by Timothy Hatcher.

Add whitespace between rgb(...) and a number, possible in gradient
syntax like "linear-gradient(rgb(...)0%,rgb(...)100%)".

  • Tools/PrettyPrinting/CodeMirrorFormatters.js:
  • Tools/PrettyPrinting/css-tests/gradient-expected.css: Added.

(.dot-nav:nth-child(1n) li a.active):

  • Tools/PrettyPrinting/css-tests/gradient.css: Added.

(.dot-nav:nth-child(1n) li a.active):

  • Tools/PrettyPrinting/index.html:
  • UserInterface/Views/CodeMirrorFormatters.js:
5:08 PM Changeset in webkit [174482] by Joseph Pecoraro
  • 5 edits
    2 adds in trunk/Source/WebInspectorUI

Web Inspector: CSS Pretty Printing fails to wrap long lines of selectors with pseudo classes/elements
​https://bugs.webkit.org/show_bug.cgi?id=137413

Reviewed by Timothy Hatcher.

Long line wrapping was breaking as soon as there was a ':' for a psuedo
class or element. Likewise it was counting comment strings as part of
the length of the line even though it would get a newline after it.

  • Tools/PrettyPrinting/CodeMirrorFormatters.js:
  • Tools/PrettyPrinting/css-tests/basic-expected.css:

(progress, section, summary, time):

  • Tools/PrettyPrinting/css-tests/wrapping-expected.css: Added.

(a.tryamacs, a.upgradenows):
(a.tryamacs:hover, a.upgradenows:hover):

  • Tools/PrettyPrinting/css-tests/wrapping.css: Added.

(a.browsewebappss,a.businessstores,a.buyiphones,a.buynows,a.buynows-arrow,a.comingsoons,p::before,a.descargarahoras,a.downloadituness,a.downloadnows,a.finds,a.freetrials,a.getstarteds,a.gos,a.howtoapplys,a.howtobuys,a.joinnows,a.learnmores,a.nikebuynows,a.notifymes,a.ordernows,a.preordernows,a.preorders,a.reserves,a.startyoursearchs,a.submits,a.tryamacs,a.upgradenows):
(a.browsewebappss:hover,a.businessstores:hover,a.buyiphones:hover,a.buynows:hover,a.buynows-arrow:hover,a.comingsoons:hover,p::before,a.descargarahoras:hover,a.downloadituness:hover,a.downloadnows:hover,a.finds:hover,a.freetrials:hover,a.getstarteds:hover,a.gos:hover,a.howtoapplys:hover,a.howtobuys:hover,a.joinnows:hover,a.learnmores:hover,a.nikebuynows:hover,a.notifymes:hover,a.ordernows:hover,a.preordernows:hover,a.preorders:hover,a.reserves:hover,a.startyoursearchs:hover,a.submits:hover,a.tryamacs:hover,a.upgradenows:hover):

  • Tools/PrettyPrinting/index.html:
  • UserInterface/Views/CodeMirrorFormatters.js:
4:37 PM Changeset in webkit [174481] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Re-marking fast/hidpi/image-srcset-svg-canvas.html as an expected image failure.

  • platform/mac/TestExpectations:
4:33 PM Changeset in webkit [174480] by Chris Dumez
  • 29 edits in trunk/Source

Use is<>() / downcast<>() for RenderBlock objects
​https://bugs.webkit.org/show_bug.cgi?id=137512

Reviewed by Darin Adler.

Source/WebCore:

Use is<>() / downcast<>() for RenderBlock objects and clean up the
surrounding code.

No new tests, no behavior change.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::firstChildConsideringContinuation):
(WebCore::lastChildConsideringContinuation):
(WebCore::AccessibilityRenderObject::firstChild):
(WebCore::startOfContinuations):
(WebCore::endOfContinuations):
(WebCore::childBeforeConsideringContinuations):
(WebCore::AccessibilityRenderObject::previousSibling):
(WebCore::AccessibilityRenderObject::nextSibling):
(WebCore::nextContinuation):
(WebCore::AccessibilityRenderObject::renderParentObject):
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::setValue):

  • bindings/objc/DOMUIKitExtensions.mm:

(-[DOMNode containsOnlyInlineObjects]):
(-[DOMNode isSelectableBlock]):
(-[DOMHTMLElement structuralComplexityContribution]):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackList):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::shouldRepresentNodeOffsetZero):

  • page/ios/FrameIOS.mm:

(WebCore::Frame::preferredHeight):

  • rendering/LogicalSelectionOffsetCaches.h:

(WebCore::containingBlockForFixedPosition):
(WebCore::containingBlockForAbsolutePosition):
(WebCore::containingBlockForObjectInFlow):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::continuationBefore):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::addChildIgnoringContinuation):
(WebCore::canMergeAnonymousBlock):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::collapseAnonymousBoxChild):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::blockElementContinuation):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::blockBeforeWithinSelectionRoot):
(WebCore::isChildHitTestCandidate):
(WebCore::RenderBlock::firstLineBlock):
(WebCore::findFirstLetterBlock):
(WebCore::RenderBlock::childBecameNonInline):
(WebCore::RenderBlock::hasMarginBeforeQuirk):
(WebCore::RenderBlock::hasMarginAfterQuirk):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::marginBeforeEstimateForChild):
(WebCore::RenderBlockFlow::estimateLogicalTopPosition):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::markSiblingsWithFloatsForLayout):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::positionNewFloatOnLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::accumulateInFlowPositionOffsets):
(WebCore::RenderBoxModelObject::moveChildTo):
(WebCore::RenderBoxModelObject::moveChildrenTo):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::propagateStyleToAnonymousChildren):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent):

  • rendering/RenderFullScreen.cpp:

(WebCore::RenderFullScreen::unwrapRenderer):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::inlineElementContinuation):
(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::styleDidChange):
(WebCore::nextContinuation):
(WebCore::RenderInline::splitFlow):
(WebCore::RenderInline::positionForPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderListItem.cpp:

(WebCore::getParentOfFirstLineBox):
(WebCore::RenderListItem::insertOrMoveMarkerRendererIfNeeded):
(WebCore::RenderListItem::positionListMarker):

  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::maxPageLogicalHeight):

  • rendering/RenderObject.cpp:

(WebCore::includeNonFixedHeight):
(WebCore::RenderObject::checkBlockPositionedObjectsNeedLayout):
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::handleDynamicFloatPositionChange):
(WebCore::RenderObject::removeAnonymousWrappersForInlinesIfNecessary):
(WebCore::RenderObject::getTextDecorationColors):

  • rendering/RenderRuby.cpp:

(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::measureDescendantTextWidth):
(WebCore::TextAutosizer::findDeepestBlockContainingAllText):
(WebCore::TextAutosizer::findFirstTextLeafNotInCluster):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::layout):

Source/WebKit2:

Use is<>() / downcast<>() for RenderBlock objects and clean up the
surrounding code.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::contractedRangeFromHandle):

3:11 PM Changeset in webkit [174479] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Mark two inspector-protocol tests as crashing.
​https://bugs.webkit.org/show_bug.cgi?id=137529

  • platform/win/TestExpectations:
1:54 PM Changeset in webkit [174478] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Make sure arguments tearoff is performed through the environment record if necessary
​https://bugs.webkit.org/show_bug.cgi?id=137538

Reviewed by Michael Saboff.

Fairly simple change. If we have a lexical record we need to pull the unmodified
arguments object from the record and then use the standard op_tear_off_arguments
instruction on the temporary.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetOwnScope):
(JSC::BytecodeGenerator::emitReturn):

  • bytecompiler/BytecodeGenerator.h:
1:40 PM Changeset in webkit [174477] by rniwa@webkit.org
  • 1 edit
    18 adds in trunk/Websites/perf.webkit.org

Add v2 UI for the perf dashboard
​https://bugs.webkit.org/show_bug.cgi?id=137537

Rubber-stamped by Andreas Kling.

  • public/v2: Added.
  • public/v2/app.css: Added.
  • public/v2/app.js: Added.
  • public/v2/chart-pane.css: Added.
  • public/v2/data.js: Added.
  • public/v2/index.html: Added.
  • public/v2/js: Added.
  • public/v2/js/d3: Added.
  • public/v2/js/d3/LICENSE: Added.
  • public/v2/js/d3/d3.js: Added.
  • public/v2/js/d3/d3.min.js: Added.
  • public/v2/js/ember-data.js: Added.
  • public/v2/js/ember.js: Added.
  • public/v2/js/handlebars.js: Added.
  • public/v2/js/jquery.min.js: Added.
  • public/v2/js/statistics.js: Added.
  • public/v2/manifest.js: Added.
  • public/v2/popup.js: Added.
1:30 PM Changeset in webkit [174476] by jer.noble@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed clean up of inadventant double-ChangeLog.

1:26 PM Changeset in webkit [174475] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed follow-up fix for r174460. Do not register for KVOs if the object does not respond to the requested property.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(-[CDMSessionMediaSourceAVFObjCObserver beginObserving:]):
(-[CDMSessionMediaSourceAVFObjCObserver stopObserving:]):
(-[CDMSessionMediaSourceAVFObjCObserver invalidate]):

1:26 PM Changeset in webkit [174474] by jer.noble@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Layout Test media/track/track-forced-subtitles-in-band.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=137505

Reviewed by Simon Fraser.

Now that the media controls can have audio as well as text tracks, use the aria-labelledby attribute
to get the <ul> containing the text track menu list items.

  • media/track/track-forced-subtitles-in-band.html:
  • media/track/track-user-preferences-expected.txt:
  • media/track/track-user-preferences.html:
  • media/trackmenu-test.js:

(trackMenuListByLabel):
(captionTrackMenuList):
(audioTrackMenuList):
(indexOfMenuItemBeginningWith):
(indexOfCaptionMenuItemBeginningWith):
(indexOfAudioTrackMenuItemBeginningWith):
(selectMenuItemFromList):
(selectCaptionMenuItem):
(selectAudioTrackMenuItem):
(listTrackMenu):
(trackMenuList): Deleted.

  • media/video-controls-audiotracks-trackmenu.html:
  • media/video-controls-captions-trackmenu-includes-enabled-track.html:
  • media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html:
  • media/video-controls-captions-trackmenu.html:
1:16 PM Changeset in webkit [174473] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[WinCairo] Enable JIT on 32-bit.
​https://bugs.webkit.org/show_bug.cgi?id=137521

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-10-08
Reviewed by Mark Lam.

Enable JIT on Windows 32-bit, but disable it at runtime if SSE2 is not present.

Source/JavaScriptCore:

  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.pl:
  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):

Source/WTF:

  • wtf/Platform.h:
1:04 PM Changeset in webkit [174472] by jer.noble@apple.com
  • 10 edits in trunk/LayoutTests

Layout Test media/track/track-forced-subtitles-in-band.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=137505

Reviewed by Simon Fraser.

Now that the media controls can have audio as well as text tracks, use the aria-labelledby attribute
to get the <ul> containing the text track menu list items.

  • media/track/track-forced-subtitles-in-band.html:
  • media/track/track-user-preferences-expected.txt:
  • media/track/track-user-preferences.html:
  • media/trackmenu-test.js:

(trackMenuListByLabel):
(captionTrackMenuList):
(audioTrackMenuList):
(indexOfMenuItemBeginningWith):
(indexOfCaptionMenuItemBeginningWith):
(indexOfAudioTrackMenuItemBeginningWith):
(selectMenuItemFromList):
(selectCaptionMenuItem):
(selectAudioTrackMenuItem):
(listTrackMenu):
(trackMenuList): Deleted.

  • media/video-controls-audiotracks-trackmenu.html:
  • media/video-controls-captions-trackmenu-includes-enabled-track.html:
  • media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html:
  • media/video-controls-captions-trackmenu.html:
1:01 PM Changeset in webkit [174471] by Brent Fulgham
  • 16 edits in trunk/Tools

[Win] Resolve various static analyzer warnings in Tools.
​https://bugs.webkit.org/show_bug.cgi?id=137534

Reviewed by Dean Jackson.

  • DumpRenderTree/cg/ImageDiffCG.cpp:

(main): User proper printf specifiers.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::childrenCount): Handle possibility that
gcc_accChildCount returns with an error.
(accessibilityState): Ditto for gcc_accState.

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:

(DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
check for return value from 'isHTML'. HRESULT is not a boolean and cannot
be treated as such.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
by comparing an unsigned value as being greater-than zero.

  • DumpRenderTree/win/EditingDelegate.cpp:

(dump): Pass proper character pointer type to printf.
(EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
(EditingDelegate::shouldEndEditingInDOMRange): Ditto.
(EditingDelegate::shouldInsertNode): Ditto.
(EditingDelegate::shouldInsertText): Ditto.
(EditingDelegate::shouldDeleteDOMRange): Ditto.
(EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
(EditingDelegate::shouldApplyStyle): Ditto.

  • DumpRenderTree/win/EventSender.cpp:

(beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.

  • DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match

system headers.

  • DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure

from CreateDIBSection.

  • DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
  • TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under

older versions of MSVC we no longer support.

  • TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API

for 64-bit builds.

  • TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
  • TestWebKitAPI/TestsController.h: Ditto.
  • WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
  • WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid

performing bitwise | before the comparison is done.

12:34 PM Changeset in webkit [174470] by Brent Fulgham
  • 6 edits in trunk/Source/WebKit/win

[Win] Resolve various static analyzer warnings in WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=137531

Reviewed by Dean Jackson.

  • MarshallingHelpers.cpp:

(MarshallingHelpers::safeArrayToIntArray): Handle possible failure of
SafeArrayGetElement call.
(MarshallingHelpers::safeArrayToIUnknownArray): Ditto.

  • MemoryStream.cpp:

(MemoryStream::CopyTo): Zero-initialize 'written' to silence warning.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::exceededDatabaseQuota): Handle possible failure of
GetModuleFileName.

  • WebHistory.cpp:

(getDayBoundaries): Handle possible failure of TzSpecificLocalTimeToSystemTime

  • WebView.cpp:

(WebView::shouldInitializeTrackPointHack): Zero initialize return value.
(WebView::dispatchDidReceiveIconFromWebFrame): Avoid possible DeleteObject
call on a null bitmap handle.
(WebView::standardUserAgentWithApplicationName): Get rid of spurious
pointer dereference.

12:24 PM Changeset in webkit [174469] by dino@apple.com
  • 5 edits in trunk

Add deprecation warning for CSSKeyframesRule::appendRule
​https://bugs.webkit.org/show_bug.cgi?id=137532
<rdar://problem/18585745>

Reviewed by Brent Fulgham.

Source/WebCore:

In r173982 (webkit.org/b/57910) we added insertRule to match
the spec. We should print a warning to the JS console suggesting
users move to insertRule.

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::appendRule): Add a message to the system
console.

  • css/WebKitCSSKeyframesRule.h:

LayoutTests:

Update test expectations to include console message.

  • animations/change-keyframes-expected.txt:
12:21 PM Changeset in webkit [174468] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Remove superfluously duplicated code in public/api/report-commits.php.

12:21 PM Changeset in webkit [174467] by Brent Fulgham
  • 2 edits in trunk/Source/ThirdParty/ANGLE

[Win] Use proper v120 target for 64-bit builds.

  • ANGLE.vcxproj/libEGL.vcxproj:
12:21 PM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
11:55 AM Changeset in webkit [174466] by mmaxfield@apple.com
  • 5 edits
    2 adds in trunk

Text drawn with an SVG font has no spaces when word-rounding hacks are enabled
​https://bugs.webkit.org/show_bug.cgi?id=137463

Reviewed by Darin Adler.

Source/WebCore:

When rounding hacks are enabled, we use the "adjusted space width" instead of the
regular space width. However, the SVG-font-specific implementation of the
SimpleFontData constructor doesn't initialize this value, so it was getting set
to an undefined value (which happened to be close to 0 in my tests).

Test: svg/text/svg-font-word-rounding-hacks-spaces.html

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):
(WebCore::CSSFontFaceSource::ensureFontData):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::getSVGFontById):

  • platform/graphics/SimpleFontData.h:
  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::initializeFontData):

LayoutTests:

Make sure that spaces are present.

  • svg/text/svg-font-word-rounding-hacks-spaces.html:
  • svg/text/svg-font-word-rounding-hacks-spaces-expected.html:
11:32 AM Changeset in webkit [174465] by Brent Fulgham
  • 12 edits in trunk/Source/WebCore

[Win] Resolve various static analyzer warnings in WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=137526

Reviewed by Dean Jackson.

A series of small changes to resolve various issues found by the MSVC static analyzer.

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::clear): Add assertion that it->value should never be null.

  • page/SessionIDHash.h:

(WTF::HashTraits<WebCore::SessionID>::constructDeletedValue): Add explicit cast to avoid
compiler warning.
(WTF::HashTraits<WebCore::SessionID>::isDeletedValue): Ditto.

  • page/win/FrameCGWin.cpp:

(WebCore::imageFromRect): Resolve static analyzer warnings by initializing bits, and
checking the return value of ::CreateDIBSection, which return nullptr on error.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(printLayer): Use correct MSVC format specifier for size_t.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::getLinkedFonts): Handle possibility that a font link key does not exist.
(WebCore::FontCache::systemFallbackForCharacters): Handle error case when a valid code page
does not exist for a given character.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::containsCharacters): Handle error cases for mapping to the CP_ACP code page,
and related failures when attempting to access the contents of a given code page.

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::itemizeShapeAndPlace): Handle possible failure in the
ScriptItemize API call.
(WebCore::UniscribeController::shapeAndPlaceItem): Ditto for ScriptXtoCP API call.

  • platform/win/BString.h: Use consistent SAL annotations for our typedeof of BSTR as in

the system header.

  • platform/win/COMPtr.h: Ditto for HRESULT.
  • platform/win/DragImageCGWin.cpp:

(WebCore::allocImage): Handle case of failing CreateDIBSection API call.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::show): Handle case of failing SystemParamtersInfo API call.
(WebCore::PopupMenuWin::wndProc): Ditto.

11:31 AM Changeset in webkit [174464] by Simon Fraser
  • 5 edits in trunk/LayoutTests

Remove tests that always pass from the TestExpectations files.

  • TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
11:20 AM Changeset in webkit [174463] by adachan@apple.com
  • 4 edits
    3 adds in trunk

Source/WebKit2:
Implement WKPageIsPlayingAudio().
​https://bugs.webkit.org/show_bug.cgi?id=137048

Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.cpp:

(WKPageIsPlayingAudio):

Tools:
Add a test for WKPageIsPlayingAudio().
​https://bugs.webkit.org/show_bug.cgi?id=137048

Reviewed by Darin Adler.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.

  • TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.

(TestWebKitAPI::nullJavaScriptCallback):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::isPlayingAudioDidChangeCallback):
(TestWebKitAPI::setUpClients):
(TestWebKitAPI::TEST):
This test loads a page with a video in it. When the page is loaded, we first check that
WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
now returns true for the page.

  • TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
  • TestWebKitAPI/Tests/WebKit2/test.mp4: Added.

This is a video copied from LayoutTests/media/content.

10:56 AM Changeset in webkit [174462] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Win] Resolve warnings about missing has_include macro under MSVC
​https://bugs.webkit.org/show_bug.cgi?id=137524

Reviewed by Anders Carlsson.

  • wtf/Compiler.h: Provide a dummy implementation of has_include that

avoids the warning without changing compile behavior.

10:40 AM Changeset in webkit [174461] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
​https://bugs.webkit.org/show_bug.cgi?id=137516

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_irc):

10:32 AM Changeset in webkit [174460] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

[EME][Mac] Update CDMSessionMediaSourceAVFObjC to match new API provided by AVStreamSession
​https://bugs.webkit.org/show_bug.cgi?id=137469

Reviewed by Brent Fulgham.

Update our forward declaration to match the API provided by AVStreamSession.
AVStreamSession now takes an error: parameter in its initialiazer. It also provides the
sessionIdentifier used by the CDM, which CDMSessionMediaSourceAVFObjC will use as the
value of sessionId. Having this identifier allows us to fire a
secure-proof-of-key-release message after the client calls MediaKeySession.close().
Because this call will now generate messages, which have to be responded to in order
to remove those proofs from storage, do not clear the CDMSession from MediaKeySession
after calling close().

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::~MediaKeySession):
(WebCore::MediaKeySession::close):
(WebCore::MediaKeySession::setError): Deleted.
(WebCore::MediaKeySession::sessionId): Deleted.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:

(WebCore::CDMSessionMediaSourceAVFObjC::setSessionId):

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(-[CDMSessionMediaSourceAVFObjCListener initWithParent:]):
(-[CDMSessionMediaSourceAVFObjCObserver dealloc]):
(-[CDMSessionMediaSourceAVFObjCObserver beginObserving:]):
(-[CDMSessionMediaSourceAVFObjCObserver stopObserving:]):
(-[CDMSessionMediaSourceAVFObjCObserver invalidate]):
(-[CDMSessionMediaSourceAVFObjCListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC):
(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC):
(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys):
(WebCore::CDMSessionMediaSourceAVFObjC::update):
(WebCore::CDMSessionMediaSourceAVFObjC::addSourceBuffer):
(WebCore::CDMSessionMediaSourceAVFObjC::removeSourceBuffer):

10:20 AM Changeset in webkit [174459] by rniwa@webkit.org
  • 7 edits
    5 adds in trunk/Websites/perf.webkit.org

Perf dashboard should store commit logs
​https://bugs.webkit.org/show_bug.cgi?id=137510

Reviewed by Darin Adler.

For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.

This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
a subversion directory. The git version of this script will be added in a follow up patch.

In the new database schema, each revision in each repository is represented by exactly one row in "commits"
instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
relationship via "build_commits" relations.

In order to migrate an existing instance of this application, run the following SQL commands:

BEGIN;

INSERT INTO commits (commit_repository, commit_revision, commit_time)

(SELECT DISTINCT ON (revision_repository, revision_value)

revision_repository, revision_value, revision_time FROM build_revisions);

INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id

FROM commits, build_revisions
WHERE commit_repository = revision_repository AND commit_revision = revision_value;

DROP TABLE build_revisions;

COMMIT;

The helper script to submit commit logs can be used as follows:

python ./tools/pull-svn.py "WebKit" ​https://svn.webkit.org/repository/webkit/ ​https://perf.webkit.org

feeder-slave feeder-slave-password 60 "webkit-patch find-users"

The above command will pull the subversion server at ​https://svn.webkit.org/repository/webkit/ every 60 seconds
to retrieve at most 10 commits, and submits the results to ​https://perf.webkit.org using "feeder-slave" and
"feeder-slave-password" as the builder name and the builder password respectively.

The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
e.g. "webkit-patch find-users ​rniwa@webkit.org" yields "Ryosuke Niwa" <​rniwa@webkit.org> in the stdout.

  • init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
  • public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form

/api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:

  • Not specified - It returns every single commit for a given repository.
  • Matches "oldest" - It returns the commit with the oldest timestamp.
  • Matches "latest" - It returns the commit with the latest timestamp.
  • Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
  • Is entirely alphanumeric - It returns the commit whose revision matches the filter.
  • Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list of commits added via report-commits.php between two timestamps retrieved from commits whose revisions match the two alphanumeric values specified. Because it retrieves commits based on their timestamps, the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.

(main):
(commit_from_revision):
(fetch_commits_between):
(format_commits):

  • public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.

See tests/api-report-commits.js for examples on how to use this API.

  • public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of

"build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
to optimize this and other JSON APIs.

  • public/include/db.php:

(Database::select_or_insert_row):
(Database::update_or_insert_row): Added.
(Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.

(Database::select_first_row):
(Database::select_last_row): Added.
(Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
$order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.

  • public/include/report-processor.php:

(ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.

  • run-tests.js:

(pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.

  • tests/api-report-commits.js: Added.
  • tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
  • tools: Added.
  • tools/pull-svn.py: Added. See above for how to use this script.

(main):
(determine_first_revision_to_fetch):
(fetch_revision_from_dasbhoard):
(fetch_commit_and_resolve_author):
(fetch_commit):
(textContent):
(resolve_author_name_from_email):
(submit_commits):

10:16 AM Changeset in webkit [174458] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r174403): media/track/track-forced-subtitles-in-band.html fails
​https://bugs.webkit.org/show_bug.cgi?id=137525

  • TestExpectations: Marked media/track/track-forced-subtitles-in-band.html as an expected failure.
10:14 AM Changeset in webkit [174457] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r174456.

I was comparing a signed int to an unsigned one.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::shouldAutoActivateFontIfNeeded):

9:20 AM Changeset in webkit [174456] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

[Mac] We are spending a lot of time loading fonts when loading weather.com
​https://bugs.webkit.org/show_bug.cgi?id=137454

Reviewed by Darin Adler.

We are spending a lot of time loading fonts when loading weather.com:
~4.2% of WebProcess's cpu time in FontCache::getCachedFrontData().
In particular, we are spending a lot of time doing font auto-activation
because we don't have the Open Sans fonts installed and weather.com is
trying to load those.

Before this patch, we were doing font auto-activation ~250 times when
loading weather.com, even though the site is loading ~10 distinct font
families.

This patch adds a cache of font families we already tried to
auto-activate so that we don't try again. This results in ~10 font
auto-activations when loading weather.com instead of 250. It reduces
the amount of time spent in getCachedFrontData() to 62.6ms from 276ms
(4.4x less) when loading weather.com.

No new tests, no behavior change.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::shouldAutoActivateFontIfNeeded):
(WebCore::FontCache::createFontPlatformData):

  • platform/mac/WebFontCache.h:
  • platform/mac/WebFontCache.mm:

(+[WebFontCache fontWithFamily:traits:weight:size:shouldAutoActivateIfNeeded:]):
(+[WebFontCache fontWithFamily:traits:weight:size:]):
(+[WebFontCache fontWithFamily:traits:size:]):

9:18 AM Changeset in webkit [174455] by Brent Fulgham
  • 7 edits in trunk/Source/JavaScriptCore

[Win] Resolve some static analysis warnings in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=137508

Reviewed by Geoffrey Garen.

  • API/tests/testapi.c:

(assertEqualsAsCharactersPtr): MSVC insists on using %Iu as its format specifier
for size_t. Make the format string conditional on Windows.

  • bytecode/Watchpoint.h:

(JSC::InlineWatchpointSet::encodeState): Silence warning about left-shifting 'state'
as a 32-bit value before OR-ing it with a 64-bit value.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Silence warning about operator prescedence

causing the
operation to take place before the >= test.
  • dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::endBasicBlock): Ditto (
before !=)
  • testRegExp.cpp:

(testOneRegExp): Ditto %Iu format specifier.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): Silence warning about
using a 32-bit value as part of a 64-bit calculation.

8:16 AM Changeset in webkit [174454] by Carlos Garcia Campos
  • 8 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r174190 - Add basic caching for Document.cookie API
​https://bugs.webkit.org/show_bug.cgi?id=137225

Reviewed by Alexey Proskuryakov.

Source/WebCore:

While profiling the load of nytimes.com, I noticed that the site is
accessing ~250 times document.cookie, just during page load. Accessing
document.cookie is currently slow because we:

  • Call WebPlatformStrategies::cookiesForDOM() virtual function
  • Send a sync IPC message to the Network process to retrieve the cookies
    • The Network process gets the list of cookies from CFNetwork then serializes the result to send it back to the WebProcess
  • We unserialize the cookies into an NSList of cookies
  • We filter-out the cookies that are 'httpOnly' and construct a new NSList of cookies
  • We create a WTF String out of the cookies NSList

In the case of nytimes.com, it turns out that up to 100 calls to
document.cookie() are made in the same event loop iteration. This patch
thus caches / freezes the cookies until we return to the event
loop so that consecutive calls to document.cookie() are extremely fast.
Doing so seems to be sufficient to achieve a ~87% cache hit for
nytimes.com page load.

The cookies cache is invalidated whenever:

  • document.cookie is set
  • we return to the event loop
  • a network resource is loaded synchronously as it may cause cookies to be set before we return to the event loop

Test: http/tests/cookies/sync-xhr-set-cookie-invalidates-cache.html

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::open):
(WebCore::Document::cookie):
(WebCore::Document::setCookie):
(WebCore::Document::setCookieURL):
(WebCore::Document::initSecurityContext):
(WebCore::Document::setDOMCookieCache):
(WebCore::Document::invalidateDOMCookieCache):
(WebCore::Document::domCookieCacheExpiryTimerFired):
(WebCore::Document::didLoadResourceSynchronously):

  • dom/Document.h:

(WebCore::Document::domCookieCache):
(WebCore::Document::isDOMCookieCacheValid):
(WebCore::Document::setCookieURL): Deleted.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::didLoadResourceSynchronously):

  • dom/ScriptExecutionContext.h:
  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::loadResourceSynchronously):

LayoutTests:

Add a layout test to make sure that document.cookie returns updated
results after cookies are set via a sync XHR.

  • http/tests/cookies/sync-xhr-set-cookie-invalidates-cache-expected.txt: Added.
  • http/tests/cookies/sync-xhr-set-cookie-invalidates-cache.html: Added.
7:44 AM Changeset in webkit [174453] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
​https://bugs.webkit.org/show_bug.cgi?id=137520

Reviewed by Philippe Normand.

Debian is switching is default JPEG library to libjpeg-turbo <​https://wiki.debian.org/LJTTransition#Text>
For other distributions, we are already installing libjpeg-turbo.
So, do the same for Debian and derivatives.

  • gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
6:35 AM Changeset in webkit [174452] by Carlos Garcia Campos
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r174137 - Stack overflow with enormous SVG filter
​https://bugs.webkit.org/show_bug.cgi?id=63290

Prevent building an SVG filter if it has more than 200 FilterEffect nodes in its map
regardless whether they will be connected to its lastEffect or not. Also discard any
filter which has more 100 contributing FilterEffect nodes in its tree.

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2014-09-30
Reviewed by Dean Jackson.

Tests: svg/filters/svg-deeply-nested-crash.html

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::collectEffects):
(WebCore::FilterEffect::totalNumberOfEffectInputs):

  • platform/graphics/filters/FilterEffect.h:

-- Add a method to return the total number of input FilterEffect's contributing to a FilterEffect.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):
-- Do not build a filter if it has more than 200 FilterEffects in its map.
(WebCore::RenderSVGResourceFilter::applyResource):
-- Discard a filter after it was built if it has more than 100 FilterEffects in its tree.

LayoutTests:
Stack overflow with enormous SVG filter.
​https://bugs.webkit.org/show_bug.cgi?id=63290.

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2014-09-30
Reviewed by Dean Jackson.

Test if an SVG filter with deeply nested tree of FilterEffects can be loaded
with no crash. Make sure other valid filters can still be referenced by SVG
drawing elements. An SVG Filter will be ignored if the number of effects in
its map is greater than 200 or the total number of effects connected to its
last effect is greater than 100.

  • svg/filters/svg-deeply-nested-crash-expected.txt: Added.
  • svg/filters/svg-deeply-nested-crash.html: Added.
6:25 AM Changeset in webkit [174451] by Darin Adler
  • 5 edits in trunk/Source/WebCore

ASSERTION FAILED: underlyingStringIsValid()
​https://bugs.webkit.org/show_bug.cgi?id=137502

Reviewed by Anders Carlsson.

  • rendering/RenderTreeAsText.cpp:

(WebCore::quoteAndEscapeNonPrintables): Take a StringView instead of a String.
(WebCore::writeTextRun): Ditto.
(WebCore::writeSimpleLine): Ditto.

  • rendering/RenderTreeAsText.h: Removed unneeded include, tweaked formatting,

changed quoteAndEscapeNonPrintables to take a StringView.

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow): Tighten code using a modern for loop.
(WebCore::SimpleLineLayout::showLineLayoutForFlow): Update to work with a
StringView result for SimpleLineLayout::RunResolver::Run::text.

  • rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::Run::text): Changed return type to
StringView to fix the lifetime bug and also to improve performance by getting
rid of the need to allocate and destroy a StringImpl object.

6:24 AM Changeset in webkit [174450] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r174126 - Remove a multicolumn ASSERT and replace with a guard.
​https://bugs.webkit.org/show_bug.cgi?id=137272

Reviewed by Alexey Proskuryakov.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
For now remove the assert that is tripping and replace it with a guard
until we can figure out why it's getting hit.

6:20 AM Changeset in webkit [174449] by Carlos Garcia Campos
  • 5 edits
    4 adds in releases/WebKitGTK/webkit-2.6

Merge r174097 - Caret not shown at the end of line in overtype mode
​https://bugs.webkit.org/show_bug.cgi?id=135508

Reviewed by Ryosuke Niwa.

Source/WebCore:

When overtype mode is enabled we usually replace the 'normal'
blinking caret shown in contenteditable elements by a block cursor
that covers the next character to be replaced. The exception is the
end of line where we fallback to the blinking caret even in overtype
mode (as there is no next character to replace).

We were not showing anything at the end of lines in overtype mode
because the detection of the end of line was incorrect and not very
understandable. Replaced the old code with a proper and clean end of
line detection mechanism compatible with bidi text.

Tests: editing/selection/block-cursor-overtype-mode-end-of-line-rtl.html

editing/selection/block-cursor-overtype-mode-end-of-line.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAppearance):

  • editing/VisibleUnits.cpp:

(WebCore::isLogicalEndOfLine):

  • editing/VisibleUnits.h:

LayoutTests:

  • editing/selection/block-cursor-overtype-mode-end-of-line-expected.html: Added.
  • editing/selection/block-cursor-overtype-mode-end-of-line-rtl-expected.html: Added.
  • editing/selection/block-cursor-overtype-mode-end-of-line-rtl.html: Added.
  • editing/selection/block-cursor-overtype-mode-end-of-line.html: Added.
6:19 AM Changeset in webkit [174448] by evab.u-szeged@partner.samsung.com
  • 2 edits in trunk/Tools

[webkitpy] Add back the workaround to replace ZipFile.extractall()
​https://bugs.webkit.org/show_bug.cgi?id=137519

Reviewed by Csaba Osztrogonác.

It was removed by <​http://trac.webkit.org/changeset/174266>,
because the comment stated it is a workaround for buggy python
2.6.1 which shipped on Snow Leopard. But it turned out the bug
is still valid with python 2.7 shipped on the latest Ubuntu
(12.04 and 14.04) and OS X 10.9.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller):
(AutoInstaller._extract_all):
(AutoInstaller._unzip):

6:18 AM Changeset in webkit [174447] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r174085 - REGRESSION (r168046): Confused column spans when combined with dynamic animations
​https://bugs.webkit.org/show_bug.cgi?id=134048.

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/multicol/multicol-fieldset-span-changes.html

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::processPossibleSpannerDescendant):
Refactor handling of insertions into the multicolumn flow thread into
a helper function, processPossibleSpannerDescendant. This makes it easier
to call the code from more than one place.

(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted):
Modify the nested columns span shifting code to avoid problems. The
new code suppresses notifications and does the move of the spanner back
into the original spot *before* removing the placeholder. This ensures that
the placeholder parent still exists.

The stale placeholder is then removed and destroyed after the spanner has been put back
into place.

(WebCore::RenderMultiColumnFlowThread::handleSpannerRemoval):
(WebCore::RenderMultiColumnFlowThread::flowThreadRelativeWillBeRemoved):
Refactor the removal notifications for spanners into a helper function so that it can
be called to do cleanup from the code that cleans up stale placeholders on a shift.

  • rendering/RenderMultiColumnFlowThread.h:

Modified to add the new helpers.

LayoutTests:

  • fast/multicol/multicol-fieldset-span-changes-expected.txt: Added.
  • fast/multicol/multicol-fieldset-span-changes.html: Added.
6:16 AM Changeset in webkit [174446] by Carlos Garcia Campos
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r174074 - AX: in an aria-labelledby computation, do not traverse into elements whose nameFrom value does not include 'contents'
​https://bugs.webkit.org/show_bug.cgi?id=136714

Reviewed by Darin Adler.

Source/WebCore:

There are certain ARIA elements that tell us we should not query their children when determining the name of the object.
Those ones have the "nameFrom" property set to "author" instead of "contents." WebKit needs to honor that status.

Test: accessibility/aria-namefrom-author.html

Modified: accessibility/aria-labelledby-with-descendants.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::shouldUseAccessiblityObjectInnerText):
(WebCore::shouldAddSpaceBeforeAppendingNextElement):
(WebCore::appendNameToStringBuilder):
(WebCore::AccessibilityNodeObject::textUnderElement):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibleNameDerivesFromContent):
(WebCore::initializeRoleMap):

  • accessibility/AccessibilityObject.h:

LayoutTests:

  • accessibility/aria-labelledby-with-descendants-expected.txt:
  • accessibility/aria-labelledby-with-descendants.html:
  • accessibility/aria-namefrom-author-expected.txt: Added.
  • accessibility/aria-namefrom-author.html: Added.
6:11 AM Changeset in webkit [174445] by Carlos Garcia Campos
  • 11 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r174040 - HTMLPlugInElement::isUserObservable() is causing layout
​https://bugs.webkit.org/show_bug.cgi?id=137156

Reviewed by Ryosuke Niwa.

While profiling the page load of nytimes.com, I noticed that we were
spending ~4-5% of cpu time in HTMLPlugInElement::isUserObservable().
The reason is that the function calls pluginWidget(), which causes a
layout update in HTMLObjectElement::renderWidgetForJSBindings(), to
make sure the plugin is loaded and its renderer is created.

HTMLPlugInElement::isUserObservable() shouldn't need to do a layout.
This patch does the following to address the problem:

  • Rename renderWidgetForJSBindings() to renderWidgetLoadingPlugin() because this function is not always called from the JS Bindings nowadays. The new name makes it clearer that this will load the plugin if needed (to make sure the renderer is created, and by doing a layout).
  • Add a PluginLoadingPolicy argument to HTMLPlugInElement::pluginWidget() to let the caller control if the plugin should be loaded or not.
  • Update the call to pluginWidget() in isUserObservable() so that we do not attempt to load the plugin (thus not causing a layout).

No new tests, no behavior change.

  • WebCore.exp.in:
  • WebCore.order:
  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::renderWidgetLoadingPlugin):
(WebCore::HTMLAppletElement::renderWidgetForJSBindings): Deleted.

  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::renderWidgetLoadingPlugin):
(WebCore::HTMLEmbedElement::renderWidgetForJSBindings): Deleted.

  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderWidgetLoadingPlugin):
(WebCore::HTMLObjectElement::renderWidgetForJSBindings): Deleted.

  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::pluginWidget):
(WebCore::HTMLPlugInElement::isUserObservable):

  • html/HTMLPlugInElement.h:
6:06 AM Changeset in webkit [174444] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebInspectorUI

Merge r174019 - Web Inspector: Type Token View shows type information on hover when it shouldn't
​https://bugs.webkit.org/show_bug.cgi?id=137152

Reviewed by Brian J. Burg.

TypeTokenView should only show type information when there is
more than one primitive type or more than zero objects types.
This fixes a bug in checking the length of object types.

  • UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView.prototype._shouldShowPopover):

6:05 AM Changeset in webkit [174443] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore

Merge r174012 - Fix typo in YARR at BOL check
​https://bugs.webkit.org/show_bug.cgi?id=137144

Reviewed by Darin Adler.

  • yarr/YarrPattern.cpp: replace bitwise and operator by logical and

(JSC::Yarr::YarrPatternConstructor::assertionBOL):

6:03 AM Changeset in webkit [174442] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r174014 - StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)
​https://bugs.webkit.org/show_bug.cgi?id=129642

Apply post-review comments from Alexey Proskuryakov.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::deleteEmptyDatabase): Make a thread-safe isolated copy of the string.

6:01 AM Changeset in webkit [174441] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.6/Source

Merge r173994 - Web Inspector: console.assert(bitString) TypeSet:50
​https://bugs.webkit.org/show_bug.cgi?id=137051

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

This patch creates stricter requirements on a TypeDescription
being valid. To be valid, a TypeDescription now ensures that
the TypeSet it describes has non null type information.

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

  • runtime/TypeSet.h:

(JSC::TypeSet::isEmpty):

Source/WebInspectorUI:

This fixes TypeSet's isContainedIn method by ensuring that
the type bit string isn't zero because the test would trivially
pass if the bit string is zero.

  • UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet.prototype.isContainedIn):

5:33 AM Changeset in webkit [174440] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6

Merge r173991 - StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)
​https://bugs.webkit.org/show_bug.cgi?id=129642

Reviewed by Brady Eidson.

Source/WebCore:

When tearing down the inspector frontend's page, we trigger a threading violation
in StorageAreaSync's final sync code underneath StorageAreaSync::deleteEmptyDatabase().

No new tests. Regression is covered by inspector/test-harness-trivially-works.html.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::deleteEmptyDatabase): add a missing callOnMainThread() when
calling StorageTracker::deleteOriginWithIdentifier().

LayoutTests:

Remove the blanket Skip for all tests in inspector/.

  • TestExpectations: clean up expectations for inspector/ and add new tracking bugs.
5:29 AM Changeset in webkit [174439] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r173973 - CommitLayerTree decode fails in 32-bit apps on 64-bit devices (TransformationMatrix alignment differs)
​https://bugs.webkit.org/show_bug.cgi?id=136444
<rdar://problem/17952526>

Reviewed by Anders Carlsson.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TransformationMatrix>::encode):
(IPC::ArgumentCoder<TransformationMatrix>::decode):
Stop using SimpleArgumentCoder to encode/decode TransformationMatrix,
because the alignment of TransformationMatrix differs between architectures,
and there's no guarantee that both sides of a connection are the same architecture.

5:27 AM Changeset in webkit [174438] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r173965 - ASSERTION FAILED: columnCount in WebCore::CSSParser::parseGridTemplateAreasRow
​https://bugs.webkit.org/show_bug.cgi?id=136945

Reviewed by Sergio Villar Senin.

Source/WebCore:

Checking out whether the grid-template-areas value contains a white-space only
string, which is not valid as it does not produce a cell token.

Test: fast/css-grid-layout/grid-template-areas-empty-string-crash.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTemplateAreasRow):

LayoutTests:

Testing the different types of white-space only strings for the grid-template-areas
property, which is not valid as it does not produce a cell token.

  • fast/css-grid-layout/grid-template-areas-empty-string-crash-expected.txt: Added.
  • fast/css-grid-layout/grid-template-areas-empty-string-crash.html: Added.
4:41 AM Changeset in webkit [174437] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173945 - Use tighter typing for render objects in RenderGeometryMap
​https://bugs.webkit.org/show_bug.cgi?id=137102

Reviewed by Ryosuke Niwa.

Use tighter typing for render objects in RenderGeometryMap for clarity
and efficiency.

In particular, using RenderElement type instead of RenderObject
in canMapBetweenRenderers() allows us to call the faster
RenderElement::style() instead of RenderObject::style().

No new tests, no behavior change.

  • rendering/RenderGeometryMap.cpp:

(WebCore::canMapBetweenRenderers):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):

4:40 AM Changeset in webkit [174436] by Carlos Garcia Campos
  • 8 edits
    3 adds in releases/WebKitGTK/webkit-2.6

Merge r173943 - Old Turkic characters behave as left-to-right instead of right-to-left, because they are encoded as surrogate pairs.
​https://bugs.webkit.org/show_bug.cgi?id=70029

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/text/international/old-turkic-direction.html

  • CMakeLists.txt: Added InlineIterator.cpp.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/RenderingAllInOne.cpp: Ditto.
  • rendering/InlineIterator.cpp: Added.

(WebCore::InlineIterator::surrogateTextDirection): New function used to compute the direction
when a surrogate pair is involved.

  • rendering/InlineIterator.h: Made the characterAt function private.

(WebCore::InlineIterator::previousInSameNode): Took out unneeded range check. A zero will underflow
and become a large number and the characterAt function will return 0 in that case.
(WebCore::InlineIterator::direction): Added code to check U16_IS_SINGLE before calling
u_charDirection, and call surrogateTextDirection instead.

LayoutTests:

  • fast/text/international/old-turkic-direction.html: Added.
  • fast/text/international/old-turkic-direction-expected.html: Added.
4:38 AM Changeset in webkit [174435] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL][CoordinatedGraphics] All EFL layout tests are broken since r174231
​https://bugs.webkit.org/show_bug.cgi?id=137443

Reviewed by Zoltan Herczeg.

EFL layout test and MiniBrowser have broken since r174231. r174231 was to move PageOverlay implementation
from WebKit2 to WebCore with lazy initializing of PageOverlayController. It caused all EFL layout tests
crash and build break. To restore EFL layout test, this patch sets viewOverlayRootLayer through
attachViewOverlayGraphicsLayer() as mac port's one in r174231.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

(WebKit::CoordinatedDrawingArea::attachViewOverlayGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::updateRootLayers):
(WebKit::CoordinatedLayerTreeHost::setViewOverlayRootLayer):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
4:34 AM Changeset in webkit [174434] by Carlos Garcia Campos
  • 9 edits
    2 deletes in releases/WebKitGTK/webkit-2.6

Merge r173941 - REGRESSION: Text with a zero offset, zero blur shadow vanishes
​https://bugs.webkit.org/show_bug.cgi?id=136801

Reviewed by Darin Adler.

Source/WebCore:

This patch performs some cleanup regarding TextPainter's shadow logic and handles an
additional case of empty shadows. Previously, there was tight coupling between
applyShadowToGraphicalContext() and paintTextWithShadows(), as they both used a
collection of variables to determine how shadows are to be drawn. This complexity has
been moved into a helper class, ShadowApplier, which performs what
applyShadowToGraphicsContext() used to do, and cleans up correctly in its destructor.
This removes the tight coupling mentioned earlier.

Test: fast/text/empty-shadow.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::applyShadowToGraphicsContext): Moved to ShadowApplier.

  • rendering/InlineTextBox.h: Deleted applyShadowToGraphicsContext signature.
  • rendering/TextPainter.cpp:

(WebCore::ShadowApplier::ShadowApplier): Perform the contents of applyShadowToGraphicsContext()
(WebCore::ShadowApplier::~ShadowApplier): Undo the work done previously
(WebCore::paintTextWithShadows): Create a ShadowApplier to do the relevant shadow work. In addition,
refactor some boolean flags to more meaningful ones with relation to the computation at hand.
(WebCore::isEmptyShadow): Moved to TextPainter.h, named shadowIsCompletelyCoveredByText()

  • rendering/TextPainter.h:

(WebCore::ShadowApplier::ShadowApplier): Moved from InlineTextBox::applyShadowToGraphicsContext().
(WebCore::ShadowApplier::extraOffset): Getter.
(WebCore::ShadowApplier::~ShadowApplier): Moved from TextPainter::paintTextWithShadows().
(WebCore::isLastShadowIteration): Helper function.
(WebCore::shadowIsCompletelyCoveredByText): Determines whether or not we should not draw the shadow.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintTextWithShadows): Update to use ShadowApplier.

LayoutTests:

This test should be a comprehensive test of empty shadows. It tests every
combination of one and two shadows being empty, as well as transparent and
opaque text.

After updating fast/text/empty-shadow.html, fast/text/empty-shadow-with-color.html
is no longer necessary.

  • fast/text/empty-shadow-expected.html:
  • fast/text/empty-shadow-with-color-expected.html: Removed.
  • fast/text/empty-shadow-with-color.html: Removed.
  • fast/text/empty-shadow.html:
4:23 AM Changeset in webkit [174433] by Carlos Garcia Campos
  • 3 edits
    8 adds in releases/WebKitGTK/webkit-2.6

Merge r173906 - The style resolution cache applies properties incorrectly whenever direction != ltr
​https://bugs.webkit.org/show_bug.cgi?id=137052

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-23
Reviewed by Andreas Kling.

Source/WebCore:

The optimization r135021 introduced a bug whenever the direction of subtree is not
uniform in the whole page.

When StyleResolver::applyMatchedProperties() resolves the style, some properties are
resolved differently based on the writing-mode and the direction.

In isCacheableInMatchedPropertiesCache(), the cases for writing-mode are already handled
by not caching any style with anything else than the default.
The direction was ignored, causing the bugs solved here.

Tests: css3/flexbox/flex-flow-2.html

fast/css/style-resolver-cache-direction-1.html
fast/css/style-resolver-cache-direction-2.html
fast/css/style-resolver-cache-direction-3.html

  • css/StyleResolver.cpp:

(WebCore::isCacheableInMatchedPropertiesCache):

LayoutTests:

  • css3/flexbox/flex-flow-2-expected.txt: Added.
  • css3/flexbox/flex-flow-2.html: Added.

The test flex-flow.html should have uncovered the bug. It did not because it uses
:nth-child(), which disable style optimizations.

flex-flow-2.html is a copy of flex-flow.html using classes instead of :nth-child().
This would have caught the bug.

  • fast/css/style-resolver-cache-direction-1-expected.html: Added.
  • fast/css/style-resolver-cache-direction-1.html: Added.
  • fast/css/style-resolver-cache-direction-2-expected.html: Added.
  • fast/css/style-resolver-cache-direction-2.html: Added.
  • fast/css/style-resolver-cache-direction-3-expected.html: Added.
  • fast/css/style-resolver-cache-direction-3.html: Added.

New basic tests for the fix.

4:20 AM Changeset in webkit [174432] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Tools

Merge r173887 - [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
​https://bugs.webkit.org/show_bug.cgi?id=137031

Reviewed by Joseph Pecoraro.

commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
ChangeLog locations before passing them to createCommitMessage().

  • Scripts/commit-log-editor:
4:19 AM Changeset in webkit [174431] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173865 - Ensure that layout is up-to-date before hit-testing via RenderView
​https://bugs.webkit.org/show_bug.cgi?id=136651

Reviewed by David Hyatt.

Ensure that layout is up-to-date before we do hit-testing via the RenderView.
Previously, RenderLayer::hitTest() called updateLayout(), but it's better
to push that responsibility onto RenderView before entering the RenderLayer
tree.

Make callers a little more consistent in getting the RenderView via
Frame::contentRenderer(), though perhaps we should remove that and just
call Document::renderView() everywhere.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press): Hit test via the RenderView, rather
than doing so on the RenderView's layer, to ensure that we updateLayout().

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityHitTest): This code calls
hitTest() on arbitrary layers, so needs to explicitly update layout.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::contains):

  • page/EventHandler.cpp:

(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint): The explicit updateLayout() is
no longer needed.
(WebCore::EventHandler::updateCursor):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::hitTestResultInFrame):

  • page/Frame.cpp:

(WebCore::Frame::contentRenderer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

  • rendering/RenderView.cpp:

(WebCore::RenderView::hitTest): Here's where we ensure that layout is up-to-date.

4:15 AM Changeset in webkit [174430] by Carlos Garcia Campos
  • 11 edits
    4 adds in releases/WebKitGTK/webkit-2.6

Merge r173784 - Latching in iframes is not working as expected
​https://bugs.webkit.org/show_bug.cgi?id=136729
<rdar://problem/18370549>

Reviewed by Simon Fraser.

Source/WebCore:

Test: platform/mac/fast/scrolling/scrolling-iframe-100pct.html

Correct latching behavior by moving the concept of latching from the event handler to the main frame.
The event handlers are per-document, and can improperly latch to the iframe element (rather than the
scrollable content of the iframe) resulting in incorrect behavior.

Also move the wheel event delta tracking to the main frame, as this is similarly "top-level" in nature.

  • WebCore.vcxproj/WebCore.vcxproj: Add new LatchedState class.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Update constructor after moving some members to the new
LatchedState object.
(WebCore::EventHandler::clear): Call 'clear' on the LatchedState class.
(WebCore::EventHandler::platformRecordWheelEvent): Update for new LatchedState class.
(WebCore::EventHandler::handleWheelEvent): Ditto.
(WebCore::EventHandler::clearLatchedState): Ditto.
(WebCore::EventHandler::defaultWheelEventHandler): Ditto.

  • page/EventHandler.h:
  • page/LatchedState.cpp: Added.

(WebCore::LatchedState::LatchedState):
(WebCore::LatchedState::~LatchedState):
(WebCore::LatchedState::clear):
(WebCore::LatchedState::setWheelEventElement):
(WebCore::LatchedState::setWidgetIsLatched):
(WebCore::LatchedState::setPreviousWheelScrolledElement):
(WebCore::LatchedState::setScrollableContainer):

  • page/LatchedState.h: Added.

(WebCore::LatchedState::wheelEventElement):
(WebCore::LatchedState::frame):
(WebCore::LatchedState::setFrame):
(WebCore::LatchedState::widgetIsLatched):
(WebCore::LatchedState::previousWheelScrolledElement):
(WebCore::LatchedState::scrollableContainer):
(WebCore::LatchedState::startedGestureAtScrollLimit):
(WebCore::LatchedState::setStartedGestureAtScrollLimit):

  • page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame): Update for new members (LatchedState and WheelEventDeltaTracker)

  • page/MainFrame.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformPrepareForWheelEvents): Use mainFrame-located latching information.
(WebCore::EventHandler::platformRecordWheelEvent): Use mainFrame-located wheel event delta tracking.
(WebCore::EventHandler::platformCompleteWheelEvent): Make sure to use the latched frame as well as
the latched element so that events get routed properly.
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Update for new mainFrame
location for latched state information.

LayoutTests:

  • platform/mac/fast/scrolling/scroll-iframe-webkit1-latching-bug-expected.txt: Added.
  • platform/mac/fast/scrolling/scroll-iframe-webkit1-latching-bug.html: Added.
4:08 AM Changeset in webkit [174429] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.6/Source

Merge r173766 - Provide a default argument for the most commonly used HitTestRequest variant
​https://bugs.webkit.org/show_bug.cgi?id=136653

Reviewed by Darin Adler.

Make the default HitTestRequest flags be ReadOnly | Active | DisallowShadowContent
and change call sites using the default flags to use a HitTestRequest temporary.

Source/WebCore:

  • dom/TreeScope.cpp:

(WebCore::nodeFromPoint):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::contains):

  • page/DragController.cpp:

(WebCore::elementUnderMouse):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleMousePressEvent):

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::HitTestRequest):

Source/WebKit2:

  • WebProcess/WebPage/ViewGestureGeometryCollector.cpp:

(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):

3:42 AM Changeset in webkit [174428] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173783 - Minimize virtual function calls in MarkupAccumulator
​https://bugs.webkit.org/show_bug.cgi?id=136957

Reviewed by Benjamin Poulain.

This patch minimizes the number of virtual function calls in
MarkupAccumulator by:

  • De-virtualizing MarkupAccumulator::appendString(), which is never overridden
  • Having MarkupAccumulator::appendEndTag() virtual function take an Element in argument instead of a Node, as it only applies to Element. Also add a non-virtual overload that takes a Node in argument and that does the isElementNode() check so that we don't need to explicitly do the check at each call site.

No new tests, no behavior change.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendEndTag):
(WebCore::MarkupAccumulator::shouldSelfClose):
(WebCore::MarkupAccumulator::appendEndMarkup):

  • editing/MarkupAccumulator.h:

(WebCore::MarkupAccumulator::appendEndTag):

  • page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::appendEndTag):

3:37 AM Changeset in webkit [174427] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173769 - Add a size check for CSSSelector
​https://bugs.webkit.org/show_bug.cgi?id=136882

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-19
Reviewed by Christophe Dumez.

  • css/CSSSelector.cpp:
3:22 AM Changeset in webkit [174426] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Tools

Merge r174309 - [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
​https://bugs.webkit.org/show_bug.cgi?id=135502

Reviewed by Martin Robinson.

When writing to stdout/stderr fails due to a UnicodeDecodeError
exception, try again without encoding the output.

  • gtk/gtkdoc.py:

(GTKDoc._run_command):

3:19 AM Changeset in webkit [174425] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r174327 - [GTK] The new web inspector can't be docked again once undocked
​https://bugs.webkit.org/show_bug.cgi?id=121544

Reviewed by Martin Robinson.

Use a GtkHeaderBar for the inspector window to add dock buttons
when building with GTK+ >= 3.10.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::dockButtonClicked):
(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::updateInspectorWindowTitle):
(WebKit::WebInspectorProxy::platformInspectedURLChanged):
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged):

3:01 AM Changeset in webkit [174424] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r174316 - Unreviewed. Add missing inspector files to compilation.

  • PlatformGTK.cmake: Add javascript sources in

WebInspectorUI/UserInterface/External/Esprima to the list of
inspector files.

1:48 AM Changeset in webkit [174423] by gyuyoung.kim@samsung.com
  • 12 edits
    2 adds
    6 deletes in trunk

Unreviewed, rolling out r174335.
​https://bugs.webkit.org/show_bug.cgi?id=137515

It broke EFL layout test totally (Requested by gyuyoung on
#webkit).

Reverted changeset:

"[EFL] Introduce EWebKit_Extension"
​https://bugs.webkit.org/show_bug.cgi?id=134921
​http://trac.webkit.org/changeset/174335

Patch by Commit Queue <​commit-queue@webkit.org> on 2014-10-08

12:37 AM Changeset in webkit [174422] by Carlos Garcia Campos
  • 6 edits in trunk

[GTK] Make forwarding headers generation depend on source code
​https://bugs.webkit.org/show_bug.cgi?id=137394

Reviewed by Philippe Normand.

Source/WebKit2:

Only run generate-forwarding-headers.pl when source code changes
and use a different target for the symlinks.

  • PlatformGTK.cmake:

Tools:

  • TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
  • TestWebKitAPI/PlatformGTK.cmake: Only run

generate-forwarding-headers.pl when source code changes.

  • WebKitTestRunner/PlatformGTK.cmake: Ditto.
12:30 AM Changeset in webkit [174421] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.6/Tools

Merge r174093 - [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
​https://bugs.webkit.org/show_bug.cgi?id=137212

This moves TestNetscapePlugin to a new folder (lib/plugins).
We should not use the same directory for TestNetscapePlugin and
the other libraries, because we end up scanning all the .so in the
lib dir for every test.

Reviewed by Carlos Garcia Campos.

  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
  • Scripts/webkitpy/port/efl.py:

(EflPort.setup_environ_for_server): Update plugin path.

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server): Update plugin path.

  • TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
12:21 AM Changeset in webkit [174420] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6

Merge r174394 - [SOUP] TLS errors should take precedence over HTTP authentication
​https://bugs.webkit.org/show_bug.cgi?id=137300

Reviewed by Sergio Villar Senin.

Source/WebCore:

Handle TLS errors in got-headers callback to make sure it happens
before starting the authentication process.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::handleUnignoredTLSErrors): Refactored to receive the
soup message.
(WebCore::gotHeadersCallback): Return early and cancel the request in case of TLS errors.
(WebCore::sendRequestCallback): Do not handle TLS errors here, the request should have already been
cancelled at this point in case of TLS errors.

Tools:

Add a test case to check that authenticate signal is not emitted
in case of TLS errors, and the load fails instead.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(webViewAuthenticationCallback):
(testTLSErrorsHTTPAuth):
(httpsServerCallback):
(beforeAll):

Oct 7, 2014:

11:37 PM Changeset in webkit [174419] by commit-queue@webkit.org
  • 13 edits in trunk

[EFL] Enable custom URI schemes with CustomProtocols
​https://bugs.webkit.org/show_bug.cgi?id=128177

Patch by Pascal Jacquemart <​p.jacquemart@samsung.com> on 2014-10-07
Reviewed by Gyuyoung Kim.

Fixing ewk_context_url_scheme_register() ewebkit2 API
rely on r162449 - CustomProtocols implementation from Carlos Garcia Campos

.:

  • Source/cmake/OptionsEfl.cmake: Forcing CUSTOM_PROTOCOLS flag

Source/WebKit2:

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_url_scheme_request.cpp:

(EwkUrlSchemeRequest::EwkUrlSchemeRequest):
(EwkUrlSchemeRequest::finish):

  • UIProcess/API/efl/ewk_url_scheme_request_private.h:

(EwkUrlSchemeRequest::create):

  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

  • UIProcess/Network/CustomProtocols/soup/WebSoupCustomProtocolRequestManager.cpp:
  • UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
(WebKit::RequestManagerClientEfl::startLoading):
(WebKit::RequestManagerClientEfl::stopLoading):
(WebKit::RequestManagerClientEfl::registerURLSchemeHandler):
(WebKit::EwkUrlSchemeHandler::EwkUrlSchemeHandler): Deleted.
(WebKit::RequestManagerClientEfl::didReceiveURIRequest): Deleted.

  • UIProcess/efl/RequestManagerClientEfl.h:
  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/soup/WebContextSoup.cpp:

(WebKit::WebContext::platformInitializeNetworkProcess):

10:36 PM Changeset in webkit [174418] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove build warnings in Hashmap API tests
​https://bugs.webkit.org/show_bug.cgi?id=137484

Patch by Tanay C <​tanay.c@samsung.com> on 2014-10-07
Reviewed by Darin Adler.

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry)

10:17 PM Changeset in webkit [174417] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Remove WKPageCreateSnapshotOfVisibleContent API.
​https://bugs.webkit.org/show_bug.cgi?id=66979

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2014-10-07
Reviewed by Darin Adler.

After the landing of the first patch of webkit.org/b/66979,
WKPageCreateSnapshotOfVisibleContent API has been neglected for years.
Currently, this is not used anywhere and does not break the nightlies.
So we can remove this.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCreateSnapshotOfVisibleContent): Deleted.

  • UIProcess/API/C/WKPagePrivate.h:
9:51 PM Changeset in webkit [174416] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Call requestScrollPositionUpdate() instead of delegatedScrollRequested() in ScrollView::scrollTo()
​https://bugs.webkit.org/show_bug.cgi?id=137478

Reviewed by Benjamin Poulain.

As r174380 did, ScrollView::scrollTo() also calls requestScrollPositionUpdate() instead of delegatedScrollRequested().
delegatedScrollRequested() will be only called by requestScrollPositionUpdate(), and it needs to be merged by existing
other scroll request function.

No new tests, no behavior changes.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollTo):

8:48 PM Changeset in webkit [174415] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Remove WKPageSetInvalidMessageFunction.
​https://bugs.webkit.org/show_bug.cgi?id=137509

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2014-10-07
Reviewed by Benjamin Poulain.

According to the FIXME comment in WKPageSetInvalidMessageFunction,
we can remove this function when doing so won't break the nightlies.
Currently, this is not used anywhere and does not break the nightlies.
So we can remove this.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetInvalidMessageFunction): Deleted.

  • UIProcess/API/C/WKPagePrivate.h:
7:23 PM Changeset in webkit [174414] by dino@apple.com
  • 5 edits in trunk/Source/WebCore

Safari 8 on OSX 10.10 does not run WebGL in Retina HiDPI mode.
​https://bugs.webkit.org/show_bug.cgi?id=134854
<rdar://problem/18465263>

Reviewed by Tim Horton.

The NSOpenGLLayer has to have its contentScale property
set accordingly when on a retina display. Do this by
adding another value to the GraphicsContext3D creation
attribute dictionary, representing the device pixel ratio.
Then, when we come to draw into the layer, make sure
we set our GL viewport to the correct value.

This is currently untestable because:

  • we can't just read from the GL buffer as it is always correct
  • WebGL isn't working in reftests
  • a layer dump doesn't show the change since it was done in a CALayer subclass.
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create): Pass the devicePixelRatio into the attribute dictionary.

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes): Add a devicePixelRatio attribute.

  • platform/graphics/mac/WebGLLayer.h: New property to save us looking up the attributes

each frame.

  • platform/graphics/mac/WebGLLayer.mm:

(-[WebGLLayer initWithGraphicsContext3D:]): Store the devicePixelRatio, and set our
contents scale appropriately.
(-[WebGLLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): Draw into
a correctly sized backbuffer.
(-[WebGLLayer copyImageSnapshotWithColorSpace:]): Generate an image of the correct size.

5:41 PM Changeset in webkit [174413] by Chris Dumez
  • 6 edits in trunk/Source/WebKit2

[WK2] Use is<>() / downcast<>() for DrawingArea subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137497

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for DrawingArea subclasses.

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::synchronizeDynamicViewportUpdate):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
4:17 PM Changeset in webkit [174412] by Brent Fulgham
  • 4 edits in trunk/Source/WTF

[Win] Resolve some MSVC static analyzer warnings
​https://bugs.webkit.org/show_bug.cgi?id=137504

Reviewed by Dean Jackson.

  • wtf/GregorianDateTime.cpp:

(WTF::GregorianDateTime::setToCurrentLocalTime): Properly handle
possible timezone error case.

  • wtf/OSAllocatorWin.cpp:

(WTF::OSAllocator::decommit): Silence a spurious warning about using
MEM_DECOMMIT instead of MEM_RELEASE.

  • wtf/ThreadingWin.cpp: Silence a spurious warning about how the

tryLock method is implemented.

3:28 PM Changeset in webkit [174411] by Simon Fraser
  • 4 edits
    4 copies in trunk

Roll-over Changelogs.

Source/JavaScriptCore:

  • ChangeLog-2014-10-07: Copied from Source/JavaScriptCore/ChangeLog.

Source/WebCore:

  • ChangeLog-2014-10-07: Copied from Source/WebCore/ChangeLog.

Source/WebKit2:

  • ChangeLog-2014-10-07: Copied from Source/WebKit2/ChangeLog.

LayoutTests:

  • ChangeLog-2014-10-07: Copied from LayoutTests/ChangeLog.
3:26 PM Changeset in webkit [174410] by akling@apple.com
  • 10 edits in trunk/Source

Use more Ref and PassRef for Gradient.
<​https://webkit.org/b/137490>

Codify the fact that CanvasGradient always has an internal WebCore::Gradient
and make GraphicsContext gradient setters take PassRef, exposing some
unnecessary null checks.

Reviewed by Christophe Dumez.

  • WebCore.exp.in:
  • html/canvas/CanvasGradient.h:

(WebCore::CanvasGradient::gradient):

  • platform/graphics/Gradient.h:

(WebCore::Gradient::create):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):

  • platform/graphics/GraphicsContext.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintProgressBar):

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::useStrokeStyleToFill):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

3:17 PM Changeset in webkit [174409] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Bug link should be at the beginning of the line.

  • platform/mac/TestExpectations:
3:14 PM Changeset in webkit [174408] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

Commit queue doesn't drop obsolete patches sometimes
​https://bugs.webkit.org/show_bug.cgi?id=137460

Patch by Jake Nielsen <​jacob_nielsen@apple.com> on 2014-10-07
Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

Adds another test patch for use in queues_unittest.py.
courtesy of Csaba Osztrogonác <Csaba Osztrogonác>
(MockBugzilla):

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:

Raises a PatchIsNotValid exception in the case of validate() returning
false.
(CommitQueueTask.run):

  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:

Raises a PatchIsNotValid exception in the case of validate() returning
false.
(EarlyWarningSystemTask.run):

  • Scripts/webkitpy/tool/bot/patchanalysistask.py:

Defines PatchIsNotValid exception.
(PatchIsNotValid):
(PatchIsNotValid.init):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

Remove call to validate() and instead catches the PatchIsNotValid
exception.
(AbstractEarlyWarningSystem.review_patch):

  • Scripts/webkitpy/tool/commands/queues.py:

Adds logic to catch the PatchIsNotValid exception.
(CommitQueue.process_work_item):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

Adds the test_non_valid_patch test to ensure that invalid patches are
handled properly, and don't just result in indefinite spinning.
courtesy of Csaba Osztrogonác <Csaba Osztrogonác>
(test_non_valid_patch):

2:35 PM Changeset in webkit [174407] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed iOS build fix after r174400.

Missing explicit WebKit:: namespace.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _restorePageStateToExposedRect:scale:]):
(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):

2:35 PM Changeset in webkit [174406] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
​https://bugs.webkit.org/show_bug.cgi?id=137499

Patch by Daniel Bates <​dabates@apple.com> on 2014-10-07
Reviewed by Simon Fraser.

Tools:

Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
bit simulator builds of iOS WebKit.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort._generate_all_test_configurations):

LayoutTests:

Add a new platform directory, called ios-simulator, and associated TestExpectation file.
For now, there is a single entry to skip all accessibility tests on iOS due to significant
API differences. We'll likely update TestExpectations as we rebaseline iOS Simulator
layout test results.

  • platform/ios-simulator/TestExpectations: Added.
1:52 PM Changeset in webkit [174405] by mhock@apple.com
  • 6 edits in trunk/Source/WebCore

Defer resolution of viewport size.
​https://bugs.webkit.org/show_bug.cgi?id=137376
rdar://problem/18558094

Reviewed by Benjamin Poulain.

ViewportConfiguration should resolve the viewport size on configuration update.

  • dom/Document.cpp:

(WebCore::Document::processViewport): Defer resolution of viewport size.

  • dom/ViewportArguments.cpp:

(WebCore::finalizeViewportArguments): Deleted.

  • dom/ViewportArguments.h:
  • page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::updateConfiguration): Resolve viewport size.
(WebCore::ViewportConfiguration::viewportArgumentsLength): Resolves width or height based on viewport arguments.

  • page/ViewportConfiguration.h:
1:37 PM Changeset in webkit [174404] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] WebKit1 clients crash in DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse()
​https://bugs.webkit.org/show_bug.cgi?id=137495
<rdar://problem/18495034>

Reviewed by Andreas Kling.

Retain/release the CFCachedURLResponseRef object otherwise we could access a deleted object
and crash on the web thread.

  • loader/cocoa/DiskCacheMonitorCocoa.mm:

(WebCore::DiskCacheMonitor::DiskCacheMonitor):

12:33 PM Changeset in webkit [174403] by Chris Dumez
  • 46 edits in trunk/Source

Use is<>() / downcast<>() for RenderText / RenderTextFragment
​https://bugs.webkit.org/show_bug.cgi?id=137476

Reviewed by Darin Adler.

Source/WebCore:

Use is<>() / downcast<>() for RenderText / RenderTextFragment, and
clean up the surrounding code.

No new tests, no behavior change.

  • WebCore.exp.in:

Export symbol for RenderInline::linesBoundingBox() as it is used by
RenderInline::orderBoundingBox() which is inlined and now called in
WebRenderNode.mm.

  • WebCore.xcodeproj/project.pbxproj:

Make RenderInline.h header as Private so that it can be included by
WebRenderNode.mm, similarly to RenderText.h.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::passwordFieldValue):

  • accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::getLengthForTextRange):

  • bindings/objc/DOMUIKitExtensions.mm:

(-[DOMNode textHeight]):
(-[DOMNode findExplodedTextNodeAtPoint:]):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore::ContainerNode::getLowerRightCorner):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::addMarker):

  • dom/Position.cpp:

(WebCore::hasInlineBoxWrapper):
(WebCore::Position::upstream):
(WebCore::Position::downstream):
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
(WebCore::Position::isCandidate):
(WebCore::Position::rendersInDifferentPosition):
(WebCore::searchAheadForBetterMatch):
(WebCore::Position::getInlineBoxAndOffset):

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate):

  • dom/Range.cpp:

(WebCore::Range::textRects):
(WebCore::Range::textQuads):
(WebCore::Range::getBorderAndTextQuads):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::debugRenderer):

  • editing/TextIterator.cpp:

(WebCore::hasVisibleTextNode):
(WebCore::TextIterator::handleTextNode):
(WebCore::maxOffsetIncludingCollapsedSpaces):
(WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter):

  • editing/VisibleUnits.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • page/FrameView.cpp:

(WebCore::countRenderedCharactersInRenderObjectWithThreshold):

  • rendering/BidiRun.cpp:

(WebCore::BidiRun::BidiRun):

  • rendering/InlineIterator.cpp:

(WebCore::InlineIterator::surrogateTextDirection):

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::atTextParagraphSeparator):
(WebCore::InlineIterator::atParagraphSeparator):
(WebCore::isEmptyInline):
(WebCore::InlineIterator::fastIncrementInTextNode):
(WebCore::InlineIterator::increment):
(WebCore::InlineIterator::characterAt):
(WebCore::InlineIterator::direction):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::renderer):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::deleteLineBoxesBeforeSimpleLineLayout):
(WebCore::isVisibleRenderText):
(WebCore::RenderBlockFlow::adjustComputedFontSizes):
(WebCore::stripTrailingSpace):
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::createInlineBoxForRenderer):
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::reachedEndOfTextRenderer):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
(WebCore::RenderBlockFlow::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlockFlow::handleTrailingSpaces):
(WebCore::RenderBlockFlow::determineStartPosition):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::moveChildrenTo):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::hasImmediateNonWhitespaceTextChildOrBorderOrOutline):
(WebCore::RenderElement::addChild):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::dirtyLineBoxes):

  • rendering/RenderInline.h:

Make borderBoundingBox() public so that call sites (here
WebRenderNode.mm) can use tighter typing and benefit from the virtual
function being final.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::getRanges):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::getOverhang):

  • rendering/RenderSelectionInfo.cpp:

(WebCore::RenderSelectionInfo::RenderSelectionInfo):

  • rendering/RenderText.cpp:

(WebCore::isInlineFlowOrEmptyText):
(WebCore::RenderText::previousCharacter):

  • rendering/RenderText.h:

(WebCore::Text::renderer):

  • rendering/RenderTextFragment.h:

(isType):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::write):

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::create):

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):
(WebCore::SimpleLineLayout::hitTestFlow):

  • rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::RunResolver):

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::addNode):

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::containerIsRowOfLinks):
(WebCore::TextAutosizer::measureDescendantTextWidth):

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
(WebCore::shouldAddBorderPaddingMargin):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::BreakingContext::handleText):
(WebCore::textBeginsWithBreakablePosition):
(WebCore::BreakingContext::canBreakAtThisPosition):

Source/WebKit/mac:

  • WebView/WebRenderNode.mm:

(copyRenderNode):

Source/WebKit2:

Use is<>() / downcast<>() for RenderText / RenderTextFragment.

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

12:11 PM Changeset in webkit [174402] by jer.noble@apple.com
  • 20 edits
    5 adds in trunk

[Media] Expose AudioTracks in the "captions" menu.
​https://bugs.webkit.org/show_bug.cgi?id=137472

Reviewed by Brent Fulgham.

Source/WebCore:

Test: media/video-controls-audiotracks-trackmenu.html

If more than one AudioTrack is present in the video element, add those tracks to the
captions menu:

  • English.lproj/mediaControlsLocalizedStrings.js:
  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.handleAudioTrackChange):
(Controller.prototype.handleAudioTrackAdd):
(Controller.prototype.handleAudioTrackRemove):
(Controller.prototype.updateCaptionButton):
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.handleCaptionItemKeyUp):
(Controller.prototype.audioTrackItemSelected):
(Controller.prototype.focusSiblingAudioTrackItem):
(Controller.prototype.handleAudioTrackItemKeyUp):

Add support to MediaControlHost for retrieving the sorted audio track list, and the
localized names for every audio track:

  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::sortedTrackListForMenu):
(WebCore::MediaControlsHost::displayNameForTrack):

  • Modules/mediacontrols/MediaControlsHost.h:
  • Modules/mediacontrols/MediaControlsHost.idl:
  • page/CaptionUserPreferences.cpp:

(WebCore::trackDisplayName):
(WebCore::CaptionUserPreferences::displayNameForTrack):
(WebCore::CaptionUserPreferences::sortedTrackListForMenu):

  • page/CaptionUserPreferences.h:
  • platform/LocalizedStrings.cpp:

(WebCore::audioTrackNoLabelText):

  • platform/LocalizedStrings.h:
  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::audioTrackNoLabelText):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::audioTrackNoLabelText):

Drive-by fix; do not recurse into AudioTrackPrivate->setEnabled() when the enabled
state changes.

  • html/track/AudioTrack.cpp:

(WebCore::AudioTrack::enabledChanged):

Fix possible out-of-bounds Vector access when adding tracks to a track list by
sorting the list at insert time, rather than inserting into the track's reported
position in the Vector:

  • html/track/AudioTrackList.cpp:

(AudioTrackList::append):

  • html/track/VideoTrackList.cpp:

(VideoTrackList::append):

Correctly report the trackIndex of audio and video tracks from AVFoundation:

  • platform/graphics/avfoundation/AudioTrackPrivateAVF.h:

(WebCore::AudioTrackPrivateAVF::trackIndex):
(WebCore::AudioTrackPrivateAVF::setTrackIndex):
(WebCore::AudioTrackPrivateAVF::AudioTrackPrivateAVF):

  • platform/graphics/avfoundation/VideoTrackPrivateAVF.h:

(WebCore::VideoTrackPrivateAVF::trackIndex):
(WebCore::VideoTrackPrivateAVF::setTrackIndex):
(WebCore::VideoTrackPrivateAVF::VideoTrackPrivateAVF):

  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:

(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):

  • platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:

(WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack):

LayoutTests:

  • media/content/audio-tracks.mp4: Added.
  • media/content/audio-tracks.ogg: Added.
  • media/content/audio-tracks.webm: Added.
  • media/video-controls-audiotracks-trackmenu-expected.txt: Added.
  • media/video-controls-audiotracks-trackmenu.html: Added.
11:57 AM Changeset in webkit [174401] by oliver@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

Remove op_new_captured_func
​https://bugs.webkit.org/show_bug.cgi?id=137491

Reviewed by Mark Lam.

Removes the op_captured_new_func opcode as part of the work
towards having any magical opcodes that write directly to
named "registers" and then have a follow on op to ensure that
the environment record correctly represents the stack state.

For this we add a non-captured scratch register so we don't
have to have any kind of magic opcode, and instead simply
have sensible creation and move semantics for capturing new
functions.

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitLazyNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionInternal):

  • bytecompiler/BytecodeGenerator.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_captured_func): Deleted.

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL): Deleted.

  • runtime/CommonSlowPaths.h:
11:41 AM Changeset in webkit [174400] by Chris Dumez
  • 15 edits
    1 move in trunk/Source

[WK2] Use is<>() / downcast<>() for DrawingAreaProxy subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137477

Reviewed by Andreas Kling.

Source/WebCore:

Include TypeCastsCF.h now that the header was renamed.

No new tests, no behavior change.

  • platform/cf/SharedBufferCF.cpp:

Source/WebKit2:

Use is<>() / downcast<>() for DrawingAreaProxy subclasses.

  • Shared/cf/KeyedDecoder.cpp:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _restorePageStateToExposedRect:scale:]):
(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):

  • UIProcess/Cocoa/WebPageProxyCocoa.mm:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::layerTreeHost):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::updateVisibleContentRects):
(WebKit::WebPageProxy::dynamicViewportUpdateChangedTarget):

  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):

  • UIProcess/mac/LegacySessionStateCoding.cpp:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

Source/WTF:

Rename wtf/cf/TypeCasts.h to wtf/cf/TypeCastsCF.h to avoid conflict
with wtf/TypeCasts.h. They were using the same #ifndef guard and it
was causing problems when both were included in the same context.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/cf/TypeCastsCF.h: Renamed from Source/WTF/wtf/cf/TypeCasts.h.

(WTF::dynamic_cf_cast):
(WTF::checked_cf_cast):

10:15 AM Changeset in webkit [174399] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Try to fix the Mountain Lion build.

  • wtf/text/StringView.h:

(WTF::StringView::underlyingStringIsValid):
(WTF::StringView::setUnderlyingString):
(WTF::StringView::invalidate):

9:36 AM Changeset in webkit [174398] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Use "1", not "true".

  • wtf/text/StringView.h:
9:20 AM Changeset in webkit [174397] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Temporarily disable the StringView lifetime checking.

  • wtf/text/StringView.h:
9:12 AM Changeset in webkit [174396] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] jhbuild modules should build xserver with the --without-dtrace option.
​https://bugs.webkit.org/show_bug.cgi?id=137482

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-10-07
Reviewed by Martin Robinson.

  • gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
9:06 AM Changeset in webkit [174395] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Another build fix attempt.

  • wtf/text/StringView.cpp:

(WTF::StringView::UnderlyingString::UnderlyingString):

8:49 AM Changeset in webkit [174394] by Carlos Garcia Campos
  • 4 edits in trunk

[SOUP] TLS errors should take precedence over HTTP authentication
​https://bugs.webkit.org/show_bug.cgi?id=137300

Reviewed by Sergio Villar Senin.

Source/WebCore:

Handle TLS errors in got-headers callback to make sure it happens
before starting the authentication process.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::handleUnignoredTLSErrors): Refactored to receive the
soup message.
(WebCore::gotHeadersCallback): Return early and cancel the request in case of TLS errors.
(WebCore::sendRequestCallback): Do not handle TLS errors here, the request should have already been
cancelled at this point in case of TLS errors.

Tools:

Add a test case to check that authenticate signal is not emitted
in case of TLS errors, and the load fails instead.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(webViewAuthenticationCallback):
(testTLSErrorsHTTPAuth):
(httpsServerCallback):
(beforeAll):

8:47 AM Changeset in webkit [174393] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Try to fix the Windows build.

  • wtf/text/StringView.cpp:

(WTF::StringView::UnderlyingString::UnderlyingString):

12:42 AM Changeset in webkit [174392] by Carlos Garcia Campos
  • 15 edits in releases/WebKitGTK/webkit-2.6/Source

Merge r173776 - Multithreaded WebGL is a bad idea - remove it
​https://bugs.webkit.org/show_bug.cgi?id=136964
<rdar://problem/18399858>

Reviewed by Brent Fulgham.

Source/WebCore:

We should not allow multithreaded GL access. Remove the
feature.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create):

  • page/Settings.in:
  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

Source/WebKit/mac:

Remove the setting to allow multithreaded WebGL.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences multithreadedWebGLEnabled]): Deleted.
(-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Remove the setting to allow multithreaded WebGL.

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMultithreadedWebGLEnabled): Deleted.
(WKPreferencesGetMultithreadedWebGLEnabled): Deleted.

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

12:26 AM Changeset in webkit [174391] by Carlos Garcia Campos
  • 3 edits
    6 adds in releases/WebKitGTK/webkit-2.6

Merge r174002 - [GTK] Fix support for the initial-letter CSS property to first-letter
​https://bugs.webkit.org/show_bug.cgi?id=137108

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2014-09-26
Reviewed by Alejandro G. Castro.

Source/WebCore:

Add support for cap-height to the font system.

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

Add missing GTK test expectation files after ​http://webkit.org/b/136484

  • platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
12:23 AM Changeset in webkit [174390] by Carlos Garcia Campos
  • 47 edits
    9 copies
    7 adds
    12 deletes in releases/WebKitGTK/webkit-2.6/Source/WebInspectorUI

Merge r174207 - Web Inspector: [GTK] Missing icons and enhancing the proportion and visibility of some icons
​https://bugs.webkit.org/show_bug.cgi?id=137248

Reviewed by Carlos Garcia Campos.

Add more free icons and removed some unused ones for the Web
Inspector in GTK+.
Also, enhanced the visibility and/or proportion of several of the
icons.

  • UserInterface/Images/gtk/AUTHORS:
  • UserInterface/Images/gtk/COPYING:
  • UserInterface/Images/gtk/Checkers.svg: Added.
  • UserInterface/Images/gtk/Circle.svg: Added.
  • UserInterface/Images/gtk/CloseLarge.svg: Added.
  • UserInterface/Images/gtk/CloseTimeline.png: Removed.
  • UserInterface/Images/gtk/​CloseTimeline@2x.png: Removed.
  • UserInterface/Images/gtk/Crosshair.svg:
  • UserInterface/Images/gtk/DOMCharacterData.svg:
  • UserInterface/Images/gtk/DOMComment.svg:
  • UserInterface/Images/gtk/DOMDocument.svg:
  • UserInterface/Images/gtk/DOMDocumentType.svg:
  • UserInterface/Images/gtk/DOMElement.svg:
  • UserInterface/Images/gtk/DOMNode.svg:
  • UserInterface/Images/gtk/DOMTextNode.svg:
  • UserInterface/Images/gtk/DOMTree.svg:
  • UserInterface/Images/gtk/EventListener.svg:
  • UserInterface/Images/gtk/Exception.svg:
  • UserInterface/Images/gtk/Function.svg:
  • UserInterface/Images/gtk/GradientStop.png: Added.
  • UserInterface/Images/gtk/​GradientStop@2x.png: Added.
  • UserInterface/Images/gtk/GradientStopSelected.png: Added.
  • UserInterface/Images/gtk/​GradientStopSelected@2x.png: Added.
  • UserInterface/Images/gtk/Issues.svg:
  • UserInterface/Images/gtk/IssuesEnabled.svg:
  • UserInterface/Images/gtk/LessColumns.svg: Removed.
  • UserInterface/Images/gtk/Logs.svg:
  • UserInterface/Images/gtk/Memory.svg: Removed.
  • UserInterface/Images/gtk/MoreColumns.svg: Removed.
  • UserInterface/Images/gtk/Native.svg:
  • UserInterface/Images/gtk/NavigationItemAngleBrackets.svg:
  • UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg:
  • UserInterface/Images/gtk/NavigationItemBug.svg:
  • UserInterface/Images/gtk/NavigationItemFile.svg:
  • UserInterface/Images/gtk/NavigationItemLayers.svg:
  • UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Removed.
  • UserInterface/Images/gtk/NavigationItemProbes.pdf: Added.
  • UserInterface/Images/gtk/NavigationItemStopwatch.svg:
  • UserInterface/Images/gtk/NavigationItemTypes.svg: Added.
  • UserInterface/Images/gtk/PaintFlashing.svg: Added.
  • UserInterface/Images/gtk/PseudoElement.svg:
  • UserInterface/Images/gtk/Record.svg: Added.
  • UserInterface/Images/gtk/Recording.png: Removed.
  • UserInterface/Images/gtk/​Recording@2x.png: Removed.
  • UserInterface/Images/gtk/RecordingHovered.png: Removed.
  • UserInterface/Images/gtk/​RecordingHovered@2x.png: Removed.
  • UserInterface/Images/gtk/RecordingStopped.png: Removed.
  • UserInterface/Images/gtk/​RecordingStopped@2x.png: Removed.
  • UserInterface/Images/gtk/Reflection.svg:
  • UserInterface/Images/gtk/ReplayPauseButton.svg: Added.
  • UserInterface/Images/gtk/ReplayPlayButton.svg: Added.
  • UserInterface/Images/gtk/ReplayRecordingButton.svg: Added.
  • UserInterface/Images/gtk/Request.svg:
  • UserInterface/Images/gtk/Resources.svg:
  • UserInterface/Images/gtk/Response.svg:
  • UserInterface/Images/gtk/ResultLine.svg:
  • UserInterface/Images/gtk/SourceCode.svg:
  • UserInterface/Images/gtk/Stop.svg: Added.
  • UserInterface/Images/gtk/StyleRuleAuthor.svg:
  • UserInterface/Images/gtk/StyleRuleInherited.svg:
  • UserInterface/Images/gtk/StyleRuleInheritedElement.svg:
  • UserInterface/Images/gtk/StyleRuleInspector.svg:
  • UserInterface/Images/gtk/StyleRuleUser.svg:
  • UserInterface/Images/gtk/StyleRuleUserAgent.svg:
  • UserInterface/Images/gtk/Time.svg:
  • UserInterface/Images/gtk/TimelineRecordAnimation.svg:
  • UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordEvent.svg:
  • UserInterface/Images/gtk/TimelineRecordLayout.svg:
  • UserInterface/Images/gtk/TimelineRecordPaint.svg:
  • UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg:
  • UserInterface/Images/gtk/TimelineRecordStyle.svg:
  • UserInterface/Images/gtk/TimelineRecordTimer.svg:
  • UserInterface/Images/gtk/Weight.svg:
12:06 AM Changeset in webkit [174389] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a warning when passing an NSInteger to abs().
​https://bugs.webkit.org/show_bug.cgi?id=137480

Reviewed by Mark Rowe.

Use std::abs() instead, which is overloaded for both long (a.k.a. NSInteger) and int.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError):

Oct 6, 2014:

11:58 PM Changeset in webkit [174388] by Darin Adler
  • 9 edits
    1 add in trunk/Source

Make StringView check the lifetime of the StringImpl it's created from
​https://bugs.webkit.org/show_bug.cgi?id=137202

Reviewed by Anders Carlsson.

Source/WebCore:

  • platform/graphics/TextRun.cpp: Update since TextRun's definition now

uses a StringView.

Source/WTF:

  • WTF.vcxproj/WTF.vcxproj: Added StringView.cpp.
  • WTF.vcxproj/WTF.vcxproj.filters: Added StringView.cpp.
  • WTF.xcodeproj/project.pbxproj: Added StringView.cpp.
  • wtf/CMakeLists.txt: Added StringView.cpp.
  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl): Call StringView::invalidate.

  • wtf/text/StringView.cpp: Added.

(WTF::underlyingStrings): Returns map from StringImpl to the underlying
string object used by StringView to track validity.
(WTF::StringView::invalidate): Mark the underlying string object invalid,
and remove it from the map, so any future StringImpl will get a new one,
even if it has the same pointer.
(WTF::StringView::underlyingStringIsValid): Return true only if the
underlying string is still valid.
(WTF::StringView::setUnderlyingString): Create and manage reference counts
of underlying string objects as needed.

  • wtf/text/StringView.h: Moved function bodies out of the class definition,

so we can now read a clean class definition to see the class design and what
functions it offers.
(WTF::StringView::StringView): Added a comment to the default constructor.
Also added copy and move constructors so they can call setUnderlyingString
and assert the underlying string is valid as needed, replacing the
compiler-generated ones.
(WTF::StringView::~StringView): Added a call to setUnderlyingString.
(WTF::StringView::operator=): Added these assignment operators with the same
job as the constructors above.
(WTF::StringView::initialize): Added a comment.
(WTF::StringView::characters8): Added an assertion that the underlying
string is valid.
(WTF::StringView::characters16): Ditto.
(WTF::StringView::substring): Added code to propagate the underlying string
from the original string to the substring.
(WTF::StringView::invalidate): Inline empty version of this function for
non-debug builds.
(WTF::StringView::underlyingStringIsValid): Ditto.
(WTF::StringView::setUnderlyingString): Ditto.

11:54 PM Changeset in webkit [174387] by vivek.vg@samsung.com
  • 2 edits in trunk/Source/WebKit2

Remove unused warning in WebPageOverlay
​https://bugs.webkit.org/show_bug.cgi?id=137444

Reviewed by Darin Adler.

Commenting the unused parameter to supress the warning.

  • WebProcess/WebPage/WebPageOverlay.h:

(WebKit::WebPageOverlay::Client::copyAccessibilityAttributeStringValueForPoint):
(WebKit::WebPageOverlay::Client::copyAccessibilityAttributeBoolValueForPoint):

11:19 PM Changeset in webkit [174386] by aestes@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Objective-C objects must be fully defined when used in a WTF::Vector
​https://bugs.webkit.org/show_bug.cgi?id=137479

Reviewed by Mark Rowe.

When compiling an Objective-C++ file under ARC, @class types are considered non-trivially destructable, so
Vector needs to see their definition in order to call their destructor.

See <​http://clang.llvm.org/docs/AutomaticReferenceCounting.html#ownership-qualified-fields-of-structs-and-unions> for details.

  • API/ObjcRuntimeExtras.h: Imported <objc/Protocol.h>.
10:26 PM Changeset in webkit [174385] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Make webkit-patch find-users useful
​https://bugs.webkit.org/show_bug.cgi?id=137475

Reviewed by Alexey Proskuryakov.

Make find-users use the CommitterList instead of accessing Bugzilla.

This essentially exposes the same functionality as webkitbot's whois command.

  • Scripts/webkitpy/tool/commands/findusers.py:

(FindUsers.execute):

9:42 PM Changeset in webkit [174384] by adachan@apple.com
  • 8 edits in trunk/Source/WebKit2

Call WKPageUIClient::isPlayingAudioDidChange() whenever audio starts/stops playing on a page.
​https://bugs.webkit.org/show_bug.cgi?id=137050

Reviewed by Anders Carlsson.

Implement WebChromeClient::isPlayingAudioDidChange() which sends the new isPlayingAudio state
over to the UI process. WebPageProxy caches the isPlayingAudio state, and when that changes,
it calls WKPageUIClient::isPlayingAudioDidChange().

  • UIProcess/API/APIUIClient.h:

(API::UIClient::isPlayingAudioDidChange):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::isPlayingAudioDidChange):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isPlayingAudio):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::isPlayingAudioDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
8:32 PM Changeset in webkit [174383] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Fix remaining misuses of abs() and fabsf()
​https://bugs.webkit.org/show_bug.cgi?id=130947

Reviewed by Simon Fraser.

Fixed issues found when compiling with -Wabsolute-value.

  • platform/ios/ScrollAnimatorIOS.mm:

(WebCore::ScrollAnimatorIOS::handleTouchEvent): Called abs() instead of fabsf for integral types. Explicitly
cast the divisor to float in the call to atanf().

  • platform/ios/wak/WKView.mm:

(_WKViewAutoresizeCoord): Explicitly cast origMarginsTotal to an int before calling abs(). Added a FIXME
indicating the strange behavior when origMarginsTotal is in the range (0, 1) (as pointed out by Darin).

8:28 PM Changeset in webkit [174382] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

CanvasPattern always has an internal WebCore::Pattern.
<​https://webkit.org/b/137456>

Use more Ref & PassRef for CanvasPattern and Pattern.

Removed some impossible null checks in GraphicsContext that
got exposed as compile errors with these changes.

Reviewed by Anders Carlsson.

  • html/canvas/CanvasPattern.h:

(WebCore::CanvasPattern::pattern):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Pattern.cpp:

(WebCore::Pattern::create):

  • platform/graphics/Pattern.h:
  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

  • rendering/svg/RenderSVGPath.cpp:

(WebCore::useStrokeStyleToFill):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

8:10 PM Changeset in webkit [174381] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Use of 1-bit Enum type behaves improperly
​https://bugs.webkit.org/show_bug.cgi?id=137471
<rdar://problem/18559172>

Reviewed by Mark Lam.

Represent 1-bit enum element as 'unsigned', as we have done elsewhere
in WebKit to avoid problems when building with MSVC.

  • debugger/Debugger.h:
7:33 PM Changeset in webkit [174380] by gyuyoung.kim@samsung.com
  • 8 edits in trunk/Source

[EFL] Restore previous scroll position using restoreViewState()
​https://bugs.webkit.org/show_bug.cgi?id=136999

Reviewed by Benjamin Poulain.

There are duplicating code paths to restore previous scroll position and scale factor in
HistoryController::restoreScrollPositionAndViewState. EFL port has processed the two code paths.
It causes wrong rendering update or scroll position change when previous page's scroll position
is restored. Thus EFL port begins to use restoreViewState() to restore scroll position and scale factor.
This patch is first step to support it.

Additionally EFL port has supported to use ScrollingCoordinatorCoordinatedGraphics::requestScrollPositionUpdate()
since r173785. So EFL port can use the requestScrollPositionUpdate() to restore scroll position on previous page
instead of delegatedScrollRequested(). However setScrollPosition() can't be used there for now, because iOS port
should call it when delegatesScrolling is disabled. On the other hand, EFL port supports it only when delegatesScrolling
is enabled.

Source/WebCore:

Test covered by WKViewRestoreZoomAndScrollBackForward API test.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):
EFL port only calls restoreViewState() to restore previous page's view state.

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::saveViewStateToItem):
Move iOS saveViewStateToItem() to common place in order to share iOS implementation with EFL port.

(WebKit::WebFrameLoaderClient::restoreViewState):
EFL begins to share restoreViewState() of iOS, thus move iOS restoreViewState() to common place.

  • WebProcess/WebCoreSupport/ios/WebFrameLoaderClientIOS.mm:

(WebKit::WebFrameLoaderClient::saveViewStateToItem): Deleted.
(WebKit::WebFrameLoaderClient::restoreViewState): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::WebPage::restorePageState):
Call scalePage() to update previous scaleFactor and scrollPosition of historyItem both to WebProcess and UIProcess.

(WebKit::WebPage::savePageState):

6:55 PM Changeset in webkit [174379] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Highlighted selectors in Rules sidebar break with selectors that contain nested selector lists
​https://bugs.webkit.org/show_bug.cgi?id=137378

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-10-06
Reviewed by Joseph Pecoraro.

We should not update the parser's selectorRange when matching a nested selector list.

To implement this with low risk of unbalanced start+end and good error recovery,
I have wrapped the parsing of selector_list between a start/end function at the grammar
level. Whenever the parser enter a nested selector list, m_nestedSelectorLevel goes up
by one. Any time the parsing is currently in a nested selector list, we never update
the selector ranges.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::markSelectorStart):
(WebCore::CSSParser::markSelectorEnd):

  • css/CSSParser.h:

(WebCore::CSSParser::startNestedSelectorList):
(WebCore::CSSParser::endNestedSelectorList):

6:16 PM Changeset in webkit [174378] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Windows] Build fix for EWS bots.

  • WebCore.vcxproj/WebCoreGenerated.make: Make sure we always regenerate WebCore derived sources.
6:15 PM Changeset in webkit [174377] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Win] DateMath's calculateUTFOffset does not account for DST.
​https://bugs.webkit.org/show_bug.cgi?id=137458
<rdar://problem/18559172>

Reviewed by Geoffrey Garen.

Check the return value of GetTimeZoneInformation and use the
proper bias against UTC (depending on whether we are in daylight
savings time, or standard time).

Also, handle possible error cases in the FileTimeToSystemTime
and SystemTimeToTzSpecificLocalTime, rather than using potentially
uninitialized values.

  • wtf/DateMath.cpp:

(WTF::calculateUTCOffset): Use proper daylight-savings-time state.
(WTF::calculateDSTOffset): Avoid uninitialized data due to failing
API calls.

6:10 PM Changeset in webkit [174376] by Chris Fleizach
  • 2 edits in trunk/Tools

AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
​https://bugs.webkit.org/show_bug.cgi?id=137289

Unreviewed build fix.

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::getChildrenWithRange):

5:26 PM Changeset in webkit [174375] by Chris Dumez
  • 97 edits in trunk/Source

Add is<>() / downcast<>() support for RenderObject subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137424

Reviewed by Benjamin Poulain.

Source/WebCore:

Add is<>() / downcast<>() support for RenderObject subclasses, and
get rid of IsRendererOfType traits struct as we can now rely on the
TypeCastsTraits instead.

toRender*() is still supported for most render objects because I did
not want to remove all usages in this patch, to keep the size small.
For now, only the MathML render objects were ported over to using
is<>() / downcast<>(). Other render objects will be taken care of in
follow-up patches and I will drop support for toRender*()
incrementally.

No new tests, no behavior change.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isMathFenceOperator):
(WebCore::AccessibilityRenderObject::isMathSeparatorOperator):
(WebCore::AccessibilityRenderObject::mathLineThickness):

  • dom/make_names.pl:

(printTypeHelpers):

  • mathml/MathMLInlineContainerElement.cpp:

(WebCore::MathMLInlineContainerElement::childrenChanged):

  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::didAttachRenderers):
(WebCore::MathMLTextElement::childrenChanged):

  • rendering/RenderAncestorIterator.h:

(WebCore::lineageOfType):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.h:
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderButton.h:
  • rendering/RenderCombineText.h:
  • rendering/RenderCounter.h:
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderElement.h:
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlowThread.h:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderFullScreen.h:
  • rendering/RenderGrid.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderIFrame.h:
  • rendering/RenderImage.h:
  • rendering/RenderInline.h:
  • rendering/RenderIterator.h:

(WebCore::isRendererOfType):
(WebCore::RenderTraversal::firstChild):
(WebCore::RenderTraversal::lastChild):
(WebCore::RenderTraversal::nextSibling):
(WebCore::RenderTraversal::previousSibling):
(WebCore::RenderTraversal::findAncestorOfType):

  • rendering/RenderLayerModelObject.h:
  • rendering/RenderLineBreak.h:
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderMedia.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderMeter.h:
  • rendering/RenderMultiColumnFlowThread.h:
  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderMultiColumnSpannerPlaceholder.h:
  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject>): Deleted.

  • rendering/RenderProgress.h:
  • rendering/RenderQuote.h:
  • rendering/RenderRegion.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderRubyRun.h:
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderSearchField.h:
  • rendering/RenderSlider.h:
  • rendering/RenderSnapshottedPlugIn.h:
  • rendering/RenderTable.h:
  • rendering/RenderTableCaption.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h:
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderTextFragment.h:
  • rendering/RenderVideo.h:
  • rendering/RenderView.h:
  • rendering/RenderWidget.h:
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::unembellishedOperator):

  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRadicalOperator.h:
  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::baseWrapper):
(WebCore::RenderMathMLRoot::radicalWrapper):
(WebCore::RenderMathMLRoot::indexWrapper):
(WebCore::RenderMathMLRoot::radicalOperator):
(WebCore::RenderMathMLRootWrapper::removeChild):

  • rendering/mathml/RenderMathMLRoot.h:
  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::updateOperatorProperties):
(WebCore::RenderMathMLRow::layout):

  • rendering/mathml/RenderMathMLRow.h:
  • rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::addChildInternal):
(WebCore::RenderMathMLScripts::removeChildInternal):
(WebCore::RenderMathMLScripts::unembellishedOperator):
(WebCore::RenderMathMLScripts::layout):
(WebCore::RenderMathMLScriptsWrapper::addChildInternal):
(WebCore::RenderMathMLScriptsWrapper::addChild):
(WebCore::RenderMathMLScriptsWrapper::removeChildInternal):
(WebCore::RenderMathMLScriptsWrapper::removeChild):

  • rendering/mathml/RenderMathMLScripts.h:
  • rendering/mathml/RenderMathMLSpace.h:
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/mathml/RenderMathMLToken.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::unembellishedOperator):

  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGGradientStop.h:
  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGResourceContainer.h:
  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGShape.h:
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/RenderSVGTextPath.h:
  • rendering/svg/RenderSVGViewportContainer.h:

Source/WTF:

Handle correctly calling TypeCastTraits<ExpectedType, ArgType>::isOfType(ArgType&)
with ExpectedType being a base class of ArgType (or the same as ArgType). The
previous template specialization was only meant to support the case where
ExpectedType is the same as ArgType but even that wasn't working as the compiler
would complain about ambiguous partial specializations. Since this is needed by
RenderTraversal functions, this patch adds an extra isBaseType template parameter
to TypeCastTraits to resolve the ambiguity and relies on std::is_base_of for the
detection.

  • wtf/TypeCasts.h:
5:15 PM Changeset in webkit [174374] by Chris Dumez
  • 9 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for ScrollingTreeNode subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137451

Reviewed by Tim Horton.

Use is<>() / downcast<>() for ScrollingTreeNode subclasses.

No new tests, no behavior change.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::handleWheelEvent):
(WebCore::ScrollingTree::viewportChangedViaDelegatedScrolling):
(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling):

  • page/scrolling/ScrollingTreeFrameScrollingNode.h:
  • page/scrolling/ScrollingTreeNode.h:
  • page/scrolling/ScrollingTreeOverflowScrollingNode.h:
  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.h:
  • page/scrolling/mac/ScrollingTreeStickyNode.h:
  • page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::updateLayersAfterAncestorChange):

4:54 PM Changeset in webkit [174373] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Addressing post-review comment on r174297.
​https://bugs.webkit.org/show_bug.cgi?id=137355

Unreviewed.

  • rendering/RenderText.cpp:

(WebCore::RenderText::stringView):

3:44 PM Changeset in webkit [174372] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed merge fix for r174279.
​https://bugs.webkit.org/show_bug.cgi?id=137097

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont):

3:17 PM Changeset in webkit [174371] by mark.lam@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Fixed compiler warnings on Windows build.
<​https://webkit.org/b/135205>

Reviewed by Geoffrey Garen.

Benchmarking with jsc shows that perf is neutral with this change.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::call):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • dfg/DFGArgumentPosition.h:

(JSC::DFG::ArgumentPosition::mergeShouldNeverUnbox):
(JSC::DFG::ArgumentPosition::mergeArgumentUnboxingAwareness):

  • dfg/DFGEdge.h:

(JSC::DFG::Edge::makeWord):

  • dfg/DFGNodeFlags.h:

(JSC::DFG::nodeMayOverflow):
(JSC::DFG::nodeMayNegZero):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

  • dfg/DFGVariableAccessData.cpp:

(JSC::DFG::VariableAccessData::mergeIsCaptured):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::mergeIsProfitableToUnbox):
(JSC::DFG::VariableAccessData::mergeStructureCheckHoistingFailed):
(JSC::DFG::VariableAccessData::mergeCheckArrayHoistingFailed):
(JSC::DFG::VariableAccessData::mergeIsArgumentsAlias):
(JSC::DFG::VariableAccessData::mergeIsLoadedFrom):

  • runtime/JSDataViewPrototype.cpp:

(JSC::getData):

3:07 PM Changeset in webkit [174370] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (Simple Line Layout): Inline block baselines computed incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=137461

Reviewed by Simon Fraser.

Source/WebCore:

Added fast/inline-block/simple-line-layout.html

  • rendering/SimpleLineLayoutFunctions.h:

(WebCore::SimpleLineLayout::computeFlowFirstLineBaseline):
(WebCore::SimpleLineLayout::computeFlowLastLineBaseline):
Fix the baseline computation functions in simple line layout to
use lineCount rather than runCount.

LayoutTests:

  • fast/inline-block/simple-line-layout-expected.html: Added.
  • fast/inline-block/simple-line-layout.html: Added.
3:07 PM Changeset in webkit [174369] by Chris Dumez
  • 13 edits in trunk/Source/WebKit2

[Mac] We are spending too much time serializing ProtectionSpace objects
​https://bugs.webkit.org/show_bug.cgi?id=137367

Reviewed by Dan Bernstein.

When profiling the load of nytimes.com, I noticed that we were spending
a lot of CPU time serializing ProtectionSpace objects (in particular
the NSURLProtectionSpace platform data):

  • 5.6% of CPU time for Network Process
  • 2.5% of CPU time for WebProcess

Serializing an NSURLProtectionSpace seems to be costly due to server
trust verification. We do this for every sub-resource load over HTTPS
due to the canAuthenticateAgainstProtectionSpace() callback for server
trust validation, from the NetworkProcess to the WebProcess and then to
the UIProcess.

This patch adds a WKContextSetCanHandleHTTPSServerTrustEvaluation(bool)
WK2 private API that the client can call to indicate that it cannot
handle HTTPS server trust evaluation and that it is thus unnecessary to
call the canAuthenticateAgainstProtectionSpace() callback for such
evaluations. This reduces the amount of IPC between the process and
thus the number of times we have to serialize the ProtectionSpace.

In the case of the nytimes.com load, there is no longer any
ProtectionSpace serialization happening as
canAuthenticateAgainstProtectionSpace() was only called for HTTPS
server trust evaluation.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::setCanHandleHTTPSServerTrustEvaluation):

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::canHandleHTTPSServerTrustEvaluation):

  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetCanHandleHTTPSServerTrustEvaluation):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setCanHandleHTTPSServerTrustEvaluation:]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::setCanHandleHTTPSServerTrustEvaluation):

  • UIProcess/WebContext.h:
2:53 PM Changeset in webkit [174368] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Unreviewed 64-bit build fix after r174315.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Update exports for

64-bit symbol names.

2:52 PM Changeset in webkit [174367] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

Don't attempt to paint into zero-sized backing store
​https://bugs.webkit.org/show_bug.cgi?id=137465

Reviewed by Tim Horton.

Page scale could cause the backing store for a small composited element to become empty,
in which case we'd try to allocate, and paint into a graphics context with no surface
behind it.

Fix by bailing from RemoteLayerBackingStore::display() when checking the backing store
size after accounting for scale.

  • Shared/mac/RemoteLayerBackingStore.h:
  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::backingStoreSize):
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
(WebKit::RemoteLayerBackingStore::display):

2:37 PM Changeset in webkit [174366] by ap@apple.com
  • 6 edits
    3 moves in trunk/Tools

build.webkit.org/dashboard: Add commit queue
​https://bugs.webkit.org/show_bug.cgi?id=137462

Reviewed by Tim Horton.

Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
Style queue is still invisible, as it doesn't have an associated platform, and also
we never have problems with it anyway, so it's not worth watching.

The UI now allows for adding more bots to the Other column (such as leaks bot).
To make that actually happen, we'll need to refactor QueueView, allowing for multiple
sources of data in a cell.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.

(BubbleQueue):
(BubbleQueue.prototype.get statusPageURL):
(BubbleQueue.prototype.update):
(BubbleQueue.prototype.loadDetailedStatus):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.

(BubbleQueueServer):
(BubbleQueueServer.prototype.jsonQueueLengthURL):
(BubbleQueueServer.prototype.jsonQueueStatusURL):
(BubbleQueueServer.prototype.queueStatusURL):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.

(BubbleQueueView):
(BubbleQueueView.prototype.update.appendQueue):
(BubbleQueueView.prototype.update):
(BubbleQueueView.prototype._addQueueHeadingToPopover):
(BubbleQueueView.prototype._popoverContentForBubbleQueue):
(BubbleQueueView.prototype._presentPopoverForBubbleQueue):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:

(.bubble-server-popover .popover-queue-heading .queue-charts-link):
(.bubble-server-popover .latest-status-no-link):
(.bubble-server-popover .bot-status-description):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:

(buildAggregateTable):
(buildQueuesTable):
Removed dysfunctional support for EWS for now. It will be different.

2:36 PM Changeset in webkit [174365] by adachan@apple.com
  • 3 edits in trunk/Source/WebCore

Add ChromeClient::isPlayingAudioDidChange().
​https://bugs.webkit.org/show_bug.cgi?id=137220

Reviewed by Jer Noble.

This is called when the Page's m_isPlayingAudio changes.

No new tests, no behavior change.

  • page/ChromeClient.h:

(WebCore::ChromeClient::isPlayingAudioDidChange):

  • page/Page.cpp:

(WebCore::Page::updateIsPlayingAudio):

1:58 PM Changeset in webkit [174364] by ap@apple.com
  • 3 edits in trunk/Tools

One more case of incorrect comparison in recordpatchevent.py
​https://bugs.webkit.org/show_bug.cgi?id=137459

Reviewed by Tim Horton.

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/loggers/recordpatchevent.py:

(RecordPatchEvent.started):

1:45 PM Changeset in webkit [174363] by benjamin@webkit.org
  • 17 edits in trunk

Unreviewed, rolling out r174336.

Mozilla's Dromaeo still relies on the deprecated function.

Reverted changeset:

"Add a deprecation warning for Element.webkitMatchesSelector"
​https://bugs.webkit.org/show_bug.cgi?id=137417
​http://trac.webkit.org/changeset/174336

1:42 PM Changeset in webkit [174362] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove incorrect assertion.

1:27 PM Changeset in webkit [174361] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix cloop build.

1:18 PM Changeset in webkit [174360] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix.
<​https://webkit.org/b/137279>

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

12:29 PM Changeset in webkit [174359] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

REGRESSION(r174226): [JSC] Crash when running the perf test Speedometer/Full.html
​https://bugs.webkit.org/show_bug.cgi?id=137404

Reviewed by Michael Saboff.

Update the Arguments object to recognise that it must always have an
environment record if the referenced callee has one, and if such is not
present it should not try to extract one from the callframe, as that
path leads to madness.

Happily this makes some of the other code more sensible, and removes a
bunch of unnecessary and icky logic.

  • interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):

  • jit/JITOperations.cpp:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/Arguments.cpp:

(JSC::Arguments::tearOff):
(JSC::Arguments::didTearOffActivation): Deleted.

  • runtime/Arguments.h:

(JSC::Arguments::argument):
(JSC::Arguments::finishCreation):

12:20 PM Changeset in webkit [174358] by Chris Dumez
  • 13 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for CryptoKey subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137436

Reviewed by Ryosuke Niwa.

Use is<>() / downcast<>() for CryptoKey subclasses.

No new tests, no behavior change.

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::addJWKAlgorithmToJSON):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):

  • crypto/CryptoKey.h:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):

  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmAES_KW::encryptForWrapKey):
(WebCore::CryptoAlgorithmAES_KW::decryptForUnwrapKey):

  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):

  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):

  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):

  • crypto/keys/CryptoKeyAES.h:

(WebCore::isCryptoKeyAES): Deleted.

  • crypto/keys/CryptoKeyHMAC.h:

(WebCore::isCryptoKeyHMAC): Deleted.

  • crypto/keys/CryptoKeyRSA.h:

(WebCore::isCryptoKeyRSA): Deleted.

12:09 PM Changeset in webkit [174357] by ap@apple.com
  • 3 edits in trunk/Tools

webkit-queues PatchLog is incorrect for patches that took less than a second
​https://bugs.webkit.org/show_bug.cgi?id=137453

Reviewed by Tim Horton.

  • QueueStatusServer/app.yaml: Updated app version.
  • QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):

Don't bail out for patches that took 0 seconds to process (as frequently happens
when a patch is obsolete).

11:57 AM Changeset in webkit [174356] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Some compositing logic cleanup
​https://bugs.webkit.org/show_bug.cgi?id=133060

Reviewed by Zalan Bujtas.

Move compositing-related code from RenderLayer::styleChanged() to
RenderLayerCompositor::layerStyleChanged(). Combine various tests
(many clip-related) for changes that require layer rebuilding into
styleChangeRequiresLayerRebuild().

Remove code that calls setBackingNeedsRepaint() after filters change
between being composited or not; I verified that existing "repaint after
style change" code takes care those repaints.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::checkIfDescendantClippingContextNeedsUpdate): Deleted.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::checkIfDescendantClippingContextNeedsUpdate):
(WebCore::styleChangeRequiresLayerRebuild):
(WebCore::RenderLayerCompositor::layerStyleChanged):

  • rendering/RenderLayerCompositor.h:
11:56 AM Changeset in webkit [174355] by adachan@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the iOS build after ​https://trac.webkit.org/changeset/174353.

  • platform/audio/ios/AudioDestinationIOS.h:
11:39 AM Changeset in webkit [174354] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Build fix.

  • Misc/WebCache.mm:

(+[WebCache imageForURL:]):

11:22 AM Changeset in webkit [174353] by adachan@apple.com
  • 10 edits in trunk/Source/WebCore

Implement Page::isPlayingAudio().
​https://bugs.webkit.org/show_bug.cgi?id=137218

Reviewed by Eric Carlson.

  • Add a hasMediaCharacteristics() method to MediaSession. There are three characteristics:

audible, visual, and legible. MediaSession gets the media characteristics information from
its MediaSessionClient.

  • Add a mediaStateDidChange() method to MediaSessionClient that MediaSession can call when its

state changes.

  • Each Document keeps a set of MediaSessions it contains. When that set changes, or when a MediaSession

changes state, or when its characteristics change, Document::updateIsPlayingAudio() is called. That method
iterates through all its MediaSessions to check if the overall isPlayingAudio state has changed in the Document.

  • Each Page caches its overall isPlayingAudio state. Whenever a Document's isPlayingAudio state changes,

it calls Page::updateIsPlayingAudio() which iterates through its frames' documents to calculate its
overall isPlayingAudio state.

No new tests, no behavior change.

  • dom/Document.cpp:

(WebCore::Document::Document):
Initialize m_isPlayingAudio.
(WebCore::Document::registerMediaSession):
Add the MediaSession to m_mediaSessions. Call updateIsPlayingAudio().
(WebCore::Document::unregisterMediaSession):
Remove the MediaSession from m_mediaSessions. Call updateIsPlayingAudio().
(WebCore::Document::updateIsPlayingAudio):
Go through all the MediaSessions in this Document and check if any has the Audible characteristic
and is playing. If the overall isPlayingAudio state changes, call Page::updateIsPlayingAudio().

  • dom/Document.h:

(WebCore::Document::isPlayingAudio):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::registerWithDocument):
Call Document::registerMediaSession().
(WebCore::HTMLMediaElement::unregisterWithDocument):
Call Document::unregisterMediaSession().
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
Call Document::updateIsPlayingAudio().
(WebCore::HTMLMediaElement::stop):
Call MediaSession::clientWillPausePlayback() so the MediaSession's state can be set back to Paused.
(WebCore::HTMLMediaElement::hasMediaCharacteristics):
Call hasAudio() to check if the HTMLMediaElement has the Audible characteristic. Call hasVideo()
to check if it has the Visual characteristic. Call hasClosedCaptions() to check if it has the
Legible characteristic.
(WebCore::HTMLMediaElement::mediaStateDidChange):
Call Document::updateIsPlayingAudio().

  • html/HTMLMediaElement.h:
  • page/Page.cpp:

(WebCore::Page::Page):
Initialize m_isPlayingAudio.
(WebCore::Page::updateIsPlayingAudio):
Iterate through all its frames' documents to check if any has audio playing. If the overall isPlayingAudio
state has changed, update m_isPlayingAudio.

  • page/Page.h:

(WebCore::Page::isPlayingAudio):

  • platform/audio/MediaSession.cpp:

(WebCore::MediaSession::setState):
If the MediaSession's state has changed, call Document::updateIsPlayingAudio().
(WebCore::MediaSession::hasMediaCharacteristics):
Call MediaSessionClient::hasMediaCharacteristics().

  • platform/audio/MediaSession.h:

(WebCore::MediaSessionClient::mediaStateDidChange):

  • platform/audio/mac/AudioDestinationMac.h:

AudioDestination only has the Audible characteristic.

11:09 AM Changeset in webkit [174352] by Chris Dumez
  • 2 edits in trunk/Source/WebKit/mac

Unreviewed build fix after r174333.

Forgot explicit WebCore:: namespace.

  • Misc/WebCache.mm:

(+[WebCache imageForURL:]):

11:08 AM Changeset in webkit [174351] by Chris Dumez
  • 8 edits in trunk/Source

Use is<>() / downcast<>() for ScrollingTree subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137449

Reviewed by Ryosuke Niwa.

Use is<>() / downcast<>() for ScrollingTree subclasses.

Source/WebCore:

No new tests, no behavior change.

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/ThreadedScrollingTree.h:
  • page/scrolling/ios/ScrollingTreeIOS.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):
(WebCore::ScrollingCoordinatorMac::commitTreeState):

Source/WebKit2:

  • UIProcess/Scrolling/RemoteScrollingTree.h:
  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::addScrollingTreeForPage):

11:01 AM Changeset in webkit [174350] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Build fix aftr r174347.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Use correct build

macro to prevent build break when ENCRYPTED_MEDIA_V2 is not enabled.

10:55 AM Changeset in webkit [174349] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] Skip remaining failing media tests after adding audio devices to the bots Part 2.

  • platform/win/TestExpectations:
10:55 AM Changeset in webkit [174348] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Win] Project file gardening.

  • WTF.vcxproj/WTF.vcxproj.filters: Move HashMethod.h and

FastBitVector.cpp to proper places in hierarchy.

10:53 AM Changeset in webkit [174347] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Project file gardening.

  • WebCore.vcxproj/WebCore.vcxproj.filters: Move EditorWin.cpp and MediatTimeAVFoundation to proper folder locations in project.
10:49 AM Changeset in webkit [174346] by Brent Fulgham
  • 7 edits in trunk/Source/WebCore

[Win] Extend AVFoundationCF Media Implementation
​https://bugs.webkit.org/show_bug.cgi?id=137409

Reviewed by Eric Carlson.

This code is not yet being built and tested by our system. Appropriate
tests will be activated when we enable the build.

Most of this patch involves correcting some misuse of the AVFoundationCF API.

  1. It is never appropriate in AVCF to pass a null CFErrorRef; instead you must pass a CFErrorRef with error type kCFURLErrorUnknown.
  2. Because of the asynchronous way we handle the request/response, it is possible for AVCF to make two AVCF requests while negotiating the key exchange.
  • platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Add

missing declaration.

  • platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:

(WebCore::CDMSessionAVFoundationCF::generateKeyRequest): Tighten up scope
of 'underlyingError'.
(WebCore::CDMSessionAVFoundationCF::update): Add call to complete the
loading process.

  • platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:

(WebCore::InbandTextTrackPrivateAVCF::label): Handle null titles CFArray
found during testing.
(WebCore::InbandTextTrackPrivateAVCF::language): Ditto for a null locale.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::registerMediaEngine): Add support
for the new 'supportsKeySystem' method.
(WebCore::MediaPlayerPrivateAVFoundationCF::createContextVideoRenderer): Add
assertion for mainThread.
(WebCore::MediaPlayerPrivateAVFoundationCF::destroyContextVideoRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::createVideoLayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::destroyVideoLayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayerItem): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::platformLayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::platformSetVisible): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::paintCurrentFrameInContext): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::paint): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationCF::supportsKeySystem): Added.
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged): Add assertion that this
is being called on the main thread.
(WebCore::MediaPlayerPrivateAVFoundationCF::processMediaSelectionOptions): Handle
the allows empty media selection properly based on test behavior.
(WebCore::AVFWrapper::AVFWrapper): Initialize resource loader callback structure
when building with AVFOUNDATION_LOADER_DELEGATE.
(WebCore::AVFWrapper::createAssetForURL): Use AVFWrapper's loader callback struct,
rather than passing the address of a temporary value.
(WebCore::AVFWrapper::processNotification): Stop using the deprecated
'dispatch_get_current_queue' function.
(WebCore::AVFWrapper::processCue): Ditto.
(WebCore::AVFWrapper::legibleOutputCallback): Ditto.
(WebCore::AVFWrapper::processShouldWaitForLoadingOfResource): Pass a valid CFError
object; nullptr is not allowed as an argument to the "...FinishedLoadingWithError"
method.
(WebCore::AVFWrapper::shouldWaitForLoadingOfResource): Add support for multiple
in-flight requests.
(WebCore::AVFWrapper::platformLayer): Assert we are on the main thread.
(WebCore::AVFWrapper::setRequestForKey): Add support for multiple in-flight requests.
(WebCore::AVFWrapper::takeRequestForKeyURI): Ditto.
(WebCore::LayerClient::platformCALayerLayoutSublayersOfLayer): Ditto.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
  • platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp: Make sure we pass

valid CFError objects, rather than nullptr.

9:39 AM Changeset in webkit [174345] by Chris Fleizach
  • 3 edits in trunk/Source/WebCore

AX: Performance: Certain Web site causes Safari to hang completely while entering form data
​https://bugs.webkit.org/show_bug.cgi?id=137420

Reviewed by Mario Sanchez Prada.

If a website has multiple nested tables that are not "accessibility" tables, the performance of accessibility slows to a crawl because:

1) We are re-computing accessibilityIsIgnored many times.

As a solution, we can enable the isIgnoredCache when updating children.

2) When asking if an object isTableCell, we'd go up the parent chain, asking each of those parents the same question, which exploded into calling this many times.

As a solution, I've changed our determination of isTableCell to instead check if the parent is an accessibiltyTable which should be much faster.

No new functionality. Existing tests cover changes.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateChildrenIfNecessary):
(WebCore::AccessibilityObject::accessibilityIsIgnored):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::parentTable):
(WebCore::AccessibilityTableCell::isTableCell):

9:25 AM Changeset in webkit [174344] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed, touch testing/Internals.idl to try to fix Windows EWS after r174315.

  • testing/Internals.idl: Remove unnecessary whitespaces.
7:34 AM Changeset in webkit [174343] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

EWS bubble hover shows wrong timestamps
​https://bugs.webkit.org/show_bug.cgi?id=137252

Reviewed by Alexey Proskuryakov.

Add "Z" suffix to timestamps to make sure if it is handled as UTC time.

  • QueueStatusServer/handlers/queuestatusjson.py:

(QueueStatusJSON.get):

  • QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._iso_time):

5:47 AM Changeset in webkit [174342] by mario@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, updated list of email addresses in contributors.json

  • Scripts/webkitpy/common/config/contributors.json: Added my former

email address in Igalia, for the sake of completeness.

2:10 AM Changeset in webkit [174341] by zsborbely.u-szeged@partner.samsung.com
  • 2 edits in trunk/Tools

Unreviewed, moved myself to the list of committers.

  • Scripts/webkitpy/common/config/contributors.json:

Oct 5, 2014:

10:14 PM Changeset in webkit [174340] by Chris Dumez
  • 26 edits in trunk/Source

Use is<>() / downcast<>() for ScrollingCoordinator / ScrollingStateNode subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137440

Reviewed by Ryosuke Niwa.

Use is<>() / downcast<>() for ScrollingCoordinator / ScrollingStateNode subclasses.

Source/WebCore:

No new tests, no behavior change.

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::updateFrameScrollingNode):
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode):
(WebCore::AsyncScrollingCoordinator::updateViewportConstrainedNode):
(WebCore::AsyncScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateFrameScrollingNode.h:
  • page/scrolling/ScrollingStateNode.h:
  • page/scrolling/ScrollingStateOverflowScrollingNode.h:
  • page/scrolling/ScrollingStateScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ScrollingTreeFrameScrollingNode.cpp:

(WebCore::ScrollingTreeFrameScrollingNode::updateBeforeChildren):

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
(WebCore::ScrollingTreeScrollingNode::updateAfterChildren):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateViewportConstrainedNode):

  • page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:

(WebCore::ScrollingTreeFrameScrollingNodeIOS::updateBeforeChildren):
(WebCore::ScrollingTreeFrameScrollingNodeIOS::updateAfterChildren):

  • page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::updateBeforeChildren):

  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):
(WebCore::ScrollingTreeFrameScrollingNodeMac::updateAfterChildren):

  • page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::updateBeforeChildren):

Source/WebKit2:

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::RemoteScrollingTreeTextStream::dump):

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateBeforeChildren):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):

  • UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

  • WebProcess/Scrolling/RemoteScrollingCoordinator.h:
  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::addScrollingTreeForPage):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

10:13 PM Changeset in webkit [174339] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for CachedRawResource
​https://bugs.webkit.org/show_bug.cgi?id=137439

Reviewed by Ryosuke Niwa.

Use is<>() / downcast<>() for CachedRawResource.

No new tests, no behavior change.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::switchClientsToRevalidatedResource):

  • loader/cache/CachedRawResource.h:

(isType):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestMainResource):

10:10 PM Changeset in webkit [174338] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for TextTrack subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137438

Reviewed by Ryosuke Niwa.

Use is<>() / downcast<>() for TextTrack subclasses.

No new tests, no behavior change.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/track/InbandTextTrack.h:

(isType):

  • html/track/LoadableTextTrack.h:

(isType):

  • html/track/TextTrackList.cpp:

(TextTrackList::getTrackIndex):
(TextTrackList::append): Deleted.

10:08 PM Changeset in webkit [174337] by Chris Dumez
  • 13 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for CryptoKeyData subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137437

Reviewed by Ryosuke Niwa.

Use is<>() / downcast<>() for CryptoKeyData subclasses.

No new tests, no behavior change.

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::serialize):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):

  • crypto/CryptoKeyData.h:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::importKey):

  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::importKey):

  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::importKey):

  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::importKey):

  • crypto/keys/CryptoKeyDataOctetSequence.h:

(WebCore::isCryptoKeyDataOctetSequence): Deleted.

  • crypto/keys/CryptoKeyDataRSAComponents.h:

(WebCore::isCryptoKeyDataRSAComponents): Deleted.

  • crypto/keys/CryptoKeySerializationRaw.cpp:

(WebCore::CryptoKeySerializationRaw::serialize):

7:08 PM Changeset in webkit [174336] by benjamin@webkit.org
  • 19 edits in trunk

Add a deprecation warning for Element.webkitMatchesSelector
​https://bugs.webkit.org/show_bug.cgi?id=137417

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-10-05
Reviewed by Christophe Dumez.

Source/WebCore:

Many scripts have assumed that the unprefixed version of ElementwebkitMatchesSelector
would be Element.matchesSelector. Feature detection scripts too often test
for Element.matchesSelector instead of Element.matches before calling Element.webkitMatchesSelector.

This patch add a deprecation warning for Element.webkitMatchesSelector with the hope
that it will push the adoption of the unprefixed version.

  • dom/Element.cpp:

(WebCore::Element::webkitMatchesSelector):

  • dom/Element.h:
  • dom/Element.idl:

LayoutTests:

  • jquery/resources/src/sizzle/sizzle.js:

This is a great example of library that needs fixing. The old sizzle
we have in WebKit used "matchesSelector" instead of "matches".

  • fast/dom/SelectorAPI/attrname-case-insensitive-expected.txt:
  • fast/dom/SelectorAPI/attrname-case-sensitive-expected.txt:
  • fast/dom/SelectorAPI/caseID-almost-strict-expected.txt:
  • fast/dom/SelectorAPI/caseID-expected.txt:
  • fast/dom/SelectorAPI/caseID-strict-expected.txt:
  • fast/dom/SelectorAPI/caseTag-expected.txt:
  • fast/dom/SelectorAPI/caseTagX-expected.txt:
  • fast/dom/SelectorAPI/detached-element-expected.txt:
  • fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt:
  • fast/dom/SelectorAPI/undefined-null-stringify-expected.txt:

Update the test results due to the warning.

  • fast/forms/radio/radio-live-validation-style-expected.txt:
  • fast/forms/radio/radio-live-validation-style.html:

That duplicate I added back when I unprefixed Element.matches() is useless.

5:47 PM Changeset in webkit [174335] by ryuan.choi@gmail.com
  • 12 edits
    11 adds
    1 delete in trunk

[EFL] Introduce EWebKit_Extension
​https://bugs.webkit.org/show_bug.cgi?id=134921

Reviewed by Gyuyoung Kim.

Source/WebKit2:

EWebKit2 does not provide the functionality to extend WebProcess.
Although there is ewk_context_new_with_injected_bundle_path() in ewebkit2 APIs,
application developers can not make bundle object without touching WK APIs
which ewebkit2 does not expose.

This patch introduces EWebKit_Extension, basic structure for the extension of WebProcess.

  • PlatformEfl.cmake:

Added files for the EWebKit_Extension and install them properly.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
(bundlePathForExtension):
(EwkContext::create):
(EwkContext::getInjectedBundleInitializationUserData):
(EwkContext::setMessageFromInjectedBundleCallback):
(ewk_context_new_with_extensions_path):
Deleted because ewebkit2 does not have a way to make injected bundle.
Instead, Ewk_Extension will cover the same functionalities.
(ewk_context_new_with_injected_bundle_path): Deleted.

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext::extensionsPath):

  • UIProcess/API/efl/tests/InjectedBundle/injected_bundle_sample.cpp: Removed.
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::extensionSample):
(EWK2UnitTest::EWK2UnitTestEnvironment::injectedBundleSample): Renamed injectedBundleSample to extensionSample.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
  • UIProcess/API/efl/tests/extensions/extension_sample.cpp: Copied from Source/WebKit2/UIProcess/API/efl/tests/InjectedBundle/injected_bundle_sample.cpp.
  • UIProcess/API/efl/tests/test_ewk2_context.cpp: Renamed ewk_context_new_with_injected_bundle_path to ewk_context_new_with_extensions_path.

(TEST_F):

  • WebProcess/InjectedBundle/API/efl/EWebKit_Extension.h: Added.
  • WebProcess/InjectedBundle/API/efl/ewk_extension.cpp: Added.

(EwkExtension::append):
(EwkExtension::remove):
(ewk_extension_client_add):
(ewk_extension_client_del):

  • WebProcess/InjectedBundle/API/efl/ewk_extension.h: Added.
  • WebProcess/InjectedBundle/API/efl/ewk_extension_private.h: Added.

(EwkExtension::EwkExtension):
(EwkExtension::~EwkExtension):

  • WebProcess/efl/ExtensionManagerEfl.cpp: Added.

(WebKit::ExtensionManagerEfl::shared):
(WebKit::ExtensionManagerEfl::ExtensionManagerEfl):
(WebKit::ExtensionManagerEfl::initialize):

  • WebProcess/efl/ExtensionManagerEfl.h: Added.
  • WebProcess/efl/WebInjectedBundleMainEfl.cpp: Added.

(WKBundleInitialize):

  • efl/ewebkit2-extension.pc.in: Added.

Tools:

  • MiniBrowser/efl/main.c: Added x option to test extension path.

(window_create):
(elm_main):

  • Scripts/webkitpy/common/config/watchlist:

Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.

  • Scripts/webkitpy/style/checker.py:

Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.

5:41 PM Changeset in webkit [174334] by benjamin@webkit.org
  • 3 edits
    8 adds in trunk

Element.matches()'s argument is not supposed to be optional
​https://bugs.webkit.org/show_bug.cgi?id=137427

Reviewed by Christophe Dumez.

Source/WebCore:

The argument was marked as optional, it is not supposed to:
​https://dom.spec.whatwg.org/#interface-element

Also update the webkit-prefixed version: webkitMatchesSelector().

Tests: fast/dom/SelectorAPI/closest-definition.html

fast/dom/SelectorAPI/closest-null-undefined.html
fast/dom/SelectorAPI/matches-definition.html
fast/dom/SelectorAPI/matches-null-undefined.html

  • dom/Element.idl:

LayoutTests:

  • fast/dom/SelectorAPI/matches-definition.html: Added.
  • fast/dom/SelectorAPI/matches-null-undefined.html: Added.

Test for the bug.

  • fast/dom/SelectorAPI/closest-definition.html: Added.
  • fast/dom/SelectorAPI/closest-null-undefined.html: Added.

Similar tests for Element.closest() since those are similar APIs.

5:31 PM Changeset in webkit [174333] by Chris Dumez
  • 15 edits in trunk/Source

Use is<>() / downcast<>() for CachedResource subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137431

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for CachedResource subclasses.

Source/WebCore:

No new tests, no behavior change.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceContent):

  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::switchClientsToRevalidatedResource):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):

  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedScript.h:
  • loader/cache/CachedTextTrack.h:
  • loader/cache/CachedXSLStyleSheet.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeImageFromCache):

Source/WebKit/mac:

  • Misc/WebCache.mm:

(+[WebCache imageForURL:]):

5:23 PM Changeset in webkit [174332] by Chris Dumez
  • 9 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for StyleSheet subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137429

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for StyleSheet subclasses.

No new tests, no behavior change.

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • css/CSSStyleSheet.h:

(isType):

  • css/StyleSheet.h:
  • dom/Document.cpp:

(WebCore::Document::applyXSLTransform):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::filterEnabledNonemptyCSSStyleSheets):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getAllStyleSheets):

  • xml/XSLStyleSheet.h:

(isType):

4:27 PM Changeset in webkit [174331] by Chris Dumez
  • 17 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for CryptoAlgorithmParameters subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137432

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for CryptoAlgorithmParameters subclasses.

No new tests, no behavior change.

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):

  • crypto/CryptoAlgorithmParameters.h:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
(WebCore::CryptoAlgorithmAES_CBC::generateKey):

  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::generateKey):

  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
(WebCore::CryptoAlgorithmHMAC::generateKey):
(WebCore::CryptoAlgorithmHMAC::importKey):

  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::generateKey):

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::generateKey):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::generateKey):
(WebCore::CryptoAlgorithmRSA_OAEP::importKey):

  • crypto/parameters/CryptoAlgorithmAesCbcParams.h:
  • crypto/parameters/CryptoAlgorithmAesKeyGenParams.h:
  • crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
  • crypto/parameters/CryptoAlgorithmHmacParams.h:
  • crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h:
  • crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h:
  • crypto/parameters/CryptoAlgorithmRsaOaepParams.h:
  • crypto/parameters/CryptoAlgorithmRsaSsaParams.h:
4:09 PM Changeset in webkit [174330] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
​https://bugs.webkit.org/show_bug.cgi?id=137289

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Casting a NSInteger to an unsigned can bypass the check we were hoping to achieve,
because size_t is not the same as unsigned.

Test: platform/ios-sim/accessibility/out-of-bounds-child-access.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):

LayoutTests:

  • platform/ios-sim/accessibility/out-of-bounds-child-access-expected.txt: Added.
  • platform/ios-sim/accessibility/out-of-bounds-child-access.html: Added.
3:14 PM Changeset in webkit [174329] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for ElementData subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137430

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for ElementData subclasses.

No new tests, no behavior change.

  • dom/Element.cpp:

(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createUniqueElementData):

  • dom/ElementData.cpp:

(WebCore::ElementData::destroy):

  • dom/ElementData.h:

(WebCore::ElementData::length):
(WebCore::ElementData::attributeBase):
(WebCore::ElementData::presentationAttributeStyle):
(WebCore::ElementData::attributesIterator):
(WebCore::ElementData::findAttributeByName):
(isType):

4:28 AM Changeset in webkit [174328] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[GTK] Fix build when DRAG_SUPPORT is disabled
​https://bugs.webkit.org/show_bug.cgi?id=137361

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2014-10-05
Reviewed by Carlos Garcia Campos.

Flag out unbuildable code without DRAG_SUPPORT.

Source/WebCore:

  • platform/gtk/GtkDragAndDropHelper.cpp:
  • platform/gtk/GtkDragAndDropHelper.h:

Source/WebKit2:

  • Shared/gtk/ArgumentCodersGtk.cpp:
  • Shared/gtk/ArgumentCodersGtk.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:
  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseConstructed):

  • UIProcess/PageClient.h:
1:17 AM Changeset in webkit [174327] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] The new web inspector can't be docked again once undocked
​https://bugs.webkit.org/show_bug.cgi?id=121544

Reviewed by Martin Robinson.

Use a GtkHeaderBar for the inspector window to add dock buttons
when building with GTK+ >= 3.10.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::dockButtonClicked):
(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::updateInspectorWindowTitle):
(WebKit::WebInspectorProxy::platformInspectedURLChanged):
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged):

12:41 AM Changeset in webkit [174326] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Do not generate a symlink in derived sources for every header in WebCore/bindings/gobject
​https://bugs.webkit.org/show_bug.cgi?id=137389

Reviewed by Martin Robinson.

We only need a symlink for static sources that are included in
public generated headers, because they are added with as
<webkitdom/WebKitDOMFoo.h> so they need to be inside a webkitdom
directory. Also use proper targets and commands to create the
symlinks only when needed instead of for every build.

  • PlatformGTK.cmake:

Oct 4, 2014:

11:34 PM Changeset in webkit [174325] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[SVG -> OTF Converter] Arabic forms are not substituted correctly
​https://bugs.webkit.org/show_bug.cgi?id=137092

Reviewed by Darin Adler.

Tests: svg/W3C-SVG-1.1/fonts-glyph-02-t.svg

svg/custom/glyph-selection-arabic-forms.svg

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendArabicReplacementSubtable): Invoked for each of the three
Arabic form substitutions.
(WebCore::SVGToOTFFontConverter::appendGSUBTable): OpenType "Advanced Typographic Table":
"Glyph substitution data"
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Re-order the m_codepointsToIndicesMap
to prefer isolated forms of glyphs.
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): Append the GSUB table.
(WebCore::calculateChecksum): Deleted.

3:24 PM Changeset in webkit [174324] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Implement Element.closest() API
​https://bugs.webkit.org/show_bug.cgi?id=137418

Patch by Dhi Aurrahman <​diorahman@rockybars.com> on 2014-10-04
Reviewed by Benjamin Poulain.

Source/WebCore:

Implement Element.closest() API as specified in [1].

[1]: ​https://dom.spec.whatwg.org/#dom-element-closest

Tests: fast/selectors/closest-general.html

fast/selectors/closest-scope.html

  • dom/Element.cpp:

(WebCore::Element::closest):

  • dom/Element.h:
  • dom/Element.idl:
  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorClosest):
(WebCore::SelectorDataList::closest):

  • dom/SelectorQuery.h:

(WebCore::SelectorQuery::closest):

LayoutTests:

Add test cases for Element.closest() API

  • fast/selectors/closest-general-expected.txt: Added.
  • fast/selectors/closest-general.html: Added.
  • fast/selectors/closest-scope-expected.txt: Added.
  • fast/selectors/closest-scope.html: Added.
3:11 PM Changeset in webkit [174323] by commit-queue@webkit.org
  • 6 edits
    9 adds in trunk/Source/WebInspectorUI

Web Inspector: Add PrettyPrinter CSS tests
​https://bugs.webkit.org/show_bug.cgi?id=134005

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-04
Reviewed by Timothy Hatcher.

Add CSS pretty printing tests. Improve pretty printing of calc()
expressions and media-queries with whitespace around operators
and keywords. Also fix the debug output in the tool for CSS.

  • Tools/PrettyPrinting/CodeMirrorFormatters.js:
  • Tools/PrettyPrinting/FormatterContentBuilder.js:

(FormatterContentBuilder.prototype._appendIndent):

  • Tools/PrettyPrinting/FormatterDebug.js:

(.debugToken):
(Formatter.prototype.debug):

  • Tools/PrettyPrinting/css-tests/basic-expected.css: Added.
  • Tools/PrettyPrinting/css-tests/basic.css: Added.
  • Tools/PrettyPrinting/css-tests/calc-expected.css: Added.
  • Tools/PrettyPrinting/css-tests/calc.css: Added.
  • Tools/PrettyPrinting/css-tests/media-query-expected.css: Added.
  • Tools/PrettyPrinting/css-tests/media-query.css: Added.
  • Tools/PrettyPrinting/css-tests/selectors-expected.css: Added.
  • Tools/PrettyPrinting/css-tests/selectors.css: Added.
  • Tools/PrettyPrinting/index.html:
  • UserInterface/Views/CodeMirrorFormatters.js:
2:55 PM Changeset in webkit [174322] by Brian Burg
  • 24 edits
    1 delete in trunk/Source

Unreviewed, rolling out r174319.

Causes assertions in fast/profiler tests. Needs nontrivial
investigation, will take offline.

Reverted changeset:

"Web Inspector: timelines should not count time elapsed while
paused in the debugger"
​https://bugs.webkit.org/show_bug.cgi?id=136351
​http://trac.webkit.org/changeset/174319

12:55 PM Changeset in webkit [174321] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Try to fix the Windows build after r174315.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
12:35 PM Changeset in webkit [174320] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Try to fix the Windows build after r174315.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
12:18 PM Changeset in webkit [174319] by Brian Burg
  • 24 edits
    1 add in trunk/Source

Web Inspector: timelines should not count time elapsed while paused in the debugger
​https://bugs.webkit.org/show_bug.cgi?id=136351

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Now that we have a stopwatch to provide pause-aware timing data, we can remove the
profiler's handling of debugger pause/continue callbacks. The timeline agent accounts
for debugger pauses by pausing and resuming the stopwatch.

  • API/JSProfilerPrivate.cpp:

(JSStartProfiling): Use a fresh stopwatch when profiling from the JSC API.

  • inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::handlePause):

  • profiler/LegacyProfiler.cpp:

(JSC::LegacyProfiler::profiler): Use nullptr.
(JSC::LegacyProfiler::startProfiling): Hand off a stopwatch to the profile generator.
(JSC::LegacyProfiler::stopProfiling): Use nullptr.
(JSC::LegacyProfiler::didPause): Deleted.
(JSC::LegacyProfiler::didContinue): Deleted.

  • profiler/LegacyProfiler.h:
  • profiler/ProfileGenerator.cpp: Remove debugger pause/continue callbacks and the

timestamp member that was used to track time elapsed by the debugger. Just use the
stopwatch's elapsed times to generate start/elapsed times for function calls.
(JSC::ProfileGenerator::create):
(JSC::ProfileGenerator::ProfileGenerator):
(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didPause): Deleted.
(JSC::ProfileGenerator::didContinue): Deleted.

  • profiler/ProfileGenerator.h:

Source/WebCore:

To avoid counting time elapsed while the debugger is paused, timeline records should
keep track of time elapsed since the start of timeline capturing, rather than wall clock
timestamps. We can easily compute elapsed time by sharing Stopwatch instance among
all timeline record-generating code. The stopwatch is paused while the debugger is paused,
so subsequent time measurements will not include time elapsed while the debugger is paused.

Agents use the shared stopwatch to generate timestamps if the timeline agent is active
(i.e., a timeline recording is being captured). If not, use a zero timestamp since the timing data is only revealed through the Timeline interface.

This refactoring is safe because start and end times are only used to graph records; the
timestamp's actual value is irrelevant and is not displayed in the user interface. Date
timestamps are still included with network-related records as part of their header data.

No new tests, because we cannot reliably test timing changes induced by debugger pauses.
It is possible for records to accrue time before the debugger pauses or after it resumes.

  • inspector/InspectorCSSAgent.cpp: Remove unused include.
  • inspector/InspectorPageAgent.cpp: Use timestamps from the shared stopwatch.

(WebCore::InspectorPageAgent::timestamp):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp: Use timestamps from the shared stopwatch.

(WebCore::InspectorResourceAgent::timestamp):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
(WebCore::InspectorResourceAgent::didSendWebSocketFrame):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrameError):

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.cpp: Add calls to reset, start, and stop the stopwatch.

(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::startProfiling):
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didPause):
(WebCore::InspectorTimelineAgent::didContinue):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::timestamp):
(WebCore::TimelineTimeConverter::reset): Deleted.

  • inspector/InspectorTimelineAgent.h: Make timestamp() public, and remove old timepieces.

(WebCore::TimelineTimeConverter::TimelineTimeConverter): Deleted.
(WebCore::TimelineTimeConverter::fromMonotonicallyIncreasingTime): Deleted.
(WebCore::InspectorTimelineAgent::timeConverter): Deleted.

  • inspector/TimelineRecordFactory.cpp:

Source/WebInspectorUI:

Don't update the timeline's current time when the debugger is paused.

Start and end times for timeline records are now in seconds elapsed since timeline
recording started, rather than milliseconds since the epoch. Add a workaround to
preserve compatibility with old backends.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.capturingStarted):
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):

  • UserInterface/Views/TimelineContentView.js:

(WebInspector.TimelineContentView.prototype._debuggerPaused):
(WebInspector.TimelineContentView.prototype._debuggerResumed):

Source/WTF:

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/Stopwatch.h: Added. This implements a refcounted monotonic stopwatch.

(WTF::Stopwatch::reset):
(WTF::Stopwatch::start):
(WTF::Stopwatch::stop):

10:18 AM Changeset in webkit [174318] by fpizlo@apple.com
  • 24 edits
    6 adds in trunk

FTL should sink PutLocals
​https://bugs.webkit.org/show_bug.cgi?id=137168

Reviewed by Oliver Hunt.
Source/JavaScriptCore:


We've known for a while that our PutLocal situation was sub-optimal. We emit them anytime we
"pass" arguments to an inlined function call, because we need to enable the runtime to grab
those arguments when doing foo.arguments where foo is inlined: our engine doesn't deoptimize
in that case but rather just relies on the arguments being flushed (i.e. a copy of their
values is spilled) at a well-known place in a well-known format.

The PutLocals incur two costs: (1) they are store instructions and stores ain't free, and (2)
they look like escaping sites and so they inhibit object allocation sinking.

But in most cases, the PutLocals are unnecessary because the inlined code never performs any
side effect that could transitively lead to function.arguments. Even if the inlined code
could do such a side effect, it may be on a rare path so there is no need to penalize the
entire function.

This patch implements one solution to the PutLocal problem: it aggressively sinks PutLocals
to the latest possible point. This is even more aggressive than the object allocation
sinking. That sinking algorithm avoids creating situations where an object could be
materialized more than one along any path. PutLocal sinking, on the other hand, doesn't avoid
this at all - both to make the phase cheaper and simpler and to make it more aggressive.
Every PutLocal is sunk no matter what.

The upside of this patch is that it eliminates many PutLocals: many of them are sunk "past
their death", thus eliminating them completely. Others are sunk to rare paths. This enables a
lot of object allocation sinking and it removes a lot of pointless store instructions.

It also has downsites. Sinking PutLocals increases register pressure because it increases the
live ranges of things like inlined arguments.

This patch is a net performance win in its current form: 1% SunSpider regression, 2% OctaneV2
progression, 0.6% Kraken regression, 1% AsmBench progression, and 0.5% CompressionBench
regression. The biggest win is on Octane/raytrace, which improves by 27%.

Relanding after fixing internal builds. We have to be careful about implicit casts from int64
to int32.

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.h:
  • bytecode/Operands.h:

(JSC::Operands::dump): Deleted.

  • bytecode/OperandsInlines.h:

(JSC::Traits>::dump):

  • bytecode/VirtualRegister.h:

(JSC::VirtualRegister::isHeader):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGClobberSet.h:

(JSC::DFG::ClobberSetAdd::operator()):
(JSC::DFG::ClobberSetOverlaps::operator()):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):
(JSC::DFG::NoOpClobberize::operator()):
(JSC::DFG::CheckClobberize::operator()):
(JSC::DFG::AbstractHeapOverlaps::operator()):
(JSC::DFG::ReadMethodClobberize::operator()):
(JSC::DFG::WriteMethodClobberize::operator()):
(JSC::DFG::DefMethodClobberize::operator()):

  • dfg/DFGFlushFormat.h:

(JSC::DFG::merge):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::capturedVarsFor):

  • dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::determineMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::placeMaterializationPoints):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPreciseLocalClobberize.h: Added.

(JSC::DFG::PreciseLocalClobberizeAdaptor::PreciseLocalClobberizeAdaptor):
(JSC::DFG::PreciseLocalClobberizeAdaptor::read):
(JSC::DFG::PreciseLocalClobberizeAdaptor::write):
(JSC::DFG::PreciseLocalClobberizeAdaptor::def):
(JSC::DFG::PreciseLocalClobberizeAdaptor::callIfAppropriate):
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
(JSC::DFG::PreciseLocalClobberizeAdaptor::writeTop):
(JSC::DFG::forEachLocalReadByUnwind):
(JSC::DFG::preciseLocalClobberize):

  • dfg/DFGPutLocalSinkingPhase.cpp: Added.

(JSC::DFG::performPutLocalSinking):

  • dfg/DFGPutLocalSinkingPhase.h: Added.
  • dfg/DFGSSACalculator.h:

(JSC::DFG::SSACalculator::computePhis):

  • dfg/DFGValidate.cpp:

Source/WTF:


Make the set bits of a BitVector iterable.

  • wtf/BitVector.h:

(WTF::BitVector::SetBitsIterable::SetBitsIterable):
(WTF::BitVector::SetBitsIterable::iterator::iterator):
(WTF::BitVector::SetBitsIterable::iterator::operator*):
(WTF::BitVector::SetBitsIterable::iterator::operator++):
(WTF::BitVector::SetBitsIterable::iterator::operator==):
(WTF::BitVector::SetBitsIterable::iterator::operator!=):
(WTF::BitVector::SetBitsIterable::begin):
(WTF::BitVector::SetBitsIterable::end):
(WTF::BitVector::setBits):

LayoutTests:

  • js/regress/elidable-new-object-then-call-expected.txt: Added.
  • js/regress/elidable-new-object-then-call.html: Added.
  • js/regress/script-tests/elidable-new-object-then-call.js: Added.

(sumOfArithSeries):
(bar):
(foo):

3:04 AM Changeset in webkit [174317] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=137390

Reviewed by Carlos Garcia Campos.

  • Scripts/update-webkit-libs-jhbuild:
2:07 AM Changeset in webkit [174316] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Add missing inspector files to compilation.

  • PlatformGTK.cmake: Add javascript sources in

WebInspectorUI/UserInterface/External/Esprima to the list of
inspector files.

1:47 AM Changeset in webkit [174315] by timothy_horton@apple.com
  • 17 edits
    20 adds in trunk

Make it possible to test page overlays
​https://bugs.webkit.org/show_bug.cgi?id=137339

Reviewed by Dan Bernstein.

Tests: pageoverlay/overlay-installation.html

pageoverlay/overlay-large-document-scrolled.html
pageoverlay/overlay-large-document.html

Do some initial work to make page overlays testable.
There are many more tests to be written, but this lays the groundwork.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.vcxproj/WebCoreTestSupport.vcxproj:
  • WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters:
  • CMakeLists.txt:

Add MockPageOverlayClient.

  • platform/graphics/GraphicsLayer.h:
  • page/PageOverlayController.h:
  • page/PageOverlayController.cpp:

(WebCore::PageOverlayController::shouldSkipLayerInDump):
Don't skip PageOverlayController-owned layers in the layer tree dump if the
layerTreeAsText behavior says that we should include them.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::dumpChildren):

  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::shouldSkipLayerInDump):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldSkipLayerInDump):

  • rendering/RenderLayerBacking.h:

Pass the LayerTreeAsTextBehavior through shouldSkipLayerInDump.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
Uninstall all page overlays when resetting to a consistent state.

(WebCore::Internals::installMockPageOverlay):
(WebCore::Internals::pageOverlayLayerTreeAsText):
Expose two new internals functions.
installMockPageOverlay takes "view" or "document", allowing script
to choose the appropriate overlay type.
pageOverlayLayerTreeAsText dumps both view and document-relative
overlays, from each overlay container layer.

  • testing/Internals.h:
  • testing/Internals.idl:

Fix some typos.

  • testing/MockPageOverlayClient.cpp: Added.

(WebCore::MockPageOverlayClient::shared):
(WebCore::MockPageOverlayClient::MockPageOverlayClient):
(WebCore::MockPageOverlayClient::installOverlay):
(WebCore::MockPageOverlayClient::uninstallAllOverlays):
(WebCore::MockPageOverlayClient::layerTreeAsText):
(WebCore::MockPageOverlayClient::pageOverlayDestroyed):
(WebCore::MockPageOverlayClient::willMoveToPage):
(WebCore::MockPageOverlayClient::didMoveToPage):
When the overlay is parented, mark it as needing repaint.
Future tests might want to test overlays without content,
but for now this is a reasonable default behavior.

(WebCore::MockPageOverlayClient::drawRect):
Paint the overlay rects as described in the LayoutTests ChangeLog.

(WebCore::MockPageOverlayClient::mouseEvent):
(WebCore::MockPageOverlayClient::didScrollFrame):
(WebCore::MockPageOverlayClient::copyAccessibilityAttributeStringValueForPoint):
(WebCore::MockPageOverlayClient::copyAccessibilityAttributeBoolValueForPoint):
(WebCore::MockPageOverlayClient::copyAccessibilityAttributeNames):

  • testing/MockPageOverlayClient.h: Added.
  • pageoverlay/overlay-installation.html: Added.

Add a test which just installs one view-relative and one document-relative
overlay, and dumps the layer tree and pixel results. The mock overlay
strokes a blue rectangle (inset a little from the overlay bounds) for
view-relative overlays, and a green rectangle (inset a bit more) for
document-relative overlays.

  • pageoverlay/overlay-large-document.html: Added.
  • pageoverlay/overlay-large-document-scrolled.html: Added.

Tests that do the same as the -installation test, but with a larger document;
the view-relative overlay should be the same size (or slightly smaller,
because we have scrollbars now), but the document-relative overlay should
be the size of the document. The second test scrolls to maxX, maxY, and
the document-relative overlay should scroll along with it, while the
view-relative overlay should remain fixed.

  • pageoverlay/overlay-installation-expected.txt: Added.
  • pageoverlay/overlay-large-document-expected.txt: Added.
  • pageoverlay/overlay-large-document-scrolled-expected.txt: Added.

"Normal" layer tree expectations.

  • platform/mac-wk1/pageoverlay/overlay-installation-expected.png: Added.
  • platform/mac-wk1/pageoverlay/overlay-installation-expected.txt: Added.
  • platform/mac-wk1/pageoverlay/overlay-large-document-expected.png: Added.
  • platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt: Added.
  • platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.png: Added.
  • platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt: Added.

Expected results for WebKit1 differ for view-relative overlays, because
we don't currently hook up view-relative overlays for WebKit1.

  • platform/mac/pageoverlay/overlay-installation-expected.png: Added.
  • platform/mac/pageoverlay/overlay-large-document-expected.png: Added.
  • platform/mac/pageoverlay/overlay-large-document-scrolled-expected.png: Added.

"Normal" pixel dump expectations.

1:37 AM Changeset in webkit [174314] by Carlos Garcia Campos
  • 14 edits
    2 adds in trunk/Source/WebCore

Move DragController::createFragmentFromDragData implementation to the editor
​https://bugs.webkit.org/show_bug.cgi?id=136819

Reviewed by Darin Adler.

Make Editor::webContentFromPasteboard() common to all ports and
add a implementation for every port.

  • PlatformWin.cmake: Add new files to compilation.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • editing/Editor.cpp:

(WebCore::Editor::pasteWithPasteboard): Move to EditorWin.cpp
since this is only used by windows port.

  • editing/Editor.h:
  • editing/efl/EditorEfl.cpp:

(WebCore::Editor::webContentFromPasteboard):

  • editing/gtk/EditorGtk.cpp:

(WebCore::Editor::webContentFromPasteboard):

  • editing/win/EditorWin.cpp: Added.

(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::webContentFromPasteboard):

  • page/DragController.cpp:

(WebCore::documentFragmentFromDragData): Use the editor instead of
createFragmentFromDragData() that has been removed. Also made this
method a static funtion again.

  • page/DragController.h:
  • page/efl/DragControllerEfl.cpp: Remove createFragmentFromDragData().
  • page/gtk/DragControllerGtk.cpp: Ditto.
  • page/mac/DragControllerMac.mm: Ditto.
  • page/win/DragControllerWin.cpp: Ditto.
  • platform/Pasteboard.h:

(WebCore::Pasteboard::dragDataMap): Add a getter for m_dragDataMap
as required by Editor::webContentFromPasteboard for windows.

1:30 AM Changeset in webkit [174313] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for CSS StyleProperties
​https://bugs.webkit.org/show_bug.cgi?id=137398

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for CSS StyleProperties subclasses.

No new tests, no behavior change.

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::immutableCopyIfNeeded):
(WebCore::MutableStyleProperties::MutableStyleProperties):
(WebCore::StyleProperties::hasCSSOMWrapper):

  • css/StyleProperties.h:

(WebCore::StyleProperties::PropertyReference::propertyMetadata):
(WebCore::StyleProperties::PropertyReference::propertyValue):
(WebCore::StyleProperties::propertyCount):
(WebCore::StyleProperties::deref):
(WebCore::StyleProperties::findPropertyIndex):
(isType):
(WebCore::toMutableStyleProperties): Deleted.
(WebCore::toImmutableStyleProperties): Deleted.

  • css/StyleRule.cpp:

(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::mutableProperties):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::mutableProperties):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::setInlineStyleFromString):

1:05 AM Changeset in webkit [174312] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] Skip remaining failing media tests after adding audio devices to the bots.

  • platform/win/TestExpectations:
12:56 AM Changeset in webkit [174311] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[TexMap] Clean up GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded()
​https://bugs.webkit.org/show_bug.cgi?id=137263

Reviewed by Darin Adler.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded): Clean up
the method a bit. When the backing store will not be in use the change mask
should only get updated if there was a backing store present beforehand.

12:46 AM Changeset in webkit [174310] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
​https://bugs.webkit.org/show_bug.cgi?id=137391

Reviewed by Martin Robinson.

Add a custom command to only re-generate
webkit2gtk-tests-resources.gresource when any of its dependencies changes.

  • TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
12:35 AM Changeset in webkit [174309] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
​https://bugs.webkit.org/show_bug.cgi?id=135502

Reviewed by Martin Robinson.

When writing to stdout/stderr fails due to a UnicodeDecodeError
exception, try again without encoding the output.

  • gtk/gtkdoc.py:

(GTKDoc._run_command):

12:14 AM Changeset in webkit [174308] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[TexMap] Remove QDoc comments in GraphicsLayerTextureMapper
​https://bugs.webkit.org/show_bug.cgi?id=137264

Reviewed by Andreas Kling.

Remove all the QDoc comments in the class that were
left over by the Qt port.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):

Oct 3, 2014:

7:41 PM Changeset in webkit [174307] by Yusuke Suzuki
  • 2 edits
    68 adds in trunk/LayoutTests

Introduce Promise A+ tests into WebKit
​https://bugs.webkit.org/show_bug.cgi?id=136878

Reviewed by Sam Weinig.

To ensure WebKit Promise stability, introducing Promise A+ tests[1] into WebKit.
It's also used to test V8 Promise[2].
So the tests guarantee that WebKit Promise's spec validity and interchangeability
to the other browser's Promise implementation.

Promise A+ tests assumes that it works on the Node.js environment. To work it on
LayoutTests correctly, we need to transform Node.js styled JavaScript code into
browser styled code. In this patch, we use browserify[3] to transform the test code.
Through transforming pipeline, some dependent JS code is bundled into the produced code.
So added SinonJS[4] and browserify's license files into the test directory.

And tests assume that it is used with Mocha[5] test runner. So introducing mocha.js and
added LICENSE file into this directory.

And since Promises/A+ 2.3.3 has many tests, it consumes much time (13s in GTK debug build).
So mark it as a Slow test.

[1]: ​https://github.com/promises-aplus/promises-tests
[2]: ​https://code.google.com/p/v8/source/browse#svn%2Ftrunk%2Ftest%2Fpromises-aplus
[3]: ​http://browserify.org/
[4]: ​http://sinonjs.org/
[5]: ​http://visionmedia.github.io/mocha/

  • TestExpectations:
  • js/promises-tests/README: Added.
  • js/promises-tests/browserify-entry-point.js: Added.

(.):

  • js/promises-tests/browserify.LICENSE: Added.
  • js/promises-tests/mocha.LICENSE: Added.
  • js/promises-tests/promises-tests-2-1-2-expected.txt: Added.
  • js/promises-tests/promises-tests-2-1-2.html: Added.
  • js/promises-tests/promises-tests-2-1-3-expected.txt: Added.
  • js/promises-tests/promises-tests-2-1-3.html: Added.
  • js/promises-tests/promises-tests-2-2-1-expected.txt: Added.
  • js/promises-tests/promises-tests-2-2-1.html: Added.
  • js/promises-tests/promises-tests-2-2-2-expected.txt: Added.
  • js/promises-tests/promises-tests-2-2-2.html: Added.
  • js/promises-tests/promises-tests-2-2-3-expected.txt: Added.
  • js/promises-tests/promises-tests-2-2-3.html: Added.
  • js/promises-tests/promises-tests-2-2-4-expected.txt: Added.
  • js/promises-tests/promises-tests-2-2-4.html: Added.
  • js/promises-tests/promises-tests-2-2-5-expected.txt: Added.
  • js/promises-tests/promises-tests-2-2-5.html: Added.
  • js/promises-tests/promises-tests-2-2-6-expected.txt: Added.
  • js/promises-tests/promises-tests-2-2-6.html: Added.
  • js/promises-tests/promises-tests-2-2-7-expected.txt: Added.
  • js/promises-tests/promises-tests-2-2-7.html: Added.
  • js/promises-tests/promises-tests-2-3-1-expected.txt: Added.
  • js/promises-tests/promises-tests-2-3-1.html: Added.
  • js/promises-tests/promises-tests-2-3-2-expected.txt: Added.
  • js/promises-tests/promises-tests-2-3-2.html: Added.
  • js/promises-tests/promises-tests-2-3-3-expected.txt: Added.
  • js/promises-tests/promises-tests-2-3-3.html: Added.
  • js/promises-tests/promises-tests-2-3-4-expected.txt: Added.
  • js/promises-tests/promises-tests-2-3-4.html: Added.
  • js/promises-tests/promises-tests.LICENSE: Added.
  • js/promises-tests/promises-tests.js: Added.

(.):

  • js/promises-tests/promises-tests/.gitignore: Added.
  • js/promises-tests/promises-tests/.jshintrc: Added.
  • js/promises-tests/promises-tests/.npmignore: Added.
  • js/promises-tests/promises-tests/LICENSE.txt: Added.
  • js/promises-tests/promises-tests/README.md: Added.
  • js/promises-tests/promises-tests/lib/cli.js: Added.

(getAdapterFilePath):
(adapterObjectFromFilePath):

  • js/promises-tests/promises-tests/lib/getMochaOpts.js: Added.

(module.exports):

  • js/promises-tests/promises-tests/lib/programmaticRunner.js: Added.

(normalizeAdapter.adapter.resolved):
(normalizeAdapter.adapter.rejected):
(normalizeAdapter):
(.cb):
(.):
(module.exports):
(module.exports.mocha):

  • js/promises-tests/promises-tests/lib/tests/2.1.2.js: Added.

(.):

  • js/promises-tests/promises-tests/lib/tests/2.1.3.js: Added.

(.):

  • js/promises-tests/promises-tests/lib/tests/2.2.1.js: Added.
  • js/promises-tests/promises-tests/lib/tests/2.2.2.js: Added.

(.):

  • js/promises-tests/promises-tests/lib/tests/2.2.3.js: Added.

(.):

  • js/promises-tests/promises-tests/lib/tests/2.2.4.js: Added.

(.):

  • js/promises-tests/promises-tests/lib/tests/2.2.5.js: Added.
  • js/promises-tests/promises-tests/lib/tests/2.2.6.js: Added.

(.return.if):
(callbackAggregator):
(.):

  • js/promises-tests/promises-tests/lib/tests/2.2.7.js: Added.

(.):

  • js/promises-tests/promises-tests/lib/tests/2.3.1.js: Added.

(.):

  • js/promises-tests/promises-tests/lib/tests/2.3.2.js: Added.

(.):
(testPromiseResolution):

  • js/promises-tests/promises-tests/lib/tests/2.3.3.js: Added.

(.):
(testPromiseResolution):
(testCallingResolvePromiseRejectsWith):
(testCallingRejectPromiseRejectsWith):
(describe):

  • js/promises-tests/promises-tests/lib/tests/2.3.4.js: Added.

(.):

  • js/promises-tests/promises-tests/lib/tests/helpers/reasons.js: Added.

(exports.string_appeared_here):
(exports.string_appeared_here.return.then):

  • js/promises-tests/promises-tests/lib/tests/helpers/testThreeCases.js: Added.

(.specify):
(.):
(exports.testFulfilled):
(exports.testRejected):

  • js/promises-tests/promises-tests/lib/tests/helpers/thenables.js: Added.

(exports.fulfilled.string_appeared_here.return.then):
(exports.fulfilled.string_appeared_here):
(exports.fulfilled.string_appeared_here.):
(exports.fulfilled.get string_appeared_here.return.then):
(exports.fulfilled.get string_appeared_here):
(exports.rejected.string_appeared_here.return.then):
(exports.rejected.string_appeared_here):
(exports.rejected.string_appeared_here.):
(exports.rejected.get string_appeared_here.return.then):
(exports.rejected.get string_appeared_here):

  • js/promises-tests/promises-tests/package.json: Added.
  • js/promises-tests/promises-tests/test/getMochaOptsTest.js: Added.
  • js/promises-tests/resources/adapter.js: Added.

(LayoutTestsReporter.runner):
(window.adapter.resolved):
(window.adapter.rejected):
(window.adapter.deferred):

  • js/promises-tests/resources/mocha.js: Added.

(.):

  • js/promises-tests/sinonjs.LICENSE: Added.
5:04 PM Changeset in webkit [174306] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

5:01 PM Changeset in webkit [174305] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.11.12

New tag.

4:48 PM Changeset in webkit [174304] by ap@apple.com
  • 3 edits in trunk/Tools/QueueStatusServer

Bugzilla status bubble displays an exception showing attachment 175738
​https://bugs.webkit.org/show_bug.cgi?id=137410

Reviewed by Tim Horton.

  • QueueStatusServer/app.yaml: Update version.
  • QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):

Don't fail even if expected status message is missing.

  • QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define

the field in the same way it's defined in QueueStatus table.

4:36 PM Changeset in webkit [174303] by ap@apple.com
  • 1 edit in trunk/Tools/ChangeLog

Bugzilla status bubble displays an exception showing attachment 175738
​https://bugs.webkit.org/show_bug.cgi?id=137410

Reviewed by Tim Horton.

  • QueueStatusServer/app.yaml: Update version.
  • QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):

Don't fail even if expected status message is missing.

  • QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define

the field in the same way it's defined in QueueStatus table.

4:27 PM Changeset in webkit [174302] by ap@apple.com
  • 3 edits in trunk/Tools

Record latest message in PatchLog for quick access
​https://bugs.webkit.org/show_bug.cgi?id=137405

Fixing a typo.

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/handlers/releasepatch.py:
4:22 PM Changeset in webkit [174301] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r174216): CodeBlock::dumpByteCodes crashes on op_push_name_scope
​https://bugs.webkit.org/show_bug.cgi?id=137412

Reviewed by Mark Lam.

Added support for the JSNameScope::type opcode parameter in dumpBytecode().

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

4:17 PM Changeset in webkit [174300] by Chris Dumez
  • 63 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for CSSValue subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137381

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() for CSSValue subclasses.

No new tests, no behavior change.

  • css/CSSAspectRatioValue.h:
  • css/CSSBorderImageSliceValue.h:
  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcExpressionNodeParser::parseValue):

  • css/CSSCalculationValue.h:
  • css/CSSCanvasValue.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusShorthandValue):
(WebCore::ComputedStyleExtractor::propertyMatches):

  • css/CSSCrossfadeValue.cpp:

(WebCore::subimageKnownToBeOpaque):

  • css/CSSCrossfadeValue.h:
  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
(WebCore::CSSCursorImageValue::isSVGCursor):

  • css/CSSCursorImageValue.h:
  • css/CSSFilterImageValue.h:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSFontFeatureValue.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSFontValue.h:
  • css/CSSFunctionValue.h:
  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::gradientWithStylesResolved):

  • css/CSSGradientValue.h:
  • css/CSSGridLineNamesValue.h:
  • css/CSSGridTemplateAreasValue.h:
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::isFixedSize):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::isPending):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):
(WebCore::CSSImageGeneratorValue::loadSubimages):
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):

  • css/CSSImageGeneratorValue.h:
  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):

  • css/CSSImageSetValue.h:
  • css/CSSImageValue.h:
  • css/CSSInheritedValue.h:
  • css/CSSInitialValue.h:
  • css/CSSLineBoxContainValue.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::addFillValue):
(WebCore::CSSParser::addAnimationValue):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::gridMissingGridPositionValue):
(WebCore::CSSParser::parseGridTemplateRowsAndAreas):
(WebCore::CSSParser::parseBasicShapeCircle):
(WebCore::CSSParser::parseBasicShapeEllipse):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::createFontFaceRule):

  • css/CSSPrimitiveValue.h:
  • css/CSSReflectValue.h:
  • css/CSSShadowValue.h:
  • css/CSSTimingFunctionValue.h:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImage):
(WebCore::CSSToStyleMap::mapNinePieceImageSlice):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):

  • css/CSSUnicodeRangeValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::hasFailedOrCanceledSubresources):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

  • css/CSSValue.h:
  • css/CSSValueList.h:

(WebCore::CSSValueListInspector::CSSValueListInspector):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyTextDecorationSkip::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyWordSpacing::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyTextEmphasisPosition::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):

  • css/MediaList.cpp:

(WebCore::reportMediaQueryWarningIfNeeded):

  • css/MediaQueryEvaluator.cpp:

(WebCore::compareAspectRatioValue):
(WebCore::numberValue):
(WebCore::orientationMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::computeLength):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::strokeDashArrayToCSSValueList):
(WebCore::ComputedStyleExtractor::svgPropertyValue):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/SourceSizeList.cpp:

(WebCore::computeLength):

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getLayeredShorthandValue):

  • css/StyleResolver.cpp:

(WebCore::extractDirectionAndWritingMode):
(WebCore::createGridTrackSize):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::StyleResolver::parseSnapCoordinate):
(WebCore::StyleResolver::parseSnapPoints):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::createFilterOperations):

  • css/TransformFunctions.cpp:

(WebCore::transformsForValue):

  • css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::getViewportArgumentValue):

  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

  • css/WebKitCSSTransformValue.h:

(WebCore::toWebKitCSSTransformValue): Deleted.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::computedFontSize):

  • editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeStyle):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::legacyFontSize):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::fontWeightIsBold):
(WebCore::isTransparentColorValue):

  • editing/EditorCommand.cpp:

(WebCore::executeToggleStyleInList):

  • editing/cocoa/HTMLConverter.mm:

(stringFromCSSValue):
(HTMLConverterCaches::floatPropertyValueForNode):
(HTMLConverterCaches::colorPropertyValueForNode):

  • editing/markup.cpp:

(WebCore::propertyMissingOrEqualToNone):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::retrieveResourcesForProperties):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::adjustInnerTextStyle):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):

  • svg/SVGColor.h:
  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::rebuildFontFace):

  • svg/SVGPaint.h:
4:05 PM Changeset in webkit [174299] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove a workaround for a bug that's been fixed
​https://bugs.webkit.org/show_bug.cgi?id=137411

Reviewed by Dan Bernstein.

  • mac/rewrite-availability-macros.sh:
3:19 PM Changeset in webkit [174298] by saambarati1@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Implement op_profile_type in the 32-bit baseline JIT
​https://bugs.webkit.org/show_bug.cgi?id=137181

Reviewed by Michael Saboff.

Generate inline code to write to the TypeProfilerLog inside the 32-bit
baseline JIT instead of unconditionally bailing out to the slow path
for op_profile_type.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_type):

3:07 PM Changeset in webkit [174297] by mmaxfield@apple.com
  • 8 edits in trunk/Source/WebCore

Clean up interface to Font::expansionOpportunityCount()
​https://bugs.webkit.org/show_bug.cgi?id=137355

Reviewed by Dean Jackson.

There are two overloads of Font::expansionOpportunityCount() which perform the same
operation. One overload takes a UChar*, the other takes an LChar*, and they both
take a length. This is the abstraction that StringView was designed to be. Instead
of forcing each caller to take a different overload based on if their data is
8 bit or not, allow the caller to construct a StringView and pass that into
Font::expansionOpportunityCount() instead of a raw pointer/length.

No new tests because there is no behavior change.

  • platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCountInternal): Original two functions,
renamed.
(WebCore::Font::expansionOpportunityCount): Takes a StringView, calls
expansionOpportunityCountInternal().

  • platform/graphics/Font.h: Update signatures.
  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Use new signature to
Font::expansionOpportunityCount().

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Ditto.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment): Ditto.

  • rendering/RenderText.cpp:

(WebCore::RenderText::stringView): Accessor to encapsulate character pointer
and length.

  • rendering/RenderText.h: Signature of new accessor.
3:05 PM Changeset in webkit [174296] by Beth Dakin
  • 23 edits
    6 deletes in trunk

Unreviewed, rolling out r174275.
​https://bugs.webkit.org/show_bug.cgi?id=137408

Build failures on the internal bots. (Requested by dethbakin
on #webkit).

Reverted changeset:

"FTL should sink PutLocals"
​https://bugs.webkit.org/show_bug.cgi?id=137168
​http://trac.webkit.org/changeset/174275

Patch by Commit Queue <​commit-queue@webkit.org> on 2014-10-03

3:03 PM Changeset in webkit [174295] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix for MSVC 2013 SP 3.

The std::array initializer is not fully implemented in SP3 and causes a
build error.

  • platform/graphics/transforms/AffineTransform.cpp: Use old style assignment

initialization for MSVC builds until this bug is fixed.

2:46 PM Changeset in webkit [174294] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

tearoff_arguments should always refer to the unmodified arguments register
​https://bugs.webkit.org/show_bug.cgi?id=137406

Reviewed by Michael Saboff.

To simplify subsequent work, and remove unnecessary work from
actual execution this patch simply ensures that tear_off_arguments
refers to the actual unmodified arguments register.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitReturn):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_tear_off_arguments):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_tear_off_arguments):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
2:43 PM Changeset in webkit [174293] by Chris Dumez
  • 2 edits in trunk/Source/WTF

Add TypeCasts.h to xcodeproject
​https://bugs.webkit.org/show_bug.cgi?id=137403

Reviewed by Benjamin Poulain.

Add TypeCasts.h to xcodeproject.

  • WTF.xcodeproj/project.pbxproj:
2:35 PM Changeset in webkit [174292] by saambarati1@gmail.com
  • 9 edits in trunk/Source

Web Inspector: Move the computation that results in UI strings from JSC to the Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=137295

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Remove unnecessary functions and properties from JSC that are
now being computed inside the Web Inspector.

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

  • inspector/protocol/Runtime.json:
  • runtime/TypeSet.cpp:

(JSC::TypeSet::allPrimitiveTypeNames): Deleted.

  • runtime/TypeSet.h:

Source/WebInspectorUI:

The inspector now computes a set of properties that was previously
computed inside JSC.

This patch also addresses the weird experience of the
type of an expression claiming to be both a Number and
an Integer. This could be a bit confusing because Number
is supposed to represent Double|Integer and the previous
UI implied that Number was equivalent to Double. The new UI only
ever shows either the type of Number or Integer when showing
the type information of an expression. It never shows both Number
and Integer simultaneously to describe a single expression.

  • UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet):
(WebInspector.TypeSet.prototype.isContainedIn):
(WebInspector.TypeSet.prototype.get primitiveTypeNames):

  • UserInterface/Views/TypePropertiesSection.js:

(WebInspector.TypePropertiesSection):
(WebInspector.TypePropertiesSection.prototype.onpopulate):

  • UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView):
(WebInspector.TypeTokenView.prototype.update):
(WebInspector.TypeTokenView.prototype._shouldShowPopover):
(WebInspector.TypeTokenView.prototype._displayTypeName):

2:35 PM Changeset in webkit [174291] by ap@apple.com
  • 6 edits in trunk/Tools

Record latest message in PatchLog for quick access
​https://bugs.webkit.org/show_bug.cgi?id=137405

Reviewed by Ryosuke Niwa.

It's no SQL...

  • QueueStatusServer/handlers/releasepatch.py:
  • QueueStatusServer/handlers/updatestatus.py:
  • QueueStatusServer/loggers/recordpatchevent.py:
  • QueueStatusServer/model/patchlog.py:
2:18 PM Changeset in webkit [174290] by dfarler@apple.com
  • 2 edits in trunk/Tools

-asan-blacklist option also renamed to generic -fsanitize-blacklist
​https://bugs.webkit.org/show_bug.cgi?id=137377

Reviewed by Daniel Bates.

  • asan/asan.xcconfig:

-asan-blacklist -> -fsanitize-blacklist

​http://llvm.org/viewvc/llvm-project?view=revision&revision=212505

1:47 PM Changeset in webkit [174289] by betravis@adobe.com
  • 2 edits in trunk/LayoutTests

FTL should sink PutLocals
​https://bugs.webkit.org/show_bug.cgi?id=137168

Patch by Filip Pizlo <​fpizlo@apple.com> on 2014-10-02
Reviewed by Oliver Hunt.

  • js/regress/elidable-new-object-then-call-expected.txt: Added.
  • js/regress/elidable-new-object-then-call.html: Added.
  • js/regress/script-tests/elidable-new-object-then-call.js: Added.

(sumOfArithSeries):
(bar):
(foo):

1:45 PM Changeset in webkit [174288] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Revert an accidental change introduced by r173318.

Rubber-stamped by Tim Horton.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::suspendPainting):
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):

1:36 PM Changeset in webkit [174287] by timothy_horton@apple.com
  • 4 edits in trunk/Source

WKWebView snapshot of Daring Fireball has the wrong color in the obscured inset
​https://bugs.webkit.org/show_bug.cgi?id=137383
<rdar://problem/18535439>

Reviewed by Sam Weinig.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotAtSize):
Use documentBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):
Use documentBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set.

1:32 PM Changeset in webkit [174286] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Highlight clicked links in WKPDFView
​https://bugs.webkit.org/show_bug.cgi?id=137400

Reviewed by Tim Horton.

Show a _UIHighlightView on top of clicked links for 200 ms before starting the navigation. This matches the behavior of UIWebPDFView.

  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView _createHighlightViewWithFrame:]): Created a _UIHighlightView with a color and border radius matching the values used by UIWebPDFView.
(-[WKPDFView annotation:wasTouchedAtPoint:controller:]): Displayed the highlight, then removed it after the navigation began.

1:29 PM Changeset in webkit [174285] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Include batch size argument to layout tests on Windows.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.start):
This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
These crashes seem to happen on random tests though generally in a spread out fashion.
It seems possible that the DRT instance is being clobbered somehow after running too many
tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.

1:28 PM Changeset in webkit [174284] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit/ios

REGRESSION (r165896): UIWebView PDFs have a forced black background
​https://bugs.webkit.org/show_bug.cgi?id=137387
<rdar://problem/17948411>

Reviewed by David Kilzer.

  • WebView/WebPDFViewPlaceholder.h:
  • WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder layout]):
Remove an ill-advised attempt to force the PDF background color from WebKit.
The idea was that we would maintain Safari's black background except if there
were no pages in the PDF, in which case we would use white instead to avoid
having an all-black view. However, this broke clients who didn't want a black
background, because we were now forcing it to black. Also, we don't need to
maintain the black color in Safari because it doesn't use WebPDFViewPlaceholder anymore.
This wasn't an important part of the patch, in any case.

1:27 PM Changeset in webkit [174283] by dino@apple.com
  • 5 edits in trunk/Source/WebCore

webkit-appearance: default-button styling does not set the button font color to white
​https://bugs.webkit.org/show_bug.cgi?id=137399
rdar://problem/17788616

Reviewed by Dave Hyatt.

When a button is styled with -webkit-appearance: default-button, it should
use the CSSValueActivebuttontext value for its text color when the window
is active, and the normal value when the window is inactive.

Since activating (focus/blur) windows doesn't cause a style recalculation, this
is applied as a paint-time operation. However, the render tree children that
paint the text don't know that they are contained within a RenderButton
and that the button is a default type. So I added an inherited flag, similar
to what we use for visited links, to remember if we're in a button. And then
computeTextPaintStyle chooses the correct value.

We can't test this because our LayoutTest system doesn't have
an active window, and thus the default button renders like a normal
button. This should cause no regressions though. Also, the appearance is
protected behind an SPI (or Setting), so this is not exposed to the Web.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle): Set the flag if we're inside a default button.

  • rendering/TextPaintStyle.cpp:

(WebCore::computeTextPaintStyle): If we're in a default button inside an active window,
use the CSSValueActivebuttontext color.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle): Add and expose the new inherited flag: ._insideDefaultButton.
(WebCore::RenderStyle::changeRequiresRepaint): Ditto.

  • rendering/style/RenderStyle.h: Ditto.
1:26 PM Changeset in webkit [174282] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit/ios

REGRESSION (r173265): UIWebView PDF loading is completely broken
​https://bugs.webkit.org/show_bug.cgi?id=137386
<rdar://problem/18524717>

Reviewed by David Kilzer.

  • WebView/WebPDFViewPlaceholder.h:
  • WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder layout]):
(-[WebPDFViewPlaceholder finishedLoadingWithDataSource:]):
Restore important code that creates the CGDataProvider and sets _didFinishLoad
and calls _doPostLoadOrUnlockTasks after finishing a load, which was haphazardly
removed in the aforementioned revision.

1:20 PM Changeset in webkit [174281] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.11-branch/Source/WebCore

Merged r174277. <rdar://problem/18436044>

1:15 PM Changeset in webkit [174280] by bshafiei@apple.com
  • 4 edits in branches/safari-600.1.4.11-branch/Source/WebCore

Merged r174244. <rdar://problem/18507382>

1:10 PM Changeset in webkit [174279] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[SVG -> OTF Converter] Support non-BMP codepoints
​https://bugs.webkit.org/show_bug.cgi?id=137097

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2014-09-28
Reviewed by Darin Adler.

This patch has two pieces:

1) Moves write16(), overwrite32() and overwrite16() inside SVGToOTFFontConverter. This
is so that we don't have to keep passing around references to m_result everywhere. Instead,
put the output vector inside the class as an instance member variable. In addition, rename
write32() and write16() to append32() and append16(), and provide a copy of append32 inside
SVGToOTFFontConverter.

2) Change the "Codepoint" typedef to be a String, and rename it to Codepoints. This is so that
we can implement ligatures later on. Update all the places that use this variable to work with
a String of multiple codepoints.

This patch updates the CMAP table to use format 12 instead of format 4. It currently only maps
single codepoints to glyph IDs and skips all multi-codepoint glyphs. We will implement
ligatures in another patch.

Test: svg/custom/glyph-selection-non-bmp.svg

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::append32): Append a result to a given vector. This is for the path transcoder.
(WebCore::SVGToOTFFontConverter::releaseResult): WTF::move()'s the result.
(WebCore::SVGToOTFFontConverter::GlyphData::GlyphData): Update to take Codepoints instead of Codepoint.
(WebCore::SVGToOTFFontConverter::append32): Piece 1 above.
(WebCore::SVGToOTFFontConverter::append16): Ditto.
(WebCore::SVGToOTFFontConverter::append4ByteCode): Convenience function.
(WebCore::SVGToOTFFontConverter::overwrite32): Piece 1 above.
(WebCore::SVGToOTFFontConverter::overwrite16): Ditto.
(WebCore::SVGToOTFFontConverter::appendCMAPTable): Update to format 12.
(WebCore::SVGToOTFFontConverter::appendHEADTable): Passing in a result vector is no longer necessary.
(WebCore::SVGToOTFFontConverter::appendHHEATable): Ditto.
(WebCore::SVGToOTFFontConverter::appendHMTXTable): Ditto.
(WebCore::SVGToOTFFontConverter::appendMAXPTable): Ditto.
(WebCore::SVGToOTFFontConverter::appendNAMETable): Ditto.
(WebCore::SVGToOTFFontConverter::appendOS2Table): Ditto.
(WebCore::SVGToOTFFontConverter::appendPOSTTable): Ditto.
(WebCore::isValidStringForCFF): Ditto.
(WebCore::SVGToOTFFontConverter::appendCFFValidString): Ditto.
(WebCore::SVGToOTFFontConverter::appendCFFTable): Ditto.
(WebCore::SVGToOTFFontConverter::appendVORGTable): Ditto.
(WebCore::SVGToOTFFontConverter::appendVHEATable): Ditto.
(WebCore::SVGToOTFFontConverter::appendVMTXTable): Ditto.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): Update for Codepoints.
(WebCore::SVGToOTFFontConverter::addCodepoints): Ditto.
(WebCore::SVGToOTFFontConverter::addGlyphNames): Ditto.
(WebCore::SVGToOTFFontConverter::appendKERNSubtable): Ditto.
(WebCore::SVGToOTFFontConverter::appendKERNTable): Ditto.
(WebCore::writeCFFEncodedNumber): Passing in a result vector is no longer necessary.
(WebCore::SVGToOTFFontConverter::appendGlyphData): Update for Codepoints.
(WebCore::SVGToOTFFontConverter::processGlyphElement): Update for Codepoints.
(WebCore::SVGToOTFFontConverter::compareCodepointsLexicographically): Comparing Codepoints
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Update for Codepoints.
(WebCore::SVGToOTFFontConverter::calculateChecksum): Passing in a result vector is no longer necessary.
(WebCore::SVGToOTFFontConverter::appendTable): Ditto.
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): Ditto.
(WebCore::convertSVGToOTFFont): Move out of the result vector.
(WebCore::write32): Deleted.
(WebCore::write16): Deleted.
(WebCore::overwrite32): Deleted.
(WebCore::appendCFFValidString): Deleted.
(WebCore::transcodeGlyphPaths): Deleted.
(WebCore::calculateChecksum): Deleted.

1:08 PM Changeset in webkit [174278] by Beth Dakin
  • 16 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r174270.
​https://bugs.webkit.org/show_bug.cgi?id=137397

crashes on the bots (Requested by dethbakin on #webkit).

Reverted changeset:

"EventSender dispatches should be per-Document"
​https://bugs.webkit.org/show_bug.cgi?id=136051
​http://trac.webkit.org/changeset/174270

Patch by Commit Queue <​commit-queue@webkit.org> on 2014-10-03

1:07 PM Changeset in webkit [174277] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Back-to-back fullscreen videos result in incorrectly sized videos
​https://bugs.webkit.org/show_bug.cgi?id=137380

Reviewed by Eric Carlson.

During a normal workflow, a <video> element will create an AVPlayerLayer, then it will get a
fullscreen (hosted) parent layer, then it will be told an explicit fullscreen size. But when
a <video> element creates an AVPlayerLayer after the <video> element is already in
fullscreen mode, it sets that AVPlayerLayer's frame using the size of the hosted parent
layer, rather than the explicit fullscreen size. Instead, use the (already set) explicit
fullscreen size after creating the AVPlayerLayer.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::ensureAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer):

12:58 PM Changeset in webkit [174276] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Settle for 2 chid processes running NRWT on Windows.

  • Scripts/webkitpy/port/win.py:

(WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.

12:38 PM Changeset in webkit [174275] by fpizlo@apple.com
  • 23 edits
    6 adds in trunk

FTL should sink PutLocals
​https://bugs.webkit.org/show_bug.cgi?id=137168

Reviewed by Oliver Hunt.
Source/JavaScriptCore:


We've known for a while that our PutLocal situation was sub-optimal. We emit them anytime we
"pass" arguments to an inlined function call, because we need to enable the runtime to grab
those arguments when doing foo.arguments where foo is inlined: our engine doesn't deoptimize
in that case but rather just relies on the arguments being flushed (i.e. a copy of their
values is spilled) at a well-known place in a well-known format.

The PutLocals incur two costs: (1) they are store instructions and stores ain't free, and (2)
they look like escaping sites and so they inhibit object allocation sinking.

But in most cases, the PutLocals are unnecessary because the inlined code never performs any
side effect that could transitively lead to function.arguments. Even if the inlined code
could do such a side effect, it may be on a rare path so there is no need to penalize the
entire function.

This patch implements one solution to the PutLocal problem: it aggressively sinks PutLocals
to the latest possible point. This is even more aggressive than the object allocation
sinking. That sinking algorithm avoids creating situations where an object could be
materialized more than one along any path. PutLocal sinking, on the other hand, doesn't avoid
this at all - both to make the phase cheaper and simpler and to make it more aggressive.
Every PutLocal is sunk no matter what.

The upside of this patch is that it eliminates many PutLocals: many of them are sunk "past
their death", thus eliminating them completely. Others are sunk to rare paths. This enables a
lot of object allocation sinking and it removes a lot of pointless store instructions.

It also has downsites. Sinking PutLocals increases register pressure because it increases the
live ranges of things like inlined arguments.

This patch is a net performance win in its current form: 1% SunSpider regression, 2% OctaneV2
progression, 0.6% Kraken regression, 1% AsmBench progression, and 0.5% CompressionBench
regression. The biggest win is on Octane/raytrace, which improves by 27%.

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.h:
  • bytecode/Operands.h:

(JSC::Operands::dump): Deleted.

  • bytecode/OperandsInlines.h:

(JSC::Traits>::dump):

  • bytecode/VirtualRegister.h:

(JSC::VirtualRegister::isHeader):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGClobberSet.h:

(JSC::DFG::ClobberSetAdd::operator()):
(JSC::DFG::ClobberSetOverlaps::operator()):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):
(JSC::DFG::NoOpClobberize::operator()):
(JSC::DFG::CheckClobberize::operator()):
(JSC::DFG::AbstractHeapOverlaps::operator()):
(JSC::DFG::ReadMethodClobberize::operator()):
(JSC::DFG::WriteMethodClobberize::operator()):
(JSC::DFG::DefMethodClobberize::operator()):

  • dfg/DFGFlushFormat.h:

(JSC::DFG::merge):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::capturedVarsFor):

  • dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::determineMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::placeMaterializationPoints):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPreciseLocalClobberize.h: Added.

(JSC::DFG::PreciseLocalClobberizeAdaptor::PreciseLocalClobberizeAdaptor):
(JSC::DFG::PreciseLocalClobberizeAdaptor::read):
(JSC::DFG::PreciseLocalClobberizeAdaptor::write):
(JSC::DFG::PreciseLocalClobberizeAdaptor::def):
(JSC::DFG::PreciseLocalClobberizeAdaptor::callIfAppropriate):
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
(JSC::DFG::PreciseLocalClobberizeAdaptor::writeTop):
(JSC::DFG::forEachLocalReadByUnwind):
(JSC::DFG::preciseLocalClobberize):

  • dfg/DFGPutLocalSinkingPhase.cpp: Added.

(JSC::DFG::performPutLocalSinking):

  • dfg/DFGPutLocalSinkingPhase.h: Added.
  • dfg/DFGSSACalculator.h:

(JSC::DFG::SSACalculator::computePhis):

  • dfg/DFGValidate.cpp:

Source/WTF:


Make the set bits of a BitVector iterable.

  • wtf/BitVector.h:

(WTF::BitVector::SetBitsIterable::SetBitsIterable):
(WTF::BitVector::SetBitsIterable::iterator::iterator):
(WTF::BitVector::SetBitsIterable::iterator::operator*):
(WTF::BitVector::SetBitsIterable::iterator::operator++):
(WTF::BitVector::SetBitsIterable::iterator::operator==):
(WTF::BitVector::SetBitsIterable::iterator::operator!=):
(WTF::BitVector::SetBitsIterable::begin):
(WTF::BitVector::SetBitsIterable::end):
(WTF::BitVector::setBits):

LayoutTests:

  • js/regress/elidable-new-object-then-call-expected.txt: Added.
  • js/regress/elidable-new-object-then-call.html: Added.
  • js/regress/script-tests/elidable-new-object-then-call.js: Added.

(sumOfArithSeries):
(bar):
(foo):

11:38 AM Changeset in webkit [174274] by commit-queue@webkit.org
  • 2 edits
    3 adds
    1 delete in trunk/Tools

[GTK] Bump up and patch dependencies to allow building for aarch64
​https://bugs.webkit.org/show_bug.cgi?id=137147

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-10-03
Reviewed by Martin Robinson.

The currently used versions of pixman, libffi, librsvg, glib,
glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
and/or build for aarch64, so they are bumped up and patched where
necessary. Wherever possible, the same versions and patches were used as
for the EFL port bump-up
(​https://bugs.webkit.org/show_bug.cgi?id=135885).

After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
regression by crashing http/tests/media/video-redirect.html . A patch
already in upstream fixes that bug.

This change does not touch xserver, which also needs bumping up, but
will be dealt with later.

  • gtk/jhbuild.modules:

Specified versions and patches necessary to correctly build for aarch64.

  • gtk/patches/gst-events-arent-gstobjects.patch:

Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.

  • gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:

Added. Patches gst-plugins-base to configure correctly for aarch64.

  • gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:

Added. Bumps up config.guess and config.sub in librsvg to recognize
aarch64.

  • gtk/patches/libxml2-2.9.0-dtd.patch:

Removed. Not necessary for libxml2 v2.9.1 anymore.

11:35 AM Changeset in webkit [174273] by betravis@adobe.com
  • 4 edits
    2 adds in trunk

REGRESSION (r173531): Use after free in WebCore::RenderStyle::fontMetrics /
WebCore::CSSPrimitiveValue::computeLengthDouble
​https://bugs.webkit.org/show_bug.cgi?id=136864

Reviewed by Andreas Kling.

Source/WebCore:

FontLoader previously called updateDocumentStyleIfNeeded,
which would reset styles currently in use as part of
the tabIndex calculation. The FontLoader should instead
wait for pending stylesheets to load.

Tests: fast/css/fontloader-tab-index.html

  • css/FontLoader.cpp:

(WebCore::FontLoader::notifyWhenFontsReady): Do not immediately
call loadingDone().
(WebCore::FontLoader::loadingDone): Wait for stylesheets to
finish loading rather than updating document styles.

  • css/FontLoader.h:

(WebCore::FontLoader::loading): Include JS font loads when testing
for the loading state.

LayoutTests:

Test that getting the tab index on a body element with
font-relative measurements to a local @font-face do not
cause a crash.

  • fast/css/fontloader-tab-index-expected.html: Added.
  • fast/css/fontloader-tab-index.html: Added.
10:55 AM Changeset in webkit [174272] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

Fixing the Windows build after r174269.

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2014-10-03

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem):

10:43 AM Changeset in webkit [174271] by mmaxfield@apple.com
  • 3 edits in trunk

Support modern for loops over StringViews
​https://bugs.webkit.org/show_bug.cgi?id=137165

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2014-10-03
Reviewed by Darin Adler.

This patch adds two functions, codePoints() and codeUnits(), on StringView.
These two functions return small objects which have begin() and end() functions,
which means it can be used by the modern for loop style. This small class also
has an inner iterator class which can be incremented, dereferenced, and
compared.

Using these new objects looks like this:
for (UChar codeunit : stringView.codeUnits()) { } and
for (UChar32 codepoint : stringView.codePoints()) { }.

  • wtf/text/StringView.h:

(WTF::StringView::codepoints):
(WTF::StringView::codeunits):
(WTF::StringViewCodePointIterator::StringViewCodePointIterator):
(WTF::StringViewCodePointIterator::Iterator::Iterator):
(WTF::StringViewCodePointIterator::Iterator::operator*):
(WTF::StringViewCodePointIterator::Iterator::operator!=):
(WTF::StringViewCodeUnitIterator::StringViewCodeUnitIterator):
(WTF::StringViewCodeUnitIterator::Iterator::Iterator):
(WTF::StringViewCodeUnitIterator::Iterator::operator*):
(WTF::StringViewCodeUnitIterator::Iterator::operator!=):

10:15 AM Changeset in webkit [174270] by Brian Burg
  • 16 edits
    2 adds in trunk/Source/WebCore

EventSender dispatches should be per-Document
​https://bugs.webkit.org/show_bug.cgi?id=136051

Reviewed by Andreas Kling.

EventSender uses a Timer to asynchronously dispatch the same event to multiple
elements of the same type on a future run loop. However, we previously dispatched events
to elements from any Document rather than the one that requested the event send.

This patch changes EventSender to be associated with a single Document. EventSenders
for each Document are lazily allocated. Further per-Document or global optimizations
are possible.

This change also lays the groundwork for making EventSender-related DOM events
deterministic during web replay, tracked at <​https://webkit.org/b/137090>.

No new tests, covered by fast/text/svg-font-trigger-load-event.html.

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::implicitClose):
Dispatch pending events for this document only. Rename local variable f to frame.

  • dom/Document.h:

(WebCore::Document::sharedEventSenders):

  • dom/EventSender.h:

(WebCore::EventSender::EventSender):
(WebCore::EventSender::hasPendingEvents):
(WebCore::EventSender<T>::dispatchEventSoon):
(WebCore::EventSender<T>::cancelEvent):
(WebCore::EventSender<T>::dispatchPendingEvents):
(WebCore::EventSender<T>::EventSender): Deleted. The type argument was not necessary.

  • dom/SharedEventSenders.cpp: Added. Lazily creates event senders as they are requested.

(WebCore::SharedEventSenders::linkLoadEventSender):
(WebCore::SharedEventSenders::styleLoadEventSender):
(WebCore::SharedEventSenders::imageBeforeloadEventSender):
(WebCore::SharedEventSenders::imageLoadEventSender):
(WebCore::SharedEventSenders::imageErrorEventSender):

  • dom/SharedEventSenders.h: Added.

(WebCore::SharedEventSenders::SharedEventSenders):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::dispatchPendingEvent):
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources):
(WebCore::linkLoadEventSender): Deleted.
(WebCore::HTMLLinkElement::dispatchPendingLoadEvents): Deleted.

  • html/HTMLLinkElement.h:
  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::~HTMLStyleElement):
(WebCore::HTMLStyleElement::dispatchPendingEvent):
(WebCore::HTMLStyleElement::notifyLoadedSheetAndAllCriticalSubresources):
(WebCore::styleLoadEventSender): Deleted.
(WebCore::HTMLStyleElement::dispatchPendingLoadEvents): Deleted.

  • html/HTMLStyleElement.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::beforeLoadEventSender):
(WebCore::ImageLoader::loadEventSender):
(WebCore::ImageLoader::errorEventSender):
(WebCore::ImageLoader::dispatchPendingEvent):
(WebCore::beforeLoadEventSender): Deleted.
(WebCore::loadEventSender): Deleted.
(WebCore::errorEventSender): Deleted.
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvents): Deleted.
(WebCore::ImageLoader::dispatchPendingLoadEvents): Deleted.
(WebCore::ImageLoader::dispatchPendingErrorEvents): Deleted.

  • loader/ImageLoader.h:
  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::append): Remove an early call to the EventSender for image
beforeload events. This was a performance optimization, but is no longer safe since the
document (and thus the event sender) may not be available in a synchronous document write.

9:57 AM Changeset in webkit [174269] by mmaxfield@apple.com
  • 9 edits in trunk/Source/WebCore

TextRun::length() should return an unsigned
​https://bugs.webkit.org/show_bug.cgi?id=137354

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2014-10-03
Reviewed by Antti Koivisto.

Currently, the m_len instance variable that backs the TextRun::length() function is
an unsigned, but the length() function implicitly casts that to an int when
returning it. This patch makes the function return an unsigned, and makes the
do any casting if necessary.

No new tests because there is no behavior change.

  • platform/graphics/Font.cpp:

(WebCore::Font::drawText): Cast result to int.
(WebCore::Font::drawEmphasisMarks): Ditto.
(WebCore::Font::adjustSelectionRectForText): Ditto.
(WebCore::computeUnderlineType): Update internal type to be unsigned.

  • platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::add): Update sentinel value to be unsigned.
(WebCore::GlyphBuffer::saveOffsetsInString): Ditto.

  • platform/graphics/GraphicsContext.cpp: Update internal type to be unsigned.
  • platform/graphics/TextRun.h:

(WebCore::TextRun::length): Update return type.
(WebCore::TextRun::charactersLength): Ditto.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal): Cast result to int.

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair): Remove
unnecessary casts.
(WebCore::SVGTextMetricsBuilder::advance): Ditto.

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection): Cast result to int.

9:51 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
9:47 AM Changeset in webkit [174268] by weinig@apple.com
  • 8 edits
    1 delete in trunk

Remove RefPtrHashMap
​https://bugs.webkit.org/show_bug.cgi?id=137200

Reviewed by Darin Adler.

Source/WTF:

HashMap now has all the features of the RefPtr specialization of HashMap
(which lived in RefPtrHashMap.h) and is in fact more efficient when moving
items into it. For instance:

For HashMap<RefPtr<Foo>, Bar> map:

RefPtr<Foo> foo = ...;
map.add(WTF::move(foo), Bar());

will now not cause a ref() / deref(), but will successfully move the item in
without churn. The same is true if foo.release() was used.

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:

Remove references to RefPtrHashMap.h.

  • wtf/RefPtrHashMap.h: Removed.
  • wtf/HashMap.h:

Remove #include of RefPtrHashMap.h and add inlineGet to match the interface
exposed by the RefPtrHashMap specialization.

Tools:

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):
Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
a minimum of refcount churn occurs.

9:43 AM Changeset in webkit [174267] by clopez@igalia.com
  • 35 edits
    1 add in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Update test name for bug 136673 after r173418.
  • platform/gtk/css1/box_properties/clear_float-expected.txt: Rebaseline after r174233.
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt: Rebaseline after r174233.
  • platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt: Rebaseline after r174233.
  • platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Rebaseline after r174233.
  • platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/multicol/float-avoidance-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/multicol/overflow-across-columns-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/multicol/overflow-across-columns-percent-height-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/multicol/overflow-unsplittable-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/multicol/positive-leading-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/text/justified-selection-at-edge-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.txt: Rebaseline after r174233.
  • platform/gtk/fast/text/justify-nbsp-expected.txt: Added. Rebaseline after r174233.
  • platform/gtk/fast/text/trailing-white-space-2-expected.txt: Rebaseline after r174233.
  • platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt: Rebaseline after r174233.
  • platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.txt: Rebaseline after r174233.
  • platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt: Rebaseline after r174233.
  • platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.txt: Rebaseline after r174233.
  • platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt: Rebaseline after r174233.
  • platform/gtk/tables/mozilla/marvin/x_tr_align_justify-expected.txt: Rebaseline after r174233.
8:03 AM Changeset in webkit [174266] by evab.u-szeged@partner.samsung.com
  • 6 edits in trunk/Tools

Remove workarounds for versions of Python before 2.7
​https://bugs.webkit.org/show_bug.cgi?id=137338

Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._extract_targz):
(AutoInstaller._unzip):
(AutoInstaller): Deleted.
(AutoInstaller._extract_all): Deleted.

  • Scripts/webkitpy/common/webkitunittest.py:

(TestCase.setUp): Deleted.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):
(TestConfigurationConverter):
(TestConfigurationConverter.combinations): Deleted.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  • Scripts/webkitpy/port/base.py:
6:34 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
5:26 AM Changeset in webkit [174265] by evab.u-szeged@partner.samsung.com
  • 8 edits in trunk/Tools

Unreviewed, rolling out r174264.
​https://bugs.webkit.org/show_bug.cgi?id=137392

It broke run-webkit-tests (Requested by ebalazsfalvi on
#webkit).

Reverted changeset:

"Remove workarounds for versions of Python before 2.7"
​https://bugs.webkit.org/show_bug.cgi?id=137338
​http://trac.webkit.org/changeset/174264

Patch by Commit Queue <​commit-queue@webkit.org> on 2014-10-03

3:14 AM Changeset in webkit [174264] by evab.u-szeged@partner.samsung.com
  • 8 edits in trunk/Tools

Remove workarounds for versions of Python before 2.7
​https://bugs.webkit.org/show_bug.cgi?id=137338

Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._extract_targz):
(AutoInstaller._unzip):
(AutoInstaller): Deleted.
(AutoInstaller._extract_all): Deleted.

  • Scripts/webkitpy/common/webkitunittest.py:

(TestCase.setUp): Deleted.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):
(TestConfigurationConverter):
(TestConfigurationConverter.combinations): Deleted.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  • Scripts/webkitpy/port/base.py:
  • Scripts/webkitpy/port/driver.py:

(ContentBlock.init):

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess._reset):

3:13 AM Changeset in webkit [174263] by evab.u-szeged@partner.samsung.com
  • 4 edits in trunk/Tools

Remove autoinstaller workaround for python 2.6
​https://bugs.webkit.org/show_bug.cgi?id=137343

Reviewed by Daniel Bates.

Reverting <​http://trac.webkit.org/changeset/124928>, neither Python
2.6, nor Snow Leopard is supported anymore, so the workaround is not
needed anymore.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller.install):

  • Scripts/webkitpy/test/main.py:

(Tester._run_tests):

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_mechanize):
(AutoinstallImportHook._install_pep8):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_buildbot):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install_irc):
(AutoinstallImportHook._install):
(autoinstall_everything):

2:25 AM Changeset in webkit [174262] by Csaba Osztrogonác
  • 6 edits in trunk/Source/WebKit2

[GTK] URTBF after r174231.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkit_web_page_get_dom_document):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didInstallPageOverlay): Deleted.
(WebKit::DrawingAreaImpl::didUninstallPageOverlay): Deleted.
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay): Deleted.
(WebKit::DrawingAreaImpl::setPageOverlayOpacity): Deleted.

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::createPageOverlayLayer):
(WebKit::LayerTreeHostGtk::destroyPageOverlayLayer):
(WebKit::LayerTreeHostGtk::didInstallPageOverlay): Deleted.
(WebKit::LayerTreeHostGtk::didUninstallPageOverlay): Deleted.
(WebKit::LayerTreeHostGtk::setPageOverlayNeedsDisplay): Deleted.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
1:00 AM Changeset in webkit [174261] by gyuyoung.kim@samsung.com
  • 8 edits in trunk/Source

[EFL] Fix build break since r174231 and r174256
​https://bugs.webkit.org/show_bug.cgi?id=137384

Unreviewed, EFL build fix.

r174231 and r174256 didn't consider EFL port and CoordinatedGraphics area.

Source/WebCore:

  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::WebKitCSSViewportRule):

  • css/WebKitCSSViewportRule.h:

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

(WebKit::CoordinatedDrawingArea::mainFrameContentSizeChanged):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):

  • WebProcess/WebPage/TapHighlightController.cpp:

(WebKit::TapHighlightController::highlight):
(WebKit::TapHighlightController::hideHighlight):

  • WebProcess/WebPage/TapHighlightController.h: Add WebCore:: namespace prefix to PageOverlay argument type.
12:53 AM Changeset in webkit [174260] by saambarati1@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Change how 32-bit JSValues check if they are a Boolean

Rubber stamped by Filip Pizlo.

32-bit JSValue::isBoolean can simply check if its tag corresponds
to the boolean tag instead of checking if it's either true or false.

  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::isBoolean):

12:13 AM Changeset in webkit [174259] by Yusuke Suzuki
  • 13 edits
    16 adds in trunk

CSS Selectors Level 4: Add parsing for :matches
​https://bugs.webkit.org/show_bug.cgi?id=137348

Reviewed by Benjamin Poulain.

Source/WebCore:

Add initial parsing functionality of :matches pseudo class in Selectors Level 4.
It accepts selector list as a parameter. It can contain pseudo elements.
And now at the parsing phase, multiple pseudo elements are allowed.
Currently :not doesn't accept any functional pseudo classes, :not(:matches(...)) is rejected.
And currently, :matches(:visited, :link) is allowed in the parsing phase.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::detectFunctionTypeToken):

  • css/CSSSelector.cpp:

(WebCore::appendSelectorList):
(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:

Cover CSSOM tests; canonicalizing :matches text representation.

  • fast/css/parsing-css-matches-1-expected.txt: Added.
  • fast/css/parsing-css-matches-1.html: Added.
  • fast/css/parsing-css-matches-2-expected.txt: Added.
  • fast/css/parsing-css-matches-2.html: Added.
  • fast/css/parsing-css-matches-3-expected.txt: Added.
  • fast/css/parsing-css-matches-3.html: Added.
  • fast/css/parsing-css-matches-4-expected.txt: Added.
  • fast/css/parsing-css-matches-4.html: Added.
  • fast/css/parsing-css-matches-5-expected.txt: Added.
  • fast/css/parsing-css-matches-5.html: Added.
  • fast/css/parsing-css-matches-6-expected.txt: Added.
  • fast/css/parsing-css-matches-6.html: Added.

Valid :matches are tested in the above tests. Selector lists with 1, 2, 3 elements are tested.

  • fast/css/parsing-css-matches-7-expected.txt: Added.
  • fast/css/parsing-css-matches-7.html: Added.
  • fast/css/parsing-css-matches-8-expected.txt: Added.
  • fast/css/parsing-css-matches-8.html: Added.

Invalid :matches are tested in the above tests. :matches() etc. are tested.

Oct 2, 2014:

11:15 PM Changeset in webkit [174258] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.2/Source/WebCore

Merged r174252. <rdar://problem/18531395>

10:39 PM Changeset in webkit [174257] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF after r174231 to fix non Apple builds.

  • WebProcess/WebPage/WebPage.h:
9:38 PM Changeset in webkit [174256] by akling@apple.com
  • 29 edits in trunk/Source/WebCore

CSSOM rule wrappers always have a corresponding internal style object.
<​https://webkit.org/b/137379>

Make the CSSOM rule wrapper classes use references & Ref instead of
raw pointers and RefPtr for pointing to the internal style rule.

Also changed the signature of reattach() to take a StyleRuleBase&
since it's never called with a null pointer.

Finally marked the rule classes final.

Reviewed by Geoffrey Garen.

  • css/CSSCharsetRule.h:
  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::CSSFontFaceRule):
(WebCore::CSSFontFaceRule::reattach):

  • css/CSSFontFaceRule.h:

(WebCore::CSSFontFaceRule::create): Deleted.

  • css/CSSGroupingRule.cpp:

(WebCore::CSSGroupingRule::CSSGroupingRule):
(WebCore::CSSGroupingRule::reattach):

  • css/CSSGroupingRule.h:
  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::href):
(WebCore::CSSImportRule::media):
(WebCore::CSSImportRule::cssText):
(WebCore::CSSImportRule::styleSheet):
(WebCore::CSSImportRule::reattach):

  • css/CSSImportRule.h:

(WebCore::CSSImportRule::create): Deleted.

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::mediaQueries):
(WebCore::CSSMediaRule::reattach):

  • css/CSSMediaRule.h:

(WebCore::CSSMediaRule::create): Deleted.

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):
(WebCore::CSSPageRule::reattach):

  • css/CSSPageRule.h:

(WebCore::CSSPageRule::create): Deleted.

  • css/CSSRule.h:
  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::reattach):

  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::create): Deleted.
(WebCore::CSSStyleRule::styleRule): Deleted.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):

  • css/CSSSupportsRule.cpp:

(WebCore::CSSSupportsRule::CSSSupportsRule):
(WebCore::CSSSupportsRule::conditionText):

  • css/CSSSupportsRule.h:

(WebCore::CSSSupportsRule::create):

  • css/CSSUnknownRule.h:
  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::createCSSOMWrapper):

  • css/StyleRuleImport.h:

(WebCore::StyleRuleImport::mediaQueries):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::reattach):

  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::item):
(WebCore::WebKitCSSKeyframesRule::reattach):

  • css/WebKitCSSKeyframesRule.h:

(WebCore::WebKitCSSKeyframesRule::create):

  • css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):

  • css/WebKitCSSRegionRule.h:

(WebCore::WebKitCSSRegionRule::create):

  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::reattach):

  • css/WebKitCSSViewportRule.h:
7:49 PM Changeset in webkit [174255] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Add back debugging/testing code that I accidentally removed.

  • wtf/text/StringConcatenate.h:

(WTF::StringTypeAdapter<String>::writeTo):

7:07 PM Changeset in webkit [174254] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Cannot add a new CSS Rule to elements with 3 or more class names
​https://bugs.webkit.org/show_bug.cgi?id=137375

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-02
Reviewed by Timothy Hatcher.

Correctly merge all class names with dots instead of just the first two.

  • UserInterface/Models/DOMNode.js:
6:40 PM Changeset in webkit [174253] by Chris Dumez
  • 14 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for CSSRule subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137364

Reviewed by Benjamin Poulain.

Use is<>() / downcast<>() functions for CSSRule subclasses.

No new tests, no behavior change.

  • css/CSSFontFaceRule.h:
  • css/CSSImportRule.h:
  • css/CSSMediaRule.h:
  • css/CSSRule.h:
  • css/CSSStyleRule.h:
  • css/CSSSupportsRule.h:
  • css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collect):

  • css/WebKitCSSKeyframesRule.h:
  • css/WebKitCSSRegionRule.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asCSSStyleRule):
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::addRule):
(WebCore::InspectorStyleSheet::collectFlatRules):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

5:37 PM Changeset in webkit [174252] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/18531395> REGRESSION (r173272): Crash in ResourceResponse::platformSuggestedFilename() when called on the null response
​https://bugs.webkit.org/show_bug.cgi?id=137239

Reviewed by Pratik Solanki.

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformSuggestedFilename): Return the null String if
m_cfResponse is null.

5:30 PM Changeset in webkit [174251] by dbates@webkit.org
  • 4 edits in trunk

Use version number 101000 instead of 10100 for OS X Yosemite
​https://bugs.webkit.org/show_bug.cgi?id=137372

Reviewed by Mark Rowe.

The version number for OS X Yosemite is 101000.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

  • DumpRenderTree/mac/TextInputController.m:
4:56 PM Changeset in webkit [174250] by aestes@apple.com
  • 4 edits
    2 adds in trunk/Source

[iOS] Create an SPI wrapper for _UIHighlightView and use it in WKContentView
​https://bugs.webkit.org/show_bug.cgi?id=137370

Reviewed by Tim Horton.

Source/WebCore:

Added _UIHighlightViewSPI.h. When building against the internal SDK it imports <UIKit/_UIHighlightView.h>. Otherwise, it redeclares the SPI we use in WebKit2.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/spi/ios/_UIHighlightViewSPI.h: Added.

Source/WebKit2:

  • UIProcess/ios/WKContentViewInteraction.mm: Included <WebCore/_UIHighlightViewSPI.h> instead of <UIKit/_UIHighlightView.h>.
4:50 PM Changeset in webkit [174249] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

4:49 PM Changeset in webkit [174248] by ap@apple.com
  • 12 edits in trunk/Tools

update-work-items should never delete items
​https://bugs.webkit.org/show_bug.cgi?id=137366

Reviewed by Ryosuke Niwa.

As we don't just replace the whole list any more, indicate which items are high
priority, and which are not. Hight priority ones will be prepended to the queue,
others will be appended.

This creates a bit of unfairness in that high priority item queue becomes a LIFO.
But hopefully we will never have many rollouts competing like that.

  • QueueStatusServer/app.yaml: Update version.
  • QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high

priority and regular items separately. Removed some error handling that used to
end up in returning status 500 - an uncaught exception does that automatically.

  • QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
  • QueueStatusServer/model/workitems.py: Added a way to add high priority items.
  • QueueStatusServer/templates/updateworkitems.html: Added a field for high

priority items.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
line that complicated testing.

  • Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
  • Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular

priority items into separate lists.

  • Scripts/webkitpy/common/net/statusserver_mock.py:
  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:

Updated tests.

4:47 PM Changeset in webkit [174247] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.11.11

New tag.

4:41 PM Changeset in webkit [174246] by b.long@cablelabs.com
  • 2 edits in trunk/Tools

Annoying build warnings in WTFString API tests
​https://bugs.webkit.org/show_bug.cgi?id=137360

Reviewed by Darin Adler.

  • TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).

4:41 PM Changeset in webkit [174245] by benjamin@webkit.org
  • 3 edits
    20 adds in trunk

CSS JIT: add the initial implementation of :nth-child(An+B of selector)
​https://bugs.webkit.org/show_bug.cgi?id=137285

Reviewed by Andreas Kling.

Source/WebCore:

This patch adds the baseline support for JIT compiling :nth-child(An+B of selector).

The simple optimizations from the classic :nth-child() are carried over to :nth-child(An+B of selector),
but the new code generation is pretty much left completely unoptimized.

The main challenge introduced with the new functional pseudo classes is the possibility of backtracking
while already inside a backtracking chain.

For example:

:nth-child(odd of a+a+a~a)+b+b~b

has to backtrack the chain a+a+a while already in the backtracking chain b+b+b.

The easiest way to solve this would have been to have each subselector generate a new function.
The generator for :nth-child() would simply call the function call for each sibling.

In the example, we would have:

functionA(): a+a+a~a
selectorChecker(): :nth-child(odd of functionA())+b+b~b

I decided against explicit functions because I believe the would be counterproductive for the common cases.
I expect most use of :nth-child(of) to be done with a light filter without combinators, things like:

:nth-child(odd of .class)
:nth-child(odd of type.class)
:nth-child(odd of type[attribute=value])
etc.

For simple cases, inlining the internal filter will greatly simplify the generated code.

In this particular patch, the selector checkers are inlined, but we do not attempt to have good code generation.
The optimizations will come later.

To implement backtracking in the subselectors, the backtracking implementation was abstracted into the structure
BacktrackingLevel. Every time the code generator starts a new subselector, a new BacktrackingLevel is pushed onto
the multilevel backtracking stack. The code generation always use the latest BacktrackingLevel for code generation
until the subselector is finished, and code generation can continue with the existing state.

Tests: fast/selectors/nth-child-of-backtracking-adjacent-2.html

fast/selectors/nth-child-of-backtracking-adjacent-optimized.html
fast/selectors/nth-child-of-backtracking-adjacent.html
fast/selectors/nth-child-of-boundaries-1.html
fast/selectors/nth-child-of-boundaries-2.html
fast/selectors/nth-child-of-boundaries-3.html
fast/selectors/nth-child-of-chained-2.html
fast/selectors/nth-child-of-has-parent.html
fast/selectors/nth-child-of-never-matching-selector.html
fast/selectors/nth-child-of-with-invalid-An+B.html

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::minimumRegisterRequirements):
(WebCore::SelectorCompiler::computeBacktrackingMemoryRequirements):
Previously, we only needed stack space for the adjacent backtracking entry.

Now we can have several backtracking level active at the same time. We compute how much stack we need
initially and each backtracking level take stack references as needed.

(WebCore::SelectorCompiler::computeBacktrackingInformation):
The entire backtracking infrastructure already works great for multilevel backtracking. It is actually
amazing how everything fits nicely together :)

The only addition here is logging facility in case we run into a bug.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorCheckerExcludingPseudoElements):
generateSelectorChecker() has handling for pseudo elements, which should not be used
for :nth-child(of). The core generator was moved to generateSelectorCheckerExcludingPseudoElements()
to be used for code generation of subselectors.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateParentElementTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAncestorTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDirectAdjacentTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateIndirectAdjacentTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::linkFailures):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAdjacentBacktrackingTail):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDescendantBacktrackingTail):
The two main changes are:
1) Adopt the BacktrackingLevel to handle multilevel generation.
2) Descendant backtracking can use the stack if we have multi level descendant backtracking.

In that case, we just use the stack like for adjacent backtracking.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChildOf):
This is very similar to generateElementIsNthChild(). The main difference is we cannot use
the cache in this case.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::nthFilterIsAlwaysSatisified):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateNthFilterTest):

LayoutTests:

Those are new tests on top of the existing tests for :nth-child(An+B of selector).
They cover mostly areas related to the JIT optimizations.

The areas with the least test coverage for correctness is multilevel backtracking.
I expect we will create more of those tests while extending :not() and adding :matches().

  • fast/selectors/nth-child-of-backtracking-adjacent-expected.txt: Added.
  • fast/selectors/nth-child-of-backtracking-adjacent-optimized.html: Added.
  • fast/selectors/nth-child-of-backtracking-adjacent-expected.html: Added.
  • fast/selectors/nth-child-of-backtracking-adjacent.html: Added.
  • fast/selectors/nth-child-of-backtracking-adjacent-2-expected.txt: Added.
  • fast/selectors/nth-child-of-backtracking-adjacent-2.html: Added.

Those tests are based on Yusuke's backtracking test suite for adjacent combinators.

The tests in nth-child-of-backtracking-adjacent.html use :nth-child(of) inside a regular
backtracking chain.

The tests in nth-child-of-backtracking-adjacent-2.html test backtracking inside :nth-chlid(of).

  • fast/selectors/nth-child-of-boundaries-1-expected.txt: Added.
  • fast/selectors/nth-child-of-boundaries-1.html: Added.
  • fast/selectors/nth-child-of-boundaries-2-expected.txt: Added.
  • fast/selectors/nth-child-of-boundaries-2.html: Added.
  • fast/selectors/nth-child-of-boundaries-3-expected.txt: Added.
  • fast/selectors/nth-child-of-boundaries-3.html: Added.

Test various abuse of :nth-child(of).

  • fast/selectors/nth-child-of-chained-2-expected.txt: Added.
  • fast/selectors/nth-child-of-chained-2.html: Added.

Test that disjoint :nth-child(of) are not agregated, unlike the old :nth-child().

  • fast/selectors/nth-child-of-has-parent-expected.txt: Added.
  • fast/selectors/nth-child-of-has-parent.html: Added.

Make sure we don't optimize out the parent check when skipping filters that always match.

  • fast/selectors/nth-child-of-never-matching-selector-expected.txt: Added.
  • fast/selectors/nth-child-of-never-matching-selector.html: Added.

Test code generation for things that never match.

  • fast/selectors/nth-child-of-with-invalid-An+B-expected.txt: Added.
  • fast/selectors/nth-child-of-with-invalid-An+B.html: Added.

Test for useless variation of An+B that can never match anything.

4:39 PM Changeset in webkit [174244] by psolanki@apple.com
  • 4 edits in trunk/Source/WebCore

[iOS] Networking process stops loading web pages while running Alexa test with random URL list
​https://bugs.webkit.org/show_bug.cgi?id=137362
<rdar://problem/18507382>

Reviewed by Alexey Proskuryakov.

ResourceHandleCFURLConnectionDelegateWithOperationQueue needs to signal threads waiting on
its semaphore when the handle is being destroyed. Otherwise, we can leave dispatch threads
hanging around waiting for a response. This can happen when the Web Content process dies.
Any thread/queue waiting on a response from that web process will leak and stay around
forever. If we reach the dispatch queue limit of 64, then all networking will cease to
happen in the Networking process. Fix this by signalling waiting threads and clearing out
our state in much the same way that -[WebCoreResourceHandleAsOperationQueueDelegate
detachHandle] does for Mac.

  • platform/network/cf/ResourceHandleCFURLConnectionDelegate.h:
  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::releaseHandle):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:
4:36 PM Changeset in webkit [174243] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.

  • Scripts/webkitpy/port/win.py:

(WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.

4:32 PM Changeset in webkit [174242] by dfarler@apple.com
  • 2 edits in trunk/Tools

Move ASan arguments from LLVM (-mllvm) to the frontend
​https://bugs.webkit.org/show_bug.cgi?id=137365

Reviewed by David Kilzer.

  • asan/asan.xcconfig:

Remove the -mllvm prefix to the asan-blacklist argument, moving it
to the clang frontend.

​http://llvm.org/viewvc/llvm-project?view=revision&revision=212505

4:30 PM Changeset in webkit [174241] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] Skip a small handful of tests that fail consistently on Windows bots Part 2.

  • platform/win/TestExpectations: Typo, meant to skip the whole folder on Debug tests.
4:27 PM Changeset in webkit [174240] by Beth Dakin
  • 2 edits in trunk/LayoutTests

Marking flaky on Mavericks.

  • platform/mac/TestExpectations:
4:14 PM Changeset in webkit [174239] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] Skip a small handful of tests that fail consistently on Windows bots.

  • platform/win/TestExpectations:
4:03 PM Changeset in webkit [174238] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the iOS build.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::blurAssistedNode):
(WebKit::WebPage::setAssistedNodeValue):
(WebKit::WebPage::setAssistedNodeValueAsNumber):
(WebKit::WebPage::setAssistedNodeSelectedIndex):

4:01 PM Changeset in webkit [174237] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] Unskip media tests now that audio devices are installed on the bots.

  • platform/win/TestExpectations: There will likely still be a handful of failures left, which we will then skip.
3:53 PM Changeset in webkit [174236] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for CSSBasicShape objects
​https://bugs.webkit.org/show_bug.cgi?id=137331

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for CSSBasicShape objects.

No new tests, no behavior change.

  • css/BasicShapeFunctions.cpp:

(WebCore::basicShapeForValue):

  • css/CSSBasicShapes.cpp:

(WebCore::CSSBasicShapeCircle::equals):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::CSSBasicShapePolygon::equals):
(WebCore::CSSBasicShapeInset::equals):

  • css/CSSBasicShapes.h:
3:49 PM Changeset in webkit [174235] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

XMLHttpRequestProgressEventThrottle shouldn't throttle / defer progress events if there are no listeners
​https://bugs.webkit.org/show_bug.cgi?id=137346

Reviewed by Alexey Proskuryakov.

Previously XMLHttpRequestProgressEventThrottle would throttle / defer
progress events, which involves queueing events and starting timers,
even if there were no listeners for those events (which is fairly
common case).

This patch updates XMLHttpRequestProgressEventThrottle to make sure
there are actual progress event listeners *before* attempting to
throttle and do extra processing, to avoid doing unnecessary work.

This patch also makes XMLHttpRequestProgressEventThrottle::dispatchEvent()
private as this method is only called from other dispatch methods of
the class and never from the outside.

No new tests, no behavior change.

  • xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):

3:48 PM Changeset in webkit [174234] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Simplify StringTypeAdapter templates
​https://bugs.webkit.org/show_bug.cgi?id=137356

Reviewed by Andreas Kling.

  • wtf/text/StringConcatenate.h:

Use StringView for copying characters. Use inheritance for char* vs const char* etc. Make all StringAdapter member functions const.

  • wtf/text/StringView.h:

Move enough functions out of line so we can include WTFString.h after the StringView class definition.

3:25 PM Changeset in webkit [174233] by mmaxfield@apple.com
  • 43 edits
    1 add in trunk

[Subpixel] Use floats instead of ints for text justification expansion
​https://bugs.webkit.org/show_bug.cgi?id=137327

Reviewed by Zalan Bujtas.

Source/WebCore:

Use a float instead of an int for the expansion variable in InlineBox. The int was inside an inner class
that held a collection of bitfields, and this patch removes that inner-inner variable.

No new tests because there is plenty of existing coverage and existing tests are rebaselined.

  • rendering/InlineBox.cpp: Update static_assert for the size of InlineBox.
  • rendering/InlineBox.h: Use a float for the justification expansion amount instead of an int bitfield.

(WebCore::InlineBox::InlineBoxBitfields::InlineBoxBitfields): Remove int bitfield.
(WebCore::InlineBox::InlineBox): Initialize float expansion.
(WebCore::InlineBox::expansion): Return a float.
(WebCore::InlineBox::setExpansion): Take a float.
(WebCore::InlineBox::InlineBoxBitfields::expansion): Deleted. Moved to InlineBox.
(WebCore::InlineBox::InlineBoxBitfields::setExpansion): Deleted. Ditto.

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::setExpansion): Take a float.

LayoutTests:

Rebaselining tests due to subpixel differences.

  • platform/mac/css1/box_properties/clear_float-expected.txt:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.txt:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/overflow-across-columns-expected.txt:
  • platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt:
  • platform/mac/fast/multicol/overflow-unsplittable-expected.txt:
  • platform/mac/fast/multicol/positive-leading-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:
  • platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/mac/fast/ruby/bopomofo-rl-expected.txt:
  • platform/mac/fast/text/hyphenate-character-expected.txt:
  • platform/mac/fast/text/hyphens-expected.txt:
  • platform/mac/fast/text/justified-selection-at-edge-expected.txt:
  • platform/mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
  • platform/mac/fast/text/justify-nbsp-expected.txt: Added.
  • platform/mac/fast/text/trailing-white-space-2-expected.txt:
  • platform/mac/fast/text/trailing-white-space-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
2:51 PM Changeset in webkit [174232] by aestes@apple.com
  • 9 edits in trunk/Source/WebKit2

[iOS] Teach WKPDFView to navigate to pageNumber links
​https://bugs.webkit.org/show_bug.cgi?id=137358

Reviewed by Tim Horton.

Treat PDF pageNumber annotations as if they were fragment navigations in an HTML document. For a given page
number N, create a fragment called "#pageN" and tell WebKit to navigate to it. By doing this we create history
entries for each pageNumber navigation and allow for proper back/forward. When navigating to a page, reset to
the initial scale factor and scroll to the beginning of the Nth page.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _zoomToPoint:atScale:animated:]): Added an animated parameter. If animated is NO, use a duration of 0.
(-[WKWebView _zoomToRect:atScale:origin:animated:]): Added an animated parameter and passed it to _zoomToPoint:atScale:animated:.
(-[WKWebView _zoomOutWithOrigin:animated:]): Ditto.
(-[WKWebView _zoomToRect:withOrigin:fitEntireRect:minimumScale:maximumScale:minimumScrollDistance:]): Called _zoomToRect:atScale:origin:animated:,
setting animated to YES.
(-[WKWebView _didSameDocumentNavigationForMainFrame:]): Called web_didSameDocumentNavigation: on _customContentView.
(-[WKWebView _zoomToPoint:atScale:]): Deleted.
(-[WKWebView _zoomToRect:atScale:origin:]): Deleted.
(-[WKWebView _zoomOutWithOrigin:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/Cocoa/WKWebViewContentProvider.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didSameDocumentNavigationForMainFrame): Called _didSameDocumentNavigationForMainFrame on m_webView.

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _zoomOutWithOrigin:]): Called _zoomOutWithOrigin:animated: on m_webView, setting animated to YES.

  • UIProcess/ios/WKPDFPageNumberIndicator.h:
  • UIProcess/ios/WKPDFPageNumberIndicator.mm:

(-[WKPDFPageNumberIndicator hide]): Added a method to hide the page number indicator.

  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView web_setContentProviderData:suggestedFilename:]): Added a FIXME for restoring scroll position and page scale when loading from the back/forward list.
(-[WKPDFView scrollViewDidScroll:]): Stopped showing the page number indicator if a same-document navigation is occurring (to match UIWebPDFView).
(-[WKPDFView _updatePageNumberIndicator]): Ditto.
(-[WKPDFView web_didSameDocumentNavigation:]):
(-[WKPDFView _resetZoomAnimated:]): For same-document navigations of type kWKSameDocumentNavigationSessionStatePop, extracted the page index from the URL fragment
identifier, hid the page number indicator, reset the zoom (without an animation to match UIWebPDFView), and scrolled to the beginning of the given page.
(-[WKPDFView resetZoom:]): Called _resetZoomAnimated:, setting animated to YES.
(-[WKPDFView annotation:wasTouchedAtPoint:controller:]): If there is a non-zero pageNumber in the link annotation, construct a "#pageN" fragment and navigate to it.

2:06 PM Changeset in webkit [174231] by timothy_horton@apple.com
  • 54 edits
    6 adds
    4 deletes in trunk/Source

Move PageOverlay[Controller] to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=137164
<rdar://problem/18508258>

Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Make the appropriate build system changes.

  • WebCore.exp.in:

Export the new PageOverlay[Controller] symbols from WebCore.

  • loader/EmptyClients.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::documentOverlayLayerForFrame): Deleted.
Add attachViewOverlayGraphicsLayer, which allows PageOverlayController
to push view-relative page overlay root layers down to WebKit to be
installed just inside the view.

Remove documentOverlayLayerForFrame because RenderLayerCompositor can now
talk directly to PageOverlayController.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseReleaseEvent):
When the mouse is moved, pressed, or released, give PageOverlayController
the first shot at handling the event.

  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):
Inform PageOverlayController that the main FrameView's size changed,
so it can update the size of view-relative overlays.

(WebCore::FrameView::setContentsSize):
Inform PageOverlayController that the main FrameView's contents size changed,
so it can update the size of document-relative overlays.

(WebCore::FrameView::setFixedVisibleContentRect):
(WebCore::FrameView::didChangeScrollOffset):
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::wheelEvent):
Inform PageOverlayController that something scrolled.

(WebCore::FrameView::setExposedRect):
Inform PageOverlayController that the exposed rect changed, so it can push
the new exposed rect down to the overlays.

  • page/FrameView.h:

Add didChangeScrollOffset.

  • page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame):

  • page/MainFrame.h:

Keep one PageOverlayController per MainFrame.

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):
Inform PageOverlayController that the device scale factor changed.

(WebCore::Page::setSessionID):
Remove a blank line.

  • page/PageOverlay.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp.

Move PageOverlay from WebKit2 to WebCore.
A few overarching changes that I won't detail in each place:

  • references instead of pointers in many places
  • WebCore types instead of WebKit2 types everywhere

(WebCore::PageOverlay::bounds):
It is possible to install an overlay before we have a FrameView.
We will eventually get a view/contents size changed notification and try again.

(WebCore::PageOverlay::copyAccessibilityAttributeStringValueForPoint):
(WebCore::PageOverlay::copyAccessibilityAttributeBoolValueForPoint):
(WebCore::PageOverlay::copyAccessibilityAttributeNames):
Split copyAccessibilityAttribute into "StringValueForPoint" and "BoolValueForPoint"
variants, because we don't have anything like WKTypeRef here.

  • page/PageOverlay.h: Renamed from Source/WebKit2/WebProcess/WebPage/PageOverlay.h.

Make PageOverlay a normal RefCounted object instead of a WebKit2 API object.
Leave a comment noting that we should move the PageOverlay's GraphicsLayer
to PageOverlay instead of a map on PageOverlayController.

  • page/PageOverlayController.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp.

Move PageOverlayController from WebKit2 to WebCore.
A few overarching changes that I won't detail in each place:

  • references instead of pointers in many places
  • WebCore types instead of WebKit2 types everywhere

Leave a FIXME that didChangeSettings is not currently called when settings change.
This is not a problem for normal use of overlays, only for dynamically changing
layer border/repaint counter settings.

(WebCore::PageOverlayController::PageOverlayController):
(WebCore::PageOverlayController::createRootLayersIfNeeded):
We will now lazily initialize the root layers when we first try to use them,
because otherwise we try to create them before the ChromeClient's GraphicsLayerFactory
is hooked up, in some cases, and that can cause us to create the wrong kind of GraphicsLayers.

(WebCore::PageOverlayController::installPageOverlay):
Enter compositing mode when installing a PageOverlay.
Avoid pushing the Page to the PageOverlay until after we've set up
its root layer, so that the installation process can make use of that layer;
clients may, for example, expect to be able to setNeedsDisplay() in the
didMoveToPage callback.
Avoid updateOverlayGeometry until the layer is created and we've pushed
the Page down, so that e.g. bounds() will use the right Page.

(WebCore::PageOverlayController::didChangeSettings):
Leave a FIXME about a future improvement to didChangeSettings.

(WebCore::PageOverlayController::deviceScaleFactor):
(WebCore::PageOverlayController::notifyFlushRequired):
Null-check Page; these can get called when tearing down the Frame.

  • page/PageOverlayController.h: Renamed from Source/WebKit2/WebProcess/WebPage/PageOverlayController.h.
  • platform/graphics/GraphicsLayerClient.h:

Add wtf/Forward.h, because GraphicsLayerClient.h uses String.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
Inform PageOverlayController that something scrolled.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):
Make hasAnyAdditionalCompositedLayers return true if there are any page overlays,
because we need to avoid falling out of compositing mode if we still have
page overlays.

(WebCore::RenderLayerCompositor::updateCompositingLayers):
Enter compositing mode if we have page overlays.

(WebCore::RenderLayerCompositor::appendOverlayLayers): Deleted.
(WebCore::RenderLayerCompositor::appendDocumentOverlayLayers):
Rename appendOverlayLayers -> appendDocumentOverlayLayers.

(WebCore::RenderLayerCompositor::attachRootLayer):
(WebCore::RenderLayerCompositor::detachRootLayer):
Attach/detach the view overlay root layer when attaching/detaching the
normal compositing root layer.

(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged):

  • rendering/RenderLayerCompositor.h:
  • CMakeLists.txt:
  • WebKit2.xcodeproj/project.pbxproj:

Make the appropriate build system changes.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

Make WKBundlePageOverlayRef map to WebPageOverlay instead of PageOverlay.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageInstallPageOverlay):
(WKBundlePageUninstallPageOverlay):
(WKBundlePageInstallPageOverlayWithAnimation):
(WKBundlePageUninstallPageOverlayWithAnimation):
Forward PageOverlay installation/uninstallation to WebCore.

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WKBundlePageOverlayGetTypeID):
(WKBundlePageOverlayCreate):
(WKBundlePageOverlaySetAccessibilityClient):
Use WebPageOverlay instead of PageOverlay, and references instead of pointers.
We forward client callbacks through from PageOverlay::Client to WebPageOverlay::Client.

(PageOverlayClientImpl::copyAccessibilityAttributeValue):
(PageOverlayClientImpl::copyAccessibilityAttributeNames):
Convert from wtf types to WebKit2 types.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::graphicsLayerFactory):
If we don't have a drawing area, don't dereference it!

(WebKit::WebChromeClient::attachViewOverlayGraphicsLayer):
Forward attachViewOverlayGraphicsLayer to the DrawingArea.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebPage/FindController.cpp:
  • WebProcess/WebPage/FindController.h:
  • WebProcess/WebPage/ios/FindControllerIOS.mm:
  • WebProcess/WebPage/ios/FindIndicatorOverlayClientIOS.h:
  • WebProcess/WebPage/mac/ServicesOverlayController.mm:
  • WebProcess/WebPage/ServicesOverlayController.h:

Mechanical changes to adopt to the fact that PageOverlay is in WebCore now.

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:

Remove support for WebKit2-based page overlays.
Return MainFrame instead of Frame from mainFrame().

  • WebProcess/WebPage/WebPageOverlay.cpp: Added.
  • WebProcess/WebPage/WebPageOverlay.h: Added.

(WebKit::WebPageOverlay::create):
(WebKit::WebPageOverlay::WebPageOverlay):
(WebKit::WebPageOverlay::~WebPageOverlay):
(WebKit::WebPageOverlay::setNeedsDisplay):
(WebKit::WebPageOverlay::clear):
(WebKit::WebPageOverlay::pageOverlayDestroyed):
(WebKit::WebPageOverlay::willMoveToPage):
(WebKit::WebPageOverlay::didMoveToPage):
(WebKit::WebPageOverlay::drawRect):
(WebKit::WebPageOverlay::mouseEvent):
(WebKit::WebPageOverlay::didScrollFrame):
(WebKit::WebPageOverlay::copyAccessibilityAttributeStringValueForPoint):
(WebKit::WebPageOverlay::copyAccessibilityAttributeBoolValueForPoint):
(WebKit::WebPageOverlay::copyAccessibilityAttributeNames):
WebPageOverlay exists to be our API object, but forwards everything
to its WebCore::PageOverlay, and implements WebCore::PageOverlay::Client, and
forwards client callbacks to its WebPageOverlay::Client (which
WKBundlePageOverlay implements).

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
Forward the three AX properties that PageOverlays are ever queried for
to the appropriate PageOverlayController function.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::updateRootLayers):
Factor updateRootLayers out of setRootCompositingLayer.

(WebKit::RemoteLayerTreeDrawingArea::attachViewOverlayGraphicsLayer):
If we attach/detach the view-relative page overlay root layer,
reattach the root compositing layer's children.

(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
Ditto for the root compositing layer.

(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::mainFrameContentSizeChanged):
Informing PageOverlayController of exposed rect/document size changes is now
WebCore's job.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::updateRootLayers):
Factor updateRootLayers out of setRootCompositingLayer.

(WebKit::TiledCoreAnimationDrawingArea::attachViewOverlayGraphicsLayer):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
Make use of updateRootLayers when we attach/detach root compositing layer/view overlay layer.

(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
Informing PageOverlayController of exposed rect/document size changes is now
WebCore's job.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::attachViewOverlayGraphicsLayer):

  • Shared/WebRenderLayer.cpp:
  • Shared/WebRenderObject.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebProcess.cpp:

Include MainFrame.h because WebPage::mainFrame returns a MainFrame now.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::attachViewOverlayGraphicsLayer):
Add an empty ChromeClient override.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::attachViewOverlayGraphicsLayer):

  • WebCoreSupport/WebChromeClient.h:

Add an empty ChromeClient override.

2:01 PM Changeset in webkit [174230] by jeffm@apple.com
  • 12 edits in trunk/Source/WebKit2

WKDownloadCopyRequest() returns 0 until the download starts
​https://bugs.webkit.org/show_bug.cgi?id=137322

Reviewed by Anders Carlsson.

The m_request ivar in DownloadProxy was only being initialized when didStart() was called after the
download starts. Since clients have access to the ResourceRequest when the DownloadProxy is created,
there's no reason not to pass that along to DownloadProxy::create() so it can be returned if
WKDownloadCopyRequest() is called before didStart().

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::create):
Add ResourceRequest parameter, and pass it to DownloadProxy constructor.

(WebKit::DownloadProxy::DownloadProxy):
Initialize m_request.

  • UIProcess/Downloads/DownloadProxy.h:

Add ResourceRequest parameter to create() and constructor.

  • UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::createDownloadProxy):
Add ResourceRequest parameter and pass it to DownloadProxy::create().

  • UIProcess/Downloads/DownloadProxyMap.h:

Add ResourceRequest parameter to createDownloadProxy().

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::createDownloadProxy):
Add ResourceRequest parameter and pass it to DownloadProxy::create().

  • UIProcess/Network/NetworkProcessProxy.h:

Add ResourceRequest parameter to createDownloadProxy().

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::download):
Pass ResourceRequest to createDownloadProxy().

(WebKit::WebContext::createDownloadProxy):
Add ResourceRequest parameter and pass it to createDownloadProxy() functions.

  • UIProcess/WebContext.h:

Add ResourceRequest parameter to createDownloadProxy().

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Pass m_decidePolicyForResponseRequest to WebContext::createDownloadProxy().

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createDownloadProxy):
Add ResourceRequest parameter and pass it to DownloadProxyMap::create().

  • UIProcess/WebProcessProxy.h:

Add ResourceRequest parameter to createDownloadProxy().

1:56 PM Changeset in webkit [174229] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.11-branch/Source/WebCore

Merged r174199. <rdar://problem/18459443>

1:54 PM Changeset in webkit [174228] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Back TextRun with a StringView
​https://bugs.webkit.org/show_bug.cgi?id=137352

Reviewed by Antti Koivisto.

TextRun contains a union of a UChar* and an LChar* as well as a length, which is the abstraction
that StringView is intended to be. This patch cleans up TextRun by replacing the union and length
with a StringView instance member.

No new tests because there is no behavior change.

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::subRun):
(WebCore::TextRun::operator[]):
(WebCore::TextRun::data8):
(WebCore::TextRun::data16):
(WebCore::TextRun::characters8):
(WebCore::TextRun::characters16):
(WebCore::TextRun::is8Bit):
(WebCore::TextRun::length):
(WebCore::TextRun::string):
(WebCore::TextRun::setText):
(WebCore::TextRun::stringView):

1:50 PM Changeset in webkit [174227] by Beth Dakin
  • 2 edits in trunk/LayoutTests

Marking test as flaky.

1:35 PM Changeset in webkit [174226] by oliver@apple.com
  • 44 edits in trunk/Source/JavaScriptCore

Do all closed variable access through the local lexical object
​https://bugs.webkit.org/show_bug.cgi?id=136869

Reviewed by Filip Pizlo.

This patch makes all reads and writes from captured registers
go through the lexical record, and by doing so removes the
need for record tearoff.

To keep the patch simple we still number variables as though
they are local stack allocated registers, but ::local() will
fail. When local fails we perform a generic resolve, and in
that resolve we now use a ResolveScopeInfo struct to pass
around information about whether a lookup is a statically
known captured variable, and its location in the activation.
To ensure correct behaviour during codeblock linking we also
add a LocalClosureVariable resolution type.

To ensure correct semantics for the Arguments object, we now
have to eagerly create the Arguments object for any function
that uses both the Arguments object and requires a lexical
record.

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeCapturedVariable):

During the entry to a function we are not yet in a position
to allocate temporaries so we directly use the lexical
environment register.

(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::local):
(JSC::BytecodeGenerator::constLocal):
(JSC::BytecodeGenerator::emitResolveScope):
(JSC::BytecodeGenerator::emitResolveConstantLocal):

The two resolve scope operations could technically skip
the op_resolve_scope, and simply perform

op_mov dst, recordRegister

but for now it seemed best to maintain the same basic
behaviour.

(JSC::BytecodeGenerator::emitGetFromScope):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::createArgumentsIfNecessary):

If we have an environment we've already created Arguments
so no need to check again.

(JSC::BytecodeGenerator::emitReturn):

Don't need to emit tearoff_environment

  • bytecompiler/BytecodeGenerator.h:

(JSC::Local::Local):
(JSC::Local::operator bool):
(JSC::Local::get):
(JSC::Local::isReadOnly):
(JSC::Local::isSpecial):
(JSC::ResolveScopeInfo::ResolveScopeInfo):
(JSC::ResolveScopeInfo::isLocal):
(JSC::ResolveScopeInfo::localIndex):
(JSC::BytecodeGenerator::shouldCreateArgumentsEagerly):
(JSC::Local::isCaptured): Deleted.
(JSC::Local::captureMode): Deleted.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ResolveNode::emitBytecode):
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::DeleteResolveNode::emitBytecode):
(JSC::TypeOfResolveNode::emitBytecode):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::EmptyVarExpression::emitBytecode):
(JSC::ForInNode::tryGetBoundLocal):
(JSC::ForInNode::emitLoopHeader):
(JSC::ForOfNode::emitBytecode):
(JSC::BindingNode::bindValue):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::tryGetRegisters):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_captured_mov): Deleted.
(JSC::JIT::emit_op_tear_off_lexical_environment): Deleted.
(JSC::JIT::emitSlow_op_captured_mov): Deleted.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_captured_mov): Deleted.
(JSC::JIT::emit_op_tear_off_lexical_environment): Deleted.

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitPutClosureVar):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitPutClosureVar):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/Arguments.cpp:

(JSC::Arguments::tearOff):

  • runtime/Arguments.h:

(JSC::Arguments::argument):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL): Deleted.

  • runtime/CommonSlowPaths.h:
  • runtime/JSLexicalEnvironment.cpp:

(JSC::JSLexicalEnvironment::visitChildren):
(JSC::JSLexicalEnvironment::symbolTableGet):
(JSC::JSLexicalEnvironment::symbolTablePut):
(JSC::JSLexicalEnvironment::getOwnNonIndexPropertyNames):
(JSC::JSLexicalEnvironment::getOwnPropertySlot):
(JSC::JSLexicalEnvironment::argumentsGetter):

  • runtime/JSLexicalEnvironment.h:

(JSC::JSLexicalEnvironment::create):
(JSC::JSLexicalEnvironment::JSLexicalEnvironment):
(JSC::JSLexicalEnvironment::tearOff): Deleted.
(JSC::JSLexicalEnvironment::isTornOff): Deleted.

  • runtime/JSScope.cpp:

(JSC::resolveTypeName):

  • runtime/JSScope.h:

(JSC::makeType):
(JSC::needsVarInjectionChecks):

  • runtime/WriteBarrier.h:

(JSC::WriteBarrier<Unknown>::WriteBarrier):

12:39 PM Changeset in webkit [174225] by Chris Dumez
  • 251 edits in trunk/Source

Have is<>(T*) function do a null check on the pointer argument
​https://bugs.webkit.org/show_bug.cgi?id=137333

Reviewed by Gavin Barraclough.

Have is<>(T*) function do a null check on the argument instead of a
simple assertion. This makes sense for 2 reasons:

  1. It is more consistent with downcast<>(T*), which will succeed even if the argument is a nullptr.
  2. It simplifies the code a bit as it gets rid of a lot of explicit null checks.

Source/WebCore:

No new tests, no behavior change.

  • Modules/indexeddb/IDBFactory.cpp:
  • Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::create):

  • Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::create):

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage):

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::createFromRenderer):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::handleLiveRegionCreated):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
(WebCore::AXObjectCache::rootAXEditableElement):
(WebCore::isNodeAriaVisible):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isEnabled):
(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaTimeline::valueDescription):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isEnabled):
(WebCore::AccessibilityNodeObject::isPressed):
(WebCore::AccessibilityNodeObject::isHovered):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::isRequired):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::AccessibilityNodeObject::isControl):
(WebCore::AccessibilityNodeObject::anchorElement):
(WebCore::isNodeActionElement):
(WebCore::AccessibilityNodeObject::mouseButtonListener):
(WebCore::AccessibilityNodeObject::labelForElement):
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):
(WebCore::AccessibilityNodeObject::helpText):
(WebCore::AccessibilityNodeObject::hierarchicalLevel):
(WebCore::AccessibilityNodeObject::textUnderElement):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press):
(WebCore::AccessibilityObject::hasTagName):
(WebCore::AccessibilityObject::hasAttribute):
(WebCore::AccessibilityObject::element):
(WebCore::AccessibilityObject::classList):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::labelElementContainer):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::titleUIElement):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::accessKey):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::setElementAttributeValue):
(WebCore::AccessibilityRenderObject::setFocused):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
(WebCore::AccessibilityRenderObject::renderObjectIsObservable):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
(WebCore::AccessibilityRenderObject::setAccessibleName):
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
(WebCore::AccessibilityRenderObject::isLinked):
(WebCore::AccessibilityRenderObject::stringRoleForMSAA):
(WebCore::AccessibilityRenderObject::isMathElement):

  • accessibility/AccessibilitySearchFieldButtons.cpp:

(WebCore::AccessibilitySearchFieldCancelButton::press):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableElement):
(WebCore::AccessibilityTable::isDataTable):
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::title):

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetCaption):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetName):
(webkitAccessibleGetDescription):
(webkitAccessibleGetAttributes):

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::constructJSAudioContext):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::toJSDOMGlobalObject):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):
(WebCore::createWrapperInline):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/js/ScriptState.cpp:

(WebCore::frameFromExecState):

  • bindings/objc/DOM.mm:

(kitClass):

  • css/CSSCursorImageValue.cpp:

(WebCore::resourceReferencedByCursorElement):

  • css/CSSStyleSheet.cpp:

(WebCore::isAcceptableCSSStyleSheetParent):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isAutofilled):
(WebCore::isDisabled):
(WebCore::isEnabled):
(WebCore::isChecked):
(WebCore::matchesLangPseudoClass):
(WebCore::matchesFutureCuePseudoClass):
(WebCore::matchesPastCuePseudoClass):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::locateCousinList):
(WebCore::elementHasDirectionAuto):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::findSiblingForStyleSharing):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::useSVGZoomRulesForLength):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::getNamedItem):

  • dom/Attr.cpp:

(WebCore::Attr::style):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):

  • dom/ContainerNode.cpp:

(WebCore::checkAcceptChild):
(WebCore::ContainerNode::notifyChildRemoved):

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):

  • dom/CurrentScriptIncrementer.h:

(WebCore::CurrentScriptIncrementer::CurrentScriptIncrementer):

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDragImage):

  • dom/Document.cpp:

(WebCore::Document::elementFromPoint):
(WebCore::Document::setTitle):
(WebCore::Document::iconURLs):
(WebCore::eventTargetElementForDocument):
(WebCore::Document::updateHoverActiveState):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Element.cpp:

(WebCore::Element::computeInheritedLanguage):

  • dom/Element.h:

(WebCore::Node::parentElement):

  • dom/ElementTraversal.h:

(WebCore::Traversal<Element>::nextTemplate):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):

  • dom/EventDispatcher.cpp:

(WebCore::WindowEventContext::WindowEventContext):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::nodeOrHostIfPseudoElement):
(WebCore::EventPath::EventPath):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):

  • dom/KeyboardEvent.cpp:

(WebCore::findKeyboardEvent):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::namedItem):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchMessages):

  • dom/MouseEvent.cpp:

(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setNamedItem):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::computedStyle):
(WebCore::Node::parentOrShadowHostElement):
(WebCore::Node::rootEditableElement):
(WebCore::Node::ancestorElement):
(WebCore::Node::compareDocumentPosition):
(WebCore::appendAttributeDesc):
(WebCore::Node::showNodePathForThis):
(WebCore::Node::enclosingLinkEventParentOrSelf):
(WebCore::Node::dispatchEvent):
(WebCore::Node::defaultEventHandler):

  • dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::nodeCanBeDistributed):
(WebCore::NodeRenderingTraversal::traverseParent):

  • dom/NodeTraversal.cpp:

(WebCore::NodeTraversal::previousIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):

  • dom/Position.cpp:

(WebCore::Position::element):
(WebCore::endsOfNodeAreVisuallyDistinctPositions):
(WebCore::Position::isRenderedCharacter):
(WebCore::Position::leadingWhitespacePosition):

  • dom/Range.cpp:

(WebCore::Range::insertNode):
(WebCore::Range::getBorderAndTextQuads):

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/ShadowRoot.h:

(WebCore::Node::parentOrShadowHostNode):

  • dom/Text.cpp:

(WebCore::earliestLogicallyAdjacentTextNode):
(WebCore::latestLogicallyAdjacentTextNode):
(WebCore::isSVGShadowText):

  • dom/TextNodeTraversal.cpp:

(WebCore::TextNodeTraversal::contentsAsString):

  • dom/TextNodeTraversal.h:

(WebCore::TextNodeTraversal::firstTextChildTemplate):
(WebCore::TextNodeTraversal::firstTextWithinTemplate):
(WebCore::TextNodeTraversal::traverseNextTextTemplate):
(WebCore::TextNodeTraversal::nextSibling):

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

  • editing/ApplyBlockElementCommand.cpp:

(WebCore::isNewLineAtPosition):
(WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded):

  • editing/ApplyStyleCommand.cpp:

(WebCore::isLegacyAppleStyleSpan):
(WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute):
(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan):
(WebCore::isEmptyFontTag):
(WebCore::ApplyStyleCommand::applyBlockStyle):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::dummySpanAncestorForNode):
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::splitTextAtEnd):
(WebCore::ApplyStyleCommand::splitTextElementAtEnd):
(WebCore::ApplyStyleCommand::shouldSplitTextElement):
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
(WebCore::ApplyStyleCommand::applyInlineStyleChange):
(WebCore::ApplyStyleCommand::joinChildTextNodes):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::isRemovableBlock):
(WebCore::CompositeEditCommand::insertNodeAt):
(WebCore::CompositeEditCommand::canRebalance):
(WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::removePlaceholderAt):
(WebCore::CompositeEditCommand::cleanupAfterDeletion):
(WebCore::CompositeEditCommand::moveParagraphs):

  • editing/DeleteButtonController.cpp:

(WebCore::enclosingDeletableElement):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):
(WebCore::DeleteSelectionCommand::fixupWhitespace):
(WebCore::DeleteSelectionCommand::doApply):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::wrappingStyleForSerialization):

  • editing/Editor.cpp:

(WebCore::imageElementFromImageDocument):
(WebCore::Editor::shouldInsertFragment):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::setComposition):
(WebCore::Editor::isSpellCheckingEnabledFor):
(WebCore::Editor::applyEditingStyleToElement):

  • editing/FormatBlockCommand.cpp:

(WebCore::isElementForFormatBlock):

  • editing/FrameSelection.cpp:

(WebCore::removingNodeRemovesPosition):
(WebCore::CaretBase::paintCaret):
(WebCore::FrameSelection::debugRenderer):
(WebCore::FrameSelection::selectAll):
(WebCore::scanForForm):

  • editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::mergeWithNeighboringLists):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::haveSameTagName):
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::isCheckable):

  • editing/SplitTextNodeContainingElementCommand.cpp:

(WebCore::SplitTextNodeContainingElementCommand::doApply):

  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::isInPasswordField):

  • editing/VisibleUnits.cpp:

(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::aggregatedAttributesForAncestors):
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors):
(WebCore::editingAttributedStringFromRange):

  • editing/htmlediting.cpp:

(WebCore::enclosingBlock):
(WebCore::enclosingElementWithTag):
(WebCore::enclosingAnchorElement):
(WebCore::enclosingList):
(WebCore::lineBreakExistsAtPosition):
(WebCore::areIdenticalElements):
(WebCore::isNonTableCellHTMLBlockElement):
(WebCore::deprecatedEnclosingBlockFlowElement):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::ancestorToRetainStructureAndAppearanceForBlock):
(WebCore::isPlainTextMarkup):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::readAsArrayBuffer):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):

  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::updateAppearance):

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm):

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::eventType):
(WebCore::isEnterKeyKeydownEvent):
(WebCore::isLinkClick):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::imageElement):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedInto):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::defaultEventHandler):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNamedElementCache):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::setBgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::setFgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::setAlinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::setLinkColor):
(WebCore::HTMLDocument::vlinkColor):
(WebCore::HTMLDocument::setVlinkColor):
(WebCore::HTMLDocument::isFrameSet):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::matchesReadWritePseudoClass):
(WebCore::mergeWithNextTextNode):
(WebCore::HTMLElement::setOuterHTML):
(WebCore::HTMLElement::setOuterText):
(WebCore::HTMLElement::insertAdjacentElement):
(WebCore::contextElementForInsertion):
(WebCore::HTMLElement::directionality):
(WebCore::HTMLElement::dirAttributeChanged):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded):

  • html/HTMLFieldSetElement.cpp:

(WebCore::updateFromControlElementsAncestorDisabledStateUnder):
(WebCore::HTMLFieldSetElement::disabledStateChanged):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::computeIsDisabledByFieldsetAncestor):
(WebCore::shouldAutofocus):
(WebCore::HTMLFormControlElement::enclosingFormControlElement):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::rendererIsNeeded):
(WebCore::HTMLFormElement::submitImplicitly):
(WebCore::submitElementFromEvent):
(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::defaultButton):
(WebCore::HTMLFormElement::documentDidResumeFromPageCache):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::getSVGDocument):

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::defaultEventHandler):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::dataList):

  • html/HTMLLabelElement.cpp:

(WebCore::nodeAsSupportedLabelableElement):

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::virtualForm):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasFallbackContent):
(WebCore::HTMLObjectElement::updateDocNamedItem):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions):
(WebCore::HTMLOptGroupElement::ownerSelectElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText):
(WebCore::HTMLOptionElement::index):
(WebCore::HTMLOptionElement::ownerDataListElement):
(WebCore::HTMLOptionElement::ownerSelectElement):
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
(WebCore::HTMLOptionElement::isDisabledFormControl):
(WebCore::HTMLOptionElement::collectOptionInnerText):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin):
(WebCore::HTMLPlugInImageElement::defaultEventHandler):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::setText):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::defaultEventHandler):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedInto):
(WebCore::HTMLSourceElement::removedFrom):

  • html/HTMLSummaryElement.cpp:

(WebCore::isClickableControl):
(WebCore::HTMLSummaryElement::defaultEventHandler):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::findParentTable):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::rowAfter):
(WebCore::HTMLTableRowsCollection::lastRow):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultEventHandler):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::innerTextValue):
(WebCore::positionForIndex):
(WebCore::HTMLTextFormControlElement::indexForPosition):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::setText):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::mediaElement):

  • html/ImageDocument.cpp:

(WebCore::ImageEventListener::handleEvent):

  • html/InputType.cpp:

(WebCore::InputType::shouldSubmitImplicitly):

  • html/MediaDocument.cpp:

(WebCore::ancestorVideoElement):
(WebCore::MediaDocument::defaultEventHandler):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::shouldSubmitImplicitly):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag):
(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::ownerDocumentForCurrentNode):
(WebCore::HTMLConstructionSite::findFosterSite):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isSelectScopeMarker):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):

  • html/shadow/InsertionPoint.h:

(WebCore::isActiveInsertionPoint):
(WebCore::parentNodeForDistribution):
(WebCore::parentElementForDistribution):

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::parentMediaElement):
(WebCore::mediaControlElementType):
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::defaultEventHandler):
(WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler):
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler):
(WebCore::MediaControlTimelineElement::defaultEventHandler):

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::containsRelatedTarget):

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsAppleEventListener::handleEvent):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::defaultEventHandler):

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::forwardEvent):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):

  • html/track/VTTCue.cpp:

(WebCore::VTTCue::copyWebVTTNodeToDOMTree):
(WebCore::VTTCue::markFutureAndPastNodes):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::elementForId):
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::assertDocument):
(WebCore::InspectorDOMAgent::assertElement):
(WebCore::InspectorDOMAgent::querySelector):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
(WebCore::InspectorDOMAgent::innerParentNode):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::frameForScriptExecutionContext):
(WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::instrumentingAgentsForContext):

  • inspector/InspectorNodeFinder.cpp:

(WebCore::InspectorNodeFinder::searchUsingDOMTreeTraversal):
(WebCore::InspectorNodeFinder::searchUsingXPath):
(WebCore::InspectorNodeFinder::searchUsingCSSSelectors):

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementInfo):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin):

  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeRequestFromCache):
(WebCore::MemoryCache::removeRequestFromSessionCaches):

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::attributeChanged):

  • mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::getSelectedSemanticsChild):

  • page/Chrome.cpp:

(WebCore::Chrome::setToolTip):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::maybeCreateContextMenu):
(WebCore::ContextMenuController::populate):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/DragController.cpp:

(WebCore::elementUnderMouse):
(WebCore::DragController::operationForLoad):
(WebCore::DragController::canProcessDrag):
(WebCore::DragController::draggableElement):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::isSubmitImage):
(WebCore::targetIsFrame):
(WebCore::findDropZone):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::handleTextInputEvent):

  • page/FocusController.cpp:

(WebCore::FocusNavigationScope::owner):
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::findElementWithExactTabIndex):
(WebCore::nextElementWithGreaterTabIndex):
(WebCore::previousElementWithLowerTabIndex):
(WebCore::FocusController::nextFocusableElement):
(WebCore::FocusController::previousFocusableElement):
(WebCore::clearSelectionIfNeeded):
(WebCore::FocusController::advanceFocusDirectionally):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):
(WebCore::Frame::setPageAndTextZoomFactors):

  • page/FrameView.cpp:

(WebCore::FrameView::init):
(WebCore::FrameView::scrollToAnchor):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::scrollInDirection):
(WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDirection):
(WebCore::canScrollInDirection):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::areElementsOnSameLine):

  • page/ios/FrameIOS.mm:

(WebCore::ancestorRespondingToClickEvents):

  • platform/network/FormData.cpp:

(WebCore::FormData::appendKeyValuePairItems):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::setInnerNode):
(WebCore::HitTestResult::setInnerNonSharedNode):
(WebCore::HitTestResult::title):
(WebCore::HitTestResult::innerTextIfTruncated):
(WebCore::HitTestResult::mediaSupportsFullscreen):
(WebCore::HitTestResult::enterFullscreenForVideo):
(WebCore::HitTestResult::mediaIsVideo):
(WebCore::HitTestResult::innerElement):
(WebCore::HitTestResult::innerNonSharedElement):

  • rendering/RenderBlockFlow.cpp:

(WebCore::resizeTextPermitted):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesLogicalWidthToFitContent):

  • rendering/RenderCounter.cpp:

(WebCore::planCounter):

  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::isOpen):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintAreaElementFocusRing):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::resize):
(WebCore::RenderLayer::updateSnapOffsets):

  • rendering/RenderLayerBacking.cpp:

(WebCore::isRestartedPlugin):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::marqueeSpeed):

  • rendering/RenderMenuList.cpp:

(WebCore::selectedOptionCount):
(RenderMenuList::updateOptionsWidth):
(RenderMenuList::setTextFromOption):
(RenderMenuList::itemText):
(RenderMenuList::itemIsEnabled):
(RenderMenuList::itemIsLabel):
(RenderMenuList::itemIsSelected):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::meterElement):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::isChildAllowed):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect):
(WebCore::RenderObject::shouldRespectImageOrientation):
(WebCore::RenderObject::updateDragState):
(WebCore::RenderObject::getUncachedPseudoStyle):
(WebCore::RenderObject::getTextDecorationColors):

  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::progressElement):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::handleEvent):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isEnabled):
(WebCore::RenderTheme::isFocused):
(WebCore::RenderTheme::isPressed):
(WebCore::RenderTheme::isSpinUpButtonPartPressed):
(WebCore::RenderTheme::isReadOnlyControl):
(WebCore::RenderTheme::isHovered):
(WebCore::RenderTheme::isSpinUpButtonPartHovered):
(WebCore::RenderTheme::paintSliderTicks):

  • rendering/RenderThemeGtk.cpp:

(WebCore::getMediaElementFromRenderObject):
(WebCore::nodeHasClass):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::updatePressedState):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • rendering/RenderTreeAsText.cpp:

(WebCore::isEmptyOrUnstyledAppleStyleSpan):
(WebCore::RenderTreeAsText::writeRenderObject):

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isAutosizingContainer):
(WebCore::TextAutosizer::containerContainsOneOfTags):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::isChildAllowed):

  • rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::gradientElement):

  • rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • style/StyleResolveTree.cpp:

(WebCore::Style::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):
(WebCore::Style::attachChildren):
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::detachDistributedChildren):
(WebCore::Style::detachChildren):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::resolveTree):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::hasValidAttributeType):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::rootElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::isOutermostSVGSVGElement):
(WebCore::SVGElement::ownerSVGElement):
(WebCore::SVGElement::viewportElement):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::associatedFontElement):
(WebCore::SVGFontFaceElement::rebuildFontFace):

  • svg/SVGFontFaceSrcElement.cpp:

(WebCore::SVGFontFaceSrcElement::childrenChanged):

  • svg/SVGGlyphElement.cpp:

(WebCore::SVGGlyphElement::invalidateGlyphCache):

  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):

  • svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::determineViewport):

  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::collectGradientAttributes):

  • svg/SVGLocatable.cpp:

(WebCore::isViewportElement):
(WebCore::SVGLocatable::getTransformToElement):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::pathElement):
(WebCore::SVGMPathElement::notifyParentOfPathChange):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::invalidateMPathDependencies):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::collectPatternAttributes):

  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::collectGradientAttributes):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setupInitialView):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::elementFromRenderer):

  • svg/SVGUseElement.cpp:

(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):

  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageForRenderer):

  • testing/Internals.cpp:

(WebCore::Internals::shadowRootType):
(WebCore::Internals::visiblePlaceholder):
(WebCore::Internals::selectColorInColorChooser):
(WebCore::Internals::wasLastChangeUserEdit):
(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):
(WebCore::Internals::isSelectPopupVisible):

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::expandedNameLocalPart):
(WebCore::XPath::FunLang::evaluate):

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::sortBlock):
(WebCore::XPath::NodeSet::sort):
(WebCore::XPath::findRootNode):
(WebCore::XPath::NodeSet::traversalSort):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

Source/WebKit/ios:

  • WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::focusedElementChanged):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedElementChanged):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):

  • WebView/WebHTMLRepresentation.mm:

(inputElementFromDOMElement):
(searchForLabelsBeforeElement):

  • WebView/WebRenderLayer.mm:

(+[WebRenderLayer nameForLayer:]):

Source/WebKit/win:

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::body):
(DOMHTMLDocument::forms):
(DOMHTMLElement::idName):
(DOMHTMLElement::innerText):
(DOMHTMLElement::setInnerText):
(DOMHTMLFormElement::action):
(DOMHTMLFormElement::method):
(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::rectOnScreen):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):

  • WebFrame.cpp:

(formElementFromDOMElement):
(inputElementFromDOMElement):
(WebFrame::elementWithName):

Source/WebKit2:

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::mediaType):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::focusedElementChanged):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormElements):
(WebKit::WebFrame::containsAnyFormControls):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pdfDocumentForPrintingFrame):
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::blurAssistedNode):
(WebKit::WebPage::setAssistedNodeValue):
(WebKit::WebPage::setAssistedNodeValueAsNumber):
(WebKit::WebPage::setAssistedNodeSelectedIndex):
(WebKit::WebPage::getPositionInformation):
(WebKit::WebPage::performActionOnElement):
(WebKit::isAssistableNode):
(WebKit::WebPage::getAssistedNodeInformation):

Source/WTF:

  • wtf/TypeCasts.h:

(WTF::is):

12:38 PM Changeset in webkit [174224] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Object allocation sinking should have a sound story for picking materialization points
​https://bugs.webkit.org/show_bug.cgi?id=137315

Reviewed by Oliver Hunt.

The only missing piece was having the object allocation sinking phase locate materialization
points that were at CFG edges.

The logic for how and why this "just works" relies on some properties of critical edge
breaking, so I was fairly careful in how I did this. Also, this requires inserting things at
the "first origin node" of a block - that is the first node in a block that has a NodeOrigin
and therefore is allowed to exit. We basically had support for such a notion before, but
didn't close the loop on it; this patch does that.

Also I added the ability to provide a BasicBlock* as context for a DFG_ASSERT().

  • dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::firstOriginNode):
(JSC::DFG::BasicBlock::firstOrigin):

  • dfg/DFGBasicBlock.h:
  • dfg/DFGCriticalEdgeBreakingPhase.cpp:

(JSC::DFG::CriticalEdgeBreakingPhase::breakCriticalEdge):

  • dfg/DFGGraph.cpp:

(JSC::DFG::crash):
(JSC::DFG::Graph::handleAssertionFailure):

  • dfg/DFGGraph.h:
  • dfg/DFGLoopPreHeaderCreationPhase.cpp:

(JSC::DFG::createPreHeader):

  • dfg/DFGNodeOrigin.h:

(JSC::DFG::NodeOrigin::isSet):

  • dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::determineMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::placeMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::promoteSunkenFields):
(JSC::DFG::ObjectAllocationSinkingPhase::createMaterialize):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):

  • runtime/Options.h:
12:14 PM Changeset in webkit [174223] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r174120.
​https://bugs.webkit.org/show_bug.cgi?id=137350

While number of failures is reasonable with 2 processes, test
results seem to be inconsistent between runs (Requested by
rfong on #webkit).

Reverted changeset:

"[Windows] Back to 2 child processes for NRWT on Windows."
​http://trac.webkit.org/changeset/174120

11:35 AM Changeset in webkit [174222] by cabanier@adobe.com
  • 2 edits in trunk/Source/WebCore

Clean up loops in CSSGradientValue.cpp
​https://bugs.webkit.org/show_bug.cgi?id=137332

Reviewed by Andreas Kling.

This patch cleans up a couple of for loops by using C++11 syntax and
fixes some grammar in a comment.

No new tests, no behavior change.

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::gradientWithStylesResolved): Move for loops to C++11.
(WebCore::CSSGradientValue::addStops): Update grammar in comment for gradient midpoints.

10:39 AM Changeset in webkit [174221] by jeffm@apple.com
  • 3 edits in trunk/Tools

DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
​https://bugs.webkit.org/show_bug.cgi?id=137347

Reviewed by Dan Bernstein.

  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:

Use WebKitSystemInterfaceYosemite on OS X 10.10.

  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:

Ditto.

9:24 AM Changeset in webkit [174220] by dbates@webkit.org
  • 12 edits
    2 adds in trunk/Source

Clean up: Move XPC forward declarations in JavaScriptCore to WTF SPI wrapper header
​https://bugs.webkit.org/show_bug.cgi?id=137277

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

Use wtf/spi/darwin/XPCSPI.h instead of including the corresponding XPC headers/
forward declaring XPC functions.

  • inspector/remote/RemoteInspector.mm:
  • inspector/remote/RemoteInspectorXPCConnection.h:
  • inspector/remote/RemoteInspectorXPCConnection.mm:

Source/WebKit2:

Use wtf/spi/darwin/XPCSPI.h instead of including the corresponding XPC headers/
forward declaring XPC functions.

  • Platform/IPC/Connection.h:
  • Platform/IPC/mac/ConnectionMac.mm:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

Source/WTF:

Towards centralizing the declarations of XPC functions used in JavaScriptCore
and WebKit2, add a header that wraps these function declarations called XPCSPI.h
and use it instead of including the corresponding XPC API/SPI headers/forward
declaring XPC functions. This will also aid in the effort to make WebKit2 build
for iOS with the public iOS SDK.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/spi/darwin/XPCSPI.h: Added.
9:14 AM Changeset in webkit [174219] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Use variadic templates for jsMakeNontrivialString
​https://bugs.webkit.org/show_bug.cgi?id=137325

Reviewed by Sam Weinig.

  • runtime/JSString.h:

(JSC::jsNontrivialString):
Add an overload that takes an rvalue reference to a String so we can transfer ownership easily.

  • runtime/JSStringBuilder.h:

(JSC::jsMakeNontrivialString):
Make this a variadic function template, with a single-parameter version that can steal the string if it's OK to do so.

8:57 AM Changeset in webkit [174218] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[ Windows ] More Windows test gardening to get bots green Part 4.

  • platform/win/TestExpectations: Hopefully the last batch of indiscriminate mass skipping.
8:32 AM Changeset in webkit [174217] by k.czech@samsung.com
  • 5 edits in trunk

AX: Default orientation for aria scrollbars should be vertical
​https://bugs.webkit.org/show_bug.cgi?id=137341

Reviewed by Chris Fleizach.

Source/WebCore:

Default orientation for aria scrollbars regarding w3c spec should be vertical

No new tests, covering by existing one.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::orientation):

LayoutTests:

Update expectation and test for having new test case.

  • accessibility/aria-scrollbar-role-expected.txt:
  • accessibility/aria-scrollbar-role.html:
8:15 AM Changeset in webkit [174216] by mark.lam@apple.com
  • 26 edits in trunk/Source

Fixed the Inspector to be able to properly distinguish between scope types.
<​https://webkit.org/b/137279>

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

The pre-existing code incorrectly labels Catch Scopes and Function Name Scopes
as With Scopes. This patch will fix this.

  • bytecode/BytecodeList.json:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitPushFunctionNameScope):
(JSC::BytecodeGenerator::emitPushCatchScope):

  • These now passes stores the desired JSNameScope::Type in a bytecode operand.
  • debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::isCatchScope):
(JSC::DebuggerScope::isFunctionNameScope):

  • Added queries to be able to explicitly test if the scope is a CatchScope or FunctionNameScope. The FunctionNameScope is the case where the NameScope is used to capture the function name of a function expression.
  • debugger/DebuggerScope.h:
  • inspector/InjectedScriptSource.js:
  • inspector/JSJavaScriptCallFrame.cpp:

(Inspector::JSJavaScriptCallFrame::scopeType):

  • inspector/JSJavaScriptCallFrame.h:
  • inspector/JSJavaScriptCallFramePrototype.cpp:

(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
(Inspector::jsJavaScriptCallFrameConstantFUNCTION_NAME_SCOPE):

  • inspector/protocol/Debugger.json:
  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_push_name_scope):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_push_name_scope):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::addNameScopeIfNeeded):

  • runtime/JSNameScope.h:

(JSC::JSNameScope::create):
(JSC::JSNameScope::isFunctionNameScope):
(JSC::JSNameScope::isCatchScope):
(JSC::JSNameScope::JSNameScope):

  • Now stores the JSNameScope::Type in a field.

Source/WebInspectorUI:

Reviewed by Geoffrey Garen and Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Controllers/DebuggerManager.js:
  • UserInterface/Models/ScopeChainNode.js:
  • UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
  • Added handling of the FunctionNameScope case.
6:06 AM Changeset in webkit [174215] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r174054 - REGRESSION(r172919): WebKitPluginProcess fails to scan GTK+2 plugins after r172919.
​https://bugs.webkit.org/show_bug.cgi?id=137191

Reviewed by Philippe Normand.

In r172919 I moved the GTK+ symbols mix check earlier, before the
plugin is loaded and initialized. That made impossible to use the
GTK3 plugin process to scan gtk2 plugins, because we need to load
the plugin to get its metadata. But we don't need to initialize
the plugin to check if it requires GTK2, so we can do that check
in the UI process to decide which plugin process to use.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
Remove the requires GTK2 check.
(WebKit::NetscapePluginModule::scanPlugin): Don't write
requires-gtk2 to stdout.

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::pluginRequiresGtk2): Helper function to check if the
given plugin path requires GTK2.
(WebKit::PluginProcessProxy::scanPlugin): Check if the plugin path
requires GTK2 and use WebKitPluginProcess2 in such case, or return
early if GTK2 plugins are not enabled. Log error messages when
something fails scanning the plugin to make it easiert to debug
problems in the future.

6:03 AM Changeset in webkit [174214] by Carlos Garcia Campos
  • 3 edits
    29 adds in releases/WebKitGTK/webkit-2.6/Source/WebInspectorUI

Merge r173952 - Unreviewed. Add more free icons for the Web Inspector in GTK+.

Patch by Andres Gomez <Andres Gomez> on 2014-09-25

  • UserInterface/Images/gtk/AUTHORS:
  • UserInterface/Images/gtk/ApplicationCacheManifest.png: Added.
  • UserInterface/Images/gtk/​ApplicationCacheManifest@2x.png: Added.
  • UserInterface/Images/gtk/COPYING:
  • UserInterface/Images/gtk/COPYING_LGPL2: Added.
  • UserInterface/Images/gtk/Cookie.png: Added.
  • UserInterface/Images/gtk/​Cookie@2x.png: Added.
  • UserInterface/Images/gtk/HoverMenuButton.png: Added.
  • UserInterface/Images/gtk/​HoverMenuButton@2x.png: Added.
  • UserInterface/Images/gtk/InstructionPointer.png: Added.
  • UserInterface/Images/gtk/​InstructionPointer@2x.png: Added.
  • UserInterface/Images/gtk/Log.png: Added.
  • UserInterface/Images/gtk/​Log@2x.png: Added.
  • UserInterface/Images/gtk/Profile.png: Added.
  • UserInterface/Images/gtk/​Profile@2x.png: Added.
  • UserInterface/Images/gtk/Recording.png: Added.
  • UserInterface/Images/gtk/​Recording@2x.png: Added.
  • UserInterface/Images/gtk/RecordingHovered.png: Added.
  • UserInterface/Images/gtk/​RecordingHovered@2x.png: Added.
  • UserInterface/Images/gtk/RecordingStopped.png: Added.
  • UserInterface/Images/gtk/​RecordingStopped@2x.png: Added.
  • UserInterface/Images/gtk/Script.png: Added.
  • UserInterface/Images/gtk/​Script@2x.png: Added.
  • UserInterface/Images/gtk/ScriptLarge.png: Added.
  • UserInterface/Images/gtk/​ScriptLarge@2x.png: Added.
  • UserInterface/Images/gtk/SliderThumb.png: Added.
  • UserInterface/Images/gtk/​SliderThumb@2x.png: Added.
  • UserInterface/Images/gtk/SliderThumbPressed.png: Added.
  • UserInterface/Images/gtk/​SliderThumbPressed@2x.png: Added.
  • UserInterface/Images/gtk/Stopwatch.png: Added.
  • UserInterface/Images/gtk/​Stopwatch@2x.png: Added.
5:55 AM Changeset in webkit [174213] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r174100 - Hindi translation updated
​https://bugs.webkit.org/show_bug.cgi?id=137021

Patch by Rajesh Ranjan <​rajeshkajha@yahoo.com> on 2014-09-30
Reviewed by Philippe Normand.

  • hi.po:
5:54 AM Changeset in webkit [174212] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r174099 - Updated Telugu Translation for WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=137027

Patch by Krishnababu Krothapalli <​kkrothap@redhat.com> on 2014-09-30
Reviewed by Philippe Normand.

  • te.po:
5:54 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
5:53 AM Changeset in webkit [174211] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r174008 - [GTK] Don't include full path names in WebKitEnumTypes.h
​https://bugs.webkit.org/show_bug.cgi?id=137148

Reviewed by Carlos Garcia Campos.

Replace @filename@ with @basename@ in the template, since we don't
want to include the full path name in the generated header.

  • UIProcess/API/gtk/WebKitEnumTypes.h.template:
5:49 AM Changeset in webkit [174210] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r174104 - [GTK] The remote web inspector shows the HTML content as plain text
​https://bugs.webkit.org/show_bug.cgi?id=137250

Reviewed by Gustavo Noronha Silva.

Use GResource API directly to get the resource data, instead of
using the GFile API, and use g_content_type_guess() to get the
MIME Type.

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):

5:48 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
5:30 AM Changeset in webkit [174209] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] [JHBuild] Switch sourceware.org mirror to http.

Unreviewed.

The ftp access is recently failing to work as expected, and the
bots fail to download the file.
The same mirror is available via http and seems to work better.

  • gtk/jhbuild.modules:
4:14 AM Changeset in webkit [174208] by ryuan.choi@gmail.com
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] test_ewk2_view is failed
​https://bugs.webkit.org/show_bug.cgi?id=132983

Reviewed by Gyuyoung Kim.

Enable test_ewk2_view because test cases of test_ewk2_view are passed except
for few tests related to device_pixel_ratio.
This patch adds macro guard for ailed test case to CAIRO_SURFACE_SET_DEVICE_SCALE macro.
In addition, fixed some warnings while building with test_ewk2_view.

  • PlatformEfl.cmake: Enables test_ewk2_view.
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp: Added const keyword for argument to fix the warnings.

(EWK2UnitTest::EWK2UnitTestBase::keyDown):
(EWK2UnitTest::EWK2UnitTestBase::keyUp):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

3:57 AM Changeset in webkit [174207] by Andres Gomez
  • 47 edits
    9 copies
    7 adds
    12 deletes in trunk/Source/WebInspectorUI

Web Inspector: [GTK] Missing icons and enhancing the proportion and visibility of some icons
​https://bugs.webkit.org/show_bug.cgi?id=137248

Reviewed by Carlos Garcia Campos.

Add more free icons and removed some unused ones for the Web
Inspector in GTK+.
Also, enhanced the visibility and/or proportion of several of the
icons.

  • UserInterface/Images/gtk/AUTHORS:
  • UserInterface/Images/gtk/COPYING:
  • UserInterface/Images/gtk/Checkers.svg: Added.
  • UserInterface/Images/gtk/Circle.svg: Added.
  • UserInterface/Images/gtk/CloseLarge.svg: Added.
  • UserInterface/Images/gtk/CloseTimeline.png: Removed.
  • UserInterface/Images/gtk/​CloseTimeline@2x.png: Removed.
  • UserInterface/Images/gtk/Crosshair.svg:
  • UserInterface/Images/gtk/DOMCharacterData.svg:
  • UserInterface/Images/gtk/DOMComment.svg:
  • UserInterface/Images/gtk/DOMDocument.svg:
  • UserInterface/Images/gtk/DOMDocumentType.svg:
  • UserInterface/Images/gtk/DOMElement.svg:
  • UserInterface/Images/gtk/DOMNode.svg:
  • UserInterface/Images/gtk/DOMTextNode.svg:
  • UserInterface/Images/gtk/DOMTree.svg:
  • UserInterface/Images/gtk/EventListener.svg:
  • UserInterface/Images/gtk/Exception.svg:
  • UserInterface/Images/gtk/Function.svg:
  • UserInterface/Images/gtk/GradientStop.png: Added.
  • UserInterface/Images/gtk/​GradientStop@2x.png: Added.
  • UserInterface/Images/gtk/GradientStopSelected.png: Added.
  • UserInterface/Images/gtk/​GradientStopSelected@2x.png: Added.
  • UserInterface/Images/gtk/Issues.svg:
  • UserInterface/Images/gtk/IssuesEnabled.svg:
  • UserInterface/Images/gtk/LessColumns.svg: Removed.
  • UserInterface/Images/gtk/Logs.svg:
  • UserInterface/Images/gtk/Memory.svg: Removed.
  • UserInterface/Images/gtk/MoreColumns.svg: Removed.
  • UserInterface/Images/gtk/Native.svg:
  • UserInterface/Images/gtk/NavigationItemAngleBrackets.svg:
  • UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg:
  • UserInterface/Images/gtk/NavigationItemBug.svg:
  • UserInterface/Images/gtk/NavigationItemFile.svg:
  • UserInterface/Images/gtk/NavigationItemLayers.svg:
  • UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Removed.
  • UserInterface/Images/gtk/NavigationItemProbes.pdf: Added.
  • UserInterface/Images/gtk/NavigationItemStopwatch.svg:
  • UserInterface/Images/gtk/NavigationItemTypes.svg: Added.
  • UserInterface/Images/gtk/PaintFlashing.svg: Added.
  • UserInterface/Images/gtk/PseudoElement.svg:
  • UserInterface/Images/gtk/Record.svg: Added.
  • UserInterface/Images/gtk/Recording.png: Removed.
  • UserInterface/Images/gtk/​Recording@2x.png: Removed.
  • UserInterface/Images/gtk/RecordingHovered.png: Removed.
  • UserInterface/Images/gtk/​RecordingHovered@2x.png: Removed.
  • UserInterface/Images/gtk/RecordingStopped.png: Removed.
  • UserInterface/Images/gtk/​RecordingStopped@2x.png: Removed.
  • UserInterface/Images/gtk/Reflection.svg:
  • UserInterface/Images/gtk/ReplayPauseButton.svg: Added.
  • UserInterface/Images/gtk/ReplayPlayButton.svg: Added.
  • UserInterface/Images/gtk/ReplayRecordingButton.svg: Added.
  • UserInterface/Images/gtk/Request.svg:
  • UserInterface/Images/gtk/Resources.svg:
  • UserInterface/Images/gtk/Response.svg:
  • UserInterface/Images/gtk/ResultLine.svg:
  • UserInterface/Images/gtk/SourceCode.svg:
  • UserInterface/Images/gtk/Stop.svg: Added.
  • UserInterface/Images/gtk/StyleRuleAuthor.svg:
  • UserInterface/Images/gtk/StyleRuleInherited.svg:
  • UserInterface/Images/gtk/StyleRuleInheritedElement.svg:
  • UserInterface/Images/gtk/StyleRuleInspector.svg:
  • UserInterface/Images/gtk/StyleRuleUser.svg:
  • UserInterface/Images/gtk/StyleRuleUserAgent.svg:
  • UserInterface/Images/gtk/Time.svg:
  • UserInterface/Images/gtk/TimelineRecordAnimation.svg:
  • UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordEvent.svg:
  • UserInterface/Images/gtk/TimelineRecordLayout.svg:
  • UserInterface/Images/gtk/TimelineRecordPaint.svg:
  • UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg:
  • UserInterface/Images/gtk/TimelineRecordStyle.svg:
  • UserInterface/Images/gtk/TimelineRecordTimer.svg:
  • UserInterface/Images/gtk/Weight.svg:
2:47 AM Changeset in webkit [174206] by evab.u-szeged@partner.samsung.com
  • 6 edits in trunk/Source/WebCore

Fix minimal build warnings
​https://bugs.webkit.org/show_bug.cgi?id=137066

Reviewed by Daniel Bates.

No new tests, no behavior change.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::glyphDataForCharacter):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::prepareGraphicsContextForTextPainting):

2:05 AM Changeset in webkit [174205] by jinwoo7.song@samsung.com
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening. Rebaseline after r174160.

  • platform/efl/fast/borders/bidi-002-expected.txt:
  • platform/efl/fast/borders/bidi-009a-expected.txt:
1:01 AM Changeset in webkit [174204] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Minor bug in UIClient::exceededDatabaseQuota()
​https://bugs.webkit.org/show_bug.cgi?id=137213

Patch by JinYoung Hur <​hurims@gmail.com> on 2014-10-02
Reviewed by Anders Carlsson.

Make sure not to call the completion handler twice if exceededDatabaseQuota is null.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

12:58 AM Changeset in webkit [174203] by jinwoo7.song@samsung.com
  • 1 edit
    6 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening. Add expected results after r174002 and r136484.

  • platform/efl/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
  • platform/efl/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
  • platform/efl/fast/css-generated-content/initial-letter-clearance-expected.txt: Added.
  • platform/efl/fast/css-generated-content/initial-letter-descender-expected.txt: Added.
  • platform/efl/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
  • platform/efl/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.

Oct 1, 2014:

11:25 PM Changeset in webkit [174202] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r174185.
​https://bugs.webkit.org/show_bug.cgi?id=137334

Patch that adds logging causes webkitpy failures (Requested by
rfong on #webkit).

Reverted changeset:

"commitqueuetasks_unittest references a non-existent member
variable"
​https://bugs.webkit.org/show_bug.cgi?id=137303
​http://trac.webkit.org/changeset/174185

11:19 PM Changeset in webkit [174201] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

EWS and Commit Queue should know better than to spew 500 failed
results in the case of extremely red patches.
​https://bugs.webkit.org/show_bug.cgi?id=137324

Patch by Jake Nielsen <​jacob_nielsen@apple.com> on 2014-10-01
Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

Adds a check for did_exceed_test_failure_limit.
(AbstractEarlyWarningSystem._failing_tests_message):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

Alters the task mock to respond properly to
results_from_patch_test_run(patch)
(AbstractEarlyWarningSystemTest.test_failing_tests_message):

  • Scripts/webkitpy/tool/commands/queues.py:

Adds a check for did_exceed_test_failure_limit.
(CommitQueue._failing_tests_message):

11:19 PM Changeset in webkit [174200] by commit-queue@webkit.org
  • 2 edits in trunk

Bump version to 2.7.0
​https://bugs.webkit.org/show_bug.cgi?id=137301

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-10-01
Rubber-stamped by Carlos Garcia Campos.

  • Source/cmake/OptionsGTK.cmake: Bump version numbers
11:10 PM Changeset in webkit [174199] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Click events offset in webkit-overflow-scrolling iframes
​https://bugs.webkit.org/show_bug.cgi?id=134596

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-10-01
Reviewed by Sam Weinig.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRectInternal):
When converting coordinates from the main frame to a subframe's document, the position
is first converted to the subframe's FrameView coordinate system, then offset by the scroll
offset of the subframe itself.

The bug in this case was that the scroll offset used was the global scroll offset of the frame
in the view instead of the scroll offset of the document in its own frameview.

The regression was introduced by the refactoring r162663. On iOS WebKit1, the coordinate system
is different depending on VisibleContentRectIncludesScrollbars. In r162663, the value was set
such that the rect returned is always in absolute coordinate.

The ideal solution would be to refactor ScrollView::platformVisibleContentRect() to always return
the offsets in scroll view coordinates and verify and update all the call sites to use explicit
conversion to the top frame. In this patch I only reverted the coordinate change of r162663 to avoid
large scale impact.

10:25 PM Changeset in webkit [174198] by dbates@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r174192.

Revert the unit test fix in r174192 since we reverted r174187
in r174194 due to correctness issues. See
<​http://webkit.org/b/137329> for more details.

Reverted changeset:

"Test fix after r174187"
​http://trac.webkit.org/changeset/174192

9:10 PM Changeset in webkit [174197] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for File
​https://bugs.webkit.org/show_bug.cgi?id=137318

Reviewed by Gyuyoung Kim.

Use is<>() / downcast<>() for File instead of isFile() / toFile().

No new tests, no behavior change.

  • fileapi/Blob.h:
  • fileapi/File.h:

(isType):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::readAsArrayBuffer):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):

  • platform/network/FormData.cpp:

(WebCore::FormData::appendKeyValuePairItems):

7:19 PM Changeset in webkit [174196] by mrowe@apple.com
  • 10 edits
    3 adds in trunk

<​https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users

Source/WebKit/mac:

Reviewed by Dan Bernstein.

  • Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.

Source/WebKit2:

Reviewed by Dan Bernstein.

  • Configurations/DebugRelease.xcconfig: Use libWebKitSystemInterfaceYosemite.a on Yosemite.

Tools:

Reviewed by Dan Bernstein.

  • Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a

into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
for the LLVM components when on Yosemite.

WebKitLibraries:

Add versions of WebKitSystemInterface and LLVM for Yosemite. The LLVM build is from
LLVM SVN r206312, matching the Mavericks and Mountain Lion builds.

Reviewed by Dan Bernstein.

  • LLVMIncludesYosemite.tar.bz2: Added.
  • LLVMLibrariesYosemite.tar.bz2: Added.
  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceMavericks.a:
  • libWebKitSystemInterfaceMountainLion.a:
  • libWebKitSystemInterfaceYosemite.a: Added.
7:11 PM Changeset in webkit [174195] by Chris Dumez
  • 2 edits in trunk/Source/WTF

Unreviewed build fix after r174193.

Adding a return statement as that function is returning a boolean.

  • wtf/TypeCasts.h:

(WTF::TypeCastTraits::isOfType):

6:58 PM Changeset in webkit [174194] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r174187.
​https://bugs.webkit.org/show_bug.cgi?id=137329

webkitpy failures, and thorton says the patch is wrong
(Requested by dethbakin on #webkit).

Reverted changeset:

"[Windows] Increase layout test timeout for Windows following
r174162."
​http://trac.webkit.org/changeset/174187

6:18 PM Changeset in webkit [174193] by Chris Dumez
  • 2 edits in trunk/Source/WTF

Fail better when is<>() / downcast<>() is used for an unsupported type
​https://bugs.webkit.org/show_bug.cgi?id=137323

Reviewed by Benjamin Poulain.

We should fail better when is<>() / downcast<>() is used for an
unsupported type (i.e. a type that doesn't have the needed
TypeCastTraits template specialization). Previously, we would get an
obscure linking error, which was sub-optimal.

With this patch, you would now hit a static_assert() at build time if
you tried to use is<>() / downcast<>() for a type that did not have the
needed template specialization. There is also a helpful comment above
the assertion letting the developer know how to add the needed template
specialization.

  • wtf/TypeCasts.h:

(WTF::TypeCastTraits::isOfType):

5:58 PM Changeset in webkit [174192] by Brent Fulgham
  • 2 edits in trunk/Tools

Test fix after r174187

  • Scripts/webkitpy/port/win_unittest.py:

(WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.

5:49 PM Changeset in webkit [174191] by cabanier@adobe.com
  • 15 edits
    2 copies
    5 adds in trunk

Add support for midpoint to CSS gradients
​https://bugs.webkit.org/show_bug.cgi?id=137171

Reviewed by Darin Adler.

Source/WebCore:

This patch adds support for gradient midpoints. It also updates the
gradient tests so they use the feature.
Spec: ​http://dev.w3.org/csswg/css-images-4/#color-interpolation-hint

Tests: fast/gradients/unprefixed-color-stops2.html

fast/gradients/unprefixed-gradient-parsing.html
fast/gradients/unprefixed-linear-angle-gradients2.html
fast/gradients/unprefixed-radial-gradients.html
fast/gradients/unprefixed-radial-gradients2.html
fast/gradients/unprefixed-repeating-linear-gradient.html
fast/gradients/unprefixed-repeating-radial-gradients.html

  • css/CSSGradientValue.cpp:

(WebCore::GradientStop::GradientStop): constructor initializes the midpoint variable
(WebCore::CSSGradientValue::gradientWithStylesResolved): this function checks for midpoint color stops
(WebCore::CSSGradientValue::addStops): this function processes midpoints and converts them to regular color stops
(WebCore::CSSLinearGradientValue::customCSSText): this routine was updated to do correct parsing for midpoints
(WebCore::CSSRadialGradientValue::customCSSText):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientColorStop::CSSGradientColorStop): this function stores if a stop is a midpoint

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGradientColorStops): this function now allows color stops with no color

LayoutTests:

Updated the CSS gradient test files so they test the
gradient midpoint feature.

  • fast/gradients/unprefixed-color-stops2.html:
  • fast/gradients/unprefixed-gradient-parsing.html:
  • fast/gradients/unprefixed-linear-angle-gradients2.html:
  • fast/gradients/unprefixed-radial-gradients.html:
  • fast/gradients/unprefixed-radial-gradients2.html:
  • fast/gradients/unprefixed-repeating-linear-gradient.html:
  • fast/gradients/unprefixed-repeating-radial-gradients.html:
5:22 PM Changeset in webkit [174190] by Chris Dumez
  • 8 edits
    2 adds in trunk

Add basic caching for Document.cookie API
​https://bugs.webkit.org/show_bug.cgi?id=137225

Reviewed by Alexey Proskuryakov.

Source/WebCore:

While profiling the load of nytimes.com, I noticed that the site is
accessing ~250 times document.cookie, just during page load. Accessing
document.cookie is currently slow because we:

  • Call WebPlatformStrategies::cookiesForDOM() virtual function
  • Send a sync IPC message to the Network process to retrieve the cookies
    • The Network process gets the list of cookies from CFNetwork then serializes the result to send it back to the WebProcess
  • We unserialize the cookies into an NSList of cookies
  • We filter-out the cookies that are 'httpOnly' and construct a new NSList of cookies
  • We create a WTF String out of the cookies NSList

In the case of nytimes.com, it turns out that up to 100 calls to
document.cookie() are made in the same event loop iteration. This patch
thus caches / freezes the cookies until we return to the event
loop so that consecutive calls to document.cookie() are extremely fast.
Doing so seems to be sufficient to achieve a ~87% cache hit for
nytimes.com page load.

The cookies cache is invalidated whenever:

  • document.cookie is set
  • we return to the event loop
  • a network resource is loaded synchronously as it may cause cookies to be set before we return to the event loop

Test: http/tests/cookies/sync-xhr-set-cookie-invalidates-cache.html

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::open):
(WebCore::Document::cookie):
(WebCore::Document::setCookie):
(WebCore::Document::setCookieURL):
(WebCore::Document::initSecurityContext):
(WebCore::Document::setDOMCookieCache):
(WebCore::Document::invalidateDOMCookieCache):
(WebCore::Document::domCookieCacheExpiryTimerFired):
(WebCore::Document::didLoadResourceSynchronously):

  • dom/Document.h:

(WebCore::Document::domCookieCache):
(WebCore::Document::isDOMCookieCacheValid):
(WebCore::Document::setCookieURL): Deleted.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::didLoadResourceSynchronously):

  • dom/ScriptExecutionContext.h:
  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::loadResourceSynchronously):

LayoutTests:

Add a layout test to make sure that document.cookie returns updated
results after cookies are set via a sync XHR.

  • http/tests/cookies/sync-xhr-set-cookie-invalidates-cache-expected.txt: Added.
  • http/tests/cookies/sync-xhr-set-cookie-invalidates-cache.html: Added.
5:20 PM Changeset in webkit [174189] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] Mass skip all media tests until bots have audio devices to run them with.

  • platform/win/TestExpectations:
4:54 PM Changeset in webkit [174188] by commit-queue@webkit.org
  • 12 edits
    1 delete in trunk/Source

Unreviewed, rolling out r174180, r174183, and r174186.
​https://bugs.webkit.org/show_bug.cgi?id=137320

Broke the Mac MountainLion build. Will investigate offline.
(Requested by dydz on #webkit).

Reverted changesets:

"Clean up: Move XPC forward declarations in JavaScriptCore to
WTF SPI wrapper header"
​https://bugs.webkit.org/show_bug.cgi?id=137277
​http://trac.webkit.org/changeset/174180

"Attempt to fix the build after
<​https://trac.webkit.org/changeset/174180>"
​https://bugs.webkit.org/show_bug.cgi?id=137277
​http://trac.webkit.org/changeset/174183

"Another attempt to fix the Mac build after
<​https://trac.webkit.org/changeset/174180>"
​https://bugs.webkit.org/show_bug.cgi?id=137277
​http://trac.webkit.org/changeset/174186

4:29 PM Changeset in webkit [174187] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Increase layout test timeout for Windows following r174162.

  • Scripts/webkitpy/port/win.py:

(WinPort.default_timeout_ms):

4:17 PM Changeset in webkit [174186] by dbates@webkit.org
  • 2 edits in trunk/Source/WTF

Another attempt to fix the Mac build after <​https://trac.webkit.org/changeset/174180>
(​https://bugs.webkit.org/show_bug.cgi?id=137277)

Include header AvailabilityMacros.h instead of Availability.h, which actually defines the
macro MAC_OS_X_VERSION_MIN_REQUIRED.

  • wtf/spi/darwin/XPCSPI.h:
4:05 PM Changeset in webkit [174185] by roger_fong@apple.com
  • 3 edits in trunk/Tools

[Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.

  • Scripts/webkitpy/port/drdiver.py:

(Driver.stop):

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess.stop):

4:00 PM Changeset in webkit [174184] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[ Windows ] More Windows test gardening to get bots green Part 3.

  • platform/win/TestExpectations: More indiscriminate mass skipping.
3:59 PM Changeset in webkit [174183] by dbates@webkit.org
  • 2 edits in trunk/Source/WTF

Attempt to fix the build after <​https://trac.webkit.org/changeset/174180>
(​https://bugs.webkit.org/show_bug.cgi?id=137277)

Include header <Availability.h> for the definition of MAC_OS_X_VERSION_MIN_REQUIRED.
Also, we want to define CONST_ON_OR_AFTER_MAC_OS_X_VERSION_1090 to be const when building
on iOS.

  • wtf/spi/darwin/XPCSPI.h:
3:46 PM Changeset in webkit [174182] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

commitqueuetasks_unittest references a non-existent member variable
when mock-reporting flaky tests.
​https://bugs.webkit.org/show_bug.cgi?id=137303

Patch by Jake Nielsen <​jacob_nielsen@apple.com> on 2014-10-01
Reviewed by Daniel Bates.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(MockCommitQueue.report_flaky_tests):
Makes the appropriate name change.
(test_simple_flaky_test_failure):
Adds a unit test to make sure that the code is excercised.

3:43 PM Changeset in webkit [174181] by Beth Dakin
  • 2 edits in trunk/LayoutTests

This expectation should be MoutainLion-only until we find evidence otherwise.

  • platform/mac/TestExpectations:
3:38 PM Changeset in webkit [174180] by dbates@webkit.org
  • 12 edits
    2 adds in trunk/Source

Clean up: Move XPC forward declarations in JavaScriptCore to WTF SPI wrapper header
​https://bugs.webkit.org/show_bug.cgi?id=137277

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

Use wtf/spi/darwin/XPCSPI.h instead of including the corresponding XPC headers/
forward declaring XPC functions.

  • inspector/remote/RemoteInspector.mm:
  • inspector/remote/RemoteInspectorXPCConnection.h:
  • inspector/remote/RemoteInspectorXPCConnection.mm:

Source/WebKit2:

Use wtf/spi/darwin/XPCSPI.h instead of including the corresponding XPC headers/
forward declaring XPC functions.

  • Platform/IPC/Connection.h:
  • Platform/IPC/mac/ConnectionMac.mm:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

Source/WTF:

Towards centralizing the declarations of XPC functions used in JavaScriptCore
and WebKit2, add a header that wraps these function declarations called XPCSPI.h
and use it instead of including the corresponding XPC API/SPI headers/forward
declaring XPC functions. This will also aid in the effort to make WebKit2 build
for iOS with the public iOS SDK.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/spi/darwin/XPCSPI.h: Added.
3:35 PM Changeset in webkit [174179] by Beth Dakin
  • 2 edits in trunk/LayoutTests

Another flaky-trashy test.

  • platform/mac/TestExpectations:
3:29 PM Changeset in webkit [174178] by Chris Dumez
  • 48 edits in trunk/Source

Use is<>() / downcast<>() for Event classes
​https://bugs.webkit.org/show_bug.cgi?id=137284

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for Event classes.

Source/WebCore:

No new tests, no behavior change.

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • dom/BeforeTextInsertedEvent.h:
  • dom/BeforeUnloadEvent.h:
  • dom/ErrorEvent.h:
  • dom/Event.h:
  • dom/EventContext.cpp:

(WebCore::MouseOrFocusEventContext::handleLocalEvents):

  • dom/FocusEvent.h:
  • dom/KeyboardEvent.cpp:

(WebCore::findKeyboardEvent):

  • dom/KeyboardEvent.h:
  • dom/MouseEvent.cpp:

(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):

  • dom/MouseEvent.h:
  • dom/Node.cpp:

(WebCore::Node::defaultEventHandler):

  • dom/TextEvent.h:
  • dom/UIEvent.h:
  • dom/WheelEvent.h:
  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::eventType):
(WebCore::isEnterKeyKeydownEvent):
(WebCore::isLinkClick):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::defaultEventHandler):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::submitImplicitly):

  • html/HTMLFormElement.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::defaultEventHandler):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::willDispatchEvent):
(WebCore::HTMLInputElement::defaultEventHandler):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::defaultEventHandler):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::defaultEventHandler):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::defaultEventHandler):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultEventHandler):

  • html/ImageDocument.cpp:

(WebCore::ImageEventListener::handleEvent):

  • html/ImageInputType.cpp:

(WebCore::ImageInputType::handleDOMActivateEvent):

  • html/InputType.cpp:

(WebCore::InputType::shouldSubmitImplicitly):

  • html/InputType.h:
  • html/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::shouldSubmitImplicitly):

  • html/TextFieldInputType.h:
  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::defaultEventHandler):
(WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler):
(WebCore::MediaControlTimelineElement::defaultEventHandler):

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::containsRelatedTarget):

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsAppleEventListener::handleEvent):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::defaultEventHandler):

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::forwardEvent):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::maybeCreateContextMenu):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTextInputEvent):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):

  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::handleEvent):

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):

3:18 PM AddingFiles edited by Brian Burg
[Win] Add reminder about *AllInOne.cpp files. (diff)
3:12 PM Changeset in webkit [174177] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Unreviewed build gardening.

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Show files in the appropriate

folders in Visual Studio.

3:00 PM Changeset in webkit [174176] by Beth Dakin
  • 2 edits in trunk/LayoutTests

Yet another crash-flaky test.

2:48 PM Changeset in webkit [174175] by Lucas Forschler
  • 5 edits in branches/safari-600.1.17-branch/Source

Versioning.

2:45 PM Changeset in webkit [174174] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.17.3

New Tag.

2:34 PM Changeset in webkit [174173] by fpizlo@apple.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

Object allocation sinking is broken for escaping sites in loops
​https://bugs.webkit.org/show_bug.cgi?id=137310

Reviewed by Michael Saboff.

I tried to do this clever forward-flow based materialization point placement, and I messed up loops. Disabling
the phase for now and landing a test to demonstrate what it going on.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • runtime/Options.h:
  • tests/stress/object-escapes-in-loop.js: Added.

(foo):
(bar):

2:27 PM Changeset in webkit [174172] by Beth Dakin
  • 2 edits in trunk/LayoutTests

Marking this test as CRASHY-flaky since it is.

  • platform/mac-wk2/TestExpectations:
2:24 PM Changeset in webkit [174171] by Lucas Forschler
  • 4 edits in branches/safari-600.1.17-branch/Source

Merged r174162.

2:08 PM Changeset in webkit [174170] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

EWS is inconclusively spinning forever on a patch that breaks 500+
tests
​https://bugs.webkit.org/show_bug.cgi?id=137223

Patch by Jake Nielsen <​jacob_nielsen@apple.com> on 2014-10-01
Reviewed by Tim Horton.

  • Scripts/webkitpy/tool/bot/patchanalysistask.py:

Checks to see whether the tests have exceeded the failure limit, and
only spins off another test if they have not exceeded the limit.
(PatchAnalysisTask._test_patch):

2:02 PM Changeset in webkit [174169] by Beth Dakin
  • 2 edits in trunk/LayoutTests

Marking this test as trashy-flaky since it is.

  • platform/mac/TestExpectations:
1:52 PM Changeset in webkit [174168] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[TexMap] Sprinkle range-based for-loops in GraphicsLayerTextureMapper, TextureMapperLayer
​https://bugs.webkit.org/show_bug.cgi?id=137271

Reviewed by Sergio Villar Senin.

Switch to using C++11 range-based for-loops in the
GraphicsLayerTextureMapper and TextureMapperLayer classes.

The for loops that remained unchanged either do further computation
with the loop index or must iterate over the container in reverse.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::toTextureMapperLayerVector):
(WebCore::GraphicsLayerTextureMapper::flushCompositingState):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::computeOverlapRegions):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::setChildren):
(WebCore::TextureMapperLayer::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperLayer::applyAnimationsRecursively):

1:47 PM Changeset in webkit [174167] by saambarati1@gmail.com
  • 20 edits
    1 add in trunk/Source/JavaScriptCore

Support the type profiler in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=136712

Reviewed by Filip Pizlo.

This patch implements op_profile_type inside the DFG as the node: ProfileType.
The DFG will convert the ProfileType node into a Check node in the cases where
passing a type check is equivalent to writing to the TypeProfilerLog. This
gives the DFG the potential to optimize out multiple ProfileType nodes into
a single Check node.

When the DFG doesn't convert ProfileType into a Check node, it will generate
the same inline code as the baseline JIT does for writing an entry to the
TypeProfilerLog.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::typeLocation):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/TypeProfiler.cpp:

(JSC::TypeProfiler::logTypesForTypeLocation):

  • runtime/TypeSet.cpp:

(JSC::TypeSet::dumpTypes):
(JSC::TypeSet::doesTypeConformTo):
Make this method public so others can reason about the types a TypeSet has seen.
(JSC::TypeSet::seenTypes): Deleted.
(JSC::TypeSet::dumpSeenTypes): Deleted.
Renamed to dumpTypes so the method seenTypes can be used as a public getter.

  • runtime/TypeSet.h:

(JSC::TypeSet::seenTypes):

  • tests/typeProfiler/dfg-jit-optimizations.js: Added.

(tierUpToDFG):
(funcs):
(.return):

1:39 PM Changeset in webkit [174166] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix 32-bit.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

1:12 PM Changeset in webkit [174165] by fpizlo@apple.com
  • 17 edits in trunk/Source/JavaScriptCore

DFG SSA should use PutLocal/KillLocal instead of SetLocal to communicate what is flushed to the stack and when
​https://bugs.webkit.org/show_bug.cgi?id=137242

Reviewed by Geoffrey Garen.

OSR availability has to do with telling you the various ways that you could go about getting
the value of a bytecode variable. It can give you two options: node availability means that
there is a node in the DFG IR that has the right value, and flush availability tells you
that the value was already stored to the stack. The clients of OSR availability would
typically prefer flush over node availability.

Previously OSR availability was affected thusly by the various local-related nodes: SetLocal
set both the node and flush availability, MovHint set node availability and cleared flush
availability, GetArgument set both, and ZombieHint cleared both.

A MovHint could be turned into a ZombieHint if its source value was DCEd.

The fact that each node affected both node and flush availability caused weirdness. For
example it meant that we could not insert MovHints in areas of the CFG where a SetLocal's
variable was still live, because then those parts of the code would forget that they had an
availability flush. This meant that if a flush was available, we wouldn't insert MovHints,
and so we would forget that a node was in fact available. This kind of "either-or" picking
was not only hackish but it led to interesting problems for IR transformation: for example
if you tried to do any kind of code motion on SetLocals, you had to be super careful because
you might violate the rule that "MovHints must exist for a live local if a flush is
unavailable".

The right thing to do is to have independent nodes for flushing and making nodes available.
They shouldn't interact with each other. This patch accomplishes this:

  • PutLocal means that that a value is to be stored to the stack. It makes a flush available.
  • KillLocal means that the value stored to the stack is no longer available for the purposes of OSR (i.e. it no longer accurately corresponds to what that actual bytecode variable would have been, so you have to fall back on node availability).
  • MovHint means that a node is available. It has no effect on flush availability.
  • ZombieHint means that a node is not available. It has no effect on flush availability.


This means that we will see a lot of KillLocals and MovHints right next to each other. It's
a bit verbose, but at least it's precise.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGAvailability.h:

(JSC::DFG::Availability::setFlush):
(JSC::DFG::Availability::setNode):
(JSC::DFG::Availability::setNodeUnavailable):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.cpp:

(JSC::DFG::Node::hasVariableAccessData):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasUnlinkedLocal):
(JSC::DFG::Node::willHaveCodeGenOrOSR):

  • dfg/DFGNodeType.h:
  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compilePutLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal): Deleted.

11:30 AM Changeset in webkit [174164] by Brian Burg
  • 2 edits in trunk/Tools

Unreviewed, add Katie Madonna as a contributor.

  • Scripts/webkitpy/common/config/contributors.json:
11:26 AM Changeset in webkit [174163] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[ Windows ] More Windows test gardening to get bots green Part 2.

  • platform/win/TestExpectations: More indiscriminate mass skipping.
11:22 AM Changeset in webkit [174162] by Brent Fulgham
  • 4 edits in trunk/Source

[Win] 32-bit JavaScriptCore should limit itself to the C loop
​https://bugs.webkit.org/show_bug.cgi?id=137304
<rdar://problem/18375370>

Reviewed by Michael Saboff.

../JavaScriptCore:

Use the C loop for 32-bit builds.

../WTF:

  • wtf/Platform.h: Force the C loop when building for 32-bit Windows.
10:52 AM Changeset in webkit [174161] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

commitqueuetasks_unittest does not construct FailingTestCommitQueue
objects properly in its test cases.
​https://bugs.webkit.org/show_bug.cgi?id=137281

Patch by Jake Nielsen <​jacob_nielsen@apple.com> on 2014-10-01
Reviewed by Daniel Bates.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(FailingTestCommitQueue.test_results):
Adds an assert to make FailingTestCommitQueue harder to mis-use.
(test_double_flaky_test_failure):
Nests the intended test failure strings into one-length lists.
(test_red_test_failure):
Nests the intended test failure strings into one-length lists.

10:35 AM Changeset in webkit [174160] by ap@apple.com
  • 41 edits in trunk

REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
​https://bugs.webkit.org/show_bug.cgi?id=136987

Reviewed by Daniel Bates.

Tools:

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):

Specify the default encoding for all WebKit developers to get consistent results.

LayoutTests:

These test changes are not strictly necessary to fix the issue, as I'm also adding
a default to WebKitTestRunner. But it's nice to have tests work identically in WKTR
and in a browser, for which it's necessary to have them specify charset.

  • accessibility/table-scope-expected.txt:
  • accessibility/table-scope.html:
  • fast/borders/bidi-002.html:
  • fast/borders/bidi-009a.html:
  • fast/frames/sandboxed-iframe-attribute-parsing-03-expected.txt:
  • fast/frames/sandboxed-iframe-attribute-parsing-03.html:
  • platform/mac/accessibility/table-headers-attribute-expected.txt:
  • platform/mac/accessibility/table-headers-attribute.html:
  • platform/mac/accessibility/table-with-zebra-rows-expected.txt:
  • platform/mac/accessibility/table-with-zebra-rows.html:
  • platform/mac/fast/borders/bidi-002-expected.png:
  • platform/mac/fast/borders/bidi-002-expected.txt:
  • platform/mac/fast/borders/bidi-009a-expected.png:
  • platform/mac/fast/borders/bidi-009a-expected.txt:
  • plugins/plugin-remove-subframe-expected.txt:
  • plugins/plugin-remove-subframe.html:

These tests were actually expected to use UTF-8, so we used to be running them in
an inconsequentially wrong way.

  • fast/css/text-transform-select.html:
  • fast/encoding/high-bit-latin1.html:
  • fast/encoding/parser-tests-10.html:
  • fast/encoding/parser-tests-100.html:
  • fast/encoding/parser-tests-110.html:
  • fast/encoding/parser-tests-120.html:
  • fast/encoding/parser-tests-20.html:
  • fast/encoding/parser-tests-30.html:
  • fast/encoding/parser-tests-50.html:
  • fast/encoding/parser-tests-60.html:
  • fast/encoding/parser-tests-70.html:
  • fast/encoding/parser-tests-80.html:
  • fast/encoding/parser-tests-90.html:
  • fast/encoding/parser-tests.html:
  • fast/url/anchor.html:
  • fast/url/file-http-base.html:
  • fast/url/file.html:
  • fast/url/query.html:
  • fast/url/standard-url.html:
  • http/tests/misc/char-encoding-in-hidden-charset-field-default.html:
  • js/dom/regexp-overflow.html:
  • tables/mozilla_expected_failures/bugs/bug47163.html:

Specified the encoding, windows-1252 is what we use for Latin1 and ISO-8859-1 alike.

10:30 AM Changeset in webkit [174159] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6

Merge r173964 - [Gtk] build.sh needs a -- before make options when the build command is cmake --build
​https://bugs.webkit.org/show_bug.cgi?id=136377

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2014-09-25
Reviewed by Philippe Normand.

.:

  • Source/cmake/OptionsGTK.cmake: Only create the build.sh script

for CMake versions less than 3.

Tools:

  • Scripts/webkitdirs.pm:

(buildCMakeGeneratedProject): Only use the build.sh script if it exists.

10:18 AM Changeset in webkit [174158] by ap@apple.com
  • 3 edits in trunk/Tools

EWS is too eager to say that a patch does not apply to trunk of repository
​https://bugs.webkit.org/show_bug.cgi?id=137290

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/app.yaml: Updated app version.
  • QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble):
(StatusBubble._build_bubbles_for_attachment):
Rewrote to make more sense.

9:17 AM Changeset in webkit [174157] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Windows build fix.

  • platform/network/cf/ResourceResponseCFNet.cpp:
7:54 AM WebKitGtkLayoutTests edited by Andres Gomez
Updated due to the removal of WebKit1 (diff)
7:50 AM WebKitGTK/StartHacking edited by Andres Gomez
Updating instructions due to migration to CMake and removal of WebKit1 code (diff)
7:31 AM Changeset in webkit [174156] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r173423): [iOS] Sites with EV certificates appear as normal HTTPS sites
​https://bugs.webkit.org/show_bug.cgi?id=137262

Reviewed by Antti Koivisto.

No new tests, because the API test harness doesn’t run an HTTP server to test against.

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformCertificateInfo): Return a CertificateInfo initialized
with the certificate array from the response.

4:19 AM Changeset in webkit [174155] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.2.8

WebKitGTK+ 2.2.8

3:41 AM Changeset in webkit [174154] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.2.8 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Add release notes.
1:55 AM Changeset in webkit [174153] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r173252 - [SOUP] Race condition when downloading a file due to the intermediate temporary file
​https://bugs.webkit.org/show_bug.cgi?id=136423

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-09-03
Reviewed by Carlos Garcia Campos.

  • Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::DownloadClient): Replace m_destinationURI with
m_destinationFile and add m_createdDestination.
(WebKit::DownloadClient::deleteFilesIfNeeded): Added.
(WebKit::DownloadClient::downloadFailed): Call deleteFilesIfNeeded.
(WebKit::DownloadClient::didReceiveResponse): Attempt to create the
destination file before the intermediate file. Fail here if the file
exists and overwrite is not allowed, so we don't erroneously fire the
didCreateDestination event or waste time downloading the file when we
know the download will fail.
(WebKit::DownloadClient::didFinishLoading): Unconditionally overwrite
the empty destination file.
(WebKit::DownloadClient::cancel): Call deleteFilesIfNeeded.
(WebKit::DownloadClient::deleteIntermediateFileInNeeded): Deleted.

1:49 AM Changeset in webkit [174152] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r173154 - [SOUP] WebKitDownload cannot overwrite existing file
​https://bugs.webkit.org/show_bug.cgi?id=136322

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-09-01
Reviewed by Carlos Garcia Campos.

  • Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): pass a member variable
to Download::decideDestinationWithSuggestedFilename instead of a
temporary bool, so we can use the result in didFinishLoading.
(WebKit::DownloadClient::didFinishLoading): overwrite the destination
if Download::decideDestinationWithSuggestedFilename determined we
should do so.

1:44 AM Changeset in webkit [174151] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r172896 - [GTK] Toggle buttons visually broken with GTK+ 3.13.7
​https://bugs.webkit.org/show_bug.cgi?id=136130

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-08-24
Reviewed by Martin Robinson.

No new tests. Hopefully covered by existing tests, and our tests only
run with GTK+ 3.6 anyway.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::paintToggle): use GTK_STATE_FLAG_CHECKED when compiling for
GTK+ 3.13.7 and above to ensure toggle buttons display as toggled.

1:39 AM Changeset in webkit [174150] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r172958 - [GTK] Selection background is rendered white when unfocused with recent GTK+
​https://bugs.webkit.org/show_bug.cgi?id=136251

Reviewed by Martin Robinson.

This is due to a change in the GTK+ theme, but because we are not
using the right flags to get the selections colors. We should use
GTK_STATE_FLAG_SELECTED | GTK_STATE_FLAG_FOCUSED when focused and
GTK_STATE_FLAG_SELECTED when unfocused, instead of
GTK_STATE_FLAG_ACTIVE when unfocused.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionForegroundColor):

1:33 AM Changeset in webkit [174149] by Carlos Garcia Campos
  • 2 edits
    189 adds in releases/WebKitGTK/webkit-2.2/Source/WebInspectorUI

Merge r173753 - Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
​https://bugs.webkit.org/show_bug.cgi?id=136632

Reviewed by Gustavo Noronha Silva.

Source/WebInspectorUI:

Add free icons for the GTK port. These icons are from the GNOME
project, some of them adapted by Andres Gomez for the inspector.

1:15 AM Changeset in webkit [174148] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS] <select> with <optgroup> may change initial selected option when assisted
​https://bugs.webkit.org/show_bug.cgi?id=137261

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-01
Reviewed by Enrica Casucci.

The initial assignemnt of _singleSelectionIndex was calculating the
item index (ignoring groups) instead of the row index (affected by
groups!). Thus if there was N groups we would select the row N
before the real selection.

Also avoid this entirely if this is a multiple selection picker.
This logic is only needed for single selection with groups.

  • UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKMultipleSelectPicker initWithView:]):

12:57 AM Changeset in webkit [174147] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2

Merge r173999 - [GTK] Enable CSS_IMAGE_SET in production builds
​https://bugs.webkit.org/show_bug.cgi?id=137142

Reviewed by Alejandro G. Castro.

This is required by the inspector to show some of the icons that
has a HiDPI variant.

  • Source/cmake/OptionsGTK.cmake:
12:28 AM Changeset in webkit [174146] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r172919 - [GTK] Should check if a plugin mixes GTK+ symbols earlier
​https://bugs.webkit.org/show_bug.cgi?id=136214

Reviewed by Philippe Normand.

We are currently checking if the plugin module and the plugin
process mix GTK symbols after the plugin has been loaded and
initialized. This is too late in many cases, since plugins can use
GTK methods in the NP_Initialize implementation. This is causing
the apps using WebKitGTK+ 2.4 to freeze when the plugin process
scans the plugins and there's a plugin using GTK+3 installed. We
should move the check earlier, once the module is loaded but
before calling NP_Initialize.

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::moduleMixesGtkSymbols):
(WebKit::NetscapePluginModule::tryLoad):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformPostInitialize):

12:20 AM Changeset in webkit [174145] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r172920 - [GTK] Older versions of WebKit should use the plugins cache in read only mode
​https://bugs.webkit.org/show_bug.cgi?id=136215

Reviewed by Philippe Normand.

Now that WebKitGTK+ 2.4 and 2.5 are parallel installable, since
they use different versions of the plugins cache, apps using 2.4
might override the plugins cache file. We should prevent this from
happening by making older versions use the plugin cache, but not
downgrade it.

  • UIProcess/Plugins/gtk/PluginInfoCache.cpp:

(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::updatePluginInfo):

  • UIProcess/Plugins/gtk/PluginInfoCache.h:

Sep 30, 2014:

11:40 PM Changeset in webkit [174144] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

11:37 PM Changeset in webkit [174143] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.2

New tag.

11:20 PM Changeset in webkit [174142] by Yusuke Suzuki
  • 2 edits in trunk/Source/WebCore

CSS JIT: Enable multiple stack references allocation by allocateUninitialized
​https://bugs.webkit.org/show_bug.cgi?id=135293

Reviewed by Benjamin Poulain.

  • cssjit/StackAllocator.h:

(WebCore::StackAllocator::stackTop):

Add stackTop method to check references are allocated easily.

(WebCore::StackAllocator::allocateUninitialized):

10:49 PM Changeset in webkit [174141] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Drop getPtr() overload taking a Document reference in argument
​https://bugs.webkit.org/show_bug.cgi?id=137280

Reviewed by Daniel Bates.

Drop getPtr() overload taking a Document reference in argument. This is
no longer needed as the generic getPtr() function converts references
into pointers just fine after r173765.

No new tests, no behavior change.

  • dom/Document.h:

(WTF::getPtr): Deleted.

9:34 PM Changeset in webkit [174140] by Brian Burg
  • 72 edits in trunk/Source

Web Inspector: ErrorString should be passed by reference
​https://bugs.webkit.org/show_bug.cgi?id=137257

Reviewed by Joseph Pecoraro.

Pass the leading ErrorString argument by reference, since it is always an out parameter.
Clean up callsites where the error message is written.

Source/JavaScriptCore:

  • inspector/InjectedScript.cpp:

(Inspector::InjectedScript::evaluate):
(Inspector::InjectedScript::callFunctionOn):
(Inspector::InjectedScript::evaluateOnCallFrame):
(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getInternalProperties):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::makeEvalCall):

  • inspector/InjectedScriptBase.h:
  • inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorAgent::enable):
(Inspector::InspectorAgent::disable):
(Inspector::InspectorAgent::initialized):

  • inspector/agents/InspectorAgent.h:
  • inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorConsoleAgent::enable):
(Inspector::InspectorConsoleAgent::disable):
(Inspector::InspectorConsoleAgent::clearMessages):
(Inspector::InspectorConsoleAgent::reset):
(Inspector::InspectorConsoleAgent::addMessageToConsole):

  • inspector/agents/InspectorConsoleAgent.h:
  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::enable):
(Inspector::InspectorDebuggerAgent::disable):
(Inspector::InspectorDebuggerAgent::setBreakpointsActive):
(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::parseLocation):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::removeBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::searchInContent):
(Inspector::InspectorDebuggerAgent::getScriptSource):
(Inspector::InspectorDebuggerAgent::getFunctionDetails):
(Inspector::InspectorDebuggerAgent::pause):
(Inspector::InspectorDebuggerAgent::resume):
(Inspector::InspectorDebuggerAgent::stepOver):
(Inspector::InspectorDebuggerAgent::stepInto):
(Inspector::InspectorDebuggerAgent::stepOut):
(Inspector::InspectorDebuggerAgent::setPauseOnExceptions):
(Inspector::InspectorDebuggerAgent::evaluateOnCallFrame):
(Inspector::InspectorDebuggerAgent::setOverlayMessage):
(Inspector::InspectorDebuggerAgent::didParseSource):
(Inspector::InspectorDebuggerAgent::clearInspectorBreakpointState):
(Inspector::InspectorDebuggerAgent::assertPaused):

  • inspector/agents/InspectorDebuggerAgent.h:
  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::parse):
(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::releaseObject):
(Inspector::InspectorRuntimeAgent::releaseObjectGroup):
(Inspector::InspectorRuntimeAgent::run):
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
(Inspector::InspectorRuntimeAgent::enableTypeProfiler):
(Inspector::InspectorRuntimeAgent::disableTypeProfiler):

  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/agents/JSGlobalObjectConsoleAgent.cpp:

(Inspector::JSGlobalObjectConsoleAgent::setMonitoringXHREnabled):
(Inspector::JSGlobalObjectConsoleAgent::addInspectedNode):

  • inspector/agents/JSGlobalObjectConsoleAgent.h:
  • inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::injectedScriptForEval):

  • inspector/agents/JSGlobalObjectDebuggerAgent.h:
  • inspector/agents/JSGlobalObjectRuntimeAgent.cpp:

(Inspector::JSGlobalObjectRuntimeAgent::injectedScriptForEval):

  • inspector/agents/JSGlobalObjectRuntimeAgent.h:
  • inspector/scripts/codegen/generate_backend_dispatcher_header.py:

(BackendDispatcherHeaderGenerator._generate_handler_declaration_for_command):
(BackendDispatcherHeaderGenerator._generate_async_handler_declaration_for_command):

  • inspector/scripts/codegen/generate_backend_dispatcher_implementation.py:

(BackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):

  • inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
  • inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
  • inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
  • inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:

Source/WebCore:

No new tests, no behavior changed.

  • inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::clearConsoleMessages):

  • inspector/DOMEditor.cpp:

(WebCore::populateErrorString):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::removeChild):
(WebCore::DOMEditor::setAttribute):
(WebCore::DOMEditor::removeAttribute):
(WebCore::DOMEditor::setOuterHTML):
(WebCore::DOMEditor::replaceWholeText):

  • inspector/DOMEditor.h:
  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::enable):
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::assertFrameWithDocumentLoader):
(WebCore::InspectorApplicationCacheAgent::getManifestForFrame):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::disable):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::regionOversetChanged):
(WebCore::InspectorCSSAgent::didRegisterNamedFlowContentElement):
(WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::getStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleSheetText):
(WebCore::InspectorCSSAgent::setStyleText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::elementForId):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):
(WebCore::InspectorCSSAgent::buildArrayForRegions):
(WebCore::InspectorCSSAgent::buildObjectForNamedFlow):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::hideHighlight):
(WebCore::InspectorController::setProfilerEnabled):
(WebCore::InspectorController::resume):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDOMAgent::assertNode):
(WebCore::InspectorDOMAgent::assertDocument):
(WebCore::InspectorDOMAgent::assertElement):
(WebCore::InspectorDOMAgent::assertEditableNode):
(WebCore::InspectorDOMAgent::assertEditableElement):
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
(WebCore::InspectorDOMAgent::requestChildNodes):
(WebCore::InspectorDOMAgent::querySelector):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::releaseBackendNodeIds):
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getAccessibilityPropertiesForNode):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::discardSearchResults):
(WebCore::InspectorDOMAgent::inspect):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::hideHighlight):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::undo):
(WebCore::InspectorDOMAgent::redo):
(WebCore::InspectorDOMAgent::markUndoableState):
(WebCore::InspectorDOMAgent::focus):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::requestNode):
(WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
(WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeInstrumentationBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::domTypeForName):
(WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::findStorageArea):

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):

  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
(WebCore::assertDocument):
(WebCore::assertIDBFactory):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
(WebCore::InspectorIndexedDBAgent::clearObjectStore):

  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorLayerTreeAgent::enable):
(WebCore::InspectorLayerTreeAgent::disable):
(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderLayerHierarchy):
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
(WebCore::InspectorLayerTreeAgent::idForNode):
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):

  • inspector/InspectorLayerTreeAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceContent):
(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::navigate):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::getResourceContent):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::setDocumentContent):
(WebCore::InspectorPageAgent::setShowPaintRects):
(WebCore::InspectorPageAgent::canShowDebugBorders):
(WebCore::InspectorPageAgent::setShowDebugBorders):
(WebCore::InspectorPageAgent::canShowFPSCounter):
(WebCore::InspectorPageAgent::setShowFPSCounter):
(WebCore::InspectorPageAgent::canContinuouslyPaint):
(WebCore::InspectorPageAgent::setContinuousPaintingEnabled):
(WebCore::InspectorPageAgent::getScriptExecutionStatus):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
(WebCore::InspectorPageAgent::assertFrame):
(WebCore::InspectorPageAgent::assertDocumentLoader):
(WebCore::InspectorPageAgent::setTouchEmulationEnabled):
(WebCore::InspectorPageAgent::setEmulatedMedia):
(WebCore::InspectorPageAgent::getCompositingBordersVisible):
(WebCore::InspectorPageAgent::setCompositingBordersVisible):
(WebCore::InspectorPageAgent::snapshotNode):
(WebCore::InspectorPageAgent::snapshotRect):
(WebCore::InspectorPageAgent::handleJavaScriptDialog):
(WebCore::InspectorPageAgent::archive):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorReplayAgent.cpp:

(WebCore::InspectorReplayAgent::startCapturing):
(WebCore::InspectorReplayAgent::stopCapturing):
(WebCore::InspectorReplayAgent::replayToPosition):
(WebCore::InspectorReplayAgent::replayToCompletion):
(WebCore::InspectorReplayAgent::pausePlayback):
(WebCore::InspectorReplayAgent::cancelPlayback):
(WebCore::InspectorReplayAgent::switchSession):
(WebCore::InspectorReplayAgent::insertSessionSegment):
(WebCore::InspectorReplayAgent::removeSessionSegment):
(WebCore::InspectorReplayAgent::findSession):
(WebCore::InspectorReplayAgent::findSegment):
(WebCore::InspectorReplayAgent::currentReplayState):
(WebCore::InspectorReplayAgent::getAvailableSessions):
(WebCore::InspectorReplayAgent::getSessionData):
(WebCore::InspectorReplayAgent::getSegmentData):

  • inspector/InspectorReplayAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorResourceAgent::~InspectorResourceAgent):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
(WebCore::InspectorResourceAgent::getResponseBody):
(WebCore::InspectorResourceAgent::replayXHR):
(WebCore::InspectorResourceAgent::canClearBrowserCache):
(WebCore::InspectorResourceAgent::clearBrowserCache):
(WebCore::InspectorResourceAgent::canClearBrowserCookies):
(WebCore::InspectorResourceAgent::clearBrowserCookies):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::loadResource):

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::resourceStyleSheetText):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):

  • inspector/InspectorTimelineAgent.h:
  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorWorkerAgent::enable):
(WebCore::InspectorWorkerAgent::disable):
(WebCore::InspectorWorkerAgent::canInspectWorkers):
(WebCore::InspectorWorkerAgent::connectToWorker):
(WebCore::InspectorWorkerAgent::disconnectFromWorker):
(WebCore::InspectorWorkerAgent::sendMessageToWorker):
(WebCore::InspectorWorkerAgent::setAutoconnectToWorkers):

  • inspector/InspectorWorkerAgent.h:
  • inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::clearMessages):
(WebCore::PageConsoleAgent::addInspectedNode):

  • inspector/PageConsoleAgent.h:
  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::injectedScriptForEval):
(WebCore::PageDebuggerAgent::setOverlayMessage):

  • inspector/PageDebuggerAgent.h:
  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::willDestroyFrontendAndBackend):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::disable):
(WebCore::PageRuntimeAgent::injectedScriptForEval):

  • inspector/PageRuntimeAgent.h:
  • inspector/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::setMonitoringXHREnabled):

  • inspector/WebConsoleAgent.h:
  • inspector/WorkerConsoleAgent.cpp:

(WebCore::WorkerConsoleAgent::addInspectedNode):

  • inspector/WorkerConsoleAgent.h:
  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::injectedScriptForEval):

  • inspector/WorkerDebuggerAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::resume):

  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::injectedScriptForEval):
(WebCore::WorkerRuntimeAgent::run):

  • inspector/WorkerRuntimeAgent.h:
6:51 PM Changeset in webkit [174139] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Update Install.md for Mavericks and fix typos
​https://bugs.webkit.org/show_bug.cgi?id=137276

Reviewed by Benjamin Poulain.

Add the instruction to copy php.ini to enable the Postgres extension in PHP.

Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.

Finally, init-database.sql is no longer located inside database directory.

  • Install.md:
5:17 PM Changeset in webkit [174138] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[ Windows ] More Windows test gardening to get bots green.

  • platform/win/TestExpectations: More indiscriminate mass skipping.
5:14 PM Changeset in webkit [174137] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Source/WebCore:
Stack overflow with enormous SVG filter
​https://bugs.webkit.org/show_bug.cgi?id=63290

Prevent building an SVG filter if it has more than 200 FilterEffect nodes in its map
regardless whether they will be connected to its lastEffect or not. Also discard any
filter which has more 100 contributing FilterEffect nodes in its tree.

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2014-09-30
Reviewed by Dean Jackson.

Tests: svg/filters/svg-deeply-nested-crash.html

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::collectEffects):
(WebCore::FilterEffect::totalNumberOfEffectInputs):

  • platform/graphics/filters/FilterEffect.h:

-- Add a method to return the total number of input FilterEffect's contributing to a FilterEffect.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):
-- Do not build a filter if it has more than 200 FilterEffects in its map.
(WebCore::RenderSVGResourceFilter::applyResource):
-- Discard a filter after it was built if it has more than 100 FilterEffects in its tree.

LayoutTests:
Stack overflow with enormous SVG filter.
​https://bugs.webkit.org/show_bug.cgi?id=63290.

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2014-09-30
Reviewed by Dean Jackson.

Test if an SVG filter with deeply nested tree of FilterEffects can be loaded
with no crash. Make sure other valid filters can still be referenced by SVG
drawing elements. An SVG Filter will be ignored if the number of effects in
its map is greater than 200 or the total number of effects connected to its
last effect is greater than 100.

  • svg/filters/svg-deeply-nested-crash-expected.txt: Added.
  • svg/filters/svg-deeply-nested-crash.html: Added.
5:11 PM Changeset in webkit [174136] by evab.u-szeged@partner.samsung.com
  • 169 edits
    1 delete in trunk/Tools

Remove thirdparty/unittest2 from webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=137251

Reviewed by Brent Fulgham.

Additionally ordered imports in related webkitpy files and
removed unnecessary shebangs from unittest files.

  • BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
  • Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/config/committers_unittest.py:
  • Scripts/webkitpy/common/config/committervalidator_unittest.py:
  • Scripts/webkitpy/common/config/contributionareas_unittest.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
  • Scripts/webkitpy/common/config/urls_unittest.py:
  • Scripts/webkitpy/common/editdistance_unittest.py:
  • Scripts/webkitpy/common/find_files_unittest.py:
  • Scripts/webkitpy/common/lru_cache_unittest.py:
  • Scripts/webkitpy/common/memoized_unittest.py:
  • Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/net/failuremap_unittest.py:
  • Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/common/net/networktransaction_unittest.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  • Scripts/webkitpy/common/net/statusserver_unittest.py:
  • Scripts/webkitpy/common/net/unittestresults_unittest.py:
  • Scripts/webkitpy/common/newstringio_unittest.py:
  • Scripts/webkitpy/common/prettypatch_unittest.py:
  • Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
  • Scripts/webkitpy/common/system/crashlogs_unittest.py:
  • Scripts/webkitpy/common/system/environment_unittest.py:
  • Scripts/webkitpy/common/system/executive.py: Ordered imports.
  • Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/common/system/file_lock_integrationtest.py:
  • Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
  • Scripts/webkitpy/common/system/logtesting.py:
  • Scripts/webkitpy/common/system/logutils_unittest.py:
  • Scripts/webkitpy/common/system/outputcapture.py:
  • Scripts/webkitpy/common/system/outputcapture_unittest.py:
  • Scripts/webkitpy/common/system/outputtee_unittest.py:
  • Scripts/webkitpy/common/system/path_unittest.py:
  • Scripts/webkitpy/common/system/platforminfo_unittest.py:
  • Scripts/webkitpy/common/system/profiler_unittest.py:
  • Scripts/webkitpy/common/system/stack_utils_unittest.py:
  • Scripts/webkitpy/common/system/user_unittest.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/common/system/zipfileset_unittest.py:
  • Scripts/webkitpy/common/thread/messagepump_unittest.py:
  • Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
  • Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
  • Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
  • Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
  • Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
  • Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
  • Scripts/webkitpy/common/webkitunittest.py:
  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  • Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  • Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
  • Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
  • Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
  • Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
  • Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  • Scripts/webkitpy/performance_tests/perftest_unittest.py:
  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  • Scripts/webkitpy/port/base_unittest.py:
  • Scripts/webkitpy/port/builders_unittest.py:
  • Scripts/webkitpy/port/config_unittest.py:
  • Scripts/webkitpy/port/driver_unittest.py:
  • Scripts/webkitpy/port/efl_unittest.py:
  • Scripts/webkitpy/port/factory_unittest.py:
  • Scripts/webkitpy/port/gtk_unittest.py:
  • Scripts/webkitpy/port/http_lock_unittest.py:
  • Scripts/webkitpy/port/image_diff_unittest.py:
  • Scripts/webkitpy/port/leakdetector_unittest.py:
  • Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
  • Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
  • Scripts/webkitpy/port/mock_drt_unittest.py:
  • Scripts/webkitpy/port/port_testcase.py:
  • Scripts/webkitpy/port/server_process_unittest.py:
  • Scripts/webkitpy/port/westondriver_unittest.py:
  • Scripts/webkitpy/port/win_unittest.py:
  • Scripts/webkitpy/port/xvfbdriver_unittest.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/style/checkers/changelog_unittest.py:
  • Scripts/webkitpy/style/checkers/cmake_unittest.py:
  • Scripts/webkitpy/style/checkers/common_unittest.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
  • Scripts/webkitpy/style/checkers/exportfile_unittest.py:
  • Scripts/webkitpy/style/checkers/js_unittest.py:
  • Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
  • Scripts/webkitpy/style/checkers/messagesin_unittest.py:
  • Scripts/webkitpy/style/checkers/png_unittest.py:
  • Scripts/webkitpy/style/checkers/python_unittest.py:
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  • Scripts/webkitpy/style/checkers/text_unittest.py:
  • Scripts/webkitpy/style/checkers/watchlist_unittest.py:
  • Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
  • Scripts/webkitpy/style/checkers/xml_unittest.py:
  • Scripts/webkitpy/style/error_handlers_unittest.py:
  • Scripts/webkitpy/style/filereader_unittest.py:
  • Scripts/webkitpy/style/filter_unittest.py:
  • Scripts/webkitpy/style/main_unittest.py:
  • Scripts/webkitpy/style/optparser_unittest.py:
  • Scripts/webkitpy/style/patchreader_unittest.py:
  • Scripts/webkitpy/test/finder_unittest.py:
  • Scripts/webkitpy/test/main.py: Ordered imports.
  • Scripts/webkitpy/test/main_unittest.py:
  • Scripts/webkitpy/test/printer.py: Ordered imports.

(Printer.configure):

  • Scripts/webkitpy/test/runner_unittest.py:
  • Scripts/webkitpy/test/skip_unittest.py:
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_irc):
(AutoinstallImportHook._install_unittest2): Deleted.

  • Scripts/webkitpy/thirdparty/init_unittest.py:
  • Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
  • Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
  • Scripts/webkitpy/tool/bot/botinfo_unittest.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:
  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
  • Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/grammar_unittest.py:
  • Scripts/webkitpy/tool/mocktool_unittest.py:
  • Scripts/webkitpy/tool/multicommandtool_unittest.py:
  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  • Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
  • Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/commit_unittest.py:
  • Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
  • Scripts/webkitpy/tool/steps/haslanded_unittest.py:
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
  • Scripts/webkitpy/tool/steps/update_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  • Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
  • Scripts/webkitpy/w3c/test_converter_unittest.py:
  • Scripts/webkitpy/w3c/test_importer_unittest.py:
  • Scripts/webkitpy/w3c/test_parser_unittest.py:
4:42 PM Changeset in webkit [174135] by roger_fong@apple.com
  • 5 edits in trunk/LayoutTests

[ Windows ] More Windows test gardening to get bots green.

  • platform/win/TestExpectations:
  • platform/win/css3/unicode-bidi-isolate-basic-expected.txt:
  • platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
4:32 PM Changeset in webkit [174134] by Beth Dakin
  • 2 edits in trunk/LayoutTests

According to the history, this test has been very flaky. Marking as such.

  • platform/mac/TestExpectations:
4:15 PM Changeset in webkit [174133] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.1.1/Source/JavaScriptCore

Merged r174108. <rdar://problem/18487528>

4:03 PM Changeset in webkit [174132] by Chris Dumez
  • 17 edits in trunk/Source/WebCore

Use is<>() / downcast<>() for ContainerNode
​https://bugs.webkit.org/show_bug.cgi?id=137270

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for ContainerNode instead of isContainerNode()
/ toContainerNode(). Also kill the NODE_TYPE_CASTS() macro as this was
its last user.

No new tests, no behavior change.

  • dom/ContainerNode.cpp:

(WebCore::collectChildrenAndRemoveFromOldParent):
(WebCore::ContainerNode::willRemoveChild):
(WebCore::cloneChildNodesAvoidingDeleteButton):

  • dom/ContainerNode.h:

(WebCore::Node::countChildNodes):
(WebCore::Node::traverseToChildAt):
(WebCore::Node::firstChild):
(WebCore::Node::lastChild):
(isType):
(WebCore::isContainerNode): Deleted.

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notify):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notify):

  • dom/Node.cpp:

(WebCore::Node::childNodes):
(WebCore::Node::insertBefore):
(WebCore::Node::replaceChild):
(WebCore::Node::removeChild):
(WebCore::Node::appendChild):
(WebCore::Node::setTextContent):

  • dom/Node.h:
  • dom/Range.cpp:

(WebCore::Range::surroundContents):

  • dom/TextNodeTraversal.cpp:

(WebCore::TextNodeTraversal::contentsAsString):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyBlockStyle):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::insertNodeAt):

  • editing/Editor.cpp:

(WebCore::correctSpellcheckingPreservingTextCheckingParagraph):

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

  • html/parser/HTMLConstructionSite.h:

(WebCore::HTMLConstructionSiteTask::oldParent):

  • html/track/VTTCue.cpp:

(WebCore::VTTCue::copyWebVTTNodeToDOMTree):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::querySelector):
(WebCore::InspectorDOMAgent::querySelectorAll):

  • inspector/InspectorNodeFinder.cpp:

(WebCore::InspectorNodeFinder::searchUsingCSSSelectors):

3:59 PM Changeset in webkit [174131] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.1.1/Source

Versioning.

3:58 PM Changeset in webkit [174130] by commit-queue@webkit.org
  • 12 edits in trunk/Tools

LayoutTestResults and ExpectedFailures should know about the
interrupted flag from the json results file
​https://bugs.webkit.org/show_bug.cgi?id=137229

Patch by Jake Nielsen <​jacob_nielsen@apple.com> on 2014-09-30
Reviewed by Daniel Bates.

Changes LayoutTestResults to use the interrupted flag instead of
counting failures.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(BuilderTest._install_fetch_build._mock_fetch_build):
(BuilderTest.test_latest_layout_test_results):

  • Scripts/webkitpy/common/net/layouttestresults.py:

Removes notion of failure_limit_count, and adds
did_exceed_test_failure_limit.

(LayoutTestResults.results_from_string):
(LayoutTestResults.init):
(LayoutTestResults.did_exceed_test_failure_limit):
(LayoutTestResults): Deleted.
(LayoutTestResults.set_failure_limit_count): Deleted.
(LayoutTestResults.failure_limit_count): Deleted.

  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:

Removes unit test for failure_limit_count logic.

(LayoutTestResultsTest.test_set_failure_limit_count): Deleted.

  • Scripts/webkitpy/common/net/resultsjsonparser.py:

Instead of providing a class method that returns a list of
TestResults objects, resultsjsonparser now provides a class
ParsedJSONResults that serves as an interface between the results.json
file and the rest of webkitpy.

(ParsedJSONResults):
(ParsedJSONResults.init):
(ParsedJSONResults.did_exceed_test_failure_limit):
(ParsedJSONResults.test_results):
(ResultsJSONParser): Deleted.
(ResultsJSONParser.parse_results_json): Deleted.

  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:

Updates the unit test so that it can test the new ResultsJSONParser
class.

(ParsedJSONResultsTest):
(test_basic):
(ResultsJSONParserTest): Deleted.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

Updates the unit test to instantiate ResultsJSONParser objects rather
than simple lists of TestResult objects.

(MockCommitQueue.test_results):
(FailingTestCommitQueue.test_results):
(test_flaky_test_failure):
(test_failed_archive):

  • Scripts/webkitpy/tool/bot/expectedfailures.py:

Updates ExpectedFailures to use the did_exceed_test_failure_limit
method rather than counting the number of failed tests.

(ExpectedFailures._should_trust):

  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:

Updates MockResults to more closely resemble the updated
LayoutTestResults class.

(MockResults.init):
(MockResults.did_exceed_test_failure_limit):
(ExpectedFailuresTest.test_can_trust_results):
(ExpectedFailuresTest.test_unexpected_failures_observed):
(ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
(MockResults.failure_limit_count): Deleted.

  • Scripts/webkitpy/tool/bot/layouttestresultsreader.py:

Removes a FIXME regarding the use of the
NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.

(LayoutTestResultsReader.results):

  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:

Updates test to not check the now-nonexistant failure_count_limit
method.

(test_missing_unit_test_results_path):
(test_layout_test_results):

  • Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

Accounts for name change: ResultsJSONParserTest ->
ParsedJSONParserTest.

(RebaselineTestTest.test_gather_baselines):

3:56 PM Changeset in webkit [174129] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.1.1

New tag.

3:54 PM Changeset in webkit [174128] by gyuyoung.kim@samsung.com
  • 9 edits in trunk

[EFL] Rename TEST_THEME_DIR macro
​https://bugs.webkit.org/show_bug.cgi?id=137244

Reviewed by Csaba Osztrogonác.

.:

  • Source/cmake/OptionsEfl.cmake: Rename TEST_THEME_DIR to DEFAULT_THEME_DIR.

Source/WebKit2:

TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
DEFAULT_THEME_DIR is better than it.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::defaultTheme):
(EWK2UnitTest::EWK2UnitTestEnvironment::pathForTheme):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools:

TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
DEFAULT_THEME_DIR is better than it.

  • MiniBrowser/efl/main.c:

(window_create):

  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):

3:50 PM Changeset in webkit [174127] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Windows] Remove an errant WTFLogAlways that makes test output hard to read and generates stderr output.

  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didFinishLoading):

3:12 PM Changeset in webkit [174126] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Remove a multicolumn ASSERT and replace with a guard.
​https://bugs.webkit.org/show_bug.cgi?id=137272

Reviewed by Alexey Proskuryakov.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
For now remove the assert that is tripping and replace it with a guard
until we can figure out why it's getting hit.

2:32 PM Changeset in webkit [174125] by Chris Dumez
  • 70 edits
    1 add in trunk/Source

Generalize is<>() / downcast<>() support to all types
​https://bugs.webkit.org/show_bug.cgi?id=137243

Reviewed by Benjamin Poulain.

Generalize is<>() / downcast<>() support to all types, not just Nodes.
Source/WebCore:

To achieve this, the following changes were made:

  • Move is<> / downcast<>() and NodeTypeCastTraits from Node.h to a new wtf/TypeCasts.h header. Also move them to WTF namespace instead of WebCore namespace as they can be used for classes in other namespaces (e.g. WebKit namespace).
  • Rename NodeTypeCastsTraits to TypeCastTraits as it can be specialized for non-Nodes.
  • Since C++ does not allow template specializations in different namespaces, I had to move all the SPECIALIZE_TYPE_TRAITS_*() uses to
the global scope and use the WebCore
namespace explicitly in those. This is a bit unfortunate but I couldn't find a better way.

This patch also takes care of supporting is<>() / downcast<>() for
the WorkerGlobalScope class, which does not derive from Node.

No new tests, no behavior change.

  • Modules/indexeddb/IDBFactory.cpp:
  • Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp:

(WebCore::WorkerGlobalScopeIndexedDatabase::from):

  • Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::create):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::toJSDOMGlobalObject):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • dom/Attr.h:

(isType):
(WebCore::isAttr): Deleted.

  • dom/CDATASection.h:

(isType):
(WebCore::isCDATASection): Deleted.

  • dom/CharacterData.h:

(isType):
(WebCore::isCharacterData): Deleted.

  • dom/Comment.h:

(isType):
(WebCore::isComment): Deleted.

  • dom/Document.h:

(isType):
(WebCore::isDocument): Deleted.

  • dom/DocumentFragment.h:

(isType):
(WebCore::isDocumentFragment): Deleted.

  • dom/DocumentType.h:

(isType):
(WebCore::isDocumentType): Deleted.

  • dom/Element.h:
  • dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchMessages):

  • dom/Node.h:

(WebCore::is): Deleted.
(WebCore::downcast): Deleted.

  • dom/ProcessingInstruction.h:

(isType):
(WebCore::isProcessingInstruction): Deleted.

  • dom/PseudoElement.h:

(isType):
(WebCore::isPseudoElement): Deleted.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createdMessagePort):
(WebCore::ScriptExecutionContext::destroyedMessagePort):
(WebCore::ScriptExecutionContext::vm):

  • dom/ScriptExecutionContext.h:
  • dom/ShadowRoot.h:

(isType):
(WebCore::isShadowRoot): Deleted.

  • dom/StyledElement.h:

(isType):
(WebCore::isStyledElement): Deleted.

  • dom/Text.h:

(isType):
(WebCore::isText): Deleted.

  • dom/make_names.pl:

(printTypeHelpers):
(printTypeHelpersHeaderFile):

  • html/HTMLDocument.h:

(isType):
(WebCore::isHTMLDocument): Deleted.

  • html/HTMLElement.h:

(isType):
(WebCore::isHTMLElement): Deleted.

  • html/HTMLFormControlElement.h:

(isType):
(WebCore::isHTMLFormControlElement): Deleted.

  • html/HTMLFrameElementBase.h:

(isType):
(WebCore::isHTMLFrameElementBase): Deleted.

  • html/HTMLFrameOwnerElement.h:

(isType):
(WebCore::isHTMLFrameOwnerElement): Deleted.

  • html/HTMLMediaElement.h:

(isType):
(WebCore::isHTMLMediaElement): Deleted.

  • html/HTMLPlugInElement.h:

(isType):
(WebCore::isHTMLPlugInElement): Deleted.

  • html/HTMLPlugInImageElement.h:

(isType):
(WebCore::isHTMLPlugInImageElement): Deleted.

  • html/HTMLTableCellElement.h:

(isType):
(WebCore::isHTMLTableCellElement): Deleted.

  • html/HTMLTableSectionElement.h:

(isType):
(WebCore::isHTMLTableSectionElement): Deleted.

  • html/HTMLTextFormControlElement.h:

(isType):
(WebCore::isHTMLTextFormControlElement): Deleted.

  • html/ImageDocument.h:

(isType):
(WebCore::isImageDocument): Deleted.

  • html/LabelableElement.h:

(isType):
(WebCore::isLabelableElement): Deleted.

  • html/MediaDocument.h:

(isType):
(WebCore::isMediaDocument): Deleted.

  • html/PluginDocument.h:

(isType):
(WebCore::isPluginDocument): Deleted.

  • html/shadow/InsertionPoint.h:

(isType):
(WebCore::isInsertionPoint): Deleted.

  • html/shadow/TextControlInnerElements.h:

(isType):
(WebCore::isTextControlInnerTextElement): Deleted.

  • html/track/WebVTTElement.h:

(isType):
(WebCore::isWebVTTElement): Deleted.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):

  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeRequestFromCache):
(WebCore::MemoryCache::removeRequestFromSessionCaches):

  • mathml/MathMLElement.h:

(isType):
(WebCore::isMathMLElement): Deleted.

  • svg/SVGAnimateElementBase.h:

(isType):
(WebCore::isSVGAnimateElementBase): Deleted.

  • svg/SVGDocument.h:

(isType):
(WebCore::isSVGDocument): Deleted.

  • svg/SVGElement.h:

(isType):
(WebCore::isSVGElement): Deleted.

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(isType):
(WebCore::isSVGFilterPrimitiveStandardAttributes): Deleted.

  • svg/SVGGradientElement.h:

(isType):
(WebCore::isSVGGradientElement): Deleted.

  • svg/SVGGraphicsElement.h:

(isType):
(WebCore::isSVGGraphicsElement): Deleted.

  • svg/SVGPolyElement.h:

(isType):
(WebCore::isSVGPolyElement): Deleted.

  • svg/SVGTextContentElement.h:

(isType):
(WebCore::isSVGTextContentElement): Deleted.

  • svg/animation/SVGSMILElement.h:

(isType):
(WebCore::isSVGSMILElement): Deleted.

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::close):

  • workers/WorkerGlobalScope.h:

(isType):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadSynchronously):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::stop):

Source/WebKit/win:

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:

(-[WKDOMDocument createElement:]):
(-[WKDOMDocument createTextNode:]):
(-[WKDOMDocument body]):

  • WebProcess/InjectedBundle/API/mac/WKDOMText.mm:

(-[WKDOMText data]):
(-[WKDOMText setData:]):

Source/WTF:

  • wtf/Assertions.h:
  • wtf/TypeCasts.h: Added.

(WTF::is):
(WTF::downcast):

2:30 PM Changeset in webkit [174124] by ap@apple.com
  • 3 edits in trunk/Tools

Windows EWS went purple when it failed to build
​https://bugs.webkit.org/show_bug.cgi?id=137267

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/app.yaml: Update the version.
  • QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):

Make it work for style and win-ews queues.

2:11 PM Changeset in webkit [174123] by fpizlo@apple.com
  • 2 edits
    1 move
    20 adds in trunk

It should be fun and easy to run every possible JavaScript benchmark from the command line
​https://bugs.webkit.org/show_bug.cgi?id=137245

Reviewed by Oliver Hunt.

PerformanceTests:

This adds the scaffolding for running Octane version 2 inside run-jsc-benchmarks.
In the future we should just land Octane2 in this directory, and run-jsc-benchmarks
should be changed to point directly at this directory instead of requiring the
Octane path to be configured as part of the configuration file.

  • Octane: Added.
  • Octane/wrappers: Added.
  • Octane/wrappers/jsc-box2d.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-boyer.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-closure.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-decrypt.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-deltablue.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-earley.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-encrypt.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-gbemu.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-jquery.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-mandreel.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-navier-stokes.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-pdfjs.js: Added.

(jscSetUp.PdfJS_window.console.log):
(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-raytrace.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-regexp.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-richards.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-splay.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-typescript.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

  • Octane/wrappers/jsc-zlib.js: Added.

(jscSetUp):
(jscTearDown):
(jscRun):

Tools:

We previously had Tools/Scripts/bencher. Then we stopped adding things to it because we
weren't sure about the licensing of things like Kraken and Octane. Various people ended up
having their own private scripts for doing benchmark runs, and didn't share them in the open
source community, because of fears about the shady licensing of the benchmarks suites that
they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
but some of them are. The non-public tests are exclusively those that were not made by any
WebKit contributor, but which JSC/WebKit devs found useful for testing.

This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
checked into WebKit svn at all) can be run by passing the path to them via a configuration
file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
probably never be checked in because there is no license text anywhere in that benchmark.
A valid ~/.run-jsc-benchmarks file will just be something like:

{

"OctanePath": "/path/to/Octane2",
"KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"

}


If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
run-jsc-benchmarks will just gracefully avoid running that test suite.

Finally, a word about policy: it is understood that different organizations that do
development on JSC may find themselves having internal benchmarks that they cannot share
because of weird licensing. It happens - usually because the organization doing JSC
development found some test in the wild that is owned by someone else and therefore cannot
be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
that add support for some new kind of benchmark suite even if the suite is not made public
as part of the same patch - so long as the patch isn't too invasive. An example of
non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
completely open-sourced and committed to the WebKit repo - but the reality is that this
can't always be done safely.

  • Scripts/bencher: Removed.
  • Scripts/run-jsc-benchmarks: Added.
2:05 PM Changeset in webkit [174122] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Label some asserts as having security implications.
<​https://webkit.org/b/137260>

Reviewed by Filip Pizlo.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::handleAssertionFailure):

  • runtime/JSCell.h:

(JSC::jsCast):

  • runtime/StructureIDTable.h:

(JSC::StructureIDTable::get):

2:02 PM Changeset in webkit [174121] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r174025): Invalid cast in JSC::asString
​https://bugs.webkit.org/show_bug.cgi?id=137224

Reviewed by Geoffrey Garen.

Store barrier elision in fixup depends on checking the type of the value being stored. It's very important that
when we speak of "the value being stored" we are really referring to the right value.

The bug here was that the PutClosureVar case was assuming that child2 is the value being stored. It's actually
child3. So we were incorrectly removing all barriers from PutClosureVar.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

1:36 PM Changeset in webkit [174120] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Back to 2 child processes for NRWT on Windows.

  • Scripts/webkitpy/port/win.py:

(WinPort.default_child_processes):
Changing the number of processes to 1 did not have an effect on the layout test results.
It does introduce an issue with one of the workers hanging indefinitely and causing the
layout tests to timeout as a whole occasionally, but we should just fix that.

1:32 PM Changeset in webkit [174119] by roger_fong@apple.com
  • 3 edits in trunk/LayoutTests

[ Windows ] More Windows test gardening to get bots green.

  • platform/win/TestExpectations:
  • platform/win/fast/dom/navigator-detached-no-crash-expected.txt:
12:59 PM Changeset in webkit [174118] by ap@apple.com
  • 2 edits in trunk/Tools

Remove an accidentally committed line..

  • QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble):

12:59 PM Changeset in webkit [174117] by Chris Dumez
  • 108 edits in trunk/Source

Use is<>() / downcast<>() for Element
​https://bugs.webkit.org/show_bug.cgi?id=137241

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for Element instead of isElementNode() /
toElement().

Source/WebCore:

No new tests, no behavior change.

  • accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):
(WebCore::createFromRenderer):
(WebCore::AXObjectCache::handleLiveRegionCreated):
(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::AXObjectCache::rootAXEditableElement):
(WebCore::isNodeAriaVisible):

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::canSetFocusAttribute):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
(WebCore::AccessibilityNodeObject::isEnabled):
(WebCore::AccessibilityNodeObject::isPressed):
(WebCore::AccessibilityNodeObject::isHovered):
(WebCore::AccessibilityNodeObject::anchorElement):
(WebCore::nativeActionElement):
(WebCore::AccessibilityNodeObject::actionElement):
(WebCore::AccessibilityNodeObject::mouseButtonListener):
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::helpText):
(WebCore::AccessibilityNodeObject::hierarchicalLevel):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::text):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press):
(WebCore::AccessibilityObject::hasTagName):
(WebCore::AccessibilityObject::hasAttribute):
(WebCore::AccessibilityObject::element):
(WebCore::AccessibilityObject::classList):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
(WebCore::AccessibilityRenderObject::titleUIElement):
(WebCore::AccessibilityRenderObject::accessKey):
(WebCore::AccessibilityRenderObject::setElementAttributeValue):
(WebCore::AccessibilityRenderObject::setFocused):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
(WebCore::AccessibilityRenderObject::renderObjectIsObservable):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
(WebCore::AccessibilityRenderObject::setAccessibleName):
(WebCore::AccessibilityRenderObject::stringRoleForMSAA):

  • accessibility/AccessibilitySearchFieldButtons.cpp:

(WebCore::AccessibilitySearchFieldCancelButton::press):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::styledNode):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::locateCousinList):

  • dom/ContainerNode.cpp:

(WebCore::destroyRenderTreeIfNeeded):
(WebCore::ContainerNode::notifyChildRemoved):

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):
(WebCore::assertConnectedSubrameCountIsConsistent):

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::elementFromPoint):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Element.cpp:

(WebCore::Element::computeInheritedLanguage):

  • dom/Element.h:

(WebCore::isElement):
(WebCore::Node::hasAttributes):
(WebCore::Node::attributes):
(WebCore::Node::parentElement):

  • dom/ElementTraversal.h:

(WebCore::Traversal<Element>::nextTemplate):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::namedItem):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::normalize):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):
(WebCore::Node::computedStyle):
(WebCore::Node::parentOrShadowHostElement):
(WebCore::Node::rootEditableElement):
(WebCore::Node::isEqualNode):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespacePrefix):
(WebCore::Node::ancestorElement):
(WebCore::appendAttributeDesc):
(WebCore::Node::showNodePathForThis):
(WebCore::Node::enclosingLinkEventParentOrSelf):
(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):

  • dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::nodeCanBeDistributed):

  • dom/Position.cpp:

(WebCore::Position::element):

  • dom/Range.cpp:

(WebCore::Range::getBorderAndTextQuads):

  • dom/ShadowRoot.h:

(WebCore::Node::shadowRoot):

  • dom/StaticNodeList.cpp:

(WebCore::StaticNodeList::namedItem):

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):

  • editing/ApplyStyleCommand.cpp:

(WebCore::dummySpanAncestorForNode):
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::isRemovableBlock):
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
(WebCore::CompositeEditCommand::moveParagraphs):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):

  • editing/Editor.cpp:

(WebCore::Editor::isSpellCheckingEnabledFor):
(WebCore::Editor::applyEditingStyleToBodyElement):

  • editing/FormatBlockCommand.cpp:

(WebCore::isElementForFormatBlock):
(WebCore::FormatBlockCommand::elementForFormatBlockCommand):

  • editing/FrameSelection.cpp:

(WebCore::removingNodeRemovesPosition):
(WebCore::CaretBase::paintCaret):
(WebCore::FrameSelection::debugRenderer):

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentParagraph):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):
(WebCore::MarkupAccumulator::appendStartMarkup):

  • editing/MarkupAccumulator.h:

(WebCore::MarkupAccumulator::appendEndTag):

  • editing/ModifySelectionListLevel.cpp:

(WebCore::IncreaseSelectionListLevelCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::isMailPasteAsQuotationNode):
(WebCore::haveSameTagName):
(WebCore::handleStyleSpansBeforeInsertion):
(WebCore::ReplaceSelectionCommand::doApply):

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::isCheckable):

  • editing/SplitTextNodeContainingElementCommand.cpp:

(WebCore::SplitTextNodeContainingElementCommand::doApply):

  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::propertyValueForNode):
(HTMLConverterCaches::floatPropertyValueForNode):
(HTMLConverterCaches::colorPropertyValueForNode):
(HTMLConverter::aggregatedAttributesForAncestors):
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors):
(HTMLConverter::_traverseNode):
(WebCore::editingAttributedStringFromRange):

  • editing/htmlediting.cpp:

(WebCore::unsplittableElementForPosition):
(WebCore::enclosingBlock):
(WebCore::enclosingElementWithTag):
(WebCore::enclosingTableCell):
(WebCore::enclosingAnchorElement):
(WebCore::areIdenticalElements):
(WebCore::isNonTableCellHTMLBlockElement):
(WebCore::deprecatedEnclosingBlockFlowElement):
(WebCore::rendererForCaretPainting):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::wrapWithNode):
(WebCore::createMarkupInternal):
(WebCore::createFragmentFromText):

  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsSummaryElement::fallbackSummary):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::insertAdjacentElement):
(WebCore::contextElementForInsertion):
(WebCore::HTMLElement::directionality):

  • html/HTMLFormControlElement.h:

(WebCore::isHTMLFormControlElement):

  • html/HTMLMediaElement.h:

(WebCore::isHTMLMediaElement):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::collectOptionInnerText):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::removedFrom):

  • html/HTMLSummaryElement.cpp:

(WebCore::isClickableControl):

  • html/HTMLTextFormControlElement.h:

(WebCore::isHTMLTextFormControlElement):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attachLater):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::htmlElement):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::element):

  • html/shadow/InsertionPoint.h:

(WebCore::parentElementForDistribution):
(WebCore::shadowRootOfParentForDistribution):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler):

  • html/track/VTTCue.cpp:

(WebCore::VTTCue::markFutureAndPastNodes):

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore::DOMPatchSupport::createDigest):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::elementForId):
(WebCore::InspectorCSSAgent::buildArrayForRegions):
(WebCore::InspectorCSSAgent::resetPseudoStates):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::assertElement):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
(WebCore::InspectorDOMAgent::didInvalidateStyleAttr):

  • inspector/InspectorNodeFinder.cpp:

(WebCore::InspectorNodeFinder::searchUsingDOMTreeTraversal):

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementInfo):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

  • page/DragController.cpp:

(WebCore::elementUnderMouse):

  • page/EventHandler.cpp:

(WebCore::findDropZone):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::updateMouseEventTargetNode):

  • page/FocusController.cpp:

(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost):
(WebCore::isFocusableShadowHost):
(WebCore::adjustedTabIndex):
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::findElementWithExactTabIndex):
(WebCore::nextElementWithGreaterTabIndex):
(WebCore::previousElementWithLowerTabIndex):
(WebCore::FocusController::nextFocusableElement):
(WebCore::FocusController::previousFocusableElement):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::title):
(WebCore::HitTestResult::innerTextIfTruncated):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::innerElement):
(WebCore::HitTestResult::innerNonSharedElement):

  • rendering/RenderDeprecatedFlexibleBox.h:
  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::isOpen):

  • rendering/RenderElement.h:

(WebCore::RenderElement::element):
(WebCore::RenderElement::nonPseudoElement):
(WebCore::RenderElement::generatingElement):

  • rendering/RenderGrid.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::isRestartedPlugin):

  • rendering/RenderListItem.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::isChildAllowed):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect):
(WebCore::RenderObject::updateDragState):
(WebCore::RenderObject::getUncachedPseudoStyle):

  • rendering/RenderRuby.h:
  • rendering/RenderRubyText.h:
  • rendering/RenderTableCaption.h:
  • rendering/RenderTableCol.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isEnabled):
(WebCore::RenderTheme::isFocused):
(WebCore::RenderTheme::isPressed):
(WebCore::RenderTheme::isSpinUpButtonPartPressed):
(WebCore::RenderTheme::isReadOnlyControl):
(WebCore::RenderTheme::isHovered):
(WebCore::RenderTheme::isSpinUpButtonPartHovered):

  • rendering/RenderThemeGtk.cpp:

(WebCore::nodeHasClass):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::updatePressedState):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isAutosizingContainer):
(WebCore::TextAutosizer::containerContainsOneOfTags):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::isChildAllowed):

  • style/StyleResolveTree.cpp:

(WebCore::Style::attachChildren):
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::detachDistributedChildren):
(WebCore::Style::detachChildren):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::resolveTree):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunLang::evaluate):

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

  • xml/XPathStep.cpp:

(WebCore::XPath::nodeMatchesBasicTest):
(WebCore::XPath::Step::nodesInAxis):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::endElementNs):

Source/WebKit/mac:

  • WebView/WebRenderLayer.mm:

(+[WebRenderLayer nameForLayer:]):

Source/WebKit/win:

  • DOMEventsClasses.cpp:

(DOMMouseEvent::toElement):

  • DOMEventsClasses.h:

Source/WebKit2:

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

  • WebProcess/InjectedBundle/API/mac/WKDOMElement.mm:

(-[WKDOMElement hasAttribute:]):
(-[WKDOMElement getAttribute:]):
(-[WKDOMElement setAttribute:value:]):
(-[WKDOMElement tagName]):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::elementBounds):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::mediaType):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
(WebKit::WebPage::blurAssistedNode):
(WebKit::WebPage::getPositionInformation):
(WebKit::nextFocusableElement):
(WebKit::WebPage::elementDidFocus):

12:50 PM Changeset in webkit [174116] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Get the STRING_STATS codepath compiling again, and add calls to ref/deref
​https://bugs.webkit.org/show_bug.cgi?id=137259

Reviewed by Andreas Kling.

  • wtf/text/StringImpl.cpp:

(WTF::StringStats::removeString):
(WTF::StringStats::printStats):
(WTF::StringImpl::~StringImpl):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::isSubString):
(WTF::StringImpl::ref):
(WTF::StringImpl::deref):
(WTF::StringStats::addUpconvertedString): Deleted.

12:48 PM Changeset in webkit [174115] by ap@apple.com
  • 6 edits in trunk/Tools

build.webkit.org/dashboard: Switch EWS view to using actual retry count
​https://bugs.webkit.org/show_bug.cgi?id=137240

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:

(EWSQueue.prototype.loadDetailedStatus):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:

(EWSQueueView.prototype._popoverContentForEWSQueue):
Use the new retry_count data member from JSON.

  • QueueStatusServer/app.yaml: Updating the version.
  • QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):

Instead of message_count, produce retry_count.

12:43 PM Changeset in webkit [174114] by ap@apple.com
  • 4 edits in trunk/Tools

EWS doesn't need to show all the bubbles when a patch fails to apply
​https://bugs.webkit.org/show_bug.cgi?id=137256

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/app.yaml: Updated app version.
  • QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble):
(StatusBubble._build_bubbles_for_attachment):
(StatusBubble.get):

  • QueueStatusServer/templates/statusbubble.html:

When some queues fail to apply, and no queues had meaningful output (meaning that
they will almost certainly fail to apply later), we can show a single bubble
telling the user just that.

12:21 PM Changeset in webkit [174113] by Brian Burg
  • 34 edits
    2 deletes in trunk/Source

Web Replay: use static Strings instead of AtomicStrings for replay input type tags
​https://bugs.webkit.org/show_bug.cgi?id=137086

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

This pattern doesn't work when we want to define some inputs in WebKit2.
The ReplayInputTypes class was generated from WebCore inputs only. This
patch moves all input traits to use static local Strings as type tags.

  • replay/scripts/CodeGeneratorReplayInputs.py: Remove configuration of how

type tags are generated, since all framework targets now generate the same code.

  • replay/NondeterministicInput.h:
  • replay/scripts/CodeGeneratorReplayInputs.py: Simplify and rebase test results.

(Generator.generate_input_trait_implementation):

  • replay/scripts/CodeGeneratorReplayInputsTemplates.py: Simplify templates.
  • replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.cpp:

(JSC::InputTraits<Test::SavedMouseButton>::type):

  • replay/scripts/tests/expected/generate-enum-encoding-helpers-with-guarded-values.json-TestReplayInputs.h:
  • replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.cpp:

(JSC::InputTraits<Test::SavedMouseButton>::type):

  • replay/scripts/tests/expected/generate-enum-encoding-helpers.json-TestReplayInputs.h:
  • replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.cpp:

(JSC::InputTraits<Test::HandleWheelEvent>::type):

  • replay/scripts/tests/expected/generate-enum-with-guard.json-TestReplayInputs.h:
  • replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.cpp:

(JSC::InputTraits<Test::FormCombo>::type):

  • replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.h:
  • replay/scripts/tests/expected/generate-input-with-guard.json-TestReplayInputs.cpp:

(JSC::InputTraits<Test::GetCurrentTime>::type):
(JSC::InputTraits<Test::SetRandomSeed>::type):

  • replay/scripts/tests/expected/generate-input-with-guard.json-TestReplayInputs.h:
  • replay/scripts/tests/expected/generate-input-with-vector-members.json-TestReplayInputs.cpp:

(JSC::InputTraits<Test::ArrayOfThings>::type):
(JSC::InputTraits<Test::SavedHistory>::type):

  • replay/scripts/tests/expected/generate-input-with-vector-members.json-TestReplayInputs.h:
  • replay/scripts/tests/expected/generate-inputs-with-flags.json-TestReplayInputs.cpp:

(JSC::InputTraits<Test::ScalarInput1>::type):
(JSC::InputTraits<Test::ScalarInput2>::type):

  • replay/scripts/tests/expected/generate-inputs-with-flags.json-TestReplayInputs.h:
  • replay/scripts/tests/expected/generate-memoized-type-modes.json-TestReplayInputs.cpp:

(JSC::InputTraits<Test::ScalarInput>::type):
(JSC::InputTraits<Test::MapInput>::type):

  • replay/scripts/tests/expected/generate-memoized-type-modes.json-TestReplayInputs.h:

Source/WebCore:

This pattern doesn't work when we want to define some inputs in WebKit2,
since the ReplayInputTypes class is generated from WebCore inputs only.

Replace tag-checking uses of ReplayInputTypes with InputTraits<T>::type().
Remove thread-local input types, and switch to using a plain const String instead
of const AtomicString.

No new tests, no behavior changed.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorReplayAgent.cpp:

(WebCore::SerializeInputToJSONFunctor::operator()):

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::inputTypes): Deleted.

  • replay/AllReplayInputs.h:
  • replay/EventLoopInput.h:
  • replay/EventLoopInputDispatcher.cpp:

(WebCore::EventLoopInputDispatcher::dispatchInput):

  • replay/MemoizedDOMResult.cpp:

(WebCore::MemoizedDOMResultBase::type):
(JSC::InputTraits<MemoizedDOMResultBase>::type):

  • replay/MemoizedDOMResult.h:
  • replay/ReplayInputTypes.cpp: Removed.
  • replay/ReplayInputTypes.h: Removed.
  • replay/ReplayingInputCursor.cpp:

(WebCore::ReplayingInputCursor::loadInput):

  • replay/SegmentedInputStorage.cpp:

(WebCore::SegmentedInputStorage::load):
(WebCore::SegmentedInputStorage::store):

  • replay/SerializationMethods.cpp:

(JSC::EncodingTraits<NondeterministicInputBase>::encodeValue):
(JSC::EncodingTraits<NondeterministicInputBase>::decodeValue):

12:11 PM Changeset in webkit [174112] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Flaky test marked as failing in r174111 also needs to be marked as passing.

  • platform/mac/TestExpectations:
12:05 PM Changeset in webkit [174111] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Mark a flaky webgl conformance test as failing.

  • platform/mac/TestExpectations:
11:40 AM Changeset in webkit [174110] by dbates@webkit.org
  • 9 edits
    1 copy
    2 adds in trunk/Source

REGRESSION (r172532): JSBase.h declares NSMapTable functions that are SPI
​https://bugs.webkit.org/show_bug.cgi?id=137170
<rdar://problem/18477384>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Move conditional include of header Foundation/NSMapTablePriv.h and forward declarations
of NSMapTable SPI from file JavaScriptCore/API/JSBase.h to WTF/wtf/spi/cocoa/NSMapTableSPI.h.

  • API/JSBase.h:
  • API/JSManagedValue.mm: Include header WTF/wtf/spi/cocoa/NSMapTableSPI.h.
  • API/JSVirtualMachine.mm: Ditto.
  • API/JSVirtualMachineInternal.h: Forward declare class NSMapTable.
  • API/JSWrapperMap.mm: Include header WTF/wtf/spi/cocoa/NSMapTableSPI.h. Also, order

#include directives such that they are sorted in alphabetical order.

Source/WTF:

Add SPI wrapper header, NSMapTableSPI.h.

Additionally, define convenience macro EXTERN_C that can be used to specify the C linkage
convention for a declaration. For example, the declaration "EXTERN_C const int x;" will
expand to:

extern const int x;

and

extern "C" const int x;

when used in a C and C++ file, respectively.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/Compiler.h:
  • wtf/spi/cocoa/NSMapTableSPI.h: Added.
11:37 AM Changeset in webkit [174109] by ggaren@apple.com
  • 10 edits in trunk/Source/bmalloc

bmalloc: cleaned up fast path vs slow path
​https://bugs.webkit.org/show_bug.cgi?id=137081

Reviewed by Sam Weinig.

Might be a 1% speedup on MallocBench. Also cleans up the code a bit.

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::Allocator): Merged the small and medium range
caches, just like the small and medium allocators. Ranges are abstract
objects that don't really care whether they hold small or medium objects,
so they don't need to be segregated.

(bmalloc::Allocator::scavenge): Ditto.

(bmalloc::Allocator::allocateBumpRangeSlowCase):
(bmalloc::Allocator::allocateBumpRange): Same thing here, except that
we do care a tiny bit, because we need to specify small vs medium when
allocating new ranges from the heap, to ensure that the heap allocates
from the right segment of VM.

(bmalloc::Allocator::allocateLarge):
(bmalloc::Allocator::allocateXLarge): NO_INLINE because this was clouding
up the fast path. Large allocation performance is dominated by allocation
logic and initialization, so inlining it doesn't help.

(bmalloc::Allocator::allocateSlowCase): Slow path got a bit cleaner since
it doesn't need to distinguish small vs medium objects.

(bmalloc::Allocator::allocateSmallBumpRange): Deleted.
(bmalloc::Allocator::allocateMediumBumpRange): Deleted.

  • bmalloc/Allocator.h:
  • bmalloc/BumpRange.h:
  • bmalloc/Cache.cpp:

(bmalloc::Cache::allocateSlowCase): Deleted.
(bmalloc::Cache::deallocateSlowCase): Deleted.

  • bmalloc/Cache.h:

(bmalloc::Cache::allocate):
(bmalloc::Cache::deallocate):
(bmalloc::Cache::allocateFastCase): Deleted.
(bmalloc::Cache::deallocateFastCase): Deleted. Removed the Cache slow
paths. The downside to this change is that the fast path branches to two
distinct failure cases instead of one. The upside is that the slow path
doesn't need to re-read the segment register, which is not as cheap as a
normal register, and it doesn't need to do an extra level of function
call. Seems to be worth it.

  • bmalloc/Deallocator.h:
  • bmalloc/Heap.cpp:

(bmalloc::Heap::refillSmallBumpRangeCache):
(bmalloc::Heap::refillMediumBumpRangeCache):

  • bmalloc/Heap.h: Updated for interface changes.
  • bmalloc/Sizes.h: The most ranges a cache will hold is the number of

small lines in a page / 2, since any other free lines will coalesce
with their neighbors.

10:27 AM Changeset in webkit [174108] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix C API header
​https://bugs.webkit.org/show_bug.cgi?id=137254
<rdar://problem/18487528>

Build fix

Guard extern "C" behind cplusplus ifdef

  • API/JSBase.h:
8:19 AM Changeset in webkit [174107] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/Tools

[EFL] Bump EFL version to 1.11.2
​https://bugs.webkit.org/show_bug.cgi?id=137118

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-09-30
Reviewed by Gyuyoung Kim.

Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.

  • efl/jhbuild.modules:
  • efl/patches/ecore.patch: Removed.
7:30 AM Changeset in webkit [174106] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[Mac] MediaPlayerPrivateQTKit should not use FrameView
​https://bugs.webkit.org/show_bug.cgi?id=137119

Reviewed by Carlos Garcia Campos.

Remove obsolete QTKit code that would fall back to rendering into an NSView.
Aside from being dead code, it was only used when accelerated compositing
was not enabled and tha hasn't been possible for a long time, it required a
layering violation to get the FrameView.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::currentRenderingMode):
(WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
(WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::hasSetUpVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::setSize):
(WebCore::MediaPlayerPrivateQTKit::paint):
(WebCore::mainThreadSetNeedsDisplay): Deleted.
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView): Deleted.
(WebCore::MediaPlayerPrivateQTKit::detachQTMovieView): Deleted.
(-[WebCoreMovieObserver menuForEventDelegate:]): Deleted.
(-[WebCoreMovieObserver setView:]): Deleted.

6:38 AM Changeset in webkit [174105] by Carlos Garcia Campos
  • 11 edits in trunk

REGRESSION(r173929): [GTK] TestInspector fails after r173929
​https://bugs.webkit.org/show_bug.cgi?id=137247

Reviewed by Philippe Normand.

Source/WebKit2:

Add WebKitWebInspector:can-attach property to notify when the
inspector attach availability changes.

  • UIProcess/API/C/gtk/WKInspectorClientGtk.h:
  • UIProcess/API/gtk/WebKitWebInspector.cpp:

(webkit_web_inspector_class_init): Add WebKitWebInspector:can-attach property.
(didChangeAttachAvailability): Emit notify::can-attach.
(webkitWebInspectorCreate): Add implementation for didChangeAttachAvailability.
(webkit_web_inspector_get_can_attach): Return whether the inspector can be attached.

  • UIProcess/API/gtk/WebKitWebInspector.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add index of new symbols in 2.8.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
  • UIProcess/gtk/WebInspectorClientGtk.cpp:

(WebKit::WebInspectorClientGtk::didChangeAttachAvailability):

  • UIProcess/gtk/WebInspectorClientGtk.h:
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged): Notify the client.

Tools:

Wait until can-attach property changes before trying to attach the
inspector after resizing the view.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:

(testInspectorDefault):

6:33 AM Changeset in webkit [174104] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] The remote web inspector shows the HTML content as plain text
​https://bugs.webkit.org/show_bug.cgi?id=137250

Reviewed by Gustavo Noronha Silva.

Use GResource API directly to get the resource data, instead of
using the GFile API, and use g_content_type_guess() to get the
MIME Type.

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):

6:28 AM Changeset in webkit [174103] by Carlos Garcia Campos
  • 5 edits
    2 deletes in trunk/Source

[GTK] Move GtkPopupMenu implementation to WebPopupMenuProxyGtk
​https://bugs.webkit.org/show_bug.cgi?id=137193

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Remove GtkPopupMenu from platform.

  • PlatformGTK.cmake:
  • platform/gtk/GtkPopupMenu.cpp: Removed.
  • platform/gtk/GtkPopupMenu.h: Removed.

Source/WebKit2:

GtkPopupMenu was in platform only to have a common implementation to
be shared with WebKit1. Now that it's only used by
WebPopupMenuProxyGtk in WebKit2, we can simplify the code by
merging the implementation directly into WebPopupMenuProxyGtk.

  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk):
(WebKit::WebPopupMenuProxyGtk::~WebPopupMenuProxyGtk):
(WebKit::WebPopupMenuProxyGtk::populatePopupMenu):
(WebKit::WebPopupMenuProxyGtk::showPopupMenu):
(WebKit::WebPopupMenuProxyGtk::hidePopupMenu):
(WebKit::WebPopupMenuProxyGtk::typeAheadFind):
(WebKit::WebPopupMenuProxyGtk::resetTypeAheadFindState):
(WebKit::WebPopupMenuProxyGtk::selectItemCallback):
(WebKit::WebPopupMenuProxyGtk::keyPressEventCallback):

  • UIProcess/gtk/WebPopupMenuProxyGtk.h:

(WebKit::WebPopupMenuProxyGtk::setCurrentlySelectedMenuItem):

5:50 AM Changeset in webkit [174102] by evab.u-szeged@partner.samsung.com
  • 3 edits in trunk/Tools

Require Python 2.7 version
​https://bugs.webkit.org/show_bug.cgi?id=137112

Reviewed by Csaba Osztrogonác.

  • Scripts/ensure-valid-python:

(checkPythonVersion):

  • Scripts/webkitpy/common/version_check.py:
5:48 AM Changeset in webkit [174101] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Avoid copying the iterated-over items in range-based for-loops in RenderGrid
​https://bugs.webkit.org/show_bug.cgi?id=137246

Reviewed by Sergio Villar Senin.

Adjust the range-based for-loops in RenderGrid to avoid the unnecessary copying
of the items that are being iterated.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeNormalizedFractionBreadth):
(WebCore::RenderGrid::insertItemIntoGrid):
(WebCore::RenderGrid::gridAreaBreadthForChild):

5:17 AM Changeset in webkit [174100] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Hindi translation updated
​https://bugs.webkit.org/show_bug.cgi?id=137021

Patch by Rajesh Ranjan <​rajeshkajha@yahoo.com> on 2014-09-30
Reviewed by Philippe Normand.

  • hi.po:
5:15 AM Changeset in webkit [174099] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Updated Telugu Translation for WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=137027

Patch by Krishnababu Krothapalli <​kkrothap@redhat.com> on 2014-09-30
Reviewed by Philippe Normand.

  • te.po:
3:30 AM Changeset in webkit [174098] by svillar@igalia.com
  • 2 edits in trunk/Source/WebCore

[CSS Grid Layout] Use modern for-loops in RenderGrid
​https://bugs.webkit.org/show_bug.cgi?id=137214

Reviewed by Darin Adler.

New code is already using modern range based for loops. We had some
"old" code pending to be migrated.

No new tests as there is no change in functionality.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeNormalizedFractionBreadth):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::layoutGridItems):

3:17 AM Changeset in webkit [174097] by svillar@igalia.com
  • 5 edits
    4 adds in trunk

Caret not shown at the end of line in overtype mode
​https://bugs.webkit.org/show_bug.cgi?id=135508

Reviewed by Ryosuke Niwa.

Source/WebCore:

When overtype mode is enabled we usually replace the 'normal'
blinking caret shown in contenteditable elements by a block cursor
that covers the next character to be replaced. The exception is the
end of line where we fallback to the blinking caret even in overtype
mode (as there is no next character to replace).

We were not showing anything at the end of lines in overtype mode
because the detection of the end of line was incorrect and not very
understandable. Replaced the old code with a proper and clean end of
line detection mechanism compatible with bidi text.

Tests: editing/selection/block-cursor-overtype-mode-end-of-line-rtl.html

editing/selection/block-cursor-overtype-mode-end-of-line.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAppearance):

  • editing/VisibleUnits.cpp:

(WebCore::isLogicalEndOfLine):

  • editing/VisibleUnits.h:

LayoutTests:

  • editing/selection/block-cursor-overtype-mode-end-of-line-expected.html: Added.
  • editing/selection/block-cursor-overtype-mode-end-of-line-rtl-expected.html: Added.
  • editing/selection/block-cursor-overtype-mode-end-of-line-rtl.html: Added.
  • editing/selection/block-cursor-overtype-mode-end-of-line.html: Added.
2:45 AM Changeset in webkit [174096] by mhock@apple.com
  • 2 edits in trunk/Tools

Skip a JSC test after r174036.
​https://bugs.webkit.org/show_bug.cgi?id=137236

Reviewed by Csaba Osztrogonác.

  • Scripts/run-javascriptcore-tests:

Sep 29, 2014:

8:34 PM Changeset in webkit [174095] by Brian Burg
  • 7 edits in trunk/Source

Web Inspector: InjectedScripts should not be profiled or displayed in Timeline
​https://bugs.webkit.org/show_bug.cgi?id=136806

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

It doesn't make sense to show profile nodes for injected scripts when profiling user content.
For now, omit nodes by suspending profiling before and after executing injected scripts.

  • profiler/LegacyProfiler.cpp:

(JSC::LegacyProfiler::suspendProfiling): Added.
(JSC::LegacyProfiler::unsuspendProfiling): Added.

  • profiler/LegacyProfiler.h:
  • profiler/ProfileGenerator.cpp: Add isSuspended() flag, remove unused typedef.

(JSC::ProfileGenerator::ProfileGenerator):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):

  • profiler/ProfileGenerator.h:

(JSC::ProfileGenerator::setIsSuspended): Added.

Source/WebCore:

Instead of creating timeline records for injected scripts, suspend profiling
of the current page before and after calling injected script functions.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::willCallInjectedScriptFunction):
(WebCore::InspectorController::didCallInjectedScriptFunction):

8:30 PM Changeset in webkit [174094] by Brian Burg
  • 27 edits in trunk/Source

Web Inspector: InspectorValues should use references for out parameters
​https://bugs.webkit.org/show_bug.cgi?id=137190

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Use references for out parameters in asType() and getType() methods.
Also convert to references in some miscellaneous code where we don't
expect or handle null values.

Remove variants of asObject() and asArray() that return a nullable RefPtr.
Now, client code is forced to use out parameters and check for cast failure.

Iron out control flow in some functions and fix some style issues.

  • inspector/InjectedScript.cpp:

(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::wrapObject):
(Inspector::InjectedScript::wrapTable):

  • inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::makeEvalCall):

  • inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::injectedScriptForObjectId): Simplify control flow.

  • inspector/InspectorBackendDispatcher.cpp:

(Inspector::InspectorBackendDispatcher::dispatch):
(Inspector::getPropertyValue):
(Inspector::AsMethodBridges::asInteger):
(Inspector::AsMethodBridges::asDouble):
(Inspector::AsMethodBridges::asString):
(Inspector::AsMethodBridges::asBoolean):
(Inspector::AsMethodBridges::asObject):
(Inspector::AsMethodBridges::asArray):

  • inspector/InspectorProtocolTypes.h:

(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::runtimeCast):
(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::assertValueHasExpectedType):

  • inspector/InspectorValues.cpp: Use more by-reference out parameters. Add more spacing.

(Inspector::InspectorValue::asBoolean):
(Inspector::InspectorValue::asDouble):
(Inspector::InspectorValue::asInteger):
(Inspector::InspectorValue::asString):
(Inspector::InspectorValue::asValue):
(Inspector::InspectorValue::asObject):
(Inspector::InspectorValue::asArray):
(Inspector::InspectorValue::parseJSON):
(Inspector::InspectorValue::toJSONString):
(Inspector::InspectorValue::writeJSON):
(Inspector::InspectorBasicValue::asBoolean):
(Inspector::InspectorBasicValue::asDouble):
(Inspector::InspectorBasicValue::asInteger):
(Inspector::InspectorBasicValue::writeJSON):
(Inspector::InspectorString::asString):
(Inspector::InspectorString::writeJSON):
(Inspector::InspectorObjectBase::asObject):
(Inspector::InspectorObjectBase::openAccessors):
(Inspector::InspectorObjectBase::getBoolean):
(Inspector::InspectorObjectBase::getString):
(Inspector::InspectorObjectBase::getObject):
(Inspector::InspectorObjectBase::getArray):
(Inspector::InspectorObjectBase::writeJSON):
(Inspector::InspectorArrayBase::asArray):
(Inspector::InspectorArrayBase::writeJSON):

  • inspector/InspectorValues.h:
  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::parseLocation):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::didParseSource):

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

  • inspector/scripts/codegen/generate_protocol_types_implementation.py:

(ProtocolTypesImplementationGenerator):
(ProtocolTypesImplementationGenerator._generate_assertion_for_enum):

  • inspector/scripts/codegen/generator_templates.py:
  • inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
  • replay/EncodedValue.cpp:

(JSC::EncodedValue::asObject):
(JSC::EncodedValue::asArray):
(JSC::EncodedValue::convertTo<bool>):
(JSC::EncodedValue::convertTo<double>):
(JSC::EncodedValue::convertTo<float>):
(JSC::EncodedValue::convertTo<int32_t>):
(JSC::EncodedValue::convertTo<int64_t>):
(JSC::EncodedValue::convertTo<uint32_t>):
(JSC::EncodedValue::convertTo<uint64_t>):
(JSC::EncodedValue::convertTo<String>):

Source/WebCore:

Clean up some call sites to explicitly check for cast success, and simplify
some exceptional control flows.

No new tests, no behavior changed.

  • inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::inspectImpl):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::computePseudoClassMask):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::parseColor):
(WebCore::parseConfigColor):
(WebCore::parseQuad):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
(WebCore::InspectorDOMAgent::highlightFrame):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::findStorageArea):

  • inspector/InspectorIndexedDBAgent.cpp: Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL.
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):

  • inspector/InspectorReplayAgent.cpp:

(WebCore::InspectorReplayAgent::replayToPosition):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::styleWithProperties):

  • inspector/InspectorStyleSheet.h:

(WebCore::InspectorCSSId::InspectorCSSId):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):

  • inspector/InspectorWorkerAgent.cpp:
7:02 PM Changeset in webkit [174093] by clopez@igalia.com
  • 5 edits in trunk/Tools

[GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
​https://bugs.webkit.org/show_bug.cgi?id=137212

This moves TestNetscapePlugin to a new folder (lib/plugins).
We should not use the same directory for TestNetscapePlugin and
the other libraries, because we end up scanning all the .so in the
lib dir for every test.

Reviewed by Carlos Garcia Campos.

  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
  • Scripts/webkitpy/port/efl.py:

(EflPort.setup_environ_for_server): Update plugin path.

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server): Update plugin path.

  • TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
4:08 PM Changeset in webkit [174092] by ap@apple.com
  • 3 edits in trunk/Tools

A small change to EWS bubble text. Explain why there are messages for ineligible patches.

Rubber-stamped by Tim Horton.

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble):

3:38 PM Changeset in webkit [174091] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG HasStructureProperty codegen should use one fewer registers
​https://bugs.webkit.org/show_bug.cgi?id=137235

Reviewed by Andreas Kling.

This was an obvious source of inefficiency and it was causing us to run out of registers on
x86-32.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:25 PM Changeset in webkit [174090] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Don't use GPRResult unless you're flushing registers and making a runtime function call
​https://bugs.webkit.org/show_bug.cgi?id=137234

Rubber stamped by Andreas Kling.

Rename GPRResult to GPRFlushedCallResult, in an attempt to dissuade people from using it for results in the
general case.

Replace GPRResult with GPRTemporary in those places where it was causing bugs: particularly in GetDirectPname it
would cause us to spill the register that has the base, and the code was assuming (rightly) that the base and the
result were in different registers. That's a valid assumption when using GPRTemporary but not with GPRResult.
Also this code wasn't getting any benefit from using GPRResult because it wasn't doing flushRegisters().

I don't know how to test this. A test would require setting up a particularly awkward register allocation state.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):
(JSC::DFG::SpeculativeJIT::compileNewFunctionNoCheck):
(JSC::DFG::SpeculativeJIT::compileNewFunctionExpression):
(JSC::DFG::SpeculativeJIT::compileRegExpExec):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileToStringOnCell):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::GPRFlushedCallResult::GPRFlushedCallResult):
(JSC::DFG::GPRFlushedCallResult2::GPRFlushedCallResult2):
(JSC::DFG::GPRResult::GPRResult): Deleted.
(JSC::DFG::GPRResult2::GPRResult2): Deleted.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::speculateDoubleRepMachineInt):

3:23 PM Changeset in webkit [174089] by Chris Dumez
  • 68 edits in trunk/Source

Use is<>() / downcast<>() for Document
​https://bugs.webkit.org/show_bug.cgi?id=137221

Reviewed by Andreas Kling.

Use is<>() / downcast<>() for Document instead of isDocumentNode() /
toDocument().

Source/WebCore:

No new tests, no behavior change.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::document):
(WebCore::Geolocation::frame):
(WebCore::Geolocation::page):

  • Modules/indexeddb/IDBFactory.cpp:
  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::document):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):

  • Modules/notifications/Notification.cpp:

(WebCore::Notification::Notification):
(WebCore::Notification::show):
(WebCore::Notification::permission):
(WebCore::Notification::requestPermission):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::document):

  • Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::create):

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::allowDatabaseAccess):
(WebCore::DatabaseContext::databaseExceededQuota):

  • Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::create):

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • bindings/js/DOMConstructorWithDocument.h:

(WebCore::DOMConstructorWithDocument::document):

  • bindings/js/DOMRequestState.h:

(WebCore::DOMRequestState::DOMRequestState):
(WebCore::DOMRequestState::clear):

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::constructJSAudioContext):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::toJSDOMGlobalObject):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/js/ScriptState.cpp:

(WebCore::frameFromExecState):

  • crypto/SubtleCrypto.cpp:

(WebCore::SubtleCrypto::document):

  • dom/Comment.cpp:

(WebCore::Comment::create):

  • dom/ContainerNode.cpp:

(WebCore::checkAcceptChild):

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):

  • dom/Document.h:

(WebCore::isDocument):

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::create):

  • dom/Element.cpp:

(WebCore::Element::computeInheritedLanguage):

  • dom/EventDispatcher.cpp:

(WebCore::WindowEventContext::WindowEventContext):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::document):

  • dom/Node.cpp:

(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::removedLastRef):

  • dom/Range.cpp:

(WebCore::Range::create):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::dispatchErrorEvent):

  • dom/Text.cpp:

(WebCore::Text::create):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

  • html/HTMLDocument.h:

(WebCore::isHTMLDocument):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::document):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::insertedInto):

  • html/ImageDocument.h:

(WebCore::isImageDocument):

  • html/MediaDocument.h:

(WebCore::isMediaDocument):

  • html/PluginDocument.h:

(WebCore::isPluginDocument):

  • html/track/TextTrackCue.h:

(WebCore::TextTrackCue::ownerDocument):

  • html/track/VTTCue.cpp:

(WebCore::VTTCue::initialize):

  • html/track/VTTRegion.h:

(WebCore::VTTRegion::ownerDocument):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::assertDocument):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::innerParentNode):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::frameForScriptExecutionContext):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::instrumentingAgentsForContext):

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::corsPolicyPreventedLoad):
(WebCore::TextTrackLoader::notifyFinished):
(WebCore::TextTrackLoader::load):

  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

  • page/Crypto.cpp:

(WebCore::Crypto::document):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::focus):
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::document):
(WebCore::DOMWindow::styleMedia):
(WebCore::DOMWindow::getComputedStyle):

  • page/DragController.cpp:

(WebCore::DragController::dragExited):
(WebCore::DragController::dragEnteredOrUpdated):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

  • page/History.cpp:

(WebCore::History::go):

  • page/SpatialNavigation.cpp:

(WebCore::scrollInDirection):
(WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDirection):
(WebCore::canScrollInDirection):
(WebCore::nodeRectInAbsoluteCoordinates):

  • svg/SVGDocument.h:

(WebCore::isSVGDocument):

  • testing/Internals.cpp:

(WebCore::Internals::contextDocument):
(WebCore::Internals::frame):
(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):
(WebCoreTestSupport::resetInternalsObject):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::addToWorkerDocuments):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::document):
(WebCore::XMLHttpRequest::open):

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:

(-[WKDOMDocument createElement:]):
(-[WKDOMDocument createTextNode:]):
(-[WKDOMDocument body]):

3:14 PM Changeset in webkit [174088] by ap@apple.com
  • 3 edits in trunk/Tools

Typo fix, suggested by Tim Horton.

  • QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_message_for_provisional_failure):

2:55 PM Changeset in webkit [174087] by ap@apple.com
  • 5 edits in trunk/Tools

Improve Bugzilla status bubbles
​https://bugs.webkit.org/show_bug.cgi?id=137232

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/app.yaml: Will update again with an actual version when landing.
  • QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added

blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
that are stuck, as it was only confusing that they disappeared after 99.

  • QueueStatusServer/model/attachment.py: Removed functionality that was only used

by old bubbles. We need a lot more information to determine color, so the implementation
can not be here.

  • QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles

always have a link for consistency. Added code to convert timestamps in tooltips
to local time zone.

2:26 PM Changeset in webkit [174086] by commit-queue@webkit.org
  • 17 edits
    1 move
    1 add in trunk

Unreviewed, rolling out r174045.
​https://bugs.webkit.org/show_bug.cgi?id=137231

Introduced a crash during page loading tests on Mac (Requested
by rniwa on #webkit).

Reverted changeset:

"Replace OSObjectPtr with RetainPtr/adoptOS"
​https://bugs.webkit.org/show_bug.cgi?id=137158
​http://trac.webkit.org/changeset/174045

1:54 PM Changeset in webkit [174085] by hyatt@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION (r168046): Confused column spans when combined with dynamic animations
​https://bugs.webkit.org/show_bug.cgi?id=134048.

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/multicol/multicol-fieldset-span-changes.html

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::processPossibleSpannerDescendant):
Refactor handling of insertions into the multicolumn flow thread into
a helper function, processPossibleSpannerDescendant. This makes it easier
to call the code from more than one place.

(WebCore::RenderMultiColumnFlowThread::flowThreadDescendantInserted):
Modify the nested columns span shifting code to avoid problems. The
new code suppresses notifications and does the move of the spanner back
into the original spot *before* removing the placeholder. This ensures that
the placeholder parent still exists.

The stale placeholder is then removed and destroyed after the spanner has been put back
into place.

(WebCore::RenderMultiColumnFlowThread::handleSpannerRemoval):
(WebCore::RenderMultiColumnFlowThread::flowThreadRelativeWillBeRemoved):
Refactor the removal notifications for spanners into a helper function so that it can
be called to do cleanup from the code that cleans up stale placeholders on a shift.

  • rendering/RenderMultiColumnFlowThread.h:

Modified to add the new helpers.

LayoutTests:

  • fast/multicol/multicol-fieldset-span-changes-expected.txt: Added.
  • fast/multicol/multicol-fieldset-span-changes.html: Added.
1:50 PM Changeset in webkit [174084] by Chris Dumez
  • 7 edits in trunk/Source/WebCore

Use SPECIALIZE_TYPE_TRAITS_*() macro for MathMLElement
​https://bugs.webkit.org/show_bug.cgi?id=137222

Reviewed by Ryosuke Niwa.

Use SPECIALIZE_TYPE_TRAITS_*() macro for MathMLElement instead of
NODE_TYPE_CASTS() + NodeTypeCastTraits template specialization.

No new tests, no behavior change.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::accessibilityDescription):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isMathElement):

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::attributeChanged):

  • mathml/MathMLElement.h:

(WebCore::isMathMLElement):

  • mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::getSelectedSemanticsChild):

1:39 PM Changeset in webkit [174083] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] Skip some failing inspector tests following r174020.

  • platform/win/TestExpectations:
1:25 PM Changeset in webkit [174082] by roger_fong@apple.com
  • 3 edits in trunk/LayoutTests

[Mac] Unreviewed. Missing test gardening from r174080.

  • accessibility/roles-computedRoleString-expected.txt:
  • accessibility/roles-computedRoleString.html:
1:19 PM Changeset in webkit [174081] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Set the TBA versions based on the PLATFORM_NAME
​https://bugs.webkit.org/show_bug.cgi?id=137226
Follow-up fix for <rdar://problem/17761459>.

Reviewed by Dan Bernstein.

  • mac/rewrite-availability-macros.sh:

Turns out that MACOSX_DEPLOYMENT_TARGET is set even for iOS builds,
so set the versions based on the PLATFORM_NAME environment variable.

12:42 PM Changeset in webkit [174080] by roger_fong@apple.com
  • 4 edits in trunk/LayoutTests

[Mac] Unreviewed test gardening.

These accessibility tests need to be changed following r174074.

  • accessibility/aria-labelledby-with-descendants-expected.txt:
  • accessibility/roles-computedRoleString.html:
  • platform/mac/TestExpectations: Some previously skipped inspector tests crash in debug configuration.
12:29 PM Changeset in webkit [174079] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[Mac] Remove MediaPlayerPrivateQTKit frame rate code
​https://bugs.webkit.org/show_bug.cgi?id=137217

Reviewed by Carlos Garcia Campos.

No new tests, this removes obsolete code.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::play):
(WebCore::MediaPlayerPrivateQTKit::pause):
(WebCore::MediaPlayerPrivateQTKit::didEnd):
(WebCore::MediaPlayerPrivateQTKit::repaint):
(WebCore::MediaPlayerPrivateQTKit::paint):

12:26 PM Changeset in webkit [174078] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Add Jake as a contributor.

  • Scripts/webkitpy/common/config/contributors.json:
12:13 PM Changeset in webkit [174077] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Skip a javascriptcore test following r174036.

  • Scripts/run-javascriptcore-tests:
11:42 AM Changeset in webkit [174076] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Reduce number of processes used by NRWT on Windows to 1.

  • Scripts/webkitpy/port/win.py:

(WinPort.default_child_processes):
Reduce number of processes to 1 so we can get a good baseline for what failures
we should be expecting to see from the Windows bots.

11:28 AM Changeset in webkit [174075] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performActionOnElement):

11:18 AM Changeset in webkit [174074] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: in an aria-labelledby computation, do not traverse into elements whose nameFrom value does not include 'contents'
​https://bugs.webkit.org/show_bug.cgi?id=136714

Reviewed by Darin Adler.

Source/WebCore:

There are certain ARIA elements that tell us we should not query their children when determining the name of the object.
Those ones have the "nameFrom" property set to "author" instead of "contents." WebKit needs to honor that status.

Test: accessibility/aria-namefrom-author.html

Modified: accessibility/aria-labelledby-with-descendants.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::shouldUseAccessiblityObjectInnerText):
(WebCore::shouldAddSpaceBeforeAppendingNextElement):
(WebCore::appendNameToStringBuilder):
(WebCore::AccessibilityNodeObject::textUnderElement):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibleNameDerivesFromContent):
(WebCore::initializeRoleMap):

  • accessibility/AccessibilityObject.h:

LayoutTests:

  • accessibility/aria-labelledby-with-descendants-expected.txt:
  • accessibility/aria-labelledby-with-descendants.html:
  • accessibility/aria-namefrom-author-expected.txt: Added.
  • accessibility/aria-namefrom-author.html: Added.
11:12 AM Changeset in webkit [174073] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Optimize media controls AirPlay discovery
​https://bugs.webkit.org/show_bug.cgi?id=137180

Reviewed by Darin Adler.

AirPlay discovery mode uses increases power consumption, so don't enable it when there
is no chance an AirPlay target picker will be useful.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS): Initialize isListeningForPlaybackTargetAvailabilityEvent.
(ControllerIOS.prototype.addVideoListeners): Don't enable register wireless playback event

listeners, it isn't possible to show the target picker until there is an inline controller.

(ControllerIOS.prototype.removeVideoListeners): Call setShouldListenForPlaybackTargetAvailabilityEvent.
(ControllerIOS.prototype.setControlsType): Add wireless event listers on when not showing

the one button controller.

(ControllerIOS.prototype.updateStatusDisplay): Unregister wireless event listeners when the

media element is in an error state.

(ControllerIOS.prototype.setShouldListenForPlaybackTargetAvailabilityEvent): New, add or

remove event listeners.

11:05 AM Changeset in webkit [174072] by aestes@apple.com
  • 8 edits in trunk/Source/WebKit2

[iOS] Add basic support for link navigation in WKPDFView
​https://bugs.webkit.org/show_bug.cgi?id=137182

Reviewed by Tim Horton.

Teach WKPDFView to navigate to URLs when PDF link annotations are tapped.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::navigateToURLWithSimulatedClick): Sent Messages::WebPage::NavigateToURLWithSimulatedClick.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKPDFView.h:
  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView _clearPages]): Removed self as the UIPDFAnnotationControllerDelegate.
(-[WKPDFView _revalidateViews]): Added self as the UIPDFAnnotationControllerDelegate.
(-[WKPDFView annotation:wasTouchedAtPoint:controller:]): Retrieved the URL from the touched annotation,
computed the touched point relative to the WKPDFView and to the screen, and called
navigateToURLWithSimulatedClick() after a 200 ms delay in order to show a soon-to-be-added tap highlight
(this value matches the delay in UIWebPDFView).

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToURLWithSimulatedClick): Created a fake single-click MouseEvent and called
FrameLoader::urlSelected(). Creating a mouse event ensures that the navigation appears as a
NavigationTypeLinkClicked in navigation policy delegates.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
11:00 AM Changeset in webkit [174071] by eric.carlson@apple.com
  • 5 edits in trunk/Source/WebCore

[iOS] Remove obsolete playbackTargetAvailabilityChanged methods
​https://bugs.webkit.org/show_bug.cgi?id=137179

Reviewed by Darin Adler.

No new tests, this just removes unused code.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerPlaybackTargetAvailabilityChanged): Deleted.

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::playbackTargetAvailabilityChanged): Deleted.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerPlaybackTargetAvailabilityChanged): Deleted.

10:44 AM Changeset in webkit [174070] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty/ANGLE

[WinCairo] D3D11 is not used by default.
​https://bugs.webkit.org/show_bug.cgi?id=137215

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-09-29
Reviewed by Alex Christensen.

ANGLE_DEFAULT_D3D11 needs to be defined for D3D11 to be used as default.

  • ANGLE.vcxproj/libGLESv2Common.props:
10:35 AM Changeset in webkit [174069] by Chris Dumez
  • 28 edits in trunk/Source/WebCore

Use the new is<>() / downcast<>() for ShadowRoot and StyledElement
​https://bugs.webkit.org/show_bug.cgi?id=137199

Reviewed by Darin Adler.

Use the new is<>() / downcast<>() for ShadowRoot and StyledElement and
move towards getting rid of the NODE_TYPE_CASTS() macro.

No new tests, no behavior change.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchAllRules):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::findSiblingForStyleSharing):

  • dom/Attr.cpp:

(WebCore::Attr::style):

  • dom/Element.cpp:

(WebCore::Element::removeAttribute):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedNodeResolver::moveToParentOrShadowHost):
(WebCore::EventRelatedNodeResolver::findHostOfTreeScopeInTargetTreeScope):
(WebCore::eventTargetRespectingTargetRules):
(WebCore::EventPath::EventPath):

  • dom/Node.cpp:

(WebCore::Node::containingShadowRoot):
(WebCore::Node::parentOrShadowHostElement):
(WebCore::Node::showNodePathForThis):

  • dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::traverseParent):

  • dom/ShadowRoot.h:

(WebCore::isShadowRoot):
(WebCore::Node::shadowRoot):
(WebCore::Node::parentOrShadowHostNode):

  • dom/StyledElement.h:

(WebCore::StyledElement::presentationAttributeStyle):
(WebCore::isStyledElement):

  • dom/Text.cpp:

(WebCore::isSVGShadowText):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::focusedElement):

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::wrappingStyleForSerialization):

  • editing/Editor.cpp:

(WebCore::Editor::applyEditingStyleToElement):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::inlineStylePropertyForElement):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendElement):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementInfo):

  • page/DragController.cpp:

(WebCore::asFileInput):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):

  • page/FocusController.cpp:

(WebCore::FocusNavigationScope::owner):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::title):

  • testing/Internals.cpp:

(WebCore::Internals::shadowRoot):
(WebCore::Internals::shadowRootType):
(WebCore::Internals::includerFor):

10:20 AM Changeset in webkit [174068] by Chris Dumez
  • 43 edits in trunk/Source

Use the new is<>() / downcast<>() for Text Nodes
​https://bugs.webkit.org/show_bug.cgi?id=137188

Reviewed by Darin Adler.

Use the new is<>() / downcast<>() functions for Text Nodes instead of
isText() / toText().

Source/WebCore:

No new tests, no behavior change.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::textUnderElement):

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):
(WebCore::CharacterData::setDataAndUpdate):

  • dom/ContainerNode.cpp:

(WebCore::destroyRenderTreeIfNeeded):

  • dom/Node.cpp:

(WebCore::Node::normalize):

  • dom/Position.cpp:

(WebCore::Position::containerNode):
(WebCore::Position::containerText):
(WebCore::Position::isRenderedCharacter):
(WebCore::Position::leadingWhitespacePosition):

  • dom/Range.cpp:

(WebCore::Range::insertNode):
(WebCore::Range::getBorderAndTextQuads):

  • dom/Text.cpp:

(WebCore::earliestLogicallyAdjacentTextNode):
(WebCore::latestLogicallyAdjacentTextNode):

  • dom/Text.h:

(WebCore::isText):

  • dom/TextNodeTraversal.cpp:

(WebCore::TextNodeTraversal::contentsAsString):

  • dom/TextNodeTraversal.h:

(WebCore::TextNodeTraversal::firstTextChildTemplate):
(WebCore::TextNodeTraversal::firstTextWithinTemplate):
(WebCore::TextNodeTraversal::traverseNextTextTemplate):
(WebCore::TextNodeTraversal::nextSibling):

  • editing/ApplyBlockElementCommand.cpp:

(WebCore::isNewLineAtPosition):
(WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::splitTextAtEnd):
(WebCore::ApplyStyleCommand::splitTextElementAtEnd):
(WebCore::ApplyStyleCommand::joinChildTextNodes):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::insertNodeAt):
(WebCore::CompositeEditCommand::positionOutsideTabSpan):
(WebCore::CompositeEditCommand::canRebalance):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
(WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::removePlaceholderAt):
(WebCore::CompositeEditCommand::cleanupAfterDeletion):
(WebCore::CompositeEditCommand::moveParagraphs):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):
(WebCore::DeleteSelectionCommand::fixupWhitespace):
(WebCore::DeleteSelectionCommand::doApply):

  • editing/Editor.cpp:

(WebCore::Editor::setComposition):

  • editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextBox):
(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):

  • editing/VisibleUnits.cpp:

(WebCore::startPositionForLine):
(WebCore::endPositionForLine):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • editing/htmlediting.cpp:

(WebCore::lineBreakExistsAtPosition):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::renderedText):
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):

  • html/HTMLElement.cpp:

(WebCore::mergeWithNextTextNode):
(WebCore::HTMLElement::setOuterHTML):
(WebCore::HTMLElement::setOuterText):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasFallbackContent):
(WebCore::HTMLObjectElement::updateDocNamedItem):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::setText):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::innerTextValue):
(WebCore::positionForIndex):
(WebCore::HTMLTextFormControlElement::indexForPosition):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::setText):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertTextNode):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setNodeValue):

  • rendering/RenderCombineText.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::getRanges):

  • rendering/RenderText.cpp:

(WebCore::RenderText::textNode):

  • rendering/svg/RenderSVGInlineText.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):
(WebCore::Style::attachChildren):
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::detachDistributedChildren):
(WebCore::Style::detachChildren):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::resolveTree):

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMText.mm:

(-[WKDOMText data]):
(-[WKDOMText setData:]):

10:16 AM Changeset in webkit [174067] by Chris Dumez
  • 14 edits in trunk/Source/WebCore

Remove remaining uses of NODE_TYPE_CASTS() from html/
​https://bugs.webkit.org/show_bug.cgi?id=137172

Reviewed by Darin Adler.

Remove remaining uses of NODE_TYPE_CASTS() from html/ and use the new
SPECIALIZE_TYPE_TRAITS_*() macro instead so that is<>() / downcast<>()
works for those types.

No new tests, no behavior change.

  • css/SelectorCheckerTestFunctions.h:

(WebCore::matchesLangPseudoClass):
(WebCore::matchesFutureCuePseudoClass):
(WebCore::matchesPastCuePseudoClass):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):
The new casting function found a bad cast from a StyledElement to VTTElement.
Those two types are unrelated as VTTElement inherits directly from Element.
Knowing that |element| in this method cannot be a VTTElement simplifies the
logic a bit.

  • dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::findFirstEnteringInsertionPoints):
(WebCore::NodeRenderingTraversal::findLastEnteringInsertionPoints):
(WebCore::NodeRenderingTraversal::traverseParent):

  • html/HTMLLabelElement.cpp:

(WebCore::nodeAsSupportedLabelableElement):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement):

  • html/LabelableElement.h:

(WebCore::isLabelableElement):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::ensureInsertionPointList):

  • html/shadow/InsertionPoint.h:

(WebCore::isInsertionPoint):
(WebCore::isActiveInsertionPoint):
(WebCore::parentNodeForDistribution):

  • html/shadow/TextControlInnerElements.h:

(WebCore::isTextControlInnerTextElement):

  • html/track/VTTCue.cpp:

(WebCore::VTTCue::copyWebVTTNodeToDOMTree):
(WebCore::VTTCue::markFutureAndPastNodes):

  • html/track/WebVTTElement.h:

(WebCore::isWebVTTElement):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTTreeBuilder::constructTreeFromToken):

  • style/StyleResolveTree.cpp:

(WebCore::Style::attachRenderTree):
(WebCore::Style::detachChildren):

10:05 AM Changeset in webkit [174066] by commit-queue@webkit.org
  • 5 edits in trunk

Missing changes from r174049
​https://bugs.webkit.org/show_bug.cgi?id=137206

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-09-29
Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:

LayoutTests:

  • js/number-constructor-expected.txt:
  • js/script-tests/number-constructor.js:
9:58 AM Changeset in webkit [174065] by Chris Dumez
  • 23 edits in trunk/Source

Make is<>() / downcast<>() work for HTMLDocument and its subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137169

Reviewed by Darin Adler.

Source/WebCore:

Make is<>() / downcast<>() work for HTMLDocument and its subclasses by
using the SPECIALIZE_TYPE_TRAITS_*() macro. Drop the DOCUMENT_TYPE_CASTS()
macro as it is no longer needed.

No new tests, no behavior change.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
(WebCore::Document::processHttpEquiv):
(WebCore::eventTargetElementForDocument):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateName):
(WebCore::Element::updateId):

  • html/HTMLDocument.h:

(WebCore::isHTMLDocument):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::matchesReadWritePseudoClass):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::document):

  • html/ImageDocument.h:

(WebCore::isImageDocument):

  • html/MediaDocument.h:

(WebCore::isMediaDocument):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • html/PluginDocument.h:

(WebCore::isPluginDocument):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin):

  • page/DragController.cpp:

(WebCore::DragController::operationForLoad):

  • page/FrameView.cpp:

(WebCore::determineLayerFlushThrottleState):

Source/WebKit/win:

Use is<>() / downcast<>() for HTMLDocument and its subclasses.

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::URL):
(DOMHTMLDocument::body):
(DOMHTMLDocument::forms):

Source/WebKit2:

Use is<>() / downcast<>() for HTMLDocument and its subclasses.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pdfDocumentForPrintingFrame):

9:31 AM Changeset in webkit [174064] by Bruno de Oliveira Abinader
  • 4 edits
    2 deletes in trunk

Revert "Support for :enabled selector on Anchor & Area elements"
​https://bugs.webkit.org/show_bug.cgi?id=134826

Reviewed by Darin Adler.

Source/WebCore:

HTML spec has been modified [1] to disable support for :enabled CSS
selector on Anchor, Area & Link elements, after discussion on W3C
Bugzilla [2].

This reverts r171671.

[1] ​https://html5.org/r/8818
[2] ​https://www.w3.org/Bugs/Public/show_bug.cgi?id=26622

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isEnabled):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

LayoutTests:

These layout tests are no longer correct after changes to the :enabled
CSS selector specification.

  • fast/css/css-selector-enabled-links-expected.txt: Removed.
  • fast/css/css-selector-enabled-links.html: Removed.
9:26 AM Changeset in webkit [174063] by Darin Adler
  • 4 edits in trunk

Tweak and tighten SVG font converter
​https://bugs.webkit.org/show_bug.cgi?id=136956

Reviewed by Myles Maxfield.

Source/WebCore:

  • svg/SVGToOTFFontConversion.cpp: Fixed copyright date.

(WebCore::overwrite32): Changed to use normal subscripting for clarity.
(WebCore::overwrite16): Added.
(WebCore::SVGToOTFFontConverter::GlyphData::GlyphData): Added a move
to make constructing each GlyphData less expensive.
(WebCore::SVGToOTFFontConverter::KerningData): Removed the < operator
since it the struct contains more than what we want to sort it by, so it's
not elegant to build the sorting rule into the struct.
(WebCore::SVGToOTFFontConverter): Removed "k" prefix from some constants.
Replaced many function templates with non-template functions. Changed
key type for m_codepointToIndexMap to UChar32.
(WebCore::integralLog2): Tweaked formatting.
(WebCore::SVGToOTFFontConverter::appendCMAPTable): Removed a stray
cast that doesn't have any effect. Use the Glyph type to index m_glyphs.
(WebCore::SVGToOTFFontConverter::appendHEADTable): Append the magic
number in a more straightforward way.
(WebCore::clampTo): Tweak formatting of the template function.
(WebCore::SVGToOTFFontConverter::appendHHEATable): Made some minor
style changes and improved some comments.
(WebCore::SVGToOTFFontConverter::appendOS2Table): Made some minor
style changes and tightened up code that did parsing a bit, removing the
dynamically allocated array for the fixed length Panose number.
Also use first and last instead of hand-coded versions of those.
(WebCore::appendValidCFFString): Renamed.
(WebCore::SVGToOTFFontConverter::appendCFFTable): Made various tweaks,
including more specific of null for the "no weight" value instead of
either empty or null.
(WebCore::SVGToOTFFontConverter::appendVORGTable): Simplified some of
the numeric parsing, since toInt is guaranteed to return 0 when it also
would return "false" for ok. Also got rid of a local vector and instead
just fixed up the size of the table afterward.
(WebCore::SVGToOTFFontConverter::appendVHEATable): Tweaked comment.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): Use isValidKey
instead of a local hardcoded rule to check hash table key validity.
Check for zero in the result of get rather than using find on the HashMap.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): Ditto.
(WebCore::SVGToOTFFontConverter::addGlyphNames): Ditto.
(WebCore::SVGToOTFFontConverter::addKerningPair): Added. Factored out from
appendKERNSubtable to reduce template bloat and improve clarity.
(WebCore::SVGToOTFFontConverter::appendKERNSubtable): Tweaked formatting.
Moved the bulk of the function into non-template function.
(WebCore::SVGToOTFFontConverter::finishAppendingKERNSubtable): Added.
Non-template part of appendKERNSubtable. Also changed std::sort to supply
custom comparison function rather than trying to use the < operator directly
on KerningData.
(WebCore::writeCFFEncodedNumber): Don't use powf just to multiply by
216. It's pretty easy to do that with plain old multiplication.
(WebCore::CFFBuilder::CFFBuilder): Renamed m_firstPoint to
m_hasBoundingBox.
(WebCore::CFFBuilder::boundingBox): Made this public and const and made
the rest of the class private.
(WebCore::CFFBuilder::updateBoundingBox): Used early return and revised
to use m_hasBoundingBox.
(WebCore::CFFBuilder::writePoint): Added. Used to keep the other
functions below smaller.
(WebCore::CFFBuilder::moveTo): Marked virtual and simplified using writePoint.
Might find a way to simplify even further by teaching writePoint about
the PathCoordinateMode.
(WebCore::CFFBuilder::lineTo): Ditto.
(WebCore::CFFBuilder::curveToCubic): Ditto. Also removed comment that said
the function could be faster. Not sure that's important to state like this.
(WebCore::SVGToOTFFontConverter::transcodeGlyphPaths): Changed into a
non-template function. Tweaked logic and formatting a bit.
(WebCore::SVGToOTFFontConverter::processGlyphElement): Changed into a
non-template function. Moved the code from appendGlyphData in here.
Use WTF::move so we don't copy the glyph paths when creating a GlyphData.
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Updated a bit for
function changes above. Changed code to use isValidKey to check if we can
add to m_codepointToIndexMap. Parse font-style rather than parsing
font-weight twice. Round weights instead of truncating them. Change rule
to "first wins" instead of "last wins" when there are multiple segments.
Removed one vague and non-helpful comment.
(WebCore::isFourByteAligned): Fixed minor formatting issue by making the
function non-abstract. No reason not to hard-code the number 3 when the
number four appears in the function name.
(WebCore::calculateChecksum): Removed unneeded comment about why the
checksum is little-endian; since this came from Windows documentation there
is no doubt that little-endian is correct, so we don't need a comment creating
fear, uncertainty, and doubt. If the checksum computation is wrong, it should
become obvious that we have a bad checksum. Also changed the for loop to use
its own loop variable instead of changing startingOffset, which is not logical.
(WebCore::SVGToOTFFontConverter::appendTable): Updated for name changes.
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): Ditto. Also streamlined
the checksum code a little. The comment still is a little peculiar; I was
tempted to take it out.

Tools:

I was investigating behavior of String::toInt, String::toDouble, and
String::toFloat for various failure cases, and decided to start some
unit tests for those functions here.

  • TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
StringToDouble testing.

8:37 AM Changeset in webkit [174062] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit/ios

[iOS] Remove CoreLocation workaround
​https://bugs.webkit.org/show_bug.cgi?id=137198

Reviewed by Dan Bernstein.

Following the fix for <rdar://problem/18448331>, we can revert the CoreLocation workaround
committed in <​http://trac.webkit.org/changeset/173946> and <​http://trac.webkit.org/changeset/173940> (in order).

  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):

8:30 AM Changeset in webkit [174061] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix !ENABLE(INSPECTOR) build after r173929
​https://bugs.webkit.org/show_bug.cgi?id=137210

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-09-29
Reviewed by Timothy Hatcher.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions):

8:16 AM Changeset in webkit [174060] by Philippe Normand
  • 2 edits in trunk/Tools

[GTK][CMake] TestWebCore target build sometimes fail
​https://bugs.webkit.org/show_bug.cgi?id=137207

Reviewed by Csaba Osztrogon.

  • TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding

headers are generated before the TestWebCore target is built.

5:32 AM Changeset in webkit [174059] by Carlos Garcia Campos
  • 2 edits
    2 deletes in trunk/Source/WebCore

[GTK] Remove MainFrameScrollbarGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=137211

Reviewed by Philippe Normand.

This was only used by WebKit1.

  • PlatformGTK.cmake:
  • platform/gtk/MainFrameScrollbarGtk.cpp: Removed.
  • platform/gtk/MainFrameScrollbarGtk.h: Removed.
4:54 AM Changeset in webkit [174058] by Carlos Garcia Campos
  • 7 edits
    2 deletes in trunk

[GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=137209

Reviewed by Philippe Normand.

Source/WebCore:

IntPointGtk is unused and IntRectGtk is only required by GTK+2 and
only used when building with GTK+2 in GtkInputMethodFilter.cpp
that can be easily replaced.

  • PlatformGTK.cmake:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/gtk/IntPointGtk.cpp: Removed.
  • platform/graphics/gtk/IntRectGtk.cpp: Removed.
  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::setCursorRect):

Tools:

  • TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp

from the WebCore test sources.

3:08 AM Changeset in webkit [174057] by svillar@igalia.com
  • 9 edits
    6 adds in trunk

[CSS Grid Layout] Handle percentages of indefinite sizes in minmax() and grid-auto-*
​https://bugs.webkit.org/show_bug.cgi?id=136453

Reviewed by Darin Adler.

Source/WebCore:

After r165048 percentages of indefinite sizes were correctly
computed to "auto". The problem is that we were not doing it when
the percentage was inside the minmax() function. In those cases it
should compute to min-content for the min track sizing function or
to max-content for the max track sizing function.

We were not doing it also for the track sizes specified in
grid-auto-{column|row} properties. Fixed as well as the code is
the same.

Tests: fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html

fast/css-grid-layout/percent-of-indefinite-track-size-in-minmax-crash.html
fast/css-grid-layout/percent-of-indefinite-track-size.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::gridTrackSize):

  • rendering/RenderGrid.h:
  • rendering/style/GridLength.h:

(WebCore::GridLength::isPercentage):

  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::GridTrackSize):

LayoutTests:

Added three new tests, one to verify that we do not assert with
percentages inside minmax() and another two to verify that we
properly compute the percentage of indefinite size in various
situations both in grid-template-* properties and in
grid-auto-{column|row} properties.

Three other tests required minimum adjustments as they were using
percentages of indefinite sizes inside minmax functions. In order
to keep the original expected behavior some definite sizes were
added.

  • fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
  • fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
  • fast/css-grid-layout/grid-auto-columns-rows-update.html:
  • fast/css-grid-layout/percent-of-indefinite-track-size-expected.txt: Added.
  • fast/css-grid-layout/percent-of-indefinite-track-size-in-auto-expected.txt: Added.
  • fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html: Added.
  • fast/css-grid-layout/percent-of-indefinite-track-size-in-minmax-crash-expected.txt: Added.
  • fast/css-grid-layout/percent-of-indefinite-track-size-in-minmax-crash.html: Added.
  • fast/css-grid-layout/percent-of-indefinite-track-size.html: Added.
2:16 AM Changeset in webkit [174056] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.4.6

WebKitGTK+ 2.4.6

1:54 AM Changeset in webkit [174055] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Move sources not using GTK+ from WebCorePlatformGTK_SOURCES to WebCore_SOURCES.

  • PlatformGTK.cmake:
1:51 AM Changeset in webkit [174054] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

REGRESSION(r172919): WebKitPluginProcess fails to scan GTK+2 plugins after r172919.
​https://bugs.webkit.org/show_bug.cgi?id=137191

Reviewed by Philippe Normand.

In r172919 I moved the GTK+ symbols mix check earlier, before the
plugin is loaded and initialized. That made impossible to use the
GTK3 plugin process to scan gtk2 plugins, because we need to load
the plugin to get its metadata. But we don't need to initialize
the plugin to check if it requires GTK2, so we can do that check
in the UI process to decide which plugin process to use.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
Remove the requires GTK2 check.
(WebKit::NetscapePluginModule::scanPlugin): Don't write
requires-gtk2 to stdout.

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::pluginRequiresGtk2): Helper function to check if the
given plugin path requires GTK2.
(WebKit::PluginProcessProxy::scanPlugin): Check if the plugin path
requires GTK2 and use WebKitPluginProcess2 in such case, or return
early if GTK2 plugins are not enabled. Log error messages when
something fails scanning the plugin to make it easiert to debug
problems in the future.

12:15 AM Changeset in webkit [174053] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

Use std::unique_ptr instead of PassOwnPtr|OwnPtr for NamedNodeMap
​https://bugs.webkit.org/show_bug.cgi?id=137201

Reviewed by Darin Adler.

No new tests, just refactoring patch.

  • dom/ElementRareData.h: Use std::unique_ptr instead of OwnPtr.

(WebCore::ElementRareData::setAttributeMap): Use std::unique_ptr.

  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::create): ditto.

Sep 28, 2014:

8:42 PM Changeset in webkit [174052] by mmaxfield@apple.com
  • 13 edits
    1 add in trunk/Source

Replace wkGetGlyphsForCharacters() with CGFontGetGlyphsForUnichars()
​https://bugs.webkit.org/show_bug.cgi?id=137197

Reviewed by Alexey Proskuryakov.

No new tests because there is no behavior change.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.order:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill): Use SPI call instead of WKSI call

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/spi/cocoa/CGFontUnicodeSupport.h: Added for SPI call.

Source/WebKit:

  • mac/WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebKit.order:

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • mac/WebKit2.order:
8:02 PM Changeset in webkit [174051] by mmaxfield@apple.com
  • 3 edits in trunk/Tools

Allow webkit-patch upload to respect the --directory argument with git checkouts
​https://bugs.webkit.org/show_bug.cgi?id=137166

Reviewed by Darin Adler.

We simply hadn't plumbed it through.

  • Scripts/webkitpy/common/checkout/scm/detection.py:

(SCMDetector.detect_scm_system):

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.init):
(Git.changed_files):

7:13 PM Changeset in webkit [174050] by Chris Dumez
  • 32 edits
    2 copies in trunk/Source/WebCore

Automatically generate template specializations for most Elements
​https://bugs.webkit.org/show_bug.cgi?id=137174

Reviewed by Darin Adler.

Previously, the template specializations to make is<>() / downcast<>()
work for HTML/SVG/MathML elements were only generated if
"generateTypeHelpers" parameter was explicitly specified for the
corresponding tag name in the *Tags.in file.

We are however able to generate the template specializations for most
types so this patch drops the "generateTypeHelpers" parameter and
generates those template specializations by default.

One case we cannot generate the specialization ifor is when a class is
associated to several tag names but this patch updates the
make_names.pl script to detect this and skip those classes.

No new tests, no behavior change.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/make_names.pl:

(defaultTagPropertyHash):
(printTypeHelpers):

  • html/HTMLTagNames.in:
  • mathml/mathtags.in:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAnimateColorElement.cpp:

(WebCore::SVGAnimateColorElement::SVGAnimateColorElement):
(WebCore::SVGAnimateColorElement::determinePropertyValueTypes):

  • svg/SVGAnimateColorElement.h:
  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::~SVGAnimateElement): Deleted.
(WebCore::SVGAnimateElement::hasValidAttributeType): Deleted.
(WebCore::SVGAnimateElement::determineAnimatedPropertyType): Deleted.
(WebCore::SVGAnimateElement::calculateAnimatedValue): Deleted.
(WebCore::SVGAnimateElement::calculateToAtEndOfDurationValue): Deleted.
(WebCore::SVGAnimateElement::calculateFromAndToValues): Deleted.
(WebCore::SVGAnimateElement::calculateFromAndByValues): Deleted.
(WebCore::propertyTypesAreConsistent): Deleted.
(WebCore::SVGAnimateElement::resetAnimatedType): Deleted.
(WebCore::applyCSSPropertyToTarget): Deleted.
(WebCore::removeCSSPropertyFromTarget): Deleted.
(WebCore::applyCSSPropertyToTargetAndInstances): Deleted.
(WebCore::removeCSSPropertyFromTargetAndInstances): Deleted.
(WebCore::notifyTargetAboutAnimValChange): Deleted.
(WebCore::notifyTargetAndInstancesAboutAnimValChange): Deleted.
(WebCore::SVGAnimateElement::clearAnimatedType): Deleted.
(WebCore::SVGAnimateElement::applyResultsToTarget): Deleted.
(WebCore::SVGAnimateElement::animatedPropertyTypeSupportsAddition): Deleted.
(WebCore::SVGAnimateElement::isAdditive): Deleted.
(WebCore::SVGAnimateElement::calculateDistance): Deleted.
(WebCore::SVGAnimateElement::setTargetElement): Deleted.
(WebCore::SVGAnimateElement::setAttributeName): Deleted.
(WebCore::SVGAnimateElement::resetAnimatedPropertyType): Deleted.
(WebCore::SVGAnimateElement::ensureAnimator): Deleted.

  • svg/SVGAnimateElement.h:

(WebCore::isSVGAnimateElement): Deleted.

  • svg/SVGAnimateElementBase.cpp: Copied from Source/WebCore/svg/SVGAnimateElement.cpp.

(WebCore::SVGAnimateElementBase::SVGAnimateElementBase):
(WebCore::SVGAnimateElementBase::~SVGAnimateElementBase):
(WebCore::SVGAnimateElementBase::hasValidAttributeType):
(WebCore::SVGAnimateElementBase::determineAnimatedPropertyType):
(WebCore::SVGAnimateElementBase::calculateAnimatedValue):
(WebCore::SVGAnimateElementBase::calculateToAtEndOfDurationValue):
(WebCore::SVGAnimateElementBase::calculateFromAndToValues):
(WebCore::SVGAnimateElementBase::calculateFromAndByValues):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElementBase::resetAnimatedType):
(WebCore::applyCSSPropertyToTarget):
(WebCore::removeCSSPropertyFromTarget):
(WebCore::applyCSSPropertyToTargetAndInstances):
(WebCore::removeCSSPropertyFromTargetAndInstances):
(WebCore::notifyTargetAboutAnimValChange):
(WebCore::notifyTargetAndInstancesAboutAnimValChange):
(WebCore::SVGAnimateElementBase::clearAnimatedType):
(WebCore::SVGAnimateElementBase::applyResultsToTarget):
(WebCore::SVGAnimateElementBase::animatedPropertyTypeSupportsAddition):
(WebCore::SVGAnimateElementBase::isAdditive):
(WebCore::SVGAnimateElementBase::calculateDistance):
(WebCore::SVGAnimateElementBase::setTargetElement):
(WebCore::SVGAnimateElementBase::setAttributeName):
(WebCore::SVGAnimateElementBase::resetAnimatedPropertyType):
(WebCore::SVGAnimateElementBase::ensureAnimator):

  • svg/SVGAnimateElementBase.h: Copied from Source/WebCore/svg/SVGAnimateElement.h.

(WebCore::isSVGAnimateElementBase):

  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
(WebCore::SVGAnimateTransformElement::parseAttribute):

  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimatedAngle.cpp:
  • svg/SVGAnimatedBoolean.cpp:
  • svg/SVGAnimatedColor.cpp:
  • svg/SVGAnimatedInteger.cpp:
  • svg/SVGAnimatedIntegerOptionalInteger.cpp:
  • svg/SVGAnimatedLength.cpp:
  • svg/SVGAnimatedLengthList.cpp:
  • svg/SVGAnimatedNumber.cpp:
  • svg/SVGAnimatedNumberList.cpp:
  • svg/SVGAnimatedNumberOptionalNumber.cpp:
  • svg/SVGAnimatedPath.cpp:
  • svg/SVGAnimatedPointList.cpp:
  • svg/SVGAnimatedPreserveAspectRatio.cpp:
  • svg/SVGAnimatedRect.cpp:
  • svg/SVGAnimatedString.cpp:
  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

  • svg/SVGSetElement.cpp:

(WebCore::SVGSetElement::SVGSetElement):

  • svg/SVGSetElement.h:
  • svg/svgtags.in:
6:52 PM Changeset in webkit [174049] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

Simple ES6 feature: Number constructor extras
​https://bugs.webkit.org/show_bug.cgi?id=131707

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-09-28
Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::finishCreation): Setup constants and
functions.
(JSC::numberConstructorFuncIsFinite): Added.
(JSC::numberConstructorFuncIsInteger): Added.
(JSC::numberConstructorFuncIsNaN): Added.
(JSC::numberConstructorFuncIsSafeInteger): Added.
(JSC::NumberConstructor::getOwnPropertySlot): Deleted.
(JSC::numberConstructorNaNValue): Deleted.
(JSC::numberConstructorNegInfinity): Deleted.
(JSC::numberConstructorPosInfinity): Deleted.
(JSC::numberConstructorMaxValue): Deleted.
(JSC::numberConstructorMinValue): Deleted.

  • runtime/NumberConstructor.h:

LayoutTests:

  • js/Object-getOwnPropertyNames-expected.txt:
  • js/number-constructor-expected.txt: Added.
  • js/number-constructor.html: Added.
  • js/script-tests/Object-getOwnPropertyNames.js:
  • js/script-tests/number-constructor.js: Added.
6:18 PM Changeset in webkit [174048] by gyuyoung.kim@samsung.com
  • 12 edits in trunk/Source

Use std::unique_ptr for ContextMenuController
​https://bugs.webkit.org/show_bug.cgi?id=137178

Reviewed by Darin Adler.

Switch to using std::unique_ptr instead of OwnPtr and PassOwnPtr
for ContextMenuController class. Inherited class is changed by this use as well.

Source/WebCore:

No new tests, no behavior changes.

  • loader/EmptyClients.cpp:

(WebCore::EmptyContextMenuClient::customizeMenu):

  • loader/EmptyClients.h:
  • page/ContextMenuClient.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::clearContextMenu):
(WebCore::ContextMenuController::maybeCreateContextMenu):
(WebCore::ContextMenuController::showContextMenu):

  • page/ContextMenuController.h:

Source/WebKit/win:

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::customizeMenu):

  • WebCoreSupport/WebContextMenuClient.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::customizeMenu):

  • WebProcess/WebCoreSupport/WebContextMenuClient.h:
6:04 PM Changeset in webkit [174047] by gyuyoung.kim@samsung.com
  • 14 edits in trunk/Source

Move ColorInputType class to std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=137173

Reviewed by Darin Adler.

Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
Child classes follow this change as well.

Source/WebCore:

No new tests, no behavior changes.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::didEndChooser):

  • html/ColorInputType.h:
  • loader/EmptyClients.cpp:

(WebCore::EmptyChromeClient::createColorChooser):

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::createColorChooser):

  • page/Chrome.h:
  • page/ChromeClient.h:

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::createColorChooser):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createColorChooser):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
4:18 PM Changeset in webkit [174046] by commit-queue@webkit.org
  • 16 edits in trunk

Fix some minor typos: psuedo -> pseudo
​https://bugs.webkit.org/show_bug.cgi?id=137192

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2014-09-28
Reviewed by Alexey Proskuryakov.

PerformanceTests:

  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js:

Source/WebCore:

No new tests, no behavior change.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::specificityForOneSelector):

LayoutTests:

  • fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements-expected.txt:
  • fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html:
  • fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-expected.txt:
  • fast/dom/Window/getMatchedCSSRules-with-pseudo-elements.html:
  • fast/selectors/159.html:
  • fast/selectors/160.html:
  • fast/selectors/166.html:
  • platform/efl/fast/selectors/166-expected.txt:
  • platform/gtk/fast/selectors/166-expected.txt:
  • platform/ios-sim/fast/selectors/166-expected.txt:
  • platform/mac/fast/selectors/166-expected.txt:
1:59 PM Changeset in webkit [174045] by weinig@apple.com
  • 17 edits
    1 move
    1 delete in trunk

Replace OSObjectPtr with RetainPtr/adoptOS
​https://bugs.webkit.org/show_bug.cgi?id=137158

Reviewed by Dan Bernstein.

Source/WebKit2:

  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm:

(DatabaseServiceInitializer):

  • NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:

(WebKit::NetworkServiceInitializerDelegate::NetworkServiceInitializerDelegate):
(NetworkServiceInitializer):

  • Platform/IPC/Connection.h:

(IPC::Connection::Identifier::Identifier):

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::ConnectionTerminationWatchdog::createConnectionTerminationWatchdog):
(IPC::ConnectionTerminationWatchdog::ConnectionTerminationWatchdog):

  • PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:

(WebKit::PluginServiceInitializerDelegate::PluginServiceInitializerDelegate):
(PluginServiceInitializer):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializerDelegate::XPCServiceInitializerDelegate):
(WebKit::XPCServiceInitializer):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::checkEntitlements):
(WebKit::XPCServiceInitializerDelegate::hasEntitlement):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:

(WebKit::XPCServiceEventHandler):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):
(WebKit::connectToReExecService):

  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(WebContentServiceInitializer):

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/OSObjectPtr.h: Removed.
  • wtf/RetainPtr.h:

(WTF::adoptOS):
Added. This adopt function is slightly different than both adoptCF and adoptNS,
in that unlike adoptCF(), it can be passed an Objective-C type (since OS objects
are sometimes Objective-C objects, but not always), and unlike adoptNS() it doesn't
require us to jump through hoops to appease GC (since OS objects are not Objective-C
objects if GC is enabled).

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
  • TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.

Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.

7:07 AM WebKitGTK/2.6.x edited by berto@igalia.com
(diff)
1:23 AM Changeset in webkit [174044] by Carlos Garcia Campos
  • 1 edit
    1 move in trunk/Source/WebCore

Unreviewed. Move RenderThemeGtk.h from platform/gtk to rendering.

I forgot to move this file in r173111.

  • rendering/RenderThemeGtk.h: Renamed from Source/WebCore/platform/gtk/RenderThemeGtk.h.
1:18 AM Changeset in webkit [174043] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[ATK] WebKitAccessibleWrapperAtk should not depend on GTK
​https://bugs.webkit.org/show_bug.cgi?id=137177

Reviewed by Martin Robinson.

It's used to get the web view widget, but there's no GtkWidget in
the web process and platformPageClient is always NULL.

  • PlatformGTK.cmake: Move accessibility sources to the WebCore

sources list.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkParentOfRootObject): Remove code to get view GtkWidget.

  • editing/atk/FrameSelectionAtk.cpp: Remove unneeded header include.
1:14 AM Changeset in webkit [174042] by Carlos Garcia Campos
  • 2 edits
    2 deletes in trunk/Source/WebCore

[GTK] Remove unused GtkPluginWidget
​https://bugs.webkit.org/show_bug.cgi?id=137176

Reviewed by Csaba Osztrogonác.

It was only used by WebKit1.

  • PlatformGTK.cmake:
  • platform/gtk/GtkPluginWidget.cpp: Removed.
  • platform/gtk/GtkPluginWidget.h: Removed.
1:06 AM Changeset in webkit [174041] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebCore

[cairo] GraphicsContext should not depend on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=137175

Reviewed by Martin Robinson.

Remove the unused methods depending on GDK and simplify
GraphicsContext::drawFocusRing() using only cairo API.

  • PlatformGTK.cmake: Move GraphicsContextCairo.cpp to the webcore sources.
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawFocusRing): Iterate the rectangles
instead of creating a region for the rectangles and call gdk_cairo_region().
(WebCore::GraphicsContext::setGdkExposeEvent): Deleted.
(WebCore::GraphicsContext::gdkExposeEvent): Deleted.
(WebCore::GraphicsContext::gdkWindow): Deleted.

  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:

(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

Sep 27, 2014:

10:57 PM Changeset in webkit [174040] by Chris Dumez
  • 11 edits in trunk/Source/WebCore

HTMLPlugInElement::isUserObservable() is causing layout
​https://bugs.webkit.org/show_bug.cgi?id=137156

Reviewed by Ryosuke Niwa.

While profiling the page load of nytimes.com, I noticed that we were
spending ~4-5% of cpu time in HTMLPlugInElement::isUserObservable().
The reason is that the function calls pluginWidget(), which causes a
layout update in HTMLObjectElement::renderWidgetForJSBindings(), to
make sure the plugin is loaded and its renderer is created.

HTMLPlugInElement::isUserObservable() shouldn't need to do a layout.
This patch does the following to address the problem:

  • Rename renderWidgetForJSBindings() to renderWidgetLoadingPlugin() because this function is not always called from the JS Bindings nowadays. The new name makes it clearer that this will load the plugin if needed (to make sure the renderer is created, and by doing a layout).
  • Add a PluginLoadingPolicy argument to HTMLPlugInElement::pluginWidget() to let the caller control if the plugin should be loaded or not.
  • Update the call to pluginWidget() in isUserObservable() so that we do not attempt to load the plugin (thus not causing a layout).

No new tests, no behavior change.

  • WebCore.exp.in:
  • WebCore.order:
  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::renderWidgetLoadingPlugin):
(WebCore::HTMLAppletElement::renderWidgetForJSBindings): Deleted.

  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::renderWidgetLoadingPlugin):
(WebCore::HTMLEmbedElement::renderWidgetForJSBindings): Deleted.

  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderWidgetLoadingPlugin):
(WebCore::HTMLObjectElement::renderWidgetForJSBindings): Deleted.

  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::pluginWidget):
(WebCore::HTMLPlugInElement::isUserObservable):

  • html/HTMLPlugInElement.h:
10:21 PM Changeset in webkit [174039] by Chris Dumez
  • 22 edits in trunk/Source/WebCore

Use the new is<>() / downcast<>() for more Node subclasses
​https://bugs.webkit.org/show_bug.cgi?id=137184

Reviewed by Ryosuke Niwa.

Use the new is<>() / downcast<>() for more Node subclasses:
CDATASection, CharacterData, Comment, DocumentType,
ProcessingInstruction, and PseudoElement.

No new tests, no behavior change.

  • dom/CDATASection.h:

(WebCore::isCDATASection):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::setDataAndUpdate):

  • dom/CharacterData.h:

(WebCore::isCharacterData):

  • dom/Comment.h:

(WebCore::isComment):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/DocumentType.h:

(WebCore::isDocumentType):

  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingTargetRules):
(WebCore::nodeOrHostIfPseudoElement):

  • dom/Node.cpp:

(WebCore::markAncestorsWithChildNeedsStyleRecalc):
(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore::Node::pseudoAwareNextSibling):

  • dom/NodeTraversal.cpp:

(WebCore::NodeTraversal::previousIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):

  • dom/ProcessingInstruction.h:

(WebCore::isProcessingInstruction):

  • dom/PseudoElement.h:

(WebCore::isPseudoElement):

  • dom/Range.cpp:

(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::checkNodeWOffset):

  • editing/Editor.cpp:

(WebCore::Editor::shouldInsertFragment):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_traverseNode):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::setInnerNode):
(WebCore::HitTestResult::setInnerNonSharedNode):

  • rendering/RenderListItem.cpp:

(WebCore::enclosingList):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::generatingPseudoHostElement):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::expandedNameLocalPart):

9:13 PM Changeset in webkit [174038] by Chris Dumez
  • 8 edits in trunk/Source/WebCore

Use the new is<>() / downcast<>() for Attr Nodes
​https://bugs.webkit.org/show_bug.cgi?id=137183

Reviewed by Ryosuke Niwa.

Use the new is<>() / downcast<>() for Attr Nodes instead of isAttr() /
toAttr().

No new tests, no behavior change.

  • dom/Attr.h:

(WebCore::isAttr):

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::adoptNode):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setNamedItem):

  • dom/Node.cpp:

(WebCore::Node::compareDocumentPosition):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorNodeFinder.cpp:

(WebCore::InspectorNodeFinder::searchUsingXPath):

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::sortBlock):
(WebCore::XPath::NodeSet::sort):
(WebCore::XPath::findRootNode):

3:17 PM Changeset in webkit [174037] by Brian Burg
  • 5 edits in trunk/Source

Web Replay: Playback position updates should be sent before the next event loop input is dispatched
​https://bugs.webkit.org/show_bug.cgi?id=137162

Reviewed by Timothy Hatcher.

Source/WebCore:

To drive playback position updates in the Inspector UI, we send playbackHitPosition protocol
messages as the replay backend dispatches inputs. However, right now the semantics of that
message are muddy. The update is sent *after* the input at the offset is dispatched. This leads
to unexpected results if the debugger pauses while the input is being dispatched: the frontend
will only know about the previous (stale) playback position when the debugger pauses.

With this patch, the backend sends the playbackHitPosition(segmentOffset=n, inputOffset=m)
message when backend is about to dispatch input m, but has not yet begun to do so. Thus, any
subsequent page execution events (profiling, debugger pauses, etc) until the next
playbackHitPosition are caused by input m's being dispatched.

  • inspector/protocol/Replay.json: Clarify the message's semantics.
  • replay/ReplayController.cpp:

(WebCore::ReplayController::willDispatchInput):
(WebCore::ReplayController::didDispatchInput):

Source/WebInspectorUI:

Pausing playback from the UI was broken because of a typo. Fix this, and rename
stopPlayback to cancelPlayback.

  • UserInterface/Controllers/ReplayManager.js:

(WebInspector.ReplayManager.prototype.switchSession.if):

1:27 PM Changeset in webkit [174036] by fpizlo@apple.com
  • 8 edits
    1 add in trunk

Disable function.arguments
​https://bugs.webkit.org/show_bug.cgi?id=137167

Source/JavaScriptCore:

Rubber stamped by Geoffrey Garen.

Add an option to disable function.arguments. Add a test for disabling it.

Disabling function.arguments means that it returns an Arguments object that claims that
there were zero arguments. All other Arguments functionality still works, so any code
that tries to inspect this object will still think that it is looking at a perfectly
valid Arguments object.

This also makes function.arguments disabled by default. Note that the RJST harness will
enable them by default, to continue to get test coverage for the code that implements
the feature.

We will rip out that code once we're confident that it's really safe to remove this
feature. Only once we rip out that support will we be able to do optimizations to
leverage the lack of this feature. It's important to keep the support code, and the test
infrastructure, in place before we are confident. The logic to keep this working touches
the entire compiler and a large chunk of the runtime, so reimplementing it - or even
merging it back in - would be a nightmare. That's also basically the reason why we want
to rip it out if at all possible. It's a lot of terrible code.

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::createArguments):

  • runtime/Arguments.h:

(JSC::Arguments::create):
(JSC::Arguments::finishCreation):

  • runtime/Options.h:
  • tests/stress/disable-function-dot-arguments.js: Added.

(foo):
(bar):

Tools:

Rubber stamped by Geoffrey Garen

Enable the feature by default during tests.

  • Scripts/run-jsc-stress-tests:

LayoutTests:

Rubber stamped by Geoffrey Garen.

Don't remove the tests for this, yet - but mark them as failing. We will rebase these,
or remove them entirely, once we know that it's safe to rip out this feature entirely.

11:49 AM Changeset in webkit [174035] by benjamin@webkit.org
  • 3 edits
    8 adds in trunk

Chaining multiple :nth-child() does not work properly
​https://bugs.webkit.org/show_bug.cgi?id=137032

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-27
Reviewed by Gavin Barraclough.

Source/WebCore:

When multiple :nth-child() are chained, the evaluation of each "An+B" could depend on
the execution of the previous "An+B". The reason is that the register holding the position
of the current element could be modified by the evaluation of "An+B".

There are two cases in which the register was used as the destination of an operation:
1) When A and B are positive, the counter would be the destination of "counter - B".
2) When A is not 1 or 2, the modulo operation was not preserving the input register.

For (1), we a copy of the counter in that case of generateElementIsNthChild().

For (2), we also preserve a copy of the input if it is used by the operation. In this case,
if the input register is one of the argument we need for idiv, we preserve it on the stack
or in a register depending on what is available.

This increases the register requirements by 2 in the worst case on x86. The extra registers
can push generateElementIsNthChild() above the 4 available registers. To accomodate for that,
minimumRegisterRequirements() reserve more registers on x86.

The extra register pressure has strictly no effect on performance, x86_64 has 9 registers
available without pushing anything. The extra allocation is only necessary for debugging.

Tests: fast/selectors/nth-child-basics.html

fast/selectors/nth-child-chained.html
fast/selectors/nth-child-of-basics-2.html
fast/selectors/nth-child-of-chained.html

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::minimumRegisterRequirements):
(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):

LayoutTests:

  • fast/selectors/nth-child-chained-expected.txt: Added.
  • fast/selectors/nth-child-chained.html: Added.
  • fast/selectors/nth-child-of-chained-expected.txt: Added.
  • fast/selectors/nth-child-of-chained.html: Added.

Those new tests target specifically the register reuse bug fixed by the patch.

  • fast/selectors/nth-child-basics-expected.txt: Added.
  • fast/selectors/nth-child-basics.html: Added.
  • fast/selectors/nth-child-of-basics-2-expected.txt: Added.
  • fast/selectors/nth-child-of-basics-2.html: Added.

Those tests add coverage for the examples used by ​http://nthmaster.com. This is to increase
the general test coverage.

I added nth-child-of-basics-2.html instead of extending nth-child-of-basics.html because
of the speed issue in debug without CSS JIT (otherwise the test can timeout).

12:13 AM Changeset in webkit [174034] by mitz@apple.com
  • 5 edits in trunk

WebKit top of tree sources won't build in 10.9 w/ Xcode 6.0.1
​https://bugs.webkit.org/show_bug.cgi?id=137053

Reviewed by Mark Rowe.

.:

  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:

In the build pre-action, pass the --wksi and --llvm options to
copy-webkitlibraries-to-product-directory.

  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Ditto.

Websites/webkit.org:

  • building/build.html: Removed instructions how to work around this bug, now that it’s fixed.

Sep 26, 2014:

10:18 PM Changeset in webkit [174033] by ap@apple.com
  • 2 edits in trunk/Websites/webkit.org

WebKit top of tree sources won't build in 10.9 w/ Xcode 6.0.1
​https://bugs.webkit.org/show_bug.cgi?id=137053

Patch by David Gatwood. Reviewed, tweaked and landed by Alexey Proskuryakov.

Explain that to build from Xcode, one needs to build from command line once first.

Removed a Windows section that explained how to launch cygwin shell, which was
silly given that we then link to a long document explaining further steps.

  • building/build.html:
8:52 PM Changeset in webkit [174032] by Yusuke Suzuki
  • 2 edits in trunk/LayoutTests

Mark fast/selectors/nth-child-of-basics as Slow
​https://bugs.webkit.org/show_bug.cgi?id=137149

Reviewed by Benjamin Poulain.

Since there are many tests in fast/selectors/nth-child-of-basics,
it takes long time and sometime LayoutTests timeout[1].

[1]: ​https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20(Tests)/builds/3042

Mark fast/selectors/nth-child-of-basics as Slow.

6:32 PM Changeset in webkit [174031] by Chris Dumez
  • 97 edits in trunk/Source

Stop using legacy NODE_TYPE_CASTS() macro for HTML Elements
​https://bugs.webkit.org/show_bug.cgi?id=137137

Reviewed by Benjamin Poulain.

Source/WebCore:

Stop using legacy NODE_TYPE_CASTS() macro for HTML Elements and use the
new SPECIALIZE_TYPE_TRAITS_*() macro instead so that is<>() /
downcast<>() works for those types.

No new tests, no behavior change.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::labelForElement):
(WebCore::AccessibilityNodeObject::text):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetName):
(webkitAccessibleGetDescription):

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginInstance):
(WebCore::pluginScriptObjectFromPluginViewBase):
(WebCore::pluginScriptObject):
(WebCore::pluginElementCustomPut):
(WebCore::isPluginElement): Deleted.

  • bindings/objc/DOM.mm:

(kitClass):

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchAllRules):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::locateCousinList):
(WebCore::elementHasDirectionAuto):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::isPlaceholderShown):

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::assertConnectedSubrameCountIsConsistent):
(WebCore::collectFrameOwners):
(WebCore::disconnectSubframes):

  • dom/Document.cpp:

(WebCore::Document::adoptNode):
(WebCore::Document::setBody):
(WebCore::Document::iconURLs):
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):
(WebCore::Document::updateHoverActiveState):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Range.cpp:

(WebCore::Range::createContextualFragment):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/ApplyStyleCommand.cpp:

(WebCore::isLegacyAppleStyleSpan):
(WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute):
(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan):
(WebCore::isEmptyFontTag):
(WebCore::ApplyStyleCommand::applyBlockStyle):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeConflictingInlineStyleFromRun):
(WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
(WebCore::ApplyStyleCommand::removeInlineStyle):
(WebCore::ApplyStyleCommand::shouldSplitTextElement):
(WebCore::ApplyStyleCommand::applyInlineStyleChange):

  • editing/DeleteButtonController.cpp:

(WebCore::enclosingDeletableElement):

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::findFirstMarkable):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):
(WebCore::scanForForm):

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::mergeWithNeighboringLists):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::elementCannotHaveEndTag):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::insertAsListItems):

  • editing/TextIterator.cpp:

(WebCore::shouldEmitNewlinesBeforeAndAfterNode):
(WebCore::shouldEmitExtraNewlineForNode):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_addTableCellForElement):
(HTMLConverter::_processElement):

  • editing/htmlediting.cpp:

(WebCore::enclosingList):
(WebCore::embeddedSublist):
(WebCore::appendedSublist):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):

  • editing/mac/EditorMac.mm:

(WebCore::maybeCopyNodeAttributesToFragment):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendElement):

  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::updateAppearance):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::shadowColorSwatch):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedInto):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNamedElementCache):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::matchesReadWritePseudoClass):
(WebCore::HTMLElement::setOuterHTML):
(WebCore::elementAffectsDirectionality):
(WebCore::HTMLElement::directionality):
(WebCore::HTMLElement::dirAttributeChanged):

  • html/HTMLElement.h:

(WebCore::isHTMLElement):
(WebCore::Node::hasTagName):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::getNamedElements):

  • html/HTMLFrameElementBase.h:

(WebCore::isHTMLFrameElementBase):

  • html/HTMLFrameOwnerElement.h:

(WebCore::isHTMLFrameOwnerElement):

  • html/HTMLMediaElement.h:

(WebCore::isHTMLMediaElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::isDisabledFormControl):

  • html/HTMLPlugInElement.h:

(WebCore::isHTMLPlugInElement):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin):

  • html/HTMLPlugInImageElement.h:

(WebCore::isHTMLPlugInImageElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setOption):
(WebCore::HTMLSelectElement::setLength):
(WebCore::HTMLSelectElement::recalcListItems):

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedInto):
(WebCore::HTMLSourceElement::removedFrom):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::cellAbove):

  • html/HTMLTableCellElement.h:

(WebCore::isHTMLTableCellElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::isInSection):

  • html/HTMLTableSectionElement.h:

(WebCore::isHTMLTableSectionElement):

  • html/HTMLTagNames.in:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::enclosingTextFormControl):

  • html/HTMLTextFormControlElement.h:

(WebCore::isHTMLTextFormControlElement):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::removedFrom):
(WebCore::HTMLTrackElement::mediaElement):

  • html/LabelableElement.h:

(WebCore::isLabelableElement):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::sliderTrackElement):

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::parentMediaElement):
(WebCore::mediaControlElementType):

  • html/shadow/TextControlInnerElements.h:

(WebCore::isTextControlInnerTextElement):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorNodeFinder.cpp:

(WebCore::InspectorNodeFinder::searchUsingDOMTreeTraversal):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPhrasingContent):
(WebCore::MathMLElement::isFlowContent):
(WebCore::MathMLElement::childShouldCreateRenderer):

  • mathml/mathtags.in:
  • page/DragController.cpp:

(WebCore::DragController::canProcessDrag):

  • page/EventHandler.cpp:

(WebCore::targetIsFrame):

  • page/FocusController.cpp:

(WebCore::hasCustomFocusLogic):
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

  • page/FrameView.cpp:

(WebCore::FrameView::init):
(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):

  • page/PageSerializer.cpp:

(WebCore::isCharsetSpecifyingNode):
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):

  • page/SpatialNavigation.cpp:

(WebCore::frameOwnerElement):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absolutePDFURL):
(WebCore::HitTestResult::mediaElement):

  • rendering/RenderBlockFlow.cpp:

(WebCore::resizeTextPermitted):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::layout):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::updateSnapOffsets):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::isRestartedPlugin):

  • rendering/RenderMedia.h:

(WebCore::RenderMedia::mediaElement):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetParent):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::plugInImageElement):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement):

  • rendering/RenderThemeGtk.cpp:

(WebCore::getMediaElementFromRenderObject):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • rendering/RenderTreeAsText.cpp:

(WebCore::isEmptyOrUnstyledAppleStyleSpan):

  • rendering/RenderWidget.h:

(WebCore::RenderWidget::frameOwnerElement):

  • testing/Internals.cpp:

(WebCore::Internals::visiblePlaceholder):
(WebCore::Internals::simulateAudioInterruption):
(WebCore::Internals::isPluginSnapshotted):

  • xml/XPathStep.cpp:

(WebCore::XPath::nodeMatchesBasicTest):

Source/WebKit/win:

Use is<>() / downcast<>() where appropriate.

  • DOMHTMLClasses.cpp:

(DOMHTMLElement::idName):
(DOMHTMLElement::innerText):
(DOMHTMLElement::setInnerText):

Source/WebKit2:

Use is<>() / downcast<>() where appropriate.

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::value):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginSnapshotTimerFired):
(WebKit::PluginView::pluginDidReceiveUserInteraction):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performActionOnElement):

4:55 PM Changeset in webkit [174030] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed. More gardening on Windows tests.

  • platform/win/TestExpectations:

Enable some css3 conditional tests that are now passing.
Disable some failing hidpi tests since we don’t have hidpi test support on Windows.

4:38 PM Changeset in webkit [174029] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Add API for loading local files
​https://bugs.webkit.org/show_bug.cgi?id=137153
rdar://problem/17761459

Reviewed by Oliver Hunt.

  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView loadFileURL:allowingReadAccessToURL:]):
Load the file, wrapping the navigation ID in a WKNavigation using createLoadRequestNavigation.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadFile):

  • UIProcess/WebPageProxy.h:

Return the navigation ID (or 0 if the navigation failed).

4:25 PM Changeset in webkit [174028] by commit-queue@webkit.org
  • 19 edits in trunk/Source

Web Inspector: Automatic Inspection should continue once all breakpoints are loaded
​https://bugs.webkit.org/show_bug.cgi?id=137038

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-26
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Add a new protocol command "Inspector.initialized" that signifies to the backend
when the frontend has sent all its initialization messages to the backend. This
can include information like breakpoints, which we would want to have loaded
before any JavaScript evaluates in the context.

  • inspector/protocol/InspectorDomain.json:

New protocol command, Inspector.initialized.

  • inspector/agents/InspectorAgent.h:
  • inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::InspectorAgent):
(Inspector::InspectorAgent::initialized):
Tell the InspectorEnvironment (the Controller) the frontend has initialized.

  • inspector/InspectorEnvironment.h:

Abstract virtual method to handle frontend initialization. To be
implemented by all of the InspectorControllers.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
(Inspector::JSGlobalObjectInspectorController::frontendInitialized):
When a frontend is initialized, if it was automatic inspection unpause the debuggable.

  • inspector/remote/RemoteInspectorDebuggable.cpp:

(Inspector::RemoteInspectorDebuggable::unpauseForInitializedInspector):
Complete setup for this debuggable.

  • inspector/remote/RemoteInspectorDebuggable.h:
  • inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setup):
Move the setup complete to later, when the frontend sends an "initialized" message.

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::updateDebuggableAutomaticInspectCandidate):
Provide a longer timeout now that the frontend must send messages after the connection
has established. The longest I have seen in 600ms, but the average tends to be 200ms.
So bump the timeout to 800ms for a buffer.

(Inspector::RemoteInspector::setupSucceeded): Deleted.
(Inspector::RemoteInspector::setupCompleted):
Rename, as this happens at a slightly different time.

Source/WebCore:

Handle frontend initialization messages even though pages cannot
be automatically inspected yet.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::frontendInitialized):

  • inspector/InspectorController.h:
  • inspector/WorkerInspectorController.h:
  • page/Page.h:

(WebCore::Page::inspectorDebuggable):

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

Send the initialized message after we have sent all other setup messages,
such as enabling features and setting breakpoints.

4:18 PM Changeset in webkit [174027] by Beth Dakin
  • 2 edits in trunk/Tools

Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
​https://bugs.webkit.org/show_bug.cgi?id=137089

Reviewed by Tim Horton.

This is a little sneaky since updateWindowScaleForTest() should ensure that these
tests run at 1x, but that code does not seem to execute at the right time for
these tests, so if we just ensure we start out at 1x, that appears to fix these
tests and does not break the HiDPI tests either.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

3:54 PM Changeset in webkit [174026] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Decrease default number of child processes used by Windows.

  • Scripts/webkitpy/port/win.py:

(WinPort.default_child_processes):
Having too many seems to cause many tests to crash or timeout.
We may even need to make it have only 1 child process if we’re still seeing problems after this.

3:53 PM Changeset in webkit [174025] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG shouldn't insert store barriers when it has it on good authority that we're not storing a cell
​https://bugs.webkit.org/show_bug.cgi?id=137161

Reviewed by Mark Hahnenberg.

This looks like a 1% Octane speed-up.

  • bytecode/SpeculatedType.h:

(JSC::isNotCellSpeculation):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::insertStoreBarrier):
(JSC::DFG::FixupPhase::insertCheck):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateNotCell):

3:17 PM Changeset in webkit [174024] by bshafiei@apple.com
  • 7 edits
    5 deletes in tags/Safari-601.1.1

Roll out r172794. <rdar://problem/18447606>

3:05 PM Changeset in webkit [174023] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.1/Source/WebCore

Merged r173981. <rdar://problem/18447820>

2:57 PM Changeset in webkit [174022] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

2:53 PM Changeset in webkit [174021] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.1

New tag.

2:41 PM Changeset in webkit [174020] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Some inspector tests time out following r173992.
​https://bugs.webkit.org/show_bug.cgi?id=137157

  • platform/mac/TestExpectations:
2:39 PM Changeset in webkit [174019] by saambarati1@gmail.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Type Token View shows type information on hover when it shouldn't
​https://bugs.webkit.org/show_bug.cgi?id=137152

Reviewed by Brian J. Burg.

TypeTokenView should only show type information when there is
more than one primitive type or more than zero objects types.
This fixes a bug in checking the length of object types.

  • UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView.prototype._shouldShowPopover):

2:05 PM Changeset in webkit [174018] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r173988): Fix unused variable warning in PDFDocumentImage.cpp

Fixes the following build failure in release builds:

WebCore/platform/graphics/cg/PDFDocumentImage.cpp:230:12: error: unused variable 'pageCount' [-Werror,-Wunused-variable]

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::computeBoundsForCurrentPage): Change
ASSERT() to call pageCount().

12:02 PM Changeset in webkit [174017] by ap@apple.com
  • 2 edits in trunk/Tools

Mac EWS bots do not keep logs as promised
​https://bugs.webkit.org/show_bug.cgi?id=137151

Reviewed by Ryosuke Niwa.

  • EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
11:51 AM Changeset in webkit [174016] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2

Add WKInspector back function stubs that went missing from r173929.
My changes to WKDeprecatedFunctions.cpp got lost in the shuffle.

  • Shared/API/c/WKDeprecatedFunctions.cpp:

(WKInspectorIsDebuggingJavaScript):
(WKInspectorToggleJavaScriptDebugging):
(WKInspectorIsProfilingJavaScript):
(WKInspectorToggleJavaScriptProfiling):

11:49 AM Changeset in webkit [174015] by ap@apple.com
  • 7 edits
    1 move
    2 deletes in trunk/Tools

Get rid of webkit-queues dashboard
​https://bugs.webkit.org/show_bug.cgi?id=137141

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/app.yaml: Updated version.
  • QueueStatusServer/templates/dashboard.html: Removed.
  • QueueStatusServer/handlers/dashboard.py: Removed.
  • QueueStatusServer/main.py:

Kill it!

  • QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.

(.status-cell): Deleted.
(.status-cell:hover): Deleted.
(.status-cell.pass): Deleted.
(.status-cell.fail): Deleted.
(.status-cell.pending): Deleted.
(.status-cell.error): Deleted.

  • QueueStatusServer/stylesheets/dashboard.css: Removed.
  • QueueStatusServer/templates/activebots.html:
  • QueueStatusServer/templates/patch.html:
  • QueueStatusServer/templates/queuestatus.html:
  • QueueStatusServer/templates/recentstatus.html:

Renamed dashboard.css to common.css, and removed dashboard-only rules.

11:26 AM Changeset in webkit [174014] by Brian Burg
  • 2 edits in trunk/Source/WebCore

StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)
​https://bugs.webkit.org/show_bug.cgi?id=129642

Apply post-review comments from Alexey Proskuryakov.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::deleteEmptyDatabase): Make a thread-safe isolated copy of the string.

10:50 AM Changeset in webkit [174013] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

REGRESSION(r173929): Web inspector doesn't work after r173929 when INSPECTOR_SERVER is enabled
​https://bugs.webkit.org/show_bug.cgi?id=137150

Reviewed by Timothy Hatcher.

The inspector doesn't show any information about the inspected
page because it's sending messages to a remote frontend that is
not running.

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::WebInspector): Initialize m_remoteFrontendConnected.
(WebKit::WebInspector::sendMessageToFrontend): Send
SendMessageToRemoteFrontend message to the UI process when remote
frontend is connected, or SendMessageToFrontend message to
WebInspectorUI otherwise.
(WebKit::WebInspector::remoteFrontendConnected): Set m_remoteFrontendConnected to true.
(WebKit::WebInspector::remoteFrontendDisconnected): Set m_remoteFrontendConnected to false.

  • WebProcess/WebPage/WebInspector.h:
10:49 AM Changeset in webkit [174012] by pvarga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix typo in YARR at BOL check
​https://bugs.webkit.org/show_bug.cgi?id=137144

Reviewed by Darin Adler.

  • yarr/YarrPattern.cpp: replace bitwise and operator by logical and

(JSC::Yarr::YarrPatternConstructor::assertionBOL):

10:18 AM Changeset in webkit [174011] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

SVG -> OTF converter bug gardening
​https://bugs.webkit.org/show_bug.cgi?id=137088

Reviewed by Darin Adler.

This test fixes some (but not all) of the svg/ layout tests that never worked with the
SVG -> OTF font converter. The actual list of tests this fixes is shown below. I will be
filing bugs for the remaining issues along with the relevant tests that those issues
cause to fail.

Tests: svg/W3C-SVG-1.1/fonts-elem-05-t.svg

svg/W3C-SVG-1.1/fonts-kern-01-t.svg
svg/custom/glyph-setting-d-attribute.svg
svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html
svg/custom/skip-underline-missing-glyph.html
svg/custom/svg-fonts-fallback.xhtml
svg/custom/svg-fonts-in-text-controls.html

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendHEADTable): We use the font's minimum and maximum
bounding box information to size <textarea>s and <input>s.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): Codepoint ranges are closed.
(WebCore::SVGToOTFFontConverter::computeKerningData): Typo in appending glyphs to the
wrong set.
(WebCore::SVGToOTFFontConverter::transcodeGlyphPaths): Use the font's horizontal
origin if the glyph doesn't have one.
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): r173852 implemented vhea, vmtx,
and kern.
(WebCore::transcodeGlyphPaths): Moved inside SVGToOTFFontConverter.

10:02 AM Changeset in webkit [174010] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

iOS build fix following r173989.

  • page/ios/FrameIOS.mm:

(WebCore::ancestorRespondingToClickEvents):

9:58 AM Changeset in webkit [174009] by ap@apple.com
  • 10 edits in trunk/Tools

Get rid of Retry status in webkit-queues
​https://bugs.webkit.org/show_bug.cgi?id=137135

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/config/messages.py: Removed Retry.
  • QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it

no longer needs to check the latest status. It just always both unlocks the patch
and removes it from WorkItems.

  • QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):

I don't understand why we even needed to check for retries here, but now that there
are no retries, that code can go to /dev/null.

  • QueueStatusServer/loggers/recordpatchevent.py:

(RecordPatchEvent.started):
(RecordPatchEvent.retrying): Deleted.
Fixed retry counting, it should work for all queues now.

  • QueueStatusServer/model/queuestatus.py:

(QueueStatus.is_retry_request): Deleted. These are no more.

  • Scripts/webkitpy/common/net/statusserver_mock.py:

(MockStatusServer.release_lock):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

Did whatever it took to keep passing the tests. The particular test doesn't seem
quite right, but whatever.

  • Scripts/webkitpy/tool/commands/queues.py:

(CommitQueue.process_work_item): Instead of posting a retry status, just unlock
and let others pick up. Also, added explicit returns for clarity.
(AbstractPatchQueue._did_retry): Deleted.

9:57 AM Changeset in webkit [174008] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Don't include full path names in WebKitEnumTypes.h
​https://bugs.webkit.org/show_bug.cgi?id=137148

Reviewed by Carlos Garcia Campos.

Replace @filename@ with @basename@ in the template, since we don't
want to include the full path name in the generated header.

  • UIProcess/API/gtk/WebKitEnumTypes.h.template:
9:57 AM WebKitGTK/2.6.x edited by berto@igalia.com
(diff)
7:27 AM Changeset in webkit [174007] by jfernandez@igalia.com
  • 2 edits in trunk/Source/WebCore

[CSS Grid Layout] Empty string case already covered by containesOnlyWhiteSpace.
​https://bugs.webkit.org/show_bug.cgi?id=137146

Reviewed by Sergio Villar Senin.

When checking out for white-space only strings in the grid-template-areas
property values, it's not neccessary to check out for empty strings as
such case is already covered.

No new tests, already covered by fast/css-grid-layout/grid-template-areas-empty-string-crash.html.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTemplateAreasRow):

6:41 AM Changeset in webkit [174006] by svillar@igalia.com
  • 4 edits
    2 adds in trunk

[CSS Grid Layout] Fix the handling of infinity in track growth limits
​https://bugs.webkit.org/show_bug.cgi?id=137019

Reviewed by Darin Adler.

Source/WebCore:

The growth limit of content sized tracks is initialized to
infinity which is internally represented as -1. We were not
specialcasing this situation, and thus, -1 was used in the
computations as any other value. This change makes the code aware
of the existence of infinites (like when sorting tracks by growth
potential or when initializing the track growth limits).

There was another bug related to infinities. The code that was
replacing a infinite growth limit by a finite one was not using
the proper indexes so the tracks that were being updated were the
wrong ones.

Test: fast/css-grid-layout/grid-content-sized-columns-resolution.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::sortByGridTrackGrowthPotential):
(WebCore::RenderGrid::distributeSpaceToTracks):

LayoutTests:

  • fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt: Added.
  • fast/css-grid-layout/grid-content-sized-columns-resolution.html: Added.
  • fast/css-grid-layout/grid-item-order-in-content-sized-columns-resolution-expected.txt:
6:14 AM Changeset in webkit [174005] by Csaba Osztrogonác
  • 2 edits
    1 add in trunk/Tools

[EFL] Fix the gst-libav build on ARM Thumb2
​https://bugs.webkit.org/show_bug.cgi?id=137022

Reviewed by Zoltan Herczeg.

  • efl/jhbuild.modules:
  • efl/patches/gst-libav.patch: Added.
5:16 AM Changeset in webkit [174004] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header file.
2:50 AM Changeset in webkit [174003] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4

Merge r170997 - [GTK] Enable VIDEO_TRACK by default
​https://bugs.webkit.org/show_bug.cgi?id=134801

Reviewed by Philippe Normand.

  • Source/cmake/OptionsGTK.cmake:
1:39 AM Changeset in webkit [174002] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

[GTK] Fix support for the initial-letter CSS property to first-letter
​https://bugs.webkit.org/show_bug.cgi?id=137108

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2014-09-26
Reviewed by Alejandro G. Castro.

Source/WebCore:

Add support for cap-height to the font system.

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

Add missing GTK test expectation files after ​http://webkit.org/b/136484

  • platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
1:20 AM Changeset in webkit [174001] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Bump up dependencies not to conflict with the GTK port.
​https://bugs.webkit.org/show_bug.cgi?id=137143

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-09-26
Reviewed by Gyuyoung Kim.

Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
installing and removing different versions of libgnutls-dev, thus
hindering the development for both ports on the same machine. GTK is
using the newer version of the package, now bumping up EFL to use the
same.

  • efl/install-dependencies:
1:17 AM Changeset in webkit [174000] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4

Merge r173999 - [GTK] Enable CSS_IMAGE_SET in production builds
​https://bugs.webkit.org/show_bug.cgi?id=137142

Reviewed by Alejandro G. Castro.

This is required by the inspector to show some of the icons that
has a HiDPI variant.

  • Source/cmake/OptionsGTK.cmake:
12:39 AM Changeset in webkit [173999] by Carlos Garcia Campos
  • 2 edits in trunk

[GTK] Enable CSS_IMAGE_SET in production builds
​https://bugs.webkit.org/show_bug.cgi?id=137142

Reviewed by Alejandro G. Castro.

This is required by the inspector to show some of the icons that
has a HiDPI variant.

  • Source/cmake/OptionsGTK.cmake:
12:32 AM Changeset in webkit [173998] by Brian Burg
  • 2 edits in trunk/LayoutTests

Unreviewed gardening after r173992. Skip inspector/timelines/.

it seems to be running into unexplained nondeterminism similar to
inspector/debugger/ tests. These should be investigated together.

Sep 25, 2014:

11:24 PM Changeset in webkit [173997] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=136854

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-09-25
Reviewed by Gyuyoung Kim.

'Escape' key should exit fullscreen first and then should be used to stop page load.

  • MiniBrowser/efl/main.c:

(on_key_down):

11:03 PM Changeset in webkit [173996] by timothy@apple.com
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Show type info icon is blurry
​https://bugs.webkit.org/show_bug.cgi?id=137125

Reviewed by Darin Adler.

  • UserInterface/Images/NavigationItemTypes.svg:
  • UserInterface/Views/ScriptContentView.js:

(WebInspector.ScriptContentView):

  • UserInterface/Views/TextContentView.js:

(WebInspector.TextContentView):

  • UserInterface/Views/TextResourceContentView.js:

(WebInspector.TextResourceContentView):

10:37 PM Changeset in webkit [173995] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Mark SVG 1.1 tests are flaky.

  • platform/efl/TestExpectations:
9:31 PM Changeset in webkit [173994] by saambarati1@gmail.com
  • 5 edits in trunk/Source

Web Inspector: console.assert(bitString) TypeSet:50
​https://bugs.webkit.org/show_bug.cgi?id=137051

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

This patch creates stricter requirements on a TypeDescription
being valid. To be valid, a TypeDescription now ensures that
the TypeSet it describes has non null type information.

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

  • runtime/TypeSet.h:

(JSC::TypeSet::isEmpty):

Source/WebInspectorUI:

This fixes TypeSet's isContainedIn method by ensuring that
the type bit string isn't zero because the test would trivially
pass if the bit string is zero.

  • UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet.prototype.isContainedIn):

8:59 PM Changeset in webkit [173993] by fpizlo@apple.com
  • 51 edits
    52 adds in trunk

FTL should sink object allocations
​https://bugs.webkit.org/show_bug.cgi?id=136330

Reviewed by Oliver Hunt.
Source/JavaScriptCore:


This adds a comprehensive infrastructure for sinking object allocations in DFG SSA form. The
ultimate goal of sinking is to sink an allocation "past the points of its death" - i.e. to
eliminate it completely. The way sinking reasons about the CFG means that it resembles a
partial escape analysis: we create paths through a function where some allocation(s) don't
have to be done at all even if there are other paths along which those allocations still have
to happen. But it also produces other side benefits. Even if an allocation isn't eliminated
along any path, the act of sinking reduces the number of barriers that have to execute.

Because this was a fairly ambituous SSA analysis and transformation, I added a bunch of C++11
sugar to the DFG's internal APIs to allow for easier iteration over blocks, nodes, and
successors; and to add more functor goodness to allow for more lambdas.

This is just the beginning. The bug has a bunch of other bugs that depend on it. So far this
is a spectacular speed-up on microbenchmarks but it's still too limited to affect big
benchmarks. For example, doing o == p makes the sinking phase think that o and p escape.
That's just an omission and there are likely others; we can easily fix them. I think it's
best to land it in its current form and then to worry about the big benchmarks in subsequent
work (see bug 137126).

(JSC::StructureSet::iterator::iterator):
(JSC::StructureSet::iterator::operator*):
(JSC::StructureSet::iterator::operator++):
(JSC::StructureSet::iterator::operator==):
(JSC::StructureSet::iterator::operator!=):
(JSC::StructureSet::begin):
(JSC::StructureSet::end):

  • dfg/DFGAbstractInterpreter.h:

(JSC::DFG::AbstractInterpreter::phiChildren):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::AbstractInterpreter):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::startExecuting):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::execute):

  • dfg/DFGAvailability.h:

(JSC::DFG::Availability::shouldUseNode):
(JSC::DFG::Availability::isFlushUseful):
(JSC::DFG::Availability::isDead):
(JSC::DFG::Availability::operator!=):

  • dfg/DFGAvailabilityMap.cpp: Added.

(JSC::DFG::AvailabilityMap::prune):
(JSC::DFG::AvailabilityMap::clear):
(JSC::DFG::AvailabilityMap::dump):
(JSC::DFG::AvailabilityMap::operator==):
(JSC::DFG::AvailabilityMap::merge):

  • dfg/DFGAvailabilityMap.h: Added.

(JSC::DFG::AvailabilityMap::forEachAvailability):

  • dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::SSAData::SSAData):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::begin):
(JSC::DFG::BasicBlock::end):
(JSC::DFG::BasicBlock::SuccessorsIterable::SuccessorsIterable):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::iterator):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator*):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator++):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator==):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator!=):
(JSC::DFG::BasicBlock::SuccessorsIterable::begin):
(JSC::DFG::BasicBlock::SuccessorsIterable::end):
(JSC::DFG::BasicBlock::successors):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGFlushedAt.cpp:

(JSC::DFG::FlushedAt::dump):

  • dfg/DFGFlushedAt.h:

(JSC::DFG::FlushedAt::FlushedAt):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::mergeRelevantToOSR):
(JSC::DFG::Graph::invalidateCFG):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::NaturalBlockIterable::NaturalBlockIterable):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::iterator):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator*):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator++):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator==):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator!=):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::findNext):
(JSC::DFG::Graph::NaturalBlockIterable::begin):
(JSC::DFG::Graph::NaturalBlockIterable::end):
(JSC::DFG::Graph::blocksInNaturalOrder):
(JSC::DFG::Graph::doToChildrenWithNode):
(JSC::DFG::Graph::doToChildren):

  • dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

  • dfg/DFGHeapLocation.h:
  • dfg/DFGInsertOSRHintsForUpdate.cpp: Added.

(JSC::DFG::insertOSRHintsForUpdate):

  • dfg/DFGInsertOSRHintsForUpdate.h: Added.
  • dfg/DFGInsertionSet.h:

(JSC::DFG::InsertionSet::graph):

  • dfg/DFGMayExit.cpp:

(JSC::DFG::mayExit):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToPutByOffsetHint):
(JSC::DFG::Node::convertToPutStructureHint):
(JSC::DFG::Node::convertToPhantomNewObject):
(JSC::DFG::Node::isCellConstant):
(JSC::DFG::Node::castConstant):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::hasObjectMaterializationData):
(JSC::DFG::Node::objectMaterializationData):
(JSC::DFG::Node::isPhantomObjectAllocation):

  • dfg/DFGNodeType.h:
  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
(JSC::DFG::LocalOSRAvailabilityCalculator::endBlock):
(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

  • dfg/DFGOSRAvailabilityAnalysisPhase.h:
  • dfg/DFGObjectAllocationSinkingPhase.cpp: Added.

(JSC::DFG::ObjectAllocationSinkingPhase::ObjectAllocationSinkingPhase):
(JSC::DFG::ObjectAllocationSinkingPhase::run):
(JSC::DFG::ObjectAllocationSinkingPhase::performSinking):
(JSC::DFG::ObjectAllocationSinkingPhase::determineMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::placeMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::lowerNonReadingOperationsOnPhantomAllocations):
(JSC::DFG::ObjectAllocationSinkingPhase::promoteSunkenFields):
(JSC::DFG::ObjectAllocationSinkingPhase::resolve):
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):
(JSC::DFG::ObjectAllocationSinkingPhase::createMaterialize):
(JSC::DFG::ObjectAllocationSinkingPhase::populateMaterialize):
(JSC::DFG::performObjectAllocationSinking):

  • dfg/DFGObjectAllocationSinkingPhase.h: Added.
  • dfg/DFGObjectMaterializationData.cpp: Added.

(JSC::DFG::PhantomPropertyValue::dump):
(JSC::DFG::ObjectMaterializationData::dump):
(JSC::DFG::ObjectMaterializationData::oneWaySimilarityScore):
(JSC::DFG::ObjectMaterializationData::similarityScore):

  • dfg/DFGObjectMaterializationData.h: Added.

(JSC::DFG::PhantomPropertyValue::PhantomPropertyValue):
(JSC::DFG::PhantomPropertyValue::operator==):

  • dfg/DFGPhantomCanonicalizationPhase.cpp:

(JSC::DFG::PhantomCanonicalizationPhase::run):

  • dfg/DFGPhantomRemovalPhase.cpp:

(JSC::DFG::PhantomRemovalPhase::run):

  • dfg/DFGPhiChildren.cpp: Added.

(JSC::DFG::PhiChildren::PhiChildren):
(JSC::DFG::PhiChildren::~PhiChildren):
(JSC::DFG::PhiChildren::upsilonsOf):

  • dfg/DFGPhiChildren.h: Added.

(JSC::DFG::PhiChildren::forAllIncomingValues):
(JSC::DFG::PhiChildren::forAllTransitiveIncomingValues):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPrePostNumbering.cpp: Added.

(JSC::DFG::PrePostNumbering::PrePostNumbering):
(JSC::DFG::PrePostNumbering::~PrePostNumbering):
(JSC::DFG::PrePostNumbering::compute):
(WTF::printInternal):

  • dfg/DFGPrePostNumbering.h: Added.

(JSC::DFG::PrePostNumbering::preNumber):
(JSC::DFG::PrePostNumbering::postNumber):
(JSC::DFG::PrePostNumbering::isStrictAncestorOf):
(JSC::DFG::PrePostNumbering::isAncestorOf):
(JSC::DFG::PrePostNumbering::isStrictDescendantOf):
(JSC::DFG::PrePostNumbering::isDescendantOf):
(JSC::DFG::PrePostNumbering::edgeKind):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGPromoteHeapAccess.h: Added.

(JSC::DFG::promoteHeapAccess):

  • dfg/DFGPromotedHeapLocation.cpp: Added.

(JSC::DFG::PromotedLocationDescriptor::dump):
(JSC::DFG::PromotedHeapLocation::createHint):
(JSC::DFG::PromotedHeapLocation::dump):
(WTF::printInternal):

  • dfg/DFGPromotedHeapLocation.h: Added.

(JSC::DFG::PromotedLocationDescriptor::PromotedLocationDescriptor):
(JSC::DFG::PromotedLocationDescriptor::operator!):
(JSC::DFG::PromotedLocationDescriptor::kind):
(JSC::DFG::PromotedLocationDescriptor::info):
(JSC::DFG::PromotedLocationDescriptor::hash):
(JSC::DFG::PromotedLocationDescriptor::operator==):
(JSC::DFG::PromotedLocationDescriptor::operator!=):
(JSC::DFG::PromotedLocationDescriptor::isHashTableDeletedValue):
(JSC::DFG::PromotedHeapLocation::PromotedHeapLocation):
(JSC::DFG::PromotedHeapLocation::operator!):
(JSC::DFG::PromotedHeapLocation::kind):
(JSC::DFG::PromotedHeapLocation::base):
(JSC::DFG::PromotedHeapLocation::info):
(JSC::DFG::PromotedHeapLocation::descriptor):
(JSC::DFG::PromotedHeapLocation::hash):
(JSC::DFG::PromotedHeapLocation::operator==):
(JSC::DFG::PromotedHeapLocation::isHashTableDeletedValue):
(JSC::DFG::PromotedHeapLocationHash::hash):
(JSC::DFG::PromotedHeapLocationHash::equal):

  • dfg/DFGSSACalculator.cpp:

(JSC::DFG::SSACalculator::reset):

  • dfg/DFGSSACalculator.h:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureRegistrationPhase.cpp:

(JSC::DFG::StructureRegistrationPhase::run):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLExitPropertyValue.cpp: Added.

(JSC::FTL::ExitPropertyValue::dump):

  • ftl/FTLExitPropertyValue.h: Added.

(JSC::FTL::ExitPropertyValue::ExitPropertyValue):
(JSC::FTL::ExitPropertyValue::operator!):
(JSC::FTL::ExitPropertyValue::location):
(JSC::FTL::ExitPropertyValue::value):

  • ftl/FTLExitTimeObjectMaterialization.cpp: Added.

(JSC::FTL::ExitTimeObjectMaterialization::ExitTimeObjectMaterialization):
(JSC::FTL::ExitTimeObjectMaterialization::~ExitTimeObjectMaterialization):
(JSC::FTL::ExitTimeObjectMaterialization::add):
(JSC::FTL::ExitTimeObjectMaterialization::get):
(JSC::FTL::ExitTimeObjectMaterialization::dump):

  • ftl/FTLExitTimeObjectMaterialization.h: Added.

(JSC::FTL::ExitTimeObjectMaterialization::type):
(JSC::FTL::ExitTimeObjectMaterialization::properties):

  • ftl/FTLExitValue.cpp:

(JSC::FTL::ExitValue::materializeNewObject):
(JSC::FTL::ExitValue::dumpInContext):

  • ftl/FTLExitValue.h:

(JSC::FTL::ExitValue::isObjectMaterialization):
(JSC::FTL::ExitValue::objectMaterialization):
(JSC::FTL::ExitValue::withVirtualRegister):
(JSC::FTL::ExitValue::valueFormat):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileArrayifyToStructure):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructureImmediate):
(JSC::FTL::LowerDFGToLLVM::compileMaterializeNewObject):
(JSC::FTL::LowerDFGToLLVM::checkStructure):
(JSC::FTL::LowerDFGToLLVM::allocateCell):
(JSC::FTL::LowerDFGToLLVM::storeStructure):
(JSC::FTL::LowerDFGToLLVM::allocateObject):
(JSC::FTL::LowerDFGToLLVM::speculateStringObjectForStructureID):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::exitValueForAvailability):
(JSC::FTL::LowerDFGToLLVM::exitValueForNode):
(JSC::FTL::LowerDFGToLLVM::weakStructureID):
(JSC::FTL::LowerDFGToLLVM::weakStructure):
(JSC::FTL::LowerDFGToLLVM::availabilityMap):
(JSC::FTL::LowerDFGToLLVM::availability): Deleted.

  • ftl/FTLOSRExit.h:
  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileRecovery):
(JSC::FTL::compileStub):

  • ftl/FTLOperations.cpp: Added.

(JSC::FTL::operationNewObjectWithButterfly):
(JSC::FTL::operationMaterializeObjectInOSR):

  • ftl/FTLOperations.h: Added.
  • ftl/FTLSwitchCase.h:

(JSC::FTL::SwitchCase::SwitchCase):

  • runtime/JSObject.h:

(JSC::JSObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSFinalObject::create):

  • runtime/Structure.cpp:

(JSC::Structure::canUseForAllocationsOf):

  • runtime/Structure.h:
  • tests/stress/elidable-new-object-roflcopter-then-exit.js: Added.

(sumOfArithSeries):
(foo):

  • tests/stress/elide-new-object-dag-then-exit.js: Added.

(sumOfArithSeries):
(bar):
(verify):
(foo):

  • tests/stress/obviously-elidable-new-object-then-exit.js: Added.

(sumOfArithSeries):
(foo):

Source/WTF:


Make it possible to reset a Bag.

  • wtf/Bag.h:

(WTF::Bag::Bag):
(WTF::Bag::~Bag):
(WTF::Bag::clear):

LayoutTests:

  • js/math-denorm.html: Added.
  • js/regress/elidable-new-object-dag-expected.txt: Added.
  • js/regress/elidable-new-object-dag.html: Added.
  • js/regress/elidable-new-object-roflcopter-expected.txt: Added.
  • js/regress/elidable-new-object-roflcopter.html: Added.
  • js/regress/elidable-new-object-tree-expected.txt: Added.
  • js/regress/elidable-new-object-tree.html: Added.
  • js/regress/obvious-sink-pathology-expected.txt: Added.
  • js/regress/obvious-sink-pathology-taken-expected.txt: Added.
  • js/regress/obvious-sink-pathology-taken.html: Added.
  • js/regress/obvious-sink-pathology.html: Added.
  • js/regress/obviously-elidable-new-object-expected.txt: Added.
  • js/regress/obviously-elidable-new-object.html: Added.
  • js/regress/script-tests/elidable-new-object-dag.js: Added.

(sumOfArithSeries):
(foo):

  • js/regress/script-tests/elidable-new-object-roflcopter.js: Added.

(sumOfArithSeries):
(foo):

  • js/regress/script-tests/elidable-new-object-tree.js: Added.

(sumOfArithSeries):
(foo):

  • js/regress/script-tests/obvious-sink-pathology-taken.js: Added.

(sumOfArithSeries):
(bar):
(foo):

  • js/regress/script-tests/obvious-sink-pathology.js: Added.

(sumOfArithSeries):
(bar):
(foo):

  • js/regress/script-tests/obviously-elidable-new-object.js: Added.

(sumOfArithSeries):
(foo):

  • js/regress/script-tests/sinkable-new-object-dag.js: Added.

(sumOfArithSeries):
(verify):
(foo):

  • js/regress/script-tests/sinkable-new-object-taken.js: Added.

(sumOfArithSeries):
(bar):
(foo):

  • js/regress/script-tests/sinkable-new-object.js: Added.

(sumOfArithSeries):
(bar):
(foo):

  • js/regress/sinkable-new-object-dag-expected.txt: Added.
  • js/regress/sinkable-new-object-dag.html: Added.
  • js/regress/sinkable-new-object-expected.txt: Added.
  • js/regress/sinkable-new-object-taken-expected.txt: Added.
  • js/regress/sinkable-new-object-taken.html: Added.
  • js/regress/sinkable-new-object.html: Added.
7:29 PM Changeset in webkit [173992] by Brian Burg
  • 6 edits
    3 adds in trunk

Web Inspector: FunctionCall timeline records omit profile data if the debugger has paused
​https://bugs.webkit.org/show_bug.cgi?id=136805

Reviewed by Timothy Hatcher.

Source/WebCore:

TimelineAgent was mismanaging its call stack depth counter, which caused nested FunctionCall
records to steal the parent FunctionCall's captured profile in the child's didCallFunction().
Thus, the top FunctionCall node had no profile data and nested FunctionCall nodes each had
their own profiles. The frontend expected just one profile, so it didn't show anything when
it couldn't be found.

Test: inspector/timeline/debugger-paused-while-recording.html

  • inspector/InspectorTimelineAgent.cpp: Rename m_recordingProfileDepth to m_callStackDepth.

(WebCore::InspectorTimelineAgent::willCallFunction): Fix the call stack depth management.
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:

Source/WebInspectorUI:

  • UserInterface/Test.html: Add missing include for ScopeChainNode.js.

LayoutTests:

Add a test to see that script timeline records contain profiles even when
the debugger pauses during timeline capturing.

  • inspector/timeline/debugger-paused-while-recording-expected.txt: Added.
  • inspector/timeline/debugger-paused-while-recording.html: Added.
  • inspector/timeline/resources/timeline-helper.js: Added.

(callFunction):
(hook):

7:20 PM Changeset in webkit [173991] by Brian Burg
  • 4 edits in trunk

StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)
​https://bugs.webkit.org/show_bug.cgi?id=129642

Reviewed by Brady Eidson.

Source/WebCore:

When tearing down the inspector frontend's page, we trigger a threading violation
in StorageAreaSync's final sync code underneath StorageAreaSync::deleteEmptyDatabase().

No new tests. Regression is covered by inspector/test-harness-trivially-works.html.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::deleteEmptyDatabase): add a missing callOnMainThread() when
calling StorageTracker::deleteOriginWithIdentifier().

LayoutTests:

Remove the blanket Skip for all tests in inspector/.

  • TestExpectations: clean up expectations for inspector/ and add new tracking bugs.
6:09 PM Changeset in webkit [173990] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebKit2

Clean up unused parameter warnings
​https://bugs.webkit.org/show_bug.cgi?id=137107

Reviewed by Benjamin Poulain.

  • Scripts/webkit/messages.py:

(generate_message_handler):
Sometimes generated code doesn't use connection parameter. So UNUSED_PARAM(connection) is necessary.

  • UIProcess/API/C/WKPage.cpp:

(WKPageIsPlayingAudio):

6:00 PM Changeset in webkit [173989] by commit-queue@webkit.org
  • 12 edits in trunk

Unprefix CSS cursor values zoom-in and zoom-out.
​https://bugs.webkit.org/show_bug.cgi?id=137061

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2014-09-25
Reviewed by Benjamin Poulain.

Source/WebCore:

This patch unprefixes CSS cursor values zoom-in and zoom-out.
-webkit-zoom-in and -webkit-zoom-out are kept as aliases.
ECursor members use InterCaps with an initial capital letter for now.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ECursor):

  • css/CSSValueKeywords.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::restoreImageSize):
(WebCore::ImageDocument::windowSizeChanged):

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Add test cases for zoom-in, zoom-out, -webkit-zoom-in, -webkit-zoom-out.

  • fast/css/cursor-parsing-expected.txt:
  • fast/css/cursor-parsing.html:
5:39 PM Changeset in webkit [173988] by Brent Fulgham
  • 57 edits in trunk/Source

[Win] Debug builds of TestWebKitAPI are crashing.
​https://bugs.webkit.org/show_bug.cgi?id=133553

Reviewed by Dean Jackson.

../WebCore:

Avoid crash on shutdown due to invalid mutex state in the
HashMap debug implementation during a static destruction operation.

  • dom/Node.cpp:

(WebCore::ignoreSet): Convert static value into a NeverDestroyed.
(WebCore::Node::trackForDebugging): Use new NeverDestroyed call.
(WebCore::Node::~Node): Ditto.

../WebKit/win:

Switch from global static HashTable to a NeverDestroyed object.
Modify all accessors of the global static to use the new
NeverDestroyed accessor method.

  • AccessibleBase.cpp:

(AccessibleBase::AccessibleBase):
(AccessibleBase::~AccessibleBase):

  • CFDictionaryPropertyBag.cpp:

(CFDictionaryPropertyBag::CFDictionaryPropertyBag):
(CFDictionaryPropertyBag::~CFDictionaryPropertyBag):

  • DefaultDownloadDelegate.cpp:

(DefaultDownloadDelegate::DefaultDownloadDelegate):
(DefaultDownloadDelegate::~DefaultDownloadDelegate):

  • DefaultPolicyDelegate.cpp:

(DefaultPolicyDelegate::DefaultPolicyDelegate):
(DefaultPolicyDelegate::~DefaultPolicyDelegate):

  • MemoryStream.cpp:

(MemoryStream::MemoryStream):
(MemoryStream::~MemoryStream):

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::WebActionPropertyBag):
(WebActionPropertyBag::~WebActionPropertyBag):

  • WebArchive.cpp:

(WebArchive::WebArchive):
(WebArchive::~WebArchive):

  • WebBackForwardList.cpp:

(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::~WebBackForwardList):

  • WebCache.cpp:

(WebCache::WebCache):
(WebCache::~WebCache):

  • WebCookieManager.cpp:

(WebCookieManager::WebCookieManager):
(WebCookieManager::~WebCookieManager):

  • WebCoreStatistics.cpp:

(WebCoreStatistics::WebCoreStatistics):
(WebCoreStatistics::~WebCoreStatistics):

  • WebDataSource.cpp:

(WebDataSource::~WebDataSource):

  • WebDatabaseManager.cpp:

(WebDatabaseManager::WebDatabaseManager):
(WebDatabaseManager::~WebDatabaseManager):

  • WebDocumentLoader.cpp:

(WebDocumentLoader::WebDocumentLoader):
(WebDocumentLoader::~WebDocumentLoader):

  • WebDownload.cpp:

(WebDownload::WebDownload):
(WebDownload::~WebDownload):

  • WebDropSource.cpp:

(WebDropSource::WebDropSource):
(WebDropSource::~WebDropSource):

  • WebElementPropertyBag.cpp:

(WebElementPropertyBag::WebElementPropertyBag):
(WebElementPropertyBag::~WebElementPropertyBag):

  • WebError.cpp:

(WebError::WebError):
(WebError::~WebError):

  • WebFrame.cpp:

(WebFrame::WebFrame):
(WebFrame::~WebFrame):

  • WebFramePolicyListener.cpp:

(WebFramePolicyListener::WebFramePolicyListener):
(WebFramePolicyListener::~WebFramePolicyListener):

  • WebGeolocationPolicyListener.cpp:

(WebGeolocationPolicyListener::WebGeolocationPolicyListener):
(WebGeolocationPolicyListener::~WebGeolocationPolicyListener):

  • WebGeolocationPosition.cpp:

(WebGeolocationPosition::WebGeolocationPosition):
(WebGeolocationPosition::~WebGeolocationPosition):

  • WebHTMLRepresentation.cpp:

(WebHTMLRepresentation::WebHTMLRepresentation):
(WebHTMLRepresentation::~WebHTMLRepresentation):

  • WebHistory.cpp:

(WebHistory::WebHistory):
(WebHistory::~WebHistory):

  • WebHistoryItem.cpp:

(WebHistoryItem::WebHistoryItem):
(WebHistoryItem::~WebHistoryItem):

  • WebIconDatabase.cpp:

(WebIconDatabase::WebIconDatabase):
(WebIconDatabase::~WebIconDatabase):

(WebInspector::WebInspector):
(WebInspector::~WebInspector):

  • WebJavaScriptCollector.cpp:

(WebJavaScriptCollector::WebJavaScriptCollector):
(WebJavaScriptCollector::~WebJavaScriptCollector):

  • WebKitClassFactory.cpp:

(WebKitClassFactory::WebKitClassFactory):
(WebKitClassFactory::~WebKitClassFactory):

  • WebKitDLL.cpp: Also switch to NeverDestroyed HashTable for

the global class name count.

  • WebKitDLL.h:
  • WebKitStatistics.cpp:

(WebKitStatistics::WebKitStatistics):
(WebKitStatistics::~WebKitStatistics):
(WebKitStatistics::comClassNameCounts):

  • WebMutableURLRequest.cpp:

(WebMutableURLRequest::WebMutableURLRequest):
(WebMutableURLRequest::~WebMutableURLRequest):

  • WebNavigationData.cpp:

(WebNavigationData::WebNavigationData):
(WebNavigationData::~WebNavigationData):

  • WebNotification.cpp:

(WebNotification::WebNotification):
(WebNotification::~WebNotification):

  • WebNotificationCenter.cpp:

(WebNotificationCenter::WebNotificationCenter):
(WebNotificationCenter::~WebNotificationCenter):

  • WebPreferences.cpp:

(webPreferencesInstances):
(WebPreferences::WebPreferences):
(WebPreferences::~WebPreferences):
(WebPreferences::getInstanceForIdentifier):
(WebPreferences::setInstance):
(WebPreferences::removeReferenceForIdentifier):

  • WebResource.cpp:

(WebResource::WebResource):
(WebResource::~WebResource):

  • WebScriptObject.cpp:

(WebScriptObject::WebScriptObject):
(WebScriptObject::~WebScriptObject):

  • WebScriptWorld.cpp:

(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::~WebScriptWorld):

  • WebSecurityOrigin.cpp:

(WebSecurityOrigin::WebSecurityOrigin):
(WebSecurityOrigin::~WebSecurityOrigin):

  • WebSerializedJSValue.cpp:

(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::~WebSerializedJSValue):

  • WebTextRenderer.cpp:

(WebTextRenderer::WebTextRenderer):
(WebTextRenderer::~WebTextRenderer):

  • WebURLAuthenticationChallenge.cpp:

(WebURLAuthenticationChallenge::WebURLAuthenticationChallenge):
(WebURLAuthenticationChallenge::~WebURLAuthenticationChallenge):

  • WebURLAuthenticationChallengeSender.cpp:

(WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
(WebURLAuthenticationChallengeSender::~WebURLAuthenticationChallengeSender):

  • WebURLCredential.cpp:

(WebURLCredential::WebURLCredential):
(WebURLCredential::~WebURLCredential):

  • WebURLProtectionSpace.cpp:

(WebURLProtectionSpace::WebURLProtectionSpace):
(WebURLProtectionSpace::~WebURLProtectionSpace):

  • WebURLResponse.cpp:

(:m_refCount):
(WebURLResponse::~WebURLResponse):

  • WebUserContentURLPattern.cpp:

(WebUserContentURLPattern::WebUserContentURLPattern):
(WebUserContentURLPattern::~WebUserContentURLPattern):

  • WebView.cpp:

(pendingDeleteBackingStoreSet): Switch from a global static
value to a NeverDestroyed object wrapped by an accessor function.
(WebView::WebView): Ditto.
(WebView::~WebView): Ditto.
(WebView::deleteBackingStore): Ditto.
(WebView::deleteBackingStoreSoon): Ditto,
(WebView::cancelDeleteBackingStoreSoon): Ditto.

  • WebWorkersPrivate.cpp: Switch from a global static value for

the preferences objects t a NeverDestroyed container.
(WebWorkersPrivate::WebWorkersPrivate): Ditto.
(WebWorkersPrivate::~WebWorkersPrivate): Ditto.

5:34 PM Changeset in webkit [173987] by Chris Dumez
  • 9 edits in trunk/Source/WebCore

Add support for is<SVGDocument>() / downcast<SVGDocument>()
​https://bugs.webkit.org/show_bug.cgi?id=137128

Reviewed by Ryosuke Niwa.

Add support for is<SVGDocument>() / downcast<SVGDocument>() by using
the SPECIALIZE_TYPE_TRAITS_*() macro, instead of the
DOCUMENT_TYPE_CASTS() one.

No new tests, no behavior change.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::getSVGDocument):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):

  • svg/SVGDocument.h:

(WebCore::isSVGDocument):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasSingleSecurityOrigin):
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::embeddedContentBox):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):

5:34 PM Changeset in webkit [173986] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] 64-bit build fix after r173929.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
5:29 PM Changeset in webkit [173985] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip quicktime-plugin-snapshotted.html
Quicktime plugin snapshotting is now covered by all other snapshotting tests
and this test in particular seems to fail only on a few bots.

  • platform/mac/TestExpectations:
5:22 PM Changeset in webkit [173984] by roger_fong@apple.com
  • 2 edits in trunk/Source/WTF

[Windows] Unreviewed build fix. Ensure that python2.7 is used for Windows builds.

  • WTF.vcxproj/WTFGenerated.make:
5:04 PM Changeset in webkit [173983] by dino@apple.com
  • 2 edits in trunk/Tools

Add Said to the contributors list so his name completes in bugzilla.

  • Scripts/webkitpy/common/config/contributors.json:
5:03 PM Changeset in webkit [173982] by commit-queue@webkit.org
  • 5 edits in trunk

Rename CSSKeyframesRule insertRule to appendRule (57910)
​https://bugs.webkit.org/show_bug.cgi?id=57910

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2014-09-25
Reviewed by Dean Jackson.

Source/WebCore:

Tests: animations/change-keyframes.html

  • css/WebKitCSSKeyframesRule.h:

(WebCore::WebKitCSSKeyframesRule::appendRule):
-- Make WebKitCSSKeyframesRule::appendRule to be an alias of WebKitCSSKeyframesRule::insertRule()

to conform with CSS specs

  • css/WebKitCSSKeyframesRule.idl:

-- Add the new method WebKitCSSKeyframesRule::appendRule() but keep the original method

WebKitCSSKeyframesRule::appendRule() to not break exiting customers' pages.

LayoutTests:

  • animations/change-keyframes.html:

-- Ensure both WebKitCSSKeyframesRule methods insertRule() and appendRule() are

both supported.

4:49 PM Changeset in webkit [173981] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Null deref in setStateScrollingNodeSnapOffsetsAsFloat
​https://bugs.webkit.org/show_bug.cgi?id=137133
<rdar://problem/18447820>

Reviewed by Beth Dakin.

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode):
Get the deviceScaleFactor from m_page instead of various other places,
because scrolledContentsLayer can be null in the case of non-composited
overflow scroll.

4:37 PM Changeset in webkit [173980] by Chris Dumez
  • 91 edits in trunk/Source

Use is<HTML*Element>() instead of isHTML*Element() - Part 2
​https://bugs.webkit.org/show_bug.cgi?id=137103

Reviewed by Benjamin Poulain.

Source/WebCore:

Use is<HTML*Element>() instead of isHTML*Element() and drop support for
the generated isHTML*Element() macros.

No new tests, no behavior change.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isEnabled):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::anchorElement):
(WebCore::AccessibilityNodeObject::alternativeText):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::labelElementContainer):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
(WebCore::AccessibilityRenderObject::isLinked):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableElement):
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::title):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetCaption):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

  • css/CSSStyleSheet.cpp:

(WebCore::isAcceptableCSSStyleSheetParent):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::getNamedItem):

  • dom/CurrentScriptIncrementer.h:

(WebCore::CurrentScriptIncrementer::CurrentScriptIncrementer):

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDragImage):

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::keyMatchesLabelForAttribute):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Node.cpp:

(WebCore::Node::enclosingLinkEventParentOrSelf):

  • dom/Position.cpp:

(WebCore::endsOfNodeAreVisuallyDistinctPositions):

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/VisitedLinkState.cpp:

(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):

  • editing/Editor.cpp:

(WebCore::imageElementFromImageDocument):

  • editing/FrameSelection.cpp:

(WebCore::scanForForm):

  • editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::removeHeadContents):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_processElement):

  • editing/htmlediting.cpp:

(WebCore::isNonTableCellHTMLBlockElement):

  • editing/markup.cpp:

(WebCore::ancestorToRetainStructureAndAppearanceForBlock):
(WebCore::collectElementsToRemoveFromFragment):

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm):

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::imageElement):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::setBgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::setFgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::setAlinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::setLinkColor):
(WebCore::HTMLDocument::vlinkColor):
(WebCore::HTMLDocument::setVlinkColor):
(WebCore::HTMLDocument::isFrameSet):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerHTML):

  • html/HTMLFieldSetElement.cpp:

(WebCore::updateFromControlElementsAncestorDisabledStateUnder):
(WebCore::HTMLFieldSetElement::disabledStateChanged):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::computeIsDisabledByFieldsetAncestor):

  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):
(WebCore::HTMLFormControlsCollection::namedItem):
(WebCore::HTMLFormControlsCollection::updateNamedElementCache):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::rendererIsNeeded):

  • html/HTMLFrameElementBase.h:

(WebCore::isHTMLFrameElementBase):

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::dispatchLoadEvent):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::dataList):

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::virtualForm):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLNameCollection.cpp:

(WebCore::WindowNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::ownerDataListElement):
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
(WebCore::HTMLOptionElement::isDisabledFormControl):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::findParentTable):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::rowAfter):
(WebCore::HTMLTableRowsCollection::lastRow):

  • html/HTMLTagNames.in:
  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::elementMatches):

  • html/MediaDocument.cpp:

(WebCore::descendentVideoElement):
(WebCore::ancestorVideoElement):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag):
(WebCore::insert):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::ownerDocumentForCurrentNode):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

  • page/DragController.cpp:

(WebCore::DragController::draggableElement):

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::areElementsOnSameLine):

  • page/ios/FrameIOS.mm:

(WebCore::ancestorRespondingToClickEvents):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::mediaSupportsFullscreen):
(WebCore::HitTestResult::mediaElement):
(WebCore::HitTestResult::enterFullscreenForVideo):
(WebCore::HitTestResult::mediaIsVideo):
(WebCore::HitTestResult::isLiveLink):

  • rendering/RenderCounter.cpp:

(WebCore::planCounter):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::paintAreaElementFocusRing):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::marqueeSpeed):

  • rendering/RenderMenuList.cpp:

(RenderMenuList::itemText):
(RenderMenuList::itemIsEnabled):
(RenderMenuList::itemIsLabel):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::meterElement):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):
(WebCore::RenderObject::getTextDecorationColors):
(WebCore::RenderObject::offsetParent):

  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::progressElement):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageForRenderer):

  • testing/Internals.cpp:

(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

Source/WebKit/win:

Use is<HTML*Element>() instead of isHTML*Element().

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

  • DOMHTMLClasses.cpp:

(DOMHTMLFormElement::action):
(DOMHTMLFormElement::method):

  • WebFrame.cpp:

(formElementFromDOMElement):

Source/WebKit2:

Use is<HTML*Element>() instead of isHTML*Element().

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormElements):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getAssistedNodeInformation):

4:16 PM Changeset in webkit [173979] by ap@apple.com
  • 10 edits
    2 adds in trunk/Tools

EWS only repeats its cycle every two hours
​https://bugs.webkit.org/show_bug.cgi?id=137129

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/app.yaml: Updated version.
  • QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
  • QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing

the patch from work items.

  • QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
  • QueueStatusServer/main.py: Added release-lock.
  • QueueStatusServer/model/activeworkitems.py:

(ActiveWorkItems.deactivate_expired): Use timeout from configuration.

  • QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,

we don't want it to be immediately picked up again, it's better to give other patches
a chance.

  • QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have

these interactive versions, but OK.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):

Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
or svn is down).

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
meaning that these handlers could never do the right thing. We'd either get a duplicate
_did_fail, or try to unlock an already unlocked patch.
(StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
making it eligible for retry immediately.

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer._post_release_lock):
(StatusServer.release_lock):
Added a call to release-lock.

2:59 PM Changeset in webkit [173978] by Brian Burg
  • 8 edits in trunk/Source

Source/JavaScriptCore:
Web Replay: Check event loop input extents during replaying too
​https://bugs.webkit.org/show_bug.cgi?id=136316

Reviewed by Timothy Hatcher.

Sometimes we see different nondeterminism during capture and replay
executions, so we should add determinism checks during replay too.

Move the withinEventLoopInputExtent flag to the base class, and tighten
the assertion to address <​http://webkit.org/b/133019>.

  • replay/InputCursor.h:

(JSC::InputCursor::InputCursor):
(JSC::InputCursor::setWithinEventLoopInputExtent): Added.
This assertion is slightly wrong because it does not account for nested run loops.
We can be within two input extents when a nested run loop processes additional
user inputs while the debugger is paused.

This should only be the case when execution is being neither captured or
replayed. The debugger should not pause when capturing, and we should not replay
event loop inputs while in a nested run loop.

(JSC::InputCursor::withinEventLoopInputExtent): Added.

Source/WebCore:
Web Replay: Check event loop input extents during replay too
​https://bugs.webkit.org/show_bug.cgi?id=136316

Reviewed by Timothy Hatcher.

Sometimes we see different nondeterminism during capture and replay
executions, so we should support determinism checks during replay too.

Move the withinEventLoopInputExtent flag to the base class.

No new tests, no behavior changed.

  • replay/CapturingInputCursor.cpp:

(WebCore::CapturingInputCursor::CapturingInputCursor):
(WebCore::CapturingInputCursor::setWithinEventLoopInputExtent): Deleted.

  • replay/CapturingInputCursor.h:
  • replay/EventLoopInput.cpp:

(WebCore::EventLoopInputExtent::EventLoopInputExtent):
(WebCore::EventLoopInputExtent::~EventLoopInputExtent):
Make m_cursor a pointer and add a new constructor so we can conditionally
enter event loop input extents. This is useful in some network replay situations.

  • replay/EventLoopInput.h:
  • replay/ReplayController.cpp:

(WebCore::ReplayController::willDispatchEvent): Expand the assertion to include replaying.

2:53 PM Changeset in webkit [173977] by Brian Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: sort probe details sidebar sections by source code location string
​https://bugs.webkit.org/show_bug.cgi?id=137080

Reviewed by Timothy Hatcher.

Probe sections should display in the same order as associated breakpoint tree elements.

  • UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WebInspector.ProbeDetailsSidebarPanel.prototype.inspect.inspectedProbeSets):
(WebInspector.ProbeDetailsSidebarPanel.prototype.inspect):

2:45 PM Changeset in webkit [173976] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Followup to r173972. Don’t set child process to none before reading from stdout.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath.convert):

2:05 PM Changeset in webkit [173975] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Expand WK_MAC_TBA and WK_IOS_TBA to the current deployment target version (or NA).
​https://bugs.webkit.org/show_bug.cgi?id=137127
Part of rdar://problem/17761459.

Reviewed by Dan Bernstein.

  • mac/rewrite-availability-macros.sh:
1:35 PM Changeset in webkit [173974] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Race in ref pointer for WebVideoFullscreenInterfaceAVKit.
​https://bugs.webkit.org/show_bug.cgi?id=137123

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-09-25
Reviewed by Eric Carlson.

Add WebThreadRun to prevent race with RefPtr of WebVideoFullscreenInterfaceAVKit.

  • platform/ios/WebVideoFullscreenControllerAVKit.mm:

(-[WebVideoFullscreenController didSetupFullscreen]): add WebThreadRun

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setDuration): ditto
(WebVideoFullscreenInterfaceAVKit::setCurrentTime): ditto
(WebVideoFullscreenInterfaceAVKit::setRate): ditto
(WebVideoFullscreenInterfaceAVKit::setVideoDimensions): ditto
(WebVideoFullscreenInterfaceAVKit::setSeekableRanges): ditto
(WebVideoFullscreenInterfaceAVKit::setAudioMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setLegibleMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setExternalPlayback): ditto
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen): ditto

12:30 PM Changeset in webkit [173973] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

CommitLayerTree decode fails in 32-bit apps on 64-bit devices (TransformationMatrix alignment differs)
​https://bugs.webkit.org/show_bug.cgi?id=136444
<rdar://problem/17952526>

Reviewed by Anders Carlsson.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TransformationMatrix>::encode):
(IPC::ArgumentCoder<TransformationMatrix>::decode):
Stop using SimpleArgumentCoder to encode/decode TransformationMatrix,
because the alignment of TransformationMatrix differs between architectures,
and there's no guarantee that both sides of a connection are the same architecture.

12:21 PM Changeset in webkit [173972] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath.convert):

10:26 AM Changeset in webkit [173971] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed iOS build fix after r173944.

Add a missing header include.
See <rdar://problem/18454708> for more details.

  • html/parser/HTMLTreeBuilder.cpp:
10:25 AM Changeset in webkit [173970] by Chris Dumez
  • 41 edits in trunk/Source/WebCore

Stop using legacy NODE_TYPE_CASTS() macro in svg/
​https://bugs.webkit.org/show_bug.cgi?id=137106

Reviewed by Ryosuke Niwa.

Stop using legacy NODE_TYPE_CASTS() in svg/ and use the new
SPECIALIZE_TYPE_TRAITS_*() macro instead so that is<>() / downcast<>()
can be used for those types.

No new tests, no behavior change.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • dom/Element.h:
  • dom/Node.h:

(WebCore::is):

  • dom/make_names.pl:

(printTypeHelpers):

  • html/HTMLElement.h:
  • html/HTMLMediaElement.h:
  • html/HTMLPlugInImageElement.h:
  • html/LabelableElement.h:
  • mathml/MathMLElement.h:

Rename NodeTypeCastTraits::is() to NodeTypeCastTraits::isType() to
avoid naming conflict with the global is<>() function. This was an
issue when is<>() was called from one of the template specializations.

  • rendering/svg/RenderSVGBlock.h:

(WebCore::RenderSVGBlock::graphicsElement):

  • rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::gradientElement):

  • rendering/svg/RenderSVGInline.h:

(WebCore::RenderSVGInline::graphicsElement):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::pathOnlyClipping):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::graphicsElement):

  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::isSVGAnimateElement): Deleted.
Use is<>() / downcast<>() where appropriate.

  • svg/SVGAnimateElement.h:

(WebCore::isSVGAnimateElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and add
overload for isSVGAnimateElement() taking an SVGElement in argument to
bypass the is<SVGElement>() check when the input type is an SVGElement.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::getBoundingBox):
Use is<>() / downcast<>() where appropriate.

  • svg/SVGElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:

Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and drop
the pre-existing NodeTypeCastTraits template specialization as it is
now generated by the macro.

  • svg/SVGGradientElement.cpp:

(WebCore::isSVGGradientElement): Deleted.

  • svg/SVGGradientElement.h:

(WebCore::isSVGGradientElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and add
overload for isSVGAnimateElement() taking an SVGElement in argument to
bypass the is<SVGElement>() check when the input type is an SVGElement.

  • svg/SVGGraphicsElement.h:

(WebCore::isSVGGraphicsElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS().

  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::collectGradientAttributes):

  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::getTransformToElement):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):
(WebCore::isSVGPolyElement): Deleted.
Use is<>() / downcast<>() where appropriate.

  • svg/SVGPolyElement.h:

(WebCore::isSVGPolyElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and add
overload for isPolyElement() taking an SVGElement in argument to
bypass the is<SVGElement>() check when the input type is an SVGElement.

  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::collectGradientAttributes):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):
(WebCore::SVGTextContentElement::elementFromRenderer):
Use is<>() / downcast<>() where appropriate.

  • svg/SVGTextContentElement.h:

WebCore::isSVGTextContentElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS().

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::toClipPath):
Use is<>() / downcast<>() where appropriate. Also use tighter typing
for value returned by shadowTreeElement().

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
Use is<>() / downcast<>() where appropriate.

  • svg/animation/SVGSMILElement.h:

(WebCore::isSVGSMILElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and drop
the pre-existing NodeTypeCastTraits template specialization as it is
now generated by the macro.

10:23 AM Changeset in webkit [173969] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

Minor refactoring to mediaType/presentationType
​https://bugs.webkit.org/show_bug.cgi?id=137085

Reviewed by Eric Carlson.

Add overloads for presentationType for the audio and video
HTML elements so that we don't have to explicity check the
tag name (via string comparison) to identify the type of
element.

No new tests. Should create no change in behavior.

  • html/HTMLAudioElement.h: Overload presentationType to always

indicate audio type.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaType): Use the presentationType
method implementation, rather than duplicating that code.

  • html/HTMLVideoElement.h: Overload presentationType to always

return video type.

9:17 AM Changeset in webkit [173968] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.4

Unreviewed. Update NEWS and Versions.m4 for 2.4.6 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.4.6.
9:11 AM Changeset in webkit [173967] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebInspectorUI

Unreviewed. Fix make distcheck.

  • GNUmakefile.am: Files in EXTRA_DIST need to be explicitly listed.
7:54 AM Changeset in webkit [173966] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed typo fix.

  • UIProcess/API/C/soup/WKContextSoup.cpp:
7:50 AM Changeset in webkit [173965] by jfernandez@igalia.com
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: columnCount in WebCore::CSSParser::parseGridTemplateAreasRow
​https://bugs.webkit.org/show_bug.cgi?id=136945

Reviewed by Sergio Villar Senin.

Source/WebCore:

Checking out whether the grid-template-areas value contains a white-space only
string, which is not valid as it does not produce a cell token.

Test: fast/css-grid-layout/grid-template-areas-empty-string-crash.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTemplateAreasRow):

LayoutTests:

Testing the different types of white-space only strings for the grid-template-areas
property, which is not valid as it does not produce a cell token.

  • fast/css-grid-layout/grid-template-areas-empty-string-crash-expected.txt: Added.
  • fast/css-grid-layout/grid-template-areas-empty-string-crash.html: Added.
7:45 AM Changeset in webkit [173964] by commit-queue@webkit.org
  • 4 edits in trunk

[Gtk] build.sh needs a -- before make options when the build command is cmake --build
​https://bugs.webkit.org/show_bug.cgi?id=136377

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2014-09-25
Reviewed by Philippe Normand.

.:

  • Source/cmake/OptionsGTK.cmake: Only create the build.sh script

for CMake versions less than 3.

Tools:

  • Scripts/webkitdirs.pm:

(buildCMakeGeneratedProject): Only use the build.sh script if it exists.

7:21 AM Changeset in webkit [173963] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.4/Tools

Unreviewed. Get rid of runtime warnings about deprecated properties and signals, since they break the tests.

  • TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testdownload.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testloading.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testwebresource.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testwebview.c:
7:05 AM Changeset in webkit [173962] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r173252 - [SOUP] Race condition when downloading a file due to the intermediate temporary file
​https://bugs.webkit.org/show_bug.cgi?id=136423

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-09-03
Reviewed by Carlos Garcia Campos.

  • Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::DownloadClient): Replace m_destinationURI with
m_destinationFile and add m_createdDestination.
(WebKit::DownloadClient::deleteFilesIfNeeded): Added.
(WebKit::DownloadClient::downloadFailed): Call deleteFilesIfNeeded.
(WebKit::DownloadClient::didReceiveResponse): Attempt to create the
destination file before the intermediate file. Fail here if the file
exists and overwrite is not allowed, so we don't erroneously fire the
didCreateDestination event or waste time downloading the file when we
know the download will fail.
(WebKit::DownloadClient::didFinishLoading): Unconditionally overwrite
the empty destination file.
(WebKit::DownloadClient::cancel): Call deleteFilesIfNeeded.
(WebKit::DownloadClient::deleteIntermediateFileInNeeded): Deleted.

6:56 AM Changeset in webkit [173961] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r173154 - [SOUP] WebKitDownload cannot overwrite existing file
​https://bugs.webkit.org/show_bug.cgi?id=136322

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-09-01
Reviewed by Carlos Garcia Campos.

  • Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): pass a member variable
to Download::decideDestinationWithSuggestedFilename instead of a
temporary bool, so we can use the result in didFinishLoading.
(WebKit::DownloadClient::didFinishLoading): overwrite the destination
if Download::decideDestinationWithSuggestedFilename determined we
should do so.

6:49 AM Changeset in webkit [173960] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r173658 - [GTK] Typo in webkit_security_manager_register_uri_scheme_as_empty_document documentation
​https://bugs.webkit.org/show_bug.cgi?id=136852

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-09-16
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/WebKitSecurityManager.cpp:
6:46 AM Changeset in webkit [173959] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r172928 - [GStreamer] ASSERT failure in WebKitWebSource in StreamingClient
​https://bugs.webkit.org/show_bug.cgi?id=136132

adoptGRef() has an ASSERT failure if it's used on a floating pointer. For some reason,
WebKitWebSrc* src in StreamingClient's constructor is floating. Since we
don't construct this ourselves, I assume this is happening in Playbin.

If we remove the ref and adopt, GRefPtr's constructor calls gst_object_ref_sink,
which removes the floating reference and doesn't increment the reference count.
This should work, but actually causes the page to either lock up or crash (different
results for different testers).

In this case, it seems like the adoptGRef / gst_object_ref was the correct thing to do,
but adoptGRef won't actually let us do. Removing the ASSERT is a bad idea, because
usually we don't want to adopt floating pointers.

This is all a long way of saying that making m_src a raw pointer and manually
calling gst_object_ref(), and calling gst_object_unref in the destructor is the
best solution in this case, since it fixes the problem while leaving the ASSERT
to protect us in the much more common case where adopting a floating reference is bad.

Reviewed by Philippe Normand.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::StreamingClient): Make m_src a raw pointer instead of a GRefPtr.
(StreamingClient::~StreamingClient): Unref m_src.
(StreamingClient::createReadBuffer): Replace m_src.get() with m_src, since it's a raw pointer now.
(StreamingClient::handleResponseReceived): Same.
(StreamingClient::handleDataReceived): Same.
(StreamingClient::handleNotifyFinished): Same.
(CachedResourceStreamingClient::notifyFinished): Same.
(ResourceHandleStreamingClient::didFail): Same.
(ResourceHandleStreamingClient::wasBlocked): Same.
(ResourceHandleStreamingClient::cannotShowURL): Same.

6:39 AM Changeset in webkit [173958] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
​https://bugs.webkit.org/show_bug.cgi?id=137117

Tools/efl/install-dependencies relies on apt-get to install packages.
Unfortunately, if a package does not exist (e.g., for a given
architecture) then apt-get install is not able to ignore the missing
package and install the rest but fails to run entirely (and there
seems to be no intent to change this behaviour).

On ARM64, the luajit package is missing and currently it needs manual
editing of install-dependencies to get the script install as much as it
can.

This patch separates the installation of the universally available
packages from those which might not be available for all architectures.

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-09-25
Reviewed by Gyuyoung Kim.

  • efl/install-dependencies:
6:39 AM Changeset in webkit [173957] by Carlos Garcia Campos
  • 1 edit in releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog

Merge r172896 - [GTK] Toggle buttons visually broken with GTK+ 3.13.7
​https://bugs.webkit.org/show_bug.cgi?id=136130

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-08-24
Reviewed by Martin Robinson.

No new tests. Hopefully covered by existing tests, and our tests only
run with GTK+ 3.6 anyway.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::paintToggle): use GTK_STATE_FLAG_CHECKED when compiling for
GTK+ 3.13.7 and above to ensure toggle buttons display as toggled.

6:31 AM Changeset in webkit [173956] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r172958 - [GTK] Selection background is rendered white when unfocused with recent GTK+
​https://bugs.webkit.org/show_bug.cgi?id=136251

Reviewed by Martin Robinson.

This is due to a change in the GTK+ theme, but because we are not
using the right flags to get the selections colors. We should use
GTK_STATE_FLAG_SELECTED | GTK_STATE_FLAG_FOCUSED when focused and
GTK_STATE_FLAG_SELECTED when unfocused, instead of
GTK_STATE_FLAG_ACTIVE when unfocused.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionForegroundColor):

6:25 AM Changeset in webkit [173955] by Carlos Garcia Campos
  • 4 edits
    6 adds in releases/WebKitGTK/webkit-2.4

Merge r173809 - [GStreamer] Cannot play Vimeo video
​https://bugs.webkit.org/show_bug.cgi?id=134969

Reviewed by Sergio Villar Senin.

Source/WebCore:

Ensure the GStreamer HTTP source element also sends cookies when
it's sending its requests. Some streaming platforms such as Vimeo
do server-side cookie checks on incoming requests before serving
media data.

Test: http/tests/media/hls/video-cookie.html

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart): Set first-party cookie URL to the request so
the ResourceLoader properly sets cookies in the HTTP request.

6:13 AM Changeset in webkit [173954] by Carlos Garcia Campos
  • 3 edits
    189 adds in releases/WebKitGTK/webkit-2.4

Merge r173753 - Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
​https://bugs.webkit.org/show_bug.cgi?id=136632

Reviewed by Gustavo Noronha Silva.

Source/WebInspectorUI:

Add free icons for the GTK port. These icons are from the GNOME
project, some of them adapted by Andres Gomez for the inspector.

6:10 AM Changeset in webkit [173953] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.4

Merge r173751 - [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
​https://bugs.webkit.org/show_bug.cgi?id=136943

Reviewed by Philippe Normand.

Source/WebKit2:

  • PlatformGTK.cmake: Fix the inspector file list and pass it to

the generate-inspector-gresource-manifest.py script.

Tools:

Update the script to receive the list of files from the command
line instead of scanning the given directories.

  • gtk/generate-inspector-gresource-manifest.py:

(get_filenames): Convert filenames to use relative paths.
(find_all_files_in_directory): Deleted.
(find_all_files_in_directory.select_file): Deleted.

4:26 AM Changeset in webkit [173952] by Carlos Garcia Campos
  • 3 edits
    29 adds in trunk/Source/WebInspectorUI

Unreviewed. Add more free icons for the Web Inspector in GTK+.

Patch by Andres Gomez <Andres Gomez> on 2014-09-25

  • UserInterface/Images/gtk/AUTHORS:
  • UserInterface/Images/gtk/ApplicationCacheManifest.png: Added.
  • UserInterface/Images/gtk/​ApplicationCacheManifest@2x.png: Added.
  • UserInterface/Images/gtk/COPYING:
  • UserInterface/Images/gtk/COPYING_LGPL2: Added.
  • UserInterface/Images/gtk/Cookie.png: Added.
  • UserInterface/Images/gtk/​Cookie@2x.png: Added.
  • UserInterface/Images/gtk/HoverMenuButton.png: Added.
  • UserInterface/Images/gtk/​HoverMenuButton@2x.png: Added.
  • UserInterface/Images/gtk/InstructionPointer.png: Added.
  • UserInterface/Images/gtk/​InstructionPointer@2x.png: Added.
  • UserInterface/Images/gtk/Log.png: Added.
  • UserInterface/Images/gtk/​Log@2x.png: Added.
  • UserInterface/Images/gtk/Profile.png: Added.
  • UserInterface/Images/gtk/​Profile@2x.png: Added.
  • UserInterface/Images/gtk/Recording.png: Added.
  • UserInterface/Images/gtk/​Recording@2x.png: Added.
  • UserInterface/Images/gtk/RecordingHovered.png: Added.
  • UserInterface/Images/gtk/​RecordingHovered@2x.png: Added.
  • UserInterface/Images/gtk/RecordingStopped.png: Added.
  • UserInterface/Images/gtk/​RecordingStopped@2x.png: Added.
  • UserInterface/Images/gtk/Script.png: Added.
  • UserInterface/Images/gtk/​Script@2x.png: Added.
  • UserInterface/Images/gtk/ScriptLarge.png: Added.
  • UserInterface/Images/gtk/​ScriptLarge@2x.png: Added.
  • UserInterface/Images/gtk/SliderThumb.png: Added.
  • UserInterface/Images/gtk/​SliderThumb@2x.png: Added.
  • UserInterface/Images/gtk/SliderThumbPressed.png: Added.
  • UserInterface/Images/gtk/​SliderThumbPressed@2x.png: Added.
  • UserInterface/Images/gtk/Stopwatch.png: Added.
  • UserInterface/Images/gtk/​Stopwatch@2x.png: Added.
3:51 AM Changeset in webkit [173951] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WebKit2] Fix build warning in WebKit2/WebProcess module.
​https://bugs.webkit.org/show_bug.cgi?id=137105

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-09-25
Reviewed by Csaba Osztrogonác.

Fix build warning by removing unused parameter names

  • WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::didReceiveInvalidMessage):

  • WebProcess/WebPage/WebInspectorUI.h:

(WebKit::WebInspectorUI::didReceiveInvalidMessage):

3:36 AM Changeset in webkit [173950] by Csaba Osztrogonác
  • 1 delete in trunk/Source/WebKit/wince

Unreviewed, delete the empty Source/WebKit/wince/ChangeLog after r173949.

3:14 AM Changeset in webkit [173949] by Csaba Osztrogonác
  • 101 edits
    54 deletes in trunk

Remove WinCE port from trunk
​https://bugs.webkit.org/show_bug.cgi?id=136951

Reviewed by Alex Christensen.

.:

  • Source/cmake/OptionsWinCE.cmake: Removed.
  • Source/cmake/WebKitPackaging.cmake:

Source/JavaScriptCore:

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::cacheFlush):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::cacheFlush):

  • config.h:
  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::swapIfBackwards): Deleted.

  • jit/ExecutableAllocator.h:
  • jsc.cpp:

(main):

  • runtime/DateConstructor.cpp:
  • runtime/Options.cpp:

(JSC::overrideOptionWithHeuristic):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • testRegExp.cpp:

(main):

  • tools/CodeProfiling.cpp:

(JSC::CodeProfiling::notifyAllocator):

Source/WebCore:

  • Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp:
  • PlatformWinCE.cmake: Removed.
  • accessibility/AXObjectCache.cpp:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::modifyMovingRight):

  • loader/icon/wince/IconDatabaseWinCE.cpp: Removed.
  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):

  • page/Settings.cpp:
  • page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::createDraggingDataTransfer):

  • platform/ContextMenu.h:
  • platform/DragImage.cpp:
  • platform/FileSystem.h:
  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::mayFillWithSolidColor):

  • platform/graphics/FontGlyphs.cpp:

(WebCore::FontGlyphs::glyphDataAndPageForCharacter):

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/ImageBufferData.h:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/opentype/OpenTypeUtilities.cpp:

(WebCore::renameAndActivateFont):

  • platform/graphics/opentype/OpenTypeUtilities.h:
  • platform/graphics/win/DIBPixelData.cpp:

(WebCore::DIBPixelData::setRGBABitmapAlpha):

  • platform/graphics/win/GDIExtras.cpp: Removed.
  • platform/graphics/win/GDIExtras.h:

(WebCore::hasAlphaBlendSupport):
(WebCore::alphaBlendIfSupported):

  • platform/graphics/win/IconWin.cpp:

(WebCore::Icon::createIconForFiles):
(WebCore::Icon::paint):

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::initGDIFont):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::boundsForGDIGlyph):
(WebCore::SimpleFontData::widthForGDIGlyph):
(WebCore::SimpleFontData::scriptFontProperties):

  • platform/graphics/wince/FontCacheWinCE.cpp: Removed.
  • platform/graphics/wince/FontCustomPlatformData.cpp: Removed.
  • platform/graphics/wince/FontCustomPlatformData.h: Removed.
  • platform/graphics/wince/FontPlatformData.cpp: Removed.
  • platform/graphics/wince/FontPlatformData.h: Removed.
  • platform/graphics/wince/FontWinCE.cpp: Removed.
  • platform/graphics/wince/GlyphPageTreeNodeWinCE.cpp: Removed.
  • platform/graphics/wince/GradientWinCE.cpp: Removed.
  • platform/graphics/wince/GraphicsContextWinCE.cpp: Removed.
  • platform/graphics/wince/ImageBufferDataWince.h: Removed.
  • platform/graphics/wince/ImageBufferWinCE.cpp: Removed.
  • platform/graphics/wince/ImageWinCE.cpp: Removed.
  • platform/graphics/wince/MediaPlayerPrivateWinCE.h: Removed.
  • platform/graphics/wince/MediaPlayerProxy.cpp: Removed.
  • platform/graphics/wince/MediaPlayerProxy.h: Removed.
  • platform/graphics/wince/PathWinCE.cpp: Removed.
  • platform/graphics/wince/PlatformPathWinCE.cpp: Removed.
  • platform/graphics/wince/PlatformPathWinCE.h: Removed.
  • platform/graphics/wince/SharedBitmap.cpp: Removed.
  • platform/graphics/wince/SharedBitmap.h: Removed.
  • platform/graphics/wince/SimpleFontDataWinCE.cpp: Removed.
  • platform/graphics/wince/WinCEGraphicsExtras.h: Removed.
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/network/win/NetworkStateNotifierWin.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

  • platform/win/COMPtr.h:
  • platform/win/ClipboardUtilitiesWin.cpp:
  • platform/win/ContextMenuItemWin.cpp:
  • platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):

  • platform/win/DragImageWin.cpp:

(WebCore::dragLabelFont):

  • platform/win/FileSystemWin.cpp:

(WebCore::pathByAppendingComponent):
(WebCore::pathGetFileName):
(WebCore::storageDirectory):

  • platform/win/LoggingWin.cpp:

(WebCore::logLevelString):

  • platform/win/PasteboardWin.cpp:

(WebCore::PasteboardOwnerWndProc):
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::pathRemoveBadFSCharacters):
(WebCore::filesystemPathFromUrlOrTitle):
(WebCore::createGlobalHDropContent):

  • platform/win/PlatformMouseEventWin.cpp:

(WebCore::messageToEventType):
(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/win/PlatformScreenWin.cpp:

(WebCore::deviceInfoForWidget):
(WebCore::screenIsMonochrome):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::show):
(WebCore::PopupMenuWin::paint):
(WebCore::PopupMenuWin::registerClass):
(WebCore::PopupMenuWin::wndProc):

  • platform/win/ScrollbarThemeWin.cpp:

(WebCore::ScrollbarThemeWin::paintButton):

  • platform/win/SharedBufferWin.cpp:
  • platform/win/SharedTimerWin.cpp:

(WebCore::TimerWindowWndProc):
(WebCore::initializeOffScreenTimerWindow):
(WebCore::queueTimerProc):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

  • platform/win/SoftLinking.h:
  • platform/win/SystemInfo.cpp:

(WebCore::windowsVersion):
(WebCore::processorArchitecture):
(WebCore::architectureTokenForUAString):

  • platform/win/WCDataObject.cpp:

(WebCore::WCDataObject::CopyMedium):

  • plugins/PluginDatabase.cpp:
  • plugins/PluginView.cpp:

(WebCore::PluginView::stop):

  • plugins/PluginViewNone.cpp:
  • plugins/win/PluginDatabaseWin.cpp:

(WebCore::addWindowsMediaPlayerPluginDirectory):
(WebCore::addMacromediaPluginDirectories):

  • plugins/win/PluginPackageWin.cpp:

(WebCore::PluginPackage::load):

  • plugins/win/PluginViewWin.cpp:

(WebCore::setUpOffscreenPaintingHooks):
(WebCore::registerPluginView):
(WebCore::PluginView::wndProc):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paintIntoTransformedContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::platformStart):

  • rendering/RenderThemeWinCE.cpp: Removed.
  • rendering/RenderThemeWinCE.h: Removed.
  • storage/wince/DatabaseThreadWinCE.cpp: Removed.
  • storage/wince/DatabaseThreadWinCE.h: Removed.
  • storage/wince/StorageThreadWinCE.cpp: Removed.
  • storage/wince/StorageThreadWinCE.h: Removed.

Source/WebKit:

  • PlatformWinCE.cmake: Removed.
  • wince/WebCoreSupport/ChromeClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/ChromeClientWinCE.h: Removed.
  • wince/WebCoreSupport/ContextMenuClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/ContextMenuClientWinCE.h: Removed.
  • wince/WebCoreSupport/DragClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/DragClientWinCE.h: Removed.
  • wince/WebCoreSupport/EditorClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/EditorClientWinCE.h: Removed.
  • wince/WebCoreSupport/FrameLoaderClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/FrameLoaderClientWinCE.h: Removed.
  • wince/WebCoreSupport/FrameNetworkingContextWinCE.cpp: Removed.
  • wince/WebCoreSupport/FrameNetworkingContextWinCE.h: Removed.
  • wince/WebCoreSupport/InspectorClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/InspectorClientWinCE.h: Removed.
  • wince/WebCoreSupport/PlatformStrategiesWinCE.cpp: Removed.
  • wince/WebCoreSupport/PlatformStrategiesWinCE.h: Removed.
  • wince/WebView.cpp: Removed.
  • wince/WebView.h: Removed.

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WTF:

  • config.h:
  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

  • wtf/CurrentTime.cpp:

(WTF::lowResUTCTime):

  • wtf/DataLog.cpp:
  • wtf/DateMath.cpp:

(WTF::getLocalTime):
(WTF::calculateDSTOffset):

  • wtf/FastMalloc.cpp:
  • wtf/FeatureDefines.h:
  • wtf/OSAllocator.h:

(WTF::OSAllocator::decommitAndRelease):

  • wtf/Platform.h:
  • wtf/PlatformWin.cmake:
  • wtf/RAMSize.cpp:

(WTF::computeRAMSize):

  • wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator):

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

  • wtf/StackBounds.h:

(WTF::StackBounds::isGrowingDownward):

  • wtf/StdLibExtras.h:

(wtf_bsearch): Deleted.

  • wtf/StringExtras.h:

(strnicmp): Deleted.
(stricmp): Deleted.
(strdup): Deleted.

  • wtf/ThreadSpecific.h:
  • wtf/ThreadingWin.cpp:

(WTF::createThreadInternal):

  • wtf/WindowsExtras.h:

(WTF::getRegistryValue):
(WTF::getWindowPointer):
(WTF::setWindowPointer):

  • wtf/dtoa/utils.h:
  • wtf/text/WTFString.cpp:

(WTF::String::format):

Tools:

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

(ShouldBuildTest):

  • CMakeLists.txt:
  • DumpRenderTree/win/DRTDataObject.cpp:

(DRTDataObject::CopyMedium):

  • Scripts/build-webkit:
  • Scripts/webkit-build-directory:
  • Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(builtDylibPathForName):
(isAppleWinWebKit):
(launcherPath):
(launcherName):
(shouldRemoveCMakeCache):
(cmakeBasedPortArguments):
(cmakeBasedPortName):
(isCMakeBuild):
(isWinCE): Deleted.
(determineIsWinCE): Deleted.

  • Scripts/webkitperl/FeatureList.pm:
  • Scripts/webkitpy/port/port_testcase.py:

(test_apache_config_file_name_for_platform):

  • TestWebKitAPI/config.h:
  • WinCELauncher/CMakeLists.txt: Removed.
  • WinCELauncher/main.cpp: Removed.
  • gtk/manifest.txt:
2:44 AM Changeset in webkit [173948] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2014-09-25

  • platform/gtk/TestExpectations: Report and mark new failures after r173515 and r173582.
  • platform/gtk/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:

Update expectations after r173857.

2:36 AM Changeset in webkit [173947] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK+ build after r173944.

  • page/ContextMenuController.cpp: Add missing include.
2:27 AM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com
(diff)

Sep 24, 2014:

9:30 PM Changeset in webkit [173946] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit/ios

[iOS] Another iOS build fix; workaround for CoreLocation
​https://bugs.webkit.org/show_bug.cgi?id=137104
<rdar://problem/18450785>

Rubber-stamped by Benjamin Poulain.

Workaround CoreLocation issue by adding a default statement in -[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]
and -[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:].
We'll remove these default statements once we have the fix for <rdar://problem/18448331>.

  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):

9:02 PM Changeset in webkit [173945] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Use tighter typing for render objects in RenderGeometryMap
​https://bugs.webkit.org/show_bug.cgi?id=137102

Reviewed by Ryosuke Niwa.

Use tighter typing for render objects in RenderGeometryMap for clarity
and efficiency.

In particular, using RenderElement type instead of RenderObject
in canMapBetweenRenderers() allows us to call the faster
RenderElement::style() instead of RenderObject::style().

No new tests, no behavior change.

  • rendering/RenderGeometryMap.cpp:

(WebCore::canMapBetweenRenderers):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):

8:50 PM Changeset in webkit [173944] by Chris Dumez
  • 39 edits in trunk/Source

Add initial is<>() / downcast<>() support for any type of Nodes
​https://bugs.webkit.org/show_bug.cgi?id=137056

Reviewed by Benjamin Poulain.

Source/WebCore:

Add initial is<>() / downcast<>() support for any type of Nodes, not
just Elements by:

  • Moving the is<>() / downcast<>() declarations from Element.h to Node.h
  • Introducing a SPECIALIZE_TYPE_TRAITS_*() macro that generates the needed template specializations for is<>() / downcast<>() to work. This macro will replace NODE_TYPE_CASTS() entirely once the code base is fully ported.

This patch makes use of SPECIALIZE_TYPE_TRAITS_*() macro for
HTMLFormControlElement, that is an HTMLElement for which the template
specializations cannot be automatically generated because it requires
special handling.

This patch also makes use of SPECIALIZE_TYPE_TRAITS_*() macro for
DocumentFragment to show that it can be used for non-Element Nodes.

No new tests, no behavior change.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::isRequired):
(WebCore::AccessibilityNodeObject::isControl):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isAutofilled):
(WebCore::isDisabled):
(WebCore::isEnabled):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::adjustRenderStyle):

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::setFocusedElement):

  • dom/DocumentFragment.h:

(WebCore::isDocumentFragment):

  • dom/Element.cpp:

(WebCore::Element::focus):

  • dom/Element.h:

(WebCore::is): Deleted.
(WebCore::downcast): Deleted.

  • dom/Node.h:

(WebCore::is):
(WebCore::downcast):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/FrameSelection.cpp:

(WebCore::scanForForm):

  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

  • html/FormAssociatedElement.h:
  • html/HTMLElement.h:
  • html/HTMLFieldSetElement.cpp:

(WebCore::updateFromControlElementsAncestorDisabledStateUnder):
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::enclosingFormControlElement):

  • html/HTMLFormControlElement.h:

(WebCore::isHTMLFormControlElement):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::submitImplicitly):
(WebCore::submitElementFromEvent):
(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::formElementIndex):
(WebCore::HTMLFormElement::defaultButton):
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
(WebCore::HTMLFormElement::documentDidResumeFromPageCache):

  • html/HTMLMediaElement.h:
  • html/HTMLPlugInImageElement.h:
  • html/HTMLSummaryElement.cpp:

(WebCore::isClickableControl):

  • html/LabelableElement.h:
  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
(WebCore::RadioNodeList::elementMatches):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::findFosterSite):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::disallowTelephoneNumberParsing):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • mathml/MathMLElement.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::formControlElement):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isReadOnlyControl):

  • svg/SVGElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/animation/SVGSMILElement.h:

Source/WebKit/mac:

Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
instead of isFormControlElement() / toHTMLFormControlElement().

  • WebView/WebHTMLRepresentation.mm:

(searchForLabelsBeforeElement):

Source/WebKit/win:

Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
instead of isFormControlElement() / toHTMLFormControlElement().

  • WebFrame.cpp:

(WebFrame::elementWithName):

7:53 PM Changeset in webkit [173943] by Darin Adler
  • 8 edits
    3 adds in trunk

Old Turkic characters behave as left-to-right instead of right-to-left, because they are encoded as surrogate pairs.
​https://bugs.webkit.org/show_bug.cgi?id=70029

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/text/international/old-turkic-direction.html

  • CMakeLists.txt: Added InlineIterator.cpp.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/RenderingAllInOne.cpp: Ditto.
  • rendering/InlineIterator.cpp: Added.

(WebCore::InlineIterator::surrogateTextDirection): New function used to compute the direction
when a surrogate pair is involved.

  • rendering/InlineIterator.h: Made the characterAt function private.

(WebCore::InlineIterator::previousInSameNode): Took out unneeded range check. A zero will underflow
and become a large number and the characterAt function will return 0 in that case.
(WebCore::InlineIterator::direction): Added code to check U16_IS_SINGLE before calling
u_charDirection, and call surrogateTextDirection instead.

LayoutTests:

  • fast/text/international/old-turkic-direction.html: Added.
  • fast/text/international/old-turkic-direction-expected.html: Added.
7:46 PM Changeset in webkit [173942] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r173941.

Rename shadow to m_shadow.

  • rendering/TextPainter.h:

(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText):

7:32 PM Changeset in webkit [173941] by mmaxfield@apple.com
  • 9 edits
    2 deletes in trunk

REGRESSION: Text with a zero offset, zero blur shadow vanishes
​https://bugs.webkit.org/show_bug.cgi?id=136801

Reviewed by Darin Adler.

Source/WebCore:

This patch performs some cleanup regarding TextPainter's shadow logic and handles an
additional case of empty shadows. Previously, there was tight coupling between
applyShadowToGraphicalContext() and paintTextWithShadows(), as they both used a
collection of variables to determine how shadows are to be drawn. This complexity has
been moved into a helper class, ShadowApplier, which performs what
applyShadowToGraphicsContext() used to do, and cleans up correctly in its destructor.
This removes the tight coupling mentioned earlier.

Test: fast/text/empty-shadow.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::applyShadowToGraphicsContext): Moved to ShadowApplier.

  • rendering/InlineTextBox.h: Deleted applyShadowToGraphicsContext signature.
  • rendering/TextPainter.cpp:

(WebCore::ShadowApplier::ShadowApplier): Perform the contents of applyShadowToGraphicsContext()
(WebCore::ShadowApplier::~ShadowApplier): Undo the work done previously
(WebCore::paintTextWithShadows): Create a ShadowApplier to do the relevant shadow work. In addition,
refactor some boolean flags to more meaningful ones with relation to the computation at hand.
(WebCore::isEmptyShadow): Moved to TextPainter.h, named shadowIsCompletelyCoveredByText()

  • rendering/TextPainter.h:

(WebCore::ShadowApplier::ShadowApplier): Moved from InlineTextBox::applyShadowToGraphicsContext().
(WebCore::ShadowApplier::extraOffset): Getter.
(WebCore::ShadowApplier::~ShadowApplier): Moved from TextPainter::paintTextWithShadows().
(WebCore::isLastShadowIteration): Helper function.
(WebCore::shadowIsCompletelyCoveredByText): Determines whether or not we should not draw the shadow.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintTextWithShadows): Update to use ShadowApplier.

LayoutTests:

This test should be a comprehensive test of empty shadows. It tests every
combination of one and two shadows being empty, as well as transparent and
opaque text.

After updating fast/text/empty-shadow.html, fast/text/empty-shadow-with-color.html
is no longer necessary.

  • fast/text/empty-shadow-expected.html:
  • fast/text/empty-shadow-with-color-expected.html: Removed.
  • fast/text/empty-shadow-with-color.html: Removed.
  • fast/text/empty-shadow.html:
7:17 PM Changeset in webkit [173940] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit/ios

[iOS] Fix the iOS build; add case statements for kCLAuthorizationStatusAuthorized
​https://bugs.webkit.org/show_bug.cgi?id=137101
<rdar://problem/18449815>

Reviewed by Mark Lam.

  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):

5:25 PM Changeset in webkit [173939] by Brian Burg
  • 6 edits in trunk/Source

Web Inspector: subtract elapsed time while debugger is paused from profile nodes
​https://bugs.webkit.org/show_bug.cgi?id=136796

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Rather than accruing no time to any profile node created while the debugger is paused,
we can instead count a node's elapsed time and exclude time elapsed while paused.

Time for a node may elapse in a non-contiguous fashion depending on the interleaving of
didPause, didContinue, willExecute, and didExecute. A node's start time is set to the
start of the last such interval that accrues elapsed time.

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::ProfileGenerator):
(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didPause): Added.
(JSC::ProfileGenerator::didContinue): Added.

  • profiler/ProfileGenerator.h:

(JSC::ProfileGenerator::didPause): Deleted.
(JSC::ProfileGenerator::didContinue): Deleted.

  • profiler/ProfileNode.h: Rename totalTime to elapsedTime.

(JSC::ProfileNode::Call::Call):
(JSC::ProfileNode::Call::elapsedTime): Added.
(JSC::ProfileNode::Call::setElapsedTime): Added.
(JSC::CalculateProfileSubtreeDataFunctor::operator()):
(JSC::ProfileNode::Call::totalTime): Deleted.
(JSC::ProfileNode::Call::setTotalTime): Deleted.

Source/WebCore:

  • inspector/TimelineRecordFactory.cpp:

(WebCore::buildInspectorObject):

4:29 PM Changeset in webkit [173938] by Chris Dumez
  • 2 edits in trunk/Source/WebKit/win

Unreviewed build fix after r173932.

Unreviewed build fix after r173932 for Windows. Use WebCore:: namespace
explicitely in DOMCoreClasses.cpp.

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

4:28 PM Changeset in webkit [173937] by dfarler@apple.com
  • 5 edits in trunk/Tools

[iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
​https://bugs.webkit.org/show_bug.cgi?id=136895

Reviewed by David Kilzer.

Create Device, DeviceType, and Runtime data classes.
Create Simulator class represent simctl output.

Wherever possible, use structured data classes anywhere a raw
identifier or UDID string was used for a cleaner implementation
and to encapsulate the inherent fragility of scraping simctl output.

Create a suitably named testing device if one doesn't exist.

Finally, accurately handle having multiple simulator runtimes (SDKs)
installed in the active Xcode.app bundle.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):

  • Scripts/webkitpy/port/driver.py:

(IOSSimulatorDriver.cmd_line):
Construct DeviceType and Runtime objects from identifiers passed at the
command line, still providing sensible defaults for 32- and 64-bit testing.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.init):
(IOSSimulatorPort.setup_test_run):
(IOSSimulatorPort):
(IOSSimulatorPort.testing_device):
Cache the testing device once it is created or found.
(IOSSimulatorPort.reset_preferences):
Get the device path from the Device object instead of consructing it
in the port class.
(IOSSimulatorPort.simulator_udid): Deleted.
Get the UDID from the testing_device :: Device object itself.

  • Scripts/webkitpy/xcode/simulator.py:

Created Device, DeviceType, Runtime, and Simulator classes.
(get_runtimes): Deleted.
(get_devices): Deleted.
(get_device_types): Deleted.
(get_latest_runtime): Deleted.

4:11 PM Changeset in webkit [173936] by timothy@apple.com
  • 1 edit in trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm

Attempt to fix crash seen on bots.

3:07 PM Changeset in webkit [173935] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

Do the bmalloc.
​https://bugs.webkit.org/show_bug.cgi?id=132629

Reviewed by Gavin Barraclough.

64-bit only for now, just to try it out.

  • wtf/FastMalloc.cpp:
3:02 PM Changeset in webkit [173934] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove incorrect use of the BKSProcessAssertionAllowSuspendOnSleep flag for process suspension in iOS WebKit2
<rdar://problem/18400566>
​https://bugs.webkit.org/show_bug.cgi?id=137077

Reviewed by Anders Carlsson.

  • UIProcess/ios/ProcessAssertionIOS.mm:

Remove use of the BKSProcessAssertionAllowSuspendOnSleep which does not do what we expect, and instead
causes processes to be suspended "forever" after sleep.

2:41 PM Changeset in webkit [173933] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2/UIProcess

Fix 32-bit Mac build.

2:25 PM Changeset in webkit [173932] by Chris Dumez
  • 72 edits in trunk/Source

Use is<HTML*Element>() instead of isHTML*Element() - Part 1
​https://bugs.webkit.org/show_bug.cgi?id=137068

Reviewed by Ryosuke Niwa.

Start using is<HTML*Element>() instead of isHTML*Element().
Remaining usages will be updated in a follow-up patch to
reduce the size of the change.

Source/WebCore:

No new tests, no behavior change.

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaTimeline::valueDescription):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::setElement):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::isNodeActionElement):
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isDisabled):
(WebCore::isEnabled):
(WebCore::isChecked):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::isInPasswordField):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_processElement):

  • editing/gtk/EditorGtk.cpp:

(WebCore::elementURL):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::isPlainTextMarkup):
(WebCore::collectElementsToRemoveFromFragment):

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded):

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::getTextFieldValues):
(WebCore::HTMLFormElement::formElementIndex):

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::dispatchLoadEvent):
(WebCore::HTMLImageLoader::notifyFinished):

  • html/HTMLNameCollection.cpp:

(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions):
(WebCore::HTMLOptGroupElement::ownerSelectElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::index):
(WebCore::HTMLOptionElement::ownerSelectElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::add):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::setLength):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):

  • html/HTMLTagNames.in:
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isSelectScopeMarker):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::mediaControlElementType):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestObject):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • page/Chrome.cpp:

(WebCore::Chrome::setToolTip):

  • page/EventHandler.cpp:

(WebCore::isSubmitImage):
(WebCore::EventHandler::handleMousePressEvent):

  • page/FocusController.cpp:

(WebCore::clearSelectionIfNeeded):

  • page/FrameView.cpp:

(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):

  • page/PageSerializer.cpp:

(WebCore::frameOwnerURLAttributeName):

  • page/SpatialNavigation.cpp:

(WebCore::canScrollInDirection):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absolutePDFURL):
(WebCore::HitTestResult::isContentEditable):

  • rendering/RenderBlockFlow.cpp:

(WebCore::resizeTextPermitted):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesLogicalWidthToFitContent):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::updateFromElement):
(WebCore::RenderButton::canHaveGeneratedChildren):

  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::isOpen):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::updateAltText):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderMenuList.cpp:

(WebCore::selectedOptionCount):
(RenderMenuList::updateOptionsWidth):
(RenderMenuList::setTextFromOption):
(RenderMenuList::itemText):
(RenderMenuList::itemIsEnabled):
(RenderMenuList::itemIsSelected):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks):

  • testing/Internals.cpp:

(WebCore::Internals::selectColorInColorChooser):
(WebCore::Internals::wasLastChangeUserEdit):
(WebCore::Internals::isSelectPopupVisible):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

Source/WebKit/ios:

  • WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::focusedElementChanged):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedElementChanged):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):

  • WebView/WebHTMLRepresentation.mm:

(inputElementFromDOMElement):

Source/WebKit/win:

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

  • DOMHTMLClasses.cpp:

(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::rectOnScreen):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):

  • WebFrame.cpp:

(inputElementFromDOMElement):

Source/WebKit2:

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::isTextField):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::focusedElementChanged):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormControls):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeValue):
(WebKit::WebPage::setAssistedNodeValueAsNumber):
(WebKit::WebPage::setAssistedNodeSelectedIndex):

2:22 PM Changeset in webkit [173931] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

[iOS] Remove MediaPlayer::setHasPlaybackTargetAvailabilityListeners
​https://bugs.webkit.org/show_bug.cgi?id=137075

Reviewed by Dean Jackson.

No new tests, this just removes unused code.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setHasPlaybackTargetAvailabilityListeners): Deleted.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::setHasPlaybackTargetAvailabilityListeners): Deleted.

1:11 PM Changeset in webkit [173930] by adachan@apple.com
  • 4 edits in trunk/Source/WebKit2

Add stub implementation of WKPageIsPlayingAudio().
​https://bugs.webkit.org/show_bug.cgi?id=137044

Reviewed by Anders Carlsson.

Also add an isPlayingAudioDidChange callback to WKPageUIClient.

  • UIProcess/API/C/WKPage.cpp:

(WKPageIsPlayingAudio):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/API/C/WKPageUIClient.h:
12:58 PM Changeset in webkit [173929] by timothy@apple.com
  • 53 edits
    1 copy
    5 adds
    1 delete in trunk/Source

Make the Web Inspector use a separate web process.

​https://bugs.webkit.org/show_bug.cgi?id=135120

Reviewed by Anders Carlsson.

Source/WebCore:

  • English.lproj/Localizable.strings: Updated.
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptGlobalObject.h:
  • bindings/js/ScriptState.h:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorPageAgent.h:
  • page/Chrome.h:

Exported a few functions and private headers.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::hasInspectorFrontendClient):
(WebCore::InspectorController::show):

  • inspector/InspectorController.h:

Make InspectorFrontendClient a pointer instead of a std::unique_ptr.
This makes it easier to implement InspectorFrontendClient as
part of an existing object that is externally owned.

  • testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):

  • testing/Internals.h:

Change InspectorFrontendClientDummy from being moved to owned.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js: Updated.
  • UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
Move InspectorFrontendHost.loaded to later in the load.
Calling it early just shows the window before we have
a user interface to show.

  • UserInterface/Base/Test.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
Match the changes in Main.js.

  • UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.savedURL): Change comment.
(InspectorFrontendAPI.appendedToURL): Change comment.
(InspectorFrontendAPI.dispatch): Add an assert and early
return to be safe from unknown commands.
(InspectorFrontendAPI.loadCompleted): Delete _pendingCommands,
no need to keep an empty array around a one time use.

Source/WebKit/ios:

  • WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorClient::WebInspectorClient):
Removed m_frontendClient initialization since it is
now a std::unique_ptr that defaults to nullptr.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::releaseFrontend):
Own WebInspectorFrontendClient instead of moving it.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend):

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient::frontendClient):
Own WebInspectorFrontendClient instead of moving it.

Source/WebKit2:

  • CMakeLists.txt:
  • DerivedSources.make:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • WebKit2.xcodeproj/project.pbxproj:

Added new WebInspectorUI files and removed WebInspectorFrontendClient.cpp.

  • Shared/APIObject.h: Added BundleInspectorUI.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:

(WebKit::ChildProcessMainDelegate::getExtraInitializationData):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):
Add support for "inspector-process" data, a boolean that is used by
WebProcess::initializeProcessName.

  • UIProcess/API/C/WKInspector.cpp:

(WKInspectorIsDebuggingJavaScript):
(WKInspectorToggleJavaScriptDebugging):
(WKInspectorIsProfilingJavaScript):
(WKInspectorToggleJavaScriptProfiling):

  • UIProcess/API/C/WKInspector.h:

Stub out functions we don't support but need to keep for nightly compatibility.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):
(WebKit::WebInspectorProxy::connect):
(WebKit::WebInspectorProxy::showConsole):
(WebKit::WebInspectorProxy::showResources):
(WebKit::WebInspectorProxy::showMainResourceForFrame):
(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
(WebKit::WebInspectorProxy::inspectorContext):
(WebKit::WebInspectorProxy::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::open):
(WebKit::WebInspectorProxy::didClose):
(WebKit::WebInspectorProxy::attachAvailabilityChanged):

  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::isConnected):
(WebKit::WebInspectorProxy::canAttach):

  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformAttach):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter close]):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformHide):
(WebKit::WebInspectorProxy::platformSave):
(WebKit::WebInspectorProxy::platformAppend):
(WebKit::WebInspectorProxy::platformAttach):
Changed how the Inspector page is created by making it in a new WebContext for
the Inspector. This removes us from the main process pool and guarantees no process
sharing for our user interface. Also send new WebInspectorUI messages to the Inspector
page and not the inspected page when appropriate.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions): Add "inspector-process" to extraInitializationData
if the context is the Inspector context. This is used by WebProcess::initializeProcessName.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend):
(WebKit::WebInspectorClient::closeInspectorFrontend):
(WebKit::WebInspectorClient::bringFrontendToFront):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:

Remove the InspectorFrontendChannel class from WebInspectorClient and clean up a little.
InspectorFrontendChannel implementation moved to WebInspector.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: Removed. Superseded by WebInspectorUI.
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::create):
(WebKit::WebInspector::WebInspector):
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::closeFrontend):
(WebKit::WebInspector::openInNewTab):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::canAttachWindow):
(WebKit::WebInspector::updateDockingAvailability):
(WebKit::WebInspector::sendMessageToBackend):
(WebKit::WebInspector::sendMessageToFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):

  • WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::didClose):
(WebKit::WebInspector::didReceiveInvalidMessage):
(WebKit::WebInspector::setAttached):

  • WebProcess/WebPage/WebInspector.messages.in:

Stop taking an optional InspectorFrontendChannel and inherit it instead. Create a connection that
can be passed to the other web process for WebInspectorUI to use. Stop referencing Inspector's page
directly, since it is in another process now.

  • WebProcess/WebPage/WebInspectorUI.cpp: Added.

(WebKit::WebInspectorUI::create):
(WebKit::WebInspectorUI::WebInspectorUI):
(WebKit::WebInspectorUI::establishConnection):
(WebKit::WebInspectorUI::windowObjectCleared):
(WebKit::WebInspectorUI::frontendLoaded):
(WebKit::WebInspectorUI::moveWindowBy):
(WebKit::WebInspectorUI::bringToFront):
(WebKit::WebInspectorUI::closeWindow):
(WebKit::WebInspectorUI::requestSetDockSide):
(WebKit::WebInspectorUI::setDockSide):
(WebKit::WebInspectorUI::changeAttachedWindowHeight):
(WebKit::WebInspectorUI::changeAttachedWindowWidth):
(WebKit::WebInspectorUI::setToolbarHeight):
(WebKit::WebInspectorUI::openInNewTab):
(WebKit::WebInspectorUI::save):
(WebKit::WebInspectorUI::append):
(WebKit::WebInspectorUI::inspectedURLChanged):
(WebKit::WebInspectorUI::showConsole):
(WebKit::WebInspectorUI::showResources):
(WebKit::WebInspectorUI::showMainResourceForFrame):
(WebKit::WebInspectorUI::startPageProfiling):
(WebKit::WebInspectorUI::stopPageProfiling):
(WebKit::WebInspectorUI::didSave):
(WebKit::WebInspectorUI::didAppend):
(WebKit::WebInspectorUI::sendMessageToFrontend):
(WebKit::WebInspectorUI::sendMessageToBackend):
(WebKit::WebInspectorUI::evaluateCommandOnLoad):
(WebKit::WebInspectorUI::evaluateExpressionOnLoad):
(WebKit::WebInspectorUI::evaluatePendingExpressions):

  • WebProcess/WebPage/WebInspectorUI.h: Added.

(WebKit::WebInspectorUI::page):
(WebKit::WebInspectorUI::didClose):
(WebKit::WebInspectorUI::didReceiveInvalidMessage):
(WebKit::WebInspectorUI::attachedBottom):
(WebKit::WebInspectorUI::attachedRight):
(WebKit::WebInspectorUI::detached):
(WebKit::WebInspectorUI::evaluateCommandOnLoad):

  • WebProcess/WebPage/WebInspectorUI.messages.in: Added.
  • WebProcess/WebPage/efl/WebInspectorUIEfl.cpp: Added.

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):

  • WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp: Added.

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):

  • WebProcess/WebPage/mac/WebInspectorUIMac.mm: Added.

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):
Implement the InspectorFrontendClient and handle a connection to the inspected page's WebInspector.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
(WebKit::WebPage::inspector):
(WebKit::WebPage::inspectorUI):
(WebKit::WebPage::didReceiveMessage):
Setup as a listener for WebInspectorUI messages.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::isInspectorPage): It is an Inspector page if we have a m_inspectorUI.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeProcessName):
Name the process "%@ Web Inspector" if it is an Inspector content process. Processes in that
context are not shared with multiple pages.

12:57 PM Changeset in webkit [173928] by dino@apple.com
  • 5 edits in trunk/Source/WebCore

[Yosemite] Button text doesn't go white while pushing the button, like it does for real buttons
​https://bugs.webkit.org/show_bug.cgi?id=137054
rdar://problem/17559038

Reviewed by NOBODY (OOPS!).

On Yosemite and above, system buttons paint with white-ish text when they
are pressed. Since this isn't exposed by API, I've hardcoded the value
into RenderThemeMac.

The actual state is exposed by adding a :active rule to html.css that
uses a new CSSValueKeyword: ActiveButtonText.

Unfortunately I can't find a way to test this, because the active state isn't
testable. We should really expose the Inspector's forcePseudoState function into
window.internals.

  • css/CSSValueKeywords.in: Add "activebuttontext".
  • css/html.css:

(input[type="button"]:active, input[type="submit"]:active, input[type="reset"]:active, input[type="file"]::-webkit-file-upload-button:active, button:active): New rule for active
button elements.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::systemColor): Handle CSSValueActivebuttontext as black.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor): Handle CSSValueActivebuttontext as
white with 75% opacity.

12:52 PM Changeset in webkit [173927] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Add a deprecated stub for WKPreferencesSetMultithreadedWebGLEnabled (and Get)
​https://bugs.webkit.org/show_bug.cgi?id=137071

Reviewed by Brent Fulgham.

Put in stubs for WKPreferencesSetMultithreadedWebGLEnabled and
WKPreferencesGetMultithreadedWebGLEnabled. These were removed in
r173776 but are still needed for nightly builds to link
(or will be once Yosemite nightlies are available).

  • Shared/API/c/WKDeprecatedFunctions.cpp:

(WKPreferencesSetMultithreadedWebGLEnabled):
(WKPreferencesGetMultithreadedWebGLEnabled):

12:24 PM Changeset in webkit [173926] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Tentative fix for Windows test bots.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath.convert):

10:30 AM Changeset in webkit [173925] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add New Test for overrideMimeType in XMLHttpRequest.
​https://bugs.webkit.org/show_bug.cgi?id=137057

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-09-24
Reviewed by Alexey Proskuryakov.

As part of bug: ​https://bugs.webkit.org/show_bug.cgi?id=136699, add more tests to test overrideMimeType for all states.

  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html: Added.
10:26 AM Changeset in webkit [173924] by ap@apple.com
  • 13 edits in trunk/Tools

Change more build.webkit.org links to https
​https://bugs.webkit.org/show_bug.cgi?id=137049

Reviewed by Csaba Osztrogonác.

Fix appspot, svn.webkit.org and Trac links.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:

(ViewController.prototype._domForBuildName):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:

(EWS):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:

(TestHistory):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
9:59 AM Changeset in webkit [173923] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS] Fix the iOS build after <​http://trac.webkit.org/changeset/173893>
(​https://bugs.webkit.org/show_bug.cgi?id=137007)

Add closing parenthesis characters that were inadvertently removed in <​http://trac.webkit.org/changeset/173893>.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeSelectedIndex):
(WebKit::WebPage::getAssistedNodeInformation):

9:11 AM Changeset in webkit [173922] by llango.u-szeged@partner.samsung.com
  • 4 edits in trunk

Update the list of u-szeged contributors.

Rubber-stamped by Csaba Osztrogonác <Csaba Osztrogonác>.

Tools:

  • Scripts/webkitpy/common/config/contributors.json:

Websites/webkit.org:

  • team.html:
8:56 AM Changeset in webkit [173921] by Chris Dumez
  • 34 edits in trunk/Source/WebCore

Use is<SVG*Element>() instead of isSVG*Element()
​https://bugs.webkit.org/show_bug.cgi?id=137058

Reviewed by Dirk Schulze.

Use is<SVG*Element>() instead of isSVG*Element() and drop support for
generated isSVG*Element().

No new tests, no behavior change.

  • css/CSSCursorImageValue.cpp:

(WebCore::resourceReferencedByCursorElement):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::useSVGZoomRulesForLength):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/gtk/EditorGtk.cpp:

(WebCore::elementURL):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::isLiveLink):

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):

  • rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

  • rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromCircleElement):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):

  • svg/SVGAltGlyphDefElement.cpp:

(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::hasValidAttributeType):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::rootElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::isOutermostSVGSVGElement):
(WebCore::SVGElement::ownerSVGElement):
(WebCore::SVGElement::viewportElement):

  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::build):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::findLightElement):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::ensureGlyphCache):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::associatedFontElement):
(WebCore::SVGFontFaceElement::rebuildFontFace):

  • svg/SVGFontFaceSrcElement.cpp:

(WebCore::SVGFontFaceSrcElement::srcValue):
(WebCore::SVGFontFaceSrcElement::childrenChanged):

  • svg/SVGGlyphElement.cpp:

(WebCore::SVGGlyphElement::invalidateGlyphCache):

  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):

  • svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::determineViewport):

  • svg/SVGLocatable.cpp:

(WebCore::isViewportElement):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::pathElement):
(WebCore::SVGMPathElement::notifyParentOfPathChange):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::invalidateMPathDependencies):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::collectPatternAttributes):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setupInitialView):

  • svg/SVGUseElement.cpp:

(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):

  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):

8:40 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
8:11 AM Changeset in webkit [173920] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.6.0

WebKitGTK+ 2.6.0

8:10 AM Changeset in webkit [173919] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.6.0 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.6.0.
6:38 AM Changeset in webkit [173918] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore

Merge r173886 - [CLoop] - Fix CLoop on the 32-bit Big-Endians
​https://bugs.webkit.org/show_bug.cgi?id=137020

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-09-23
Reviewed by Mark Lam.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
6:37 AM Changeset in webkit [173917] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173848 - WebSocket crash when a connection is closed from server side
​https://bugs.webkit.org/show_bug.cgi?id=137009
rdar://problem/18333977
rdar://problem/12708225

Reviewed by Brady Eidson.

I don't think that this can be tested with our test server.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel): Added logging.
(WebCore::WebSocketChannel::~WebSocketChannel): Ditto.
(WebCore::WebSocketChannel::close): Protect self, because startClosingHandshake
can release the last reference.
(WebCore::WebSocketChannel::fail): Added an assertion that the channel is always
closed after this function.
(WebCore::WebSocketChannel::startClosingHandshake): Protect self, and don't change
the stack from closed back to closing if after failing to send closing handshake.
(WebCore::WebSocketChannel::processOutgoingFrameQueue): Protect self.

6:36 AM Changeset in webkit [173916] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r173845 - Bad cast in isValidColumnSpanner.
​https://bugs.webkit.org/show_bug.cgi?id=133380.

Reviewed by Simon Fraser.

Source/WebCore:

Added fast/multicol/multicol-crazy-nesting.html

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
The crawl up the chain looking for unsplittable objects should use containing blocks
and not be casting to parent boxes. You can have an inline in the parent chain, so
this was not the right way to walk up the tree.

LayoutTests:

  • fast/multicol/multicol-crazy-nesting-expected.txt: Added.
  • fast/multicol/multicol-crazy-nesting.html: Added.
6:35 AM Changeset in webkit [173915] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r173843 - ASSERT in RenderMultiColumnSet::requiresBalancing.
​https://bugs.webkit.org/show_bug.cgi?id=136376.

Reviewed by David Kilzer.

Source/WebCore:

Added fast/multicol/multicol-selection.html.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
Don't allow an object to become a spanner if it does not have the flow
thread as its containing block. Otherwise the flow thread won't get notified
of spanner placeholder insertions, and so the spanner ends up orphaned.

LayoutTests:

  • fast/multicol/multicol-selection-expected.txt: Added.
  • fast/multicol/multicol-selection.html: Added.
6:33 AM Changeset in webkit [173914] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173836 - REGRESSION(r173631): It broke the !ENABLE(VIDEO) build
​https://bugs.webkit.org/show_bug.cgi?id=136946

Reviewed by Jer Noble.

No new tests required, no new functionality.

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

5:59 AM Changeset in webkit [173913] by Carlos Garcia Campos
  • 5 edits
    1 copy
    104 adds in releases/WebKitGTK/webkit-2.6/Source/WebInspectorUI

Merge r173912 - Unreviewed. Add more free icons for the Web Inspector in GTK+

Patch by Andres Gomez <Andres Gomez> on 2014-09-24

  • UserInterface/Images/gtk/AUTHORS:
  • UserInterface/Images/gtk/ApplicationCache.png: Added.
  • UserInterface/Images/gtk/​ApplicationCache@2x.png: Added.
  • UserInterface/Images/gtk/BottomUpTree.svg: Added.
  • UserInterface/Images/gtk/Breakpoint.png: Added.
  • UserInterface/Images/gtk/​Breakpoint@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointButton.svg:
  • UserInterface/Images/gtk/BreakpointInactive.png: Added.
  • UserInterface/Images/gtk/​BreakpointInactive@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointInactiveButton.svg:
  • UserInterface/Images/gtk/COPYING:
  • UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
  • UserInterface/Images/gtk/ClippingCSS.png: Added.
  • UserInterface/Images/gtk/​ClippingCSS@2x.png: Added.
  • UserInterface/Images/gtk/ClippingGeneric.png: Added.
  • UserInterface/Images/gtk/​ClippingGeneric@2x.png: Added.
  • UserInterface/Images/gtk/ClippingJS.png: Added.
  • UserInterface/Images/gtk/​ClippingJS@2x.png: Added.
  • UserInterface/Images/gtk/CloseTimeline.png: Added.
  • UserInterface/Images/gtk/​CloseTimeline@2x.png: Added.
  • UserInterface/Images/gtk/ColorIcon.png: Added.
  • UserInterface/Images/gtk/​ColorIcon@2x.png: Added.
  • UserInterface/Images/gtk/Colors.png: Added.
  • UserInterface/Images/gtk/​Colors@2x.png: Added.
  • UserInterface/Images/gtk/ColorsLarge.png: Added.
  • UserInterface/Images/gtk/​ColorsLarge@2x.png: Added.
  • UserInterface/Images/gtk/Database.png: Added.
  • UserInterface/Images/gtk/​Database@2x.png: Added.
  • UserInterface/Images/gtk/DatabaseTable.png: Added.
  • UserInterface/Images/gtk/​DatabaseTable@2x.png: Added.
  • UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
  • UserInterface/Images/gtk/Issues.svg: Added.
  • UserInterface/Images/gtk/IssuesEnabled.svg: Added.
  • UserInterface/Images/gtk/LayerBorders.svg: Added.
  • UserInterface/Images/gtk/LessColumns.svg: Added.
  • UserInterface/Images/gtk/LocalStorage.png: Added.
  • UserInterface/Images/gtk/​LocalStorage@2x.png: Added.
  • UserInterface/Images/gtk/Locked.svg: Added.
  • UserInterface/Images/gtk/Logs.svg: Added.
  • UserInterface/Images/gtk/Memory.svg: Added.
  • UserInterface/Images/gtk/MoreColumns.svg: Added.
  • UserInterface/Images/gtk/Native.svg: Added.
  • UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBug.svg: Added.
  • UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
  • UserInterface/Images/gtk/NavigationItemFile.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLog.svg: Added.
  • UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
  • UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
  • UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
  • UserInterface/Images/gtk/Network.png: Added.
  • UserInterface/Images/gtk/​Network@2x.png: Added.
  • UserInterface/Images/gtk/NetworkLarge.png: Added.
  • UserInterface/Images/gtk/​NetworkLarge@2x.png: Added.
  • UserInterface/Images/gtk/Pause.svg: Added.
  • UserInterface/Images/gtk/Percent.svg: Added.
  • UserInterface/Images/gtk/Plus.svg: Added.
  • UserInterface/Images/gtk/PseudoElement.svg: Added.
  • UserInterface/Images/gtk/Reflection.svg: Added.
  • UserInterface/Images/gtk/Reload.svg: Added.
  • UserInterface/Images/gtk/Request.svg: Added.
  • UserInterface/Images/gtk/Response.svg: Added.
  • UserInterface/Images/gtk/ResultLine.svg: Added.
  • UserInterface/Images/gtk/Resume.svg: Added.
  • UserInterface/Images/gtk/SessionStorage.png: Added.
  • UserInterface/Images/gtk/​SessionStorage@2x.png: Added.
  • UserInterface/Images/gtk/ShadowDOM.svg: Added.
  • UserInterface/Images/gtk/SourceCode.svg: Added.
  • UserInterface/Images/gtk/SplitToggleDown.svg: Added.
  • UserInterface/Images/gtk/SplitToggleUp.svg: Added.
  • UserInterface/Images/gtk/StepInto.svg: Added.
  • UserInterface/Images/gtk/StepOut.svg: Added.
  • UserInterface/Images/gtk/StepOver.svg: Added.
  • UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUser.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
  • UserInterface/Images/gtk/Time.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
  • UserInterface/Images/gtk/Undock.svg: Added.
  • UserInterface/Images/gtk/UserInputPrompt.svg: Added.
  • UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
  • UserInterface/Images/gtk/UserInputResult.svg: Added.
  • UserInterface/Images/gtk/Warning.svg: Added.
  • UserInterface/Images/gtk/Weight.svg: Added.
5:53 AM Changeset in webkit [173912] by Carlos Garcia Campos
  • 5 edits
    1 copy
    104 adds in trunk/Source/WebInspectorUI

Unreviewed. Add more free icons for the Web Inspector in GTK+

Patch by Andres Gomez <Andres Gomez> on 2014-09-24

  • UserInterface/Images/gtk/AUTHORS:
  • UserInterface/Images/gtk/ApplicationCache.png: Added.
  • UserInterface/Images/gtk/​ApplicationCache@2x.png: Added.
  • UserInterface/Images/gtk/BottomUpTree.svg: Added.
  • UserInterface/Images/gtk/Breakpoint.png: Added.
  • UserInterface/Images/gtk/​Breakpoint@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointButton.svg:
  • UserInterface/Images/gtk/BreakpointInactive.png: Added.
  • UserInterface/Images/gtk/​BreakpointInactive@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointInactiveButton.svg:
  • UserInterface/Images/gtk/COPYING:
  • UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
  • UserInterface/Images/gtk/ClippingCSS.png: Added.
  • UserInterface/Images/gtk/​ClippingCSS@2x.png: Added.
  • UserInterface/Images/gtk/ClippingGeneric.png: Added.
  • UserInterface/Images/gtk/​ClippingGeneric@2x.png: Added.
  • UserInterface/Images/gtk/ClippingJS.png: Added.
  • UserInterface/Images/gtk/​ClippingJS@2x.png: Added.
  • UserInterface/Images/gtk/CloseTimeline.png: Added.
  • UserInterface/Images/gtk/​CloseTimeline@2x.png: Added.
  • UserInterface/Images/gtk/ColorIcon.png: Added.
  • UserInterface/Images/gtk/​ColorIcon@2x.png: Added.
  • UserInterface/Images/gtk/Colors.png: Added.
  • UserInterface/Images/gtk/​Colors@2x.png: Added.
  • UserInterface/Images/gtk/ColorsLarge.png: Added.
  • UserInterface/Images/gtk/​ColorsLarge@2x.png: Added.
  • UserInterface/Images/gtk/Database.png: Added.
  • UserInterface/Images/gtk/​Database@2x.png: Added.
  • UserInterface/Images/gtk/DatabaseTable.png: Added.
  • UserInterface/Images/gtk/​DatabaseTable@2x.png: Added.
  • UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
  • UserInterface/Images/gtk/Issues.svg: Added.
  • UserInterface/Images/gtk/IssuesEnabled.svg: Added.
  • UserInterface/Images/gtk/LayerBorders.svg: Added.
  • UserInterface/Images/gtk/LessColumns.svg: Added.
  • UserInterface/Images/gtk/LocalStorage.png: Added.
  • UserInterface/Images/gtk/​LocalStorage@2x.png: Added.
  • UserInterface/Images/gtk/Locked.svg: Added.
  • UserInterface/Images/gtk/Logs.svg: Added.
  • UserInterface/Images/gtk/Memory.svg: Added.
  • UserInterface/Images/gtk/MoreColumns.svg: Added.
  • UserInterface/Images/gtk/Native.svg: Added.
  • UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBug.svg: Added.
  • UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
  • UserInterface/Images/gtk/NavigationItemFile.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLog.svg: Added.
  • UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
  • UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
  • UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
  • UserInterface/Images/gtk/Network.png: Added.
  • UserInterface/Images/gtk/​Network@2x.png: Added.
  • UserInterface/Images/gtk/NetworkLarge.png: Added.
  • UserInterface/Images/gtk/​NetworkLarge@2x.png: Added.
  • UserInterface/Images/gtk/Pause.svg: Added.
  • UserInterface/Images/gtk/Percent.svg: Added.
  • UserInterface/Images/gtk/Plus.svg: Added.
  • UserInterface/Images/gtk/PseudoElement.svg: Added.
  • UserInterface/Images/gtk/Reflection.svg: Added.
  • UserInterface/Images/gtk/Reload.svg: Added.
  • UserInterface/Images/gtk/Request.svg: Added.
  • UserInterface/Images/gtk/Response.svg: Added.
  • UserInterface/Images/gtk/ResultLine.svg: Added.
  • UserInterface/Images/gtk/Resume.svg: Added.
  • UserInterface/Images/gtk/SessionStorage.png: Added.
  • UserInterface/Images/gtk/​SessionStorage@2x.png: Added.
  • UserInterface/Images/gtk/ShadowDOM.svg: Added.
  • UserInterface/Images/gtk/SourceCode.svg: Added.
  • UserInterface/Images/gtk/SplitToggleDown.svg: Added.
  • UserInterface/Images/gtk/SplitToggleUp.svg: Added.
  • UserInterface/Images/gtk/StepInto.svg: Added.
  • UserInterface/Images/gtk/StepOut.svg: Added.
  • UserInterface/Images/gtk/StepOver.svg: Added.
  • UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUser.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
  • UserInterface/Images/gtk/Time.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
  • UserInterface/Images/gtk/Undock.svg: Added.
  • UserInterface/Images/gtk/UserInputPrompt.svg: Added.
  • UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
  • UserInterface/Images/gtk/UserInputResult.svg: Added.
  • UserInterface/Images/gtk/Warning.svg: Added.
  • UserInterface/Images/gtk/Weight.svg: Added.
2:14 AM Changeset in webkit [173911] by commit-queue@webkit.org
  • 7 edits
    3 deletes in trunk

Unreviewed, rolling out r173839.
​https://bugs.webkit.org/show_bug.cgi?id=137062

NumberConstruct should no longer use static tables (Requested
by dpino on #webkit).

Reverted changeset:

"Simple ES6 feature: Number constructor extras"
​https://bugs.webkit.org/show_bug.cgi?id=131707
​http://trac.webkit.org/changeset/173839

1:35 AM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com
(diff)
12:56 AM Changeset in webkit [173910] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk

Remove the style marking from :nth-child()
​https://bugs.webkit.org/show_bug.cgi?id=137055

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-24
Reviewed by Andreas Kling.

Source/WebCore:

Previously, :nth-child() had to mark the RenderStyle as unique in order
to prevent it from being used for style sharing.

After r173229, :nth-child() use the more generic element marking
"StyleIsAffectedByPreviousSibling".

In StyleResolver::canShareStyleWithElement(), StyleIsAffectedByPreviousSibling
is already used to prevent style sharing of those elements, making the "Unique"
flag redundant.

Since it is now useless, remove the style marking from SelectorChecker and the CSS JIT.

Tests: fast/css/nth-child-style-sharing-even.html

fast/css/nth-child-style-sharing-fixed-integer.html
fast/css/nth-child-style-sharing-odd.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::setElementChildIndexAndUpdateStyle): Deleted.

  • rendering/style/RenderStyle.h:

LayoutTests:

Add basic tests for style sharing with :nth-child().

  • fast/css/nth-child-style-sharing-even-expected.html: Added.
  • fast/css/nth-child-style-sharing-even.html: Added.
  • fast/css/nth-child-style-sharing-fixed-integer-expected.html: Added.
  • fast/css/nth-child-style-sharing-fixed-integer.html: Added.
  • fast/css/nth-child-style-sharing-odd-expected.html: Added.
  • fast/css/nth-child-style-sharing-odd.html: Added.

Sep 23, 2014:

11:31 PM WebKitGTK/2.6.x edited by tpopela@redhat.com
(diff)
10:10 PM Changeset in webkit [173909] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

2014-09-23 Geoffrey Garen <​ggaren@apple.com>

Rolled out r173346.

bmalloc should honor the FastMalloc statistics API
​https://bugs.webkit.org/show_bug.cgi?id=136592

This didn't really work. Because we allow ranges with and without
physical pages to merge, and we allow double-committing and
double-decommitting, we can't rely on commit actions to track memory
footprint.

  • wtf/FastMalloc.cpp: (WTF::fastMallocStatistics):
10:07 PM Changeset in webkit [173908] by ggaren@apple.com
  • 6 edits in trunk/Source/bmalloc

2014-09-23 Geoffrey Garen <​ggaren@apple.com>

Rolled out r173346.

bmalloc should honor the FastMalloc statistics API
​https://bugs.webkit.org/show_bug.cgi?id=136592

This didn't really work. Because we allow ranges with and without
physical pages to merge, and we allow double-committing and
double-decommitting, we can't rely on commit actions to track memory
footprint.

  • bmalloc/Heap.cpp: (bmalloc::Heap::size): Deleted. (bmalloc::Heap::capacity): Deleted.
  • bmalloc/Heap.h:
  • bmalloc/VMHeap.cpp: (bmalloc::VMHeap::VMHeap): (bmalloc::VMHeap::allocateSmallChunk): (bmalloc::VMHeap::allocateMediumChunk): (bmalloc::VMHeap::allocateLargeChunk):
  • bmalloc/VMHeap.h: (bmalloc::VMHeap::allocateSmallPage): (bmalloc::VMHeap::allocateMediumPage): (bmalloc::VMHeap::allocateLargeRange): (bmalloc::VMHeap::deallocateSmallPage): (bmalloc::VMHeap::deallocateMediumPage): (bmalloc::VMHeap::deallocateLargeRange): (bmalloc::VMHeap::size): Deleted. (bmalloc::VMHeap::capacity): Deleted.
  • bmalloc/bmalloc.h: (bmalloc::api::heapSize): Deleted. (bmalloc::api::heapCapacity): Deleted.
8:31 PM Changeset in webkit [173907] by Chris Dumez
  • 9 edits in trunk/Source/WebCore

Add support for is<HTML*Element>() for type checking
​https://bugs.webkit.org/show_bug.cgi?id=137015

Reviewed by Benjamin Poulain.

Add support for is<HTML*Element>() for type checking while keeping
support for the legacy toHTML*Element() form until the code base is
ported.

toHTML*Element() helpers are now macros to the new is<HTML*Element>()
type checking helpers.

No new tests, no behavior change.

  • dom/Document.cpp:

(WebCore::Document::setTitle):

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:

(WebCore::is):
(WebCore::downcast):
(WebCore::isElementOfType): Deleted.

  • dom/ElementAncestorIterator.h:

(WebCore::lineageOfType):

  • dom/ElementIterator.h:

(WebCore::findElementAncestorOfType):

  • dom/ElementTraversal.h:

(WebCore::Traversal<ElementType>::firstChildTemplate):
(WebCore::Traversal<ElementType>::lastChildTemplate):
(WebCore::Traversal<ElementType>::firstWithinTemplate):
(WebCore::Traversal<ElementType>::lastWithinTemplate):
(WebCore::Traversal<ElementType>::nextTemplate):
(WebCore::Traversal<ElementType>::previous):
(WebCore::Traversal<ElementType>::nextSibling):
(WebCore::Traversal<ElementType>::previousSibling):
(WebCore::Traversal<ElementType>::nextSkippingChildren):

  • dom/TypedElementDescendantIterator.h:

(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::from):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::from):

  • dom/make_names.pl:

(printTypeHelpers):

8:17 PM Changeset in webkit [173906] by benjamin@webkit.org
  • 3 edits
    8 adds in trunk

The style resolution cache applies properties incorrectly whenever direction != ltr
​https://bugs.webkit.org/show_bug.cgi?id=137052

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-23
Reviewed by Andreas Kling.

Source/WebCore:

The optimization r135021 introduced a bug whenever the direction of subtree is not
uniform in the whole page.

When StyleResolver::applyMatchedProperties() resolves the style, some properties are
resolved differently based on the writing-mode and the direction.

In isCacheableInMatchedPropertiesCache(), the cases for writing-mode are already handled
by not caching any style with anything else than the default.
The direction was ignored, causing the bugs solved here.

Tests: css3/flexbox/flex-flow-2.html

fast/css/style-resolver-cache-direction-1.html
fast/css/style-resolver-cache-direction-2.html
fast/css/style-resolver-cache-direction-3.html

  • css/StyleResolver.cpp:

(WebCore::isCacheableInMatchedPropertiesCache):

LayoutTests:

  • css3/flexbox/flex-flow-2-expected.txt: Added.
  • css3/flexbox/flex-flow-2.html: Added.

The test flex-flow.html should have uncovered the bug. It did not because it uses
:nth-child(), which disable style optimizations.

flex-flow-2.html is a copy of flex-flow.html using classes instead of :nth-child().
This would have caught the bug.

  • fast/css/style-resolver-cache-direction-1-expected.html: Added.
  • fast/css/style-resolver-cache-direction-1.html: Added.
  • fast/css/style-resolver-cache-direction-2-expected.html: Added.
  • fast/css/style-resolver-cache-direction-2.html: Added.
  • fast/css/style-resolver-cache-direction-3-expected.html: Added.
  • fast/css/style-resolver-cache-direction-3.html: Added.

New basic tests for the fix.

6:45 PM Changeset in webkit [173905] by Chris Dumez
  • 18 edits in trunk/Source/WebCore

Have CSS classes' methods return more references
​https://bugs.webkit.org/show_bug.cgi?id=137036

Reviewed by Ryosuke Niwa.

Have CSS classes' methods return more references instead of pointers
when possible.

No new tests, no behavior change.

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::style):

  • css/CSSFontFaceRule.h:
  • css/CSSGroupingRule.cpp:

(WebCore::CSSGroupingRule::cssRules):

  • css/CSSGroupingRule.h:
  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::media):

  • css/CSSImportRule.h:
  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::style):

  • css/CSSPageRule.h:
  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::style):

  • css/CSSStyleRule.h:
  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::style):

  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::cssRules):

  • css/WebKitCSSKeyframesRule.h:
  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::style):

  • css/WebKitCSSViewportRule.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::styleForId):
(WebCore::InspectorStyleSheet::ruleIndexByStyle):
(WebCore::InspectorStyleSheet::ruleId):
(WebCore::InspectorStyleSheet::revalidateStyle):

5:52 PM Changeset in webkit [173904] by roger_fong@apple.com
  • 4 edits in trunk

[Windows] Enable CSS Supports Rule on Windows.

  • win/tools/vsprops/FeatureDefines.props:
  • css/CSSAllInOne.cpp:
5:46 PM Changeset in webkit [173903] by roger_fong@apple.com
  • 3 edits in trunk/Tools

[Windows] More debugging for the Windows bots.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath):

5:16 PM Changeset in webkit [173902] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Fix for r173899, those tabs should be spaces.

  • Scripts/webkitpy/port/driver.py:

(Driver._command_from_driver_input):
(Driver): Deleted.

5:08 PM Changeset in webkit [173901] by roger_fong@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

[Windows] More windows test gardening of some fast/dom tests.

  • platform/win/TestExpectations:
  • platform/win/fast/dom/NavigatorContentUtils: Added.
  • platform/win/fast/dom/NavigatorContentUtils/is-protocol-handler-registered-expected.txt: Added.
  • platform/win/fast/dom/navigator-detached-no-crash-expected.txt: Added.
4:58 PM Changeset in webkit [173900] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] 64-bit Build fix after r173882.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add correct 64-bit mangled symbol name.
4:34 PM Changeset in webkit [173899] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.

  • Scripts/webkitpy/port/driver.py:

(Driver):

4:07 PM Changeset in webkit [173898] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Rollout 173848. rdar://problem/12708225

3:30 PM Changeset in webkit [173897] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r173848. rdar://problem/12708225

3:29 PM Changeset in webkit [173896] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DebuggerCallFrame::invalidate() should invalidate all DebuggerScope chains.
<​https://webkit.org/b/137045>

Reviewed by Geoffrey Garen.

DebuggerCallFrame::invalidate() currently invalidates all DebuggerCallFrames
in the debugger stack, but only invalidates the DebuggerScope chain of the
top most frame. We should also invalidate all the DebuggerScope chains of
the other frames in the debugger stack.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::invalidate):

  • debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::invalidateChain):

3:27 PM Changeset in webkit [173895] by Chris Dumez
  • 27 edits in trunk/Source

Unreviewed build fix after r173893.

Partial revert of r173893 to fix debug builds.

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::text):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::isPlaceholderShown):

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateName):
(WebCore::Element::updateId):

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):
(WebCore::findFirstMarkable):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::matchesReadWritePseudoClass):
(WebCore::HTMLElement::directionality):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::enclosingTextFormControl):

  • page/FrameView.cpp:

(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absolutePDFURL):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::plugInImageElement):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • testing/Internals.cpp:

(WebCore::Internals::visiblePlaceholder):

Source/WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::URL):
(DOMHTMLDocument::body):
(DOMHTMLDocument::forms):

Source/WebKit2:

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::value):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginSnapshotTimerFired):
(WebKit::PluginView::pluginDidReceiveUserInteraction):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

3:16 PM Changeset in webkit [173894] by Brent Fulgham
  • 6 edits in trunk/Source/WebCore

Implement snapping behavior for Mac overflow scrolling
​https://bugs.webkit.org/show_bug.cgi?id=135774

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-09-22
Reviewed by Beth Dakin.

Hooks into AxisScrollSnapAnimator to implement overflow scroll snapping on Mac.

We need to find a way to test this!

  • dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

  • page/EventHandler.cpp:

(WebCore::handleWheelEventInAppropriateEnclosingBoxForSingleAxis):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):
(WebCore::ScrollAnimator::updateScrollAnimatorsAndTimers):
(WebCore::ScrollAnimator::scrollOffsetInAxis):
(WebCore::ScrollAnimator::immediateScrollInAxis):
(WebCore::ScrollAnimator::startScrollSnapTimer):
(WebCore::ScrollAnimator::stopScrollSnapTimer):
(WebCore::ScrollAnimator::horizontalScrollSnapTimerFired):
(WebCore::ScrollAnimator::verticalScrollSnapTimerFired):

  • platform/ScrollAnimator.h:
  • platform/mac/AxisScrollSnapAnimator.h:
  • platform/mac/AxisScrollSnapAnimator.mm:

(WebCore::AxisScrollSnapAnimator::AxisScrollSnapAnimator):
(WebCore::AxisScrollSnapAnimator::beginScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::endScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::initializeGlideParameters):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):

3:03 PM Changeset in webkit [173893] by Chris Dumez
  • 155 edits in trunk/Source

Use downcast<HTML*Element>() instead of toHTML*Element()
​https://bugs.webkit.org/show_bug.cgi?id=137007

Reviewed by Benjamin Poulain.

Source/WebCore:

Use downcast<HTML*Element>() instead of toHTML*Element() and drop
transition macros for toHTML*Element().

This patch also cleans up the surrounding code.

No new tests, no behavior change.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::labelChanged):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):
(WebCore::AccessibilityListBox::addChildren):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaTimeline::valueDescription):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::isEnabled):
(WebCore::AccessibilityMenuListOption::isSelected):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::stringValue):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isMultiSelectable):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::isNodeActionElement):
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::text):
(WebCore::AccessibilityNodeObject::stringValue):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::labelElementContainer):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
(WebCore::AccessibilityRenderObject::isLinked):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::inputElement):
(WebCore::AccessibilitySliderThumb::elementRect):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableElement):
(WebCore::AccessibilityTable::title):

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):

  • accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

(optionFromSelection):
(webkitAccessibleSelectionGetSelectionCount):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetCaption):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetDescription):

  • accessibility/ios/AccessibilityObjectIOS.mm:

(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isChecked):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::getNamedItem):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::isPlaceholderShown):

  • dom/CurrentScriptIncrementer.h:

(WebCore::CurrentScriptIncrementer::CurrentScriptIncrementer):

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDragImage):

  • dom/Document.cpp:

(WebCore::Document::setTitle):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::iconURLs):

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateName):
(WebCore::Element::updateId):
(WebCore::Element::updateLabel):
(WebCore::Element::ensureCachedHTMLCollection):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/VisitedLinkState.cpp:

(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):
(WebCore::imageElementFromImageDocument):
(WebCore::findFirstMarkable):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):
(WebCore::scanForForm):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):
(WebCore::VisibleSelection::isInPasswordField):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_processElement):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):

  • editing/markup.cpp:

(WebCore::isPlainTextMarkup):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::suggestions):

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm):

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::imageElement):

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::matchesReadWritePseudoClass):
(WebCore::HTMLElement::setInnerHTML):
(WebCore::HTMLElement::directionality):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::computeIsDisabledByFieldsetAncestor):
(WebCore::shouldAutofocus):

  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::getTextFieldValues):
(WebCore::HTMLFormElement::assertItemCanBeInPastNamesMap):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::notifyFinished):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::dataList):
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect):

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::virtualForm):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLNameCollection.cpp:

(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::containsJavaApplet):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions):
(WebCore::HTMLOptGroupElement::ownerSelectElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::ownerDataListElement):
(WebCore::HTMLOptionElement::ownerSelectElement):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

  • html/HTMLOptionsCollection.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::detailsElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::findParentTable):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::rowAfter):
(WebCore::HTMLTableRowsCollection::lastRow):
(WebCore::HTMLTableRowsCollection::customElementAfter):

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::cloneNode):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::enclosingTextFormControl):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::elementMatches):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::descendentVideoElement):
(WebCore::ancestorVideoElement):
(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::updateTickMarkValues):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::insert):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::ownerDocumentForCurrentNode):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::rendererIsNeeded):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::meterElement):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressShadowElement::progressElement):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestObject):

  • page/Chrome.cpp:

(WebCore::Chrome::setToolTip):

  • page/DragController.cpp:

(WebCore::DragController::draggableElement):

  • page/EventHandler.cpp:

(WebCore::isSubmitImage):

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

  • page/FrameView.cpp:

(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):

  • page/ios/FrameIOS.mm:

(WebCore::ancestorRespondingToClickEvents):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absolutePDFURL):
(WebCore::HitTestResult::enterFullscreenForVideo):
(WebCore::HitTestResult::mediaControlsEnabled):
(WebCore::HitTestResult::isLiveLink):
(WebCore::HitTestResult::isContentEditable):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::updateFromElement):

  • rendering/RenderCounter.cpp:

(WebCore::planCounter):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::inputElement):
(WebCore::RenderFileUploadControl::uploadButton):

  • rendering/RenderFrame.cpp:

(WebCore::RenderFrame::frameElement):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::frameSetElement):

  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::canvasElement):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::iframeElement):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::paintAreaElementFocusRing):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):

  • rendering/RenderLayerBacking.cpp:

(WebCore::canvasCompositingStrategy):
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateConfiguration):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForCanvas):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::selectElement):
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::updateListMarkerNumbers):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::marqueeSpeed):

  • rendering/RenderMenuList.cpp:

(WebCore::selectedOptionCount):
(RenderMenuList::selectElement):
(RenderMenuList::updateOptionsWidth):
(RenderMenuList::setTextFromOption):
(RenderMenuList::itemText):
(RenderMenuList::itemIsSelected):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::meterElement):

  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::progressElement):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::element):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::plugInImageElement):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::textAreaElement):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks):

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::videoElement):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageForRenderer):

  • svg/svgtags.in:

Generate helpers to SVGAElement so that isSVGAElement() can be used
instead of hasTagName(SVGNames::aTag). I did such update in this
patch.

  • testing/Internals.cpp:

(WebCore::Internals::visiblePlaceholder):
(WebCore::Internals::wasLastChangeUserEdit):
(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):
(WebCore::Internals::isSelectPopupVisible):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

Source/WebKit/ios:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::focusedElementChanged):

Source/WebKit/mac:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • DOM/WebDOMOperations.mm:

(-[DOMHTMLInputElement _setAutofilled:]):

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedElementChanged):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):

  • WebView/WebHTMLRepresentation.mm:

(inputElementFromDOMElement):

Source/WebKit/win:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::URL):
(DOMHTMLDocument::body):
(DOMHTMLDocument::forms):
(DOMHTMLFormElement::action):
(DOMHTMLFormElement::method):
(DOMHTMLSelectElement::options):
(DOMHTMLSelectElement::activateItemAtIndex):
(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):
(DOMHTMLIFrameElement::contentFrame):

  • WebFrame.cpp:

(formElementFromDOMElement):
(inputElementFromDOMElement):

Source/WebKit2:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::isTextField):
(WebKit::InjectedBundleNodeHandle::htmlTableCellElementCellAbove):
(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):

  • WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:

(WebKit::PDFPluginChoiceAnnotation::commit):

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
(WebKit::PDFPluginTextAnnotation::value):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginSnapshotTimerFired):
(WebKit::PluginView::pluginDidReceiveUserInteraction):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::focusedElementChanged):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeValue):
(WebKit::WebPage::setAssistedNodeValueAsNumber):
(WebKit::WebPage::setAssistedNodeSelectedIndex):
(WebKit::isAssistableNode): Deleted.
(WebKit::WebPage::getAssistedNodeInformation): Deleted.

2:24 PM Changeset in webkit [173892] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Renamed DebuggerCallFrameScope to DebuggerPausedScope.
<​https://webkit.org/b/137042>

Reviewed by Michael Saboff.

DebuggerPausedScope is a better name for this data structure because it
is meant for tracking the period within which the debugger is paused,
and doing clean ups after the pause ends.

  • debugger/Debugger.cpp:

(JSC::DebuggerPausedScope::DebuggerPausedScope):
(JSC::DebuggerPausedScope::~DebuggerPausedScope):
(JSC::Debugger::pauseIfNeeded):
(JSC::DebuggerCallFrameScope::DebuggerCallFrameScope): Deleted.
(JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope): Deleted.

  • debugger/Debugger.h:
  • debugger/DebuggerCallFrame.h:
2:21 PM Changeset in webkit [173891] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Have DataTransfer::files() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137039

Reviewed by Ryosuke Niwa.

Have DataTransfer::files() return a reference instead of a pointer as
it can never return null.

No new tests, no behavior change.

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::files):

  • dom/DataTransfer.h:
2:17 PM Changeset in webkit [173890] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Have NamedNodeMap::element() and DOMStringMap::element() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137040

Reviewed by Ryosuke Niwa.

Have NamedNodeMap::element() and DOMStringMap::element() return a
reference instead of a pointer as they can never return null.

No new tests, no behavior change.

  • dom/DatasetDOMStringMap.h:
  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::element):

2:08 PM Changeset in webkit [173889] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove UserInterface/Images/gtk from Apple builds
​https://bugs.webkit.org/show_bug.cgi?id=136955

Reviewed by Joseph Pecoraro.

  • Scripts/copy-user-interface-resources.pl:

Remove Images/Legacy and Images/gtk on Mac and Windows builds by looking
at the MAC_OS_X_VERSION_MAJOR and OFFICIAL_BUILD environment vars.

2:04 PM Changeset in webkit [173888] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r171197): Clip's content is drawn behind Safari window when entering Full Screen youtube html5 first time
​https://bugs.webkit.org/show_bug.cgi?id=137029

Reviewed by Brent Fulgham.

In r171197, we ordered the full screen window on- and off-screen so that the fullscreen animation went to the
correct screen, which introduced a subtle glitch at the beginning and end of an animation. For entering, ensure
that the window is scaled to its starting size before ordering on-screen. For exiting, order the window off-
screen before resetting its clipping rect.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

1:54 PM Changeset in webkit [173887] by jer.noble@apple.com
  • 2 edits in trunk/Tools

[Tools] git-commit uses wrong ChangeLog when run from a subdirectory
​https://bugs.webkit.org/show_bug.cgi?id=137031

Reviewed by Joseph Pecoraro.

commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
ChangeLog locations before passing them to createCommitMessage().

  • Scripts/commit-log-editor:
1:21 PM Changeset in webkit [173886] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[CLoop] - Fix CLoop on the 32-bit Big-Endians
​https://bugs.webkit.org/show_bug.cgi?id=137020

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-09-23
Reviewed by Mark Lam.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
12:53 PM Changeset in webkit [173885] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Have DOMImplementation::document() and Element::attributes() return references
​https://bugs.webkit.org/show_bug.cgi?id=137035

Reviewed by Andreas Kling.

Have DOMImplementation::document() and Element::attributes() return
references instead of pointers as they can never return null.

No new tests, no behavior change.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
Update the JS Bindings code generator to use WTF::getPtr() in a couple
more places so that the implementation can return references instead
of pointers even when [GenerateIsReachable=xxx] IDL extended attribute
is used.

  • dom/DOMImplementation.h:

(WebCore::DOMImplementation::document):

  • dom/Element.cpp:

(WebCore::Element::attributes):

  • dom/Element.h:

(WebCore::Node::attributes):

12:30 PM Changeset in webkit [173884] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Have Document::ensureTemplateDocument() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137033

Reviewed by Ryosuke Niwa.

Have Document::ensureTemplateDocument() return a reference instead of
a pointer as it can never return null.

No new tests, no behavior change.

  • dom/Document.cpp:

(WebCore::Document::ensureTemplateDocument):

  • dom/Document.h:
  • editing/markup.cpp:

(WebCore::createFragmentForInnerOuterHTML):

  • html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::content):
(WebCore::HTMLTemplateElement::didMoveToNewDocument):

11:44 AM Changeset in webkit [173883] by Chris Dumez
  • 28 edits in trunk/Source/WebCore

Have Document::accessSVGExtensions() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137030

Reviewed by Ryosuke Niwa.

Have Document::accessSVGExtensions() return a reference instead of a
pointer as it can never return null.

No new tests, no behavior change.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

  • dom/Document.cpp:

(WebCore::Document::commonTeardown):
(WebCore::Document::implicitClose):
(WebCore::Document::accessSVGExtensions):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::removedFrom):

  • editing/markup.cpp:

(WebCore::isPlainTextMarkup):

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::svgExtensionsFromElement):

  • rendering/svg/RenderSVGResourceContainer.h:

(WebCore::getRenderSVGResourceContainerById):
(WebCore::getRenderSVGResourceById):

  • rendering/svg/SVGResources.cpp:

(WebCore::registerPendingResource):
(WebCore::SVGResources::buildCachedResources):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::resourcesCacheFromRenderer):
(WebCore::SVGResourcesCache::resourceDestroyed):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::reportAttributeParsingError):
(WebCore::SVGElement::removedFrom):
(WebCore::SVGElement::viewportElement):
(WebCore::SVGElement::attributeChanged):
(WebCore::SVGElement::buildPendingResourcesIfNeeded):
(WebCore::SVGElement::accessDocumentSVGExtensions): Deleted.

  • svg/SVGElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::parseAttribute):

  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::parseAttribute):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::clearResourceReferences):
(WebCore::SVGFEImageElement::buildPendingResource):

  • svg/SVGFitToViewBox.cpp:

(WebCore::SVGFitToViewBox::parseViewBox):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedInto):
(WebCore::SVGFontFaceElement::removedFrom):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):
(WebCore::SVGMPathElement::clearResourceReferences):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::invalidateMPathDependencies):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::parseAttribute):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::~SVGSVGElement):
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::detachTarget):
(WebCore::SVGTRefElement::buildPendingResource):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::clearResourceReferences):
(WebCore::SVGTextPathElement::buildPendingResource):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::clearResourceReferences):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::buildInstanceTree):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::clearResourceReferences):
(WebCore::SVGSMILElement::buildPendingResource):

11:38 AM Changeset in webkit [173882] by commit-queue@webkit.org
  • 26 edits in trunk/Source

Web Inspector: Should be able to attach a debugger to a JSContext before anything is executed
​https://bugs.webkit.org/show_bug.cgi?id=136893

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-23
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Adds new remote inspector protocol handling for automatic inspection.
Debuggers can signal they have enabled automatic inspection, and
when debuggables are created the current application will pause to
see if the debugger will inspect or decline to inspect the debuggable.

  • inspector/remote/RemoteInspectorConstants.h:
  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::globalAutomaticInspectionState):
(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::start):
When first starting, check the global "is there an auto-inspect" debugger state.
This is necessary so that the current application knows if it should pause or
not when a debuggable is created, even without having connected to webinspectord yet.

(Inspector::RemoteInspector::updateDebuggableAutomaticInspectCandidate):
When a debuggable has enabled remote inspection, take this path to propose
it as an automatic inspection candidate if there is an auto-inspect debugger.

(Inspector::RemoteInspector::sendAutomaticInspectionCandidateMessage):
Send the automatic inspection candidate message.

(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::setupSucceeded):
After attempting to open an inspector, unpause if it was for the
automatic inspection candidate.

(Inspector::RemoteInspector::waitingForAutomaticInspection):
When running a nested runloop, check if we should remain paused.

(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
If by the time we connect to webinspectord we have a candidate, then
immediately send the candidate message.

(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::xpcConnectionFailed):
In error cases, clear our state.

(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionConfigurationMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionRejectMessage):
Update state when receiving new messages.

  • inspector/remote/RemoteInspectorDebuggable.h:
  • inspector/remote/RemoteInspectorDebuggable.cpp:

(Inspector::RemoteInspectorDebuggable::setRemoteDebuggingAllowed):
Special case when a debuggable is newly allowed to be debuggable.

(Inspector::RemoteInspectorDebuggable::pauseWaitingForAutomaticInspection):
Run a nested run loop while this is an automatic inspection candidate.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
When the inspector starts via automatic inspection automatically pause.
We plan on removing this condition by having the frontend signal to the
backend when it is completely initialized.

  • inspector/remote/RemoteInspectorDebuggableConnection.h:
  • inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setup):
Pass on the flag of whether or not this was automatic inspection.

  • runtime/JSGlobalObjectDebuggable.h:
  • runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::pauseWaitingForAutomaticInspection):
When pausing in a JSGlobalObject we need to release the API lock.

Source/WebCore:

Automatic inspection is currently disabled for web pages.
This just updates the interfaces that changed.

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::show):

  • inspector/InspectorController.h:
  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::connect):

  • page/PageDebuggable.h:
  • testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend):

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::remoteFrontendConnected):

Source/WTF:

Currently automatic inspection only happens in processes that have a
debugger attached. That condition may change in the future, but this
function can stand on its own in WTF. It may be useful in the future
to perhaps continue though ASSERTs if you have a debugger attached.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
11:24 AM Changeset in webkit [173881] by ggaren@apple.com
  • 13 edits
    2 adds
    1 delete in trunk/Source/bmalloc

bmalloc: Allocation should be more precise
​https://bugs.webkit.org/show_bug.cgi?id=136993

Reviewed by Gavin Barraclough.

13% reduction in heap size on the MallocBench *_memory_warning benchmarks.

This patch teaches the allocator to merge adjacent free lines into a
single allocatable range. This allows us to shrink the size of an
individual line without increasing fragmentation or the rate of allocator
slow paths.

We'll only take more slow paths when available memory is sparse, which
is exactly when it's worth it. When available memory is dense, we'll
take fewer slow paths.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Algorithm.h:

(bmalloc::divideRoundingUp):

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::Allocator): Updated for interface changes.

(bmalloc::Allocator::scavenge): Scavenge by object instead of by line.
Now that we merge lines, it's not convenient to scavenge by line.

(bmalloc::Allocator::allocateSmallBumpRange):
(bmalloc::Allocator::allocateMediumBumpRange): Allocate whole ranges
instead of individual lines.

(bmalloc::Allocator::allocateSlowCase):
(bmalloc::Allocator::allocateSmallLine): Deleted.
(bmalloc::Allocator::allocateMediumLine): Deleted.
(bmalloc::Allocator::allocateMedium): Deleted.

  • bmalloc/Allocator.h:

(bmalloc::Allocator::allocateFastCase): Folded medium allocations
into the standard fast path with small allocations. Since a BumpAllocator
just allocates out of an arbitrary range, it doesn't need to distinguish
between small and medium lines.

  • bmalloc/BumpAllocator.h:

(bmalloc::BumpAllocator::size):
(bmalloc::BumpAllocator::BumpAllocator):
(bmalloc::BumpAllocator::init):
(bmalloc::BumpAllocator::refill):
(bmalloc::BumpAllocator::line): Deleted. No need to track line information
anymore: the heap just gives us a pointer and a pre-computed number of
objects, and we allocate them.

  • bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog): Updated for interface changes.

  • bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):
(bmalloc::Heap::initializeLineMetadata): Pre-compute precise metadata
detailing where all objects will lie in memory. After we merge two lines,
we might allocate an object that spans from one line to the next. This
metadata details which bits of memory overlap in that way, and how they
overlap.

(bmalloc::Heap::refillSmallBumpRangeCache):
(bmalloc::Heap::refillMediumBumpRangeCache): Scan a whole page at a time,
and merge adjacent free lines into BumpRanges.

(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::allocateMediumPage):
(bmalloc::Heap::deallocateSmallLine):
(bmalloc::Heap::deallocateMediumLine): Track pages rather than lines,
since we scan for free memory a page at a time.

(bmalloc::Heap::allocateSmallLineSlowCase): Deleted.
(bmalloc::Heap::allocateMediumLineSlowCase): Deleted. Folded into the
fast path.

  • bmalloc/Heap.h:

(bmalloc::Heap::derefSmallLine):
(bmalloc::Heap::derefMediumLine):
(bmalloc::Heap::deallocateSmallLine): Deleted.
(bmalloc::Heap::allocateSmallLine): Deleted.
(bmalloc::Heap::deallocateMediumLine): Deleted.
(bmalloc::Heap::allocateMediumLine): Deleted. Updated for interface changes.

  • bmalloc/Line.h:

(bmalloc::Line<Traits>::ref):
(bmalloc::Line<Traits>::deref):
(bmalloc::Line<Traits>::concurrentRef): Deleted. We don't pass a derefCount
anymore, since we only ever deref by 1 now.

  • bmalloc/MediumAllocator.h:

(bmalloc::MediumAllocator::isNull): Deleted.
(bmalloc::MediumAllocator::MediumAllocator): Deleted.
(bmalloc::MediumAllocator::line): Deleted.
(bmalloc::MediumAllocator::allocate): Deleted.
(bmalloc::MediumAllocator::derefCount): Deleted.
(bmalloc::MediumAllocator::refill): Deleted.
(bmalloc::MediumAllocator::clear): Deleted. Deleted some code that's
been dead for a while, since it doesn't build anymore with this patch.

  • bmalloc/Page.h:

(bmalloc::Page::sizeClass):
(bmalloc::Page::setSizeClass):
(bmalloc::Page::smallSizeClass): Deleted.
(bmalloc::Page::setSmallSizeClass): Deleted. Renamed setSmallSizeClass
to sizeClass, since we use it for medium sizes too.

  • bmalloc/Sizes.h:

(bmalloc::Sizes::sizeClass):
(bmalloc::Sizes::objectSize): Shrank line sizes to save memory.

(bmalloc::Sizes::smallSizeClassFor): Deleted.
(bmalloc::Sizes::mediumSizeClassFor): Deleted.

  • bmalloc/bmalloc.h:

(bmalloc::api::realloc): Now that we have precise objects sizes, realloc
can be a bit more precise. It also has to be, since we can't guarantee
that an object ends at the end of a line anymore.

11:09 AM Changeset in webkit [173880] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

W3C test importer should detect manual and reference tests according their filenames
​https://bugs.webkit.org/show_bug.cgi?id=133852

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-23
Reviewed by Bem Jones-Bey.

  • Scripts/webkitpy/w3c/test_parser.py:

(TestParser.analyze_test): Adding checks based on WPT filename rules.
(TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
(TestParser):
(TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
(TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.

  • Scripts/webkitpy/w3c/test_parser_unittest.py:

(test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it.

10:32 AM Changeset in webkit [173879] by Bem Jones-Bey
  • 2 edits in trunk/Tools

Unreviewed, add Rebecca Hauck as a contributor.

  • Scripts/webkitpy/common/config/contributors.json:
10:11 AM Changeset in webkit [173878] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Correct 64-bit Windows export definitions after r173804.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Provide proper

64-bit mangled symbol names.

10:11 AM Changeset in webkit [173877] by ddkilzer@apple.com
  • 18 edits in trunk/Tools

Switch build.webkit.org URLs to https

Reviewed by Lucas Forschler and Alexey Proskuryakov.

  • TestResultServer/app.yaml: Update version to this commit

revision.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_builder_with_name):

  • Scripts/webkitpy/tool/commands/queries.py:

(TreeStatus):

  • TestResultServer/generate_builders_json.py:

(main):

  • TestResultServer/generate_builders_json_unittest.py:

(GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
(GenerateBuildersJsonTest):
(GenerateBuildersJsonTest.test_generate_json_data):

  • TestResultServer/static-dashboards/builders.jsonp:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(loadExpectationsLayoutTests):

  • TestResultServer/static-dashboards/timeline_explorer.js:
10:10 AM Changeset in webkit [173876] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

W3C test importer should copy .htaccess files
​https://bugs.webkit.org/show_bug.cgi?id=136850

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-23
Reviewed by Bem Jones-Bey.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
(TestImporter):
(TestImporter.find_importable_tests): Making use of new helper function.

9:56 AM Changeset in webkit [173875] by ap@apple.com
  • 2 edits in trunk/Tools

Trying to revive bot watcher's dashboard after HSTS.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.

9:41 AM Changeset in webkit [173874] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Adds implementation of subtle crypto HMAC algorithm
​https://bugs.webkit.org/show_bug.cgi?id=133320

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-09-23
Reviewed by Philippe Normand.

Source/WebCore:

Tests are already in place under crypto/subtle/hmac-*.html

  • crypto/gtk/CryptoAlgorithmHMACGtk.cpp:

(WebCore::getGnutlsDigestAlgorithm):
(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

LayoutTests:

  • platform/gtk/TestExpectations: Whitelists HMAC related tests that are passing
9:14 AM Changeset in webkit [173873] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r173864.

It still make tests failes on EFL bots

Reverted changeset:

"Unreviewed, EFL gardening. Unskip media test on EFL port.
Almost media tests"
​http://trac.webkit.org/changeset/173864

8:17 AM Changeset in webkit [173872] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Adds implementation of Subtle Crypto digest algorithms
​https://bugs.webkit.org/show_bug.cgi?id=133319

Source/WebCore:

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-09-23
Reviewed by Philippe Normand.

Tests are already in place under crypto/subtle/sha-*.html

  • crypto/gtk/CryptoDigestGtk.cpp:

(WebCore::CryptoDigest::CryptoDigest):
(WebCore::CryptoDigest::~CryptoDigest):
(WebCore::CryptoDigest::create):
(WebCore::CryptoDigest::addBytes):
(WebCore::CryptoDigest::computeHash):

LayoutTests:

Leaves all crypto/subtle tests skipped and whitelist only those related to
digest algorithms (sha-*.html). When enough crypto algorithms are implemented,
we can invert the approach and blacklist only those tests whose algorithms are
not implemented.

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-09-23
Reviewed by Philippe Normand.

  • platform/gtk/TestExpectations: Unskip tests for Subtle-Crypto digest algorithms.
7:47 AM Changeset in webkit [173871] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
​https://bugs.webkit.org/show_bug.cgi?id=137026

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-09-23
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/wait-for-SVN-server.py:

(getLatestSVNRevision):
(waitForSVNRevision):

2:57 AM Changeset in webkit [173870] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove unlinkZeroFiles from build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=137018

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-09-23
Reviewed by Csaba Osztrogonác.

  • Scripts/build-webkit:

(unlinkZeroFiles): Deleted.

2:26 AM Changeset in webkit [173869] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Minibrowser : Add keyboard support for stop page load
​https://bugs.webkit.org/show_bug.cgi?id=136857

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-09-23
Reviewed by Philippe Normand.

Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.

  • MiniBrowser/gtk/BrowserWindow.c:

(stopPageLoad): Callback to stop page load.
(browser_window_init):

1:37 AM Changeset in webkit [173868] by svillar@igalia.com
  • 2 edits in trunk/Source/WebCore

[CSS Grid Layout] Do not grow tracks when the growth factor is 0
​https://bugs.webkit.org/show_bug.cgi?id=136575

Reviewed by Darin Adler.

A couple of performance optimizations for the track sizing
algorithm. On the one hand we avoid the computation of the
available logical space share if the track has no growth potential
(the current breadth is the maximum breadth) and on the other
hand, we avoid calling RenderGrid::distributeSpaceToTracks() if
the available logical space is not greater than 0.

The combined effect of these two changes is an impressive +16%
improvement in auto-grid-lots-of-data.html performance test.

No new tests as there is no change in the functionality.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::distributeSpaceToTracks):

12:47 AM Changeset in webkit [173867] by Ion Rosca
  • 6 edits
    4 adds in trunk

[CSS Blending] The composited layers isolated by the page group should blend with the default white background color.
​https://bugs.webkit.org/show_bug.cgi?id=136563

Reviewed by Simon Fraser.

Source/WebCore:

If a blending layer is not isolated, then it should blend with a white backdrop:
​http://dev.w3.org/fxtf/compositing-1/#pagebackdrop

Tests: css3/blending/blend-mode-body-composited-child-background-color.html

css3/blending/blend-mode-body-composited-child.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
If the isolating composited layer is the root renderer, then it should have a backing store
into which the initial white backdrop will be painted.

LayoutTests:

  • css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt:
  • css3/blending/blend-mode-body-composited-child-background-color-expected.html: Added.
  • css3/blending/blend-mode-body-composited-child-background-color.html: Added.
  • css3/blending/blend-mode-body-composited-child-expected.html: Added.
  • css3/blending/blend-mode-body-composited-child.html: Added.
  • css3/blending/blend-mode-parent-of-composited-blended-has-layer-expected.txt:
  • css3/blending/blend-mode-with-composited-descendant-should-have-layer-expected.txt:

Sep 22, 2014:

11:00 PM Changeset in webkit [173866] by Chris Dumez
  • 29 edits in trunk/Source/WebCore

Unreviewed build fix after r173859.

Partial revert to fix debug build after r173859.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::getSVGDocument):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):

  • rendering/svg/RenderSVGBlock.h:

(WebCore::RenderSVGBlock::graphicsElement):

  • rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::gradientElement):

  • rendering/svg/RenderSVGInline.h:

(WebCore::RenderSVGInline::graphicsElement):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::pathOnlyClipping):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::graphicsElement):

  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::getBoundingBox):

  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::collectGradientAttributes):

  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::getTransformToElement):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):

  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::collectGradientAttributes):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):
(WebCore::SVGTextContentElement::elementFromRenderer):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::toClipPath):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasSingleSecurityOrigin):
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::embeddedContentBox):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):

9:39 PM Changeset in webkit [173865] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

Ensure that layout is up-to-date before hit-testing via RenderView
​https://bugs.webkit.org/show_bug.cgi?id=136651

Reviewed by David Hyatt.

Ensure that layout is up-to-date before we do hit-testing via the RenderView.
Previously, RenderLayer::hitTest() called updateLayout(), but it's better
to push that responsibility onto RenderView before entering the RenderLayer
tree.

Make callers a little more consistent in getting the RenderView via
Frame::contentRenderer(), though perhaps we should remove that and just
call Document::renderView() everywhere.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press): Hit test via the RenderView, rather
than doing so on the RenderView's layer, to ensure that we updateLayout().

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityHitTest): This code calls
hitTest() on arbitrary layers, so needs to explicitly update layout.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::contains):

  • page/EventHandler.cpp:

(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint): The explicit updateLayout() is
no longer needed.
(WebCore::EventHandler::updateCursor):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::hitTestResultInFrame):

  • page/Frame.cpp:

(WebCore::Frame::contentRenderer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

  • rendering/RenderView.cpp:

(WebCore::RenderView::hitTest): Here's where we ensure that layout is up-to-date.

9:31 PM Changeset in webkit [173864] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Unskip media test on EFL port. Almost media tests
are passed except for some tests. Unfortunately what revision fixed this crash on media test.
To maintain media test on EFL port again, this commit unskips those tests.

  • platform/efl/TestExpectations:
9:13 PM Changeset in webkit [173863] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Unskip batterystatus, which doesn't come to crash anymore.

  • platform/efl/TestExpectations:
8:08 PM Changeset in webkit [173862] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] More test expectation gardening.

  • platform/win/TestExpectations: Skip some failing image only failures, unskip some tests reported as now passing.
7:25 PM Changeset in webkit [173861] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] More test expectation gardening.

  • platform/win/TestExpectations:
6:05 PM Changeset in webkit [173860] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
​https://bugs.webkit.org/show_bug.cgi?id=136813

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-09-22
Reviewed by Gyuyoung Kim.

Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.

  • MiniBrowser/efl/main.c:

(on_key_down):

5:55 PM Changeset in webkit [173859] by Chris Dumez
  • 102 edits in trunk/Source/WebCore

Use downcast<SVG*Element>() instead of toSVG*Element()
​https://bugs.webkit.org/show_bug.cgi?id=137004

Reviewed by Benjamin Poulain.

Use downcast<SVG*Element>() instead of toSVG*Element() for casting SVG
Elements and get rid of the transition toSVG*Element() macros.

Also use downcast<MathML*Element>() instead of toMathML*Element() for
casting MathML Elements.

The HTML Elements casting counterparts will be taken care of in a
separate patch.

No new tests, no behavior change.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

  • bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSCursorImageValue.cpp:

(WebCore::resourceReferencedByCursorElement):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchAllRules):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Element.cpp:

(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):
(WebCore::Element::boundsInRootViewSpace):
(WebCore::Element::getBoundingClientRect):
(WebCore::Element::childShouldCreateRenderer):
(WebCore::Element::fastAttributeLookupAllowed):

  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingTargetRules):

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/make_names.pl:

(printTypeHelpers):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::getSVGDocument):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPhrasingContent):
(WebCore::MathMLElement::childShouldCreateRenderer):
(WebCore::MathMLElement::attributeChanged):

  • mathml/MathMLElement.h:

(WebCore::Node::hasTagName):

  • mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::getSelectedSemanticsChild):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::instanceAssociatedWithShadowTreeElement):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
(WebCore::RenderTableCell::computePreferredLogicalWidths):

  • rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::addChild):
(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
(WebCore::RenderMathMLMenclose::updateLogicalHeight):
(WebCore::RenderMathMLMenclose::paint):

  • rendering/svg/RenderSVGBlock.h:

(WebCore::RenderSVGBlock::graphicsElement):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::foreignObjectElement):

  • rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::gradientElement):

  • rendering/svg/RenderSVGGradientStop.h:
  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::imageElement):

  • rendering/svg/RenderSVGInline.h:

(WebCore::RenderSVGInline::graphicsElement):

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::getElementCTM):
(WebCore::RenderSVGModelObject::checkIntersection):
(WebCore::RenderSVGModelObject::checkEnclosure):

  • rendering/svg/RenderSVGModelObject.h:

(WebCore::RenderSVGModelObject::element):

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::rectElement):

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):

  • rendering/svg/RenderSVGResourceClipper.h:
  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):

  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceLinearGradient.h:
  • rendering/svg/RenderSVGResourceMarker.h:
  • rendering/svg/RenderSVGResourceMasker.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::patternElement):

  • rendering/svg/RenderSVGResourceRadialGradient.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::svgSVGElement):

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::graphicsElement):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::textElement):

  • rendering/svg/RenderSVGTextPath.cpp:

(WebCore::RenderSVGTextPath::textPathElement):
(WebCore::RenderSVGTextPath::layoutPath):

  • rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::svgSVGElement):

  • rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromLineElement):
(WebCore::updatePathFromPathElement):
(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::layoutChildren):
(WebCore::SVGRenderSupport::applyStrokeStyleToContext):
(WebCore::SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):
(WebCore::SVGResources::buildCachedResources):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::createElementRenderer):
(WebCore::SVGAElement::defaultEventHandler):

  • svg/SVGAltGlyphDefElement.cpp:

(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements):

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::SVGAnimatedTransformListAnimator):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
(WebCore::SVGAnimationElement::adjustForInheritance):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::rootElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::ownerSVGElement):
(WebCore::SVGElement::viewportElement):
(WebCore::SVGElement::getBoundingBox):
(WebCore::SVGElement::childShouldCreateRenderer):
(WebCore::SVGElement::title):
(WebCore::SVGElement::updateRelativeLengthsInformation):

  • svg/SVGElement.h:

(WebCore::Node::hasTagName):

  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::build):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::buildPendingResource):

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::childShouldCreateRenderer):

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::isSVGFilterPrimitiveStandardAttributes):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::ensureGlyphCache):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::rebuildFontFace):

  • svg/SVGFontFaceFormatElement.cpp:

(WebCore::SVGFontFaceFormatElement::childrenChanged):

  • svg/SVGFontFaceSrcElement.cpp:

(WebCore::SVGFontFaceSrcElement::srcValue):
(WebCore::SVGFontFaceSrcElement::childrenChanged):

  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::childrenChanged):

  • svg/SVGGlyphElement.cpp:

(WebCore::SVGGlyphElement::invalidateGlyphCache):

  • svg/SVGGraphicsElement.h:

(WebCore::isSVGGraphicsElement):

  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):

  • svg/SVGImageLoader.cpp:

(WebCore::SVGImageLoader::dispatchLoadEvent):

  • svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::determineViewport):

  • svg/SVGLinearGradientElement.cpp:

(WebCore::setGradientAttributes):
(WebCore::SVGLinearGradientElement::collectGradientAttributes):

  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::nearestViewportElement):
(WebCore::SVGLocatable::farthestViewportElement):
(WebCore::SVGLocatable::computeCTM):
(WebCore::SVGLocatable::getTransformToElement):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):
(WebCore::SVGMPathElement::pathElement):
(WebCore::SVGMPathElement::notifyParentOfPathChange):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::synchronizeOrientType):
(WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::invalidateMPathDependencies):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::synchronizeD):

  • svg/SVGPathSegList.cpp:

(WebCore::SVGPathSegList::commitChange):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::collectPatternAttributes):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):

  • svg/SVGRadialGradientElement.cpp:

(WebCore::setGradientAttributes):
(WebCore::SVGRadialGradientElement::collectGradientAttributes):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setupInitialView):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):
(WebCore::SVGTextContentElement::elementFromRenderer):

  • svg/SVGTextContentElement.h:

(WebCore::isSVGTextContentElement):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::buildPendingResource):

  • svg/SVGUseElement.cpp:

(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::buildInstanceTree):
(WebCore::SVGUseElement::hasCycleUseReferencing):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):

  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):

  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::viewTarget):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):

  • svg/animation/SVGSMILElement.h:

(WebCore::isSVGSMILElement):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasSingleSecurityOrigin):
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::embeddedContentBox):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):

  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::animValDidChange):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::contextElement):

5:47 PM Changeset in webkit [173858] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Follow on fix for [iOS] ASSERTION FAILED: WTF::isMainThread() in WebCore::memoryCache() when using WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=136962

Rubber-stamped by Simon Fraser.

Remove the const per review comment. It is not needed.

  • loader/cocoa/DiskCacheMonitorCocoa.mm:

(WebCore::DiskCacheMonitor::DiskCacheMonitor):

5:23 PM Changeset in webkit [173857] by Simon Fraser
  • 10 edits in trunk

Move nodeFromPoint() back to Document where it belongs
​https://bugs.webkit.org/show_bug.cgi?id=137012

Reviewed by Zalan Bujtas.
Source/WebCore:

nodeFromPoint() was moved into TreeScope for ShadowDOM work, but now we can move
it back to its logical place.

Make versions of elementFromPoint and caretRangeFromPoint that take LayoutPoints,
and change the current scale/offset code to be in layout units (which results
in a small behavior change).

elementFromPoint(int, int) and caretRangeFromPoint(int, int) are still required
for bindings code.

  • dom/Document.cpp:

(WebCore::Document::nodeFromPoint):
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):

  • dom/Document.h:

(WebCore::Document::elementFromPoint): Move logic from TreeScope::elementFromPoint()
here.

  • dom/TreeScope.cpp:

(WebCore::nodeFromPoint): Deleted.
(WebCore::TreeScope::elementFromPoint): Deleted.

  • dom/TreeScope.h:

LayoutTests:

All platforms use subpixel layout now, so remove the conditional behavior in this test.
Fix the test to account for scaling now being done in layout units.

  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
  • platform/mac/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
4:10 PM Changeset in webkit [173856] by benjamin@webkit.org
  • 1 edit
    6 adds
    2 deletes in trunk/LayoutTests

Split the test parsing-css-nth-child-of.html in 3
​https://bugs.webkit.org/show_bug.cgi?id=137013

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-22
Rubber-stamped by Christophe Dumez.

parsing-css-nth-child-of.html tends to be too slow in debug, causing timeout from time to time.

The speed issues will be fixed once we JIT the selector. Since it will take a while before the JIT is ready,
this patch splits the test in three to avoid timeouts on the bots.

  • fast/css/parsing-css-nth-child-of-1-expected.txt: Renamed from LayoutTests/fast/css/parsing-css-nth-child-of-expected.txt.
  • fast/css/parsing-css-nth-child-of-1.html: Added.
  • fast/css/parsing-css-nth-child-of-2-expected.txt: Added.
  • fast/css/parsing-css-nth-child-of-2.html: Renamed from LayoutTests/fast/css/parsing-css-nth-child-of.html.
  • fast/css/parsing-css-nth-child-of-3-expected.txt: Added.
  • fast/css/parsing-css-nth-child-of-3.html: Added.
3:37 PM Changeset in webkit [173855] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

3:34 PM Changeset in webkit [173854] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.11.10

New tag.

3:09 PM Changeset in webkit [173853] by benjamin@webkit.org
  • 4 edits
    16 adds in trunk

Add the baseline implementation of :nth-child(An+B of selector-list)
​https://bugs.webkit.org/show_bug.cgi?id=136975

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-22
Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/css/nth-child-of-classname.html

fast/css/nth-child-of-complex-selector.html
fast/css/nth-child-of-compound-selector.html
fast/css/nth-child-of-tagname.html
fast/selectors/nth-child-of-basics.html
fast/selectors/nth-child-of-class-style-update.html
fast/selectors/nth-child-of-complex-selectors.html
fast/selectors/nth-child-of-selector-list.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):
Pretty basic:
-Go over the previous siblings.
-For each sibling, test the selector list. If it matches, increase the count.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
Skip any case of the new selector. This will be implemented separately.

LayoutTests:

  • fast/css/nth-child-of-classname-expected.html: Added.
  • fast/css/nth-child-of-classname.html: Added.
  • fast/css/nth-child-of-complex-selector-expected.html: Added.
  • fast/css/nth-child-of-complex-selector.html: Added.
  • fast/css/nth-child-of-compound-selector-expected.html: Added.
  • fast/css/nth-child-of-compound-selector.html: Added.
  • fast/css/nth-child-of-tagname-expected.html: Added.
  • fast/css/nth-child-of-tagname.html: Added.

Cover basic styling and style sharing.

  • fast/selectors/nth-child-of-basics-expected.txt: Added.
  • fast/selectors/nth-child-of-basics.html: Added.
  • fast/selectors/nth-child-of-complex-selectors-expected.txt: Added.
  • fast/selectors/nth-child-of-complex-selectors.html: Added.
  • fast/selectors/nth-child-of-selector-list-expected.txt: Added.
  • fast/selectors/nth-child-of-selector-list.html: Added.

Cover querySelector and styling of various cases.

  • fast/selectors/nth-child-of-class-style-update-expected.txt: Added.
  • fast/selectors/nth-child-of-class-style-update.html: Added.

Basic case of style invalidation.

3:08 PM Changeset in webkit [173852] by mmaxfield@apple.com
  • 7 edits in trunk/Source/WebCore

Implement 'vhea', 'vmtx', and 'kern' tables in SVG -> OTF converter
​https://bugs.webkit.org/show_bug.cgi?id=136971

Reviewed by Darin Adler.

This patch fills in the tables related to vertical metrics and kerning. The vertical metrics tables are
fairly straightforward. On the other hand, the 'kern' table has subtables which can be in a variety
of formats; however, according to Microsoft, Windows only allows one particular format, which doesn't
allow for ranges of glyphs to be described and therefore might lead to a large 'kern' table size. In
the interest of platform agnosticism I have implemented this particular format, and have not actually
witnessed any extremely large 'kern' tables in any of the fonts that I have looked at.

I also added basic support for the horiz-origin-x and horiz-origin-y SVG properties, though support
might not be perfect based on my testing.

Regarding testing, after this patch, almost all of our SVG fonts tests pass (barring tiny rebaselining;
the platform font system calculates slightly different advances than we did. These differences are tiny
and expected from such a dramatic shift in text handling engines.) There are around two dozen failing
tests left that look like they are actually indiciative of code problems.

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::ensureGlyphCache): Refactor to accept new signature of
SVG*KernElement::build*KerningPair().

  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::buildHorizontalKerningPair): Refactor to allow for intermediate data to be
returned, which the SVG -> OTF font converter can use.

  • svg/SVGHKernElement.h: New signature for buildHorizontalKerningPair().
  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::GlyphData::GlyphData): Save the glyph's vertical advance along with
the glyph's horizontal advance.
(WebCore::SVGToOTFFontConverter::KerningData::KerningData): This data represents a record in one of
the two 'kern' subtables, and as such needs to be sorted.
(WebCore::SVGToOTFFontConverter::KerningData::operator<): Sort comparator.
(WebCore::SVGToOTFFontConverter::appendHEADTable): Save the unitsPerEm locally to save a conditional.
(WebCore::SVGToOTFFontConverter::appendHHEATable): Ditto.
(WebCore::SVGToOTFFontConverter::appendHMTXTable): Ditto. Also use the horizontal advance as opposed to
the vertical advance.
(WebCore::SVGToOTFFontConverter::appendOS2Table): Save the unitsPerEm locally to save a conditional.
Also if the average advance isn't found in the font, use the missing glyph's advance. If there is no
missing glyph, bail and use the unitsPerEm.
(WebCore::SVGToOTFFontConverter::appendVORGTable): If the default vertical origin isn't found in the
font, use the missing glyphs's vertical origin. If there is no missing glyph, bail and use 0.
(WebCore::SVGToOTFFontConverter::appendVHEATable): Parallel of 'hhea' table, except for vertical info.
(WebCore::SVGToOTFFontConverter::appendVMTXTable): Parallel of 'hmtx' table, except for vertical info.
(WebCore::SVGToOTFFontConverter::appendKerningHelperFields): Computes and appends 4 fields that font
parsers need in order to do a binary search on the kern records.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): For each codepoint in the ranges, look up its
representative glyph and append it to a set.
(WebCore::SVGToOTFFontConverter::addCodepoints): For each codepoint in the range, look up its
representative glyph and append it to a set.
(WebCore::SVGToOTFFontConverter::addGlyphNames): For each glyph name, look up its representative glyph
and append it to a set.
(WebCore::SVGToOTFFontConverter::computeKerningData): Call SVG*KernElement::build*KerningPair() and
iterate through all the data it returned, building up records into a Vector.
(WebCore::SVGToOTFFontConverter::appendKERNTable): Go through the vector that computeKerningData()
returned and actually write out the two subtables. One is for horizontal kerning and the other is for
vertical kerning.
(WebCore::CFFBuilder::CFFBuilder): Use the position of the glyph origin to perform the initial moveto
command.
(WebCore::transcodeGlyphPaths): Get the glyph's origin and pass it to the CFFBuilder.
(WebCore::SVGToOTFFontConverter::appendGlyphData): Templated overloading so that the missing glyph
gets a null SVGGlyphElement pointer but the rest of the glyphs get a non-null one.
(WebCore::SVGToOTFFontConverter::processGlyphElement): Called on both SVGGlyphElements and
SVGMissingGlyphElements, this pulls out information from the element and computs its path information.
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Use the new templated version of
processGlyphElement so we can get the same glyph parsing behavior on SVGMissingGlyphElements. In
addition, populate two maps for the kerning table creation function to use.
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): Append new tables.

  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::buildVerticalKerningPair): Refactor to allow for intermediate data to be
returned, which the SVG -> OTF font converter can use.

  • svg/SVGVKernElement.h: New signature for buildVerticalKerningPair().
3:00 PM Changeset in webkit [173851] by dbates@webkit.org
  • 6 edits
    2 adds in trunk

[Cocoa] Add UI delegate callback when window.close() is called
​https://bugs.webkit.org/show_bug.cgi?id=137008
<rdar://problem/17801001>

Reviewed by Anders Carlsson.

Source/WebKit2:

Implement support infrastructure to notify the UI client when window.close() is called.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Added method declaration for -_webViewClose:.
  • UIProcess/Cocoa/UIDelegate.h: Added override declaration for API::UIClient::close().
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate): Wire up delegate method to Objective-C selector, -[WKUIDelegatePrivate _webViewClose:].
(WebKit::UIDelegate::UIClient::close): Added; turns around and calls -[WKUIDelegatePrivate _webViewClose:] (if applicable).

Tools:

Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
for window opened via JavaScript (i.e. window.open()).

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
2:13 PM Changeset in webkit [173850] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.11-branch/Source/WebKit2

Merged r173788. <rdar://problem/17878728>

2:10 PM Changeset in webkit [173849] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.11-branch/Source/WebKit2

Roll out r171775. <rdar://problem/17173916>

2:10 PM Changeset in webkit [173848] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

WebSocket crash when a connection is closed from server side
​https://bugs.webkit.org/show_bug.cgi?id=137009
rdar://problem/18333977
rdar://problem/12708225

Reviewed by Brady Eidson.

I don't think that this can be tested with our test server.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel): Added logging.
(WebCore::WebSocketChannel::~WebSocketChannel): Ditto.
(WebCore::WebSocketChannel::close): Protect self, because startClosingHandshake
can release the last reference.
(WebCore::WebSocketChannel::fail): Added an assertion that the channel is always
closed after this function.
(WebCore::WebSocketChannel::startClosingHandshake): Protect self, and don't change
the stack from closed back to closing if after failing to send closing handshake.
(WebCore::WebSocketChannel::processOutgoingFrameQueue): Protect self.

1:25 PM Changeset in webkit [173847] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FTL allocatePropertyStorage code should involve less copy-paste
​https://bugs.webkit.org/show_bug.cgi?id=137006

Reviewed by Michael Saboff.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::allocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::reallocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::allocatePropertyStorageWithSizeImpl):

1:04 PM Changeset in webkit [173846] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.11-branch/Source/WebKit2

Merged r171775. <rdar://problem/17173916>

12:52 PM Changeset in webkit [173845] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

Bad cast in isValidColumnSpanner.
​https://bugs.webkit.org/show_bug.cgi?id=133380.

Reviewed by Simon Fraser.

Source/WebCore:

Added fast/multicol/multicol-crazy-nesting.html

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
The crawl up the chain looking for unsplittable objects should use containing blocks
and not be casting to parent boxes. You can have an inline in the parent chain, so
this was not the right way to walk up the tree.

LayoutTests:

  • fast/multicol/multicol-crazy-nesting-expected.txt: Added.
  • fast/multicol/multicol-crazy-nesting.html: Added.
12:01 PM Changeset in webkit [173844] by Lucas Forschler
  • 1 move in branches/safari-600.1.4.10-branch

Fix typo.

11:55 AM Changeset in webkit [173843] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

ASSERT in RenderMultiColumnSet::requiresBalancing.
​https://bugs.webkit.org/show_bug.cgi?id=136376.

Reviewed by David Kilzer.

Source/WebCore:

Added fast/multicol/multicol-selection.html.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
Don't allow an object to become a spanner if it does not have the flow
thread as its containing block. Otherwise the flow thread won't get notified
of spanner placeholder insertions, and so the spanner ends up orphaned.

LayoutTests:

  • fast/multicol/multicol-selection-expected.txt: Added.
  • fast/multicol/multicol-selection.html: Added.
11:51 AM Changeset in webkit [173842] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

11:36 AM Changeset in webkit [173841] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

W3C importer should import html files within resources folders
​https://bugs.webkit.org/show_bug.cgi?id=127548

Patch by Youenn Fablet <​youennf@gmail.com> on 2014-09-22
Reviewed by Ryosuke Niwa.

Import HTML files in any folder named "resources" even if file is not detected as a HTML test file

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.find_importable_tests):

11:35 AM Changeset in webkit [173840] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Implement cap height in SimpleFontDataWin to enable initial-letter support for Windows.
​https://bugs.webkit.org/show_bug.cgi?id=136841

Reviewed by David Hyatt.

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::SimpleFontData::platformInit): Add missing calls to set up our fonts.

9:53 AM Changeset in webkit [173839] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

Simple ES6 feature: Number constructor extras
​https://bugs.webkit.org/show_bug.cgi?id=131707

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-09-22
Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h: Added new identifiers.
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::isFunction): Added.
(JSC::numberConstructorEpsilonValue): Added.
(JSC::numberConstructorNegInfinity): Added.
(JSC::numberConstructorPosInfinity): Added.
(JSC::numberConstructorMaxValue): Added.
(JSC::numberConstructorMinValue): Added.
(JSC::numberConstructorMaxSafeInteger): Added.
(JSC::numberConstructorMinSafeInteger): Added.
(JSC::numberConstructorFuncIsFinite): Added.
(JSC::numberConstructorFuncIsInteger): Added.
(JSC::numberConstructorFuncIsNaN): Added.
(JSC::numberConstructorFuncIsSafeInteger): Added.

  • runtime/NumberConstructor.h:

LayoutTests:

  • js/Object-getOwnPropertyNames-expected.txt:
  • js/number-constructor-expected.txt: Added.
  • js/number-constructor.html: Added.
  • js/script-tests/Object-getOwnPropertyNames.js:
  • js/script-tests/number-constructor.js: Added.
8:51 AM Changeset in webkit [173838] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Update HTMLMediaElement logging
​https://bugs.webkit.org/show_bug.cgi?id=136991

Reviewed by Alexey Proskuryakov.

No new tests, only logging was changed.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):

8:34 AM Changeset in webkit [173837] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

FTL should store the four bytes of the cell header using a 32-bit store rather than four 8-bit stores
​https://bugs.webkit.org/show_bug.cgi?id=136992

Reviewed by Sam Weinig.

LLVM ought to be able to do this optimization for us given how the code was written, but
any such lower-level attempts to optimize this would get into trouble with the weird
object materialization logic I'll be introducing in bug 136330. So, this brings the
merging of the byte stores into the FTL lowering so that we can control it explicitly.

  • ftl/FTLAbstractHeap.h:

(JSC::FTL::AbstractHeap::changeParent):

  • ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::allocateCell):

8:00 AM Changeset in webkit [173836] by evab.u-szeged@partner.samsung.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r173631): It broke the !ENABLE(VIDEO) build
​https://bugs.webkit.org/show_bug.cgi?id=136946

Reviewed by Jer Noble.

No new tests required, no new functionality.

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

7:47 AM Changeset in webkit [173835] by mihnea@adobe.com
  • 6 edits in trunk/Source/WebCore

[CSSRegions] Use nullptr in regions code
​https://bugs.webkit.org/show_bug.cgi?id=137001

Reviewed by Andrei Bucur.

No new tests as no new functionality is introduced.

  • dom/DOMNamedFlowCollection.cpp:

(WebCore::DOMNamedFlowCollection::item):
(WebCore::DOMNamedFlowCollection::namedItem):

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::flowByName):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::WebKitNamedFlow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
(WebCore::RenderFlowThread::currentActiveRenderBox):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::nextRendererForElement):

4:20 AM Changeset in webkit [173834] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Tools

Merge r173832 - [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
​https://bugs.webkit.org/show_bug.cgi?id=136998

Reviewed by Philippe Normand.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewCanShowMIMEType): Remove the check of PDF as
unsupported MIME type.

4:19 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
4:19 AM Changeset in webkit [173833] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173831 - [kn] Kannada Translation for webkit - Updated
​https://bugs.webkit.org/show_bug.cgi?id=116941

Patch by Shankar Prasad <​svenkate@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • kn.po:
4:15 AM Changeset in webkit [173832] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
​https://bugs.webkit.org/show_bug.cgi?id=136998

Reviewed by Philippe Normand.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewCanShowMIMEType): Remove the check of PDF as
unsupported MIME type.

4:11 AM WebKitGTK/2.6.x edited by berto@igalia.com
(diff)
4:10 AM Changeset in webkit [173831] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[kn] Kannada Translation for webkit - Updated
​https://bugs.webkit.org/show_bug.cgi?id=116941

Patch by Shankar Prasad <​svenkate@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • kn.po:
3:40 AM Changeset in webkit [173830] by Carlos Garcia Campos
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r173806 - [CSS Regions] Assertion failure and null dereference crash when using animations and regions
​https://bugs.webkit.org/show_bug.cgi?id=136918

Reviewed by Andrei Bucur.

Source/WebCore:

In some situations, for instance when an image has an attached animation, the style change caused by the animation
triggers a geometry update for the backing store associated with the image's layer. This may occur before
the layout for the image has finished.

Moreover, if the image in such situation - having a composited layer - is displayed in a region,
sicne the layout did not finish yet, the mappings between the layers of the elements collected in the named flow
and the regions associated with the named flow are not updated and cannot be used.

Therefore in those situations, we have to bail out early and use these mappings only after the layout has finished.

This patch also changes RenderLayerBacking method updateAfterDescendents -> updateAfterDescendants.

Test: fast/regions/animated-image-in-region.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterDescendants):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):

LayoutTests:

  • fast/regions/animated-image-in-region-expected.txt: Added.
  • fast/regions/animated-image-in-region.html: Added.
3:34 AM Changeset in webkit [173829] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173800 - Fix post-mortem nits for r173724
​https://bugs.webkit.org/show_bug.cgi?id=136986

Reviewed by Darin Adler.

Fix post-mortem nits for r173724.

No new tests, no behavior change.

  • editing/EditingStyle.cpp:

(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):
Use nullptr instead of 0.

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):
Use getIdAttribute() / setIdAttribute().

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):
Use fastHasAttribute() for nowrap and do an early return to avoid
calling styleOrColLogicalWidth() if the nowrap attribute is missing.

3:32 AM Changeset in webkit [173828] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore

Merge r173787 - Leak of mallocs under StructureSet::OutOfLineList::create
​https://bugs.webkit.org/show_bug.cgi?id=136970

Reviewed by Filip Pizlo.

addOutOfLine should free the old list when expanding the capacity.

  • bytecode/StructureSet.cpp:

(JSC::StructureSet::addOutOfLine):

3:29 AM Changeset in webkit [173827] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173767 - REGRESSION(r173464): It broke the !ENABLE(PICTURE_SIZES) build
​https://bugs.webkit.org/show_bug.cgi?id=136942

Reviewed by Simon Fraser.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

3:01 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
2:56 AM Changeset in webkit [173826] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173824 - [l10n] [mr] WebKitGTK+ Marathi Translations
​https://bugs.webkit.org/show_bug.cgi?id=136979

Patch by Sandeep Shedmake <​sandeep.shedmake@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • mr.po:
2:53 AM Changeset in webkit [173825] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix WebKitGTKTranslations rule in watchlist.

In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
to Source/WebCore/platform/gtk/po/ but the rule was not updated.

  • Scripts/webkitpy/common/config/watchlist: Use

Source/WebCore/platform/gtk/po/ as directory to watch for
WebKitGTKTranslations rule and add berto and myself to the list of
watchers.

2:48 AM Changeset in webkit [173824] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] [mr] WebKitGTK+ Marathi Translations
​https://bugs.webkit.org/show_bug.cgi?id=136979

Patch by Sandeep Shedmake <​sandeep.shedmake@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • mr.po:
2:47 AM WebKitGTK/2.6.x edited by berto@igalia.com
(diff)
2:42 AM Changeset in webkit [173823] by Carlos Garcia Campos
  • 6 edits
    4 adds in releases/WebKitGTK/webkit-2.6

Merge r173809 - [GStreamer] Cannot play Vimeo video
​https://bugs.webkit.org/show_bug.cgi?id=134969

Reviewed by Sergio Villar Senin.

Source/WebCore:

Ensure the GStreamer HTTP source element also sends cookies when
it's sending its requests. Some streaming platforms such as Vimeo
do server-side cookie checks on incoming requests before serving
media data.

Test: http/tests/media/hls/video-cookie.html

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart): Set first-party cookie URL to the request so
the ResourceLoader properly sets cookies in the HTTP request.

LayoutTests:

New test for a HLS stream enforcing a specific cookie before
serving its fragments, like Vimeo does.

  • http/tests/media/hls/video-cookie-expected.txt: Added.
  • http/tests/media/hls/video-cookie.html: Added.
  • http/tests/media/resources/hls/playlist-with-cookie.m3u8: Added.
  • http/tests/media/resources/hls/sub-playlist-with-cookie.php: Added.
  • http/tests/media/resources/video-cookie-check-cookie.php:
  • platform/gtk/TestExpectations: Marked test as slow, as the other

HLS test.

2:41 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
2:37 AM Changeset in webkit [173822] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173815 - [l10n] Updated Polish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=136976

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • pl.po:
2:36 AM Changeset in webkit [173821] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173814 - [l10n] Updated Hebrew translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=136678

Patch by Yosef Or Boczko <​yoseforb@gnome.org> on 2014-09-22
Reviewed by Philippe Normand.

  • he.po:
2:36 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
2:35 AM Changeset in webkit [173820] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173813 - Webkit Tamil translations updated
​https://bugs.webkit.org/show_bug.cgi?id=136816

Patch by Shantha kumar <​shantha.thamizh@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • ta.po:
2:34 AM Changeset in webkit [173819] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173812 - [as] Updated Assamese translations of WebKitGtk+
​https://bugs.webkit.org/show_bug.cgi?id=136908

Patch by Nilamdyuti Goswami <​ngoswami@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • as.po:
2:33 AM Changeset in webkit [173818] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173811 - Odia (or_IN) translation for webkit
​https://bugs.webkit.org/show_bug.cgi?id=136920

Patch by Manoj Kumar Giri <​mgiri@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • or.po:
2:32 AM Changeset in webkit [173817] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173810 - Webkit Gujarati Translations
​https://bugs.webkit.org/show_bug.cgi?id=136525

Patch by Sweta Kothari <​swkothar@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • gu.po:
2:29 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
2:29 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
1:51 AM Changeset in webkit [173816] by ryuan.choi@gmail.com
  • 2 edits in trunk/Tools

Fix syntaxError in watchlist since r173594
​https://bugs.webkit.org/show_bug.cgi?id=136996

Reviewed by Philippe Normand.

  • Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
1:44 AM WebKitGTK/2.6.x edited by philn@igalia.com
(diff)
1:41 AM WebKitGTK/2.6.x edited by berto@igalia.com
(diff)
1:36 AM Changeset in webkit [173815] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=136976

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • pl.po:
1:34 AM Changeset in webkit [173814] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Hebrew translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=136678

Patch by Yosef Or Boczko <​yoseforb@gnome.org> on 2014-09-22
Reviewed by Philippe Normand.

  • he.po:
1:33 AM Changeset in webkit [173813] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Webkit Tamil translations updated
​https://bugs.webkit.org/show_bug.cgi?id=136816

Patch by Shantha kumar <​shantha.thamizh@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • ta.po:
1:32 AM Changeset in webkit [173812] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[as] Updated Assamese translations of WebKitGtk+
​https://bugs.webkit.org/show_bug.cgi?id=136908

Patch by Nilamdyuti Goswami <​ngoswami@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • as.po:
1:30 AM Changeset in webkit [173811] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Odia (or_IN) translation for webkit
​https://bugs.webkit.org/show_bug.cgi?id=136920

Patch by Manoj Kumar Giri <​mgiri@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • or.po:
1:28 AM Changeset in webkit [173810] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Webkit Gujarati Translations
​https://bugs.webkit.org/show_bug.cgi?id=136525

Patch by Sweta Kothari <​swkothar@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • gu.po:
1:15 AM Changeset in webkit [173809] by Philippe Normand
  • 6 edits
    4 adds in trunk

[GStreamer] Cannot play Vimeo video
​https://bugs.webkit.org/show_bug.cgi?id=134969

Reviewed by Sergio Villar Senin.

Source/WebCore:

Ensure the GStreamer HTTP source element also sends cookies when
it's sending its requests. Some streaming platforms such as Vimeo
do server-side cookie checks on incoming requests before serving
media data.

Test: http/tests/media/hls/video-cookie.html

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart): Set first-party cookie URL to the request so
the ResourceLoader properly sets cookies in the HTTP request.

LayoutTests:

New test for a HLS stream enforcing a specific cookie before
serving its fragments, like Vimeo does.

  • http/tests/media/hls/video-cookie-expected.txt: Added.
  • http/tests/media/hls/video-cookie.html: Added.
  • http/tests/media/resources/hls/playlist-with-cookie.m3u8: Added.
  • http/tests/media/resources/hls/sub-playlist-with-cookie.php: Added.
  • http/tests/media/resources/video-cookie-check-cookie.php:
  • platform/gtk/TestExpectations: Marked test as slow, as the other

HLS test.

12:51 AM Changeset in webkit [173808] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

Leverage RenderLayerBacking::renderer() instead of m_owningLayer.renderer()
​https://bugs.webkit.org/show_bug.cgi?id=136954

Reviewed by Darin Adler.

No new tests just refactoring.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::paintIntoLayer):

12:20 AM Changeset in webkit [173807] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WTF

Eliminate redundant PtrHash specializations
​https://bugs.webkit.org/show_bug.cgi?id=136990

Patch by Sam Weinig <​sam@webkit.org> on 2014-09-22
Reviewed by Darin Adler.

Now that we have IsSmartPtr, we can eliminate all the specializations
of PtrHash that we had (for RefPtr, OwnPtr, RetainPtr, and std::unique_ptr)
and instead just have one that uses GetPtrHelper.

No changes of behavior intended.

  • wtf/GetPtr.h:

Remove unnecessary const_cast that Darin noticed.

  • wtf/HashFunctions.h:

(WTF::PtrHash::hash): Deleted.
(WTF::PtrHash::equal): Deleted.
(WTF::PtrHash<RefPtr<P>>::hash): Deleted.
(WTF::PtrHash<RefPtr<P>>::equal): Deleted.
Specialize PtrHash based on whether the type is a smart pointer, and use GetPtrHelper
to implement the smart pointer specialized variant.

  • wtf/HashMap.h:

Remove include of GetPtr.h that is now included by HashFunctions.h

  • wtf/OwnPtr.h:

(WTF::PtrHash<OwnPtr<P>>::hash): Deleted.
(WTF::PtrHash<OwnPtr<P>>::equal): Deleted.
Remove unnecessary specialization of PtrHash.

  • wtf/RetainPtr.h:

(WTF::PtrHash<RetainPtr<P>>::hash): Deleted.
(WTF::PtrHash<RetainPtr<P>>::equal): Deleted.
Specialize IsSmartPointer for RetainPtr and remove the then unnecessary specialization of PtrHash.
(This is already tested in the API test WTF/cf/RetainPtrHashing).

12:08 AM Changeset in webkit [173806] by mihnea@adobe.com
  • 7 edits
    2 adds in trunk

[CSS Regions] Assertion failure and null dereference crash when using animations and regions
​https://bugs.webkit.org/show_bug.cgi?id=136918

Reviewed by Andrei Bucur.

Source/WebCore:

In some situations, for instance when an image has an attached animation, the style change caused by the animation
triggers a geometry update for the backing store associated with the image's layer. This may occur before
the layout for the image has finished.

Moreover, if the image in such situation - having a composited layer - is displayed in a region,
sicne the layout did not finish yet, the mappings between the layers of the elements collected in the named flow
and the regions associated with the named flow are not updated and cannot be used.

Therefore in those situations, we have to bail out early and use these mappings only after the layout has finished.

This patch also changes RenderLayerBacking method updateAfterDescendents -> updateAfterDescendants.

Test: fast/regions/animated-image-in-region.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterDescendants):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):

LayoutTests:

  • fast/regions/animated-image-in-region-expected.txt: Added.
  • fast/regions/animated-image-in-region.html: Added.

Sep 21, 2014:

11:58 PM Changeset in webkit [173805] by saambarati1@gmail.com
  • 5 edits in trunk/Source

Web Inspector: fix TypeSet hierarchy in TypeTokenView
​https://bugs.webkit.org/show_bug.cgi?id=136982

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

TypeSet was computing the set of type booleans in the Inspector::Protocol::Runtime::TypeSet
object incorrectly because it was calling TypeSet::doesTypeConformTo(T) which checks if the
type set has only been of type T. It now checks '(m_seenTypes & T) != TypeNothing' to see
if type T is in the set of seen types, but not the entire set itself.

  • runtime/TypeSet.cpp:

(JSC::TypeSet::inspectorTypeSet):

Source/WebInspectorUI:

The protocol object representation of TypeSet was being computed
incorrectly in JSC::TypeSet. This patch fixes that problem
and also asserts that the type information that the Web Inspector
receives is not empty.

  • UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet):

  • UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView.prototype._displayTypeName):

10:59 PM BadContent edited by Csaba Osztrogonác
add one more spammer (diff)
8:51 PM Changeset in webkit [173804] by Chris Dumez
  • 167 edits in trunk/Source

Generate Element casting helper functions
​https://bugs.webkit.org/show_bug.cgi?id=136839

Reviewed by Darin Adler.

Source/WebCore:

Generate Element casting helper functions instead of requiring explicit
use of NODE_TYPE_CASTS() macro. Casting is now done using the following
form: downcast<HTMLDivElement>(), instead of toHTMLDivElement().

The previous form (i.e. toHTMLDivElement()) is still supported for now
by generating macros that convert these calls into the new form, until
the code base is ported to the new casting helpers.

The plan is also to use is<HTMLDivElement>() instead of
isHTMLDivElement() for consistency but this was not changed in this
patch to avoid blowing up the size.

This CL also updates the way we convert a JSValue into an
implementation pointer. Instead of using toHTMLDivElement(), which
looked like a cast, we now use JSHTMLDivElement::toWrapped(). This
avoids conflicting with the toXXXElement() macros and makes it
clearer this is not a simple cast.

No new tests, no behavior change.

  • Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::installReplacement):

  • WebCore.exp.in:
  • bindings/js/JSAudioBufferSourceNodeCustom.cpp:

(WebCore::JSAudioBufferSourceNode::setBuffer):

  • bindings/js/JSBlobCustom.cpp:

(WebCore::constructJSBlob):

  • bindings/js/JSCommandLineAPIHostCustom.cpp:

(WebCore::JSCommandLineAPIHost::getEventListeners):
(WebCore::JSCommandLineAPIHost::databaseId):
(WebCore::JSCommandLineAPIHost::storageId):

  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::toHTMLFormElementOrNull):
(WebCore::constructJSDOMFormData):
(WebCore::JSDOMFormData::append):
(WebCore::toHTMLFormElement): Deleted.

  • bindings/js/JSDOMStringListCustom.cpp:

(WebCore::JSDOMStringList::toWrapped):
(WebCore::toDOMStringList): Deleted.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::toWrapped):
(WebCore::toDOMWindow): Deleted.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::createTouchList):

  • bindings/js/JSEventTargetCustom.cpp:

(WebCore::JSEventTarget::toWrapped):
(WebCore::toEventTarget): Deleted.

  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/js/JSHTMLMediaElementCustom.cpp:

(WebCore::JSHTMLMediaElement::setController):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::add):
(WebCore::JSHTMLOptionsCollection::remove):

  • bindings/js/JSHTMLSelectElementCustom.cpp:

(WebCore::JSHTMLSelectElement::remove):
(WebCore::selectIndexSetter):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::fillMessagePortArray):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::removeChild):
(WebCore::JSNode::appendChild):

  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::toWrapped):
(WebCore::toNodeFilter): Deleted.

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::getAttachedShaders):
(WebCore::JSWebGLRenderingContext::getProgramParameter):
(WebCore::JSWebGLRenderingContext::getShaderParameter):
(WebCore::JSWebGLRenderingContext::getUniform):
(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateParametersCheck):
(JSValueToNative):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::JSTestActiveDOMObject::toWrapped):
(WebCore::toTestActiveDOMObject): Deleted.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::toWrapped):
(WebCore::toTestCustomNamedGetter): Deleted.

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::toWrapped):
(WebCore::toTestEventConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestEventConstructor.h:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
(WebCore::JSTestEventTarget::toWrapped):
(WebCore::toTestEventTarget): Deleted.

  • bindings/scripts/test/JS/JSTestEventTarget.h:
  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::toWrapped):
(WebCore::toTestException): Deleted.

  • bindings/scripts/test/JS/JSTestException.h:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachable::toWrapped):
(WebCore::toTestGenerateIsReachable): Deleted.

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceSupplementalNode):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
(WebCore::JSTestInterface::toWrapped):
(WebCore::toTestInterface): Deleted.

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::toWrapped):
(WebCore::toTestMediaQueryListListener): Deleted.

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::toWrapped):
(WebCore::toTestNamedConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:
  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministic::toWrapped):
(WebCore::toTestNondeterministic): Deleted.

  • bindings/scripts/test/JS/JSTestNondeterministic.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionByteMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionOctetMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod8):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithArray):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):
(WebCore::JSTestObj::toWrapped):
(WebCore::toTestObj): Deleted.

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors3):
(WebCore::JSTestOverloadedConstructors::toWrapped):
(WebCore::toTestOverloadedConstructors): Deleted.

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::toWrapped):
(WebCore::toTestSerializedScriptValueInterface): Deleted.

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestTypedefsPrototypeFunctionCallWithSequenceThatRequiresInclude):
(WebCore::JSTestTypedefs::toWrapped):
(WebCore::toTestTypedefs): Deleted.

  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattribute::toWrapped):
(WebCore::toattribute): Deleted.

  • bindings/scripts/test/JS/JSattribute.h:
  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonly::toWrapped):
(WebCore::toreadonly): Deleted.

  • bindings/scripts/test/JS/JSreadonly.h:
  • dom/Element.h:

(WebCore::downcast):

  • dom/make_names.pl:

(printTypeHelpers):

  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.h:
  • html/HTMLAudioElement.h:
  • html/HTMLBaseElement.h:
  • html/HTMLBodyElement.h:
  • html/HTMLCanvasElement.h:
  • html/HTMLDataListElement.h:
  • html/HTMLDetailsElement.h:
  • html/HTMLDivElement.h:
  • html/HTMLEmbedElement.h:
  • html/HTMLFieldSetElement.h:
  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.h:
  • html/HTMLFrameSetElement.h:
  • html/HTMLHtmlElement.h:
  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.h:
  • html/HTMLInputElement.h:
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.h:
  • html/HTMLLinkElement.h:
  • html/HTMLMapElement.h:
  • html/HTMLMarqueeElement.h:
  • html/HTMLMetaElement.h:
  • html/HTMLMeterElement.h:
  • html/HTMLOListElement.h:
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.h:
  • html/HTMLParamElement.h:
  • html/HTMLProgressElement.h:
  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLSourceElement.h:
  • html/HTMLStyleElement.h:
  • html/HTMLSummaryElement.h:
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.h:
  • html/HTMLTemplateElement.h:
  • html/HTMLTextAreaElement.h:
  • html/HTMLTitleElement.h:
  • html/HTMLTrackElement.h:
  • html/HTMLVideoElement.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::scriptValueAsNode):

  • mathml/MathMLMencloseElement.h:
  • svg/SVGAltGlyphDefElement.h:
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAltGlyphItemElement.h:
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.h:
  • svg/SVGCursorElement.h:
  • svg/SVGEllipseElement.h:
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFilterElement.h:
  • svg/SVGFontElement.h:
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceNameElement.h:
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGGlyphRefElement.h:
  • svg/SVGHKernElement.h:
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.h:
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGPathElement.h:
  • svg/SVGPatternElement.h:
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.h:
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.h:
  • svg/SVGStopElement.h:
  • svg/SVGStyleElement.h:
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.h:
  • svg/SVGVKernElement.h:
  • svg/SVGViewElement.h:

Source/WebKit:

Update some of the exported symbols on Windows for functions that were
renamed.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/mac:

Use JSXXX::toWrapped() instead of toXXX() function.

  • DOM/WebDOMOperations.mm:
  • WebView/WebView.mm:

(-[WebView _notificationIDForTesting:]):

Source/WebKit/win:

Use JSXXX::toWrapped() instead of toXXX() function.

  • WebView.cpp:

(WebView::elementFromJS):

Source/WebKit2:

Use JSXXX::toWrapped() instead of toXXX() function.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::webNotificationID):

8:42 PM Changeset in webkit [173803] by saambarati1@gmail.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: unlocalized 'many' string in type profiler inline bubble
​https://bugs.webkit.org/show_bug.cgi?id=136980

Reviewed by Timothy Hatcher.

Generate the localizable string for the type profiler's "many" inline bubble.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/TypeTokenView.js:
5:31 PM Changeset in webkit [173802] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/mac

Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=136972

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-21
Reviewed by Darin Adler.

  • WebView/WebNotification.h:
  • WebView/WebNotification.mm:

(-[WebNotification initWithCoreNotification:notificationID:]):
Switch to RetainPtr and adopt into _private to ensure when we are
deallocated that _private will get deallocated.

5:24 PM Changeset in webkit [173801] by weinig@apple.com
  • 15 edits
    1 move
    1 add in trunk

Make possible HashSet<std::unique_ptr<>>
​https://bugs.webkit.org/show_bug.cgi?id=136166

Reviewed by Darin Adler.

Source/WTF:

  • wtf/GetPtr.h:

(WTF::getPtr):
(WTF::GetPtrHelper<std::unique_ptr<T>>::getPtr):
Make specializing GetPtrHelper a bit cleaner (you don't have to put
IsSmartPtr<T>::value everywhere any more) and add specializations for
std::unique_ptr.

  • wtf/HashFunctions.h:

(WTF::PtrHash<std::unique_ptr<P>>):
Add specialization for PtrHash for std::unique_ptr and set it as the DefaultHash
for it as well.

  • wtf/HashMap.h:
  • wtf/HashSet.h:

Add overloads of find(), contains(), remove(), take() (and get() for HashMap) for "smart pointers" that
take the raw pointer type as the parameter. These use SFINAE to make themselves only available
when the IsSmartPtr<KeyType>::value is true.

  • wtf/HashTraits.h:

Override constructDeletedValue() and isDeletedValue() in the std::unique_ptr specialization
since the default implementation depends on the type having a constructor that takes a HashTableDeletedValue
and function named isHashTableDeletedValue().

  • wtf/OwnPtr.h:

(WTF::OwnPtr::OwnPtr):
(WTF::OwnPtr::isHashTableDeletedValue):
(WTF::OwnPtr::hashTableDeletedValue):
Add HashTableDeletedValue constructor/functions to allow the constructDeletedValue() and isDeletedValue()
hash traits to work.

(WTF::PtrHash<OwnPtr<P>>::hash):
(WTF::PtrHash<OwnPtr<P>>::equal):
Add specialization for PtrHash for OwnPtr and set it as the DefaultHash
for it as well.

  • wtf/Ref.h:

Update for the less verbose GetPtrHelper specialization.

Tools:

  • TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
  • TestWebKitAPI/Counters.cpp: Added.
  • TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.

Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
translation unit.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add new files.

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.

5:18 PM Changeset in webkit [173800] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Fix post-mortem nits for r173724
​https://bugs.webkit.org/show_bug.cgi?id=136986

Reviewed by Darin Adler.

Fix post-mortem nits for r173724.

No new tests, no behavior change.

  • editing/EditingStyle.cpp:

(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):
Use nullptr instead of 0.

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):
Use getIdAttribute() / setIdAttribute().

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):
Use fastHasAttribute() for nowrap and do an early return to avoid
calling styleOrColLogicalWidth() if the nowrap attribute is missing.

4:52 PM Changeset in webkit [173799] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Structure should have a method for concurrently getting all of the property map entries, and this method shouldn't involve copy-paste
​https://bugs.webkit.org/show_bug.cgi?id=136983

Reviewed by Mark Hahnenberg.

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyMapEntry::PropertyMapEntry): Moved PropertyMapEntry struct to Structure.h so that Structure can refer to it.

  • runtime/Structure.cpp:

(JSC::Structure::getConcurrently): Switch to using the new forEachPropertyConcurrently() method.
(JSC::Structure::getPropertiesConcurrently): The subject of this patch. It will be useful for object allocation sinking (bug 136330).
(JSC::Structure::dump): Switch to using the new forEachPropertyConcurrently() method.

  • runtime/Structure.h:

(JSC::PropertyMapEntry::PropertyMapEntry): Moved from PropertyMapHashTable.h.

  • runtime/StructureInlines.h:

(JSC::Structure::forEachPropertyConcurrently): Capture this very common concurrent structure iteration pattern into a template method.

1:30 PM Changeset in webkit [173798] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

run-webkit-tests should count tests submitted as absolute paths once
​https://bugs.webkit.org/show_bug.cgi?id=136848

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-21
Reviewed by Darin Adler.

  • Scripts/webkitpy/port/base.py:

(Port._expanded_paths): In case of absolute path, do not search for platform specific tests.

12:18 PM Changeset in webkit [173797] by fpizlo@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Structure::getConcurrently() doesn't need to take a VM& argument.

Rubber stamped by Dan Bernstein.

Removed the extra argument, and then removed similar arguments from other methods until
I could build successfully again. It turned out that many methods took a VM& argument
just for calling getConcurrently().

  • bytecode/CodeBlock.cpp:

(JSC::dumpStructure):
(JSC::dumpChain):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printPutByIdCacheStatus):

  • bytecode/ComplexGetStatus.cpp:

(JSC::ComplexGetStatus::computeFor):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForStubInfo):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:
  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeForStubInfo):
(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):

  • runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::mayInterceptStoreTo):

  • runtime/IntendedStructureChain.h:
  • runtime/Structure.cpp:

(JSC::Structure::getConcurrently):

  • runtime/Structure.h:
  • runtime/StructureInlines.h:

(JSC::Structure::getConcurrently):

11:26 AM Changeset in webkit [173796] by fpizlo@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, speculative build fix.

If you use typed arrays, you gotta include runtime/TypedArrayInlines.h.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

Sep 20, 2014:

2:52 PM Changeset in webkit [173795] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FTL OSRExit construction should be based on methods that return ExitValues rather than methods that add ExitValues to OSRExit
​https://bugs.webkit.org/show_bug.cgi?id=136978

Reviewed by Dean Jackson.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::exitValueForNode):
(JSC::FTL::LowerDFGToLLVM::exitArgument):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode): Deleted.
(JSC::FTL::LowerDFGToLLVM::tryToSetConstantExitArgument): Deleted.
(JSC::FTL::LowerDFGToLLVM::addExitArgument): Deleted.

11:45 AM Changeset in webkit [173794] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FTL OSR exit should do reboxing and value recovery in the same pass
​https://bugs.webkit.org/show_bug.cgi?id=136977

Reviewed by Oliver Hunt.

It's conceptually simpler to have all of the logic in one place. After the
recover-and-rebox loop is done, all of the exit values are in the form that the baseline
JIT would want them to be in; the only remaining task is to move them into the right
place on the stack after we do all of the necessary stack adjustments.

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

10:59 AM Changeset in webkit [173793] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

StorageAccessData should be referenced in a sensible way
​https://bugs.webkit.org/show_bug.cgi?id=136963

Reviewed and rubber stamped by Michael Saboff.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handlePutByOffset):
(JSC::DFG::ByteCodeParser::handlePutById):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:
  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::storageAccessData):
(JSC::DFG::Node::storageAccessDataIndex): Deleted.

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):

8:34 AM Changeset in webkit [173792] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Option+Click on CSS url(...) should jump to resource view
​https://bugs.webkit.org/show_bug.cgi?id=136965

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-20
Reviewed by Timothy Hatcher.

  • UserInterface/Views/CodeMirrorAdditions.js:

When parsing CSS url(...) tokens, the contents of url(...)
are a "string" type, not "atom".

Sep 19, 2014:

11:49 PM Changeset in webkit [173791] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

[EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysystem.
​https://bugs.webkit.org/show_bug.cgi?id=136898

Reviewed by Eric Carlson.

Add support for proof of key release to the CDM by supporting a new "mime" type called
"keyrelease". When a session of type "keyrelease" is created, the initData is the server
certificate, the keyMessage contains the first stored proof of key release if present,
and closing the session will remove that proof from storage.

  • platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::CDMPrivateMediaSourceAVFObjC::supportsKeySystemAndMimeType):

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC):
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest):
(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys):
(WebCore::sessionStorageDirectory):
(WebCore::CDMSessionMediaSourceAVFObjC::update):
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyReleaseMessage):

11:02 PM Changeset in webkit [173790] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[Media][Mac] Buffered range slides around as you resize a window
​https://bugs.webkit.org/show_bug.cgi?id=136960

Reviewed by Dean Jackson.

Rather than using a canvas as the background image for the timeline slider, use a generated SVG image
to represent the buffered ranges.

  • Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-timeline):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls):
(Controller.prototype.updateProgress):

10:46 PM Changeset in webkit [173789] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
​https://bugs.webkit.org/show_bug.cgi?id=136974

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-19
Reviewed by Chris Fleizach.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(selectTextWithCriteriaCallback):
Be sure to release the string if it was allocated.

8:07 PM Changeset in webkit [173788] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebContent crash in WebKit::WebPage::expandedRangeFromHandle
​https://bugs.webkit.org/show_bug.cgi?id=136969

Reviewed by David Kilzer.

The crash was caused by m_currentBlockSelection and frame.selection().selection().toNormalizedRange()
both being null and the subsequent lines of code assuming currentRange to be not null.

Replace the assertion by an early exit since the range could be null here.

In the future, we should figure out if there are other things we need to do in addition
to checking the nullity when this race condition is hit.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle):

8:01 PM Changeset in webkit [173787] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Leak of mallocs under StructureSet::OutOfLineList::create
​https://bugs.webkit.org/show_bug.cgi?id=136970

Reviewed by Filip Pizlo.

addOutOfLine should free the old list when expanding the capacity.

  • bytecode/StructureSet.cpp:

(JSC::StructureSet::addOutOfLine):

7:44 PM Changeset in webkit [173786] by ap@apple.com
  • 2 edits in trunk/Tools

build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
​https://bugs.webkit.org/show_bug.cgi?id=136966

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:

(Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.

7:33 PM Changeset in webkit [173785] by gyuyoung.kim@samsung.com
  • 6 edits
    2 adds in trunk

[CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
​https://bugs.webkit.org/show_bug.cgi?id=136917

Reviewed by Darin Adler.

Source/WebCore:

When fixed layout is enabled, scrollTo doesn't work on EFL port with coordinated graphics.
Since updateScrollbars() doesn't update scroll position when delegatesScrolling() is enabled.
To fix this issue, EFL port should update scroll position based on WK2 port. This patch
update scroll position in FrameView::requestScrollPositionUpdate() as Mac port.

TestWebKitAPI: Tools/TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo

  • page/FrameView.cpp:

(WebCore::FrameView::requestScrollPositionUpdate):

Tools:

Added WKViewScrollTo.cpp and scrollTo.html to test this issue.

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
6:10 PM Changeset in webkit [173784] by Brent Fulgham
  • 11 edits
    4 adds in trunk

Latching in iframes is not working as expected
​https://bugs.webkit.org/show_bug.cgi?id=136729
<rdar://problem/18370549>

Reviewed by Simon Fraser.

Source/WebCore:

Test: platform/mac/fast/scrolling/scrolling-iframe-100pct.html

Correct latching behavior by moving the concept of latching from the event handler to the main frame.
The event handlers are per-document, and can improperly latch to the iframe element (rather than the
scrollable content of the iframe) resulting in incorrect behavior.

Also move the wheel event delta tracking to the main frame, as this is similarly "top-level" in nature.

  • WebCore.vcxproj/WebCore.vcxproj: Add new LatchedState class.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Update constructor after moving some members to the new
LatchedState object.
(WebCore::EventHandler::clear): Call 'clear' on the LatchedState class.
(WebCore::EventHandler::platformRecordWheelEvent): Update for new LatchedState class.
(WebCore::EventHandler::handleWheelEvent): Ditto.
(WebCore::EventHandler::clearLatchedState): Ditto.
(WebCore::EventHandler::defaultWheelEventHandler): Ditto.

  • page/EventHandler.h:
  • page/LatchedState.cpp: Added.

(WebCore::LatchedState::LatchedState):
(WebCore::LatchedState::~LatchedState):
(WebCore::LatchedState::clear):
(WebCore::LatchedState::setWheelEventElement):
(WebCore::LatchedState::setWidgetIsLatched):
(WebCore::LatchedState::setPreviousWheelScrolledElement):
(WebCore::LatchedState::setScrollableContainer):

  • page/LatchedState.h: Added.

(WebCore::LatchedState::wheelEventElement):
(WebCore::LatchedState::frame):
(WebCore::LatchedState::setFrame):
(WebCore::LatchedState::widgetIsLatched):
(WebCore::LatchedState::previousWheelScrolledElement):
(WebCore::LatchedState::scrollableContainer):
(WebCore::LatchedState::startedGestureAtScrollLimit):
(WebCore::LatchedState::setStartedGestureAtScrollLimit):

  • page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame): Update for new members (LatchedState and WheelEventDeltaTracker)

  • page/MainFrame.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformPrepareForWheelEvents): Use mainFrame-located latching information.
(WebCore::EventHandler::platformRecordWheelEvent): Use mainFrame-located wheel event delta tracking.
(WebCore::EventHandler::platformCompleteWheelEvent): Make sure to use the latched frame as well as
the latched element so that events get routed properly.
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Update for new mainFrame
location for latched state information.

LayoutTests:

  • platform/mac/fast/scrolling/scroll-iframe-webkit1-latching-bug-expected.txt: Added.
  • platform/mac/fast/scrolling/scroll-iframe-webkit1-latching-bug.html: Added.
5:11 PM Changeset in webkit [173783] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Minimize virtual function calls in MarkupAccumulator
​https://bugs.webkit.org/show_bug.cgi?id=136957

Reviewed by Benjamin Poulain.

This patch minimizes the number of virtual function calls in
MarkupAccumulator by:

  • De-virtualizing MarkupAccumulator::appendString(), which is never overridden
  • Having MarkupAccumulator::appendEndTag() virtual function take an Element in argument instead of a Node, as it only applies to Element. Also add a non-virtual overload that takes a Node in argument and that does the isElementNode() check so that we don't need to explicitly do the check at each call site.

No new tests, no behavior change.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendEndTag):
(WebCore::MarkupAccumulator::shouldSelfClose):
(WebCore::MarkupAccumulator::appendEndMarkup):

  • editing/MarkupAccumulator.h:

(WebCore::MarkupAccumulator::appendEndTag):

  • page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::appendEndTag):

5:05 PM Changeset in webkit [173782] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] ASSERTION FAILED: WTF::isMainThread() in WebCore::memoryCache() when using WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=136962
<rdar://problem/18342344>

Reviewed by Geoffrey Garen.

The disk cache monitor callback code was being executed on the main thread. This is wrong
when the web thread is being used in WebKit1 on iOS. The code needs to run on the web
thread. Use WebThreadRun to dispatch the block to the web thread. This works for WebKit2 as
well since when web thread is not being used, WebThreadRun invokes the block directly.

  • loader/cocoa/DiskCacheMonitorCocoa.mm:

(WebCore::DiskCacheMonitor::DiskCacheMonitor):

4:10 PM Changeset in webkit [173781] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.17-branch/Source

Versioning.

4:08 PM Changeset in webkit [173780] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.17.2

New Tag.

4:05 PM Changeset in webkit [173779] by matthew_hanson@apple.com
  • 1 edit in branches/safari-600.1.17-branch/WebKitLibraries/ChangeLog

Correct Radar to <rdar://problem/18375370>

4:04 PM Changeset in webkit [173778] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.17-branch/WebKitLibraries

Merge r173768. <rdar://problem/173768>

3:59 PM Changeset in webkit [173777] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; pass duration into the lambda.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged):

3:30 PM Changeset in webkit [173776] by dino@apple.com
  • 15 edits in trunk/Source

Multithreaded WebGL is a bad idea - remove it
​https://bugs.webkit.org/show_bug.cgi?id=136964
<rdar://problem/18399858>

Reviewed by Brent Fulgham.

Source/WebCore:

We should not allow multithreaded GL access. Remove the
feature.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create):

  • page/Settings.in:
  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

Source/WebKit/mac:

Remove the setting to allow multithreaded WebGL.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences multithreadedWebGLEnabled]): Deleted.
(-[WebPreferences setMultithreadedWebGLEnabled:]): Deleted.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Remove the setting to allow multithreaded WebGL.

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMultithreadedWebGLEnabled): Deleted.
(WKPreferencesGetMultithreadedWebGLEnabled): Deleted.

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

3:20 PM Changeset in webkit [173775] by dburkart@apple.com
  • 5 edits in branches/Safari-600.1.4.10-branch/Source

Bump versioning

2:41 PM Changeset in webkit [173774] by dburkart@apple.com
  • 1 move in tags/Safari-600.1.4.11.9

Fix tag name typo

2:39 PM Changeset in webkit [173773] by dburkart@apple.com
  • 1 copy in tags/safari-600.1.4.11.9

Tagging 600.1.4.11.9

2:25 PM Changeset in webkit [173772] by dburkart@apple.com
  • 2 edits in branches/safari-600.1.4.11-branch/Source/WebKit2

Merge r173722. <rdar://problem/18389146>

1:53 PM Changeset in webkit [173771] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[MSE][Mac] work around AVSampleBufferRenderSynchronizer early callbacks
​https://bugs.webkit.org/show_bug.cgi?id=136958

Reviewed by Jer Noble.

No new tests, we have been unable to come up with a test case that reproduces
this issue reliably.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged): Set the synchronizer

time to duration when the duration time observer is called early. Add more logging.

1:26 PM Changeset in webkit [173770] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

CSS JIT: allocate the minimum required register count in debug
​https://bugs.webkit.org/show_bug.cgi?id=136933

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-19
Reviewed by Andreas Kling.

It is hard to catch bugs of minimumRegisterRequirements() because every CPU has a different
number of registers available by default.

This patch aims at improving testing by creating artificial register pressure when running
in debug. When running in debug, we no longer allocate all the available registers right away.
Instead, we allocate just enough to satisfy minimumRegisterRequirements().

The expectation with this is that under-allocation would be detected quicker since they would
crash debug builds.

  • cssjit/RegisterAllocator.h:

(WebCore::RegisterAllocator::RegisterAllocator):
(WebCore::RegisterAllocator::reserveCallerSavedRegisters):
(WebCore::RegisterAllocator::availableRegisterCount): Deleted.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):

1:26 PM Changeset in webkit [173769] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Add a size check for CSSSelector
​https://bugs.webkit.org/show_bug.cgi?id=136882

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-19
Reviewed by Christophe Dumez.

  • css/CSSSelector.cpp:
1:19 PM Changeset in webkit [173768] by Brent Fulgham
  • 2 edits in trunk/WebKitLibraries

[Win] Turn off SSE Instructions for 32-bit Builds
​https://bugs.webkit.org/show_bug.cgi?id=136959
<rdar://problem/18375370>

Reviewed by Dean Jackson.

  • win/tools/vsprops/common.props: Conditionally exclude the enhanced (SSE) instruction

set when building for 32-bit Windows. Otherwise, continue using SSE.

11:48 AM Changeset in webkit [173767] by evab.u-szeged@partner.samsung.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r173464): It broke the !ENABLE(PICTURE_SIZES) build
​https://bugs.webkit.org/show_bug.cgi?id=136942

Reviewed by Simon Fraser.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

11:43 AM Changeset in webkit [173766] by Simon Fraser
  • 9 edits in trunk/Source

Provide a default argument for the most commonly used HitTestRequest variant
​https://bugs.webkit.org/show_bug.cgi?id=136653

Reviewed by Darin Adler.

Make the default HitTestRequest flags be ReadOnly | Active | DisallowShadowContent
and change call sites using the default flags to use a HitTestRequest temporary.

Source/WebCore:

  • dom/TreeScope.cpp:

(WebCore::nodeFromPoint):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::contains):

  • page/DragController.cpp:

(WebCore::elementUnderMouse):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleMousePressEvent):

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::HitTestRequest):

Source/WebKit2:

  • WebProcess/WebPage/ViewGestureGeometryCollector.cpp:

(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):

11:33 AM Changeset in webkit [173765] by Chris Dumez
  • 20 edits in trunk/Source

Allow DOM methods to return references instead of pointers
​https://bugs.webkit.org/show_bug.cgi?id=136931

Source/WebCore:

Reviewed by Sam Weinig.

It is common practice in WebKit to have methods return a reference
instead of a pointer if the pointer can never be null. However, this
unfortunately did not work for DOM methods (functions called by JS
bindings). This prevented further refactoring.

This patch brings support for having DOM methods to return references
instead of pointers when the pointer cannot be null. The generated
bindings were calling WTF::getPtr() on the pointer type returned by
the implementation already (in case it was a smart pointer type).
This patch leverages this by having WTF::getPtr() convert reference
arguments into raw pointers.

This patch also updates a few DOM methods on Document and Element
classes to return a reference instead of a pointer, to test the change.
There are likely more DOM methods that can be updated though.

No new tests, no behavior change.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::classList):

  • bindings/js/JSDOMBinding.h:

(WTF::getPtr): Deleted.

  • dom/Document.cpp:

(WebCore::Document::implementation):
(WebCore::Document::webkitGetNamedFlows):
(WebCore::Document::namedFlows):
(WebCore::Document::setXMLVersion):
(WebCore::Document::setXMLStandalone):
(WebCore::Document::securityPolicy):
(WebCore::Document::styleSheets):

  • dom/Document.h:

(WebCore::Document::timing):

  • dom/Element.cpp:

(WebCore::Element::classList):
(WebCore::Element::dataset):

  • dom/Element.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):

  • html/track/VTTRegion.cpp:

(WebCore::VTTRegion::displayLastTextTrackCueBox):
(WebCore::VTTRegion::willRemoveTextTrackCueBox):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):

  • page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::documentTiming):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):

Source/WTF:

Add support for having WTF::getPtr() transform reference arguments
into raw pointers so that DOM methods can now return references when
appropriate and so that the generated bindings code can handle this
via WTF::getPtr().

This patch had to alter the way getPtr() was overloaded for smart
pointer types so that we don't call &p on smart pointers but p.get().
This was needed because the new WTF::getPtr(T&) was being called for
RefPtr<T> arguments instead of the getPtr(const RefPtr<T>&) overload.
This was addressed using traits and template specialization to
distinguish WTF smart pointers from other types.

Reviewed by Sam Weinig.

  • wtf/GetPtr.h:

(WTF::getPtr):

  • wtf/OwnPtr.h:

(WTF::getPtr): Deleted.

  • wtf/PassOwnPtr.h:

(WTF::getPtr): Deleted.

  • wtf/PassRefPtr.h:

(WTF::getPtr): Deleted.

  • wtf/Ref.h:
  • wtf/RefPtr.h:

(WTF::getPtr): Deleted.

  • wtf/gobject/GRefPtr.h:

(WTF::getPtr): Deleted.

11:15 AM Changeset in webkit [173764] by jer.noble@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Videos with controls enabled never receive 'dragstart' events.
​https://bugs.webkit.org/show_bug.cgi?id=136837

Reviewed by Sam Weinig.

  • media/video-controls-drag-expected.txt: Added.
  • media/video-controls-drag.html: Added.
11:10 AM Changeset in webkit [173763] by dbates@webkit.org
  • 22 edits in trunk

Always assume internal SDK when building configuration Production
​https://bugs.webkit.org/show_bug.cgi?id=136925
<rdar://problem/18362399>

Reviewed by Dan Bernstein.

Source/bmalloc:

  • Configurations/Base.xcconfig:

Source/JavaScriptCore:

As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.

  • Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:

Source/WebCore:

As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.

  • Configurations/Base.xcconfig:

Source/WebInspectorUI:

  • Configurations/DebugRelease.xcconfig: Also move #include of HaveInternalSDK.xcconfig from DebugRelease.xcconfig

to Base.xcconfig so as to be consistent with the format of other Base.xcconfig/DebugRelease.xcconfig files
(e.g. Source/WebCore/Configurations/Base.xcconfig and Source/WebCore/Configurations/DebugRelease.xcconfig).

Source/WebKit/mac:

As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.

  • Configurations/Base.xcconfig:

Source/WebKit2:

As a side effect of this change we will always enable ENABLE_TOUCH_EVENTS, ENABLE_IOS_{GESTURE, TOUCH}_EVENTS,
and ENABLE_XSLT when either building configuration Production or building with the Internal SDK.

  • Configurations/Base.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • MiniBrowser/Configurations/DebugRelease.xcconfig:
  • TestWebKitAPI/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
11:04 AM Changeset in webkit [173762] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

Fix the Mac Mavericks build. Only iOS cares about fencing.

  • Platform/mac/LayerHostingContext.h:
  • Platform/mac/LayerHostingContext.mm:
10:47 AM Changeset in webkit [173761] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

Simple ES6 feature:String prototype additions
​https://bugs.webkit.org/show_bug.cgi?id=131704

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-09-19
Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):
(JSC::stringProtoFuncStartsWith): Added.
(JSC::stringProtoFuncEndsWith): Added.
(JSC::stringProtoFuncContains): Added.

Source/WTF:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::find):
(WTF::equalInner): Added.
(WTF::StringImpl::startsWith): Add implementation that supports
'startOffset' parameter.
(WTF::StringImpl::endsWith): Add implementation that supports
'endOffset' parameter.

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.h:

(WTF::String::contains): Modify current implementation to allow
setting a startOffset, 0 by default.
(WTF::String::startsWith):
(WTF::String::endsWith):

LayoutTests:

Test ES6 functions: string.startsWith(), string.endsWith() and
string.contains().

  • js/Object-getOwnPropertyNames-expected.txt:
  • js/script-tests/Object-getOwnPropertyNames.js:
  • js/script-tests/string-contains.js: Added.

(stringToSearchIn.toString):
(startOffset.valueOf):
(matchString.toString):
(endOffset.valueOf):

  • js/string-contains-expected.txt: Added.
  • js/string-contains.html: Added.
10:38 AM Changeset in webkit [173760] by commit-queue@webkit.org
  • 13 edits
    1 move
    1 add
    10 deletes in trunk

WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
​https://bugs.webkit.org/show_bug.cgi?id=136847

Tools:

Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-19
Reviewed by Alexey Proskuryakov.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveAuthenticationChallengeInFrame):

LayoutTests:

Updated WK2 expected.txt files according new logging of didReceiveAuthenticationChallengeInFrame.
Factorized efl/gtk platform specific expected files as WK2 expected files.

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-19
Reviewed by Alexey Proskuryakov.

  • platform/gtk/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Removed.
  • platform/gtk/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Removed.
  • platform/gtk/http/tests/media/video-auth-expected.txt: Removed.
  • platform/gtk/http/tests/misc/401-alternative-content-expected.txt: Removed.
  • platform/gtk/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Removed.
  • platform/gtk/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Removed.
  • platform/gtk/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Removed.
  • platform/gtk/http/tests/security/401-logout/401-logout-expected.txt: Removed.
  • platform/gtk/http/tests/xmlhttprequest/failed-auth-expected.txt: Removed.
  • platform/gtk/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Removed.
  • platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt:
  • platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
  • platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
  • platform/wk2/http/tests/media/video-auth-expected.txt: Renamed from LayoutTests/platform/efl/http/tests/media/video-auth-expected.txt.
  • platform/wk2/http/tests/misc/401-alternative-content-expected.txt:
  • platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt:
  • platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt:
  • platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt:
  • platform/wk2/http/tests/security/401-logout/401-logout-expected.txt:
  • platform/wk2/http/tests/xmlhttprequest/failed-auth-expected.txt:
  • platform/wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt:
9:36 AM Changeset in webkit [173759] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.5.90

WebKitGTK+ 2.5.90

9:31 AM Changeset in webkit [173758] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.90 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.5.90.
9:01 AM Changeset in webkit [173757] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6

Merge r173755 - [GTK] Missing inspector files in the tarball
​https://bugs.webkit.org/show_bug.cgi?id=136952

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

  • PlatformGTK.cmake: Use APPEND instead of GLOB to add individual

and generated files to the list of inspector files.

Tools:

  • gtk/manifest.txt: Add

Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
to the tarball.

9:00 AM Changeset in webkit [173756] by Carlos Garcia Campos
  • 6 edits
    55 adds in releases/WebKitGTK/webkit-2.6

Merge r173753 - Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
​https://bugs.webkit.org/show_bug.cgi?id=136632

Reviewed by Gustavo Noronha Silva.

Source/WebInspectorUI:

Add free icons for the GTK port. These icons are from the GNOME
project, some of them adapted by Andres Gomez for the inspector.
This is only a subset of the icons, since we still don't have a
free replacement for all of them, but at least it makes the
inspector kind of usable.

  • UserInterface/Images/gtk/AUTHORS: Added.
  • UserInterface/Images/gtk/BackArrow.svg: Added.
  • UserInterface/Images/gtk/BreakpointActionAdd.svg: Added.
  • UserInterface/Images/gtk/BreakpointActionRemove.svg: Added.
  • UserInterface/Images/gtk/BreakpointButton.svg: Added.
  • UserInterface/Images/gtk/BreakpointInactiveButton.svg: Added.
  • UserInterface/Images/gtk/Breakpoints.svg: Added.
  • UserInterface/Images/gtk/COPYING: Added.
  • UserInterface/Images/gtk/Close.svg: Added.
  • UserInterface/Images/gtk/CloseWhite.svg: Added.
  • UserInterface/Images/gtk/ContentFlow.svg: Added.
  • UserInterface/Images/gtk/Crosshair.svg: Added.
  • UserInterface/Images/gtk/DOMCharacterData.svg: Added.
  • UserInterface/Images/gtk/DOMComment.svg: Added.
  • UserInterface/Images/gtk/DOMDocument.svg: Added.
  • UserInterface/Images/gtk/DOMDocumentType.svg: Added.
  • UserInterface/Images/gtk/DOMElement.svg: Added.
  • UserInterface/Images/gtk/DOMNode.svg: Added.
  • UserInterface/Images/gtk/DOMTextNode.svg: Added.
  • UserInterface/Images/gtk/DOMTree.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Added.
  • UserInterface/Images/gtk/DockBottom.svg: Added.
  • UserInterface/Images/gtk/DockRight.svg: Added.
  • UserInterface/Images/gtk/DocumentCSS.png: Added.
  • UserInterface/Images/gtk/​DocumentCSS@2x.png: Added.
  • UserInterface/Images/gtk/DocumentFont.png: Added.
  • UserInterface/Images/gtk/​DocumentFont@2x.png: Added.
  • UserInterface/Images/gtk/DocumentGeneric.png: Added.
  • UserInterface/Images/gtk/​DocumentGeneric@2x.png: Added.
  • UserInterface/Images/gtk/DocumentImage.png: Added.
  • UserInterface/Images/gtk/​DocumentImage@2x.png: Added.
  • UserInterface/Images/gtk/DocumentJS.png: Added.
  • UserInterface/Images/gtk/​DocumentJS@2x.png: Added.
  • UserInterface/Images/gtk/DocumentMarkup.png: Added.
  • UserInterface/Images/gtk/​DocumentMarkup@2x.png: Added.
  • UserInterface/Images/gtk/DownloadArrow.svg: Added.
  • UserInterface/Images/gtk/Error.svg: Added.
  • UserInterface/Images/gtk/Errors.svg: Added.
  • UserInterface/Images/gtk/ErrorsEnabled.svg: Added.
  • UserInterface/Images/gtk/EventListener.svg: Added.
  • UserInterface/Images/gtk/Exception.svg: Added.
  • UserInterface/Images/gtk/FilterFieldGlyph.svg: Added.
  • UserInterface/Images/gtk/FolderGeneric.png: Added.
  • UserInterface/Images/gtk/​FolderGeneric@2x.png: Added.
  • UserInterface/Images/gtk/ForwardArrow.svg: Added.
  • UserInterface/Images/gtk/Function.svg: Added.
  • UserInterface/Images/gtk/GoToArrow.svg: Added.
  • UserInterface/Images/gtk/Resources.svg: Added.
  • UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Added.
  • UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Added.
  • UserInterface/Images/gtk/UpDownArrows.svg: Added.

Source/WebKit2:

  • PlatformGTK.cmake: Use only the icons from the gtk directory since they are free.

Tools:

  • gtk/generate-inspector-gresource-manifest.py: Use an alias for

the gtk icons.

  • gtk/manifest.txt: Only include the free icons in the tarball.
8:59 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
8:58 AM Changeset in webkit [173755] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] Missing inspector files in the tarball
​https://bugs.webkit.org/show_bug.cgi?id=136952

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

  • PlatformGTK.cmake: Use APPEND instead of GLOB to add individual

and generated files to the list of inspector files.

Tools:

  • gtk/manifest.txt: Add

Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
to the tarball.

8:48 AM Changeset in webkit [173754] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Optimize MarkupAccumulator::appendText()
​https://bugs.webkit.org/show_bug.cgi?id=136935

Reviewed by Benjamin Poulain.

MarkupAccumulator::appendText() was calling the generic appendNodeValue()
method to append the text. appendNodeValue() supports any kind of Node and
thus calls the Node::nodeValue() virtual function.

Since appendText() is the only caller to appendNodeValue(), this patch
inlines the code in appendText() and makes it specific to Text Node, and
thus more efficient. The code now calls CharacterData::data() instead of
the Node::nodeValue() virtual function. This patch also updates
CharacterData::data() to return a const reference to avoid copying the
return value.

No new tests, no behavior change.

  • dom/CharacterData.h:

(WebCore::CharacterData::data):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendText):
(WebCore::MarkupAccumulator::appendNodeValue): Deleted.

  • editing/MarkupAccumulator.h:
8:40 AM Changeset in webkit [173753] by Carlos Garcia Campos
  • 6 edits
    55 adds in trunk

Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
​https://bugs.webkit.org/show_bug.cgi?id=136632

Reviewed by Gustavo Noronha Silva.

Source/WebInspectorUI:

Add free icons for the GTK port. These icons are from the GNOME
project, some of them adapted by Andres Gomez for the inspector.
This is only a subset of the icons, since we still don't have a
free replacement for all of them, but at least it makes the
inspector kind of usable.

  • UserInterface/Images/gtk/AUTHORS: Added.
  • UserInterface/Images/gtk/BackArrow.svg: Added.
  • UserInterface/Images/gtk/BreakpointActionAdd.svg: Added.
  • UserInterface/Images/gtk/BreakpointActionRemove.svg: Added.
  • UserInterface/Images/gtk/BreakpointButton.svg: Added.
  • UserInterface/Images/gtk/BreakpointInactiveButton.svg: Added.
  • UserInterface/Images/gtk/Breakpoints.svg: Added.
  • UserInterface/Images/gtk/COPYING: Added.
  • UserInterface/Images/gtk/Close.svg: Added.
  • UserInterface/Images/gtk/CloseWhite.svg: Added.
  • UserInterface/Images/gtk/ContentFlow.svg: Added.
  • UserInterface/Images/gtk/Crosshair.svg: Added.
  • UserInterface/Images/gtk/DOMCharacterData.svg: Added.
  • UserInterface/Images/gtk/DOMComment.svg: Added.
  • UserInterface/Images/gtk/DOMDocument.svg: Added.
  • UserInterface/Images/gtk/DOMDocumentType.svg: Added.
  • UserInterface/Images/gtk/DOMElement.svg: Added.
  • UserInterface/Images/gtk/DOMNode.svg: Added.
  • UserInterface/Images/gtk/DOMTextNode.svg: Added.
  • UserInterface/Images/gtk/DOMTree.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Added.
  • UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Added.
  • UserInterface/Images/gtk/DockBottom.svg: Added.
  • UserInterface/Images/gtk/DockRight.svg: Added.
  • UserInterface/Images/gtk/DocumentCSS.png: Added.
  • UserInterface/Images/gtk/​DocumentCSS@2x.png: Added.
  • UserInterface/Images/gtk/DocumentFont.png: Added.
  • UserInterface/Images/gtk/​DocumentFont@2x.png: Added.
  • UserInterface/Images/gtk/DocumentGeneric.png: Added.
  • UserInterface/Images/gtk/​DocumentGeneric@2x.png: Added.
  • UserInterface/Images/gtk/DocumentImage.png: Added.
  • UserInterface/Images/gtk/​DocumentImage@2x.png: Added.
  • UserInterface/Images/gtk/DocumentJS.png: Added.
  • UserInterface/Images/gtk/​DocumentJS@2x.png: Added.
  • UserInterface/Images/gtk/DocumentMarkup.png: Added.
  • UserInterface/Images/gtk/​DocumentMarkup@2x.png: Added.
  • UserInterface/Images/gtk/DownloadArrow.svg: Added.
  • UserInterface/Images/gtk/Error.svg: Added.
  • UserInterface/Images/gtk/Errors.svg: Added.
  • UserInterface/Images/gtk/ErrorsEnabled.svg: Added.
  • UserInterface/Images/gtk/EventListener.svg: Added.
  • UserInterface/Images/gtk/Exception.svg: Added.
  • UserInterface/Images/gtk/FilterFieldGlyph.svg: Added.
  • UserInterface/Images/gtk/FolderGeneric.png: Added.
  • UserInterface/Images/gtk/​FolderGeneric@2x.png: Added.
  • UserInterface/Images/gtk/ForwardArrow.svg: Added.
  • UserInterface/Images/gtk/Function.svg: Added.
  • UserInterface/Images/gtk/GoToArrow.svg: Added.
  • UserInterface/Images/gtk/Resources.svg: Added.
  • UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Added.
  • UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Added.
  • UserInterface/Images/gtk/UpDownArrows.svg: Added.

Source/WebKit2:

  • PlatformGTK.cmake: Use only the icons from the gtk directory since they are free.

Tools:

  • gtk/generate-inspector-gresource-manifest.py: Use an alias for

the gtk icons.

  • gtk/manifest.txt: Only include the free icons in the tarball.
3:39 AM WebKitGTK/2.6.x created by Carlos Garcia Campos
3:23 AM Changeset in webkit [173752] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.6

Branch WebKitGTK+ for 2.6

2:21 AM Changeset in webkit [173751] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
​https://bugs.webkit.org/show_bug.cgi?id=136943

Reviewed by Philippe Normand.

Source/WebKit2:

  • PlatformGTK.cmake: Fix the inspector file list and pass it to

the generate-inspector-gresource-manifest.py script.

Tools:

Update the script to receive the list of files from the command
line instead of scanning the given directories.

  • gtk/generate-inspector-gresource-manifest.py:

(get_filenames): Convert filenames to use relative paths.
(find_all_files_in_directory): Deleted.
(find_all_files_in_directory.select_file): Deleted.

Sep 18, 2014:

11:58 PM Changeset in webkit [173750] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
​https://bugs.webkit.org/show_bug.cgi?id=136739

Patch by Tanay C <​tanay.c@samsung.com> on 2014-09-18
Reviewed by Gyuyoung Kim.

  • MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll

(on_mouse_wheel): Modified.

11:51 PM Changeset in webkit [173749] by Carlos Garcia Campos
  • 11 edits in trunk

[GTK] Dot not allow to create delete-on-destroy GMainLoopSources
​https://bugs.webkit.org/show_bug.cgi?id=136923

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

  • platform/gtk/GtkDragAndDropHelper.cpp:

(WebCore::GtkDragAndDropHelper::handleDragLeave): Use GMainLoopSource::scheduleAndDeleteOnDestroy().

Source/WebKit2:

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::dispatch): Use GMainLoopSource::scheduleAndDeleteOnDestroy().
(WorkQueue::dispatchAfter): Use GMainLoopSource::scheduleAfterDelayAndDeleteOnDestroy().

Source/WTF:

We have several asserts to ensure that delete-on-destroy sources
are not misused, like not scheduling socket sources on a
delete-on-destroy GMainLoopSource or not allowing to cancel them
before they have been dispatched. It's better to ensure all those
things at compile time, using static methods to schedule sources
creating a delete-on-destroy GMainLoopSource that is not returned
to the user.

  • wtf/gobject/GMainLoopSource.cpp:

(WTF::GMainLoopSource::create): Private static method to create a
delete-on-destroy GMainLoopSource.
(WTF::GMainLoopSource::cancelWithoutLocking): Return early in case
of delete-on-destroy source, since they can't be cancelled.
(WTF::GMainLoopSource::schedule): Remove assertion to ensure
socket sources are not scheduled on a delete-on-destroy GMainLoopSource.
(WTF::GMainLoopSource::scheduleAndDeleteOnDestroy):
(WTF::GMainLoopSource::scheduleAfterDelayAndDeleteOnDestroy):
(WTF::GMainLoopSource::createAndDeleteOnDestroy): Deleted.

  • wtf/gobject/GMainLoopSource.h:
  • wtf/gtk/MainThreadGtk.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread): Use GMainLoopSource::scheduleAndDeleteOnDestroy()

  • wtf/gtk/RunLoopGtk.cpp:

(WTF::RunLoop::wakeUp): Ditto.

Tools:

  • TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:

(TestWebKitAPI::TEST): Use the new API that doesn't allow to use
the source.

9:41 PM Changeset in webkit [173748] by ryuan.choi@gmail.com
  • 16 edits in trunk/Source/WebKit2

[EFL][CoordinatedGraphics] Remove setBackgroundColor message
​https://bugs.webkit.org/show_bug.cgi?id=136824

Reviewed by Gyuyoung Kim.

CoordinatedGraphics used setBackgroundColor() to draw the background of contents
although tiles are not ready.

This patch removes setBackgroundColor() and uses pageExtendedBackgroundColor()
which provides similar functionality.

  • UIProcess/API/efl/EwkView.cpp:

Enables or disables WKPageSetBackgroundExtendsBeyondPage to use pageExtendedBackgroundColor()
(EwkView::EwkView):
(EwkView::setBackgroundColor):

  • UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext): Passed pageExtendedBackgroundColor.
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext): Ditto.
(WebCore::CoordinatedGraphicsScene::setBackgroundColor): Deleted.

  • UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.h:

(WebCore::CoordinatedGraphicsScene::setDrawsBackground): Deleted.

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::setBackgroundColor): Deleted.

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::paintToCurrentGLContext):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::pageExtendedBackgroundColorDidChange):
Refactored to use const reference for the Color parameter.

  • UIProcess/WebPageProxy.h:
  • UIProcess/efl/WebViewEfl.cpp:

(WebKit::WebViewEfl::paintToCairoSurface):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::pageExtendedBackgroundColorDidChange):
Added PLATFORM(EFL) to pass PageExtendedBackgroundColorDidChange message.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::setBackgroundColor): Deleted.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setBackgroundColor): Deleted.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mainFrameDidLayout):

6:55 PM Changeset in webkit [173747] by dburkart@apple.com
  • 1 copy in tags/Safari-600.1.4.10.1

Tagging

6:47 PM Changeset in webkit [173746] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Windows] Media tests all fail because they cannot find localized strings.

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::mediaControlsScript):
Make sure to use localized strings files in RenderThemeSafari.

6:37 PM Changeset in webkit [173745] by dburkart@apple.com
  • 2 edits in branches/Safari-600.1.4.10-branch/Source/WebKit2

Merge r172989

6:21 PM Changeset in webkit [173744] by dburkart@apple.com
  • 5 edits in branches/Safari-600.1.4.10-branch/Source

Bumping versioning

6:01 PM Changeset in webkit [173743] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Remove generator/yield terminology in RenderInline's GeneratorContext
​https://bugs.webkit.org/show_bug.cgi?id=119278

Reviewed by Sam Weinig.

Get rid of the icky Generator/yield syntax used for collecting rects in RenderInline.
Just replace the operator() with an explicit addRect().

Also some drive-by nullptr cleanup, and removing default arguments from
addChildIgnoringContinuation() calls.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::willBeDestroyed):
(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::addChildToContinuation):
(WebCore::RenderInline::generateLineBoxRects):
(WebCore::RenderInline::generateCulledLineBoxRects):

  • rendering/RenderInline.h:
4:57 PM Changeset in webkit [173742] by dburkart@apple.com
  • 1 copy in branches/Safari-600.1.4.10-branch

Creating 600.1.4.10 branch

4:40 PM Changeset in webkit [173741] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Improve fullscreen video rotation animation.
​https://bugs.webkit.org/show_bug.cgi?id=136870

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-09-18
Reviewed by Simon Fraser.

Source/WebCore:

Instead of setting the frame on the video layer, set position and bounds separately. This allows the position to be synchronized with the rest of the animation.
When using a fencePort to synchronize animations, if the fence times out, pivoting around the center provides a better fallback.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVVideoLayer setVideoSublayer:]): added
(-[WebAVVideoLayer videoSublayer]): added
(-[WebAVVideoLayer setBounds:]): set position and bounds insted of frame.
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): use setVideoSublayer

  • platform/ios/WebVideoFullscreenModelVideoElement.mm:

(WebVideoFullscreenModelVideoElement::setVideoFullscreenLayer): set bounds and anchorPoint instead of frame
(WebVideoFullscreenModelVideoElement::setVideoLayerFrame): set bounds instead of frame.

Source/WebKit2:

Remove WKCAContext from LayerHostingContext and use a fencePort to synchronize animation between processes.

  • Platform/mac/LayerHostingContext.h: add setFencePort. Remove WKCAContext.
  • Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForPort): Remove WKCAContext.
(WebKit::LayerHostingContext::createForExternalHostingProcess): ditto
(WebKit::LayerHostingContext::setRootLayer): ditto
(WebKit::LayerHostingContext::rootLayer): ditto
(WebKit::LayerHostingContext::contextID): ditto
(WebKit::LayerHostingContext::invalidate): ditto
(WebKit::LayerHostingContext::setColorSpace): ditto
(WebKit::LayerHostingContext::colorSpace): ditto
(WebKit::LayerHostingContext::setFencePort): added

  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerFrame):

  • WebProcess/ios/WebVideoFullscreenManager.h:
  • WebProcess/ios/WebVideoFullscreenManager.messages.in: add fence port parameter
  • WebProcess/ios/WebVideoFullscreenManager.mm: ditto

(WebKit::WebVideoFullscreenManager::didSetupFullscreen): ditto
(WebKit::WebVideoFullscreenManager::setVideoLayerFrameFenced): ditto

3:58 PM Changeset in webkit [173740] by dino@apple.com
  • 4 edits
    2 adds in trunk/Websites/webkit.org

Expand the srcset demo to have 3x and 4x images.

Unreviewed.

  • demos/srcset/image-1x.png:
  • demos/srcset/image-2x.png:
  • demos/srcset/image-3x.png: Added.
  • demos/srcset/image-4x.png: Added.
  • demos/srcset/index.html:
3:52 PM Changeset in webkit [173739] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Text laid out with the SVG -> OTF font converter does not have the same metrics as with the SVG font code path
​https://bugs.webkit.org/show_bug.cgi?id=136907

Reviewed by Darin Adler.

There are three things that are causing text laid out with the SVG -> OTF font converter to not have metrics that
measure our existing SVG codepath. They are:

  1. Creating a font with a 0 ascent or descent makes OS X think that something is wrong with the font, and take

a different codepath when trying to parse ascent and descent information. This patch checks for this condition
and sets the ascent/descent to 1 FUnit instead (which is generally much smaller than a pixel).

  1. Our SVG font codepath hardcodes a line gap of 1/10th of the font size for every font. This patch makes the

font converter obey this.

  1. The converter was not allowing for default glyph advances as per the SVG font specification. This patch

does so.

No new tests yet, but they will come soon! I promise!

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendHHEATable):
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter):

3:49 PM Changeset in webkit [173738] by dbates@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r168921): SVG elements may be unnecessarily rebuilt
​https://bugs.webkit.org/show_bug.cgi?id=136373

Reviewed by David Kilzer.

Source/WebCore:

Fixes an issue where a SVG element may be unnecessarily rebuilt. In particular,
it is unnecessary to rebuild a SVG element that will be removed from the document.

Test: svg/custom/remove-subtree-including-use-with-child-textpath-that-references-earlier-path.html

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget): Modified to remove a SVG element
from the list of elements to be rebuilt.

LayoutTests:

Add a test to ensure that we don't rebuild a SVG element that will be removed from the document.

  • svg/custom/remove-subtree-including-use-with-child-textpath-that-references-earlier-path-expected.txt: Added.
  • svg/custom/remove-subtree-including-use-with-child-textpath-that-references-earlier-path.html: Added.
3:31 PM Changeset in webkit [173737] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Avoid divide by zero when we get an empty rect while snapshotting a node
​https://bugs.webkit.org/show_bug.cgi?id=136932
rdar://problem/18383473

Reviewed by Dean Jackson.

renderer()->paintingRootRect() can return an empty rect for some inline configurations,
for example an <a> containing a floated <span>

When this occurs, avoid a divide by zero and return a null snapshot image.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotNode):

3:06 PM Changeset in webkit [173736] by Joseph Pecoraro
  • 22 edits in trunk/Source

Unreviewed rollout r173731. Broke multiple builds.

Source/JavaScriptCore:

  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
(Inspector::RemoteInspector::xpcConnectionFailed):
(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::globalAutomaticInspectionState): Deleted.
(Inspector::RemoteInspector::updateDebuggableAutomaticInspectCandidate): Deleted.
(Inspector::RemoteInspector::sendAutomaticInspectionCandidateMessage): Deleted.
(Inspector::RemoteInspector::setupSucceeded): Deleted.
(Inspector::RemoteInspector::waitingForAutomaticInspection): Deleted.
(Inspector::RemoteInspector::receivedAutomaticInspectionConfigurationMessage): Deleted.
(Inspector::RemoteInspector::receivedAutomaticInspectionRejectMessage): Deleted.

  • inspector/remote/RemoteInspectorConstants.h:
  • inspector/remote/RemoteInspectorDebuggable.cpp:

(Inspector::RemoteInspectorDebuggable::setRemoteDebuggingAllowed):
(Inspector::RemoteInspectorDebuggable::pauseWaitingForAutomaticInspection): Deleted.

  • inspector/remote/RemoteInspectorDebuggable.h:
  • inspector/remote/RemoteInspectorDebuggableConnection.h:
  • inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setup):

  • runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::pauseWaitingForAutomaticInspection): Deleted.

  • runtime/JSGlobalObjectDebuggable.h:

Source/WebCore:

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::show):

  • inspector/InspectorController.h:
  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::connect):

  • page/PageDebuggable.h:
  • testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend):

Source/WTF:

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
2:59 PM Changeset in webkit [173735] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

2:37 PM Changeset in webkit [173734] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

ASSERT in RenderBox::instrinsicScrollbarLogicalWidth opening the inspector
​https://bugs.webkit.org/show_bug.cgi?id=136929

Reviewed by Simon Fraser.

This is a regression from ​http://trac.webkit.org/changeset/173668
This code is wrong after that change because it assumes that overflow:scroll will
always have a scrollbar. That is no longer the case. We need to check to make sure
it’s an overflow:scroll that does NOT have overflow:auto behavior.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::instrinsicScrollbarLogicalWidth):

2:32 PM Changeset in webkit [173733] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.11.8

New tag.

2:26 PM Changeset in webkit [173732] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch

Merge patch for <rdar://problem/18382131>.

12:47 PM Changeset in webkit [173731] by commit-queue@webkit.org
  • 22 edits in trunk/Source

Web Inspector: Should be able to attach a debugger to a JSContext before anything is executed
​https://bugs.webkit.org/show_bug.cgi?id=136893

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-18
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Adds new remote inspector protocol handling for automatic inspection.
Debuggers can signal they have enabled automatic inspection, and
when debuggables are created the current application will pause to
see if the debugger will inspect or decline to inspect the debuggable.

  • inspector/remote/RemoteInspectorConstants.h:
  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::globalAutomaticInspectionState):
(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::start):
When first starting, check the global "is there an auto-inspect" debugger state.
This is necessary so that the current application knows if it should pause or
not when a debuggable is created, even without having connected to webinspectord yet.

(Inspector::RemoteInspector::updateDebuggableAutomaticInspectCandidate):
When a debuggable has enabled remote inspection, take this path to propose
it as an automatic inspection candidate if there is an auto-inspect debugger.

(Inspector::RemoteInspector::sendAutomaticInspectionCandidateMessage):
Send the automatic inspection candidate message.

(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::setupSucceeded):
After attempting to open an inspector, unpause if it was for the
automatic inspection candidate.

(Inspector::RemoteInspector::waitingForAutomaticInspection):
When running a nested runloop, check if we should remain paused.

(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
If by the time we connect to webinspectord we have a candidate, then
immediately send the candidate message.

(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::xpcConnectionFailed):
In error cases, clear our state.

(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionConfigurationMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionRejectMessage):
Update state when receiving new messages.

  • inspector/remote/RemoteInspectorDebuggable.h:
  • inspector/remote/RemoteInspectorDebuggable.cpp:

(Inspector::RemoteInspectorDebuggable::setRemoteDebuggingAllowed):
Special case when a debuggable is newly allowed to be debuggable.

(Inspector::RemoteInspectorDebuggable::pauseWaitingForAutomaticInspection):
Run a nested run loop while this is an automatic inspection candidate.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
When the inspector starts via automatic inspection automatically pause.
We plan on removing this condition by having the frontend signal to the
backend when it is completely initialized.

  • inspector/remote/RemoteInspectorDebuggableConnection.h:
  • inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setup):
Pass on the flag of whether or not this was automatic inspection.

  • runtime/JSGlobalObjectDebuggable.h:
  • runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::pauseWaitingForAutomaticInspection):
When pausing in a JSGlobalObject we need to release the API lock.

Source/WebCore:

Automatic inspection is currently disabled for web pages.
This just updates the interfaces that changed.

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::show):

  • inspector/InspectorController.h:
  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::connect):

  • page/PageDebuggable.h:
  • testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend):

Source/WTF:

Currently automatic inspection only happens in processes that have a
debugger attached. That condition may change in the future, but this
function can stand on its own in WTF. It may be useful in the future
to perhaps continue though ASSERTs if you have a debugger attached.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
12:36 PM Changeset in webkit [173730] by benjamin@webkit.org
  • 3 edits in trunk/LayoutTests

CSS JIT: The backtracking register can be ignored from the minimumRegisterRequirements
​https://bugs.webkit.org/show_bug.cgi?id=136906
rdar://problem/18368294

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-18
Reviewed by Darin Adler.

  • fast/selectors/nth-child-with-backtracking-expected.txt:
  • fast/selectors/nth-child-with-backtracking.html:

The use case is well covered by existing tests. This is updating the backtracking test
with a simpler selector similar to the one in the bug report.

12:33 PM Changeset in webkit [173729] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Don’t skip all the media tests on Windows.

  • platform/win/TestExpectations:
12:12 PM Changeset in webkit [173728] by roger_fong@apple.com
  • 9 edits
    9 adds in trunk/LayoutTests

Unreviewed. Windows rebaselining to account for subpixel layout Part 3.

  • platform/win/css1/box_properties/acid_test-expected.txt: Added.
  • platform/win/fast/block/margin-collapse: Added.
  • platform/win/fast/block/margin-collapse/103-expected.txt: Added.
  • platform/win/fast/css/empty-pseudo-class-expected.txt:
  • platform/win/fast/css/first-child-pseudo-class-expected.txt:
  • platform/win/fast/css/last-child-pseudo-class-expected.txt:
  • platform/win/fast/css/only-child-pseudo-class-expected.txt:
  • platform/win/fast/forms/basic-inputs-expected.txt: Added.
  • platform/win/fast/forms/file/file-input-direction-expected.txt:
  • platform/win/fast/forms/formmove-expected.txt: Added.
  • platform/win/fast/forms/formmove2-expected.txt: Added.
  • platform/win/fast/repaint/reflection-redraw-expected.txt:
  • platform/win/fast/replaced/width100percent-button-expected.txt:
  • platform/win/fast/ruby/bopomofo-expected.txt: Added.
  • platform/win/fast/ruby/bopomofo-letter-spacing-expected.txt: Added.
  • platform/win/fast/ruby/bopomofo-rl-expected.txt: Added.
  • platform/win/fast/table/multiple-captions-display-expected.txt:
11:10 AM Changeset in webkit [173727] by Brent Fulgham
  • 2 edits in trunk/Source/ThirdParty

[Win] Unreviewed build fix.

  • gtest/msvc/gtest-md.vcxproj: Make sure we use static linking for gtest on

normal debug build to match the rest of WebKit.

10:36 AM Changeset in webkit [173726] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Incorrect pending API request URL when loading an HTML string
​https://bugs.webkit.org/show_bug.cgi?id=136913

Reviewed by Alexey Proskuryakov.

Use about:blank as pending API request URL when the given base URL
is empty, otherwise use the given base URL.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadHTMLString):

10:15 AM Changeset in webkit [173725] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
​https://bugs.webkit.org/show_bug.cgi?id=136856

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunLLINTCLoopTests.countFailures):
(Run32bitJSCTests.countFailures):

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunLLINTCLoopTestsTest.test_failures):
(RunLLINTCLoopTestsTest.test_failure):
(RunLLINTCLoopTestsTest.test_no_failure):
(Run32bitJSCTestsTest.test_failures):
(Run32bitJSCTestsTest.test_failure):
(Run32bitJSCTestsTest.test_no_failure):

9:52 AM Changeset in webkit [173724] by Chris Dumez
  • 52 edits in trunk/Source/WebCore

Use fastHasAttribute() / fastGetAttribute() when possible
​https://bugs.webkit.org/show_bug.cgi?id=136900

Reviewed by Benjamin Poulain.

Use fastHasAttribute() / fastGetAttribute() when possible, that is when
the attribute is not SVG-animated or the |style| attribute, to avoid
synchronizing attributes unnecessarily.

Also avoid calling hasAttribute(xxxAttr) then getAttribute(xxxAttr) as
it causes 2 linear searches. It is best to call getAttribute(xxxAttr)
directly and check if it returns the nullAtom.

No new tests, no behavior change. Element::fastAttributeLookupAllowed()
is there as a safety set for debug builds.

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isEnabled):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
(WebCore::AccessibilityNodeObject::hierarchicalLevel):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::contentEditableAttributeIsEnabled):

  • dom/Document.cpp:

(WebCore::Document::hasManifest):

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesLabelForAttribute):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Element.cpp:

(WebCore::Element::imageSourceURL):
(WebCore::Element::pseudo):
(WebCore::Element::spellcheckAttributeState):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):

  • editing/EditingStyle.cpp:

(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::draggable):
(WebCore::HTMLAnchorElement::sendPings):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::updateWidget):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::value):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::imageSourceURL):
(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::~HTMLFieldSetElement):
(WebCore::updateFromControlElementsAncestorDisabledStateUnder):
(WebCore::HTMLFieldSetElement::disabledAttributeChanged):
(WebCore::HTMLFieldSetElement::disabledStateChanged):
(WebCore::HTMLFieldSetElement::childrenChanged):
(WebCore::HTMLFieldSetElement::didMoveToNewDocument):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::computeIsDisabledByFieldsetAncestor):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::action):

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::noResize):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::location):

  • html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectStyleForPresentationAttribute):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::altText):
(WebCore::HTMLImageElement::alt):
(WebCore::HTMLImageElement::draggable):
(WebCore::HTMLImageElement::src):
(WebCore::HTMLImageElement::addSubresourceAttributeURLs):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::reset):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::rel):

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::content):
(WebCore::HTMLMetaElement::httpEquiv):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::imageSourceURL):
(WebCore::HTMLObjectElement::addSubresourceAttributeURLs):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::groupLabelText):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::max):

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::forAttributeValue):
(WebCore::HTMLScriptElement::eventAttributeValue):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rules):
(WebCore::HTMLTableElement::summary):
(WebCore::HTMLTableElement::addSubresourceAttributeURLs):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::align):
(WebCore::HTMLTableSectionElement::ch):
(WebCore::HTMLTableSectionElement::vAlign):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::maxLength):

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::searchEventsShouldBeDispatched):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • page/Frame.cpp:

(WebCore::Frame::matchLabelsAgainstElement):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeImageToDataObject):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::autosaveName):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):

9:32 AM Changeset in webkit [173723] by Chris Dumez
  • 15 edits in trunk/Source/WebCore

Have LiveNodeLists / HTMLCollections's elementMatches() take a reference
​https://bugs.webkit.org/show_bug.cgi?id=136902

Reviewed by Darin Adler.

Have LiveNodeLists / HTMLCollections's elementMatches() take a reference
in argument instead of a pointer as the Element can never be null.

No new tests, no behavior change.

  • dom/ClassNodeList.h:

(WebCore::ClassNodeList::elementMatches):

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesWindowNamedItem):
(WebCore::keyMatchesDocumentNamedItem):

  • dom/Element.cpp:

(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateIdForDocument):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::namedItem):

  • dom/LiveNodeList.h:

(WebCore::CachedLiveNodeList<NodeListType>::collectionBegin):
(WebCore::CachedLiveNodeList<NodeListType>::collectionLast):
(WebCore::CachedLiveNodeList<NodeListType>::collectionTraverseForward):
(WebCore::CachedLiveNodeList<NodeListType>::collectionTraverseBackward):

  • dom/NameNodeList.h:

(WebCore::NameNodeList::elementMatches):

  • dom/TagNodeList.h:

(WebCore::TagNodeList::elementMatches):
(WebCore::HTMLTagNodeList::elementMatches):

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement):

  • html/HTMLNameCollection.cpp:

(WebCore::WindowNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::WindowNameCollection::elementMatches):
(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):

  • html/HTMLNameCollection.h:
  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::elementMatches):

  • html/LabelsNodeList.h:
  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
(WebCore::RadioNodeList::elementMatches):

  • html/RadioNodeList.h:
9:26 AM Changeset in webkit [173722] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Occasional unreproducible crashes in MessageReceiverMap::dispatchMessage
​https://bugs.webkit.org/show_bug.cgi?id=136909
<rdar://problem/17758325>

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView dealloc]):
We're seeing some messages dispatched on the WebContext that end up
attempting to call dispatchMessage on a freed MessageReceiver.
The WKRemoteObjectRegistry message receiver is added to the WebContext
message receiver map, but never removed, despite the WebContext easily
outliving the WKWebView that owns the remote object registry.

9:22 AM Changeset in webkit [173721] by evab.u-szeged@partner.samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix "Tools/Scripts/build-webkit --efl --no-inspector" build
​https://bugs.webkit.org/show_bug.cgi?id=136912

Reviewed by Darin Adler.

  • runtime/TypeSet.cpp:

(JSC::TypeSet::leastCommonAncestor):

6:06 AM Changeset in webkit [173720] by zandobersek@gmail.com
  • 5 edits
    1 add in trunk

GMainLoopSource is exposed to race conditions
​https://bugs.webkit.org/show_bug.cgi?id=135800

Reviewed by Carlos Garcia Campos.

Source/WTF:

GMainLoopSource objects can be dispatching tasks on one thread
while having a new task scheduled on a different thread. This
can for instance occur in WebKitVideoSink, where the timeout
callback can be called on main thread while at the same time
it is being rescheduled on a different thread (created through
GStreamer).

The initial solution is to use GMutex to prevent parallel data
access from different threads. In the future I plan to look at
the possibility of creating thread-specific GMainLoopSource
objects that wouldn't require the use of GMutex.

GSource, GCancellable and std::function<> objects are now packed
into an internal Context structure. Using the C++11 move semantics
it's simple to, at the time of dispatch, move the current context
out of the GMainLoopSource object in case the dispatch causes a
rescheduling on that same object.

Also added in the Context struct is a new GCancellable. The pointer
of that object is shared with the GMainLoopSource before the Context
is moved out for the callback dispatch. This makes it safe to cancel
or even delete the GMainLoopSource during the dispatch and prevents
use-after-delete on GMainLoopSource once the dispatch is done in
the GMainLoopSource::*Callback() methods.

All the schedule*() methods and the cancelWithoutLocking() method
callers now lock the GMutex to ensure no one else is accessing the
data at that moment. Similar goes for the dispatch methods, but those
do the dispatch and possible destruction duties with the mutex unlocked.
The dispatch can cause rescheduling on the same GMainLoopSource object,
which must not be done with a locked mutex.

  • wtf/gobject/GMainLoopSource.cpp:

(WTF::GMainLoopSource::GMainLoopSource):
(WTF::GMainLoopSource::~GMainLoopSource):
(WTF::GMainLoopSource::cancel):
(WTF::GMainLoopSource::cancelWithoutLocking):
(WTF::GMainLoopSource::scheduleIdleSource):
(WTF::GMainLoopSource::schedule):
(WTF::GMainLoopSource::scheduleTimeoutSource):
(WTF::GMainLoopSource::scheduleAfterDelay):
(WTF::GMainLoopSource::voidCallback):
(WTF::GMainLoopSource::boolCallback):
(WTF::GMainLoopSource::socketCallback):
(WTF::GMainLoopSource::socketSourceCallback):
(WTF::GMainLoopSource::Context::destroySource):
(WTF::GMainLoopSource::reset): Deleted.
(WTF::GMainLoopSource::destroy): Deleted.

  • wtf/gobject/GMainLoopSource.h:

Tools:

Add unit tests for GMainLoopSource.

The tests check correct behavior of GMainLoopSource in various conditions --
from the most simple rescheduling to rescheduling during dispatch, cancelling
or destroying the GMainLoopSource during dispatch, proper destroy callback
dispatching etc.

Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
State of the GMainLoopSource object (either ready, sheduled or active) is
thoroughly tested throughout the lifetime of that object.

Still missing are tests for socket callbacks, which are a bit trickier because
they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
are also not tested thoroughly, simply because it is at the moment impossible
to test that the objects are actually destroyed when the corresponding source
is finally deleted.

  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.

(TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
(TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
(TestWebKitAPI::GMainLoopSourceTest::runLoop):
(TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
(TestWebKitAPI::GMainLoopSourceTest::finish):
(TestWebKitAPI::GMainLoopSourceTest::source):
(TestWebKitAPI::TEST):

4:16 AM Changeset in webkit [173719] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

Remove unused methods from MediaPlayerClient
​https://bugs.webkit.org/show_bug.cgi?id=136884

Reviewed by Eric Carlson.

Remove unused methods from MediaPlayerClient that introduce
dependencies on WebCore types.

  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerOwningDocument): Deleted.
(WebCore::MediaPlayerClient::mediaPlayerHostWindow): Deleted.
(WebCore::MediaPlayerClient::mediaPlayerWindowClipRect): Deleted.

Sep 17, 2014:

11:54 PM Changeset in webkit [173718] by bshafiei@apple.com
  • 11 edits in branches/safari-600.1.4.11-branch/Source/WebKit2

Merged r173702. <rdar://problem/18316542>

11:23 PM Changeset in webkit [173717] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Use the correct enum for control key in Ewk_Event_Modifiers in ewk_navigation_policy_decision.cpp
​https://bugs.webkit.org/show_bug.cgi?id=136740

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-09-17
Reviewed by Gyuyoung Kim.

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(toEwkEventModifiers):

11:21 PM Changeset in webkit [173716] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Add Wayland support to GLContextEGL
​https://bugs.webkit.org/show_bug.cgi?id=136829

Reviewed by Martin Robinson.

  • platform/graphics/egl/GLContextEGL.cpp:

(WebCore::sharedEGLDisplay): Special-case the shared EGL display initialization
for the GTK port when running under Wayland. In that case the pointer to the
native wl_display object should be passed to eglGetDisplay(). If not running
under Wayland we should fall back to using the shared X11 display (if support
for that display system is enabled) or the EGL_DEFAULT_DISPLAY.

7:32 PM Changeset in webkit [173715] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unnecessary prefixes in WebInspectorUI CSS
​https://bugs.webkit.org/show_bug.cgi?id=136905

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-17
Reviewed by Timothy Hatcher.

Removed vendor prefixes from justify-content and a few lingering
occurances with transition, box-shadow, and display.

  • UserInterface/Views/BreakpointActionView.css:
  • UserInterface/Views/BreakpointTreeElement.css:
  • UserInterface/Views/ButtonNavigationItem.css:
  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
  • UserInterface/Views/ControlToolbarItem.css:
  • UserInterface/Views/DebuggerDashboardView.css:
  • UserInterface/Views/DefaultDashboardView.css:
  • UserInterface/Views/FontResourceContentView.css:
  • UserInterface/Views/ImageResourceContentView.css:
  • UserInterface/Views/LayerTreeSidebarPanel.css:
  • UserInterface/Views/Main.css:
  • UserInterface/Views/NavigationBar.css:
  • UserInterface/Views/NavigationSidebarPanel.css:
  • UserInterface/Views/Popover.css:
  • UserInterface/Views/ReplayDashboardView.css:
  • UserInterface/Views/Toolbar.css:
6:53 PM Changeset in webkit [173714] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

6:52 PM Changeset in webkit [173713] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.25

New Tag.

6:26 PM Changeset in webkit [173712] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

[Windows] Unreviewed rebaselining of some failing JS tests.

  • platform/win/js/dom/deep-recursion-test-expected.txt: Added.
  • platform/win/js/dom/global-constructors-attributes-shared-worker-expected.txt:
6:23 PM Changeset in webkit [173711] by ryuan.choi@gmail.com
  • 2 edits in trunk/Tools

Unreviewed, Update my email in contributors.json

  • Scripts/webkitpy/common/config/contributors.json:
6:15 PM Changeset in webkit [173710] by dbates@webkit.org
  • 69 edits
    10 deletes in trunk

Unreviewed, rolling out r173695.

Broke building third-party Legacy WebKit apps; will
investigate offline

Reverted changeset:

"[iOS] Make WebCore build with public iOS SDK"
​https://bugs.webkit.org/show_bug.cgi?id=136487
​http://trac.webkit.org/changeset/173695

5:59 PM Changeset in webkit [173709] by roger_fong@apple.com
  • 3 edits
    1 move in trunk/LayoutTests

Unreviewed. Use a power-of-2 image size instead so that WebGL tests won’t complain.

  • fast/canvas/image-potential-subsample.html:
  • fast/canvas/resources/image-6400x6400.jpg: Copied from fast/canvas/resources/image-8000x8000.jpg.
  • fast/canvas/resources/image-8000x8000.jpg: Removed.
  • fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-potentially-subsampled-image.js:

(.init):

5:26 PM Changeset in webkit [173708] by roger_fong@apple.com
  • 6 edits
    5 adds in trunk/LayoutTests

Unreviewed. Windows rebaselining to account for subpixel layout Part 2.

  • platform/win/editing/apply-style-iframe-crash-expected.txt: Added.
  • platform/win/editing/selection/move-left-right-expected.txt:
  • platform/win/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
  • platform/win/tables/mozilla/bugs/bug4527-expected.txt: Added.
  • platform/win/tables/mozilla/marvin/body_col-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/other/body_col-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core: Added.
  • platform/win/tables/mozilla_expected_failures/core/captions1-expected.txt: Added.
  • platform/win/tables/mozilla_expected_failures/core/captions2-expected.txt: Added.
3:40 PM Changeset in webkit [173707] by dino@apple.com
  • 23 edits in trunk/Source/WebInspectorUI

WebInpector can use unprefixed flexbox
​https://bugs.webkit.org/show_bug.cgi?id=136899

Reviewed by Joseph Pecoraro.

Now the inspector UI itself can use a non-prefixed flexbox. This was
a basic search and replace for the following properties:

  • align-content
  • align-items
  • align-self
  • flex-basis
  • flex-direction
  • flex-wrap
  • flex-grow
  • flex-shrink
  • flex
  • flex-flow
  • justify
  • UserInterface/Views/ButtonToolbarItem.css:
  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
  • UserInterface/Views/ContentBrowser.css:
  • UserInterface/Views/ControlToolbarItem.css:
  • UserInterface/Views/DebuggerDashboardView.css:
  • UserInterface/Views/DefaultDashboardView.css:
  • UserInterface/Views/FilterBar.css:
  • UserInterface/Views/FlexibleSpaceNavigationItem.css:
  • UserInterface/Views/FontResourceContentView.css:
  • UserInterface/Views/HierarchicalPathComponent.css:
  • UserInterface/Views/ImageResourceContentView.css:
  • UserInterface/Views/LayerTreeSidebarPanel.css:
  • UserInterface/Views/LogContentView.css:
  • UserInterface/Views/Main.css:
  • UserInterface/Views/NavigationBar.css:
  • UserInterface/Views/NavigationSidebarPanel.css:
  • UserInterface/Views/Popover.css:
  • UserInterface/Views/QuickConsole.css:
  • UserInterface/Views/ReplayDashboardView.css:
  • UserInterface/Views/ResourceSidebarPanel.css:
  • UserInterface/Views/Toolbar.css:
3:34 PM Changeset in webkit [173706] by msaboff@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Change CallFrame to use Callee instead of JSScope to implement vm()
​https://bugs.webkit.org/show_bug.cgi?id=136894

Reviewed by Geoffrey Garen.

Added JSCell::vm() method that can be used on any JSObject. Changed CallFrame::vm() to
use JSCell::vm with the Callee. Made similar changes in the LLInt.
In support of this, changed JSGlobalObject::init() to take a VM& parameter, as there is
a chicken/egg problem with trying to use the Callee in the global exec before the Callee
has been create. Besides, the vm is readily available in finishCreation(), the caller of
init().

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:

Changed the calculation of CallFrame::VM to use the Callee instead of JSScope.

  • runtime/JSCell.h:
  • runtime/JSCellInlines.h:

(JSC::JSCell::vm): New method for getting VM from the pointer.
(JSC::ExecState::vm): Moved this method from JSScope.h to here since this file
contains the implementation of JSCell::vm(), this file is included by all users
of CallFrame::vm, and lastly putting it in CallFrameInlines.h required changing
many other .h files and possible the WebCore generator generate-bindings.pl.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::finishCreation):
Changed init() to take a VM parameter.

  • runtime/JSScope.h:

(JSC::ExecState::vm): Deleted.

3:06 PM Changeset in webkit [173705] by dino@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Add unprefixed flexbox display values and property names/values
​https://bugs.webkit.org/show_bug.cgi?id=136880
<rdar://problem/18361137>

Reviewed by Benjamin Poulain with some extra comments by Joseph Pecoraro.

  • UserInterface/Models/CSSKeywordCompletions.js: Switch to all the unprefixed

flex properties.

2:37 PM Changeset in webkit [173704] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] Unreviewed gardening. Content Security Policy 1.1 (ENABLE_CSP_NEXT) is not enabled

  • platform/win/TestExpectations: Tests sometimes crash or timeout in addition to just failing.
2:24 PM Changeset in webkit [173703] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Speculative fix for a fast\dom\html-collections-named-getter failing only in Debug builds.

  • dom/Node.cpp:

(WebCore::Document::invalidateNodeListAndCollectionCaches):

2:18 PM Changeset in webkit [173702] by Simon Fraser
  • 11 edits in trunk/Source/WebKit2

Fix an issue that caused video playback to not always use high resolution streams
​https://bugs.webkit.org/show_bug.cgi?id=136879
rdar://problem/18316542

Reviewed by Eric Carlson.

The underlying video framework expects to be able to use -[CALayer convertRect:toLayer:nil] on
the video layer to obtain information about the display resolution of the video,
including the device scale factor. This doesn't work for layers in the web process,
which are remotely hosted into the UI process.

For now, use a workaround which involves putting a scale transform equivalent to
the device scale factor on the web process layer, and the inverse scale on the
hosting layer in the UI process.

We have to do this in two places, for in-page video, and for fullscreen video.

  • Shared/mac/RemoteLayerTreeTransaction.h: Add hostingDeviceScaleFactor to the LayerCreation

properties.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):

  • UIProcess/ios/RemoteLayerTreeHostIOS.mm:

(-[WKRemoteView initWithFrame:contextID:hostingDeviceScaleFactor:]): Set the inverse scale
transform on the layer.
(WebKit::RemoteLayerTreeHost::createLayer):
(-[WKRemoteView initWithFrame:contextID:]): Deleted.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.h:
  • UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:
  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:

(WebKit::RemoteLayerTreeContext::deviceScaleFactor):

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::layerWasCreated):

  • WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::enterFullscreenForNode):
(WebKit::WebVideoFullscreenManager::didSetupFullscreen):

1:45 PM Changeset in webkit [173701] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merge r173664. rdar://problem/18187713

1:42 PM Changeset in webkit [173700] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merge r173632. rdar://problem/18187713

1:39 PM Changeset in webkit [173699] by matthew_hanson@apple.com
  • 4 edits in branches/safari-600.1-branch/Source/WebCore

Merge r173631. rdar://problem/18187713

1:03 PM Changeset in webkit [173698] by benjamin@webkit.org
  • 12 edits
    2 adds in trunk

Add parsing for :nth-child(An+B of selector)
​https://bugs.webkit.org/show_bug.cgi?id=136845

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-17
Reviewed by Antti Koivisto.

Source/WebCore:

Add support for parsing :nth-child(of). The implementation of selector matching
will be in a follow up, there are enough edge cases here already.

Spec here: ​http://dev.w3.org/csswg/selectors4/#the-nth-child-pseudo

Test: fast/css/parsing-css-nth-child-of.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectFunctionTypeToken):
(WebCore::CSSParser::realLex):
The parser generate two new kinds of tokens:
-NTHCHILDFUNCTION, matching the "nth-child" identifier.
-NTHCHILDSELECTORSEPARATOR, matching the "of" keyword separating An+B from the selector list.

NTHCHILDFUNCTION is used to extend the new syntax only for :nth-child() and not all the "nth" functions
(e.g. :nth-of-type()).

NTHCHILDSELECTORSEPARATOR exists for two reasons:
-We must clear the "parsingMode" before parsing selectorList. If we failed to do that, the complex selectors

would be parsed in NthChildMode, which has all kind of bad side effects.

-The second reason is differentiacting "of" for all the other identifiers. Arguably, this could have been done

in the grammar, but it is clearer this way since we already need the branches for the parsingMode.

  • css/CSSGrammar.y.in:

Those are pretty much duplicates of the existing FUNCTION rules but supporting the new syntax.

  • css/CSSParserValues.cpp:

(WebCore::selectorListMatchesPseudoElement):
(WebCore::CSSParserSelector::matchesPseudoElement):
Matching pseudo elements does not make much sense for those selectorList (e.g. :nth-child(2n of ::before)).
Add helper function to fail parsing of those cases.

  • css/CSSParserValues.h:
  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:

(WebCore::CSSSelector::selectorList):
Updated serialization code for CSS OM.

LayoutTests:

  • fast/css/parsing-css-nth-child-of-expected.txt: Added.
  • fast/css/parsing-css-nth-child-of.html: Added.

Two new tests to cover the new syntax.

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:

The usual tests for CSS OM.

1:01 PM Changeset in webkit [173697] by benjamin@webkit.org
  • 9 edits
    6 adds in trunk

CSS value in whitespace-separated list attribute selector (~=) mishandles tab/newline/etc.
​https://bugs.webkit.org/show_bug.cgi?id=136807

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-17
Reviewed by Antti Koivisto.

Source/WebCore:

The spec defines selector lists as token separated by white space.

The definition of white space for CSS Selectors is:
"White space in Selectors consists of the code points SPACE (U+0020),
TAB (U+0009), LINE FEED (U+000A), CARRIAGE RETURN (U+000D), and FORM FEED (U+000C)
can occur in whitespace. Other space-like code points, such as EM SPACE (U+2003)
and IDEOGRAPHIC SPACE (U+3000), are never part of white space."

The old code was only matching SPACE (U+0020) which is buggy. This patch
adds support for the other caracters.

Tests: fast/selectors/attr-list-01.html

fast/selectors/attribute-list-with-whitespace-in-selector.html
fast/selectors/attribute-list-with-whitespace-in-value.html

  • css/SelectorChecker.cpp:

(WebCore::attributeValueMatches):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::attributeValueSpaceSeparetedListContains):
Add the missing checks.

  • html/track/VTTRegion.cpp:

(WebCore::VTTRegion::setRegionSettings):
(WebCore::VTTRegion::parseSettingValue):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::hasRequiredFileIdentifier):
(WebCore::WebVTTParser::collectTimingsAndSettings):

  • html/track/WebVTTParser.h:

While looking for affected code, I discovered WebVTT redefines isHTMLSpace().
I cleaned that code.

Source/WTF:

  • wtf/text/AtomicString.h:

(WTF::AtomicString::find):

LayoutTests:

  • fast/selectors/attr-list-01-expected.html: Added.
  • fast/selectors/attr-list-01.html: Added.

This test is from a similar fix from Opera for the blink fork.
Review URL: ​https://chromiumcodereview.appspot.com/14980012
No other part of that patch is included.

  • fast/selectors/attribute-list-with-whitespace-in-selector-expected.txt: Added.
  • fast/selectors/attribute-list-with-whitespace-in-selector.html: Added.

Test whitespace characters in the selector itself.

  • fast/selectors/attribute-list-with-whitespace-in-value-expected.txt: Added.
  • fast/selectors/attribute-list-with-whitespace-in-value.html: Added.

Test whitespace characters in the attribute value.

11:27 AM Changeset in webkit [173696] by barraclough@apple.com
  • 11 edits in trunk/Source

Aways have a PageThrottler (sometimes have a UserActivity::Impl)
​https://bugs.webkit.org/show_bug.cgi?id=136892

Reviewed by Geoffrey Garen.

Some instances of Page have a PageThrottler to track activity on the Page, and some do not.
(Specifically, those created from WebPage in WK2 do, those related to WK1, SVG & inspector do not).

We do this for three reasons:

  • We do not need to take AppNap assertions on WK1.
  • Some Pages do not track their visibility correctly, and would always claim to be visible.
  • Page VisibilityState is not set until after construction, so if we instantiate

Creating the entire PageThrottler lazily has the drawback that we have to check for its existence at
numerous points throughout the code, and we'll miss activity that occurs between the Page being created
& the PageThrottler added to it (really a theoretical problem right now, since they're currently always
created pretty much back to back).

Instead, Page should always have a PageThrottler, & instead make the UserActivity::Impl on the
PageThrottler be added later.

Source/WebCore:

  • WebCore.exp.in:
    • createPageThrottler -> enablePageThrottler
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • Page::pageThrottler now returns a reference rather than a pointer
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::started):

  • Page::pageThrottler now returns a reference rather than a pointer
  • page/Page.cpp:

(WebCore::Page::Page):

  • instantiate PageThrottler in constructor

(WebCore::Page::enablePageThrottler):

  • renamed from createPageThrottler, instead of creating the PageThrottler this method now instruct PageThrottler to create a UserActivity::Impl

(WebCore::Page::setViewState):

  • m_pageThrottler is not a pointer

(WebCore::Page::createPageThrottler): Deleted.

  • renamed to enablePageThrottler
  • page/Page.h:

(WebCore::Page::pageThrottler):

  • now returns a reference
  • page/PageThrottler.cpp:

(WebCore::PageThrottler::PageThrottler):

  • no longer instantiate m_activity

(WebCore::PageThrottler::createUserActivity):

  • lazily instantiate m_activity, call updateUserActivity

(WebCore::PageThrottler::updateUserActivity):

  • m_activity may not yet be instantiated; added early return
  • page/PageThrottler.h:
    • m_activity becomes a std::unique_ptr, added createUserActivity

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::evaluate):

  • createPageThrottler -> enablePageThrottler
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):

  • Page::pageThrottler now returns a reference rather than a pointer
11:18 AM Changeset in webkit [173695] by dbates@webkit.org
  • 69 edits
    27 copies
    6 adds in trunk

[iOS] Make WebCore build with public iOS SDK
​https://bugs.webkit.org/show_bug.cgi?id=136487

Reviewed by David Kilzer.

Source/WebCore:

Add headers that wrap Mac and iOS SPIs and update WebCore source files to include these
headers instead of the corresponding actual SPI header(s).

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.vcxproj/WebCoreCG.props:
  • WebCore.vcxproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMInternal.mm:
  • bridge/objc/objc_instance.mm:
  • platform/audio/ios/MediaSessionManagerIOS.mm:
  • platform/cocoa/DisplaySleepDisablerCocoa.cpp:
  • platform/cocoa/MemoryPressureHandlerCocoa.mm:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:
  • platform/graphics/cg/BitmapImageCG.cpp:
  • platform/graphics/cg/ColorCG.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageSourceCG.cpp:
  • platform/graphics/cg/PDFDocumentImage.cpp:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:
  • platform/graphics/ios/FontCacheIOS.mm:
  • platform/graphics/ios/FontServicesIOS.mm:
  • platform/graphics/ios/SimpleFontDataIOS.mm:
  • platform/graphics/mac/FontMac.mm:
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
  • platform/graphics/mac/MediaPlayerProxy.h:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/ios/LegacyTileCache.mm:
  • platform/ios/LegacyTileGrid.mm:
  • platform/ios/LegacyTileGridTile.mm:
  • platform/ios/PlatformEventFactoryIOS.mm:
  • platform/ios/PlatformScreenIOS.mm:
  • platform/ios/WebEvent.mm:
  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
  • platform/ios/wak/WAKAppKitStubs.h:
  • platform/ios/wak/WAKView.h:
  • platform/ios/wak/WKGraphics.h:
  • platform/ios/wak/WKGraphics.mm:
  • platform/ios/wak/WebCoreThread.mm:
  • platform/network/ios/QuickLook.mm:
  • platform/spi/ca/CALayerSPI.h: Added.
  • platform/spi/ca/CATiledLayerSPI.h: Added.
  • platform/spi/cf/CFLocaleSPI.h: Modified to use EXTERN_C.
  • platform/spi/cf/CFNetworkConnectionCacheSPI.h: Ditto. Also changed header visibility from private to project.
  • platform/spi/cf/CFURLRequestSPI.h: Ditto. Also modified to unconditionally include header <CoreFoundation/CFBase.h>.
  • platform/spi/cg/CGColorTransformSPI.h: Added.
  • platform/spi/cg/CGContextSPI.h: Added.
  • platform/spi/cg/CGFloatSPI.h: Added.
  • platform/spi/cg/CGFontGlyphSupportSPI.h: Added.
  • platform/spi/cg/CGFontInfoSPI.h: Added.
  • platform/spi/cg/CGFontRenderingSPI.h: Added.
  • platform/spi/cg/CGFontUnicodeSupportSPI.h: Added.
  • platform/spi/cg/CGImageSPI.h: Added.
  • platform/spi/cg/CGSRegionSPI.h: Added.
  • platform/spi/cocoa/DispatchSPI.h: Added.
  • platform/spi/cocoa/IOPMLibSPI.h: Added.
  • platform/spi/cocoa/MachVMSPI.h: Added.
  • platform/spi/cocoa/NSFileManagerSPI.h: Added.
  • platform/spi/cocoa/NSGeometrySPI.h: Added.
  • platform/spi/cocoa/NSPointerFunctionsSPI.h: Added.
  • platform/spi/cocoa/dyldSPI.h: Added.
  • platform/spi/ios/AVPlayerControllerSPI.h: Added.
  • platform/spi/ios/AVPlayerViewControllerSPI.h: Added.
  • platform/spi/ios/AVValueTimingSPI.h: Added.
  • platform/spi/ios/AVVideoLayerSPI.h: Added.
  • platform/spi/ios/CTFontDescriptorSPI.h: Added.
  • platform/spi/ios/CTFontSPI.h: Added.
  • platform/spi/ios/CUICatalogSPI.h: Added.
  • platform/spi/ios/CUIStyleEffectConfigurationSPI.h: Added.
  • platform/spi/ios/MPAVRoutingControllerSPI.h: Added.
  • platform/spi/ios/MobileGestaltSPI.h: Added.
  • platform/spi/ios/QLPreviewConverterSPI.h: Added.
  • platform/spi/ios/QuickLookSPI.h: Added.
  • rendering/RenderThemeIOS.mm:

Source/WebKit/ios:

Substitute <WebCore/CGFloatSPI.h> for <CoreGraphics/CGFloat.h>.

  • WebCoreSupport/WebFixedPositionContent.mm:

Source/WebKit/mac:

Update WebKit1 source files to include the wrapper SPI headers instead of the corresponding
actual SPI header(s).

  • DOM/WebDOMOperationsPrivate.h:
  • MigrateHeaders.make: Modified to only modify the include path of a "<WebCore/"-prefixed header

file if its filename doesn't end in "SPI.h" as an alternative to having MigrateHeaders.make copy
such files into the WebKit framework as private headers.

  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebInspector/WebNodeHighlight.mm:
  • WebView/WebIndicateLayer.mm:
  • WebView/WebRenderLayer.h:
  • WebView/WebView.mm:

Source/WebKit2:

Update WebKit2 source files to include the wrapper SPI headers instead of the corresponding
actual SPI header(s).

  • Platform/mac/SharedMemoryMac.cpp:
  • Shared/ios/NativeWebTouchEventIOS.mm:
  • Shared/mac/RemoteLayerBackingStore.mm:
  • Shared/mac/RemoteLayerTreePropertyApplier.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/ios/WKPDFPageNumberIndicator.mm:
  • UIProcess/ios/WKScrollView.mm:
  • UIProcess/ios/WebMemoryPressureHandlerIOS.mm:
  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
  • WebProcess/WebPage/WebPage.cpp:

Source/WTF:

Define convenience macro EXTERN_C that can be used to specify the C linkage convention
for a declaration. For example, the declaration "EXTERN_C const int x;" will expand to:

extern const int x;

and

extern "C" const int x;

when used in a C and C++ file, respectively.

  • wtf/Compiler.h:

Tools:

Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.

  • DumpRenderTree/mac/CheckedMalloc.cpp:
10:00 AM Changeset in webkit [173694] by barraclough@apple.com
  • 12 edits in trunk/Source

DOM timer throttling for hidden plugins
​https://bugs.webkit.org/show_bug.cgi?id=136197

Patch by Gavin Barraclough <​barraclough@apple.com> on 2014-09-17
Reviewed by Geoff Garen & Andreas Kling.

For non-visible web pages we slow timers (since they can't be driving animations, etc).
We should do the same for plugins.

Source/WebCore:

There are a few steps to this:

  • JSPluginElementFunctions notifies DOMTimer when script interacts with a plugin.
  • DOMTimerFireState keeps a record of events that occur while a timer is firing.
  • DOMTimer::fired detects timers that interact with invisible/inaudible plugins, and flags itself for throtting.
  • DOMTimer::intervalClampedToMinimum sets timer intervals appropriately.
  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginScriptObject):

  • notify DOMTimer when script interacts with a plugin.
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::isDetectable):

  • html/HTMLPlugInElement.h:
    • added isDetectable, to check for visible / audible plugins.
  • page/DOMTimer.cpp:

(WebCore::DOMTimerFireState::DOMTimerFireState):
(WebCore::DOMTimerFireState::~DOMTimerFireState):

  • track current DOMTimerFireState.

(WebCore::DOMTimer::DOMTimer):

  • initialize m_throttleState.

(WebCore::DOMTimer::scriptDidInteractWithPlugin):

  • if interaction with a plugin occurs while a timer is firing, record on the DOMTimerFireState.

(WebCore::DOMTimer::fired):

  • set DOMTimerFireState, and update m_throttleState accordingly.

(WebCore::DOMTimer::updateTimerIntervalIfNecessary):

  • remove redundant check of maxTimerNestingLevel (covered by intervalClampedToMinimum).

(WebCore::DOMTimer::intervalClampedToMinimum):

  • Also take m_throttleState into account when throttling.
  • page/DOMTimer.h:
    • added scriptDidInteractWithPlugin, m_throttleState.
  • platform/audio/AudioHardwareListener.h:
    • enum -> enum class.
  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::audioHardwareActivity):

  • expose audioHardwareActivity on PluginViewBase (previously available in subclass).

Source/WebKit2:

  • PluginProcess/WebProcessConnection.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
    • remove now redundant includes.
  • WebProcess/Plugins/PluginView.h:
    • audioHardwareActivity is now virtual, override.
9:32 AM Changeset in webkit [173693] by barraclough@apple.com
  • 4 edits in trunk/Source/WebCore

Exclude page visibility from PageThrottler's hysteresis
​https://bugs.webkit.org/show_bug.cgi?id=136866

Reviewed by Geoff Garen.

Including visibility in the hysteresis mechanism has the effect of prolonging the visually
idle timeout, and causing the page hide event to be run at foreground priority. Neither of
these are particularly desirable. Instead separate visibility from the rest of the page
activities we track (and apply hysteresis to), and feed this directly into determination
of the UserActivity state.

  • page/PageThrottler.cpp:

(WebCore::PageThrottler::PageThrottler):

  • when the PageThrottler is instantiated call updateUserActivity to set initial UserActivity.

(WebCore::PageThrottler::incrementActivityCount):

  • simplified - when m_activityCount becomes non-zero, start m_hysteresis.

(WebCore::PageThrottler::decrementActivityCount):

  • simplified - when m_activityCount becomes zero, stop m_hysteresis.

(WebCore::PageThrottler::updateUserActivity):

  • end the UserActivity (allow AppNap) if visually idle and no page activity is taking place.

(WebCore::PageThrottler::setViewState):

  • when the visually idle state changed call updateUserActivity to update the UserActivity.

(WebCore::PageThrottler::started):
(WebCore::PageThrottler::stopped):

  • when the hysteresis state changed call updateUserActivity to update the UserActivity.

(WebCore::PageThrottler::updateHysteresis): Deleted.

  • removed: simplified the hysteresis trigger, we now incorporate visually idle state in updateUserActivity.
  • page/PageThrottler.h:
    • removed updateHysteresis, added updateUserActivity.
  • platform/HysteresisActivity.h:

(WebCore::HysteresisActivity::state):

  • determine the curent state of the HysteresisActivity - started, waiting, or stopped.
9:12 AM Changeset in webkit [173692] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Fix runtime critical warnings when writing to the clipboard after r173687
​https://bugs.webkit.org/show_bug.cgi?id=136891

Reviewed by Philippe Normand.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::writeClipboardContents): Check passed
callback is not null before trying to ref/unref it since
g_closure_ref/unref are not null safe.

9:11 AM Changeset in webkit [173691] by Carlos Garcia Campos
  • 7 edits in trunk

[GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
​https://bugs.webkit.org/show_bug.cgi?id=136889

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

We were passing a host for two different reasons, first because
it's more convenient to add an exception with
webkit_web_context_allow_tls_certificate_for_host(), but also
because we were assuming the active URI is the failing URI in case
of failure. This assumption is correct because our current code
does that, but I'm not sure we are doing it on purpose. That
behaviour is not documented anywhere and it's not what WebKit2 does
internaly.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):
(webkitWebViewLoadFailedWithTLSErrors):

  • UIProcess/API/gtk/WebKitWebView.h:

Tools:

  • TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
event was added to the events vector.

  • TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:

(loadFailedCallback): Do not assume the web view URI is the
failing URI when the load fails before the committed state.
(loadFailedWithTLSErrorsCallback): Handle the case of load failure
because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
(LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
(LoadTrackingTest::loadFailedWithTLSErrors): Add
LoadFailedWithTLSErrors event to the events vector.

  • TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
5:35 AM Changeset in webkit [173690] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[GTK] Add a helper function for display system deduction
​https://bugs.webkit.org/show_bug.cgi?id=136849

Reviewed by Martin Robinson.

getDisplaySystemType() is a helper function that checks the type of the
default GdkDisplay object and initializes a static variable to the
corresponding value. It then returns the value of that variable.

When building with the GTK+2 API (still the case with the GTK+2 plugin
process) we default to X11.

The function is declared and implemented in GtkUtilities files.

  • platform/gtk/GtkUtilities.cpp:

(WebCore::widgetIsOnscreenToplevelWindow):
(WebCore::getDisplaySystemType):

  • platform/gtk/GtkUtilities.h:
2:29 AM Changeset in webkit [173689] by commit-queue@webkit.org
  • 13 edits in trunk

[EFL][GTK] Remove WebKit1 related codes
​https://bugs.webkit.org/show_bug.cgi?id=136853

Patch by Renato Nagy <​rnagy@inf.u-szeged.hu> on 2014-09-17
Reviewed by Csaba Osztrogonác.

Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
from scripts.

.:

  • Source/PlatformGTK.cmake:

Tools:

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Compile32bitJSC):
(BuildAndTestWebKit2Factory):
(CompileWebKit1Only): Deleted.
(CompileWebKit2Only): Deleted.
(BuildAndTestWebKit1OnlyFactory): Deleted.
(BuildAndTestWebKit2OnlyFactory): Deleted.

  • Scripts/build-webkit:
  • Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
  • Scripts/webkitpy/common/config/ports.py:

(GtkWK2Port.build_webkit_command):
(EflWK2Port.build_webkit_command):

  • Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_wk2_port):

  • Scripts/webkitpy/port/efl.py:

(EflPort.build_webkit_command):

  • Scripts/webkitpy/port/gtk.py:

(GtkPort._built_libraries_path):
(GtkPort._search_paths):
(GtkPort.test_expectations_file_position):
(GtkPort.build_webkit_command):
(GtkPort.run_webkit_tests_command):
(GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.

1:54 AM Changeset in webkit [173688] by Yusuke Suzuki
  • 3 edits
    2 adds in trunk

filterRootById accidentally clears inAdjacentChain flag
​https://bugs.webkit.org/show_bug.cgi?id=136851

Reviewed by Benjamin Poulain.

Source/WebCore:

Test: fast/selectors/filter-root-node-with-selector-contains-adjacents.html

  • dom/SelectorQuery.cpp:

(WebCore::filterRootById):

LayoutTests:

When SubSelector comes, inAdjacentChain flag is cleared to false.
So for example, document.querySelector("span#id + ok") doesn't work correctly.
In this patch, we handles SubSelector relation correctly; don't change inAdjacentChain flag
to filter the right search root node.

  • fast/selectors/filter-root-node-with-selector-contains-adjacents-expected.txt: Added.
  • fast/selectors/filter-root-node-with-selector-contains-adjacents.html: Added.
12:05 AM Changeset in webkit [173687] by Carlos Garcia Campos
  • 15 edits
    2 adds in trunk/Source

[GTK] Fix layering violations in PasteboardGtk
​https://bugs.webkit.org/show_bug.cgi?id=136802

Reviewed by Darin Adler.

Source/WebCore:

Refactor the Pasteboard code moving the WebCore parts to the Editor.

  • PlatformGTK.cmake: Add new file to compilation.
  • editing/Editor.cpp:

(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::copyImage):

  • editing/Editor.h:
  • editing/gtk/EditorGtk.cpp: Added.

(WebCore::createFragmentFromPasteBoardData):
(WebCore::Editor::pasteWithPasteboard):
(WebCore::getImageAndURLForElement):
(WebCore::Editor::writeImageToPasteboard):
(WebCore::Editor::writeSelectionToPasteboard):

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

  • page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::declareAndWriteDragImage):

  • platform/Pasteboard.h:
  • platform/gtk/DataObjectGtk.cpp: Remove range member, the caller

should call setText() + setMarkup() intead.
(WebCore::DataObjectGtk::setText):
(WebCore::DataObjectGtk::setMarkup):
(WebCore::DataObjectGtk::clearText):
(WebCore::DataObjectGtk::clearMarkup):
(WebCore::DataObjectGtk::clearAllExceptFilenames):

  • platform/gtk/DataObjectGtk.h:

(WebCore::DataObjectGtk::hasText):
(WebCore::DataObjectGtk::hasMarkup):
(WebCore::DataObjectGtk::clearImage):
(WebCore::DataObjectGtk::text):
(WebCore::DataObjectGtk::markup):
(WebCore::DataObjectGtk::setRange): Deleted.

  • platform/gtk/GtkDragAndDropHelper.h:
  • platform/gtk/PasteboardGtk.cpp:

(WebCore::PasteboardImage::PasteboardImage):
(WebCore::PasteboardImage::~PasteboardImage):
(WebCore::Pasteboard::write):
(WebCore::Pasteboard::writeSelection): Deleted.
(WebCore::getURLForImageElement): Deleted.
(WebCore::Pasteboard::writeImage): Deleted.
(WebCore::Pasteboard::documentFragment): Deleted.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::displayFromFrame): Deleted.
(WebCore::PasteboardHelper::getPrimarySelectionClipboard): Deleted.

  • platform/gtk/PasteboardHelper.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::updateGlobalSelection): Use new API to
update the global selection.

Sep 16, 2014:

11:27 PM Changeset in webkit [173686] by Carlos Garcia Campos
  • 15 edits in trunk/Source

DragData should not depend on Clipboard, DocumentFragment, and Document
​https://bugs.webkit.org/show_bug.cgi?id=21358

Reviewed by Darin Adler.

Source/WebCore:

Refactor DragData to not depend on Frame, DocumentFragment,
Document and Range. DragData::asFragment() has been moved to
DragController and implemented in the platform specific file.
DragData methods using Frame has been reworked in Mac to not use
Frame, since all other ports were ignoreing the frame parameter.

  • page/DragController.cpp:

(WebCore::DragController::documentFragmentFromDragData): Make it
a static member to be able to use createFragmentFromDragData().
(WebCore::DragController::performDragOperation): Update to
DragData API changes.
(WebCore::DragController::dispatchTextInputEventFor): Ditto.
(WebCore::DragController::concludeEditDrag): Ditto.
(WebCore::documentFragmentFromDragData): Deleted.

  • page/DragController.h:
  • page/efl/DragControllerEfl.cpp:

(WebCore::DragController::createFragmentFromDragData): Move
DragData::asFragment() implementation here.

  • page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::dragOperation):
(WebCore::DragController::createFragmentFromDragData): Ditto.

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::dragOperation):
(WebCore::DragController::createFragmentFromDragData): Ditto.

  • page/win/DragControllerWin.cpp:

(WebCore::DragController::createFragmentFromDragData): Ditto.

  • platform/DragData.h:
  • platform/efl/DragDataEfl.cpp:

(WebCore::DragData::asPlainText): Remove Frame parameter.
(WebCore::DragData::containsURL): Ditto.
(WebCore::DragData::asURL): Ditto.
(WebCore::DragData::asFragment): Deleted.

  • platform/gtk/DragDataGtk.cpp:

(WebCore::DragData::asPlainText): Remove Frame parameter.
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsURL): Ditto.
(WebCore::DragData::asURL): Ditto.
(WebCore::DragData::asFragment): Deleted.

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::asPlainText): Same implementation as the
Editor.
(WebCore::DragData::containsURL): Remove Frame parameter.
(WebCore::DragData::asURL): Use URLByCanonicalizingURL() instead
of using the Editor client.
(WebCore::DragData::asFragment): Deleted.

  • platform/win/DragDataWin.cpp:

(WebCore::DragData::containsURL): Remove Frame parameter.
(WebCore::DragData::asURL): Ditto.
(WebCore::DragData::asPlainText): Ditto.
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment): Deleted.

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performDragControllerAction): Update to API
change in DragData::asURL().

9:32 PM Changeset in webkit [173685] by fpizlo@apple.com
  • 4 edits in trunk/Source

Unreviewed, disable native inlining because it causes build failures.

Source/JavaScriptCore:

Source/WTF:

  • wtf/Platform.h:
7:00 PM Changeset in webkit [173684] by Chris Dumez
  • 21 edits in trunk/Source/WebCore

Rename Node::childNode(index) to traverseToChildAt(index) for clarity
​https://bugs.webkit.org/show_bug.cgi?id=136825

Reviewed by Benjamin Poulain.

Rename Node::childNode(index) to traverseToChildAt(index) to make it
clearer that the method is actually traversing the children and thus
potentially expensive.

This patch also avoids calling traverseToChildAt() in a couple of
easily avoidable cases.

No new tests, no behavior change.

  • WebCore.exp.in:
  • WebCore.order:

Remove symbol for ContainerNode::childNode() as it was renamed. It does
not seem we need to expose ContainerNode::traverseToChildAt().

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::stringForVisiblePositionRange):
(WebCore::AccessibilityObject::lengthForVisiblePositionRange):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
Mechanical renaming.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::traverseToChildAt):
(WebCore::ContainerNode::childNode): Deleted.

  • dom/ContainerNode.h:

(WebCore::Node::traverseToChildAt):
(WebCore::Node::childNode): Deleted.

  • dom/Node.h:
  • Rename Node / ContainerNode's childNode(index) to traverseToChildAt(index) to make it clear that it is actually traversing the children and thus potentially expensive.
  • Clean up the implementation of ContainerNode::traverseToChildAt() to avoid the use of an extra |i| variable.
  • dom/Position.cpp:

(WebCore::Position::computeNodeBeforePosition):
Avoid calling traverseToChildAt(-1). Relying on the unsigned argument
wrapping and the method returning null in this case is a bit obscure
and causes unnecessary traversal of all children.

(WebCore::Position::computeNodeAfterPosition):
(WebCore::Position::previous):
(WebCore::Position::next):
Mechanical renaming and update variable names to stop using
abbreviations as per coding style.

  • dom/PositionIterator.h:

(WebCore::PositionIterator::PositionIterator):

  • dom/Range.cpp:

(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::firstNode):
(WebCore::Range::pastLastNode):

  • dom/RangeBoundaryPoint.h:

(WebCore::RangeBoundaryPoint::set):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::removeChildrenInRange):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/TextIterator.cpp:

(WebCore::nextInPreOrderCrossingShadowBoundaries):
(WebCore::TextIterator::node):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):

  • editing/VisibleUnits.cpp:

(WebCore::nextLinePosition):

  • editing/cocoa/HTMLConverter.mm:

(WebCore::editingAttributedStringFromRange):
Mechanical renaming.

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::innerPatchChildren):
Iterate over children while incrementing the |i| variable to avoid
calling traverseToChildAt(index) repeatedly and thus traversing the
children from the beginning every time.

5:49 PM Changeset in webkit [173683] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Web Inspector: Reduce a bit of churn setting initial remote inspection state
​https://bugs.webkit.org/show_bug.cgi?id=136875

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-16
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • API/JSContextRef.cpp:

(JSGlobalContextCreateInGroup):
Set the defaultl remote debuggable state at the API boundary.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
Do not set remote debuggable state here. Let clients set it.

Source/WebCore:

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::finishCreation):
We no longer need to toggle this state.

5:48 PM Changeset in webkit [173682] by enrica@apple.com
  • 7 edits in trunk/Source/WebCore

Should have an editing behavior specific for IOS.
​https://bugs.webkit.org/show_bug.cgi?id=136876

Reviewed by Sam Weinig.

This patch introduces a new editing behavior type to be able
to perform editing tasks that are specific to iOS.
All the existing EditingBehavior methods return the same boolean
value for for Mac and iOS. A new one has been introduced to support
a specific behavior in the DeleteSelectionCommand.

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::doApply):

  • editing/EditingBehavior.h:

(WebCore::EditingBehavior::shouldConsiderSelectionAsDirectional):
(WebCore::EditingBehavior::shouldCenterAlignWhenSelectionIsRevealed):
(WebCore::EditingBehavior::shouldToggleStyleBasedOnStartOfSelection):
(WebCore::EditingBehavior::shouldAlwaysGrowSelectionWhenExtendingToBoundary):
(WebCore::EditingBehavior::shouldSelectOnContextualMenuClick):
(WebCore::EditingBehavior::shouldExtendSelectionByWordOrLineAcrossCaret):
(WebCore::EditingBehavior::shouldRebalanceWhiteSpacesInSecureField):

  • editing/EditingBehaviorTypes.h:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::positionForPlatform):

  • page/Settings.cpp:

(WebCore::editingBehaviorTypeForPlatform):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setEditingBehavior):

5:32 PM Changeset in webkit [173681] by Yusuke Suzuki
  • 8 edits
    2 deletes in trunk

Promise: Drop Promise.cast
​https://bugs.webkit.org/show_bug.cgi?id=136222

Reviewed by Sam Weinig.

Promise.cast is dropped and Promise.resolve is replaced with old Promise.cast.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:
  • runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructorFuncResolve):
(JSC::JSPromiseConstructorFuncRace):
(JSC::JSPromiseConstructorFuncAll):
(JSC::JSPromiseConstructorFuncCast): Deleted.

LayoutTests:

  • js/dom/Promise-static-cast-expected.txt: Removed.
  • js/dom/Promise-static-cast.html: Removed.
  • js/dom/Promise-static-resolve-expected.txt:
  • js/dom/Promise-static-resolve.html:
  • js/dom/Promise-types-expected.txt:
  • js/dom/Promise-types.html:
4:47 PM Changeset in webkit [173680] by commit-queue@webkit.org
  • 2 edits
    5 adds in trunk/Source/WebInspectorUI

Web Inspector: Add Versioned Inspector protocol JSON files for iOS 8.0
​https://bugs.webkit.org/show_bug.cgi?id=136873

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-16
Reviewed by Timothy Hatcher.

  • Scripts/update-LegacyInspectorBackendCommands.rb:
  • UserInterface/Protocol/Legacy/8.0/InspectorJSBackendCommands.js: Added.
  • UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js: Added.
  • Versions/InspectorJS-iOS-8.0.json: Added.
  • Versions/InspectorWeb-iOS-8.0.json: Added.
4:32 PM Changeset in webkit [173679] by enrica@apple.com
  • 2 edits
    3 adds
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r173670.
​https://bugs.webkit.org/show_bug.cgi?id=136871

Creates layering violation (Requested by enrica on #webkit).

Reverted changeset:

"Move HTMLConverter from editing/cocoa to platform/cocoa."
​https://bugs.webkit.org/show_bug.cgi?id=136474
​http://trac.webkit.org/changeset/173670

Patch by Commit Queue <​commit-queue@webkit.org> on 2014-09-16

4:27 PM Changeset in webkit [173678] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Mac] MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput doesn't work with rotated movies
​https://bugs.webkit.org/show_bug.cgi?id=136872

Patch by Eric Carlson <​eric.carlson@apple.com> on 2014-09-16
Reviewed by Tim Horton.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator): Add logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): Apply the video track

preferred transform.

4:12 PM Changeset in webkit [173677] by Brent Fulgham
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

[Mac] MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput doesn't work with rotated movies
​https://bugs.webkit.org/show_bug.cgi?id=136872

Patch by Eric Carlson <​eric.carlson@apple.com> on 2014-09-16
Reviewed by Tim Horton.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator): Add logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): Apply the video track

preferred transform.

3:53 PM Changeset in webkit [173676] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r173635

3:37 PM Changeset in webkit [173675] by ggaren@apple.com
  • 7 edits in trunk/Source/bmalloc

bmalloc: moved line caches from the deallocator to the allocator
​https://bugs.webkit.org/show_bug.cgi?id=136868

Reviewed by Gavin Barraclough.

I did this mostly as a simplification, to make it easier to change the
allocation strategy.

No throughput change on MallocBench. Saves about 50kB.

Since the deallocator needs to lock the heap when freeing lines anyway,
there isn't much benefit to giving the deallocator a local cache of
deallocated lines.

We still give the allocator a local cache of lines because that does
reduce the frequency at which it needs to lock the heap in order to
acquire more lines.

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::scavenge):
(bmalloc::Allocator::allocateSmallLine):
(bmalloc::Allocator::allocateMediumLine):
(bmalloc::Allocator::allocateMedium):
(bmalloc::Allocator::allocateSlowCase):

  • bmalloc/Allocator.h:
  • bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::Deallocator):
(bmalloc::Deallocator::scavenge):
(bmalloc::Deallocator::processObjectLog):
(bmalloc::Deallocator::deallocateSmallLine): Deleted.
(bmalloc::Deallocator::allocateSmallLine): Deleted.
(bmalloc::Deallocator::deallocateMediumLine): Deleted.
(bmalloc::Deallocator::allocateMediumLine): Deleted.

  • bmalloc/Deallocator.h:
  • bmalloc/Sizes.h:
  • bmalloc/VMAllocate.h: Took the opportunity to make the line cache size

exactly one page in size. That's about what we were shooting for anyway,
and it may make it easier to switch to per-page allocation in future.

3:36 PM Changeset in webkit [173674] by mmaxfield@apple.com
  • 4 edits in trunk/LayoutTests

Make spelling tests more reliable by using a word that is misspelled everywhere
​https://bugs.webkit.org/show_bug.cgi?id=136865

Reviewed by Simon Fraser.

Some platforms recognize "wellcome" as spelled correctly.

  • editing/spelling/context-menu-suggestions.html:
  • editing/spelling/spelling-with-punctuation-selection-expected.txt:
  • editing/spelling/spelling-with-punctuation-selection.html:
3:29 PM Changeset in webkit [173673] by dbates@webkit.org
  • 8 edits in trunk

[iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
​https://bugs.webkit.org/show_bug.cgi?id=136862

Reviewed by David Kilzer.

Source/WebKit/mac:

  • Configurations/DebugRelease.xcconfig:

Source/WebKit2:

  • Configurations/DebugRelease.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0

IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.

3:18 PM Changeset in webkit [173672] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Local OSR availability calculation should be reusable
​https://bugs.webkit.org/show_bug.cgi?id=136860

Reviewed by Oliver Hunt.

Previously, the FTL lowering repeated some of the logic of the OSR availability analysis
phase. Humorously, it actually did this logic a bit differently; for example the phase
would claim that a SetLocal makes both the flush and the node available while the FTL
only claimed that the flush was available. This different was benign, but still: yuck!

Also, previously if you wanted to use availability information then you'd have to repeat
some of the logic that both the phase itself and the FTL lowering already had.
Presumably, you could get epic style points for finding other benign ways in which to
make your copy of the logic different from the other two!

This reduces the amount of style points one could conceivably get in the future when
hacking JSC, by creating a single reusable thingy for computing local OSR availability.

  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
(JSC::DFG::LocalOSRAvailabilityCalculator::LocalOSRAvailabilityCalculator):
(JSC::DFG::LocalOSRAvailabilityCalculator::~LocalOSRAvailabilityCalculator):
(JSC::DFG::LocalOSRAvailabilityCalculator::beginBlock):
(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

  • dfg/DFGOSRAvailabilityAnalysisPhase.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::availability):
(JSC::FTL::LowerDFGToLLVM::compileMovHint): Deleted.
(JSC::FTL::LowerDFGToLLVM::compileZombieHint): Deleted.
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock): Deleted.

3:14 PM Changeset in webkit [173671] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Mac queue slaves should reboot every so often
​https://bugs.webkit.org/show_bug.cgi?id=136791

Reviewed by Alexey Proskuryakov.

Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.

  • EWSTools/start-queue-mac.sh:
2:00 PM Changeset in webkit [173670] by enrica@apple.com
  • 2 edits
    2 copies
    1 delete in trunk/Source/WebCore

Move HTMLConverter from editing/cocoa to platform/cocoa.
​https://bugs.webkit.org/show_bug.cgi?id=136474

Reviewed by Benjamin Poulain.

This is a platform specific class and it belongs to the platform folder.

  • WebCore.xcodeproj/project.pbxproj:
  • editing/cocoa: Removed.
  • editing/cocoa/HTMLConverter.h: Removed.
  • editing/cocoa/HTMLConverter.mm: Removed.
  • platform/cocoa/HTMLConverter.h: Copied from editing/cocoa/HTMLConverter.h.
  • platform/cocoa/HTMLConverter.mm: Copied from editing/cocoa/HTMLConverter.mm.
1:38 PM Changeset in webkit [173669] by enrica@apple.com
  • 9 edits in trunk/Source

Remove PLATFORM(IOS) from WebCore/editing (Part 3).
​https://bugs.webkit.org/show_bug.cgi?id=136474

Reviewed by Benjamin Poulain.

This is the updated version of the patch that was landed in r173340.
This patch removes the use of PLATFORM(IOS) from TextAffinity.h
and removes the assumption that EAffinity values match NSSelectionAffinity
values. It also removes the includes in TextAffinity.h, creating the need to
include explicitly the files when necessary.

Source/WebCore:

  • editing/TextAffinity.h:

(kit): Deleted.
(core): Deleted.

  • editing/cocoa/HTMLConverter.mm:
  • page/mac/WebCoreFrameView.h:

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:

(kit):
(core):

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
  • WebProcess/WebPage/WKAccessibilityWebPageObjectIOS.mm:
1:32 PM Changeset in webkit [173668] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

overflow:scroll should not leave space for a scroll corner with overlay scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=136861

Reviewed by Sam Weinig.

overflow:scroll should behave like overflow:auto when the scrollbar will render as
an overlay scrollbar.

Re-name hasAutoVerticalScrollbar()/Horizontal to
hasVerticalScrollbarWithAutoBehavior()/Horizontal, and return true for
overflow:scroll scrollbars that will render as overlay scrollbars.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::hasVerticalScrollbarWithAutoBehavior):
(WebCore::RenderBox::hasHorizontalScrollbarWithAutoBehavior):

  • rendering/RenderBox.h:

(WebCore::RenderBox::scrollsOverflowX):
(WebCore::RenderBox::scrollsOverflowY):
(WebCore::RenderBox::hasAutoVerticalScrollbar): Deleted.
(WebCore::RenderBox::hasAutoHorizontalScrollbar): Deleted.

Re-name overflowRequiresScrollbar() to styleRequiresScrollbar() and also re-name
overflowDefinesAutomaticScrollbar() to styleDefinesAutomaticScrollbar(), and make
these functions take into account the fact that overflow:scroll should act like
overflow:auto when the scrollbar will render as an overlay scrollbar.

  • rendering/RenderLayer.cpp:

(WebCore::styleRequiresScrollbar):
(WebCore::styleDefinesAutomaticScrollbar):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::calculateClipRects):

12:54 PM Changeset in webkit [173667] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix ESLint no-extra-bind warnings
​https://bugs.webkit.org/show_bug.cgi?id=136659

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-16
Reviewed by Timothy Hatcher.

  • .eslintrc:
  • UserInterface/Controllers/LayerTreeManager.js:

(WebInspector.LayerTreeManager.prototype.layersForNode):

12:22 PM Changeset in webkit [173666] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Curl] Sometimes incomplete or empty content can be loaded from cache.
​https://bugs.webkit.org/show_bug.cgi?id=136855

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-09-16
Reviewed by Alex Christensen.

Sometimes, when two requests with the same url are started at the same time,
there is a possibility of loading incomplete or empty content from the cache.
This happens because the method CurlCacheEntry::isLoading() is returning the wrong status
in the time period between the headers are received, and the content data is received.
This can be fixed by using a flag for the load status, instead of checking whether
the content file is open.

  • platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::CurlCacheEntry): Initialize loading flag.
(WebCore::CurlCacheEntry::isLoading): Return loading flag.
(WebCore::CurlCacheEntry::didFail): Call new method to set loading flag.
(WebCore::CurlCacheEntry::didFinishLoading): Ditto.
(WebCore::CurlCacheEntry::setIsLoading): Added new method to set loading flag.

  • platform/network/curl/CurlCacheEntry.h: Added loading flag and new method to set it.
  • platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::didReceiveResponse): Call new method to set loading flag.

11:28 AM Changeset in webkit [173665] by Chris Dumez
  • 22 edits in trunk/Source/WebCore

Rename Node::nodeIndex() to computeNodeIndex() for clarity
​https://bugs.webkit.org/show_bug.cgi?id=136826

Reviewed by Benjamin Poulain.

Rename Node::nodeIndex() to computeNodeIndex() to make it clear that
index is being computed and that calling this method is potentially
expensive.

No new tests, no behavior change.

  • WebCore.exp.in:
  • WebCore.order:

Rename exported symbol for Node::nodeIndex() as well.

  • dom/Document.cpp:

(WebCore::Document::caretRangeFromPoint):

  • dom/Node.cpp:

(WebCore::Node::computeNodeIndex):
(WebCore::Node::nodeIndex): Deleted.

  • dom/Node.h:
  • dom/NodeWithIndex.h:

(WebCore::NodeWithIndex::index):
Clean up implementation to reduce the scope of the Node variable and
to follow coding style (variable naming, spacing, star placement).

  • dom/Position.cpp:

(WebCore::Position::computeOffsetInContainerNode):
(WebCore::Position::previous):
(WebCore::Position::next):
(WebCore::Position::upstream):
(WebCore::Position::downstream):

  • dom/Position.h:

(WebCore::positionInParentBeforeNode):
(WebCore::positionInParentAfterNode):

  • dom/Range.cpp:

(WebCore::Range::compareNode):
(WebCore::Range::intersectsNode):
(WebCore::Range::processContents):
(WebCore::Range::insertNode):
(WebCore::Range::setStartAfter):
(WebCore::Range::setEndBefore):
(WebCore::Range::setEndAfter):
(WebCore::Range::setStartBefore):

  • dom/RangeBoundaryPoint.h:

(WebCore::RangeBoundaryPoint::ensureOffsetIsValid):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):

  • editing/Editor.cpp:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::range):
(WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):

  • editing/htmlediting.cpp:

(WebCore::updatePositionForNodeRemoval):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::setContainerAndOffsetForRange):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::getRangeAt):
(WebCore::DOMSelection::containsNode):
(WebCore::DOMSelection::shadowAdjustedOffset):

  • rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries):

  • rendering/RenderTreeAsText.cpp:

(WebCore::nodePosition):

11:09 AM Changeset in webkit [173664] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Videos with controls enabled never receive 'dragstart' events.
​https://bugs.webkit.org/show_bug.cgi?id=136837

Reviewed by Eric Carlson.

Fixes a crash regression introduced by r173631. Node::contains() has an interesting property of returning false
if this is NULL. Rather than depending on this behavior, explicitly NULL-check state.source and bail early.

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

11:08 AM Changeset in webkit [173663] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed. Skip failing WebGL conformance test.

  • platform/win/TestExpectations:
11:00 AM Changeset in webkit [173662] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Standardized the return type of a delegate method.

Rubber-stamped by Anders Carlsson.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Changed a return type from bool to BOOL.
10:27 AM Changeset in webkit [173661] by Gustavo Noronha Silva
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[as] Updated Assamese translations of WebKitGtk+
​https://bugs.webkit.org/show_bug.cgi?id=136480

Patch by Nilamdyuti Goswami <​ngoswami@redhat.com> on 2014-09-16
Reviewed by Gustavo Noronha.

  • as.po: updated.
9:18 AM Changeset in webkit [173660] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

URTBF after r173659.

After r173659 convertToIntLength() is used only inside ENABLE(DASHBOARD_SUPPORT), so it
became unused function and caused build failure if ENABLE(DASHBOARD_SUPPORT) is false.

Source/WebCore/css/StyleResolver.cpp:1471:15: error: 'WebCore::Length WebCore::convertToIntLength(const WebCore::CSSPrimitiveValue*, const WebCore::CSSToLengthConversionData&)'
defined but not used [-Werror=unused-function] cc1plus: all warnings being treated as errors

  • css/StyleResolver.cpp: Missing ENABLE(DASHBOARD_SUPPORT) guard added.
8:58 AM Changeset in webkit [173659] by Darin Adler
  • 18 edits in trunk

Source/WebCore:
Scroll snap properties don't handle inherit and initial propertly.
​https://bugs.webkit.org/show_bug.cgi?id=136643

Reviewed by Beth Dakin.

Restructured scroll snap code both to handle inherit and initial, and to reduce the
total code size a bit, fixing a few minor bugs along the way. Updated the regression
tests to cover the new parts.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::addValuesForNamedGridLinesAtIndex): Use a modern for loop.
(WebCore::scrollSnapDestination): Changed to take a LengthSize. Also streamlined.
(WebCore::scrollSnapPoints): Changed to to take a ScrollSnapPoints. Also streamlined and
added code to handle the "uses elements" case; serialize that as an identifier, not the
string "elements", fixing a minor bug.
(WebCore::scrollSnapCoordinates): Changed to take a Vector<LengthSize>. Also streamlined
and added code to handle the empty vector case; serialize that as an identifier, not the
string "none", fixing a minor bug.
(WebCore::ComputedStyleExtractor::getFontSizeCSSValuePreferringKeyword): Use nullptr.
(WebCore::counterToCSSValue): Use nullptr.
(WebCore::ComputedStyleExtractor::styledNode): Use nullptr.
(WebCore::ComputedStyleExtractor::propertyValue): Use nullptr. Moved CSS_SCROLL_SNAP
to a more appropriate section of the switch statement. Made it just call through to
the functions above in a more straightforward way.
(WebCore::CSSComputedStyleDeclaration::getPropertyValue): Reversed logic to use early
return and to call emptyString.
(WebCore::CSSComputedStyleDeclaration::item): Use emptyString.
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForSidesShorthand): Use nullptr.
(WebCore::CSSComputedStyleDeclaration::parentRule): Use nullptr.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Use nullptr.
(WebCore::CSSComputedStyleDeclaration::getPropertyPriority): Use emptyString.
(WebCore::CSSComputedStyleDeclaration::getPropertyShorthand): Use emptyString.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyMarqueeIncrement::applyValue): Use the switch statement for the
invalid value as well as for the valid values, rather than a separate if statement.
Call convertToLength directly rather than through a StyleResolver static member function.

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue): Fixed a formatting mistake.

  • css/StyleResolver.cpp:

(WebCore::convertToIntLength): Made this function local to this file instead of a
static member function.
(WebCore::convertToFloatLength): Ditto.
(WebCore::StyleResolver::parseSnapCoordinate): Added. Used to keep snap point parsing
code small.
(WebCore::StyleResolver::parseSnapCoordinatePair): Ditto.
(WebCore::StyleResolver::parseSnapPoints): Added. Parses an entire snap points property.
(WebCore::StyleResolver::applyProperty): Removed various bits of redundant code that
were not using the primitiveValue value already in a local variable. Added the
HANDLE_INHERIT_AND_INITIAL to all the scroll snap properties and updated since the
RenderStyle structure now more closely matches the CSS properties.

  • css/StyleResolver.h: Updated for above changes, and removed a redundant "private:".
  • page/scrolling/AxisScrollSnapOffsets.cpp:

(WebCore::appendChildSnapOffsets): Use auto& instead of SnapCoordinate since that type
is now gone. Updated since coordinates are now LengthSize.
(WebCore::updateFromStyle): Changed to take a reference instead of a pointer and
also to fetch the data from RenderStyle in a new way that more closely matches the
CSS properties.
(WebCore::updateSnapOffsetsForScrollableArea): Ditto. Also moved some memory allocation
inside if statements so we don't wastefully allocate and destroy.

  • rendering/style/RenderStyle.cpp: Added an include of StyleScrollSnapPoints.h now

that the header doesn't include them. Moved the conditional includes out of the main
include paragraph (even though I don't think conditional includes are usually a good
idea).
(WebCore::RenderStyle::initialScrollSnapPointsX): Added.
(WebCore::RenderStyle::initialScrollSnapPointsY): Added.
(WebCore::RenderStyle::initialScrollSnapDestination): Added.
(WebCore::RenderStyle::initialScrollSnapCoordinates): Added.
(WebCore::RenderStyle::scrollSnapPointsX): Added.
(WebCore::RenderStyle::scrollSnapPointsY): Added.
(WebCore::RenderStyle::scrollSnapDestination): Added.
(WebCore::RenderStyle::scrollSnapCoordinates): Added.
(WebCore::RenderStyle::setScrollSnapPointsX): Added.
(WebCore::RenderStyle::setScrollSnapPointsY): Added.
(WebCore::RenderStyle::setScrollSnapDestination): Added.
(WebCore::RenderStyle::setScrollSnapCoordinates): Added.

  • rendering/style/RenderStyle.h: Replaced the include of StyleScrollSnapPoints.h with

a forward declaration of ScrollSnapPoints. Removed getters and setters for the old
style properties and replaced them with new ones that match the CSS properties more
closely. Tweaked formatting a bit. Added initial value functions for the the scroll snap
properties.

  • rendering/style/StyleRareNonInheritedData.cpp: Added include of StyleScrollSnapPoints.h

now that RenderStyle.h doesn't include it.
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Updated since
m_scrollSnapType is now unsigned instead of ScrollSnapType.

  • rendering/style/StyleRareNonInheritedData.h: Fixed type of m_scrollSnapType to be

unsigned instead of ScrollSnapType. This should have been causing problems on Windows,
but I think we got lucky and had no detectable problems.

  • rendering/style/StyleScrollSnapPoints.cpp:

(WebCore::ScrollSnapPoints::ScrollSnapPoints): Added.
(WebCore::operator==): Added overloads for both ScrollSnapPoints and also for
StyleScrollSnapPoints; using a free function for both since both have public data.
(WebCore::defaultScrollSnapDestination): Added, replaces a static member function.
(WebCore::StyleScrollSnapPoints::StyleScrollSnapPoints): Updated both the default
constructor and the copy constructor for the new design.

  • rendering/style/StyleScrollSnapPoints.h: Added a ScrollSnapPoints struct for the

type of the snap-points-x and snap-points-y CSS properties. Changed the data members
of StyleScrollSnapPoints to match the various CSS properties rather than breaking
out all the data into separate data members.
(WebCore::StyleScrollSnapPoints::defaultRepeatOffset): Deleted. Replaced by the
default constructor for ScrollSnapPoints.
(WebCore::StyleScrollSnapPoints::defaultDestinationOffset): Deleted. Replaced by
a function inside the .cpp file.

LayoutTests:
Scroll snap properties do not handle inherit and initial properly.
​https://bugs.webkit.org/show_bug.cgi?id=136643

Reviewed by Beth Dakin.

  • css3/scroll-snap/scroll-snap-property-computed-style-expected.txt: Added

expected passing results from new tests.

  • css3/scroll-snap/scroll-snap-property-computed-style.js: Added new test

cases that cover inherit and initial. Before, these would crash or fail.

  • css3/scroll-snap/scroll-snap-property-parsing-expected.txt: Added expected

passing results from new tests, and also updated to expect pass rather than
fail for the tests that had incorrect expected results.

  • css3/scroll-snap/scroll-snap-property-parsing.js: Added new test cases that

cover inherit and initial. Also updated expected results for certain pixel
repeat cases that were incorrect.

  • platform/mac/TestExpectations: Fixed an unrelated syntax error in this file.
5:36 AM Changeset in webkit [173658] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Typo in webkit_security_manager_register_uri_scheme_as_empty_document documentation
​https://bugs.webkit.org/show_bug.cgi?id=136852

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-09-16
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/WebKitSecurityManager.cpp:
2:29 AM Changeset in webkit [173657] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed gardening, skip one more tests on Windows.

  • Scripts/run-javascriptcore-tests:
1:58 AM Changeset in webkit [173656] by Csaba Osztrogonác
  • 4 edits in trunk

JSC test gardening
​https://bugs.webkit.org/show_bug.cgi?id=136823

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • tests/mozilla/mozilla-tests.yaml: Unskip passing tests.

Tools:

  • Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
1:57 AM Changeset in webkit [173655] by commit-queue@webkit.org
  • 2 edits in trunk

Fix FindICU.cmake
​https://bugs.webkit.org/show_bug.cgi?id=136820

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-09-16
Reviewed by Csaba Osztrogonác.

  • Source/cmake/FindICU.cmake:
1:46 AM Changeset in webkit [173654] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[GStreamer] http/tests/media/video-auth.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=126619

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-16
Reviewed by Philippe Normand.

Source/WebCore:

Test: http/tests/media/video-auth-cors.html

Use stored credentials when retrieving videos following image loading behavior
(i.e. stored credentials are always used except when in cors anonymous mode),
except that requesting credentials from user remains disabled for cross-origin requests.

Patch is covered by http/tests/media/video-auth.html.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(CachedResourceStreamingClient::CachedResourceStreamingClient): Enable using stored credentials except when using cors anonymous mode.

LayoutTests:

  • platform/efl/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
  • platform/efl/http/tests/media/video-auth-expected.txt: Added.
  • platform/gtk/TestExpectations: Removed failure expectation for http/tests/media/video-auth.html.
  • platform/gtk/http/tests/media/video-auth-expected.txt: Added.
1:16 AM Changeset in webkit [173653] by evab.u-szeged@partner.samsung.com
  • 2 edits in trunk/Tools

Remove shouldAbortEarly cruft from master.cfg
​https://bugs.webkit.org/show_bug.cgi?id=136779

Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ConfigureBuild.start):
(RunWebKitTests.start):
(RunWebKit2Tests.start): Deleted.

1:13 AM Changeset in webkit [173652] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

Add version of drawFocusIfNeeded that take a Path2D parameter.
​https://bugs.webkit.org/show_bug.cgi?id=136846

Patch by Jinho Bang <​jinho.bang@samsung.com> on 2014-09-16
Reviewed by Dirk Schulze.

Source/WebCore:

Tests: fast/canvas/draw-focus-if-needed-with-path.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawFocusIfNeeded):
(WebCore::CanvasRenderingContext2D::drawFocusIfNeededInternal):

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

  • fast/canvas/draw-focus-if-needed-expected.txt: Added.
  • fast/canvas/draw-focus-if-needed-with-path-expected.txt: Added.
  • fast/canvas/draw-focus-if-needed-with-path.html: Added.
  • fast/canvas/draw-focus-if-needed.html: Added.

Sep 15, 2014:

11:53 PM Changeset in webkit [173651] by zandobersek@gmail.com
  • 3 edits
    2 adds in trunk/Source/WebCore

[GTK] Add WaylandDisplay
​https://bugs.webkit.org/show_bug.cgi?id=136216

Reviewed by Martin Robinson.

Add the WaylandDisplay class. This class is used in the LayerTreeHostGtk,
in the WebProcess, and controls the connection to the nested Wayland
compositor in the UIProcess. Only one instance of the class is used in the
WebProcess, accessible via the static WaylandDisplay::instance() method.

The WaylandDisplay constructor performs the EGL initialization while also
querying the Wayland register, resulting in initializing client-side objects
that can interact with the wl_compositor and wl_webkitgtk interfaces
implemented in the nested Wayland compositor. The single class instance is
only deemed properly initialized if it picked up the Wayland interface objects
and has properly acquired the EGL display and config.

WaylandDisplay::createSurface() is called by the LayerTreeHostGtk during
its own initialization. The method creates a new wl_surface object via the
wl_compositor interface and a new wl_egl_window object that's based on that
surface. For the wl_egl_window object, we fall back to a width or height of 1
in case the passed-in value for either is 0. This avoids problems in Mesa
where widths or heights of 0 are not supported.

We associate the created surface with the passed-in widget ID, as provided
by LayerTreeHostGtk, via the wl_webkitgtk interface. This enables proper
mapping of Wayland surfaces and the GtkWidgets in the UIProcess and makes
it possible for the nested Wayland compositor to correctly determine which
GtkWidget has to be redrawn after some surface has been committed.

WaylandDisplay::createSharingGLContext() creates a new GLContextEGL object
that's to be used as a sharing context. The method creates a new surface
via the wl_compositor interface and uses it to create a dummy native EGL
window that's 1x1px in size. The GLContextEGL object is then created
through the static GLContextEGL::createWindowContext() method.

  • PlatformGTK.cmake:
  • platform/graphics/wayland/WaylandDisplay.cpp: Added.

(WebCore::WaylandDisplay::globalCallback):
(WebCore::WaylandDisplay::globalRemoveCallback):
(WebCore::WaylandDisplay::instance):
(WebCore::WaylandDisplay::WaylandDisplay):
(WebCore::WaylandDisplay::createSurface):
(WebCore::WaylandDisplay::createSharingGLContext):

  • platform/graphics/wayland/WaylandDisplay.h: Added.

(WebCore::WaylandDisplay::nativeDisplay):
(WebCore::WaylandDisplay::eglDisplay):

  • platform/graphics/wayland/WaylandSurface.cpp:

(WebCore::WaylandSurface::~WaylandSurface): Assert that the WaylandDisplay
instance is present before going on to destroy the surface resources.

11:26 PM Changeset in webkit [173650] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

10:36 PM Changeset in webkit [173649] by Chris Dumez
  • 15 edits in trunk/Source/WebCore

Rename LiveNodeLists / HTMLCollections's nodeMatches() to elementMatches()
​https://bugs.webkit.org/show_bug.cgi?id=136844

Reviewed by Sam Weinig.

Rename LiveNodeLists / HTMLCollections's nodeMatches() to elementMatches()
for clarity as the argument is an Element.

No new tests, no behavior change.

  • dom/ClassNodeList.h:

(WebCore::ClassNodeList::elementMatches):
(WebCore::ClassNodeList::nodeMatches): Deleted.

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesWindowNamedItem):
(WebCore::keyMatchesDocumentNamedItem):

  • dom/Element.cpp:

(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateIdForDocument):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::namedItem):

  • dom/LiveNodeList.h:

(WebCore::CachedLiveNodeList<NodeListType>::collectionBegin):
(WebCore::CachedLiveNodeList<NodeListType>::collectionLast):
(WebCore::CachedLiveNodeList<NodeListType>::collectionTraverseForward):
(WebCore::CachedLiveNodeList<NodeListType>::collectionTraverseBackward):

  • dom/NameNodeList.h:

(WebCore::NameNodeList::elementMatches):
(WebCore::NameNodeList::nodeMatches): Deleted.

  • dom/TagNodeList.h:

(WebCore::TagNodeList::elementMatches):
(WebCore::HTMLTagNodeList::elementMatches):
(WebCore::TagNodeList::nodeMatches): Deleted.
(WebCore::HTMLTagNodeList::nodeMatches): Deleted.

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement):

  • html/HTMLNameCollection.cpp:

(WebCore::WindowNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::WindowNameCollection::elementMatches):
(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):
(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch): Deleted.
(WebCore::WindowNameCollection::nodeMatches): Deleted.
(WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch): Deleted.
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch): Deleted.
(WebCore::DocumentNameCollection::nodeMatches): Deleted.

  • html/HTMLNameCollection.h:
  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::elementMatches):
(WebCore::LabelsNodeList::nodeMatches): Deleted.

  • html/LabelsNodeList.h:
  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::elementMatches):
(WebCore::RadioNodeList::nodeMatches): Deleted.

  • html/RadioNodeList.h:
9:09 PM Changeset in webkit [173648] by Chris Dumez
  • 8 edits
    2 adds in trunk

Use an AtomicString as key for caching ClassNodeList objects
​https://bugs.webkit.org/show_bug.cgi?id=136830

Reviewed by Benjamin Poulain.

Use an AtomicString as key for caching ClassNodeList objects instead of
a String. ClassNodeList is the only type using a String instead of an
AtomicString as key in the cache HashTable. This brings some
complexity.

I believe this was done to avoid unnecessarily atomizing the String,
for performance reasons. However, at the moment, the String gets
atomized anyway when constructing the ClassNodeList object. This is
because the ClassNodeList::m_classNames member is of SpaceSplitString
type and the SpaceSplitString constructor takes an AtomicString in
argument.

Using an AtomicString to cache ClassNodeLists simplifies the code quite
a bit and decreases the size of NodeListsNodeData as well.

Test: fast/dom/getElementsByClassName/conflict-tag-name.html

  • WebCore.order:

Remove symbol corresponding to addCacheWithName() as it was removed.

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::~ClassNodeList):
Update the constructor to take an AtomicString in argument instead of
a String, for clarity. The String gets atomized when initializing
m_classNames anyway.

(WebCore::ClassNodeList::ClassNodeList):
Call removeCacheWithAtomicName() instead of removeCacheWithName() now
that m_originalClassNames is an AtomicString.

  • dom/ClassNodeList.h:

Use AtomicString instead of String type for classNames, in both the
constructor argument and the m_originalClassNames data member.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getElementsByClassName):
Call addCacheWithAtomicName() instead of addCacheWithName() now that
addCacheWithName() has been removed.

  • dom/Node.cpp:

(WebCore::NodeListsNodeData::invalidateCaches):
Stop invalidating m_nameCaches as this HashMap no longer exists.

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::NodeListCacheMapEntryHash::hash):
(WebCore::NodeListsNodeData::NodeListCacheMapEntryHash::equal):
(WebCore::NodeListsNodeData::isEmpty):
(WebCore::NodeListsNodeData::adoptDocument):
(WebCore::NodeListsNodeData::namedNodeListKey):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList):
(WebCore::NodeListsNodeData::addCacheWithName): Deleted.
(WebCore::NodeListsNodeData::removeCacheWithName): Deleted.

  • Drop addCacheWithName() / removeCacheWithName() now that no NodeList uses a String as HashMap key.
  • Drop m_nameCaches now that ClassNodeLists are cached in m_atomicNameCaches instead.
  • Remove StringType template parameter and hardcode AtomicString instead.
8:50 PM Changeset in webkit [173647] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove ORWT related crufts from webkitdirs.pm
​https://bugs.webkit.org/show_bug.cgi?id=136821

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-09-15
Reviewed by Alexey Proskuryakov.

  • Scripts/webkitdirs.pm:

(isPerianInstalled): Deleted.
(determineIPhoneSimulatorVersion): Deleted.
(iPhoneSimulatorVersion): Deleted.
(isSnowLeopard): Deleted.
(isLion): Deleted.
(quitIOSSimulator): Deleted.

7:30 PM Changeset in webkit [173646] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Return early in SelectorChecker::checkOne() if selector.isAttributeSelector() is true
​https://bugs.webkit.org/show_bug.cgi?id=136838

Reviewed by Benjamin Poulain.

Return early in SelectorChecker::checkOne() if selector.isAttributeSelector()
is true and the selector matched. Previously, we were only returning early if
the selector did not match and we were falling through if it did. This means
that we ended up doing the 2 if() checks below in the method unnecessarily:

  • selector.m_match == CSSSelector::PseudoClass
  • selector.m_match == CSSSelector::PseudoElement

No new tests, no behavior change.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

7:24 PM Changeset in webkit [173645] by ggaren@apple.com
  • 7 edits
    1 copy in trunk/Source/bmalloc

bmalloc: allocate small and medium objects using the same bump pointer class
​https://bugs.webkit.org/show_bug.cgi?id=136843

Reviewed by Gavin Barraclough.

4% speedup on MallocBench.

Now that medium-sized objects have dedicated per-size allocators, they
don't need to use an arbitrary bump pointer allocator. This means that
every allocator knows how many objects it will allocate from the start,
and we don't need a post-processing step to adjust refcounts based on
real allocation count.

  • bmalloc.xcodeproj/project.pbxproj: Renamed SmallAllocator to BumpAllocator

since it's used for small and medium objects now.

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::Allocator): Updated to use new interface.
(bmalloc::Allocator::scavenge): To "retire" an allocator, we just need
to make sure that we finish allocating all the objects in it.

(bmalloc::Allocator::allocateMedium):
(bmalloc::Allocator::allocateSlowCase):
(bmalloc::Allocator::retire): Deleted.
(bmalloc::Allocator::processSmallAllocatorLog): Deleted.
(bmalloc::Allocator::processMediumAllocatorLog): Deleted.

  • bmalloc/Allocator.h:

(bmalloc::Allocator::allocateFastCase): Removed abstractions and data
used to post-process an allocator based on how many objects it allocated.

  • bmalloc/BumpAllocator.h: Copied from Source/bmalloc/bmalloc/SmallAllocator.h.

(bmalloc::BumpAllocator::BumpAllocator):
(bmalloc::BumpAllocator::init):
(bmalloc::BumpAllocator::line):
(bmalloc::BumpAllocator::validate):
(bmalloc::BumpAllocator::allocate):
(bmalloc::BumpAllocator::refill):
(bmalloc::BumpAllocator::clear): Updated these functions to be agnostic
about the kinds of lines they allocate into. In some cases, the line
type must be provided as a template parameter by the caller.

(bmalloc::SmallAllocator::SmallAllocator): Deleted.
(bmalloc::SmallAllocator::line): Deleted.
(bmalloc::SmallAllocator::allocate): Deleted.
(bmalloc::SmallAllocator::objectCount): Deleted.
(bmalloc::SmallAllocator::derefCount): Deleted.
(bmalloc::SmallAllocator::refill): Deleted.
(bmalloc::SmallAllocator::clear): Deleted.

  • bmalloc/ObjectType.h:

(bmalloc::isMedium):

  • bmalloc/SmallAllocator.h:

(bmalloc::SmallAllocator::isNull): Deleted.
(bmalloc::SmallAllocator::canAllocate): Deleted.
(bmalloc::SmallAllocator::SmallAllocator): Deleted.
(bmalloc::SmallAllocator::line): Deleted.
(bmalloc::SmallAllocator::allocate): Deleted.
(bmalloc::SmallAllocator::objectCount): Deleted.
(bmalloc::SmallAllocator::derefCount): Deleted.
(bmalloc::SmallAllocator::refill): Deleted.
(bmalloc::SmallAllocator::clear): Deleted.

6:22 PM Changeset in webkit [173644] by roger_fong@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed Windows gardening. fast/forms/label test expectations now match Mac platform's expectations.

  • platform/win/fast/forms/label: Removed.
  • platform/win/fast/forms/label/labelable-elements-expected.txt: Removed.
  • platform/win/fast/forms/label/labels-add-htmlFor-label-expected.txt: Removed.
  • platform/win/fast/forms/label/labels-add-parent-label-expected.txt: Removed.
  • platform/win/fast/forms/label/labels-change-htmlFor-attribute-expected.txt: Removed.
  • platform/win/fast/forms/label/labels-multiple-sibling-labels-expected.txt: Removed.
  • platform/win/fast/forms/label/labels-parent-and-sibling-labels-expected.txt: Removed.
  • platform/win/fast/forms/label/labels-remove-htmlFor-attribute-expected.txt: Removed.
  • platform/win/fast/forms/label/labels-remove-htmlFor-label-expected.txt: Removed.
  • platform/win/fast/forms/label/labels-remove-parent-label-expected.txt: Removed.
  • platform/win/fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Removed.
6:15 PM Changeset in webkit [173643] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Un-inline the Node constructor
​https://bugs.webkit.org/show_bug.cgi?id=136842

Reviewed by Benjamin Poulain.

Un-inline the Node constructor as it does not seem to impact
performance, based on my testing:
​http://dromaeo.com/?id=226992,226998

This reduces the stripped binary size by ~4Kb.

No new tests, no behavior change.

  • dom/Document.h:

(WebCore::Node::Node): Deleted.

  • dom/Node.cpp:

(WebCore::Node::Node):

5:45 PM Changeset in webkit [173642] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Web Core: Websocket state should be set to closed in didReceiveMessage call back.
​https://bugs.webkit.org/show_bug.cgi?id=136219

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-09-15
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Set the Websocket state to closed in didReceiveMessage call back.

Test: http/tests/websocket/tests/hybi/error-event-ready-state.html

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveMessageError):

LayoutTests:

Added test to check readyState is CLOSED within onerror event.

  • http/tests/websocket/tests/hybi/error-event-ready-state-expected.txt: Added.
  • http/tests/websocket/tests/hybi/error-event-ready-state.html: Added.
5:44 PM Changeset in webkit [173641] by roger_fong@apple.com
  • 11 edits in trunk/LayoutTests

Unreviewed. Windows rebaselining to account for subpixel layout Part 1.

  • platform/win/editing/selection/move-left-right-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
5:41 PM Changeset in webkit [173640] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: mouse drifts away from resizer when resizing docked inspector
​https://bugs.webkit.org/show_bug.cgi?id=22263

Patch by Matt Baker <Matt Baker> on 2014-09-15
Reviewed by Joseph Pecoraro.

Modified the docked resizer dragging logic to record the initial mouse down position relative to the
resizer client rectangle. Added check while dragging the resizer to ensure that the cursor is positioned
correctly with respect to the resize direction before updating the attached window dimension.

  • UserInterface/Base/Main.js:

(WebInspector._dockedResizerMouseDown.dockedResizerDrag):

4:47 PM Changeset in webkit [173639] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.11.7

New tag.

4:15 PM Changeset in webkit [173638] by jhoneycutt@apple.com
  • 3 edits in trunk/Source/WebCore

Naming clean-up.

Rubber-stamped by Andy Estes.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::requestAutocomplete):
(WebCore::HTMLFormElement::finishRequestAutocomplete):
Remove superfluous "AutocompleteResult".

  • html/HTMLFormElement.h:

Ditto.

4:13 PM Changeset in webkit [173637] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=25160

  • Scripts/run-javascriptcore-tests:
3:58 PM Changeset in webkit [173636] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Create a JSCallee for GlobalExec object
​https://bugs.webkit.org/show_bug.cgi?id=136840

Reviewed by Geoffrey Garen.

Added m_globalCallee, initialized it and then used it to set the globalExec's callee.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:
3:52 PM Changeset in webkit [173635] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when logging in to optionshouse.com
​https://bugs.webkit.org/show_bug.cgi?id=136834

Reviewed by Anders Carlsson.

No test, because I couldn't make one. I don't have a way to reproduce first-hand.

  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):

3:47 PM Changeset in webkit [173634] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

Unreviewed build fix for 32-bit builds.

Make casts from unsigned long long -> size_t explicit, rather than implicit. Also
make CARingBuffer be protected by USING_MEDIA_TOOLBOX so ports without that flag
won't try to compile unused code.

  • platform/audio/mac/CARingBuffer.cpp:

(WebCore::CARingBuffer::fetch):

  • platform/audio/mac/CARingBuffer.h:
  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::provideInput):

3:03 PM Changeset in webkit [173633] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip initial-letter tests on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=136841

  • platform/win/TestExpectations:
2:52 PM Changeset in webkit [173632] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed logic fix from r173631. Logic for includeShadowDOM was reversed.

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

2:47 PM Changeset in webkit [173631] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

Videos with controls enabled never receive 'dragstart' events.
​https://bugs.webkit.org/show_bug.cgi?id=136837

Reviewed by Simon Fraser.

When initiating a drag, the DragController checks whether the hit-tested element at a
drag location is a child of the drag source, and bails if early if that is not the case.
For a <video> element with controls, the hit-tested element is an element within the
<video> element's Shadow DOM. Because the DragController uses a method which does not
take Shadow DOM into account when determining a child-parent relationship, this test fails
and all drag operations fail as well.

For <video> elements only, when testing whether the drag source is an ancestor of the
hit-tested element, use containsIncludingShadowDOM() instead of contains(). To ensure that
the controls are still usable when a drag listener is active on a <video> element, mark
the controls as a draggable element, but simply call preventDefault() in the controls'
'dragstart' handler, ensuring the timeline and volume controls are themselves still draggable.

  • Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-panel):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls):
(Controller.prototype.handlePanelDragStart):

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

2:40 PM Changeset in webkit [173630] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Add an unimplemented case to handle CSSPropertyWebkitInitialLetter so we don't get an assertion failure.

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

1:17 PM Changeset in webkit [173629] by roger_fong@apple.com
  • 13 edits in trunk/LayoutTests

Change all snapshotting tests to use quicktime.

  • platform/mac-wk2/TestExpectations:
  • platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-expected.txt:
  • plugins/snapshotting/autoplay-dominant-blank-plugin-moved-into-view.html:
  • plugins/snapshotting/autoplay-dominant.html:
  • plugins/snapshotting/autoplay-plugin-blocked-by-image.html:
  • plugins/snapshotting/autoplay-plugin-mostly-blocked-by-image.html:
  • plugins/snapshotting/autoplay-similar-to-dominant.html:
  • plugins/snapshotting/plugin-receives-click-event.html:
  • plugins/snapshotting/restart.html:
  • plugins/snapshotting/set-plugin-size-to-tiny.html:
  • plugins/snapshotting/simple.html:
  • plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html:
1:05 PM Changeset in webkit [173628] by jer.noble@apple.com
  • 7 edits
    4 adds in trunk/Source

[Mac] Support audioSourceProvider() in MediaPlayerPrivateAVFoundationObjC
​https://bugs.webkit.org/show_bug.cgi?id=135042

Reviewed by Eric Carlson.

Source/WebCore:

Add support for AudioSourceProvider in MediaPlayerPrivateAVFoundationObjC, thereby
supporting MediaElementAudioSourceNode.

Import the CARingBuffer from CoreAudio sample code, making the necessary modifications
for WebKit style and coding conventions. The threading assumptions for this class are
that there will be a single writer thread and a single reader thread.

  • platform/audio/mac/CARingBuffer.cpp: Added.

(WebCore::CARingBuffer::create): Create a unique_ptr.
(WebCore::CARingBuffer::CARingBuffer): Simple constructor.
(WebCore::CARingBuffer::~CARingBuffer): Simple destructor.
(WebCore::CARingBuffer::allocate): Initialize the buffers and time bounds structures.
(WebCore::CARingBuffer::deallocate): Destroy same.
(WebCore::ZeroRange): Static utility method.
(WebCore::StoreABL): Ditto.
(WebCore::FetchABL): Ditto.
(WebCore::ZeroABL): Ditto.
(WebCore::CARingBuffer::store): Store the passed in buffer in the ring buffer, wrapping

if necessary.

(WebCore::CARingBuffer::setTimeBounds): Set the new time bounds by incrementing the

bounds index locally, filling in the new values, then atomically incrementing the
reader-visible index.

(WebCore::CARingBuffer::getTimeBounds): Get the new time bounds by masking the time

bounds index, and using it as an offset to the time bounds array. Protect against
CPU starvation on the reading thread by checking the index against the stored
index in the array entry. This check will fail if the writing thread has wrapped
more than the size of the array.

(WebCore::CARingBuffer::clipTimeBounds): Clamp the passed values to the available bounds.
(WebCore::CARingBuffer::startFrame): Simple accessor.
(WebCore::CARingBuffer::endFrame): Ditto.
(WebCore::CARingBuffer::fetch): Read an audio buffer list from the ring buffer, possbily

wrapping around to the start of the ring buffer.

  • platform/audio/mac/CARingBuffer.h: Added.

(WebCore::CARingBuffer::numberOfChannels): Simple accessor.
(WebCore::CARingBuffer::frameOffset): Ditto.
(WebCore::CARingBuffer::TimeBounds::TimeBounds): Struct holding the start and end frame values.

Add an implementation of AudioSourceProvider, using AVAudioMix and MTAudioProcessingTap
to tap an AVPlayerItem's audio output and feed it to a MediaElementAudioSourceNode.

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h: Added.
  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm: Added.

(WebCore::AudioSourceProviderAVFObjC::create): Simple factory.
(WebCore::AudioSourceProviderAVFObjC::AudioSourceProviderAVFObjC): Simple constructor.
(WebCore::AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC): Simple destructor.
(WebCore::AudioSourceProviderAVFObjC::provideInput): Push audio into the ring buffer.
(WebCore::AudioSourceProviderAVFObjC::setClient): Call destroyMix()/createMix() as appropriate.
(WebCore::AudioSourceProviderAVFObjC::setPlayerItem): Ditto.
(WebCore::AudioSourceProviderAVFObjC::destroyMix): Detach and destroy the AVAudioMix and tap.
(WebCore::AudioSourceProviderAVFObjC::createMix): Set up the AVAudioMix and tap and attach to

the AVPlayerItem.

(WebCore::AudioSourceProviderAVFObjC::initCallback): Pass to class method.
(WebCore::AudioSourceProviderAVFObjC::finalizeCallback): Ditto.
(WebCore::AudioSourceProviderAVFObjC::prepareCallback): Ditto.
(WebCore::AudioSourceProviderAVFObjC::unprepareCallback): Ditto.
(WebCore::AudioSourceProviderAVFObjC::processCallback): Ditto.
(WebCore::AudioSourceProviderAVFObjC::init): Set up the storage pointer for the tap.
(WebCore::AudioSourceProviderAVFObjC::finalize): No-op.
(WebCore::operator==): Compare two AudioStreamBasicDescription objects.
(WebCore::operator!=): Ditto.
(WebCore::AudioSourceProviderAVFObjC::prepare): Create an AudioCoverter object if necessary,

create the ring buffer, and notify the client of format changes.

(WebCore::AudioSourceProviderAVFObjC::unprepare): Destroy same.
(WebCore::AudioSourceProviderAVFObjC::process): Copy samples out of the ring buffer,

format converting them if necessary. Mute original audio.

Create the AudioSourceProviderAVFObjC object and notify it when the current AVPlayerItem changes.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::audioSourceProvider):

Enable SOFT_LINK_MAY_FAIL on the Mac platform.

  • platform/mac/SoftLinking.h:

Add new files to the project.

  • WebCore.xcodeproj/project.pbxproj:

Source/WTF:

  • wtf/Platform.h: Add WTF_USE_MEDIATOOLBOX.
12:50 PM Changeset in webkit [173627] by Lucas Forschler
  • 2 edits in trunk/Tools

Add another Apple build slave to the Mountain Lion Debug WK1 queue

Rubber stamped by Matt Hanson.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
12:32 PM Changeset in webkit [173626] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG ref count calculation should be reusable
​https://bugs.webkit.org/show_bug.cgi?id=136811

Reviewed by Oliver Hunt.

Henceforth if you call Graph::computeRefCounts(), a nifty O(n) operation, every Node
will be able to tell you how many places it is used from. Currently only DCE uses this,
but it will be useful for ​https://bugs.webkit.org/show_bug.cgi?id=136330.

  • dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):
(JSC::DFG::DCEPhase::findTypeCheckRoot): Deleted.
(JSC::DFG::DCEPhase::countNode): Deleted.
(JSC::DFG::DCEPhase::countEdge): Deleted.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::computeRefCounts):

  • dfg/DFGGraph.h:
11:45 AM Changeset in webkit [173625] by bshafiei@apple.com
  • 4 edits in branches/safari-600.1.4.11-branch/Source/WebKit2

Merged r173623. <rdar://problem/17897780>

11:40 AM Changeset in webkit [173624] by bshafiei@apple.com
  • 8 edits in branches/safari-600.1.4.11-branch/Source

Merge patch for <rdar://problem/18327341>.

10:10 AM Changeset in webkit [173623] by barraclough@apple.com
  • 4 edits in trunk/Source/WebKit2

Should call [BKSProcessAssertion invalidate]
​https://bugs.webkit.org/show_bug.cgi?id=136804
<rdar://problem/17897780>

Reviewed by Darin Adler.

We should invalidate the process assertion before releasing it. Fortunately this is really easy,
since there is a simple 1:1 relationship with ProcessAssertion, with their lifetimes matching exactly.

  • UIProcess/ProcessAssertion.cpp:

(WebKit::ProcessAssertion::~ProcessAssertion):

  • no-op implementation.
  • UIProcess/ProcessAssertion.h:
    • added destructor.
  • UIProcess/ios/ProcessAssertionIOS.mm:

(WebKit::ProcessAssertion::~ProcessAssertion):

  • destructor invalidates the BKSProcessAssertion.
8:59 AM Changeset in webkit [173622] by Chris Dumez
  • 14 edits in trunk/Source/WebCore

Avoid redundant isElementNode() checks in Traversal<HTML*Element> / Traversal<SVG*Element>
​https://bugs.webkit.org/show_bug.cgi?id=136719

Reviewed by Darin Adler.

Avoid redundant isElementNode() checks in Traversal<HTML*Element> /
Traversal<SVG*Element>. We used to iterate through Elements, and then
call isElementOfType<HTML*Element>() on each Element. This made sense
because hasTagName() used to be defined on Element. However, after
​http://trac.webkit.org/changeset/165699, hasTagName() is now defined on
Node for HTMLQualifiedName / SVGQualifiedName arguments.

Node::hasTagName(HTMLQualifiedName) basically does the following check
"isHTMLElement() && toHTMLElement(*this).hasTagName(tagName)". As a
consequence, doing an isElementNode() check is now redundant as
isHTMLElement() is defined on Node.

This patch adds a template parameter to isElementOfType() so that it can
take any type in argument (particulaly Node, Element, HTMLElement,
SVGElement, MathMLElement), not just an Element. I had to add an
ElementTypeCastTraits struct to support partial specialization as C++
does not support partial specialization of template functions.
This patch also updates Traversal<ElementType> so that the methods use
NodeTraversal internally instead of Traversal<ElementType>. As a result,
we now iterate over Nodes (not Elements) and call the new
isElementOfType<ElementType>(Node) helpers (which are efficient after
r165699).

Before the patch, the code ended up doing the following checks for
Traversal<HTML*element>:
node.isElementNode() && toElement(node).isHTMLElement()

&& toHTMLElement(node).hasTagName(HTMLNames::fooTag)

After the patch, the code only does:
node.isHTMLElement()

&& toHTMLElement(node).hasTagName(HTMLNames::fooTag)

No new tests, no behavior change.

  • dom/Element.h:

(WebCore::Element>):
(WebCore::isElementOfType):
Add template parameter to isElementOfType() function so that it can
handle any argument type, not just Elements. Also introduce an
ElementTypeCastTraits struct that is called by isElementOfType()
function so that we can so partial template specialization.

  • dom/ElementTraversal.h:

(WebCore::Traversal<ElementType>::firstWithinTemplate):
(WebCore::Traversal<ElementType>::lastWithinTemplate):
(WebCore::Traversal<ElementType>::nextTemplate):
(WebCore::Traversal<ElementType>::previousTemplate):
Use NodeTraversal API internally instead of Traversal<Element> to avoid
redundant isElementNode() checks.

(WebCore::Traversal<Element>::lastWithinTemplate): Deleted.
The code is now identical to the generic version.

(WebCore::Traversal<Element>::previousTemplate): Deleted.
The code is now identical to the generic version.

  • dom/make_names.pl:

(printTypeHelpers):

  • Generate template specializations for ElementTypeCastTraits struct instead of isElementOfType(). This avoids having to provide overloads for specific argument types (e.g. Node, Element, HTMLElement, ...).
  • Share more code between HTML code path and the other path (for SVG, MTHML).
  • html/HTMLElement.h:

(WebCore::HTMLElement>):
Provide HTMLElement template specialization for ElementTypeCastTraits
struct instead of isElementOfType().

  • html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElement>):
Provide HTMLFormControlElement template specialization for
ElementTypeCastTraits struct instead of isElementOfType().

  • html/HTMLFrameElementBase.h:

(WebCore::isHTMLFrameElementBase):

  • Remove helper taking an Element in argument as it does not bring any benefit. Instead, update the overload taking a Node in argument to remove the unnecessary isElementNode() check as isHTMLFrameElement(Node) is now efficient.
  • Add an overload taking an HTMLElement in argument so that we can bypass the isHTMLElement() check when we know the input is an HTMLElement.
  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement>):
Provide HTMLMediaElement template specialization for ElementTypeCastTraits
struct instead of isElementOfType().

  • html/HTMLPlugInImageElement.h:

(WebCore::HTMLPlugInImageElement>):
Provide HTMLPlugInImageElement template specialization for
ElementTypeCastTraits struct instead of isElementOfType().

  • html/LabelableElement.h:

(WebCore::LabelableElement>):
Provide LabelableElement template specialization for ElementTypeCastTraits
struct instead of isElementOfType().

  • mathml/MathMLElement.h:

(WebCore::MathMLElement>):
Provide MathMLElement template specialization for ElementTypeCastTraits
struct for consistency with HTMLElement / SVGElement.

  • svg/SVGElement.h:

(WebCore::SVGElement>):

  • Provide SVGElement template specialization for ElementTypeCastTraits struct instead of isElementOfType().
  • include SVGElementTypeHelpers.h at the end of the file (similarly to what is already done in HTMLElement.h because isElementOfType(const SVGElement&) needs to be defiend because the include.
  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::SVGFilterPrimitiveStandardAttributes>):
Provide SVGFilterPrimitiveStandardAttributes template specialization for
ElementTypeCastTraits struct instead of isElementOfType().

  • svg/animation/SVGSMILElement.h:

(WebCore::SVGSMILElement>):
Provide SVGSMILElement template specialization for ElementTypeCastTraits
struct instead of isElementOfType().

7:45 AM Changeset in webkit [173621] by g.czajkowski@samsung.com
  • 4 edits in trunk/Tools

[EFL] Ecore and Eina are initialized twice in TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=136822

Reviewed by Gyuyoung Kim.

In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
initialized as we already does it in PlatformWebView::PlatformWebView
calling ewk_init(). The reason for that was to ensure testing for example,
WTF where creating the view is not mandatory.

Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
in order to properly initalize and release EWebKit.

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):

  • TestWebKitAPI/efl/main.cpp:

(main):

7:20 AM Changeset in webkit [173620] by svillar@igalia.com
  • 4 edits
    2 adds in trunk

[CSS Grid Layout] Sort items by span when resolving content-based track sizing functions
​https://bugs.webkit.org/show_bug.cgi?id=135701

Reviewed by Darin Adler.

Source/WebCore:

Section 10.4 of the specs mentions that we should first treat non
spanning items and then incrementally proceed with items with
greater spans when resolving the track breaths in the Track Sizing
Algorithm.

As a nice side effect we're removing the multiple processing of
spanning grid items caused by GridIterator (it returns the same
item as many times as the number of cells it spans). This adds a
~4% performance penalty in auto-grid-lots-of-data.html mainly due
to the use of a hash to remove duplicates.

Test: fast/css-grid-layout/grid-item-order-in-content-sized-columns-resolution.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::gridItemSpan):
(WebCore::gridItemWithSpanSorter):
(WebCore::uniquePointerInPair):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):

  • rendering/RenderGrid.h:

LayoutTests:

Tests that check that items are sorted by span to resolve content
based track sizing functions instead of directly using DOM order.

  • fast/css-grid-layout/grid-item-order-in-content-sized-columns-resolution-expected.txt: Added.
  • fast/css-grid-layout/grid-item-order-in-content-sized-columns-resolution.html: Added.
4:35 AM Changeset in webkit [173619] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK][CMake] Build WebCore with Wayland-specific include directories, libraries
​https://bugs.webkit.org/show_bug.cgi?id=136815

Reviewed by Philippe Normand.

  • PlatformGTK.cmake: Add the platform/graphics/wayland/ directory to the list of

WebCore's include directories. Add include directories of the Wayland dependency
to the list of WebCore's include directories. Same for the Wayland libraries.

4:32 AM Changeset in webkit [173618] by zandobersek@gmail.com
  • 2 edits in trunk

[CMake] Remove FIND_PACKAGE_HANDLE_STANDARD_ARGS call for WAYLAND_EGL in FindWayland.cmake
​https://bugs.webkit.org/show_bug.cgi?id=136814

Reviewed by Philippe Normand.

  • Source/cmake/FindWayland.cmake: This line was committed by mistake.

We bundle the wayland-egl dependency with wayland-client and wayland-server
and store the resulting variables with the WAYLAND_ prefix. Because of this
this line wasn't exporting anything useful.

3:04 AM Changeset in webkit [173617] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION(r170243): [EFL][WK2] Dirty image is shown when new page is loading on fixed layout
​https://bugs.webkit.org/show_bug.cgi?id=136568

Reviewed by Csaba Osztrogonác.

r170243 landed wrong didCommitNewPage() since it always returns false. It cause that
PageViewportControllerClientEfl::didChangeVisibleContents() continues to draw dirty image on 0,0 coordinate.
This patch fixes the problem.

  • UIProcess/API/efl/EwkView.h:

(EwkView::waitingForNewPage):
(EwkView::didCommitNewPage):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):

2:45 AM Changeset in webkit [173616] by commit-queue@webkit.org
  • 14 edits in trunk

[WinCairo] Make it easier to enable/disable GStreamer.
​https://bugs.webkit.org/show_bug.cgi?id=135766

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-09-15
Reviewed by Brent Fulgham.

Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.

Source/WebCore:

  • WebCore.vcxproj/WebCoreDebugWinCairo.props: Import GStreamer property file.
  • WebCore.vcxproj/WebCoreReleaseWinCairo.props: Ditto.

Source/WebKit:

  • WebKit.vcxproj/WebKit/WebKitDebugWinCairo.props: Import GStreamer property file.
  • WebKit.vcxproj/WebKit/WebKitReleaseWinCairo.props: Ditto.

Source/WTF:

  • WTF.vcxproj/WTFDebugWinCairo.props: Import GStreamer property file.
  • WTF.vcxproj/WTFReleaseWinCairo.props: Ditto.
  • wtf/Platform.h: Enable GStreamer if ENABLE(GSTREAMER_WINCAIRO) is true, otherwise use Media Foundation.

Tools:

  • WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.

WebKitLibraries:

  • win/tools/vsprops/GStreamerCommon.props: Add user macro ENABLE_GSTREAMER_WINCAIRO.
2:12 AM Changeset in webkit [173615] by svillar@igalia.com
  • 6 edits in trunk

[CSS Grid Layout] Crash at CSSParser::parseGridTemplateRowsAndAreas
​https://bugs.webkit.org/show_bug.cgi?id=136778

Reviewed by Darin Adler.

Source/WebCore:

An empty list of grid line names (represented by "()") does not
add anything to the list of parsed values. That's why trying to
concatenate an adjacent list of grid line names was failing,
because we were trying to concatenate a list with the last parsed
CSSValue which was not the expected grid line names list.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTemplateRowsAndAreas):
(WebCore::CSSParser::parseGridLineNames):

  • css/CSSParser.h:

LayoutTests:

Added some new test cases to verify that we properly handle empty
lists of grid line names.

  • fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt:
  • fast/css-grid-layout/grid-template-shorthand-get-set.html:
1:08 AM Changeset in webkit [173614] by Andres Gomez
  • 3 edits in trunk/Source/WebCore

[GStreamer] don't send transferMode HTTP header
​https://bugs.webkit.org/show_bug.cgi?id=136781

Reviewed by Philippe Normand.

No header at all is better than having the wrong header as DLNA
mandates that a missing header has to be tolerated while a wrong
header is an error.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

  • platform/network/HTTPHeaderNames.in:

Sep 14, 2014:

10:40 PM Changeset in webkit [173613] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Fix post-mortem nits for r173528 & r173549
​https://bugs.webkit.org/show_bug.cgi?id=136808

Reviewed by Darin Adler.

Fix post-mortem nits for r173528 & r173549.

No new tests, no behavior change.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::alternativeTextForWebArea):

  • Use auto* instead of more specific types.
  • Use fastGetAttribute() instead of getAttribute() as this is supported for the "title" attribute.
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionFromNone):
Use auto* instead of more specific types.

9:29 PM Changeset in webkit [173612] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/WebCore

Introduce FONT_DATA_TYPE_CASTS, and use it
​https://bugs.webkit.org/show_bug.cgi?id=136766

Reviewed by Darin Adler.

As a step to use toFoo, this patch introduces FONT_DATA_TYPE_CASTS macro for toFooFontData().
This will help to detect wrong type cast.

  • platform/graphics/FontData.h:
  • platform/graphics/FontGlyphs.cpp:

(WebCore::FontGlyphs::releaseFontData):
(WebCore::FontGlyphs::determinePitch):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

  • platform/graphics/SegmentedFontData.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCompositeFontReferenceFontData):

9:07 PM Changeset in webkit [173611] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source/WebCore

Generate toCSSStyleSheet using STYLE_SHEET_TYPE_CASTS
​https://bugs.webkit.org/show_bug.cgi?id=136774

Reviewed by Darin Adler.

As a step to use toFoo, this patch introduces STYLE_SHEET_TYPE_CASTS for toCSSStyleSheet().
This will help to detect wrong type cast. Additonally this patch helps to remove argument type of RefPtr.

No new tests, no behavior changes.

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • css/CSSStyleSheet.h:
  • css/StyleSheet.h:
  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::filterEnabledNonemptyCSSStyleSheets):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::collectStyleSheets):

8:40 PM Changeset in webkit [173610] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Generate toFooElementData() using ELEMENT_DATA_TYPE_CASTS
​https://bugs.webkit.org/show_bug.cgi?id=136775

Reviewed by Darin Adler.

As a step to use toFoo, this patch introduces ELEMENT_DATA_TYPE_CASTS for toFooElementData().
This will help to detect wrong type cast. Additonally this patch helps to remove argument type of RefPtr.

No new tests, no behavior changes.

  • dom/Element.cpp:

(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createUniqueElementData):

  • dom/ElementData.cpp:

(WebCore::ElementData::destroy):

  • dom/ElementData.h:

(WebCore::ElementData::length):
(WebCore::ElementData::attributeBase):
(WebCore::ElementData::presentationAttributeStyle):
(WebCore::ElementData::attributesIterator):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setupInitialView): Remove static_cast<SVGSVGElement*>

7:23 PM Changeset in webkit [173609] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Remove unnecessary overloads taking a ContainerNode in Element Traversal
​https://bugs.webkit.org/show_bug.cgi?id=136767

Reviewed by Darin Adler.

Remove unnecessary overloads taking a ContainerNode in Element Traversal.
Several of those don't bring any performance improvements as the needed
methods are defined on Node (not ContainerNode).

No new tests, no behavior change.

  • dom/ElementTraversal.h:

(WebCore::Traversal<Element>::previous):
NodeTraversal::previous() takes a const Node* in argument so the
ContainerNode overload is not needed.

(WebCore::Traversal<ElementType>::previous):
Unnecessary now that Traversal<Element>::previous() takes a const Node*
in argument.

(WebCore::Traversal<ElementType>::nextSibling):
nextSibling() is defined on Node, not ContainerNode, so the overload
is not needed.

(WebCore::Traversal<ElementType>::previousSibling):
previousSibling() is defined on Node, not ContainerNode, so the overload
is not needed.

(WebCore::Traversal<Element>::previousTemplate): Deleted.
(WebCore::Traversal<ElementType>::previousTemplate): Deleted.
(WebCore::Traversal<ElementType>::nextSiblingTemplate): Deleted.
(WebCore::Traversal<ElementType>::previousSiblingTemplate): Deleted.
No need to have those functions templated anymore.

6:51 PM Changeset in webkit [173608] by dbates@webkit.org
  • 5 edits in trunk/Source

[iOS] Attempt to fix the iOS build after <​http://trac.webkit.org/changeset/173606>
(​https://bugs.webkit.org/show_bug.cgi?id=136789)

Substitute Node::countChildNodes() for Node::childNodeCount() in more places.

Source/WebCore:

Although I updated a comment in WebCore::lastOffsetForEditing() (defined in file
editing/htmlediting.cpp) to refer to Node::countChildNodes(), I'm unclear what the
comment is trying to explain that isn't otherwise explained by the code or the
comments that precede this function. Specifically, I don't understand the use of
the word "preempt" in the comment. We should look to improve the readability of
this comment.

  • editing/htmlediting.cpp:

(WebCore::lastOffsetForEditing):

  • page/ios/FrameIOS.mm:

(WebCore::Frame::interpretationsForCurrentRoot):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame focusedNodeHasContent]):

3:19 PM Changeset in webkit [173607] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Drop NodeTraversal::nextSkippingChildren() overload taking a ContainerNode
​https://bugs.webkit.org/show_bug.cgi?id=136764

Reviewed by Darin Adler.

Drop NodeTraversal::nextSkippingChildren() overload taking a
ContainerNode argument. This one does not bring any performance
improvement because nextSibling() is defined on Node and
nextAncestorSibling() takes a Node in argument.

Also remove the overload in ElementTraversal as it no longer makes
sense after this change.

No new tests, no behavior change.

  • dom/ElementTraversal.h:

(WebCore::Traversal<ElementType>::nextSkippingChildren):
(WebCore::Traversal<ElementType>::nextSkippingChildrenTemplate): Deleted.

  • dom/NodeTraversal.h:

(WebCore::NodeTraversal::nextSkippingChildren):
(WebCore::NodeTraversal::next):
(WebCore::NodeTraversal::traverseNextSkippingChildrenTemplate): Deleted.

2:18 PM Changeset in webkit [173606] by Chris Dumez
  • 31 edits in trunk/Source

Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
​https://bugs.webkit.org/show_bug.cgi?id=136789

Reviewed by Darin Adler.

Source/WebCore:

Rename Node::childNodeCount() to countChildNodes() to make it clearer
that the method actually computes the result rather than returning a
cached value.

This patch also introduces a new Node::hasOneChild() method that is
used to check if a Node has a single child. This is much more efficient
than calling countChildNodes() == 1.

The patch also leverages Node::hasChildNodes() in a lot of places
instead of calling countChildNodes().

Finally, in a couple of places, we now use childrenOfType() to iterate
over children more efficient than using countChildNodes() and
childNode(index).

No new tests, no behavior change.

  • WebCore.exp.in:
  • WebCore.order:

Update the name of the exposed symbol for countChildNodes().

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::countChildNodes):
(WebCore::ContainerNode::childNodeCount): Deleted.
Rename childNodeCount() to countChildNodes() to make it obvious it is
computing the result rather than returning a cached value.

  • dom/ContainerNode.h:

(WebCore::ContainerNode::hasOneChild):
Introduce an efficient way to check in a ContainerNode has a single
child as "countChildNodes() == 1" calls were frequent and inefficient.

(WebCore::Node::countChildNodes):
(WebCore::Node::childNodeCount): Deleted.

  • dom/Node.h:

Rename childNodeCount() to countChildNodes().

  • dom/Position.cpp:

(WebCore::Position::parentAnchoredEquivalent):

  • dom/Position.h:

(WebCore::lastOffsetInNode):

  • dom/Range.cpp:

Mechanical renaming.

(WebCore::lengthOfContentsInNode):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::shouldApplyInlineStyleToRun):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
(WebCore::ApplyStyleCommand::applyInlineStyleChange):
Call hasChildNodes() rather than countChildNodes() as it is a lot more
efficient.

  • editing/Editor.cpp:

(WebCore::Editor::setTextAsChildOfElement):
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::elementRangeContainingCaretSelection):
Mechanical renaming.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::insertAsListItems):
Call hasOneChild() instead of countChildNodes() == 1. Also remove
redundant listElement->hasChildNodes() check as hasOneChild() takes
care of this already.

  • editing/TextIterator.cpp:

(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):

  • editing/VisibleUnits.cpp:

(WebCore::endOfDocument):

  • editing/htmlediting.cpp:

(WebCore::lastOffsetForEditing):
Mechanical renaming.

(WebCore::visiblePositionBeforeNode):
(WebCore::visiblePositionAfterNode):
Call hasChildNodes() instead of converting countChildNodes() to a
boolean.

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):
Call !hasChildNodes() instead of !countChildNodes().

(WebCore::isPlainTextMarkup):

  • Drop !node->isElementNode() check as !node->hasTagName(divTag) takes care of discarding non-Element Nodes already.
  • Cast the Node to an HTMLDivElement as soon as possible to avoid calling calling the slower Node APIs in several cases.
  • Call hasOneChild() instead of countChildNodes() == 1.
  • html/HTMLDivElement.h:
  • html/HTMLTagNames.in:

Generate casting helpers as I use them in WebCore::isPlainTextMarkup().

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::setText):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::setText):
Call hasOneChild() / hasChildNodes() instead of countChildNodes().

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTimelineContainerElement::setTimeDisplaysHidden):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
Use childrenOfType<Element>() to iterate of child Elements instead of
slower childNodeCount() + childNode(index) + isElementNode(). Also,
childNodeCount() was not even cached before the loop.

  • html/track/VTTRegion.cpp:

(WebCore::VTTRegion::displayLastTextTrackCueBox):
Use childrenOfType<Element>() to iterate of child Elements, thus
avoiding calling childNodeCount() + childNode(index).

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::extend):
(WebCore::DOMSelection::selectAllChildren):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::caretMaxOffset):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::isSelected):

  • rendering/RenderView.cpp:

(WebCore::RenderView::splitSelectionBetweenSubtrees):
Mechanical renaming.

Source/WebKit/mac:

Rename childNodeCount() to countChildNodes().

  • WebView/WebHTMLView.mm:

(-[WebHTMLView attributedString]):

Source/WebKit2:

Avoid calling slow Node::countChildNodes().

  • WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp:

(WebKit::WebPage::findZoomableAreaForPoint):
Replace call to "node->parentNode()->childNodeCount() != 1" by
"!node->parentNode()->hasOneChild()" which is equivalent but more
efficient.

Sep 13, 2014:

4:21 PM Changeset in webkit [173605] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Un-inline Element constructor
​https://bugs.webkit.org/show_bug.cgi?id=136786

Reviewed by Benjamin Poulain.

Un-inline Element constructor as it is non-trivial and it does not seem
to impact performance based on my testing:
​http://dromaeo.com/?id=226865,226869

This reduces the stripped binary size by 8 Kb.

No new tests, no behavior change.

  • dom/Element.cpp:

(WebCore::Element::Element):

  • dom/Element.h:

(WebCore::Element::Element): Deleted.

11:59 AM Changeset in webkit [173604] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.24

New tag.

11:56 AM Changeset in webkit [173603] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

9:46 AM Changeset in webkit [173602] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1-branch/Source

Merged r173595. <rdar://problem/18324338>

9:26 AM Changeset in webkit [173601] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Merge JSGlobalObject::reset() into ::init()
​https://bugs.webkit.org/show_bug.cgi?id=136800

Reviewed by Oliver Hunt.

Moved the contents of reset() into init().
Note that the diff shows more changes.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init): Moved body of reset() into init.
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::defineOwnProperty):
(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):
(JSC::lastInPrototypeChain):
(JSC::JSGlobalObject::reset): Deleted.

  • runtime/JSGlobalObject.h:

Sep 12, 2014:

10:21 PM Changeset in webkit [173600] by msaboff@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Add JSCallee to program and eval CallFrames
​https://bugs.webkit.org/show_bug.cgi?id=136785

Reviewed by Mark Lam.

Populated Callee slot for program and call eval CallFrames with a JSCallee objects.
Made supporting changes including adding a JSCallee structure to global object and adding
JSCallee::create() method. Added code so that the newly added callee object won't be
returned by Function.caller. Changed null pointer checks of callee to check the if
the type is JSFunction* or JSCallee*.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::type):

  • profiler/LegacyProfiler.cpp:

(JSC::LegacyProfiler::createCallIdentifier):

  • interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):
Changed checks of callee is a JSFunction* or JSCallee* instead of just checking
if it is null or not.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute): Create and use JSCallee objects for execute(EvalExecutable, ...)
and execute(ProgramExecutable, ...)

  • jit/JITCode.cpp:

(JSC::JITCode::execute): Use jsDynamicCast to cast only JSFunctions.

  • runtime/JSCallee.cpp:

(JSC::JSCallee::create): Not used, therefore deleted.

  • runtime/JSCallee.h:

(JSC::JSCallee::create): Added.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::callerGetter): Added test to return null for JSCallee's that aren't
JSFunction's. This can only be the case when the JSCallee comes from a program or
call eval CallFrame.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::calleeStructure):
Added new JSCallee structure.

7:18 PM Changeset in webkit [173599] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix with REQUEST_AUTOCOMPLETE enabled

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::requestAutocomplete):
(WebCore::HTMLFormElement::finishRequestAutocomplete):

6:06 PM Changeset in webkit [173598] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

6:03 PM Changeset in webkit [173597] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.23

New Tag.

6:01 PM Changeset in webkit [173596] by jhoneycutt@apple.com
  • 30 edits
    6 adds in trunk

Re-add the request autocomplete feature

<​https://bugs.webkit.org/show_bug.cgi?id=136730>

This feature was rolled out in r148731 because it was only used by
Chromium. As we consider supporting this feature, roll it back in, but
leave it disabled.

This rolls out r148731 (which removed the feature) with small changes
Source/JavaScriptCore:

needed to make the code build in ToT, to match modern style, to make
the tests run, and to remove unused code.

Reviewed by Andy Estes.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

needed to make the code build in ToT, to match modern style, to make
the tests run, and to remove unused code.

Reviewed by Andy Estes.

Tests: fast/events/constructors/autocomplete-error-event-constructor.html

fast/forms/form-request-autocomplete.html

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/AutocompleteErrorEvent.h: Added.

(WebCore::AutocompleteErrorEvent::create):
(WebCore::AutocompleteErrorEvent::reason):
(WebCore::AutocompleteErrorEvent::AutocompleteErrorEvent):

  • dom/AutocompleteErrorEvent.idl: Added.
  • dom/EventNames.h:
  • dom/EventNames.in:
  • html/HTMLAttributeNames.in:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore::HTMLFormElement::requestAutocomplete):
(WebCore::HTMLFormElement::finishRequestAutocomplete):
(WebCore::HTMLFormElement::requestAutocompleteTimerFired):
(WebCore::HTMLFormElement::parseAttribute):

  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl:
  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:
  • page/DOMWindow.idl:

Source/WebKit/mac:

needed to make the code build in ToT, to match modern style, to make
the tests run, and to remove unused code.

Reviewed by Andy Estes.

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

needed to make the code build in ToT, to match modern style, to make
the tests run, and to remove unused code.

Reviewed by Andy Estes.

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didRequestAutocomplete):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WTF:

needed to make the code build in ToT, to make the tests run, and to
remove unused code.

Reviewed by Andy Estes.

  • wtf/FeatureDefines.h:

LayoutTests:

needed to make the code build in ToT, to match modern style, to make
the tests run, and to remove unused code.

Reviewed by Andy Estes.

  • fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
  • fast/events/constructors/autocomplete-error-event-constructor.html: Added.
  • fast/events/event-creation.html:
  • fast/forms/form-request-autocomplete-expected.txt: Added.
  • fast/forms/form-request-autocomplete.html: Added.
  • js/dom/constructor-length.html:
  • platform/efl/js/dom/constructor-length-expected.txt:
  • platform/gtk/js/dom/constructor-length-expected.txt:
5:59 PM Changeset in webkit [173595] by timothy_horton@apple.com
  • 5 edits in trunk/Source

Swiping back from a Twitter image to Twitter flashes to the wrong position
​https://bugs.webkit.org/show_bug.cgi?id=136798
<rdar://problem/18324338>

Reviewed by Darin Adler and Sam Weinig.

  • UIProcess/mac/ViewGestureController.h:
  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::didFinishLoadForMainFrame):
(WebKit::ViewGestureController::didSameDocumentNavigationForMainFrame):
Add a 250ms repeating timer that we start in didFinishLoadForMainFrame
if we are for some reason still loading, and in didSameDocumentNavigationForMainFrame
unconditionally, to match behavior of the old swipe implementation.

Also, do the active gesture check in both of those places so that we don't
start the timer if we're in the middle of a live swipe or have already torn
down the snapshot (removeSwipeSnapshotAfterRepaint does this as well, so
this isn't really a behavior change).

(WebKit::ViewGestureController::activeLoadMonitoringTimerFired):
Every time the timer fires, check if we're still loading; if not,
tear down the swipe snapshot (after repainting).

(WebKit::ViewGestureController::removeSwipeSnapshotAfterRepaint):
Stop the active load monitoring timer.

  • wtf/RunLoop.h:

(WTF::RunLoop::TimerBase::startRepeating):
Add a std::chrono veresion of RunLoop::TimerBase::startRepeating.

5:35 PM Changeset in webkit [173594] by Brian Burg
  • 2 edits in trunk/Tools

Web Inspector: remind about rebaselining generator test results
​https://bugs.webkit.org/show_bug.cgi?id=136759

Reviewed by Joseph Pecoraro.

For now, we can implement this as a watchlist message. Add watchlist
groups and messages for the inspector and web replay generators.

  • Scripts/webkitpy/common/config/watchlist:
5:24 PM Changeset in webkit [173593] by ap@apple.com
  • 2 edits in trunk/Tools

build.webkit.org/dashboard: Overlapping text when status is long
​https://bugs.webkit.org/show_bug.cgi?id=136794

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:

(.status-line): Replaces height with min-height.

5:09 PM Changeset in webkit [173592] by Yusuke Suzuki
  • 2 edits
    2 adds in trunk/LayoutTests

Add -webkit-appearance and pseudo element tests for quirks mode
​https://bugs.webkit.org/show_bug.cgi?id=136366

Reviewed by Benjamin Poulain.

  • fast/css/appearance-with-pseudo-elements-expected.html:

-webkit-appearance in OSX affects the ::first-letter related style informations (such as font).
So expected.html also requires these styles.

  • fast/css/appearance-with-pseudo-elements-in-quirks-mode-expected.html: Added.
  • fast/css/appearance-with-pseudo-elements-in-quirks-mode.html: Added.
5:07 PM Changeset in webkit [173591] by vivek.vg@samsung.com
  • 3 edits
    2 adds in trunk

CanvasRenderingContext2D should update the computed style while setting the font
​https://bugs.webkit.org/show_bug.cgi?id=136737

Reviewed by Darin Adler.

Source/WebCore:

Before accessing the computed style for populating 'font' property of CanvasRenderingContext2D
make sure to have an up-to-date computed style avoiding any stale reference.

Test: fast/canvas/canvas-set-font-with-updated-style.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

LayoutTests:

  • fast/canvas/canvas-set-font-with-updated-style-expected.txt: Added.
  • fast/canvas/canvas-set-font-with-updated-style.html: Added.
5:03 PM Changeset in webkit [173590] by Yusuke Suzuki
  • 4 edits
    2 adds in trunk

CSS JIT: Apply CSS JIT to SelectorQuery with multiple selectors
​https://bugs.webkit.org/show_bug.cgi?id=135255

Reviewed by Benjamin Poulain.

Source/WebCore:

After dropping SelectorCheckerFastPath, Dromaeo cssquery-jquery test
result becomes significantly worse. 400.26/s to 348.16/s, 13%
performance regression.

Investigated the cause of it and we found that the test results for
querySelector with multiple selectors causes performance regressions.

To solve this, we attempt to JIT compile all selectors in multiple
selectors. And if compiling some selectors is failed, SelectorQuery
fallbacks to the slower implementation.

This change improves the performance. After applying this patch,
cssquery-jquery test result becomes 418.71/s, 4.61% better than the
previous good performance case.

Test: fast/selectors/querySelector-multiple-selectors.html

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::SelectorDataList):
(WebCore::SelectorDataList::executeCompiledSingleMultiSelectorData):
(WebCore::SelectorDataList::execute):

  • dom/SelectorQuery.h:

LayoutTests:

  • fast/selectors/querySelector-multiple-selectors-expected.txt: Added.
  • fast/selectors/querySelector-multiple-selectors.html: Added.
4:47 PM Changeset in webkit [173589] by ggaren@apple.com
  • 2 edits in trunk/Source/bmalloc

Fixed a goof in bmalloc Vector sizing
​https://bugs.webkit.org/show_bug.cgi?id=136795

Reviewed by Gavin Barraclough and Sam Weinig.

We want our minimum vector to be page-sized since the OS will give us
a page no matter what -- but we want that many bytes, and not enough
bytes to store that many elements.

  • bmalloc/Vector.h: Math is hard.
4:37 PM Changeset in webkit [173588] by timothy@apple.com
  • 2 edits in trunk/Tools

Make Brian Burg a WebKit reviewer.

  • Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
4:33 PM Changeset in webkit [173587] by ap@apple.com
  • 3 edits in trunk/Tools

Multiple EWS or commit bots can pick up processing of the same patch
​https://bugs.webkit.org/show_bug.cgi?id=136793

Reviewed by Ryosuke Niwa.

Change timeout from one hour to two hours. This will let bots finish, and in the
unlikely event of a bot being frozen, will only delay patch processing restart by
one hour.

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
4:21 PM Changeset in webkit [173586] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r173584. rdar://problem/18324592

4:04 PM Changeset in webkit [173585] by jer.noble@apple.com
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed gardening.

  • Unskip some passing tests.
  • Move flakey tests into flakey test section.
  • Move non-media tests out of the media section.
  • Mark WontFix tests as such.
  • platform/mac/TestExpectations:
  • platform/mac/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
  • platform/mac/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
4:02 PM Changeset in webkit [173584] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Fullscreen] Taking embedded youtube video full screen takes the whole page full screen
​https://bugs.webkit.org/show_bug.cgi?id=136792

Reviewed by Beth Dakin.

Recalculate style after beginning the enter fullscreen animation, but before sending the
"webkitfullscreenchange" event to listeners.

  • dom/Document.cpp:

(WebCore::Document::webkitWillEnterFullScreenForElement):

3:48 PM Changeset in webkit [173583] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r173573. <rdar://problem/18314597>

3:41 PM Changeset in webkit [173582] by dino@apple.com
  • 2 edits
    415 adds in trunk/LayoutTests

Import (some of) the W3C CSSWG flexbox tests
​https://bugs.webkit.org/show_bug.cgi?id=136787
<rdar://problem/18325725>

Reviewed by Benjamin Poulain.

Take most of the tests from ​http://test.csswg.org/suites/css3-flexbox/nightly-unstable/html/toc.htm
and import them into LayoutTests.

I had to rearrange some things to follow our testing approach,
and I only included the ref tests. There are a handful of failures,
marked in TestExpectations, and tracked by:
​https://bugs.webkit.org/show_bug.cgi?id=136754

  • TestExpectations:
  • css3/flexbox/csswg/Flexible-order-expected.html: Added.
  • css3/flexbox/csswg/Flexible-order.html: Added.
  • css3/flexbox/csswg/align-content-001-expected.html: Added.
  • css3/flexbox/csswg/align-content-001.html: Added.
  • css3/flexbox/csswg/css-box-justify-content-expected.html: Added.
  • css3/flexbox/csswg/css-box-justify-content.html: Added.
  • css3/flexbox/csswg/css-flexbox-column-expected.html: Added.
  • css3/flexbox/csswg/css-flexbox-column.html: Added.
  • css3/flexbox/csswg/css-flexbox-height-animation-stretch-expected.html: Added.
  • css3/flexbox/csswg/css-flexbox-height-animation-stretch.html: Added.
  • css3/flexbox/csswg/css-flexbox-img-expand-evenly-expected.html: Added.
  • css3/flexbox/csswg/css-flexbox-img-expand-evenly.html: Added.
  • css3/flexbox/csswg/css-flexbox-row-expected.html: Added.
  • css3/flexbox/csswg/css-flexbox-row.html: Added.
  • css3/flexbox/csswg/css-flexbox-test1-expected.html: Added.
  • css3/flexbox/csswg/css-flexbox-test1.html: Added.
  • css3/flexbox/csswg/flex-align-items-center-expected.html: Added.
  • css3/flexbox/csswg/flex-align-items-center.html: Added.
  • css3/flexbox/csswg/flex-box-wrap-expected.html: Added.
  • css3/flexbox/csswg/flex-box-wrap.html: Added.
  • css3/flexbox/csswg/flex-container-margin-expected.html: Added.
  • css3/flexbox/csswg/flex-container-margin.html: Added.
  • css3/flexbox/csswg/flex-direction-expected.html: Added.
  • css3/flexbox/csswg/flex-direction-modify-expected.html: Added.
  • css3/flexbox/csswg/flex-direction-modify.html: Added.
  • css3/flexbox/csswg/flex-direction-with-element-insert-expected.html: Added.
  • css3/flexbox/csswg/flex-direction-with-element-insert.html: Added.
  • css3/flexbox/csswg/flex-direction-with-element-insert.html-expected.html: Added.
  • css3/flexbox/csswg/flex-direction.html: Added.
  • css3/flexbox/csswg/flex-direction.html-expected.html: Added.
  • css3/flexbox/csswg/flex-flexitem-childmargin-expected.html: Added.
  • css3/flexbox/csswg/flex-flexitem-childmargin.html: Added.
  • css3/flexbox/csswg/flex-flexitem-percentage-prescation-expected.html: Added.
  • css3/flexbox/csswg/flex-flexitem-percentage-prescation.html: Added.
  • css3/flexbox/csswg/flex-flow-001-expected.html: Added.
  • css3/flexbox/csswg/flex-flow-001.html: Added.
  • css3/flexbox/csswg/flex-flow-002-expected.html: Added.
  • css3/flexbox/csswg/flex-flow-002.html: Added.
  • css3/flexbox/csswg/flex-flow-007-expected.html: Added.
  • css3/flexbox/csswg/flex-flow-007.html: Added.
  • css3/flexbox/csswg/flex-items-flexibility-expected.html: Added.
  • css3/flexbox/csswg/flex-items-flexibility.html: Added.
  • css3/flexbox/csswg/flex-items-flexibility.html-expected.html: Added.
  • css3/flexbox/csswg/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html: Added.
  • css3/flexbox/csswg/flex-lines/multi-line-wrap-reverse-column-reverse.html: Added.
  • css3/flexbox/csswg/flex-lines/multi-line-wrap-reverse-row-reverse-expected.html: Added.
  • css3/flexbox/csswg/flex-lines/multi-line-wrap-reverse-row-reverse.html: Added.
  • css3/flexbox/csswg/flex-lines/multi-line-wrap-with-column-reverse-expected.html: Added.
  • css3/flexbox/csswg/flex-lines/multi-line-wrap-with-column-reverse.html: Added.
  • css3/flexbox/csswg/flex-lines/multi-line-wrap-with-row-reverse-expected.html: Added.
  • css3/flexbox/csswg/flex-lines/multi-line-wrap-with-row-reverse.html: Added.
  • css3/flexbox/csswg/flex-margin-no-collapse-expected.html: Added.
  • css3/flexbox/csswg/flex-margin-no-collapse.html: Added.
  • css3/flexbox/csswg/flex-order-expected.html: Added.
  • css3/flexbox/csswg/flex-order.html: Added.
  • css3/flexbox/csswg/flex-vertical-align-effect-expected.html: Added.
  • css3/flexbox/csswg/flex-vertical-align-effect.html: Added.
  • css3/flexbox/csswg/flex-vertical-align-effect.html-expected.html: Added.
  • css3/flexbox/csswg/flexbox-flex-wrap-flexing-expected.html: Added.
  • css3/flexbox/csswg/flexbox-flex-wrap-flexing.html: Added.
  • css3/flexbox/csswg/flexbox-flex-wrap-nowrap-expected.html: Added.
  • css3/flexbox/csswg/flexbox-flex-wrap-nowrap.html: Added.
  • css3/flexbox/csswg/flexbox_absolute-atomic-expected.html: Added.
  • css3/flexbox/csswg/flexbox_absolute-atomic.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-center-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-center.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-flexend-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-flexend.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-flexstart-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-flexstart.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-spacearound-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-spacearound.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-spacebetween-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-spacebetween.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-stretch-2-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-stretch-2.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-stretch-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-content-stretch.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-baseline-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-baseline.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-center-2-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-center-2.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-center-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-center.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-flexend-2-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-flexend-2.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-flexend-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-flexend.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-flexstart-2-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-flexstart-2.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-flexstart-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-flexstart.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-stretch-2-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-stretch-2.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-stretch-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-items-stretch.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-auto.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-baseline-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-baseline.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-center-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-center.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-flexend-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-flexend.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-flexstart-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-flexstart.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-stretch-expected.html: Added.
  • css3/flexbox/csswg/flexbox_align-self-stretch.html: Added.
  • css3/flexbox/csswg/flexbox_box-clear-expected.html: Added.
  • css3/flexbox/csswg/flexbox_box-clear.html: Added.
  • css3/flexbox/csswg/flexbox_columns-expected.html: Added.
  • css3/flexbox/csswg/flexbox_columns-flexitems-2-expected.html: Added.
  • css3/flexbox/csswg/flexbox_columns-flexitems-2.html: Added.
  • css3/flexbox/csswg/flexbox_columns-flexitems-expected.html: Added.
  • css3/flexbox/csswg/flexbox_columns-flexitems.html: Added.
  • css3/flexbox/csswg/flexbox_columns.html: Added.
  • css3/flexbox/csswg/flexbox_direction-column-expected.html: Added.
  • css3/flexbox/csswg/flexbox_direction-column-reverse-expected.html: Added.
  • css3/flexbox/csswg/flexbox_direction-column-reverse.html: Added.
  • css3/flexbox/csswg/flexbox_direction-column.html: Added.
  • css3/flexbox/csswg/flexbox_direction-row-reverse-expected.html: Added.
  • css3/flexbox/csswg/flexbox_direction-row-reverse.html: Added.
  • css3/flexbox/csswg/flexbox_display-expected.html: Added.
  • css3/flexbox/csswg/flexbox_display.html: Added.
  • css3/flexbox/csswg/flexbox_empty-expected.html: Added.
  • css3/flexbox/csswg/flexbox_fbfc-expected.html: Added.
  • css3/flexbox/csswg/flexbox_fbfc.html: Added.
  • css3/flexbox/csswg/flexbox_fbfc2-expected.html: Added.
  • css3/flexbox/csswg/flexbox_fbfc2.html: Added.
  • css3/flexbox/csswg/flexbox_first-line-expected.html: Added.
  • css3/flexbox/csswg/flexbox_first-line.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-0-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-0.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-N-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-N-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-N-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-N.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-Npercent-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-Npercent-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-Npercent-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-Npercent.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-auto-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-auto-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-0-auto.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-0-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-0.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-N-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-N-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-N-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-N.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-Npercent-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-Npercent-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-Npercent-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-Npercent.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-auto-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-auto-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-1-auto.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-0-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-0.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-N-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-N-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-N-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-N.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-Npercent-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-Npercent-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-Npercent-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-Npercent.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-auto-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-auto-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-0-N-auto.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-0-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-0.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-N-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-N-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-N-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-N.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-Npercent-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-Npercent-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-Npercent-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-Npercent.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-auto-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-auto-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-0-auto.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-0-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-0.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-N-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-N-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-N-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-N.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-Npercent-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-Npercent-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-Npercent-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-Npercent.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-auto-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-auto-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-1-auto.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-0-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-0.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-N-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-N-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-N-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-N.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-Npercent-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-Npercent-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-Npercent-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-Npercent.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-auto-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-auto-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-1-N-auto.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-0-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-0.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-N-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-N-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-N-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-N.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-Npercent-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-Npercent-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-Npercent-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-Npercent.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-auto-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-auto-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-0-auto.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-0-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-0.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-N-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-N-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-N-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-N.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-Npercent-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-Npercent-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-Npercent-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-Npercent.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-auto-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-auto-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-1-auto.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-0-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-0.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-N-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-N-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-N-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-N.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-Npercent-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-Npercent-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-Npercent-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-Npercent.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-auto-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-auto-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-N-N-auto.html: Added.
  • css3/flexbox/csswg/flexbox_flex-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-auto.html: Added.
  • css3/flexbox/csswg/flexbox_flex-basis-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-basis-shrink-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-basis-shrink.html: Added.
  • css3/flexbox/csswg/flexbox_flex-basis.html: Added.
  • css3/flexbox/csswg/flexbox_flex-formatting-interop-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-formatting-interop.html: Added.
  • css3/flexbox/csswg/flexbox_flex-initial-2-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-initial-2.html: Added.
  • css3/flexbox/csswg/flexbox_flex-initial-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-initial.html: Added.
  • css3/flexbox/csswg/flexbox_flex-natural-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-natural-mixed-basis-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-natural-mixed-basis-auto.html: Added.
  • css3/flexbox/csswg/flexbox_flex-natural-mixed-basis-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-natural-mixed-basis.html: Added.
  • css3/flexbox/csswg/flexbox_flex-natural-variable-auto-basis-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-natural-variable-auto-basis.html: Added.
  • css3/flexbox/csswg/flexbox_flex-natural-variable-zero-basis-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-natural-variable-zero-basis.html: Added.
  • css3/flexbox/csswg/flexbox_flex-natural.html: Added.
  • css3/flexbox/csswg/flexbox_flex-none-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flex-none.html: Added.
  • css3/flexbox/csswg/flexbox_flex-unitless-basis-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flow-column-reverse-wrap-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flow-column-reverse-wrap-reverse-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flow-column-reverse-wrap-reverse.html: Added.
  • css3/flexbox/csswg/flexbox_flow-column-reverse-wrap.html: Added.
  • css3/flexbox/csswg/flexbox_flow-column-wrap-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flow-column-wrap-reverse-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flow-column-wrap-reverse.html: Added.
  • css3/flexbox/csswg/flexbox_flow-column-wrap.html: Added.
  • css3/flexbox/csswg/flexbox_flow-row-wrap-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flow-row-wrap-reverse-expected.html: Added.
  • css3/flexbox/csswg/flexbox_flow-row-wrap-reverse.html: Added.
  • css3/flexbox/csswg/flexbox_flow-row-wrap.html: Added.
  • css3/flexbox/csswg/flexbox_generated-container-expected.html: Added.
  • css3/flexbox/csswg/flexbox_generated-container.html: Added.
  • css3/flexbox/csswg/flexbox_generated-expected.html: Added.
  • css3/flexbox/csswg/flexbox_generated-flex-expected.html: Added.
  • css3/flexbox/csswg/flexbox_generated-flex.html: Added.
  • css3/flexbox/csswg/flexbox_generated.html: Added.
  • css3/flexbox/csswg/flexbox_inline-expected.html: Added.
  • css3/flexbox/csswg/flexbox_inline.html: Added.
  • css3/flexbox/csswg/flexbox_item-bottom-float-expected.html: Added.
  • css3/flexbox/csswg/flexbox_item-bottom-float.html: Added.
  • css3/flexbox/csswg/flexbox_item-clear-expected.html: Added.
  • css3/flexbox/csswg/flexbox_item-clear.html: Added.
  • css3/flexbox/csswg/flexbox_item-float-expected.html: Added.
  • css3/flexbox/csswg/flexbox_item-float.html: Added.
  • css3/flexbox/csswg/flexbox_item-top-float-expected.html: Added.
  • css3/flexbox/csswg/flexbox_item-top-float.html: Added.
  • css3/flexbox/csswg/flexbox_item-vertical-align-expected.html: Added.
  • css3/flexbox/csswg/flexbox_item-vertical-align.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-center-expected.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-center-overflow-expected.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-center-overflow.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-center.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-flex-end-expected.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-flex-end.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-flex-start-expected.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-flex-start.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacearound-expected.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacearound-negative-expected.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacearound-negative.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacearound-only-expected.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacearound-only.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacearound.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacebetween-expected.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacebetween-negative-expected.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacebetween-negative.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacebetween-only-expected.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacebetween-only.html: Added.
  • css3/flexbox/csswg/flexbox_justifycontent-spacebetween.html: Added.
  • css3/flexbox/csswg/flexbox_margin-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_margin-auto-overflow-2-expected.html: Added.
  • css3/flexbox/csswg/flexbox_margin-auto-overflow-2.html: Added.
  • css3/flexbox/csswg/flexbox_margin-auto-overflow-expected.html: Added.
  • css3/flexbox/csswg/flexbox_margin-auto-overflow.html: Added.
  • css3/flexbox/csswg/flexbox_margin-auto.html: Added.
  • css3/flexbox/csswg/flexbox_margin-collapse-expected.html: Added.
  • css3/flexbox/csswg/flexbox_margin-collapse.html: Added.
  • css3/flexbox/csswg/flexbox_margin-expected.html: Added.
  • css3/flexbox/csswg/flexbox_margin-left-ex-expected.html: Added.
  • css3/flexbox/csswg/flexbox_margin-left-ex.html: Added.
  • css3/flexbox/csswg/flexbox_margin.html: Added.
  • css3/flexbox/csswg/flexbox_min-height-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_min-height-auto.html: Added.
  • css3/flexbox/csswg/flexbox_min-width-auto-expected.html: Added.
  • css3/flexbox/csswg/flexbox_min-width-auto.html: Added.
  • css3/flexbox/csswg/flexbox_object-expected.html: Added.
  • css3/flexbox/csswg/flexbox_object.html: Added.
  • css3/flexbox/csswg/flexbox_order-abspos-space-around-expected.html: Added.
  • css3/flexbox/csswg/flexbox_order-abspos-space-around.html: Added.
  • css3/flexbox/csswg/flexbox_order-box-expected.html: Added.
  • css3/flexbox/csswg/flexbox_order-box.html: Added.
  • css3/flexbox/csswg/flexbox_order-expected.html: Added.
  • css3/flexbox/csswg/flexbox_order.html: Added.
  • css3/flexbox/csswg/flexbox_rowspan-expected.html: Added.
  • css3/flexbox/csswg/flexbox_rowspan.html: Added.
  • css3/flexbox/csswg/flexbox_rtl-direction-expected.html: Added.
  • css3/flexbox/csswg/flexbox_rtl-direction.html: Added.
  • css3/flexbox/csswg/flexbox_rtl-flow-expected.html: Added.
  • css3/flexbox/csswg/flexbox_rtl-flow-reverse-expected.html: Added.
  • css3/flexbox/csswg/flexbox_rtl-flow-reverse.html: Added.
  • css3/flexbox/csswg/flexbox_rtl-flow.html: Added.
  • css3/flexbox/csswg/flexbox_rtl-order-expected.html: Added.
  • css3/flexbox/csswg/flexbox_rtl-order.html: Added.
  • css3/flexbox/csswg/flexbox_stf-table-singleline-expected.html: Added.
  • css3/flexbox/csswg/flexbox_stf-table-singleline.html: Added.
  • css3/flexbox/csswg/flexbox_visibility-collapse-expected.html: Added.
  • css3/flexbox/csswg/flexbox_visibility-collapse-line-wrapping-expected.html: Added.
  • css3/flexbox/csswg/flexbox_visibility-collapse-line-wrapping.html: Added.
  • css3/flexbox/csswg/flexbox_visibility-collapse.html: Added.
  • css3/flexbox/csswg/flexbox_wrap-expected.html: Added.
  • css3/flexbox/csswg/flexbox_wrap-long-expected.html: Added.
  • css3/flexbox/csswg/flexbox_wrap-long.html: Added.
  • css3/flexbox/csswg/flexbox_wrap-reverse-expected.html: Added.
  • css3/flexbox/csswg/flexbox_wrap-reverse.html: Added.
  • css3/flexbox/csswg/flexbox_wrap.html: Added.
  • css3/flexbox/csswg/flexbox_writing_mode_vertical_lays_out_contents_from_top_to_bottom-expected.html: Added.
  • css3/flexbox/csswg/flexbox_writing_mode_vertical_lays_out_contents_from_top_to_bottom.html: Added.
  • css3/flexbox/csswg/justify-content-001-expected.html: Added.
  • css3/flexbox/csswg/justify-content-001.html: Added.
  • css3/flexbox/csswg/order/order-with-column-reverse-expected.html: Added.
  • css3/flexbox/csswg/order/order-with-column-reverse.html: Added.
  • css3/flexbox/csswg/order/order-with-row-reverse-expected.html: Added.
  • css3/flexbox/csswg/order/order-with-row-reverse.html: Added.
  • css3/flexbox/csswg/ref-filled-green-100px-square-expected.html: Added.
  • css3/flexbox/csswg/ref-filled-green-100px-square.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-align-content-center-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-align-content-center.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-align-content-end-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-align-content-end.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-align-content-space-between-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-align-content-space-between.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-align-content-start-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-align-content-start.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-base-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-base.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-direction-column-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-direction-column-reverse-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-direction-column-reverse.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-direction-column.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-direction-row-reverse-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-direction-row-reverse.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-inline-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-inline.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-order-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-order.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-wrap-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-wrap-reverse-expected.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-wrap-reverse.html: Added.
  • css3/flexbox/csswg/ttwf-reftest-flex-wrap.html: Added.
3:20 PM Changeset in webkit [173581] by commit-queue@webkit.org
  • 14 edits in trunk/Source

Unreviewed, rolling out r173575.
​https://bugs.webkit.org/show_bug.cgi?id=136790

Failing tests (Requested by enrica on #webkit).

Reverted changeset:

"Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
​https://bugs.webkit.org/show_bug.cgi?id=136474
​http://trac.webkit.org/changeset/173575

3:00 PM Changeset in webkit [173580] by Julien Brianceau
  • 4 edits in trunk/Source/JavaScriptCore

[x86] moveDoubleToInts() does not clobber its source register anymore
​https://bugs.webkit.org/show_bug.cgi?id=131690

Reviewed by Oliver Hunt.

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::moveDoubleToInts):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueRep):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::returnDouble):

2:43 PM Changeset in webkit [173579] by dino@apple.com
  • 5 edits in trunk/Source/WebCore

Unprefix the flexbox CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=98420

Unreviewed fix up, that missed the original
commit. Tony Chang made some comments
on the bugzilla.

"justify-self" should not have been unprefixed.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

2:31 PM Changeset in webkit [173578] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. WebGL conformance test gardening.

  • platform/mac/TestExpectations:
2:29 PM Changeset in webkit [173577] by Csaba Osztrogonác
  • 2 edits in trunk

URTBF after r173574.

  • Source/cmake/WebKitMacros.cmake:
2:08 PM Changeset in webkit [173576] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for CLOOP build.

  • runtime/JSCallee.h:
2:07 PM Changeset in webkit [173575] by enrica@apple.com
  • 14 edits in trunk/Source

Remove PLATFORM(IOS) from WebCore/editing (Part 3).
​https://bugs.webkit.org/show_bug.cgi?id=136474

Reviewed by Benjamin Poulain.

This is the updated version of the patch that was landed in r173340.
I changed the use of IntPoint to FloatPoint since it was causing tests
to fail.
This patch removes the use of PLATFORM(IOS) from TextAffinity.h
and removes the assumption that EAffinity values match NSSelectionAffinity
values. It also removes the includes in TextAffinity.h, creating the need to
include explicitly the files when necessary. It also removes the unnecessary
use of platform specific types, replacing them with WebCore types.

Source/WebCore:

  • WebCore.exp.in:
  • editing/TextAffinity.h:

(kit): Deleted.
(core): Deleted.

  • editing/cocoa/HTMLConverter.mm:
  • page/mac/WebCoreFrameView.h:
  • platform/ios/ScrollViewIOS.mm:

(WebCore::ScrollView::platformSetScrollPosition):

  • platform/ios/wak/WAKScrollView.mm:

(-[WAKScrollView setScrollOrigin:updatePositionAtAll:immediately:]):
(-[WAKScrollView scrollOrigin]):

  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetScrollPosition):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:

(kit):
(core):

  • WebView/WebFrameView.mm:

(-[WebFrameView _scrollToBeginningOfDocument]):
(-[WebFrameView _scrollToEndOfDocument]):

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
  • WebProcess/WebPage/WKAccessibilityWebPageObjectIOS.mm:

(-[WKAccessibilityWebPageObject accessibilityHitTest:]):

2:05 PM Changeset in webkit [173574] by mitz@apple.com
  • 5 edits
    1 copy
    1 delete in trunk/Source/WebKit2

[Cocoa] Message generation scripts should be installed in WebKit.framework
​https://bugs.webkit.org/show_bug.cgi?id=136771

Reviewed by Anders Carlsson.

  • DerivedSources.make: Updated for rename of Scripts/webkit2 to Scripts/webkit.
  • Scripts/generate-message-receiver.py:

(main): Updated for rename from webkit2 to webkit.

  • Scripts/generate-messages-header.py:

(main): Ditto.

  • Scripts/webkit: Renamed from Source/WebKit2/Scripts/webkit2.
  • Scripts/webkit/messages.py: Updated for rename.
  • Scripts/webkit/parser.py: Ditto.
  • WebKit2.xcodeproj/project.pbxproj: Moved the Copy Message Generation Scripts build phase

from the WebKit2 target to the WebKit target and changed its destination to
WebKit.framework/PrivateHeaders/Scripts/webkit. Removed the Remove Compiled Python Files
build phase, since compiled files no longer get copied.

1:59 PM Changeset in webkit [173573] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Flash of page scrolled to wrong origin before restoring scroll position after swiping back to CNN front page from an article
​https://bugs.webkit.org/show_bug.cgi?id=136788
<rdar://problem/18314597>

Reviewed by Sam Weinig.

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::didHitRenderTreeSizeThreshold):
(WebKit::ViewGestureController::didFirstVisuallyNonEmptyLayoutForMainFrame):
Always wait until didFinishLoadForMainFrame or didSameDocumentNavigationForMainFrame
before removing the snapshot, because otherwise we don't know if the scroll
position has been restored yet.

We should revisit this at some point, because it should be possible to
determine if the scroll position has been restored appropriately, but for
now it is safest to restore the antique behavior.

1:46 PM Changeset in webkit [173572] by dino@apple.com
  • 27 edits in trunk

Unprefix the flexbox CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=98420

Reviewed by Benjamin Poulain.

Source/WebCore:

Remove the need for a "-webkit-" prefix on flexbox
and related properties. This includes:

  • align-content
  • align-items
  • align-self
  • flex-basis
  • flex-direction
  • flex-wrap
  • flex-grow
  • flex-shrink
  • flex
  • flex-flow
  • justify
  • order

... as well as the display keyword values "flex" and
"inline-flex".

  • css/CSSComputedStyleDeclaration.cpp: Change names.

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp: Ditto.

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):

  • css/CSSPrimitiveValueMappings.h: Since we need to still handle the old

keywords for display, this has added two new keywords.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EDisplay): If the older keywords were used in
content, map them to the new value names.

  • css/CSSPropertyNames.in: Add aliases for the prefixed properties.
  • css/CSSValueKeywords.in: Add "flex" and "inline-flex".
  • css/DeprecatedStyleBuilder.cpp: Change names.

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

  • css/StyleProperties.cpp: Change names.

(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::asText):

  • css/StylePropertyShorthand.cpp: Rename shorthand methods to remove the prefix.

(WebCore::flexFlowShorthand):
(WebCore::flexShorthand):
(WebCore::shorthandForProperty):
(WebCore::matchingShorthandsForLonghand):
(WebCore::webkitFlexFlowShorthand): Deleted.
(WebCore::webkitFlexShorthand): Deleted.

  • css/StylePropertyShorthand.h:
  • css/StyleResolver.cpp:

(WebCore::equivalentBlockDisplay):
(WebCore::StyleResolver::applyProperty):

  • page/animation/CSSPropertyAnimation.cpp: Change names.

(WebCore::PropertyWrapperFlex::PropertyWrapperFlex):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor): Handle the two new display values (the same way as
the old values).

  • rendering/style/RenderStyleConstants.h: Add constants for the new display values.

LayoutTests:

Now that we return "flex" instead of "-webkit-flex" (and similar
changes) update the tests that rely on this. Other than that,
we're still testing the prefixed content. A followup patch
will add tests for non-prefixed content.

  • css3/flexbox/display-flexbox-set-get-expected.txt:
  • css3/flexbox/display-flexbox-set-get.html:
  • css3/flexbox/flexitem.html:
  • fast/css-grid-layout/grid-item-display.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/resources/property-names.js:
  • fast/css/inherit-initial-shorthand-values-expected.txt:
  • fast/css/inherit-initial-shorthand-values.html:
  • svg/css/getComputedStyle-basic-expected.txt:
  • transitions/flex-transitions-expected.txt:
  • transitions/flex-transitions.html:
1:33 PM Changeset in webkit [173571] by Yusuke Suzuki
  • 18 edits
    2 adds in trunk

ASSERTION FAILED: e in WebCore::StyleResolver::adjustRenderStyle
​https://bugs.webkit.org/show_bug.cgi?id=136366

Reviewed by Benjamin Poulain.

Source/WebCore:

Since element becomes nullptr when resolving styles for pseudo elements,
so don't do ASSERT(e) and use pointer for that.

Test: fast/css/appearance-with-pseudo-elements.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderThumb::updateAppearance):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbSize):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):

  • platform/efl/RenderThemeEfl.h:
  • platform/gtk/RenderThemeGtk.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustCheckboxStyle):
(WebCore::RenderTheme::adjustRadioStyle):
(WebCore::RenderTheme::adjustButtonStyle):
(WebCore::RenderTheme::adjustInnerSpinButtonStyle):
(WebCore::RenderTheme::adjustTextFieldStyle):
(WebCore::RenderTheme::adjustTextAreaStyle):
(WebCore::RenderTheme::adjustMenuListStyle):
(WebCore::RenderTheme::adjustMeterStyle):
(WebCore::RenderTheme::adjustProgressBarStyle):
(WebCore::RenderTheme::adjustMenuListButtonStyle):
(WebCore::RenderTheme::adjustMediaControlStyle):
(WebCore::RenderTheme::adjustSliderTrackStyle):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSliderThumbSize):
(WebCore::RenderTheme::adjustSearchFieldStyle):
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderTheme::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle):

  • rendering/RenderTheme.h:
  • rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::adjustButtonStyle):
(WebCore::RenderThemeGtk::adjustMenuListStyle):
(WebCore::RenderThemeGtk::adjustMenuListButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
(WebCore::RenderThemeGtk::adjustSliderTrackStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeGtk::adjustProgressBarStyle):

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::adjustCheckboxStyle):
(WebCore::RenderThemeIOS::adjustRadioStyle):
(WebCore::RenderThemeIOS::adjustMenuListButtonStyle):
(WebCore::RenderThemeIOS::adjustSliderTrackStyle):
(WebCore::RenderThemeIOS::adjustSliderThumbSize):
(WebCore::RenderThemeIOS::adjustSearchFieldStyle):
(WebCore::RenderThemeIOS::adjustButtonStyle):

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeMac::adjustSliderThumbSize):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::adjustButtonStyle):
(WebCore::RenderThemeSafari::adjustTextFieldStyle):
(WebCore::RenderThemeSafari::adjustTextAreaStyle):
(WebCore::RenderThemeSafari::adjustMenuListStyle):
(WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbSize):
(WebCore::RenderThemeSafari::adjustSearchFieldStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeSafari::adjustMeterStyle):

  • rendering/RenderThemeSafari.h:
  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
(WebCore::RenderThemeWin::adjustSliderThumbSize):
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeWin::adjustMeterStyle):

  • rendering/RenderThemeWin.h:

LayoutTests:

  • fast/css/appearance-with-pseudo-elements-expected.html: Added.
  • fast/css/appearance-with-pseudo-elements.html: Added.
1:17 PM Changeset in webkit [173570] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix casing in method name - formatNumberForCustomCSSText
​https://bugs.webkit.org/show_bug.cgi?id=136758

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-12
Reviewed by Benjamin Poulain.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::formatNumberForcustomCSSText): Deleted.

  • css/CSSPrimitiveValue.h:
12:24 PM Changeset in webkit [173569] by Chris Dumez
  • 14 edits in trunk/Source/WebCore

Make all CSSSelector data members private
​https://bugs.webkit.org/show_bug.cgi?id=136784

Reviewed by Benjamin Poulain.

Make all CSSSelector data members private. Previously, some of the data
members such as m_relation / m_match / m_pseudoType were public and
accessed directly from outside the class. The new approach is better
because:

  • Those members are bit fields so by using getters, we can hide the casts inside the getters. The setters can now also check that the bitfield is big enough to actually store the enum value.
  • When using those in switch() statements, the compiler now complains if we fail to test some of the enum values as the value is now an enum, and not merely an unsigned integer.
  • Some of these members already has getters (e.g. relation()).
  • Better encapsulation.

No new tests, no behavior change.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::parsePagePseudoSelector):
(WebCore::CSSParserSelector::parsePseudoElementSelector):
(WebCore::CSSParserSelector::parsePseudoElementCueFunctionSelector):
(WebCore::CSSParserSelector::parsePseudoClassAndCompatibilityElementSelector):
(WebCore::CSSParserSelector::setPseudoClassValue):
(WebCore::CSSParserSelector::isSimple):
(WebCore::CSSParserSelector::prependTagSelector):

  • css/CSSParserValues.h:

(WebCore::CSSParserSelector::setMatch):
(WebCore::CSSParserSelector::setRelation):
(WebCore::CSSParserSelector::isPseudoElementCueFunction):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::createRareData):
(WebCore::CSSSelector::specificityForOneSelector):
(WebCore::CSSSelector::specificityForPage):
(WebCore::CSSSelector::operator==):
(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:

(WebCore::CSSSelector::setPseudoElementType):
(WebCore::CSSSelector::setPagePseudoType):
(WebCore::CSSSelector::pseudoClassType):
(WebCore::CSSSelector::setPseudoClassType):
(WebCore::CSSSelector::pseudoElementType):
(WebCore::CSSSelector::pagePseudoClassType):
(WebCore::CSSSelector::setRelation):
(WebCore::CSSSelector::match):
(WebCore::CSSSelector::setMatch):
(WebCore::CSSSelector::matchesPseudoElement):
(WebCore::CSSSelector::isUnknownPseudoElement):
(WebCore::CSSSelector::isCustomPseudoElement):
(WebCore::CSSSelector::isSiblingSelector):
(WebCore::CSSSelector::isAttributeSelector):
(WebCore::CSSSelector::setValue):
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagQName):
(WebCore::CSSSelector::value):

  • css/CSSSelectorList.cpp:

(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):

  • css/PageRuleCollector.cpp:

(WebCore::checkPageSelectorComponents):

  • css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::collectFeaturesFromSelector):

  • css/RuleSet.cpp:

(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::determinePropertyWhitelistType):
(WebCore::RuleSet::addRule):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):
(WebCore::anyAttributeMatches):
(WebCore::canMatchHoverOrActiveInQuirksMode):
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::checkScrollbarPseudoClass):
(WebCore::SelectorChecker::determineLinkMatchType):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::isCommonPseudoClassSelector):

  • css/SelectorFilter.cpp:

(WebCore::collectDescendantSelectorIdentifierHashes):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueMatching):

  • dom/SelectorQuery.cpp:

(WebCore::isSingleTagNameSelector):
(WebCore::isSingleClassNameSelector):
(WebCore::findIdMatchingType):
(WebCore::SelectorDataList::SelectorDataList):
(WebCore::selectorForIdLookup):
(WebCore::filterRootById):

12:08 PM Changeset in webkit [173568] by mitz@apple.com
  • 5 edits
    1 copy
    1 delete in trunk/Source/WebKit2

Build fix.

Reverted r173564.

  • DerivedSources.make:
  • Scripts/generate-message-receiver.py:

(main):

  • Scripts/generate-messages-header.py:

(main):

  • Scripts/webkit: Removed.
  • Scripts/webkit/LegacyMessageReceiver-expected.cpp: Removed.
  • Scripts/webkit/LegacyMessages-expected.h: Removed.
  • Scripts/webkit/MessageReceiver-expected.cpp: Removed.
  • Scripts/webkit/MessageReceiverSuperclass-expected.cpp: Removed.
  • Scripts/webkit/Messages-expected.h: Removed.
  • Scripts/webkit/MessagesSuperclass-expected.h: Removed.
  • Scripts/webkit/init.py: Removed.
  • Scripts/webkit/messages.py: Removed.
  • Scripts/webkit/messages_unittest.py: Removed.
  • Scripts/webkit/model.py: Removed.
  • Scripts/webkit/parser.py: Removed.
  • Scripts/webkit/test-legacy-messages.in: Removed.
  • Scripts/webkit/test-messages.in: Removed.
  • Scripts/webkit/test-superclass-messages.in: Removed.
  • Scripts/webkit2: Copied from Scripts/webkit2.
  • WebKit2.xcodeproj/project.pbxproj:
10:54 AM Changeset in webkit [173567] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove unneeded declarations from JSCallee.h
​https://bugs.webkit.org/show_bug.cgi?id=136783

Reviewed by Mark Lam.

  • runtime/JSCallee.h:

(JSCallee::name): Deleted.
(JSCallee::displayName): Deleted.
(JSCallee::calculatedDisplayName): Deleted.

10:53 AM Changeset in webkit [173566] by aestes@apple.com
  • 4 edits
    1 copy in trunk

[WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
​https://bugs.webkit.org/show_bug.cgi?id=136768

Reviewed by Tim Horton.

Source/WebKit2:

WKImageCreateFromCGImage can return null, so it only seems fair that WKImageCreateCGImage should tolerate null.

  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateCGImage):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.

(TestWebKitAPI::TEST):

10:45 AM Changeset in webkit [173565] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

2014-09-12 Geoffrey Garen <​ggaren@apple.com>

Rolled out r173540.

It broke the Membuster performance bot, and it's still slightly profligate
with memory.

Do the bmalloc.
​https://bugs.webkit.org/show_bug.cgi?id=132629

  • wtf/FastMalloc.cpp:
10:30 AM Changeset in webkit [173564] by mitz@apple.com
  • 7 edits
    1 move in trunk/Source/WebKit2

[Cocoa] Message generation scripts should be installed in WebKit.framework
​https://bugs.webkit.org/show_bug.cgi?id=136771

Reviewed by Anders Carlsson.

  • DerivedSources.make: Updated for rename of Scripts/webkit2 to Scripts/webkit.
  • Scripts/generate-message-receiver.py:

(main): Updated for rename from webkit2 to webkit.

  • Scripts/generate-messages-header.py:

(main): Ditto.

  • Scripts/webkit: Renamed from Source/WebKit2/Scripts/webkit2.
  • Scripts/webkit/messages.py: Updated for rename.
  • Scripts/webkit/parser.py: Ditto.
  • WebKit2.xcodeproj/project.pbxproj: Moved the Copy Message Generation Scripts build phase

from the WebKit2 target to the WebKit target and changed its destination to
WebKit.framework/PrivateHeaders/Scripts/webkit. Removed the Remove Compiled Python Files
build phase, since compiled files no longer get copied.

10:17 AM Changeset in webkit [173563] by Lucas Forschler
  • 6 edits in branches/safari-600.1-branch/Source/WebCore

Merged r173544. rdar://problem/18195616

10:11 AM Changeset in webkit [173562] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r173533. rdar://problem/18187939

9:27 AM Changeset in webkit [173561] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

8:59 AM Changeset in webkit [173560] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Use a nicer HTTP authentication dialog
​https://bugs.webkit.org/show_bug.cgi?id=136615

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-09-12
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize): Use a nicer layout.
(packTwoColumnLayoutInBox): Deleted.
(createLabel): Deleted.
(createEntry): Deleted.

8:44 AM Changeset in webkit [173559] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

REGRESSION(r173441): [GTK] All buttons appear insensitive
​https://bugs.webkit.org/show_bug.cgi?id=136614

Reviewed by Sergio Villar Senin.

Do not use RenderTheme::isReadOnlyControl() to decide whether to
render non text based forms sensitive or unsensitive, isEnabled()
is enough in those cases.

  • rendering/RenderThemeGtk.cpp:

(WebCore::paintToggle):
(WebCore::renderButton):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):

8:42 AM Changeset in webkit [173558] by Carlos Garcia Campos
  • 15 edits in trunk

REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
​https://bugs.webkit.org/show_bug.cgi?id=136669

Reviewed by Antti Koivisto.

Source/WebCore:

Add CertificateInfoPolicy option to ResourceLoaderOptions. It's
set to DoNotIncludeCertificateInfo for all loads except the main
resource load.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource): Pass
IncludeCertificateInfo to ResourceLoaderOptions.

  • loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
Pass DoNotIncludeCertificateInfo to ResourceLoaderOptions().

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::shouldIncludeCertificateInfo): Return
true if IncludeCertificateInfo option was given.

  • loader/ResourceLoaderOptions.h:

(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
(WebCore::ResourceLoaderOptions::certificateInfoPolicy):
(WebCore::ResourceLoaderOptions::setCertificateInfoPolicy):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): If
IncludeCertificateInfo option is present, call
includeCertificateInfo() on the response.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Pass
DoNotIncludeCertificateInfo to ResourceLoaderOptions().
(WebCore::CachedResourceLoader::defaultCachedResourceOptions): Ditto.

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading): Ditto.

  • platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:

(WebCore::WebCoreAVCFResourceLoader::startLoading): Ditto.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::startLoading): Ditto.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(CachedResourceStreamingClient::CachedResourceStreamingClient): Ditto.

Source/WebKit2:

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad): Use
ResourceLoader::shouldIncludeCertificateInfo() to initialize
needsCertificateInfo parameter.

Tools:

  • Scripts/run-gtk-tests:

(TestRunner): Unskip SSL test.

6:06 AM Changeset in webkit [173557] by eric.carlson@apple.com
  • 6 edits in trunk/Tools

Strip extraneous AVFoundation and CoreMedia logging
​https://bugs.webkit.org/show_bug.cgi?id=136747

Reviewed by Jer Noble.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.

  • Scripts/webkitpy/port/base.py:

(Port.stderr_patterns_to_strip): Base class, empty list

  • Scripts/webkitpy/port/driver.py:

(DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.

  • Scripts/webkitpy/port/mac.py:

(MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.

Note: See TracTimeline for information about the timeline view.