Timeline
Dec 13, 2014:
- 10:44 PM Changeset in webkit [177258] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=139597
rdar://problem/19237334
Fixed positioned pseudo content does not get composited.
Reviewed by Simon Fraser.
This patch ensures that adjustRenderStyle() can access to settings even when Element* is null.
Source/WebCore:
Test: compositing/fixed-positioned-pseudo-content-no-compositing.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
LayoutTests:
- compositing/fixed-positioned-pseudo-content-no-compositing-expected.txt: Added.
- compositing/fixed-positioned-pseudo-content-no-compositing.html: Added.
- 5:33 PM Changeset in webkit [177257] by
-
- 3 edits in branches/safari-600.3-branch/Source/WebCore
Merged r177254. rdar://problem/19189948
- 1:22 AM Changeset in webkit [177256] by
-
- 2 edits in trunk/Tools
[EFL] MiniBrowser's window_create may return NULL
https://bugs.webkit.org/show_bug.cgi?id=139585
Reviewed by Gyuyoung Kim.
Move NULL checking before using object which window_create
returns.
- MiniBrowser/efl/main.c:
(elm_main):
Dec 12, 2014:
- 5:44 PM Changeset in webkit [177255] by
-
- 6 edits in trunk/Source/WebKit2
Split WebPageProxy::m_preventProcessSuppression to track pref/visibility separately
https://bugs.webkit.org/show_bug.cgi?id=139600
Reviewed by Geoff Garen.
Previously WebPageProxy::m_preventProcessSuppression would be set if either the page was visible
or its suppression was disabled by the pref. Instead track these separately. This will make the
user observability state applicable on iOS, too.
Add a new counter to WebContext, and split the counting in WebPageProxy.
::updateProccessSuppressionState continues to track the pref change (which matches its name),
tracking of user observability changes moved to updateActivityToken (which we should further
merge with; it already tracks observability to control process state for iOS).
- UIProcess/WebContext.cpp:
(WebKit::m_processSuppressionDisabledForPageCounter):
- added new RefCounter.
- UIProcess/WebContext.h:
(WebKit::WebContext::processSuppressionDisabledForPageCount):
- added new RefCounter.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcess):
- no longer needs to call updateProccessSuppressionState (pref has not changed; handled by the call to updateActivityToken).
(WebKit::WebPageProxy::dispatchViewStateChange):
- no longer needs to call updateProccessSuppressionState (pref has not changed; handled by the call to updateActivityToken).
(WebKit::WebPageProxy::updateActivityToken):
- this now also updated the user observability counter.
(WebKit::WebPageProxy::updateProccessSuppressionState):
- now only tracks whether this is disabled via the preference.
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- clear the user observability counter; thsi will be reset on reattach.
- UIProcess/WebPageProxy.h:
- added new RefCounter::Count.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::processSuppressionEnabled):
- processSuppressionEnabled is disabled if *neither*:
- there are user observable pages
- disabled by pref for any page.
- 5:40 PM Changeset in webkit [177254] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Work around a bug in dsymutil on older OS versions
<https://webkit.org/b/139609> / <rdar://problem/16045763>
Older versions of dsymutil are unable to write out more than 2GB of symbols per architecture.
WebCore has recently passed that threshold. To work around this we will reduce the level of
symbols included in the dSYM bundles on the affected OS versions.
Reviewed by Geoff Garen.
- Configurations/Base.xcconfig: Include line tables only in the debug symbols for production
builds on OS X 10.8 and 10.9.
- Configurations/DebugRelease.xcconfig: Include full symbols in debug and release builds since they
do not make use of dSYMs.
- 5:14 PM Changeset in webkit [177253] by
-
- 4 edits in trunk/Source
Need a fake mouse move after hiding data detectors UI
https://bugs.webkit.org/show_bug.cgi?id=139608
-and corresponding-
rdar://problem/19221935
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::dataDetectorsDidHideUI):
- 5:06 PM Changeset in webkit [177252] by
-
- 2 edits in trunk/Source/WebKit2
Handle caches in WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=139607
<rdar://problem/19107614>
Reviewed by Sam Weinig.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::computeNetworkProcessAccessType):
- 4:44 PM Changeset in webkit [177251] by
-
- 2 edits in trunk/Source/WebCore
[Media iOS] Inline video controls have an outlined scrubber
https://bugs.webkit.org/show_bug.cgi?id=139602
<rdar://problem/19184212>
Reviewed by Eric Carlson.
This is another change similar to https://bugs.webkit.org/show_bug.cgi?id=138378
where the specificity of pseduo elements had changed, and thus iOS
was inheriting some of the UA styles.
The fix is to add some more style rules to ensure that the timeline track
is drawn in white.
- Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-timeline): Border rules not needed here.
(video::-webkit-media-controls-timeline::-webkit-slider-runnable-track): But are needed
here, along with some other things.
(audio::-webkit-media-controls-timeline::-webkit-slider-thumb): Now that the runnable
track has some style, we need to account for the change.
- 4:42 PM Changeset in webkit [177250] by
-
- 2 edits in trunk/LayoutTests
[WebGL] Texture size tests failures
https://bugs.webkit.org/show_bug.cgi?id=131886
- platform/mac/TestExpectations: Further relax expectations for these tests, as
they also fail on different OS versions and in different ways.
- 4:37 PM Changeset in webkit [177249] by
-
- 2 edits in trunk/Source/WebCore
Remove a workaround for a bug that was fixed in Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=139605
Reviewed by Sam Weinig.
- WebCorePrefix.h:
(move): Deleted.
- 4:33 PM Changeset in webkit [177248] by
-
- 2 edits in trunk/LayoutTests
Mark two canvas tests that fail on a new Mac Pro locally.
- platform/mac/TestExpectations:
- 4:16 PM Changeset in webkit [177247] by
-
- 3 edits in trunk/LayoutTests
Move expectations for test that hit !m_visibleDescendantStatusDirty assertion,
because locally, this also happens in WK1.
- TestExpectations:
- platform/wk2/TestExpectations:
- 4:00 PM Changeset in webkit [177246] by
-
- 7 edits in trunk/Source/WebKit2
[iOS] Predictions are not updated when using navigation buttons.
https://bugs.webkit.org/show_bug.cgi?id=139567
rdar://problem/19132585
Reviewed by Dan Bernstein.
When moving focus programmatically, we need to notify the keyboard so that it
can update the prediction bar.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKFormInputSession setAccessoryViewCustomButtonTitle:]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView inputAssistantButtonItems]):
(-[WKContentView accessoryTab:]):
(-[WKContentView _startAssistingKeyboard]):
(-[WKContentView _stopAssistingNode]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::focusNextAssistedNode):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::focusNextAssistedNode):
- 3:46 PM Changeset in webkit [177245] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
shiftCountWithArrayStorage should exit to slow path if the object has a sparse map.
https://bugs.webkit.org/show_bug.cgi?id=139598
<rdar://problem/18779367>
Reviewed by Filip Pizlo.
- runtime/JSArray.cpp:
(JSC::JSArray::shiftCountWithArrayStorage): Added check for object having a sparse map.
- tests/stress/sparse_splice.js: Added.
- 3:38 PM Changeset in webkit [177244] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r168217): Images are cropped out during animation at jetblue.com
https://bugs.webkit.org/show_bug.cgi?id=136410
Reviewed by Dean Jackson.
We were hitting the new assertion under Page::setPageScaleFactor(), which
calls recalcStyle(), so move the AnimationUpdateBlock from updateStyleIfNeeded()
to recalcStyle().
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::updateStyleIfNeeded):
- 3:35 PM Changeset in webkit [177243] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=139596
Subpixel rendering: REGRESSION (r163272): Fixed positioned pseudo content leaves trails while scrolling.
rdar://problem/18697851
Reviewed by Simon Fraser.
Final repaint rect at FrameView::scrollContentsFastPath needs to be pixel aligned (as opposed to snap to int).
However we can't pixelsnap it until after ScrollView finished transitioning to Float/LayoutRect.
Use enclosing int rect for now to ensure scrolling does not leave trails.
Unable to test. Apparently scrolling clears trails in dumprendertree. (repaint rects are not useful either with scrolling)
- page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
- 3:16 PM Changeset in webkit [177242] by
-
- 9 edits in trunk/Source/WebKit2
TextIndicator (and other view-relative subwindows) is not dismissed on zoom gesture
https://bugs.webkit.org/show_bug.cgi?id=139580
<rdar://problem/19226350>
Reviewed by Anders Carlsson.
- UIProcess/PageClient.h:
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::dismissContentRelativeChildWindows):
(WebKit::PageClientImpl::dismissDictionaryLookupPanel): Deleted.
(WebKit::PageClientImpl::dismissActionMenuPopovers): Deleted.
Merge dismissDictionaryLookupPanel and dismissActionMenuPopovers into
_dismissContentRelativeChildWindows, which also dismisses TextIndicator and the
text correction panel. Dismissal of any child windows which are anchored to
the page content now bottlenecks through this function.
(WebKit::PageClientImpl::navigationGestureDidBegin):
Dismiss all anchored subwindows when starting a navigation gesture, not
just TextIndicator and action menu popovers.
- UIProcess/API/mac/WKView.mm:
(-[WKView scrollWheel:]):
No need to dismiss TextIndicator here; we've got this covered in the more-inclusive
WebPageProxy::pageDidScroll, and will now dismiss more things.
(-[WKView mouseDown:]):
Dismiss more things.
(-[WKView viewDidMoveToWindow]):
Dismiss more things.
(-[WKView _dismissContentRelativeChildWindows]):
The aforementioned combined dismissal function.
(-[WKView magnifyWithEvent:]):
(-[WKView smartMagnifyWithEvent:]):
(-[WKView setMagnification:centeredAtPoint:]):
(-[WKView setMagnification:]):
Any time the page magnification changes, dismiss all the things.
- UIProcess/API/mac/WKViewPrivate.h:
Expose _dismissContentRelativeChildWindows instead of _dismissActionMenuPopovers;
for all existing clients, it makes more sense to dismiss all view-relative subwindows
than just a subset of them.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::pageDidScroll):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
Make use of dismissAnchoredSubwindows.
- UIProcess/mac/WKActionMenuController.h:
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController prepareForMenu:withEvent:]):
Dismiss more things.
(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
(-[WKActionMenuController dismissActionMenuPopovers]): Deleted.
dismissActionMenuPopovers is folded into WKView's _dismissContentRelativeChildWindows.
(-[WKActionMenuController _showTextIndicator]): Deleted.
(-[WKActionMenuController _hideTextIndicator]): Deleted.
Fold _showTextIndicator and _hideTextIndicator into their only callers.
_isShowingTextIndicator was never necessary, because it's OK to change
the current TextIndicator at any time, and a newer one is always more relevant.
- 3:12 PM Changeset in webkit [177241] by
-
- 9 edits in trunk/Source/WebKit2
Keep single RefCounter to track whether any pages in a context are process suppressible
https://bugs.webkit.org/show_bug.cgi?id=139576
Reviewed by Sam Weinig.
Currently we keep separate counters in each process, and coallesce these in the
context. Instead we should have a counter in the WebContext.
Also, changed the name to better describe the state we're tracking, rather than
describing what it's currently used for. This counter will also be useful for
iOS, to better manage background state of the networking process.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
- initialize m_userObservablePageCounter.
- UIProcess/WebContext.h:
(WebKit::WebContext::updateProcessSuppressionState):
- Added no-op implementation for non-cocoa platforms.
(WebKit::WebContext::userObservablePageCount):
- Count the number of user visible (audible / visible) pages in Context.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateProccessSuppressionState):
- WebProcessProxy::processSuppressionCounter -> WebContext::userObservablePageCount
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::didFinishLaunching):
- moved all processs supression state tracking to the WebContext.
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::processSuppressionCounter): Deleted.
- moved all processs supression state tracking to the WebContext.
- UIProcess/ios/WebProcessProxyIOS.mm:
(WebKit::WebProcessProxy::allPagesAreProcessSuppressible): Deleted.
(WebKit::WebProcessProxy::updateProcessSuppressionState): Deleted.
- moved all processs supression state tracking to the WebContext.
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::processSuppressionEnabled):
- no need to interate all processes; just have a single counter.
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::allPagesAreProcessSuppressible): Deleted.
(WebKit::WebProcessProxy::updateProcessSuppressionState): Deleted.
- moved all processs supression state tracking to the WebContext.
- 3:04 PM Changeset in webkit [177240] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed 64bit build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 3:03 PM Changeset in webkit [177239] by
-
- 2 edits in trunk/LayoutTests
fast/images/animated-gif-body-outside-viewport.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139599
- platform/mac-wk1/TestExpectations: Mark it as such.
- 2:52 PM Changeset in webkit [177238] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION (r168217): Images are cropped out during animation at jetblue.com
https://bugs.webkit.org/show_bug.cgi?id=136410
rdar://problem/18188533
Reviewed by Dean Jackson.
During GraphicsLayer flushing, for tiled layers we can compute a visible rect using
the current state of an animation, which is obtained via the AnimationController.
If that animation was running in a subframe, AnimationController could use a stale
beginAnimationUpdateTime since no-one called its beginAnimationUpdate(). That
resulted in an incorrect computation of the visible rect, resulting in missing tiles.
There are two parts to this fix. First, add an assertion that beginAnimationUpdateTime()
is being called inside an animation update block. This required moving m_beginAnimationUpdateCount
into AnimationControllerPrivate, and changes to endAnimationUpdate().
The second is adding a AnimationUpdateBlock to getAnimatedStyleForRenderer(), which
can be called outside of style resolution. We also need some in other API functions.
Testing revealed that layout can call via layoutOverflowRectForPropagation(), suggesting
that we should have an animation batch inside FrameView::layout(). In addition, a single
resolveStyle/layout should use the same animationBeginTime, so we add a batch to
updateLayoutAndStyleIfNeededRecursive().
No test because it's timing-dependent. Existing tests exercise the new assertion.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::computeRenderStyleForProperty):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
- page/animation/AnimationController.cpp:
(WebCore::AnimationPrivateUpdateBlock::AnimationPrivateUpdateBlock):
(WebCore::AnimationPrivateUpdateBlock::~AnimationPrivateUpdateBlock):
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::animationTimerFired):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
(WebCore::AnimationControllerPrivate::beginAnimationUpdate):
(WebCore::AnimationControllerPrivate::endAnimationUpdate):
(WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::AnimationController::AnimationController):
(WebCore::AnimationController::notifyAnimationStarted):
(WebCore::AnimationController::pauseAnimationAtTime):
(WebCore::AnimationController::pauseTransitionAtTime):
(WebCore::AnimationController::resumeAnimationsForDocument):
(WebCore::AnimationController::startAnimationsIfNotSuspended):
(WebCore::AnimationController::beginAnimationUpdate):
(WebCore::AnimationController::endAnimationUpdate):
- page/animation/AnimationController.h:
- page/animation/AnimationControllerPrivate.h:
- 2:17 PM Changeset in webkit [177237] by
-
- 2 edits in trunk/LayoutTests
http/tests/xmlhttprequest/workers/abort-exception-assert.html often times out
https://bugs.webkit.org/show_bug.cgi?id=139595
- TestExpectations: Mark it as such.
- 2:07 PM Changeset in webkit [177236] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed build fix following r177235.
- WebCore.vcxproj/WebCore.vcxproj:
- 1:56 PM Changeset in webkit [177235] by
-
- 15 edits3 adds in trunk
Implement EXT_blend_minmax as a WebGL 1 extension.
https://bugs.webkit.org/show_bug.cgi?id=128974.
<rdar://problem/19195535>
Tested by:
webgl/1.0.3/conformance/extensions/ext-blend-minmax.html
fast/canvas/webgl/constants.html
Specifications for this extension:
https://www.khronos.org/registry/webgl/extensions/EXT_blend_minmax/
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- html/canvas/EXTBlendMinMax.cpp: Added.
(WebCore::EXTBlendMinMax::EXTBlendMinMax):
(WebCore::EXTBlendMinMax::~EXTBlendMinMax):
(WebCore::EXTBlendMinMax::getName):
- html/canvas/EXTBlendMinMax.h: Added.
- html/canvas/EXTBlendMinMax.idl: Added.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateBlendEquation):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl:
- platform/graphics/Extensions3D.h:
- 1:40 PM Changeset in webkit [177234] by
-
- 4 edits in trunk
Layout Test http/tests/loading/307-after-303-after-post.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=73030
Reviewed by Anders Carlsson.
Source/WebKit2:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess): Added a FIXME comment.
(WebKit::WebContext::setIconDatabasePath): Don't enable m_iconDatabase if the path
is empty, meaning that the database is disabled (which is not a great way to say
that, but WebKit2 icon database doesn't support enabling/disabling cleanly).
(WebKit::WebContext::iconDatabasePath): Keep it empty if it was empty.
Tools:
- WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
database to empty to avoid having it fetch default favicons at random times.
DumpRenderTree also disables it, and also it has a way for tests to temporarily
enable it.
- 1:15 PM Changeset in webkit [177233] by
-
- 2 edits in trunk/Source/WebKit
Handle null local storage database URLs
https://bugs.webkit.org/show_bug.cgi?id=139594
<rdar://problem/19236505>
Reviewed by Beth Dakin.
- Storage/WebStorageNamespaceProvider.cpp:
(WebStorageNamespaceProvider::WebStorageNamespaceProvider):
- 1:05 PM Changeset in webkit [177232] by
-
- 3 edits in trunk/Source/WebCore
Remove the concept of simple selector from the parser
https://bugs.webkit.org/show_bug.cgi?id=139575
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-12
Reviewed by Mark Lam.
We have complete support for nested selector list, we no longer
need the old concept of simple selector.
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::isSimple): Deleted.
- css/CSSParserValues.h:
- 1:01 PM Changeset in webkit [177231] by
-
- 4 edits1 move1 add3 deletes in trunk/LayoutTests
http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139591
Reviewed by Antti Koivisto.
- http/tests/css/resources/empty.css: Added.
- http/tests/css/resources/500.php: Copied from LayoutTests/http/tests/css/resources/slow-loading-sheet-in-error.php.
- http/tests/css/resources/slow-loading-sheet-in-error.php: Removed.
- http/tests/css/resources/slow-loading-sheet.php: Removed.
These scripts were not "slow" at all - 100 microseconds is nothing. Furthermore,
slow-loading-sheet-in-error.php wasn't even used, because of a typo in the test.
And worst of all, WebCore has its own ideas about when to load stylesheets - notably,
default stylesheet loading blocks script execution, so we cannot do anything before
the stylesheet loads.
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html:
- http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html:
Removed built-in timeout for the tests, we don't need it. Also, fixed a number of
small stylistic issues.
- http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js: Removed.
- http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js: Removed.
Moved inside HTML, because having tests in a separate file is useless and harmful.
- platform/mac-wk2/TestExpectations: These tests were always flaky, not 100% failing.
- 12:54 PM Changeset in webkit [177230] by
-
- 2 edits in trunk/Source/WebKit2
Fix the 32-bit build.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setPreviewTitle:]):
- 12:31 PM Changeset in webkit [177229] by
-
- 4 edits in trunk/Source/WebCore
FontGlyphs::glyphDataAndPageForCharacter cleanups
https://bugs.webkit.org/show_bug.cgi?id=139584
Reviewed by Andreas Kling.
Split it up and use helper functions.
- WebCore.exp.in:
- platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::determinePitch):
(WebCore::FontGlyphs::realizeFontDataAt):
(WebCore::FontGlyphs::glyphDataAndPageForSystemFallback):
(WebCore::FontGlyphs::glyphDataAndPageForVariant):
Add private helpers.
(WebCore::FontGlyphs::glyphDataAndPageForCharacter):
Do the m_pages cache lookup only once and use the pointer reference afterwards.
- platform/graphics/FontGlyphs.h:
(WebCore::FontGlyphs::fontSelector):
(WebCore::FontGlyphs::widthCache):
(WebCore::FontGlyphs::primaryFontData):
(WebCore::FontGlyphs::isFixedPitch):
(WebCore::FontGlyphs::primarySimpleFontData):
Also removed the mutable attribute from the fields (almost everything was marked mutable) and made the inteface
non-const. The FontGlyphs member of Font is already mutable so this is not needed.
- 12:28 PM Changeset in webkit [177228] by
-
- 14 edits in trunk/Source/WebCore
Use is<>() / downcast<>() for StyleRuleBase subclasses
https://bugs.webkit.org/show_bug.cgi?id=139571
Reviewed by Andreas Kling.
Use is<>() / downcast<>() for StyleRuleBase subclasses for safety and
consistency.
No new tests, no behavior change.
- css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reattach):
- css/CSSKeyframesRule.h:
(isType):
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reattach):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reattach):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::insertRule):
- css/RuleSet.cpp:
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addChildRules):
- css/StyleInvalidationAnalysis.cpp:
(WebCore::shouldDirtyAllStyle):
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
- css/StyleRule.h:
(isType):
(WebCore::toStyleRule): Deleted.
- css/StyleRuleImport.h:
(isType):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::StyleSheetContents::wrapperInsertRule):
(WebCore::StyleSheetContents::addSubresourceStyleURLs):
(WebCore::childRulesHaveFailedOrCanceledSubresources):
- css/WebKitCSSViewportRule.cpp:
(WebCore::WebKitCSSViewportRule::reattach):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
- 12:21 PM Changeset in webkit [177227] by
-
- 2 edits in trunk/Source/WebKit2
Fix the 32-bit build.
- UIProcess/mac/WKImmediateActionController.h:
- 12:13 PM Changeset in webkit [177226] by
-
- 2 edits in trunk/LayoutTests
animations/cross-fade-webkit-mask-image.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139590
Reviewed by Alexey Proskuryakov.
animations/cross-fade-webkit-mask-image.html became flaky after the way
masks are handled was changed in https://bugs.webkit.org/show_bug.cgi?id=139294.
Marking it flaky for now, pending investigation.
- 11:27 AM Changeset in webkit [177225] by
-
- 8 edits1 add in trunk
[MSE] Add support for SourceBuffer.mode.
https://bugs.webkit.org/show_bug.cgi?id=139265
Reviewed by Eric Carlson.
Source/WebCore:
Support setting SourceBuffer's mode property, and add support for "sequence" mode. Prior
to this change, "segments" mode was implied.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::regenerateActiveSourceBuffers):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::segmentsKeyword):
(WebCore::SourceBuffer::sequenceKeyword):
(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::setTimestampOffset):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::setMode):
- Modules/mediasource/SourceBuffer.h:
- Modules/mediasource/SourceBuffer.idl:
LayoutTests:
- http/tests/media/media-source/mediasource-util.js:
- platform/mac/TestExpectations:
Add an expected-failure; the test fails due to lack of support for a non-DOM-visible
algorithm variable unsupported by the Mac port.
- platform/mac/http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt: Added.
- 8:59 AM Changeset in webkit [177224] by
-
- 2 edits in trunk/Source/WebKit2
Fix Build Warning in WebKit2/UIProcess module for GTK build and WebKit2/NetworkProcess module in GTK and EFL build
https://bugs.webkit.org/show_bug.cgi?id=139535
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-12-12
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebView.cpp: Use UNUSED_PARAM for conditional #if case
(webkitWebViewShowNotification):
(webkitWebViewCloseNotification):
- 6:19 AM Changeset in webkit [177223] by
-
- 29 edits1 copy34 adds in trunk
[SVG Masking] Enable the use of <mask> elements for -webkit-mask-image
https://bugs.webkit.org/show_bug.cgi?id=139294
Reviewed by Simon Fraser.
Source/WebCore:
This patch links together all parts required for the functionality which improves
the -webkit-mask-image property by allowing it to reference a <mask> element defined
in an inline or external SVG document.
Support for this new functionality has been added in a previous patch, under issue
https://bugs.webkit.org/show_bug.cgi?id=139092. A more detailed description of how
the new functionality works can be found in the ChangeLog for that commit.
The containsSVGDocument in ScrollView has been removed because it was added in the
previous patch but is no longer required.
Tests: css3/masking/mask-base64.html
css3/masking/mask-multiple-values.html
css3/masking/mask-svg-clipped-fragmentId.html
css3/masking/mask-svg-fragmentId.html
css3/masking/mask-svg-inline-fragmentId.html
css3/masking/mask-svg-inline-invalid-fragmentId.html
css3/masking/mask-svg-invalid-fragmentId.html
css3/masking/mask-svg-no-fragmentId-tiled.html
css3/masking/mask-svg-no-fragmentId.html
css3/masking/mask-svg-script-entire-svg-to-mask.html
css3/masking/mask-svg-script-mask-to-entire-svg.html
css3/masking/mask-svg-script-mask-to-none.html
css3/masking/mask-svg-script-mask-to-png.html
css3/masking/mask-svg-script-none-to-mask.html
css3/masking/mask-svg-script-none-to-png.html
css3/masking/mask-svg-script-png-to-mask.html
css3/masking/mask-svg-script-png-to-none.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseMaskImage):
- css/CSSParser.h:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustStyleForMaskImages):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::createMaskImageOperations):
(WebCore::StyleResolver::loadPendingImages):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::MaskImagePropertyWrapper::MaskImagePropertyWrapper):
(WebCore::MaskImagePropertyWrapper::equals):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- platform/graphics/MaskImageOperation.cpp:
(WebCore::MaskImageOperation::~MaskImageOperation):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::maskClipRect):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::updateFillImages):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/style/FillLayer.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setMaskImage):
- rendering/style/RenderStyle.h:
LayoutTests:
Added tests for different situations using URLs with fragment id
for the -webkit-mask-image property.
- css3/masking/mask-base64-expected.html: Added.
- css3/masking/mask-base64.html: Added.
- css3/masking/mask-multiple-values-expected.html: Added.
- css3/masking/mask-multiple-values.html: Added.
- css3/masking/mask-repeat-space-padding-expected.html:
- css3/masking/mask-repeat-space-padding.html:
- css3/masking/mask-svg-clipped-fragmentId-expected.html: Added.
- css3/masking/mask-svg-clipped-fragmentId.html: Added.
- css3/masking/mask-svg-fragmentId-expected.html: Added.
- css3/masking/mask-svg-fragmentId.html: Added.
- css3/masking/mask-svg-inline-fragmentId-expected.html: Added.
- css3/masking/mask-svg-inline-fragmentId.html: Added.
- css3/masking/mask-svg-inline-invalid-fragmentId-expected.html: Added.
- css3/masking/mask-svg-inline-invalid-fragmentId.html: Added.
- css3/masking/mask-svg-invalid-fragmentId-expected.html: Added.
- css3/masking/mask-svg-invalid-fragmentId.html: Added.
- css3/masking/mask-svg-no-fragmentId-expected.html: Added.
- css3/masking/mask-svg-no-fragmentId-tiled-expected.html: Added.
- css3/masking/mask-svg-no-fragmentId-tiled.html: Added.
- css3/masking/mask-svg-no-fragmentId.html: Added.
- css3/masking/mask-svg-script-entire-svg-to-mask-expected.html: Added.
- css3/masking/mask-svg-script-entire-svg-to-mask.html: Added.
- css3/masking/mask-svg-script-mask-to-entire-svg-expected.html: Added.
- css3/masking/mask-svg-script-mask-to-entire-svg.html: Added.
- css3/masking/mask-svg-script-mask-to-none-expected.html: Added.
- css3/masking/mask-svg-script-mask-to-none.html: Added.
- css3/masking/mask-svg-script-mask-to-png-expected.html: Added.
- css3/masking/mask-svg-script-mask-to-png.html: Added.
- css3/masking/mask-svg-script-none-to-mask-expected.html: Added.
- css3/masking/mask-svg-script-none-to-mask.html: Added.
- css3/masking/mask-svg-script-none-to-png-expected.html: Added.
- css3/masking/mask-svg-script-none-to-png.html: Added.
- css3/masking/mask-svg-script-png-to-mask-expected.html: Added.
- css3/masking/mask-svg-script-png-to-mask.html: Added.
- css3/masking/mask-svg-script-png-to-none-expected.html: Added.
- css3/masking/mask-svg-script-png-to-none.html: Added.
- css3/masking/resources/masks.svg: Added.
- 5:34 AM Changeset in webkit [177222] by
-
- 20 edits in trunk/Source/JavaScriptCore
Final clean up OwnPtr in JSC - runtime, ftl, and tool directories
https://bugs.webkit.org/show_bug.cgi?id=139532
Reviewed by Mark Lam.
Final remove OwnPtr, PassOwnPtr in runtime, ftl, and tools directories of JSC.
- builtins/BuiltinExecutables.h:
- bytecode/CodeBlock.h:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock):
- ftl/FTLAbstractHeap.cpp:
(JSC::FTL::IndexedAbstractHeap::atSlow):
- ftl/FTLAbstractHeap.h:
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLJITFinalizer.h:
- jsc.cpp:
(jscmain):
- parser/Lexer.h:
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::clearDeletedOffsets):
(JSC::PropertyTable::addDeletedOffset):
- runtime/PropertyTable.cpp:
(JSC::PropertyTable::PropertyTable):
- runtime/RegExpObject.cpp:
- runtime/SmallStrings.cpp:
- runtime/Structure.cpp:
- runtime/StructureIDTable.cpp:
(JSC::StructureIDTable::StructureIDTable):
(JSC::StructureIDTable::resize):
- runtime/StructureIDTable.h:
- runtime/StructureTransitionTable.h:
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
- runtime/VM.h:
- tools/CodeProfile.h:
(JSC::CodeProfile::CodeProfile):
(JSC::CodeProfile::addChild):
- 4:34 AM Changeset in webkit [177221] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(SVG_FONTS) build after r177078
https://bugs.webkit.org/show_bug.cgi?id=139578
Reviewed by Martin Robinson.
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::dashesForIntersectionsWithRect):
- 4:09 AM Changeset in webkit [177220] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[kn] Kannada Translation for webkit - Updated
https://bugs.webkit.org/show_bug.cgi?id=116941
Patch by Shankar Prasad <svenkate@redhat.com> on 2014-12-12
Reviewed by Carlos Garcia Campos.
- kn.po:
- 3:49 AM Changeset in webkit [177219] by
-
- 6 edits2 adds in trunk
Simple line layout: Add 16bit support.
https://bugs.webkit.org/show_bug.cgi?id=139469
Reviewed by Antti Koivisto.
This patch adds the 16bit support to simple line layout.
Source/WebCore:
Test: fast/inline/simple-line-layout-16bit-content.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::nextBreakablePosition):
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):
(WebCore::SimpleLineLayout::findNextNonWhitespace):
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContents::textWidth):
(WebCore::SimpleLineLayout::FlowContents::runWidth):
- rendering/SimpleLineLayoutFlowContents.h:
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::Run::text):
LayoutTests:
- fast/inline/simple-line-layout-16bit-content-expected.html: Added.
- fast/inline/simple-line-layout-16bit-content.html: Added.
- 2:49 AM Changeset in webkit [177218] by
-
- 2 edits in trunk/Websites/planet.webkit.org
[Planet WebKit] Raise the number of posts per feed to import.
https://bugs.webkit.org/show_bug.cgi?id=139579
Reviewed by Csaba Osztrogonác.
- config.ini: Raise the number of posts to import for each feed to 6.
- 2:47 AM Changeset in webkit [177217] by
-
- 2 edits in trunk/Tools
Update Apple owned build slaves after infrastructure update.
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 1:21 AM Changeset in webkit [177216] by
-
- 5 edits1 add in trunk/Source/WebCore
Implement MemoryPressureHandler for Linux system
https://bugs.webkit.org/show_bug.cgi?id=123532
Reviewed by Sergio Villar Senin.
This is an initial implementation to support MemoryPressureHandler for linux system.
The patch is based on Tomeu's last patch and improved on top of it.
Most of current linux distributions support cgroup, so that we use the memory.pressure_level
mechanism of cgroup to get notifications when an application reaches the 'low' memory
pressure level.
No new tests since no engine behavior changed.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::MemoryPressureHandler):
- platform/MemoryPressureHandler.h:
- platform/linux/MemoryPressureHandlerLinux.cpp: Added.
(WebCore::nextToken):
(WebCore::MemoryPressureHandler::~MemoryPressureHandler):
(WebCore::MemoryPressureHandler::waitForMemoryPressureEvent): run in a seperated thread
to listen 'low' level event.
(WebCore::MemoryPressureHandler::logErrorAndCloseFDs):
(WebCore::MemoryPressureHandler::install):
(WebCore::MemoryPressureHandler::uninstall):
(WebCore::MemoryPressureHandler::holdOffTimerFired):
(WebCore::MemoryPressureHandler::holdOff):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
(WebCore::MemoryPressureHandler::platformReleaseMemory):
(WebCore::MemoryPressureHandler::ReliefLogger::platformLog):
(WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage): read /proc/self/status
to get VM amount used by current process.
- 1:17 AM Changeset in webkit [177215] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Disable all EWK2Accessibility unit tests
https://bugs.webkit.org/show_bug.cgi?id=139577
Reviewed by Csaba Osztrogonác.
WebAccessibility functionality isn't supported by EFL WebKit2 though,
EWK2Accessibility unit tests have been tested. That's why those tests have been failed
so far.
- UIProcess/API/efl/tests/test_ewk2_accessibility.cpp:
(TEST_F):
- 1:16 AM Changeset in webkit [177214] by
-
- 5 edits in trunk/Source
Layer borders on contentsLayers don't correctly toggle with the rest of the borders
https://bugs.webkit.org/show_bug.cgi?id=139570
rdar://problem/18007746
Reviewed by Tim Horton.
Source/WebCore:
The "Show Debug Borders" toggle didn't cleanly remove layer borders from
content layers (image, video), nor did it deal with cloned layers (reflections).
Fix by making updateDebugBorder() update the layer borders on the contents
layer and cloned layers, moving some code around to avoid having colors
in more than one place. If the borders are hidden, send an invalid color
to PlatformCALayer::setBorderColor(), which now knows to remove the color
property on the layer (to avoid leaving transparent border color properties
on CALayers).
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::setLayerDebugBorder):
(WebCore::contentsLayerDebugBorderColor):
(WebCore::cloneLayerDebugBorderColor):
(WebCore::GraphicsLayerCA::updateDebugBorder):
(WebCore::GraphicsLayerCA::setDebugBorder):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::setBorderColor):
Source/WebKit2:
Return nil if the color is invalid, to remove the color from the layer's
border or background.
- Shared/mac/RemoteLayerTreePropertyApplier.mm:
(WebKit::cgColorFromColor):
Dec 11, 2014:
- 10:00 PM Changeset in webkit [177213] by
-
- 2 edits in tags/Safari-601.1.12.1/Source/JavaScriptCore
Merged r177210.
- 9:59 PM Changeset in webkit [177212] by
-
- 5 edits in tags/Safari-601.1.12.1/Source
Versioning.
- 9:57 PM Changeset in webkit [177211] by
-
- 1 copy in tags/Safari-601.1.12.1
New tag.
- 9:41 PM Changeset in webkit [177210] by
-
- 2 edits in trunk/Source/JavaScriptCore
iOS Simulator production build fix.
- Configurations/JavaScriptCore.xcconfig: Don’t use an order file when building for the iOS
Simulator, as we did prior to 177027.
- 9:15 PM Changeset in webkit [177209] by
-
- 6 edits in trunk/Source/WebKit2
Track pages preventing suppression in WebProcessProxy using RefCounter
https://bugs.webkit.org/show_bug.cgi?id=139108
Reviewed by Benjamin Poulain.
The networking process is allowed to app nap if all web pages are also currently in app nap.
In order to detect whether any page in any process currently requires the networking process
to be active we:
- maintain hash sets in every WebProcessProxy of pages that are okay with suppression.
- if anything changes, the WebContext iterates every WebProcessProxy to recompute state.
This is all crazy - all we actually need is a simple count of the number of pages that need
to prevent the networking process from entering app nap. This patch gets us half way there -
replace the HashSet with a RefCounter. Next step will be to hoist the RefCounters from the
process proxies up to the context to do away with the iteration.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
- make sure we prevent process suppression, per current viewstate & preferences.
(WebKit::WebPageProxy::dispatchViewStateChange):
- make sure we prevent process suppression, per viewstate change.
(WebKit::WebPageProxy::updateProccessSuppressionState):
- recompute whether we need to prevent process suppression.
(WebKit::WebPageProxy::preferencesDidChange):
- when preferences change process supression may be disabled.
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- we need to drop the old ref, to allow a new one to be taken when we reattach.
(WebKit::WebPageProxy::isProcessSuppressible): Deleted.
- moreged into updateProccessSuppressionState.
- UIProcess/WebPageProxy.h:
- added m_preventProcessSuppression.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
- initialize m_pagesPreventingSuppression
(WebKit::WebProcessProxy::createWebPage):
- moved to WebPageProxy::WebPageProxy
(WebKit::WebProcessProxy::addExistingWebPage):
- moved to WebPageProxy::reattachToWebProcess
(WebKit::WebProcessProxy::removeWebPage):
- now implicit; when the page is destroyed the RefPtr will release.
(WebKit::WebProcessProxy::pageSuppressibilityChanged): Deleted.
- moved to WebPageProxy::dispatchViewStateChange.
(WebKit::WebProcessProxy::pagePreferencesChanged): Deleted.
- moved to WebPageProxy::preferencesDidChange.
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::preventProcessSuppressionForPage):
- reference count m_pagesPreventingSuppression
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::allPagesAreProcessSuppressible):
- converted to use m_pagesPreventingSuppression.
- removed guard that meant processes with no pages would keep the networking process from entering app nap, which made no sense.
- 7:16 PM Changeset in webkit [177208] by
-
- 1 delete in tags/Safari-600.1.12
Remove unnecessary tag.
- 7:02 PM Changeset in webkit [177207] by
-
- 3 edits in tags/Safari-601.1.12/Source/WebKit2
Merged r177205.
- 7:01 PM Changeset in webkit [177206] by
-
- 1 copy in tags/Safari-600.3.12
New Tag.
- 6:50 PM Changeset in webkit [177205] by
-
- 3 edits in trunk/Source/WebKit2
Temporarily use WebCore session storage for transient local storage
https://bugs.webkit.org/show_bug.cgi?id=139574
Reviewed by Dan Bernstein.
- WebProcess/Storage/StorageNamespaceImpl.h:
Change the header guard so it won't conflict with StorageNamespaceImpl.h in WebCore.
- WebProcess/Storage/WebStorageNamespaceProvider.cpp:
(WebKit::WebStorageNamespaceProvider::createTransientLocalStorageNamespace):
Use the WebCore session storage for now, to avoid crashes.
- 6:45 PM Changeset in webkit [177204] by
-
- 1 copy in tags/Safari-600.1.12
New Tag.
- 6:41 PM Changeset in webkit [177203] by
-
- 1 edit3 adds in trunk/LayoutTests
Need a regression test for bug 139533
https://bugs.webkit.org/show_bug.cgi?id=139572
Reviewed by Mark Lam.
- js/regress-139533-expected.txt: Added.
- js/regress-139533.html: Added.
- js/script-tests/regress-139533.js: Added.
(.inner):
(outer):
(MyNumber):
(MyNumber.prototype.toString):
- 6:26 PM Changeset in webkit [177202] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Crash when trying to inspect LocalStorage
https://bugs.webkit.org/show_bug.cgi?id=139573
Reviewed by Anders Carlsson.
Move away from PageGroup::localStorage and instead to StorageNamespaceProvider.
This matches what DOMWindow::localStorage does to get the StorageArea for a document.
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::findStorageArea):
- 6:16 PM Changeset in webkit [177201] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix a leak introduced in r177199.
Reviewed by Anders Carlsson.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _updateImmediateActionItem]):
- 5:59 PM Changeset in webkit [177200] by
-
- 26 edits10 adds in trunk
Transform-style should not kill position:fixed
https://bugs.webkit.org/show_bug.cgi?id=138122
Reviewed by Dean Jackson.
Source/WebCore:
Various bits of rendering code checked RenderObject::hasTransform() for various
reasons. Confusingly, this meant "has transform, or preserve-3d, or perspective".
This patch teases those behaviors apart to produce the following behavior:
- "transform" acts as containing block for fixed position (no behavior change).
- "transform" acts as containing block for absolute/relative position (no behavior change).
- "perspective" does not act as containing block for fixed position (no behavior change).
- "perspective" acts as containing block for absolute/relative position (no behavior change).
- "preserve-3d" does not act as containing block for fixed position (behavior change).
- "preserve-3d" acts as containing block for absolute/relative position. This is not a
behavior change, but seems like incorrect behavior (https://www.w3.org/Bugs/Public/show_bug.cgi?id=27566).
However, we may be forced to keep it for compatibility.
The gist of the change is to rename RenderObject::hasTransform() to RenderObject::hasTransformRelatedProperty(),
and add hasTransform() with the more restrictive meaning. All call sites of hasTransform() were examined
and fixed to produce the desired behaviors.
Tests: transforms/2d/perspective-not-fixed-container.html
transforms/2d/preserve3d-not-fixed-container.html
transforms/perspective-is-containing-block-for-absolute.html
transforms/preserve3d-is-containing-block-for-absolute.html
transforms/transform-is-containing-block-for-absolute.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedTransform): Now we can just test hasTransform().
- rendering/LogicalSelectionOffsetCaches.h:
(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): For now, this
can just use hasTransformRelatedProperty(), but if we change [6] above this will have
to change (as documented in the comment). Also FIXME comments about sharing code.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::updateFromStyle):
(WebCore::RenderBox::mapLocalToContainer): Can just use hasTransform() now.
(WebCore::RenderBox::pushMappingToContainer): Ditto.
(WebCore::RenderBox::mapAbsoluteToLocalPoint): Ditto.
(WebCore::RenderBox::layoutOverflowRectForPropagation): Ditto.
- rendering/RenderBox.h: All transform-related properties create RenderLayers.
- rendering/RenderBoxModelObject.h: Ditto.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
- rendering/RenderGeometryMap.cpp:
(WebCore::canMapBetweenRenderersViaLayers): Rename to clarify. We need to not map via
layers if we have a perspective (since we need to generate a perspective matrix). It's
OK with preserve-3d though.
(WebCore::RenderGeometryMap::pushMappingsToAncestor):
(WebCore::canMapBetweenRenderers): Deleted.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::updateFromStyle):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateTransform): Can just check hasTransform().
(WebCore::RenderLayer::updateLayerPosition): Avoid calling parent() and enclosingPositionedAncestor() twice.
(WebCore::RenderLayer::perspectiveTransform): Do the fast bit check hasTransformRelatedProperty() first.
(WebCore::RenderLayer::perspectiveOrigin): Ditto.
(WebCore::isContainerForPositioned): This code has to now have different behavior for absolute and fixed
position. Changed it to call existing functions, rather than having a 3rd place that has to know about
containing block rules.
(WebCore::RenderLayer::enclosingAncestorForPosition): Call isContainerForPositioned() now.
(WebCore::accumulateOffsetTowardsAncestor): Call enclosingAncestorForPosition().
(WebCore::RenderLayer::createLocalTransformState):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::isPositionedContainer): Deleted.
(WebCore::isFixedPositionedContainer): Deleted.
(WebCore::RenderLayer::enclosingPositionedAncestor): Deleted.
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldUseTransformFromContainer): Can just check hasTransform() now.
(WebCore::RenderObject::container):
- rendering/RenderObject.h:
(WebCore::RenderObject::hasTransformRelatedProperty):
(WebCore::RenderObject::hasTransform):
(WebCore::RenderObject::setHasTransformRelatedProperty):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::setHasTransform): Deleted.
- rendering/RenderTableRow.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer): nullptr goodness.
(WebCore::RenderView::pushMappingToContainer): Ditto.
(WebCore::RenderView::mapAbsoluteToLocalPoint): Ditto.
LayoutTests:
New tests and updated results:
- platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Progression, caused
by RenderLayerBacking::updateCompositedBounds() now allowing shouldClipCompositedBounds on
preserve-3d layers, since they are no longer considered to have a transform.
- platform/mac/compositing/visible-rect/3d-transform-style-expected.txt: Ditto.
- transforms/2d/perspective-not-fixed-container-expected.html: Added.
- transforms/2d/perspective-not-fixed-container.html: Added. Tests that
perspective does not act as containing block for fixed position (not a behavior change).
- transforms/2d/preserve3d-not-fixed-container-expected.html: Added.
- transforms/2d/preserve3d-not-fixed-container.html: Added. Tests that
preserve3d does not act as containing block for fixed position. This is a behavior change.
- transforms/perspective-is-containing-block-for-absolute-expected.html: Added.
- transforms/perspective-is-containing-block-for-absolute.html: Added. Tests that
perspective is a as containing block for absolute/relative position. This is not a behavior change.
- transforms/preserve3d-is-containing-block-for-absolute-expected.html: Added.
- transforms/preserve3d-is-containing-block-for-absolute.html: Added. Tests that
preserve3d is a as containing block for absolute/relative position. This is not a behavior change,
but seems like incorrect behavior for now.
- transforms/transform-is-containing-block-for-absolute-expected.html: Added.
- transforms/transform-is-containing-block-for-absolute.html: Added. Tests that
transform is a as containing block for absolute/relative position. This is not a behavior change.
- 5:48 PM Changeset in webkit [177199] by
-
- 3 edits in trunk/Source/WebKit/mac
WK1: Need new SPI for Webkit clients to override default immediate action
https://bugs.webkit.org/show_bug.cgi?id=139568
-and corresponding-
rdar://problem/19225448
Reviewed by Dan Bernstein.
Call SPI giving clients a chance to override the default behavior.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _updateImmediateActionItem]):
New SPI.
- WebView/WebUIDelegatePrivate.h:
- 5:41 PM Changeset in webkit [177198] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Normalize iOS DeviceOrientation beta/gamma per spec.
https://bugs.webkit.org/show_bug.cgi?id=137134
<radr://problem/9414459>
Patch by Rich Tibbett <rich.tibbett@gmail.com> on 2014-12-11
Reviewed by Benjamin Poulain.
Normalize DeviceOrientation beta and gamma on iOS to match the
conventions defined in the W3C DeviceOrientation Events specification.
beta values are returned in the range [-180, 180). gamma values are
returned in the range [-90, 90).
- platform/ios/WebCoreMotionManager.mm:
- 5:37 PM Changeset in webkit [177197] by
-
- 8 edits in tags/Safari-601.1.12/Source
Merged r177196.
- 5:02 PM Changeset in webkit [177196] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r177081.
https://bugs.webkit.org/show_bug.cgi?id=139569
broke iOS video playback (Requested by eric_carlson on
#webkit).
Reverted changeset:
"Fix iOS builders for 8.0"
https://bugs.webkit.org/show_bug.cgi?id=139495
http://trac.webkit.org/changeset/177081
- 4:59 PM Changeset in webkit [177195] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix to build fix in r177134.
- html/canvas/WebGLDrawBuffers.cpp: iOS should query the system for GL extension availability.
- 4:56 PM Changeset in webkit [177194] by
-
- 15 edits3 adds in trunk
Implement frag depth as a WebGL 1 extension.
https://bugs.webkit.org/show_bug.cgi?id=133635.
<rdar://problem/19195381>
Reviewed by Dean Jackson.
Test:
webgl/1.0.3/conformance/extensions/ext-frag-depth.html
Spec for this extension outlined here:
http://www.khronos.org/registry/webgl/extensions/EXT_frag_depth/
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- html/canvas/EXTFragDepth.cpp: Added.
(WebCore::EXTFragDepth::EXTFragDepth):
(WebCore::EXTFragDepth::~EXTFragDepth):
(WebCore::EXTFragDepth::getName):
- html/canvas/EXTFragDepth.h: Added.
- html/canvas/EXTFragDepth.idl: Added.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
- html/canvas/WebGLRenderingContext.h:
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension):
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::ensureEnabled):
- 4:46 PM Changeset in webkit [177193] by
-
- 2 edits in trunk/Source/WebCore
Optimize RenderElement::rendererForRootBackground() a bit
https://bugs.webkit.org/show_bug.cgi?id=139527
Reviewed by Andreas Kling.
Optimize RenderElement::rendererForRootBackground() a bit by not
calling Document::body(). We are only interested in the child element
with a <body> tag. However, Document::body() first checks if a
<frameset> child is present.
No new tests, no behavior change.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::rendererForRootBackground):
- 4:25 PM Changeset in webkit [177192] by
-
- 6 edits in trunk/Source/WebKit2
WK2: Need new SPI for Webkit clients to override default immediate action
https://bugs.webkit.org/show_bug.cgi?id=139564
-and corresponding-
rdar://problem/19225448
Reviewed by Tim Horton.
New SPI _immediateActionAnimationControllerForHitTestResult:withType:userData:
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _immediateActionAnimationControllerForHitTestResult:withType:userData:]):
Keep at ivar for the userData so that it can be passed to the new SPI.
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController didPerformActionMenuHitTest:userData:]):
Always give the SPI a chance to override the animationController.
(-[WKImmediateActionController _updateImmediateActionItem]):
Need to mark WKImmediateActionTypes.h as Private.
- WebKit2.xcodeproj/project.pbxproj:
- 4:22 PM Changeset in webkit [177191] by
-
- 5 edits in trunk/Source/bmalloc
bmalloc should support system memory analysis tools (part 2)
https://bugs.webkit.org/show_bug.cgi?id=139565
Reviewed by Mark Lam.
This patch actually queries the environment to see if memory analysis
tools have been enabled.
- bmalloc/Deallocator.cpp:
(bmalloc::Deallocator::scavenge): Don't process the object log if
we've disabled bmalloc because it will be full of invalid nullptrs.
- bmalloc/Environment.cpp:
(bmalloc::isMallocEnvironmentVariableSet): Test for the list of known
Malloc debugging flags. I also added a plain "Malloc" catch-all for
when you want to disable bmalloc without enabling any kind of funny
business.
It would be slightly nicer just to iterate the list of environment
variables and strstr them, but getenv is the more portable option,
and performance here doesn't really matter.
(bmalloc::isLibgmallocEnabled): Test for the libgmalloc insertion
environment variable.
(bmalloc::Environment::computeIsBmallocEnabled):
- 4:18 PM Changeset in webkit [177190] by
-
- 7 edits in trunk
Remove DataCue "text" attribute
https://bugs.webkit.org/show_bug.cgi?id=139461
Reviewed by Eric Carlson.
Source/WebCore:
- html/track/DataCue.cpp:
- html/track/DataCue.h:
- html/track/DataCue.idl:
LayoutTests:
- media/track/track-datacue-expected.txt:
- media/track/track-datacue.html:
- 4:13 PM Changeset in webkit [177189] by
-
- 3 edits in trunk/Source/bmalloc
2014-12-11 Geoffrey Garen <ggaren@apple.com>
Try to fix the iOS simulator build.
#include the declaration of malloc / free.
- bmalloc/Allocator.cpp:
- bmalloc/Deallocator.cpp:
- 3:50 PM Changeset in webkit [177188] by
-
- 2 edits in trunk/Source/WebCore
Initialize m_ownsGeneratedFile when decoding a FormDataElement
https://bugs.webkit.org/show_bug.cgi?id=139566
Reviewed by Tim Horton.
No tests, because it's random, and I couldn't reproduce an assertion failure in
controlled circumstances.
- platform/network/FormData.h: (WebCore::FormDataElement::decode): A newly created
FormDataElement by definition doesn't own the file.
- 3:28 PM Changeset in webkit [177187] by
-
- 2 edits in trunk/LayoutTests
fast/workers/worker-constructor.html frequently crashes
https://bugs.webkit.org/show_bug.cgi?id=139548
- TestExpectations: Skip it again, it definitely crashes for real, even though
we can't reproduce locally.
- 3:11 PM Changeset in webkit [177186] by
-
- 9 edits in trunk/Source
Move the preview popover to WebImmediateActionController
https://bugs.webkit.org/show_bug.cgi?id=139563
<rdar://problem/19208291>
Reviewed by Beth Dakin.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForLink]):
(-[WebActionMenuController menuItem:viewAtScreenPoint:]): Deleted.
(-[WebActionMenuController menuItem:previewItemAtPoint:]): Deleted.
(-[WebActionMenuController menuItem:preferredEdgeForPoint:]): Deleted.
- WebView/WebImmediateActionController.h:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController webViewClosed]):
(-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
(-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
(-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
(-[WebImmediateActionController _updateImmediateActionItem]):
(-[WebImmediateActionController menuItem:viewAtScreenPoint:]):
(-[WebImmediateActionController menuItem:previewItemAtPoint:]):
(-[WebImmediateActionController menuItem:preferredEdgeForPoint:]):
Move page preview popover related code to WebImmediateActionController.
- WebView/WebUIDelegatePrivate.h:
Add a link preview type.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Pass the gesture recognizer to the WebImmediateActionController.
- UIProcess/mac/WKImmediateActionController.h:
Remove an unnecessary forward declaration.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController willDestroyView:]):
Clear the immediate action recognizer when the view goes away.
- 2:59 PM Changeset in webkit [177185] by
-
- 3 edits in trunk/Source/WebCore
Fix Windows build.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 2:52 PM Changeset in webkit [177184] by
-
- 2 edits in trunk/Source/bmalloc
2014-12-11 Geoffrey Garen <ggaren@apple.com>
Try to fix the build.
- bmalloc.xcodeproj/project.pbxproj: Marked a header exported.
- 2:38 PM Changeset in webkit [177183] by
-
- 8 edits in trunk/Source
Fix the build.
- WebView/WebImmediateActionController.h:
- WebView/WebImmediateActionController.mm:
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
- platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h:
- 2:23 PM Changeset in webkit [177182] by
-
- 2 edits in trunk/Source/WebCore
Fix the build.
- platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h:
- 2:17 PM Changeset in webkit [177181] by
-
- 11 edits2 adds in trunk/Source/bmalloc
bmalloc should support system memory analysis tools (part 1)
https://bugs.webkit.org/show_bug.cgi?id=139559
Reviewed by Mark Lam.
This patch adds the hooks to disable bmalloc at runtime if certain
environment variables are set, but doesn't actually read from the
environment yet.
No performance change.
- bmalloc.xcodeproj/project.pbxproj: Added the Environment class, which
we'll use to read environment variables and see if memory analysis tools
have been enabled.
- bmalloc/Allocator.cpp:
(bmalloc::Allocator::Allocator):
(bmalloc::Allocator::allocateSlowCase): Added a hook to disable bmalloc
on the allocation path. We cache the setting to make the check fast.
- bmalloc/Allocator.h: Interface changes.
- bmalloc/Cache.cpp:
(bmalloc::Cache::Cache): Pass a heap pointer through to our allocator
and deallocator. This main purpose is to enable them to query the
environment for whether bmalloc is enabled; but this is also a slightly
cleaner way to guarantee to them that the Heap has been pre-initialized.
- bmalloc/Deallocator.cpp:
(bmalloc::Deallocator::Deallocator): If bmalloc is disable, artificially
fill the object log to force us to take the slow path on all deallocations.
(bmalloc::Deallocator::deallocateSlowCase): Do the disabled check.
- bmalloc/Deallocator.h: Interface changes.
- bmalloc/Environment.cpp: Added.
(bmalloc::Environment::Environment):
(bmalloc::Environment::computeIsBmallocEnabled):
- bmalloc/Environment.h: Added.
(bmalloc::Environment::isBmallocEnabled): This is the class that will
encapsulate looking for environment variables that turn on heap
analysis tools.
- bmalloc/Heap.h:
(bmalloc::Heap::environment):
- bmalloc/Mutex.h:
(bmalloc::Mutex::Mutex):
- bmalloc/StaticMutex.h: A little refactoring to clarify these comments,
since I got super confused about them while writing this patch.
- bmalloc/VMHeap.cpp: Fixed an #include.
- 2:00 PM Changeset in webkit [177180] by
-
- 10 edits2 adds in trunk/Source
Move the preview popover to WKImmediateActionController
https://bugs.webkit.org/show_bug.cgi?id=139560
<rdar://problem/19208291>
Reviewed by Beth Dakin.
- Shared/API/c/WKImmediateActionTypes.h:
Add a link preview type.
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:webView:]):
Pass the gesture recognizer to the WKImmediateActionController.
(-[WKView _setPreviewTitle:]):
Forward preview title changes to the WKImmediateActionController,
because that's where the preview popover lives now.
- UIProcess/mac/WKActionMenuController.h:
- UIProcess/mac/WKActionMenuController.mm:
Move WKPagePreviewViewController into its own file.
Move page preview popover related code to WKImmediateActionController.
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
Compare the gesture recognizers directly instead of their views, for accuracy.
Move page preview popover related code in from WKActionMenuController.
Some of this should eventually move to WKPagePreviewViewController, but
for now for ease of transition we will move it here.
- UIProcess/mac/WKPagePreviewViewController.h: Added.
- UIProcess/mac/WKPagePreviewViewController.mm: Added.
- WebKit2.xcodeproj/project.pbxproj:
Move WKPagePreviewViewController into its own file.
- platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h:
Add some requisite SPI.
- 1:57 PM Changeset in webkit [177179] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Crash in -[WebVideoFullscreenHUDWindowController playing] in WK1 clients without FULLSCREEN_API enabled.
https://bugs.webkit.org/show_bug.cgi?id=139546
Reviewed by Eric Carlson.
Finish the work started by r173230 and rename mediaElement -> videoElement in WebVideoFullscreenHUDWindowController.
- platform/mac/WebVideoFullscreenHUDWindowController.h:
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController endScrubbing]):
(-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
(-[WebVideoFullscreenHUDWindowController currentTime]):
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
(-[WebVideoFullscreenHUDWindowController duration]):
(-[WebVideoFullscreenHUDWindowController decrementVolume]):
(-[WebVideoFullscreenHUDWindowController incrementVolume]):
(-[WebVideoFullscreenHUDWindowController volume]):
(-[WebVideoFullscreenHUDWindowController setVolume:]):
(-[WebVideoFullscreenHUDWindowController playing]):
(-[WebVideoFullscreenHUDWindowController setPlaying:]):
(-[WebVideoFullscreenHUDWindowController remainingTimeText]):
(-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
(-[WebVideoFullscreenHUDWindowController rewind:]):
(-[WebVideoFullscreenHUDWindowController fastForward:]):
- 1:42 PM Changeset in webkit [177178] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build.
- storage/StorageTracker.cpp:
(WebCore::StorageTracker::syncDeleteAllOrigins):
- 1:17 PM Changeset in webkit [177177] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Minor fixes for documentation and translations
https://bugs.webkit.org/show_bug.cgi?id=139450
Patch by Tomas Popela <tpopela@redhat.com> on 2014-12-11
Reviewed by Sergio Villar Senin.
- UIProcess/API/gtk/WebKitNavigationAction.cpp:
Fix typo in documentation.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):
Mark zoom-level and is-loading properties names for translation and
when touching them also fix the indentation style.
- 1:09 PM Changeset in webkit [177176] by
-
- 2 edits in trunk/LayoutTests
fast/workers/worker-constructor.html frequently crashes
https://bugs.webkit.org/show_bug.cgi?id=139548
- TestExpectations: Enable it again, going to try clean builds.
- 12:45 PM Changeset in webkit [177175] by
-
- 3 edits3 adds497 deletes in trunk/LayoutTests
[iOS] Update expected results for LayoutTests/{scrollingcoordinator, security, sputnik,
storage, svg, tables, transforms, transitions, traversal}
Also skip some animation, css, compositing, transitions, and crypto tests that timeout
when using WebKit1/WebKit2 and remove duplicate and erroneous entries from file
LayoutTests/platform/ios-simulator/TestExpectations.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
[...]
- 12:41 PM Changeset in webkit [177174] by
-
- 2 edits in trunk/LayoutTests
fast/workers/worker-constructor.html frequently crashes
https://bugs.webkit.org/show_bug.cgi?id=139548
- TestExpectations: Skip the test while Michael is investigating. This is a pre-existing
failure that became a lot more frequent today.
- 12:18 PM Changeset in webkit [177173] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Remove a duplicate ChangeLog entry.
- 12:17 PM Changeset in webkit [177172] by
-
- 3 edits in trunk/Source/WebCore
Stop using SQLiteFileSystem in the storage code
https://bugs.webkit.org/show_bug.cgi?id=139549
Reviewed by Sam Weinig.
Just inline the SQLiteFileSystem calls into their respective call sites.
This is more preparation for moving the old storage code into WebKit proper.
- storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::deleteEmptyDatabase):
- storage/StorageTracker.cpp:
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::ensureDatabaseFileExists):
(WebCore::StorageTracker::openTrackerDatabase):
(WebCore::truncateDatabaseFile):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::diskUsageForOrigin):
- 12:15 PM Changeset in webkit [177171] by
-
- 5 edits in trunk/Source
Versioning.
- 12:11 PM Changeset in webkit [177170] by
-
- 1 copy in tags/Safari-601.1.12
New tag.
- 12:08 PM Changeset in webkit [177169] by
-
- 28 edits35 deletes in trunk
Unreviewed, rolling out r177155.
Caused crashes on webarchive tests.
Reverted changeset:
"[SVG Masking] Enable the use of <mask> elements for -webkit-
mask-image"
https://bugs.webkit.org/show_bug.cgi?id=139294
http://trac.webkit.org/changeset/177155
- 11:46 AM Changeset in webkit [177168] by
-
- 16 edits in trunk/Source/JavaScriptCore
Explicitly export somre more RWIProtocol classes.
rdar://problem/19220408
Unreviewed build fix.
- inspector/scripts/codegen/generate_objc_configuration_header.py:
(ObjCConfigurationHeaderGenerator._generate_configuration_interface_for_domains):
- inspector/scripts/codegen/generate_objc_header.py:
(ObjCHeaderGenerator._generate_event_interfaces):
- inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/expected/enum-values.json-result:
- inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
- 11:38 AM Changeset in webkit [177167] by
-
- 6 edits in trunk/Source
Call StorageThread::releaseFastMallocFreeMemoryInAllThreads from WebKit
https://bugs.webkit.org/show_bug.cgi?id=139547
Reviewed by Sam Weinig.
Source/WebCore:
This is another step towards moving StorageThread (and friends) to WebKit.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseMemory):
Source/WebKit/mac:
- WebView/WebView.mm:
(+[WebView _handleMemoryWarning]):
- 11:35 AM Changeset in webkit [177166] by
-
- 4 edits2 adds in trunk
ASSERTION FAILED: animatedTypes[0].properties.size() == 1 in WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue.
https://bugs.webkit.org/show_bug.cgi?id=139046.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2014-12-11
Reviewed by Dirk Schulze.
Source/WebCore:
Test: svg/animations/unsupported-animate-element-attributes.svg.
The SVG base animator element should not animate an attribute if it is not
supported by the target SVG element. Besides the CSS presentation attributes,
every SVG element defines which attributes can be animated by including them
between BEGIN_DECLARE_ANIMATED_PROPERTIES and END_DECLARE_ANIMATED_PROPERTIES
in the definition of the class. This definition builds attribute-properties map.
When restarting the animation, the animator looks for all the attributes that
match the animated attribute name. If the supported attribute-properties map
does not include the animated attribute name, an empty element-properties list
should be returned. When getting an empty element-properties list, the animator
should not start any animation for the unsupported attribute.
Do not start the animation if the animated attribute is not supported by
the target SVG element.
- svg/SVGAnimateElementBase.cpp:
(WebCore::SVGAnimateElementBase::resetAnimatedType):
Return an empty element-properties list if the animated attribute is not
supported by the target SVG element.
- svg/SVGAnimatedTypeAnimator.cpp:
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
LayoutTests:
Ensure the animation attributes will be ignored by the SVG base animator if
they are not supported by the SVG target element.
- svg/animations/unsupported-animate-element-attributes-expected.svg: Added.
- svg/animations/unsupported-animate-element-attributes.svg: Added.
- 11:29 AM Changeset in webkit [177165] by
-
- 4 edits4 adds in trunk
InstancedArray crashes attempting to draw out of bounds
https://bugs.webkit.org/show_bug.cgi?id=139521
Source/WebCore:
Reviewed by Simon Fraser.
We were not doing index validation correctly for instancing.
Test: fast/canvas/webgl/angle-instanced-arrays-out-of-bounds.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateVertexAttributes): We need to check
the number of instances drawn against the amount of instance data that has
been provided, taking into account the number of repeats (the divisor).
(WebCore::WebGLRenderingContext::drawArrays): Added some whitespace to make it more clear.
(WebCore::WebGLRenderingContext::validateDrawElements): This needs to take a primcount
parameter so that it can correctly validate the call (when used from drawElementsInstanced).
(WebCore::WebGLRenderingContext::drawElements): New signature to validate.
(WebCore::WebGLRenderingContext::drawArraysInstanced): Rearrange this a bit. The
primcount validation is already being done by the validateDrawArrays call. Also, there
was a bogus UNUSED_PARAM hanging around.
(WebCore::WebGLRenderingContext::drawElementsInstanced): Similar rearrangement. Use
the primcount parameter.
- html/canvas/WebGLRenderingContext.h:
LayoutTests:
<rdar://problem/17540398>
Reviewed by Simon Fraser.
This is a copy of the official webgl/1.0.3 test.
- platform/mac-mountainlion/fast/canvas/webgl/angle-instanced-arrays-out-of-bounds-expected.txt: Added. This extension is not available on Mountain Lion.
- fast/canvas/webgl/angle-instanced-arrays-out-of-bounds-expected.txt: Added.
- fast/canvas/webgl/angle-instanced-arrays-out-of-bounds.html: Added.
- fast/canvas/webgl/resources/out-of-bounds-test.js: Added.
(OutOfBoundsTest):
- 11:28 AM Changeset in webkit [177164] by
-
- 2 edits in trunk/Source/WebKit2
Web Inspector: Inspector Process crash when navigating to non-inspectable page
https://bugs.webkit.org/show_bug.cgi?id=139508
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-11
Reviewed by Zalan Bujtas.
The Inspector Process can still receive InspectorFrontendHost messages
even though the backend connection has been invalidated and cleared.
Only send messages if the connection exists.
- WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::openInNewTab):
(WebKit::WebInspectorUI::sendMessageToBackend):
- 11:26 AM Changeset in webkit [177163] by
-
- 6 edits in trunk/Source/WebKit2
WebKit2 should expose FirstVisuallyNonEmptyLayout rendering milestone.
https://bugs.webkit.org/show_bug.cgi?id=139514
Expose DidFirstVisuallyNonEmptyLayout so that WebKit2 client can listen to visually non-empty layout rendering event.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-12-11
Reviewed by Dan Bernstein.
- Shared/API/Cocoa/WKRenderingProgressEvents.h: Add WKRenderingProgressEventFirstVisuallyNonEmptyLayout to WKRenderingProgressEvents.
- Shared/API/Cocoa/WKRenderingProgressEventsInternal.h: Also map kWKDidFirstVisuallyNonEmptyLayout to WKRenderingProgressEventFirstVisuallyNonEmptyLayout.
(renderingProgressEvents):
- UIProcess/API/Cocoa/WKWebView.mm:
(layoutMilestones): Map _WKRenderingProgressEventFirstVisuallyNonEmptyLayout to WebCore::DidFirstVisuallyNonEmptyLayout.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/NavigationState.mm: Add _WKRenderingProgressEventFirstVisuallyNonEmptyLayout to _WKRenderingProgressEventFirstLayout.
(WebKit::renderingProgressEvents): Map WebCore::DidFirstVisuallyNonEmptyLayout to _WKRenderingProgressEventFirstVisuallyNonEmptyLayout.
- 11:24 AM Changeset in webkit [177162] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Disable backspace key navigation
https://bugs.webkit.org/show_bug.cgi?id=136231
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-12-11
Reviewed by Carlos Garcia Campos.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): remove handling
for backspace and <shift>backspace key combinations.
- 11:23 AM Changeset in webkit [177161] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] String changes for the HTTP authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=136782
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-12-11
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
(webkitAuthenticationDialogInitialize): Add a title to the dialog, add
some missing mnemonics, and tweak a few strings.
- 10:30 AM Changeset in webkit [177160] by
-
- 3 edits3 adds1 delete in trunk/LayoutTests
[iOS] Update expected results for LayoutTests/{js, loader, mathml, pageoverlay, scrollbars}
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/js/dom/constructor-length-expected.txt: Added.
- platform/ios-simulator/scrollbars/scrollbar-selectors-expected.png: Removed.
- 10:23 AM Changeset in webkit [177159] by
-
- 2 edits in trunk/Source/WebKit
Build fix.
- Storage/WebStorageNamespaceProvider.h:
- 10:17 AM Changeset in webkit [177158] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Remove unused storage header includes
https://bugs.webkit.org/show_bug.cgi?id=139540
Reviewed by Antti Koivisto.
- storage/StorageAreaImpl.cpp:
- storage/StorageAreaSync.cpp:
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::localStorageNamespace): Deleted.
(WebCore::StorageNamespaceImpl::sessionStorageNamespace): Deleted.
(WebCore::StorageNamespaceImpl::transientLocalStorageNamespace): Deleted.
- storage/StorageNamespaceImpl.h:
- storage/StorageSyncManager.cpp:
- storage/StorageThread.cpp:
- storage/StorageTracker.cpp:
- 10:15 AM Changeset in webkit [177157] by
-
- 3 edits in trunk/Source/WebKit
Replicate a bunch of PageGroup functions in WebStorageNamespaceProvider
https://bugs.webkit.org/show_bug.cgi?id=139544
Reviewed by Antti Koivisto.
This code is currently unused but will be called by StorageTracker once that class has been
moved from WebCore to WebKit.
- Storage/WebStorageNamespaceProvider.cpp:
(WebStorageNamespaceProvider::clearLocalStorageForAllOrigins):
(WebStorageNamespaceProvider::clearLocalStorageForOrigin):
(WebStorageNamespaceProvider::closeIdleLocalStorageDatabases):
(WebStorageNamespaceProvider::syncLocalStorage):
- Storage/WebStorageNamespaceProvider.h:
- 10:02 AM Changeset in webkit [177156] by
-
- 9 edits in trunk/Source/JavaScriptCore
Explicitly export some RWIProtocol classes
rdar://problem/19220408
- inspector/scripts/codegen/generate_objc_header.py:
(ObjCHeaderGenerator._generate_type_interface):
- inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
- 9:54 AM Changeset in webkit [177155] by
-
- 28 edits35 adds in trunk
[SVG Masking] Enable the use of <mask> elements for -webkit-mask-image
https://bugs.webkit.org/show_bug.cgi?id=139294
Patch by Radu Stavila <stavila@adobe.com> on 2014-12-11
Reviewed by Simon Fraser.
Source/WebCore:
This patch links together all parts required for the functionality which improves
the -webkit-mask-image property by allowing it to reference a <mask> element defined
in an inline or external SVG document.
Support for this new functionality has been added in a previous patch, under issue
https://bugs.webkit.org/show_bug.cgi?id=139092. A more detailed description of how
the new functionality works can be found in the ChangeLog for that commit.
The containsSVGDocument in ScrollView has been removed because it was added in the
previous patch but is no longer required.
Tests: css3/masking/mask-base64.html
css3/masking/mask-multiple-values.html
css3/masking/mask-svg-clipped-fragmentId.html
css3/masking/mask-svg-fragmentId.html
css3/masking/mask-svg-inline-fragmentId.html
css3/masking/mask-svg-inline-invalid-fragmentId.html
css3/masking/mask-svg-invalid-fragmentId.html
css3/masking/mask-svg-no-fragmentId-tiled.html
css3/masking/mask-svg-no-fragmentId.html
css3/masking/mask-svg-script-entire-svg-to-mask.html
css3/masking/mask-svg-script-mask-to-entire-svg.html
css3/masking/mask-svg-script-mask-to-none.html
css3/masking/mask-svg-script-mask-to-png.html
css3/masking/mask-svg-script-none-to-mask.html
css3/masking/mask-svg-script-none-to-png.html
css3/masking/mask-svg-script-png-to-mask.html
css3/masking/mask-svg-script-png-to-none.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseMaskImage):
- css/CSSParser.h:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustStyleForMaskImages):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::createMaskImageOperations):
(WebCore::StyleResolver::loadPendingImages):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::MaskImagePropertyWrapper::MaskImagePropertyWrapper):
(WebCore::MaskImagePropertyWrapper::equals):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- platform/graphics/MaskImageOperation.cpp:
(WebCore::MaskImageOperation::~MaskImageOperation):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::maskClipRect):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::updateFillImages):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/style/FillLayer.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setMaskImage):
- rendering/style/RenderStyle.h:
LayoutTests:
Added tests for different situations using URLs with fragment id
for the -webkit-mask-image property.
- css3/masking/mask-base64-expected.html: Added.
- css3/masking/mask-base64.html: Added.
- css3/masking/mask-multiple-values-expected.html: Added.
- css3/masking/mask-multiple-values.html: Added.
- css3/masking/mask-repeat-space-padding-expected.html:
- css3/masking/mask-repeat-space-padding.html:
- css3/masking/mask-svg-clipped-fragmentId-expected.html: Added.
- css3/masking/mask-svg-clipped-fragmentId.html: Added.
- css3/masking/mask-svg-fragmentId-expected.html: Added.
- css3/masking/mask-svg-fragmentId.html: Added.
- css3/masking/mask-svg-inline-fragmentId-expected.html: Added.
- css3/masking/mask-svg-inline-fragmentId.html: Added.
- css3/masking/mask-svg-inline-invalid-fragmentId-expected.html: Added.
- css3/masking/mask-svg-inline-invalid-fragmentId.html: Added.
- css3/masking/mask-svg-invalid-fragmentId-expected.html: Added.
- css3/masking/mask-svg-invalid-fragmentId.html: Added.
- css3/masking/mask-svg-no-fragmentId-expected.html: Added.
- css3/masking/mask-svg-no-fragmentId-tiled-expected.html: Added.
- css3/masking/mask-svg-no-fragmentId-tiled.html: Added.
- css3/masking/mask-svg-no-fragmentId.html: Added.
- css3/masking/mask-svg-script-entire-svg-to-mask-expected.html: Added.
- css3/masking/mask-svg-script-entire-svg-to-mask.html: Added.
- css3/masking/mask-svg-script-mask-to-entire-svg-expected.html: Added.
- css3/masking/mask-svg-script-mask-to-entire-svg.html: Added.
- css3/masking/mask-svg-script-mask-to-none-expected.html: Added.
- css3/masking/mask-svg-script-mask-to-none.html: Added.
- css3/masking/mask-svg-script-mask-to-png-expected.html: Added.
- css3/masking/mask-svg-script-mask-to-png.html: Added.
- css3/masking/mask-svg-script-none-to-mask-expected.html: Added.
- css3/masking/mask-svg-script-none-to-mask.html: Added.
- css3/masking/mask-svg-script-none-to-png-expected.html: Added.
- css3/masking/mask-svg-script-none-to-png.html: Added.
- css3/masking/mask-svg-script-png-to-mask-expected.html: Added.
- css3/masking/mask-svg-script-png-to-mask.html: Added.
- css3/masking/mask-svg-script-png-to-none-expected.html: Added.
- css3/masking/mask-svg-script-png-to-none.html: Added.
- css3/masking/resources/masks.svg: Added.
- 9:51 AM Changeset in webkit [177154] by
-
- 13 edits in trunk/Source
Restore interface state when stopping optimized fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=139465
Reviewed by Simon Fraser.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController fullscreenMayReturnToInline:]): add empty implementation.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h: add declaration
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): restore interface context when optimized mode ends.
(WebVideoFullscreenInterfaceAVKit::setIsOptimized): restore interface context when optimized mode ends.
- UIProcess/API/APIUIClient.h:
(API::UIClient::fullscreenMayReturnToInline): added
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h: add declaration
- UIProcess/Cocoa/UIDelegate.h: add declaration
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate): check for responds to selector
(WebKit::UIDelegate::UIClient::fullscreenMayReturnToInline): added
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::fullscreenMayReturnToInline): added.
- UIProcess/WebPageProxy.h: add declaration
- UIProcess/ios/WebVideoFullscreenManagerProxy.h: add declaration
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::fullscreenMayReturnToInline): show the tab.
- 9:37 AM Changeset in webkit [177153] by
-
- 8 edits in trunk/Source/WebCore
Remove unused storage header includes
https://bugs.webkit.org/show_bug.cgi?id=139540
Reviewed by Antti Koivisto.
- storage/StorageAreaImpl.cpp:
- storage/StorageAreaSync.cpp:
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::localStorageNamespace): Deleted.
(WebCore::StorageNamespaceImpl::sessionStorageNamespace): Deleted.
(WebCore::StorageNamespaceImpl::transientLocalStorageNamespace): Deleted.
- storage/StorageNamespaceImpl.h:
- storage/StorageSyncManager.cpp:
- storage/StorageThread.cpp:
- storage/StorageTracker.cpp:
- 9:23 AM Changeset in webkit [177152] by
-
- 18 edits in trunk/Source
REGRESSION (Async Text Input): Text input method state is not reset when reloading a page
https://bugs.webkit.org/show_bug.cgi?id=139504
rdar://problem/19034674
Reviewed by Enrica Casucci.
Source/WebCore:
Explicitly notify EditorClient when a composition is voluntarily canceled by WebCore.
These are almost certainly not all the places where this happens, but this fixes the bug,
and lays the groundwork for using this new client call instead of didChangeSelection
hacks.
- editing/Editor.cpp:
(WebCore::Editor::clear):
(WebCore::Editor::cancelComposition):
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::willTransitionToCommitted):
- page/EditorClient.h:
Source/WebKit/mac:
Stub out new client calls, this patch does not attempt to make any changes on WebKit1.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::discardedComposition):
Source/WebKit/win:
Stub out new client calls, this patch doesn't attempt to make any changes on Windows.
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::discardedComposition):
- WebCoreSupport/WebEditorClient.h:
Source/WebKit2:
WebKit2 used to look at EditorState changes and guess when to cancel a composition.
This was quite unreliable, and needlessly complicated - WebCore knows when it decides
to destroy a composition, so it now explicitly notifies the clients.
- UIProcess/API/mac/WKView.mm: (-[WKView _processDidExit]): Address crashing case too.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::discardedComposition):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeSelection):
(WebKit::WebPage::discardedComposition):
- WebProcess/WebPage/WebPage.h:
- 9:12 AM Changeset in webkit [177151] by
-
- 23 edits3 deletes in trunk/Source
Get rid of the storage strategy
https://bugs.webkit.org/show_bug.cgi?id=139519
Reviewed by Antti Koivisto.
Source/WebCore:
- CMakeLists.txt:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::localStorage):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::sessionStorage):
(WebCore::Page::setStorageNamespaceProvider):
- page/Page.h:
(WebCore::Page::storageNamespaceProvider):
- page/PageGroup.cpp:
(WebCore::PageGroup::localStorage):
(WebCore::PageGroup::transientLocalStorage):
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::PlatformStrategies):
(WebCore::PlatformStrategies::storageStrategy): Deleted.
- storage/StorageNamespace.cpp: Removed.
- storage/StorageNamespace.h:
- storage/StorageStrategy.cpp: Removed.
- storage/StorageStrategy.h: Removed.
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createStorageStrategy): Deleted.
Source/WebKit/win:
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createStorageStrategy): Deleted.
- WebCoreSupport/WebPlatformStrategies.h:
Source/WebKit2:
- NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::createStorageStrategy): Deleted.
- NetworkProcess/NetworkProcessPlatformStrategies.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createStorageStrategy): Deleted.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 9:09 AM Changeset in webkit [177150] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] WebKitNotification is defined twice
https://bugs.webkit.org/show_bug.cgi?id=139538
Reviewed by Martin Robinson.
Remove the typedef from WebKitForwardDeclarations.h since it's
already in WebKitNotification.h and include WebKitNotification.h
in WebKitWebView.h.
- UIProcess/API/gtk/WebKitForwardDeclarations.h:
- UIProcess/API/gtk/WebKitWebView.h:
- 9:09 AM Changeset in webkit [177149] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix broken build after r177146.
https://bugs.webkit.org/show_bug.cgi?id=139533
Not reviewed.
- interpreter/CallFrame.h:
(JSC::ExecState::init):
- Restored CallFrame::init() minus the unused JSScope* arg.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- Remove JSScope* arg when calling CallFrame::init().
- 9:07 AM Changeset in webkit [177148] by
-
- 4 edits2 deletes in trunk/Source
[GTK] Move click counter logic back to WebKitWebViewBase
https://bugs.webkit.org/show_bug.cgi?id=137685
Reviewed by Martin Robinson.
Source/WebCore:
Remove GtkClickCounter.
- PlatformGTK.cmake:
- platform/gtk/GtkClickCounter.cpp: Removed.
- platform/gtk/GtkClickCounter.h: Removed.
Source/WebKit2:
It was moved to a shared class in platform to be used by both
WebKit1 and WebKit2, but it's currently only used by WebKitWebViewBase.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(ClickCounter::reset):
(ClickCounter::currentClickCountForGdkButtonEvent):
(webkitWebViewBaseButtonPressEvent):
- 9:02 AM Changeset in webkit [177147] by
-
- 3 edits in trunk/Tools
[GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
https://bugs.webkit.org/show_bug.cgi?id=139537
Reviewed by Carlos Garcia Campos.
- jhbuild/jhbuild-wrapper: Pass the port name in the invocation
of get_dependencies_path().
- jhbuild/jhbuildutils.py:
(get_dependencies_path): Fix the function to return the new
dependencies path: DependenciesPORT.
(enter_jhbuild_environment_if_available): Pass the port name
when invoking get_dependencies_path().
- 8:41 AM Changeset in webkit [177146] by
-
- 19 edits in trunk/Source/JavaScriptCore
REGRESSION: Use of undefined CallFrame::ScopeChain value
https://bugs.webkit.org/show_bug.cgi?id=139533
Reviewed by Mark Lam.
Removed CallFrame::scope() and CallFrame::setScope() and eliminated or changed
all usages of these funcitons. In some cases the scope is passed in or determined
another way. In some cases the scope is used to calculate other values. Lastly
were places where these functions where used that are no longer needed. For
example when making a call, the caller's ScopeChain was copied to the callee's
ScopeChain. This change no longer uses the ScopeChain call frame header slot.
That slot will be removed in a future patch.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- runtime/JSLexicalEnvironment.h:
(JSC::JSLexicalEnvironment::create):
(JSC::JSLexicalEnvironment::JSLexicalEnvironment):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_create_lexical_environment):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_create_lexical_environment):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
(JSC::LLInt::llint_throw_stack_overflow_error):
Pass the current scope value to the helper operationCreateActivation() and
the call to JSLexicalEnvironment::create() instead of using the stack frame
scope chain value.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
CreateActivation now has a second child, the scope.
- interpreter/CallFrame.h:
(JSC::ExecState::init): Deleted. This is dead code.
(JSC::ExecState::scope): Deleted.
(JSC::ExecState::setScope): Deleted.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters): Changed so we didn't access the scope
chain slot.
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
Changed process to find JSScope values on the stack or by some other means.
- runtime/JSWithScope.h:
(JSC::JSWithScope::JSWithScope): Deleted.
Eliminated unused constructor.
- runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::StrictEvalActivation):
- runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::create):
Changed to pass in the current scope.
- 5:37 AM Changeset in webkit [177145] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] [GTK] warning: unused parameter at NetworkProcessSoup.cpp after r177056.
https://bugs.webkit.org/show_bug.cgi?id=139534
Reviewed by Martin Robinson.
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::clearDiskCache): Comment the parameter names.
- 3:22 AM Changeset in webkit [177144] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Timers might never be fired during animations
https://bugs.webkit.org/show_bug.cgi?id=139062
Reviewed by Martin Robinson.
This can happen in old/slow machines where the time to render
layers might take more than 0.016. Since the layer flush timer is
using a higher priority than WebCore timers, when scheduling all
(or several) layer flushes immediately, no other sources with
lower priority are dispatched in the main loop. We could detect if
we are scheduling layer flushes immediately for too long (100ms)
and schedule the next flush after a delay to ensure other sources
with lower priority have a chance to be dispatched. Also use a
lower priority, GDK_PRIORITY_EVENTS is too high, so we use
GDK_PRIORITY_REDRAW - 1 to ensure it's higher than WebCore timers.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::LayerTreeHostGtk): Rename
m_lastFlushTime as m_lastImmediateFlushTime.
(WebKit::LayerTreeHostGtk::layerFlushTimerFired): Save the
fireTime before calling flushAndRenderLayers() and compute the
next flush delay based on the elapsed time using monotonically
increasing time instead of current time. Use the target delay
as next flush delay if we have scheduled flushes immediately for
more than 100ms.
(WebKit::LayerTreeHostGtk::flushAndRenderLayers): Do not save the
layer flush time here, it's done in layerFlushTimerFired() so that
we don't need to keep it as a member.
(WebKit::LayerTreeHostGtk::scheduleLayerFlush): Use global
layerFlushTimerPriority.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 2:31 AM Changeset in webkit [177143] by
-
- 6 edits in trunk/Source/WebCore
[GTK] Implement sizes attribute for link tag
https://bugs.webkit.org/show_bug.cgi?id=125775
Reviewed by Martin Robinson.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_link_element_set_sizes): Add custom setter implementation.
- bindings/gobject/WebKitDOMCustomUnstable.h:
- bindings/js/JSHTMLLinkElementCustom.cpp:
(WebCore::JSHTMLLinkElement::sizes): Remove custom getter implementation.
- bindings/scripts/CodeGeneratorGObject.pm:
(HasUnstableCustomAPI): Mark WebKitDOMHTMLLinkElement as having custom unstable API.
- html/HTMLLinkElement.idl: Mark sizes attribute as CustomSetter
instead of Custom, since the getter can be autogenerated, and make
it available to the GObject DOM bindings too.
- 1:18 AM Changeset in webkit [177142] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r177106. rdar://problems/19135389
- 1:18 AM Changeset in webkit [177141] by
-
- 16 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r177104. rdar://problems/19135389
- 12:52 AM Changeset in webkit [177140] by
-
- 5 edits1 delete in trunk/LayoutTests
Mac test expectations gardening.
https://bugs.webkit.org/show_bug.cgi?id=139472
Removed expectations for tests that are no longer flaky, moved WK1 and WK2 only
expectations to correct files, added more flakiness expectations for tests that
fail with ATI graphics.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/mac/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Removed.
- platform/wk2/TestExpectations:
- 12:50 AM Changeset in webkit [177139] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r177132. rdar://problems/19213620
- 12:50 AM Changeset in webkit [177138] by
-
- 4 edits in branches/safari-600.3-branch/Source
Merged r177111. rdar://problems/19198388
- 12:25 AM Changeset in webkit [177137] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Remove invalid Apple slave.
- 12:11 AM Changeset in webkit [177136] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Fix config.json.
Dec 10, 2014:
- 11:41 PM Changeset in webkit [177135] by
-
- 6 edits6 adds in trunk
http://omfgdogs.info/ only animates when you resize the window
https://bugs.webkit.org/show_bug.cgi?id=139435
<rdar://problem/19190493>
Reviewed by Simon Fraser.
Source/WebCore:
After r163928, we would fail to animate a gif if:
- it is used as a background image of a 0-height html element
- it is used as a background image of a 0-height body element whose background is delegated to the root (because the root has no background).
This is because in such cases, shouldRepaintForImageAnimation()
should use the background rect instead of the renderer's overflow
rect to determine if the image is inside the viewport. Both cases
are addressed in this patch.
Tests: fast/images/animated-gif-body-delegated-background-image.html
fast/images/animated-gif-body-outside-viewport.html
fast/images/animated-gif-html-background-image.html
- rendering/RenderElement.cpp:
(WebCore::shouldRepaintForImageAnimation):
- testing/Internals.cpp:
(WebCore::Internals::hasPausedImageAnimations):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Add layout tests to make sure a gif image is still animated if:
- It is used as a background image of a 0-height html element
- It is used as a background image of a 0-height body element that is delegated to the root (because the root has no background)
Also add a layout test to make sure we still stop the gif animation
if it is used as background image of a body that is outside the
viewport.
- fast/images/animated-gif-body-delegated-background-image-expected.txt: Added.
- fast/images/animated-gif-body-delegated-background-image.html: Added.
- fast/images/animated-gif-body-outside-viewport-expected.txt: Added.
- fast/images/animated-gif-body-outside-viewport.html: Added.
- fast/images/animated-gif-html-background-image-expected.txt: Added.
- fast/images/animated-gif-html-background-image.html: Added.
- 11:37 PM Changeset in webkit [177134] by
-
- 2 edits in trunk/Source/WebCore
Fix the build.
- html/canvas/WebGLDrawBuffers.cpp:
Yosemite is 101000, not 10100.
Also, MAC_OS_X_VERSION_MIN_REQUIRED is only defined for PLATFORM(MAC).
- 11:22 PM Changeset in webkit [177133] by
-
- 2 edits in trunk/Tools
Update Apple owned build slaves.
Rubber-stamped by Dana Burkart.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 10:32 PM Changeset in webkit [177132] by
-
- 2 edits in trunk/Source/WebKit/mac
Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=139529
<rdar://problem/19213620>
Reviewed by Beth Dakin.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _copySelection:]):
(-[WebActionMenuController _paste:]):
Use the copy: and paste: methods on WebView so that we traverse subviews
when trying to respond, otherwise these actions don't work in subframes.
- 10:24 PM Changeset in webkit [177131] by
-
- 7 edits2 adds in trunk/Source/WebKit
WK1: Add initial support for immediate actions
https://bugs.webkit.org/show_bug.cgi?id=139522
Reviewed by Dan Bernstein.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
This basic implementation of the controller will use the delegate methods to
perform and cache a HitTest when relevant. Future patches will patch
_updateImmediateActionItem to use the HitTestResult to determine if there is any
immediate action that should be taken.
- WebView/WebImmediateActionController.h: Added.
- WebView/WebImmediateActionController.mm: Added.
(-[WebImmediateActionController webViewClosed]):
(-[WebImmediateActionController _clearImmediateActionState]):
(-[WebImmediateActionController performHitTestAtPoint:]):
(-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
(-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
(-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
(-[WebImmediateActionController _updateImmediateActionItem]):
New enum for immediate action types.
- WebView/WebUIDelegatePrivate.h:
Create an NSImmediateActionGestureRecognizer if possible and a controller.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _close]):
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]):
- 9:31 PM Changeset in webkit [177130] by
-
- 22 edits in trunk/Source/JavaScriptCore
Use std::unique_ptr instead of OwnPtr in JSC - heap, jit, runtime, and parser directories
https://bugs.webkit.org/show_bug.cgi?id=139351
Reviewed by Filip Pizlo.
As a step to use std::unique_ptr<>, this cleans up OwnPtr and PassOwnPtr.
- bytecode/SamplingTool.h:
(JSC::SamplingTool::SamplingTool):
- heap/CopiedBlock.h:
(JSC::CopiedBlock::didSurviveGC):
(JSC::CopiedBlock::pin):
- heap/CopiedBlockInlines.h:
(JSC::CopiedBlock::reportLiveBytes):
- heap/GCActivityCallback.h:
- heap/GCThread.cpp:
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::markListSet):
- jit/ExecutableAllocator.cpp:
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITThunks.cpp:
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::clearHostFunctionStubs):
- jit/JITThunks.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
- parser/Parser.h:
(JSC::Scope::Scope):
(JSC::Scope::pushLabel):
- parser/ParserArena.cpp:
- parser/ParserArena.h:
(JSC::ParserArena::identifierArena):
- parser/SourceProviderCache.h:
- runtime/CodeCache.h:
- runtime/Executable.h:
- runtime/JSArray.cpp:
(JSC::JSArray::sortVector):
- runtime/JSGlobalObject.h:
- 7:54 PM Changeset in webkit [177129] by
-
- 2 edits in trunk/Tools
[iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
timeout instead of test failure
https://bugs.webkit.org/show_bug.cgi?id=139525
Reviewed by Zalan Bujtas.
Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
output.
Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
for the WebThread to spin its run loop before dumping its output. A test that
calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
because run-webkit-tests may terminate a DumpRenderTree.app process when it
exceeds its process time limit (defaults to 35ms) regardless of whether such
a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_timeout_ms):
- 7:29 PM Changeset in webkit [177128] by
-
- 6 edits4 adds in trunk
Continuously repainting large parts of Huffington Post.
https://bugs.webkit.org/show_bug.cgi?id=139468
Reviewed by Antti Koivisto.
This patch eliminates redundant repaint requests for inlines when neither the parent
block flow nor any of the inline children are dirty.
Previously,
- simple line layout always recalculated inline content positions regardless of whether
the content needed relayout at all; as a result, it always triggered full repaint.
- inline tree layout ignored the needslayout flag on the last line and treated it dirty
(unless it broke cleanly (<div>foo<br></div>)).
This was an ancient workaround for an editing/insert use case, but it seems not to be the case anymore.
Source/WebCore:
Tests: fast/repaint/implicitly-positioned-block-repaint-complex-line-layout.html
fast/repaint/implicitly-positioned-block-repaint-simple-line-layout.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlockFlow::layoutSimpleLines): Check if we need to trigger layout at all.
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::determineStartPosition): Remove the last line dirty hack. If it
happens to introduce regression, we should fix it at the caller site to make the line dirty.
LayoutTests:
- fast/repaint/implicitly-positioned-block-repaint-complex-line-layout-expected.txt: Added.
- fast/repaint/implicitly-positioned-block-repaint-complex-line-layout.html: Added.
- fast/repaint/implicitly-positioned-block-repaint-simple-line-layout-expected.txt: Added.
- fast/repaint/implicitly-positioned-block-repaint-simple-line-layout.html: Added.
- platform/mac/fast/line-grid/line-align-right-edges-expected.txt:
- 7:04 PM Changeset in webkit [177127] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Update Apple bot list.
- 6:35 PM Changeset in webkit [177126] by
-
- 2 edits in trunk/Source/WebCore
Add an empty storage namespace provider
https://bugs.webkit.org/show_bug.cgi?id=139520
Reviewed by Tim Horton.
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
- 6:33 PM Changeset in webkit [177125] by
-
- 2 edits in trunk/Source/WebKit2
[CMake] Fix build after WebStorageNamespaceProvider
Unreviewed, fix build.
- CMakeLists.txt: Add WebStorageNamespaceProvider.cpp to the source list.
- 6:30 PM Changeset in webkit [177124] by
-
- 2 edits in trunk/Source/WebCore
Speculative build fix.
- platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h:
- 6:11 PM Changeset in webkit [177123] by
-
- 3 edits in trunk/Source/WebKit2
Build fix for EFL and GTK ports since r177104
https://bugs.webkit.org/show_bug.cgi?id=139513
Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2014-12-10
Reviewed by Tim Horton.
Moved WebPageProxy::installViewStateChangeCompletionHandler in PLATFORM(MAC) macro.
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- 5:59 PM Changeset in webkit [177122] by
-
- 2 edits in trunk/LayoutTests
Remove expectations that were incorrectly landed in http://trac.webkit.org/changeset/176778
- platform/mac/TestExpectations:
- 5:54 PM Changeset in webkit [177121] by
-
- 2 edits in trunk/LayoutTests
Fix a typo in the rpevious commit.
- platform/mac-wk1/TestExpectations:
- 5:51 PM Changeset in webkit [177120] by
-
- 4 edits in trunk/LayoutTests
Fix lint warnings on Mac TestExpectations.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 5:31 PM Changeset in webkit [177119] by
-
- 6 edits in trunk/Source/WebKit
Use the new storage namespace provider in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=139425
Reviewed by Tim Horton.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Set the storage namespace provider from the web page group.
Source/WebKit/win:
- WebView.cpp:
(localStorageDatabasePath):
Helper from getting the local storage database path given a WebPreferences instance.
(WebView::initWithFrame):
Create a storage namespace provider.
- 5:18 PM Changeset in webkit [177118] by
-
- 5 edits in trunk/Source/WebKit2
Switch WebKit2 over to using the storage namespace provider
https://bugs.webkit.org/show_bug.cgi?id=139509
Reviewed by Tim Horton.
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
(WebKit::StorageNamespaceImpl::~StorageNamespaceImpl):
(WebKit::localStorageNamespaceMap): Deleted.
Get rid of the storage namespace map - we have a map inside WebStorageNamespaceProvider now.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createStorageStrategy):
(WebKit::WebPlatformStrategies::populatePluginCache): Deleted.
(WebKit::WebPlatformStrategies::localStorageNamespace): Deleted.
(WebKit::WebPlatformStrategies::transientLocalStorageNamespace): Deleted.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Get rid of the storage strategy.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Set a storage namespace provider.
- 5:14 PM Changeset in webkit [177117] by
-
- 1 copy in tags/Safari-600.1.4.13.1
New tag.
- 5:10 PM Changeset in webkit [177116] by
-
- 2 edits in trunk/Source/WebKit2
Follow-up build fix.
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:webView:]):
- 5:10 PM Changeset in webkit [177115] by
-
- 3 edits1 add in trunk
Null dereference performing a "TapAndAHalf" gesture in Google search field
<https://bugs.webkit.org/show_bug.cgi?id=139506>
<rdar://problem/19028828>
Reviewed by Darin Adler.
.:
- ManualTests/ios/tap-and-a-half-gesture-in-empty-text-field.html: Added.
Source/WebKit2:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):
Add a null check in the case that there is no word range for the
current position.
- 5:05 PM Changeset in webkit [177114] by
-
- 2 edits in trunk/Source/WebKit2
Speculative build fix.
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:webView:]):
- 4:14 PM Changeset in webkit [177113] by
-
- 5 edits4 adds in trunk/Source
WK2: Add initial support for immediate actions
https://bugs.webkit.org/show_bug.cgi?id=139511
Reviewed by Tim Horton.
Source/WebCore:
SPI needed for immediate actions.
- WebCore.xcodeproj/project.pbxproj:
- platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h: Added.
Source/WebKit2:
New enum to track immediate action types as we add them.
- Shared/API/c/WKImmediateActionTypes.h: Added.
Create an NSImmediateActionGestureRecognizer if possible and a controller.
- UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]):
(-[WKView initWithFrame:context:configuration:webView:]):
(-[WKView _didPerformActionMenuHitTest:userData:]):
This basic implementation of the controller will use the delegate methods to
perform an ActionMenuHitTest when relevant. Future patches will patch
_updateImmediateActionItem to use the hit test result to determine if there is any
immediate action that should be taken.
- UIProcess/mac/WKImmediateActionController.h: Added.
- UIProcess/mac/WKImmediateActionController.mm: Added.
(-[WKImmediateActionController willDestroyView:]):
(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController didPerformActionMenuHitTest:userData:]):
Does much of the work done in Action Menu’s prepareForMenu.
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
Does much of the work done in Action Menu’s menuNeedsUpdate.
(-[WKImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
Does much of the work done in Action Menu’s didCloseMenu.
(-[WKImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
Does much of the work done in Action Menu’s willOpenMenu.
(-[WKImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
To be filled in.
(-[WKImmediateActionController _updateImmediateActionItem]):
- WebKit2.xcodeproj/project.pbxproj:
- 3:55 PM Changeset in webkit [177112] by
-
- 2 edits2 deletes in trunk/LayoutTests
Mark more tests that fail on EWS bots with ATI graphics.
- platform/mac/TestExpectations:
- platform/mac/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
- platform/mac/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
These were expecting failure, but the tests pass on regular bots.
- 3:48 PM Changeset in webkit [177111] by
-
- 4 edits in trunk/Source
Should have copy and paste items in all text menus
https://bugs.webkit.org/show_bug.cgi?id=139510
<rdar://problem/19198388>
Reviewed by Beth Dakin.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForText]):
Add a disabled paste menu item into the read-only text menu.
(-[WKActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
Add a disabled copy menu item into the editable whitespace text menu.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForText]):
Add a disabled paste menu item into the read-only text menu.
(-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
Add a disabled copy menu item into the editable whitespace text menu.
- 3:42 PM Changeset in webkit [177110] by
-
- 10 edits in trunk/Source
[iOS] Add setting to ignore viewport scaling constraints
https://bugs.webkit.org/show_bug.cgi?id=139466
<rdar://problem/19200328>
Reviewed by Benjamin Poulain.
Source/WebCore:
- WebCore.exp.in:
- page/Settings.in: Add setting to ignore viewport scaling constraints.
- page/ViewportConfiguration.cpp: Ignore viewport scaling constraints based on preference.
(WebCore::ViewportConfiguration::initialScale):
(WebCore::ViewportConfiguration::minimumScale):
(WebCore::ViewportConfiguration::allowsUserScaling):
- page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::setIgnoreScalingConstraints):
(WebCore::ViewportConfiguration::allowsUserScaling): Moved to cpp.
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h: Add ignoreViewportScalingConstraints preference.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetIgnoreViewportScalingConstraints):
(WKPreferencesGetIgnoreViewportScalingConstraints):
- UIProcess/API/C/WKPreferencesRef.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 3:35 PM Changeset in webkit [177109] by
-
- 12 edits in branches/safari-600.3-branch/Source
Merged r176999. rdar://problems/19149219
- 3:31 PM Changeset in webkit [177108] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported
https://bugs.webkit.org/show_bug.cgi?id=139307
Reviewed by Darin Adler.
- UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):
- 3:19 PM Changeset in webkit [177107] by
-
- 2 edits in trunk/Source/WebCore
Speculative fix for assertion "frame().view() == this"
<rdar://problem/18419449>
Rubber-stamped by Anders Carlsson.
I have not reproduced this issue, but we can safely ignore animation
notifications for cached pages.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::newImageAnimationFrameAvailable):
- 3:16 PM Changeset in webkit [177106] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build.
- UIProcess/API/mac/WKView.mm:
(-[WKView _targetWindowForMovePreparation]):
- 3:07 PM Changeset in webkit [177105] by
-
- 7 edits in trunk/LayoutTests
Rename layoutTestController to testRunner in TestExpectations.
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/win-xp/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 3:00 PM Changeset in webkit [177104] by
-
- 16 edits in trunk/Source/WebKit2
Provide SPI to asynchronously move a WKView into a window and know when it has painted
https://bugs.webkit.org/show_bug.cgi?id=139460
<rdar://problem/19135389>
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKViewPrivate.h:
Add _prepareForMoveToWindow:withCompletionHandler:, which internally
goes through the motions of being parented in that window and calls
the completion handler once painting is done and the view is ready
to be displayed (upon which we expect the view to actually move into the window).
- UIProcess/API/mac/WKView.mm:
(-[WKView viewWillMoveToWindow:]):
If we currently have a _targetWindowForMovePreparation (and are
pretending to be in that window), avoid performing viewWillMoveToWindow:
for a different window.
(-[WKView viewDidMoveToWindow]):
(-[WKView doWindowDidChangeScreen]):
(-[WKView _intrinsicDeviceScaleFactor]):
(-[WKView _colorSpace]):
(-[WKView _targetWindowForMovePreparation]):
If we have a _targetWindowForMovePreparation, use its properties instead
of self.window's.
(-[WKView _prepareForMoveToWindow:withCompletionHandler:]):
Simulate a move into the target window, but defer sending the view state update.
Then, send the view state update after registering the completion handler.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Rename m_viewStateChangeWantsReply to m_viewStateChangeWantsSynchronousReply.
(WebKit::WebPageProxy::installViewStateChangeCompletionHandler):
Added. Allow installing a block that will be called the next time
we get a didUpdateViewState back from the WebProcess after pushing the
current view state changes.
(WebKit::WebPageProxy::viewStateDidChange):
Adapt to the aforementioned rename.
(WebKit::WebPageProxy::dispatchViewStateChange):
Adapt to the aforementioned rename.
Send the view state change callback IDs along with SetViewState.
(WebKit::WebPageProxy::updateViewState):
Adapt to the aforementioned rename.
- UIProcess/WebPageProxy.h:
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::activeWindow):
(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewVisibleOrOccluded):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::viewLayerHostingMode):
If we have a _targetWindowForMovePreparation, use its properties instead
of the WKView's window's.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::viewStateDidChange):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::setViewState):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::viewStateDidChange):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::viewStateDidChange):
Push the callback IDs to the WebProcess, and accumulate them in TiledCoreAnimationDrawingArea.
(WebKit::TiledCoreAnimationDrawingArea::didUpdateViewStateTimerFired):
Call all of the callbacks after one runloop cycle, just like DidUpdateViewState.
- 2:50 PM Changeset in webkit [177103] by
-
- 2 edits in trunk/LayoutTests
media/video-controls-no-scripting.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=137368
- platform/mac/TestExpectations: Update expectations to expect flakiness on all
OS X versions.
- 2:48 PM Changeset in webkit [177102] by
-
- 11 edits in trunk/Source
Add session storage handling to StorageNamespaceProvider
https://bugs.webkit.org/show_bug.cgi?id=139507
Reviewed by Tim Horton.
Source/WebCore:
- page/Page.cpp:
(WebCore::Page::sessionStorage):
- storage/StorageNamespaceProvider.h:
Source/WebKit:
- Storage/WebStorageNamespaceProvider.cpp:
(WebStorageNamespaceProvider::createSessionStorageNamespace):
- Storage/WebStorageNamespaceProvider.h:
Source/WebKit2:
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createSessionStorageNamespace):
- WebProcess/Storage/StorageNamespaceImpl.h:
- WebProcess/Storage/WebStorageNamespaceProvider.cpp:
(WebKit::WebStorageNamespaceProvider::createSessionStorageNamespace):
- WebProcess/Storage/WebStorageNamespaceProvider.h:
- 2:33 PM Changeset in webkit [177101] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Follow-up patch to r177099.
https://bugs.webkit.org/show_bug.cgi?id=133634
<rdar://problem/15949588>
Enable GL_EXT_draw_buffers on iOS as well.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension):
- 2:31 PM Changeset in webkit [177100] by
-
- 3 edits in trunk/Source/WebKit2
Implement the rest of the transient local storage namespace code
https://bugs.webkit.org/show_bug.cgi?id=139505
Reviewed by Tim Horton.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::TransientLocalStorageNamespace::create):
(WebKit::StorageManager::TransientLocalStorageNamespace::~TransientLocalStorageNamespace):
(WebKit::StorageManager::TransientLocalStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::TransientLocalStorageNamespace::clearStorageAreasMatchingOrigin):
(WebKit::StorageManager::TransientLocalStorageNamespace::clearAllStorageAreas):
(WebKit::StorageManager::TransientLocalStorageNamespace::TransientLocalStorageNamespace):
Introduce a new TransientLocalStorageNamespace that's just a glorified SecurityOrigin -> StorageArea HashMap.
(WebKit::StorageManager::StorageArea::create):
Change the return type to RefPtr.
(WebKit::StorageManager::deleteEntriesForOrigin):
(WebKit::StorageManager::deleteAllEntries):
(WebKit::StorageManager::deleteLocalStorageOriginsModifiedSince):
Use lambdas instead of bind. Delete the transient local storage as well.
(WebKit::StorageManager::createTransientLocalStorageMap):
Get a transient local storage namespace and ask it for a storage area.
(WebKit::StorageManager::getOrCreateTransientLocalStorageNamespace):
Look up the namespace from the map and create one if it doesn't exist.
(WebKit::StorageManager::deleteEntriesForOriginInternal): Deleted.
(WebKit::StorageManager::deleteAllEntriesInternal): Deleted.
- UIProcess/Storage/StorageManager.h:
- 2:12 PM Changeset in webkit [177099] by
-
- 2 edits in trunk/Source/WebCore
Implement Multiple Render Targets as WebGL 1 extension.
https://bugs.webkit.org/show_bug.cgi?id=133634.
<rdar://problem/15949588>
Reviewed by Brent Fulgham.
Tested by:
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
Enable the implementation now that an underlying driver bug has been resolved.
Do not enable for desktop platforms older that OS X 10.10.
- html/canvas/WebGLDrawBuffers.cpp:
(WebCore::WebGLDrawBuffers::supported):
- 2:10 PM Changeset in webkit [177098] by
-
- 3 edits6 adds in trunk
REGRESSION(r164329): Input fields are not honoring the maxlength attribute
https://bugs.webkit.org/show_bug.cgi?id=139447
Reviewed by Benjamin Poulain.
Source/WebCore:
The bug was caused by String::substring being called with the selection's end offset
in the second argument instead of the selection's length in handleBeforeTextInsertedEvent.
Fixed the bug by passing the right second argument to String::substring.
Test: fast/forms/input-maxlength-inserting-in-middle.html
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
LayoutTests:
Added regression tests.
- fast/forms/input-maxlength-inserting-in-middle-expected.txt: Added.
- fast/forms/input-maxlength-inserting-in-middle.html: Added.
- fast/forms/input-maxlength-paste-clusters-in-middle-expected.txt: Added.
- fast/forms/input-maxlength-paste-clusters-in-middle.html: Added.
- fast/forms/input-maxlength-paste-in-middle-expected.txt: Added.
- fast/forms/input-maxlength-paste-in-middle.html: Added.
- 1:51 PM Changeset in webkit [177097] by
-
- 3 edits3 adds in branches/safari-600.3-branch
Merged r176972. rdar://problems/19196762
- 1:51 PM Changeset in webkit [177096] by
-
- 2 edits in branches/safari-600.3-branch/Source/JavaScriptCore
Merged r175653. rdar://problems/19196762
- 1:51 PM Changeset in webkit [177095] by
-
- 11 edits in branches/safari-600.3-branch/Source/JavaScriptCore
Merged r175593. rdar://problems/19196762
- 1:51 PM Changeset in webkit [177094] by
-
- 2 edits2 adds in branches/safari-600.3-branch
Merged r175312. rdar://problems/19196762
- 1:50 PM Changeset in webkit [177093] by
-
- 3 edits6 adds in branches/safari-600.3-branch
Merged r175243. rdar://problems/19196762
- 1:20 PM Changeset in webkit [177092] by
-
- 2 edits in trunk/Source/WebCore
Add a missing null check.
- page/Page.cpp:
(WebCore::Page::~Page):
- 1:10 PM Changeset in webkit [177091] by
-
- 4 edits in trunk/Source
Please disable the webkitFirstVersionWithInitConstructorSupport check on Apple TV
https://bugs.webkit.org/show_bug.cgi?id=139501
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
NSVersionOfLinkTimeLibrary only works if you link directly against
JavaScriptCore, which is a bit awkward for our Apple TV client to do.
It's easy enough just to disable this check on Apple TV, since it has no
backwards compatibility requirement.
- API/JSWrapperMap.mm:
(supportsInitMethodConstructors):
Source/WTF:
Added a platform definition for APPLETV.
(It's not an OS because it's not mutually exclusive with other OS definitions.)
- wtf/Platform.h:
- 1:00 PM Changeset in webkit [177090] by
-
- 8 edits in trunk/Source/WebKit2
Begin fixing transient local storage handling
https://bugs.webkit.org/show_bug.cgi?id=139503
Reviewed by Sam Weinig.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createTransientLocalStorageMap):
- UIProcess/Storage/StorageManager.h:
Add empty stub implementation of createTransientLocalStorageMap.
- UIProcess/Storage/StorageManager.messages.in:
Add CreateTransientLocalStorageMap message.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::StorageAreaMap):
If we have a local storage namespace with a non-null top-level origin, create a
transient local storage map.
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
Pass a null top-level origin to the StorageNamespaceImpl constructor.
(WebKit::StorageNamespaceImpl::createTransientLocalStorageNamespace):
Create a new StorageNamespaceImpl, passing the top-level origin to the constructor.
(WebKit::StorageNamespaceImpl::createSessionStorageNamespace):
Pass a null top-level origin to the StorageNamespaceImpl constructor.
(WebKit::StorageNamespaceImpl::StorageNamespaceImpl):
Add a top-level origin parameter.
- WebProcess/Storage/StorageNamespaceImpl.h:
(WebKit::StorageNamespaceImpl::topLevelOrigin):
Add top-level origin member and getter.
- WebProcess/Storage/WebStorageNamespaceProvider.cpp:
(WebKit::WebStorageNamespaceProvider::createTransientLocalStorageNamespace):
Call StorageNamespaceImpl::createTransientLocalStorageNamespace.
- 12:46 PM Changeset in webkit [177089] by
-
- 3 edits2 adds in trunk
Crash when creating CSSCalcBinaryOperation
https://bugs.webkit.org/show_bug.cgi?id=134886
rdar://problem/17663561
Reviewed by Chris Dumez.
Source/WebCore:
Test: fast/css/calc-binary-operation-crash.html
- css/CSSCalculationValue.cpp:
(WebCore::determineCategory):
Ensure that both axis are within the addSubtractResult table.
Remove unneeded CalcOther test. The call site guarantees it doesn't happen and the normal cases would handle it anyway.
Also strengthen some asserts.
LayoutTests:
- fast/css/calc-binary-operation-crash-expected.txt: Added.
- fast/css/calc-binary-operation-crash.html: Added.
- 12:43 PM Changeset in webkit [177088] by
-
- 1 edit1 move in trunk
Blur filter performance test doesn't provide results
https://bugs.webkit.org/show_bug.cgi?id=139462
Reviewed by Sam Weinig.
This can't currently work under our performance test
infrastructure. Move it to a manual test to avoid
putting FAILures into the results.
- ManualTests/blur-filter-timing.html: Renamed from PerformanceTests/Interactive/blur-filter-timing.html.
- 12:10 PM Changeset in webkit [177087] by
-
- 8 edits in trunk/Source
Add WebStorageNamespaceProvider::closeLocalStorage
https://bugs.webkit.org/show_bug.cgi?id=139502
Reviewed by Tim Horton.
Source/WebCore:
- page/Page.cpp:
(WebCore::Page::~Page):
Call StorageNamespaceProvider::removePage.
- storage/StorageNamespaceProvider.h:
(WebCore::StorageNamespaceProvider::optionalLocalStorageNamespace):
Helper function that returns the local storage namespace if one exists.
Source/WebKit:
- Storage/WebStorageNamespaceProvider.cpp:
(storageNamespaceProviders):
(WebStorageNamespaceProvider::WebStorageNamespaceProvider):
(WebStorageNamespaceProvider::~WebStorageNamespaceProvider):
Keep track of all live storage namespace providers.
(WebStorageNamespaceProvider::closeLocalStorage):
Loop through all storage namespace providers and call close() on their local storage namespaces.
- Storage/WebStorageNamespaceProvider.h:
Source/WebKit/mac:
- WebView/WebView.mm:
(+[WebView _applicationWillTerminate]):
Call WebStorageNamespaceProvider::closeLocalStorage.
- 11:57 AM Changeset in webkit [177086] by
-
- 4 edits4 adds in trunk
AX: [ATK] MathML tokens with text fail to expose their text content via AtkText
https://bugs.webkit.org/show_bug.cgi?id=139454
Reviewed by Chris Fleizach.
Source/WebCore:
Expose the text content of the element for non-anonymous RenderMathMLOperators.
This is needed because for ATK we expose the rendered element itself; not the
descendant text renderers. Also include MathML tokens as objects which should
implement AtkText.
Test: accessibility/math-text.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(getInterfaceMaskFromObject):
LayoutTests:
- accessibility/math-text.html: Added.
- platform/efl/accessibility/math-text-expected.txt: Added.
- platform/gtk/accessibility/math-text-expected.txt: Added.
- platform/mac/accessibility/math-text-expected.txt: Added.
- 11:43 AM Changeset in webkit [177085] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Use appsrcs instead of unconnected queues
https://bugs.webkit.org/show_bug.cgi?id=139490
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-10
Reviewed by Philippe Normand.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_init):
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcFinalize):
(webKitWebAudioSrcSetProperty):
(webKitWebAudioSrcLoop):
(webKitWebAudioSrcChangeState):
Previously we directly chained buffers into unconnected queues,
which confused some code inside GStreamer and caused some harmless
warnings. Now we use appsrcs instead, which also allows us to remove
quite some code.
- 11:41 AM Changeset in webkit [177084] by
-
- 4 edits in trunk/Source/WebKit2
Implement WebStorageNamespaceProvider::createLocalStorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=139498
Reviewed by Beth Dakin.
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
Add a new overload that takes an identifier + quota. Have the old overload call the new one.
- WebProcess/Storage/StorageNamespaceImpl.h:
Add new member.
- WebProcess/Storage/WebStorageNamespaceProvider.cpp:
(WebKit::WebStorageNamespaceProvider::createLocalStorageNamespace):
Call StorageNamespaceImpl::createLocalStorageNamespace.
- 11:36 AM Changeset in webkit [177083] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
Fixes operationPutByIds such that they check that the put didn't
change the structure of the object who's property access is being
cached.
https://bugs.webkit.org/show_bug.cgi?id=139196
Reviewed by Filip Pizlo.
- jit/JITOperations.cpp:
(JSC::operationGetByIdOptimize): changed get to getPropertySlot
(JSC::operationPutByIdStrictBuildList): saved the structure before the put.
(JSC::operationPutByIdNonStrictBuildList): ditto.
(JSC::operationPutByIdDirectStrictBuildList): ditto.
(JSC::operationPutByIdDirectNonStrictBuildList): ditto.
- jit/Repatch.cpp:
(JSC::tryCachePutByID): fixed structure() to use the existant vm.
(JSC::tryBuildPutByIdList): Added a check that the old structure's id
is the same as the new.
(JSC::buildPutByIdList): Added an argument
- jit/Repatch.h:
(JSC::buildPutByIdList): Added an argument
- tests/stress/put-by-id-strict-build-list-order.js: Added.
- 11:25 AM Changeset in webkit [177082] by
-
- 2 edits2 adds in trunk/Source/WebKit2
Add a stubbed out WebStorageNamespaceProvider class to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=139497
Reviewed by Beth Dakin.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Storage/WebStorageNamespaceProvider.cpp: Added.
(WebKit::storageNamespaceProviders):
(WebKit::WebStorageNamespaceProvider::getOrCreate):
(WebKit::WebStorageNamespaceProvider::WebStorageNamespaceProvider):
(WebKit::WebStorageNamespaceProvider::~WebStorageNamespaceProvider):
(WebKit::WebStorageNamespaceProvider::createLocalStorageNamespace):
(WebKit::WebStorageNamespaceProvider::createTransientLocalStorageNamespace):
- WebProcess/Storage/WebStorageNamespaceProvider.h: Added.
- 11:25 AM Changeset in webkit [177081] by
-
- 8 edits in trunk/Source
Fix iOS builders for 8.0
https://bugs.webkit.org/show_bug.cgi?id=139495
Reviewed by Eric Carlson.
Source/WebCore:
- WebCore.exp.in:
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController enterFullscreen:mode:]):
(-[WebVideoFullscreenController requestHideAndExitFullscreen]):
(-[WebVideoFullscreenController enterFullscreen:]): Deleted.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _mayAutomaticallyShowVideoOptimized]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
- 10:54 AM Changeset in webkit [177080] by
-
- 5 edits in trunk/Source/WebCore
[Curl] Cache entry is sometimes deleted when request receives a not modified response.
https://bugs.webkit.org/show_bug.cgi?id=139339
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-10
Reviewed by Alex Christensen.
Sometimes it happens that a request receives a not modified response,
but the cache entry has already been deleted by another request.
This can be avoided by locking a cache entry while there are pending
requests for the cache entry's url.
- platform/network/curl/CurlCacheEntry.h:
(WebCore::CurlCacheEntry::addClient):
(WebCore::CurlCacheEntry::removeClient):
(WebCore::CurlCacheEntry::hasClients):
- platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::didReceiveResponse):
(WebCore::CurlCacheManager::didFail):
(WebCore::CurlCacheManager::addCacheEntryClient):
(WebCore::CurlCacheManager::removeCacheEntryClient):
- platform/network/curl/CurlCacheManager.h:
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::isHttpNotModified):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::initializeHandle):
- 10:38 AM Changeset in webkit [177079] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Use a buffer pool for allocations in the AudioDestination
https://bugs.webkit.org/show_bug.cgi?id=139487
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-10
Reviewed by Philippe Normand.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop):
(webKitWebAudioSrcChangeState):
Use a buffer pool for the allocations instead of allocating a
new small buffer for every 128 samples we produce.
- 10:37 AM Changeset in webkit [177078] by
-
- 8 edits in trunk
[GTK] Add support for text-decoration-skip
https://bugs.webkit.org/show_bug.cgi?id=131540
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
No new tests. This is covered by existing layout tests.
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::GlyphIterationState): Added this class, a modified version of the Mac
port's implementation.
(WebCore::Font::dashesForIntersectionsWithRect): Ditto.
- platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::Font::getGlyphsAndAdvancesForComplexText): Added an implementation for
HarfBuzz that just fills out the GlyphBuffer, but does not render it.
(WebCore::Font::drawComplexText): Use the new getGlyphsAndAdvancesForComplexText
in a similar way to the Mac port.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun): We need to pass the current
character index to GlyphBuffer:add since it's used by dashesForIntersectionsWithRect
and otherwise it will be uninitialized when we try to access it.
Source/WTF:
- wtf/Platform.h: Enable text decoration skip by default.
LayoutTests:
- platform/gtk/TestExpectations: Unskip a test relying on text-decoration-skip
and skip a new test that has a newly exposed, but unrelated issue.
- 10:19 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 10:15 AM Changeset in webkit [177077] by
-
- 21 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Report and mark new failures.
- platform/gtk/accessibility/media-emits-object-replacement-expected.txt: Rebaseline after r177015.
- platform/gtk/fast/box-sizing/box-sizing-expected.txt: Rebaseline after 176978.
- platform/gtk/fast/forms/basic-selects-expected.txt: Rebaseline after r176978.
- platform/gtk/fast/forms/search-vertical-alignment-expected.txt: Rebaseline after 176978.
- platform/gtk/fast/forms/searchfield-heights-expected.txt: Rebaseline after r176978.
- platform/gtk/fast/forms/textfield-overflow-by-value-update-expected.txt: Rebaseline after r176978.
- platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt: Rebaseline after r177015.
- platform/gtk/fast/layers/video-layer-expected.txt: Rebaseline after r177015.
- platform/gtk/fast/multicol/client-rects-expected.txt: Rebaseline after 176978.
- platform/gtk/fast/multicol/client-rects-spanners-complex-expected.txt: Rebaseline after 176978.
- platform/gtk/fast/multicol/client-rects-spanners-expected.txt: Rebaseline after 176978.
- platform/gtk/fast/multicol/layers-split-across-columns-expected.txt: Rebaseline after 176978.
- platform/gtk/fast/multicol/newmulticol/client-rects-expected.txt: Rebaseline after 176978.
- platform/gtk/http/tests/media/hls/video-controls-live-stream-expected.txt: Rebaseline after r177015.
- platform/gtk/media/audio-repaint-expected.txt: Rebaseline after r177015.
- platform/gtk/media/controls-without-preload-expected.txt: Rebaseline after r177015.
- platform/gtk/media/media-controls-clone-expected.txt: Rebaseline after r177015.
- platform/gtk/media/video-empty-source-expected.txt: Rebaseline after r177015
- platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt: Rebaseline after r175847.
- 10:08 AM Changeset in webkit [177076] by
-
- 2 edits in trunk/LayoutTests
[WK1] new http/tests/notifications/legacy/notification-request-permission-then-navigate.html test is crashing
https://bugs.webkit.org/show_bug.cgi?id=139494
Reviewed by Alexey Proskuryakov.
Call window.open() after the page has been loaded because our test infrastructure
asserts that testRunner.waitUntilDone() must have been called *before* window.open()
is called. Since testRunner.waitUntilDone() is called is js-test-post.js, calling
window.open() after page load fixes the issue.
- http/tests/notifications/legacy/notification-request-permission-then-navigate.html:
- 9:42 AM Changeset in webkit [177075] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Enable depth 32 for the RedirectedXCompositeWindow
https://bugs.webkit.org/show_bug.cgi?id=139028
On gtk/X11, the layout compositing is done in the web process.
If one needs to handle alpha with the rest of the application
then it is not enough to make to browser's window as RGBA.
The shared redirected window needs to be RGBA as well.
(The shared X composite window between UIProcess and WebProcess).
This allows an end-to-end RGBA solution when the application
wants to interact with the alpha channel at compositing time.
For example for transparent Web UI.
Patch by Julien Isorce <j.isorce@samsung.com> on 2014-12-10
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize):
(webkitWebViewBaseConstructed):
(webkitWebViewRenderAcceleratedCompositingResults):
(webkitWebViewBaseUpdatePreferences):
(webkitWebViewBaseCreateWebPage):
- UIProcess/gtk/RedirectedXCompositeWindow.cpp:
(WebKit::RedirectedXCompositeWindow::create):
(WebKit::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
- UIProcess/gtk/RedirectedXCompositeWindow.h:
- 9:42 AM Changeset in webkit [177074] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r177048) 11 failures on layout tests fast/selectors.
<https://webkit.org/b/139483>
Unreviewed fix for bots.
When rolling out the broken change, I accidentally also rolled out
a bug fix that Benjamin had made to sibling invalidation.
Restore his implementation of nodeOrItsAncestorNeedsStyleRecalc().
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::nodeOrItsAncestorNeedsStyleRecalc):
(WebCore::updateStyleIfNeededForNode):
(WebCore::ComputedStyleExtractor::propertyValue):
- 9:36 AM Changeset in webkit [177073] by
-
- 18 edits9 adds in trunk
[GTK][WK2] Add HTML5 Notifications support
https://bugs.webkit.org/show_bug.cgi?id=61140
.:
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2014-12-09
Reviewed by Carlos Garcia Campos.
- Source/cmake/FindLibNotify.cmake: Added.
- Source/cmake/OptionsGTK.cmake: add option to enable notifications, look for
libnotify and use it for a default implementation when found.
Source/WebKit2:
Patch by Claudio Saavedra <Claudio Saavedra> and Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2014-12-09
Reviewed by Carlos Garcia Campos.
- PlatformGTK.cmake: add new files to the build.
- UIProcess/API/gtk/WebKitForwardDeclarations.h:
- UIProcess/API/gtk/WebKitNotification.cpp: Added. New GObject used to expose information about
the notification to the API.
(webkitNotificationGetProperty):
(webkit_notification_class_init):
(webkitNotificationCreate):
(webkit_notification_get_id):
(webkit_notification_get_title):
(webkit_notification_get_body):
- UIProcess/API/gtk/WebKitNotification.h: Added.
- UIProcess/API/gtk/WebKitNotificationPermissionRequest.cpp: Added. Permission request object
for notifications.
(webkitNotificationPermissionRequestAllow):
(webkitNotificationPermissionRequestDeny):
(webkit_permission_request_interface_init):
(webkitNotificationPermissionRequestDispose):
(webkit_notification_permission_request_class_init):
(webkitNotificationPermissionRequestCreate):
- UIProcess/API/gtk/WebKitNotificationPermissionRequest.h: Added.
- UIProcess/API/gtk/WebKitNotificationPermissionRequestPrivate.h: Added.
- UIProcess/API/gtk/WebKitNotificationPrivate.h: Added.
- UIProcess/API/gtk/WebKitNotificationProvider.cpp: Added. Notification provider that emits signals.
The C API allows overriding the notification providers and managers for customizing the handling of
notifications. We decided to go for a single manager and a single provider which provide more idiomatic
GObject API - signals.
(toNotificationProvider):
(showCallback):
(cancelCallback):
(WebKitNotificationProvider::~WebKitNotificationProvider):
(WebKitNotificationProvider::create):
(WebKitNotificationProvider::WebKitNotificationProvider):
(WebKitNotificationProvider::show):
(WebKitNotificationProvider::cancel):
- UIProcess/API/gtk/WebKitNotificationProvider.h: Added.
- UIProcess/API/gtk/WebKitUIClient.cpp: implemented decidePolicyForNotificationPermissionRequest.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed): initialize the notification provider.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewShowNotification): default implementation for showing the notification, currently
using GNotification, about to be ported to libnotify.
(webkit_web_view_class_init): set the default implementation for the show-notification signal.
(webkitWebViewEmitCloseNotification): emit the close-notification signal.
(webkitWebViewEmitShowNotification): emit the show-notification signal.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: list new objects and methods.
- UIProcess/API/gtk/webkit2.h: include new headers.
Tools:
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2014-12-09
Reviewed by Carlos Garcia Campos.
- Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewNotification):
(beforeAll):
- MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
(permissionRequestDialogCallback):
(webViewDecidePermissionRequest):
(geolocationRequestDialogCallback): Deleted.
LayoutTests:
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2014-12-09
Reviewed by Carlos Garcia Campos.
- platform/gtk/TestExpectations: unskip the HTTP tests for new-style notifications.
- 9:12 AM Changeset in webkit [177072] by
-
- 4 edits in branches/safari-600.1.4.13-branch/Source
Merged r176803. rdar://problem/19131878
- 9:10 AM Changeset in webkit [177071] by
-
- 2 edits in branches/safari-600.1.4.13-branch/Source/WebCore
Merged r175974. rdar://problem/19132083
- 9:08 AM Changeset in webkit [177070] by
-
- 4 edits in branches/safari-600.1.4.13-branch/Source/WebCore
Merged r175347. rdar://problem/19132037
- 9:06 AM Changeset in webkit [177069] by
-
- 4 edits2 copies in branches/safari-600.1.4.13-branch
Merged r175345. rdar://problem/19132020
- 9:05 AM Changeset in webkit [177068] by
-
- 5 edits in branches/safari-600.1.4.13-branch
Merged r175197. rdar://problem/19132052
- 9:02 AM Changeset in webkit [177067] by
-
- 2 edits in branches/safari-600.1.4.13-branch/Source/WebCore
Merged r176735. rdar://problem/19132009
- 9:01 AM Changeset in webkit [177066] by
-
- 3 edits2 copies in branches/safari-600.1.4.13-branch
Merged r176295. rdar://problem/19132009
- 8:59 AM Changeset in webkit [177065] by
-
- 3 edits9 copies in branches/safari-600.1.4.13-branch
Merged r175074. rdar://problem/19131907
- 8:57 AM Changeset in webkit [177064] by
-
- 4 edits2 copies in branches/safari-600.1.4.13-branch
Merged r174946. rdar://problem/19131919
- 8:54 AM Changeset in webkit [177063] by
-
- 3 edits2 copies in branches/safari-600.1.4.13-branch
Merged r174922. rdar://problem/19131993
- 8:53 AM Changeset in webkit [177062] by
-
- 3 edits2 copies in branches/safari-600.1.4.13-branch
Merged r173845. rdar://problem/19131891
- 8:51 AM Changeset in webkit [177061] by
-
- 3 edits2 copies in branches/safari-600.1.4.13-branch
Merged r173843. rdar://problem/19131981
- 8:48 AM Changeset in webkit [177060] by
-
- 3 edits2 copies in branches/safari-600.1.4.13-branch
Merged r173738. rdar://problem/19131970
- 8:46 AM Changeset in webkit [177059] by
-
- 3 edits in branches/safari-600.1.4.13-branch
Merged r173424. rdar://problem/19131999
- 8:00 AM Changeset in webkit [177058] by
-
- 5 edits2 adds in trunk/Source/WebCore
[GStreamer] AudioSourceProvider support in the MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=78883
Reviewed by Gustavo Noronha Silva.
GStreamer-based audio source provider for the GTK and EFL
ports. This new component gathers decoded raw audio data from the
MediaPlayer and pipes it to an AudioBus when required by the
User Agent.
- PlatformEfl.cmake: New files in the build.
- PlatformGTK.cmake: Ditto.
- platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp: Added.
(WebCore::onAppsinkNewBufferCallback): Function called when a new
buffer can be pulled from appsink.
(WebCore::onGStreamerDeinterleavePadAddedCallback): Function
called when a new source pad has been added to deinterleave.
(WebCore::onGStreamerDeinterleaveReadyCallback): Function called
when the deinterleave element completed the configuration of all
its source pads.
(WebCore::copyGstreamerBuffersToAudioChannel): Called for each
channel of the AudioBus that needs data as input.
(WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer):
Create an audio bin that by default routes buffers only to
autoaudiosink. A new route is added if the provider has a client.
(WebCore::AudioSourceProviderGStreamer::~AudioSourceProviderGStreamer):
Clean buffer adapters and audio bin.
(WebCore::AudioSourceProviderGStreamer::configureAudioBin):
(WebCore::AudioSourceProviderGStreamer::provideInput): Transfer
data from the buffer adapters to the bus channels.
(WebCore::AudioSourceProviderGStreamer::handleAudioBuffer): Pull a
buffer from appsink and queue it to the buffer adapter.
(WebCore::AudioSourceProviderGStreamer::setClient): Complete the
construction of the audio bin by adding a new chain to the tee
element. This new chain will deinterleave the buffer stream to
planar audio channels and route them to an appsink per channel for
data extraction.
(WebCore::AudioSourceProviderGStreamer::handleNewDeinterleavePad):
A new appsink after a new source pad has been added to deinterleave.
(WebCore::AudioSourceProviderGStreamer::deinterleavePadsConfigured):
Configure the client Node format (number of channels and sample
rate) once the provider knows how many audio channels are managed
by the pipeline.
(WebCore::cleanUpElementsAfterDeinterleaveSourcePadCallback):
(WebCore::AudioSourceProviderGStreamer::cleanUpElementsAfterDeinterleaveSourcePad):
Remove the elements after the given deinterleave source pad.
(WebCore::AudioSourceProviderGStreamer::reset): Cleanup the
deinterleave source pads. This is especially needed before the
whole pipeline goes to NULL and later on prerolls again.
- platform/audio/gstreamer/AudioSourceProviderGStreamer.h: Added.
(WebCore::AudioSourceProviderGStreamer::create): Use this to
create the provider and get an OwnPtr of it.
(WebCore::AudioSourceProviderGStreamer::client): Provider client getter.
(WebCore::AudioSourceProviderGStreamer::getAudioBin): Audio bin
getter, used by the media player to configure its
playbin::audio-sink property.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Provider life cycle management and reset the audio provider before
going to NULL.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::handlePluginInstallerResult): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::cancelLoad): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::didEnd): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink): Configure
the audio source provider if needed.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivateGStreamer::audioSourceProvider):
Provider getter, used by MediaPlayer and MediaElement.
- 5:00 AM Changeset in webkit [177057] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][[WK2] test_ewk2_text_checker is failed
https://bugs.webkit.org/show_bug.cgi?id=132982
Reviewed by Gyuyoung Kim.
Insert misspelled word to the input field using execCommand instead of
input.value attribute change which stops spell check, tracked by
https://bugs.webkit.org/show_bug.cgi?id=139473.
Since text checker API tests do not verify spellchecker itself (it's being
tested by LayoutTests/editing/spelling) but rather opportunity for overriding
its functionality this patch unskips those tests in order to API coverage.
- PlatformEfl.cmake:
Unskip test_ewk2_text_checker
- UIProcess/API/efl/tests/resources/spelling_test.html:
Use document.execCommand("InsertText", false, "aa ") instead of
input.value = "aa " to trigger spellchecker.
- 4:51 AM Changeset in webkit [177056] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r177038): [SOUP] [GTK] Debug build broken
https://bugs.webkit.org/show_bug.cgi?id=139475
Reviewed by Martin Robinson.
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::clearCacheForAllOrigins): Call clearDiskCache().
(WebKit::NetworkProcess::clearDiskCache): Implement this for SOUP.
SoupCache don't seems to have API for clearing a part of the cache,
so add a FIXME note regarding that.
- 4:40 AM Changeset in webkit [177055] by
-
- 2 edits in trunk/Source/JavaScriptCore
URTBF after r177030.
Fix linking failure occured on ARM buildbots:
lib/libjavascriptcore_efl.so.1.11.0: undefined reference to `JSC::Structure::get(JSC::VM&, JSC::PropertyName, unsigned int&)'
- runtime/NullGetterFunction.cpp:
Dec 9, 2014:
- 10:44 PM Changeset in webkit [177054] by
-
- 3 edits in trunk/LayoutTests
Unskip more multipart tests
https://bugs.webkit.org/show_bug.cgi?id=139431
Reviewed by Darin Adler.
- http/tests/multipart/load-last-non-html-frame.php:
- platform/mac/TestExpectations:
- 9:14 PM Changeset in webkit [177053] by
-
- 3 edits in trunk/LayoutTests
[iOS] Unskip some tests in LayoutTests/{fonts, html5lib, ietestcenter, imported, indieui, inspector, jquery}
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 8:01 PM Changeset in webkit [177052] by
-
- 20 edits44 copies135 moves96 adds116 deletes in trunk/LayoutTests
[iOS] Update expected results for LayoutTests/{compositing, css1, css2.1, css3, cssom}
https://bugs.webkit.org/show_bug.cgi?id=139467
Rubber-stamped by Zalan Bujtas.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator-wk2/compositing/absolute-inside-out-of-view-fixed-expected.txt: Copied from LayoutTests/platform/ios-simulator/compositing/absolute-inside-out-of-view-fixed-expected.txt.
- platform/ios-simulator-wk2/compositing/backing/backface-visibility-flip-expected.txt: Copied from LayoutTests/platform/ios-simulator/compositing/backing/backface-visibility-flip-expected.txt.
[...]
- 6:19 PM Changeset in webkit [177051] by
-
- 1 edit2 adds in trunk/PerformanceTests
Add performance test related to font fallback
https://bugs.webkit.org/show_bug.cgi?id=139332
Reviewed by Simon Fraser.
- Layout/font-fallback.html: Added.
- Layout/resources/font-fallback.html: Added.
- 5:02 PM Changeset in webkit [177050] by
-
- 5 edits8 adds in trunk
Scrolling to anchor tags does nothing in vertical-rl writing mode
https://bugs.webkit.org/show_bug.cgi?id=137838
Reviewed by David Hyatt.
Source/WebCore:
Scroll to a particular tag, and make sure the viewport is rendered as expected.
Tests: fast/events/scroll-to-anchor-vertical-lr-writing-mode.html
fast/events/scroll-to-anchor-vertical-writing-mode-contained-2.html
fast/events/scroll-to-anchor-vertical-writing-mode-contained.html
fast/events/scroll-to-anchor-vertical-writing-mode.html
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
- rendering/ScrollBehavior.cpp:
- rendering/ScrollBehavior.h:
LayoutTests:
When we specify the behavior regarding scrolling to anchor tags, we previously had
only described behavior regarding horizontal text. When we have vertical text, we
need to switch the horizontal and vertical scrolling policies.
- fast/events/scroll-to-anchor-vertical-lr-writing-mode-expected.html: Added.
- fast/events/scroll-to-anchor-vertical-lr-writing-mode.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode-contained-2-expected.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode-contained-2.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode-contained-expected.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode-contained.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode-expected.html: Added.
- fast/events/scroll-to-anchor-vertical-writing-mode.html: Added.
- 4:57 PM Changeset in webkit [177049] by
-
- 3 edits in trunk
REGRESSION(r155906): Page content disappears on Tuaw article after loading
https://bugs.webkit.org/show_bug.cgi?id=138100
Reviewed by Simon Fraser.
.:
DRT causes an extra paint which makes it impossible to test this with
an automated test.
- ManualTests/float-layer-not-painting.html: Added.
Source/WebCore:
Test: ManualTests/float-layer-not-painting.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::insertFloatingObject): If a layout happens,
it can change whether the float's renderer has a self painting layer.
So in that case, we need to update the flag on the FloatingObject
instance for that float.
- 4:47 PM Changeset in webkit [177048] by
-
- 6 edits in trunk/Source/WebCore
Roll out r165076.
<rdar://problem/18490587>
This change broke selection when editing Confluence wiki pages.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::nodeOrItsAncestorNeedsStyleRecalc):
(WebCore::ComputedStyleExtractor::propertyValue):
- dom/Document.cpp:
(WebCore::nodeOrItsAncestorNeedsStyleRecalc): Deleted.
(WebCore::Document::updateStyleIfNeededForNode): Deleted.
- dom/Document.h:
- editing/htmlediting.cpp:
(WebCore::isEditablePosition):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::forwardEvent):
- 4:36 PM Changeset in webkit [177047] by
-
- 3 edits2 copies in branches/safari-600.1.4.13-branch
Merged r173061. rdar://problem/19131928
- 4:34 PM Changeset in webkit [177046] by
-
- 3 edits2 copies in branches/safari-600.1.4.13-branch
Merged r173046. rdar://problem/19132074
- 4:32 PM Changeset in webkit [177045] by
-
- 3 edits6 copies in branches/safari-600.1.4.13-branch
Merged r171849. rdar://problem/19131955
- 4:22 PM Changeset in webkit [177044] by
-
- 7 edits in trunk/Source/WebKit
Unreviewed, rolling out r177037.
https://bugs.webkit.org/show_bug.cgi?id=139464
broke ~50 API tests (Requested by thorton on #webkit).
Reverted changeset:
"Use the new storage namespace provider in WebKit1"
https://bugs.webkit.org/show_bug.cgi?id=139425
http://trac.webkit.org/changeset/177037
- 4:12 PM Changeset in webkit [177043] by
-
- 2 edits in trunk/Source/WebKit2
URTBF after r177032.
- CMakeLists.txt:
- 3:26 PM Changeset in webkit [177042] by
-
- 1 edit1 move in trunk/LayoutTests
Move mixed border color test image result to mac folder,
should address yosemite case.
- 3:05 PM Changeset in webkit [177041] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build after r177035.
Unreviewed.
I accidentally added my line to WebCore.exp.in inside an
- WebCore.exp.in:
- 2:39 PM Changeset in webkit [177040] by
-
- 5 edits in trunk/Source/WebKit2
Kotoeri sometimes doesn't correctly process the first chanaracter in a text field in Safari 7.1 or 6.2
https://bugs.webkit.org/show_bug.cgi?id=139459
rdar://problem/19017432
rdar://problem/19036869
Reviewed by Enrica Casucci.
When inputContext changes, notify the application. We already did this when the context
changed due to plug-ins, and this used to sort of make it work on on yahoo.co.jp,
which has plug-ins. But that was quite unreliable, as evidenced by the reproducible
cases where we didn't use an input method for the first keypress.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::editorStateChanged):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::notifyApplicationAboutInputContextChange):
- 1:54 PM Changeset in webkit [177039] by
-
- 9 edits in trunk/Source
Enable automatic optimized fullscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=139437
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-12-09
Source/WebCore:
Reviewed by Eric Carlson.
Anticipate transition to optimized video fullscreen mode when entering background.
- WebCore.exp.in:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::overrideBackgroundPlaybackRestriction): Add logic for automatic transition detection.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h:
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::mayAutomaticallyShowVideoOptimized): Add logic for automatic transition detection.
Source/WebKit2:
Reviewed by Simon Fraser.
Anticipate the automatic transition to optimized video fullscreen mode when deciding if the page is visible.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _isShowingVideoOptimized]): Renamed. Test precondition.
(-[WKWebView _mayAutomaticallyShowVideoOptimized]): Added.
(-[WKWebView _isPlayingFullscreenOptimizedVideo]): Deleted.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isViewVisible): Test for optimized modes even when not in a window.
- 1:53 PM Changeset in webkit [177038] by
-
- 8 edits in trunk/Source/WebKit2
Add support for clearing the disk cache
https://bugs.webkit.org/show_bug.cgi?id=139458
Reviewed by Antti Koivisto.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteWebsiteData):
If we're asked to clear the disk cache, do so. Clearing the cache is asynchronous,
so we make sure not to call the completion handler right away in that case.
- NetworkProcess/NetworkProcess.h:
Add clearDiskCache member function.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::clearDiskCache):
Clear the disk cache, then call the completion handler.
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::clearCacheForAllOrigins):
Call the new clearDiskCache function.
- Shared/WebsiteData/WebsiteDataTypes.h:
Add WebsiteDataTypeDiskCache.
- UIProcess/API/Cocoa/_WKWebsiteDataStore.h:
- UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
(toWebsiteDataTypes):
Handle WKWebsiteDataTypeDiskCache.
- 1:49 PM Changeset in webkit [177037] by
-
- 6 edits in trunk/Source/WebKit
Use the new storage namespace provider in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=139425
Reviewed by Tim Horton.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Set the storage namespace provider from the web page group.
Source/WebKit/win:
- WebView.cpp:
(localStorageDatabasePath):
Helper from getting the local storage database path given a WebPreferences instance.
(WebView::initWithFrame):
Create a storage namespace provider.
- 1:45 PM Changeset in webkit [177036] by
-
- 2 edits in trunk/Tools
Fix webkitpy test expectation
Not sure what I messed up, but TOTAL_SKIPS was not right.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-09
- Scripts/webkitpy/port/test.py:
- 1:03 PM Changeset in webkit [177035] by
-
- 28 edits in trunk
Delete Node::boundingBox()
https://bugs.webkit.org/show_bug.cgi?id=139333
Source/WebCore:
Conceptually, boundingBox() should be on RenderInline. In addition,
Node::boundingBox() is completely broken for inline elements: it
makes a rect from the top left of the first inline child to the
bottom right of the last inline child, disregarding the intermediate
inline children. This breaks with vertical text and with line
breaks.
What makes this problem worse is that some functions actually rely
on this bad behavior. These functions are functions that use the
Node's so-called "bounding box" to scroll to an anchor tag.
This patch goes through all the call sites of Node::boundingBox(),
and segregates them into calls that expect the true bounding box
and calls that need this false bounding box. This patch then moves
this false bounding box into RenderElement, using the name
anchorRect(). Callers what want the correct bounding box have been
updated to use RenderElement::absoluteBoundingBoxRect().
Reviewed by Zalan Bujtas.
No new tests because there should be no behavior change.
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect): Use
RenderObject::absoluteBoundingBoxRect()
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner): Deleted.
(WebCore::ContainerNode::getLowerRightCorner): Deleted.
(WebCore::ContainerNode::boundingBox): Deleted.
- dom/ContainerNode.h:
- dom/Element.cpp:
(WebCore::Element::scrollIntoView): Use RenderElement::anchorRect().
(WebCore::Element::scrollIntoViewIfNeeded): Ditto.
(WebCore::Element::updateFocusAppearance): Ditto.
- dom/Node.cpp:
(WebCore::Node::boundingBox): Deleted.
- dom/Node.h:
(WebCore::Node::pixelSnappedBoundingBox): Deleted.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::elementRectRelativeToRootView): Use
RenderObject::absoluteBoundingBoxRect()
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters): Ditto.
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree): Ditto.
- page/FrameView.cpp:
(WebCore::FrameView::scrollElementToRect): Use
RenderElement::anchorRect().
(WebCore::FrameView::scrollToAnchor): Ditto.
- page/SpatialNavigation.cpp:
(WebCore::nodeRectInAbsoluteCoordinates): Use
RenderObject::absoluteBoundingBoxRect()
- rendering/RenderElement.cpp:
(WebCore::RenderElement::getUpperLeftCorner): Moved from ContainerNode.
(WebCore::RenderElement::getLowerRightCorner): Moved from
ContainerNode.
(WebCore::RenderElement::anchorRect): Moved from ContainerNode.
- rendering/RenderObject.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::topOfFirstText): Helper for
RenderElement::anchorRect()
- rendering/RenderText.h:
Source/WebKit/mac:
Reviewed by Zalan Bujtas.
- WebView/WebActionMenuController.mm:
(elementBoundingBoxInWindowCoordinatesFromNode): Use
RenderObject::absoluteBoundingBoxRect().
Source/WebKit2:
Reviewed by Zalan Bujtas.
- Shared/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::Data::elementBoundingBoxInWindowCoordinates):
Use RenderObject::absoluteBoundingBoxRect().
- WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp:
(WebKit::WebPage::findZoomableAreaForPoint): Use
RenderObject::absoluteBoundingBoxRect().
- 12:50 PM Changeset in webkit [177034] by
-
- 9 edits in trunk/Tools
Remove virtual test support from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=139427
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-09
Reviewed by Alexey Proskuryakov.
It seems that the only concrete client of virtual tests is the unit tests :D
This patch tries to clean as much useless code as possible.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_tolerance):
(RunTest.test_virtual): Deleted.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_test_trace):
- Scripts/webkitpy/port/base.py:
(Port.expected_filename):
(Port.tests):
(Port.test_isfile):
(Port.test_isdir):
(Port.sample_process):
(Port.find_system_pid):
(Port.test_expectations_file_position):
(Port.virtual_test_suites): Deleted.
(Port): Deleted.
(Port.populated_virtual_test_suites): Deleted.
(Port._virtual_tests): Deleted.
(Port.lookup_virtual_test_base): Deleted.
(Port.lookup_virtual_test_args): Deleted.
(VirtualTestSuite): Deleted.
(VirtualTestSuite.init): Deleted.
(VirtualTestSuite.repr): Deleted.
- Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_test_exists):
(PortTest.test_test_isfile):
(PortTest.test_test_isdir):
(PortTest.test_tests):
- Scripts/webkitpy/port/driver.py:
(DriverProxy.run_test): Deleted.
- Scripts/webkitpy/port/test.py:
(TestPort._skipped_tests_for_unsupported_features):
(TestPort.all_baseline_variants):
(TestPort.virtual_test_suites): Deleted.
- Scripts/webkitpy/tool/commands/queries.py:
(PrintBaselines.init):
(PrintBaselines.execute):
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintBaselinesTest.test_basic):
(PrintBaselinesTest.test_multiple):
(PrintBaselinesTest.test_csv):
- 12:31 PM Changeset in webkit [177033] by
-
- 3 edits5 adds in trunk
[WK2] Crash when answering notification permission request after navigating
https://bugs.webkit.org/show_bug.cgi?id=139429
<rdar://problem/18921122>
Reviewed by Andreas Kling.
Source/WebKit2:
When requesting a notification permission, navigating away and then
answering the permission, WebKit2 would crash. This is because upon
navigating, the request is cancelled and removed from the HashMaps
in NotificationPermissionRequestManager. When
didReceiveNotificationPermissionDecision() is later called, it would
look for the request identifier in m_idToOriginMap HashMap. As the
request was cancelled, HashMap::take() call would return null for
the SecurityOrigin*. This security origin pointer is then removed
from m_originToIDMap, but the code was failing to do a null check
first. Calling HashMap::remove(nullptr) would then crash.
This patch adds the missing null check and a layout test to cover
this case.
Test: http/tests/notifications/legacy/notification-request-permission-then-navigate.html
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):
LayoutTests:
Add layout test to cover the case where the notification permission is
requesting before navigating to a new URL and answered after the page
is navigated away.
- http/tests/notifications/legacy/notification-request-permission-then-navigate-expected.txt: Added.
- http/tests/notifications/legacy/notification-request-permission-then-navigate.html: Added.
- http/tests/notifications/legacy/resources/notify-opener-done.html: Added.
- http/tests/notifications/legacy/resources/request-permission-then-navigate.html: Added.
- 12:29 PM Changeset in webkit [177032] by
-
- 11 edits1 copy1 add in trunk/Source/WebKit2
Implement clearing of cookies
https://bugs.webkit.org/show_bug.cgi?id=139455
Reviewed by Andreas Kling.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteWebsiteData):
Handle deleting cookies by finding the right network storage session and deleting the cookies from it.
Then, send a DidDeleteWebsiteData message back.
- NetworkProcess/NetworkProcess.h:
Add new members.
- NetworkProcess/NetworkProcess.messages.in:
Add new DeleteWebsiteData message.
- Shared/WebsiteData/WebsiteDataTypes.h:
Move the website data types enum to its own file so it can be shared.
- UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
(toWebsiteDataTypes):
Update now that WebsiteDataTypes is its own enum.
(-[_WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:]):
removeDataModifiedSince was renamed to removeData.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::generateCallbackID):
Helper function to create a callback ID.
(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
Assert that we have no pending callbacks.
(WebKit::NetworkProcessProxy::deleteWebsiteData):
Put the completion handler in our map and message the network process.
(WebKit::NetworkProcessProxy::networkProcessCrashedOrFailedToLaunch):
Call all completion handlers.
(WebKit::NetworkProcessProxy::didDeleteWebsiteData):
Grab the completion handler and call it.
- UIProcess/Network/NetworkProcessProxy.h:
Add new members.
- UIProcess/Network/NetworkProcessProxy.messages.in:
Add DidDeleteWebsiteData callback.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::computeNetworkProcessAccessType):
Helper function that computes the type of process access we'd need for the given mask of
website data types.
(WebKit::WebsiteDataStore::removeData):
Gather all the network processes and message them. Use a callback aggregator object to track callbacks
so we'll call the completion handler once all callbacks have been invoked.
- UIProcess/WebsiteData/WebsiteDataStore.h:
Move WebsiteDataTypes to its own file.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 12:06 PM Changeset in webkit [177031] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r173272): When open PDF from Safari in iBooks, title is replaced to “QuickLookPDF-s72DbgAU-1”
https://bugs.webkit.org/show_bug.cgi?id=139453
rdar://problem/19052192
Reviewed by Pratik Solanki.
Pulling the suggested filename from the platform response returned null string on USE(CFNETWORK) code path
if it was the first thing needed from it.
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformSuggestedFilename): Use the lazy accessor.
- 11:52 AM Changeset in webkit [177030] by
-
- 20 edits5 adds in trunk
DFG Tries using an inner object's getter/setter when one hasn't been defined
https://bugs.webkit.org/show_bug.cgi?id=139229
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Added a new NullGetterFunction singleton class to use for getters and setters that
haven't been set to a user defined value. The NullGetterFunction callReturnUndefined()
and createReturnUndefined() methods return undefined. Changed all null checks of the
getter and setter pointers to the newly added isGetterNull() and isSetterNull()
helper methods.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
Added NullGetterFunction.cpp & .h to build files.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
- runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::setDescriptor):
(JSC::PropertyDescriptor::setAccessorDescriptor):
Changed checking getter and setter to null to use new isGetterNull() and isSetterNull()
helpers.
- inspector/JSInjectedScriptHostPrototype.cpp:
(Inspector::JSInjectedScriptHostPrototype::finishCreation):
- inspector/JSJavaScriptCallFramePrototype.cpp:
- jit/JITOperations.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/JSObject.cpp:
(JSC::JSObject::putIndexedDescriptor):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnNonIndexProperty):
- runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
- runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):
Updated calls to GetterSetter::create(), setGetter(), setSetter(), withGetter()
and withSetter() to provide a global object.
- runtime/GetterSetter.cpp:
(JSC::GetterSetter::withGetter):
(JSC::GetterSetter::withSetter):
(JSC::callGetter):
(JSC::callSetter):
- runtime/GetterSetter.h:
(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::create):
(JSC::GetterSetter::isGetterNull):
(JSC::GetterSetter::isSetterNull):
(JSC::GetterSetter::setGetter):
(JSC::GetterSetter::setSetter):
Changed to use NullGetterFunction for unspecified getters / setters.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::createThrowTypeError):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::nullGetterFunction):
(JSC::JSGlobalObject::evalFunction):
Added m_nullGetterFunction singleton. Updated calls to GetterSetter::create(),
setGetter() and setSetter() to provide a global object.
- runtime/NullGetterFunction.cpp: Added.
(JSC::callReturnUndefined):
(JSC::constructReturnUndefined):
(JSC::NullGetterFunction::getCallData):
(JSC::NullGetterFunction::getConstructData):
- runtime/NullGetterFunction.h: Added.
(JSC::NullGetterFunction::create):
(JSC::NullGetterFunction::createStructure):
(JSC::NullGetterFunction::NullGetterFunction):
New singleton class that returns undefined when called.
LayoutTests:
New regression test.
- js/regress-139229-expected.txt: Added.
- js/regress-139229.html: Added.
- js/script-tests/regress-139229.js: Added.
(InnerObjectNoGetter):
(InnerObjectNoGetter.prototype.set enabled):
(InnerObjectNoSetter):
(InnerObjectNoSetter.prototype.get enabled):
(OuterObject):
(OuterObject.prototype.get enabled):
(OuterObject.prototype.set enabled):
- 11:39 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 11:39 AM Changeset in webkit [177029] by
-
- 4 edits in trunk
Re-enable function.arguments
https://bugs.webkit.org/show_bug.cgi?id=139452
Source/JavaScriptCore:
<rdar://problem/18848149>
Reviewed by Sam Weinig.
Disabling function.arguments broke a few websites, and we don't have
time right now to work through the details.
I'm re-enabling function.arguments but leaving in the infrastructure
to re-disable it, so we can try this experiment again in the future.
- runtime/Options.h:
LayoutTests:
Reviewed by Sam Weinig.
- TestExpectations: Re-enable these tests, since WebKit supports this
feature by default now.
- 11:35 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 11:32 AM Changeset in webkit [177028] by
-
- 10 edits2 deletes in trunk/Tools
Blink Merge: Remove 'http_lock' code from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=136722
Reviewed by Alexey Proskuryakov.
Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.init):
(LayoutTestRunner.run_tests):
(LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
(LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(FakePrinter.flush):
(LayoutTestRunnerTests._runner):
(LayoutTestRunnerTests._run_tests):
(LayoutTestRunnerTests.test_servers_started):
(LockCheckingRunner): Deleted.
(LockCheckingRunner.init): Deleted.
(LockCheckingRunner.handle_finished_list): Deleted.
(LayoutTestRunnerTests.test_http_locking): Deleted.
- Scripts/webkitpy/port/base.py:
(Port.init):
(Port.to.http_server_supports_ipv6):
(Port.to.stop_websocket_server):
(Port.to.acquire_http_lock): Deleted.
(Port.to.release_http_lock): Deleted.
- Scripts/webkitpy/port/http_lock.py: Removed.
- Scripts/webkitpy/port/http_lock_unittest.py: Removed.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.show_results_html_file):
(IOSSimulatorPort.acquire_http_lock): Deleted.
(IOSSimulatorPort): Deleted.
(IOSSimulatorPort.release_http_lock): Deleted.
- Scripts/webkitpy/port/mac.py:
(MacPort.show_results_html_file):
(MacPort): Deleted.
(MacPort.acquire_http_lock): Deleted.
(MacPort.release_http_lock): Deleted.
- Scripts/webkitpy/port/mock_drt.py:
(MockDRTPort.start_websocket_server):
(MockDRTPort.stop_websocket_server):
(MockDRTPort.acquire_http_lock): Deleted.
(MockDRTPort.release_http_lock): Deleted.
- Scripts/webkitpy/port/mock_drt_unittest.py:
(MockDRTPortTest.test_uses_apache):
(MockDRTPortTest.integration_test_http_lock): Deleted.
- Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.assert_servers_are_up):
(PortTestCase.integration_test_http_lock): Deleted.
- Scripts/webkitpy/port/test.py:
(TestPort.start_websocket_server):
(TestPort.stop_websocket_server):
(TestPort.acquire_http_lock): Deleted.
(TestPort.release_http_lock): Deleted.
- 11:08 AM Changeset in webkit [177027] by
-
- 19 edits in trunk/Source
Switch from using PLATFORM_NAME to SDK selectors in ANGLE, bmalloc, gtest, JavaScriptCore, WTF
<http://webkit.org/b/139212>
Reviewed by Joseph Pecoraro.
Source/bmalloc:
- Configurations/Base.xcconfig:
- Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS on OS X.
- Configurations/DebugRelease.xcconfig:
- Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS on OS X.
- Only set LLVM_LOCAL_HEADER_PATH and LLVM_SYSTEM_HEADER_PATH on OS X.
- Set JAVASCRIPTCORE_CONTENTS_DIR and JAVASCRIPTCORE_FRAMEWORKS_DIR separately for iOS and OS X.
- Configurations/DebugRelease.xcconfig:
- Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
- Configurations/JSC.xcconfig:
- Only set CODE_SIGN_ENTITLEMENTS for iOS hardware builds.
- Configurations/JavaScriptCore.xcconfig:
- Set OTHER_LDFLAGS separately for iOS and OS X.
- Set SECTORDER_FLAGS separately for iOS and OS X, but only for Production builds.
- Only set EXCLUDED_SOURCE_FILE_NAMES for iOS.
- Configurations/LLVMForJSC.xcconfig:
- Rename LLVM_LIBS_iphoneos to LLVM_LIBS_ios.
- Set LLVM_LIBRARY_PATHS and OTHER_LDFLAGS_LLVM_ENABLE_FTL_JIT separately for iOS hardware and OS X.
- Fix curly braces in LIBRARY_SEARCH_PATHS.
- Merge OTHER_LDFLAGS_BASE into OTHER_LDFLAGS. (Could have been done before this patch.)
- Configurations/ToolExecutable.xcconfig:
- Only set CODE_SIGN_ENTITLEMENTS for iOS, per target.
- Only set CLANG_ENABLE_OBJC_ARC for i386 on the iOS Simulator.
- Add missing newline.
- Configurations/Version.xcconfig:
- Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig:
- Only set SDKROOT and TOOLCHAINS on OS X.
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS on OS X.
- Configurations/DebugRelease.xcconfig:
- Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
Source/WTF:
- Configurations/Base.xcconfig:
- Only set GCC_ENABLE_OBJC_GC, GCC_MODEL_TUNING and TOOLCHAINS on OS X.
- Configurations/DebugRelease.xcconfig:
- Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
- 10:52 AM Changeset in webkit [177026] by
-
- 2 edits in trunk/LayoutTests
Mark several hidpi compositing tests that fail on EWS bots with ATI graphics.
- platform/mac/TestExpectations:
- 10:31 AM Changeset in webkit [177025] by
-
- 14 edits in trunk
AX: [ATK] MathML tokens, tables, and row-like elements are exposed with ATK_ROLE_UNKNOWN
https://bugs.webkit.org/show_bug.cgi?id=139402
Reviewed by Chris Fleizach.
Source/WebCore:
Expose tables and their children using existing table AtkRole types,
token elements using the new ATK_ROLE_STATIC, and row-like elements
using ATK_ROLE_PANEL. Also expose <mlabeledtr> as a math table row
and <ms> as math text.
No new tests; instead, added MathML elements to roles-exposed.html.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isMathToken):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMathToken):
(WebCore::AccessibilityRenderObject::isMathText):
(WebCore::AccessibilityRenderObject::isMathTableRow):
- accessibility/AccessibilityRenderObject.h:
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
- css/mathml.css:
(ms, mi, mo, mrow, mfenced, mfrac, msub, msup, msubsup, mmultiscripts, mprescripts, none, munder, mover, munderover, msqrt, mroot, merror, mphantom, mstyle, menclose):
(mi, mo, mrow, mfenced, mfrac, msub, msup, msubsup, mmultiscripts, mprescripts, none, munder, mover, munderover, msqrt, mroot, merror, mphantom, mstyle, menclose): Deleted.
- mathml/mathtags.in:
LayoutTests:
- accessibility/roles-exposed.html: Added MathML elements.
- platform/efl/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/gtk/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/mac-mountainlion/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/mac/accessibility/roles-exposed-expected.txt: Updated for added elements.
- 10:31 AM Changeset in webkit [177024] by
-
- 4 edits in trunk/Source
[Apple] Use Accelerate framework to speed-up FEGaussianBlur
https://bugs.webkit.org/show_bug.cgi?id=139310
Unreviewed followup, after comments by Andreas Kling.
It was pointed out that we already have a USE(ACCELERATE), so
we don't need a HAVE(ACCELERATE) :)
Source/WebCore:
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApply):
Source/WTF:
- wtf/Platform.h:
- 10:21 AM Changeset in webkit [177023] by
-
- 2 edits in trunk/Source/WTF
Undefined Symbol build error "_objc_registerThreadWithCollector" when building WebKit GTK Mac OS X on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=58737
Reviewed by Darin Adler.
Replace OS(MAC_OS_X) with PLATFORM(MAC) to prevent using
osx-specific code in WebKitGTK+ builds.
- wtf/ThreadingPthreads.cpp:
(WTF::initializeCurrentThreadInternal):
- 9:53 AM Changeset in webkit [177022] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Style fix following r177019.
Use nullptr instead of 0.
- bindings/gobject/ConvertToUTF8String.cpp:
(convertToUTF8String):
- 9:44 AM Changeset in webkit [177021] by
-
- 5 edits in trunk/Source/WebCore
Refactor of rebuildFloatingObjectSetFromIntrudingFloats function after r176957.
https://bugs.webkit.org/show_bug.cgi?id=139445
Reviewed by Darin Adler.
The function rebuildFloatingObjectSetFromIntrudingFloats would be clearer if
we use a helper function to locate the previous sibling with overhanging floats.
These changes has been suggested as part of the patch review for bug #139150, which
landed in r176957.
No new tests, no behavior change.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::avoidsFloats):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::previousSiblingWithOverhangingFloats):
(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
- rendering/RenderBlockFlow.h:
- rendering/RenderBox.h:
(WebCore::RenderBox::isGridItem):
- 9:16 AM Changeset in webkit [177020] by
-
- 6 edits in trunk/Source/WebKit2
Give WebsiteDataStore a unique ID
https://bugs.webkit.org/show_bug.cgi?id=139448
Reviewed by Andreas Kling.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::generateIdentifier):
(WebKit::WebsiteDataStore::WebsiteDataStore):
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::identifier):
- 9:12 AM WebKitGTK/2.6.x edited by
- (diff)
- 9:11 AM Changeset in webkit [177019] by
-
- 4 edits in trunk
convertToUTF8String converts null string to empty string
https://bugs.webkit.org/show_bug.cgi?id=133904
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Test added to Tools/TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp
Return 0 if the string is null.
- bindings/gobject/ConvertToUTF8String.cpp:
(convertToUTF8String):
Tools:
Test that trying to get the value of a non-existent attribute
returns 0 instead of an empty string.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
(WebKitDOMNodeTest::testInsertion):
- 7:57 AM Changeset in webkit [177018] by
-
- 2 edits in trunk/Source/WebKit2
Build fix.
- UIProcess/API/Cocoa/_WKWebsiteDataStore.h:
- 4:43 AM Changeset in webkit [177017] by
-
- 3 edits in trunk/Source/WebCore
When invalidating fullscreen, cancel instead of stop optimizedFullscfreen.
https://bugs.webkit.org/show_bug.cgi?id=139145
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-12-09
Reviewed by Eric Carlson.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::invalidate): call cancel instead of stop
- platform/spi/ios/AVKitSPI.h: add -cancelOptimizedFullscreen.
- 2:22 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:20 AM Changeset in webkit [177016] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] LDFLAGS is ignored when running g-ir-scanner
https://bugs.webkit.org/show_bug.cgi?id=138832
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-12-09
Reviewed by Carlos Garcia Campos.
GTK+ requires libintl on FreeBSD because there is no gettext
implementation in FreeBSD libc. In order to link to libintl, which is
not located in the default search path of the linker, we need to add
the required path via the linker command line. However, LDFLAGS is
ignored when running g-ir-scanner starting from r167873, so we have
to manually pick required flags from CMAKE_SHARED_LINKER_FLAGS and
put them in correct order to prevent g-ir-scanner from linking to
the installed version of libraries.
- PlatformGTK.cmake:
- 2:04 AM Changeset in webkit [177015] by
-
- 3 edits in trunk/Source/WebCore
[Media][GTK][EFL] Reduce style updates (painting) in controls
https://bugs.webkit.org/show_bug.cgi?id=137773
Reviewed by Carlos Garcia Campos.
Don't update media controls if they are not visible, and
initialize slider to a zero value.
- Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.createControls):
(Controller.prototype.handleDurationChange):
(Controller.prototype.updateProgress):
(Controller.prototype.updateTime):
- Modules/mediacontrols/mediaControlsGtk.js:
(ControllerGtk.prototype.updateTime):
- 1:51 AM Changeset in webkit [177014] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Add video/mp2t as alternative mimetype for MPEG TS
https://bugs.webkit.org/show_bug.cgi?id=139433
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-09
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
It's used e.g. on http://www.jwplayer.com/html5/mediasource/ .
- 1:20 AM Changeset in webkit [177013] by
-
- 4 edits in trunk
[GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
https://bugs.webkit.org/show_bug.cgi?id=139070
Reviewed by Carlos Garcia Campos.
Tools:
- gtk/jhbuild.modules:
LayoutTests:
- platform/gtk/accessibility/roles-exposed-expected.txt: Updated to reflect
the fact that the exposed role is STATIC and not UNKNOWN.
- 12:25 AM Changeset in webkit [177012] by
-
- 17 edits in trunk/Source
Enable activating optimized fullscreen mode from standard fulscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=139137
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-12-09
Source/WebCore:
Reviewed by Jer Noble.
Going from standard fullscreen mode to optimized fullscreen mode requires the ability to
update the fullscreen mode in HTMLMediaElement and a new standard-and-optimized-fullscreen mode.
This change KVO observes AVKit's optimizedFullscreenActive and forwards the change down to HTMLMediaElement so it can adjust behavior appropriately.
It also hides the standard fullscreen window when going into this mode.
When exiting fullscreen from standard-and-optimized, first exit fullscreen immediately, then stopOptimizedFullscreen, and notify of completion when
optimizedFullscreen goes inactive.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::fullscreenMode):
Treat VideoFullscreenModeStandardAndOptimized as a kind of optimized mode.
- WebCore.exp.in: New export for WebVideoFullscreenModelVideoElement::fullscreenModeChanged
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::displayType):
Treat VideoFullscreenModeStandardAndOptimized as a kind of optimized mode.
- html/HTMLMediaElement.h: Add new fullscreen mode.
(WebCore::HTMLMediaElement::fullscreenModeChanged): Update fullscreen mode so it does optimized fullscreen mode behaviors when applicable.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h: Declare setOptimizedActive
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVVideoLayer setPlayerViewController:]): observe optimizedFullscreenActive
(-[WebAVVideoLayer observeValueForKeyPath:ofObject:change:context:]): respond to changes to optimizedFullscreenActive
(WebVideoFullscreenInterfaceAVKit::WebVideoFullscreenInterfaceAVKit): Init members.
(WebVideoFullscreenInterfaceAVKit::playerController):
Give player controller a reference to the WebVideoFullscreenInterface so it can pass along mode change state.
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): Handle new fullscreen modes.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::invalidate): ditto
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::setOptimizedActive): Handle changes to fullscreen mode.
Also handle the case that exiting fullscreen happend when optimized mode ends.
- platform/ios/WebVideoFullscreenModel.h: declare fullscreenModeChanged()
- platform/ios/WebVideoFullscreenModelVideoElement.h: declare fullscreenModeChanged()
- platform/ios/WebVideoFullscreenModelVideoElement.mm: add fullscreenModeChanged()
(WebVideoFullscreenModelVideoElement::WebVideoFullscreenModelVideoElement): Init members.
(WebVideoFullscreenModelVideoElement::fullscreenModeChanged): Added. Update video element fullscreen mode.
Source/WebKit2:
Reviewed by Simon Fraser.
Going from standard fullscreen mode to optimized fullscreen mode requires the ability to
update the fullscreen mode and a new standard-and-optimized-fullscreen mode.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _isPlayingFullscreenOptimizedVideo]):
Treat new standard-and-optimized as a kind of optimized.
- UIProcess/ios/WebVideoFullscreenManagerProxy.h: IPC fullscreen mode changes
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm: ditto
(WebKit::WebVideoFullscreenManagerProxy::fullscreenModeChanged): dito
- WebProcess/ios/WebVideoFullscreenManager.h: ditto
- WebProcess/ios/WebVideoFullscreenManager.messages.in: ditto
- WebProcess/ios/WebVideoFullscreenManager.mm: dito
(WebKit::WebVideoFullscreenManager::WebVideoFullscreenManager): ditto
(WebKit::WebVideoFullscreenManager::setFullscreenModeChanged): ditto
Dec 8, 2014:
- 11:26 PM Changeset in webkit [177011] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION (r158036): WebView cannot handle HTTP Basic Authentication challenge
https://bugs.webkit.org/show_bug.cgi?id=138843
rdar://problem/18793695
Reviewed by Dan Bernstein.
- Panels/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel cancel:]):
(-[WebAuthenticationPanel logIn:]):
Don't close the panel before using panel.sheetParent, because the parent becomes nil.
In fact, we don't need to close it at all, it's enough to call orderOut:, and even
that only when using an old NSWindow API.
- 9:53 PM Changeset in webkit [177010] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix EFL build fix since r177001
https://bugs.webkit.org/show_bug.cgi?id=139428
Unreviewed, EFL build fix.
Do not inherit duplicated class. ExpressionNode is already
child of ParserArenaFreeable class.
- parser/Nodes.h:
- 9:24 PM Changeset in webkit [177009] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix Build Warning in JavaScriptCore ControlFlowProfiler::dumpData() api.
https://bugs.webkit.org/show_bug.cgi?id=139384
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-12-08
Reviewed by Mark Lam.
Fix Build Warning by using dataLog() function instead of dataLogF() function.
- runtime/ControlFlowProfiler.cpp:
(JSC::ControlFlowProfiler::dumpData):
- 9:02 PM Changeset in webkit [177008] by
-
- 4 edits in trunk/Source/JavaScriptCore
Web Inspector: Enable runtime API for JSC's control flow profiler
https://bugs.webkit.org/show_bug.cgi?id=139346
Reviewed by Joseph Pecoraro.
This patch creates an API that the Web Inspector can use
to get information about which basic blocks have exectued
from JSC's control flow profiler.
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getBasicBlocks):
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/protocol/Runtime.json:
- 8:56 PM Changeset in webkit [177007] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Use DependenciesEFL instead of Dependencies
Unreviewed, fix simple typo.
- PlatformEfl.cmake:
- 7:10 PM Changeset in webkit [177006] by
-
- 3 edits in trunk/LayoutTests
Rebaseline Mavericks test results after r176978.
Unreviewed.
- platform/mac-mavericks/fast/forms/search-vertical-alignment-expected.png:
- platform/mac-mavericks/fast/forms/search-vertical-alignment-expected.txt:
- 6:57 PM Changeset in webkit [177005] by
-
- 5 edits in branches/safari-600.3-branch/Source
Versioning.
- 6:50 PM Changeset in webkit [177004] by
-
- 1 copy in tags/Safari-600.3.11
New Tag.
- 6:24 PM Changeset in webkit [177003] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build after r177002
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-08
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension):
- 6:04 PM Changeset in webkit [177002] by
-
- 19 edits3 adds in trunk
Implementation EXT_sRGB as a WebGL1 extension.
https://bugs.webkit.org/show_bug.cgi?id=109332.
<rdar://problem/17363470>
Reviewed by Dean Jackson.
Tested by:
webgl/1.0.3/conformance/webgl/ext-sRGB.html
fast/canvas/webgl/constants.html
This patch implements the SRGB extension for WebGL1.
Details of the extension specification are outlined here:
https://www.khronos.org/registry/webgl/extensions/EXT_sRGB/
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- html/canvas/EXTsRGB.cpp: Added.
(WebCore::EXTsRGB::EXTsRGB):
(WebCore::EXTsRGB::~EXTsRGB):
(WebCore::EXTsRGB::getName):
- html/canvas/EXTsRGB.h: Added.
- html/canvas/EXTsRGB.idl: Added.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::checkStatus):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::renderbufferStorage):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContext.idl:
- platform/graphics/Extensions3D.h:
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
(WebCore::GraphicsContext3D::getClearBitsByFormat):
(WebCore::GraphicsContext3D::getChannelBitsByFormat):
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension):
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D):
- 5:53 PM Changeset in webkit [177001] by
-
- 16 edits1 delete in trunk
Source/JavaScriptCore:
Removed some allocation and cruft from the parser
https://bugs.webkit.org/show_bug.cgi?id=139416
Reviewed by Mark Lam.
Now, the only AST nodes that require a destructor are the ones that
relate to pickling a function's arguments -- which will required some
deeper thinking to resolve.
This is a < 1% parser speedup.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj: Removed NodeInfo because it
was unused.
- bytecompiler/NodesCodegen.cpp:
(JSC::CommaNode::emitBytecode):
(JSC::SourceElements::lastStatement):
(JSC::SourceElements::emitBytecode): Updated for interface change to linked list.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::varDeclarations):
(JSC::ASTBuilder::funcDeclarations):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::addVar): Removed the ParserArenaData abstraction because
it wasn't buying us anything. We can just use Vector directly.
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::appendToCommaExpr): Changed to use a linked list instead
of a vector, to avoid allocating a vector with inline capacity in the
common case in which an expression is not followed by a vector.
(JSC::ASTBuilder::Scope::Scope): Use Vector directly to avoid new'ing
up a Vector*.
(JSC::ASTBuilder::appendToComma): Deleted.
(JSC::ASTBuilder::combineCommaNodes): Deleted.
- parser/Lexer.cpp:
- parser/NodeConstructors.h:
(JSC::StatementNode::StatementNode):
(JSC::CommaNode::CommaNode):
(JSC::SourceElements::SourceElements): Updated for interface change to linked list.
- parser/NodeInfo.h: Removed.
- parser/Nodes.cpp:
(JSC::SourceElements::append):
(JSC::SourceElements::singleStatement): Use a linked list instead of a
vector to track the statements in a list. This removes some allocation
and it means that we don't need a destructor anymore.
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::EvalNode::EvalNode):
(JSC::FunctionNode::FunctionNode): Updated for interface change to reference,
since these values are never null.
- parser/Nodes.h:
(JSC::StatementNode::next):
(JSC::StatementNode::setNext):
(JSC::CommaNode::append): Deleted. Updated for interface change to linked list.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::didFinishParsing): Updated for interface change to reference.
(JSC::Parser<LexerType>::parseVarDeclarationList):
(JSC::Parser<LexerType>::parseExpression): Track comma expressions as
an explicit list of CommaNodes, removing a use of vector and a destructor.
- parser/Parser.h:
(JSC::Parser<LexerType>::parse):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::appendToCommaExpr):
(JSC::SyntaxChecker::appendToComma): Deleted. Updated for interface changes.
LayoutTests:
Removed the custom allocator for ParserArena
https://bugs.webkit.org/show_bug.cgi?id=139305
Reviewed by Mark Lam.
Added a test for something I messed up while writing this patch.
- js/basic-strict-mode-expected.txt:
- js/script-tests/basic-strict-mode.js:
- 5:31 PM Changeset in webkit [177000] by
-
- 6 edits1 add in trunk
[Apple] Use Accelerate framework to speed-up FEGaussianBlur
https://bugs.webkit.org/show_bug.cgi?id=139310
<rdar://problem/18434594>
PerformanceTests:
Reviewed by Simon Fraser.
Add an interactive performance test that measures the speed of a set
of blur operations on a generated images.
- Interactive/blur-filter-timing.html: Added.
Source/WebCore:
<rdar://problem/18434594>
Reviewed by Simon Fraser.
Using Apple's Accelerate framework provides faster blurs
than the parallel jobs approach, especially since r168577
which started performing retina-accurate filters.
Using Accelerate.framework to replace the existing box blur (what
we use to approximate Gaussian blurs) gets about a 20% speedup on
desktop class machines, but between a 2x-6x speedup on iOS hardware.
Obviously this depends on the size of the content being blurred,
but it is still good.
The change is to intercept the platformApply function on
FEGaussianBlur and send it off to Accelerate.
There is an interactive performance test: PerformanceTests/Interactive/blur-filter-timing.html
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::kernelPosition): Move this to a file static function from the .h.
(WebCore::accelerateBoxBlur): The Accelerate implementation.
(WebCore::standardBoxBlur): The default generic/standard implementation.
(WebCore::FEGaussianBlur::platformApplyGeneric): Use accelerate or the default form.
(WebCore::FEGaussianBlur::platformApply): Don't try the parallelJobs approach if Accelerate is available.
- platform/graphics/filters/FEGaussianBlur.h:
(WebCore::FEGaussianBlur::kernelPosition): Deleted. Move into the .cpp.
Source/WTF:
<rdar://problem/18434594>
Reviewed by Simon Fraser.
Add a HAVE_ACCELERATE flag, true on Apple platforms.
- wtf/Platform.h:
- 5:29 PM Changeset in webkit [176999] by
-
- 12 edits in trunk/Source
Copy and Lookup menu items should be disabled when something is not copyable
https://bugs.webkit.org/show_bug.cgi?id=139423
Reviewed by Tim Horton.
Source/WebCore:
New function allowCopy() indicates whether the HitTestResult would allow itself to
be copied onto the pasteboard.
- WebCore.exp.in:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::allowsCopy):
- rendering/HitTestResult.h:
Source/WebKit/mac:
Disable both lookup and copy when a HitTestResult does not allow copy.
- WebView/WebActionMenuController.mm:
Set autoenablesItems to NO. It’s messing with our ability to control the enable/
disable state otherwise.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit2:
Add allowsCopy to the WebHitTestResult.
- Shared/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::Data::Data):
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):
- Shared/WebHitTestResult.h:
(WebKit::WebHitTestResult::allowsCopy):
Set autoenablesItems to NO. It’s messing with our ability to control the enable/
disable state otherwise.
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:webView:]):
Disable both lookup and copy when a WebHitTestResult does not allow copy.
- UIProcess/mac/WKActionMenuController.mm:
- 5:28 PM Changeset in webkit [176998] by
-
- 2 edits in trunk/Source/WebCore
Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAffectsVisualOverflow()
https://bugs.webkit.org/show_bug.cgi?id=139420
Reviewed by Simon Fraser.
Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to
changeAffectsVisualOverflow(). This has no behavior change as
changeRequiresLayout() calls changeAffectsVisualOverflow(). However,
this is clearer as text-shadow affects the visual overflow (similarly
to box-shadow).
No new tests, no behavior change.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeAffectsVisualOverflow):
(WebCore::RenderStyle::changeRequiresLayout):
- 5:26 PM Changeset in webkit [176997] by
-
- 4 edits2 deletes in trunk/Source/JavaScriptCore
Unreviewed, rolling out r176979.
https://bugs.webkit.org/show_bug.cgi?id=139424
"New JSC test in this patch is failing" (Requested by mlam on
#webkit).
Reverted changeset:
"Fixes operationPutByIds such that they check that the put
didn't"
https://bugs.webkit.org/show_bug.cgi?id=139196
http://trac.webkit.org/changeset/176979
- 5:20 PM Changeset in webkit [176996] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/18905383> [iOS] Crash due to null m_webPageProxyForBackForwardListForCurrentSwipe in ViewGestureController::endSwipeGesture
https://bugs.webkit.org/show_bug.cgi?id=138750
Reviewed by Tim Horton.
The snapshot for the current gesture was being removed mid-gesture by the callback from
dispatchAfterEnsuringDrawing scheduled by the previous gesture. The fix is to ignore the
callback for a gesture if it is made after the snapshot for that gesture has already been
removed (which can happen as a result of the watchdog timer firing).
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::ViewGestureController): Initialize new member variable.
(WebKit::addLogEntry): Fixed the log message format.
(WebKit::ViewGestureController::endSwipeGesture): When dispatchAfterEnsuringDrawing() calls
us back, bail out if the gesture snapshot has already been removed.
(WebKit::ViewGestureController::removeSwipeSnapshot): Increment
m_gesturePendingSnapshotRemoval.
- UIProcess/mac/ViewGestureController.h: Added m_gesturePendingSnapshotRemoval member
variable.
- 5:17 PM Changeset in webkit [176995] by
-
- 2 edits in trunk/Source/WebCore
Fix typo.
- storage/StorageNamespaceImpl.cpp:
(WebCore::localStorageNamespaceMap):
- 5:05 PM Changeset in webkit [176994] by
-
- 4 edits4 deletes in branches/safari-600.3-branch/Tools
Rollout r176959. rdar://problem/19179009
- 4:48 PM Changeset in webkit [176993] by
-
- 4 edits4 adds in branches/safari-600.3-branch/Tools
Merged r176959. rdar://problems/19179009
- 4:28 PM Changeset in webkit [176992] by
-
- 10 edits in trunk/Source
WebStorageNamespaceProvider should create StorageNamespaceImpls
https://bugs.webkit.org/show_bug.cgi?id=139419
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
Export new symbols.
- WebCore.xcodeproj/project.pbxproj:
Make StorageNamespaceImpl.h a private header.
- storage/StorageNamespaceImpl.cpp:
(WebCore::localStorageNamespaceMap):
Use NeverDestroyed.
(WebCore::StorageNamespaceImpl::createSessionStorageNamespace):
(WebCore::StorageNamespaceImpl::getOrCreateLocalStorageNamespace):
Add new functions for creating namespaces.
(WebCore::StorageNamespaceImpl::localStorageNamespace):
(WebCore::StorageNamespaceImpl::sessionStorageNamespace):
Call the new functions.
- storage/StorageNamespaceImpl.h:
Add new members, make sure to deprecate the ones we don't want anyone calling.
- storage/StorageNamespaceProvider.cpp:
(WebCore::StorageNamespaceProvider::localStorageNamespace):
(WebCore::StorageNamespaceProvider::transientLocalStorageNamespace):
- storage/StorageNamespaceProvider.h:
Pass the quota when creating storage namespaces.
Source/WebKit:
- Storage/WebStorageNamespaceProvider.cpp:
(WebStorageNamespaceProvider::createLocalStorageNamespace):
(WebStorageNamespaceProvider::createTransientLocalStorageNamespace):
Create StorageNamespaceImpls.
(WebStorageNamespaceProvider::createSessionStorageNamespace): Deleted.
Delete this for now.
- Storage/WebStorageNamespaceProvider.h:
- 4:23 PM Changeset in webkit [176991] by
-
- 4 edits in trunk/Source/WebKit/mac
Adding user content to a group should force that group to be created
https://bugs.webkit.org/show_bug.cgi?id=139421
rdar://problem/19180108
Reviewed by Sam Weinig.
- WebCoreSupport/WebViewGroup.h:
Store the local storage database path in the group.
- WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::getOrCreate):
If we have an existing group that hasn't had its storage namespace provider created, and the path passed is not empty,
set it. This will ensure that getOrCreate will still work when creating a storage namspace provider.
(WebViewGroup::WebViewGroup):
Initialize the new member variable.
(WebViewGroup::storageNamespaceProvider):
Create the namespace provider lazily.
- WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
Use getOrCreate instead of get.
- 4:16 PM Changeset in webkit [176990] by
-
- 2 edits2 adds in trunk/LayoutTests
REGRESSION (173394): Support for webcam is broken
https://bugs.webkit.org/show_bug.cgi?id=139313
Test by Antti Koivisto, reviewed and tweaked by Alexey Proskuryakov.
- http/tests/multipart/multipart-image-expected.html: Added.
- http/tests/multipart/multipart-image.html: Added.
- http/tests/multipart/resources/multipart.php: Multiopart boundary must start on
a new line, so make it so. In newwer OS versions, CFNetwork has a workaround that
makes invalid multipart response work, which is why the test was passing locally.
- 4:10 PM Changeset in webkit [176989] by
-
- 3 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176883. rdar://problems/19158331
- 4:10 PM Changeset in webkit [176988] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r176856. rdar://problems/19157955
- 4:10 PM Changeset in webkit [176987] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176870. rdar://problems/19052381
- 4:10 PM Changeset in webkit [176986] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r176116. <rdar://problem/19052381>
- 3:57 PM Changeset in webkit [176985] by
-
- 3 edits in trunk/Source/WebCore
Move the new :nth-child() and :nth-last-child() out of experimental
https://bugs.webkit.org/show_bug.cgi?id=139329
Reviewed by Andreas Kling.
The code is stable.
Feedback has only been positive.
All the known issues have been reported to the CSS WG.
The #ifdef don't really work anymore anyway for :nth-child() and :nth-last-child().
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- 3:56 PM Changeset in webkit [176984] by
-
- 3 edits6 adds in trunk
A selector should not match anything if there is a subselector after a non-scrollbar pseudo element
https://bugs.webkit.org/show_bug.cgi?id=139336
Source/WebCore:
rdar://problem/19051623
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-08
Reviewed by Andreas Kling.
Tests: fast/css/duplicated-after-pseudo-element.html
fast/css/duplicated-before-pseudo-element.html
fast/css/simple-selector-after-pseudo-element.html
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::constructFragments):
The code filtering out simple selectors was only considering
the relation CSSSelector::SubSelector. That comes from SelectorChecker where
the relation considered is the one from the previous selector.
In this case, the relation is the extracted from the current simple selector,
which is the relation with the following selector.
When a single simple selector was following a pseudo element, the relation evaluated
to descendant/adjacent/direct-adjacent and we were skipping the early return.
That simple selector was evaluated as a regular filter on the element.
In the CSS JIT, we can just remove that test altogether. Fragments are built one after
the other. By definition, the evaluated simple selector belong to the current fragment.
LayoutTests:
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-08
Reviewed by Andreas Kling.
- fast/css/duplicated-after-pseudo-element-expected.html: Added.
- fast/css/duplicated-after-pseudo-element.html: Added.
- fast/css/duplicated-before-pseudo-element-expected.html: Added.
- fast/css/duplicated-before-pseudo-element.html: Added.
- fast/css/simple-selector-after-pseudo-element-expected.html: Added.
- fast/css/simple-selector-after-pseudo-element.html: Added.
- 3:55 PM Changeset in webkit [176983] by
-
- 9 edits in trunk
Fix the parsing of advanced :lang() after r176902
https://bugs.webkit.org/show_bug.cgi?id=139379
Reviewed by Andreas Kling.
Source/WebCore:
There were two mistakes that were only caught in debug:
The lexer was not calling isIdentifierStart() before parseIdentifier().
Some identifier we were parsing should have been invalid.
This was caught with an assertion in parseIdentifier().
The other issue is that we were accumulating pointer to freed memory.
The tokenizer for LANGRANGE was creating a new string with a StringBuilder.
The problem is that CSSParserString does not keep the source string alive.
Consequently, the list of language range was accumulating pointers to dead
StringImpls.
The fix there is to simply extend the token to take the original asterisk character
from the input. That is not elegant but that's efficient and we know
the buffer lifetime.
- css/CSSParser.cpp:
(WebCore::CSSParser::realLex):
- css/CSSGrammar.y.in: Fix the indentation of a language range rule.
LayoutTests:
Unskip and update the tests.
All the interesting cases were covered, I just had to update
the expectations.
- TestExpectations:
- fast/css/css-selector-text-expected.txt:
- fast/css/css-selector-text.html:
- fast/css/parsing-css-lang-expected.txt:
- fast/css/parsing-css-lang.html:
- 3:34 PM Changeset in webkit [176982] by
-
- 2 edits in trunk/Source/WTF
Fix iOS build after r176971.
I had previously modified the WTF forwarding header instead of modifying the real source.
- wtf/unicode/CharacterNames.h:
- 3:14 PM Changeset in webkit [176981] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the 32-bit build.
- WebCore.exp.in:
- 3:14 PM Changeset in webkit [176980] by
-
- 5 edits in trunk/Source/WebKit2
The website data store should know all its associated pages
https://bugs.webkit.org/show_bug.cgi?id=139411
Reviewed by Tim Horton.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
- UIProcess/WebPageProxy.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::~WebsiteDataStore):
(WebKit::WebsiteDataStore::addWebPage):
(WebKit::WebsiteDataStore::removeWebPage):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 3:11 PM Changeset in webkit [176979] by
-
- 4 edits2 adds in trunk/Source/JavaScriptCore
Fixes operationPutByIds such that they check that the put didn't
change the structure of the object who's property access is being
cached.
https://bugs.webkit.org/show_bug.cgi?id=139196
Reviewed by Filip Pizlo.
- jit/JITOperations.cpp:
(JSC::operationGetByIdOptimize): changed get to getPropertySlot
(JSC::operationPutByIdStrictBuildList): saved the structure before the put.
(JSC::operationPutByIdNonStrictBuildList): ditto.
(JSC::operationPutByIdDirectStrictBuildList): ditto.
(JSC::operationPutByIdDirectNonStrictBuildList): ditto.
- jit/Repatch.cpp:
(JSC::tryCachePutByID): fixed structure() to use the existant vm.
(JSC::tryBuildPutByIdList): Added a check that the old structure's id
is the same as the new.
(JSC::buildPutByIdList): Added an argument
- jit/Repatch.h:
(JSC::buildPutByIdList): Added an argument
- tests/stress/put-by-id-build-list-order-recurse.js: Test that failed before the change
- tests/stress/put-by-id-strict-build-list-order.js: Added.
- 3:10 PM Changeset in webkit [176978] by
-
- 22 edits3 adds1 delete in trunk
Inline elements whose parents have small line-height are laid out too low
https://bugs.webkit.org/show_bug.cgi?id=139375
Reviewed by Dave Hyatt.
Source/WebCore:
This is a port of the Blink patch at
https://src.chromium.org/viewvc/blink?revision=155253&view=revision.
When laying out inline elements, we try to align leaf children's parents'
baselines across the entire line. However, if you set line-height: 0px on a
span, the entire InlineBox which represents that span will have a height of
0, and therefore be laid out entirely on the baseline. In addition, we will
try to vertically center the leaf text in the span's InlineBox, which means
the leaf text will be vertically centered on the baseline. All the other
major browsers do not have this behavior; instead, they line up the boxes
as you would expect.
This bug led to a rendering problem on the front page of the New York Times.
Here is the ChangeLog from the Blink patch:
Fix baseline position when it is outside the element's box
Specifically, we shouldn't force the baseline to be inside the element. IE
and FF don't do this, and it's incompatible with the CSS spec:
"The baseline of an 'inline-block' is the baseline of its last line box in
the normal flow, unless it has either no in-flow line boxes or if its
'overflow' property has a computed value other than 'visible', in which case
the baseline is the bottom margin edge."
-- http://www.w3.org/TR/CSS21/visudet.html#leading
It doesn't have a special case for "baseline is outside of the element's
margin box".
Test: fast/text/small-line-height.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::baselinePosition):
LayoutTests:
Add fast/text/small-line-height.html for a simple example. In addition, update
existing tests.
- fast/forms/textfield-overflow-by-value-update-expected.txt:
- fast/regions/cssom/client-rects-inline-complex.html:
- fast/regions/overflow/overflow-region-inline-expected.html:
- fast/text/small-line-height-expected.html: Added.
- fast/text/small-line-height.html: Added.
- platform/mac/fast/box-sizing/box-sizing-expected.png:
- platform/mac/fast/box-sizing/box-sizing-expected.txt:
- platform/mac/fast/forms/search-vertical-alignment-expected.png:
- platform/mac/fast/forms/search-vertical-alignment-expected.txt:
- platform/mac/fast/forms/textfield-overflow-by-value-update-expected.png: Removed.
- platform/mac/fast/multicol/client-rects-expected.png:
- platform/mac/fast/multicol/client-rects-expected.txt:
- platform/mac/fast/multicol/client-rects-spanners-complex-expected.png:
- platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt:
- platform/mac/fast/multicol/client-rects-spanners-expected.png:
- platform/mac/fast/multicol/client-rects-spanners-expected.txt:
- platform/mac/fast/multicol/layers-split-across-columns-expected.png:
- platform/mac/fast/multicol/layers-split-across-columns-expected.txt:
- platform/mac/fast/multicol/newmulticol/client-rects-expected.png:
- platform/mac/fast/multicol/newmulticol/client-rects-expected.txt:
- 2:56 PM Changeset in webkit [176977] by
-
- 2 edits in trunk/Source/WebCore
[iOS] YouTube plug-in replacement should support partial urls
https://bugs.webkit.org/show_bug.cgi?id=139400
Reviewed by Alexey Proskuryakov.
- Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::YouTubePluginReplacement::youTubeURL): Call Document::completeURL.
- 2:39 PM Changeset in webkit [176976] by
-
- 7 edits in trunk/Source/WebKit
WebStorageNamespaceProvider should know about its local storage database path
https://bugs.webkit.org/show_bug.cgi?id=139413
Reviewed by Andreas Kling.
Source/WebKit:
- Storage/WebStorageNamespaceProvider.cpp:
(WebStorageNamespaceProvider::create):
(WebStorageNamespaceProvider::WebStorageNamespaceProvider):
- Storage/WebStorageNamespaceProvider.h:
Source/WebKit/mac:
- WebCoreSupport/WebViewGroup.h:
- WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::getOrCreate):
(WebViewGroup::WebViewGroup):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView setGroupName:]):
(-[WebView groupName]): Deleted.
- 2:38 PM Changeset in webkit [176975] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::deleteAllCookiesModifiedSince):
- 2:17 PM Changeset in webkit [176974] by
-
- 8 edits in trunk/Source/WebCore
Roll out r175352.
<https://webkit.org/b/139146>
This change caused some unexpected assertions in line box teardown.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::willBeRemovedFromTree):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::willBeDestroyed):
- rendering/RenderReplaced.h:
- 2:17 PM Changeset in webkit [176973] by
-
- 9 edits in trunk/Source
Change WTF::currentCPUTime to return std::chrono::microseconds and get rid of currentCPUTimeMS
https://bugs.webkit.org/show_bug.cgi?id=139410
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- API/JSContextRef.cpp:
(JSContextGroupSetExecutionTimeLimit):
(JSContextGroupClearExecutionTimeLimit):
- runtime/Watchdog.cpp:
(JSC::Watchdog::setTimeLimit):
(JSC::Watchdog::didFire):
(JSC::Watchdog::startCountdownIfNeeded):
(JSC::Watchdog::startCountdown):
- runtime/Watchdog.h:
- runtime/WatchdogMac.cpp:
(JSC::Watchdog::startTimer):
Source/WTF:
- wtf/CurrentTime.cpp:
(WTF::currentCPUTime):
(WTF::currentCPUTimeMS): Deleted.
- wtf/CurrentTime.h:
- 2:12 PM Changeset in webkit [176972] by
-
- 3 edits3 adds in trunk
CFA wrongly assumes that a speculation for SlowPutArrayStorageShape disallows ArrayStorageShape arrays.
<https://webkit.org/b/139327>
Reviewed by Michael Saboff.
Source/JavaScriptCore:
The code generator and runtime slow paths expects otherwise. This patch fixes
CFA to match the code generator's expectation.
- dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::arrayModesThatPassFiltering):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShapes):
LayoutTests:
- js/dfg-slow-put-array-storage-spec-should-allow-fast-array-storage-expected.txt: Added.
- js/dfg-slow-put-array-storage-spec-should-allow-fast-array-storage.html: Added.
- js/script-tests/dfg-slow-put-array-storage-spec-should-allow-fast-array-storage.js: Added.
(foo):
(test):
- 2:10 PM Changeset in webkit [176971] by
-
- 3 edits2 adds in trunk
[iOS] Narrow non-breaking space does not fall back to a correct font
https://bugs.webkit.org/show_bug.cgi?id=139335
Reviewed by Enrica Casucci.
Source/WebCore:
Test: fast/text/narrow-non-breaking-space.html
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::requiresCustomFallbackFont):
(WebCore::FontCache::getCustomFallbackFont):
LayoutTests:
- fast/text/narrow-non-breaking-space-expected.html: Added.
- fast/text/narrow-non-breaking-space.html: Added.
- 2:06 PM Changeset in webkit [176970] by
-
- 4 edits in trunk/Source
[iOS] Fix the WebKit build with the public SDK
Source/WebCore:
Include header UIKit.h.
- platform/spi/ios/MediaPlayerSPI.h:
Source/WebKit/mac:
Include header NSURLDownloadSPI.h.
- WebCoreSupport/WebFrameLoaderClient.mm:
- 1:53 PM Changeset in webkit [176969] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/18046692> [iOS] Safari crashes at -[_NSUndoStack popAndInvoke] when trying to undo typing on closed tab
https://bugs.webkit.org/show_bug.cgi?id=139408
Reviewed by Anders Carlsson.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView undoManager]): Override to initialize if necessary and return a unique undo
manager for this instance. This ensures that undoable operations for this webview don’t get
put in other undo managers, and matches UIWebView behavior.
- 1:10 PM Changeset in webkit [176968] by
-
- 5 edits in tags/Safari-600.3.10.2/Source
Versioning.
- 1:08 PM Changeset in webkit [176967] by
-
- 5 edits in tags/Safari-601.1.11.2/Source
Versioning.
- 1:01 PM Changeset in webkit [176966] by
-
- 1 copy in tags/Safari-601.1.11.2
New tag.
- 1:00 PM Changeset in webkit [176965] by
-
- 1 copy in tags/Safari-600.3.10.2
New tag.
- 12:40 PM Changeset in webkit [176964] by
-
- 23 edits in trunk/Source
Unreviewed, revert r176293 & r176275 changing the Vector API to use unsigned type
instead of size_t. There is some disagreement regarding the long-term direction
of the API and we shouldn’t leave the API partly transitioned to unsigned type
while making a decision.
Source/JavaScriptCore:
- bytecode/PreciseJumpTargets.cpp:
- replay/EncodedValue.h:
Source/WebCore:
- WebCore.exp.in:
- bindings/js/JSDOMBinding.h:
(WebCore::jsArray):
- bindings/js/JSWebGLRenderingContextCustom.cpp:
- cssjit/SelectorCompiler.cpp:
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::append):
(WebCore::SearchBuffer::prependContext):
(WebCore::SearchBuffer::search):
(WebCore::SearchBuffer::length):
- html/HTMLFormElement.cpp:
(WebCore::removeFromVector):
- html/parser/HTMLParserIdioms.h:
- html/parser/XSSAuditor.cpp:
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::duplicateDataBufferIfNecessary):
Source/WebKit2:
- Platform/IPC/ArgumentCoders.h:
- Platform/IPC/DataReference.h:
Source/WTF:
- wtf/Forward.h:
- wtf/Vector.h:
(WTF::VectorTypeOperations::compare):
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::shouldReallocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
(WTF::VectorBufferBase::capacity):
(WTF::VectorBufferBase::VectorBufferBase):
(WTF::VectorBuffer::VectorBuffer):
(WTF::VectorBuffer::allocateBuffer):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::VectorBuffer::shouldReallocateBuffer):
(WTF::VectorBuffer::reallocateBuffer):
(WTF::VectorBuffer::swap):
(WTF::VectorBuffer::swapInlineBuffer):
(WTF::VectorBuffer::swapInlineBuffers):
(WTF::Vector::Vector):
(WTF::Vector::capacity):
(WTF::Vector::at):
(WTF::Vector::operator[]):
(WTF::OverflowHandler>::find):
(WTF::OverflowHandler>::reverseFind):
(WTF::OverflowHandler>::fill):
(WTF::OverflowHandler>::expandCapacity):
(WTF::OverflowHandler>::tryExpandCapacity):
(WTF::OverflowHandler>::resize):
(WTF::OverflowHandler>::resizeToFit):
(WTF::OverflowHandler>::shrink):
(WTF::OverflowHandler>::grow):
(WTF::OverflowHandler>::reserveCapacity):
(WTF::OverflowHandler>::tryReserveCapacity):
(WTF::OverflowHandler>::reserveInitialCapacity):
(WTF::OverflowHandler>::shrinkCapacity):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::insert):
(WTF::OverflowHandler>::insertVector):
(WTF::OverflowHandler>::remove):
(WTF::OverflowHandler>::reverse):
(WTF::OverflowHandler>::checkConsistency):
- wtf/text/AtomicString.h:
- wtf/text/StringImpl.h:
(WTF::StringImpl::adopt):
(WTF::equalIgnoringNullity):
- wtf/text/StringView.h:
(WTF::append):
- wtf/text/WTFString.h:
- 12:36 PM Changeset in webkit [176963] by
-
- 18 edits in trunk/Source
Make deleting all cookies after a given date a little more sane
https://bugs.webkit.org/show_bug.cgi?id=139409
Reviewed by Antti Koivisto.
Source/WebCore:
- WebCore.exp.in:
Update exports.
- platform/network/PlatformCookieJar.h:
- platform/network/cf/CookieJarCFNet.cpp:
- platform/network/curl/CookieJarCurl.cpp:
- platform/network/soup/CookieJarSoup.cpp:
Rename deleteAllCookiesModifiedAfterDate to deleteAllCookiesModifiedSince and change it
to take an std::chrono::system_clock::time_point instead.
- platform/network/mac/CookieJarMac.mm:
(WebCore::cookieStorage):
Helper function that returns an NSHTTPCookieStorage given a network session.
(WebCore::deleteAllCookiesModifiedSince):
Get the cookie storage from the network storage instead of just getting the global one.
Source/WebKit2:
Change all the doubles to std::chrono::system_clock::time_points instead.
- Platform/IPC/ArgumentCoders.cpp:
(IPC::ArgumentCoder<std::chrono::system_clock::time_point>::encode):
(IPC::ArgumentCoder<std::chrono::system_clock::time_point>::decode):
- Platform/IPC/ArgumentCoders.h:
- Scripts/webkit/messages.py:
(headers_for_type):
- UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerDeleteAllCookiesModifiedAfterDate):
- UIProcess/API/C/WKCookieManager.h:
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedAfterDate): Deleted.
- UIProcess/WebCookieManagerProxy.h:
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManager::deleteAllCookiesModifiedAfterDate): Deleted.
- WebProcess/Cookies/WebCookieManager.h:
- WebProcess/Cookies/WebCookieManager.messages.in:
- 12:34 PM Changeset in webkit [176962] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176596. rdar://problems/19176127
- 12:23 PM Changeset in webkit [176961] by
-
- 5 edits in branches/safari-600.3-branch/Source
Versioning.
- 12:07 PM Changeset in webkit [176960] by
-
- 2 edits in trunk/Source/WebKit2
Move the callback invocation outside of the loop.
Rubber-stamped by Tim Horton.
- UIProcess/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::getStorageDetailsByOrigin):
- 11:40 AM Changeset in webkit [176959] by
-
- 4 edits4 adds in trunk/Tools
Add action menu tests
https://bugs.webkit.org/show_bug.cgi?id=139156
Reviewed by Dean Jackson.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
Add a mechanism allowing tests to provide their own WKView subclass.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
Add a file with lots of menu targets.
- TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
(-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
(-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
(-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
(-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
(TestWebKitAPI::didFinishLoadForFrameCallback):
(TestWebKitAPI::didFinishDownloadCallback):
(TestWebKitAPI::didCreateDownloadDestinationCallback):
Watch downloads and ensure that they match the content we expect.
(TestWebKitAPI::watchPasteboardForString):
(TestWebKitAPI::watchPasteboardForImage):
(TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
(TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
(TestWebKitAPI::javaScriptStringCallback):
(TestWebKitAPI::javaScriptBoolCallback):
(TestWebKitAPI::callJavaScriptReturningString):
(TestWebKitAPI::callJavaScriptReturningBool):
(TestWebKitAPI::watchEditableAreaForString):
(TestWebKitAPI::waitForVideoReady):
(TestWebKitAPI::retrieveSelection):
(TestWebKitAPI::retrieveSelectionInElement):
(TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
(TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
Add many helpers for testing, especially to make asynchronous things synchronous.
(TestWebKitAPI::windowPointForTarget):
(TestWebKitAPI::inset8):
Hard-code points in action-menu-targets.html for hit testing.
(TestWebKitAPI::TEST):
Add a suite of tests for WebKit2 action menus.
- TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
(TestWebKitAPI::createActionContextForPhoneNumber):
(TestWebKitAPI::ActionMenuTest::ActionMenuTest):
(TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
(TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
(TestWebKitAPI::ActionMenuTest::drawRect):
(TestWebKitAPI::ActionMenuTest::didCreatePage):
Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
so that we can test that infrastructure.
- 11:30 AM Changeset in webkit [176958] by
-
- 2 edits in trunk/Source/WebCore
URTBF after r176953, add an unreachable return to make GCC happy.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
- 11:13 AM Changeset in webkit [176957] by
-
- 10 edits4 adds in trunk
[CSS Grid Layout] Grid items must set a new formatting context.
https://bugs.webkit.org/show_bug.cgi?id=139150
Reviewed by David Hyatt.
Source/WebCore:
Grid item's margins must not collapse even when they may be adjoining to
its content's margins. Also, setting a new formatting context prevents any
'float' protruding content on the adjoining grid items.
This patch also renames the expandsToEncloseOverhangingFloats to be more generic now,
determining whether a new formatting context is set or not. This affects not only to
how floats behave, but whether margins should collapse or not.
Tests: fast/css-grid-layout/float-not-protruding-into-next-grid-item.html
fast/css-grid-layout/grid-item-margins-not-collapse.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::avoidsFloats): Using the new createsNewFormattingContext function.
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats): Deleted.
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::MarginInfo::MarginInfo): Using the new createsNewFormattingContext function.
(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats): Using the new createsNewFormattingContext function.
(WebCore::RenderBlockFlow::layoutBlock): Using the new createsNewFormattingContext function.
(WebCore::RenderBlockFlow::computeOverflow): Using the new createsNewFormattingContext function.
(WebCore::RenderBlockFlow::addOverhangingFloats): Using the new createsNewFormattingContext function.
(WebCore::RenderBlockFlow::needsLayoutAfterRegionRangeChange): Using the new createsNewFormattingContext function.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::createsNewFormattingContext): Added.
(WebCore::RenderBox::avoidsFloats): Removed checks already defined in the new createsNewFormattingContext function.
- rendering/RenderBox.h:
(WebCore::RenderBox::isGridItem): Added.
LayoutTests:
Test to verify that grid items's margin don't collapese with its parent's margin
and there is no 'float' protruding content on the adjoining grid items.
I had to rebaseline the form-hides-table.html test because table-caption, which
is supposed to establish a new formatting context, does not allow margins collapsing.
- fast/css-grid-layout/float-not-protruding-into-next-grid-item-expected.html: Added.
- fast/css-grid-layout/float-not-protruding-into-next-grid-item.html: Added.
- fast/css-grid-layout/grid-item-margins-not-collapse-expected.html: Added.
- fast/css-grid-layout/grid-item-margins-not-collapse.html: Added.
- platform/gtk/fast/forms/form-hides-table-expected.txt: Rebaseline needed.
- platform/mac/fast/forms/form-hides-table-expected.txt: Rebaseline needed.
- platform/efl/TestExpectations: Mark fast/forms/form-hides-table-expected as failure.
- 10:50 AM Changeset in webkit [176956] by
-
- 4 edits in trunk/Source/WebKit2
Add a stub implementation of WebsiteDataStore::removeDataModifiedSince
https://bugs.webkit.org/show_bug.cgi?id=139406
Reviewed by Antti Koivisto.
Change _WKWebsiteDataStore to call the newly added function.
- UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
(toWebsiteDataTypes):
(toSystemClockTime):
(-[_WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:]):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeDataModifiedSince):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 10:47 AM Changeset in webkit [176955] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Attempt to fix the public SDK build after <https://trac.webkit.org/r176841>
(https://bugs.webkit.org/show_bug.cgi?id=139227)
- platform/spi/ios/AVKitSPI.h:
- 10:46 AM Changeset in webkit [176954] by
-
- 14 edits in trunk/Source/WebKit2
[GTK] Let DrawingArea manages setAcceleratedCompositingWindowId
https://bugs.webkit.org/show_bug.cgi?id=117230
Reviewed by Anders Carlsson.
This is a preparation patch for Threaded Coordinated Graphics.
LayerTreeHostGtk uses a native window handle to make glContext for
accelerated compositing. Therefore it is natural for DrawingArea to take
responsibility for the native window handle. And, in Coordinated
Graphics case, WebPage creates LayerTreeHost before receiving a native
window handle from UIProcess. It means we need a method to pass the
native window handle to already created LayerTreeHost.
This patch uses DrawingAreaProxy::setNativeSurfaceHandleForCompositing
instead of WebCoreProxy::setAcceleratedCompositingWindowId to set window
ID for accelerated compositing.
Also, this patch renames the setAcceleratedCompositingWindowId with a
more generic name, setNativeSurfaceHandleForCompositing.
No new tests. No change in functionality.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setNativeSurfaceHandleForCompositing):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/WebPageProxy.h:
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::setAcceleratedCompositingWindowId): Deleted.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::nativeSurfaceHandleForCompositing):
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNativeSurfaceHandleForCompositing):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::glContext):
(WebKit::LayerTreeHostGtk::initialize):
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::setAcceleratedCompositingWindowId): Deleted.
- 10:42 AM Changeset in webkit [176953] by
-
- 2 edits in trunk/Source/WebCore
Stop using ResourceRequest::cachePolicy() in FrameLoader::subresourceCachePolicy()
https://bugs.webkit.org/show_bug.cgi?id=139350
Reviewed by Antti Koivisto.
Stop using ResourceRequest::cachePolicy() in FrameLoader::subresourceCachePolicy()
and use m_loadType instead. ResourceRequest::cachePolicy() is meant to be passed
to the network stack, and isn't supposed to be used as input inside WebCore.
No new tests, no behavior change.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
- 10:14 AM Changeset in webkit [176952] by
-
- 16 edits3 adds in trunk
[GTK] UserMedia Permission Request API
https://bugs.webkit.org/show_bug.cgi?id=136449
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Very basic constraints validation support in the GStreamer
MediaStreamCenter. This is needed so the GTK C API tests using the
getUserMedia() API would not time out.
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
(WebCore::MediaStreamCenterGStreamer::~MediaStreamCenterGStreamer):
(WebCore::MediaStreamCenterGStreamer::validateRequestConstraints):
(WebCore::MediaStreamCenterGStreamer::createMediaStream):
Source/WebKit2:
- PlatformGTK.cmake: GTK-specific new files.
- UIProcess/API/gtk/WebKitUIClient.cpp: DecidePolicy handler
implementation for UserMediaPermissionRequest.
- UIProcess/API/gtk/WebKitUserMediaPermissionRequest.cpp: Added,
WebKitGTK API for UserMediaPermissionRequest, very similar to the
one used for Geolocation.
(webkitUserMediaPermissionRequestAllow):
(webkitUserMediaPermissionRequestDeny):
(webkit_permission_request_interface_init):
(webkitUserMediaPermissionRequestDispose):
(webkit_user_media_permission_get_media_types):
(webkitUserMediaPermissionRequestGetProperty):
(webkit_user_media_permission_request_class_init):
(webkitUserMediaPermissionRequestCreate):
- UIProcess/API/gtk/WebKitUserMediaPermissionRequest.h: Added.
- UIProcess/API/gtk/WebKitUserMediaPermissionRequestPrivate.h: Added.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Expose new API
in documentation.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
- UIProcess/API/gtk/webkit2.h: Expose UserMediaPermissionRequest API.
Tools:
The GTK version of the MiniBrowser has gained UserMedia permission
request support.
- MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
requires user permission to access audio/video devices.
(permissionRequestDialogCallback):
(webViewDecidePermissionRequest):
(geolocationRequestDialogCallback): Deleted.
- 10:05 AM Changeset in webkit [176951] by
-
- 6 edits in trunk
Add a stubbed out method for clearing out the website data store
https://bugs.webkit.org/show_bug.cgi?id=139404
Reviewed by Antti Koivisto.
Source/WebKit2:
Add stubbed out method that just calls the completion handler.
- UIProcess/API/Cocoa/_WKWebsiteDataStore.h:
- UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
(-[_WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:]):
Tools:
Add a debug menu item for testing clearing of website data.
- MiniBrowser/mac/MainMenu.xib:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController clearWebsiteData:]):
- 9:27 AM Changeset in webkit [176950] by
-
- 3 edits in trunk/LayoutTests
[EFL] Change expectations for two accessibility layout tests.
https://bugs.webkit.org/show_bug.cgi?id=139399
Unreviewed gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-12-08
- platform/efl/accessibility/roles-exposed-expected.txt:
- platform/efl/accessibility/table-sections-expected.txt:
- 8:57 AM Changeset in webkit [176949] by
-
- 7 edits in trunk/Source/WebCore
Remove ResourceHandle::loadsBlocked()
https://bugs.webkit.org/show_bug.cgi?id=139401
Reviewed by Daniel Bates.
This hasn't returned true since Leopard, so get rid of it.
- page/Chrome.cpp:
(WebCore::Chrome::canRunModalNow):
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::loadsBlocked): Deleted.
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::loadsBlocked): Deleted.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::loadsBlocked): Deleted.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::loadsBlocked): Deleted.
- 8:12 AM Changeset in webkit [176948] by
-
- 4 edits in trunk/Source/WebCore
AX: iOS: VoiceOver gets hung on some websites consistently.
https://bugs.webkit.org/show_bug.cgi?id=139331
Reviewed by Mario Sanchez Prada.
iFrames are attachments on iOS, but they do not have attachment views. As a result,
WebCore would return incorrect information for the element count and index of children elements.
No tests. Bug only manifests itself when iOS accessibility frameworks call into WebCore.
- accessibility/AccessibilityMockObject.h:
(WebCore::AccessibilityMockObject::isDetachedFromParent):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isDetachedFromParent):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper accessibilityContainer]):
- 4:59 AM Changeset in webkit [176947] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (173394): Support for webcam is broken
https://bugs.webkit.org/show_bug.cgi?id=139313
Reviewed by Alexey Proskuryakov.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
Don't buffer when handling multipart/x-mixed-replace. Multiple calls to didReceiveResponseAsync break assumptions.
- 4:09 AM Changeset in webkit [176946] by
-
- 2 edits4 moves in trunk/Source/WebKit2
[CoordinatedGraphics] Move CoordinatedBackingStore and CoordinatedGraphicsScene to Shared
https://bugs.webkit.org/show_bug.cgi?id=139385
Reviewed by Martin Robinson.
For the Threaded Compositor, CoordinatedBackingStore and
CoordinatedGraphicsScene should be placed at the Shared instead of
UIProcess because it can be used in the WebProcess also.
No new tests because there is no behavior change.
- PlatformEfl.cmake:
- Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp.
- Shared/CoordinatedGraphics/CoordinatedBackingStore.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h.
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.cpp.
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.h.
- 3:44 AM WebKitGTK/2.4.x edited by
- (diff)
- 3:34 AM Changeset in webkit [176945] by
-
- 2 edits in trunk/Source/WebCore
Webkit using Harfbuzz does not display Arabic script correctly
https://bugs.webkit.org/show_bug.cgi?id=136337
Patch by Doron Wloschowsky <doron_wloschowsky@scee.net> on 2014-12-08
Reviewed by Carlos Garcia Campos.
Using reinterpret_cast to convert hb_codepoint_t* into UChar*
doesn't work on big endian systems.
- platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
(WebCore::harfBuzzGetGlyph):
- 3:33 AM Changeset in webkit [176944] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[as] Updated Assamese translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=137487
Patch by Nilamdyuti Goswami <nilamdyuti@gmail.com> on 2014-12-08
Reviewed by Carlos Garcia Campos.
- as.po:
- 3:28 AM WebKitGTK/2.6.x edited by
- (diff)
- 1:34 AM Changeset in webkit [176943] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] Major cleanup of AudioDestination implementation
https://bugs.webkit.org/show_bug.cgi?id=139370
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
Add an audioresample element before the audio sink. The audio sink
might not be able to handle our sampling rate.
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::stop):
(WebCore::AudioDestinationGStreamer::finishBuildingPipelineAfterWavParserPadReady): Deleted.
Don't use a wavparse element but directly link the raw audio from
the source to the audio sink.
(WebCore::AudioDestinationGStreamer::start):
Catch errors when going to PLAYING early, we might not get an error
message.
- platform/audio/gstreamer/AudioDestinationGStreamer.h:
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(getGStreamerMonoAudioCaps):
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcChangeState):
Don't use a WAV encoder but directly output raw audio. Also don't
include a unneeded audioconvert element before the interleave.
(webKitWebAudioSrcLoop):
Add timestamps and durations to the output buffers, map them in
READWRITE mode and actually keep them mapped until we're sure
nothing is actually writing into them.
(webKitWebAudioSrcLoop):
Pause the task on errors instead of continuously calling it again
immediately.
- 1:28 AM Changeset in webkit [176942] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Use gst_message_parse_buffering()
https://bugs.webkit.org/show_bug.cgi?id=139365
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):
Use gst_message_parse_buffering() instead of manually getting
the percentage from the message's structure. While the latter
is supposed to work and part of the ABI stability guarantee,
it's just not nice and overly complicated.
- 1:26 AM Changeset in webkit [176941] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Minor cleanup of the AudioFileReader implementation
https://bugs.webkit.org/show_bug.cgi?id=139367
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::~AudioFileReader):
Don't call gst_bus_remove_signal_watch(), the source was already
destroyed together with the main context and doing it again here
will give a g_critical().
(WebCore::AudioFileReader::handleSample):
Calculate the number of samples from the actual buffer size
and the bytes-per-frame instead of the buffer duration. Using
the buffer duration can lead to rounding errors and might cause
too few samples to be copied over later.
(WebCore::AudioFileReader::handleMessage):
Set the pipeline to GST_STATE_NULL immediately when receiving
errors to prevent other follow-up error messages from propagating
through the bus and spamming the user's terminal with g_warnings().
(WebCore::AudioFileReader::handleNewDeinterleavePad):
Sync the state of the queue and sink after deinterleave with
the parent state instead of just setting them to READY. That
way we potentially go to PAUSED state a bit earlier already
and prevent a potential race condition that could cause buffers
to arrive in the new elements in READY state already (which would
fail).
(WebCore::AudioFileReader::plugDeinterleave):
Handle multiple decodebin source pads by ignoring all following
ones just in case there are multiple for whatever reason.
(WebCore::AudioFileReader::decodeAudioForBusCreation):
Catch errors from going to PAUSED state early. We might not
get a error message at all if we're unlucky.
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::createBus):
(WebCore::AudioFileReader::handleSample):
Downmix to mono if required instead of just using the front
left channel and claiming it is mono. Downmixing from stereo
to mono will mix both channels instead of just taking the left.
- 1:25 AM Changeset in webkit [176940] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Handle CLOCK_LOST and LATENCY messages
https://bugs.webkit.org/show_bug.cgi?id=139341
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
Handle CLOCK_LOST message by shortly going back to PAUSED state
and then to PLAYING again to let the pipeline select a new clock
for us.
This can happen if the stream that ends in a sink that provides
the current clock disappears, for example if the audio sink
provides the clock and the audio stream is disabled. It also
happens relatively often with HTTP adaptive streams when switching
between different variants of a stream.
Also handle the LATENCY message by triggering the default GStreamer
mechanism to update the latency. This can happen if the latency of
live elements changes, or for one reason or another a new live element
is added or removed from the pipeline.
- 1:23 AM Changeset in webkit [176939] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Use audio-filter property on GStreamer >= 1.4.2
https://bugs.webkit.org/show_bug.cgi?id=139360
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
Since 1.4.0 there is an audio-filter property we can use to place
the pitch-preserving filter at a more canonical position inside
the pipeline. Since 1.4.2 this property also handles all necessary
conversions for us.
This simplifies our sink code a bit because we don't have to create
a custom sink bin anymore.
- 1:22 AM Changeset in webkit [176938] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Add video/flv to the list of supported mimetypes
https://bugs.webkit.org/show_bug.cgi?id=139344
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Gustavo Noronha Silva.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
Add video/flv additional to video/x-flv to the list of supported
mimetypes. It's used on some websites, e.g.
http://www.jwplayer.com/html5/formats/
- 1:19 AM Changeset in webkit [176937] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Remove GStreamer 0.10 #ifdefs.
https://bugs.webkit.org/show_bug.cgi?id=138921
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::initializeGStreamer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::buffered):
Remove GStreamer 0.10 #ifdefs, we depend on >= 1.0.3 at least.
- 1:18 AM Changeset in webkit [176936] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Add application/x-mpegurl to the list of supported mimetypes.
https://bugs.webkit.org/show_bug.cgi?id=139343
Patch by Sebastian Dröge <sebastian@centricular.com> on 2014-12-08
Reviewed by Gustavo Noronha Silva.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache):
It's an alternative mimetype for the already supported
application/vnd.apple.mpegurl (aka HLS) and adding it
allows all streams on http://www.jwplayer.com/html5/hls/
to be played.
- 1:15 AM Changeset in webkit [176935] by
-
- 2 edits in trunk/Source/WebKit2
Fix build warning in WebKit2/UIProcess module.
https://bugs.webkit.org/show_bug.cgi?id=139386
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-12-08
Reviewed by Alexey Proskuryakov.
Fix build warning by removing unused parameter name from function
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):
Dec 7, 2014:
- 7:50 PM Changeset in webkit [176934] by
-
- 9 edits in trunk/Source/WebKit2
[CoordinatedGraphics] Change the namespace of CoordinatedBackingStore and CoordinatedGraphicsScene
https://bugs.webkit.org/show_bug.cgi?id=139372
Reviewed by Gyuyoung Kim.
CoordinatedBackingStore and CoordinatedGraphicsScene should be declared in the WebKit namespace
instead of WebCore namespace.
- UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:
- UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
- UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:
(WebKit::CoordinatedBackingStoreTile::CoordinatedBackingStoreTile):
(WebKit::CoordinatedBackingStore::rect):
(WebCore::CoordinatedBackingStoreTile::CoordinatedBackingStoreTile): Deleted.
(WebCore::CoordinatedBackingStore::rect): Deleted.
- UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
- UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.h:
(WebKit::CoordinatedGraphicsScene::setViewBackgroundColor):
(WebKit::CoordinatedGraphicsScene::viewBackgroundColor):
(WebKit::CoordinatedGraphicsScene::layerByID):
(WebKit::CoordinatedGraphicsScene::rootLayer):
(WebCore::CoordinatedGraphicsScene::setViewBackgroundColor): Deleted.
(WebCore::CoordinatedGraphicsScene::viewBackgroundColor): Deleted.
(WebCore::CoordinatedGraphicsScene::layerByID): Deleted.
(WebCore::CoordinatedGraphicsScene::rootLayer): Deleted.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(WebKit::CoordinatedLayerTreeHostProxy::coordinatedGraphicsScene):
- UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:
(WebKit::toImpl):
(WebKit::toAPI):
(toImpl): Deleted.
(toAPI): Deleted.
- UIProcess/CoordinatedGraphics/WebView.h:
- 3:25 PM Changeset in webkit [176933] by
-
- 5 edits in trunk/Source
Use more PassRef in AtomicString.
<https://webkit.org/b/139319>
Reviewed by Antti Koivisto.
Make a pass over AtomicString and convert functions that return PassRefPtr
into returning RefPtr (where it may be null) and PassRef otherwise.
This allows the compiler to skip null checks in many places.
- wtf/text/AtomicString.cpp:
(WTF::addToStringTable):
(WTF::AtomicString::add):
(WTF::AtomicString::addFromLiteralData):
(WTF::AtomicString::addSlowCase):
- wtf/text/AtomicString.h:
(WTF::AtomicString::add):
(WTF::AtomicString::addWithStringTableProvider):
- wtf/text/cf/AtomicStringCF.cpp:
(WTF::AtomicString::add):
- 2:25 PM Changeset in webkit [176932] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove the unused WTF_USE_GCC_COMPUTED_GOTO_WORKAROUND after r129453.
https://bugs.webkit.org/show_bug.cgi?id=139373
Reviewed by Sam Weinig.
- interpreter/Interpreter.cpp:
- 2:00 PM Changeset in webkit [176931] by
-
- 2 edits in trunk/Source/WebCore
[TextureMapper] Normalize pattern transform for pattern compositing
https://bugs.webkit.org/show_bug.cgi?id=139374
Reviewed by Martin Robinson.
In CoordGfx/TexMapGL, pattern compositing (for background image) uses
the patternTransform shader uniform. However, current implementation
miscalculates its transform matrix. It uses simple rectToRect
transformationMatrix which produces unnormalized garbage term.
This causes unexpected behavior at the fragmentation stage in some
mobile GPUs.
It should calculate its scale based on tileSize and contentSize,
and its position based on tilePhase and contentSize.
No new tests because the bug only occurs on some mobile GPUs.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computePatternTransformIfNeeded):
- 12:05 PM Changeset in webkit [176930] by
-
- 6 edits4 adds2 deletes in trunk
[Soup][Curl] HTTP header values should be treated as latin1, not UTF-8
https://bugs.webkit.org/show_bug.cgi?id=128739
Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-12-07
Reviewed by Martin Robinson.
Source/WebCore:
Removed UTF-8 conversion of HTTP header values (SOUP and CURL).
Removed unnecessary UTF-8 conversion of HTTP header names (SOUP).
Changed conversion of HTTP method from UTF-8 to ASCII (SOUP and CURL).
Added explicit UTF-8 conversion of Content-Disposition header to compute download suggested filename.
Test: http/tests/xmlhttprequest/response-special-characters.html
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::headerCallback): Removed header conversion.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::headerCallback): Ditto.
(WebCore::ResourceHandleManager::initializeHandle): Changed HTTP method conversion to ASCI.
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateFromSoupMessageHeaders): Removed header conversion.
(WebCore::ResourceRequest::updateSoupMessage): Changed HTTP method conversion to ASCII.
(WebCore::ResourceRequest::toSoupMessage): Ditto.
(WebCore::ResourceRequest::updateFromSoupMessage):
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessageHeaders): Rmoved header conversion.
(WebCore::ResourceResponse::platformSuggestedFilename): Added explicit conversion of contentDisposition to UTF-8.
LayoutTests:
Tests that non ascii header & reason phrase values are correctly retrieved by the web application.
headers.php script sends a response that includes non ascii header value.
not-ascii-status.php sends a response that includes non ascii reason phrase.
Removed specific gtk/efl expectations as now aligned with regular expectation.
- http/tests/xmlhttprequest/resources/headers.php: Added.
- http/tests/xmlhttprequest/resources/not-ascii-status.php: Added.
- http/tests/xmlhttprequest/response-special-characters-expected.txt: Added.
- http/tests/xmlhttprequest/response-special-characters.html: Added.
- platform/efl/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Removed.
- 11:58 AM Changeset in webkit [176929] by
-
- 3 edits in trunk/Tools
Update style checker to deal with "const override"
https://bugs.webkit.org/show_bug.cgi?id=139371
Reviewed by Csaba Osztrogonác.
check-webkit-style shouldn't complain about an open brace to start a
line after a function definition with const override.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_braces):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_brace_at_begin_of_line):
- 11:24 AM Changeset in webkit [176928] by
-
- 2 edits in trunk
[GTK] WebKit has a new required dependency on GnuTLS
https://bugs.webkit.org/show_bug.cgi?id=136158
Reviewed by Martin Robinson.
Detect if GnuTLS is installed and enable or disable subtle crypto
support accordingly.
- Source/cmake/OptionsGTK.cmake:
- 10:57 AM Changeset in webkit [176927] by
-
- 1 edit1 move in trunk/LayoutTests
fast/borders/mixed-border-style2.html has missing results on Mac Yosemite.
Looking at the bots, Yosemite results are the same as Mavericks, so moving the file.
- platform/mac-mavericks/fast/borders/mixed-border-style2-expected.txt: Removed.
- platform/mac/fast/borders/mixed-border-style2-expected.txt: Copied from LayoutTests/platform/mac-mavericks/fast/borders/mixed-border-style2-expected.txt.
- 10:53 AM Changeset in webkit [176926] by
-
- 2 edits1 delete in trunk/LayoutTests
Remove platform/mac-mavericks/TestExpectations file.
We don't need it, we should be using modifiers such as [ Mavericks ].
- platform/mac/editing/input/undo-grouping-on-text-insertion.html was already
skipped on all OS versions in platform/mac, so this skip did nothing.
- Moved css3/filters/backdrop expectation to platform/mac.
- css3/viewport-percentage-lengths tests are now fixed by a configuration change
on a bot.
- platform/mac-mavericks/TestExpectations: Removed.
- platform/mac/TestExpectations:
- 10:11 AM Changeset in webkit [176925] by
-
- 2 edits in trunk/Tools
[GTK] Fix GObject DOM bindings API break tests after r176920
https://bugs.webkit.org/show_bug.cgi?id=139368
Reviewed by Gustavo Noronha Silva.
Remove the @version from the symbol name before comparing.
- gtk/check-for-webkitdom-api-breaks:
(read_expected_api):
- 10:08 AM WebKitGTK/2.4.x edited by
- (diff)
- 9:28 AM Changeset in webkit [176924] by
-
- 34 edits in trunk/Source
Introduce and deploy a function that allocates and returns an instance of a soft-linked class
https://bugs.webkit.org/show_bug.cgi?id=139348
Reviewed by Anders Carlsson.
In [[getFooClass() alloc] init*], the type of the result of +alloc is id, so the compiler
picks an arbitrary declaration of init*, not necessarily the Foo one. This can then lead
to warnings or errors if the types or attributes don’t match, or to runtime errors if Foo
doesn’t even have the expected initializer. The new allocFooInstance() returns a Foo *, thus
avoiding the ambiguity.
Source/WebCore:
- editing/mac/DataDetection.mm:
(WebCore::DataDetection::detectItemAroundHitTestResult):
- platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper allocateVolumeView]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):
- platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::createMix):
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::abort):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::PlatformCALayerMac): Cast the result of +alloc to an instance of the
expected class.
- platform/graphics/mac/FontMac.mm:
(WebCore::showLetterpressedGlyphsWithAdvances):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
- platform/graphics/mac/PDFDocumentImageMac.mm:
(WebCore::PDFDocumentImage::createPDFDocument):
- platform/ios/PlatformSpeechSynthesizerIOS.mm:
(SOFT_LINK_CONSTANT):
(-[WebSpeechSynthesisWrapper speakUtterance:]):
- platform/ios/WebCoreMotionManager.mm:
(-[WebCoreMotionManager initializeOnMainThread]):
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController init]):
(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
- platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::ContentFilter):
- platform/mac/SoftLinking.h: Added alloc##className##instance().
- platform/mac/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController setVideoElement:]):
- platform/mediastream/mac/AVAudioCaptureSource.mm:
(WebCore::AVAudioCaptureSource::setupCaptureSession):
- platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::AVCaptureDeviceManager::verifyConstraintsForMediaType):
- platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::setupSession):
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setupCaptureSession):
- platform/network/ios/QuickLook.mm:
(WebCore::registerQLPreviewConverterIfNeeded):
(WebCore::QuickLookHandle::QuickLookHandle):
Source/WebKit/ios:
- Misc/WebGeolocationCoreLocationProvider.mm:
(-[WebGeolocationCoreLocationProvider createLocationManager]):
Source/WebKit/mac:
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
Source/WebKit2:
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]):
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]):
(-[WKAirPlayRoutePicker show:fromRect:]):
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[_WKVideoFileUploadItem displayImage]):
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForDataDetectableLink]):
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::clone):
- 8:23 AM Changeset in webkit [176923] by
-
- 2 edits in trunk/Tools
Remove the option to automatically update the GObject DOM bindings symbols file
https://bugs.webkit.org/show_bug.cgi?id=139366
Reviewed by Martin Robinson.
It's currently broken, because symbols now need to be in a
specific order. Now that the symbols file only contains stable
API, it's not a problem to manually update it every time new API
is added.
- gtk/check-for-webkitdom-api-breaks:
(read_expected_api):
(check_api):
(write_expected_api): Deleted.
- 8:19 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 8:11 AM Changeset in webkit [176922] by
-
- 2 edits4 adds in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Report and mark new failures.
- platform/gtk/svg/animations/animate-marker-orienttype-1-expected.txt: Added. Rebaseline after r175525.
- platform/gtk/svg/animations/animate-marker-orienttype-2-expected.txt: Added. Rebaseline after r175525.
- platform/gtk/svg/animations/animate-marker-orienttype-3-expected.txt: Added. Rebaseline after r175525.
- 6:08 AM Changeset in webkit [176921] by
-
- 4 edits in trunk/Tools
[GTK] Use GMainLoopSource in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=138831
Reviewed by Sergio Villar Senin.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::waitToDumpWatchdogTimerCallback): Deleted.
- WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::notifyDone):
(WTR::TestController::platformRunUntil):
(WTR::cancelTimeout): Deleted.
- 5:40 AM Changeset in webkit [176920] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Add Since tags to GObject DOM bindings documentation
https://bugs.webkit.org/show_bug.cgi?id=139356
Reviewed by Gustavo Noronha Silva.
Now that we have a small stable API, and new symbols are added
manually, we can also add the version to the symbols file, that
the code generator can ue to add Since tags to the gtk-doc.
- bindings/gobject/webkitdom.symbols: Add @2.8 to the new symbols
added for 2.8.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateConstants): Add Since tag to gtk-doc if there's a version
number for the symbol in the .symbols file.
(GenerateFunction): Ditto.
(ReadStableSymbols):
- 4:00 AM WebKitGTK/2.6.x edited by
- (diff)
- 3:39 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:02 AM Changeset in webkit [176919] by
-
- 9 edits3 adds in trunk
[GTK] Missing API detected in GObject DOM bindings after r176630
https://bugs.webkit.org/show_bug.cgi?id=139201
Reviewed by Gustavo Noronha Silva.
.:
Change GENERATE_BINDINGS macro to receive a list of optional
additional dependencies, so that we can add more dependecies
without having to change the macro.
- Source/cmake/WebKitMacros.cmake:
Source/WebCore:
Bring back WebKitDOMDeprecated and add custom versions of the
removed symbols as deprecated in favor of the new ones. Also add
the new ones as stable API.
- CMakeLists.txt: Pass a list of additional dependencies to GENERATE_BINDINGS.
- PlatformGTK.cmake: Ditto.
- PlatformMac.cmake: Ditto.
- bindings/gobject/WebKitDOMDeprecated.cpp: Added.
(webkit_dom_html_element_get_inner_html):
(webkit_dom_html_element_set_inner_html):
(webkit_dom_html_element_get_outer_html):
(webkit_dom_html_element_set_outer_html):
- bindings/gobject/WebKitDOMDeprecated.h: Added.
- bindings/gobject/WebKitDOMDeprecated.symbols: Added.
- bindings/gobject/webkitdom.symbols:
Tools:
Handle deprecated symbols again when generating the GObject DOM
bindings documentation.
- gtk/webkitdom.py:
(WebKitDOMDocGenerator):
(WebKitDOMDocGenerator.is_deprecated_symbol_file):
(WebKitDOMDocGenerator.generate):
(WebKitDOMDocGeneratorSections.init):
(WebKitDOMDocGeneratorSections._find_deprecated_symbols):
(WebKitDOMDocGeneratorSections.write_section):
- 1:17 AM Changeset in webkit [176918] by
-
- 2 edits2 adds in trunk/Tools
[EFL][jhbuild] Fix libsoup build with clang
https://bugs.webkit.org/show_bug.cgi?id=139088
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- efl/patches/soup-clang-warning-fix1.patch: Added.
- efl/patches/soup-clang-warning-fix2.patch: Added.
- 1:15 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
Dec 6, 2014:
- 3:52 PM Changeset in webkit [176917] by
-
- 2 edits in trunk/Tools
[Mac] DumpRenderTree sets storage directory incorrectly
https://bugs.webkit.org/show_bug.cgi?id=139347
Reviewed by Dan Bernstein.
- DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
Don't use user defaults to pass per-instance paths, as user defaults are shared
across all instances.
- 3:35 PM Changeset in webkit [176916] by
-
- 3 edits in trunk/Source/WebCore
URTBF after r176915.
DisplayRefreshMonitorClient is the parent class of GraphicsLayerUpdater
only if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is true, so override
is incorrect if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is false.
That's why r176915 broke the build on non PLATFORM(COCOA) platforms,
such as GTK, EFL, Apple Windows.
Additionally displayRefreshFired is only used inside USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
guard, so there is no reason to define it for non COCOA platforms.
- platform/graphics/GraphicsLayerUpdater.cpp:
- platform/graphics/GraphicsLayerUpdater.h:
- 1:44 PM Changeset in webkit [176915] by
-
- 33 edits in trunk/Source
Fix build with newer versions of clang.
rdar://problem/18978733
Source/WebCore:
Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingStateFixedNode.h:
- page/scrolling/ScrollingStateFrameScrollingNode.h:
- page/scrolling/ScrollingStateOverflowScrollingNode.h:
- page/scrolling/ScrollingStateStickyNode.h:
- page/scrolling/ScrollingTreeFrameScrollingNode.h:
(WebCore::ScrollingTreeFrameScrollingNode::updateLayersAfterDelegatedScroll): Deleted.
- page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
- platform/graphics/GraphicsLayerUpdater.h:
- platform/mac/ScrollbarThemeMac.h:
(WebCore::ScrollbarThemeMac::supportsControlTints): Deleted.
(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): Deleted.
- rendering/RenderLayerCompositor.h:
- rendering/RenderSnapshottedPlugIn.h:
Source/WebKit2:
Add missing overrides and casts.
- NetworkProcess/NetworkProcess.h:
- Shared/Downloads/DownloadAuthenticationClient.h:
(WebKit::DownloadAuthenticationClient::refAuthenticationClient): Deleted.
(WebKit::DownloadAuthenticationClient::derefAuthenticationClient): Deleted.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration copyWithZone:]):
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterViewportChange): Deleted.
- UIProcess/WebPageProxy.h:
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork): Deleted.
(WebKit::WebContentProcessMainDelegate::getConnectionIdentifier): Deleted.
(WebKit::WebContentProcessMainDelegate::getClientIdentifier): Deleted.
(WebKit::WebContentProcessMainDelegate::getClientProcessName): Deleted.
- WebProcess/IconDatabase/WebIconDatabaseProxy.h:
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::initialize):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebBackForwardListProxy.h:
- WebProcess/WebPage/WebInspector.h:
(WebKit::WebInspector::didClose): Deleted.
(WebKit::WebInspector::didReceiveInvalidMessage): Deleted.
- WebProcess/WebPage/WebInspectorUI.h:
(WebKit::WebInspectorUI::didClose): Deleted.
(WebKit::WebInspectorUI::didReceiveInvalidMessage): Deleted.
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
- WebProcess/WebProcess.h:
- WebProcess/ios/WebVideoFullscreenManager.h:
- 1:43 PM Changeset in webkit [176914] by
-
- 2 edits in trunk/Source/WebKit2
Only include TUCallSPI on Mac.
- Platform/mac/MenuUtilities.mm:
- 1:27 PM Changeset in webkit [176913] by
-
- 9 edits2 copies1 add in trunk/Source
Add a stubbed out version of WebStorageNamespaceProvider
https://bugs.webkit.org/show_bug.cgi?id=139213
Reviewed by Sam Weinig.
Source/WebKit:
- Storage/WebStorageNamespaceProvider.cpp: Added.
- Storage/WebStorageNamespaceProvider.h: Added.
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
- WebKit.xcodeproj/project.pbxproj:
Add new files.
Source/WebKit/mac:
- WebCoreSupport/WebViewGroup.h:
(WebViewGroup::storageNamespaceProvider):
- WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::getOrCreate):
(WebViewGroup::WebViewGroup):
Give WebViewGroup a storage namespace provider.
- 1:23 PM Changeset in webkit [176912] by
-
- 21 edits in trunk/Source
Fix build with newer versions of clang.
rdar://problem/18978687
Source/WebCore:
Add a bunch of overrides since we're not disabling the "inconsistent missing override" warning in WebKit.
- html/HTMLElement.h:
- html/HTMLMediaElement.h:
- html/track/VTTCue.h:
- loader/FrameNetworkingContext.h:
(WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Deleted.
- loader/cache/CachedImage.h:
- page/SuspendableTimer.h:
- platform/Scrollbar.h:
- platform/graphics/InbandTextTrackPrivate.h:
- rendering/RenderBlockFlow.h:
Source/WebKit/ios:
Cast the result of +alloc to the right type.
- Misc/WebGeolocationCoreLocationProvider.mm:
(-[WebGeolocationCoreLocationProvider createLocationManager]):
- WebCoreSupport/WebSelectionRect.m:
(+[WebSelectionRect selectionRect]):
Source/WebKit/mac:
Add missing overrides and missing casts.
- Storage/WebDatabaseManagerClient.h:
- Storage/WebStorageTrackerClient.h:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebInspectorClient.h:
- WebView/WebDataSource.mm:
(-[WebDataSource _makeRepresentation]):
- WebView/WebFrameView.mm:
(-[WebFrameView _makeDocumentViewForDataSource:]):
- 1:10 PM Changeset in webkit [176911] by
-
- 2 edits in trunk/Source/WebCore
Follow-up build fix.
- Configurations/Base.xcconfig:
- 1:04 PM Changeset in webkit [176910] by
-
- 11 edits in trunk/Source/WebCore
Fix build with newer versions of clang.
rdar://problem/18978689
Disable the "inconsistent missing override" warning due to our use of macros in SVG where it's hard to
know whether we can add an override or not.
Also, cast return values of +alloc to the right type, and add some casts for vector iterator arithmetic.
- Configurations/Base.xcconfig:
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::guidForOriginAndName):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):
- editing/cocoa/HTMLConverter.mm:
(_shadowForShadowStyle):
(HTMLConverter::_addTableForElement):
- platform/graphics/SVGGlyph.cpp:
(WebCore::isCompatibleArabicForm):
- platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::createMix):
- platform/graphics/mac/FontMac.mm:
(WebCore::showLetterpressedGlyphsWithAdvances):
- platform/ios/PlatformSpeechSynthesizerIOS.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:]):
- platform/ios/WebCoreMotionManager.mm:
(-[WebCoreMotionManager initializeOnMainThread]):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::spannedRows):
(WebCore::RenderTableSection::spannedColumns):
- 1:04 PM Changeset in webkit [176909] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build with newer versions of clang.
rdar://problem/18978716
- ftl/FTLJITCode.h:
Add missing overrides.
- 11:36 AM Changeset in webkit [176908] by
-
- 2 edits in trunk/LayoutTests
Skipping tests due to regression in r176902.
<https://webkit.org/b/139014>
Not reviewed.
- 10:26 AM Changeset in webkit [176907] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error, missing guard.
https://bugs.webkit.org/show_bug.cgi?id=139338
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-06
Reviewed by Alex Christensen.
There is missing a ENABLE(CSS_SELECTORS_LEVEL4) guard in CSSParser.cpp.
- css/CSSParser.cpp:
(WebCore::CSSParser::realLex):
- 3:50 AM Changeset in webkit [176906] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r176905.
https://bugs.webkit.org/show_bug.cgi?id=139337
the test case is failing in bots (Requested by anttik on
#webkit).
Reverted changeset:
"REGRESSION (173394): Support for webcam is broken"
https://bugs.webkit.org/show_bug.cgi?id=139313
http://trac.webkit.org/changeset/176905
- 2:39 AM Changeset in webkit [176905] by
-
- 3 edits2 adds in trunk
REGRESSION (173394): Support for webcam is broken
https://bugs.webkit.org/show_bug.cgi?id=139313
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
Don't buffer when handling multipart/x-mixed-replace. Multiple calls to didReceiveResponseAsync break assumptions.
LayoutTests:
We had no coverage for actually rendering multipart content.
- http/tests/multipart/multipart-image-expected.html: Added.
- http/tests/multipart/multipart-image.html: Added.
Dec 5, 2014:
- 9:44 PM Changeset in webkit [176904] by
-
- 10 edits3 adds in trunk
AX: I cannot activate links on the mobile version of news.google.com
https://bugs.webkit.org/show_bug.cgi?id=139330
Reviewed by Simon Fraser.
Source/WebCore:
This website only listens for touch events. VoiceOver normally dispatches click and mouse events,
so on iOS this falls and VoiceOver is not able to activate anything.
The solution here is to dispatch simulated touch down/up events.
Test: platform/ios-simulator/ios-accessibility/press-fires-touch-events.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
(WebCore::AccessibilityObject::dispatchTouchEvent):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isDetachedFromParent):
- page/EventHandler.h:
- page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::dispatchSimulatedTouchEvent):
- platform/ios/PlatformEventFactoryIOS.h:
- platform/ios/PlatformEventFactoryIOS.mm:
(WebCore::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
(WebCore::PlatformEventFactory::createPlatformSimulatedTouchEvent):
Tools:
Implement press for iOS.
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::press):
LayoutTests:
- platform/ios-simulator/ios-accessibility: Added.
- platform/ios-simulator/ios-accessibility/press-fires-touch-events-expected.txt: Added.
- platform/ios-simulator/ios-accessibility/press-fires-touch-events.html: Added.
- 9:14 PM Changeset in webkit [176903] by
-
- 3 edits2 adds in trunk
Directional single quotation marks are not rotated in vertical text
https://bugs.webkit.org/show_bug.cgi?id=138526
Source/WebCore:
Reviewed by Darin Adler.
In vertical text, directional single quotation marks are not rotated along with
the rest of the letters.
Test: fast/text/vertical-quotation-marks.html
- platform/graphics/FontGlyphs.cpp:
(WebCore::shouldIgnoreRotation):
LayoutTests:
Compare vertical and horizontal renderings.
Reviewed by Darin Adler.
- fast/text/vertical-quotation-marks-expected.html: Added.
- fast/text/vertical-quotation-marks.html: Added.
- 9:09 PM Changeset in webkit [176902] by
-
- 6 edits2 adds in trunk
Implement parser for :lang pseudo class selector arguments that contain wildcard '*' subtags
https://bugs.webkit.org/show_bug.cgi?id=139014
Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-12-05
Reviewed by Benjamin Poulain.
Source/WebCore:
Consider each language range in :lang() that consists of an asterisk
immediately followed by an identifier beginning with an ASCII hyphen
as a valid input for the selector as specified in [1].
[1] http://dev.w3.org/csswg/selectors4/#the-lang-pseudo
Test: fast/css/parsing-css-lang.html
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::realLex):
LayoutTests:
- fast/css/css-selector-text-expected.txt: Updated for asterisk containing input.
- fast/css/css-selector-text.html: Updated for asterisk containing input.
- fast/css/parsing-css-lang-expected.txt: Added.
- fast/css/parsing-css-lang.html: Added.
- 6:04 PM Changeset in webkit [176901] by
-
- 3 edits in trunk/Source/WebKit2
Add a delegate method for didReceiveServerRedirectForProvisionalLoadForFrame.
https://bugs.webkit.org/show_bug.cgi?id=139325
Add delegate method webProcessPlugInBrowserContextController:didReceiveServerRedirectForProvisionalLoadForFrame: into
WKWebProcessPlugInLoadDelegate to listen to server side redirect in injected bundle.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-12-05
Reviewed by Dan Bernstein.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didReceiveServerRedirectForProvisionalLoadForFrame):
(setUpPageLoaderClient):
- 5:29 PM Changeset in webkit [176900] by
-
- 1 copy in tags/Safari-600.2.5
New tag.
- 5:25 PM Changeset in webkit [176899] by
-
- 4 edits1 add in trunk
Programmatic scrolling and content changes are not always synchronized
https://bugs.webkit.org/show_bug.cgi?id=139245
rdar://problem/18833612
Reviewed by Anders Carlsson.
Manual test that tries to sync layout with programmatic scrolling.
- ManualTests/programmatic-scroll-flicker.html: Added.
Source/WebCore:
For programmatic scrolls, AsyncScrollingCoordinator::requestScrollPositionUpdate()
calls updateScrollPositionAfterAsyncScroll(), then dispatches the requested
scroll position to the scrolling thread.
Once the scrolling thread commits, it calls back to the main thread via
scheduleUpdateScrollPositionAfterAsyncScroll(), which schedules a second
call to updateScrollPositionAfterAsyncScroll() on a timer. That's a problem,
because some other scroll may have happened in the meantime; when the timer
fires, it can sometimes restore a stale scroll position.
Fix by bailing early from scheduleUpdateScrollPositionAfterAsyncScroll()
for programmatic scrolls, since we know that requestScrollPositionUpdate()
already did the updateScrollPositionAfterAsyncScroll().
Test:
ManualTests/programmatic-scroll-flicker.html
- page/FrameView.cpp:
(WebCore::FrameView::reset): nullptr.
(WebCore::FrameView::setScrollPosition): Ditto.
(WebCore::FrameView::setWasScrolledByUser): Ditto.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate): Use a local variable for
isProgrammaticScroll just to make sure we use the same value for the duration of this function.
(WebCore::AsyncScrollingCoordinator::scheduleUpdateScrollPositionAfterAsyncScroll): Do nothing
if this is a programmatic scroll.
- 5:20 PM Changeset in webkit [176898] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- platform/spi/mac/TUCallSPI.h:
- 5:09 PM Changeset in webkit [176897] by
-
- 2 edits in trunk/Tools
[iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
https://bugs.webkit.org/show_bug.cgi?id=139326
Reviewed by Anders Carlsson.
Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
using the same scale factor as used in WebKit.
- DumpRenderTree/ios/PixelDumpSupportIOS.mm:
(createBitmapContextFromWebView):
- 5:09 PM Changeset in webkit [176896] by
-
- 8 edits in trunk/Source
[Win] proj files copying over too many resources..
https://bugs.webkit.org/show_bug.cgi?id=139315.
<rdar://problem/19148278>
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.proj: Don't copy over bin32 build output.
- WebKit.vcxproj/WebKit.proj: Only copy resource folders and WebKit.dll.
- JavaScriptCore.vcxproj/JavaScriptCore.proj: Only copy resource folders and JavaScriptCore.dll.
- WTF.vcxproj/WTF.proj: Only copy WTF.dll.
- 5:07 PM Changeset in webkit [176895] by
-
- 1 edit1 add in trunk/Source/WebCore
Use the system string for telephone number menu
https://bugs.webkit.org/show_bug.cgi?id=139324
<rdar://problem/18726471>
- platform/spi/mac/TUCallSPI.h: Added.
Actually add the SPI header from the last commit.
- 5:01 PM Changeset in webkit [176894] by
-
- 4 edits in trunk/Source
Use the system string for telephone number menu
https://bugs.webkit.org/show_bug.cgi?id=139324
<rdar://problem/18726471>
Reviewed by Anders Carlsson.
- Platform/mac/MenuUtilities.mm:
(WebKit::menuItemTitleForTelephoneNumberGroup):
Make use of the SPI to retrieve the string if it exists.
- WebCore.xcodeproj/project.pbxproj:
- platform/spi/mac/TUCallSPI.h: Added.
Add an SPI header.
- 4:42 PM Changeset in webkit [176893] by
-
- 3 edits in trunk/Source/WebKit2
URTBF, EFL is happy now.
- UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::defaultDataStoreConfiguration):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::createNonPersistent):
- 4:33 PM Changeset in webkit [176892] by
-
- 85 edits in trunk/Source/WebKit/win
Get rid of config.h includes and include config.h in the prefix header instead
https://bugs.webkit.org/show_bug.cgi?id=139323
Reviewed by Brent Fulgham.
This is making it easier to share code between WebKit1 for Mac and WebKit1 for Windows.
- AccessibleBase.cpp:
- AccessibleDocument.cpp:
- AccessibleImage.cpp:
- AccessibleTextImpl.cpp:
- CFDictionaryPropertyBag.cpp:
- DOMCSSClasses.cpp:
- DOMCoreClasses.cpp:
- DOMEventsClasses.cpp:
- DOMHTMLClasses.cpp:
- DefaultDownloadDelegate.cpp:
- DefaultPolicyDelegate.cpp:
- ForEachCoClass.cpp:
- FullscreenVideoController.cpp:
- MarshallingHelpers.cpp:
- MemoryStream.cpp:
- WebActionPropertyBag.cpp:
- WebArchive.cpp:
- WebBackForwardList.cpp:
- WebCache.cpp:
- WebCoreStatistics.cpp:
- WebCoreSupport/AcceleratedCompositingContext.cpp:
- WebCoreSupport/EmbeddedWidget.cpp:
- WebCoreSupport/WebChromeClient.cpp:
- WebCoreSupport/WebContextMenuClient.cpp:
- WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
- WebCoreSupport/WebDragClient.cpp:
- WebCoreSupport/WebEditorClient.cpp:
- WebCoreSupport/WebFrameLoaderClient.cpp:
- WebCoreSupport/WebFrameNetworkingContext.cpp:
- WebCoreSupport/WebGeolocationClient.cpp:
- WebCoreSupport/WebInspectorClient.cpp:
- WebCoreSupport/WebInspectorDelegate.cpp:
- WebCoreSupport/WebPlatformStrategies.cpp:
- WebCoreSupport/WebVisitedLinkStore.cpp:
- WebDataSource.cpp:
- WebDatabaseManager.cpp:
- WebDocumentLoader.cpp:
- WebDownload.cpp:
- WebDownloadCFNet.cpp:
- WebDownloadCurl.cpp:
- WebDropSource.cpp:
- WebElementPropertyBag.cpp:
- WebError.cpp:
- WebFrame.cpp:
- WebFramePolicyListener.cpp:
- WebGeolocationPolicyListener.cpp:
- WebGeolocationPosition.cpp:
- WebHTMLRepresentation.cpp:
- WebHistory.cpp:
- WebHistoryItem.cpp:
- WebIconDatabase.cpp:
- WebInspector.cpp:
- WebJavaScriptCollector.cpp:
- WebKitCOMAPI.cpp:
- WebKitClassFactory.cpp:
- WebKitDLL.cpp:
- WebKitGraphics.cpp:
- WebKitLogging.cpp:
- WebKitPrefix.h:
- WebKitStatistics.cpp:
- WebKitSystemBits.cpp:
- WebLocalizableStrings.cpp:
- WebMutableURLRequest.cpp:
- WebNavigationData.cpp:
- WebNodeHighlight.cpp:
- WebNotification.cpp:
- WebNotificationCenter.cpp:
- WebPreferences.cpp:
- WebResource.cpp:
- WebScriptObject.cpp:
- WebScriptWorld.cpp:
- WebSecurityOrigin.cpp:
- WebSerializedJSValue.cpp:
- WebTextRenderer.cpp:
- WebURLAuthenticationChallenge.cpp:
- WebURLAuthenticationChallengeSender.cpp:
- WebURLAuthenticationChallengeSenderCFNet.cpp:
- WebURLAuthenticationChallengeSenderCurl.cpp:
- WebURLCredential.cpp:
- WebURLProtectionSpace.cpp:
- WebURLResponse.cpp:
- WebUserContentURLPattern.cpp:
- WebView.cpp:
- WebWorkersPrivate.cpp:
- 4:31 PM Changeset in webkit [176891] by
-
- 2 edits in trunk/Source/WebKit2
Gardening: one more build fix for GTK builds.
- CMakeLists.txt:
- 4:29 PM Changeset in webkit [176890] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC][FTL] Add the data layout to the module and fix the pass order.
https://bugs.webkit.org/show_bug.cgi?id=138748
Patch by Juergen Ributzka <juergen@apple.com> on 2014-12-05
Reviewed by Oliver Hunt.
This adds the data layout to the module, so it can be used by all
optimization passes in the LLVM optimizer pipeline. This also allows
FastISel to select more instructions, because less non-legal types are
generated.
Also fix the order of the alias analysis passes in the optimization
pipeline.
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- 4:28 PM Changeset in webkit [176889] by
-
- 2 edits in trunk/Source/WebKit2
URTBF, remove duplicated entry due to parallel buildfixing.
- CMakeLists.txt:
- 4:26 PM Changeset in webkit [176888] by
-
- 5 edits in branches/safari-600.2-branch/Source
Versioning.
- 4:25 PM Changeset in webkit [176887] by
-
- 2 edits in trunk/Source/WebKit2
URTBF after r176849.
- CMakeLists.txt: Added WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp.
- 4:20 PM Changeset in webkit [176886] by
-
- 2 edits in trunk/Source/WebKit2
Gardening: another build fix for GTK builds.
- CMakeLists.txt:
- 4:16 PM Changeset in webkit [176885] by
-
- 2 edits in trunk/Tools
REGRESSION (r176677): All tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=139321
Reviewed by Alexey Proskuryakov.
- DumpRenderTree/win/DumpRenderTree.cpp:
(runTest):
Don't call CFRelease on the url while we have an outstanding pointer to its string,
and use the right number of bytes when allocating the testURL buffer.
- 4:10 PM Changeset in webkit [176884] by
-
- 2 edits in trunk/Source/WebKit2
Gardening: more speculative build fix for GTK builds.
- CMakeLists.txt:
- 3:59 PM Changeset in webkit [176883] by
-
- 3 edits in trunk/Source/WebKit2
If the action menu hit test times out, a menu with a single separator appears
https://bugs.webkit.org/show_bug.cgi?id=139320
<rdar://problem/19158331>
Reviewed by Beth Dakin.
- UIProcess/mac/WKActionMenuController.h:
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController menuNeedsUpdate:]):
(-[WKActionMenuController _defaultMenuItems]):
Add a new "TimedOut" state, which we get into if the sync wait for
didPerformActionMenuHitTest times out. In this case, we'll drop the
separator item and give up on the menu. This way, the menu will never
have just a single separator item at the end of menuNeedsUpdate:.
- 3:56 PM Changeset in webkit [176882] by
-
- 1 copy in tags/Safari-600.2.4
New tag.
- 3:54 PM Changeset in webkit [176881] by
-
- 2 edits in trunk/Source/WebKit2
Gardening: speculative build fix for GTK builds.
- CMakeLists.txt:
- 3:33 PM Changeset in webkit [176880] by
-
- 3 edits in trunk/Tools
[iOS] DumpRenderTree produces many reference test mismatches
https://bugs.webkit.org/show_bug.cgi?id=139314
Reviewed by Simon Fraser.
Fixes an issue where the scale factor used to render the snapshot taken by
DumpRenderTree may differ from the device scale factor. In particular, the
scale factor used to render a snapshot of a test may differ from the scale
factor used to render the snapshot of its expected result.
Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
snapshot the UIWebBrowserView. This SPI always render using a scale factor
of one when the backing store for the LegacyTileLayer objects were out-of-
date regardless of the device scale factor. Instead we should use UIImage
and CALayer API to perform the snapshot with respect to the device scale
factor.
Additionally write iOS pixel dump support logic in terms of existing
DumpRenderTree abstractions so as to support generating and comparing
pixel dump checksums as well as make the iOS code more consistent with
the logic used by other ports.
- DumpRenderTree/PixelDumpSupport.cpp:
(dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
- DumpRenderTree/ios/PixelDumpSupportIOS.mm:
(BitmapContext::createFromUIImage): Added.
(BitmapContext::pixelData): Added.
(BitmapContext::BitmapContext): Added.
(computeMD5HashStringForBitmapContext): Added.
(dumpBitmap): Added.
(createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
(dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
- 3:25 PM Changeset in webkit [176879] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Return absolute value of error code from CDMSessionMediaSourceAVFObjC::update().
https://bugs.webkit.org/show_bug.cgi?id=139316
Reviewed by Eric Carlson.
Similarly to our asynchronous error reporting, return the absolute value of the error code.
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::systemCodeForError):
(WebCore::CDMSessionMediaSourceAVFObjC::update):
- 3:11 PM Changeset in webkit [176878] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:
(API::WebsiteDataStore::defaultDataStoreConfiguration):
- 3:01 PM Changeset in webkit [176877] by
-
- 2 edits in trunk/Source/WebCore
Fix build on Windows.
- page/SessionIDHash.h:
- 3:00 PM Changeset in webkit [176876] by
-
- 7 edits in trunk
Give all web pages a website data store
https://bugs.webkit.org/show_bug.cgi?id=139317
Reviewed by Tim Horton.
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Set the website data store on the window.
- UIProcess/WebContext.cpp:
(WebKit::websiteDataStoreConfiguration):
Helper function that will create the default website data store configuration for a context.
(WebKit::WebContext::WebContext):
Create a new, per-context data store.
(WebKit::WebContext::createWebPage):
If we don't have a data store filled in, use the default per-context one.
- UIProcess/WebContext.h:
- UIProcess/WebPageProxy.h:
Tools:
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate newPrivateWindow:]):
Don't release the controller - it's implicitly retained by the window.
- 2:43 PM Changeset in webkit [176875] by
-
- 5 edits2 copies1 add in trunk/Source/WebKit2
Move the website data store code to a new file
https://bugs.webkit.org/show_bug.cgi?id=139312
Reviewed by Tim Horton.
It's weird to have all the website data code in the API class, so move it to a new file.
- UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::WebsiteDataStore):
(API::WebsiteDataStore::isNonPersistent):
(API::generateNonPersistentSessionID): Deleted.
- UIProcess/API/APIWebsiteDataStore.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- UIProcess/WebsiteData/WebsiteDataStore.cpp: Copied from Source/WebKit2/UIProcess/API/APIWebsiteDataStore.cpp.
(WebKit::generateNonPersistentSessionID):
(WebKit::WebsiteDataStore::createNonPersistent):
(WebKit::WebsiteDataStore::create):
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):
- UIProcess/WebsiteData/WebsiteDataStore.h: Copied from Source/WebKit2/UIProcess/API/APIWebsiteDataStore.h.
(WebKit::WebsiteDataStore::isNonPersistent):
(WebKit::WebsiteDataStore::sessionID):
- WebKit2.xcodeproj/project.pbxproj:
- 2:22 PM Changeset in webkit [176874] by
-
- 2 edits in trunk/Source/WebCore
Issue repaint at setUnavailablePluginIndicatorIsHidden() only when embedded object's indicator status changes.
https://bugs.webkit.org/show_bug.cgi?id=139311
Reviewed by Tim Horton.
Not testable.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsHidden):
- 2:20 PM Changeset in webkit [176873] by
-
- 5 edits in trunk/Source
PassRef should deref on destruction if pointee was not moved.
<https://webkit.org/b/139309>
Reviewed by Antti Koivisto.
Source/WebCore:
Remove calls to PassRef::dropRef() since it's no longer necessary to manually
notify PassRef that you didn't move the pointee.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
(WebCore::RenderElement::setStyle):
- style/StyleResolveTree.cpp:
(WebCore::Style::resolveTree):
Source/WTF:
Let PassRef become nullptr internally after having WTF::move()'d the pointee.
This means that PassRef is now essentially a PassRefPtr that can only be
constructed with a non-null pointee.
This should make it possible for all ::create()-style construction helpers to
return PassRef, removing a branch in each case.
- wtf/PassRef.h:
(WTF::PassRef<T>::PassRef):
(WTF::PassRef<T>::~PassRef):
(WTF::PassRef<T>::get):
(WTF::PassRef<T>::ptr):
(WTF::PassRef<T>::leakRef):
(WTF::PassRef<T>::dropRef): Deleted.
- 2:13 PM Changeset in webkit [176872] by
-
- 2 edits in trunk/Tools
[iOS] DumpRenderTree fails to render every other test when pixel tests are on
https://bugs.webkit.org/show_bug.cgi?id=137581
<rdar://problem/18642906>
Reviewed by Simon Fraser.
Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
of the test that proceeded the currently running test.
- DumpRenderTree/ios/PixelDumpSupportIOS.mm:
(dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
- 2:11 PM Changeset in webkit [176871] by
-
- 3 edits in trunk/Source/JavaScriptCore
2014-12-05 Geoffrey Garen <ggaren@apple.com>
Removed an unused function.
Reviewed by Michael Saboff.
Broken out from https://bugs.webkit.org/show_bug.cgi?id=139305.
- parser/ParserArena.h:
- 1:29 PM Changeset in webkit [176870] by
-
- 2 edits in trunk/Source/WebKit2
Keyboard input should be disabled in the preview popover
https://bugs.webkit.org/show_bug.cgi?id=139219
<rdar://problem/19052381>
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView performKeyEquivalent:]):
(-[WKView keyUp:]):
(-[WKView keyDown:]):
(-[WKView flagsChanged:]):
There are two implementations of each of these methods in this file.
Adjust the ones that the original patch missed.
- 1:25 PM Changeset in webkit [176869] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176820. rdar://problems/19147218
- 1:17 PM Changeset in webkit [176868] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r176812. rdar://problems/19140827
- 1:17 PM Changeset in webkit [176867] by
-
- 7 edits in branches/safari-600.3-branch/Source
Merged r176811. rdar://problems/19140827
- 1:16 PM Changeset in webkit [176866] by
-
- 12 edits in branches/safari-600.3-branch/Source
Merged r176810. rdar://problems/19140827
- 1:10 PM Changeset in webkit [176865] by
-
- 4 edits1 copy in branches/safari-600.3-branch
Merged r173566. rdar://problems/19150984
- 12:58 PM Changeset in webkit [176864] by
-
- 4 edits42 adds in trunk
Fix style sharing with the "type" and "readonly" attributes
https://bugs.webkit.org/show_bug.cgi?id=139283
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-05
Reviewed by Antti Koivisto.
Source/WebCore:
There are two bugs adressed with this patch:
1) The attributes "type" and "readonly" where only handled correctly
for input elements. For everything else, they could incorrectly
be ignored for style sharing.
2) The handling of attributes was incorrect for selector lists, leading
to various bugs (incorrect style sharing in some cases, disabling
style sharing on valid cases).
For [1], the problem was that attribute checking had been limited to
StyleResolver::canShareStyleWithControl(). That function is for handling
the special states of input element. For any other element, the attributes
were simply ignored.
For [2], there were a bunch of small problems. First, containsUncommonAttributeSelector()
was not recursive, which caused it to ignored any nested selector list. This used to be
correct but since we have advanced selectors we can no longer assumed selectors are not nested.
A second issue was that any attribute in a selector list was causing us to fall back
to the slow case. Now that we have the fast :matches(), we really don't want that.
The function containsUncommonAttributeSelector() was transformed into a recursive function
tracking where we are in the selector.
At the entry point, we start with the flag "startsOnRightmostElement" set to true. The flag is then
updated on the stack of each recursive call.
For example, "webkit > is:matches(freaking > awesome)". We evalute "is" with the flag to true, then recurse
into evaluating "freaking > awesome" with the flag still set to true. When we evalute ">", the flag
is set to false to evaluate any following selectors.
After evaluating "freaking > awesome", we go back to our previous stack frame, and the flag
is back to true and we can continue evaluating with the curren top level state.
From some logging, I discovered that the attribute handling is way too aggressive.
This is not a regression and I cannot fix that easily so I left a fixme.
Tests: fast/css/data-attribute-style-sharing-1.html
fast/css/data-attribute-style-sharing-2.html
fast/css/data-attribute-style-sharing-3.html
fast/css/data-attribute-style-sharing-4.html
fast/css/data-attribute-style-sharing-5.html
fast/css/data-attribute-style-sharing-6.html
fast/css/data-attribute-style-sharing-7.html
fast/css/readonly-attribute-style-sharing-1.html
fast/css/readonly-attribute-style-sharing-2.html
fast/css/readonly-attribute-style-sharing-3.html
fast/css/readonly-attribute-style-sharing-4.html
fast/css/readonly-attribute-style-sharing-5.html
fast/css/readonly-attribute-style-sharing-6.html
fast/css/readonly-attribute-style-sharing-7.html
fast/css/type-attribute-style-sharing-1.html
fast/css/type-attribute-style-sharing-2.html
fast/css/type-attribute-style-sharing-3.html
fast/css/type-attribute-style-sharing-4.html
fast/css/type-attribute-style-sharing-5.html
fast/css/type-attribute-style-sharing-6.html
fast/css/type-attribute-style-sharing-7.html
- css/RuleSet.cpp:
(WebCore::containsUncommonAttributeSelector):
(WebCore::RuleData::RuleData):
(WebCore::selectorListContainsAttributeSelector): Deleted.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::canShareStyleWithElement):
LayoutTests:
- fast/css/data-attribute-style-sharing-1-expected.html: Added.
- fast/css/data-attribute-style-sharing-1.html: Added.
- fast/css/data-attribute-style-sharing-2-expected.html: Added.
- fast/css/data-attribute-style-sharing-2.html: Added.
- fast/css/data-attribute-style-sharing-3-expected.html: Added.
- fast/css/data-attribute-style-sharing-3.html: Added.
- fast/css/data-attribute-style-sharing-4-expected.html: Added.
- fast/css/data-attribute-style-sharing-4.html: Added.
- fast/css/data-attribute-style-sharing-5-expected.html: Added.
- fast/css/data-attribute-style-sharing-5.html: Added.
- fast/css/data-attribute-style-sharing-6-expected.html: Added.
- fast/css/data-attribute-style-sharing-6.html: Added.
- fast/css/data-attribute-style-sharing-7-expected.html: Added.
- fast/css/data-attribute-style-sharing-7.html: Added.
- fast/css/readonly-attribute-style-sharing-1-expected.html: Added.
- fast/css/readonly-attribute-style-sharing-1.html: Added.
- fast/css/readonly-attribute-style-sharing-2-expected.html: Added.
- fast/css/readonly-attribute-style-sharing-2.html: Added.
- fast/css/readonly-attribute-style-sharing-3-expected.html: Added.
- fast/css/readonly-attribute-style-sharing-3.html: Added.
- fast/css/readonly-attribute-style-sharing-4-expected.html: Added.
- fast/css/readonly-attribute-style-sharing-4.html: Added.
- fast/css/readonly-attribute-style-sharing-5-expected.html: Added.
- fast/css/readonly-attribute-style-sharing-5.html: Added.
- fast/css/readonly-attribute-style-sharing-6-expected.html: Added.
- fast/css/readonly-attribute-style-sharing-6.html: Added.
- fast/css/readonly-attribute-style-sharing-7-expected.html: Added.
- fast/css/readonly-attribute-style-sharing-7.html: Added.
- fast/css/type-attribute-style-sharing-1-expected.html: Added.
- fast/css/type-attribute-style-sharing-1.html: Added.
- fast/css/type-attribute-style-sharing-2-expected.html: Added.
- fast/css/type-attribute-style-sharing-2.html: Added.
- fast/css/type-attribute-style-sharing-3-expected.html: Added.
- fast/css/type-attribute-style-sharing-3.html: Added.
- fast/css/type-attribute-style-sharing-4-expected.html: Added.
- fast/css/type-attribute-style-sharing-4.html: Added.
- fast/css/type-attribute-style-sharing-5-expected.html: Added.
- fast/css/type-attribute-style-sharing-5.html: Added.
- fast/css/type-attribute-style-sharing-6-expected.html: Added.
- fast/css/type-attribute-style-sharing-6.html: Added.
- fast/css/type-attribute-style-sharing-7-expected.html: Added.
- fast/css/type-attribute-style-sharing-7.html: Added.
- 12:51 PM Changeset in webkit [176863] by
-
- 9 edits in trunk
[WTF] MediaTime should support round-tripping from and to doubles.
https://bugs.webkit.org/show_bug.cgi?id=139248
Reviewed by Eric Carlson.
Source/WebCore:
Check whether the MediaTime's underlying data is floating point before converting
to a CMTime or QTTime.
- platform/graphics/avfoundation/MediaTimeAVFoundation.cpp:
(WebCore::toCMTime):
- platform/graphics/mac/MediaTimeQTKit.mm:
(WebCore::toQTTime):
Source/WTF:
MediaTimes should be able to return precisely the same double value as was used
when the MediaTime was created, so long as that MediaTime was not modified in a
non-destructive way. This will allow API which accepts floating-point values to
return the exact same value when asked, but still be able to store that value
as a MediaTime.
- wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat): Added; store the floating-point value in a union.
(WTF::MediaTime::createWithDouble): Ditto.
(WTF::MediaTime::toFloat): If the value is a double, just return it.
(WTF::MediaTime::toDouble): Ditto.
(WTF::MediaTime::operator+): Special case when one or both sides are doubles.
(WTF::MediaTime::operator-): Ditto.
(WTF::MediaTime::operator*): Ditto.
(WTF::MediaTime::compare): Ditto.
(WTF::abs): Ditto.
(WTF::MediaTime::setTimeScale): Convert the MediaTime from a double.
Tools:
Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
the MediaTimes after this change.
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(WTF::operator<<):
(TestWebKitAPI::TEST):
- lldb/lldb_webkit.py:
(WTFMediaTime_SummaryProvider):
(WTFMediaTimeProvider.timeValueAsDouble):
(WTFMediaTimeProvider.isIndefinite):
(WTFMediaTimeProvider):
(WTFMediaTimeProvider.hasDoubleValue):
- 12:48 PM Changeset in webkit [176862] by
-
- 7 edits in trunk
Add a private browsing mode to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=139308
Reviewed by Sam Weinig.
Source/WebCore:
Use -1 instead of -2 for the deleted value.
- page/SessionIDHash.h:
Tools:
- MiniBrowser/mac/AppDelegate.m:
(defaultConfiguration):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate newPrivateWindow:]):
- MiniBrowser/mac/MainMenu.xib:
- MiniBrowser/mac/WK2BrowserWindowController.h:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController initWithConfiguration:]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
- 12:27 PM Changeset in webkit [176861] by
-
- 4 edits in trunk/Source/WebCore
Move 'text-emphasis-style' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139285
Reviewed by Sam Weinig.
Move 'text-emphasis-style' CSS property to the new StyleBuilder by
using custom code.
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue): Deleted.
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue): Deleted.
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue): Deleted.
(WebCore::ApplyPropertyTextEmphasisStyle::createHandler): Deleted.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInitialWebkitTextEmphasisStyle):
(WebCore::StyleBuilderCustom::applyInheritWebkitTextEmphasisStyle):
(WebCore::StyleBuilderCustom::applyValueWebkitTextEmphasisStyle):
- 11:47 AM Changeset in webkit [176860] by
-
- 2 edits in tags/Safari-600.3.10.1/Source/WebCore
Merged r176855. rdar://problem/19159480
- 11:44 AM Changeset in webkit [176859] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r176855. <rdar://problem/19159480>
- 11:43 AM Changeset in webkit [176858] by
-
- 3 edits in trunk/Source/WebKit2
In NetworkResourceLoader always bail out after abort()
https://bugs.webkit.org/show_bug.cgi?id=139299
Reviewed by Alexey Proskuryakov.
Invoking abort() may kill the current object. Take care to bail out after it.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::didFinishLoading):
Either make sure sendAbortingOnFailure() is called last in callbacks or the results is explicitly tested.
(WebKit::NetworkResourceLoader::bufferingTimerFired):
(WebKit::NetworkResourceLoader::sendBufferMaybeAborting):
Rename and return a boolean to indicate if load should continue.
(WebKit::NetworkResourceLoader::sendBuffer): Deleted.
- NetworkProcess/NetworkResourceLoader.h:
- 11:31 AM Changeset in webkit [176857] by
-
- 2 edits in trunk/Source/WebCore
[iOS] remove "enter optimized fullscreen" gesture
https://bugs.webkit.org/show_bug.cgi?id=139301
Reviewed by Jer Noble.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handleWrapperTouchStart): Remove gesture recognizer.
- 11:28 AM Changeset in webkit [176856] by
-
- 2 edits in trunk/Source/WebKit/mac
Legacy WebKit should set deviceScaleFactor in _commonInitializationWithFrameName, not _initWithFrame
https://bugs.webkit.org/show_bug.cgi?id=139306
<rdar://problem/19157955>
Reviewed by Beth Dakin.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _initWithFrame:frameName:groupName:]):
Move setDeviceScaleFactor to the initialization path that is guaranteed to happen.
- 11:21 AM Changeset in webkit [176855] by
-
- 2 edits in trunk/Source/WebCore
rdar://problem/19156353 Additional build-fixes needed.
Rubber-stamped by Tim Horton.
This is a bit unfortunate, but we need to always forward-declare this for now.
- platform/spi/mac/QuickLookMacSPI.h:
- 11:10 AM Changeset in webkit [176854] by
-
- 3 edits in trunk/Source/WebKit2
Don't use PLATFORM(IOS) in non-project headers.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _allowsAlternateFullscreen]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- 10:48 AM Changeset in webkit [176853] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exceptions when attempting to show Content Flow
https://bugs.webkit.org/show_bug.cgi?id=139276
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-05
Reviewed by Brian Burg.
- UserInterface/Views/ContentView.js:
(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
LegacyJavaScriptProfileObject no longer exists, these references should be removed.
- UserInterface/Views/FolderizedTreeElement.js:
(WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
This sort function references "this" and needed to be bound.
- 10:46 AM Changeset in webkit [176852] by
-
- 3 edits in trunk/Source/WTF
[WinCairo] WTF project is missing a GStreamer source file.
https://bugs.webkit.org/show_bug.cgi?id=139296
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-05
Reviewed by Philippe Normand.
The WTF project file is missing a GStreamer source file,
causing a link error when compiling with GStreamer enabled.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- 10:38 AM Changeset in webkit [176851] by
-
- 5 edits in branches/safari-600.1.4.13-branch/Source
Versioning.
- 10:35 AM Changeset in webkit [176850] by
-
- 1 copy in branches/safari-600.1.4.13-branch
New Branch.
- 10:30 AM Changeset in webkit [176849] by
-
- 5 edits2 adds in trunk/Source/WebKit2
WKBundleCSSStyleDeclarationRef needs to be a real API::Object
https://bugs.webkit.org/show_bug.cgi?id=139291
Patch by Sam Weinig <sam@webkit.org> on 2014-12-05
Reviewed by Dan Bernstein.
Change WKBundleCSSStyleDeclarationRef from being a WebCore::CSSStyleDeclaration, to
being a real API::Object. WKRetain and WKRelease require this.
- Shared/APIObject.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp: Added.
(WebKit::domHandleCache):
(WebKit::InjectedBundleCSSStyleDeclarationHandle::getOrCreate):
(WebKit::InjectedBundleCSSStyleDeclarationHandle::InjectedBundleCSSStyleDeclarationHandle):
(WebKit::InjectedBundleCSSStyleDeclarationHandle::~InjectedBundleCSSStyleDeclarationHandle):
- WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h: Added.
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):
- 10:23 AM Changeset in webkit [176848] by
-
- 2 edits in trunk/Source/WebKit2
Oops, didn't mean to commit this.
- Shared/API/Cocoa/WKFoundation.h:
- 10:20 AM Changeset in webkit [176847] by
-
- 8 edits3 copies in trunk/Source/WebKit2
Add an API::WebsiteDataStore object and use it for _WKWebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=139304
Reviewed by Tim Horton.
- Shared/APIObject.h:
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Make _WKWebsiteDataStore a wrapper for API::WebsiteDataStore instead of API::Session.
- UIProcess/API/APIWebsiteDataStore.cpp: Added.
(API::generateNonPersistentSessionID):
(API::WebsiteDataStore::defaultDataStore):
(API::WebsiteDataStore::createNonPersistentDataStore):
(API::WebsiteDataStore::WebsiteDataStore):
(API::WebsiteDataStore::~WebsiteDataStore):
(API::WebsiteDataStore::isNonPersistent):
Add new WebsiteDataStore implementation. Currently it only contains the WebCore Session ID, but more will be
added to it in upcoming commits.
- UIProcess/API/APIWebsiteDataStore.h:
Add header.
- UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm: Added.
(API::WebsiteDataStore::defaultDataStoreConfiguration):
Platform specific file that returns the default data store configuration.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Set the session ID from the website data store.
- UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
(+[_WKWebsiteDataStore defaultDataStore]):
(+[_WKWebsiteDataStore nonPersistentDataStore]):
(-[_WKWebsiteDataStore dealloc]):
(-[_WKWebsiteDataStore isNonPersistent]):
(-[_WKWebsiteDataStore _apiObject]):
Update now that we wrap an API::WebsiteDataStore instead.
- UIProcess/API/Cocoa/_WKWebsiteDataStoreInternal.h:
(WebKit::wrapper):
Update for API::Session -> API::WebsiteDataStore change.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 9:55 AM Changeset in webkit [176846] by
-
- 8 edits in trunk/Source
FeatureDefines.xcconfig: Workaround bug in Xcode 5.1.1 when defining ENABLE_WEB_REPLAY
<http://webkit.org/b/139286>
Reviewed by Daniel Bates.
- Configurations/FeatureDefines.xcconfig: Switch back to using
PLATFORM_NAME to workaround a bug in Xcode 5.1.1 on 10.8.
- 9:33 AM Changeset in webkit [176845] by
-
- 10 edits in trunk/Source/WebKit2
Make WebPageProxy hold on to a SessionID instead of an API:Session
https://bugs.webkit.org/show_bug.cgi?id=139302
Reviewed by Sam Weinig.
This is in preparation for adding API::WebsiteDataStore. Currently we have to keep the
Session ID and the WebsiteDataStore separate because we still need to support toggling private browsing.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetSession):
- UIProcess/API/C/WKSessionRef.cpp:
(WKSessionCreate):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
(+[_WKWebsiteDataStore nonPersistentDataStore]):
- UIProcess/APISession.cpp:
(API::generateID):
(API::Session::Session):
(API::Session::createEphemeral):
(API::Session::legacyPrivateSession): Deleted.
(API::Session::create): Deleted.
- UIProcess/APISession.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createWebPage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setSessionID):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setSession): Deleted.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::sessionID):
- 9:26 AM Changeset in webkit [176844] by
-
- 5 edits in tags/Safari-600.3.10.1/Source
Versioning.
- 9:23 AM Changeset in webkit [176843] by
-
- 1 copy in tags/Safari-600.3.10.1
New tag.
- 8:34 AM Changeset in webkit [176842] by
-
- 2 edits in trunk/Source/WebKit/win
Follow-up build fix.
- WebCoreSupport/WebVisitedLinkStore.cpp:
(WebVisitedLinkStore::shared):
- 5:25 AM Changeset in webkit [176841] by
-
- 10 edits in trunk/Source
[iOS] allow host application to opt-out of alternate fullscreen pt. 2
https://bugs.webkit.org/show_bug.cgi?id=139227
Source/WebCore:
Reviewed by Jer Noble and Anders Carlsson
- WebCore.exp.in: Export HTMLMediaSession::allowsAlternateFullscreen, change the signature of
WebVideoFullscreenInterfaceAVKit::setupFullscreen.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController enterFullscreen:mode:]): Update for
WebVideoFullscreenInterfaceAVKit::setupFullscreen change.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h: Add argument to setupFullscreen.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): Ditto.
Source/WebKit2:
Reviewed by Jer Noble and Anders Carlsson.
- UIProcess/ios/WebVideoFullscreenManagerProxy.h: Add bool param to setupFullscreenWithID.
- UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in: Ditto.
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID): Ditto.
- WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement): Pass new parameter
to SetupFullscreenWithID.
- 2:29 AM Changeset in webkit [176840] by
-
- 2 edits in trunk/Source/WebCore
Fix build warning in WebCore/platform/graphics module
https://bugs.webkit.org/show_bug.cgi?id=139290
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-12-05
Reviewed by Carlos Garcia Campos.
Fix a build warning by removing parameter name from function.
No new tests, no behavior change.
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::getFamilyNameStringFromFontDescriptionAndFamily):
- 12:11 AM Changeset in webkit [176839] by
-
- 2 edits in trunk/Source/WebCore
GraphicsLayerTextureMapper: Rename parameter to be more clear
https://bugs.webkit.org/show_bug.cgi?id=139288
Patch by sungmin cho <sungmin17.cho@lge.com> on 2014-12-05
Reviewed by Martin Robinson.
Rename 'media' to 'platformLayer'.
No new tests, no change in functionality.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setContentsToPlatformLayer):
Dec 4, 2014:
- 11:46 PM Changeset in webkit [176838] by
-
- 3 edits in trunk/Source/WebCore
Fix pre-Yosemite builds.
The #ifs in two SPI wrapper headers were incorrect, resulting in code being included
prior to Yosemite that required Yosemite to compile.
- platform/spi/mac/NSSharingServicePickerSPI.h:
- platform/spi/mac/NSSharingServiceSPI.h:
- 10:58 PM Changeset in webkit [176837] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix after r176836.
Reviewed by Mark Lam.
- runtime/VM.h:
(JSC::VM::controlFlowProfiler): Don't try to export an inline function.
Doing so results in a weak external symbol being generated.
- 9:58 PM Changeset in webkit [176836] by
-
- 47 edits4 adds in trunk/Source/JavaScriptCore
JavaScript Control Flow Profiler
https://bugs.webkit.org/show_bug.cgi?id=137785
Reviewed by Filip Pizlo.
This patch introduces a mechanism for JavaScriptCore to profile
which basic blocks have executed. This mechanism will then be
used by the Web Inspector to indicate which basic blocks
have and have not executed.
The profiling works by compiling in an op_profile_control_flow
at the start of every basic block. Then, whenever this op code
executes, we know that a particular basic block has executed.
When we tier up a CodeBlock that contains an op_profile_control_flow
that corresponds to an already executed basic block, we don't
have to emit code for that particular op_profile_control_flow
because the internal data structures used to keep track of
basic block locations has already recorded that the corresponding
op_profile_control_flow has executed.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/Instruction.h:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::addOpProfileControlFlowBytecodeOffset):
(JSC::UnlinkedCodeBlock::opProfileControlFlowBytecodeOffsets):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitProfileControlFlow):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ConditionalNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::CaseClauseNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::FunctionNode::emitBytecode):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::basicBlockLocation):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_profile_control_flow):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_profile_control_flow):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionFindTypeForExpression):
(functionReturnTypeFor):
(functionDumpBasicBlockExecutionRanges):
- llint/LowLevelInterpreter.asm:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::endOffset):
(JSC::ASTBuilder::setStartOffset):
- parser/NodeConstructors.h:
(JSC::Node::Node):
- parser/Nodes.h:
(JSC::CaseClauseNode::setStartOffset):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseSwitchClauses):
(JSC::Parser<LexerType>::parseSwitchDefaultClause):
(JSC::Parser<LexerType>::parseBlockStatement):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseIfStatement):
(JSC::Parser<LexerType>::parseExpression):
(JSC::Parser<LexerType>::parseConditionalExpression):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseMemberExpression):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::operatorStackPop):
- runtime/BasicBlockLocation.cpp: Added.
(JSC::BasicBlockLocation::BasicBlockLocation):
(JSC::BasicBlockLocation::insertGap):
(JSC::BasicBlockLocation::getExecutedRanges):
(JSC::BasicBlockLocation::dumpData):
(JSC::BasicBlockLocation::emitExecuteCode):
- runtime/BasicBlockLocation.h: Added.
(JSC::BasicBlockLocation::startOffset):
(JSC::BasicBlockLocation::endOffset):
(JSC::BasicBlockLocation::setStartOffset):
(JSC::BasicBlockLocation::setEndOffset):
(JSC::BasicBlockLocation::hasExecuted):
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
- runtime/ControlFlowProfiler.cpp: Added.
(JSC::ControlFlowProfiler::~ControlFlowProfiler):
(JSC::ControlFlowProfiler::getBasicBlockLocation):
(JSC::ControlFlowProfiler::dumpData):
(JSC::ControlFlowProfiler::getBasicBlocksForSourceID):
- runtime/ControlFlowProfiler.h: Added. This class is in
charge of generating BasicBlockLocations and also
providing an interface that the Web Inspector can use to ping
which basic blocks have executed based on the source id of a script.
(JSC::BasicBlockKey::BasicBlockKey):
(JSC::BasicBlockKey::isHashTableDeletedValue):
(JSC::BasicBlockKey::operator==):
(JSC::BasicBlockKey::hash):
(JSC::BasicBlockKeyHash::hash):
(JSC::BasicBlockKeyHash::equal):
- runtime/Executable.cpp:
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::ProgramExecutable::initializeGlobalProperties):
- runtime/FunctionHasExecutedCache.cpp:
(JSC::FunctionHasExecutedCache::getUnexecutedFunctionRanges):
- runtime/FunctionHasExecutedCache.h:
- runtime/Options.h:
- runtime/TypeProfiler.cpp:
(JSC::TypeProfiler::logTypesForTypeLocation):
(JSC::TypeProfiler::typeInformationForExpressionAtOffset):
(JSC::TypeProfiler::findLocation):
(JSC::TypeProfiler::dumpTypeProfilerData):
- runtime/TypeProfiler.h:
(JSC::TypeProfiler::functionHasExecutedCache): Deleted.
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::enableProfilerWithRespectToCount):
(JSC::disableProfilerWithRespectToCount):
(JSC::VM::enableTypeProfiler):
(JSC::VM::disableTypeProfiler):
(JSC::VM::enableControlFlowProfiler):
(JSC::VM::disableControlFlowProfiler):
(JSC::VM::dumpTypeProfilerData):
- runtime/VM.h:
(JSC::VM::functionHasExecutedCache):
(JSC::VM::controlFlowProfiler):
- 9:31 PM Changeset in webkit [176835] by
-
- 2 edits in tags/Safari-601.1.11.1/Source/WTF
Merged r176832.
- 9:13 PM Changeset in webkit [176834] by
-
- 5 edits in tags/Safari-601.1.11.1/Source
Versioning.
- 9:10 PM Changeset in webkit [176833] by
-
- 1 copy in tags/Safari-601.1.11.1
New tag.
- 8:59 PM Changeset in webkit [176832] by
-
- 2 edits in trunk/Source/WTF
REGRESSION (r176683): RefCounter.h is installed outside SDKROOT
- WTF.xcodeproj/project.pbxproj: Don't mark RefCounter.h as a
private header. WTF headers use a special build phase script to
be installed.
- 5:53 PM Changeset in webkit [176831] by
-
- 1 copy in tags/Safari-600.3.10
Tagging.
- 5:37 PM Changeset in webkit [176830] by
-
- 14 edits in trunk/Tools
Run http tests parallel
https://bugs.webkit.org/show_bug.cgi?id=138958
Reviewed by Daniel Bates.
Remove the concept of "locked shard". Now http tests are just like any other tests.
We start HTTP and WebSocket servers at the start if we need them, and terminate them
when done with all the tests (not when the last http test runs, which is unnecessarily
unpredictable).
This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
patch, they used to take over 15 minutes.
As part of the fix, we no longer pass the number of servers to Apache. I don't
think that these parameters did what we wanted them to do; Apache handles the load
just fine without them.
The change applies to all platforms. I fixed everything I could find on Mac, and
Ossy told me that he's been running http tests in parallel for a long time. If
there is increased instability for some ports, it will need to be fixed - there is
generally nothing special about http tests at this point, and most code is
cross-platform in WebKit2.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.init):
(LayoutTestRunner.run_tests):
(LayoutTestRunner.start_servers_with_lock):
(LayoutTestRunner._handle_started_test):
(Worker.handle):
(Sharder.init):
(Sharder.shard_tests):
(Sharder._shard_every_file):
(Sharder._shard_by_directory):
(LayoutTestRunner._handle_finished_test_list): Deleted.
(LayoutTestRunner._handle_finished_test_list.find): Deleted.
(Sharder._shard_in_two): Deleted.
(Sharder): Deleted.
(Sharder._resize_shards): Deleted.
(Sharder._resize_shards.divide_and_round_up): Deleted.
(Sharder._resize_shards.extract_and_flatten): Deleted.
(Sharder._resize_shards.split_at): Deleted.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(FakePrinter.print_workers_and_shards):
(LayoutTestRunnerTests.test_servers_started.start_http_server):
(LayoutTestRunnerTests.test_servers_started):
(SharderTests.get_shards):
(SharderTests.test_shard_by_dir):
(SharderTests.test_shard_every_file):
(SharderTests): Deleted.
(SharderTests.test_shard_in_two): Deleted.
(SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
(SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
(SharderTests.test_multiple_locked_shards): Deleted.
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_needs_servers.get_manager):
(ManagerTest.integration_test_needs_servers.get_manager):
(ManagerTest.test_look_for_new_crash_logs.get_manager):
(ManagerTest):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_batch_size):
(RunTest.test_max_locked_shards): Deleted.
- Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd.init):
- Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
(TestLayoutTestApacheHttpd.test_start_cmd):
- Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd.init):
- Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase.init):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_workers_and_shards):
- Scripts/webkitpy/port/base.py:
(Port.default_child_processes):
(Port.to.start_http_server):
(Port.default_max_locked_shards): Deleted.
- Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.make_port):
(PortTestCase.test_default_max_locked_shards): Deleted.
- Scripts/webkitpy/port/test.py:
(TestPort.start_http_server):
- 5:23 PM Changeset in webkit [176829] by
-
- 30 edits in trunk/Source/WebKit2
Add missing includes in preparation for making toAPI require that it's passed an API::Object
https://bugs.webkit.org/show_bug.cgi?id=139278
Reviewed by Tim Horton.
- UIProcess/API/C/WKAuthenticationChallenge.cpp:
- UIProcess/API/C/WKAuthenticationDecisionListener.cpp:
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKDownload.cpp:
- UIProcess/API/C/WKFrame.cpp:
- UIProcess/API/C/WKGeolocationManager.cpp:
- UIProcess/API/C/WKInspector.cpp:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/GenericCallback.h:
- UIProcess/Notifications/WebNotificationProvider.cpp:
- UIProcess/WebContextConnectionClient.cpp:
- UIProcess/WebContextInjectedBundleClient.cpp:
- UIProcess/WebCookieManagerProxyClient.cpp:
- UIProcess/WebDatabaseManagerProxyClient.cpp:
- UIProcess/WebFindClient.cpp:
- UIProcess/WebFormClient.cpp:
- UIProcess/WebIconDatabaseClient.cpp:
- UIProcess/WebPageContextMenuClient.cpp:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/InjectedBundleClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- 5:06 PM Changeset in webkit [176828] by
-
- 2 edits in trunk/Source/JavaScriptCore
printInternal(PrintStream& out, JSC::JITCode::JITType type) ends up dumping a literal %s
https://bugs.webkit.org/show_bug.cgi?id=139274
Reviewed by Geoffrey Garen.
- jit/JITCode.cpp:
(WTF::printInternal):
- 5:06 PM Changeset in webkit [176827] by
-
- 2 edits in trunk/Source/WebKit/win
Don't use NeverDestroyed with a RefCounted object.
- WebCoreSupport/WebVisitedLinkStore.cpp:
(WebVisitedLinkStore::shared):
- 5:03 PM Changeset in webkit [176826] by
-
- 6 edits in trunk/Source
Make API::String copy the underlying strings if needed, for thread safety
https://bugs.webkit.org/show_bug.cgi?id=139261
Reviewed by Sam Weinig.
Source/WebKit2:
- Shared/API/c/WKString.cpp:
(WKStringCreateWithUTF8CString):
(WKStringCreateWithJSString):
(WKStringCopyJSString):
Move the implementations from API::String and directly into the API functions.
- Shared/APIString.h:
Add a create overload that takes an rvalue reference. Call it from the create overload
that takes an lvalue reference, but explicitly copy the string.
We call isolatedCopy() again on the string in the rvalue reference overload, but that is a no-op
if the string can be sent to another thread. Add assertions in the String constructor that we can
send the string to another thread.
Source/WTF:
- wtf/RefPtr.h:
(WTF::RefPtr<T>::leakRef):
Add a leakRef() to RefPtr so we don't have to go through PassRefPtr.
- wtf/text/WTFString.cpp:
(WTF::String::isSafeToSendToAnotherThread):
Check if the string is empty before checking whether it's in an atomic string table.
It's safe to send empty strings to other threads even if they're in the atomic string table
since they will never be deallocated.
- 4:59 PM Changeset in webkit [176825] by
-
- 13 edits in trunk/Source/JavaScriptCore
Removed the concept of ParserArenaRefCounted
https://bugs.webkit.org/show_bug.cgi?id=139277
Reviewed by Oliver Hunt.
This is a step toward a parser speedup.
Now that we have a clear root node type for each parse tree, there's no
need to have a concept for "I might be refcounted or arena allocated".
Instead, we can just use unique_ptr to manage the tree as a whole.
- API/JSScriptRef.cpp:
(parseScript):
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createBuiltinExecutable): Updated for type change.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock): Use unique_ptr. No need to call
destroyData() explicitly: the unique_ptr destructor will do everything
we need, as Bjarne intended.
- parser/NodeConstructors.h:
(JSC::ParserArenaRoot::ParserArenaRoot):
(JSC::ParserArenaRefCounted::ParserArenaRefCounted): Deleted.
- parser/Nodes.cpp:
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::EvalNode::EvalNode):
(JSC::FunctionNode::FunctionNode):
(JSC::ProgramNode::create): Deleted.
(JSC::EvalNode::create): Deleted.
(JSC::FunctionNode::create): Deleted. All special create semantics can
just go away now that we play by C++ constructor / destructor rules.
- parser/Nodes.h:
(JSC::ParserArenaRoot::parserArena):
(JSC::ParserArenaRoot::~ParserArenaRoot): Just a normal class now, which
holds onto the whole parse tree by virtue of owning the arena in which
all the parsed nodes (except for itself) were allocated.
(JSC::ProgramNode::closedVariables):
(JSC::ParserArenaRefCounted::~ParserArenaRefCounted): Deleted.
(JSC::ScopeNode::destroyData): Deleted. No need to destroy anything
explicitly anymore -- we can just rely on destructors.
(JSC::ScopeNode::parserArena): Deleted.
- parser/Parser.h:
(JSC::Parser<LexerType>::parse):
(JSC::parse): unique_ptr all the things.
- parser/ParserArena.cpp:
(JSC::ParserArena::reset):
(JSC::ParserArena::isEmpty):
(JSC::ParserArena::contains): Deleted.
(JSC::ParserArena::last): Deleted.
(JSC::ParserArena::removeLast): Deleted.
(JSC::ParserArena::derefWithArena): Deleted.
- parser/ParserArena.h:
(JSC::ParserArena::swap): Much delete. Such wow.
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/Completion.cpp:
(JSC::checkSyntax):
- runtime/Executable.cpp:
(JSC::ProgramExecutable::checkSyntax): unique_ptr all the things.
- 4:55 PM Changeset in webkit [176824] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r173188): Text inserted when trying to delete a word from the Twitter message box.
<https://webkit.org/b/139076>
Reviewed by Geoffrey Garen.
The StringImpl* -> Weak<JSString> cache used by the DOM bindings
had a bug where the key could become a stale pointer if the cached
JSString had its internal StringImpl atomicized.
If a new StringImpl was then later constructed at the exact same
address as the stale key, before the Weak<JSString> got booted out
of the string cache, we'd now have a situation where asking the
string cache for that key would return the old JSString.
Solve this by not allowing JSString::toExistingAtomicString() to
change the JSString's internal StringImpl unless it's resolving a
rope string. (The StringImpl nullity determines rope state.)
This means that calling toExistingAtomicString() may now have to
query the AtomicString table on each call rather than just once.
All clients of this API would be forced to do this regardless,
since they return value will be used to key into containers with
AtomicStringImpl* keys.
No test because this relies on malloc putting two StringImpls
at the same address at different points in time and we have no
mechanism to reliably test that.
- runtime/JSString.h:
(JSC::JSString::toExistingAtomicString):
- 3:55 PM Changeset in webkit [176823] by
-
- 2 edits in trunk/Source/JavaScriptCore
2014-12-04 Geoffrey Garen <ggaren@apple.com>
Marked some final things final.
Reviewed by Andreas Kling.
- parser/Nodes.h:
- 3:47 PM Changeset in webkit [176822] by
-
- 11 edits in trunk/Source/JavaScriptCore
Split out FunctionNode from FunctionBodyNode
https://bugs.webkit.org/show_bug.cgi?id=139273
Reviewed by Andreas Kling.
This is step toward a parser speedup.
We used to use FunctionBodyNode for two different purposes:
(1) "I am the root function you are currently parsing";
(2) "I am a lazy record of a nested function, which you will parse later".
This made for awkward lifetime semantics and interfaces.
Now, case (1) is handled by FunctionBodyNode, and case (2) is handled by
a new node named FunctionNode.
Since case (1) no longer needs to handle being the root of the parse
tree, FunctionBodyNode can be a normal arena-allocated node.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock): Use FunctionNode instead of
FunctionBodyNode, since we are producing the root of the function parse
tree.
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable): Removed
some unused data, and default-initialized other data, which isn't filled
in meaningfully until recordParse() is called. (The previous values were
incorrect / meaningless, since the FunctionBodyNode didn't have
meaningful values in this case.)
- bytecode/UnlinkedCodeBlock.h: Ditto.
(JSC::UnlinkedFunctionExecutable::forceUsesArguments): Deleted.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Use FunctionNode instead of
FunctionBodyNode, since we are generating code starting at the root of
the parse tree.
(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::addCallee):
- bytecompiler/BytecodeGenerator.h: Ditto.
- bytecompiler/NodesCodegen.cpp:
(JSC::FunctionBodyNode::emitBytecode):
(JSC::FunctionNode::emitBytecode): Moved the emitBytecode implementation
to FunctionNode, since we never generate code for FunctionBodyNode,
since it's just a placeholder in the AST.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::setUsesArguments): Deleted. Updated for interface
changes.
- parser/Nodes.cpp:
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::finishParsing):
(JSC::FunctionBodyNode::setEndPosition):
(JSC::FunctionNode::FunctionNode):
(JSC::FunctionNode::create):
(JSC::FunctionNode::finishParsing):
(JSC::FunctionBodyNode::create): Deleted.
- parser/Nodes.h:
(JSC::FunctionBodyNode::parameters):
(JSC::FunctionBodyNode::source):
(JSC::FunctionBodyNode::startStartOffset):
(JSC::FunctionBodyNode::isInStrictContext):
(JSC::FunctionNode::parameters):
(JSC::FunctionNode::ident):
(JSC::FunctionNode::functionMode):
(JSC::FunctionNode::startColumn):
(JSC::FunctionNode::endColumn):
(JSC::ScopeNode::setSource): Deleted.
(JSC::FunctionBodyNode::parameterCount): Deleted. Split out the differences
between FunctionNode and FunctionBodyNode.
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createClauseList):
(JSC::SyntaxChecker::setUsesArguments): Deleted. Removed setUsesArguments
since it wasn't used.
- runtime/Executable.cpp:
(JSC::ProgramExecutable::checkSyntax): Removed a branch that was always
false.
- 3:26 PM Changeset in webkit [176821] by
-
- 2 edits in trunk/LayoutTests
css3/viewport-percentage-lengths tests are flakey on WK1 Mavericks Debug
https://bugs.webkit.org/show_bug.cgi?id=139271
Marking as flakey.
- platform/mac-mavericks/TestExpectations:
- 2:57 PM Changeset in webkit [176820] by
-
- 2 edits in trunk/Source/WebKit2
Clients disabling action menus sometimes still invoke action menu behaviors
https://bugs.webkit.org/show_bug.cgi?id=139270
-and corresponding-
rdar://problem/19147218
Reviewed by Tim Horton.
By default, we will keep a single item in the action menu up until the point where
_state == ActionMenuState::Ready. So by checking _state here, we are preventing
clients from opting out of our choice to wait. Ideally we would always still wait
for the Ready state, but this will get the best behavior in the mean time.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _updateActionMenuItems]):
- 2:56 PM Changeset in webkit [176819] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters
https://bugs.webkit.org/show_bug.cgi?id=139268
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-04
Reviewed by Brian Burg.
- UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.createColumnScopeBar):
Users of createColumnScopeBar pass a Map object now instead of a dictionary.
Iterate over the map appropriately.
- 2:48 PM Changeset in webkit [176818] by
-
- 5 edits in trunk/Source/WebKit2
REGRESSION (r173468): Cannot step in WebInspector
https://bugs.webkit.org/show_bug.cgi?id=139260
Reviewed by Alexey Proskuryakov.
Inspector defers all loads and starts a nested runloop when it hits a breakpoint. When continuing it undefers the loads.
If the script execution was triggered from the didFinishLoading callback of the main resource then the main resource would
already be in the finished state in the network process side and setDefersLoading(false) message would end up restarting its load.
Since loads are not meant to restart the generated callbacks would assert or crash the web process when handled in the next
nested inspector runloop.
Fix by taking care that cleaned up NetworkResourceLoaders are always removed from the loader map of
the NetworkConnectionToWebProcess and so can't end up handling late messages.
No test, this requires JS debugger to trigger.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didCleanupResourceLoader):
This is now the only way to remove resource loaders.
It is called from NetworkResourceLoader::cleanup only.
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):
Calling abort removes the resource loader (since it calls cleanup) so no need to do it explicitly anymore.
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::start):
We are guaranteed to be reffed by NetworkConnectionToWebProcess until cleanup so the explicit ref/deref can be removed.
(WebKit::NetworkResourceLoader::cleanup):
Call to NetworkConnectionToWebProcess::didCleanupResourceLoader to make the loader unreachable.
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::identifier):
- 2:20 PM Changeset in webkit [176817] by
-
- 14 edits in trunk
Web Inspector: timeline probe records have inaccurate per-probe hit counts
https://bugs.webkit.org/show_bug.cgi?id=138976
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
Previously, the DebuggerAgent was responsible for assigning unique ids to samples.
However, this makes it impossible for the frontend's Timeline manager to associate
a Probe Sample timeline record with the corresponding probe sample data. The record
only included the probe batchId (misnamed as hitCount in ScriptDebugServer).
This patch moves both the batchId and sampleId counters into ScriptDebugServer, so
any client of ScriptDebugListener will get the correct sampleId for each sample.
- inspector/ScriptDebugListener.h:
- inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::ScriptDebugServer):
(Inspector::ScriptDebugServer::dispatchBreakpointActionProbe):
(Inspector::ScriptDebugServer::handleBreakpointHit):
- inspector/ScriptDebugServer.h:
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::InspectorDebuggerAgent):
(Inspector::InspectorDebuggerAgent::breakpointActionProbe):
- inspector/agents/InspectorDebuggerAgent.h:
Source/WebCore:
Update the signature for breakpointActionProbe to take batchId and sampleId.
Covered by existing test inspector-protocol/debugger/didSampleProbe-multiple-probes.html.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::breakpointActionProbe):
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createProbeSampleData):
- inspector/TimelineRecordFactory.h:
LayoutTests:
Patch by Katie Madonna <madonnk@gmail.com>
Update test to also cover expected probe sampleId behavior.
- inspector-protocol/debugger/didSampleProbe-multiple-probes-expected.txt:
- inspector-protocol/debugger/didSampleProbe-multiple-probes.html:
- 2:01 PM Changeset in webkit [176816] by
-
- 4 edits4 adds in trunk
Groove/inset/outset borders show solid if the color is black
https://bugs.webkit.org/show_bug.cgi?id=58608
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/borders/mixed-border-style2.html
This patch will lighten/darken the border side colors, handling
border decoration in a similar way as Firefox does.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::calculateBorderStyleColor):
- rendering/RenderObject.h:
LayoutTests:
- fast/borders/mixed-border-style2.html: Added.
- platform/mac-mavericks/fast/borders/mixed-border-style2-expected.png: Added.
- platform/mac-mavericks/fast/borders/mixed-border-style2-expected.txt: Added.
- 1:56 PM Changeset in webkit [176815] by
-
- 4 edits in trunk
Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
https://bugs.webkit.org/show_bug.cgi?id=138898
Reviewed by Mark Rowe.
Source/WebInspectorUI:
In Production builds, if FORCE_TOOL_INSTALL=YES is in the environment
we will copy all resources (for Tests) and still do the combine and
optimize phase for normal Production inspection resources.
- Scripts/copy-user-interface-resources.pl:
LayoutTests:
- platform/mac/TestExpectations:
- 1:49 PM Changeset in webkit [176814] by
-
- 6 edits in trunk/Tools
Don't lock perf tests in run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=139264
Reviewed by Daniel Bates.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
- Scripts/webkitpy/layout_tests/controllers/manager.py:
- Scripts/webkitpy/layout_tests/models/test_input.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
- 1:48 PM Changeset in webkit [176813] by
-
- 4 edits in trunk/Source/WebCore
Move 'webkit-aspect-ratio' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139250
Reviewed by Sam Weinig.
Move 'aspect-ratio' CSS property to the new StyleBuilder by
using custom code.
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue): Deleted.
(WebCore::ApplyPropertyAspectRatio::applyInitialValue): Deleted.
(WebCore::ApplyPropertyAspectRatio::applyValue): Deleted.
(WebCore::ApplyPropertyAspectRatio::createHandler): Deleted.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInitialWebkitAspectRatio):
(WebCore::StyleBuilderCustom::applyInheritWebkitAspectRatio):
(WebCore::StyleBuilderCustom::applyValueWebkitAspectRatio):
- 1:32 PM Changeset in webkit [176812] by
-
- 2 edits in trunk/Source/WebCore
Further fix the 32-bit build.
- page/mac/TextIndicatorWindow.mm:
(WebCore::TextIndicatorWindow::setTextIndicator):
- 1:10 PM Changeset in webkit [176811] by
-
- 7 edits in trunk/Source
Fix the 32-bit build.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setTextIndicator:fadeOut:animationCompletionHandler:]):
- WebView/WebView.mm:
(-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
- page/mac/TextIndicatorWindow.h:
- page/mac/TextIndicatorWindow.mm:
(WebCore::TextIndicatorWindow::setTextIndicator):
- 11:58 AM Changeset in webkit [176810] by
-
- 12 edits in trunk/Source
TextIndicator::createWithSelectionInFrame does synchronous IPC in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=139252
<rdar://problem/19140827>
Reviewed by Anders Carlsson.
It turns out contentsToScreen requires sync IPC in Mac WebKit2, which we
really don't want to be doing here (especially since the UI process will often
be sitting in waitForAndDispatchImmediately waiting for didPerformActionMenuHitTest).
Go back to keeping TextIndicator rects in "window" coordinates and do the conversion
in each of the WebKits instead of trying to share that code.
- WebCore.exp.in:
- page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithSelectionInFrame):
(WebCore::TextIndicator::TextIndicator):
- page/TextIndicator.h:
(WebCore::TextIndicator::selectionRectInWindowCoordinates):
(WebCore::TextIndicator::textBoundingRectInWindowCoordinates):
(WebCore::TextIndicator::selectionRectInScreenCoordinates): Deleted.
(WebCore::TextIndicator::textBoundingRectInScreenCoordinates): Deleted.
Go back to keeping the rects in "window" coordinates.
- page/mac/TextIndicatorWindow.h:
- page/mac/TextIndicatorWindow.mm:
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
(WebCore::TextIndicatorWindow::setTextIndicator):
Let callers pass in the contentRect instead of trying to share the code
to compute it, since it needs to be different for legacy and modern WebKit.
- WebView/WebView.mm:
(-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
Adjust to the WebCore changes.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):
- UIProcess/API/mac/WKView.mm:
(-[WKView _setTextIndicator:fadeOut:animationCompletionHandler:]):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):
Adjust to the WebCore changes.
- 11:57 AM Changeset in webkit [176809] by
-
- 4 edits in branches/safari-600.3-branch/Source
Merged r176803. rdar://problems/19034499
- 11:54 AM Changeset in webkit [176808] by
-
- 3 edits in branches/safari-600.3-branch/Source/WebCore
Merge r176682. rdar://problems/18903995
- 11:47 AM Changeset in webkit [176807] by
-
- 11 edits in branches/safari-600.3-branch/Source
Merge r176766. rdar://problems/19072083
- 11:39 AM Changeset in webkit [176806] by
-
- 4 edits in trunk/Source/WebKit2
Simplify StorageManager callback functions
https://bugs.webkit.org/show_bug.cgi?id=139257
Reviewed by Antti Koivisto.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::getOrigins):
(WebKit::StorageManager::getStorageDetailsByOrigin):
(WebKit::callCallbackFunction): Deleted.
(WebKit::StorageManager::getOriginsInternal): Deleted.
(WebKit::StorageManager::getStorageDetailsByOriginInternal): Deleted.
- UIProcess/Storage/StorageManager.h:
- UIProcess/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::getStorageDetailsByOrigin):
(WebKit::didGetKeyValueStorageOrigins): Deleted.
(WebKit::didGetStorageDetailsByOrigin): Deleted.
- 11:22 AM Changeset in webkit [176805] by
-
- 2 edits in trunk/Source/WTF
Fix cast-align warning in StringImpl.h
https://bugs.webkit.org/show_bug.cgi?id=139222
Reviewed by Anders Carlsson.
- wtf/text/StringImpl.h:
(WTF::StringImpl::tailPointer):
- 11:21 AM Changeset in webkit [176804] by
-
- 24 edits in branches/safari-600.3-branch/Source
Merge r173235. rdar://problems/19072083
- 10:31 AM Changeset in webkit [176803] by
-
- 4 edits in trunk/Source
Serialization of MapData object provides unsafe access to internal types
https://bugs.webkit.org/show_bug.cgi?id=138653
Patch by Oliver Hunt <oliver@apple.com> on 2014-12-04
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Converting these ASSERTs into RELEASE_ASSERTs, as it is now obvious
that despite trying hard to be safe in all cases it's simply to easy
to use an iterator in an unsafe state.
- runtime/MapData.h:
(JSC::MapData::const_iterator::key):
(JSC::MapData::const_iterator::value):
Source/WebCore:
We now keep the value portion of the key/value pair in MapData as a
separate stack. This allows us to maintain the spec semantic of
"atomic" serialisation of the key/value pair without retaining the
use of a potentially invalid iterator.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
- 9:41 AM Changeset in webkit [176802] by
-
- 2 edits in trunk/Source/WebKit2
URTBF after r176794.
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::fileCreationTime):
(WebKit::fileModificationTime):
- 9:40 AM Changeset in webkit [176801] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merge r176697. rdar://problems/19121822
- 9:18 AM Changeset in webkit [176800] by
-
- 2 edits in trunk/Tools
http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
https://bugs.webkit.org/show_bug.cgi?id=139243
Reviewed by Anders Carlsson.
We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
chance to allow untrusted certificates.
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
Set up more client objects for secondary windows. We may be able to share some of the
code with main view creation function, but it's not exactly the same (notably, we
do not focus a secondary window when it's done loading).
- 9:11 AM Changeset in webkit [176799] by
-
- 11 edits in branches/safari-600.3-branch/Source
Rollout r176766. rdar://problems/19072083
- 9:05 AM Changeset in webkit [176798] by
-
- 32 edits6 adds in trunk/Source/WebCore
[SVG Masking] Add support for referencing <mask> elements from -webkit-mask-image
https://bugs.webkit.org/show_bug.cgi?id=139092
Reviewed by Simon Fraser.
This patch improves the -webkit-mask-image property by allowing it to reference
a <mask> element defined in an inline or external SVG document.
Up until now, each image to be used as a mask consisted of a FillLayer object
whose m_image member represented the mask. Now, in order to accomodate
<mask> elements referenced by a fragment identifier (e.g. file.svg#mask1)
a new class was created (MaskImageOperation) and added as a member of the
FillLayer. As such, from now on, all FillLayer objects used for masking will
store the masking information in this new member.
When parsing the -webkit-mask-image property (or the -webkit-mask shorthand)
a new MaskImageOperation object is created for each image. If the value represents
an external URL, a pending SVG document will be created which will be loaded
during the phase that loads the pending resources. When the download is complete,
the MaskImageOperation is notified by the CachedSVGDocument class and checks if
the received download is a valid SVG and the requested fragment identifier
actually exists and identifies a <mask> element. If it does, that element's
renderer (of type RenderSVGResourceMasker) will be used when painting the mask layers.
Otherwise, the MaskImageOperation class will use the already downloaded data
buffer to create a CachedImage from it and use that instead, basically emulating
the previous behavior, when only images were accepted. This ensures that all existing
behavior, like painting entire SVGs, painting normal images (e.g. PNG/JPG), painting
generated images (e.g. linear-gradient) works as it did before.
No new tests required, this patch doesn't change any current functionality.
It only adds support for referencing <mask> elements for the -webkit-mask-image
property. This is sub-part 1 of the bigger patch https://bugs.webkit.org/show_bug.cgi?id=129682.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSValue.cpp:
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isWebKitCSSResourceValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::createMaskImageOperations):
- css/StyleResolver.h:
(WebCore::StyleResolver::State::maskImagesWithPendingSVGDocuments):
- css/WebKitCSSResourceValue.cpp: Added.
(WebCore::WebKitCSSResourceValue::WebKitCSSResourceValue):
(WebCore::WebKitCSSResourceValue::customCSSText):
(WebCore::WebKitCSSResourceValue::isCSSValueNone):
- css/WebKitCSSResourceValue.h: Added.
(WebCore::WebKitCSSResourceValue::create):
(WebCore::WebKitCSSResourceValue::innerValue):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::addCachedResource):
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::CachedSVGDocument):
(WebCore::CachedSVGDocument::finishLoading):
- loader/cache/CachedSVGDocument.h:
- loader/cache/CachedSVGDocumentReference.cpp:
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::load):
- loader/cache/CachedSVGDocumentReference.h:
- page/FrameView.cpp:
(WebCore::FrameView::isSVGDocument):
- page/FrameView.h:
- page/Page.cpp:
(WebCore::Page::createPageFromBuffer):
- page/Page.h:
- platform/ScrollView.h:
(WebCore::ScrollView::isSVGDocument):
- platform/graphics/MaskImageOperation.cpp: Added.
(WebCore::MaskImageOperation::create):
(WebCore::MaskImageOperation::MaskImageOperation):
(WebCore::MaskImageOperation::~MaskImageOperation):
(WebCore::MaskImageOperation::isCSSValueNone):
(WebCore::MaskImageOperation::cssValue):
(WebCore::MaskImageOperation::isMaskLoaded):
(WebCore::MaskImageOperation::setRenderLayerImageClient):
(WebCore::MaskImageOperation::addRendererImageClient):
(WebCore::MaskImageOperation::removeRendererImageClient):
(WebCore::MaskImageOperation::getOrCreateCachedSVGDocumentReference):
(WebCore::MaskImageOperation::notifyFinished): This is the method that gets called when the document has finished
downloading and checks if it can find a valid <mask> element.
(WebCore::MaskImageOperation::drawMask):
(WebCore::MaskImageOperation::getSVGMasker):
- platform/graphics/MaskImageOperation.h: Added.
- rendering/RenderBoxModelObject.cpp: The BackgroundImageGeometry class was moved out of RenderBoxModelObject in
order to be used as a parameter for other methods. This was necessary to avoid having methods with very many parameters.
(WebCore::BackgroundImageGeometry::setNoRepeatX):
(WebCore::BackgroundImageGeometry::setNoRepeatY):
(WebCore::BackgroundImageGeometry::useFixedAttachment):
(WebCore::BackgroundImageGeometry::clip):
(WebCore::BackgroundImageGeometry::relativePhase):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::clip): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::relativePhase): Deleted.
- rendering/RenderBoxModelObject.h:
(WebCore::BackgroundImageGeometry::BackgroundImageGeometry):
(WebCore::BackgroundImageGeometry::destOrigin):
(WebCore::BackgroundImageGeometry::setDestOrigin):
(WebCore::BackgroundImageGeometry::destRect):
(WebCore::BackgroundImageGeometry::setDestRect):
(WebCore::BackgroundImageGeometry::phase):
(WebCore::BackgroundImageGeometry::setPhase):
(WebCore::BackgroundImageGeometry::tileSize):
(WebCore::BackgroundImageGeometry::setTileSize):
(WebCore::BackgroundImageGeometry::spaceSize):
(WebCore::BackgroundImageGeometry::setSpaceSize):
(WebCore::BackgroundImageGeometry::setPhaseX):
(WebCore::BackgroundImageGeometry::setPhaseY):
(WebCore::BackgroundImageGeometry::setHasNonLocalGeometry):
(WebCore::BackgroundImageGeometry::hasNonLocalGeometry):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::BackgroundImageGeometry): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destOrigin): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestOrigin): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::destRect): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setDestRect): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::phase): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhase): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::tileSize): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setTileSize): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::spaceSize): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setSpaceSize): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseX): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setPhaseY): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setHasNonLocalGeometry): Deleted.
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::hasNonLocalGeometry): Deleted.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
- rendering/RenderLayer.h:
- rendering/RenderLayerMaskImageInfo.cpp: Added.
(WebCore::RenderLayer::MaskImageInfo::layerToMaskMap): Returns a static map that links MaskImageInfo objects to RenderLayers.
(WebCore::RenderLayer::MaskImageInfo::getIfExists): Returns the MaskImageInfo associated with a specific RenderLayer.
(WebCore::RenderLayer::MaskImageInfo::get): Returns the MaskImageInfo associated with a specific RenderLayer (creates it if necessary).
(WebCore::RenderLayer::MaskImageInfo::remove): Removes the MaskImageInfo associated with a specific RenderLayer.
(WebCore::RenderLayer::MaskImageInfo::MaskImageInfo):
(WebCore::RenderLayer::MaskImageInfo::~MaskImageInfo):
(WebCore::RenderLayer::MaskImageInfo::notifyFinished): Gets called when the SVG document finished loading, triggers repaint.
(WebCore::RenderLayer::MaskImageInfo::imageChanged): Gets called when the image object changed, triggers repaint.
(WebCore::RenderLayer::MaskImageInfo::updateMaskImageClients): Goes through all mask layers and sets image/SVG clients.
Updates list of internal and external SVG references.
(WebCore::RenderLayer::MaskImageInfo::removeMaskImageClients): Removes all image/SVG clients and clears lists of internal and external SVG references.
- rendering/RenderLayerMaskImageInfo.h: Added.
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderSVGResourceMasker):
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::cullEmptyLayers):
(WebCore::FillLayer::hasNonEmptyMaskImage):
(WebCore::FillLayer::imagesAreLoaded):
- rendering/style/FillLayer.h:
(WebCore::FillLayer::maskImage):
(WebCore::FillLayer::imageOrMaskImage):
(WebCore::FillLayer::setMaskImage):
(WebCore::FillLayer::clearMaskImage):
(WebCore::FillLayer::hasMaskImage):
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applySVGMask):
(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawMaskForRenderer):
- rendering/svg/RenderSVGResourceMasker.h:
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::createElementRenderer):
(WebCore::SVGMaskElement::addClientRenderLayer):
(WebCore::SVGMaskElement::removeClientRenderLayer):
- svg/SVGMaskElement.h:
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::setCachedDocument):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
- 8:36 AM Changeset in webkit [176797] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r176777. rdar://problems/19115662
- 8:35 AM Changeset in webkit [176796] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r176775. rdar://problems/19115662
- 8:35 AM Changeset in webkit [176795] by
-
- 11 edits in branches/safari-600.3-branch/Source
Merged r176766. rdar://problems/19072083
- 8:35 AM Changeset in webkit [176794] by
-
- 7 edits in trunk/Source/WebKit2
Add a way to delete local storage origins modified after a given date
https://bugs.webkit.org/show_bug.cgi?id=139249
Reviewed by Tim Horton.
Also change LocalStorageDatabaseTracker to hold on to WTF::Optional time_t values
instead of treating missing values as zero.
- UIProcess/LocalStorageDetails.h:
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::fileCreationTime):
(WebKit::fileModificationTime):
(WebKit::LocalStorageDatabaseTracker::deleteDatabasesModifiedSince):
(WebKit::LocalStorageDatabaseTracker::details):
- UIProcess/Storage/LocalStorageDatabaseTracker.h:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::deleteLocalStorageOriginsModifiedSince):
- UIProcess/Storage/StorageManager.h:
- UIProcess/WebKeyValueStorageManager.cpp:
(WebKit::didGetStorageDetailsByOrigin):
- 8:35 AM Changeset in webkit [176793] by
-
- 6 edits in branches/safari-600.3-branch/Source
Merged r176763. rdar://problems/19115662
- 7:54 AM Changeset in webkit [176792] by
-
- 18 edits in branches/safari-600.3-branch/Source
Merge r176753. rdar://problems/19052381
- 7:42 AM Changeset in webkit [176791] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176707. rdar://problems/19037590
- 6:09 AM Changeset in webkit [176790] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r176789.
https://bugs.webkit.org/show_bug.cgi?id=139255
Broke the non Mac-WK2 builds (Requested by stavila on
#webkit).
Reverted changeset:
"Remove isSpecifiedFont boolean from FontDescription"
https://bugs.webkit.org/show_bug.cgi?id=139233
http://trac.webkit.org/changeset/176789
- 3:50 AM Changeset in webkit [176789] by
-
- 5 edits in trunk/Source/WebCore
Remove isSpecifiedFont boolean from FontDescription
https://bugs.webkit.org/show_bug.cgi?id=139233
Reviewed by Andreas Kling.
It is barely used.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInheritFontFamily):
(WebCore::StyleBuilderCustom::applyValueFontFamily):
- platform/graphics/FontDescription.cpp:
(WebCore::genericFamiliesSet):
(WebCore::FontDescription::hasGenericFirstFamily):
Add a function to test for generic families.
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::setTextRenderingMode):
(WebCore::FontDescription::operator==):
(WebCore::FontDescription::isSpecifiedFont): Deleted.
(WebCore::FontDescription::setIsSpecifiedFont): Deleted.
- rendering/RenderText.cpp:
(WebCore::RenderText::computeUseBackslashAsYenSymbol):
This is the only client.
Figure out the equivalent information dynamically if needed.
- 2:18 AM Changeset in webkit [176788] by
-
- 2 edits in trunk/LayoutTests
[EFL][WebGL] Remove junk webgl layout tests from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=139253
Reviewed by Gyuyoung Kim.
- platform/efl/TestExpectations:
- 2:10 AM Changeset in webkit [176787] by
-
- 2 edits in trunk
can not find cairo-gl.h when build webkit with gtk on ubuntu 14.04
https://bugs.webkit.org/show_bug.cgi?id=136576
Reviewed by Carlos Garcia Campos.
CMake should complain if Accelerated 2D Canvas is explicitly
enabled but cairo-gl is not found.
- Source/cmake/OptionsGTK.cmake:
- 1:23 AM Changeset in webkit [176786] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Add ewk API to allow accepting a specific TLS certificate for a specific host
https://bugs.webkit.org/show_bug.cgi?id=131160
Reviewed by Gyuyoung Kim.
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::allowSpecificHTTPSCertificateForHost):
(ewk_context_tls_certificate_for_host_allow):
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_private.h:
- UIProcess/API/efl/tests/test_ewk2_ssl.cpp:
Dec 3, 2014:
- 10:42 PM Changeset in webkit [176785] by
-
- 1 edit12 adds in trunk/Examples
Add a sample plugin to demonstrate the mute plugin API.
https://bugs.webkit.org/show_bug.cgi?id=139231
Reviewed by Anders Carlsson.
- NetscapeMuteAPIPlugin/AudioPlayer.h: Added.
- NetscapeMuteAPIPlugin/AudioPlayer.mm: Added.
(-[AudioPlayer initWithURL:]):
(-[AudioPlayer dealloc]):
(-[AudioPlayer isReadyToPlay]):
(-[AudioPlayer isPlaying]):
(-[AudioPlayer setPlaying:]):
(-[AudioPlayer isMuted]):
(-[AudioPlayer setMuted:]):
(-[AudioPlayer observeValueForKeyPath:ofObject:change:context:]):
- NetscapeMuteAPIPlugin/English.lproj/InfoPlist.strings: Added.
- NetscapeMuteAPIPlugin/Info.plist: Added.
- NetscapeMuteAPIPlugin/MenuHandler.h: Added.
- NetscapeMuteAPIPlugin/MenuHandler.m: Added.
(-[MenuHandler _play:]):
(-[MenuHandler _pause:]):
(-[MenuHandler validateUserInterfaceItem:]):
(-[MenuHandler initWithAudioPlayer:]):
(-[MenuHandler dealloc]):
(-[MenuHandler menu]):
- NetscapeMuteAPIPlugin/NetscapeMuteAPIPlugin.xcodeproj/project.pbxproj: Added.
- NetscapeMuteAPIPlugin/main.m: Added.
(-[PluginObject initWithNPP:audioURL:]):
(-[PluginObject dealloc]):
(-[PluginObject menuHandler]):
(-[PluginObject isPlayingAudio]):
(-[PluginObject isMuted]):
(-[PluginObject setMuted:]):
(-[PluginObject readyStateDidChangeForAudioPlayer:]):
(-[PluginObject mutedStateDidChangeForAudioPlayer:]):
(-[PluginObject playStateDidChangeForAudioPlayer:]):
(-[PluginObject _invalidateDisplayString]):
(NP_Initialize):
(NP_GetEntryPoints):
(NP_Shutdown):
(NPP_New):
(NPP_Destroy):
(NPP_SetWindow):
(NPP_NewStream):
(NPP_DestroyStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_StreamAsFile):
(NPP_Print):
(handleDraw):
(invalidatePlugin):
(handleMouseEvent):
(NPP_HandleEvent):
(NPP_URLNotify):
(NPP_GetValue):
(NPP_SetValue):
- NetscapeMuteAPIPlugin/test.html: Added.
- 7:12 PM Changeset in webkit [176784] by
-
- 2 edits in tags/Safari-601.1.11/Source/WebKit2
Merged r176769. rdar://problem/19132975
- 7:10 PM Changeset in webkit [176783] by
-
- 2 edits in tags/Safari-601.1.11/Source/WebKit2
Merged r176764. rdar://problem/19132975
- 7:08 PM Changeset in webkit [176782] by
-
- 12 edits in tags/Safari-601.1.11/Source/WebKit2
Merged r176762. rdar://problem/19132975
- 7:05 PM Changeset in webkit [176781] by
-
- 2 edits in tags/Safari-601.1.11/Source/WebKit/mac
Merged r176755. rdar://problem/19132978
- 7:02 PM Changeset in webkit [176780] by
-
- 11 edits in trunk/Source/WebCore
Use std::unique_ptr instead of PassOwnPtr|OwnPtr for Pasteboard
https://bugs.webkit.org/show_bug.cgi?id=139019
Patch by Joonghun Park <jh718.park@samsung.com> on 2014-12-03
Reviewed by Darin Adler.
No new tests, no behavior changes.
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::DataTransfer):
- dom/DataTransfer.h:
- editing/Editor.cpp:
(WebCore::Editor::dispatchCPPEvent):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::createDraggingDataTransfer):
- platform/Pasteboard.h:
- platform/efl/PasteboardEfl.cpp:
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createForGlobalSelection):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):
(WebCore::Pasteboard::create): Deleted.
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):
(WebCore::Pasteboard::create): Deleted.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):
- 6:52 PM Changeset in webkit [176779] by
-
- 10 edits in trunk/Source/JavaScriptCore
Move JavaScriptCore/dfg to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=139169
Reviewed by Filip Pizlo.
Use std::unique_ptr<>|std::make_unique<> in JavaScriptCore/dfg directory.
- dfg/DFGBasicBlock.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):
- dfg/DFGJITCompiler.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::cancel):
- dfg/DFGPlan.h:
- dfg/DFGSlowPathGenerator.h:
- dfg/DFGWorklist.h:
- ftl/FTLFail.cpp:
(JSC::FTL::fail):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
- 6:43 PM Changeset in webkit [176778] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Some webgl conformance tests crash.
<rdar://problem/19136723>
- platform/mac/TestExpectations:
- 6:32 PM Changeset in webkit [176777] by
-
- 2 edits in trunk/Source/WebKit/mac
Implement action menus for tel: URLs
https://bugs.webkit.org/show_bug.cgi?id=139240
<rdar://problem/19115662>
Reviewed by Anders Carlsson.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
Make sure to use the newly created currentActionContext... everywhere.
- 6:32 PM Changeset in webkit [176776] by
-
- 3 edits2961 adds1 delete in trunk/LayoutTests
Unreviewed. Add 1.0.3 conformance tests. Remove unused webgl test resource files.
- platform/mac/TestExpectations: Skipping 1.0.3 tests until we are at least somewhat conformant.
- webgl/1.0.3: Added.
- webgl/resources/webgl_test_files: Removed
- 6:28 PM Changeset in webkit [176775] by
-
- 2 edits in trunk/Source/WebKit/mac
Implement action menus for tel: URLs
https://bugs.webkit.org/show_bug.cgi?id=139240
<rdar://problem/19115662>
Reviewed by Anders Carlsson.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
Make sure to use the newly created currentActionContext.
- 6:12 PM Changeset in webkit [176774] by
-
- 5 edits in tags/Safari-601.1.11/Source
Versioning.
- 6:09 PM Changeset in webkit [176773] by
-
- 1 copy in tags/Safari-601.1.11
New tag.
- 6:06 PM Changeset in webkit [176772] by
-
- 3 edits in trunk/Source/WebCore
Get rid of FrameLoaderClient::dispatchWillRequestResource
https://bugs.webkit.org/show_bug.cgi?id=139235
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-03
Reviewed by Alexey Proskuryakov.
It is useless.
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchWillRequestResource): Deleted.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- 5:59 PM Changeset in webkit [176771] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r176479): DFG ASSERTION beneath emitOSRExitCall running Kraken/imaging-gaussian-blur.js.ftl-no-cjit-osr-validation and other tests
https://bugs.webkit.org/show_bug.cgi?id=139246
Reviewed by Geoffrey Garen.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
The DFG_ASSERT that checks liveness at exit time doesn't properly
handle the case where the local is not available at OSR exit time,
but the local is live in the bytecode. This now happens with the
allocated scope register when we are compiling for FTLForOSREntryMode
due to DCE done when the control flow was changed and a new entrypoint
was added in the OSR entrypoint creation phase. Therefore we silence
the assert when compiling for FTLForOSREntryMode.
- 5:40 PM Changeset in webkit [176770] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Missing getter, clients never see DragToAdjustController is enabled
https://bugs.webkit.org/show_bug.cgi?id=139228
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-03
Reviewed by Simon Fraser.
- UserInterface/Controllers/DragToAdjustController.js:
(WebInspector.DragToAdjustController.prototype.get enabled):
- 5:31 PM Changeset in webkit [176769] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r176457.
https://bugs.webkit.org/show_bug.cgi?id=139247
More iOS breakage (Requested by andersca on #webkit).
Reverted changeset:
"Fix iOS build."
http://trac.webkit.org/changeset/176457
- 5:30 PM Changeset in webkit [176768] by
-
- 3 edits2 adds in trunk
List markers in RTL languages do not draw the first character.
https://bugs.webkit.org/show_bug.cgi?id=139244
Reviewed by Simon Fraser.
Source/WebCore:
Off-by-one error when reversing the string (from LTR to RTL)
Test: fast/lists/rtl-marker.html
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
LayoutTests:
- fast/lists/rtl-marker-expected.html: Added.
- fast/lists/rtl-marker.html: Added.
- 5:08 PM Changeset in webkit [176767] by
-
- 5 edits in tags/Safari-600.3.8.2/Source
Versioning.
- 5:06 PM Changeset in webkit [176766] by
-
- 11 edits in trunk/Source
<input> elements get whitespace action menu instead of editable text menu
https://bugs.webkit.org/show_bug.cgi?id=139241
-and corresponding-
rdar://problem/19072083
Reviewed by Sam Weinig.
Source/WebCore:
Since we will hit test form controls as form controls, we need a new function to
determine if the hit point is over text inside that form control or not.
- WebCore.exp.in:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isOverTextInsideFormControlElement):
- rendering/HitTestResult.h:
Source/WebKit/mac:
We should disallow shadow content in the hit test. This is the default and it is
how context menus behave. We originally wanted to text inside shadow content so
that we could find the text, but the new function I added to HitTestResult will
allow that.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController performHitTestAtPoint:]):
Adjust to the fact that we don’t hit test shadow content any more.
(-[WebActionMenuController focusAndSelectHitTestResult]):
Offer the text menus for text inside form controls.
(-[WebActionMenuController _defaultMenuItems]):
Source/WebKit2:
Add isOverTextInsideFormControlElement to WebHitTestResult.
- Shared/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::Data::Data):
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):
- Shared/WebHitTestResult.h:
(WebKit::WebHitTestResult::isOverTextInsideFormControlElement):
Offer the text menus for text inside form controls.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItems]):
We should disallow shadow content in the hit test. This is the default and it is
how context menus behave. We originally wanted to text inside shadow content so
that we could find the text, but the new function I added to HitTestResult will
allow that.
- WebProcess/WebPage/mac/WebPageMac.mm:
Adjust to the fact that we don’t hit test shadow content any more.
(WebKit::WebPage::performActionMenuHitTestAtLocation):
(WebKit::WebPage::lookupTextAtLocation):
(WebKit::WebPage::focusAndSelectLastActionMenuHitTestResult):
- 5:04 PM Changeset in webkit [176765] by
-
- 1 copy in tags/Safari-600.3.8.2
New tag.
- 4:51 PM Changeset in webkit [176764] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r176489.
https://bugs.webkit.org/show_bug.cgi?id=139242
More iOS breakage (Requested by andersca on #webkit).
Reverted changeset:
"Unreviewed, iOS build fix after r176452."
http://trac.webkit.org/changeset/176489
- 4:33 PM Changeset in webkit [176763] by
-
- 6 edits in trunk/Source
Implement action menus for tel: URLs
https://bugs.webkit.org/show_bug.cgi?id=139240
<rdar://problem/19115662>
Reviewed by Anders Carlsson.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForDataDetectableLink]):
Rename this function as it will work for both mailto and tel URLs.
Adjust it to use contextForView:.
(-[WebActionMenuController webView:willHandleMouseDown:]):
(-[WebActionMenuController prepareForMenu:withEvent:]):
(-[WebActionMenuController didCloseMenu:withEvent:]):
(-[WebActionMenuController _defaultMenuItems]):
Don't check the menu type when going to interact with _currentActionContext.
We'll only have a _currentActionContext if we have a data detected item,
and there are multiple menu types that end up using DDActionContext.
- WebView/WebUIDelegatePrivate.h:
Add a new type.
- Shared/API/c/WKActionMenuTypes.h:
Add a new type.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForDataDetectableLink]):
Rename this function as it will work for both mailto and tel URLs.
Adjust it to use contextForView:.
(-[WKActionMenuController _clearActionMenuState]):
(-[WKActionMenuController menuNeedsUpdate:]):
(-[WKActionMenuController _defaultMenuItems]):
Don't check the menu type when going to interact with _currentActionContext.
We'll only have a _currentActionContext if we have a data detected item,
and there are multiple menu types that end up using DDActionContext.
- 4:16 PM Changeset in webkit [176762] by
-
- 12 edits in trunk/Source/WebKit2
Unreviewed, rolling out r176452 and r176559.
https://bugs.webkit.org/show_bug.cgi?id=139239
Broke iOS (Requested by andersca on #webkit).
Reverted changesets:
"Remove alignment code from IPC coders"
https://bugs.webkit.org/show_bug.cgi?id=138963
http://trac.webkit.org/changeset/176452
"[WK2] SecComp buildfix after r176452"
https://bugs.webkit.org/show_bug.cgi?id=139081
http://trac.webkit.org/changeset/176559
Patch by Commit Queue <commit-queue@webkit.org> on 2014-12-03
- 4:00 PM Changeset in webkit [176761] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed gardening.
Land expected result for fast/dom/timer-throttle-on-scrolling-iframe-away.html
that was missing in r176729.
- fast/dom/timer-throttle-on-scrolling-iframe-away-expected.txt: Added.
- 3:53 PM Changeset in webkit [176760] by
-
- 5 edits in tags/Safari-600.3.8.1/Source
Versioning.
- 3:53 PM Changeset in webkit [176759] by
-
- 2 edits2 deletes in trunk/LayoutTests
Unreviewed. Remove 1.0.1 and experimental 1.0.3 WebGL conformance tests to make way for official 1.0.3 tests.
- 3:50 PM Changeset in webkit [176758] by
-
- 1 copy in tags/Safari-600.3.8.1
New tag.
- 3:39 PM Changeset in webkit [176757] by
-
- 1 edit1 copy1 add in trunk/LayoutTests
http/tests/misc/authentication-redirect tests use the same authentication realm
https://bugs.webkit.org/show_bug.cgi?id=139225
Land custom results for WebKit2, because the format of output is different there.
- platform/wk2/http/tests/misc/authentication-redirect-3: Added.
- platform/wk2/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt.
- 3:23 PM Changeset in webkit [176756] by
-
- 12 edits in trunk/Source/JavaScriptCore
Removed the global parser arena
https://bugs.webkit.org/show_bug.cgi?id=139236
Reviewed by Sam Weinig.
Simplifies parser lifetime logic.
There's no need to keep a global arena. We can create a new arena
each time we parse.
- bytecompiler/BytecodeGenerator.h: Global replace to pass around a
ParserArena instead of VM*, since the VM no longer owns the arena.
(JSC::BytecodeGenerator::parserArena):
- bytecompiler/NodesCodegen.cpp: Ditto.
(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
- parser/ASTBuilder.h: Ditto.
(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::createSourceElements):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createSpreadExpression):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArguments):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createElementList):
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createClause):
(JSC::ASTBuilder::createClauseList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createForOfLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createEmptyVarExpression):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::createDeconstructingAssignment):
(JSC::ASTBuilder::Scope::Scope):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
- parser/NodeConstructors.h: Ditto.
(JSC::ParserArenaFreeable::operator new):
(JSC::ParserArenaDeletable::operator new):
(JSC::ParserArenaRefCounted::ParserArenaRefCounted):
- parser/Nodes.cpp: Ditto.
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
- parser/Nodes.h: Ditto.
(JSC::ScopeNode::parserArena):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseProperty): The parser now owns its own
arena, and transfers ownership of its contents when invoking the ScopeNode
constructor.
- parser/Parser.h:
(JSC::Parser<LexerType>::parse): No need to explicitly reset the arena,
since its lifetime is tied to the parser's lifetime now.
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h: The point of the patch: no more global.
- 3:01 PM Changeset in webkit [176755] by
-
- 2 edits in trunk/Source/WebKit/mac
Set a visited link store when creating a simple WebView
https://bugs.webkit.org/show_bug.cgi?id=139234
<rdar://problem/19132978>
Reviewed by Sam Weinig.
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
- 1:54 PM Changeset in webkit [176754] by
-
- 6 edits in trunk/Source/JavaScriptCore
The parser should allocate all pieces of the AST
https://bugs.webkit.org/show_bug.cgi?id=139230
Reviewed by Oliver Hunt.
This is a step toward a 14% parsing speedup.
Previously, allocation was split between the parser and certain node
constructor functions. This made for some duplicated code and circular
dependencies.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createGetterOrSetterProperty): No need to pass through
the VM, since our callee no longer needs to allocate anything.
(JSC::ASTBuilder::createProperty): Allocate the identifier for our
callee, since that is simpler than requiring our callee to notice that
we didn't do so, and do it for us.
(JSC::ASTBuilder::createForInLoop): Allocate the DeconstructingAssignmentNode
for our callee, since that is simpler than requiring our callee to notice
that we didn't do so, and do it for us.
Also, reuse some code instead of duplicating it.
(JSC::ASTBuilder::createForOfLoop): Ditto.
(JSC::ASTBuilder::createArrayPattern):
(JSC::ASTBuilder::createObjectPattern):
(JSC::ASTBuilder::createBindingLocation): No need to pass through a VM
pointer, since our callee no longer needs to allocate anything.
(JSC::ASTBuilder::createBreakStatement): Deleted.
(JSC::ASTBuilder::createContinueStatement): Deleted.
- parser/NodeConstructors.h:
(JSC::PropertyNode::PropertyNode):
(JSC::DeconstructionPatternNode::DeconstructionPatternNode):
(JSC::ArrayPatternNode::ArrayPatternNode):
(JSC::ArrayPatternNode::create):
(JSC::ObjectPatternNode::ObjectPatternNode):
(JSC::ObjectPatternNode::create):
(JSC::BindingNode::create):
(JSC::BindingNode::BindingNode):
(JSC::ContinueNode::ContinueNode): Deleted.
(JSC::BreakNode::BreakNode): Deleted.
(JSC::EnumerationNode::EnumerationNode): Deleted.
(JSC::ForInNode::ForInNode): Deleted.
(JSC::ForOfNode::ForOfNode): Deleted. Deleted a bunch of special cases
that don't exist anymore, now that the parser allocates all pieces of
the AST unconditionally.
- parser/Nodes.h: Ditto.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseBreakStatement):
(JSC::Parser<LexerType>::parseContinueStatement): Allocate the null
identifier for our callee, since that is simpler than requiring our
callee to notice that we didn't do so, and do it for us.
(JSC::Parser<LexerType>::parseProperty):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createProperty): No need to pass through a VM
pointer, since our callee no longer needs to allocate anything.
- 1:53 PM Changeset in webkit [176753] by
-
- 18 edits in trunk/Source
Keyboard input should be disabled in the preview popover
https://bugs.webkit.org/show_bug.cgi?id=139219
<rdar://problem/19052381>
Reviewed by Anders Carlsson.
Make sure that keyboard input, Quick Look, etc. are blocked in preview popovers
and WKThumbnailViews. Also block the fake mouseMove events that originate in
the Web process upon scrolling, because we were missing those despite blocking
ordinary mouseMove events.
- page/ChromeClient.h:
(WebCore::ChromeClient::shouldDispatchFakeMouseMoveEvents):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
Allow ChromeClient to disable the dispatch of "fake" mouseMove events
that happens during scrolling.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
Rename _ignoresNonWheelMouseEvents to _ignoresNonWheelEvents, because it will
apply not only to mouse events but also key events, Quick Look events, menu
preparation events, swipe events, etc.
Add _ignoresAllEvents, which means the same thing as _ignoresNonWheelEvents
with the addition of ignoring scrollWheel events.
(-[WKView scrollWheel:]):
(-[WKView swipeWithEvent:]):
(-[WKView mouseMoved:]):
(-[WKView mouseDown:]):
(-[WKView mouseUp:]):
(-[WKView mouseDragged:]):
Adjust to the new name.
(-[WKView performKeyEquivalent:]):
(-[WKView keyUp:]):
(-[WKView keyDown:]):
(-[WKView flagsChanged:]):
(-[WKView quickLookWithEvent:]):
(-[WKView prepareForMenu:withEvent:]):
(-[WKView willOpenMenu:withEvent:]):
(-[WKView didCloseMenu:withEvent:]):
Block all of these events as well as those we were previously blocking.
(-[WKView _setIgnoresAllEvents:]):
(-[WKView _setIgnoresNonWheelMouseEvents:]):
(-[WKView _setIgnoresNonWheelEvents:]):
(-[WKView _ignoresNonWheelEvents]):
(-[WKView _ignoresAllEvents]):
- UIProcess/API/mac/WKViewInternal.h:
Adjust to the new names and the addition of ignoresAllEvents.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKPagePreviewViewController loadView]):
Adjust to the new name.
(-[WKActionMenuController prepareForMenu:withEvent:]):
Move bailing from prepareForMenu: up to WKView.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _ignoresNonWheelEvents]):
(-[WKWebView _setIgnoresNonWheelEvents:]):
(-[WKWebView _ignoresNonWheelMouseEvents]): Deleted.
(-[WKWebView _setIgnoresNonWheelMouseEvents:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
Adjust to the new name (without "mouse" in it).
- UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView _viewWasUnparented]):
(-[_WKThumbnailView _viewWasParented]):
Explicitly tell WKView to disable event handling while thumbnailed,
instead of having WKView special-case thumbnail views internally.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setShouldDispatchFakeMouseMoveEvents):
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldDispatchFakeMouseMoveEvents):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::shouldDispatchFakeMouseMoveEvents):
(WebKit::WebPage::setShouldDispatchFakeMouseMoveEvents):
- WebProcess/WebPage/WebPage.messages.in:
Plumb shouldDispatchFakeMouseMoveEvents from the UI process to the Web process
and through to WebKit2's ChromeClient implementation.
- 1:45 PM Changeset in webkit [176752] by
-
- 6 edits in trunk/LayoutTests
http/tests/misc/authentication-redirect tests use the same authentication realm
https://bugs.webkit.org/show_bug.cgi?id=139225
Reviewed by Tim Horton.
- http/tests/misc/authentication-redirect-1/resources/auth-then-redirect.php:
- http/tests/misc/authentication-redirect-2/resources/auth-then-redirect.php:
- http/tests/misc/authentication-redirect-3/resources/auth-then-redirect-with-url-credentials.php:
- http/tests/misc/authentication-redirect-3/resources/auth-then-redirect.php:
Use different realms.
- http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt:
This test's results no longer depend on previous tests.
- 1:01 PM Changeset in webkit [176751] by
-
- 15 edits in trunk/Source/WebCore
Remove genericFamily enum from FontDescription
https://bugs.webkit.org/show_bug.cgi?id=139207
Reviewed by Andreas Kling.
We use predefined AtomicStrings for generic families. The side enum adds no information.
- css/CSSFontSelector.cpp:
(WebCore::resolveGenericFamily):
(WebCore::CSSFontSelector::getFontData):
Match the existing quirk where the default font can be replaced by @font-face rule but user generic families can't.
(WebCore::CSSFontSelector::resolvesFamilyFor):
(WebCore::fontDataForGenericFamily): Deleted.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyFontFamily::applyInheritValue):
(WebCore::ApplyPropertyFontFamily::applyInitialValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::checkForGenericFamilyChange):
Remove the explicit monospace check, earlier useFixedDefaultSize check is equivalent.
(WebCore::StyleResolver::initializeFontStyle):
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::useFixedDefaultSize):
(WebCore::FontDescription::setWeight):
(WebCore::FontDescription::equalForTextAutoSizing):
(WebCore::FontDescription::operator==):
(WebCore::FontDescription::genericFamily): Deleted.
(WebCore::FontDescription::setGenericFamily): Deleted.
- platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::controlFont):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
Reset the lineheight unconditionally for buttons.
This always happened before because the explicitly set generic family made the font compare false.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::systemFont):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemFont):
(WebCore::RenderThemeMac::setFontFromControlSize):
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
Resolve document style for final value immediately as it can't be affected by @font-face rules.
- 12:53 PM Changeset in webkit [176750] by
-
- 3 edits2 adds in trunk
ASSERTION: RenderMultiColumnFlowThread::processPossibleSpannerDescendant() when column spanner's parent is not a RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=139188
rdar://problem/18502182
Reviewed by David Hyatt.
This patch ensures that the validation check for spanner in isValidColumnSpanner() is in synch
with the expectation in RenderMultiColumnFlowThread::processPossibleSpannerDescendant().
(descendant's parent is expected to be a RenderBlockFlow)
Source/WebCore:
Test: fast/multicol/svg-content-as-column-spanner-crash.html
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::isValidColumnSpanner):
LayoutTests:
- fast/multicol/svg-content-as-column-spanner-crash-expected.txt: Added.
- fast/multicol/svg-content-as-column-spanner-crash.html: Added.
- 12:42 PM Changeset in webkit [176749] by
-
- 3 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r176695. rdar://problems/19120929
- 12:37 PM Changeset in webkit [176748] by
-
- 5 edits in trunk/Source
[TexMap] Redundant method in GraphicsLayerTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=138005
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-03
Reviewed by Alex Christensen.
The TextureMapperLayer method descendantsOrSelfHaveRunningAnimations() can be used
instead of the GraphicsLayerTextureMapper method startedAnimation().
Source/WebCore:
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::addAnimation):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
Source/WebKit/win:
- WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::startedAnimation):
- 12:36 PM Changeset in webkit [176747] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r176694. rdar://problems/18944696
- 12:36 PM Changeset in webkit [176746] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r176693. rdar://problems/18944696
- 12:36 PM Changeset in webkit [176745] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r176692. rdar://problems/18944696
- 12:36 PM Changeset in webkit [176744] by
-
- 4 edits in branches/safari-600.3-branch/Source
Merged r176691. rdar://problems/18944696
- 12:36 PM Changeset in webkit [176743] by
-
- 4 edits in branches/safari-600.3-branch/Source
Merged r176690. rdar://problems/18944696
- 12:35 PM Changeset in webkit [176742] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r176689. rdar://problems/18944696
- 12:35 PM Changeset in webkit [176741] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r176688. rdar://problems/18944696
- 12:35 PM Changeset in webkit [176740] by
-
- 8 edits2 adds in branches/safari-600.3-branch/Source
Merged r176684. rdar://problems/18944696
- 12:30 PM Changeset in webkit [176739] by
-
- 2 edits in trunk/Source/WebKit2
Remove ENABLE_UI_PROCESS_STORAGE define, it's always 1.
Rubber-stamped by Beth Dakin.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::localStorageNamespace):
(WebKit::WebPlatformStrategies::transientLocalStorageNamespace):
(WebKit::WebPlatformStrategies::sessionStorageNamespace):
- 12:16 PM Changeset in webkit [176738] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r176681. rdar://problems/19067172
- 12:15 PM Changeset in webkit [176737] by
-
- 7 edits1 add in branches/safari-600.3-branch/Source/WebKit
Merged r176680. rdar://problems/19067172
- 12:13 PM Changeset in webkit [176736] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176678. rdar://problems/19072236
- 12:10 PM Changeset in webkit [176735] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Fix merge-related build failure. rdar://problem/19122588
- 12:03 PM Changeset in webkit [176734] by
-
- 2 edits in trunk/Source/WebCore
Subtitle menu should only appear when useful.
https://bugs.webkit.org/show_bug.cgi?id=139133
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-12-03
Reviewed by Eric Carlson.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController hasLegibleMediaSelectionOptions]): only enable when there are non default options.
(-[WebAVPlayerController hasAudioMediaSelectionOptions]): only enable when there is more than one option.
- 11:59 AM Changeset in webkit [176733] by
-
- 2 edits in trunk/Source/WebKit2
Use an @autoreleasepool instead of NSAutoreleasePool.
Rubber-stamped by Tim Horton.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 11:55 AM Changeset in webkit [176732] by
-
- 3 edits2 adds in branches/safari-600.3-branch
Merged r176295. rdar://problems/19122588
- 11:51 AM Changeset in webkit [176731] by
-
- 17 edits in trunk
AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
https://bugs.webkit.org/show_bug.cgi?id=139071
Reviewed by Chris Fleizach.
Source/WebCore:
Adds a new InlineRole accessibility role type for non-focusable inline
elements which have an event handler or attribute suggesting possible
inclusion by the platform. This is mapped to ATK_ROLE_STATIC for GTK and
EFL. On the Mac, it is currently ignored to preserve existing behavior.
Added new test cases to the existing roles-exposed.html test.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsDatetimeAttribute): Added.
- accessibility/AccessibilityObject.h: Added InlineRole.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole): Handle InlineRole.
- accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Include InlineRole objects.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore InlineRole objects.
- html/HTMLTagNames.in: Added 'time'.
Tools:
Add string value for ATK_ROLE_STATIC in roleToString.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
- accessibility/roles-exposed.html: New test cases added.
- platform/efl/accessibility/roles-exposed-expected.txt: Updated for new test cases.
- platform/gtk/accessibility/roles-exposed-expected.txt: Updated for new test cases.
- platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Updated for new test cases.
- platform/mac-mountainlion/accessibility/roles-exposed-expected.txt: Updated for new test cases.
- platform/mac/accessibility/roles-exposed-expected.txt: Updated for new test cases.
- 11:36 AM Changeset in webkit [176730] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r175974. rdar://problems/19122595
- 11:16 AM Changeset in webkit [176729] by
-
- 1 edit2 adds in trunk/LayoutTests
Add layout test for DOM timer throttling in iframe scrolled out of viewport
https://bugs.webkit.org/show_bug.cgi?id=138884
Reviewed by Andreas Kling.
Add a layout test to test that a repeating DOM timer inside an iframe
get throttled if the iframe is scrolled out of the viewport.
- fast/dom/resources/timer-throttling-iframe.html: Added.
- fast/dom/timer-throttle-on-scrolling-iframe-away.html: Added.
- 11:08 AM Changeset in webkit [176728] by
-
- 4 edits in trunk
REGRESSION(r176687): Caused webkit2 test assertion failure crashes in WebKit::WebPage::willStartDrag()
https://bugs.webkit.org/show_bug.cgi?id=139224
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEventSyncForTesting): Wait for the UI process to start dragging if
needed before handling the event.
LayoutTests:
- platform/wk2/TestExpectations: Unskip the tests.
- 10:56 AM Changeset in webkit [176727] by
-
- 5 edits in trunk/Source
Versioning.
- 10:33 AM Changeset in webkit [176726] by
-
- 2 edits in trunk/LayoutTests
Gardening: updating some tests as skips instead of crashes.
<https://webkit.org/b/139224>
Not reviewed.
- platform/wk2/TestExpectations:
- 10:01 AM Changeset in webkit [176725] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Hang when calling -[AVAsset resolvedURL].
https://bugs.webkit.org/show_bug.cgi?id=139223
Reviewed by Eric Carlson.
On a particularly slow-loading site, a call to -[AVAsset resolvedURL] can take an arbitrarily long
time. Treat this AVAsset property similar to other "metadata" properties, and check the load status
of the property before requesting it.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin): Check the load state of -resolvedURL.
(WebCore::MediaPlayerPrivateAVFoundationObjC::resolvedURL): Ditto.
(WebCore::assetMetadataKeyNames): Add @"resolvedURL".
- 9:55 AM Changeset in webkit [176724] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] outdated comment
https://bugs.webkit.org/show_bug.cgi?id=137801
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-12-03
Reviewed by Carlos Garcia Campos.
Remove a comment that is no longer correct.
- NetworkProcess/gtk/NetworkProcessMainGtk.cpp:
- 9:50 AM Changeset in webkit [176723] by
-
- 2 edits in trunk/LayoutTests
Gardening: marking some tests as crashes.
<https://webkit.org/b/139224>
Not reviewed.
- platform/wk2/TestExpectations:
- 7:26 AM Changeset in webkit [176722] by
-
- 2 edits in trunk/Source/WebCore
URTBF after r176721 to fix ENABLE(CSS_DEVICE_ADAPTATION) build.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseViewportProperty):
- 6:46 AM Changeset in webkit [176721] by
-
- 5 edits in trunk/Source/WebCore
Move 'display' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139218
Reviewed by Antti Koivisto.
Move 'display' CSS property to the new StyleBuilder.
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue): Deleted.
(WebCore::ApplyPropertyDisplay::applyInheritValue): Deleted.
(WebCore::ApplyPropertyDisplay::applyInitialValue): Deleted.
(WebCore::ApplyPropertyDisplay::applyValue): Deleted.
(WebCore::ApplyPropertyDisplay::createHandler): Deleted.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::isValidDisplayValue):
(WebCore::StyleBuilderCustom::applyInheritDisplay):
(WebCore::StyleBuilderCustom::applyValueDisplay):
- css/makeprop.pl:
Add support for passing multiple values for Custom option, e.g.:
'Custom=Inherit|Value'. This was useful as we did not need custom
code for display's initial value.
- 6:39 AM Changeset in webkit [176720] by
-
- 5 edits in branches/safari-600.3-branch/Source
Bump versioning
- 6:21 AM Changeset in webkit [176719] by
-
- 5 edits in trunk/Source/WebCore
Modernize the CSSParser code
https://bugs.webkit.org/show_bug.cgi?id=139209
Reviewed by Antti Koivisto.
Modernize the CSSParser code by:
- Using more references instead of pointers
- Using nullptr instead of 0
No new tests, no behavior change.
- 5:32 AM Changeset in webkit [176718] by
-
- 3 edits in trunk/Tools
check-webkit-style is confused by ternary expression inside first member initializer
https://bugs.webkit.org/show_bug.cgi?id=136442
Patch by Renato Nagy <rnagy@inf.u-szeged.hu> on 2014-12-03
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_member_initialization_list):
- 4:20 AM Changeset in webkit [176717] by
-
- 2 edits1 add in trunk/Tools
[GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
https://bugs.webkit.org/show_bug.cgi?id=139220
Reviewed by Philippe Normand.
- gtk/jhbuild.modules:
- gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
- 3:34 AM Changeset in webkit [176716] by
-
- 4 edits in trunk
Remove unused JSC runtime options
https://bugs.webkit.org/show_bug.cgi?id=133070
Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-12-03
Reviewed by Csaba Osztrogonác.
Source/JavaScriptCore:
- runtime/Options.h:
Tools:
- Scripts/run-jsc-stress-tests:
- 3:12 AM Changeset in webkit [176715] by
-
- 2 edits in trunk/Source/WebCore
[iOS] REGRESSION (r176622): WebCore fails to link
Speculative fix for the following build failure:
Ld WebCore
Undefined symbols for architecture armv7s:
"ZN3JSC10IdentifierC1EPNS_9ExecStateERKN3WTF12AtomicStringE", referenced from:
ZN7WebCoreL24createAccelerationObjectEPKNS_16DeviceMotionData12AccelerationEPN3JSC9ExecStateE in JSDeviceMotionEventCustom.o
- bindings/js/JSDeviceMotionEventCustom.cpp: Include
<runtime/IdentifierInlines.h> to define missing symbol.
- 2:09 AM Changeset in webkit [176714] by
-
- 4 edits2 adds in trunk
[Media] Audio content shouldn't have fullscreen buttons, even if in a video element
https://bugs.webkit.org/show_bug.cgi?id=139200
<rdar://problem/18914506>
Reviewed by Eric Carlson.
Source/WebCore:
An audio-only resource, even if loaded into a <video> element, should not
present the fullscreen or optimised fullscreen controls. This includes a
MediaDocument, which is always a <video> element. We can detect this by
examining the length of the videoTracks property as our content loads.
Test: media/audio-as-video-fullscreen.html
- Modules/mediacontrols/mediaControlsApple.js:
(Controller): Initialize a hasVisualMedia to false.
(Controller.prototype.handleReadyStateChange): If we see a videoTrack, hasVisualMedia is now true.
(Controller.prototype.updateFullscreenButtons): Merge the updateFullscreenButton and
updateOptimizedFullscreenButton methods into this single spot, and check for
hasVisualMedia.
(Controller.prototype.updateFullscreenButton): Deleted.
(Controller.prototype.updateOptimizedFullscreenButton): Deleted.
- Modules/mediacontrols/mediaControlsBase.js: Do the same for the other ports.
LayoutTests:
Loads an audio file via the video element and checks if the
fullscreen button is visible.
- media/audio-as-video-fullscreen-expected.txt: Added.
- media/audio-as-video-fullscreen.html: Added.
- 2:08 AM Changeset in webkit [176713] by
-
- 3 edits in trunk/Source/WebCore
Missing support for innerHTML on SVGElement
https://bugs.webkit.org/show_bug.cgi?id=136903
Unreviewed followup from r176630. Minor style nits that I missed in my review.
- dom/Element.h: Remove unnecessary parameter name.
- html/parser/HTMLTreeBuilder.cpp: Whitespace cleanup.
(WebCore::HTMLTreeBuilder::adjustedCurrentStackItem):
- 1:25 AM Changeset in webkit [176712] by
-
- 10 edits10 copies1 add1 delete in trunk
[EFL] Add subtle crypto to the build system
https://bugs.webkit.org/show_bug.cgi?id=138612
Reviewed by Csaba Osztrogonác.
.:
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
It is obvious to make Efl use GnuTLS as well,
and since there seems no reason why to separate
Efl and Gtk implementations from each other, I
also propose renaming the gtk directory and file
suffixes to gnutls.
No new tests needed.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- crypto/gnutls/CryptoAlgorithmAES_CBCGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp.
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
- crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmAES_KWGtk.cpp.
(WebCore::CryptoAlgorithmAES_KW::platformEncrypt):
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt):
- crypto/gnutls/CryptoAlgorithmHMACGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmHMACGtk.cpp.
(WebCore::getGnutlsDigestAlgorithm):
(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
- crypto/gnutls/CryptoAlgorithmRSAES_PKCS1_v1_5GnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRSAES_PKCS1_v1_5Gtk.cpp.
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
- crypto/gnutls/CryptoAlgorithmRSASSA_PKCS1_v1_5GnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRSASSA_PKCS1_v1_5Gtk.cpp.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):
- crypto/gnutls/CryptoAlgorithmRSA_OAEPGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRSA_OAEPGtk.cpp.
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
- crypto/gnutls/CryptoAlgorithmRegistryGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoAlgorithmRegistryGtk.cpp.
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
- crypto/gnutls/CryptoDigestGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoDigestGtk.cpp.
(WebCore::CryptoDigest::CryptoDigest):
(WebCore::CryptoDigest::~CryptoDigest):
(WebCore::CryptoDigest::create):
(WebCore::CryptoDigest::addBytes):
(WebCore::CryptoDigest::computeHash):
- crypto/gnutls/CryptoKeyRSAGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/CryptoKeyRSAGtk.cpp.
(WebCore::CryptoKeyRSA::CryptoKeyRSA):
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::~CryptoKeyRSA):
(WebCore::CryptoKeyRSA::restrictToHash):
(WebCore::CryptoKeyRSA::isRestrictedToHash):
(WebCore::CryptoKeyRSA::keySizeInBits):
(WebCore::CryptoKeyRSA::buildAlgorithmDescription):
(WebCore::CryptoKeyRSA::exportData):
(WebCore::CryptoKeyRSA::generatePair):
- crypto/gnutls/SerializedCryptoKeyWrapGnuTLS.cpp: Renamed from Source/WebCore/crypto/gtk/SerializedCryptoKeyWrapGtk.cpp.
(WebCore::getDefaultWebCryptoMasterKey):
(WebCore::wrapSerializedCryptoKey):
(WebCore::unwrapSerializedCryptoKey):
- crypto/keys/CryptoKeyRSA.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- platform/efl/TestExpectations:
Dec 2, 2014:
- 10:36 PM Changeset in webkit [176711] by
-
- 3 edits4 adds in trunk
Little cleanup of the default stylesheet
https://bugs.webkit.org/show_bug.cgi?id=139168
Reviewed by Antti Koivisto.
Source/WebCore:
The default stylesheet has a lot of historical junk that need cleaning. This patch addresses
only the bits that do not change behaviors and have positive perf and readability impact.
I have limited :matches() to attributes for now. The idea is to only target
simple selectors that are not used for filtering by the collectors.
We should eventually clean up more cases, one thing at a time.
Tests: fast/css/map-tag-default-display.html
fast/selectors/map-tag-default-display.html
- css/html.css:
(map): Deleted.
map was explicitely setting its display to inline. Remove that since it is the default.
(head): Deleted.
(meta): Deleted.
(title): Deleted.
(link): Deleted.
(style): Deleted.
(script): Deleted.
(div): Deleted.
(layer): Deleted.
(article, aside, footer, header, hgroup, main, nav, section): Deleted.
(address): Deleted.
(head, link, meta, script, style, title):
(address, article, aside, div, footer, header, hgroup, layer, main, nav, section):
Group the standard blocks in a single rule.
(input:matches([type="hidden"], [type="image"], [type="file"])):
(input:matches([type="radio"], [type="checkbox"])):
(input:matches([type="button"], [type="submit"], [type="reset"])):
(input:matches([type="button"], [type="submit"], [type="reset"]), input[type="file"]::-webkit-file-upload-button, button):
(input:matches([type="button"], [type="submit"], [type="reset"]):active, input[type="file"]::-webkit-file-upload-button:active, button:active):
(input:matches([type="button"], [type="submit"], [type="reset"]):active, input[type="file"]:active::-webkit-file-upload-button, button:active):
(input[type="file"]:active:disabled::-webkit-file-upload-button, button:active:disabled):
(input:matches([type="checkbox"], [type="radio"]):checked):
(input:matches([type="checkbox"], [type="radio"]):checked:disabled):
(select:matches([size], [multiple], [size][multiple])):
(select:matches([size="0"], [size="1"])):
(input[type="hidden"], input[type="image"], input[type="file"]): Deleted.
(input[type="radio"], input[type="checkbox"]): Deleted.
(input[type="button"], input[type="submit"], input[type="reset"]): Deleted.
(input[type="button"], input[type="submit"], input[type="reset"], input[type="file"]::-webkit-file-upload-button, button): Deleted.
(input[type="button"]:active, input[type="submit"]:active, input[type="reset"]:active, input[type="file"]::-webkit-file-upload-button:active, button:active): Deleted.
(input[type="button"]:active, input[type="submit"]:active, input[type="reset"]:active, input[type="file"]:active::-webkit-file-upload-button, button:active): Deleted.
(input[type="button"]:active:disabled, input[type="submit"]:active:disabled, input[type="reset"]:active:disabled, input[type="file"]:active:disabled::-webkit-file-upload-button, button:active:disabled): Deleted.
(input[type="checkbox"]:checked, input[type="radio"]:checked): Deleted.
(input[type="checkbox"]:checked:disabled, input[type="radio"]:checked:disabled): Deleted.
(select[size][multiple]): Deleted.
(select[size="1"]): Deleted.
Group every selector lists that only differentiates complex selectors through attributes
into a simple complex selector with :matches().
LayoutTests:
Test the default display type of <map> since it is not longer explicitely set.
- fast/css/map-tag-default-display-expected.html: Added.
- fast/css/map-tag-default-display.html: Added.
- fast/selectors/map-tag-default-display-expected.txt: Added.
- fast/selectors/map-tag-default-display.html: Added.
- 8:17 PM Changeset in webkit [176710] by
-
- 3 edits in trunk/Websites/perf.webkit.org
New perf dashboard's chart UI is buggy
https://bugs.webkit.org/show_bug.cgi?id=139214
Reviewed by Chris Dumez.
The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
component. This is not how Ember.js components should interact to begin with. The component now exposes
selectedPoints and always updates selection instead of sharedSelection.
- public/v2/app.js:
(App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
(App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
and end time should be completely determined by "since" and the present time.
(App.ChartsController._startTimeChanged): Ditto.
(App.ChartsController._scheduleQueryStringUpdate):
(App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
(App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
(App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
(App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
(App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
observes the changes to selectedPoints property as it gets updated by the main chart.
(App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
the overview chart.
(App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
when domain arrays aren't identical. This was causing a subtle race with other logic.
(App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
overviewSelection will automatically propagate to the main plot's domain as they're aliased.
(App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
(App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
see if those two points correspond to a range or a single data point. Rewrote all that logic by
directly observing selectedPoints and currentItem properties instead of taking points and relying on
an instance variable, which was a terrible API.
(App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
when the main plot has a selected range, we don't have to check this._hasRange anymore.
(App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
(App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
(App.InteractiveChartComponent._updateSelection):
(App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
(App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
selectedPoints property.
(App.AnalysisTaskController._fetchedRuns):
(App.AnalysisTaskController._rootChangedForTestSet):
- public/v2/index.html:
Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
- 8:14 PM Changeset in webkit [176709] by
-
- 29 edits1 delete in trunk/Source
Rolling out r176592, r176603, r176616, and r176705 until build and perf issues are resolved.
https://bugs.webkit.org/show_bug.cgi?id=138821
Not reviewed.
Source/JavaScriptCore:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::visitChildren):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitComplexPopScopes):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
- ftl/FTLAbbreviations.h:
(JSC::FTL::mdNode):
(JSC::FTL::buildCall):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- parser/Parser.h:
(JSC::Scope::Scope):
- runtime/JSArray.cpp:
(JSC::JSArray::setLengthWithArrayStorage):
(JSC::JSArray::sortCompactedVector):
- tools/ProfileTreeNode.h:
(JSC::ProfileTreeNode::dumpInternal):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::matchCharacterClass):
Source/WebCore:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::deserializeString):
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::isBadMatch):
- page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::buildSelectionHighlight):
- platform/graphics/SegmentedFontData.cpp:
(WebCore::SegmentedFontData::fontDataForCharacter):
(WebCore::SegmentedFontData::containsCharacter):
(WebCore::SegmentedFontData::isLoading):
- platform/graphics/WOFFFileFormat.cpp:
(WebCore::convertWOFFToSfnt):
- platform/graphics/cairo/GradientCairo.cpp:
(WebCore::Gradient::platformGradient):
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::clearFrameBufferCache):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
- rendering/style/GridResolvedPosition.cpp:
(WebCore::firstNamedGridLineBeforePosition):
(WebCore::GridResolvedPosition::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
- svg/SVGFontElement.cpp:
(WebCore::kerningForPairOfStringsAndGlyphs):
- svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::append):
- xml/XPathNodeSet.h:
(WebCore::XPath::NodeSet::begin):
(WebCore::XPath::NodeSet::end):
Source/WTF:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/IndexedIterator.h: Removed.
- wtf/RefCountedArray.h:
(WTF::RefCountedArray::RefCountedArray):
- wtf/Vector.h:
(WTF::Vector::Vector):
(WTF::Vector::begin):
(WTF::Vector::end):
(WTF::OverflowHandler>::Vector):
(WTF::=):
(WTF::OverflowHandler>::fill):
(WTF::OverflowHandler>::expandCapacity):
(WTF::OverflowHandler>::tryExpandCapacity):
(WTF::OverflowHandler>::resize):
(WTF::OverflowHandler>::shrink):
(WTF::OverflowHandler>::grow):
(WTF::OverflowHandler>::reserveCapacity):
(WTF::OverflowHandler>::tryReserveCapacity):
(WTF::OverflowHandler>::shrinkCapacity):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::appendSlowCase):
(WTF::OverflowHandler>::uncheckedAppend):
(WTF::OverflowHandler>::appendVector):
(WTF::OverflowHandler>::insert):
(WTF::OverflowHandler>::insertVector):
(WTF::OverflowHandler>::remove):
- 7:14 PM Changeset in webkit [176708] by
-
- 2 edits in trunk/Source/WebCore
Fix build break EFL port since r176696
https://bugs.webkit.org/show_bug.cgi?id=139215
Unreviewed, build fix for EFL port.
- storage/StorageNamespaceProvider.h: Include SecurityOriginHash.h from WebCore/page directory.
- 6:57 PM Changeset in webkit [176707] by
-
- 2 edits in trunk/Source/WebKit2
Don't block menu highlighting when presenting a page preview
https://bugs.webkit.org/show_bug.cgi?id=139217
Reviewed by Tim Horton.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _previewURLFromActionMenu:]):
Defer popover presentation to the next turn of the runloop.
- 6:02 PM Changeset in webkit [176706] by
-
- 21 edits8 adds2 deletes in trunk
AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
https://bugs.webkit.org/show_bug.cgi?id=139005
Reviewed by Chris Fleizach.
Source/WebCore:
Expose table captions and rows via ATK. Accomplishing the former is done
by role mapping and inclusion of the object as a child of the table for
ATK. Accomplishing the latter was mostly a matter of deleting all the ATK
platform code that had been forcing rows to be ignored. Because captions
are not being exposed on the Mac, they are now explicitly being ignored
for that platform.
Tests: accessibility/aria-table-hierarchy.html
accessibility/table-hierarchy.html
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole): Added CaptionRole.
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren): Include non-ignored captions as table children.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetNChildren): Removed special handling for tables.
(webkitAccessibleRefChild): Removed special handling for tables.
(webkitAccessibleGetIndexInParent): Removed special handling for table cells.
(atkRole): Corrected broken mapping for RowRole.
(getNChildrenForTable): Deleted.
(getChildForTable): Deleted.
(getIndexInParentForCellInRow): Deleted.
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore captions as table children.
Tools:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
Add mapping for ATK_ROLE_CAPTION to roleToString
LayoutTests:
- accessibility/aria-table-hierarchy.html: Added.
- accessibility/roles-exposed.html: Removed comment pointing to this bug.
- accessibility/table-hierarchy.html: Added.
- platform/efl/accessibility/aria-table-hierarchy-expected.txt: Added.
- platform/efl/accessibility/roles-exposed-expected.txt: Updated to reflect new behavior.
- platform/efl/accessibility/table-detection-expected.txt: Updated to reflect new behavior.
- platform/efl/accessibility/table-hierarchy-expected.txt: Added.
- platform/efl/accessibility/table-roles-hierarchy-expected.txt: Added.
- platform/efl/accessibility/table-with-rules-expected.txt: Updated to reflect new behavior.
- platform/gtk/accessibility/aria-table-hierarchy-expected.txt: Updated to reflect new behavior.
- platform/gtk/accessibility/aria-table-hierarchy.html: Removed (made into a shared test).
- platform/gtk/accessibility/caret-offsets-expected.txt: Updated to reflect new behavior.
- platform/gtk/accessibility/caret-offsets.html: Modified to handle inclusion of rows.
- platform/gtk/accessibility/roles-exposed-expected.txt: Updated to reflect new behavior.
- platform/gtk/accessibility/table-detection-expected.txt: Updated to reflect new behavior.
- platform/gtk/accessibility/table-hierarchy-expected.txt: Updated to reflect new behavior.
- platform/gtk/accessibility/table-hierarchy.html: Removed (made into a shared test).
- platform/gtk/accessibility/table-roles-hierarchy-expected.txt: Added.
- platform/gtk/accessibility/table-with-rules-expected.txt: Updated to reflect new behavior.
- platform/gtk/accessibility/text-for-range-table-cells.html: Updated to reflect new behavior.
- platform/mac/accessibility/aria-table-hierarchy-expected.txt: Added.
- platform/mac/accessibility/table-hierarchy-expected.txt: Added.
- 6:01 PM Changeset in webkit [176705] by
-
- 2 edits in trunk/Source/WTF
Fix IOS builds.
- 5:52 PM Changeset in webkit [176704] by
-
- 1 edit1 delete in trunk/Source/WebKit
Remove empty directories
Reviewed by Anders Carlsson.
- Source: Removed.
- Source/WebKit: Removed.
- Source/WebKit/mac: Removed.
- Source/WebKit/mac/Resources: Removed.
- 5:44 PM Changeset in webkit [176703] by
-
- 4 edits in trunk/Source
Fix the build.
- UIProcess/mac/WebContextMac.mm:
- WebCoreSupport/WebFrameLoaderClient.mm:
- 5:12 PM Changeset in webkit [176702] by
-
- 1 copy in tags/Safari-600.3.9
Tagging.
- 4:59 PM Changeset in webkit [176701] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/18441138> [iOS] Text selection in WKWebView with WKSelectionGranularityCharacter only works in the most recent WKWebView to load
https://bugs.webkit.org/show_bug.cgi?id=139211
Reviewed by Anders Carlsson.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView becomeFirstResponder]): Override to activate the text selection for when
becoming first resopnder.
(-[WKContentView resignFirstResponder]): Deactiavte the text selection when resigning first
responder. This ensures that if another WKWebView becomes first responder, and it uses
block selection, we don’t end up with two active selection views.
(-[WKContentView useSelectionAssistantWithMode:]): Only activate the text selection if this
is the first responder. This ensures that loading content into a non-first-responder
WKWebView doesn‘t deactivate the text selection in the current first responder.
- 4:49 PM Changeset in webkit [176700] by
-
- 3 edits in trunk/Source/JavaScriptCore
Change CallFrame::globalThisValue() to not use CallFrame::scope()
https://bugs.webkit.org/show_bug.cgi?id=139202
Reviewed by Mark Lam.
Changed to use the globalThis() on the globalObject associated with the
callee. Moved the inline definition to JSGlobalObject.h instead of
including JSGlobalObject.h in JSScope.h. Also moved it as JSScope
objects are no longer involved in getting the value.
- runtime/JSGlobalObject.h:
(JSC::ExecState::globalThisValue):
- runtime/JSScope.h:
(JSC::ExecState::globalThisValue): Deleted.
- 4:39 PM Changeset in webkit [176699] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: CSS Minification breaks some selectors with colons
https://bugs.webkit.org/show_bug.cgi?id=139206
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-02
Reviewed by Simon Fraser.
Do not remove spaces preceeding colons, as they may change the semantics
of selectors with colon prefixes (e.g. "a :not(b)").
At the same time, we can strip spaces around "!" characters, for example
a space is not required before "!important" priority.
- Scripts/cssmin.py:
(cssminify):
- 4:33 PM Changeset in webkit [176698] by
-
- 14 edits in trunk
http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=139149
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in: Added ApplicationCache::deleteAllCaches.
- loader/appcache/ApplicationCache.h:
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::deleteAllCaches): Added.
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getManifestURLs): Removed logging. It is OK to
have this function called when there is no database file.
- loader/appcache/ApplicationCacheStorage.h: Renamed manifestURLs to getManifestURLs,
because WebKit style.
Source/WebKit/mac:
This changes API behavior. I think that it's OK, because existing behavior made no sense.
We used to delete caches from disk, but they were still active in memory. Now we also
obsolete them in memory, so documents that use a cache still work, but new ones don't
pick one up.
- WebCoreSupport/WebApplicationCache.mm:
(+[WebApplicationCache setMaximumSize:]): Changing maximum on-disk size doesn't
need to delete in-momry caches too. Keep existing behavior.
(+[WebApplicationCache deleteAllApplicationCaches]): Use the new WebCore function
that properly deletes caches.
Source/WebKit2:
This changes API behavior. I think that it's OK, because existing behavior made no sense.
We used to delete caches from disk, but they were still active in memory. Now we also
obsolete them in memory, so documents that use a cache still work, but new ones don't
pick one up.
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::deleteAllEntries): Use the new WebCore function
that properly deletes caches.
Tools:
WebKit2 already cleared application caches between runs (although it wasn't entirely
effective without WebCore changes in this patch).
- DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
- DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
function is not implemented on Windows, see below).
- DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
Ameded a FIXME.
- 4:32 PM Changeset in webkit [176697] by
-
- 18 edits2 deletes in trunk/Source
Remove a SnowLeopard-era quirk for QuickLook
https://bugs.webkit.org/show_bug.cgi?id=139208
<rdar://problem/19121822>
Reviewed by Alexey Proskuryakov.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
- loader/FrameLoaderClient.h:
- platform/mac/QuickLookMac.h: Removed.
- platform/mac/QuickLookMac.mm: Removed.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::needsQuickLookResourceCachingQuirks): Deleted.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/WebProcess.h:
(WebKit::WebProcess::needsQuickLookResourceCachingQuirks): Deleted.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 4:30 PM Changeset in webkit [176696] by
-
- 10 edits2 adds in trunk/Source/WebCore
Begin stubbing out a StorageNamespaceProvider class
https://bugs.webkit.org/show_bug.cgi?id=139203
Reviewed by Tim Horton.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::localStorage):
If the page has a storage namespace provider, get the local storage from it.
- page/Page.cpp:
(WebCore::Page::Page):
Move the storage namespace provider from the configuration.
(WebCore::Page::setStorageNamespaceProvider):
Add a setter. This will be used by setGroupName.
- page/Page.h:
(WebCore::Page::storageNamespaceProvider):
Add a getter.
- page/PageConfiguration.cpp:
- page/PageConfiguration.h:
Add a storage namespace provider member.
- storage/StorageNamespaceProvider.cpp:
(WebCore::StorageNamespaceProvider::StorageNamespaceProvider):
(WebCore::StorageNamespaceProvider::~StorageNamespaceProvider):
(WebCore::StorageNamespaceProvider::addPage):
(WebCore::StorageNamespaceProvider::removePage):
(WebCore::StorageNamespaceProvider::localStorageNamespace):
(WebCore::StorageNamespaceProvider::transientLocalStorageNamespace):
- storage/StorageNamespaceProvider.h:
Stub out a storage namespace provider class.
- 3:41 PM Changeset in webkit [176695] by
-
- 3 edits in trunk/Source/WebKit/mac
Loading Lookup causes http/tests/cache/post-redirect-get.php to fail
https://bugs.webkit.org/show_bug.cgi?id=139204
<rdar://problem/19120929>
Reviewed by Anders Carlsson.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _showDictionaryLookupPopup:]):
- WebView/WebViewData.h:
Work around this by delaying the softlinking (and setting up the notification
observer) until we actually need it. There's still an underlying bug, but
this will fix the test.
- 2:05 PM Changeset in webkit [176694] by
-
- 2 edits in trunk/Source/WebCore
More build fixing.
- platform/spi/mac/QuickLookMacSPI.h:
- 1:53 PM Changeset in webkit [176693] by
-
- 2 edits in trunk/Source/WebKit/mac
Yet another build fix.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForLink]):
- 1:47 PM Changeset in webkit [176692] by
-
- 2 edits in trunk/Source/WebCore
Another build fix.
- platform/spi/mac/NSMenuSPI.h:
- 1:36 PM Changeset in webkit [176691] by
-
- 4 edits in trunk/Source
Build fix.
Source/WebKit/mac:
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForLink]):
Source/WebKit2:
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForLink]):
- 1:31 PM Changeset in webkit [176690] by
-
- 4 edits in trunk/Source
Source/WebKit/mac:
More build fixing.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForLink]):
Source/WebKit2:
More build fix.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForLink]):
- 1:20 PM Changeset in webkit [176689] by
-
- 2 edits in trunk/Source/WebCore
Speculative build fix.
- platform/spi/mac/QuickLookMacSPI.h:
- 1:12 PM Changeset in webkit [176688] by
-
- 2 edits in trunk/Source/WebCore
Speculative build fix.
- platform/spi/mac/QuickLookMacSPI.h:
- 1:00 PM Changeset in webkit [176687] by
-
- 6 edits in trunk/Source/WebKit2
REGRESSION: Dragging selected text changes the selection
https://bugs.webkit.org/show_bug.cgi?id=139110
Reviewed by Simon Fraser.
After it sent the UI process the message to start dragging, the Web process handled mouse
move events that had already been in flight, interpreting them as a drag to start a new
selection. This is fixed by ignoring any mouse events received after asking the UI process
to start dragging.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setDragImage): Send the new DidStartDrag message back to the Web
process, so that it stops ignoring mouse events.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag): Call the new WebPage::willStartDrag, so that it starts
ignoring mouse events.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize new member variable.
(WebKit::WebPage::mouseEvent): Don’t handle the event if we have asked the UI process to
start dragging.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::willStartDrag): Added. Sets new member variable m_isStartingDrag to true.
(WebKit::WebPage::didStartDrag): Added. Handles the message from the UI process by setting
m_isStartingDrag back to false.
- WebProcess/WebPage/WebPage.messages.in: Added DidStartDrag.
- 12:53 PM Changeset in webkit [176686] by
-
- 5 edits in trunk/Source
Remove more Windows cruft
https://bugs.webkit.org/show_bug.cgi?id=139189
Reviewed by Andreas Kling.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createNetworkingContext):
- WebCoreSupport/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebFrameNetworkingContext::userAgent): Deleted.
- 12:50 PM Changeset in webkit [176685] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix typo introduced in r176673.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
- 12:36 PM Changeset in webkit [176684] by
-
- 8 edits2 adds in trunk/Source
Should use standardQuickLookMenuItem for apps that don't implement customizations
https://bugs.webkit.org/show_bug.cgi?id=139193
-and corresponding-
rdar://problem/18944696
Reviewed by Anders Carlsson.
Source/WebCore:
New SPI headers.
- WebCore.xcodeproj/project.pbxproj:
- platform/spi/mac/NSMenuSPI.h: Added.
- platform/spi/mac/QuickLookMacSPI.h: Added.
Source/WebKit/mac:
Use [NSMenuItem standardQuickLookMenuItem].
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForLink]):
Delegate methods to set up the standardQuickLookMenuItem.
(-[WebActionMenuController menuItem:viewAtScreenPoint:]):
(-[WebActionMenuController menuItem:previewItemAtPoint:]):
(-[WebActionMenuController menuItem:preferredEdgeForPoint:]):
Remove all of the old QLPreviewBubble code.
(-[WebActionMenuController _createActionMenuItemForTag:]):
(-[WebActionMenuController _quickLookURLFromActionMenu:]): Deleted.
Source/WebKit2:
New SPI will allow clients to opt-out of the standardQuickLookMenuItem. By
default, opt in.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _shouldUseStandardQuickLookPreview]):
- UIProcess/mac/WKActionMenuController.mm:
Use [NSMenuItem standardQuickLookMenuItem] unless the client has requested
otherwise.
(-[WKActionMenuController _defaultMenuItemsForLink]):
Delegate methods to set up the standardQuickLookMenuItem.
(-[WKActionMenuController menuItem:viewAtScreenPoint:]):
(-[WKActionMenuController menuItem:previewItemAtPoint:]):
(-[WKActionMenuController menuItem:preferredEdgeForPoint:]):
- 12:30 PM Changeset in webkit [176683] by
-
- 20 edits3 adds2 deletes in trunk
Generalize PageActivityAssertionToken
https://bugs.webkit.org/show_bug.cgi?id=139106
Reviewed by Sam Weinig.
Source/WebCore:
PageActivityAssertionToken is a RAII mechanism implementing a counter, used by PageThrottler
to count user visible activity in progress on the page (currently page load and media playback).
Use of an RAII type is prevents a number of possible errors, including double counting a single
media element, or failing to decrement the count after a media element has been deallocated.
The current implementation has a number of drawbacks that have been addressed by this refactoring:
- specific to single use in PageThrottler class - not reusable.
- incomplete encapsulation - the counter and WeakPtrFactory that comprise the current implementation are not encapsulated (are in the client type, PageThrottler).
- tokens are not shared - PageActivityAssertionToken instances are managed by std::unique, every increment requires an object allocation.
- redundancy - the current implementation uses a WeakPtr to safely reference the PageThrottler, this is internally implemented using a reference counted type, resulting in two counters being incremented (one in the PageActivityAssertionToken, one in the PageThrottler).
In the reimplementation:
- a callback is provided via a lambda function, which allows for easy reuse without a lot of boilerplate code.
- the counter, callback and ownership of the otherwise weakly-owned token is encapsulated within the RefCounter type.
- a single count within RefCounter::Count stores the counter value, and also manage the lifetime of this object.
- standard RefPtrs are used to manage references to the RefCounter::Count.
- WebCore.xcodeproj/project.pbxproj:
- removed PageActivityAssertionToken.cpp/.h
- html/HTMLMediaElement.cpp:
- removed PageActivityAssertionToken.h
- html/HTMLMediaElement.h:
- std::unique_ptr<PageActivityAssertionToken> -> RefPtr<RefCounter::Count>
- loader/FrameLoader.cpp:
- removed PageActivityAssertionToken.h
- loader/FrameLoader.h:
- std::unique_ptr<PageActivityAssertionToken> -> RefPtr<RefCounter::Count>
- loader/SubresourceLoader.cpp:
- removed PageActivityAssertionToken.h
- loader/SubresourceLoader.h:
- removed class PageActivityAssertionToken
- page/Page.cpp:
- removed PageActivityAssertionToken.h
(WebCore::Page::Page):
- removed Page* parameter to PageThrottler
- page/Page.h:
- removed class PageActivityAssertionToken
- page/PageActivityAssertionToken.cpp: Removed.
- page/PageActivityAssertionToken.h: Removed.
- removed PageActivityAssertionToken.cpp/.h
- page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
- removed m_page, m_weakPtrFactory, m_activityCount; added m_pageActivityCounter.
(WebCore::PageThrottler::mediaActivityToken):
- std::unique_ptr<PageActivityAssertionToken> -> PassRefPtr<RefCounter::Count>
(WebCore::PageThrottler::pageLoadActivityToken):
- std::unique_ptr<PageActivityAssertionToken> -> PassRefPtr<RefCounter::Count>
(WebCore::PageThrottler::pageActivityCounterValueDidChange):
- merged functionality of incrementActivityCount/decrementActivityCount
(WebCore::PageThrottler::incrementActivityCount): Deleted.
- see pageActivityCounterValueDidChange
(WebCore::PageThrottler::decrementActivityCount): Deleted.
- see pageActivityCounterValueDidChange
- page/PageThrottler.h:
(WebCore::PageThrottler::weakPtr): Deleted.
- no longer required; this functionality is now encapsulated within RefCounter.
Source/WTF:
PageActivityAssertionToken is a RAII mechanism implementing a counter, used by PageThrottler
to count user visible activity in progress on the page (currently page load and media playback).
Use of an RAII type is prevents a number of possible errors, including double counting a single
media element, or failing to decrement the count after a media element has been deallocated.
The current implementation has a number of drawbacks that have been addressed by this refactoring:
- specific to single use in PageThrottler class - not reusable.
- incomplete encapsulation - the counter and WeakPtrFactory that comprise the current implementation are not encapsulated (are in the client type, PageThrottler).
- tokens are not shared - PageActivityAssertionToken instances are managed by std::unique, every increment requires an object allocation.
- redundancy - the current implementation uses a WeakPtr to safely reference the PageThrottler, this is internally implemented using a reference counted type, resulting in two counters being incremented (one in the PageActivityAssertionToken, one in the PageThrottler).
In the reimplementation:
- a callback is provided via a lambda function, which allows for easy reuse without a lot of boilerplate code.
- the counter, callback and ownership of the otherwise weakly-owned token is encapsulated within the RefCounter type.
- a single count within RefCounter::Count stores the counter value, and also manage the lifetime of this object.
- standard RefPtrs are used to manage references to the RefCounter::Count.
- WTF.xcodeproj/project.pbxproj:
- added RefCounter.cpp/.h
- wtf/RefCounter.cpp: Added.
(WTF::RefCounter::Count::ref):
- increment the counter.
(WTF::RefCounter::Count::deref):
- decrement the counter, and delete as necessary.
(WTF::RefCounter::RefCounter):
- create a RefCounter::Count.
(WTF::RefCounter::~RefCounter):
- eagerly delete the Counter if it has no references, otherwise let it be deleted on last deref.
- wtf/RefCounter.h: Added.
(WTF::RefCounter::Count::Count):
- initialize count to 0.
(WTF::RefCounter::RefCounter):
- takes a lambda to be called when the value changes.
(WTF::RefCounter::count):
- reference the counter (and in doing so increment the count).
(WTF::RefCounter::value):
- access the current value of the counter.
Tools:
Add an API test for WTF::RefCounter.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
(TestWebKitAPI::TEST):
- added RefCounter test.
- 11:49 AM Changeset in webkit [176682] by
-
- 3 edits in trunk/Source/WebCore
Always show the arrow for text selection services
https://bugs.webkit.org/show_bug.cgi?id=139191
<rdar://problem/18903995>
Reviewed by Anders Carlsson.
- platform/spi/mac/DataDetectorsSPI.h:
- page/mac/ServicesOverlayController.mm:
Move a few things to DataDetectorsSPI.h.
(WebCore::ServicesOverlayController::buildPhoneNumberHighlights):
(WebCore::ServicesOverlayController::buildSelectionHighlight):
Make use of the real DDHighlightStyle names.
Add DDHighlightStyleButtonShowAlways for selection services.
- 11:40 AM Changeset in webkit [176681] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix the build.
- WebView/WebViewData.h:
- 11:38 AM Changeset in webkit [176680] by
-
- 7 edits1 add in trunk/Source/WebKit
Implement Lookup transition from selection for Legacy WebKit
https://bugs.webkit.org/show_bug.cgi?id=139180
<rdar://problem/19067172>
Reviewed by Beth Dakin.
- WebView/DictionaryPopupInfo.h: Added.
Split DictionaryPopupInfo out into its own file.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _lookupText:]):
Hand the DictionaryPopupInfo to WebView, which will show the TextIndicator and invoke Lookup.
(performDictionaryLookupForSelection):
(performDictionaryLookupForRange):
Plumb the transition style through these helpers.
Create a TextIndicator from the selection range.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
Make use of TextIndicator (and DictionaryPopupInfo, and the new
_showDictionaryLookupPopup on WebView) to add a transition from blue
when performing Lookup from the context menu.
(-[WebHTMLView quickLookWithEvent:]):
Remove our TextIndicator whenever a normal three-finger-tap event
comes through, as it will have its own indication.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _dictionaryLookupPopoverWillClose:]):
Register for the LUNotificationPopoverWillClose notification and remove
our TextIndicator when it is called, just like in WebKit2.
Deregistration is already handled in _close.
(-[WebView _showDictionaryLookupPopup:]):
Just like WebKit2, show our TextIndicator and tell Lookup not to show its own,
if the relevant API is available.
- WebView/WebViewInternal.h:
- WebKit.xcodeproj/project.pbxproj:
Add mac/WebView/DictionaryPopupInfo.h.
- 11:37 AM Changeset in webkit [176679] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176474. rdar://problems/19063717
- 11:34 AM Changeset in webkit [176678] by
-
- 2 edits in trunk/Source/WebKit2
TextIndicator can get stuck (especially if we don't get LUNotificationPopoverWillClose when we should)
https://bugs.webkit.org/show_bug.cgi?id=139175
<rdar://problem/19072236>
Reviewed by Beth Dakin.
- UIProcess/API/mac/WKView.mm:
(-[WKView scrollWheel:]):
(-[WKView mouseDown:]):
Work around <rdar://problem/19086993> by always explicitly clearing the
active text indicator in mouseDown: and scrollWheel:.
This way, even if you manage to get a text indicator that outlives the
Look Up popover (or find-in-page, or whatever), it will be dismissed
by clicking or scrolling the view.
- 11:30 AM Changeset in webkit [176677] by
-
- 13 edits in trunk/Tools
[Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
https://bugs.webkit.org/show_bug.cgi?id=139174
Reviewed by Simon Fraser.
- DumpRenderTree/TestRunner.cpp:
- DumpRenderTree/TestRunner.h:
Renamed testPathOrURL to testURL, because this variable always contains a URL.
- DumpRenderTree/mac/DumpRenderTree.mm:
(sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
(testPathFromURL): Moved from FrameLoadDelegate.mm.
(runTest): Set crash reporter information here, as we know the exact test URL.
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
reporter information here.
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
- DumpRenderTree/mac/TestRunnerMac.mm:
Updated for testPathOrURL renaming.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
test URL until load starts, so save it into TestRunner now. A new TestRunner object
is created for each test.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::testURL):
(WTR::TestRunner::setTestURL):
Make TestRunner know the test name. For now, it's good enough to have it once load
starts, but if we ever need it earlier, we can send it with BeginTest message.
- WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
Use test URL, not currently loading URL for CrashReporter.
- WebKitTestRunner/cocoa/CrashReporterInfo.mm:
(WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
(WebKit1 already had it right).
- DumpRenderTree/win/DumpRenderTree.cpp:
(sizeWebViewForCurrentTest):
(runTest):
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::willSendRequest):
Changed Windows DumpRenderTree to also use URL in TestRunner.
- 11:27 AM Changeset in webkit [176676] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
Fixes inline cache fast path accessing nonexistant getters.
<rdar://problem/18416918>
https://bugs.webkit.org/show_bug.cgi?id=136961
Reviewed by Filip Pizlo.
Fixes a bug in inline caching where getters would have been able to
modify the property they are getting during
building the inline cache and then accessing that
property through the inline cache site causing a recursive
inline cache building and allowing the fast path of the cache to
try to load a getter for the property that no longer exists.
- jit/JITOperations.cpp: Switched use of get to getPropertySlot.
- runtime/JSCJSValue.h:
added getPropertySlot for when you don't want to perform the get quite yet but want
to fill out the slot.
- runtime/JSCJSValueInlines.h: Added implementation for getPropertySlot
(JSC::JSValue::get): changed to simply call getPropertySlot
(JSC::JSValue::getPropertySlot): added.
- tests/stress/recursive_property_redefine_during_inline_caching.js: Added test case for bug.
(test):
- 11:26 AM Changeset in webkit [176675] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build.
- WebCore.exp.in:
- 11:15 AM Changeset in webkit [176674] by
-
- 4 edits2 adds in trunk
Crash when setting 'flex' CSS property to 'calc(2 * 3) calc(2 * 3)'
https://bugs.webkit.org/show_bug.cgi?id=139162
Reviewed by Darin Adler.
Source/WebCore:
Add support for calculated values in 'flex' CSS property.
Previously, those did not work in release builds, and were hitting
an assertion in debug builds.
Test: fast/css/flex-calculated-value.html
- css/CSSParser.cpp:
(WebCore::CSSParser::validCalculationUnit):
Do not call RefPtr::release() as we are not interested in the return
value. Assign nullptr to the member instead.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
(WebCore::CSSParser::parseFontWeight):
(WebCore::CSSParser::parsedDouble):
(WebCore::CSSParser::colorIntFromValue):
(WebCore::CSSParser::parseColorParameters):
(WebCore::CSSParser::parseHSLParameters):
(WebCore::CSSParser::parseFlex):
- css/CSSParser.h:
LayoutTests:
Add layout test for calculated value support for 'flex' CSS property.
- fast/css/flex-calculated-value-expected.txt: Added.
- fast/css/flex-calculated-value.html: Added.
- 11:04 AM Changeset in webkit [176673] by
-
- 2 edits in trunk/Source/WebCore
Fix logging typo
https://bugs.webkit.org/show_bug.cgi?id=139182
Reviewed by Alexey Proskuryakov.
No new tests, only logging code is changed.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Don't use %f to log a string.
- 11:02 AM Changeset in webkit [176672] by
-
- 3 edits11 deletes in trunk/Source/WebCore
Get rid of the WinINet based network implementation
https://bugs.webkit.org/show_bug.cgi?id=139187
Reviewed by Andreas Kling.
This code was only used by the Windows CE port. Now it's unused.
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/win/AuthenticationChallenge.h: Removed.
- platform/network/win/CookieJarWin.cpp: Removed.
- platform/network/win/CredentialStorageWin.cpp: Removed.
- platform/network/win/ProxyServerWin.cpp: Removed.
- platform/network/win/ResourceError.h: Removed.
- platform/network/win/ResourceHandleWin.cpp: Removed.
- platform/network/win/ResourceRequest.h: Removed.
- platform/network/win/ResourceResponse.h: Removed.
- platform/network/win/SocketStreamError.h: Removed.
- platform/network/win/SocketStreamHandle.h: Removed.
- platform/network/win/SocketStreamHandleWin.cpp: Removed.
- 10:53 AM Changeset in webkit [176671] by
-
- 3 edits4 adds in trunk
Crash when setting 'column-span' CSS property to 'calc(2 * 3)'
https://bugs.webkit.org/show_bug.cgi?id=139170
Reviewed by Darin Adler.
Source/WebCore:
Add support for calculated values for 'column-span' and 'column-width'
CSS properties. Previously, these were not working in release builds
and hitting assertions in debug builds.
Tests: fast/css/column-width-calculated-value.html
fast/css/webkit-column-span-calculated-value.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
LayoutTests:
Add layout tests to test calculated values for 'column-span'
and 'column-width' CSS properties.
- fast/css/column-width-calculated-value-expected.txt: Added.
- fast/css/column-width-calculated-value.html: Added.
- fast/css/webkit-column-span-calculated-value-expected.txt: Added.
- fast/css/webkit-column-span-calculated-value.html: Added.
- 10:12 AM Changeset in webkit [176670] by
-
- 26 edits2 deletes in trunk/Source
Remove visited link handling from PageGroup
https://bugs.webkit.org/show_bug.cgi?id=139185
Reviewed by Sam Weinig.
Source/WebCore:
- CMakeLists.txt:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- loader/HistoryController.cpp:
- page/Chrome.cpp:
(WebCore::ChromeClient::populateVisitedLinks): Deleted.
- page/ChromeClient.h:
- page/DefaultVisitedLinkStore.cpp: Removed.
- page/DefaultVisitedLinkStore.h: Removed.
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::visitedLinkStore):
(WebCore::Page::setVisitedLinkStore):
(WebCore::Page::removeAllVisitedLinks): Deleted.
- page/Page.h:
- page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
(WebCore::PageGroup::visitedLinkStore): Deleted.
(WebCore::PageGroup::isLinkVisited): Deleted.
(WebCore::PageGroup::addVisitedLinkHash): Deleted.
(WebCore::PageGroup::addVisitedLink): Deleted.
(WebCore::PageGroup::removeVisitedLink): Deleted.
(WebCore::PageGroup::removeVisitedLinks): Deleted.
(WebCore::PageGroup::removeAllVisitedLinks): Deleted.
(WebCore::PageGroup::setShouldTrackVisitedLinks): Deleted.
- page/PageGroup.h:
Source/WebKit/mac:
- History/WebHistory.mm:
(-[WebHistoryPrivate removeItemForURLString:]):
(-[WebHistoryPrivate removeAllItems]):
(+[WebHistory setOptionalSharedHistory:]):
(+[WebHistory _setVisitedLinkTrackingEnabled:]):
(+[WebHistory _removeAllVisitedLinks]):
(-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Deleted.
(-[WebHistory _addVisitedLinksToPageGroup:]): Deleted.
- History/WebHistoryInternal.h:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::populateVisitedLinks): Deleted.
- WebView/WebView.mm:
(-[WebView addVisitedLinks:]):
(-[WebView removeVisitedLink:]):
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks): Deleted.
- WebCoreSupport/WebChromeClient.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::populateVisitedLinks): Deleted.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 10:04 AM Changeset in webkit [176669] by
-
- 5 edits in trunk/Tools
[iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
https://bugs.webkit.org/show_bug.cgi?id=139143
Reviewed by David Kilzer.
Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
crashes. Run-webkit-tests will record as crashing the test associated with the
DumpRenderTree instance that wrote that string.
Currently almost all of the DumpRenderTree.app crashes are recorded by run-
webkit-tests as a time-out because ReportCrash(8) delays delivery of the
process exit notification for DumpRenderTree.app to LayoutTestRelay, which
launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
(since it exceeded the time-out time limit) before it can inform rub-webkit-tests
about a crash.
Additionally, update the crash message format written to standard error when LayoutTestRelay
detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
when they crash in their test machinery logic/UI process code.
- DumpRenderTree/mac/DumpRenderTree.mm:
(writeCrashedMessageOnFatalError): Added.
(dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
SIGILL, SIGFPE, SIGBUS and SIGSEGV.
- LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
(-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
the crash logs for WebKitTestRunner/DumpRenderTree.app.
- Scripts/webkitpy/port/driver.py:
(Driver.init): Update comment.
(Driver._check_for_driver_crash): Ditto.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
regular expression. This constant is used as an optimization to avoid compiling the same
regular expression across invocations of _get_crash_log().
(IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
closer to where they are used.
- 9:59 AM Changeset in webkit [176668] by
-
- 3 edits in trunk/Source/WebCore
Use references instead of pointers in EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=137918
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-12-02
Reviewed by Darin Adler.
- editing/EditingStyle.cpp:
(WebCore::extractPropertyValue):
(WebCore::identifierForStyleProperty):
(WebCore::textColorFromStyle):
(WebCore::backgroundColorFromStyle):
(WebCore::textAlignResolvingStartAndEnd):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::StyleChange::StyleChange):
(WebCore::setTextDecorationProperty):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::fontWeightIsBold):
(WebCore::extractPropertiesNotIn):
(WebCore::getPropertiesNotIn):
- editing/EditingStyle.h:
- 9:33 AM Changeset in webkit [176667] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r176617. rdar://problems/19107247
- 9:33 AM Changeset in webkit [176666] by
-
- 5 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176613. rdar://problems/19108805
- 9:32 AM Changeset in webkit [176665] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Build fix.
- 9:07 AM Changeset in webkit [176664] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Media Source sending seek event fails.
https://bugs.webkit.org/show_bug.cgi?id=139181
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2014-12-02
Reviewed by Philippe Normand.
There were callbacks connected to app_src on 'seek', but if stream type is not seekable, they would never launch,
and seeking (as in MediaPlayerPrivateGStreamer::doSeek) fails.
No new tests needed.
- platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
(webkit_media_src_init):
- 8:57 AM Changeset in webkit [176663] by
-
- 4 edits in branches/safari-600.3-branch/Source
Merged r176618. rdar://problem/18992185
- 8:57 AM Changeset in webkit [176662] by
-
- 8 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merged r176608. rdar://problem/18992185
- 8:57 AM Changeset in webkit [176661] by
-
- 15 edits in branches/safari-600.3-branch/Source
Merged r176599. rdar://problem/18992185
- 8:56 AM Changeset in webkit [176660] by
-
- 32 edits4 moves in branches/safari-600.3-branch/Source
Merged r176462. rdar://problem/18992185
- 8:44 AM Changeset in webkit [176659] by
-
- 8 edits in trunk
Remove WKBundleRemoveAllVisitedLinks
https://bugs.webkit.org/show_bug.cgi?id=139163
Reviewed by Sam Weinig.
Source/WebKit2:
WKBundleRemoveAllVisitedLinks has been a no-op since at least Yosemite; get rid of it.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleRemoveAllVisitedLinks): Deleted.
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::removeAllVisitedLinks): Deleted.
- WebProcess/InjectedBundle/InjectedBundle.h:
Tools:
Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
- 8:43 AM Changeset in webkit [176658] by
-
- 2 edits in trunk/Tools
Fix Windows build.
- DumpRenderTree/win/DumpRenderTree.cpp:
(setAlwaysAcceptCookies):
- 8:42 AM Changeset in webkit [176657] by
-
- 4 edits in trunk/Source/WebCore
Move 'font-family' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139172
Reviewed by Antti Koivisto.
Move 'font-family' CSS property to the new StyleBuilder by using
custom code.
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyFontFamily::applyInheritValue): Deleted.
(WebCore::ApplyPropertyFontFamily::applyInitialValue): Deleted.
(WebCore::ApplyPropertyFontFamily::applyValue): Deleted.
(WebCore::ApplyPropertyFontFamily::createHandler): Deleted.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInitialFontFamily):
(WebCore::StyleBuilderCustom::applyInheritFontFamily):
(WebCore::StyleBuilderCustom::applyValueFontFamily):
- 8:38 AM Changeset in webkit [176656] by
-
- 1 edit in branches/safari-600.3-branch/Tools/TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp
Build fix. rdar://problem/19052564
- 8:05 AM Changeset in webkit [176655] by
-
- 6 edits2 adds in branches/safari-600.3-branch
Merged r176574. rdar://problems/19052564
- 7:57 AM Changeset in webkit [176654] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176570. rdar://problems/19075587
- 7:57 AM Changeset in webkit [176653] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176569. rdar://problems/19086676
- 7:57 AM Changeset in webkit [176652] by
-
- 4 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176511. rdar://problems/19070840
- 7:43 AM Changeset in webkit [176651] by
-
- 30 edits2 copies4 adds in branches/safari-600.3-branch/Source
Merged r176499. rdar://problem/19103641
- 7:15 AM Changeset in webkit [176650] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176486. rdar://problems/19056442
- 7:15 AM Changeset in webkit [176649] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176485. rdar://problems/19061959
- 7:15 AM Changeset in webkit [176648] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176483. rdar://problems/19064523
- 7:15 AM Changeset in webkit [176647] by
-
- 4 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176480. rdar://problems/19056442
- 7:09 AM Changeset in webkit [176646] by
-
- 6 edits in branches/safari-600.3-branch/Source
Merged r176477. rdar://problems/19056715
- 7:08 AM Changeset in webkit [176645] by
-
- 6 edits in branches/safari-600.3-branch/Source
Merged r176463. rdar://problems/19056715
- 6:58 AM Changeset in webkit [176644] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176460. rdar://problems/19059946
- 6:55 AM Changeset in webkit [176643] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176430. rdar://problems/18904651
- 6:55 AM Changeset in webkit [176642] by
-
- 3 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176429. rdar://problems/18904651
- 6:54 AM Changeset in webkit [176641] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176428. rdar://problems/19052196
- 6:50 AM Changeset in webkit [176640] by
-
- 4 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r176427. rdar://problem/19051534
- 6:42 AM Changeset in webkit [176639] by
-
- 4 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176418. rdar://problems/19042323
- 6:35 AM Changeset in webkit [176638] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merge r176417. rdar://problem/19021183
- 6:33 AM Changeset in webkit [176637] by
-
- 2 edits in trunk/Tools
[EFL] Remove edbus dependency from jhbuild
https://bugs.webkit.org/show_bug.cgi?id=139130
Reviewed by Gyuyoung Kim.
After http://trac.webkit.org/changeset/176555 we
don't need it anymore.
- efl/jhbuild.modules:
- 6:22 AM Changeset in webkit [176636] by
-
- 4 edits in branches/safari-600.3-branch/Source
Merge r176415. rdar://problem/18950441
- 6:14 AM Changeset in webkit [176635] by
-
- 3 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r176414. rdar://problem/19042207
- 6:03 AM Changeset in webkit [176634] by
-
- 8 edits in branches/safari-600.3-branch/Source
Merge r176412. rdar://problem/18904600
- 5:33 AM Changeset in webkit [176633] by
-
- 2 edits in trunk/Source
Typo fix after r176632. Revert accidental change of executable bit of ChangeLog files.
- 4:54 AM Changeset in webkit [176632] by
-
- 5 edits in trunk/Source
Fix class was previously declared as a struct warnings
https://bugs.webkit.org/show_bug.cgi?id=139131
Reviewed by Csaba Osztrogonác.
Source/WebCore:
No new tests needed.
- platform/graphics/texmap/TextureMapperGL.h:
Source/WebKit2:
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
- UIProcess/CoordinatedGraphics/WebViewClient.h:
- 3:23 AM Changeset in webkit [176631] by
-
- 7 edits in trunk/Source/WebKit2
[EFL] ewk_view_scale_set() doesn't work correctly
https://bugs.webkit.org/show_bug.cgi?id=139109
Reviewed by Csaba Osztrogonác.
When ewk_view_scale_set() is called, it has only updated a scale factor which is maintained by WebPageProxy.
It causes WebPageProxy unsynchronized with PageViewportController's scale factor. That's why wrong scale
behavior has occured through ewk_view_scale_set(). Besides zooming has similar problem as well.
Thus this patch updates m_pageScaleFactor of PageViewportController as well as prohibits to change the scale
factor through viewport meta tag update. Because ewk_view_scale_set() means that user wants to set a specific
value to scale factor of current viewport.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::updateScaleToPageViewportController):
Set m_initiallyFitToViewport to false. And call didChangeContentsVisibility() with new scale and scale position.
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_scale_set):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- UIProcess/CoordinatedGraphics/PageViewportController.cpp:
(WebKit::PageViewportController::didCommitLoad):
Set m_initiallyFitToViewport to true in order to fit content to viewport size by default.
Initizlize content position with (0, 0).
(WebKit::PageViewportController::pageTransitionViewportReady):
Do not update scale when m_initiallyFitToViewport is false.
(WebKit::PageViewportController::syncVisibleContents):
Return false when syncVisibleContents is failed.
(WebKit::PageViewportController::didChangeViewportAttributes):
Do not update scale when m_initiallyFitToViewport is false.
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
If syncVisibleContents() is failed, m_pageScaleFactor should be restored with previous value.
If not, new scale factor isn't applied though, PageViewportController uses it as own scale factor.
(WebKit::PageViewportController::updateMinimumScaleToFit):
Do not update scale when m_initiallyFitToViewport is false or m_hadUserInteraction is true.
- UIProcess/CoordinatedGraphics/PageViewportController.h:
(WebKit::PageViewportController::setInitiallyFitToViewport):
- 2:50 AM Changeset in webkit [176630] by
-
- 13 edits2 adds in trunk
Source/WebCore:
Missing support for innerHTML on SVGElement
https://bugs.webkit.org/show_bug.cgi?id=136903
Patch by Sylvain Galineau <galineau@adobe.com> on 2014-12-02
Reviewed by Dean Jackson.
Two parts to this patch:
- Move innerHTML/outerHTML to Element so SVG elements can inherit them, per https://dvcs.w3.org/hg/innerhtml/raw-file/tip/index.html#innerhtml
- Make sure fragment insertion is processed relative to the proper node, per http://www.whatwg.org/specs/web-apps/current-work/#adjusted-current-node
The latter part was ported over from Blink.
Test: svg/in-html/svg-inner-html.html
- bindings/objc/PublicDOMInterfaces.h: Move innerHTML/outerHTML to Element.
- dom/Element.cpp:
(WebCore::Element::mergeWithNextTextNode): Helper used by Element::innerHTML/outerHTML as well as HTMLElement::innerText/outerText; moved to Element as protected static.
(WebCore::Element::innerHTML): Moved from HTMLElement.
(WebCore::Element::outerHTML): Moved from HTMLElement.
(WebCore::Element::setOuterHTML): Moved from HTMLElement.
(WebCore::Element::setInnerHTML): Moved from HTMLElement.
- dom/Element.h:
- dom/Element.idl:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::innerHTML): Deleted.
(WebCore::HTMLElement::outerHTML): Deleted.
(WebCore::HTMLElement::setInnerHTML): Deleted.
(WebCore::mergeWithNextTextNode): Deleted.
(WebCore::HTMLElement::setOuterHTML): Deleted.
- html/HTMLElement.h:
- html/HTMLElement.idl:
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): no more m_contextElement.
(WebCore::HTMLTreeBuilder::constructTree): read namespace from adjusted current node.
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): use contextElementStackItem for insertion.
(WebCore::HTMLTreeBuilder::adjustedCurrentStackItem): compute adjusted current node.
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent): use adjusted current node for context.
(WebCore::HTMLTreeBuilder::processTokenInForeignContent): use adjusted current node to read namespace.
- html/parser/HTMLTreeBuilder.h:
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement): Deleted. Read from contextElementStackItem.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElementStackItem): Added.
LayoutTests:
Missing support for innerHTML on SVGElement
https://bugs.webkit.org/show_bug.cgi?id=136903
Patch by Sylvain Galineau <galineau@adobe.com> on 2014-12-02
Reviewed by Dean Jackson.
- js/dom/dom-static-property-for-in-iteration-expected.txt: The property enumeration order is different now that inner/outerHTML are inherited from Element
- platform/mac/svg/in-html/svg-inner-html-expected.png: Added.
- svg/css/svg-attribute-length-parsing-expected.txt:
Now that innerHTML works, the output should start with 'Test'
- svg/in-html/svg-inner-html-expected.txt: Added.
- svg/in-html/svg-inner-html.html: Added.
- 2:36 AM Changeset in webkit [176629] by
-
- 2 edits in trunk/Tools
[jhbuild] wrong Dependencies path
https://bugs.webkit.org/show_bug.cgi?id=139176
Reviewed by Martin Robinson.
- Scripts/webkitpy/port/base.py:
(Port._should_use_jhbuild):
- 1:47 AM Changeset in webkit [176628] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r176122): [GTK] Layout Test platform/gtk/accessibility/table-hierarchy.html fails.
https://bugs.webkit.org/show_bug.cgi?id=139125
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-12-02
Reviewed by Chris Fleizach.
Update test and expectation to fix regression.
- platform/gtk/accessibility/table-hierarchy-expected.txt:
- platform/gtk/accessibility/table-hierarchy.html:
- 12:12 AM Changeset in webkit [176627] by
-
- 2 edits3 deletes in trunk/Tools
[GStreamer] Bump internal jhbuild versions to 1.4.4
https://bugs.webkit.org/show_bug.cgi?id=138866
Reviewed by Carlos Garcia Campos.
- gtk/jhbuild.modules:
- gtk/patches/gst-events-arent-gstobjects.patch: Removed.
- gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
- gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
Dec 1, 2014:
- 8:28 PM Changeset in webkit [176626] by
-
- 5 edits in trunk/Source
Add cancelable version of willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=138987
Reviewed by Anders Carlsson.
Source/WebCore:
Covered by existing tests.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest):
- loader/ResourceLoader.h:
Source/WebKit2:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::willSendRequest):
- 8:09 PM Changeset in webkit [176625] by
-
- 13 edits in trunk/Source/JavaScriptCore
Remove GetMyScope node from DFG
https://bugs.webkit.org/show_bug.cgi?id=139166
Reviewed by Oliver Hunt.
Eliminated GetMyScope DFG node type.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::isLiveInBytecode):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetMyScope): Deleted.
- 6:50 PM Changeset in webkit [176624] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash (integer overflow) beneath ByteCodeParser::handleGetById typing in search field on weather.com
https://bugs.webkit.org/show_bug.cgi?id=139165
Reviewed by Oliver Hunt.
If we don't have any getById or putById variants, emit non-cached versions of these operations.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
- 6:29 PM Changeset in webkit [176623] by
-
- 6 edits16 adds in trunk
Add the dynamic specificity of the selector list argument when matching :nth-child() and :nth-last-child()
https://bugs.webkit.org/show_bug.cgi?id=139001
Reviewed by Andreas Kling.
Source/WebCore:
When matching :nth-child(An+B of selector list) or :nth-last-child(An+B of selector list),
we were previously ignoring the arguments.
That behavior seems to be confusing for users. We made the proposal to include the selector list
like when using :matches():
http://lists.w3.org/Archives/Public/www-style/2014Oct/0533.html
David Baron also agrees with this behavior:
http://lists.w3.org/Archives/Public/www-style/2014Oct/0534.html
This patch adds the specificity computation.
Tests: fast/css/nth-child-specificity-1.html
fast/css/nth-child-specificity-2.html
fast/css/nth-last-child-specificity-1.html
fast/css/nth-last-child-specificity-2.html
- css/CSSSelector.cpp:
(WebCore::simpleSelectorFunctionalPseudoClassStaticSpecificity):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::matchSelectorList):
- css/SelectorChecker.h:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
LayoutTests:
- fast/css/nth-child-specificity-1-expected.html: Added.
- fast/css/nth-child-specificity-1.html: Added.
- fast/css/nth-child-specificity-2-expected.html: Added.
- fast/css/nth-child-specificity-2.html: Added.
- fast/css/nth-child-specificity-3-expected.html: Added.
- fast/css/nth-child-specificity-3.html: Added.
- fast/css/nth-child-specificity-4-expected.html: Added.
- fast/css/nth-child-specificity-4.html: Added.
- fast/css/nth-last-child-specificity-1-expected.html: Added.
- fast/css/nth-last-child-specificity-1.html: Added.
- fast/css/nth-last-child-specificity-2-expected.html: Added.
- fast/css/nth-last-child-specificity-2.html: Added.
- fast/css/nth-last-child-specificity-3-expected.html: Added.
- fast/css/nth-last-child-specificity-3.html: Added.
- fast/css/nth-last-child-specificity-4-expected.html: Added.
- fast/css/nth-last-child-specificity-4.html: Added.
- 6:21 PM Changeset in webkit [176622] by
-
- 6 edits in trunk/Source
Optimize constructing JSC::Identifier from AtomicString.
<https://webkit.org/b/139157>
Reviewed by Michael Saboff.
Source/JavaScriptCore:
Add constructors for Identifier taking AtomicString and AtomicStringImpl.
This avoids branching on the string's isAtomic flag, which is obviously
always true for AtomicString & AtomicStringImpl.
Had to add a Identifier(const char*) constructor to resolve implicit
ambiguity between String / AtomicString.
Also made PrivateName::uid() return AtomicStringImpl* to take advantage
of the new constructor in a few places.
- runtime/Identifier.h:
(JSC::Identifier::Identifier):
- runtime/IdentifierInlines.h:
(JSC::Identifier::Identifier):
- runtime/PrivateName.h:
(JSC::PrivateName::uid):
Source/WTF:
Make AtomicString::isInAtomicStringTable() public so it can be used
in some Identifier assertions.
- wtf/text/AtomicString.h:
- 6:16 PM Changeset in webkit [176621] by
-
- 4 edits in trunk/Source/WebCore
Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138938
Reviewed by Sam Weinig.
Move 'text-shadow' / 'box-shadow' / '-webkit-box-shadow' CSS properties
from StyleResolver to the new StyleBuilder by using custom code.
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyTextOrBoxShadowValue):
(WebCore::StyleBuilderCustom::applyInitialTextShadow):
(WebCore::StyleBuilderCustom::applyInheritTextShadow):
(WebCore::StyleBuilderCustom::applyValueTextShadow):
(WebCore::StyleBuilderCustom::applyInitialBoxShadow):
(WebCore::StyleBuilderCustom::applyInheritBoxShadow):
(WebCore::StyleBuilderCustom::applyValueBoxShadow):
(WebCore::StyleBuilderCustom::applyInitialWebkitBoxShadow):
(WebCore::StyleBuilderCustom::applyInheritWebkitBoxShadow):
(WebCore::StyleBuilderCustom::applyValueWebkitBoxShadow):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 6:02 PM Changeset in webkit [176620] by
-
- 6 edits in trunk
[EFL] Add a ENABLE_CSS_SCROLL_SNAP macro to CMake build system
https://bugs.webkit.org/show_bug.cgi?id=139085
Reviewed by Andreas Kling.
.:
- Source/cmake/OptionsEfl.cmake: Add ENABLE_CSS_SCROLL_SNAP.
- Source/cmake/WebKitFeatures.cmake: ditto.
- Source/cmakeconfig.h.cmake: ditto.
Source/WebCore:
- PlatformEfl.cmake:
Include page/scrolling/AxisScrollSnapOffsets.cpp to EFL build files to fix build break.
- 5:59 PM Changeset in webkit [176619] by
-
- 3 edits2 adds in trunk
Twitter avatar moves when hovering/unhovering the "follow" button.
https://bugs.webkit.org/show_bug.cgi?id=139147
rdar://problem/19096508
Reviewed by Simon Fraser.
This patch ensures that the out of flow positioned render boxes (RenderReplaced) do not
get repositioned when their inline box wrappers move.
Ideally, out of flow positioned renderers do not have inline wrappers by the time we start
placing inline boxes, but in certain case (optimized code path for descendantsHaveSameLineHeightAndBaseline()),
they are still part of the inline box tree.
This patch prevents those renderer boxes from getting positioned as part of the inline box placement.
They will get removed later at RenderBlockFlow::computeBlockDirectionPositionsForLine().
Source/WebCore:
Test: fast/inline/out-of-flow-positioned-render-replaced-box-moves.html
- rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustPosition):
LayoutTests:
- fast/inline/out-of-flow-positioned-render-replaced-box-moves-expected.html: Added.
- fast/inline/out-of-flow-positioned-render-replaced-box-moves.html: Added.
- 5:49 PM Changeset in webkit [176618] by
-
- 2 edits in trunk/Source/WebKit/mac
Try to fix the Mac build.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _close]):
- 5:29 PM Changeset in webkit [176617] by
-
- 2 edits in trunk/Source/WebCore
Null deref under TextIndicator::createWithSelectionInFrame using find-in-page on bugzilla
https://bugs.webkit.org/show_bug.cgi?id=139164
<rdar://problem/19107247>
Reviewed by Beth Dakin.
- page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithSelectionInFrame):
Null-check the ImageBuffer in addition to the Image.
- 5:16 PM Changeset in webkit [176616] by
-
- 2 edits in trunk/Source/WTF
Fix non-mac builds.
- wtf/IndexedIterator.h:
- 5:12 PM Changeset in webkit [176615] by
-
- 2 edits in trunk/LayoutTests
[iOS] Unskip LayoutTests/dom tests
- platform/ios-simulator/TestExpectations:
- 4:55 PM Changeset in webkit [176614] by
-
- 13 edits5 deletes in trunk/Source
Remove IWebCookieManager on Windows
https://bugs.webkit.org/show_bug.cgi?id=139144
Reviewed by Sam Weinig.
Source/WebCore:
Remove code that handles overriding the cookie storage.
- platform/network/NetworkStorageSession.h:
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::cookieStorageOverride): Deleted.
(WebCore::overrideCookieStorage): Deleted.
(WebCore::overridenCookieStorage): Deleted.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
Source/WebKit:
Remove files.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters:
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
Source/WebKit/win:
Remove WebCookieManager.
- ForEachCoClass.h:
- Interfaces/IWebCookieManager.idl: Removed.
- Interfaces/WebKit.idl:
- WebCookieManager.cpp: Removed.
- WebCookieManager.h: Removed.
- WebCookieManagerCFNet.cpp: Removed.
- WebCookieManagerCurl.cpp: Removed.
- WebKitClassFactory.cpp:
- 4:49 PM Changeset in webkit [176613] by
-
- 5 edits in trunk/Source/WebKit2
Clients need a way to explicitly set the title of a page preview
https://bugs.webkit.org/show_bug.cgi?id=139161
Reviewed by Beth Dakin.
This implicitly assumes that only one page preview can be associate with a given WKView at a time.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _setPreviewTitle:]):
Wrap -[WKActionMenuController setPreviewTitle:]
- UIProcess/mac/WKActionMenuController.h:
- UIProcess/mac/WKActionMenuController.mm:
Add ivars for the title and the title text field (previously not independently exposed).
(-[WKPagePreviewViewController previewTitle]):
Accessor.
(-[WKPagePreviewViewController setPreviewTitle:]):
Accessor; set the text field's string value.
(-[WKPagePreviewViewController loadView]):
Adopt the _titleTextField ivar; assume that if a client has explicitly set the previewTitle then we don't
need to ask for it again.
(-[WKActionMenuController setPreviewTitle:]):
Wrap -[WKPagePreviewViewController setPreviewTitle:].
- 4:18 PM Changeset in webkit [176612] by
-
- 2 edits in trunk/Source/WebCore
[iOS Media] Slider knob should not have a border
https://bugs.webkit.org/show_bug.cgi?id=139160
<rdar://problem/19075185>
Reviewed by Jer Noble.
The change in r175715 required adding !important to a bunch
of rules for pseudo elements. The border width of slider knobs
for media controls should be zero, so add an !important there.
- Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-timeline::-webkit-slider-thumb): Change
border to border-width and force it to zero.
- 4:10 PM Changeset in webkit [176611] by
-
- 2 edits in trunk/Source/WebKit2
Make WebKit2 work slightly better with garbage collection
https://bugs.webkit.org/show_bug.cgi?id=139159
<rdar://problem/19108390>
Reviewed by Dan Bernstein.
- Shared/Cocoa/APIObject.mm:
(API::Object::ref):
(API::Object::deref):
Call CFRetain/CFRelease to prevent the memory from being collected.
(API::Object::newObject):
Call CFRetain under GC so we'll prevent memory from being collected prematurely.
- 4:10 PM Changeset in webkit [176610] by
-
- 11 edits in trunk/Source/WebInspectorUI
Web Inspector: add more :not() and :matches() awesomeness
https://bugs.webkit.org/show_bug.cgi?id=138997
Reviewed by Joseph Pecoraro.
Simplify the Inspector's CSS when possible.
- UserInterface/Views/DatabaseContentView.css:
(:matches(.database-user-query, .database-query-prompt, .database-query-result)::before):
(.database-user-query::before, .database-query-prompt::before, .database-query-result::before): Deleted.
- UserInterface/Views/GradientSlider.css:
(.gradient-slider-knob > :matches(img, div)):
(.gradient-slider-knob > div): Deleted.
- UserInterface/Views/HoverMenu.css:
(.hover-menu > svg > :matches(path, rect)):
(.hover-menu > svg > rect): Deleted.
- UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
(.panel.details.layer-tree .name-column :matches(.pseudo-element, .reflection)):
(.panel.details.layer-tree tr.selected .name-column :matches(.pseudo-element, .reflection)):
(.panel.details.layer-tree .name-column .reflection): Deleted.
(.panel.details.layer-tree tr.selected .name-column .reflection): Deleted.
- UserInterface/Views/ProbeDetailsSidebarPanel.css:
(.details-section.probe-set .options > :matches(.probe-remove, .probe-clear-samples, .probe-add)):
(.details-section.probe-set .options > .probe-add): Deleted.
- UserInterface/Views/ResourceSidebarPanel.css:
(.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
(.sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
- UserInterface/Views/ScopeBar.css:
(.scope-bar > li:matches(.selected, :active)):
(.scope-bar > li:active): Deleted.
- UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(.syntax-highlighted :matches(.css-comment, .javascript-comment, .html-comment)):
(.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
(.syntax-highlighted :matches(.css-number, .javascript-number)):
(.syntax-highlighted :matches(.css-property, .css-selector, .javascript-ident)):
(.syntax-highlighted :matches(.css-string, .javascript-string, .javascript-regexp, .html-attribute-value)):
(.syntax-highlighted :matches(.html-doctype, .html-processing-instruction)):
(.syntax-highlighted .html-comment): Deleted.
(.syntax-highlighted .html-tag): Deleted.
(.syntax-highlighted .javascript-number): Deleted.
(.syntax-highlighted .javascript-ident): Deleted.
(.syntax-highlighted .html-attribute-value): Deleted.
(.syntax-highlighted .html-processing-instruction): Deleted.
It looks like ".cm-tag.cm-bracket" was there only to override the rule below.
From basic testing, it looks like "cm-tag" and "cm-bracket" always appear together. I removed the "cm-bracket" rule
from the second rule, and simplified the first rule.
- UserInterface/Views/TimelineSidebarPanel.css:
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .empty-content-placeholder): Deleted.
- UserInterface/Views/Toolbar.css:
(body.mac-platform:not(.legacy, .docked) .toolbar):
(body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical):
(body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical.small-size):
(body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal, .icon-only)):
(body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only)):
(.toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only) .control-section):
(body.mac-platform:not(.legacy):not(.docked) .toolbar): Deleted.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Deleted.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Deleted.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Deleted.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Deleted.
(.toolbar.label-only .control-section): Deleted.
- 4:09 PM Changeset in webkit [176609] by
-
- 6 edits4 adds in trunk
Take into consideration canvas drawing for throttling DOM timers
https://bugs.webkit.org/show_bug.cgi?id=139140
<rdar://problem/19102218>
Reviewed by Andreas Kling.
Source/WebCore:
Take into consideration canvas drawing for throttling DOM timers so
that:
- Timers drawing on a visible canvas can no longer get throttled. This fixes the following sites:
- Timers that are drawing on a canvas that is not user observable now get throttled, thus using less CPU. As an example, on http://hint.fm/wind/, CPU usage is at 110% when the canvas is inside the viewport on my machine. CPU usage would remain at 110% when scrolling the canvas outside the viewport before this patch. After this patch, the CPU usage goes down to 5% when the canvas is outside the viewport.
Tests: fast/canvas/canvas-inside-viewport-timer-throttling.html
fast/canvas/canvas-outside-viewport-timer-throttling.html
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::putDelegate):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::notifyObserversCanvasChanged):
- page/DOMTimer.cpp:
(WebCore::DOMTimerFireState::setScriptMadeNonUserObservableChangesToElement):
(WebCore::DOMTimer::scriptDidCauseElementRepaint):
(WebCore::DOMTimerFireState::setScriptMadeNonUserObservableChangesToElementStyle): Deleted.
(WebCore::DOMTimer::scriptDidUpdateStyleOfElement): Deleted.
- page/DOMTimer.h:
LayoutTests:
Add layout tests to test that we take into consideration canvas drawing
when considering if we should throttle DOM timers.
- fast/canvas/canvas-inside-viewport-timer-throttling-expected.txt: Added.
- fast/canvas/canvas-inside-viewport-timer-throttling.html: Added.
- fast/canvas/canvas-outside-viewport-timer-throttling-expected.txt: Added.
- fast/canvas/canvas-outside-viewport-timer-throttling.html: Added.
- 3:56 PM Changeset in webkit [176608] by
-
- 8 edits in trunk/Source/WebKit/mac
Fix the iOS build.
- WebView/WebActionMenuController.h:
- WebView/WebActionMenuController.mm:
- WebView/WebHTMLView.mm:
(-[WebHTMLView scrollWheel:scrollWheel:]):
(-[WebHTMLView mouseDown:mouseDown:]):
- WebView/WebView.mm:
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]):
- WebView/WebViewInternal.h:
- 3:54 PM Changeset in webkit [176607] by
-
- 4 edits2 adds in trunk
Crash in Font::dashesForIntersectionsWithRect() due to underlining SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=139158
Reviewed by Simon Fraser.
Source/WebCore:
RenderingContexts are only created if the primary SimpleFontData is an SVG font,
but dashesForIntersectionWithRect() uses the first character's SimpleFontData.
One might be an SVG font but the other might not be.
Note that this brittle design will be fixed with the SVG -> OTF translator.
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/decoration-skip-crash-fallback-svg.html
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect):
LayoutTests:
Test for no crashes when the primary SimpleFontData and the first character's
SimpleFontData differ in their SVG-ness.
- fast/css3-text/css3-text-decoration/text-decoration-skip/decoration-skip-crash-fallback-svg-expected.html: Added.
- fast/css3-text/css3-text-decoration/text-decoration-skip/decoration-skip-crash-fallback-svg.html: Added.
- 3:40 PM Changeset in webkit [176606] by
-
- 2 edits in trunk/LayoutTests
[iOS] Update expected results for LayoutTests/crypto
- platform/ios-simulator/TestExpectations:
- 3:37 PM Changeset in webkit [176605] by
-
- 1 edit2 adds in trunk/LayoutTests
[iOS] Skip some animation tests that time out in iOS WebKit2
- platform/ios-simulator-wk2/TestExpectations: Added.
- 2:04 PM Changeset in webkit [176604] by
-
- 2 edits in trunk/Source/WebCore
[MSE] Fix not always calling mediaPlayer seek.
https://bugs.webkit.org/show_bug.cgi?id=139139
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2014-12-01
Reviewed by Jer Noble.
Original comment states that media source shall always be notified of seek if it's not closed.
No new tests needed.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::seekTimerFired):
- 1:49 PM Changeset in webkit [176603] by
-
- 2 edits in trunk/Source/WTF
Fix 32-bit build.
- wtf/IndexedIterator.h:
- 1:15 PM Changeset in webkit [176602] by
-
- 6 edits2 adds1 delete in trunk/LayoutTests
http tests should not use shared temporary files, part 3
https://bugs.webkit.org/show_bug.cgi?id=139135
Reviewed by Tim Horton.
Fix ping tests, using the same techniques as before.
- http/tests/navigation/image-load-in-unload-handler.html:
- http/tests/navigation/ping-cross-origin-from-https.html:
- http/tests/navigation/resources/check-ping.php:
- http/tests/navigation/resources/delete-ping.php:
- http/tests/navigation/resources/image-load-in-unload-handler-2.html: Copied from LayoutTests/http/tests/navigation/resources/ping-redirect.html.
- http/tests/navigation/resources/ping-file-path.php: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/resources/report-file-path.php.
- http/tests/navigation/resources/ping-redirect.html: Removed.
- http/tests/navigation/resources/save-Ping.php:
- 1:14 PM Changeset in webkit [176601] by
-
- 10 edits in trunk/Source/JavaScriptCore
Several JavaScriptCore date tests are flaky, because they expect time to be frozen during execution
https://bugs.webkit.org/show_bug.cgi?id=139138
Reviewed by Mark Lam.
Merged a fix by Bob Clary.
- tests/mozilla/ecma/Date/15.9.1.1-1.js:
- tests/mozilla/ecma/Date/15.9.1.1-2.js:
- tests/mozilla/ecma/Date/15.9.2.1.js:
- tests/mozilla/ecma/Date/15.9.2.2-1.js:
- tests/mozilla/ecma/Date/15.9.2.2-2.js:
- tests/mozilla/ecma/Date/15.9.2.2-3.js:
- tests/mozilla/ecma/Date/15.9.2.2-4.js:
- tests/mozilla/ecma/Date/15.9.2.2-5.js:
- tests/mozilla/ecma/Date/15.9.2.2-6.js:
- 1:10 PM Changeset in webkit [176600] by
-
- 3 edits in trunk/LayoutTests
<rdar://problem/11358748> http/tests/multipart/multipart-wait-before-boundary.html fails on ML as of r115745
Looks like it no longer fails.
- platform/mac/TestExpectations:
- platform/wk2/TestExpectations:
Removed it from test expectations.
- 12:48 PM Changeset in webkit [176599] by
-
- 15 edits in trunk/Source
Implement yellow highlight for WebKit1 data detectors
https://bugs.webkit.org/show_bug.cgi?id=138956
<rdar://problem/18992185>
Reviewed by Beth Dakin.
- page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithSelectionInFrame):
(WebCore::TextIndicator::TextIndicator):
- page/TextIndicator.h:
(WebCore::TextIndicator::selectionRectInScreenCoordinates):
(WebCore::TextIndicator::textBoundingRectInScreenCoordinates):
(WebCore::TextIndicator::selectionRectInWindowCoordinates): Deleted.
(WebCore::TextIndicator::textBoundingRectInWindowCoordinates): Deleted.
Store TextIndicator rects in screen coordinates, since that's what we
want anyway, and this makes it easier to share this code between the WebKits.
- page/mac/TextIndicatorWindow.mm:
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
(WebCore::TextIndicatorWindow::setTextIndicator):
Avoid some rect conversion because the TextIndicator rects are already in screen coordinates.
- WebView/WebActionMenuController.h:
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController webView:willHandleMouseDown:]):
(-[WebActionMenuController webView:didHandleScrollWheel:]):
(-[WebActionMenuController prepareForMenu:withEvent:]):
(-[WebActionMenuController didCloseMenu:withEvent:]):
(-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
(-[WebActionMenuController _showTextIndicator]):
(-[WebActionMenuController _hideTextIndicator]):
(-[WebActionMenuController _dismissActionMenuPopovers]):
Copy the WebKit2 WKActionMenuController TextIndicator implementation
into WebActionMenuController. The only significant difference is
that we build the TextIndicator right at menu construction time
instead of in the Web process.
- WebView/WebHTMLView.mm:
(-[WebHTMLView scrollWheel:]):
Let the WebActionMenuController know that we're handling a scroll.
(-[WebHTMLView mouseDown:]):
Let the WebActionMenuController know that we're handling a mouseDown.
- WebView/WebView.mm:
(-[WebView _setTextIndicator:fadeOut:animationCompletionHandler:]):
(-[WebView _clearTextIndicator]):
(-[WebView _actionMenuController]):
(-[WebView _convertRectFromRootView:]): Deleted.
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
- WebView/WebViewInternal.h:
Keep a TextIndicatorWindow on WebView, just like WKView does.
Expose the WebActionMenuController on WebView (internally).
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):
Adjust to the fact that TextIndicator keeps screen-relative rects.
- 12:18 PM Changeset in webkit [176598] by
-
- 12 edits in trunk/Source
Remove old site specific quirks code that was added in 2009
https://bugs.webkit.org/show_bug.cgi?id=139141
Reviewed by Antti Koivisto.
Source/WebCore:
- platform/network/NetworkingContext.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
Source/WebKit/mac:
- WebCoreSupport/WebFrameNetworkingContext.h:
- WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
Source/WebKit2:
- NetworkProcess/RemoteNetworkingContext.h:
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::needsSiteSpecificQuirks): Deleted.
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks): Deleted.
- 12:06 PM Changeset in webkit [176597] by
-
- 5 edits in branches/safari-600.3-branch/Source
Bump versioning
- 11:59 AM Changeset in webkit [176596] by
-
- 2 edits in trunk/Source/WebKit2
Web Inspector: Crash in WebInspectorClient::hideHighlight when page is destroyed
https://bugs.webkit.org/show_bug.cgi?id=139136
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-12-01
Reviewed by Simon Fraser.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::hideHighlight):
Speculatively fix by null-checking the main frame which
can be null during page destruction.
- 11:11 AM Changeset in webkit [176595] by
-
- 4 edits in trunk
Web Inspector: DOMExceptions do not show the error message string in Pause Reason section
https://bugs.webkit.org/show_bug.cgi?id=138988
Reviewed by Timothy Hatcher.
Source/WebCore:
- inspector/WebInjectedScriptHost.cpp:
(WebCore::WebInjectedScriptHost::type):
Give all DOM Exception types the "error" RemoteObject subtype.
LayoutTests:
- inspector/debugger/command-line-api-exception-expected.txt:
- 11:01 AM Changeset in webkit [176594] by
-
- 4 edits2 adds in trunk
[MSE] Unset timestamps of trackbuffers during Reset Parser State algorithm.
https://bugs.webkit.org/show_bug.cgi?id=139075.
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2014-12-01
Reviewed by Jer Noble.
Source/WebCore:
Specification requires from us to unset timestamps for trackBuffers
during abort() method.
Test: media/media-source/media-source-append-nonsync-sample-after-abort.html
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::resetParserState):
(WebCore::SourceBuffer::abort):
- Modules/mediasource/SourceBuffer.h:
LayoutTests:
Specification requires from us to unset timestamps for trackBuffers during abort() method.
Tests appendBuffer() with first sync sample, then aborts after a few more samples, and emits
a few more non-sync samples, so they should be dropped, as trackBuffer will have
needRandomAccessFlag set.
- media/media-source/media-source-append-nonsync-sample-after-abort-expected.txt: Added.
- media/media-source/media-source-append-nonsync-sample-after-abort.html: Added.
- 10:42 AM Changeset in webkit [176593] by
-
- 4 edits in trunk/Source/WebCore
Transform StyleBuilderCustom into a class and mark it as a friend of RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=138999
Reviewed by Sam Weinig.
Transform StyleBuilderCustom into a class and mark it as a friend of
RenderStyle. This is needed because some of the StyleBuilderCustom
functions need to access RenderStyle's private API.
No new tests, no behavior change.
- css/StyleBuilderCustom.h: Move functions from StyleBuilderFunctions namespace to StyleBuilderCustom class.
- css/makeprop.pl: Use StyleBuilderCustom scope instead of StyleBuilderFunctions for custom implementation.
- rendering/style/RenderStyle.h: Mark StyleBuilderCustom class as a friend, similarly to what was already done for DeprecatedStyleBuilder and StyleResolver.
- 9:50 AM Changeset in webkit [176592] by
-
- 29 edits1 add in trunk/Source
Make sure range based iteration of Vector<> still receives bounds checking
https://bugs.webkit.org/show_bug.cgi?id=138821
Reviewed by Mark Lam.
Source/JavaScriptCore:
There are a few uses of begin()/end() that explicitly require pointers,
so we use getPtr() to extract the underlying pointer generically.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::visitChildren):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitComplexPopScopes):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
- ftl/FTLAbbreviations.h:
(JSC::FTL::mdNode):
(JSC::FTL::buildCall):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- parser/Parser.h:
(JSC::Scope::Scope):
- profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintRecursively):
- runtime/JSArray.cpp:
(JSC::JSArray::setLengthWithArrayStorage):
(JSC::JSArray::sortCompactedVector):
- tools/ProfileTreeNode.h:
(JSC::ProfileTreeNode::dumpInternal):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::matchCharacterClass):
Source/WebCore:
There are a few uses of begin()/end() that explicitly require pointers,
so we use getPtr() to extract the underlying pointer generically.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::deserializeString):
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::isBadMatch):
- page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::buildSelectionHighlight):
- platform/graphics/SegmentedFontData.cpp:
(WebCore::SegmentedFontData::fontDataForCharacter):
(WebCore::SegmentedFontData::containsCharacter):
(WebCore::SegmentedFontData::isLoading):
- platform/graphics/WOFFFileFormat.cpp:
(WebCore::convertWOFFToSfnt):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
- rendering/style/GridResolvedPosition.cpp:
(WebCore::firstNamedGridLineBeforePosition):
(WebCore::GridResolvedPosition::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
- svg/SVGFontElement.cpp:
(WebCore::kerningForPairOfStringsAndGlyphs):
- svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::append):
- xml/XPathNodeSet.h:
(WebCore::XPath::NodeSet::begin):
(WebCore::XPath::NodeSet::end):
Source/WTF:
Add a new IndexedIterator struct to WTF that wraps a
Vector type and index to provide pointer like semantics
while still performing runtime bounds checking, even in
release builds. We store a simple index into the vector
which means that this iterator allows vector resizing
during iteration. If the vector is resized such that the
iterator is out of bounds, then any attempt to dereference
the iterator will crash safely. Any other errors, including
overflows, and over extending the iterator will likewise
crash.
For the purpose of retaining semantically equivalent
behaviour, the iterator can be moved to m_index == size()
as that is the standard "end" terminator for these types.
Attempting to dereference at that point will still crash
rather than perform an unsafe memory operation.
In order to maintain the validity of all the bounds checking,
we perform full integer range checking prior to any mutation
of the iterator location. If we detect an arithmetic overflow
we will crash rather than attempting to carry on.
By necessity there are many overrides for operator + and - as
we otherwise hit many different type promotion ambiguities when
performing arithmetic with iterators. These ambiguities are also
different for 32- vs. 64-bit, so duplicating the functions
and then forwarding to the core implementations that performed
the bounds checking and mutation seemed like the right call.
- WTF.xcodeproj/project.pbxproj:
- wtf/IndexedIterator.h: Added.
(WTF::IndexedIterator::IndexedIterator):
(WTF::IndexedIterator::operator->):
(WTF::IndexedIterator::operator*):
(WTF::IndexedIterator::get):
(WTF::IndexedIterator::operator++):
(WTF::IndexedIterator::operator--):
(WTF::IndexedIterator::operator UnspecifiedBoolType):
(WTF::IndexedIterator::operator+=):
(WTF::IndexedIterator::operator-=):
(WTF::IndexedIterator::operator+):
(WTF::IndexedIterator::operator-):
(WTF::IndexedIterator::operator=):
(WTF::IndexedIterator::operator==):
(WTF::IndexedIterator::operator!=):
(WTF::IndexedIterator::operator<):
(WTF::IndexedIterator::operator<=):
(WTF::IndexedIterator::operator>):
(WTF::IndexedIterator::operator>=):
(WTF::IndexedIterator::operator const_iterator):
(WTF::IndexedIterator::isSafeToCompare):
(WTF::IndexedIterator::unsafeGet):
(WTF::getPtr):
(WTF::operator-):
(WTF::operator==):
(WTF::operator!=):
(WTF::operator<=):
(WTF::operator>=):
(WTF::operator<):
(WTF::operator>):
(WTF::IndexedIteratorSelector::makeIterator):
(WTF::IndexedIteratorSelector::makeConstIterator):
- wtf/RefCountedArray.h:
(WTF::RefCountedArray::RefCountedArray):
- wtf/Vector.h:
(WTF::Vector::Vector):
(WTF::Vector::begin):
(WTF::Vector::end):
(WTF::OverflowHandler>::Vector):
(WTF::=):
(WTF::OverflowHandler>::fill):
(WTF::OverflowHandler>::expandCapacity):
(WTF::OverflowHandler>::tryExpandCapacity):
(WTF::OverflowHandler>::resize):
(WTF::OverflowHandler>::shrink):
(WTF::OverflowHandler>::grow):
(WTF::OverflowHandler>::reserveCapacity):
(WTF::OverflowHandler>::tryReserveCapacity):
(WTF::OverflowHandler>::shrinkCapacity):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::appendSlowCase):
(WTF::OverflowHandler>::uncheckedAppend):
(WTF::OverflowHandler>::appendVector):
(WTF::OverflowHandler>::insert):
(WTF::OverflowHandler>::insertVector):
(WTF::OverflowHandler>::remove):
- 6:48 AM Changeset in webkit [176591] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r176566.
https://bugs.webkit.org/show_bug.cgi?id=139124
It broke the GTK performance tests. (Requested by clopez on
#webkit).
Reverted changeset:
"[GTK] Use GMainLoopSource in WebKitTestRunner"
https://bugs.webkit.org/show_bug.cgi?id=138831
http://trac.webkit.org/changeset/176566
Nov 30, 2014:
- 11:36 PM Changeset in webkit [176590] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Add eldbus to the library list
https://bugs.webkit.org/show_bug.cgi?id=139120
Reviewed by Gyuyoung Kim.
Fix undefined reference errors for eldbus APIs.
- PlatformEfl.cmake:
- 7:48 PM Changeset in webkit [176589] by
-
- 4 edits9 deletes in trunk
[EFL] Drop support for the EFL 1.7
https://bugs.webkit.org/show_bug.cgi?id=139114
Reviewed by Gyuyoung Kim.
.:
- Source/cmake/EFLHelpers.cmake: Removed.
- Source/cmake/FindEcore.cmake: Removed.
- Source/cmake/FindEdje.cmake: Removed.
- Source/cmake/FindEet.cmake: Removed.
- Source/cmake/FindEeze.cmake: Removed.
- Source/cmake/FindEfreet.cmake: Removed.
- Source/cmake/FindEina.cmake: Removed.
- Source/cmake/FindElementary.cmake: Removed.
- Source/cmake/FindEvas.cmake: Removed.
- Source/cmake/OptionsEfl.cmake:
Source/WTF:
- wtf/efl/EflTypedefs.h: Removed old definitions which EFL 1.7 used.
- 4:20 PM Changeset in webkit [176588] by
-
- 3 edits in trunk/Source/WebKit/mac
Fix a test failure.
- History/WebHistory.mm:
(+[WebHistory _setVisitedLinkTrackingEnabled:]):
Call through to the visited link store.
(+[WebHistory _removeAllVisitedLinks]):
Ditto.
- WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::isLinkVisited):
Make sure to populate visited links.
- 2:48 PM Changeset in webkit [176587] by
-
- 2 edits in trunk/Source/WebKit/mac
Switch over to the visited link store from the WebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=139112
Reviewed by Sam Weinig.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView setGroupName:]):
- 2:45 PM Changeset in webkit [176586] by
-
- 4 edits in trunk/Source/WebKit/mac
Add WebVisitedLinkStore::removeVisitedLink and use it on iOS
https://bugs.webkit.org/show_bug.cgi?id=139111
Reviewed by Sam Weinig.
- WebCoreSupport/WebVisitedLinkStore.h:
- WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::removeVisitedLink):
- WebView/WebView.mm:
(-[WebView removeVisitedLink:]):
Nov 29, 2014:
- 6:36 PM Changeset in webkit [176585] by
-
- 2 edits in trunk/Source/WebCore
Fix a build warning when CSS_SCROLL_SNAP is enabled
https://bugs.webkit.org/show_bug.cgi?id=139084
Reviewed by Andrei Bucur.
Fix a build warning. Copy constructor of StyleScrollSnapPoints should initialize its base class.
- rendering/style/StyleScrollSnapPoints.cpp:
(WebCore::StyleScrollSnapPoints::StyleScrollSnapPoints): Call RefCounted().
- 4:39 PM Changeset in webkit [176584] by
-
- 4 edits in trunk/Source/WebCore
Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '-webkit-justify-self' and '-webkit-perspective' CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139104
Patch by Sam Weinig <sam@webkit.org> on 2014-11-29
Reviewed by Anders Carlsson.
- css/CSSPropertyNames.in:
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderFunctions::applyValueWebkitLocale):
(WebCore::StyleBuilderFunctions::applyValueWebkitWritingMode):
(WebCore::StyleBuilderFunctions::applyValueWebkitTextOrientation):
(WebCore::StyleBuilderFunctions::applyValueWebkitJustifySelf):
(WebCore::StyleBuilderFunctions::applyValueWebkitPerspective):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 4:06 PM Changeset in webkit [176583] by
-
- 19 edits in trunk/Source/JavaScriptCore
PropertyTable keys should be AtomicStringImpl.
<https://webkit.org/b/139096>
Reviewed by Sam Weinig.
Since PropertyTable keys are really always Identifiers, switch the key
type from StringImpl* to AtomicStringImpl*.
We have code in the GetByVal opcode implementations that assumes things
about this, so this change adds confidence to those algorithms.
- bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):
- bytecode/ComplexGetStatus.h:
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/GetByIdStatus.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):
- bytecode/PutByIdStatus.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGDesiredIdentifiers.cpp:
(JSC::DFG::DesiredIdentifiers::addLazily):
(JSC::DFG::DesiredIdentifiers::at):
- dfg/DFGDesiredIdentifiers.h:
(JSC::DFG::DesiredIdentifiers::operator[]):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
- runtime/Identifier.h:
(JSC::Identifier::impl):
- runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::mayInterceptStoreTo):
- runtime/IntendedStructureChain.h:
- runtime/PropertyMapHashTable.h:
- runtime/Structure.cpp:
(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::getConcurrently):
(JSC::Structure::add):
(JSC::Structure::remove):
- runtime/Structure.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
- runtime/StructureInlines.h:
(JSC::Structure::getConcurrently):
- runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::Hash::hash):
- 3:40 PM Changeset in webkit [176582] by
-
- 5 edits in trunk/Source/WebKit/win
Switch over to using WebVisitedLinkStore on Windows
https://bugs.webkit.org/show_bug.cgi?id=139103
Reviewed by Antti Koivisto.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks):
- WebHistory.cpp:
(WebHistory::setOptionalSharedHistory):
(WebHistory::removeAllItems):
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
(WebHistory::removeItemForURLString):
(WebHistory::addVisitedLinksToVisitedLinkStore):
(WebHistory::addVisitedLinksToPageGroup): Deleted.
- WebHistory.h:
- WebView.cpp:
(WebView::initWithFrame):
- 2:52 PM Changeset in webkit [176581] by
-
- 2 edits in trunk/Source/WebKit/win
Another build fix.
- WebHistory.cpp:
(WebHistory::addVisitedLinksToVisitedLinkStore):
- 2:48 PM Changeset in webkit [176580] by
-
- 2 edits in trunk/Source/WebKit/win
Another build fix.
- WebHistory.cpp:
(WebHistory::addVisitedLinksToVisitedLinkStore):
(WebHistory::removeAllVisitedLinks): Deleted.
(WebHistory::setHistoryItemLimit): Deleted.
- 2:43 PM Changeset in webkit [176579] by
-
- 2 edits in trunk/Source/WebKit/win
Try to fix build.
- WebHistory.h:
- 2:23 PM Changeset in webkit [176578] by
-
- 6 edits in trunk/Source/WebKit/win
Stub out more of WebVisitedLinkStore on Windows
https://bugs.webkit.org/show_bug.cgi?id=139098
Reviewed by Sam Weinig.
- WebCoreSupport/WebVisitedLinkStore.cpp:
(WebVisitedLinkStore::WebVisitedLinkStore):
Initialize m_visitedLinksPopulated to false.
(WebVisitedLinkStore::setShouldTrackVisitedLinks):
Update s_shouldTrackVisitedLinks and remove all visited links if needed.
(WebVisitedLinkStore::removeAllVisitedLinks):
Remove all hashes from our shared link store.
(WebVisitedLinkStore::addVisitedLink):
Compute the visited link hash and add it to the store.
(WebVisitedLinkStore::isLinkVisited):
Populate visited links and then look up the hash in our hash map.
(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Call out to the history delegate or populate visited links from shared history.
(WebVisitedLinkStore::addVisitedLinkHash):
Add the hash if we're tracking hashes.
(WebVisitedLinkStore::removeVisitedLinkHashes):
Clear the map.
- WebCoreSupport/WebVisitedLinkStore.h:
Add members.
- WebHistory.cpp:
(WebHistory::addVisitedLinksToVisitedLinkStore):
New function that adds visited links from the history to a given store.
- WebHistory.h:
Add new member.
- WebView.cpp:
(WebView::addVisitedLinks):
Add links to the visited link store as well.
- 2:17 PM Changeset in webkit [176577] by
-
- 3 edits in trunk/Source/WebCore
Add an EmptyVisitedLinkStore implementation
https://bugs.webkit.org/show_bug.cgi?id=139102
Reviewed by Sam Weinig.
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
- loader/EmptyClients.h:
- 2:11 PM Changeset in webkit [176576] by
-
- 6 edits in trunk/Source/WebKit/mac
Populate visited links
https://bugs.webkit.org/show_bug.cgi?id=139101
Reviewed by Sam Weinig.
- History/WebHistory.mm:
(-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
Helper function that adds all visited link to the given store.
(-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
Call the private method.
- History/WebHistoryInternal.h:
- WebCoreSupport/WebVisitedLinkStore.h:
Add new members.
- WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::addVisitedLink):
Get the characters from the URL string and hash them, then call addVisitedLinkHash.
(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Implement this. First try the delegate, then try the shared history.
(WebVisitedLinkStore::addVisitedLinkHash):
Factor code that adds the link to the hash table into a separate function.
- WebView/WebView.mm:
(-[WebView addVisitedLinks:]):
Add the visited links to the store.
- 1:49 PM Changeset in webkit [176575] by
-
- 4 edits in trunk/Source/WebKit/mac
More work on the legacy WebKit visited link store
https://bugs.webkit.org/show_bug.cgi?id=139100
Reviewed by Sam Weinig.
- History/WebHistory.mm:
(+[WebHistory setOptionalSharedHistory:]):
Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.
- WebCoreSupport/WebVisitedLinkStore.h:
- WebCoreSupport/WebVisitedLinkStore.mm:
(visitedLinkStores):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
Keep track of live visited link stores.
(WebVisitedLinkStore::setShouldTrackVisitedLinks):
Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.
(WebVisitedLinkStore::removeAllVisitedLinks):
Iterate over all live link stores and remove their links.
(WebVisitedLinkStore::isLinkVisited):
Populate visited links and check if our hash table contains the link.
(WebVisitedLinkStore::addVisitedLink):
Add the link hash to the table.
(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Add stub.
(WebVisitedLinkStore::removeVisitedLinkHashes):
Clear out the hash table.
- 1:12 PM Changeset in webkit [176574] by
-
- 6 edits2 adds in trunk
Crash when calling WKPageClose on the originated page from within createNewPage callback
https://bugs.webkit.org/show_bug.cgi?id=139099
<rdar://problem/19052564>
Reviewed by Sam Weinig.
Source/WebKit2:
Null check the namespace ID.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):
Tools:
Add a test.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::createNewPage):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
- TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
- 9:47 AM Changeset in webkit [176573] by
-
- 3 edits2 adds in trunk/Source/WebKit
Add a stubbed out WebVisitedLinkStore class on Windows
https://bugs.webkit.org/show_bug.cgi?id=139078
Reviewed by Sam Weinig.
Source/WebKit:
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
Source/WebKit/win:
- WebCoreSupport/WebVisitedLinkStore.cpp: Added.
(WebVisitedLinkStore::shared):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):
- WebCoreSupport/WebVisitedLinkStore.h: Added.
Nov 28, 2014:
- 11:11 PM Changeset in webkit [176572] by
-
- 7 edits in trunk/Source/JavaScriptCore
Use std::unique_ptr<>|make_unique<> in ftl, bytecode of JSC
https://bugs.webkit.org/show_bug.cgi?id=139063
Reviewed by Andreas Kling.
Clean up OwnPtr and PassOwnPtr in JSC.
- bytecode/StructureStubClearingWatchpoint.cpp:
(JSC::StructureStubClearingWatchpoint::push):
- bytecode/StructureStubClearingWatchpoint.h:
(JSC::StructureStubClearingWatchpoint::StructureStubClearingWatchpoint):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLJITFinalizer.h:
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- parser/SourceProviderCacheItem.h:
- 10:20 PM Changeset in webkit [176571] by
-
- 4 edits in trunk/Source/WebCore
Move the '-webkit-initial-letter', '-webkit-line-box-contain' and '-webkit-text-stroke-width' CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139053
Patch by Sam Weinig <sam@webkit.org> on 2014-11-28
Reviewed by Andreas Kling.
- css/CSSPropertyNames.in:
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertInitialLetter):
(WebCore::StyleBuilderConverter::convertTextStrokeWidth):
(WebCore::StyleBuilderConverter::convertLineBoxContain):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 2:10 PM Changeset in webkit [176570] by
-
- 2 edits in trunk/Source/WebKit2
Stale userData is handed to WKView _actionMenuItemsForHitTestResult under prepareForMenu
https://bugs.webkit.org/show_bug.cgi?id=139069
<rdar://problem/19075587>
Reviewed by Sam Weinig.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController wkView:willHandleMouseDown:]):
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController _clearActionMenuState]):
Previously, _userData was not being cleared in didCloseMenu, so a subsequent
action menu invocation would end up sending stale userData to _actionMenuItemsForHitTestResult.
Additionally, factor all of the cleanup code out into _clearActionMenuState,
and call it from both wkView:willHandleMouseDown: and didCloseMenu:withEvent:.
- 2:09 PM Changeset in webkit [176569] by
-
- 2 edits in trunk/Source/WebKit2
DataDetectors PageOverlay callbacks are never called
https://bugs.webkit.org/show_bug.cgi?id=139067
<rdar://problem/19086676>
Reviewed by Anders Carlsson.
- Shared/mac/ActionMenuHitTestResult.mm:
(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
Encode/decode the PageOverlay ID.
- 10:39 AM Changeset in webkit [176568] by
-
- 6 edits in trunk/Source/WebKit2
Allow clients of the WKRenderLayerRef C SPI to connect layer trees across frame boundaries
https://bugs.webkit.org/show_bug.cgi?id=139021
Reviewed by Dan Bernstein.
Add WKRenderLayerGetFrameContentsLayer which returns a WKRenderLayerRef for
the content document of a RenderWidget, if its has one (e.g. frames, iframes
and <object> with document contents).
- Shared/API/c/WKRenderLayer.cpp:
(WKRenderLayerGetFrameContentsLayer):
- Shared/API/c/WKRenderLayer.h:
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebRenderLayer.cpp:
(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):
- Shared/WebRenderLayer.h:
(WebKit::WebRenderLayer::frameContentsLayer):
- 9:05 AM Changeset in webkit [176567] by
-
- 2 edits3 adds in trunk/Tools
Unreviewed, rolling out r176564.
https://bugs.webkit.org/show_bug.cgi?id=139093
massive failures on release test bot (Requested by philn on
#webkit).
Reverted changeset:
"[GStreamer] Bump internal jhbuild versions to 1.4.4"
https://bugs.webkit.org/show_bug.cgi?id=138866
http://trac.webkit.org/changeset/176564
- 8:39 AM Changeset in webkit [176566] by
-
- 4 edits in trunk/Tools
[GTK] Use GMainLoopSource in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=138831
Reviewed by Sergio Villar Senin.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::waitToDumpWatchdogTimerCallback): Deleted.
- WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::notifyDone):
(WTR::TestController::platformRunUntil):
(WTR::cancelTimeout): Deleted.
- 7:27 AM Changeset in webkit [176565] by
-
- 2 edits in trunk
[CMake] Build failure against GStreamer git master
https://bugs.webkit.org/show_bug.cgi?id=138872
Reviewed by Csaba Osztrogon.
- Source/cmake/FindGStreamer.cmake: Simplified the
FIND_GSTREAMER_COMPONENT macro. Trust pkg-config for include
headers lookup, there's no need to do this manually. Also
explicitely check the version specified in GStreamer_FIND_VERSION.
- 6:42 AM Changeset in webkit [176564] by
-
- 2 edits3 deletes in trunk/Tools
[GStreamer] Bump internal jhbuild versions to 1.4.4
https://bugs.webkit.org/show_bug.cgi?id=138866
Reviewed by Carlos Garcia Campos.
- gtk/jhbuild.modules:
- gtk/patches/gst-events-arent-gstobjects.patch: Removed.
- gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
- gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
- 6:29 AM Changeset in webkit [176563] by
-
- 14 edits2 deletes in trunk/Tools
[GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
https://bugs.webkit.org/show_bug.cgi?id=138834
Reviewed by Sergio Villar Senin.
It makes everyting simpler and the tests run faster too, since we
don't need to spawn the private bus and wait until the DBus name
is registered. The web extension registers a new JavaSCript class
with a status method to run the tests, similar to the DBus
method. In the UI process side, tests use webkit_web_view_run_java_script()
instead of sending a DBus message.
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
(WebKitDOMNodeFilterTest::create):
(WebKitDOMNodeFilterTest::testTreeWalker):
(WebKitDOMNodeFilterTest::testNodeIterator):
(WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
(WebKitDOMNodeFilterTest::runTest): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
(WebKitDOMNodeTest::create):
(WebKitDOMNodeTest::testHierarchyNavigation):
(WebKitDOMNodeTest::testInsertion):
(WebKitDOMNodeTest::testTagNames):
(WebKitDOMNodeTest::webPageFromArgs): Deleted.
(WebKitDOMNodeTest::runTest): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
(WebKitDOMXPathNSResolverTest::create):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
(WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
(WebKitDOMXPathNSResolverTest::runTest): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
(WebKitFrameTest::create):
(WebKitFrameTest::testMainFrame):
(WebKitFrameTest::testURI):
(WebKitFrameTest::testJavaScriptContext):
(WebKitFrameTest::webPageFromArgs): Deleted.
(WebKitFrameTest::runTest): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
(testWebKitDOMNodeHierarchyNavigation):
(testWebKitDOMNodeInsertion):
(testWebKitDOMNodeTagNames):
(beforeAll):
(afterAll):
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
(runTest):
(beforeAll):
(afterAll):
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
(testWebKitDOMXPathNSResolverNative):
(testWebKitDOMXPathNSResolverCustom):
(beforeAll):
(afterAll):
(runTest): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
(webkitFrameTestRun):
(beforeAll):
(afterAll):
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
(testsMap):
(WebProcessTest::add):
(WebProcessTest::create):
(runTest):
(windowObjectClearedCallback):
(webkit_web_extension_initialize):
(methodCallCallback): Deleted.
(webkit_web_extension_initialize_with_user_data): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
- TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
- TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
(WebViewTest::runWebProcessTest):
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
- 5:41 AM Changeset in webkit [176562] by
-
- 2 edits1 add in trunk/Tools
[EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=139086
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- efl/patches/libseccomp-pick-up-CC.patch: Added.
- 3:05 AM Changeset in webkit [176561] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] HTTP source element lacks SCHEDULING query support
https://bugs.webkit.org/show_bug.cgi?id=139064
Reviewed by Carlos Garcia Campos.
No new tests, covered by http/tests/media/hls.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcQueryWithParent): Make the element handle SCHEDULING
queries with the BANDWIDTH_LIMITED flag. This helps uridecodebin
to configure itself for adaptive streaming playback scenarios.
- 1:50 AM Changeset in webkit [176560] by
-
- 2 edits in trunk/Tools
[EFL] Add warning if CMake version is too old for building with ninja.
https://bugs.webkit.org/show_bug.cgi?id=139055
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2014-11-28
Reviewed by Gyuyoung Kim.
CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
that version in their repositories.
- efl/install-dependencies:
- 1:10 AM Changeset in webkit [176559] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] SecComp buildfix after r176452
https://bugs.webkit.org/show_bug.cgi?id=139081
Reviewed by Antti Koivisto.
- Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBroker::runLoop):
- 1:09 AM Changeset in webkit [176558] by
-
- 3 edits in trunk/Source/WebKit2
Fix -Wc++11-narrowing error in SeccompFilters.cpp
https://bugs.webkit.org/show_bug.cgi?id=139079
Reviewed by Carlos Garcia Campos.
- Shared/linux/SeccompFilters/SeccompFilters.cpp:
(WebKit::SeccompFilters::addRule):
- Shared/linux/SeccompFilters/SeccompFilters.h:
- 1:04 AM Changeset in webkit [176557] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] SecComp buildfix after r168605 and r168999
https://bugs.webkit.org/show_bug.cgi?id=139080
Reviewed by Carlos Garcia Campos.
- Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):
- 1:00 AM Changeset in webkit [176556] by
-
- 5 edits2 adds in trunk
[ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
https://bugs.webkit.org/show_bug.cgi?id=139044
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-11-28
Reviewed by Chris Fleizach.
ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
The proposed solution will enable the use of this method for the object table.
Existing test shows the result.
Tools:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::columnHeaders):
LayoutTests:
- accessibility/table-column-headers-with-captions.html: Updated for ATK platform.
- platform/efl/accessibility/table-column-headers-with-captions-expected.txt: Added.
- platform/gtk/TestExpectations: Updated for GTK.
- platform/gtk/accessibility/table-column-headers-with-captions-expected.txt: Added.
Nov 27, 2014:
- 11:04 PM Changeset in webkit [176555] by
-
- 10 edits1 delete in trunk
[EFL] Remove E_Dbus dependency
https://bugs.webkit.org/show_bug.cgi?id=136355
Reviewed by Gyuyoung Kim.
.:
- Source/cmake/FindE_DBus.cmake: Removed.
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
E_Dbus is the simple wrapper of Dbus but it has not been maintained since EFL 1.8.
Instead, EFL introduced Eldbus, which is almost similar with E_Dbus but provides more dbus like interface.
This patch replaces E_Dbus implementation to Eldbus.
- PlatformEfl.cmake:
- platform/efl/BatteryProviderEfl.cpp:
(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl):
(WebCore::BatteryProviderEfl::stopUpdating):
(WebCore::batteryProperties):
(WebCore::batteryPropertiesChanged):
(WebCore::BatteryProviderEfl::deviceTypeCallback):
(WebCore::BatteryProviderEfl::enumerateDevices):
(WebCore::BatteryProviderEfl::startUpdating):
(WebCore::BatteryProviderEfl::setBatteryStatus):
(WebCore::BatteryProviderEfl::timerFired): Deleted.
(WebCore::BatteryProviderEfl::getBatteryStatus): Deleted.
(WebCore::BatteryProviderEfl::setBatteryClient): Deleted.
- platform/efl/BatteryProviderEfl.h:
(WebCore::BatteryProviderEfl::connection):
(WebCore::BatteryProviderEfl::setSignalHandler):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl): Deleted.
Source/WebKit2:
- UIProcess/API/efl/ewk_main.cpp: Added init/shutdown for eldbus.
(WebKit::EwkMain::initialize):
(WebKit::EwkMain::finalize):
(WebKit::EwkMain::shutdownInitializedEFLModules):
Tools:
- MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
- 5:40 PM Changeset in webkit [176554] by
-
- 2 edits in trunk/Source/WebCore
CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
https://bugs.webkit.org/show_bug.cgi?id=139057
Reviewed by Anders Carlsson.
No test, don't know how to repro.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.
- 4:51 PM Changeset in webkit [176553] by
-
- 11 edits in trunk/Source/JavaScriptCore
Use std::unique_ptr instead of OwnPtr in JSC classes
https://bugs.webkit.org/show_bug.cgi?id=139009
Reviewed by Filip Pizlo.
As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.
- bytecode/DFGExitProfile.cpp:
(JSC::DFG::ExitProfile::add):
- bytecode/DFGExitProfile.h:
- bytecode/LazyOperandValueProfile.cpp:
(JSC::CompressedLazyOperandValueProfileHolder::add):
- bytecode/LazyOperandValueProfile.h:
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::stopAllocating):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::clearNewlyAllocated):
- inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::findMagicComment):
- runtime/RegExp.cpp:
(JSC::RegExp::invalidateCode):
- runtime/RegExp.h:
- yarr/RegularExpression.cpp:
(JSC::Yarr::RegularExpression::Private::compile):
(JSC::Yarr::RegularExpression::isValid):
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::byteCompile):
- yarr/YarrInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):
- 4:24 PM Changeset in webkit [176552] by
-
- 9 edits in trunk
AX: [ATK] Meter and Option elements do not expose their id attribute
https://bugs.webkit.org/show_bug.cgi?id=139017
Reviewed by Mario Sanchez Prada.
Source/WebCore:
The options in a collapsed select element lack a node, so get the id
attribute from the associated action element. In the case of a meter,
the meter element itself is not exposed; its RenderMeter is instead.
So associate the meter element's id with the exposed RenderMeter.
No new tests. Instead, updated existing expectations to reflect the fix.
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::element):
- accessibility/AccessibilityProgressIndicator.h:
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
LayoutTests:
- accessibility/roles-exposed.html: Unskipped the meter element test.
- platform/efl/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.
- platform/gtk/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.
- 10:00 AM Changeset in webkit [176551] by
-
- 5 edits2 copies in trunk/Source/WebKit
Add a stubbed out WebVisitedLinkStore to WebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=139066
Reviewed by Antti Koivisto.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- WebCoreSupport/WebViewGroup.h:
(WebViewGroup::visitedLinkStore):
- WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::WebViewGroup):
- WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
- WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
(WebVisitedLinkStore::create):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):
- 9:58 AM Changeset in webkit [176550] by
-
- 4 edits in trunk/Source/WebCore
Add a Page::setVisitedLinkStore member function
https://bugs.webkit.org/show_bug.cgi?id=139065
Reviewed by Antti Koivisto.
This will be used in a subsequent commit.
- WebCore.exp.in:
- page/Page.cpp:
(WebCore::Page::setVisitedLinkStore):
- page/Page.h:
- 4:47 AM WebKitGTK/2.4.x edited by
- (diff)
- 4:04 AM Changeset in webkit [176549] by
-
- 1 edit6 adds in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
https://bugs.webkit.org/show_bug.cgi?id=139061
rebaseline after r176354.
Patch by Hunseop Jeong <Hunseop Jeong> on 2014-11-27
- platform/gtk/fast/multicol/tall-image-behavior-expected.png: Added.
- platform/gtk/fast/multicol/tall-image-behavior-expected.txt: Added.
- platform/gtk/fast/multicol/tall-image-behavior-lr-expected.png: Added.
- platform/gtk/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
- platform/gtk/fast/multicol/tall-image-behavior-rl-expected.png: Added.
- platform/gtk/fast/multicol/tall-image-behavior-rl-expected.txt: Added.
- 3:39 AM Changeset in webkit [176548] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Update NavigationItemProbes icon for the GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=139074
Reviewed by Carlos Garcia Campos.
NavigationItemProbes was updated for the Mac port and we are now
having a similar ideogram in GTK+.
- UserInterface/Images/gtk/NavigationItemProbes.svg: Updated.
Nov 26, 2014:
- 5:39 AM Changeset in webkit [176547] by
-
- 1 edit6 adds in trunk/LayoutTests
[EFL] Unreviewed EFL gardening after r176354.
https://bugs.webkit.org/show_bug.cgi?id=139060
rebaseline after r176354.
Patch by Hunseop Jeong <Hunseop Jeong> on 2014-11-26
- platform/efl/fast/multicol/tall-image-behavior-expected.png: Added.
- platform/efl/fast/multicol/tall-image-behavior-expected.txt: Added.
- platform/efl/fast/multicol/tall-image-behavior-lr-expected.png: Added.
- platform/efl/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
- platform/efl/fast/multicol/tall-image-behavior-rl-expected.png: Added.
- platform/efl/fast/multicol/tall-image-behavior-rl-expected.txt: Added.
- 12:08 AM Changeset in webkit [176546] by
-
- 3 edits2 adds2 deletes in trunk/Tools
[EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
https://bugs.webkit.org/show_bug.cgi?id=139047
Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-11-26
Reviewed by Carlos Garcia Campos.
- efl/jhbuild.modules:
- efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
- efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
- gtk/jhbuild-optional.modules:
- gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
- gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
Nov 25, 2014:
- 4:27 PM Changeset in webkit [176545] by
-
- 15 edits in trunk
Add parsing for :dir()
https://bugs.webkit.org/show_bug.cgi?id=138932
Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2014-11-25
Reviewed by Benjamin Poulain.
Source/WebCore:
Add support for parsing :dir() pseudo class. The implementation of selector
matching will be in a follow-up patch.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::detectFunctionTypeToken):
- css/CSSSelector.cpp:
(WebCore::appendPseudoClassFunctionTail):
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/SelectorPseudoClassAndCompatibilityElementMap.in:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
LayoutTests:
- fast/css/css-selector-text-expected.txt:
- fast/css/css-selector-text.html:
- fast/css/css-set-selector-text-expected.txt:
- fast/css/css-set-selector-text.html:
- fast/selectors/invalid-functional-pseudo-class-expected.txt:
- fast/selectors/invalid-functional-pseudo-class.html:
- 11:50 AM Changeset in webkit [176544] by
-
- 11 edits in trunk/Source
Remove user content handling from PageGroup
https://bugs.webkit.org/show_bug.cgi?id=139051
Reviewed by Antti Koivisto.
Source/WebCore:
Remove m_userContentController from PageGroup and the related functions and symbol exports.
- WebCore.exp.in:
- page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
(WebCore::PageGroup::~PageGroup):
(WebCore::PageGroup::addPage):
(WebCore::PageGroup::removePage):
(WebCore::PageGroup::addUserScriptToWorld): Deleted.
(WebCore::PageGroup::addUserStyleSheetToWorld): Deleted.
(WebCore::PageGroup::removeUserScriptFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetFromWorld): Deleted.
(WebCore::PageGroup::removeUserScriptsFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetsFromWorld): Deleted.
(WebCore::PageGroup::removeAllUserContent): Deleted.
- page/PageGroup.h:
Source/WebKit/mac:
Use the user content controller in the web view group.
- WebView/WebView.mm:
(-[WebView _injectOutlookQuirksScript]):
Source/WebKit2:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
Talk to the user content controller from the passed in WebPageGroupProxy.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Create the WebPageGroupProxy before creating the page so we can get its user content controller and
pass it to the page configuration if necessary.
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::userContentController):
New function that lazily creates a user content controller. We don't want to create this eagerly since
it's not used with the modern API.
(WebKit::WebPageGroupProxy::addUserStyleSheet):
(WebKit::WebPageGroupProxy::addUserScript):
(WebKit::WebPageGroupProxy::removeAllUserStyleSheets):
(WebKit::WebPageGroupProxy::removeAllUserScripts):
(WebKit::WebPageGroupProxy::removeAllUserContent):
Call through to the user content controller.
- WebProcess/WebPage/WebPageGroupProxy.h:
Add an m_userContentController member.
- 10:05 AM Changeset in webkit [176543] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed, upload two missing test files in the commit r174677.
- mathml/presentation/mo-stretch-update-expected.html: Added.
- mathml/presentation/mo-stretch-update.html: Added.
- 8:16 AM Changeset in webkit [176542] by
-
- 7 edits in trunk/Source
Add a user content controller to WebViewGroup and use it for user content
https://bugs.webkit.org/show_bug.cgi?id=139043
Reviewed by Antti Koivisto.
Source/WebCore:
- WebCore.exp.in:
Export symbols.
- page/Page.cpp:
(WebCore::Page::setUserContentController):
Invalidate the injected style cache when setting a new user content controller.
Source/WebKit/mac:
This is another tiny step towards getting rid of user content handling inside PageGroup.
- WebCoreSupport/WebViewGroup.h:
(WebViewGroup::userContentController):
Add a UserContentController member and getter.
- WebCoreSupport/WebViewGroup.mm:
(WebViewGroup::get):
Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).
(WebViewGroup::WebViewGroup):
Create a user content controller.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
set its user content controller in the PageConfiguration.
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Ditto.
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
(+[WebView _removeAllUserContentFromGroup:]):
Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.
(-[WebView setGroupName:]):
Set the user content controller to the new WebViewGroup's user content controller.
- 6:49 AM Changeset in webkit [176541] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] gstmpegts is not initialized
https://bugs.webkit.org/show_bug.cgi?id=139039
Reviewed by Carlos Garcia Campos.
- platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::initializeGStreamer): Initialize the gstmpegts library.
- 6:29 AM Changeset in webkit [176540] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Use LD_LIBRARY_PATH to make g-ir-scanner use the newly-built
version of libraries when running the temporary executable
https://bugs.webkit.org/show_bug.cgi?id=138833
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-11-25
Reviewed by Carlos Garcia Campos.
This patch modifies LD_LIBRARY_PATH to make sure the dynamic linker
find the correct version of libraries when running the temporary
executable to generate the .gir file.
- PlatformGTK.cmake:
- 5:48 AM Changeset in webkit [176539] by
-
- 2 edits in trunk/Tools
[GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
https://bugs.webkit.org/show_bug.cgi?id=138090
Patch by Tanay C <tanay.c@samsung.com> on 2014-11-25
Reviewed by Carlos Garcia Campos.
- MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
(browserWindowZoomIn): Added.
(browserWindowZoomOut): Added.
(scrollEventCallback): Added.
(zoomInCallback): Modified.
(zoomOutCallback): Modified.
(browserWindowConstructed): Modified.
- 1:59 AM Changeset in webkit [176538] by
-
- 5 edits in trunk
[EFL] REGRESSION(r176514): It made performance tests fail
https://bugs.webkit.org/show_bug.cgi?id=139037
Reviewed by Gyuyoung Kim.
Source/WebKit2:
- WebProcess/efl/WebProcessMainEfl.cpp: Don't try to load/shutdown eail if eailLibraryPath() is empty.
Tools:
- Scripts/webkitpy/port/efl.py:
(EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
- efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
Nov 24, 2014:
- 11:41 PM Changeset in webkit [176537] by
-
- 2 edits in trunk/Source/WebCore
Fix unused variable warning in Biquad.cpp
https://bugs.webkit.org/show_bug.cgi?id=139031
Reviewed by Andreas Kling.
No new tests needed.
- platform/audio/Biquad.cpp:
- 11:39 PM Changeset in webkit [176536] by
-
- 4 edits4 deletes in trunk/Source
Remove Qt cruft related to tap higlighting
https://bugs.webkit.org/show_bug.cgi?id=139030
Reviewed by Andreas Kling.
Source/WebCore:
No new tests needed.
- CMakeLists.txt:
- page/GestureTapHighlighter.cpp: Removed.
- page/GestureTapHighlighter.h: Removed.
Source/WebKit2:
- CMakeLists.txt:
- WebProcess/WebPage/TapHighlightController.cpp: Removed.
- WebProcess/WebPage/TapHighlightController.h: Removed.
- 9:26 PM Changeset in webkit [176535] by
-
- 5 edits in trunk
Fix the parsing and re-serialization of :lang pseudo class selector when it has multiple arguments with same value
https://bugs.webkit.org/show_bug.cgi?id=139013
Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-11-24
Reviewed by Benjamin Poulain.
Source/WebCore:
Fix the parsing and re-serialization of :lang pseudo class selector when
it has multiple arguments with same value e.g. :lang(en, en, en). Previously,
given :lang(en, en, en) selector, it was parsed and reserialized
as :lang(enenen) instead of :lang(en, en, en)
Related test on parsing and re-serialization of css selectors is updated.
- css/CSSSelector.cpp:
(WebCore::appendArgumentList):
LayoutTests:
Updated tests to verify the parsing and serialization of :lang pseudo class
selector when it has multiple arguments with same value.
- fast/css/css-selector-text-expected.txt: Updated to cover fix.
- fast/css/css-selector-text.html: Updated to cover fix.
- 7:47 PM Changeset in webkit [176534] by
-
- 2 edits in trunk/Source/WebCore
Fix r176527. Iterate through the text renderers.
https://bugs.webkit.org/show_bug.cgi?id=139007
Reviewed by Antti Koivisto.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- 6:40 PM Changeset in webkit [176533] by
-
- 14 edits in trunk/Source/JavaScriptCore
Clean up OwnPtr and PassOwnPtr in JSC - bytecode, jit, inspector, and interpreter
https://bugs.webkit.org/show_bug.cgi?id=139022
Reviewed by Filip Pizlo.
As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.
- bytecode/DFGExitProfile.cpp:
(JSC::DFG::ExitProfile::add):
- bytecode/DFGExitProfile.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):
- dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::JITFinalizer):
- dfg/DFGJITFinalizer.h:
- heap/IncrementalSweeper.h:
- inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::findMagicComment):
- inspector/agents/InspectorDebuggerAgent.h:
- inspector/agents/JSGlobalObjectRuntimeAgent.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::enableSampler):
- interpreter/Interpreter.h:
- jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::ExecutableAllocator):
- jit/ExecutableAllocator.h:
- 5:37 PM Changeset in webkit [176532] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, EFL build fix since r176530.
- UIProcess/CoordinatedGraphics/WebView.cpp: Replace pointer with reference.
(WebKit::WebView::processDidExit):
- 5:00 PM Changeset in webkit [176531] by
-
- 3 edits in trunk/Source/WebCore
Simple line layout: Rename TextFragment::mustBreak to TextFragment::isLineBreak
https://bugs.webkit.org/show_bug.cgi?id=139035
Reviewed by Antti Koivisto.
Move new line logic to FlowContents class.
This is in preparation to support <br>.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::nextFragment):
(WebCore::SimpleLineLayout::createLineRuns):
- rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::isNewline):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter): Deleted.
- 4:26 PM Changeset in webkit [176530] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Remove some bad stuff from WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=138896
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-24
Reviewed by Sam Weinig.
The state loadStateAtProcessExit does not seem to be used anywhere.
The state urlAtProcessExit only exists to forward the url from
WebPageProxy::resetStateAfterProcessExited() to the coordinated graphics code
WebView::processDidExit().
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::processDidExit):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::urlAtProcessExit): Deleted.
(WebKit::WebPageProxy::loadStateAtProcessExit): Deleted.
- 4:20 PM Changeset in webkit [176529] by
-
- 6 edits in trunk/Source/WebCore
Move :placeholder-shown out of experimental
https://bugs.webkit.org/show_bug.cgi?id=138998
Reviewed by Andreas Kling.
The pseudo class :placeholder-shown is used by the inspector, disabling it breaks
the sidebar.
The implementation has been stable for a while, we can move it to stable.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/SelectorPseudoClassAndCompatibilityElementMap.in:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPlaceholderShown):
- 4:15 PM Changeset in webkit [176528] by
-
- 4 edits2 adds in trunk
Avoid String concatenation with line break iterator
https://bugs.webkit.org/show_bug.cgi?id=139034
Reviewed by Zalan Bujtas.
Source/WebCore:
Test: fast/text/simple-lines-multiple-renderers-break.html
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::initializeSegments):
Include String too so it doesn't need to be fetched from the renderer.
(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):
Make this iterative instead of recursive.
Uset setPriorContext to provide previous characters instead of concatenating
the string from all the previous segments.
(WebCore::SimpleLineLayout::findNextNonWhitespace):
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):
Search using segments instead of the concatenated string.
(WebCore::SimpleLineLayout::FlowContents::textWidth):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPositionSlow):
(WebCore::SimpleLineLayout::FlowContents::runWidth):
(WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow): Deleted.
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded): Deleted.
(WebCore::SimpleLineLayout::FlowContents::nextNonWhitespacePosition): Deleted.
- rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::characterAt):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPosition):
(WebCore::SimpleLineLayout::FlowContents::segmentForPosition):
LayoutTests:
Test that there is no implicit break point between Text nodes.
- fast/text/simple-lines-multiple-renderers-break-expected.html: Added.
- fast/text/simple-lines-multiple-renderers-break.html: Added.
- 4:10 PM Changeset in webkit [176527] by
-
- 3 edits4 adds in trunk
SimpleLineLayout::canUseFor() should iterate through RenderTexts to check if their content is eligible for simple line layout.
https://bugs.webkit.org/show_bug.cgi?id=139007
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html
fast/text/simple-line-layout-multiple-renderers-with-float.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
LayoutTests:
- fast/text/simple-line-layout-multiple-renderers-non-breaking-space-expected.html: Added.
- fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html: Added.
- fast/text/simple-line-layout-multiple-renderers-with-float-expected.html: Added.
- fast/text/simple-line-layout-multiple-renderers-with-float.html: Added.
- 4:05 PM Changeset in webkit [176526] by
-
- 2 edits in trunk/Tools
[GTK] update-webkitgtk-libs fails to build fontconfig
https://bugs.webkit.org/show_bug.cgi?id=139032
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-11-24
Reviewed by Martin Robinson.
On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
fontconfig will try to generate documentation and fail.
- gtk/install-dependencies:
- 3:56 PM Changeset in webkit [176525] by
-
- 3 edits in trunk/LayoutTests
Simple line layout: fast/text/simple-lines-multiple-renderers test has the wrong content.
https://bugs.webkit.org/show_bug.cgi?id=139036
Swap simple-lines-multiple-renderers.html and simple-lines-multiple-renderers-expected.html
- fast/text/simple-lines-multiple-renderers-expected.html:
- fast/text/simple-lines-multiple-renderers.html:
- 2:12 PM Changeset in webkit [176524] by
-
- 4 edits in trunk/Source/WebCore
Move the '-webkit-box-reflext' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139008
Reviewed by Anders Carlsson.
- css/CSSPropertyNames.in:
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertReflection):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 2:09 PM Changeset in webkit [176523] by
-
- 2 edits in trunk/Source/WebKit/win
Stub out user content WebView member functions on Windows
https://bugs.webkit.org/show_bug.cgi?id=139033
Reviewed by Sam Weinig.
These functions aren't used by any clients and hinder getting rid of PageGroup.
If it turns out they're still needed we can copy the user content controller code from Mac Legacy WebKit.
- WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
(WebView::removeAllUserContentFromGroup):
(toStringVector): Deleted.
- 12:48 PM Changeset in webkit [176522] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] REGRESSION(176066): It made all performance tests fail
https://bugs.webkit.org/show_bug.cgi?id=138865
Reviewed by Csaba Osztrogonác.
Since r176066, there are crash because evas_gl_surface is destroyed with
invalid evas_gl instance after evas_gl is destroyed.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::~EwkView):
- 10:07 AM Changeset in webkit [176521] by
-
- 2 edits in trunk/Source/WebCore
Remove unused Style struct from SimpleLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=139027
Reviewed by Sam Weinig.
It was moved to FlowContents.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::Style::Style): Deleted.
- 9:02 AM Changeset in webkit [176520] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Compile error in ResourceHandleManager.cpp.
https://bugs.webkit.org/show_bug.cgi?id=139026
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-24
Reviewed by Brent Fulgham.
The parameter types of the constructor of the Timer class has changed.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::ResourceHandleManager):
(WebCore::ResourceHandleManager::downloadTimerCallback):
- platform/network/curl/ResourceHandleManager.h:
- 6:49 AM Changeset in webkit [176519] by
-
- 2 edits in trunk/Source/WebKit2
Webkit2 doesnt build on powerpc 32 bits
https://bugs.webkit.org/show_bug.cgi?id=130837
Reviewed by Carlos Garcia Campos.
Check if libatomic is needed in order to use std::atomic, and add
it to the list of WebKit2 libraries.
- PlatformGTK.cmake:
- 6:13 AM WebKitGTK/2.6.x edited by
- (diff)
- 4:50 AM Changeset in webkit [176518] by
-
- 1 copy in releases/WebKitGTK/webkit-2.7.2
WebKitGTK+ 2.7.2
- 4:45 AM Changeset in webkit [176517] by
-
- 4 edits in trunk
.:
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.1 release.
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.2 release.
- gtk/NEWS: Add release notes for 2.7.2.
- 4:12 AM Changeset in webkit [176516] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix GTK+ make distcheck.
- gtk/manifest.txt: Remove deleted files.
- 4:05 AM Changeset in webkit [176515] by
-
- 6 edits in trunk
AX: [ATK] Unskip the skipped ATK tests in roles-exposed.html
https://bugs.webkit.org/show_bug.cgi?id=139016
Reviewed by Chris Fleizach.
Source/WebCore:
There was one test that could not be unskipped without making a change
for that one to pass: mapping DocumentRegionRole to ATK_ROLE_PANEL. The
rest of the "fix" is just unskipping tests for ATK and updating the test
expectations.
No new tests needed.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
LayoutTests:
- accessibility/roles-exposed.html: Unskipped a bunch of tests.
- platform/efl/accessibility/roles-exposed-expected.txt: Updated for unskipped tests.
- platform/gtk/accessibility/roles-exposed-expected.txt: Updated for unskipped tests.
- 3:30 AM Changeset in webkit [176514] by
-
- 4 edits1 add in trunk
[EFL] Utilize Eail library to support accessibility in EFL
https://bugs.webkit.org/show_bug.cgi?id=137742
Reviewed by Gyuyoung Kim.
Source/WebKit2:
Initialize EAIL module so that all the listeners and atk-bridge started properly.
Dynamic loading of EAIL help us to avoid elementary dependencies in WebKit.
- WebProcess/efl/WebProcessMainEfl.cpp:
(eailLibraryPath): reads path provided by ACCESSIBILITY_EAIL_LIBRARY_PATH variable.
(eail):
Tools:
Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
- efl/jhbuild-optional.modules: Added.
- efl/jhbuild.modules:
- 3:18 AM Changeset in webkit [176513] by
-
- 4 edits in trunk
[GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
https://bugs.webkit.org/show_bug.cgi?id=139023
Reviewed by Sergio Villar Senin.
Source/WebKit2:
The WebKitWebContext is a construct only property, so it's always
set to the default value when not provided, during the
construction. When a related-view is used to create a new web view
we should ensure that the same web context is used for the new web
view, instead of the default. We should also ignore any web
context given as construct parameter if a related view is alos provided.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Do not set the context to the default
one when not given during construction.
(webkitWebViewSetProperty): Only use the default web context when
not provided as construct parameter and there isn't a related view.
Tools:
Rename WebKitWebView/default-context as WebKitWebView/web-context
and check we are always using the right context for new web views.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewWebContext):
(beforeAll):
(testWebViewDefaultContext): Deleted.
Nov 23, 2014:
- 11:24 PM Changeset in webkit [176512] by
-
- 5 edits in trunk
[GTK] Add API to override the default local storage directory
https://bugs.webkit.org/show_bug.cgi?id=138828
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
Add WebKitWebContext:local-storage-directory construct-only
property. If not provided the default will be used.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextGetProperty):
(webkitWebContextSetProperty):
(webkitWebContextConstructed):
(webkit_web_context_class_init):
Tools:
Add test to check that the local storage directory is created at
the path given on construction.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
(testWebContextConfiguration):
(beforeAll):
- TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
(Test::Test):
(Test::~Test): Deleted.
- 9:21 PM Changeset in webkit [176511] by
-
- 4 edits in trunk/Source/WebKit2
Page previews should have titles
https://bugs.webkit.org/show_bug.cgi?id=139020
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKViewPrivate.h:
Declare -_titleForPreviewOfURL:.
- UIProcess/API/mac/WKView.mm:
(-[WKView _titleForPreviewOfURL:]):
Stub implementation.
- UIProcess/mac/WKActionMenuController.mm:
(+[WKPagePreviewViewController previewPadding]):
Account for the title height.
(-[WKPagePreviewViewController loadView]):
Set correct autoresize masks on some views; create and configure a title view that is
horizontally and vertically centered.
(-[WKActionMenuController pagePreviewViewController:titleForPreviewOfURL:]):
WKPagePreviewViewControllerDelegate method; wrap -[WKView _titleForPreviewOfURL:].
- 10:46 AM Changeset in webkit [176510] by
-
- 5 edits in trunk/Source/WebCore
Use segment vector for FlowContents
https://bugs.webkit.org/show_bug.cgi?id=139015
Reviewed by Zalan Bujtas.
And FlowContents::Segment struct and use it.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::splitRunsAtRendererBoundary):
Use segments.
If there is only one segment there is nothing to do. Bail out.
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::initializeSegments):
Move initialization to a function so m_segments can be const.
Don't add empty end segment, handle the end case in code.
(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::textWidth):
Simplify and use segments.
(WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow):
Replace hand-rolled binary search with std::lower_bounds.
(WebCore::SimpleLineLayout::FlowContents::segmentForRenderer):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):
(WebCore::SimpleLineLayout::FlowContents::renderer): Deleted.
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions): Deleted.
- rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::hasOneSegment):
(WebCore::SimpleLineLayout::FlowContents::length):
(WebCore::SimpleLineLayout::FlowContents::isEnd):
(WebCore::SimpleLineLayout::FlowContents::isEndOfContent): Deleted.
Renamed.
(WebCore::SimpleLineLayout::FlowContents::segmentForPosition):
Inline the fast path.
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::rangeForRenderer):
- 10:00 AM Changeset in webkit [176509] by
-
- 12 edits in trunk/Source
Extend WKRenderObject and WKRenderLayer with some more useful data
https://bugs.webkit.org/show_bug.cgi?id=139006
Reviewed by Sam Weinig.
Source/WebCore:
Export WebCore::RenderLayerBacking::backingStoreMemoryEstimate() const.
- WebCore.exp.in:
Source/WebKit2:
Implement WKRenderLayerGetBackingStoreMemoryEstimate,
WKRenderObjectCopyTextSnippet and WKRenderObjectGetTextLength for improved
RenderLayer and RenderTree display in clients of the C SPI.
- Shared/API/c/WKRenderLayer.cpp:
(WKRenderLayerGetBackingStoreMemoryEstimate):
- Shared/API/c/WKRenderLayer.h:
- Shared/API/c/WKRenderObject.cpp:
(WKRenderObjectCopyTextSnippet):
(WKRenderObjectGetTextLength):
- Shared/API/c/WKRenderObject.h:
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebRenderLayer.cpp:
(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):
- Shared/WebRenderLayer.h:
(WebKit::WebRenderLayer::backingStoreMemoryEstimate):
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::WebRenderObject):
- Shared/WebRenderObject.h:
(WebKit::WebRenderObject::textSnippet):
(WebKit::WebRenderObject::textLength):
Nov 22, 2014:
- 8:37 PM Changeset in webkit [176508] by
-
- 14 edits in trunk/Source/JavaScriptCore
Clean up OwnPtr and PassOwnPtr in some of JS classes
https://bugs.webkit.org/show_bug.cgi?id=138724
Reviewed by Filip Pizlo.
As a step to use std::unique_ptr<> and std::make_unique<>, this patch replaces
OwnPtr with std::unique_ptr<>. Besides create() factory function is removed as well.
- builtins/BuiltinExecutables.h:
(JSC::BuiltinExecutables::create): Deleted.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::createRareDataIfNecessary):
- bytecode/StructureStubInfo.h:
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::hasRareData):
(JSC::UnlinkedCodeBlock::createRareDataIfNecessary):
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
- runtime/CodeCache.h:
(JSC::CodeCache::create): Deleted.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::clearRareData):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createRareDataIfNeeded):
- runtime/RegExpConstructor.h:
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::createSingleCharacterString):
(JSC::SmallStrings::singleCharacterStringRep):
- runtime/SmallStrings.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 11:37 AM Changeset in webkit [176507] by
-
- 3 edits in trunk/Source/WebCore
Make locale part of the SimpleLineLayout::FlowContent::Style
https://bugs.webkit.org/show_bug.cgi?id=139004
Reviewed by Zalan Bujtas.
That's the only part of style not extracted out of RenderStyle in the constructor.
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::FlowContents::Style::Style):
(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):
- rendering/SimpleLineLayoutFlowContents.h:
Also remove RenderBlockFlow member since it is now unused.
(WebCore::SimpleLineLayout::FlowContents::Style::Style): Deleted.
Move to cpp.
- 11:07 AM Changeset in webkit [176506] by
-
- 2 edits in trunk/Source/JavaScriptCore
r176455: ASSERT(!m_vector.isEmpty()) in IntendedStructureChain.cpp(143)
https://bugs.webkit.org/show_bug.cgi?id=139000
Reviewed by Darin Adler.
Check that the chainCount is non-zero before using a StructureChain.
- bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):
- 10:18 AM Changeset in webkit [176505] by
-
- 12 edits6 adds in trunk
AX: [ATK] Accessible names missing for imagemap images and links
https://bugs.webkit.org/show_bug.cgi?id=127288
Source/WebCore:
Reviewed by Chris Fleizach.
Return the alt text, if present, for the accessible name for image maps
and image map links for ATK. Also expose the accessible element with
ATK_ROLE_IMAGE_MAP instead of ATK_ROLE_IMAGE.
Test: accessibility/image-with-alt-and-map.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isImageMap):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetName):
(atkRole):
LayoutTests:
New and updated tests to reflect the expected role, accessible hierarchy,
and exposure of the alternative text for each platform.
Reviewed by Chris Fleizach.
- accessibility/image-with-alt-and-map.html: Added.
- accessibility/roles-exposed.html: Added some more elements to the test.
- platform/efl/accessibility/image-map1-expected.txt: Added.
- platform/efl/accessibility/image-map2-expected.txt: Updated to reflect fix.
- platform/efl/accessibility/image-with-alt-and-map-expected.txt: Added.
- platform/efl/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/gtk/accessibility/image-map1-expected.txt: Added.
- platform/gtk/accessibility/image-map2-expected.txt: Updated to reflect fix.
- platform/gtk/accessibility/image-with-alt-and-map-expected.txt: Added.
- platform/gtk/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/mac/accessibility/image-with-alt-and-map-expected.txt: Added.
- platform/mac/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Updated for added elements.
- platform/mac-mountainlion/accessibility/roles-exposed-expected.txt: Updated for added elements.
- 2:11 AM Changeset in webkit [176504] by
-
- 4 edits in trunk/Source/WebCore
Remove unused Document::ignoreAutofocus().
<https://webkit.org/b/139002>
Reviewed by Antti Koivisto.
No one ever actually changes this flag, so let's remove it.
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Document::ignoreAutofocus): Deleted.
(WebCore::Document::setIgnoreAutofocus): Deleted.
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
- 1:44 AM Changeset in webkit [176503] by
-
- 3 edits in trunk/Source/WebCore
URTBF after r176459 to fix GTK build.
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::requestAnimationTimerFired):
- platform/ScrollAnimatorNone.h:
- 1:12 AM Changeset in webkit [176502] by
-
- 207 edits in trunk/Source
Convert PassRefPtr return types to RefPtr.
<https://webkit.org/b/138995>
Reviewed by Anders Carlsson.
Convert an assortment of DOM and HTML related functions
to return RefPtr instead of PassRefPtr.
Nov 21, 2014:
- 11:50 PM Changeset in webkit [176501] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed iOS build fix; move new symbols out of Mac-only exports.
- WebCore.exp.in:
- 10:38 PM Changeset in webkit [176500] by
-
- 1 edit1 delete in trunk/Source/WebCore
Remove a file that r176499 presumably did not mean to add.
- WebCore.exp.in.orig: Removed.
- 9:27 PM Changeset in webkit [176499] by
-
- 30 edits2 copies4 adds in trunk/Source
Support multiple signatures of diagnostic logging.
https://bugs.webkit.org/show_bug.cgi?id=138690
Reviewed by Anders Carlsson.
Source/WebCore:
Pull logDiagnosticMessage() out of ChromeClient and make a new client interface,
DiagnosticLoggingClient, which supports multiple kinds of diagnostic logging,
namely: simple logging without a parameter, logging with a success parameter, and
logging with a generic string value parameter.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Use DiagnosticLoggingClient.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.
- loader/SubframeLoader.cpp:
(WebCore::logPluginRequest): Ditto.
- page/ChromeClient.h:
(WebCore::ChromeClient::logDiagnosticMessage): Deleted.
- page/DiagnosticLoggingClient.h:
(WebCore::DiagnosticLoggingClient::logDiagnosticMessage): Added.
(WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithResult): Added.
(WebCore::DiagnosticLoggingClient::logDiagnosticMessageWithValue): Added.
(WebCore::DiagnosticLoggingClient::~DiagnosticLoggingClient): Empty destructor.
Rename Page::PageClient to PageConfiguration, and pass that configuration from
Page into MainFrame upon construction.
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::overlayPage): Use PageConfiguration instead of PageClients.
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients): Ditto.
- loader/EmptyClients.h:
- page/MainFrame.cpp:
(WebCore::MainFrame::MainFrame): Pass loaderClientForMainFrame through to the
Frame constructor.
(WebCore::MainFrame::create): Takes a PageConfiguration.
- page/MainFrame.h:
(WebCore::MainFrame::diagnosticLoggingClient): Simple accessor.
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients): Deleted.
(WebCore::Page::PageClients::~PageClients): Deleted.
- page/Page.h:
- page/PageConfiguration.cpp: Added.
(WebCore::PageConfiguration::PageConfiguration): Renamed from PageClients().
(WebCore::PageConfiguration::~PageConfiguration): Renamed from ~PageClients().
- page/PageConfiguration.h: Added.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged): Use PageConfiguration instead of PageClients.
Add new files and symbols to the project.
- CMakeLists.txt:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Page::PageClients has been renamed PageConfiguration.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Source/WebKit/win:
Page::PageClients has been renamed PageConfiguration.
- WebView.cpp:
(WebView::initWithFrame):
Source/WebKit2:
Extend the existing WKBundlePageDiagnosticLoggingClient interface by deprecating
the original logDiagnosticMessage client method in V1 and adding three new,
explicit client methods.
- CMakeLists.txt:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp:
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageDeprecated):
Renamed from logDiagnosticMessage().
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage): Pass to the client.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageWithResult): Ditto.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessageWithValue): Ditto.
- WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::logDiagnosticMessage): Deleted.
- WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp: Added.
(WebKit::WebDiagnosticLoggingClient::WebDiagnosticLoggingClient): Simple constructor.
(WebKit::WebDiagnosticLoggingClient::~WebDiagnosticLoggingClient): Simple destructor.
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessage): Pass to the injected bundle.
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithResult): Ditto.
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValue): Ditto.
- WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h: Added.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize the new client.
- 8:25 PM Changeset in webkit [176498] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Unreviewed. Fixed syntax errors.
- init-database.sql:
- public/api/commits.php:
- 7:42 PM Changeset in webkit [176497] by
-
- 5 edits in trunk/Websites/perf.webkit.org
The dashboard on new perf monitor should be configurable
https://bugs.webkit.org/show_bug.cgi?id=138994
Reviewed by Benjamin Poulain.
For now, make it configurable via config.json. We should eventually make it configurable via
an administrative page but this will do for now.
- config.json: Added the empty dashboard configuration.
- public/include/manifest.php: Include the dashboard configuration in the manifest file.
- public/v2/app.js:
(App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
(App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
Also obtain the default configuration from App.Manifest.
(App.IndexController._normalizeTable): Moved to App.Dashboard.
- public/v2/manifest.js:
(App.Repository.urlForRevision): Fixed the position of the open curly bracket.
(App.Repository.urlForRevisionRange): Ditto.
(App.Dashboard): Added.
(App.Dashboard.table): Extracted from App.IndexController.gridChanged.
(App.Dashboard.rows): Ditto.
(App.Dashboard.headerColumns): Ditto.
(App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
(App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
Since there is exactly one dashboard object per app, it's okay to hard code an id here.
(App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
- 7:29 PM Changeset in webkit [176496] by
-
- 10 edits1 move1 add in trunk
Throttled DOMTimers can prevent their document from being garbage collected
https://bugs.webkit.org/show_bug.cgi?id=138915
Reviewed by Andreas Kling.
Source/WebCore:
Throttled DOMTimers whose interval depend on viewport changes would
keep a Vector of elements outside viewport causing them to be throttled
so that we could check later on (upon scroll or layout) if those
elements are still outside viewport. The issue is that these elements
could potentially be removed from the document (and destroyed) after
the timer has fired. To handle this, DOMTimer was ref'ing the
elements. Unfortunately, this was causing us to leak the document
as the elements in the Vector would keep the document alive.
To handle this issue, this patch updates the DOMTimer Vector to use
weak pointers. The WeakPtrFactory is stored in ElementRareData to
avoid wasting memory for all kinds of Elements (it is a fair assumption
that the number of elements whose style is animated via timers is low).
Test: fast/dom/throttled-timer-running-on-document-destruction.html
- dom/Element.cpp:
(WebCore::Element::createWeakPtr):
- dom/Element.h:
- dom/ElementRareData.cpp:
- dom/ElementRareData.h:
(WebCore::ElementRareData::weakPtrFactory):
- page/DOMTimer.cpp:
(WebCore::DOMTimerFireState::elementsChangedOutsideViewport):
(WebCore::DOMTimer::updateThrottlingStateAfterViewportChange):
- page/DOMTimer.h:
LayoutTests:
Improve fast/dom/throttled-timer-running-on-document-destruction.html
layout test to cover the case where the throttled timer is changing the
style of an element on the *same* document when the document is
destroyed.
- fast/dom/resources/frame-with-throttled-timer-animating-element-other-document.html: Renamed from LayoutTests/fast/dom/resources/frame-with-throttled-timer.html.
- fast/dom/resources/frame-with-throttled-timer-animating-element-same-document.html: Added.
- fast/dom/throttled-timer-running-on-document-destruction.html:
- 7:27 PM Changeset in webkit [176495] by
-
- 28 edits in trunk/Source
Unreviewed, EFL build fix since r176459.
r176459 removed Timer parameter in timer callbacks only for Mac port.
So this patch applies it to remaining classes for EFL port.
Source/WebCore:
No new tests, fix build break.
- Modules/mediastream/RTCDTMFSender.cpp:
(WebCore::RTCDTMFSender::RTCDTMFSender):
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::RTCDataChannel):
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
- Modules/vibration/Vibration.cpp:
(WebCore::Vibration::Vibration):
(WebCore::Vibration::timerFired):
- Modules/vibration/Vibration.h:
- bindings/js/GCController.cpp:
(WebCore::GCController::GCController):
- platform/efl/BatteryProviderEfl.cpp:
(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::timerFired):
- platform/efl/BatteryProviderEfl.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/texmap/TextureMapper.cpp:
(WebCore::BitmapTexturePool::BitmapTexturePool):
(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
(WebCore::CoordinatedImageBacking::CoordinatedImageBacking):
(WebCore::CoordinatedImageBacking::clearContentsTimerFired):
- platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
- platform/mock/DeviceMotionClientMock.cpp:
(WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
(WebCore::DeviceMotionClientMock::timerFired):
- platform/mock/DeviceMotionClientMock.h:
- platform/mock/TimerEventBasedMock.h:
(WebCore::TimerEvent::TimerEvent):
(WebCore::TimerEvent::timerFired):
Source/WebKit2:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::displayTimerFired):
- UIProcess/API/efl/EwkView.h:
- UIProcess/efl/TextCheckerClientEfl.cpp:
(TextCheckerClientEfl::TextCheckerClientEfl):
(TextCheckerClientEfl::languagesUpdateTimerFired):
(TextCheckerClientEfl::spellCheckingSettingChangeTimerFired):
- UIProcess/efl/TextCheckerClientEfl.h:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::layerFlushTimerFired):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 6:06 PM Changeset in webkit [176494] by
-
- 20 edits in trunk/Source
Start using the new :not() and :matches() in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=138978
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-21
Reviewed by Joseph Pecoraro.
Source/WebCore:
There are only minor pending issues on :not() and :matches(). The feedback
has only been positive so far. It is time to move them out the experimental
flag.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::detectFunctionTypeToken):
- css/CSSSelector.cpp:
(WebCore::simpleSelectorSpecificityInternal):
(WebCore::simpleSelectorFunctionalPseudoClassStaticSpecificity):
(WebCore::appendSelectorList):
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::determineLinkMatchType):
- css/SelectorPseudoClassAndCompatibilityElementMap.in:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
Source/WebInspectorUI:
Start simpifying some definitions by using modern CSS.
- UserInterface/Views/CSSStyleDeclarationSection.css:
(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:matches(.last-in-group, :last-child)):
(.style-declaration-section:matches(.locked, .selector-locked) > .header > .selector):
(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:last-child): Deleted.
(.style-declaration-section.selector-locked > .header > .selector): Deleted.
- UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.disabled, .invalid, .other-vendor, .not-inherited, .overridden)):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.implicit, .not-inherited)):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property:matches(.disabled, .other-vendor, .not-inherited, .overridden)):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.overridden): Deleted.
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.not-inherited): Deleted.
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property.overridden): Deleted.
- UserInterface/Views/ControlToolbarItem.css:
(.toolbar:matches(.icon-and-label-horizontal, .toolbar.icon-only) .item.control):
(.toolbar.icon-only .item.control): Deleted.
- UserInterface/Views/DOMStorageContentView.css:
- UserInterface/Views/DashboardContainerView.css:
(.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container):
(.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard-container):
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container):
(.toolbar.normal-size.icon-and-label-vertical .dashboard-container): Deleted.
(.toolbar.small-size.icon-and-label-horizontal .dashboard-container): Deleted.
(.toolbar.normal-size.icon-and-label-horizontal .dashboard-container): Deleted.
- UserInterface/Views/DataGrid.css:
(.data-grid :matches(th, td):not(:last-child)):
(.data-grid th:matches(.sort-ascending, .sort-descending)):
(.data-grid :matches(th, td) > div):
(.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child):
(.data-grid tr:matches(.selected, :hover) .go-to-arrow):
(.data-grid :-webkit-any(th, td):not(:last-child)): Deleted.
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending)): Deleted.
(.data-grid :-webkit-any(th, td) > div): Deleted.
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child): Deleted.
(.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow): Deleted.
- UserInterface/Views/DebuggerDashboardView.css:
(.toolbar.collapsed .dashboard.debugger > :not(.message, .navigation-bar )):
(.toolbar.collapsed .dashboard.debugger > :not(.message):not(.navigation-bar )): Deleted.
- UserInterface/Views/DefaultDashboardView.css:
(body.web .toolbar.collapsed .dashboard.default > :matches(.time, .resourcesSize, .logs)):
(body.javascript .toolbar .dashboard.default > :matches(.time, .resourcesSize, .resourcesCount)):
(.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard.default > .item):
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item):
(body.web .toolbar.collapsed .dashboard.default > .logs): Deleted.
(body.javascript .toolbar .dashboard.default > .resourcesCount): Deleted.
(.toolbar.small-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
(.toolbar.normal-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
- UserInterface/Views/DetailsSection.css:
(.details-section > .header > :matches(.node-link, .go-to-arrow)):
(.details-section > .content > .group:nth-child(even) > .row:matches(.simple:first-child > *, :not(.simple):first-child)):
(body.mac-platform.legacy .details-section > .content > .group:matches(:nth-child(even), :last-child) > .row.simple:last-child > *):
(.details-section > .content > .group > .row:matches(.empty, .text)):
(body.mac-platform.legacy .details-section > .content > .group > .row:matches(.empty, .text)):
(.details-section > .header > .go-to-arrow): Deleted.
(.details-section > .content > .group:nth-child(even) > .row.simple:first-child > *): Deleted.
(body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *): Deleted.
(.details-section > .content > .group > .row.text): Deleted.
(body.mac-platform.legacy .details-section > .content > .group > .row.text): Deleted.
- UserInterface/Views/FindBanner.css:
(:matches(.find-banner, .supports-find-banner).no-find-banner-transition):
(.supports-find-banner.no-find-banner-transition): Deleted.
- UserInterface/Views/FlexibleSpaceNavigationItem.css:
(:matches(.navigation-bar, .toolbar) .item.flexible-space):
(.toolbar .item.flexible-space): Deleted.
- 6:06 PM Changeset in webkit [176493] by
-
- 10 edits in trunk/Websites/perf.webkit.org
There should be a way to associate bugs with analysis tasks
https://bugs.webkit.org/show_bug.cgi?id=138977
Reviewed by Benjamin Poulain.
Updated associate-bug.php to match the new database schema.
- public/include/json-header.php:
(require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
already camel-cased in require_existence_of. This makes the function usable elsewhere.
- public/privileged-api/associate-bug.php:
(main): Changed the API to take run, bugTracker, and number to match the new database schema.
Also verify that those values are integers using require_format.
- public/v2/analysis.js:
(App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
(App.Bug.label): Added.
(App.BugAdapter): Added.
(App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
(App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
- public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
containing the bug information.
- public/v2/app.js:
(App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
(App.AnalysisTaskRoute):
(App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
(App.AnalysisTaskController._fetchedManifest): Added.
(App.AnalysisTaskController.actions.associateBug): Added.
- public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
- public/v2/data.js:
(Measurement.prototype.associateBug): Deleted.
- public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
Added a table show the bug information. Also hide the chart until chartData is available.
- public/v2/manifest.js:
(App.Model): Added.
- 5:43 PM Changeset in webkit [176492] by
-
- 4 edits in trunk/Source
Unreviewed, iOS build fix after r176462.
Source/WebCore:
Export a few extra symbols.
- WebCore.exp.in:
Source/WebKit2:
Fix include path to TextIndicator.h to include WebCore/
as it was moved.
- UIProcess/ios/PageClientImplIOS.mm:
- 5:26 PM Changeset in webkit [176491] by
-
- 4 edits in trunk/Source/WebCore
Properties in CSSPropertyNames.in should use the new StyleBuilder by default
https://bugs.webkit.org/show_bug.cgi?id=138983
Reviewed by Andreas Kling.
This patch makes using the new StyleBuilder the default and drops the
[NewStyleBuilder] option as a result. A new [LegacyStyleBuilder] option
is introduced for CSS properties that are not generated in the new
StyleBuilder yet.
- css/CSSPropertyNames.in:
- css/SVGCSSPropertyNames.in:
- css/makeprop.pl:
- 5:22 PM Changeset in webkit [176490] by
-
- 4 edits3 adds in trunk
[iOS] Regression(r176202): line-height is wrong on marco.org
https://bugs.webkit.org/show_bug.cgi?id=138970
Reviewed by Simon Fraser.
Source/WebCore:
After r176202, on iOS with IOS_TEXT_AUTOSIZING enabled, we would
multiply the lineHeight by RenderStyle::textSizeAdjust()::multiplier()
unconditionally. However, we're only supposed to do so if
RenderStyle::textSizeAdjust()::isPercentage() returns true. This
patch reintroduces the textSizeAdjust().isPercentage() check that was
inadvertently dropped when refactoring the code to be shared between
iOS and OS X.
Additionally, the multiplier is only supposed the be applied if the
input CSSPrimitiveValue is a Length or a Number. However, after
r176202, we would apply the multiplier if the CSSPrimitiveValue is
a Percentage or a Number. This patch updates the code to match the
behavior prior to r176202.
Test: fast/css/line-height-text-autosizing.html
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderFunctions::convertLineHeight):
(WebCore::StyleBuilderFunctions::applyValueLineHeight):
LayoutTests:
Add layout test to cover line-height CSS property and its interaction
with -webkit-text-size-adjust.
- fast/css/line-height-text-autosizing-expected.txt: Added.
- fast/css/line-height-text-autosizing.html: Added.
- platform/ios-simulator/fast/css/line-height-text-autosizing-expected.txt: Added.
- 5:09 PM Changeset in webkit [176489] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, iOS build fix after r176452.
dencodeFixedLengthData() now only takes 2 arguments instead of
3.
- Shared/ios/QuickLookDocumentData.cpp:
(WebKit::QuickLookDocumentData::decode):
- 4:59 PM Changeset in webkit [176488] by
-
- 14 edits in trunk
Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=138981
Reviewed by Simon Fraser.
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences simpleLineLayoutDebugBordersEnabled]):
(-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _simpleLineLayoutDebugBordersEnabled]):
(-[WKPreferences _setSimpleLineLayoutDebugBordersEnabled:]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Tools:
- MiniBrowser/mac/SettingsController.h:
- MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
(-[SettingsController simpleLineLayoutDebugBordersEnabled]):
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController didChangeSettings]):
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController didChangeSettings]):
- 4:55 PM Changeset in webkit [176487] by
-
- 2 edits in trunk/Source/WebKit2
WebVideoFullscreenManagerProxy must clear pointers when invalidated
https://bugs.webkit.org/show_bug.cgi?id=138982
Reviewed by Jer Noble.
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy): Call invalidate.
(WebKit::WebVideoFullscreenManagerProxy::invalidate): Set WebVideoFullscreenModel and
WebVideoFullscreenChangeObserver to NULL.
- 4:51 PM Changeset in webkit [176486] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build.
- UIProcess/API/mac/WKView.mm:
(-[WKView mouseDown:]):
- 4:19 PM Changeset in webkit [176485] by
-
- 2 edits in trunk/Source/WebKit2
The preview action menu item should not have a title
https://bugs.webkit.org/show_bug.cgi?id=138989
-and corresponding-
rdar://problem/19061959
Reviewed by Anders Carlsson.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _createActionMenuItemForTag:]):
- 4:11 PM Changeset in webkit [176484] by
-
- 2 edits in trunk/Source/WebCore
AX: com.apple.WebKit.WebContent crashed at WebCore: WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const
https://bugs.webkit.org/show_bug.cgi?id=138905
Reviewed by Mario Sanchez Prada.
The crash log indicates that m_renderer is null at the time we ask ancestorsOfType().
This is more of a speculative fix, since I am not entirely sure m_renderer is null when we enter the method.
Unable to determine cause of crash or how to reproduce on demand.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- 4:07 PM Changeset in webkit [176483] by
-
- 2 edits in trunk/Source/WebKit2
Page previews should have a margin.
https://bugs.webkit.org/show_bug.cgi?id=138990
Reviewed by Beth Dakin.
Enclose the WKWebView (or client-supplied preview view) in a container slightly larger
than the preview view. Adjust sizing code to accommodate the margin.
- UIProcess/mac/WKActionMenuController.mm:
(+[WKPagePreviewViewController previewPadding]):
Return the total amount of fixed padding surrounding the preview
(-[WKPagePreviewViewController loadView]):
Store the actual previewView in an ivar so that clients can distinguish it from the container
view; wrap the preview in a container view; set frames appropriately.
(-[WKActionMenuController _createPreviewPopover]):
Update to reflect method rename; supplement the popover size with the fixed padding.
(-[WKActionMenuController _preferredPopoverSizeWithPreviewPadding:]):
Renamed from -_preferredPopoverSize; account for the fixed padding when computing the preferred size.
(-[WKActionMenuController _clearPreviewPopover]):
Use the previewView ivar instead of the view controller's view.
(-[WKActionMenuController pagePreviewViewControllerWasClicked:]):
Ditto.
(-[WKActionMenuController _preferredPopoverSize]): Deleted.
- 4:04 PM Changeset in webkit [176482] by
-
- 2 edits in trunk/Source/WebCore
[EME][Mac] Check the underlying error if the one returned by AVFoundation is AVErrorUnknown.
https://bugs.webkit.org/show_bug.cgi?id=138986
Reviewed by Eric Carlson.
When we recieve an error with the code AVErrorUnknown, look for an underlying error from CoreMedia (or another
lower-level framework) with a (presumably) more informative error code, and return that code instead.
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::systemCodeForError):
(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError):
- 4:02 PM Changeset in webkit [176481] by
-
- 6 edits2 adds in trunk
AX: Unclear that user and password are autofilled, no VoiceOver version of the yellow outline.
https://bugs.webkit.org/show_bug.cgi?id=138904
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Add an attribute that marks when a text field is auto-filled.
Test: accessibility/auto-filled-value.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isValueAutofilled):
- accessibility/AccessibilityObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
- accessibility/auto-filled-value.html: Added.
- platform/mac/accessibility/auto-filled-value-expected.txt: Added.
- 3:53 PM Changeset in webkit [176480] by
-
- 4 edits in trunk/Source/WebKit2
REGRESSION (r176415): Can get stuck, unable to invoke any DataDetectors popovers
https://bugs.webkit.org/show_bug.cgi?id=138955
<rdar://problem/19056442>
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView mouseDown:]):
- UIProcess/mac/WKActionMenuController.h:
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController wkView:willHandleMouseDown:]):
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController menuNeedsUpdate:]):
Keep track of whether we have called shouldUseActionsWithContext: on a
DDActionContext; if we get a mouseDown without having seen didCloseMenu:
(and thus don't properly pair the shouldUseActionsWithContext: with a didUseActions),
tear down the old DDActionContext before proceeding.
- 3:41 PM Changeset in webkit [176479] by
-
- 23 edits2 adds in trunk
Allocate local ScopeChain register
https://bugs.webkit.org/show_bug.cgi?id=138793
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Now we allocate the scope register as a local. The allocated register is stored in the
CodeBlock for use by other components. Update the DFG to work with a local scope register.
Changed usage of JSStack::ScopeChain access to the CallFrame header to use the allocated
local register.
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
Updated to properly represent the operand inputs and bytecode result.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setScopeRegister):
(JSC::CodeBlock::scopeRegister):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::setScopeRegister):
(JSC::UnlinkedCodeBlock::scopeRegister):
Added scope register member and accessors.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::allocateAndEmitScope):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::scopeRegister):
Change m_scopeRegister to an allocated register. Added allocateAndEmitScope helper to
allocate the scope register, set the CodeBlock with its value and emit op_get_scope.
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::scope): Changed to access the scope using the new convention.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::parseBlock):
Changed op_create_lexical_environment to set the scope VirtualRegister operand.
Filled out op_get_scope processing to emit a GetScope node putting the result in
the scope VirtualRegister result operand.
Added Phantoms where appropriate to keep the Scope register alive in places where
it use is optimized away, but where the baseline JIT would need to use its value.
Eliminated uses of JSStack::ScopeChain.
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
Make sure that the scope register stack location is allocated using the same place
that the codeBlock expects.
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
Allow strength reduction of Flush to skip of GetScope nodes looking for a prior
corresponding SetLocal.
- interpreter/CallFrame.h:
(JSC::ExecState::scope):
(JSC::ExecState::setScope):
Added new scope() and setScope() helpers that take a VirtualRegister offset.
- interpreter/Interpreter.cpp:
(JSC::eval):
Changed eval() to get the scope from the caller's scope register instead of from the
temporary frame created for eval.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
Changed unwind() to manipulate the scope n the allocated register instead of from the
call frame slot.
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::readInlinedFrame):
- interpreter/StackVisitor.h:
(JSC::StackVisitor::Frame::callee):
(JSC::StackVisitor::Frame::scope): Deleted.
Eliminated the scope member as it needed to change and no StackVisitor users use it.
- jit/JITOperations.cpp:
(JSC::operationPushNameScope):
(JSC::operationPushWithScope):
- runtime/JSNameScope.h:
(JSC::JSNameScope::create):
- runtime/JSWithScope.h:
(JSC::JSWithScope::create): Deleted.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
Deleted JSNameScope::create() and JSWithScope::create() flavors tht used the ScopeChain slot
in the CallFrame header. Changed the only user of these function, op_push_name_scope and
op_push_with_scope helpers, to use the remaining create variants that require explicit scope.
Those operations get the scope from the register pointed to by their scope operands.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
Changed resolveScope to use the allocated register.
LayoutTests:
New test that sets a breakpoint in a callee of a DFG caller. While stopped in the
breakpoint, it modifies a global via the scope chain of the DFG caller as well as
a local of the DFG caller.
- inspector-protocol/debugger/resources/breakpoint.js:
(notInlineable3):
(dfgWithoutInline3):
- inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt: Added.
- inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html: Added.
- 3:39 PM Changeset in webkit [176478] by
-
- 27 edits in trunk/Source/WebCore
RenderElement::removeChild() doesn't need a return value.
<https://webkit.org/b/138985>
Reviewed by Pantti Koivisto.
Nobody uses the return value from RenderElement::removeChild().
Change it to return void and remove all the unnecessary plumbing.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::removeChild):
- rendering/RenderBlockFlow.h:
- rendering/RenderButton.cpp:
(WebCore::RenderButton::removeChild):
- rendering/RenderButton.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::removeChild):
(WebCore::RenderElement::removeChildInternal):
- rendering/RenderElement.h:
- rendering/RenderMenuList.cpp:
(RenderMenuList::removeChild):
- rendering/RenderMenuList.h:
- rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::removeChild):
- rendering/RenderRuby.h:
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::removeChild):
- rendering/RenderRubyRun.h:
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRootWrapper::removeChildWithoutRestructuring):
(WebCore::RenderMathMLRootWrapper::removeChild):
- rendering/mathml/RenderMathMLRoot.h:
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::removeChildInternal):
(WebCore::RenderMathMLScripts::removeChild):
(WebCore::RenderMathMLScriptsWrapper::removeChildInternal):
(WebCore::RenderMathMLScriptsWrapper::removeChild):
- rendering/mathml/RenderMathMLScripts.h:
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::removeChild):
- rendering/svg/RenderSVGContainer.h:
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::removeChild):
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::removeChild):
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::removeChild):
- rendering/svg/RenderSVGText.h:
- 3:38 PM Changeset in webkit [176477] by
-
- 6 edits in trunk/Source
REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
https://bugs.webkit.org/show_bug.cgi?id=138960
<rdar://problem/19056715>
Reviewed by Anders Carlsson.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
(-[WKActionMenuController _defaultMenuItemsForMailtoLink]): Deleted.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
(-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
Use DataDetectors SPI instead of an explicit blacklist.
- platform/spi/mac/DataDetectorsSPI.h:
Add some DataDetectors SPI.
- 3:29 PM Changeset in webkit [176476] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Random crashes inside media libraries when creating then destroying media quickly.
https://bugs.webkit.org/show_bug.cgi?id=138980
Reviewed by Eric Carlson.
Speculative fix for random crashes in the layout tests which occur randomly but regularly. The theory is
that creating-then-destroying our media objects too quickly triggers crashes deep within the media frameworks
when their initialization threads don't have a chance to complete before the main player object is destroyed.
Test out this theory by delaying the destruction of the AVPlayer object for 1s after its owner is destroyed.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
- 3:24 PM Changeset in webkit [176475] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Delay of 1-2s after the first paint of a video frame.
https://bugs.webkit.org/show_bug.cgi?id=138979
Reviewed by Eric Carlson.
Only bother waiting for a signal that a new image is ready when the image isn't ready in the first place.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
- 3:10 PM Changeset in webkit [176474] by
-
- 2 edits in trunk/Source/WebKit2
Crashes while encoding a TextIndicator with no contentImageWithHighlight
https://bugs.webkit.org/show_bug.cgi?id=138984
<rdar://problem/19063717>
Reviewed by Sam Weinig.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):
encodeImage doesn't deal with null images, so handle that case gracefully.
- 2:33 PM Changeset in webkit [176473] by
-
- 13 edits in trunk
Source/WebCore:
Add support to -webkit-line-break property for CSS3 Text line-break property values and semantics.
https://bugs.webkit.org/show_bug.cgi?id=89235
Reviewed by Eric Seidel and Dave Hyatt.
This patch adds semantic support for the CSS3 line-break property (qua -webkit-line-break),
and enables testing on (apple) mac ports. Follow on patches will enable these tests on
other ports as they are incrementally verified.
See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping
Tests: css3/line-break/line-break-auto-centered.html
css3/line-break/line-break-auto-half-kana.html
css3/line-break/line-break-auto-hyphens.html
css3/line-break/line-break-auto-inseparables.html
css3/line-break/line-break-auto-iteration-marks.html
css3/line-break/line-break-auto-postfixes.html
css3/line-break/line-break-auto-prefixes.html
css3/line-break/line-break-auto-sound-marks.html
css3/line-break/line-break-loose-centered.html
css3/line-break/line-break-loose-half-kana.html
css3/line-break/line-break-loose-hyphens.html
css3/line-break/line-break-loose-inseparables.html
css3/line-break/line-break-loose-iteration-marks.html
css3/line-break/line-break-loose-postfixes.html
css3/line-break/line-break-loose-prefixes.html
css3/line-break/line-break-loose-sound-marks.html
css3/line-break/line-break-normal-centered.html
css3/line-break/line-break-normal-half-kana.html
css3/line-break/line-break-normal-hyphens.html
css3/line-break/line-break-normal-inseparables.html
css3/line-break/line-break-normal-iteration-marks.html
css3/line-break/line-break-normal-postfixes.html
css3/line-break/line-break-normal-prefixes.html
css3/line-break/line-break-normal-sound-marks.html
css3/line-break/line-break-strict-centered.html
css3/line-break/line-break-strict-half-kana.html
css3/line-break/line-break-strict-hyphens.html
css3/line-break/line-break-strict-inseparables.html
css3/line-break/line-break-strict-iteration-marks.html
css3/line-break/line-break-strict-postfixes.html
css3/line-break/line-break-strict-prefixes.html
css3/line-break/line-break-strict-sound-marks.html
These tests were previously added in http://trac.webkit.org/changeset/143378, but skipped
in generic TestExpectations. In this patch, they are marked as Pass for the (apple) mac ports.
- platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
Add static function to construct ICU locale argument (also used as pool key) with additional
break keyword.
(LineBreakIteratorPool):
(WebCore::LineBreakIteratorPool::take):
(WebCore::LineBreakIteratorPool::put):
Remove direct dependency from ICU library (and types), moving that dependency into
new {open,close}LineBreakIterator() functions (defined in TextBreakIteratorICU.cpp).
Update to take line break mode into account.
Create (and cache) different break iterators depending on line break mode (in addition to locale),
which entails expanding pool entry key format to optionally append "@break=" +
"loose"|"normal"|"strict" keyword to locale string.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::isLooseCJKMode):
(WebCore::LazyLineBreakIterator::get):
(WebCore::LazyLineBreakIterator::reset):
(LazyLineBreakIterator):
Define LineBreakIteratorMode enumeration for use in TextBreakIterator et al.
Add state member to indicate line break mode.
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::acquireLineBreakIterator):
Use new line break mode when making iterator from pool.
Handle change of return type of LineBreakIteratorPool::take() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore::releaseLineBreakIterator):
Handle change of parameter type of LineBreakIteratorPool::put() to non-ICU type,
i.e., TextBreakIterator* instead of ICU's UBreakIterator*.
(WebCore):
(WebCore::isCJKLocale):
New functions for determining if CJK rules apply.
(WebCore::openLineBreakIterator):
New function for abstracting opening of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
This function also takes into account the line break mode.
Note that this function only calls ubrk_openRules() when the author has opted-in via
using the -webkit-line-break CSS property. Eventually, we would like to be able to
customize the rules that ICU's line breaking algorithm uses (especially for CJK text);
however, ubrk_openRules() currently parses its input string to create a DFA and is
therefore very slow. In fact, it's so slow that increasing our cache size in
LineBreakIteratorPool doesn't actually help enough. Also note that the default value
for the line-break CSS property is 'auto'.
(WebCore::closeLineBreakIterator):
(WebCore::mapLineIteratorModeToRules):
New function for abstracting closing of ICU style line break iterator. This is now
used in LineBreakIteratorPoolICU.h rather than having direct ICU API dependency there.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
Pass line break iterator mode flag when reseting LazyLineBreakIterator.
Add looseMode local variable to prevent need for computing under isBreakable().
- rendering/RenderText.cpp:
(WebCore::mapLineBreakToIteratorMode):
Add implementation for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
(WebCore):
(WebCore::RenderText::computePreferredLogicalWidths):
Ensure (lazy line) breakIterator is initialized for line break mode.
Ensure isBreakable() is passed loose mode flag to match behavior in RenderBlock::LineBreaker::nextLineBreak.
- rendering/RenderText.h:
(WebCore):
Add declaration for mapLineBreakToIteratorMode(), used by both RenderText::computePreferredLogicalWidths
and RenderBlock::LineBreaker::nextLineBreak.
- rendering/break_lines.cpp:
(WebCore):
Introduce (local) enum NBSPBehavior for expanding template on nextBreakablePosition.
(WebCore::isBreakableSpace):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation. Use new loose mode flavors off NBP functions.
(WebCore::needsLineBreakIterator):
Use enum NBSP behavior template parameter rather than boolean.
(WebCore::nextBreakablePositionNonLoosely):
Extend name to distinguish from loose flavor of this function.
(WebCore::nextBreakablePositionLoosely):
Add loose flavor of NBP invoked only when loose mode applies, in which case ASCII shortcut
table cannot be used.
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
Use (renamed) non-loose flavor of NBP.
(WebCore::nextBreakablePositionLoose):
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
Introduce loose flavor of NBP template expansions.
- rendering/break_lines.h:
(WebCore):
(WebCore::isBreakable):
Add externally specified loose mode parameter to prevent need to invoke line break iterator
accessor method on each invocation.
LayoutTests:
CSS3: line-break property support
https://bugs.webkit.org/show_bug.cgi?id=89235
Reviewed by Eric Seidel and Dave Hyatt.
- platform/mac/TestExpectations: Mark css3/line-break tests as passing.
- 1:34 PM Changeset in webkit [176472] by
-
- 2 edits in trunk/Source/WebCore
More build fixes.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
- 1:22 PM Changeset in webkit [176471] by
-
- 2 edits in trunk/Source/WebCore
[iOS] allocate volume view on the main thread
https://bugs.webkit.org/show_bug.cgi?id=138971
rdar://problem/18016958
Reviewed by Jer Noble.
- platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper allocateVolumeView]): New, dispatch to the main thread if necessary before allocating
the volume view.
(-[WebMediaSessionHelper initWithCallback:]): Call allocateVolumeView.
- 1:08 PM Changeset in webkit [176470] by
-
- 3 edits2 adds in trunk
REGRESSION(r175259) Simple line layout text measuring behavior changed.
https://bugs.webkit.org/show_bug.cgi?id=138947
rdar://problem/19050653
Reviewed by Antti Koivisto.
In certain cases, when block flow needs to compute the preferred width of a particular text
renderer, we use the non-simple line layout text measuring.
However, the same text renderer might end up at simple line layout later.
Complex line layout measures text including the trailing space and it subtracts
(the constant value of) space width afterwards, while simple line layout measures
runs without the extra space.
In such cases, this may result different word widths and produce unexpected line breaking. (preferred width != final width)
In long term, any text renderer qualified for simple line layout should go through the simple
text measuring code path. (https://bugs.webkit.org/show_bug.cgi?id=138973)
For now, just copy complex line layout behaviour. This also matches the previous simple line layout line breaking implementation.
Source/WebCore:
Test: fast/text/simple-line-text-measuring-with-trailing-space.html
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::FlowContents::textWidth):
LayoutTests:
- fast/text/simple-line-text-measuring-with-trailing-space-expected.html: Added.
- fast/text/simple-line-text-measuring-with-trailing-space.html: Added.
- 1:01 PM Changeset in webkit [176469] by
-
- 2 edits in trunk/Source/WebKit
Add a new symbol.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 12:57 PM Changeset in webkit [176468] by
-
- 2 edits in trunk/Source/WebKit
Remove a symbol that's gone.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 12:51 PM Changeset in webkit [176467] by
-
- 2 edits in trunk/Source/WebKit/win
Another Windows build fix.
- FullscreenVideoController.cpp:
(FullscreenVideoController::FullscreenVideoController):
- 12:44 PM Changeset in webkit [176466] by
-
- 5 edits in trunk/Source/WebCore
More Windows build fixes.
- platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
(WebCore::LegacyCACFLayerTreeHost::LegacyCACFLayerTreeHost):
(WebCore::LegacyCACFLayerTreeHost::renderTimerFired):
- platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:
- platform/mock/GeolocationClientMock.cpp:
(WebCore::GeolocationClientMock::GeolocationClientMock):
(WebCore::GeolocationClientMock::permissionTimerFired):
(WebCore::GeolocationClientMock::controllerTimerFired):
- platform/mock/GeolocationClientMock.h:
- 12:42 PM Changeset in webkit [176465] by
-
- 2 edits in trunk/Source/WebCore
RenderMathMLScripts isPrescript() helper should take a reference.
<https://webkit.org/b/138975>
Reviewed by Antti Koivisto.
Tidy this up a bit, since it's never called with a null pointer.
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::isPrescript):
(WebCore::RenderMathMLScripts::fixAnonymousStyles):
(WebCore::RenderMathMLScripts::addChildInternal):
(WebCore::RenderMathMLScripts::removeChildInternal):
(WebCore::RenderMathMLScripts::layout):
(WebCore::RenderMathMLScriptsWrapper::addChildInternal):
(WebCore::RenderMathMLScriptsWrapper::removeChildInternal):
- 12:37 PM Changeset in webkit [176464] by
-
- 9 edits in trunk/Source/WebCore
Windows build fixes.
- plugins/PluginPackage.cpp:
(WebCore::PluginPackage::freeLibraryTimerFired):
(WebCore::PluginPackage::PluginPackage):
- plugins/PluginPackage.h:
- plugins/PluginStream.cpp:
(WebCore::PluginStream::PluginStream):
(WebCore::PluginStream::delayDeliveryTimerFired):
(WebCore::PluginStream::deliverData): Deleted.
- plugins/PluginStream.h:
- plugins/PluginView.cpp:
(WebCore::PluginView::popPopupsStateTimerFired):
(WebCore::PluginView::requestTimerFired):
(WebCore::PluginView::invalidateTimerFired):
(WebCore::PluginView::PluginView):
(WebCore::PluginView::lifeSupportTimerFired):
(WebCore::PluginView::performRequest): Deleted.
(WebCore::PluginView::setValue): Deleted.
(WebCore::PluginView::setParameters): Deleted.
(WebCore::PluginView::userAgent): Deleted.
- plugins/PluginView.h:
- plugins/win/PluginMessageThrottlerWin.cpp:
(WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
(WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
- plugins/win/PluginMessageThrottlerWin.h:
- 12:28 PM Changeset in webkit [176463] by
-
- 6 edits in trunk/Source
REGRESSION (r176351): Parts of apple.com/contact aren't Lookup-able
https://bugs.webkit.org/show_bug.cgi?id=138960
<rdar://problem/19056715>
Reviewed by Beth Dakin.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
Blacklist contact results, because they don't have useful menus. If we
bail before setting up _currentActionContext, we'll still allow fallthrough
to ordinary text actions, avoiding mysterious failure when a contact is detected.
This doesn't break the case that r176351 was intended to fix,
because in that case we were detecting e.g. addresses.
- platform/spi/mac/DataDetectorsSPI.h:
Softlink some SPI.
- 12:18 PM Changeset in webkit [176462] by
-
- 33 edits4 adds4 deletes in trunk/Source
Move TextIndicator{Window} to WebCore
https://bugs.webkit.org/show_bug.cgi?id=138954
<rdar://problem/18992185>
Some adjustments by Csaba Osztrogonác.
Reviewed by Anders Carlsson.
Move TextIndicator and TextIndicatorWindow to WebCore so that both
WebKits can share the implementation.
- CMakeLists.txt:
Remove TextIndicator.cpp.
- Scripts/webkit/messages.py:
(struct_or_class):
(headers_for_type):
Tell messages.py that TextIndicatorData is a struct, and comes from TextIndicator.h.
- Shared/WebCoreArgumentCoders.h:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):
Add argument coders for TextIndicatorData.
- Shared/DictionaryPopupInfo.h:
- Shared/mac/ActionMenuHitTestResult.h:
- Shared/mac/ActionMenuHitTestResult.mm:
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/PageClientImpl.cpp:
- UIProcess/API/mac/WKView.mm:
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/CoordinatedGraphics/WebView.h:
- UIProcess/CoordinatedGraphics/WebView.cpp:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/WKContentView.h:
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
- UIProcess/mac/WKActionMenuController.mm:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
- WebProcess/WebPage/FindController.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
- WebProcess/WebPage/mac/WebPageMac.mm:
Adjust to TextIndicator and TextIndicatorWindow's new home.
- CMakeLists.txt:
Build TextIndicator.
- WebCore.exp.in:
Export TextIndicator{Window} symbols for the WebKits.
- WebCore.xcodeproj/project.pbxproj:
- page/TextIndicator.cpp: Renamed from Source/WebKit2/Shared/TextIndicator.cpp.
- page/TextIndicator.h: Renamed from Source/WebKit2/Shared/TextIndicator.h.
Straighforward move of TextIndicator from WebKit2, except:
Move TextIndicator::Data and TextIndicator::PresentationTransition out directly
into the WebCore namespace to allow for implementation of WebKit2 argument coders.
Use Image instead of ShareableBitmap internally.
Move the TextIndicatorData encode/decode to WebCoreArgumentCoders.
- page/mac/TextIndicatorWindow.h: Renamed from Source/WebKit2/UIProcess/mac/TextIndicatorWindow.h.
- page/mac/TextIndicatorWindow.mm: Renamed from Source/WebKit2/UIProcess/mac/TextIndicatorWindow.mm.
Straighforward move of TextIndicatorWindow from WebKit2.
- 12:13 PM Changeset in webkit [176461] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Remove a duplicate ChangeLog entry.
- 12:11 PM Changeset in webkit [176460] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r176238): Mailto links are getting preloaded, which results in a compose window
https://bugs.webkit.org/show_bug.cgi?id=138972
Reviewed by Beth Dakin.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController willOpenMenu:withEvent:]):
Only preload links.
- 12:10 PM Changeset in webkit [176459] by
-
- 242 edits in trunk/Source
Remove the Timer parameters from timer callbacks
https://bugs.webkit.org/show_bug.cgi?id=138974
Reviewed by Antti Koivisto.
Source/WebCore:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::GeoNotifier):
(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::resumeTimerFired):
- Modules/geolocation/Geolocation.h:
- Modules/indexeddb/IDBTransactionBackend.cpp:
(WebCore::IDBTransactionBackend::IDBTransactionBackend):
(WebCore::IDBTransactionBackend::taskTimerFired):
- Modules/indexeddb/IDBTransactionBackend.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::appendBufferTimerFired):
(WebCore::SourceBuffer::removeTimerFired):
- Modules/mediasource/SourceBuffer.h:
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::scheduledEventTimerFired):
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/RTCDTMFSender.cpp:
(WebCore::RTCDTMFSender::RTCDTMFSender):
(WebCore::RTCDTMFSender::scheduledEventTimerFired):
- Modules/mediastream/RTCDTMFSender.h:
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::RTCDataChannel):
(WebCore::RTCDataChannel::scheduledEventTimerFired):
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):
- Modules/mediastream/RTCPeerConnection.h:
- Modules/notifications/Notification.cpp:
(WebCore::Notification::Notification):
(WebCore::Notification::taskTimerFired):
- Modules/notifications/Notification.h:
- Modules/notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::NotificationRequestCallback::NotificationRequestCallback):
(WebCore::NotificationCenter::NotificationRequestCallback::timerFired):
- Modules/notifications/NotificationCenter.h:
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::closingTimerFired):
- Modules/websockets/WebSocketChannel.h:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::notificationPostTimerFired):
- accessibility/AXObjectCache.h:
- bindings/js/GCController.cpp:
(WebCore::GCController::GCController):
(WebCore::GCController::gcTimerFired):
- bindings/js/GCController.h:
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::beginLoadTimerFired):
- css/CSSFontSelector.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
- css/StyleResolver.h:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::visualUpdatesSuppressionTimerFired):
(WebCore::Document::styleRecalcTimerFired):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::sharedObjectPoolClearTimerFired):
(WebCore::Document::updateFocusAppearanceTimerFired):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::loadEventDelayTimerFired):
(WebCore::Document::didAssociateFormControlsTimerFired):
(WebCore::Document::domCookieCacheExpiryTimerFired):
- dom/Document.h:
- dom/EventSender.h:
(WebCore::EventSender::timerFired):
(WebCore::EventSender<T>::EventSender):
- dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::ScriptRunner):
(WebCore::ScriptRunner::timerFired):
- dom/ScriptRunner.h:
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::animationTimerFired):
- dom/ScriptedAnimationController.h:
- dom/StyledElement.cpp:
(WebCore::PresentationAttributeCacheCleaner::PresentationAttributeCacheCleaner):
(WebCore::PresentationAttributeCacheCleaner::cleanCache):
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::AlternativeTextController):
(WebCore::AlternativeTextController::timerFired):
- editing/AlternativeTextController.h:
- editing/Editor.cpp:
(WebCore::Editor::Editor):
(WebCore::Editor::updateEditorUINowIfScheduled):
(WebCore::Editor::editorUIUpdateTimerFired):
(WebCore::Editor::scanSelectionForTelephoneNumbers): Deleted.
- editing/Editor.h:
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::caretBlinkTimerFired):
- editing/FrameSelection.h:
- editing/SpellChecker.cpp:
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::timerFiredToProcessQueuedRequest):
- editing/SpellChecker.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore::HTMLFormElement::requestAutocompleteTimerFired):
- html/HTMLFormElement.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::HTMLPlugInElement):
(WebCore::HTMLPlugInElement::swapRendererTimerFired):
- html/HTMLPlugInElement.h:
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired):
- html/HTMLPlugInImageElement.h:
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::HTMLSourceElement):
(WebCore::HTMLSourceElement::errorEventTimerFired):
- html/HTMLSourceElement.h:
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::HTMLTrackElement):
(WebCore::HTMLTrackElement::loadTimerFired):
- html/HTMLTrackElement.h:
- html/MediaController.cpp:
(MediaController::MediaController):
(MediaController::asyncEventTimerFired):
(MediaController::clearPositionTimerFired):
(MediaController::timeupdateTimerFired):
- html/MediaController.h:
- html/MediaDocument.cpp:
(WebCore::MediaDocument::MediaDocument):
(WebCore::MediaDocument::replaceMediaElementTimerFired):
- html/MediaDocument.h:
- html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType):
(WebCore::SearchInputType::searchEventTimerFired):
- html/SearchInputType.h:
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessage):
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
(WebCore::ValidationMessage::buildBubbleTree):
(WebCore::ValidationMessage::requestToHideMessage):
(WebCore::ValidationMessage::deleteBubbleTree):
- html/ValidationMessage.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::dispatchContextLostEvent):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
- html/canvas/WebGLRenderingContext.h:
- html/parser/HTMLParserScheduler.cpp:
(WebCore::HTMLParserScheduler::HTMLParserScheduler):
(WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
- html/parser/HTMLParserScheduler.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::MediaControlPanelElement):
(WebCore::MediaControlPanelElement::transitionTimerFired):
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::MediaControls):
(WebCore::MediaControls::hideFullscreenControlsTimerFired):
- html/shadow/MediaControls.h:
- html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::repeatingTimerFired):
- html/shadow/SpinButtonElement.h:
- html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::LoadableTextTrack):
(WebCore::LoadableTextTrack::loadTimerFired):
- html/track/LoadableTextTrack.h:
- html/track/VTTRegion.cpp:
(WebCore::VTTRegion::VTTRegion):
(WebCore::VTTRegion::scrollTimerFired):
- html/track/VTTRegion.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::timerFired):
- inspector/InspectorDOMAgent.cpp:
(WebCore::RevalidateStyleAttributeTask::RevalidateStyleAttributeTask):
(WebCore::RevalidateStyleAttributeTask::timerFired):
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorBackendDispatchTask::timerFired):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::updatePaintRectsTimerFired):
- inspector/InspectorOverlay.h:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::handleSubstituteDataLoadSoon):
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::checkTimerFired):
- loader/FrameLoader.h:
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::timerFired):
- loader/ImageLoader.h:
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::LinkLoader):
(WebCore::LinkLoader::linkLoadTimerFired):
(WebCore::LinkLoader::linkLoadingErrorTimerFired):
- loader/LinkLoader.h:
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::NavigationScheduler):
(WebCore::NavigationScheduler::timerFired):
- loader/NavigationScheduler.h:
- loader/PingLoader.cpp:
(WebCore::PingLoader::PingLoader):
- loader/PingLoader.h:
(WebCore::PingLoader::timeoutTimerFired):
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::progressHeartbeatTimerFired):
- loader/ProgressTracker.h:
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::ResourceLoadScheduler):
(WebCore::ResourceLoadScheduler::requestTimerFired):
- loader/ResourceLoadScheduler.h:
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::TextTrackLoader):
(WebCore::TextTrackLoader::cueLoadTimerFired):
- loader/TextTrackLoader.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::Callback::Callback):
(WebCore::CachedResource::Callback::timerFired):
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
- loader/cache/CachedResourceLoader.h:
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::syncTimerFired):
- loader/icon/IconDatabase.h:
- page/AutoscrollController.cpp:
(WebCore::AutoscrollController::AutoscrollController):
(WebCore::AutoscrollController::autoscrollTimerFired):
- page/AutoscrollController.h:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::CaptionUserPreferences):
(WebCore::CaptionUserPreferences::timerFired):
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::CaptionUserPreferencesMediaAF):
(WebCore::CaptionUserPreferencesMediaAF::updateTimerFired):
- page/CaptionUserPreferencesMediaAF.h:
- page/DeviceController.cpp:
(WebCore::DeviceController::DeviceController):
(WebCore::DeviceController::fireDeviceEvent):
- page/DeviceController.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::cursorUpdateTimerFired):
(WebCore::EventHandler::autoHideCursorTimerFired):
(WebCore::EventHandler::recognizeLongMousePress):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
(WebCore::EventHandler::hoverTimerFired):
- page/EventHandler.h:
- page/EventSource.cpp:
(WebCore::EventSource::EventSource):
(WebCore::EventSource::connectTimerFired):
- page/EventSource.h:
- page/FocusController.cpp:
(WebCore::FocusController::FocusController):
(WebCore::FocusController::focusRepaintTimerFired):
- page/FocusController.h:
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::overflowAutoScrollTimerFired):
- page/Frame.h:
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::delayedScrollEventTimerFired):
(WebCore::FrameView::speculativeTilingEnableTimerFired):
(WebCore::FrameView::layoutTimerFired):
(WebCore::FrameView::updateEmbeddedObjectsTimerFired):
(WebCore::FrameView::flushAnyPendingPostLayoutTasks):
(WebCore::FrameView::postLayoutTimerFired):
- page/FrameView.h:
- page/PageOverlay.cpp:
(WebCore::PageOverlay::PageOverlay):
(WebCore::PageOverlay::fadeAnimationTimerFired):
- page/PageOverlay.h:
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::imageLoadingSettingsTimerFired):
- page/Settings.h:
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
(WebCore::AnimationControllerPrivate::animationTimerFired):
- page/animation/AnimationControllerPrivate.h:
- page/mac/ServicesOverlayController.h:
- page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::ServicesOverlayController):
(WebCore::ServicesOverlayController::determineActiveHighlightTimerFired):
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::AsyncScrollingCoordinator):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScrollTimerFired):
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ios/ScrollingCoordinatorIOS.h:
- page/scrolling/ios/ScrollingCoordinatorIOS.mm:
(WebCore::ScrollingCoordinatorIOS::ScrollingCoordinatorIOS):
(WebCore::ScrollingCoordinatorIOS::scrollingStateTreeCommitterTimerFired):
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac):
(WebCore::ScrollingCoordinatorMac::scrollingStateTreeCommitterTimerFired):
- platform/HysteresisActivity.h:
(WebCore::HysteresisActivity::HysteresisActivity):
(WebCore::HysteresisActivity::hysteresisTimerFired):
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::updateScrollAnimatorsAndTimers):
(WebCore::ScrollAnimator::horizontalScrollSnapTimerFired):
(WebCore::ScrollAnimator::verticalScrollSnapTimerFired):
- platform/ScrollAnimator.h:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::autoscrollTimerFired):
- platform/Scrollbar.h:
- platform/Timer.h:
(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer):
(WebCore::Timer::Timer): Deleted.
- platform/audio/MediaSession.cpp:
(WebCore::MediaSession::MediaSession):
(WebCore::MediaSession::clientDataBufferingTimerFired):
- platform/audio/MediaSession.h:
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):
(WebCore::BitmapImage::advanceAnimation):
- platform/graphics/BitmapImage.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::MediaPlayer):
(WebCore::MediaPlayer::reloadTimerFired):
- platform/graphics/MediaPlayer.h:
- platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::timerFired):
- platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:
- platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
(WebCore::MediaSelectionGroupAVFObjC::MediaSelectionGroupAVFObjC):
(WebCore::MediaSelectionGroupAVFObjC::selectionTimerFired):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekTimerFired):
- platform/graphics/ca/LayerPool.cpp:
(WebCore::LayerPool::LayerPool):
(WebCore::LayerPool::pruneTimerFired):
- platform/graphics/ca/LayerPool.h:
- platform/graphics/ca/TileController.cpp:
(WebCore::TileController::TileController):
(WebCore::TileController::tileRevalidationTimerFired):
- platform/graphics/ca/TileController.h:
- platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::TileGrid):
(WebCore::TileGrid::cohortRemovalTimerFired):
- platform/graphics/ca/TileGrid.h:
- platform/graphics/cg/IOSurfacePool.cpp:
(WebCore::IOSurfacePool::IOSurfacePool):
(WebCore::IOSurfacePool::collectionTimerFired):
- platform/graphics/cg/IOSurfacePool.h:
- platform/graphics/cg/SubimageCacheWithTimer.cpp:
(WebCore::SubimageCacheWithTimer::SubimageCacheWithTimer):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::seekTimerFired):
- platform/ios/LegacyTileCache.h:
- platform/ios/LegacyTileCache.mm:
(WebCore::LegacyTileCache::LegacyTileCache):
(WebCore::LegacyTileCache::tileCreationTimerFired):
- platform/mac/HIDGamepadProvider.cpp:
(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::connectionDelayTimerFired):
(WebCore::HIDGamepadProvider::inputNotificationTimerFired):
- platform/mac/HIDGamepadProvider.h:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):
- platform/mock/DeviceOrientationClientMock.cpp:
(WebCore::DeviceOrientationClientMock::DeviceOrientationClientMock):
(WebCore::DeviceOrientationClientMock::timerFired):
- platform/mock/DeviceOrientationClientMock.h:
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
- platform/mock/PlatformSpeechSynthesizerMock.h:
- platform/network/DNSResolveQueue.cpp:
(WebCore::DNSResolveQueue::DNSResolveQueue):
(WebCore::DNSResolveQueue::timerFired):
- platform/network/DNSResolveQueue.h:
- platform/network/NetworkStateNotifier.h:
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::failureTimerFired):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::networkStateChangeTimerFired):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::ImageQualityController):
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
- rendering/ImageQualityController.h:
- rendering/RenderButton.cpp:
(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::timerFired):
- rendering/RenderButton.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::layerFlushTimerFired):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):
- rendering/RenderLayerCompositor.h:
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::RenderMarquee):
(WebCore::RenderMarquee::timerFired):
- rendering/RenderMarquee.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):
- rendering/RenderNamedFlowThread.h:
- rendering/RenderProgress.cpp:
(WebCore::RenderProgress::RenderProgress):
(WebCore::RenderProgress::animationTimerFired):
- rendering/RenderProgress.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::lazyRepaintTimerFired):
- rendering/RenderView.h:
- replay/EventLoopInputDispatcher.cpp:
(WebCore::EventLoopInputDispatcher::EventLoopInputDispatcher):
(WebCore::EventLoopInputDispatcher::timerFired):
- replay/EventLoopInputDispatcher.h:
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::StorageAreaImpl):
(WebCore::StorageAreaImpl::closeDatabaseTimerFired):
(WebCore::StorageAreaImpl::closeDatabaseIfIdle):
- storage/StorageAreaImpl.h:
- storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::scheduleFinalSync):
(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::scheduleSync):
- storage/StorageAreaSync.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::svgLoadEventTimerFired):
- svg/SVGElement.h:
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::SVGScriptElement):
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::SVGStyleElement):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::timerFired):
- svg/animation/SMILTimeContainer.h:
- xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
- xml/XMLHttpRequestProgressEventThrottle.h:
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
(WebKit::NetscapePluginInstanceProxy::requestTimerFired):
- Plugins/WebNetscapePluginStream.h:
- Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::WebNetscapePluginStream):
(WebNetscapePluginStream::deliverDataTimerFired):
Source/WebKit/win:
- FullscreenVideoController.cpp:
(FullscreenVideoController::timerFired):
- FullscreenVideoController.h:
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::bufferingTimerFired):
- NetworkProcess/NetworkResourceLoader.h:
- Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::WebMemorySampler):
(WebKit::WebMemorySampler::sampleTimerFired):
(WebKit::WebMemorySampler::stopTimerFired):
- Shared/WebMemorySampler.h:
- Shared/mac/RemoteLayerBackingStoreCollection.h:
- Shared/mac/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::RemoteLayerBackingStoreCollection):
(WebKit::RemoteLayerBackingStoreCollection::volatilityTimerFired):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::layerFlushTimerFired):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::processSuspensionCleanupTimerFired):
(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired):
- WebProcess/WebProcess.h:
Source/WTF:
- wtf/RunLoopTimer.h:
(WTF::RunLoopTimer::RunLoopTimer):
(WTF::RunLoopTimer::fired):
- 11:48 AM Changeset in webkit [176458] by
-
- 3 edits2 adds in trunk
Crash when setting 'transition-delay' CSS property to a calculated value
https://bugs.webkit.org/show_bug.cgi?id=138784
Reviewed by Sam Weinig.
Source/WebCore:
Update CSSPrimitiveValue::computeTime() to use primitiveType() instead
of m_primitiveUnitType so that it properly handles calculated values.
Without this, we would hit the ASSERT_NOT_REACHED() assertion in
computeTime() for calculated values.
Test: fast/css/transition-delay-calculated-value.html
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::computeTime):
LayoutTests:
Add a layout test to check that setting the 'transition-delay' CSS
property to a calculated value does not crash and works as intended.
- fast/css/transition-delay-calculated-value-expected.txt: Added.
- fast/css/transition-delay-calculated-value.html: Added.
- 11:46 AM Changeset in webkit [176457] by
-
- 2 edits in trunk/Source/WebKit2
Fix iOS build.
- Shared/ios/QuickLookDocumentData.cpp:
(WebKit::QuickLookDocumentData::encode):
- 11:32 AM Changeset in webkit [176456] by
-
- 5 edits1 add in trunk/LayoutTests
Two WebGL tests try to use an external resource.
https://bugs.webkit.org/show_bug.cgi?id=138936.
Reviewed by Alexey Proskuryakov.
- http/tests/resources/square128.png: Added.
- http/tests/webgl/1.0.2/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html:
- http/tests/webgl/1.0.2/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html:
- http/tests/webgl/1.0.2/texImage2DHTML-expected.txt:
- http/tests/webgl/1.0.2/texSubImage2DHTML-expected.txt:
- 11:01 AM Changeset in webkit [176455] by
-
- 3 edits3 adds in trunk
Regression(r175381): -webkit-mask-box-image is broken
https://bugs.webkit.org/show_bug.cgi?id=138969
<rdar://problem/19054471>
Reviewed by Simon Fraser.
Source/WebCore:
After r175381, the StyleBuilder would call NinePieceImage::setMaskDefaults()
*after* calling CSSToStyleMap::mapNinePieceImage(), instead of *before*, for
-webkit-mask-box-image CSS property. This was causing the mask defaults to
overwrite what was set by mapNinePieceImage().
Test: fast/css/webkit-mask-box-image.html
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertBorderMask):
LayoutTests:
Add a layout test to add basic coverage for -webkit-mask-box-image
CSS property.
- fast/css/resources/mask.png: Added.
- fast/css/webkit-mask-box-image.html: Added.
- fast/css/webkit-mask-box-image-expected.html: Added
- 11:00 AM Changeset in webkit [176454] by
-
- 3 edits2 adds in trunk
Crash when setting 'font' CSS property to 'calc(2 * 3)'
https://bugs.webkit.org/show_bug.cgi?id=138933
Reviewed by Darin Adler.
Source/WebCore:
The CSS Parser was not handling calculated values when parsing the font
weight. This would lead us to hit an assertion when parsing a font
property whose weight is set to a calculated value.
This patch updates parseFontWeight() to properly handle calculated
values.
Test: fast/css/font-calculated-value.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontWeight):
LayoutTests:
Add a layout test to cover the case where the 'font' CSS property is
set to a value whose weight is a calculated value, to make sure it
does not crash and behaves as intended.
- fast/css/font-calculated-value-expected.txt: Added.
- fast/css/font-calculated-value.html: Added.
- 10:43 AM Changeset in webkit [176453] by
-
- 10 edits2 adds in trunk
[CSS Font Loading] Switch to dispatching events asynchronously
https://bugs.webkit.org/show_bug.cgi?id=138755
Patch by Bear Travis <betravis@gmail.com> on 2014-11-21
Reviewed by Simon Fraser.
Source/WebCore:
Moving FontLoader to dispatch events and notify callbacks similarly
to EventSender or the GenericEventQueue. Several bugs have popped
up in the past because FontLoader has been sending events during
layout, and there is no need for that to be the case.
Covered by existing font loader event tests. Added an additional
test for the svg case, fontloader-svg-select.
- css/FontLoader.cpp:
(WebCore::FontLoader::didLayout):
(WebCore::FontLoader::timerFired): Adding asynchronous callback.
(WebCore::FontLoader::scheduleEvent): Add an event to the dispatch
queue.
(WebCore::FontLoader::firePendingEvents): Modified to handle the
loading done event and callbacks.
(WebCore::FontLoader::loadingDone): Modified to spin up the timer
rather than immediately dispatching events.
- css/FontLoader.h:
LayoutTests:
Refactoring tests to check for all events only after the FontLoader
itself has completed. Tests were previously checking after a specific font
had loaded, at which point some of the events may have yet to fire.
- fast/css/fontloader-multiple-faces-download-error-expected.txt:
- fast/css/fontloader-multiple-faces-download-error.html:
- fast/css/fontloader-multiple-faces-expected.txt:
- fast/css/fontloader-multiple-faces.html:
- fast/css/fontloader-multiple-families-expected.txt:
- fast/css/fontloader-multiple-families.html:
- fast/css/fontloader-svg-select-expected.txt: Added
- fast/css/fontloader-svg-select.svg: Added
- 9:40 AM Changeset in webkit [176452] by
-
- 11 edits in trunk/Source/WebKit2
Remove alignment code from IPC coders
https://bugs.webkit.org/show_bug.cgi?id=138963
Reviewed by Anders Carlsson.
Alignment code achieves nothing except making the messages somewhat bigger.
- Platform/IPC/ArgumentCoders.cpp:
(IPC::ArgumentCoder<CString>::encode):
(IPC::ArgumentCoder<CString>::decode):
(IPC::ArgumentCoder<String>::encode):
(IPC::decodeStringText):
- Platform/IPC/ArgumentCoders.h:
(IPC::SimpleArgumentCoder::encode):
(IPC::SimpleArgumentCoder::decode):
- Platform/IPC/ArgumentDecoder.cpp:
(IPC::ArgumentDecoder::initialize):
(IPC::ArgumentDecoder::bufferIsLargeEnoughToContain):
(IPC::ArgumentDecoder::decodeFixedLengthData):
(IPC::ArgumentDecoder::decodeVariableLengthByteArray):
(IPC::ArgumentDecoder::decodeNumber):
(IPC::ArgumentDecoder::decode):
(IPC::roundUpToAlignment): Deleted.
(IPC::alignedBufferIsLargeEnoughToContain): Deleted.
(IPC::ArgumentDecoder::alignBufferPosition): Deleted.
(IPC::decodeValueFromBuffer): Deleted.
- Platform/IPC/ArgumentDecoder.h:
(IPC::ArgumentDecoder::isInvalid):
(IPC::ArgumentDecoder::markInvalid):
(IPC::ArgumentDecoder::bufferIsLargeEnoughToContain):
- Platform/IPC/ArgumentEncoder.cpp:
(IPC::ArgumentEncoder::ArgumentEncoder):
(IPC::ArgumentEncoder::grow):
(IPC::ArgumentEncoder::encodeFixedLengthData):
(IPC::ArgumentEncoder::encodeVariableLengthByteArray):
(IPC::ArgumentEncoder::encode):
- Platform/IPC/ArgumentEncoder.h:
(IPC::ArgumentEncoder::buffer):
(IPC::ArgumentEncoder::mutableBuffer):
- Platform/IPC/DataReference.cpp:
(IPC::SharedBufferDataReference::encode):
- Platform/IPC/MessageEncoder.cpp:
(IPC::MessageEncoder::setIsSyncMessage):
(IPC::MessageEncoder::setShouldDispatchMessageWhenWaitingForSyncReply):
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::sendOutgoingMessage):
- 9:05 AM Changeset in webkit [176451] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the internal Apple Mavericks build after <https://trac.webkit.org/changeset/176448>
(https://bugs.webkit.org/show_bug.cgi?id=138930)
Declare NSCachedURLResponse SPI when building without the Apple Internal SDK and with the Apple
Internal SDK when building for OS X Mavericks or earlier.
- platform/spi/cf/CFNetworkSPI.h:
- 9:04 AM Changeset in webkit [176450] by
-
- 28 edits in trunk/Source
Make memoryCache() return a reference
https://bugs.webkit.org/show_bug.cgi?id=138939
Reviewed by Antti Koivisto.
Source/WebCore:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResource):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::replayXHR):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::mainFrameNavigated):
- loader/DocumentLoader.cpp:
(WebCore::areAllLoadersPageCacheAcceptable):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::responseReceived):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::addIncrementalDataBuffer):
(WebCore::CachedImage::finishLoading):
- loader/cache/CachedResource.cpp:
(WebCore::deadDecodedDataDeletionIntervalForResourceType):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::failBeforeStarting):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore::CachedResource::setDecodedSize):
(WebCore::CachedResource::setEncodedSize):
(WebCore::CachedResource::didAccessDecodedData):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::clearPreloads):
(WebCore::CachedResourceLoader::printPreloadStats):
- loader/cache/MemoryCache.cpp:
(WebCore::memoryCache):
(WebCore::MemoryCache::removeRequestFromCache):
(WebCore::MemoryCache::removeRequestFromSessionCaches):
- loader/cache/MemoryCache.h:
- loader/cocoa/DiskCacheMonitorCocoa.mm:
(WebCore::DiskCacheMonitor::resourceBecameFileBacked):
- page/FrameView.cpp:
(WebCore::FrameView::willPaintContents):
(WebCore::FrameView::didPaintContents):
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
- testing/Internals.cpp:
(WebCore::Internals::isLoadingFromMemoryCache):
Source/WebKit/mac:
- Misc/WebCache.mm:
(+[WebCache statistics]):
(+[WebCache emptyInMemoryResources]):
(+[WebCache sizeOfDeadResources:]):
(+[WebCache addImageToCache:forURL:forFrame:]):
(+[WebCache removeImageFromCacheForURL:forFrame:]):
(+[WebCache imageForURL:]):
(+[WebCache setDisabled:]):
(+[WebCache isDisabled]):
- WebView/WebView.mm:
(+[WebView _setCacheModel:]):
Source/WebKit/win:
- WebCache.cpp:
(WebCache::statistics):
(WebCache::empty):
(WebCache::setDisabled):
(WebCache::disabled):
- WebView.cpp:
(WebView::setCacheModel):
Source/WebKit2:
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didCacheResource):
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):
(WebKit::WebProcess::clearResourceCaches):
(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::setMemoryCacheDisabled):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformSetCacheModel):
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformSetCacheModel):
- 8:44 AM Changeset in webkit [176449] by
-
- 2 edits in trunk/Tools
Remove http lock code from webkitperl
https://bugs.webkit.org/show_bug.cgi?id=138959
Reviewed by Alexey Proskuryakov.
- Scripts/webkitperl/httpd.pm:
(cleanUp):
(extractLockNumber): Deleted.
(getLockFiles): Deleted.
(getNextAvailableLockNumber): Deleted.
(getLockNumberForCurrentRunning): Deleted.
(waitForHTTPDLock): Deleted.
(scheduleHttpTesting): Deleted.
(getWaitTime): Deleted.
- 8:40 AM Changeset in webkit [176448] by
-
- 16 edits1 move in trunk/Source
[iOS] WebKit2 fails to build with public SDK due to missing SPI from CFNetwork, QuartzCore, MediaPlayer, XPC
https://bugs.webkit.org/show_bug.cgi?id=138930
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Rename header MPAVRoutingControllerSPI.h to MediaPlayerSPI.h.
- loader/cocoa/SubresourceLoaderCocoa.mm: Move NSCachedURLResponse forward declarations to file
CFNetworkSPI.h and include header CFNetworkSPI.h.
- loader/mac/ResourceLoaderMac.mm: Ditto.
- platform/audio/ios/MediaSessionManagerIOS.mm: Substitute MediaPlayerSPI.h for MPAVRoutingControllerSPI.h.
- platform/spi/cf/CFNetworkSPI.h: Add more SPI.
- platform/spi/cg/CoreGraphicsSPI.h: Ditto.
- platform/spi/cocoa/QuartzCoreSPI.h: Ditto.
- platform/spi/ios/MediaPlayerSPI.h: Renamed from Source/WebCore/platform/spi/ios/MPAVRoutingControllerSPI.h.
Source/WebKit2:
- NetworkProcess/mac/NetworkResourceLoaderMac.mm: Remove forward declaration for NSCachedURLResponse
methods as this functionality was incorporated into CFNetworkSPI.h, which is included by this file.
- Platform/mac/LayerHostingContext.mm: Moved QuartzCore forward declarations from this file to file
QuartzCoreSPI.h and included header QuartzCoreSPI.h.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h: Include header XPCSPI.h.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm: Remove forward declarations of
XPC SPI since these declarations are part of XCPSPI.h, which is included by header XPCServiceEntryPoint.h.
- UIProcess/API/Cocoa/WKWebView.mm: Remove unnecessary include of header QuartzCore/CARenderServer.h
as it will be included by header QuartzCoreSPI.h.
- UIProcess/Network/NetworkProcessProxy.cpp: Include header XPCSPI.h when building for iOS with
USE(XPC_SERVICES) enabled.
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm: Include header MediaPlayerSPI.h instead of including
MediaPlayer private headers directly. Also sort the list of #import directives.
- 7:55 AM Changeset in webkit [176447] by
-
- 4 edits2 adds in trunk
AX: MathML expressions are misread by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=138948
Reviewed by Mario Sanchez Prada.
Source/WebCore:
The logic for deciding what's the radicand and an index was too tied to children placement.
We should instead pull directly from the source.
Test: platform/mac/accessibility/mathml-root.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::mathRadicandObject):
(WebCore::AccessibilityRenderObject::mathRootIndexObject):
- rendering/mathml/RenderMathMLRoot.h:
LayoutTests:
- platform/mac/accessibility/mathml-root-expected.txt: Added.
- platform/mac/accessibility/mathml-root.html: Added.
- 7:26 AM Changeset in webkit [176446] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Disable verifyHeap
https://bugs.webkit.org/show_bug.cgi?id=138962
Reviewed by Mark Lam.
- runtime/Options.h:
Nov 20, 2014:
- 11:56 PM WebKitGTK/2.6.x edited by
- (diff)
- 11:23 PM Changeset in webkit [176445] by
-
- 2 edits in tags/Safari-601.1.10.1/Source/WebKit2
Merged r176441. rdar://problem/19054967
- 11:07 PM Changeset in webkit [176444] by
-
- 1 copy in releases/WebKitGTK/webkit-2.6.4
WebKitGTK+ 2.6.4
- 11:06 PM Changeset in webkit [176443] by
-
- 4 edits in releases/WebKitGTK/webkit-2.6
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.6.4 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.6.4.
- 11:06 PM Changeset in webkit [176442] by
-
- 2 edits in trunk
[CMake] Use ld.gold if it is available to speedup builds
https://bugs.webkit.org/show_bug.cgi?id=137953
Reviewed by Carlos Garcia Campos.
- Source/cmake/OptionsCommon.cmake:
- 10:59 PM Changeset in webkit [176441] by
-
- 2 edits in trunk/Source/WebKit2
Build fix.
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]): Cast the return value of
[getMPAudioVideoRoutingPopoverControllerClass() alloc] to resolve ambiguity about which
-initWithType: we are calling.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Cast to resolve ambiguity.
(-[WKAirPlayRoutePicker show:fromRect:]): Cast for consistency.
- 10:58 PM Changeset in webkit [176440] by
-
- 5 edits in tags/Safari-601.1.10.1/Source
Versioning.
- 10:55 PM Changeset in webkit [176439] by
-
- 1 copy in tags/Safari-601.1.10.1
New tag.
- 10:26 PM Changeset in webkit [176438] by
-
- 2 edits in trunk/Tools
[EFL] The option value of fixed layout is false in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=138830
Patch by Hunseop Jeong <Hunseop Jeong> on 2014-11-20
Reviewed by Gyuyoung Kim.
Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
- MiniBrowser/efl/main.c:
- 8:49 PM Changeset in webkit [176437] by
-
- 17 edits in trunk/Source
Remove the remaining vestiges of minimal-ui
https://bugs.webkit.org/show_bug.cgi?id=138890
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-20
Reviewed by Sam Weinig.
Source/WebCore:
In ViewportArguments' setViewportFeature(), I skip the warning for now.
- WebCore.exp.in:
- dom/ViewportArguments.cpp:
(WebCore::setViewportFeature):
- dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::operator==):
- page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::ViewportConfiguration):
(WebCore::ViewportConfiguration::initialScale):
(WebCore::ViewportConfiguration::minimumScale):
(WebCore::ViewportConfiguration::updateConfiguration):
(WebCore::ViewportConfiguration::viewportArgumentsLength):
(WebCore::ViewportConfiguration::layoutWidth):
(WebCore::ViewportConfiguration::layoutHeight):
(WebCore::ViewportConfigurationTextStream::operator<<):
(WebCore::ViewportConfiguration::description):
(WebCore::ViewportConfiguration::setMinimumLayoutSizeForMinimalUI): Deleted.
(WebCore::ViewportConfiguration::activeMinimumLayoutSizeInScrollViewCoordinates): Deleted.
(WebCore::ViewportConfiguration::resetMinimalUI): Deleted.
(WebCore::ViewportConfiguration::didFinishDocumentLoad): Deleted.
- page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::minimumLayoutSizeForMinimalUI): Deleted.
(WebCore::ViewportConfiguration::usesMinimalUI): Deleted.
Source/WebKit/ios:
- WebCoreSupport/WebChromeClientIOS.mm:
(dictionaryForViewportArguments):
- WebKit.iOS.exp:
Source/WebKit/mac:
- History/WebHistoryItem.mm:
- History/WebHistoryItemPrivate.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
(WebKit::WebPage::didFinishDocumentLoad): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::savePageState):
(WebKit::WebPage::restorePageState):
(WebKit::WebPage::viewportConfigurationChanged):
(WebKit::WebPage::updateViewportSizeForCSSViewportUnits):
- 8:31 PM Changeset in webkit [176436] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: do not show invalid specificity for dynamic cases of :matches()
https://bugs.webkit.org/show_bug.cgi?id=138911
Reviewed by Joseph Pecoraro.
- css/CSSSelector.cpp:
(WebCore::simpleSelectorFunctionalPseudoClassStaticSpecificity):
(WebCore::functionalPseudoClassStaticSpecificity):
(WebCore::staticSpecificityInternal):
(WebCore::CSSSelector::staticSpecificity):
(WebCore::CSSSelector::specificity): Deleted.
- css/CSSSelector.h:
Add an additional computation path for the inspector.
The regular path ignores everything inside function pseudo classes.
This new path takes the static specificity of the regular path, then evaluate
recursively all the selector lists inside any level of :matches().
If two complex selector of selector list do not have the same specificity,
we bail out and refuse to compute a static specificity representing the selector.
- inspector/InspectorStyleSheet.cpp:
(WebCore::buildObjectForSelectorHelper):
(WebCore::selectorsFromSource):
(WebCore::InspectorStyleSheet::buildObjectForSelector):
Do not add the complexity to the inspector's CSSSelector structure whenever
it is dynamic.
- 8:30 PM Changeset in webkit [176435] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Fix misc bugs and typos in app.js
https://bugs.webkit.org/show_bug.cgi?id=138946
Reviewed by Benjamin Poulain.
- public/v2/app.js:
(App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
(App.ChartsController.init):
(App.buildPopup): Renamed from App.BuildPopup.
(App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
remove() on the wrong object (an array as opposed to elements in the array).
(App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
_highlights is always an array and evalutes to true.
- 8:26 PM Changeset in webkit [176434] by
-
- 3 edits in trunk/Source/WebCore
Remove InspectorCSSAgent::buildArrayForRuleList()
https://bugs.webkit.org/show_bug.cgi?id=138907
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-20
Reviewed by Andreas Kling.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForRuleList): Deleted.
- inspector/InspectorCSSAgent.h:
- 7:47 PM Changeset in webkit [176433] by
-
- 2 edits in trunk/LayoutTests
[iOS] Skip some tests that fail with stderr
- platform/ios-simulator/TestExpectations:
- 7:17 PM Changeset in webkit [176432] by
-
- 3 edits2 adds in trunk
REGRESSION (174986): CSS clip property is ignored when border-radius is present.
https://bugs.webkit.org/show_bug.cgi?id=138935
rdar://problem/18965984
Reviewed by Simon Fraser.
Revert back to r163382 and fix bug 127729 properly. Save the graphics context when paint and clip rects are
the same, but the clip rect has radius.
Each iteration on ::clipRect() from r163382 onwards just introduced yet another regression.
Source/WebCore:
Test: fast/clip/css-clip-does-not-work-when-border-radius-is-present.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):
LayoutTests:
- fast/clip/css-clip-does-not-work-when-border-radius-is-present-expected.html: Added.
- fast/clip/css-clip-does-not-work-when-border-radius-is-present.html: Added.
- 6:27 PM Changeset in webkit [176431] by
-
- 9 edits2 deletes in trunk/Source/WebCore
Removed the custom allocator for PODRedBlackTree
https://bugs.webkit.org/show_bug.cgi?id=138942
Reviewed by Sam Weinig.
bmalloc is fast enough.
- WebCore.xcodeproj/project.pbxproj:
- platform/PODArena.h: Removed.
- platform/PODFreeListArena.h: Removed. This is the point of the patch.
- platform/PODIntervalTree.h:
(WebCore::PODIntervalTree::PODIntervalTree): Deleted. As a side effect
of removing our custom allocator, we can no longer have a special
"I'm not initialized yet" state. Instead, the tree either exists or not,
like an idiomatic C++ object.
- platform/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::PODRedBlackTree): Ditto.
(WebCore::PODRedBlackTree::~PODRedBlackTree): We need to clear in our
destructor because we can no longer rely on the arena destructor
implicitly freeing our tree nodes.
Side note: This change basically removes the whole reason for having
a purpose-built tree for POD data. We should probably remove this whole
data structure in a follow-up patch, and just use a standard tree.
(WebCore::PODRedBlackTree::clear):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):
(WebCore::PODRedBlackTree::deleteNode):
(WebCore::PODRedBlackTree::markFree): Use normal new/delete, and mark
ourselves as fast allocated so we get the bmalloc goodness.
(WebCore::PODRedBlackTree::isInitialized): Deleted.
(WebCore::PODRedBlackTree::initIfNeeded): Deleted.
- rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::FloatingObjects):
(WebCore::FloatingObjects::clear):
(WebCore::FloatingObjects::addPlacedObject):
(WebCore::FloatingObjects::removePlacedObject):
(WebCore::FloatingObjects::computePlacedFloatsTree):
(WebCore::FloatingObjects::placedFloatsTree):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset): POD tree had a slightly
weird behavior in which it was valid to use some of its APIs without
first initializing it, but not others. It's not really possible to model
that behavior with normal C++ objects that use new/delete, so instead
I added some explicit NULL checks.
- rendering/FloatingObjects.h:
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
- rendering/RenderView.cpp:
(WebCore::RenderView::intervalArena): Deleted.
- rendering/RenderView.h: Removed custom-allocator-related cruft.
- 6:10 PM Changeset in webkit [176430] by
-
- 2 edits in trunk/Source/WebKit2
Preview popover needs minimum and maximum sizes
https://bugs.webkit.org/show_bug.cgi?id=138943
-and corresponding-
rdar://problem/18904651
Reviewed by Tim Horton.
Quick follow-up to get the right screen.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController largestPopoverSize]):
- 5:52 PM Changeset in webkit [176429] by
-
- 3 edits in trunk/Source/WebKit2
Preview popover needs minimum and maximum sizes
https://bugs.webkit.org/show_bug.cgi?id=138943
-and corresponding-
rdar://problem/18904651
Reviewed by Tim Horton.
This patch enforces minimum and maximum popover sizes. If the popover needs to be
sized up to be above the minimum, it will end up covering some of the
_hitTestResult, so we should compute a new origin rect based on the original
event location.
- UIProcess/mac/WKActionMenuController.h:
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController prepareForMenu:withEvent:]):
(-[WKActionMenuController _previewURLFromActionMenu:]):
(-[WKActionMenuController _createPreviewPopover]):
(-[WKActionMenuController largestPopoverSize]):
(-[WKActionMenuController _preferredPopoverSize]):
(-[WKActionMenuController _preferredSizeForPopoverPresentedFromOriginRect:]): Deleted.
- 4:57 PM Changeset in webkit [176428] by
-
- 2 edits in trunk/Source/WebKit2
Clicks on previews can be recognized multiple times
https://bugs.webkit.org/show_bug.cgi?id=138944
Reviewed by Tim Horton.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKPagePreviewViewController _clickRecognized:]):
Only dispatch the delegate message on the appropriate gesture recognizer state transition.
- 4:36 PM Changeset in webkit [176427] by
-
- 4 edits in trunk/Source/WebKit2
Clients should be able to customize preview click behavior
https://bugs.webkit.org/show_bug.cgi?id=138940
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKViewPrivate.h:
Declare -_handleClickInPreviewView:URL:.
- UIProcess/API/mac/WKView.mm:
(-[WKView _handleClickInPreviewView:URL:]):
Extracted from -[WKActionMenuController pagePreviewViewControllerWasClicked:].
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController pagePreviewViewControllerWasClicked:]):
Extract code to -[WKView _handleClickInPreviewView:URL:].
- 4:28 PM Changeset in webkit [176426] by
-
- 1 copy in tags/Safari-600.3.8
Tagging.
- 3:39 PM Changeset in webkit [176425] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add some comments to describe the DFG UseKind representations.
<https://webkit.org/b/138934>
Reviewed by Filip Pizlo.
- dfg/DFGUseKind.h:
- Also regrouped the UseKind enums by representation to be more readable.
- 3:28 PM Changeset in webkit [176424] by
-
- 8 edits2 adds in trunk/Source/JavaScriptCore
Add Heap verification infrastructure.
<https://webkit.org/b/138851>
Reviewed by Geoffrey Garen.
The verification infrastructure code is always built in but disabled by
default. When disabled, the cost is minimal:
- Heap has a m_verifier field.
- GC does a few "if (m_verifier)" checks that should fail.
- HeapVerifier takes up code space though not used.
When enabled:
- The HeapVerifier will keep N number of GC cycle data. Each GC cycle will contain a "before marking" and "after marking" live object list. The GC cycles is a circular buffer. Only data for the last N GC cycles will be retained.
- During GC, the current GC cycle's live objects lists will be populated before and after marking.
- The current GC cycle's live object lists will be validated before GC, after marking, and after GC.
Currently, the only validation being done is to verify that object
butterflies are allocated from valid blocks in the Storage (aka Copied)
space.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collect):
- heap/Heap.h:
- heap/HeapVerifier.cpp: Added.
(JSC::LiveObjectList::findObject):
(JSC::HeapVerifier::HeapVerifier):
(JSC::HeapVerifier::collectionTypeName):
(JSC::HeapVerifier::phaseName):
(JSC::getButterflyDetails):
(JSC::HeapVerifier::initializeGCCycle):
(JSC::GatherLiveObjFunctor::GatherLiveObjFunctor):
(JSC::GatherLiveObjFunctor::operator()):
(JSC::HeapVerifier::gatherLiveObjects):
(JSC::HeapVerifier::liveObjectListForGathering):
(JSC::trimDeadObjectsFromList):
(JSC::HeapVerifier::trimDeadObjects):
(JSC::HeapVerifier::verifyButterflyIsInStorageSpace):
(JSC::HeapVerifier::verify):
(JSC::HeapVerifier::reportObject):
(JSC::HeapVerifier::checkIfRecorded):
- heap/HeapVerifier.h: Added.
(JSC::LiveObjectData::LiveObjectData):
(JSC::LiveObjectList::LiveObjectList):
(JSC::LiveObjectList::reset):
(JSC::HeapVerifier::GCCycle::GCCycle):
(JSC::HeapVerifier::GCCycle::collectionTypeName):
(JSC::HeapVerifier::incrementCycle):
(JSC::HeapVerifier::currentCycle):
(JSC::HeapVerifier::cycleForIndex):
- runtime/Options.h:
- 3:26 PM Changeset in webkit [176423] by
-
- 32 edits7 adds in trunk
Support unprefixed animation event types
https://bugs.webkit.org/show_bug.cgi?id=138931
<rdar://problem/18943167>
Reviewed by Simon Fraser.
Source/WebCore:
Tests: animations/unprefixed-events-mixed-with-prefixed.html
animations/unprefixed-events.html
Support the unprefixed animation event names:
- animationstart (was webkitAnimationStart)
- animationiteration (was webkitAnimationIteration)
- animationend (was webkitAnimationEnd)
(Yes, event types are case sensitive and yes, this will
likely cause some head-scratching as people change content)
The approach here is to follow what transitions does:
- listener only for old event name -> fire old event name
- listener for both old and new event name -> fire new event name
- listener only for new event name -> fire new event name
That way pages that were trying to anticipate the new event name
won't get duplicate events.
- CMakeLists.txt: Add new AnimationEvent* stuff.
- DerivedSources.make: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: New files for all in one builds.
- dom/DOMAllInOne.cpp:
- dom/AnimationEvent.cpp: Added. Copied from WebKitAnimationEvent.cpp.
(WebCore::AnimationEventInit::AnimationEventInit):
(WebCore::AnimationEvent::AnimationEvent):
(WebCore::AnimationEvent::~AnimationEvent):
(WebCore::AnimationEvent::animationName):
(WebCore::AnimationEvent::elapsedTime):
(WebCore::AnimationEvent::eventInterface):
- dom/AnimationEvent.h: Added. Copied from WebKitAnimationEvent.h.
- dom/AnimationEvent.idl: Added. Copied from WebKitAnimationEvent.idl.
- dom/Document.cpp:
(WebCore::Document::addListenerTypeIfNeeded): Handle new event types.
- dom/EventNames.h: New names.
- dom/EventNames.in:
- dom/EventTarget.cpp:
(WebCore::legacyType): Provide a mapping from the new names to the older
prefixed forms.
- html/HTMLAttributeNames.in: Support the on* attributes, even though I
hate them and wish this approach would die.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::populateEventNameForAttributeLocalNameMap):
- page/DOMWindow.h: New names, and constructors.
- page/DOMWindow.idl:
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): Fire new type.
- page/animation/KeyframeAnimation.cpp: Fire the new types of events.
(WebCore::KeyframeAnimation::onAnimationStart):
(WebCore::KeyframeAnimation::onAnimationIteration):
(WebCore::KeyframeAnimation::onAnimationEnd):
(WebCore::KeyframeAnimation::sendAnimationEvent):
LayoutTests:
Add a test for unprefixed animation event names, as well
as a test that ensures we don't get multiple dispatches if
we're still listening for the old events.
And for the older tests, just add the new things from the
window namespace.
- animations/unprefixed-events-expected.txt: Added.
- animations/unprefixed-events-mixed-with-prefixed-expected.txt: Added.
- animations/unprefixed-events-mixed-with-prefixed.html: Added.
- animations/unprefixed-events.html: Added.
- fast/events/event-creation-expected.txt:
- fast/events/event-creation.html:
- js/dom/constructor-length.html:
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/constructor-length-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/constructor-length-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/constructor-length-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 3:25 PM Changeset in webkit [176422] by
-
- 11 edits in trunk/Websites/perf.webkit.org
New perf dashboard should provide UI to create a new analysis task
https://bugs.webkit.org/show_bug.cgi?id=138910
Reviewed by Benjamin Poulain.
This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
With this patch, we can create a new analysis task by selection a range of points and opening
"analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
in the chart hyperlinked to the analysis task.
- init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
- public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
(main):
(fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
and adds the associated bugs to each task in the array.
(format_task):
- public/api/runs.php: Reverted changes made in r175006.
(fetch_runs_for_config):
(format_run):
- public/api/test-groups.php:
(fetch_test_groups_for_task): Use the newly added Database::select_rows.
- public/include/db.php:
(Database::select_first_or_last_row):
(Database::select_rows): Extracted from select_first_or_last_row.
- public/v2/analysis.js:
(App.AnalysisTask): Added "bugs" property.
(App.Bug): Added now that bugs are regular data store objects.
- public/v2/app.js:
(App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
(App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
platform that are associated with a specific range of runs.
(App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
(App.PaneController.actions.associateBug): Deleted.
(App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
once we've created one.
(App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
(App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
(App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
(App.PaneController._updateBugs): Deleted.
(App.PaneController._updateMarkedPoints): Deleted.
(App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
the name is missing or when at most one point is selected.
(App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
(App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
(App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
(App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
clickable bars for analysis tasks.
(App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
bar for analysis tasks to place them at the right location.
(App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
- public/v2/chart-pane.css:
(.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
(.chart .rangeBar): Added.
- public/v2/data.js:
(TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
- public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
task bars in the interactive chart component.
- 3:04 PM Changeset in webkit [176421] by
-
- 2 edits in trunk/Source/WebKit2
URTBF after r176420 to fix non Apple builds.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):
- 2:56 PM Changeset in webkit [176420] by
-
- 6 edits in trunk/Source/WebKit2
WebPlugInClient::m_webPage can never be null, use a reference
https://bugs.webkit.org/show_bug.cgi?id=138937
Reviewed by Andreas Kling.
- WebProcess/WebCoreSupport/WebPlugInClient.cpp:
(WebKit::WebPlugInClient::WebPlugInClient):
(WebKit::WebPlugInClient::shouldAutoStartFromOrigin):
- WebProcess/WebCoreSupport/WebPlugInClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):
- WebProcess/WebProcess.h:
- 2:33 PM Changeset in webkit [176419] by
-
- 2 edits in trunk/LayoutTests
[iOS] Update TestExpectation file for LayoutTests/canvas tests
Also skip some LayoutTests/animation tests that are flaky or fail due to an assertion failure.
- platform/ios-simulator/TestExpectations:
- 2:26 PM Changeset in webkit [176418] by
-
- 4 edits in trunk/Source/WebKit2
TextIndicator should have getters for TextIndicator::Data properties
https://bugs.webkit.org/show_bug.cgi?id=138920
Reviewed by Beth Dakin.
Instead of having clients reach into the data(), add getters.
Remove frameRect(), which is identical to the textBoundingRectInWindowCoordinates getter.
Remove declarations for draw/drawContentImage, which were already removed.
- Shared/TextIndicator.cpp:
(WebKit::TextIndicator::frameRect): Deleted.
- Shared/TextIndicator.h:
(WebKit::TextIndicator::textBoundingRectInWindowCoordinates):
(WebKit::TextIndicator::textRectsInBoundingRectCoordinates):
(WebKit::TextIndicator::contentImageScaleFactor):
(WebKit::TextIndicator::contentImageWithHighlight):
(WebKit::TextIndicator::contentImage):
- UIProcess/mac/TextIndicatorWindow.mm:
(-[WKTextIndicatorView initWithFrame:textIndicator:margin:]):
(-[WKTextIndicatorView presentWithCompletionHandler:]):
(WebKit::TextIndicatorWindow::setTextIndicator):
- 2:23 PM Changeset in webkit [176417] by
-
- 2 edits in trunk/Source/WebCore
Remove a piece of DataDetectors SPI that we aren't using anymore
https://bugs.webkit.org/show_bug.cgi?id=138917
Reviewed by Beth Dakin.
- platform/spi/mac/DataDetectorsSPI.h:
- 2:17 PM Changeset in webkit [176416] by
-
- 2 edits in trunk/LayoutTests
Skip flaky inspector-protocol/debugger tests.
webkit.org/b/100846, webkit.org/b/136715
- platform/mac/TestExpectations:
- 2:16 PM Changeset in webkit [176415] by
-
- 4 edits in trunk/Source
Cancel DataDetectors menu earlier if we know it can't be presented
https://bugs.webkit.org/show_bug.cgi?id=138922
<rdar://problem/18950441>
Reviewed by Beth Dakin.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController willOpenMenu:withEvent:]):
If we end up with a menu with no items, don't change selection or anything.
(-[WKActionMenuController menuNeedsUpdate:]):
Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
and use a bigger hammer (removeAllItems).
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController prepareForMenu:withEvent:]):
Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
and use a bigger hammer (removeAllItems).
(-[WebActionMenuController willOpenMenu:withEvent:]):
If we end up with a menu with no items, don't change selection or anything.
- 2:10 PM Changeset in webkit [176414] by
-
- 3 edits in trunk/Source/WebKit2
Don't use a TextIndicator BounceAndCrossfade transition if the selection highlight is never shown
https://bugs.webkit.org/show_bug.cgi?id=138919
<rdar://problem/19042207>
Reviewed by Beth Dakin.
- Shared/TextIndicator.h:
(WebKit::TextIndicator::presentationTransition):
(WebKit::TextIndicator::setPresentationTransition):
Add getter and setter pair.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
If the selection highlight will never be shown because there's only a single menu item,
use a normal bounce animation instead of bounce + crossfade.
- 2:10 PM Changeset in webkit [176413] by
-
- 262 edits1 move2 adds in trunk/LayoutTests
http tests should not use shared temporary files, part 2
https://bugs.webkit.org/show_bug.cgi?id=138894
Rubber-stamped by Tim Horton.
Made more scripts that access local files use per-test files. Some tests could use
HTTP referrer, others needed explicit parameters.
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow.html:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block.html:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty.html:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter.html:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid.html:
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html:
- http/tests/security/contentSecurityPolicy/resources/echo-report.php:
- http/tests/security/contentSecurityPolicy/resources/generate-csp-report.html: Removed.
- http/tests/security/contentSecurityPolicy/resources/generate-csp-report.php: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/resources/generate-csp-report.html.
- http/tests/security/contentSecurityPolicy/resources/go-to-echo-report.php: Added.
- http/tests/security/contentSecurityPolicy/resources/reflected-xss-and-xss-protection.js:
(testMixedHeader):
- http/tests/security/contentSecurityPolicy/resources/report-file-path.php: Added.
- http/tests/security/contentSecurityPolicy/resources/save-report.php:
- http/tests/security/contentSecurityPolicy/xmlhttprequest-protected-resource-does-not-crash.html:
- http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-location.html:
- http/tests/security/xssAuditor/block-does-not-leak-referrer.html:
- http/tests/security/xssAuditor/cookie-injection-expected.txt:
- http/tests/security/xssAuditor/cookie-injection.html:
- http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
- http/tests/security/xssAuditor/embed-tag-code-attribute-2.html:
- http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
- http/tests/security/xssAuditor/embed-tag-code-attribute.html:
- http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/embed-tag-control-char.html:
- http/tests/security/xssAuditor/embed-tag-expected.txt:
- http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/embed-tag-javascript-url.html:
- http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/embed-tag-null-char.html:
- http/tests/security/xssAuditor/embed-tag.html:
- http/tests/security/xssAuditor/faux-script1.html:
- http/tests/security/xssAuditor/faux-script2.html:
- http/tests/security/xssAuditor/faux-script3.html:
- http/tests/security/xssAuditor/form-action-expected.txt:
- http/tests/security/xssAuditor/form-action.html:
- http/tests/security/xssAuditor/formaction-on-button-expected.txt:
- http/tests/security/xssAuditor/formaction-on-button.html:
- http/tests/security/xssAuditor/formaction-on-input-expected.txt:
- http/tests/security/xssAuditor/formaction-on-input.html:
- http/tests/security/xssAuditor/frameset-injection-expected.txt:
- http/tests/security/xssAuditor/frameset-injection.html:
- http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
- http/tests/security/xssAuditor/full-block-get-from-iframe.html:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url.html:
- http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-no-inherit.php:
- http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
- http/tests/security/xssAuditor/full-block-link-onclick.html:
- http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-object-tag.html:
- http/tests/security/xssAuditor/full-block-post-from-iframe.html:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html:
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-with-source.html:
- http/tests/security/xssAuditor/full-block-script-tag.html:
- http/tests/security/xssAuditor/get-from-iframe-expected.txt:
- http/tests/security/xssAuditor/get-from-iframe.html:
- http/tests/security/xssAuditor/iframe-injection-allowed-2.html:
- http/tests/security/xssAuditor/iframe-injection-allowed-3.html:
- http/tests/security/xssAuditor/iframe-injection-allowed.html:
- http/tests/security/xssAuditor/iframe-injection-expected.txt:
- http/tests/security/xssAuditor/iframe-injection.html:
- http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-more-encoding.html:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html:
- http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-url-encoded.html:
- http/tests/security/xssAuditor/iframe-javascript-url.html:
- http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
- http/tests/security/xssAuditor/iframe-onload-GBK-char.html:
- http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
- http/tests/security/xssAuditor/iframe-onload-in-svg-tag.html:
- http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
- http/tests/security/xssAuditor/iframe-srcdoc.html:
- http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-GBK-char.html:
- http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-accented-char.html:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char.html:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char2.html:
- http/tests/security/xssAuditor/img-onerror-tricky.html:
- http/tests/security/xssAuditor/img-tag-with-comma-expected.txt:
- http/tests/security/xssAuditor/img-tag-with-comma.html:
- http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
- http/tests/security/xssAuditor/inline-event-HTML-entities.html:
- http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
- http/tests/security/xssAuditor/link-onclick-ampersand.html:
- http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
- http/tests/security/xssAuditor/link-onclick-control-char.html:
- http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
- http/tests/security/xssAuditor/link-onclick-entities.html:
- http/tests/security/xssAuditor/link-onclick-expected.txt:
- http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
- http/tests/security/xssAuditor/link-onclick-null-char.html:
- http/tests/security/xssAuditor/link-onclick.html:
- http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
- http/tests/security/xssAuditor/link-opens-new-window.html:
- http/tests/security/xssAuditor/malformed-HTML-expected.txt:
- http/tests/security/xssAuditor/malformed-HTML.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-1.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-2.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-3.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-4.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-5.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-6.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-7.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-8.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-9.html:
- http/tests/security/xssAuditor/no-protection-script-tag.html:
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-control-char.html:
- http/tests/security/xssAuditor/object-embed-tag-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-null-char.html:
- http/tests/security/xssAuditor/object-embed-tag.html:
- http/tests/security/xssAuditor/object-tag-expected.txt:
- http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/object-tag-javascript-url.html:
- http/tests/security/xssAuditor/object-tag.html:
- http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
- http/tests/security/xssAuditor/open-event-handler-iframe.html:
- http/tests/security/xssAuditor/open-iframe-src-03-expected.txt:
- http/tests/security/xssAuditor/open-iframe-src-03.html:
- http/tests/security/xssAuditor/post-from-iframe.html:
- http/tests/security/xssAuditor/report-script-tag-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-full-block.html:
- http/tests/security/xssAuditor/report-script-tag-replace-state-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-replace-state.html:
- http/tests/security/xssAuditor/report-script-tag.html:
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
- http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode.html:
- http/tests/security/xssAuditor/script-tag-Big5-char.html:
- http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char2.html:
- http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-control-char.html:
- http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
- http/tests/security/xssAuditor/script-tag-convoluted.html:
- http/tests/security/xssAuditor/script-tag-entities-expected.txt:
- http/tests/security/xssAuditor/script-tag-entities.html:
- http/tests/security/xssAuditor/script-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-expression-follows-expected.txt:
- http/tests/security/xssAuditor/script-tag-expression-follows.html:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag.html:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html:
- http/tests/security/xssAuditor/script-tag-near-start-expected.txt:
- http/tests/security/xssAuditor/script-tag-near-start.html:
- http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-null-char.html:
- http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
- http/tests/security/xssAuditor/script-tag-open-redirect.html:
- http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-control-char.html:
- http/tests/security/xssAuditor/script-tag-post-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-null-char.html:
- http/tests/security/xssAuditor/script-tag-post.html:
- http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
- http/tests/security/xssAuditor/script-tag-redirect.html:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair.html:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode5.html:
- http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-actual-comma.html:
- http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-callbacks.html:
- http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-comma-01.html:
- http/tests/security/xssAuditor/script-tag-with-comma-02-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-comma-02.html:
- http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html:
- http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html:
- http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding.html:
- http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-control-char.html:
- http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url.html:
- http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url2.html:
- http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url3.html:
- http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-double-quote.html:
- http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-entities.html:
- http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-no-quote.html:
- http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-null-char.html:
- http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-relative-scheme.html:
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html:
- http/tests/security/xssAuditor/script-tag-with-source-same-host.html:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-01-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-01.html:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-02-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-02.html:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-03-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-03.html:
- http/tests/security/xssAuditor/script-tag-with-source.html:
- http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode.html:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028.html:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment.html:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment5-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment5.html:
- http/tests/security/xssAuditor/script-tag.html:
- http/tests/security/xssAuditor/svg-animate-expected.txt:
- http/tests/security/xssAuditor/svg-animate.html:
- http/tests/security/xssAuditor/svg-script-tag-expected.txt:
- http/tests/security/xssAuditor/svg-script-tag.html:
- http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-big5.html:
- http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-sjis.html:
- http/tests/security/xssAuditor/xss-protection-parsing-01.html:
- http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-02.html:
- http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-03.html:
- http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-04.html:
- 2:03 PM Changeset in webkit [176412] by
-
- 8 edits in trunk/Source
Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
https://bugs.webkit.org/show_bug.cgi?id=138568
-and corresponding-
rdar://problem/18904600
Reviewed by Tim Horton.
Source/WebCore:
Add an optional parameter indicating whether or not to include images.
- WebCore.exp.in:
- editing/cocoa/HTMLConverter.h:
- editing/cocoa/HTMLConverter.mm:
(WebCore::editingAttributedStringFromRange):
Source/WebKit/mac:
Skip images for lookup.
- WebView/WebActionMenuController.mm:
(performDictionaryLookupForRange):
Source/WebKit2:
Skip images for lookup.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange):
- 1:50 PM Changeset in webkit [176411] by
-
- 6 edits in trunk/Source/WebKit2
[iOS] Add more ENABLE({TOUCH_EVENTS, IOS_TOUCH_EVENTS})-guards in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=138928
Reviewed by Simon Fraser.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
- 1:45 PM Changeset in webkit [176410] by
-
- 3 edits in trunk/Source/WebCore
Fix the !ENABLE(SVG_FONTS) build after r176276
https://bugs.webkit.org/show_bug.cgi?id=138924
Reviewed by Csaba Osztrogonác.
No new tests because there is no behavior change.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestFont):
- 1:43 PM Changeset in webkit [176409] by
-
- 2 edits6 adds in trunk/LayoutTests
[iOS] Update expected results for LayoutTests/animations
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/animations/3d/replace-filling-transform-expected.txt: Added.
- platform/ios-simulator/animations/animation-offscreen-to-onscreen-expected.txt: Added.
- platform/ios-simulator/animations/missing-values-first-keyframe-expected.txt: Added.
- platform/ios-simulator/animations/missing-values-last-keyframe-expected.txt: Added.
- platform/ios-simulator/animations/opacity-transform-animation-expected.txt: Added.
- platform/ios-simulator/animations/suspend-transform-animation-expected.txt: Added.
- 12:01 PM Changeset in webkit [176408] by
-
- 5 edits in trunk/Source/WebKit2
Add -[WKWebView loadData:MIMEType:textEncodingName:baseURL:]
https://bugs.webkit.org/show_bug.cgi?id=138929
<rdar://problem/18683802>
Reviewed by Dan Bernstein.
Also, re-implement -[WKWebView loadHTMLString:baseURL:] in terms of this newly added function
and assume a UTF-8 encoding. This matches what Legacy WebKit does.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadHTMLString:baseURL:]):
(-[WKWebView loadData:MIMEType:textEncodingName:baseURL:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadData):
- UIProcess/WebPageProxy.h:
- 11:56 AM Changeset in webkit [176407] by
-
- 3 edits3 copies in tags/Safari-601.1.10
Merged r176402. rdar://problem/19040156
- 11:12 AM Changeset in webkit [176406] by
-
- 3 edits in trunk/LayoutTests
Update media/track/track-in-band-cues-added-once.html to make failures easier to diagnose
https://bugs.webkit.org/show_bug.cgi?id=138908
Reviewed by Alexey Proskuryakov.
- media/track/track-in-band-cues-added-once.html: Update test to remove one potential
source of flakeyness and to do more logging in the event of a failure to make debugging
failures simpler.
- media/track/track-in-band-cues-added-once-expected.txt:
- 11:06 AM Changeset in webkit [176405] by
-
- 2 edits in trunk/LayoutTests
[iOS] Temporarily skip almost all DRT tests
Towards updating the expected results on iOS, temporarily skip running almost
all DRT tests on iOS. We'll subsequently un-skip tests as we land updated/new
expected results for them.
- platform/ios-simulator/TestExpectations:
- 10:50 AM Changeset in webkit [176404] by
-
- 5 edits3 moves in trunk
Rename String.prototype.contains to String.prototype.includes
https://bugs.webkit.org/show_bug.cgi?id=138923
Source/JavaScriptCore:
As per the latest TC39 meeting[1, 2], String.prototype.contains is
renamed to String.prototype.includes. This is because the name
containsbreaks the web since it conflicts with existingcontains
implementations in major libraries.
[1]: https://github.com/mathiasbynens/String.prototype.includes
[2]: https://github.com/tc39/test262/pull/119
Reviewed by Geoffrey Garen.
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
(JSC::stringProtoFuncIncludes):
(JSC::stringProtoFuncContains): Deleted.
LayoutTests:
Reviewed by Geoffrey Garen.
- js/Object-getOwnPropertyNames-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/string-includes.js: Renamed from LayoutTests/js/script-tests/string-contains.js.
(stringToSearchIn.toString):
(startOffset.valueOf):
(matchString.toString):
(endOffset.valueOf):
- js/string-includes-expected.txt: Renamed from LayoutTests/js/string-contains-expected.txt.
- js/string-includes.html: Renamed from LayoutTests/js/string-contains.html.
- 10:50 AM Changeset in webkit [176403] by
-
- 4 edits in trunk/Source/WebCore
Add a way to mute an AudioContext.
https://bugs.webkit.org/show_bug.cgi?id=138104
Reviewed by Eric Carlson.
Keep a muted state in AudioDestinationNode. If m_muted is true,
zero out the audio buffers.
No new tests, since it's difficult to test whether the audio is indeed muted.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
Call pageMutedStateDidChange() so it'll initialize the destination audio node's muted state accordingly.
(WebCore::AudioContext::pageMutedStateDidChange):
Set the destination audio node's muted state to match the page's muted state.
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
Initialize m_muted.
(WebCore::AudioDestinationNode::render):
If m_muted is true, call AudioBus::zero() to zero out the buffers.
- Modules/webaudio/AudioDestinationNode.h:
(WebCore::AudioDestinationNode::setMuted):
Set m_muted.
- 10:44 AM Changeset in webkit [176402] by
-
- 3 edits3 adds in trunk
Crash when destroying a Document that has a throttled timer still running
https://bugs.webkit.org/show_bug.cgi?id=138914
Reviewed by Benjamin Poulain.
Source/WebCore:
Upon destruction, a throttled DOMTimer whose interval depends on
viewport changes will try to unregister itself from the view. It gets
the view pointer from its Document. However, scriptExecutionContext()
can return null if the Document is being destroyed (i.e. ~DOMTimer()
is called from ~ScriptExecutionContext(), as the ScriptExecutionContext
owns the DOMTimer).
This patch adds a null check for scriptExecutionContext() in the
DOMTimer destructor to avoid this issue.
Test: fast/dom/throttled-timer-running-on-document-destruction.html
- page/DOMTimer.cpp:
(WebCore::DOMTimer::~DOMTimer):
(WebCore::DOMTimer::unregisterForViewportChanges):
Add assertion to make sure scriptExecutionContext() does not return
null.
(WebCore::DOMTimerFireState::setChangedStyleOfElementOutsideViewport): Deleted.
Killed this function as this was dead code.
LayoutTests:
Add a layout test to test the case where a Document gets destroyed while
throttled timer is still running.
- fast/dom/resources/frame-with-throttled-timer.html: Added.
- fast/dom/throttled-timer-running-on-document-destruction-expected.txt: Added.
- fast/dom/throttled-timer-running-on-document-destruction.html: Added.
- 10:11 AM Changeset in webkit [176401] by
-
- 9 edits2 adds in trunk
Simple line layout: Introduce text fragment continuation.
https://bugs.webkit.org/show_bug.cgi?id=138274
Source/WebCore:
This patch extends simple line layout coverage to multiple text renderers.
When a particular render flow has multiple text renderers (but not any other type)
then we use simple line layout to process and paint the content. -other, existing requirements still apply
so that for example if the content requires decoration, we bail out of simple line layout.
FlowContent now supports multiple renderes. It continuously reads content from sibling renderers
so that the simple line layout parser sees it as one monolithic block of content. Run positions
are all relative to the block and they get resolved to renderer's positions on demand.
(painting, computing bounding rects etc)
Reviewed by Antti Koivisto.
Performance test already been added for the multiple rendere use case,
correctness is covered by existing test cases.
Test: fast/text/simple-lines-mutliple-renderers.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor): Check if children are all 8bit RenderTexts.
(WebCore::SimpleLineLayout::removeTrailingWhitespace): Move the endofline check right before where we might overflow using end position.
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns):
(WebCore::SimpleLineLayout::splitRunsAtRendererBoundary): Split runs at renderers' boundary to be in sync with inline text renderering.
(WebCore::SimpleLineLayout::createTextRuns):
(WebCore::SimpleLineLayout::create):
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContents::textWidth): Do not measure text across renderers. It could produce different width value due to
ligature which later can produce unexpected line breaks and out sync rendering in general.
(WebCore::SimpleLineLayout::FlowContents::renderer):
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded): Read the next renderer content if needed.
(WebCore::SimpleLineLayout::FlowContents::nextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContents::runWidth):
- rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
(WebCore::SimpleLineLayout::FlowContents::isEndOfContent):
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::Run::text):
LayoutTests:
Rebaseline for simple line layout's multiple rendere support.
Reviewed by Antti Koivisto.
- fast/text/simple-lines-multiple-renderers-expected.html: Added.
- fast/text/simple-lines-multiple-renderers.html: Added.
- fast/tokenizer/script_extra_close-expected.txt: Multiple tab characters should collapse into a single whitespace. This
needs fixing in complex line layout.
- tables/mozilla/bugs/bug157890-expected.txt: no-op endofline run is added by complex inline layout
when multiple text content is injected through JS into a <pre>. This requires fixing complex line layout.
- 9:43 AM Changeset in webkit [176400] by
-
- 3 edits in trunk/Source/WebKit2
Remove alignment code from cache coders
https://bugs.webkit.org/show_bug.cgi?id=138927
Failed to land this file.
- NetworkProcess/cache/NetworkCacheCoders.cpp:
(WebKit::NetworkCacheCoder<CString>::encode):
(WebKit::NetworkCacheCoder<CString>::decode):
(WebKit::NetworkCacheCoder<String>::encode):
(WebKit::decodeStringText):
(WebKit::NetworkCacheCoder<WebCore::CertificateInfo>::encode):
(WebKit::NetworkCacheCoder<WebCore::CertificateInfo>::decode):
- NetworkProcess/cache/NetworkCacheCoders.h:
- 9:42 AM Changeset in webkit [176399] by
-
- 4 edits3 adds in trunk
WTFCrashWithSecurityImplication under SpeculativeJIT::compile() when loading a page from theblaze.com.
<https://webkit.org/b/137642>
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
In the DFG, we have a ConstantFolding phase that occurs after all LocalCSE
phases have already transpired. Hence, Identity nodes introduced in the
ConstantFolding phase will be left in the node graph. Subsequently, the
DFG code generator asserts that CSE phases have consumed all Identity nodes.
This turns out to not be true. Hence, the crash. We fix this by teaching
the DFG code generator to emit code for Identity nodes.
Unlike the DFG, the FTL does not have this issue. That is because the FTL
plan has GlobalCSE phases that come after ConstantFolding and any other
phases that can generate Identity nodes. Hence, for the FTL, it is true that
CSE will consume all Identity nodes, and the code generator should not see any
Identity nodes.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
- js/dfg-inline-identity-expected.txt: Added.
- js/dfg-inline-identity.html: Added.
- js/script-tests/dfg-inline-identity.js: Added.
(o.toKey):
(foo):
(test):
- 9:32 AM Changeset in webkit [176398] by
-
- 5 edits in trunk/Source/WebKit2
Remove alignment code from cache coders
https://bugs.webkit.org/show_bug.cgi?id=138927
Reviewed by Anders Carlsson.
Alignment code doesn't do anything useful, wastes space and produces wrong results
if the encoder and decoder buffers don't have the same 8-byte alignment.
- NetworkProcess/cache/NetworkCacheDecoder.cpp:
(WebKit::NetworkCacheDecoder::NetworkCacheDecoder):
(WebKit::NetworkCacheDecoder::bufferIsLargeEnoughToContain):
(WebKit::NetworkCacheDecoder::decodeFixedLengthData):
(WebKit::NetworkCacheDecoder::decodeNumber):
(WebKit::roundUpToAlignment): Deleted.
(WebKit::alignedBufferIsLargeEnoughToContain): Deleted.
(WebKit::NetworkCacheDecoder::alignBufferPosition): Deleted.
- NetworkProcess/cache/NetworkCacheDecoder.h:
(WebKit::NetworkCacheDecoder::currentOffset):
(WebKit::NetworkCacheDecoder::isInvalid):
(WebKit::NetworkCacheDecoder::markInvalid):
(WebKit::NetworkCacheDecoder::bufferIsLargeEnoughToContain):
- NetworkProcess/cache/NetworkCacheEncoder.cpp:
(WebKit::NetworkCacheEncoder::grow):
(WebKit::NetworkCacheEncoder::encodeFixedLengthData):
(WebKit::NetworkCacheEncoder::encodeNumber):
(WebKit::roundUpToAlignment): Deleted.
- NetworkProcess/cache/NetworkCacheEncoder.h:
- 8:33 AM Changeset in webkit [176397] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r176396.
https://bugs.webkit.org/show_bug.cgi?id=138926
revealed some WebCore::BidiResolver issue. rollout this for
now. (Requested by zalan on #webkit).
Reverted changeset:
"Simple line layout: Introduce text fragment continuation."
https://bugs.webkit.org/show_bug.cgi?id=138274
http://trac.webkit.org/changeset/176396
- 7:22 AM Changeset in webkit [176396] by
-
- 8 edits2 adds in trunk
Simple line layout: Introduce text fragment continuation.
https://bugs.webkit.org/show_bug.cgi?id=138274
Source/WebCore:
This patch extends simple line layout coverage to multiple text renderers.
When a particular render flow has multiple text renderers (but not any other type)
then we use simple line layout to process and paint the content. -other, existing requirements still apply
so that for example if the content requires decoration, we bail out of simple line layout.
FlowContent now supports multiple renderes. It continuously reads content from sibling renderers
so that the simple line layout parser sees it as one monolithic block of content. Run positions
are all relative to the block and they get resolved to renderer's positions on demand.
(painting, computing bounding rects etc)
Reviewed by Antti Koivisto.
Performance test already been added for the multiple rendere use case,
correctness is covered by existing test cases.
Test: fast/text/simple-lines-mutliple-renderers.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor): Check if children are all 8bit RenderTexts.
(WebCore::SimpleLineLayout::removeTrailingWhitespace): Move the endofline check right before where we might overflow using end position.
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns):
(WebCore::SimpleLineLayout::splitRunsAtRendererBoundary): Split runs at renderers' boundary to be in sync with inline text renderering.
(WebCore::SimpleLineLayout::createTextRuns):
(WebCore::SimpleLineLayout::create):
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContents::textWidth): Do not measure text across renderers. It could produce different width value due to
ligature which later can produce unexpected line breaks and out sync renderering in general.
(WebCore::SimpleLineLayout::FlowContents::renderer):
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded): Read the next renderer content if needed.
(WebCore::SimpleLineLayout::FlowContents::nextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContents::runWidth):
- rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
(WebCore::SimpleLineLayout::FlowContents::isEndOfContent):
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::Run::text):
LayoutTests:
Rebaseline for simple line layout's multiple rendere support.
Reviewed by Antti Koivisto.
- fast/text/simple-lines-multiple-renderers-expected.html: Added.
- fast/text/simple-lines-multiple-renderers.html: Added.
- fast/tokenizer/script_extra_close-expected.txt: Multiple tab characters should collapse into a single whitespace. This
needs fixing in complex line layout.
- tables/mozilla/bugs/bug157890-expected.txt: no-op endofline run is added by complex inline layout
when multiple text content is injected through JS into a <pre>. This requires fixing complex line layout.
- 7:20 AM Changeset in webkit [176395] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error when GStreamer is enabled.
https://bugs.webkit.org/show_bug.cgi?id=138925
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-20
Reviewed by Philippe Normand.
A guard is missing for an overridden method.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- 5:12 AM Changeset in webkit [176394] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Tools
Merge r176198 - [GTK] Add library search paths from LDFLAGS before pkg-config --libs
https://bugs.webkit.org/show_bug.cgi?id=136018
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-11-17
Reviewed by Carlos Garcia Campos.
It is possible that the order of -L arguments in the output of
pkg-config is wrong, which causes the linker to find the wrong
version (usually older version) of libraries when running
gtkdoc-scangobj.
- gtk/gtkdoc.py:
(GTKDoc._run_gtkdoc_scangobj):
- 4:46 AM Changeset in webkit [176393] by
-
- 8 edits in trunk
[GTK] Provide convenience API in DOM bindings to post messages to user message handlers
https://bugs.webkit.org/show_bug.cgi?id=138871
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-11-20
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Adds a convenience function in the WebKitGTK+ DOM bindings to post
messages to user message handlers in a way convenient way more
convenient than using the autogenerated bindings.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_dom_window_webkit_message_handlers_post_message):
Added new convenience API function to post messages to user message
handlers.
- bindings/gobject/WebKitDOMCustom.h: Ditto.
- bindings/gobject/WebKitDOMCustom.symbols: Ditto.
Tools:
Add a test case for the convenience API for posting user messages
added to the DOM bindings.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
(testUserContentManagerMessageFromConvenienceDOMBindings):
(beforeAll):
- TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
(documentLoadedCallback):
- 3:01 AM Changeset in webkit [176392] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2
Merge r175451 - REGRESSION(r163656): Remote inspector doesn't work unless preferences change after page initialization
https://bugs.webkit.org/show_bug.cgi?id=138246
Reviewed by Joseph Pecoraro.
The problem is that initializeWebPage() is still using
pageGroup().preferences() instead of m_preferences to check if
developer extras are enabled to enable remote inspection of the page.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage): Use m_preferences
instead of pageGroup().preferences().
- 2:41 AM Changeset in webkit [176391] by
-
- 7 edits in releases/WebKitGTK/webkit-2.6
Merge r175450 - REGRESSION(CMake): Make it possible to build without introspection
https://bugs.webkit.org/show_bug.cgi?id=138006
Reviewed by Philippe Normand.
.:
Add ENABLE_INTROSPECTION option.
- Source/PlatformGTK.cmake: Dot not add gir global target if
introspection is disabled.
- Source/cmake/OptionsGTK.cmake: Do not add gir individual targets if
introspection is disabled.
Source/JavaScriptCore:
Do not install introspection files when introspection is disabled.
- PlatformGTK.cmake:
Source/WebKit2:
Do not install introspection files when introspection is disabled.
- PlatformGTK.cmake:
- 1:49 AM Changeset in webkit [176390] by
-
- 9 edits in trunk/Source/WebCore
[CSS Grid Layout] Replace the usage of size_t by unsigned
https://bugs.webkit.org/show_bug.cgi?id=136218
Reviewed by Benjamin Poulain.
In general, size_t should be used for sizes of objects in
memory. We're using it to represent indexes and spans in the
grid. Now that the maximum number of tracks is 1 million, it
should be safe to replace them by unsigned integers.
No new tests as there is no change in functionality.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTrackRepeatFunction):
- css/StyleResolver.cpp:
(WebCore::createImplicitNamedGridLinesFromGridArea):
(WebCore::createGridTrackList):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::GridIterator):
(WebCore::RenderGrid::GridIterator::nextGridItem):
(WebCore::RenderGrid::GridIterator::isEmptyAreaEnough):
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
(WebCore::RenderGrid::GridSizingData::GridSizingData):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::gridTrackSize):
(WebCore::RenderGrid::distributeSpaceToTracks):
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
(WebCore::RenderGrid::ensureGridSize):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::createEmptyGridAreaAtSpecifiedPositionsOutsideGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::populateGridPositions):
- rendering/RenderGrid.h:
- rendering/style/GridCoordinate.h:
(WebCore::GridSpan::integerSpan):
- rendering/style/GridResolvedPosition.cpp:
(WebCore::GridResolvedPosition::explicitGridColumnCount):
(WebCore::GridResolvedPosition::explicitGridRowCount):
(WebCore::explicitGridSizeForSide):
(WebCore::GridResolvedPosition::resolveNamedGridLinePositionFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionAgainstOppositePosition):
(WebCore::firstNamedGridLineBeforePosition):
(WebCore::GridResolvedPosition::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition):
(WebCore::GridResolvedPosition::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
- rendering/style/GridResolvedPosition.h:
(WebCore::GridResolvedPosition::adjustGridPositionForRowEndColumnEndSide):
(WebCore::GridResolvedPosition::adjustGridPositionForSide):
(WebCore::GridResolvedPosition::GridResolvedPosition):
(WebCore::GridResolvedPosition::toInt):
- rendering/style/StyleGridData.h:
- 1:04 AM Changeset in webkit [176389] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176254 - AX: [ATK] Crash getting the orientation of a MenuListOption after the MenuList was removed from the document
https://bugs.webkit.org/show_bug.cgi?id=138727
Reviewed by Chris Fleizach.
Source/WebCore:
AccessibilityMenuListOption::elementRect() returns the value of the
grandparent MenuList, asserting that the grandparent exists with that
role. But it is possible to have an existing MenuListOption and remove
the element which had been backing that MenuList from the document.
Adding null checks prior to the assertions prevents our crashing if the
parent or grandparent was removed.
Test: platform/gtk/accessibility/combobox-descendants-orientation-crash.html
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::elementRect):
LayoutTests:
- platform/gtk/accessibility/combobox-descendants-orientation-crash-expected.txt: Added.
- platform/gtk/accessibility/combobox-descendants-orientation-crash.html: Added.
- 12:43 AM Changeset in webkit [176388] by
-
- 6 edits in trunk/Source/WebCore
Remove "document has no sibling rules" optimization.
<https://webkit.org/b/138902>
Reviewed by Antti Koivisto.
We were keeping a document-level flag to track whether there are any
sibling rules in any active style sheets.
This information was used to do.. nothing.
- css/StyleResolver.h:
(WebCore::StyleResolver::usesSiblingRules): Deleted.
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
- dom/DocumentStyleSheetCollection.h:
(WebCore::DocumentStyleSheetCollection::usesSiblingRules): Deleted.
(WebCore::DocumentStyleSheetCollection::setUsesSiblingRulesOverride): Deleted.
- mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedInto): Deleted.
- mathml/MathMLMathElement.h:
- 12:36 AM Changeset in webkit [176387] by
-
- 7 edits in trunk/Source/WebCore
Caret renderer is always a RenderBlock.
<https://webkit.org/b/138912>
Reviewed by Chris Dumez.
Tighten typing in the code that finds and deals with the renderer
used to paint the caret (it's always a RenderBlock.)
- editing/FrameSelection.cpp:
(WebCore::CaretBase::updateCaretRect):
(WebCore::FrameSelection::caretRendererWithoutUpdatingLayout):
(WebCore::DragCaretController::caretRenderer):
(WebCore::repaintCaretForLocalRect):
(WebCore::CaretBase::paintCaret):
- editing/FrameSelection.h:
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::absoluteCaretBounds):
- editing/htmlediting.cpp:
(WebCore::rendererForCaretPainting):
(WebCore::localCaretRectInRendererForCaretPainting):
(WebCore::absoluteBoundsForLocalCaretRect):
- editing/htmlediting.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintCaret):
- 12:33 AM Changeset in webkit [176386] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2
Merge r176316 - [GTK] Error in documentation of webkit_print_operation_get_page_setup()
https://bugs.webkit.org/show_bug.cgi?id=138868
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-11-19
Reviewed by Carlos Garcia Campos.
Fix copypaste error in documentation of
webkit_print_operation_get_page_setup().
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
- 12:29 AM Changeset in webkit [176385] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] URTBF after r176363.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setTextIndicator):
- UIProcess/API/gtk/PageClientImpl.h:
- 12:23 AM Changeset in webkit [176384] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r172854): Web Viewer in FileMaker does not render a Base64 encoded animated-GIF
https://bugs.webkit.org/show_bug.cgi?id=138807
<rdar://problem/18829540>
Reviewed by Simon Fraser.
Animation gets paused because WebKit thinks the GIF is outside of the view.
- page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
We need to convert to window coordinates in paintsEntireContents mode too so these functions are consistent.
This matters with some WK1 API clients.
Nov 19, 2014:
- 11:42 PM Changeset in webkit [176383] by
-
- 4 edits in trunk/Source/WebCore
Move 'clip' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138909
Reviewed by Andreas Kling.
Move 'clip' CSS property from DeprecatedStyleBuilder to the new
StyleBuilder by using custom code.
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyClip::convertToLength): Deleted.
(WebCore::ApplyPropertyClip::applyInheritValue): Deleted.
(WebCore::ApplyPropertyClip::applyInitialValue): Deleted.
(WebCore::ApplyPropertyClip::applyValue): Deleted.
(WebCore::ApplyPropertyClip::createHandler): Deleted.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderFunctions::applyInitialClip):
(WebCore::StyleBuilderFunctions::applyInheritClip):
(WebCore::StyleBuilderFunctions::applyValueClip):
- 9:45 PM Changeset in webkit [176382] by
-
- 4 edits in trunk/Source/WebKit2
Don't track sub-resources that are started after main frame progress has completed.
https://bugs.webkit.org/show_bug.cgi?id=138582
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-11-19
Reviewed by Sam Weinig.
After main frame progress has finished, starting loading a sub-resource shouldn't affect
UI process's view of page loading status (i.e., the page has already completed loading
and the progress shouldn't change). To achive that, don't track the subresources that
are started after the main frame has finished, except for those triggered by user interaction.
- WebProcess/WebCoreSupport/WebProgressTrackerClient.cpp: Notify WebPage that the main frame progress
has started or finished.
(WebKit::WebProgressTrackerClient::progressStarted):
(WebKit::WebProgressTrackerClient::progressFinished):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::addResourceRequest): Don't track the resource request if it is initiated after
the main frame is loaded and it is not triggered by user interaction.
(WebKit::WebPage::removeResourceRequest):
- WebProcess/WebPage/WebPage.h: Rename m_networkResourceRequestIdentifiers to m_trackedNetworkResourceRequestIdentifiers.
(WebKit::WebPage::setMainFrameProgressCompleted):
- 9:35 PM Changeset in webkit [176381] by
-
- 3 edits in trunk/Source/WebCore
Remove dead code from TiledBackingStore
https://bugs.webkit.org/show_bug.cgi?id=138864
Reviewed by Andreas Kling.
Since r168151, paint() method, m_commitTileUpdatesOnIdleEventLoop and related code are not used.
No new tests, no behavior change.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setTileSize):
(WebCore::TiledBackingStore::invalidate):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::paint): Deleted.
(WebCore::TiledBackingStore::startTileBufferUpdateTimer): Deleted.
(WebCore::TiledBackingStore::tileBufferUpdateTimerFired): Deleted.
(WebCore::TiledBackingStore::startBackingStoreUpdateTimer): Deleted.
(WebCore::TiledBackingStore::backingStoreUpdateTimerFired): Deleted.
- platform/graphics/TiledBackingStore.h:
(WebCore::TiledBackingStore::setCommitTileUpdatesOnIdleEventLoop): Deleted.
- 8:40 PM Changeset in webkit [176380] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r176374. rdar://problem/18840128
- 8:37 PM Changeset in webkit [176379] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r176374. rdar://problem/18840128
- 8:28 PM Changeset in webkit [176378] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Fix typos in r176203.
- public/v2/app.js:
(App.ChartsController.actions.addPaneByMetricAndPlatform):
(App.AnalysisTaskRoute):
- 8:27 PM Changeset in webkit [176377] by
-
- 24 edits1 copy in branches/safari-600.3-branch/Source
Merge r176363. rdar://problem/18840128
- 6:19 PM Changeset in webkit [176376] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: LayoutTests/inspector should not have localStorage side effects
https://bugs.webkit.org/show_bug.cgi?id=138895
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-19
Reviewed by Brian Burg.
When running inspector tests, do not restore/save WebInspector.Settings
to localStorage, as that will cause side effects. Instead each Setting
will be initialized with its default value and can be modified during
the run of the test.
- UserInterface/Base/Test.js:
(WebInspector.loaded):
Name the setting to match the normal setting name now that persistence
is not an issue.
- UserInterface/Models/Setting.js:
(WebInspector.Setting.prototype.get value):
(WebInspector.Setting.prototype.set value):
Do not restore/save when in tests.
- 6:03 PM Changeset in webkit [176375] by
-
- 3 edits in trunk/Source/WebKit2
[EFL] Fix build failure since r176363.
https://bugs.webkit.org/show_bug.cgi?id=138903
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2014-11-19
Reviewed by Gyuyoung Kim.
The parameter for animation on setTextIndicator() was removed on 'PageClient' class.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::setTextIndicator):
- UIProcess/CoordinatedGraphics/WebView.h:
- 5:55 PM Changeset in webkit [176374] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the iOS build
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupForRange):
- 5:36 PM Changeset in webkit [176373] by
-
- 9 edits in trunk/Source/WebCore
Remove "document has no ::before and/or ::after rules" optimization.
<https://webkit.org/b/138897>
Reviewed by Antti Koivisto.
This optimization has been dead for a long time, since the default UA
style contains both ::before and ::after rules.
- css/RuleFeature.cpp:
(WebCore::recursivelyCollectFeaturesFromSelector):
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):
- css/RuleFeature.h:
(WebCore::RuleFeatureSet::RuleFeatureSet):
- css/StyleResolver.h:
(WebCore::StyleResolver::usesBeforeAfterRules): Deleted.
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
- dom/DocumentStyleSheetCollection.h:
(WebCore::DocumentStyleSheetCollection::usesBeforeAfterRules): Deleted.
(WebCore::DocumentStyleSheetCollection::setUsesBeforeAfterRulesOverride): Deleted.
- html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::insertedInto): Deleted.
- html/HTMLQuoteElement.h:
- style/StyleResolveTree.cpp:
(WebCore::Style::needsPseudoElement):
- 5:35 PM Changeset in webkit [176372] by
-
- 4 edits3 adds in trunk
[OS X] Upright vertical text is completely broken for multi-code-unit codepoints
https://bugs.webkit.org/show_bug.cgi?id=138891
Reviewed by Dan Bernstein.
Source/WebCore:
We were assuming that we can use the string index (in UTF-16) as the glyph
index. This falls down when a single codepoint (and glyph) contians
multiple code units.
Test: platform/mac/fast/text/multiple-codeunit-vertical-upright.html
- platform/graphics/GlyphPage.h:
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::GlyphPage::fill):
LayoutTests:
Make sure a single upright vertical multi-code-unit codepoint is rendered the same as
the same codepoint rendered horizontally.
- platform/mac/fast/text/multiple-codeunit-vertical-upright-expected.html: Added.
- platform/mac/fast/text/multiple-codeunit-vertical-upright.html: Added.
- platform/mac/fast/text/resources/multiple-codeunit-vertical-upright.otf: Added.
- 5:23 PM Changeset in webkit [176371] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Apple Internal Mavericks build after <https://trac.webkit.org/changeset/176347>
(https://bugs.webkit.org/show_bug.cgi?id=136863)
Define enumerator NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain when building without
the Apple Internal SDK or with the Apple Internal SDK on OS X Mavericks or earlier.
- platform/spi/cf/CFNetworkSPI.h:
- 5:16 PM Changeset in webkit [176370] by
-
- 2 edits in trunk/Source/WebKit2
Fix the 32-bit build
- UIProcess/mac/TextIndicatorWindow.mm:
(WebKit::TextIndicatorWindow::setTextIndicator):
- 5:02 PM Changeset in webkit [176369] by
-
- 7 edits1 copy1 add in trunk
Move the 'quotes' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138788
Reviewed by Chris Dumez.
Source/WebCore:
Test: fast/css/content/content-quotes-07.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
Fix the parser to only accept none as a valid primitive identifier. Tested in
the newly added content-quotes-07.html.
- css/CSSPropertyNames.in:
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertQuotes):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Move "quotes" to the new style builder.
- rendering/style/RenderStyle.h:
Add an initialQuotes() function for use in the auto-generated style builder.
LayoutTests:
Add a test for the behavior of non-valid primitive identifiers being
used with the quotes property.
- fast/css/content/content-quotes-07-expected.txt: Added.
- fast/css/content/content-quotes-07.html: Added.
- 4:59 PM Changeset in webkit [176368] by
-
- 4 edits4 adds in trunk
Handle unprefixed @keyframes rule
https://bugs.webkit.org/show_bug.cgi?id=138899
<rdar://problem/18943117>
Reviewed by Simon Fraser.
Source/WebCore:
Support the parsing of unprefixed @keyframes. In
CSSParser, assign the same token identifier to
the prefixed and unprefixed forms. This will
keep compatibility with older content. If a page
has both forms, then whatever comes last will
win (as it does if you had duplicate names of the same
form).
Tests: animations/unprefixed-keyframes-rule.html
animations/unprefixed-keyframes.html
- css/CSSGrammar.y.in: Rename the WEBKIT_KEYFRAME_RULE_SYM symbol to
be KEYFRAME_RULE_SYM. Same with KEYFRAMES_SYM.
- css/CSSParser.cpp:
(WebCore::CSSParser::detectAtToken): Look for the @keyframes style
strings and assign the new token values.
LayoutTests:
Tests for @keyframes, both the OM side and the parsing.
- animations/unprefixed-keyframes-expected.txt: Added.
- animations/unprefixed-keyframes-rule-expected.txt: Added.
- animations/unprefixed-keyframes-rule.html: Added.
- animations/unprefixed-keyframes.html: Added.
- 4:34 PM Changeset in webkit [176367] by
-
- 4 edits in branches/safari-600.3-branch/Source
Merge r176356. rdar://problem/18996776
- 4:28 PM Changeset in webkit [176366] by
-
- 4 edits in branches/safari-600.3-branch/Source
Merge r176351. rdar://problem/18971616
- 4:17 PM Changeset in webkit [176365] by
-
- 9 edits in trunk/Source/WebCore
Move pseudo-style code from RenderObject to RenderElement.
<https://webkit.org/b/138880>
Reviewed by Antti Koivisto.
Migrate get*PseudoStyle() to RenderElement, and the selection color
functions along with them. This gets rid of a DOM ancestor walk in
pseudo style lookup.
Narrow down some argument types to keep things building.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::styleForFirstLetter):
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
- rendering/RenderBlock.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::getCachedPseudoStyle):
(WebCore::RenderElement::getUncachedPseudoStyle):
(WebCore::RenderElement::selectionColor):
(WebCore::RenderElement::selectionPseudoStyle):
(WebCore::RenderElement::selectionForegroundColor):
(WebCore::RenderElement::selectionEmphasisMarkColor):
(WebCore::RenderElement::selectionBackgroundColor):
- rendering/RenderElement.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionBackgroundColor): Deleted.
(WebCore::RenderObject::selectionColor): Deleted.
(WebCore::RenderObject::selectionPseudoStyle): Deleted.
(WebCore::RenderObject::selectionForegroundColor): Deleted.
(WebCore::RenderObject::selectionEmphasisMarkColor): Deleted.
(WebCore::RenderObject::getCachedPseudoStyle): Deleted.
(WebCore::RenderObject::getUncachedPseudoStyle): Deleted.
- rendering/RenderObject.h:
- rendering/RenderText.h:
(WebCore::RenderText::getCachedPseudoStyle):
(WebCore::RenderText::selectionBackgroundColor):
(WebCore::RenderText::selectionForegroundColor):
(WebCore::RenderText::selectionEmphasisMarkColor):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):
- 4:14 PM Changeset in webkit [176364] by
-
- 9 edits in tags/Safari-601.1.10/Source/WebKit2
Merged r176337. rdar://problem/18964359
- 4:10 PM Changeset in webkit [176363] by
-
- 23 edits in trunk/Source
Add an optional entry transition (from selection highlight) to TextIndicator
https://bugs.webkit.org/show_bug.cgi?id=138856
<rdar://problem/18840128>
Reviewed by Anders Carlsson.
- Shared/TextIndicator.cpp:
(WebKit::outsetIndicatorRectIncludingShadow):
(WebKit::TextIndicator::createWithRange):
(WebKit::snapshotSelectionWithHighlight):
(WebKit::TextIndicator::createWithSelectionInFrame):
(WebKit::TextIndicator::frameRect):
(WebKit::TextIndicator::Data::encode):
(WebKit::TextIndicator::Data::decode):
Remove TextIndicator::draw and related functions; drawing is handled entirely
by the TextIndicatorWindow now, and TextIndicator just stores the required data.
Unify outsetIndicatorRectIncludingShadow.
Add an argument to createWithRange/createWithSelectionInFrame to indicate
if the TextIndicator should transition from the selection highlight to
the yellow bubble.
If we're doing the transition, paint the selection into a second bitmap,
without forcing the text to black and without hiding the blue highlight.
Encode/decode the second bitmap.
- Shared/TextIndicator.h:
- UIProcess/mac/TextIndicatorWindow.h:
- UIProcess/mac/TextIndicatorWindow.mm:
(-[WKTextIndicatorView initWithFrame:textIndicator:margin:transitionFromSelectionColor:]):
(-[WKTextIndicatorView presentWithCompletionHandler:]):
(-[WKTextIndicatorView hideWithCompletionHandler:]):
(-[WKTextIndicatorView isFlipped]):
(WebKit::TextIndicatorWindow::TextIndicatorWindow):
(WebKit::TextIndicatorWindow::setTextIndicator):
(WebKit::TextIndicatorWindow::closeWindow):
(WebKit::TextIndicatorWindow::startFadeOutTimerFired):
Re-implement the bounce animation using CoreAnimation instead of
the WKSI-based WKWindowBounceAnimation*.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupOfCurrentSelection):
(WebKit::WebPage::performDictionaryLookupForRange):
(WebKit::WebPage::performActionMenuHitTestAtLocation):
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
Use the aforementioned transition animation for performDictionaryLookupOfCurrentSelection,
the context menu lookup item, and for Data Detectors.
- WebCore.exp.in:
Add an export.
- platform/spi/cocoa/QuartzCoreSPI.h:
Add some SPI.
- 4:02 PM Changeset in webkit [176362] by
-
- 5 edits1 add in trunk/Source/WebKit2
Add a version of API::Data::createWithoutCopying that takes an NSData
https://bugs.webkit.org/show_bug.cgi?id=138893
Reviewed by Dan Bernstein.
- Shared/APIData.h:
- Shared/Cocoa/APIDataCocoa.mm: Added.
(API::Data::createWithoutCopying):
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
(releaseNSData): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):
- 3:58 PM Changeset in webkit [176361] by
-
- 2 edits in trunk/Tools
Work around the fact that different masters may have different names for their codebases.
https://bugs.webkit.org/show_bug.cgi?id=138878
Reviewed by Mark Rowe.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(parseRevisionProperty): Changed.
Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
opensource / internal codebase naming convention.
- 3:55 PM Changeset in webkit [176360] by
-
- 5 edits in branches/safari-600.2-branch/Source
Versioning.
- 3:53 PM Changeset in webkit [176359] by
-
- 4 edits in trunk/Source/WebCore
Move 'outline-style' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138882
Reviewed by Sam Weinig.
Move 'outline-style' CSS property from DeprecatedStyleBuilder to the
new StyleBuilder by using custom code.
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyDefault::setValue): Deleted.
(WebCore::ApplyPropertyDefault::applyValue): Deleted.
(WebCore::ApplyPropertyDefault::createHandler): Deleted.
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue): Deleted.
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue): Deleted.
(WebCore::ApplyPropertyOutlineStyle::applyValue): Deleted.
(WebCore::ApplyPropertyOutlineStyle::createHandler): Deleted.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderFunctions::applyInheritOutlineStyle):
(WebCore::StyleBuilderFunctions::applyInitialOutlineStyle):
(WebCore::StyleBuilderFunctions::applyValueOutlineStyle):
- 3:49 PM Changeset in webkit [176358] by
-
- 14 edits1 move2 adds in trunk
Web Inspector: JSContext inspection Resource search does not work
https://bugs.webkit.org/show_bug.cgi?id=131252
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::searchInContent):
- inspector/protocol/Debugger.json:
Do some cleanup of the description and implementation of content searching.
Source/WebCore:
Test: inspector/debugger/search-scripts.html
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::searchInResources):
A little cleanup.
Source/WebInspectorUI:
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.performSearch.resourceCallback):
(WebInspector.ResourceSidebarPanel.prototype.performSearch.resourcesCallback):
Cleanup by reordering things a bit.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
(WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts):
(WebInspector.ResourceSidebarPanel.prototype.performSearch):
Search non-resource scripts individually.
(WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForScript):
Lazily create a ScriptTreeElement for the search tree outline as needed.
(WebInspector.ResourceSidebarPanel.prototype._scriptsToSearch):
When searching scripts, just perform a shallow walk of the tree outline to find
Script resources that are not also Resources. Scripts are always guarenteed to
be in a folder when inspecting a web resource. For JSContext inspection, scripts
are promoted to the top level.
- UserInterface/Main.html:
- UserInterface/Models/SourceCodeSearchMatchObject.js: Renamed from Source/WebInspectorUI/UserInterface/Models/ResourceSearchMatchObject.js.
(WebInspector.SourceCodeSearchMatchObject):
- UserInterface/Views/SearchIcons.css:
(.source-code-match-icon .icon):
(.resource-match-icon .icon): Deleted.
- UserInterface/Views/SearchResultTreeElement.js:
(WebInspector.SearchResultTreeElement):
Rename ResourceSearchMatchObject to SourceCodeSearchMatchObject.
LayoutTests:
- inspector/debugger/search-scripts-expected.txt: Added.
- inspector/debugger/search-scripts.html: Added.
Tests for Debugger.searchInContent.
- 3:49 PM Changeset in webkit [176357] by
-
- 19 edits5 adds in trunk
Web Inspector: Provide $exception in the console for the thrown exception value
https://bugs.webkit.org/show_bug.cgi?id=138726
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::caughtValue):
- debugger/DebuggerScope.h:
Access the caught value if this scope is a catch scope.
- runtime/JSNameScope.h:
(JSC::JSNameScope::isFunctionNameScope):
(JSC::JSNameScope::isCatchScope):
(JSC::JSNameScope::value):
Provide an accessor for the single value in the JSNameScope (with / catch block).
- inspector/InjectedScriptSource.js:
Save the exception value and expose it via $exception. Since the command line api
is recreated on each evaluation, $exception is essentially readonly.
- inspector/ScriptDebugServer.h:
- inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::dispatchDidPause):
(Inspector::ScriptDebugServer::exceptionOrCaughtValue):
When pausing, get the exception or caught value. The exception will be provided
if we are breaking on an explicit exception. When inside of a catch block, we
can get the caught value by walking up the scope chain.
- inspector/agents/InspectorDebuggerAgent.h:
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::InspectorDebuggerAgent):
(Inspector::InspectorDebuggerAgent::resume):
(Inspector::InspectorDebuggerAgent::stepOver):
(Inspector::InspectorDebuggerAgent::stepInto):
(Inspector::InspectorDebuggerAgent::stepOut):
Clearing state can be done in didContinue.
(Inspector::InspectorDebuggerAgent::didPause):
Set the exception value explicitly in the injected script when we have it.
(Inspector::InspectorDebuggerAgent::didContinue):
Clear state saved when we had paused, including clearly an exception value if needed.
(Inspector::InspectorDebuggerAgent::clearDebuggerBreakpointState):
(Inspector::InspectorDebuggerAgent::clearExceptionValue):
Call into the injected script only when needed.
- inspector/InjectedScript.cpp:
(Inspector::InjectedScript::setExceptionValue):
(Inspector::InjectedScript::clearExceptionValue):
- inspector/InjectedScript.h:
- inspector/InjectedScriptManager.cpp:
(Inspector::InjectedScriptManager::clearExceptionValue):
- inspector/InjectedScriptManager.h:
Clear on all injected scripts.
Source/WebCore:
Tests: inspector/debugger/command-line-api-exception-nested-catch.html
inspector/debugger/command-line-api-exception.html
- inspector/CommandLineAPIModuleSource.js:
Expose $exception in the more complete command line API.
Source/WebInspectorUI:
- UserInterface/Base/Test.js:
(WebInspector.loaded):
In order to use RuntimeManager to execute in the global context or on the
active debugger call frame, we need to expose the quickConsole controller.
- UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
Expose $exception to completion when we paused because of an exception.
LayoutTests:
Provide some tests to ensure $exception is the value we expect at different times,
such as on the exception line, when there is no exception, or when stepping through
catch blocks (it should always be the most recent caught exception).
- inspector/debugger/command-line-api-exception-expected.txt: Added.
- inspector/debugger/command-line-api-exception-nested-catch-expected.txt: Added.
- inspector/debugger/command-line-api-exception-nested-catch.html: Added.
- inspector/debugger/command-line-api-exception.html: Added.
- inspector/debugger/resources/exceptions.js: Added.
(triggerUncaughtTypeException):
(triggerUncaughtReferenceException):
(triggerUncaughtSyntaxException):
(triggerUncaughtDOMException):
(throwString):
(throwNumber):
(throwNull):
(throwObject):
(throwNode):
(catcher):
(nestedCatchBlocks):
- 3:48 PM Changeset in webkit [176356] by
-
- 4 edits in trunk/Source
Invoking an action menu on a selection should result in the text menu
https://bugs.webkit.org/show_bug.cgi?id=138892
-and corresponding-
rdar://problem/18996776
Reviewed by Tim Horton.
Source/WebKit/mac:
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItems]):
Source/WebKit2:
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItems]):
- 3:43 PM Changeset in webkit [176355] by
-
- 2 edits in trunk/Source/WebKit2
Fix iOS build.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
- 3:40 PM Changeset in webkit [176354] by
-
- 5 edits9 adds in trunk
Images/replaced elements that are as tall as a page should be on their own page
https://bugs.webkit.org/show_bug.cgi?id=138886 - <rdar://problem/18296371>
Reviewed by Dean Jackson.
Source/WebCore:
Added fast/multicol/tall-image-behavior.html (and RL/LR variants)
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeReplacedAndTextLineTopAndBottom):
- rendering/InlineFlowBox.h:
Add a new method that computes the line top and line bottom ignoring all margins,
overflow and line-height. This allows us to see if a line that is taller than a page
can be made to fit if we ignored margins and unused descent.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
Call the new helper function, computeReplacedAndTextLineTopAndBottom and push
to a new page if we see that we can fit on a page by ourselves without blank space
included.
LayoutTests:
- fast/multicol/tall-image-behavior-lr.html: Added.
- fast/multicol/tall-image-behavior-rl.html: Added.
- fast/multicol/tall-image-behavior.html: Added.
- platform/mac/fast/multicol/tall-image-behavior-expected.png: Added.
- platform/mac/fast/multicol/tall-image-behavior-expected.txt: Added.
- platform/mac/fast/multicol/tall-image-behavior-lr-expected.png: Added.
- platform/mac/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
- platform/mac/fast/multicol/tall-image-behavior-rl-expected.png: Added.
- platform/mac/fast/multicol/tall-image-behavior-rl-expected.txt: Added.
- 3:36 PM Changeset in webkit [176353] by
-
- 1 copy in tags/Safari-600.2.3
New tag.
- 3:03 PM Changeset in webkit [176352] by
-
- 2 edits2 moves in trunk/Source/WebKit2
Rename two Cocoa-only .cpp files to .mm.
Rubber-stamped by Sam Weinig.
- Shared/APIWebArchive.mm: Renamed from Source/WebKit2/Shared/APIWebArchive.cpp.
- Shared/APIWebArchiveResource.mm: Renamed from Source/WebKit2/Shared/APIWebArchiveResource.cpp.
- WebKit2.xcodeproj/project.pbxproj:
- 3:00 PM Changeset in webkit [176351] by
-
- 4 edits in trunk/Source
Data detected results with no menu items should not fall through to regular text
action menus
https://bugs.webkit.org/show_bug.cgi?id=138887
-and corresponding-
rdar://problem/18971616
Reviewed by Tim Horton.
Source/WebKit/mac:
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItems]):
Source/WebKit2:
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItems]):
- 2:58 PM Changeset in webkit [176350] by
-
- 16 edits2 adds in trunk
Take Web Audio into account for the Page::isPlayingAudio() API.
https://bugs.webkit.org/show_bug.cgi?id=137464
Reviewed by Jer Noble.
Source/WebCore:
Make AudioContext a subclass of AudioProducer. It figures out whether there's
audio playing by checking whether its AudioDestinationNode is playing (and not
silent). It calls Document::updateIsPlayingAudio() whenever its audio playing
state has changed.
Test: webaudio/web-audio-is-playing.html
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::lazyInitialize):
Add itself to the Document's list of AudioProducers if it's not an offline
audio context.
(WebCore::AudioContext::uninitialize):
Remove itself from the Document's list of AudioProducers if it's not an offline
audio context.
(WebCore::AudioContext::stop):
Tell the document to update its audio playing state.
(WebCore::AudioContext::isPlayingAudio):
Return true if the audio context hasn't been stopped and its destination node is
playing audio.
(WebCore::AudioContext::pageMutedStateDidChange):
Add a FIXME for now.
(WebCore::AudioContext::isPlayingAudioDidChange):
Call Document::updateIsPlayingAudio().
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
Initialize m_isSilent and m_isEffectivelyPlayingAudio.
(WebCore::AudioDestinationNode::render):
Call setIsSilent() with the appropriate value after rendering.
(WebCore::AudioDestinationNode::isPlayingDidChange):
Call updateIsEffectivelyPlayingAudio().
(WebCore::AudioDestinationNode::setIsSilent):
If m_isSilent has changed, call updateIsEffectivelyPlayingAudio().
(WebCore::AudioDestinationNode::updateIsEffectivelyPlayingAudio):
If m_isEffectivelyPlayingAudio has changed, call AudioContext::isPlayingAudioDidChange().
- Modules/webaudio/AudioDestinationNode.h:
(WebCore::AudioDestinationNode::isPlaying):
(WebCore::AudioDestinationNode::isPlayingAudio):
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::isPlaying):
Return whether the AudioDestination is playing.
- Modules/webaudio/DefaultAudioDestinationNode.h:
- platform/audio/AudioIOCallback.h:
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::start):
Call setIsPlaying() instead.
(WebCore::AudioDestinationIOS::stop):
Ditto.
(WebCore::AudioDestinationIOS::setIsPlaying):
If m_isPlaying has changed, call AudioIOCallback::isPlayingDidChange().
- platform/audio/ios/AudioDestinationIOS.h:
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestinationMac::start):
Call setIsPlaying() instead.
(WebCore::AudioDestinationMac::stop):
Ditto.
(WebCore::AudioDestinationMac::setIsPlaying):
If m_isPlaying has changed, call AudioIOCallback::isPlayingDidChange().
- platform/audio/mac/AudioDestinationMac.h:
- testing/Internals.cpp:
(WebCore::Internals::isPagePlayingAudio):
- testing/Internals.h:
- testing/Internals.idl:
Add internals.isPagePlayingAudio() for testing.
LayoutTests:
This test checks that Page::isPlayingAudio() returns false before an audio context is created
and before the oscillator node makes a sound. It then starts the oscillator node and checks
that Page::isPlayingAudio() later returns true.
- webaudio/web-audio-is-playing-expected.txt: Added.
- webaudio/web-audio-is-playing.html: Added.
- 2:51 PM Changeset in webkit [176349] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Apple Internal Mountain Lion build after <https://trac.webkit.org/changeset/176347>
(https://bugs.webkit.org/show_bug.cgi?id=136863)
Only import header CFNSURLConnection.h when building for iOS or OS X Yosemite.
- platform/spi/cf/CFNetworkSPI.h:
- 2:40 PM Changeset in webkit [176348] by
-
- 2 edits in trunk/Source/WebCore
Fix TilesAdded bitmask
https://bugs.webkit.org/show_bug.cgi?id=138883
Reviewed by Simon Fraser.
Simon spotted this.
- platform/graphics/ca/GraphicsLayerCA.h:
Use 1LLU << 29 instead of 1LLU < 29
This worked before by pure luck as bit 0 is unused.
- 2:32 PM Changeset in webkit [176347] by
-
- 24 edits4 adds1 delete in trunk/Source
[iOS] Make WebKit build with public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=136863
Reviewed by David Kilzer.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Add private headers CFNetworkSPI.h and
NS{CalendarDate, String, URLDownload}SPI.h.
- loader/cocoa/DiskCacheMonitorCocoa.mm: Move forward declaration of
CFNetwork data types and functions from here to file CFNetworkSPI.h and
include header CFNetworkSPI.h.
- platform/network/mac/ResourceHandleMac.mm: Substitute CFNetworkSPI.h for
CFURLRequestSPI.h as the content of the latter was incorporated into the former.
- platform/spi/cf/CFNetworkSPI.h: Added.
- platform/spi/cf/CFURLRequestSPI.h: Removed; incorporated its functionality
into CFNetworkSPI.h
- platform/spi/cocoa/NSCalendarDateSPI.h: Added.
- platform/spi/cocoa/NSStringSPI.h: Added.
- platform/spi/cocoa/NSURLDownloadSPI.h: Added.
Source/WebKit/ios:
- Misc/WebGeolocationCoreLocationProvider.mm: Remove unnecessary include of header <CoreLocation/CoreLocationPriv.h>.
- Misc/WebNSStringExtrasIOS.m: Substitute header <WebCore/NSStringSPI.h> for <Foundation/NSString_NSURLExtras.h>.
- Misc/WebUIKitSupport.mm: Remove unnecessary include of header CoreFoundation/CFPriv.h.
Source/WebKit/mac:
- History/WebHistory.mm: Include header NSCalendarDateSPI.h.
- History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
- Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.
We use has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
may be used by Apple internal clients that do not include wtf/Platform.h.
- Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including
private Foundation headers directly.
- Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
- WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h
instead of including private CFNetwork headers directly. Also fixed up style and
ordering of header include directives.
- WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private
CFNetwork headers directly. Also sort the #import directives.
- WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined
and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.
Source/WebKit2:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm: Moved CFNetwork forward declarations
from this file to file CFNetworkSPI.h and included header CFNetworkSPI.h.
- NetworkProcess/mac/NetworkDiskCacheMonitor.mm: Ditto.
- NetworkProcess/mac/NetworkResourceLoaderMac.mm: Ditto.
- UIProcess/API/Cocoa/WKProcessPool.mm: Ditto.
- UIProcess/mac/WebContextMac.mm: Ditto.
- WebProcess/cocoa/WebProcessCocoa.mm: Ditto.
- 2:24 PM Changeset in webkit [176346] by
-
- 4 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r176299. rdar://problem/19024541
- 2:20 PM Changeset in webkit [176345] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merge r176296. rdar://problem/18912505
- 2:14 PM Changeset in webkit [176344] by
-
- 7 edits in branches/safari-600.3-branch/Source
Merge r176288. rdar://problem/18840382
- 2:12 PM Changeset in webkit [176343] by
-
- 2 edits in trunk/Tools
AX: Screen braille input doesn't work on forms.
https://bugs.webkit.org/show_bug.cgi?id=138804
Unreviewed build fix.
- DumpRenderTree/AccessibilityUIElement.cpp:
(AccessibilityUIElement::setValue):
- 2:10 PM Changeset in webkit [176342] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r176238. rdar://problem/18990674
- 2:07 PM Changeset in webkit [176341] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r176237. rdar://problem/18900839
- 2:07 PM Changeset in webkit [176340] by
-
- 5 edits in trunk/Source/WebKit2
Add APIs for customizing the user agent
https://bugs.webkit.org/show_bug.cgi?id=138881
rdar://problem/17233981
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView customUserAgent]):
(-[WKWebView setCustomUserAgent:]):
(-[WKWebView _customUserAgent]):
(-[WKWebView _setCustomUserAgent:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(LazyInitialized::set):
(-[WKWebViewConfiguration copyWithZone:]):
(defaultApplicationNameForUserAgent):
(-[WKWebViewConfiguration applicationNameForUserAgent]):
(-[WKWebViewConfiguration setApplicationNameForUserAgent:]):
- 2:05 PM Changeset in webkit [176339] by
-
- 2 edits in trunk/Source/WebKit2
[WK2 UI-side compositing] Initialize RemoteLayerTreeTransaction properties which are unset on Mac
https://bugs.webkit.org/show_bug.cgi?id=138877
Reviewed by Tim Horton.
These data members are unused on Mac, but still encoded, so initialize them with
reasonable values.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::RemoteLayerTreeTransaction):
- 2:03 PM Changeset in webkit [176338] by
-
- 9 edits in branches/safari-600.3-branch/Source
Merge r176221. rdar://problem/18991369
- 1:57 PM Changeset in webkit [176337] by
-
- 9 edits in trunk/Source/WebKit2
Refactor iOS selection gestures.
https://bugs.webkit.org/show_bug.cgi?id=138720
rdar://problem/18964359
Reviewed by Benjamin Poulain.
This is a first step towards refactoring the selection gestures code.
It introduces more general selection movement functions that can be used to build
the gestures.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(toWKTextGranularity):
(toWKSelectionDirection):
(-[WKContentView selectPositionAtPoint:completionHandler:]):
(-[WKContentView selectPositionAtBoundary:inDirection:fromPoint:completionHandler:]):
(-[WKContentView selectTextWithGranularity:atPoint:completionHandler:]):
(-[WKContentView beginSelectionInDirection:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:completionHandler:]):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::selectTextWithGranularityAtPoint):
(WebKit::WebPageProxy::selectPositionAtBoundaryWithDirection):
(WebKit::WebPageProxy::selectPositionAtPoint):
(WebKit::WebPageProxy::beginSelectionInDirection):
(WebKit::WebPageProxy::updateSelectionWithExtentPoint):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::visiblePositionInFocusedNodeForPoint):
(WebKit::WebPage::selectPositionAtPoint):
(WebKit::WebPage::selectPositionAtBoundaryWithDirection):
(WebKit::WebPage::selectTextWithGranularityAtPoint):
(WebKit::WebPage::beginSelectionInDirection):
(WebKit::WebPage::updateSelectionWithExtentPoint):
- 1:56 PM Changeset in webkit [176336] by
-
- 9 edits in branches/safari-600.3-branch/Source
Merged r176220. rdar://problem/18944893
- 1:39 PM Changeset in webkit [176335] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed build fixes after r176329.
- export all of the codegen python files as they are included by the main generator
- update the imports of the main generator to match init.py
- remove bundling the python scripts as framework resources, just have them PrivateHeaders
- JavaScriptCore.xcodeproj/project.pbxproj:
- inspector/scripts/generate-inspector-protocol-bindings.py:
- 1:31 PM Changeset in webkit [176334] by
-
- 6 edits in trunk/Source/WebKit2
[WK2 UI-side Compositing] Fix the position and scroll indicator of the UI-side tiled scrolling indicator
https://bugs.webkit.org/show_bug.cgi?id=138876
Reviewed by Beth Dakin.
Fix the position of the tiled scrolling indicator in MiniBrowser by taking top
content offset into account.
On Mac, pass the current scroll position back to the UI process via the RemoteLayerTreeTransaction
so that we can use it to show the correctly scroll offset in the indicator. This is temporary until
Mac does UI-side scrolling.
- Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::scrollPosition):
(WebKit::RemoteLayerTreeTransaction::setScrollPosition):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorLocation):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicator):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::willCommitLayerTree):
- 1:15 PM Changeset in webkit [176333] by
-
- 1 edit4 moves2 adds in trunk/LayoutTests
Add layout test for throttling of DOM timer changing the style of visible and invisible elements
https://bugs.webkit.org/show_bug.cgi?id=138875
Reviewed by Simon Fraser.
Add a layout test to test that a repeating DOM timer changing the style
of both visible and invisible elements does not get throttled.
Also rename existing tests to use "display-none" instead of "invisible"
for clarity.
- fast/dom/nested-timer-display-none-element-throttling-expected.txt: Renamed from LayoutTests/fast/dom/nested-timer-invisible-element-throttling-expected.txt.
- fast/dom/nested-timer-display-none-element-throttling.html: Renamed from LayoutTests/fast/dom/nested-timer-invisible-element-throttling.html.
- fast/dom/repeating-timer-display-none-element-throttling-expected.txt: Renamed from LayoutTests/fast/dom/repeating-timer-invisible-element-throttling-expected.txt.
- fast/dom/repeating-timer-display-none-element-throttling.html: Renamed from LayoutTests/fast/dom/repeating-timer-invisible-element-throttling.html.
- fast/dom/repeating-timer-mixed-visible-display-none-elements-throttling-expected.txt: Added.
- fast/dom/repeating-timer-mixed-visible-display-none-elements-throttling.html: Added.
- 1:01 PM Changeset in webkit [176332] by
-
- 5 edits in branches/safari-600.3-branch/Source
Bump versioning
- 12:50 PM Changeset in webkit [176331] by
-
- 2 edits in trunk/Source/WebCore
Get rid of AccessibilityObject::setRoleValue()
https://bugs.webkit.org/show_bug.cgi?id=138861
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-19
Reviewed by Chris Fleizach.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::setRoleValue): Deleted.
- 12:46 PM Changeset in webkit [176330] by
-
- 1 edit2 adds in trunk/LayoutTests
Add layout test for DOM timer throttling and element moving into view after layout
https://bugs.webkit.org/show_bug.cgi?id=138874
Reviewed by Simon Fraser.
Add a layout test to make sure we unthrottle a DOM timer changing the
style of an element outside viewport if the element ends up inside
the viewport after layout.
- fast/dom/timer-unthrottle-on-layout-expected.txt: Added.
- fast/dom/timer-unthrottle-on-layout.html: Added.
- 11:16 AM Changeset in webkit [176329] by
-
- 10 edits1 copy18 moves2 adds in trunk/Source/JavaScriptCore
Web Inspector: standardize language-specific protocol generator file, class, and method prefixes
https://bugs.webkit.org/show_bug.cgi?id=138237
Reviewed by Joseph Pecoraro.
Settle on cpp/objc/js file prefixes and Cpp/ObjC/JS class prefixes for generators.
Move C++-specific static methods into CppGenerator and add cpp_ prefixes where relevant.
Split the templates file into language-specific template files.
- CMakeLists.txt:
- DerivedSources.make:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- inspector/scripts/codegen/init.py:
- inspector/scripts/codegen/cpp_generator.py: Copied from Source/JavaScriptCore/inspector/scripts/codegen/generator.py.
- inspector/scripts/codegen/cpp_generator_templates.py: Copied from Source/JavaScriptCore/inspector/scripts/codegen/generator_templates.py.
(CppGeneratorTemplates):
- inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_alternate_backend_dispatcher_header.py.
- inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_backend_dispatcher_header.py.
- inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_backend_dispatcher_implementation.py.
- inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_frontend_dispatcher_header.py.
- inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_frontend_dispatcher_implementation.py.
- inspector/scripts/codegen/generate_cpp_protocol_types_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py.
- inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py.
- inspector/scripts/codegen/generate_js_backend_commands.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_backend_commands.py.
- inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_backend_dispatcher_header.py.
- inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_backend_dispatcher_implementation.py.
- inspector/scripts/codegen/generate_objc_configuration_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_configuration_header.py.
- inspector/scripts/codegen/generate_objc_configuration_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_configuration_implementation.py.
- inspector/scripts/codegen/generate_objc_conversion_helpers.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_conversion_helpers.py.
- inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_frontend_dispatcher_implementation.py.
- inspector/scripts/codegen/generate_objc_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_header.py.
- inspector/scripts/codegen/generate_objc_internal_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_internal_header.py.
- inspector/scripts/codegen/generate_objc_protocol_types_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_types_implementation.py.
- inspector/scripts/codegen/generator.py:
- inspector/scripts/codegen/generator_templates.py:
- inspector/scripts/codegen/objc_generator.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c.py.
- inspector/scripts/codegen/objc_generator_templates.py: Added.
- inspector/scripts/generate-inspector-protocol-bindings.py:
- 11:01 AM Changeset in webkit [176328] by
-
- 1 copy in tags/Safari-601.1.10
New tag.
- 10:59 AM Changeset in webkit [176327] by
-
- 5 edits in trunk/Source
Versioning.
- 10:46 AM Changeset in webkit [176326] by
-
- 4 edits in trunk/Source/JavaScriptCore
Update WebKit to build with LLVM TOT
https://bugs.webkit.org/show_bug.cgi?id=138519
Patch by Juergen Ributzka <juergen@apple.com> on 2014-11-19
Reviewed by Alexey Proskuryakov.
- Configurations/LLVMForJSC.xcconfig:
- llvm/LLVMAPIFunctions.h:
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
- 10:34 AM Changeset in webkit [176325] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Debugger should not mutate variable when hovering mouse over ++n expression
https://bugs.webkit.org/show_bug.cgi?id=138839
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-19
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
- 10:32 AM Changeset in webkit [176324] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Improve basic JavaScript completion in inline <script>s
https://bugs.webkit.org/show_bug.cgi?id=138845
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-19
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/CodeMirrorCompletionController.js:
(WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):
Fix up CodeMirror mode handling for JavaScript completion when inside of mixed mode
input (html). Also add completion for CodeMirror's localVars list.
- 10:27 AM Changeset in webkit [176323] by
-
- 1 edit2 adds in trunk/LayoutTests
Add layout test for DOM timers throttling and 0 height element with visible overflowing content
https://bugs.webkit.org/show_bug.cgi?id=138873
Reviewed by Simon Fraser.
Add a layout test for verify that a DOM timer changing the style of a 0
height element with visible overflowing content does not get throttled.
If the implementation did not properly use the overflow rect to
determine if the element is visible, this test would fail.
This covers the case of the top scrolling banner on huffingtonpost.com.
- fast/dom/repeating-timer-element-overflow-throttling-expected.txt: Added.
- fast/dom/repeating-timer-element-overflow-throttling.html: Added.
- 9:52 AM Changeset in webkit [176322] by
-
- 2 edits in trunk/Source/WebCore
Missing NULL-check in VideoTrack::setLanguage
https://bugs.webkit.org/show_bug.cgi?id=138867
Reviewed by Jer Noble.
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::setLanguage): Prevent change event creation
on an empty video track list.
- 9:36 AM Changeset in webkit [176321] by
-
- 3 edits2 adds in trunk
AX: Safari fails to load a web page with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=138849
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Sometimes an inlineElementContinuation will continue to an inline RenderBlock, so we case this incorrectly and bad things happen.
Test: accessibility/inline-block-assertion.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::startOfContinuations):
LayoutTests:
- accessibility/inline-block-assertion-expected.txt: Added.
- accessibility/inline-block-assertion.html: Added.
- 9:26 AM Changeset in webkit [176320] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: RenderTreeAsText should use rangeForRenderer() when dumping simple line text.
https://bugs.webkit.org/show_bug.cgi?id=138847
Reviewed by Antti Koivisto.
This is in preparation to support multiple renderers for simple line layout.
Use rangeForRenderer() to get runs for a particular renderer as opposed to for the entire flow.
Not testable.
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
- 9:23 AM Changeset in webkit [176319] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error when CSS_SELECTORS_LEVEL4 is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=138870
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-19
Reviewed by Alex Christensen.
- css/CSSSelector.cpp:
(WebCore::simpleSelectorSpecificityInternal):
- 7:47 AM Changeset in webkit [176318] by
-
- 8 edits4 adds in trunk
AX: Screen braille input doesn't work on forms.
https://bugs.webkit.org/show_bug.cgi?id=138804
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Allow iOS to set values of text fields through the API.
Test: platform/ios-sim/accessibility/set-value.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:]):
Tools:
Add a method to setValue through the AX API in DRT.
- DumpRenderTree/AccessibilityUIElement.cpp:
(setValueCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::setValue):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::setValue):
LayoutTests:
- platform/ios-sim: Copied from LayoutTests/platform/ios-sim.
- platform/ios-sim/accessibility/set-value-expected.txt: Added.
- platform/ios-sim/accessibility/set-value.html: Added.
- 7:40 AM Changeset in webkit [176317] by
-
- 6 edits in trunk/Source/WebCore
Simple line layout: Add renderer based rect collecting to RunResolver.
https://bugs.webkit.org/show_bug.cgi?id=138818
Reviewed by Antti Koivisto.
This is in preparation to multiple renderers support.
RunResolver should be able to collect rects for a particular renderer
that might overlap multiple runs. (or might just be a subset of a Run)
Covered by existing tests.
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::FlowContents::renderer): It operates on a single renderer currently.
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions): It operates on a single renderer currently.
- rendering/SimpleLineLayoutFlowContents.h:
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::computeTextBoundingBox):
(WebCore::SimpleLineLayout::computeTextFirstRunLocation):
(WebCore::SimpleLineLayout::collectTextAbsoluteRects):
(WebCore::SimpleLineLayout::collectTextAbsoluteQuads):
(WebCore::SimpleLineLayout::showLineLayoutForFlow):
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::baselinePosition):
(WebCore::SimpleLineLayout::linePosition):
(WebCore::SimpleLineLayout::lineSize):
(WebCore::SimpleLineLayout::RunResolver::Run::rect):
(WebCore::SimpleLineLayout::RunResolver::Run::rectForTextRenderer):
(WebCore::SimpleLineLayout::RunResolver::Run::baseline):
(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::Run::computeRect):
(WebCore::SimpleLineLayout::RunResolver::RunResolver):
- rendering/SimpleLineLayoutResolver.h:
- 6:24 AM Changeset in webkit [176316] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Error in documentation of webkit_print_operation_get_page_setup()
https://bugs.webkit.org/show_bug.cgi?id=138868
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-11-19
Reviewed by Carlos Garcia Campos.
Fix copypaste error in documentation of
webkit_print_operation_get_page_setup().
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
- 4:46 AM WebKitGTK/2.6.x edited by
- (diff)
- 1:55 AM Changeset in webkit [176315] by
-
- 1 edit1 delete in trunk/Source/WebKit2
Remove an unused file.
- version.plist: Removed.
- 1:06 AM Changeset in webkit [176314] by
-
- 2 edits in trunk
Fix the detection of toolchain support for Cortex-A53 erratum 835769 workaround
https://bugs.webkit.org/show_bug.cgi?id=138840
Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-11-19
Reviewed by Csaba Osztrogonác.
- Source/cmake/OptionsCommon.cmake:
- 12:57 AM Changeset in webkit [176313] by
-
- 5 edits4 adds in trunk
Add selector checker for :lang pseudo class in Selectors level 4
https://bugs.webkit.org/show_bug.cgi?id=138281
Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-11-19
Reviewed by Benjamin Poulain.
Source/WebCore:
Add selector checker for :lang pseudo class in Selectors level 4.
The language tags matching is specified in [1,2].
[1] http://www.ietf.org/rfc/rfc4647.txt
[2] http://dev.w3.org/csswg/selectors4/#the-lang-pseudo
Tests: fast/selectors/lang-extended-filtering.html
fast/selectors/lang-multiple.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/SelectorCheckerTestFunctions.h:
(WebCore::containslanguageSubtagMatchingRange):
(WebCore::matchesLangPseudoClass):
(WebCore::matchesLangPseudoClassDeprecated):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
LayoutTests:
Add layout tests for :lang selector checker with multiple arguments and
related behaviors on extended filtering.
- fast/selectors/lang-extended-filtering-expected.txt: Added.
- fast/selectors/lang-extended-filtering.html: Added.
- fast/selectors/lang-multiple-expected.txt: Added.
- fast/selectors/lang-multiple.html: Added.
- 12:53 AM Changeset in webkit [176312] by
-
- 1 edit1 copy in trunk/Source/WebInspectorUI
Roll over WebInspectorUI's ChangeLog.
Nov 18, 2014:
- 11:49 PM Changeset in webkit [176311] by
-
- 8 edits in trunk
start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args
https://bugs.webkit.org/show_bug.cgi?id=138739
Reviewed by Darin Adler.
Source/WebCore:
The patch is inspired by the following Blink revision by
<Raymond Toy>:
<https://src.chromium.org/viewvc/blink?view=rev&revision=160845>
Test: webaudio/dom-exceptions.html
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::start):
(WebCore::AudioBufferSourceNode::startPlaying):
(WebCore::AudioBufferSourceNode::noteGrainOn):
(WebCore::AudioBufferSourceNode::startGrain): Deleted.
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::start):
(WebCore::AudioScheduledSourceNode::stop):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/OscillatorNode.idl:
LayoutTests:
- webaudio/dom-exceptions-expected.txt: Added.
- webaudio/dom-exceptions.html: Added.
- 10:45 PM Changeset in webkit [176310] by
-
- 2 edits in trunk/LayoutTests
Aad failing test expectations to some tests imported in r176144.
- platform/win/TestExpectations:
- 9:41 PM Changeset in webkit [176309] by
-
- 2 edits in trunk/LayoutTests
Use of uninitialized value in string eq in many http tests
https://bugs.webkit.org/show_bug.cgi?id=138852
Reviewed by Daniel Bates.
- http/tests/security/xssAuditor/resources/echo-intertag.pl: Don't use it uninitialized.
- 9:13 PM Changeset in webkit [176308] by
-
- 15 edits in trunk/Source/WebKit2
[WK2] Remove the minimalUI code from the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=138819
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-18
Reviewed by Sam Weinig.
It looks like the only interface we have to keep alive is
[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:minimumLayoutSizeForMinimalUI:maximumUnobscuredSizeOverride:].
Clean up everything else, it is a pile of useless code.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _didRelaunchProcess]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:minimumLayoutSizeForMinimalUI:maximumUnobscuredSizeOverride:]):
(-[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:maximumUnobscuredSizeOverride:]):
(-[WKWebView _setUsesMinimalUI:]): Deleted.
(-[WKWebView _usesMinimalUI]): Deleted.
(activeMinimumLayoutSizeForMinimalUI): Deleted.
(-[WKWebView _setMinimumLayoutSizeOverrideForMinimalUI:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/API/ios/WKViewIOS.mm:
(-[WKView _frameOrBoundsChanged]):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::setUsesMinimalUI): Deleted.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::dynamicViewportSizeUpdate):
(WebKit::WebPageProxy::setViewportConfigurationMinimumLayoutSizeForMinimalUI): Deleted.
(WebKit::WebPageProxy::setUsesMinimalUI): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::viewportPropertiesDidChange):
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::setViewportConfigurationMinimumLayoutSizeForMinimalUI): Deleted.
- 9:12 PM Changeset in webkit [176307] by
-
- 7 edits20 adds in trunk
Add the initial implementation of dynamic specificity for :matches()
https://bugs.webkit.org/show_bug.cgi?id=138822
Reviewed by Andreas Kling.
Source/WebCore:
Previously we completely ignored the selector list of :matches() when computing
the specificity of the selector.
The spec (http://dev.w3.org/csswg/selectors4/#specificity) says:
"The specificity of a :matches() pseudo-class, however, is the specificity
of the most specific complex selector that matched the given element."
This patch does just that.
In the CSS JIT, we only consider specificities that can be computed statically
for now, this should be extended later.
When the specificity is dynamic, we fall back to SelectorChecker. In that case,
we execute every selector of the selector list and we keep the maximum value
as the specificity for the whole :matches().
Tests: fast/css/matches-specificity-1.html
fast/css/matches-specificity-2.html
fast/css/matches-specificity-3.html
fast/css/matches-specificity-4.html
fast/css/matches-specificity-5.html
fast/css/matches-specificity-6.html
fast/css/matches-specificity-7.html
fast/css/matches-specificity-8.html
fast/css/matches-specificity-9.html
fast/css/matches-specificity-10.html
- css/CSSSelector.cpp:
(WebCore::selectorSpecificity):
(WebCore::maxSpecificity):
(WebCore::CSSSelector::specificity):
(WebCore::simpleSelectorSpecificityInternal):
(WebCore::CSSSelector::simpleSelectorSpecificity):
:matches() itself should not have any specificity. The specificity of its components
is computed in SelectorChecker.
Since :matches() is no longer accounted as a class B specificity, I had to finish
the specificity of :not() or some test breaks.
- css/CSSSelector.h:
- css/PageRuleCollector.cpp:
(WebCore::comparePageRules):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
We can no longer shortcut the execution when context.pseudoElementEffective is false.
There is no guarantee that a following selector wouldn't match with a higher specificity.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
LayoutTests:
- fast/css/matches-specificity-1-expected.html: Added.
- fast/css/matches-specificity-1.html: Added.
- fast/css/matches-specificity-2-expected.html: Added.
- fast/css/matches-specificity-2.html: Added.
- fast/css/matches-specificity-3-expected.html: Added.
- fast/css/matches-specificity-3.html: Added.
- fast/css/matches-specificity-4-expected.html: Added.
- fast/css/matches-specificity-4.html: Added.
- fast/css/matches-specificity-5-expected.html: Added.
- fast/css/matches-specificity-5.html: Added.
- fast/css/matches-specificity-6-expected.html: Added.
- fast/css/matches-specificity-6.html: Added.
- fast/css/matches-specificity-7-expected.html: Added.
- fast/css/matches-specificity-7.html: Added.
- fast/css/matches-specificity-8-expected.html: Added.
- fast/css/matches-specificity-8.html: Added.
- fast/css/matches-specificity-9-expected.html: Added.
- fast/css/matches-specificity-9.html: Added.
- fast/css/matches-specificity-10-expected.html: Added.
- fast/css/matches-specificity-10.html: Added.
- 9:08 PM Changeset in webkit [176306] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Revision to the build fix in r176304.
The guarded method should simply be in the !TARGET_OS_IPHONE block.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- 9:06 PM Changeset in webkit [176305] by
-
- 3 edits in trunk/Source/WebKit2
iOS8 new "slow tap" heuristic fires mouse compat events despite preventDefault on touchend
https://bugs.webkit.org/show_bug.cgi?id=137069
rdar://problem/18481464
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-18
Reviewed by Simon Fraser.
On WebKit2, we let UIWebTouchEventsGestureRecognizer and _UIWebHighlightLongPressGestureRecognizer
run concurrently. This causes a race with an incorrect behavior:
1) If UIWebTouchEventsGestureRecognizer does not cancel the native gestures on start.
2) _UIWebHighlightLongPressGestureRecognizer starts after highlightDelay.
3) When the finger leaves the screen, both gestures end.
-> If the touch end sent to JavaScript in [3] ask the priority over native events, that no longer stops
the _UIWebHighlightLongPressGestureRecognizer.
The two gesture recognizers can run in any order, there is no guarantee on which one runs first.
To solve the bug, I must make sure the _UIWebHighlightLongPressGestureRecognizer never trigger a click
if the page wants the event.
To solve the order problem, I use the fact that event recognition goes in two phases for
non cancelled events:
1) Update the gesture recognizers.
2) Trigger the actions.
I do not know the order of recognizers in [1], but I know both have run before [2] is executed.
I use that to stop _UIWebHighlightLongPressGestureRecognizer from ending with a click in the case of the bug:
1) When _UIWebHighlightLongPressGestureRecognizer starts, I set _highlightLongPressCanClick signaling
the gesture can end normally. This is done on a timer and not direct input so I don't really have to worry
about a race here.
2) When processing the touch event for UIWebTouchEventsGestureRecognizer, I reset the flag _highlightLongPressCanClick
if the page wants the event.
3) When the actions of _UIWebHighlightLongPressGestureRecognizer are processed, the touch event
has already been processed by the page and the flag has been cleared if needed.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _webTouchEvent:preventsNativeGestures:]):
(-[WKContentView _highlightLongPressRecognized:]):
- 8:31 PM Changeset in webkit [176304] by
-
- 2 edits in trunk/Source/WebKit2
iOS build fix after r176299. This method is not defined in WKViewIOS.mm.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- 6:42 PM Changeset in webkit [176303] by
-
- 8 edits in trunk/Source
FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
<http://webkit.org/b/138813>
Reviewed by Mark Rowe.
- Configurations/FeatureDefines.xcconfig: Switch to using SDK
selectors.
- 6:17 PM Changeset in webkit [176302] by
-
- 2 edits in branches/safari-600.2-branch/LayoutTests
nested-multicol-into-region-dynamic.html is flaky on WK1.
- platform/mac-wk1/TestExpectations:
- 6:05 PM Changeset in webkit [176301] by
-
- 3 edits4 adds in trunk
Crash when setting 'z-index' / 'flex-shrink' CSS properties to a calculated value
https://bugs.webkit.org/show_bug.cgi?id=138783
Reviewed by Andreas Kling.
Source/WebCore:
Update operators converting CSSPrimitiveValue to integer / floating
point types to properly handle calculated values (e.g. 'calc(2 * 3)').
Previously, this was not working in release builds and we would hit an
ASSERT_NOT_REACHED() in debug builds.
Tests: fast/css/flex-shrink-calculated-value.html
fast/css/z-index-calculated-value.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator unsigned short):
(WebCore::CSSPrimitiveValue::operator int):
(WebCore::CSSPrimitiveValue::operator unsigned):
(WebCore::CSSPrimitiveValue::operator float):
LayoutTests:
Add layout tests to check that settings 'z-index' / 'flex-shrink' CSS
properties to a calculated value does not crash and behaves as
expected.
- fast/css/flex-shrink-calculated-value-expected.txt: Added.
- fast/css/flex-shrink-calculated-value.html: Added.
- fast/css/z-index-calculated-value-expected.txt: Added.
- fast/css/z-index-calculated-value.html: Added.
- 5:57 PM Changeset in webkit [176300] by
-
- 1 copy in tags/Safari-600.3.7
Tagging.
- 5:43 PM Changeset in webkit [176299] by
-
- 4 edits in trunk/Source/WebKit2
Give clients a way to cancel preview popovers
https://bugs.webkit.org/show_bug.cgi?id=138855
Reviewed by Tim Horton.
Promote -[WKView _dismissActionMenuPopovers] from internal to private.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _dismissActionMenuPopovers]):
- UIProcess/API/mac/WKViewInternal.h:
- 5:19 PM Changeset in webkit [176298] by
-
- 14 edits2 moves in trunk
Unreviewed, rolling out r176263 and r176273.
https://bugs.webkit.org/show_bug.cgi?id=138854
Underlines are hideous. (Requested by litherum on #webkit).
Reverted changesets:
"Use underlining metrics from the font file"
https://bugs.webkit.org/show_bug.cgi?id=138762
http://trac.webkit.org/changeset/176263
"iOS build fix."
http://trac.webkit.org/changeset/176273
Patch by Commit Queue <commit-queue@webkit.org> on 2014-11-18# Please enter the commit message for your changes. Lines starting
- 4:56 PM Changeset in webkit [176297] by
-
- 14 edits in trunk/Source
Add a setting to toggle DOMTimer throttling support
https://bugs.webkit.org/show_bug.cgi?id=138844
<rdar://problem/19020874>
Reviewed by Andreas Kling.
Add a setting to disable DOM timers throttling, in order to help
developers determine if a specific issue is caused by timer
throttling.
Source/WebCore:
- page/DOMTimer.cpp:
(WebCore::DOMTimerFireState::contextDocument):
(WebCore::DOMTimerFireState::scriptMadeUserObservableChanges):
(WebCore::DOMTimer::isDOMTimersThrottlingEnabled):
(WebCore::DOMTimer::updateThrottlingStateIfNecessary):
- page/DOMTimer.h:
- page/Settings.in:
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences domTimersThrottlingEnabled]):
(-[WebPreferences setDOMTimersThrottlingEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetDOMTimersThrottlingEnabled):
(WKPreferencesGetDOMTimersThrottlingEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 4:49 PM Changeset in webkit [176296] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: Invoking dictionary lookup on text in some search fields searches for
incorrect item
https://bugs.webkit.org/show_bug.cgi?id=138853
-and corresponding-
rdar://problem/18912505
Reviewed by Tim Horton.
Get the visible position based on the frame, not just the renderer.
- editing/mac/DictionaryLookup.mm:
(WebCore::rangeForDictionaryLookupAtHitTestResult):
- 4:37 PM Changeset in webkit [176295] by
-
- 3 edits2 adds in trunk
REGRESSION (r167210): Invalid cast in WebCore::RenderBlock::blockSelectionGaps
https://bugs.webkit.org/show_bug.cgi?id=137590
Reviewed by Dean Jackson.
Source/WebCore:
Added fast/block/selection-block-gaps-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::blockSelectionGaps):
Check that we really are a RenderBlock before recurring.
LayoutTests:
- fast/block/selection-block-gap-crash-expected.txt: Added.
- fast/block/selection-block-gap-crash.html: Added.
- 4:20 PM Changeset in webkit [176294] by
-
- 4 edits in trunk
Avoid synchronous style recalc in Document.activeElement
<https://webkit.org/b/138850>
Reviewed by Ryosuke Niwa.
Source/WebCore:
This subtly changes the behavior of <input autofocus>, which was caught by
a layout test. Auto-focus doesn't happen until the render tree is attached,
although it was possible to force it by accessing document.activeElement.
Now auto-focus is always lazy. This is consistent with other browser engines.
~1% progression on Speedometer locally.
- dom/Document.cpp:
(WebCore::Document::activeElement):
LayoutTests:
Tweak a test to run once the DOM is loaded instead of during parsing.
- fast/forms/autofocus-in-sandbox-with-allow-scripts.html:
- 4:17 PM Changeset in webkit [176293] by
-
- 5 edits in trunk/Source
Have Vector::capacity() return an unsigned instead of a size_t
https://bugs.webkit.org/show_bug.cgi?id=138842
Reviewed by Andreas Kling.
Source/WebCore:
Update the code base now that Vector::capacity() returns an unsigned
type instead of a size_t.
No new tests, no behavior change.
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::append):
(WebCore::SearchBuffer::prependContext):
(WebCore::SearchBuffer::search):
(WebCore::SearchBuffer::length):
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::duplicateDataBufferIfNecessary):
Source/WTF:
Have Vector::capacity() return an unsigned instead of a size_t as
capacity is stored as an unsigned internally.
- wtf/Vector.h:
(WTF::Vector::capacity):
(WTF::OverflowHandler>::expandCapacity):
(WTF::OverflowHandler>::tryExpandCapacity):
- 3:07 PM Changeset in webkit [176292] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merge r175679. rdar://problem/18978404
- 3:07 PM Changeset in webkit [176291] by
-
- 5 edits4 adds in branches/safari-600.3-branch
Merge r175656. rdar://problem/18978402
- 3:06 PM Changeset in webkit [176290] by
-
- 13 edits in trunk/Source
Removed the custom allocator for ListHashSet nodes
https://bugs.webkit.org/show_bug.cgi?id=138841
Reviewed by Andreas Kling.
Source/WebCore:
Uses of ListHashSet no longer need to declare an inline capacity,
since that was only used to specify the capacity of the custom allocator.
- dom/DOMNamedFlowCollection.h:
- dom/DocumentEventQueue.h:
- dom/DocumentStyleSheetCollection.h:
- dom/NamedFlowCollection.h:
- html/FormController.h:
- rendering/FloatingObjects.h:
- rendering/RenderBlock.h:
Source/WebKit2:
Uses of ListHashSet no longer need to declare an inline capacity,
since that was only used to specify the capacity of the custom allocator.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
Source/WTF:
bmalloc is fast, so we don't need a custom allocator.
The MallocBench test for linked list node allocation (list_allocate) is
4.09X faster in bmalloc than TCMalloc. Also, I wrote a stress test to
add/remove link elements, which modify a ListHashSet on insertion and
removal, and it was 1% faster / in the noise with bmalloc enabled.
- wtf/ListHashSet.h:
(WTF::ListHashSetNode::ListHashSetNode):
(WTF::ListHashSetTranslator::translate):
(WTF::U>::ListHashSet):
(WTF::=):
(WTF::U>::swap):
(WTF::U>::~ListHashSet):
(WTF::U>::size):
(WTF::U>::capacity):
(WTF::U>::isEmpty):
(WTF::U>::first):
(WTF::U>::removeFirst):
(WTF::U>::takeFirst):
(WTF::U>::last):
(WTF::U>::removeLast):
(WTF::U>::takeLast):
(WTF::U>::contains):
(WTF::U>::remove):
(WTF::U>::clear):
(WTF::U>::unlink):
(WTF::U>::unlinkAndDelete):
(WTF::U>::appendNode):
(WTF::U>::prependNode):
(WTF::U>::insertNodeBefore):
(WTF::U>::deleteAllNodes):
(WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): Deleted.
(WTF::ListHashSetNodeAllocator::allocate): Deleted.
(WTF::ListHashSetNodeAllocator::deallocate): Deleted.
(WTF::ListHashSetNodeAllocator::pool): Deleted.
(WTF::ListHashSetNodeAllocator::pastPool): Deleted.
(WTF::ListHashSetNodeAllocator::inPool): Deleted.
(WTF::ListHashSetNode::operator new): Deleted.
(WTF::ListHashSetNode::destroy): Deleted.
- 2:57 PM Changeset in webkit [176289] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r176283.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
- 2:54 PM Changeset in webkit [176288] by
-
- 7 edits in trunk/Source
Avoid re-encoding action menu image data
https://bugs.webkit.org/show_bug.cgi?id=138817
<rdar://problem/18840382>
Reviewed by Anders Carlsson.
- Shared/mac/ActionMenuHitTestResult.h:
- Shared/mac/ActionMenuHitTestResult.mm:
(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
Store and encode a SharedMemory with the raw encoded image data,
instead of re-painting the image into a ShareableBitmap.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _hitTestResultImage]):
(-[WKActionMenuController _defaultMenuItemsForImage]):
(-[WKActionMenuController _copyImage:]):
(-[WKActionMenuController _addImageToPhotos:]):
(-[WKActionMenuController _defaultMenuItems]):
(-[WKActionMenuController _canAddMediaToPhotos]): Deleted.
Build a temporary filename from a UUID and the image's desired extension.
Use the Image's encoded data instead of re-encoding it with CGImageDestination.
Build an image menu only if we have an image, URL, data, and extension.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performActionMenuHitTestAtLocation):
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForImage:]):
(-[WebActionMenuController _addImageToPhotos:]):
Build a temporary filename from a UUID and the image's desired extension.
Use the Image's encoded data instead of re-encoding it with CGImageDestination.
Build an image menu only if we have an image, URL, data, and extension.
- 2:51 PM Changeset in webkit [176287] by
-
- 3 edits2 adds in trunk
REGRESSION(r152313): Inline-block element doesn't wrap properly
https://bugs.webkit.org/show_bug.cgi?id=138846 - <rdar://problem/18838703>
Reviewed by Simon Fraser.
Source/WebCore:
Added fast/inline-block/inline-block-empty-spans.html
- rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::canBreakAtThisPosition):
LayoutTests:
- fast/inline-block/inline-block-empty-spans-expected.html: Added.
- fast/inline-block/inline-block-empty-spans.html: Added.
- 2:45 PM Changeset in webkit [176286] by
-
- 2 edits in branches/safari-600.2-branch/LayoutTests
Add test expectations.
- platform/mac/TestExpectations:
- 2:40 PM Changeset in webkit [176285] by
-
- 3 edits2 adds in trunk
Multicolumn layout with negative line spacing and orphans causes pieces of letters to be shown at the bottom of columns
https://bugs.webkit.org/show_bug.cgi?id=138204
Source/WebCore:
Reviewed by Dave Hyatt.
This code is responsible for pushing block elements to the next column if
the "orphans" CSS property is triggered. The mechanism by which this is
achieved is to push the block down such that the origin of the block is
at the origin of the next column. However, if there is negative line
spacing, the top portion of the text might actually be on top of the
origin of the block. Therefore, the block wasn't being pushed down enough
to entirely contain its text, so the top pieces were being drawn on the
previous column.
Test: fast/multicol/orphans-negative-line-spacing.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
LayoutTests:
Patch by Myles C. Maxfield <litherum@gmail.com> on 2014-11-18
Reviewed by Dave Hyatt.
Create a layout where the "orphans" css property causes a block element to
be pushed to the next column.
- fast/multicol/orphans-negative-line-spacing-expected.html: Added.
- fast/multicol/orphans-negative-line-spacing.html: Added.
- 2:10 PM Changeset in webkit [176284] by
-
- 6 edits in branches/safari-600.3-branch/Source
Merge r176166. rdar://problem/18953982
- 2:10 PM Changeset in webkit [176283] by
-
- 5 edits in trunk/Source/WebKit2
[iOS] allow host application to opt-out of alternate fullscreen
https://bugs.webkit.org/show_bug.cgi?id=138787
Reviewed by Sam Weinig.
"allowsAlternateFullscreen" doesn't need to be in the public WKWebView header.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]): allowsAlternateFullscreen -> _allowsAlternateFullscreen.
- UIProcess/API/Cocoa/WKWebViewConfiguration.h: Remove allowsAlternateFullscreen.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _allowsAlternateFullscreen]): New.
(-[WKWebViewConfiguration _setAllowsAlternateFullscreen:]): New.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Declare _allowsAlternateFullscreen.
- 2:05 PM Changeset in webkit [176282] by
-
- 3 edits2 adds in trunk
DOMTimers sometimes don't get unthrottled on scrolling
https://bugs.webkit.org/show_bug.cgi?id=138838
Reviewed by Antti Koivisto.
Source/WebCore:
DOMTimers sometimes didn't get unthrottled on scrolling. This is
because we stopped listening for viewport changes every time the
timer fires, but we didn't listen for those changes again if we
decided the timer should stay throttled after the timer's action
was executed.
We should listen for viewport changes again after executing the
timer's action, if there are elements outside the viewport causing
the DOMTimer to be throttled, even if the throttleState hasn't
changed (i.e the timer stays throttled).
Test: fast/dom/timer-unthrottle-on-scroll.html
- page/DOMTimer.cpp:
(WebCore::DOMTimer::updateThrottlingStateIfNecessary):
(WebCore::DOMTimer::updateTimerIntervalIfNecessary):
(WebCore::DOMTimer::updateThrottlingStateAfterViewportChange):
LayoutTests:
Add a layout test to verify that DOMTimers get unthrottled on scroll if
the element whose style they are changing is inside the viewport after
the scroll.
- fast/dom/timer-unthrottle-on-scroll-expected.txt: Added.
- fast/dom/timer-unthrottle-on-scroll.html: Added.
- 1:28 PM Changeset in webkit [176281] by
-
- 28 edits1 copy in branches/safari-600.3-branch/Source
Merge r176164. rdar://problem/18953982
- 1:01 PM Changeset in webkit [176280] by
-
- 21 edits in branches/safari-600.3-branch/Source
Merge r176108. rdar://problem/19005904
- 12:59 PM Changeset in webkit [176279] by
-
- 4 edits in trunk/Tools
Remove the WinCairo buildbot
https://bugs.webkit.org/show_bug.cgi?id=138805
Reviewed by Alex Christensen.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
- BuildSlaveSupport/test-result-archive:
(archiveTestResults):
- 12:56 PM Changeset in webkit [176278] by
-
- 8 edits in trunk/Source/WebCore
[iOS] Make WebCore build and link with public SDK
https://bugs.webkit.org/show_bug.cgi?id=136487
Patch by Daniel Bates <dbates@webkit.org> on 2014-11-18
Reviewed by David Kilzer.
- bindings/objc/DOMInternal.mm: Include header NSMapTableSPI.h.
- bindings/objc/WebScriptObject.mm: Ditto; Also fix style nit, substitute
#import for #include when importing header WTFString.h.
- bridge/objc/objc_instance.mm: Include header NSMapTableSPI.h and remove
#import NSMapTable.h as the former will import the latter.
- platform/ios/PlatformEventFactoryIOS.mm: Include header wtf/CurrentTime.h
for the declaration of WTF::currentTime().
- platform/ios/wak/WebCoreThread.mm: Remove unnecessary include of header CoreFoundation/CFPriv.h.
- platform/spi/ios/AVKitSPI.h: Add more SPI.
- platform/spi/ios/MPAVRoutingControllerSPI.h: Ditto.
- 12:12 PM Changeset in webkit [176277] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed. Updated the install instruction.
- Install.md:
- 12:04 PM Changeset in webkit [176276] by
-
- 21 edits1 copy1 add in trunk/Source
Subclass CachedFont for SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=138686
Reviewed by Simon Fraser.
Re-landing due to flakey bots.
Source/WebCore:
CachedFont had many #if ENABLE(SVG_FONTS) scattered throughout it.
Splitting out this SVG-specific code into a subclass of CachedFont
cleans up the design.
No new tests because there is no behavior change.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): There are two sections
in this function; one for SVG fonts and one for regular fonts.
I've moved these two sections into CachedFont and SVGCachedFont,
thereby simplifying this function.
(WebCore::CSSFontFaceSource::ensureFontData): Ditto.
(WebCore::CSSFontFaceSource::svgFontFaceElement): Moved to header.
(WebCore::CSSFontFaceSource::setSVGFontFaceElement): Ditto.
(WebCore::CSSFontFaceSource::isSVGFontFaceSource): Ditto.
- css/CSSFontFaceSource.h: Put functions that are simple enough to
be inlined here.
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSVGFontTarget): Convenience
function.
(WebCore::CSSFontFaceSrcValue::cachedFont): Pass through a boolean
from CSSFontSelector to CachedResourceHandle regarding if we should
be using SVGCachedFont instead of CachedFont.
- css/CSSFontFaceSrcValue.h: New convenience function.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Pass through a boolean
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceType): Update for new
CachedResource type
(WebCore::cachedResourcesForFrame): Ditto.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData): Taken from
CSSFontFaceSource::getFontData()
(WebCore::CachedFont::getFontData): Ditto.
(WebCore::CachedFont::platformDataFromCustomData): Ditto.
(WebCore::CachedFont::ensureSVGFontData): Moved to SVGCachedFont.
(WebCore::CachedFont::getSVGFontById): Ditto.
- loader/cache/CachedFont.h:
- loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType): Update for new enum
type.
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource): Takes new boolean.
(WebCore::CachedResourceLoader::requestFont): Ditto.
(WebCore::CachedResourceLoader::checkInsecureContent): Update for
new enum type
(WebCore::CachedResourceLoader::canRequest): Ditto.
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedSVGFont.cpp: Added.
(WebCore::CachedSVGFont::CachedSVGFont): Moved from
CSSFontFaceSource::getFontData() and CachedFont
(WebCore::CachedSVGFont::getFontData): Ditto.
(WebCore::CachedSVGFont::platformDataFromCustomData): Ditto.
(WebCore::CachedSVGFont::ensureCustomFontData): Ditto.
(WebCore::CachedSVGFont::getSVGFontById): Ditto.
(WebCore::CachedSVGFont::firstFontFace): Ditto.
- loader/cache/CachedSVGFont.h: Subclass CachedFont.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::getStatistics): Update for new enum.
- svg/SVGFontFaceUriElement.cpp:
(WebCore::isSVGFontTarget): Convenience function.
(WebCore::SVGFontFaceUriElement::loadFont): Update for new
boolean.
Source/WebKit2:
Update for enum type.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::maximumBufferingTime):
- 11:56 AM Changeset in webkit [176275] by
-
- 21 edits in trunk/Source
Update the Vector API to deal with unsigned types instead of size_t
https://bugs.webkit.org/show_bug.cgi?id=138824
Reviewed by Andreas Kling.
Source/JavaScriptCore:
Update code base to fix build errors related to the typing changes
in the Vector API (size_t -> unsigned).
- bytecode/PreciseJumpTargets.cpp:
- replay/EncodedValue.h:
Source/WebCore:
Update code base to fix build errors related to the typing changes
in the Vector API (size_t -> unsigned).
No new tests, no behavior change.
- WebCore.exp.in:
- bindings/js/JSDOMBinding.h:
(WebCore::jsArray):
- bindings/js/JSWebGLRenderingContextCustom.cpp:
- cssjit/SelectorCompiler.cpp:
- html/HTMLFormElement.cpp:
(WebCore::removeFromVector):
- html/parser/HTMLParserIdioms.h:
- html/parser/XSSAuditor.cpp:
Source/WebKit2:
Update code base to fix build errors related to the typing changes
in the Vector API (size_t -> unsigned).
- Platform/IPC/ArgumentCoders.h:
- Platform/IPC/DataReference.h:
Source/WTF:
Update part of the Vector API to deal with unsigned types instead of
size_t. The Vector class is already using unsigned type for its
capacity and size data members. However, the Vector API was never
updated accordingly.
The rest of the Vector API will be ported in follow-up patches to
make the change smaller and more easily reviewable.
- wtf/Forward.h:
- wtf/Vector.h:
(WTF::VectorTypeOperations::compare):
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::shouldReallocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
(WTF::VectorBufferBase::capacity):
(WTF::VectorBufferBase::VectorBufferBase):
(WTF::VectorBuffer::VectorBuffer):
(WTF::VectorBuffer::allocateBuffer):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::VectorBuffer::shouldReallocateBuffer):
(WTF::VectorBuffer::reallocateBuffer):
(WTF::VectorBuffer::swap):
(WTF::VectorBuffer::swapInlineBuffer):
(WTF::VectorBuffer::swapInlineBuffers):
(WTF::Vector::Vector):
(WTF::Vector::at):
(WTF::Vector::operator[]):
(WTF::OverflowHandler>::find):
(WTF::OverflowHandler>::reverseFind):
(WTF::OverflowHandler>::fill):
(WTF::OverflowHandler>::expandCapacity):
(WTF::OverflowHandler>::tryExpandCapacity):
(WTF::OverflowHandler>::resize):
(WTF::OverflowHandler>::resizeToFit):
(WTF::OverflowHandler>::shrink):
(WTF::OverflowHandler>::grow):
(WTF::OverflowHandler>::reserveCapacity):
(WTF::OverflowHandler>::tryReserveCapacity):
(WTF::OverflowHandler>::reserveInitialCapacity):
(WTF::OverflowHandler>::shrinkCapacity):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::insert):
(WTF::OverflowHandler>::insertVector):
(WTF::OverflowHandler>::remove):
(WTF::OverflowHandler>::reverse):
(WTF::OverflowHandler>::checkConsistency):
- wtf/text/AtomicString.h:
- wtf/text/StringImpl.h:
(WTF::StringImpl::adopt):
(WTF::equalIgnoringNullity):
- wtf/text/StringView.h:
(WTF::append):
- wtf/text/WTFString.h:
- 11:32 AM Changeset in webkit [176274] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Unreviewed iOS build fix
- platform/graphics/ios/SimpleFontDataIOS.mm:
(WebCore::SimpleFontData::platformInit):
- 11:31 AM Changeset in webkit [176273] by
-
- 2 edits in trunk/Source/WebCore
iOS build fix.
- platform/graphics/ios/SimpleFontDataIOS.mm:
(WebCore::SimpleFontData::platformInit):
- 11:31 AM Changeset in webkit [176272] by
-
- 1 edit2 adds in branches/safari-600.2-branch/LayoutTests
Merge missing layout tests which were added to trunk in r175197.
rdar://problem/18976843
- css3/infinite-word-spacing-expected.txt: Added.
- css3/infinite-word-spacing.html: Added.
- 11:24 AM Changeset in webkit [176271] by
-
- 1 edit2 adds in branches/safari-600.3-branch/LayoutTests
Merge missing layout tests which were added to trunk in r175197.
rdar://problem/18976843
- css3/infinite-word-spacing-expected.txt: Added.
- css3/infinite-word-spacing.html: Added.
- 11:14 AM Changeset in webkit [176270] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merge r175765. rdar://problem/19005917
- 11:10 AM Changeset in webkit [176269] by
-
- 3 edits in trunk/Source/WTF
[WinCairo] Compile errors when GStreamer is enabled.
https://bugs.webkit.org/show_bug.cgi?id=137000
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-18
Reviewed by Philippe Normand.
MSVC does not allow the keyword default on move constructors and move assignment operators.
- wtf/gobject/GMainLoopSource.cpp:
(WTF::GMainLoopSource::cancel):
(WTF::GMainLoopSource::socketCallback):
- wtf/gobject/GMainLoopSource.h:
(WTF::GMainLoopSource::Context::operator=):
- 11:08 AM Changeset in webkit [176268] by
-
- 4 edits in branches/safari-600.3-branch/Source/WebInspectorUI
Merge r175763. rdar://problem/19005901
- 10:52 AM Changeset in webkit [176267] by
-
- 21 edits2 deletes in trunk/Source
Unreviewed, rolling out r176264.
https://bugs.webkit.org/show_bug.cgi?id=138837
caused many test failures (Requested by litherum on #webkit).
Reverted changeset:
"Subclass CachedFont for SVG fonts"
https://bugs.webkit.org/show_bug.cgi?id=138686
http://trac.webkit.org/changeset/176264
- 10:14 AM Changeset in webkit [176266] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r176207.
https://bugs.webkit.org/show_bug.cgi?id=138836
Not ready yet (Requested by ap on #webkit).
Reverted changeset:
"Update WebKit to build with LLVM TOT"
https://bugs.webkit.org/show_bug.cgi?id=138519
http://trac.webkit.org/changeset/176207
- 10:05 AM Changeset in webkit [176265] by
-
- 15 edits6 copies in trunk
[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
SPI are not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138802
Reviewed by David Kilzer.
Source/WebCore:
Add SPI wrapper headers {Dispatch, DynamicLinker, IOPMLib, MachVM, NSPointerFunctions, MobileGestalt}SPI.h
that forward declare applicable libdispatch, dyld, IOKit, mach, Foundation, MobileGestalt SPI
and use these headers instead of the including private headers corresponding to these libraries/frameworks.
- WebCore.xcodeproj/project.pbxproj: Add private headers MobileGestaltSPI.h and
MachVMSPI.h, and project headers DynamicLinkerSPI.h, NSPointerFunctionsSPI.h,
DispatchSPI.h and IOPMLibSPI.h. Also, sort files in Xcode project.
- bindings/objc/DOMInternal.mm: Include header NSPointerFunctionsSPI.h.
- bridge/objc/objc_instance.mm: Ditto; Also, sort #import directives.
- platform/cocoa/DisplaySleepDisablerCocoa.cpp: Substitute header IOPMLibSPI.h
for private header IOKit/pwr_mgt/IOPMLib.h.
- platform/cocoa/MemoryPressureHandlerCocoa.mm: Substitute header DispatchSPI.h
for private header dispatch/private.h.
- platform/graphics/ios/FontServicesIOS.mm: Substitute header DynamicLinkerSPI.h
for private header mach-o/dyld_priv.h.
- platform/ios/PlatformScreenIOS.mm: Substitute header MobileGestaltSPI.h for
private header MobileGestalt.h.
- platform/spi/cocoa/DispatchSPI.h: Added.
- platform/spi/cocoa/DynamicLinkerSPI.h: Added.
- platform/spi/cocoa/IOPMLibSPI.h: Added.
- platform/spi/cocoa/MachVMSPI.h: Added.
- platform/spi/cocoa/NSPointerFunctionsSPI.h: Added.
- platform/spi/ios/MobileGestaltSPI.h: Added.
Source/WebKit/mac:
Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
libdispatch and MobileGestalt headers directly.
- WebView/WebView.mm:
Source/WebKit2:
Include headers DispatchSPI.h and MachVMSPI.h.h instead of including
libdispatch and Mach headers directly.
- Platform/mac/SharedMemoryMac.cpp:
- UIProcess/ios/WebMemoryPressureHandlerIOS.mm:
Tools:
Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
- DumpRenderTree/mac/CheckedMalloc.cpp:
- 10:04 AM Changeset in webkit [176264] by
-
- 21 edits1 copy1 add in trunk/Source
Subclass CachedFont for SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=138686
Reviewed by Simon Fraser.
Source/WebCore:
CachedFont had many #if ENABLE(SVG_FONTS) scattered throughout it.
Splitting out this SVG-specific code into a subclass of CachedFont
cleans up the design.
No new tests because there is no behavior change.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): There are two sections
in this function; one for SVG fonts and one for regular fonts.
I've moved these two sections into CachedFont and SVGCachedFont,
thereby simplifying this function.
(WebCore::CSSFontFaceSource::ensureFontData): Ditto.
(WebCore::CSSFontFaceSource::svgFontFaceElement): Moved to header.
(WebCore::CSSFontFaceSource::setSVGFontFaceElement): Ditto.
(WebCore::CSSFontFaceSource::isSVGFontFaceSource): Ditto.
- css/CSSFontFaceSource.h: Put functions that are simple enough to
be inlined here.
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSVGFontTarget): Convenience
function.
(WebCore::CSSFontFaceSrcValue::cachedFont): Pass through a boolean
from CSSFontSelector to CachedResourceHandle regarding if we should
be using SVGCachedFont instead of CachedFont.
- css/CSSFontFaceSrcValue.h: New convenience function.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Pass through a boolean
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceType): Update for new
CachedResource type
(WebCore::cachedResourcesForFrame): Ditto.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData): Taken from
CSSFontFaceSource::getFontData()
(WebCore::CachedFont::getFontData): Ditto.
(WebCore::CachedFont::platformDataFromCustomData): Ditto.
(WebCore::CachedFont::ensureSVGFontData): Moved to SVGCachedFont.
(WebCore::CachedFont::getSVGFontById): Ditto.
- loader/cache/CachedFont.h:
- loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType): Update for new enum
type.
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource): Takes new boolean.
(WebCore::CachedResourceLoader::requestFont): Ditto.
(WebCore::CachedResourceLoader::checkInsecureContent): Update for
new enum type
(WebCore::CachedResourceLoader::canRequest): Ditto.
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedSVGFont.cpp: Added.
(WebCore::CachedSVGFont::CachedSVGFont): Moved from
CSSFontFaceSource::getFontData() and CachedFont
(WebCore::CachedSVGFont::getFontData): Ditto.
(WebCore::CachedSVGFont::platformDataFromCustomData): Ditto.
(WebCore::CachedSVGFont::ensureCustomFontData): Ditto.
(WebCore::CachedSVGFont::getSVGFontById): Ditto.
(WebCore::CachedSVGFont::firstFontFace): Ditto.
- loader/cache/CachedSVGFont.h: Subclass CachedFont.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::getStatistics): Update for new enum.
- svg/SVGFontFaceUriElement.cpp:
(WebCore::isSVGFontTarget): Convenience function.
(WebCore::SVGFontFaceUriElement::loadFont): Update for new
boolean.
Source/WebKit2:
Update for enum type.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::maximumBufferingTime):
- 10:04 AM Changeset in webkit [176263] by
-
- 14 edits2 moves in trunk
Use underlining metrics from the font file
https://bugs.webkit.org/show_bug.cgi?id=138762
Patch by Myles C. Maxfield <litherum@gmail.com> on 2014-11-18
Reviewed by Dave Hyatt.
Source/WebCore:
Test: platform/mac/fast/css3-text/css3-text-decoration/text-decoration-thickness.html
- platform/graphics/FontMetrics.h: Adding variables for text decoration thickness and
underline position.
(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::decorationThickness):
(WebCore::FontMetrics::setDecorationThickness):
(WebCore::FontMetrics::underlinePosition):
(WebCore::FontMetrics::setUnderlinePosition):
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformInit): Initialize new FontMetrics members.
- platform/graphics/ios/SimpleFontDataIOS.mm:
(WebCore::SimpleFontData::platformInit): Ditto.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit): Ditto.
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit): Ditto.
- platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::SimpleFontData::platformInit): Ditto.
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont): Ditto.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration): Use FontMetrics data.
- style/InlineTextBoxStyle.cpp:
(WebCore::computeUnderlineOffset): Ditto.
(WebCore::visualOverflowForDecorations): Ditto.
- style/InlineTextBoxStyle.h:
(WebCore::textDecorationStrokeThickness): Deleted.
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::initializeFontData): Initialize new FontMetrics members.
LayoutTests:
This patch makes underline placement platform-dependent.
- platform/mac/fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html: Renamed from LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html.
- platform/mac/fast/css3-text/css3-text-decoration/text-decoration-thickness.html: Renamed from LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness.html.
- 9:54 AM Changeset in webkit [176262] by
-
- 8 edits2 adds in trunk
Improve Ruby selection (getting rid of overlap and improving gap filling)
https://bugs.webkit.org/show_bug.cgi?id=138250
Reviewed by Dean Jackson.
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
Add Ruby text in along with the Ruby base.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::inlineSelectionGaps):
Don't let block gaps get filled in here.
- rendering/RenderRubyBase.h:
Expose accessor to the ruby run.
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::rubyRun):
- rendering/RenderRubyText.h:
Add accessor to the ruby run.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):
Improve selectionTop and selectionBottom of ruby bases to avoid the
ruby text. Improve the selectionTop and selectionBottom of ruby texts
to fill the gap up to the previous/next line as appropriate.
LayoutTests:
Added fast/repaint/selection-ruby-rl.html
- fast/repaint/selection-ruby-rl-expected.txt: Added.
- fast/repaint/selection-ruby-rl.html: Added.
- 9:45 AM Changeset in webkit [176261] by
-
- 2 edits in trunk/Source/WebCore
crypto: Use sequence<> instead of KeyUsage[] in IDL.
https://bugs.webkit.org/show_bug.cgi?id=138823
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-11-18
Reviewed by Darin Adler.
Use sequence<KeyUsage> instead of KeyUsage[] in crypto IDL as per spec: https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/
Overview.html#SubtleCrypto-method-generateKey
No new tests, no behavior change.
- crypto/SubtleCrypto.idl:
- 9:21 AM Changeset in webkit [176260] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
Forgot to fix this test before landing.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewDefaultContext):
- 8:31 AM Changeset in webkit [176259] by
-
- 10 edits in trunk/Source/WebCore
HRTFDatabaseLoader is not an absolute condition to run audioContext
https://bugs.webkit.org/show_bug.cgi?id=138829
Reviewed by Jer Noble.
This patch is a port of the following Blink revision by
<keonho07.kim@samsung.com>:
<https://src.chromium.org/viewvc/blink?revision=167887&view=revision>
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::isRunnable): Deleted.
- Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::hrtfDatabaseLoader): Deleted.
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::render):
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::offlineRender):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::process):
(WebCore::PannerNode::initialize):
(WebCore::PannerNode::setPanningModel):
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/RealtimeAnalyser.cpp:
- Modules/webaudio/RealtimeAnalyser.h:
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
- 8:09 AM Changeset in webkit [176258] by
-
- 29 edits5 deletes in trunk
Unreviewed, rolling out r176218.
https://bugs.webkit.org/show_bug.cgi?id=138827
seems to have caused regressions on the perf bots (Requested
by lajava on #webkit).
Reverted changeset:
"[CSS Grid Layout] Upgrade align-self and align-items parsing
to CSS 3"
https://bugs.webkit.org/show_bug.cgi?id=133359
http://trac.webkit.org/changeset/176218
- 7:24 AM Changeset in webkit [176257] by
-
- 5 edits in trunk/LayoutTests
fast/multicol/newmulticol tests use a non-existent resource
https://bugs.webkit.org/show_bug.cgi?id=138800
Reviewed by Andrei Bucur.
Fix path in tests.
- fast/multicol/newmulticol/compare-with-old-impl/shrink-to-column-height-for-pagination-expected.html:
- fast/multicol/newmulticol/compare-with-old-impl/shrink-to-column-height-for-pagination.html:
- fast/multicol/newmulticol/float-multicol-expected.html:
- fast/multicol/newmulticol/float-multicol.html:
- 6:19 AM Changeset in webkit [176256] by
-
- 31 edits in trunk
[GTK] Add API to create a WebKitWebContext
https://bugs.webkit.org/show_bug.cgi?id=138826
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
We have always used a default web context without providing API to
create others. The main reason was that nobody requested it and we
haven't needed it either. The main problem of the default web
context is that you can't configure anything during
construction. This hasn't been a problem so far because all the
web context configuration we expose in the API can be configured
after construction. But now we need to expose API to allow the
user to configure the local storage directory, which is a
construct only configuration. The default web context was also a
problem for our unit tests, because sharing the same context made
it difficult to ensure tests cases are independent to each other.
- UIProcess/API/gtk/WebKitGeolocationProvider.cpp:
(WebKitGeolocationProvider::~WebKitGeolocationProvider): Reset the
provider to avoid crashes when web context is destroyed and a new
one is created.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed): Add constructed implementation to
create the WebContext and initialize it.
(webkitWebContextDispose): Detach web context clients to avoid
crashes when a client callback is called on a disposed WebKitWebContext.
(webkit_web_context_class_init): Initialize gettext, add
constructed implementation and add the pointer to the vmethods
when creating signals.
(createDefaultWebContext): Simply create a WebKitWebContext.
(webkit_web_context_new): New public method to create a WebKitWebContext.
(injectedBundleFilename): Deleted.
- UIProcess/API/gtk/WebKitWebContext.h: Add virtual methods for
signals, so that users can inherit from WebKitWebContext and
override the virtual methods.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
Tools:
Use a different WebKitWebContext for every test to ensure test
cases are independent to each other. Tests using DBus to
communicate with the injected bundle extension now use a unique
name for the well known DBus name.
- TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
(beforeAll): Remove comment about the order of the tests and
move the success test before the failed one now that tests don't
depend on each others.
- TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
(beforeAll): Remove call to set the web extensions directory,
since this is now done for all test in the Test constructor.
- TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
(beforeAll): Do not create a temporary directory, a temporary data
directory is now created for all tests.
(afterAll):
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
(testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
to the web process test runner.
(testWebKitDOMNodeInsertion): Ditto.
(testWebKitDOMNodeTagNames): Ditto.
(beforeAll): Remove call to set the web extensions directory.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
(runTest): Pass the web extension ID to the web process test runner.
(beforeAll): Remove call to set the web extensions directory.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
(runTest): Pass the web extension ID to the web process test runner.
(beforeAll): Remove call to set the web extensions directory.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
(createFileAtDestination): Use Test::dataDirectory() as base dir
for temporary files.
(beforeAll): Do not create a temporary directory.
(afterAll):
- TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
(webkitFrameTestRun): Pass the web extension ID to the web process
test runner.
(beforeAll): Remove call to set the web extensions directory.
- TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
(beforeAll): Remove call to set the web extensions directory.
- TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
(testProcessPerWebView): Use local member instead of global variable.
(testMultiprocessWebViewCreateReadyClose): Ditto.
(beforeAll): Do not connect to initialize-web-extensions, Test now
connects to the signal for all tests and calls a virtual method
that test can override.
(afterAll):
(initializeWebExtensions): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
(testPrintOperationPrint): Use Test::dataDirectory() as base dir
for temporary files.
(beforeAll): Do not create a temporary directory.
(afterAll):
- TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
(beforeAll): Remove call to set the web extensions directory.
- TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
(beforeAll): Remove comment about the tests order.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
(testWebExtensionGetTitle): Build the DBus service name using the
web extension ID.
(testDocumentLoadedSignal): Ditto.
(testWebKitWebViewProcessCrashed): Ditto.
(testWebExtensionIsolatedWorld): Ditto.
(beforeAll): Remove initialization-user-data test, since now all
tests are passing user data to the web extension.
(testWebExtensionInitializationUserData): Deleted.
(initializeWebExtensions): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
(testSetDirectory): Use the web context member inherited from Test.
(testClearDatabase): Ditto.
(testGetFaviconURI): Ditto.
(beforeAll): Do not create a temporary directory.
(afterAll):
(webkitFaviconDatabaseFinalizedCallback): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
(UserContentManagerTest::UserContentManagerTest):
(beforeAll): Remove call to set the web extensions directory.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
(testWebContextDefault): Check also that a newly create web
context is not the default web context.
(testWebContextSpellChecker): Use the web context member inherited
from Test.
(testWebContextLanguages): Ditto.
- TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
(methodCallCallback): Remove GetInitializationUserData method.
(webkit_web_extension_initialize_with_user_data): Always create
the DBus name using the user data provided.
(makeBusName): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
(webkit_web_extension_initialize_with_user_data): Create the DBus
name using the user data provided.
(webkit_web_extension_initialize): Deleted.
- TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
(Test::dataDirectory): Return the temporary data directory.
(removeNonEmptyDirectory): Also remove directories recursively.
(main): Remove the disk cache directory initialization, since this
is now done in the Test constructor.
- TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
(Test::initializeWebExtensionsCallback): Call the virtual method
initializeWebExtensions()
(Test::Test): Create a new WebKitWebContext and initialize it.
(Test::~Test): Disconnect initialize-web-extensions signal.
(Test::initializeWebExtensions): Set the web extensions directory
and user data.
- TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
(WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
(WebProcessTestRunner::runTest): Build the DBus proxy using a
unique name created with the Test web extension ID.
(WebProcessTestRunner::proxy): Deleted.
- TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
(WebViewTest::WebViewTest): Create the web view with the Test web
context.
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
content manager parameter to the constructor.
- 5:53 AM WebKitGTK/2.6.x edited by
- Add another changeset which fix gtk-doc build problem on FreeBSD (diff)
- 5:40 AM Changeset in webkit [176255] by
-
- 2 edits1 add in trunk/Tools
[GTK] Mesa build fails over llvm-3.5
https://bugs.webkit.org/show_bug.cgi?id=138825
Reviewed by Gustavo Noronha Silva.
OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
- gtk/jhbuild.modules:
- gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
- 4:51 AM Changeset in webkit [176254] by
-
- 3 edits2 adds in trunk
AX: [ATK] Crash getting the orientation of a MenuListOption after the MenuList was removed from the document
https://bugs.webkit.org/show_bug.cgi?id=138727
Reviewed by Chris Fleizach.
Source/WebCore:
AccessibilityMenuListOption::elementRect() returns the value of the
grandparent MenuList, asserting that the grandparent exists with that
role. But it is possible to have an existing MenuListOption and remove
the element which had been backing that MenuList from the document.
Adding null checks prior to the assertions prevents our crashing if the
parent or grandparent was removed.
Test: platform/gtk/accessibility/combobox-descendants-orientation-crash.html
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::elementRect):
LayoutTests:
- platform/gtk/accessibility/combobox-descendants-orientation-crash-expected.txt: Added.
- platform/gtk/accessibility/combobox-descendants-orientation-crash.html: Added.
- 3:55 AM WebKitGTK/2.6.x edited by
- (diff)
- 3:55 AM WebKitGTK/2.6.x edited by
- (diff)
- 3:54 AM WebKitGTK/2.6.x edited by
- (diff)
- 3:49 AM Changeset in webkit [176253] by
-
- 3 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2
Merge r176252 - [SOUP] [GnuTLS] Don't use a SSL3.0 record version in client hello.
https://bugs.webkit.org/show_bug.cgi?id=138794
Reviewed by Sergio Villar Senin.
It seems that following POODLE many sites incorrectly banned SSL 3.0
record packet versions. Since GnuTLS uses a SSL 3.0 record to
advertise TLS 1.2, they are effectively banning it even if it doesn't
advertise SSL 3.0. That is a server issue, but it can be worked around
by using the modifier %LATEST_RECORD_VERSION.
With this modifier, GnuTLS will use the latest TLS version record
in client hello instead of using the default SSL 3.0.
- NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:
(main):
- WebProcess/EntryPoint/unix/WebProcessMain.cpp:
(main):
- 2:35 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:32 AM WebKitGTK/2.4.x edited by
- (diff)
- 2:27 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:26 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:32 AM Changeset in webkit [176252] by
-
- 3 edits in trunk/Source/WebKit2
[SOUP] [GnuTLS] Don't use a SSL3.0 record version in client hello.
https://bugs.webkit.org/show_bug.cgi?id=138794
Reviewed by Sergio Villar Senin.
It seems that following POODLE many sites incorrectly banned SSL 3.0
record packet versions. Since GnuTLS uses a SSL 3.0 record to
advertise TLS 1.2, they are effectively banning it even if it doesn't
advertise SSL 3.0. That is a server issue, but it can be worked around
by using the modifier %LATEST_RECORD_VERSION.
With this modifier, GnuTLS will use the latest TLS version record
in client hello instead of using the default SSL 3.0.
- NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:
(main):
- WebProcess/EntryPoint/unix/WebProcessMain.cpp:
(main):
Nov 17, 2014:
- 8:50 PM Changeset in webkit [176251] by
-
- 2 edits in trunk/Source/WebCore
Fix a small indentation mistake in SelectorCodeGenerator::generateNthFilterTest
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-17
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateNthFilterTest):
- 8:30 PM Changeset in webkit [176250] by
-
- 14 edits in trunk/Source/WebCore
Fix two bad function names of HTMLFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=138790
Reviewed by Andreas Kling.
Darin suggested some name improvements in https://bugs.webkit.org/show_bug.cgi?id=138769
- dom/CheckedRadioButtons.cpp:
(WebCore::RadioButtonGroup::add):
(WebCore::RadioButtonGroup::updateCheckedState):
(WebCore::RadioButtonGroup::requiredAttributeChanged):
(WebCore::RadioButtonGroup::remove):
(WebCore::RadioButtonGroup::updateValidityForAllButtons):
(WebCore::RadioButtonGroup::setNeedsValidityCheckForAllButtons): Deleted.
- html/FileInputType.cpp:
(WebCore::FileInputType::setFiles):
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::computeWillValidate):
(WebCore::HTMLButtonElement::recalcWillValidate): Deleted.
- html/HTMLButtonElement.h:
- html/HTMLFieldSetElement.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::requiredAttributeChanged):
(WebCore::HTMLFormControlElement::computeWillValidate):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
(WebCore::HTMLFormControlElement::isValidFormControlElement):
(WebCore::HTMLFormControlElement::updateValidity):
(WebCore::HTMLFormControlElement::setCustomValidity):
(WebCore::HTMLFormControlElement::recalcWillValidate): Deleted.
(WebCore::HTMLFormControlElement::setNeedsValidityCheck): Deleted.
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::runPostTypeUpdateTasks):
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::setValueInternal):
(WebCore::HTMLInputElement::setValueFromRenderer):
(WebCore::HTMLInputElement::computeWillValidate):
(WebCore::HTMLInputElement::parseMaxLengthAttribute):
(WebCore::HTMLInputElement::recalcWillValidate): Deleted.
- html/HTMLInputElement.h:
- html/HTMLKeygenElement.h:
- html/HTMLOutputElement.h:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::deselectItems):
(WebCore::HTMLSelectElement::optionSelectedByUser):
(WebCore::HTMLSelectElement::listBoxSelectItem):
(WebCore::HTMLSelectElement::add):
(WebCore::HTMLSelectElement::parseAttribute):
(WebCore::HTMLSelectElement::childrenChanged):
(WebCore::HTMLSelectElement::optionElementChildrenChanged):
(WebCore::HTMLSelectElement::setLength):
(WebCore::HTMLSelectElement::selectAll):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::parseMultipleAttribute):
(WebCore::HTMLSelectElement::reset):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseAttribute):
(WebCore::HTMLTextAreaElement::subtreeHasChanged):
(WebCore::HTMLTextAreaElement::setValue):
(WebCore::HTMLTextAreaElement::setNonDirtyValue):
- 8:13 PM Changeset in webkit [176249] by
-
- 28 edits1 delete in branches/safari-600.3-branch/Source
Revert r176248
- 7:45 PM Changeset in webkit [176248] by
-
- 28 edits1 copy in branches/safari-600.3-branch/Source
Merge r176164. rdar://problem/18953982
- 7:29 PM Changeset in webkit [176247] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r176150. rdar://problem/18982046
- 7:23 PM Changeset in webkit [176246] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r176148. rdar://problem/18990684
- 7:05 PM Changeset in webkit [176245] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merge r176145. rdar://problem/18989840
- 7:01 PM Changeset in webkit [176244] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merge 176143. rdar://problem/18989840
- 6:31 PM Changeset in webkit [176243] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merge r175492. rdar://problem/18978410
- 6:25 PM Changeset in webkit [176242] by
-
- 4 edits4 copies in branches/safari-600.3-branch
Merge r173293. rdar://problem/18978414
- 6:21 PM Changeset in webkit [176241] by
-
- 15 edits in trunk
Add parsing for :role()
https://bugs.webkit.org/show_bug.cgi?id=138310
Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2014-11-17
Reviewed by Benjamin Poulain.
Source/WebCore:
Add support for parsing :role() pseudo class. The implementation of selector
matching will be in a follow-up patch.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::detectFunctionTypeToken):
- css/CSSSelector.cpp:
(WebCore::appendPseudoClassFunctionTail):
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/SelectorPseudoClassAndCompatibilityElementMap.in:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
LayoutTests:
- fast/css/css-selector-text-expected.txt:
- fast/css/css-selector-text.html:
- fast/css/css-set-selector-text-expected.txt:
- fast/css/css-set-selector-text.html:
- fast/selectors/invalid-functional-pseudo-class-expected.txt:
- fast/selectors/invalid-functional-pseudo-class.html:
- 5:49 PM Changeset in webkit [176240] by
-
- 2 edits in trunk/Source/WebCore
[iOS WK1] Sometimes, missing tiles in -webkit-overflow-scrolling: touch in UIWebViews
https://bugs.webkit.org/show_bug.cgi?id=138815
rdar://problem/18746203
Reviewed by Tim Horton.
The scroll-velocity-related data members on FrameView, added in r168233, were uninitialized in UIWebViews,
so FrameView::computeCoverageRect() could return garbage results, leading to too much or too little tile coverage.
We still add additional coverage from the new inclusion of a margin area, but, for simplicity, leave that the same
between WK1 and WK2 for now.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
- 5:14 PM Changeset in webkit [176239] by
-
- 6 edits8 adds in trunk
Add initial layout testing coverage for timer throttling
https://bugs.webkit.org/show_bug.cgi?id=138809
Reviewed by Simon Fraser.
Source/WebCore:
Add isTimerThrottled() API to Internals so that we can add layout test
coverage for timer throttling.
Tests: fast/dom/nested-timer-invisible-element-throttling.html
fast/dom/nested-timer-visible-element-throttling.html
fast/dom/repeating-timer-invisible-element-throttling.html
fast/dom/repeating-timer-visible-element-throttling.html
- page/DOMTimer.h:
- testing/Internals.cpp:
(WebCore::Internals::isTimerThrottled):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Add initial layout test coverage for timer throttling. It currently
covers the following cases:
- Repeating timer changes the style of an Element that is visible
- Repeating timer changes the style of an Element that is not visible (i.e. "display: none").
- Repeating timer doing DOM mutations
- Nested timer changes the style of an Element that is visible
- Nested timer changes the style of an Element that is not visible (i.e. "display: none").
- Nested timer doing DOM mutations
More layout tests are coming. In particular, we should add coverage for
changing the style of an Element outside the viewport. We should also
Test that the timer gets unthrottled if necessary on scrolling / layout.
- fast/dom/nested-timer-invisible-element-throttling-expected.txt: Added.
- fast/dom/nested-timer-invisible-element-throttling.html: Added.
- fast/dom/nested-timer-visible-element-throttling-expected.txt: Added.
- fast/dom/nested-timer-visible-element-throttling.html: Added.
- fast/dom/repeating-timer-invisible-element-throttling-expected.txt: Added.
- fast/dom/repeating-timer-invisible-element-throttling.html: Added.
- fast/dom/repeating-timer-visible-element-throttling-expected.txt: Added.
- fast/dom/repeating-timer-visible-element-throttling.html: Added.
- 5:13 PM Changeset in webkit [176238] by
-
- 2 edits in trunk/Source/WebKit2
Page previews should be loaded sooner
https://bugs.webkit.org/show_bug.cgi?id=138814
Reviewed by Tim Horton.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController willOpenMenu:withEvent:]):
Send -_createPreviewPopover..
(-[WKActionMenuController _previewURLFromActionMenu:]):
Relocate some logic to the new -_createPreviewPopover; gate early return on popover visibility.
(-[WKActionMenuController _createPreviewPopover]):
Renamed from -_createPreviewPopoverForURL:originRect:; explicitly send -loadView to warm up the preview view.
(-[WKActionMenuController _createPreviewPopoverForURL:originRect:]): Deleted.
- 4:47 PM Changeset in webkit [176237] by
-
- 2 edits in trunk/Source/WebKit2
Preview is sometimes dismissed too early
https://bugs.webkit.org/show_bug.cgi?id=138811
-and corresponding-
rdar://problem/18900839
Reviewed by Tim Horton.
Don’t make the popover transient until didCloseMenu: time.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController _createPreviewPopoverForURL:originRect:]):
- 3:26 PM Changeset in webkit [176236] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove calls to deprecated NSMenu methods
https://bugs.webkit.org/show_bug.cgi?id=138808.
Reviewed by Anders Carlsson.
-[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.
- WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::populate):
- 3:17 PM Changeset in webkit [176235] by
-
- 6 edits2 adds in trunk/Source/WebCore
Simple line layout: Rename FlowContentIterator and move implementation to SimpleLineLayoutFlowContents.cpp
https://bugs.webkit.org/show_bug.cgi?id=138799
Reviewed by Antti Koivisto.
This is in preparation to support multiple renderers.
The FlowContents class will be used not just when we create runs, but also when we resolve them at painting time.
No change in functionality.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::nextFragment):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns):
(WebCore::SimpleLineLayout::createTextRuns):
(WebCore::SimpleLineLayout::FlowContentIterator::FlowContentIterator): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::findNextBreakablePosition): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::findNextNonWhitespacePosition): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::textWidth): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::isNewlineCharacter): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::isEndOfContent): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::style): Deleted.
(WebCore::SimpleLineLayout::computeLineLeft): Deleted.
- rendering/SimpleLineLayoutFlowContents.cpp: Added.
(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContents::textWidth):
- rendering/SimpleLineLayoutFlowContents.h: Added.
(WebCore::SimpleLineLayout::FlowContents::Style::Style):
(WebCore::SimpleLineLayout::FlowContents::style):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
(WebCore::SimpleLineLayout::FlowContents::isEndOfContent):
- 2:36 PM Changeset in webkit [176234] by
-
- 15 edits6 deletes in trunk
Unreviewed, rolling out r176232.
Broke the Mac build. Will investigate offline.
Reverted changeset:
"[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
MobileGestalt"
https://bugs.webkit.org/show_bug.cgi?id=138802
http://trac.webkit.org/changeset/176232
- 2:03 PM Changeset in webkit [176233] by
-
- 9 edits in trunk/Source/JavaScriptCore
Add printing functionality in JITted code for debugging purposes.
<https://webkit.org/b/138660>
Reviewed by Geoffrey Garen.
Sometimes, for debugging, it'd be nice to be able to just print the
values of constants or registers used in JITted code, or even just
a string to log that certain pieces of JITted code have been executed.
Using the JIT probe mechanism, we can make this happen.
- assembler/ARMv7Assembler.h:
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::CPUState::registerName):
(JSC::AbstractMacroAssembler::CPUState::registerValue):
(JSC::AbstractMacroAssembler::print):
(JSC::AbstractMacroAssembler::PrintArg::PrintArg):
(JSC::AbstractMacroAssembler::appendPrintArg):
(JSC::AbstractMacroAssembler::printInternal):
(JSC::AbstractMacroAssembler::printCallback):
- assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::printCPURegisters):
(JSC::MacroAssemblerARM::printRegister):
- assembler/MacroAssemblerARM.h:
- assembler/MacroAssemblerARMv7.cpp:
(JSC::MacroAssemblerARMv7::printCPURegisters):
(JSC::MacroAssemblerARMv7::printRegister):
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerX86Common.cpp:
(JSC::MacroAssemblerX86Common::printRegister):
- assembler/MacroAssemblerX86Common.h:
- 1:59 PM Changeset in webkit [176232] by
-
- 15 edits6 copies in trunk
[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
SPI are not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138802
Reviewed by David Kilzer.
Source/WebCore:
Add SPI wrapper headers {Dispatch, DynamicLinker, IOPMLib, MachVM, NSPointerFunctions, MobileGestalt}SPI.h
that forward declare applicable libdispatch, dyld, IOKit, mach, Foundation, MobileGestalt SPI
and use these headers instead of the including private headers corresponding to these libraries/frameworks.
- WebCore.xcodeproj/project.pbxproj: Add private headers MobileGestaltSPI.h and
MachVMSPI.h, and project headers DynamicLinkerSPI.h, NSPointerFunctionsSPI.h,
DispatchSPI.h and IOPMLibSPI.h. Also, sort files in Xcode project.
- bindings/objc/DOMInternal.mm: Include header NSPointerFunctionsSPI.h.
- bridge/objc/objc_instance.mm: Ditto; Also, sort #import directives.
- platform/cocoa/DisplaySleepDisablerCocoa.cpp: Substitute header IOPMLibSPI.h
for private header IOKit/pwr_mgt/IOPMLib.h.
- platform/cocoa/MemoryPressureHandlerCocoa.mm: Substitute header DispatchSPI.h
for private header dispatch/private.h.
- platform/graphics/ios/FontServicesIOS.mm: Substitute header DynamicLinkerSPI.h
for private header mach-o/dyld_priv.h.
- platform/ios/PlatformScreenIOS.mm: Substitute header MobileGestaltSPI.h for
private header MobileGestalt.h.
- platform/spi/cocoa/DispatchSPI.h: Added.
- platform/spi/cocoa/DynamicLinkerSPI.h: Added.
- platform/spi/cocoa/IOPMLibSPI.h: Added.
- platform/spi/cocoa/MachVMSPI.h: Added.
- platform/spi/cocoa/NSPointerFunctionsSPI.h: Added.
- platform/spi/ios/MobileGestaltSPI.h: Added.
Source/WebKit/mac:
Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
libdispatch and MobileGestalt headers directly.
- WebView/WebView.mm:
Source/WebKit2:
Include headers DispatchSPI.h and MachVMSPI.h.h instead of including
libdispatch and Mach headers directly.
- Platform/mac/SharedMemoryMac.cpp:
- UIProcess/ios/WebMemoryPressureHandlerIOS.mm:
Tools:
Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
- DumpRenderTree/mac/CheckedMalloc.cpp:
- 1:58 PM Changeset in webkit [176231] by
-
- 1 edit in branches/safari-600.3-branch/Source/WebCore/editing/mac/DataDetection.h
Fix build failure. rdar://problem/18877535
- 1:56 PM Changeset in webkit [176230] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merge r176132. <rdar://problem/18979004>
- 1:52 PM Changeset in webkit [176229] by
-
- 10 edits1 add in trunk/Source
[iOS] CoreText and CoreUI SPI are not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138760
Reviewed by David Kilzer.
Source/WebCore:
Add a SPI wrapper header CoreUISPI.h that forward declares CoreUI SPI
and use this header instead of including private headers of CoreUI directly.
Additionally, add more forward declarations for CoreText SPI.
- WebCore.xcodeproj/project.pbxproj: Add project header CoreUISPI.h.
- platform/graphics/ios/FontCacheIOS.mm: Include header CoreTextSPI.h instead
of including CoreText headers directly.
- platform/graphics/mac/FontMac.mm: Include header CoreUISPI.h instead
of including CoreUI headers directly.
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp: Remove unnecessary
include of CoreText headers. These headers will be included by header
CoreTextSPI.h (at the top of the file).
- platform/graphics/mac/SimpleFontDataMac.mm: Remove forward declaration
of CTFontDescriptorIsSystemUIFont() and include of header CTFontDescriptorPriv.h
as this duplicates the logic in CoreTextSPI.h, which is included in this file.
- platform/spi/cocoa/CoreTextSPI.h: Added more forward declarations. Simplified
#include directives.
- platform/spi/ios/CoreUISPI.h: Added.
- rendering/RenderThemeIOS.mm: Move CoreUI externs from this file to file
CoreUISPI.h and include header CoreUISPI.h.
Source/WebKit2:
Include header CoreTextSPI.h instead of including CoreText private headers.
- WebProcess/WebPage/WebPage.cpp:
- 1:52 PM Changeset in webkit [176228] by
-
- 2 edits in trunk/LayoutTests
media/track/track-in-band-cues-added-once.html fails sometimes
https://bugs.webkit.org/show_bug.cgi?id=138806
- platform/mac/TestExpectations: Marked as flaky.
- 1:46 PM Changeset in webkit [176227] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r176131. <rdar://problem/18941927>
- 1:43 PM Changeset in webkit [176226] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merge r176107. <rdar://problem/18977222>
- 1:32 PM Changeset in webkit [176225] by
-
- 3 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merge r176099. <rdar://problem/18877520>
- 1:26 PM Changeset in webkit [176224] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit/mac
Merge r176093. <rdar://problem/18975774>
- 1:14 PM Changeset in webkit [176223] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Drop 16bit support temporarily.
https://bugs.webkit.org/show_bug.cgi?id=138796
Reviewed by Antti Koivisto.
This is in preparation to multiple renderers support.
It requires code refactoring on top of the coming multiple renderers codebase.
(Not expecting any significant coverage shrinking.)
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::FlowContentIterator::findNextBreakablePosition):
(WebCore::SimpleLineLayout::FlowContentIterator::findNextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContentIterator::textWidth):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::nextFragment):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns):
(WebCore::SimpleLineLayout::createTextRuns):
(WebCore::SimpleLineLayout::create):
- 12:59 PM Changeset in webkit [176222] by
-
- 2 edits in trunk/LayoutTests
fast/multicol/newmulticol/spanner-crash.html still crashes sometimes
https://bugs.webkit.org/show_bug.cgi?id=137316
- TestExpectations: Skipped it.
- 12:27 PM Changeset in webkit [176221] by
-
- 9 edits in trunk/Source
DataDetectors PageOverlay callbacks can come in to the wrong overlay
https://bugs.webkit.org/show_bug.cgi?id=138801
<rdar://problem/18991369>
Reviewed by Anders Carlsson.
We can call dataDetectorsDidHideUI on the wrong (or no) PageOverlay,
because it's possible to have another performActionMenuHitTestAtLocation
between the first one and the dataDetectorsDid*UI that correspond to it.
To make sure that the callbacks come to the right PageOverlay, plumb
an integer ID through all of the callbacks and find the overlay based on that.
- Shared/mac/ActionMenuHitTestResult.h:
Store the ID of the PageOverlay that overrode data detection.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
Send the ID back to the Web process when replying from DD callbacks.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performActionMenuHitTestAtLocation):
Store the ID of the PageOverlay that overrode data detection instead of
keeping the PageOverlay itself.
(WebKit::WebPage::dataDetectorsDidPresentUI):
(WebKit::WebPage::dataDetectorsDidChangeUI):
(WebKit::WebPage::dataDetectorsDidHideUI):
Find and reply to the correct page overlay.
- page/PageOverlay.cpp:
(WebCore::generatePageOverlayID):
(WebCore::PageOverlay::PageOverlay):
- page/PageOverlay.h:
Give each PageOverlay a unique ID.
- 12:09 PM Changeset in webkit [176220] by
-
- 9 edits in trunk/Source
Whitespace action menus should focus the HitTestResult and create an insertion
point
https://bugs.webkit.org/show_bug.cgi?id=138786
-and corresponding-
rdar://problem/18944893
Reviewed by Tim Horton.
Whitespace menus should cause the HitTestResult to be focused, and they should set
the selection based on the HitTest location.
Source/WebKit/mac:
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController isMenuForTextContent]):
(-[WebActionMenuController focusAndSelectHitTestResult]):
(-[WebActionMenuController willOpenMenu:withEvent:]):
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::focusAndSelectLastActionMenuHitTestResult):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController isMenuForTextContent]):
(-[WKActionMenuController willOpenMenu:withEvent:]):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performActionMenuHitTestAtLocation):
(WebKit::WebPage::focusAndSelectLastActionMenuHitTestResult):
- 11:58 AM Changeset in webkit [176219] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix JavaScriptCore build with newer versions of clang.
<rdar://problem/18978716>
- heap/Heap.cpp:
(JSC::Heap::visitTempSortVectors):
(JSC::Heap::deleteAllCompiledCode): Deleted.
- inspector/agents/InspectorConsoleAgent.h:
- 11:52 AM Changeset in webkit [176218] by
-
- 29 edits5 adds in trunk
[CSS Grid Layout] Upgrade align-self and align-items parsing to CSS 3
https://bugs.webkit.org/show_bug.cgi?id=133359
Reviewed by David Hyatt.
Source/WebCore:
Broaden justify-self's parsing name as a preparation of migrating
align-self, align-items and justify-items to the CSS 3 Alignment syntax.
The current naming was too tied to justify-self and needs to
be broadened. This will reduce the follow-up implementations'
patches.
Upgrade align-self and align-items parsing to CSS 3
This change migrates the 2 properties to the CSS 3 Alignment
parsing. The new parsing is identical to how we parse
'justify-self'. The 2 properties need to be migrated together
as they are used in tandem in CSSComputedStyleDeclaration.
This change also removes EAlignItems as it is now unused.
Tests: css3/parse-align-items.html
css3/parse-align-self.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForItemPositionWithOverflowAlignment): Added. Builds the CSSValue for the for the alignment properties.
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::isKeywordPropertyID): Removed align-items and align-self from the list.
(WebCore::isValidKeywordPropertyAndValue): Removed align-items and align-self from the list.
(WebCore::CSSParser::parseValue): Added align-items and align-self to the list and call to the generic parsing fuction for the alignment properties.
(WebCore::isBaselinePositionKeyword): Utility function added to identify Baseline keyword values.
(WebCore::CSSParser::parseItemPositionOverflowPosition): Generic parsing fuction for the alignment properties.
(WebCore::CSSParser::parseJustifySelf): Deleted.
- css/CSSParser.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Refactoring some mapping functions.
(WebCore::CSSPrimitiveValue::operator ItemPosition): Added. Replace the old EAlignItems enumeration.
(WebCore::CSSPrimitiveValue::operator OverflowAlignment): Added.
(WebCore::CSSPrimitiveValue::operator EAlignItems): Deleted.
(WebCore::CSSPrimitiveValue::operator EJustifySelf): Deleted.
(WebCore::CSSPrimitiveValue::operator EJustifySelfOverflowAlignment): Deleted.
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle): Added a new adjustment to resolve the "auto" vale on the alignment properties.
(WebCore::StyleResolver::adjustStyleForAlignment): Added. Function to resolve the "auto" vale on the alignment properties.
(WebCore::StyleResolver::applyProperty):
(WebCore::isDisplayFlexibleBox): Deleted. Moved to the RenderStyle.
(WebCore::isDisplayGridBox): Deleted. Moved to the RenderStyle.
(WebCore::isDisplayFlexibleOrGridBox): Deleted. Moved to the RenderStyle.
- css/StyleResolver.h:
- rendering/RenderBox.cpp:
(WebCore::flexItemHasStretchAlignment): Adapted to the new ItemPosition enum.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::firstLineBaseline): Adapted to the new ItemPosition enum.
(WebCore::resolveAlignment): Consider also that align-items could be "auto", since it's the default now.
(WebCore::RenderFlexibleBox::styleDidChange): Adapted to the new ItemPosition enum.
(WebCore::RenderFlexibleBox::alignmentForChild): Adapted to the new ItemPosition enum.
(WebCore::RenderFlexibleBox::needToStretchChild): Adapted to the new ItemPosition enum.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Adapted to the new ItemPosition enum.
(WebCore::RenderFlexibleBox::alignChildren): Adapted to the new ItemPosition enum.
- rendering/RenderFlexibleBox.h:
- rendering/RenderFullScreen.cpp:
(WebCore::createFullScreenStyle): Adapted to the new ItemPosition enum.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::adjustInnerStyle): Adapted to the new ItemPosition enum.
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::updateStyle): Adapted to the new ItemPosition enum.
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::fixAnonymousStyleForSubSupPair): Adapted to the new ItemPosition enum.
(WebCore::RenderMathMLScripts::fixAnonymousStyles): Adapted to the new ItemPosition enum.
- rendering/style/RenderStyle.h: Adapted to the new ItemPosition enum.
- rendering/style/RenderStyleConstants.h: Adapted to the new ItemPosition enum.
- rendering/style/StyleRareNonInheritedData.cpp: Adapted to the new ItemPosition enum.
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Adapted to the new ItemPosition enum.
(WebCore::StyleRareNonInheritedData::operator==): Adapted to the new ItemPosition enum.
- rendering/style/StyleRareNonInheritedData.h: Adapted to the new ItemPosition enum.
- style/StyleResolveTree.cpp:
(WebCore::Style::determineChange): Changes in the alignItems property will cause a Detach.
LayoutTests:
From Blink r164817 and r165264 by <jchaffraix@chromium.org>
Broaden justify-self's parsing name and upgrade align-self and
align-items parsing to CSS 3.
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/css-properties.html:
- css3/parse-align-items-expected.txt: Added.
- css3/parse-align-items.html: Added.
- css3/parse-align-self-expected.txt: Added.
- css3/parse-align-self.html: Added.
- css3/resources/alignment-parsing-utils.js: Added.
(checkValues):
(checkBadValues):
(checkInitialValues):
(checkInheritValues):
(checkLegacyValues):
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/resources/property-names.js:
- svg/css/getComputedStyle-basic-expected.txt:
- platform/gtk/TestExpectations: Report new failures and update expectations.
- 11:48 AM Changeset in webkit [176217] by
-
- 3 edits in trunk/Source/WTF
Fix WTF build with newer versions of clang.
<rdar://problem/18978705>
- wtf/HashTable.h:
(WTF::removeIterator):
- wtf/dtoa/utils.h:
(WTF::double_conversion::BitCast):
- 11:45 AM Changeset in webkit [176216] by
-
- 6 edits in branches/safari-600.3-branch/Source
Merged r176156. rdar://problem/18877535
- 11:44 AM Changeset in webkit [176215] by
-
- 6 edits in branches/safari-600.3-branch/Source
Merged r176153. rdar://problem/18877535
- 11:36 AM Changeset in webkit [176214] by
-
- 9 edits4 copies2 deletes in branches/safari-600.3-branch/Source
Merged r176137. rdar://problem/18877535
- 11:24 AM Changeset in webkit [176213] by
-
- 5 edits2 adds in trunk
Attribute text in HTMLAnchorElement should behave as per specification.
https://bugs.webkit.org/show_bug.cgi?id=138557
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-11-17
Reviewed by Darin Adler.
Source/WebCore:
attribute text in HTMLAnchorElement should not be readonly as per specification
http://www.w3.org/TR/html/text-level-semantics.html#dom-a-text. It should behave as textContent attribute.
Also This matches the behavior of Chrome 38 and FireFox.
Test: fast/dom/HTMLAnchorElement/anchor-text-attribute.html
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::text):
(WebCore::HTMLAnchorElement::setText):
- html/HTMLAnchorElement.h:
- html/HTMLAnchorElement.idl:
LayoutTests:
- fast/dom/HTMLAnchorElement/anchor-text-attribute-expected.txt: Added.
- fast/dom/HTMLAnchorElement/anchor-text-attribute.html: Added.
- 11:23 AM Changeset in webkit [176212] by
-
- 16 edits in trunk/Source/WebCore
Throttle timers that change the style of elements outside the viewport
https://bugs.webkit.org/show_bug.cgi?id=138292
Reviewed by Antti Koivisto.
Throttle timers that change the style of elements outside the viewport
to 1 second, similarly to what was already done for timers interacting
with non user observable plugins. To be conservative, we don't throttle
timers that also cause DOM Tree modifications (e.g. adding/removing
nodes, modify element attributes).
On huffingtonpost.com, the CPU usage is at ~17% when the top scrolling
banner is inside the viewport on my machine. Without this patch, CPU
usage would stay ~17% when the banner is outside the viewport. Thanks
to timer throttling, CPU usage now goes down to ~1.5%, without user
observable side effects. The timers get unthrottled when they are
inside the viewport again (i.e. due to scrolling or layout).
On espn.com, the CPU usage goes down from ~7% at the top of the page
to ~1% when scrolling to the bottom of the page. On ebay.com, CPU
usage goes down from ~25% at the top of the page to less than 1% when
scrolling to the bottom of the page.
- 11:06 AM Changeset in webkit [176211] by
-
- 3 edits in trunk/Tools
Having 30+ flaky failures breaks EWS
https://bugs.webkit.org/show_bug.cgi?id=138743
Patch by Jake Nielsen <jacob_nielsen@apple.com> on 2014-11-17
Reviewed by Alexey Proskuryakov.
Adds tests to ensure that the problem has been solved.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(test_first_failure_limit):
(test_first_failure_limit_with_some_tree_redness):
(test_second_failure_limit):
(test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
(test_first_and_second_failure_limit):
(test_first_and_clean_failure_limit):
(test_first_second_and_clean_failure_limit):
(test_very_red_tree_retry): Deleted.
Really this was renamed to test_first_second_and_clean_failure_limit.
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
Makes the appropriate changes to PatchAnalysisTask to make sure that
even when the first test run hits the failure limit, it will still try
a second run.
(PatchAnalysisTask._results_failed_different_tests):
(PatchAnalysisTask._test_patch):
(PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
- 10:58 AM Changeset in webkit [176210] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error, CoreGraphics header file included.
https://bugs.webkit.org/show_bug.cgi?id=138795
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-17
Reviewed by Brent Fulgham.
CoreGraphics is not available on WinCairo.
- platform/graphics/win/FontCacheWin.cpp:
- 10:56 AM Changeset in webkit [176209] by
-
- 2 edits in trunk/LayoutTests
media/track/track-cues-sorted-before-dispatch.html is flaky on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=138798
- platform/mac/TestExpectations: Marked it as such.
- 10:48 AM Changeset in webkit [176208] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r176169.
https://bugs.webkit.org/show_bug.cgi?id=138797
Appears to have broken svg/custom/anchor-on-use.svg (Requested
by ap on #webkit).
Reverted changeset:
"Attribute text in HTMLAnchorElement should behave as per
specification."
https://bugs.webkit.org/show_bug.cgi?id=138557
http://trac.webkit.org/changeset/176169
- 10:42 AM Changeset in webkit [176207] by
-
- 4 edits in trunk/Source/JavaScriptCore
Update WebKit to build with LLVM TOT
https://bugs.webkit.org/show_bug.cgi?id=138519
Patch by Juergen Ributzka <juergen@apple.com> on 2014-11-17
Reviewed by Alexey Proskuryakov.
- Configurations/LLVMForJSC.xcconfig:
- llvm/LLVMAPIFunctions.h:
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
- 10:30 AM Changeset in webkit [176206] by
-
- 6 edits2 adds in trunk/Source
[iOS] AVKit and MediaPlayer SPI are not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138756
Reviewed by Eric Carlson.
Source/WebCore:
Add a SPI wrapper headers {AVKit, MPAVRoutingController}SPI.h that forward declares
AVKit and MPAVRoutingController SPI, respectively, and use these header instead of
including private headers of AVKit and MediaPlayer directly.
- WebCore.xcodeproj/project.pbxproj: Add project and private header AVKitSPI.h
and MPAVRoutingControllerSPI.h, respectively.
- platform/audio/ios/MediaSessionManagerIOS.mm: Include header MPAVRoutingControllerSPI.h
instead of including the private header MPAVRoutingController.h.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm: Include header AVKitSPI.h
instead of including AVKit headers directly.
Source/WebKit2:
Include header MPAVRoutingControllerSPI.h instead of including the
private header MPAVRoutingController.h.
Additionally, sort the list of #import directives.
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
- 9:56 AM Changeset in webkit [176205] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Mac build after <https://trac.webkit.org/changeset/176204>
(https://bugs.webkit.org/show_bug.cgi?id=138751)
Move declaration of CAContext to be before the declaration of CALayer since
the latter depends on the former.
- platform/spi/cocoa/QuartzCoreSPI.h:
- 9:44 AM Changeset in webkit [176204] by
-
- 19 edits1 add1 delete in trunk/Source
[iOS] QuartzCore SPI not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138751
Reviewed by David Kilzer.
Source/WebCore:
Add a SPI wrapper header called QuartzCoreSPI.h that forward declares
QuartzCore SPI and use this header instead of including private headers
of QuartzCore directly.
- WebCore.xcodeproj/project.pbxproj: Added private header QuartzCoreSPI.h.
- platform/graphics/ca/mac/PlatformCAFiltersMac.h: Removed; incorporated its
functionality into QuartzCoreSPI.h.
- platform/graphics/ca/mac/PlatformCAFiltersMac.mm: Substitute header
QuartzCoreSPI.h for PlatformCAFiltersMac.h as the content of the latter
was incorporated into the former.
- platform/graphics/ca/mac/PlatformCALayerMac.mm: Move CALayer and CATiledLayer
forward declarations from this file to file QuartzCoreSPI.h and include
header QuartzCoreSPI.h instead of including CATiledLayerPrivate.h directly. Also
remove header PlatformCAFiltersMac.h as its content is incorporated into QuartzCoreSPI.h
- platform/ios/LegacyTileCache.mm: Include headers CoreGraphicsSPI.h and QuartzCoreSPI.h
instead of including QuartzCore headers directly.
- platform/ios/LegacyTileGrid.mm: Include header QuartzCoreSPI.h instead
of including QuartzCore headers directly. Also sort the list of #include directives.
- platform/ios/LegacyTileGridTile.mm: Include header QuartzCoreSPI.h
instead of including QuartzCore headers directly.
- platform/spi/cocoa/QuartzCoreSPI.h: Added.
Source/WebKit/mac:
Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.
- WebInspector/WebNodeHighlight.mm:
- WebView/WebIndicateLayer.mm:
Source/WebKit2:
- Shared/mac/RemoteLayerBackingStore.mm: Move CALayer forward declaration
from this file to file QuartzCoreSPI.h and include header QuartzCoreSPI.h.
- Shared/mac/RemoteLayerTreePropertyApplier.mm: Ditto.
- UIProcess/API/Cocoa/WKWebView.mm: Include header QuartzCoreSPI.h instead
of including QuartzCore headers directly.
- UIProcess/ios/ViewGestureControllerIOS.mm: Ditto.
- UIProcess/ios/WKContentView.mm: Ditto.
- UIProcess/ios/WKPDFPageNumberIndicator.mm: Ditto.
- UIProcess/mac/ViewGestureControllerMac.mm: Move CAFilter forward declarations
from this file to fileQuartzCoreSPI.h and include header QuartzCoreSPI.h.
Also sort the list of #import directives.
- UIProcess/mac/ViewSnapshotStore.mm: Include header QuartzCoreSPI.h
instead of including QuartzCore headers directly.
- 9:07 AM Changeset in webkit [176203] by
-
- 3 edits in trunk/Websites/perf.webkit.org
App.Manifest shouldn't use App.container.lookup
https://bugs.webkit.org/show_bug.cgi?id=138768
Reviewed by Andreas Kling.
Removed the hack to find the store object via App.container.lookup.
Pass around the store object instead.
- public/v2/app.js:
(App.DashboardRow._createPane): Add "store" property to the pane.
(App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
(App.IndexController.gridChanged): Ditto.
(App.IndexController.actions.addRow): Ditto.
(App.IndexController.init): Ditto.
(App.Pane._fetch): Ditto.
(App.ChartsController._parsePaneList): Ditto.
(App.ChartsController._updateQueryString): Ditto.
(App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
(App.BuildPopup): Ditto.
(App.AnalysisTaskRoute.model): Ditto.
(App.AnalysisTaskViewModel._taskUpdated): Ditto.
- public/v2/manifest.js:
(App.Manifest.fetch): Removed the code to find the store object.
- 8:43 AM Changeset in webkit [176202] by
-
- 5 edits in trunk/Source/WebCore
Move more CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138766
Reviewed by Darin Adler.
Move more CSS properties from DeprecatedStyleBuilder to the new
StyleBuilder:
line-height
word-spacing
-webkit-marquee-repetition
-webkit-text-underline-position
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::csstoLengthConversionDataWithTextZoomFactor): Deleted.
(WebCore::ApplyPropertyMarqueeRepetition::applyValue): Deleted.
(WebCore::ApplyPropertyMarqueeRepetition::createHandler): Deleted.
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue): Deleted.
(WebCore::ApplyPropertyTextUnderlinePosition::createHandler): Deleted.
(WebCore::ApplyPropertyLineHeight::applyValue): Deleted.
(WebCore::ApplyPropertyLineHeight::createHandler): Deleted.
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue): Deleted.
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyInitialValue): Deleted.
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyInheritValue): Deleted.
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::createHandler): Deleted.
(WebCore::ApplyPropertyWordSpacing::applyValue): Deleted.
(WebCore::ApplyPropertyWordSpacing::createHandler): Deleted.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertMarqueeRepetition):
(WebCore::StyleBuilderConverter::convertTextUnderlinePosition):
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderFunctions::csstoLengthConversionDataWithTextZoomFactor):
(WebCore::StyleBuilderFunctions::convertLineHeight):
(WebCore::StyleBuilderFunctions::applyValueWordSpacing):
(WebCore::StyleBuilderFunctions::applyInheritLineHeight):
(WebCore::StyleBuilderFunctions::applyInitialLineHeight):
(WebCore::StyleBuilderFunctions::applyValueLineHeight):
- 8:22 AM Changeset in webkit [176201] by
-
- 8 edits in trunk
Avoid synchronous style recalc when mutating a Node inside FrameSelection.
<https://webkit.org/b/138791>
Reviewed by Antti Koivisto.
Source/WebCore:
We can safely clear the RenderView's selection without doing a synchronous
style recalc first.
This is a small progression on Speedometer locally.
- editing/FrameSelection.cpp:
(WebCore::DragCaretController::nodeWillBeRemoved):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::clearRenderViewSelection): Deleted.
Merged clearRenderViewSelection() into the call sites and removed
the now-unnecessary protection of the Document.
LayoutTests:
Rebaseline fast/dynamic/move-node-with-selection.html.
This is a progression, we avoid littering the render tree with some empty
text renderers due to deferring the style recalc in selection clearing.
- platform/efl/fast/dynamic/move-node-with-selection-expected.txt:
- platform/gtk/fast/dynamic/move-node-with-selection-expected.txt:
- platform/ios-sim-deprecated/fast/dynamic/move-node-with-selection-expected.txt:
- platform/ios-simulator/fast/dynamic/move-node-with-selection-expected.txt:
- platform/mac/fast/dynamic/move-node-with-selection-expected.txt:
- 6:41 AM Changeset in webkit [176200] by
-
- 2 edits in trunk/LayoutTests
[EFL] Skip timeouting editing tests
https://bugs.webkit.org/show_bug.cgi?id=138693
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-11-17
Reviewed by Csaba Osztrogonác.
- platform/efl/TestExpectations:
- 6:07 AM Changeset in webkit [176199] by
-
- 20 edits in trunk/Source
[iOS] allow host application to opt-out of alternate fullscreen
https://bugs.webkit.org/show_bug.cgi?id=138787
Reviewed by Darin Adler.
Source/WebCore:
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::optimizedFullscreenSupported): Check mediaSession().allowsAlternateFullscreen.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreenOptimized): Do nothing if
mediaSession().allowsAlternateFullscreen says it isn't allowed.
- html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::allowsAlternateFullscreen): New, check settings.
- html/HTMLMediaSession.h:
- page/Settings.cpp: Add allowsAlternateFullscreen.
- page/Settings.in: Ditto.
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences allowsAlternateFullscreen]):
(-[WebPreferences setAllowsAlternateFullscreen:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAllowsAlternateFullscreen):
(WKPreferencesGetAllowsAlternateFullscreen):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 2:48 AM Changeset in webkit [176198] by
-
- 2 edits in trunk/Tools
[GTK] Add library search paths from LDFLAGS before pkg-config --libs
https://bugs.webkit.org/show_bug.cgi?id=136018
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-11-17
Reviewed by Carlos Garcia Campos.
It is possible that the order of -L arguments in the output of
pkg-config is wrong, which causes the linker to find the wrong
version (usually older version) of libraries when running
gtkdoc-scangobj.
- gtk/gtkdoc.py:
(GTKDoc._run_gtkdoc_scangobj):
- 2:27 AM Changeset in webkit [176197] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Skip more tests failing after r175776.
There is no network load scheduling or prioritization with NetworkProcess.
- platform/gtk/TestExpectations:
- 1:53 AM Changeset in webkit [176196] by
-
- 2 edits in trunk/Tools
Bump EFL version to 1.12.0
https://bugs.webkit.org/show_bug.cgi?id=138733
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- 1:06 AM Changeset in webkit [176195] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176170 - Assertion hit when setting a very large value to 'border-width' / 'font-size' CSS properties
https://bugs.webkit.org/show_bug.cgi?id=138770
Reviewed by Darin Adler.
Source/WebCore:
When setting a very large value to a CSS property, it is represented internally as
infinity. r166114 already tried to deal with this by adding an std::isinf() check
in CSSValuePool::createValue() and returning an identifier CSSPrimitiveValue with
CSSValueInvalid value in such case. The issue is that doing leads to the
StyleBuilder getting a CSSValueInvalid CSSPrimitive value as input, which is not
handled and leads to assertions.
This patch updates the CSSParser to detect cases where the double value is
infinity earlier (in CSSParser::validUnit() and parseSimpleLengthValue()), so
that we mark the value as invalid and actually drop it. As a result,
CSSPrimitiveValues with CSSValueInvalid value no longer make their way to the
StyleBuilder.
Test: fast/css/style-builder-infinite-value.html
fast/css/infinite-floating-value.html
- css/CSSParser.cpp:
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::validUnit):
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createValue):
LayoutTests:
Add a layout test setting very large values to 'border-width' and
'font-size' CSS properties.
- fast/css/style-builder-infinite-value-expected.txt: Added.
- fast/css/style-builder-infinite-value.html: Added.
- 1:05 AM Changeset in webkit [176194] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176169 - Attribute text in HTMLAnchorElement should behave as per specification.
https://bugs.webkit.org/show_bug.cgi?id=138557
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-11-16
Reviewed by Darin Adler.
Source/WebCore:
attribute text in HTMLAnchorElement should not be readonly as per specification
http://www.w3.org/TR/html/text-level-semantics.html#dom-a-text. It should behave as textContent attribute.
Also This matches the behavior of Chrome 38 and FireFox.
Test: fast/dom/HTMLAnchorElement/anchor-text-attribute.html
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::text):
(WebCore::HTMLAnchorElement::setText):
- html/HTMLAnchorElement.h:
- html/HTMLAnchorElement.idl:
LayoutTests:
- fast/dom/HTMLAnchorElement/anchor-text-attribute-expected.txt: Added.
- fast/dom/HTMLAnchorElement/anchor-text-attribute.html: Added.
- 12:52 AM Changeset in webkit [176193] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176163 - AX: [ATK] REGRESSION(r166288): Accessible values are no longer accessible via AT-SPI2
https://bugs.webkit.org/show_bug.cgi?id=138776
Reviewed by Chris Fleizach.
r166288 used #if...#else instead of #if...#endif, thus disabling the old
AtkValue support. Unfortunately AT-SPI2 doesn't yet have support for the
new AtkValue API. Thus r166288 broke access to value-holding elements for
AT-SPI2 assistive technologies. Replacing #else with #endif fixes things.
No new tests because catching this regression would require AT-SPI2.
- accessibility/atk/WebKitAccessibleInterfaceValue.cpp:
(webkitAccessibleValueGetMinimumIncrement):
(webkitAccessibleValueInterfaceInit):
- 12:49 AM Changeset in webkit [176192] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2
Merge r176154 - Network process crash when running http/tests/appcache/fallback.html
https://bugs.webkit.org/show_bug.cgi?id=138740
Reviewed by Alexey Proskuryakov.
It happens because ResourceHandle::continueWillSendRequest() is
called with a null request. We could handle that case in the
ResourceHandle, but the thing is tha the behaviour is
not the same for async loads, or when loading in the web
process. In WebResourceLoader::willSendRequest(),
ResourceRequest::willSendRequest() is called, and cancels the load
if the client returns a null request. In this case, the
ResourceLoader is detached and WebResourceLoader::willSendRequest()
returns early without sending the ContinueWillSendRequest message
to the network process. However, for synchronous loads,
NetworkResourceLoader::continueWillSendRequest() is always called.
Fixes http/tests/appcache/fallback.html for GTK port when using
the network process.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueWillSendRequest): Do not
call ResourceHandle::continueWillSendRequest() if the client
request is null, since the load is going to be cancelled.
- 12:46 AM Changeset in webkit [176191] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176124 - Table rows repaint entire table when their background color changes.
https://bugs.webkit.org/show_bug.cgi?id=26662
Reviewed by Simon Fraser.
Added fast/repaint/table-row-repaint.html
Source/WebCore:
- rendering/RenderTableCell.h:
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
Improve table row's function to unite with the cell rects that can possibly
have the the row's background color painted behind them.
LayoutTests:
- fast/repaint/table-row-repaint-expected.txt: Added.
- fast/repaint/table-row-repaint.html: Added.
- platform/mac/accessibility/table-detection-expected.txt:
- 12:39 AM Changeset in webkit [176190] by
-
- 3 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r176120 - [SOUP] Use GMainLoopSource for request timeout in ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=138695
Reviewed by Sergio Villar Senin.
We are currently using soup_timeout_add() that simply creates a
GSource and attaches it to the given context. Using
GMainLoopSource we simplify the code and fix any potential problem
of converting the double value into milliseconds.
- platform/network/ResourceHandleInternal.h:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation):
(WebCore::ResourceHandle::sendPendingRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::requestTimeoutCallback): Deleted.
- 12:37 AM Changeset in webkit [176189] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2
Merge r176119 - [SOUP] Encode/Decode allowCookies in ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=138730
Reviewed by Sergio Villar Senin.
We are not sending this information to the network process, making
cookies always available. Fixes
http/tests/xmlhttprequest/cross-origin-no-authorization.html when
network process is enabled.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
- 12:27 AM Changeset in webkit [176188] by
-
- 4 edits in releases/WebKitGTK/webkit-2.6
Merge r176096 - Policy client not called for navigations through the page cache
https://bugs.webkit.org/show_bug.cgi?id=138703
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test added to TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadDifferentDocumentItem): When using a cached page, which already
has a document loader, set the document loader’s triggering action (so that the policy
client sees that this is a back/forward navigation) and clear its last checked request (so
that the policy client gets called).
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
(-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
(-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
- 12:23 AM Changeset in webkit [176187] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore
Merge r176151 - STRH can store values with the wrong offset
https://bugs.webkit.org/show_bug.cgi?id=138723
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-14
Reviewed by Michael Saboff.
This is the counterpart of r176083 for the str instruction.
I believe this code is currently unreachable because there is only one client of strh()
in the MacroAssembler and it always setup the scale explicitely.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::strh):
- 12:22 AM Changeset in webkit [176186] by
-
- 4 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore
Merge r176083 - ARMv7(s) Assembler: LDRH with immediate offset is loading from the wrong offset
https://bugs.webkit.org/show_bug.cgi?id=136914
Reviewed by Michael Saboff.
TLDR: the immediate offset of half-word load was divided by 2.
Story time: So I started getting those weird reports of :nth-child() behaving bizarrely
on ARMv7 and ARMv7s. To make things worse, the behavior changes depending on style updates.
I started looking the disassembly on the tests cases...
The first thing I noticed was that the computation of An+B looked wrong. For example,
in the case of n+6, the instruction should have been:
but was
After spending a lot of time trying to find the error in the assembler, I discovered
the problem was not real, but just a bug in the disassembler.
This is the first fix: ARMv7DOpcodeAddSubtractImmediate3's immediate3() was truncating
the value to 2 bits instead of 3 bits.
The disassembler being fixed, I still have no lead on the weird bug. Some disassembly later,
I realize the LDRH instruction is not decoded at all. The reason is that both LDRH and STRH
were under the umbrella ARMv7DOpcodeLoadStoreRegisterImmediateHalfWord but the pattern
only matched SRTH.
I fix that next, ARMv7DOpcodeLoadStoreRegisterImmediateHalfWord is split into
ARMv7DOpcodeStoreRegisterImmediateHalfWord and ARMv7DOpcodeLoadRegisterImmediateHalfWord,
each with their own pattern and their instruction group.
Now that I can see the LDRHs correctly, there is something fishy about them, their offset
is way too small for the data I load.
This time, looking at the binary, the generated code is indeed incorrect. It turns out that
the ARMv7 assembler shifted the offset of half-word load as if they were byte load: divided by 4.
As a result, all the load of half-words with more than zero offset were loading
values with a smaller offset than what they should have.
That being fixed, I dump the assembly: still wrong. I am ready to throw my keyboard through
my screen at that point.
Looking at the disassembler, there is yet again a bug. The computation of the scale() adjustment
of the offset was incorrect for anything but word loads.
I replaced it by a switch-case to make it explicit.
STRH is likely incorrect too. I'll fix that in a follow up, I want to survey all the 16 bits cases
that are not directly used by the CSS JIT.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::ldrh):
Fix the immediate scaling. Add an assertion to make sure the alignment of the input is correct.
- disassembler/ARMv7/ARMv7DOpcode.cpp:
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::scale):
Fix the scaling code. Just hardcode instruction-to-scale table.
- disassembler/ARMv7/ARMv7DOpcode.h:
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::immediate3):
The mask for a 3 bits immediate is not 3 :)
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::scale): Deleted.
- 12:20 AM Changeset in webkit [176185] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176082 - REGRESSION (r172826): Password field placeholder text is missing if
placeholder attribute precedes type attribute
<https://bugs.webkit.org/show_bug.cgi?id=138682>
<rdar://problem/18574213>
Source/WebCore:
When the placeholder attribute is encountered, a shadow tree is created
to include the placeholder element. When the type attribute is
encountered, the previous shadow tree is destroyed, and a new shadow
tree is created. TextFieldInputType::createShadowSubtree() did not
handle creating the placeholder element.
This regressed in r172826 because prior to r172826, the placeholder
element would be recreated when
HTMLTextFormControlElement::updatePlaceholderVisibility() was called.
In r172826, updatePlaceholderVisibility() was changed to only show or
hide the placeholder element if it exists.
Reviewed by Benjamin Poulain.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
Call updatePlaceholderVisibility() to insert the placeholder element
(after the inner text element has been inserted, as it appears before
it in the shadow DOM).
LayoutTests:
Reviewed by Benjamin Poulain.
- fast/forms/placeholder-attribute-ordering-expected.html: Added.
- fast/forms/placeholder-attribute-ordering.html: Added.
- 12:18 AM Changeset in webkit [176184] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2
Merge r176071 - [SOUP] Missing ResourceRequest members encoded/decoded
https://bugs.webkit.org/show_bug.cgi?id=138694
Reviewed by Sergio Villar Senin.
At least timeoutInterval and priority should also be
encoded/decoded. This fixes all http/tests/xmlhttprequest/timeout/
tests when using the network process, since the timeout is always
0 for all requests that we send to the network process.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
Nov 16, 2014:
- 11:59 PM Changeset in webkit [176183] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r175965 - [Frame Flattening] ASSERT(transaction->view == &view()) fails in RenderBlock::removeFromUpdateScrollInfoAfterLayoutTransaction()
https://bugs.webkit.org/show_bug.cgi?id=138615
<rdar://problem/18928487>
Reviewed by David Hyatt.
Source/WebCore:
Fixes an issue where we always expected that the RenderView associated with the RenderBlock called in
RenderBlock::removeFromUpdateScrollInfoAfterLayoutTransaction() is the same as the RenderView associated with
the top transaction in the UpdateScrollInfoAfterLayoutTransaction stack regardless of frame flattening. This
expectation is only true when frame flattening is disabled.
Test: fast/frames/flattening/iframe-flattening-inside-flexbox-with-delayed-scroll-update.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFromUpdateScrollInfoAfterLayoutTransaction):
LayoutTests:
Add a test that causes an assertion failure in affected builds.
- fast/frames/flattening/iframe-flattening-inside-flexbox-with-delayed-scroll-update-expected.txt: Added.
- fast/frames/flattening/iframe-flattening-inside-flexbox-with-delayed-scroll-update.html: Added.
- 11:50 PM Changeset in webkit [176182] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r175809 - Crash in WebCore::Node::getFlag
https://bugs.webkit.org/show_bug.cgi?id=137961
Reviewed by Antti Koivisto.
Source/WebCore:
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle): Null pointer check added.
LayoutTests:
- editing/execCommand/crash-137961-expected.txt: Added.
- editing/execCommand/crash-137961.html: Added.
- 11:48 PM Changeset in webkit [176181] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r175807 - ASSERTION FAILED: !object !object->parent()->isRuby() is<RenderRubyRun>(*object) (object->isInline() && (object->isBeforeContent() object->isAfterContent())) (object->isAnonymous() && ... ) in WebCore::isAnonymousRubyInlineBlock https://bugs.webkit.org/show_bug.cgi?id=137958
Reviewed by Chris Dumez.
Source/WebCore:
When a ruby element, with block behavior, dynamically changes its style
from multicol to without multicol, we have to remove its special children,
RenderMultiColumnFlowThread and RenderMultiColumnSet, the normal way using
the method in RenderBlockFlow base class. This patch adds both
RenderMultiColumnFlowThread and RenderMultiColumnSet to the list of RenderRuby
children removed normally and adds a new function - isRubyChildForNormalRemove -
to test the condition and use it in the assertion in RenderRuby*::removeChild
method.
Test: fast/multicol/newmulticol/ruby-from-multicol-to-auto.html
- rendering/RenderRuby.cpp:
(WebCore::isRubyChildForNormalRemove):
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::removeChild):
LayoutTests:
- fast/multicol/newmulticol/ruby-from-multicol-to-auto-expected.txt: Added.
- fast/multicol/newmulticol/ruby-from-multicol-to-auto.html: Added.
- 11:44 PM Changeset in webkit [176180] by
-
- 12 edits in trunk/Source/WebCore
Replace RenderSVGResource::cast<T>() with downcast<T>()
https://bugs.webkit.org/show_bug.cgi?id=138290
Reviewed by Chris Dumez.
Add type traits for the RenderSVGResource hierarchy. This enables
using the typecasting framework in getRenderSVGResourceById() that
in return renders the RenderSVGResource::cast<>() template and all
the static s_resourceType member variables in the hierarchy removable.
- WebCore.order:
- rendering/svg/RenderSVGResource.h:
(WebCore::RenderSVGResource::cast): Deleted.
- rendering/svg/RenderSVGResourceClipper.h:
- rendering/svg/RenderSVGResourceContainer.h:
(WebCore::getRenderSVGResourceById):
- rendering/svg/RenderSVGResourceFilter.h:
(isType):
- rendering/svg/RenderSVGResourceLinearGradient.h:
- rendering/svg/RenderSVGResourceMarker.h:
- rendering/svg/RenderSVGResourceMasker.h:
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/RenderSVGResourceRadialGradient.h:
- rendering/svg/RenderSVGResourceSolidColor.h:
- 11:43 PM Changeset in webkit [176179] by
-
- 3 edits2 adds1 delete in releases/WebKitGTK/webkit-2.6/Source/WebInspectorUI
Merge r176080 - Web Inspector: Replace PDF Probes icon with SVG version
https://bugs.webkit.org/show_bug.cgi?id=137296
Reviewed by Joseph Pecoraro.
- UserInterface/Images/NavigationItemProbes.pdf: Removed.
- UserInterface/Images/NavigationItemProbes.svg: Added.
- UserInterface/Views/ProbeDetailsSidebarPanel.js:
(WebInspector.ProbeDetailsSidebarPanel): Use NavigationItemProbes.svg.
- UserInterface/Images/gtk/NavigationItemProbes.svg: Added.
- 11:40 PM Changeset in webkit [176178] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176091 - AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
https://bugs.webkit.org/show_bug.cgi?id=137867
Reviewed by Chris Fleizach.
Source/WebCore:
Return ATK_ROLE_INVALID for null or otherwise invalid accessible objects.
Test: platform/gtk/accessibility/detached-object-role.html
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetRole):
Tools:
Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
able to test for the presence of ATK_ROLE_INVALID.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::role):
LayoutTests:
- platform/gtk/accessibility/detached-object-role-expected.txt: Added.
- platform/gtk/accessibility/detached-object-role.html: Added.
- 11:35 PM Changeset in webkit [176177] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r176076 - AX: [ATK] Accessible focus events are emitted when the selection is changed in non-focused combo boxes
https://bugs.webkit.org/show_bug.cgi?id=137866
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Check that the AccessibilityMenuList is really focused before notifying
the platform that it is focused. Likewise, only notify the platform of
an AccessibilityMenuListOption focus gain if the AccessibilityMenuList
containing that option is expanded.
Test: platform/gtk/accessibility/menu-list-unfocused-notifications.html
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange):
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
- platform/gtk/accessibility/menu-list-unfocused-notifications-expected.txt: Added.
- platform/gtk/accessibility/menu-list-unfocused-notifications.html: Added.
- 11:31 PM Changeset in webkit [176176] by
-
- 5 edits in releases/WebKitGTK/webkit-2.6
Merge r175724 - slow_path_get_direct_pname() needs to be hardened against a constant baseValue.
<https://webkit.org/b/138476>
Reviewed by Michael Saboff.
Source/JavaScriptCore:
slow_path_get_direct_pname() currently assumes that the baseValue is always a
non-constant virtual register. However, this is not always the case like in the
following:
function foo() {
var o = { a:1 };
for (var n in o)
0[n];
}
foo();
This patch fixes it to also check for constant virtual register indexes.
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
LayoutTests:
- js/get-by-pname-expected.txt:
- js/script-tests/get-by-pname.js:
(getByPnameOnConstant):
(getByPnameOnVar):
- Added more test cases.
- 11:03 PM Changeset in webkit [176175] by
-
- 3 edits in trunk/Source/WebKit2
Start cleaning up minimal UI from WKWebView
https://bugs.webkit.org/show_bug.cgi?id=138725
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-16
Reviewed by Sam Weinig.
Start removing the old update path for minimumLayoutSize/maximumUnobscuredSize.
Unfortunately, I cannot remove everything yet because the clients still did not have
alternatives to [_overrideLayoutParametersWithMinimumLayoutSize:minimumLayoutSizeForMinimalUI:maximumUnobscuredSizeOverride]
and might change the minimal UI options.
This patch adds [_overrideLayoutParametersWithMinimumLayoutSize:maximumUnobscuredSizeOverride] to move
in the right direction. Next we'll udpate the client code and get rid of all the useless code.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:minimumLayoutSizeForMinimalUI:maximumUnobscuredSizeOverride:]):
(-[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:maximumUnobscuredSizeOverride:]):
(-[WKWebView _minimumLayoutSizeOverrideForMinimalUI]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 11:01 PM Changeset in webkit [176174] by
-
- 18 edits32 adds in trunk
Implement :valid and :invalid matching for the fieldset element
https://bugs.webkit.org/show_bug.cgi?id=138769
Reviewed by Darin Adler.
Source/WebCore:
In the latest HTML spec, the pseudo classes :valid and :invalid match
a fieldset element based on its descendants:
https://html.spec.whatwg.org/#selector-valid
https://html.spec.whatwg.org/#selector-invalid
This patch adds that behavior.
There are two key problems to solve with these pseudo classes on fieldset:
-Efficient matching.
-Style invalidation when any of the descendant changes.
To implement the style invalidation, I have modified HTMLFormControlElement
to notify its ancestor when its state changes.
The first change is making the state fully internal to HTMLFormControlElement,
we do not want subclass to be able to change the behavior and forget to update
the ancestors.
To achieve that encapsulation, the interface was changed a bit:
-Neither willValidate() nor isValidFormControlElement() inherit from Element.
Instead, willValidate() is the implementation of FormAssociatedElement's interface
and it is final. The method isValidFormControlElement() becomes completely internal
to HTMLFormControlElement.
-Since willValidate() should no longer be re-implemented by subclass, the elements
that were depending on it have been migrated to recalcWillValidate() to set
the initial state as needed.
With the validity state fully encapsulated in HTMLFormControlElement, all I need
is a way to communicate that information to HTMLFieldSetElement ancestors.
This is done in two cases:
-The validity state changes.
-The tree changes in a way that would make the input element not a descendant
of a HTMLFieldSetElement.
The invalidation is simply done by walking up the ancestors and adding the current
element to a "validity dependency list" on each HTMLFieldSetElement.
Tests: fast/css/pseudo-invalid-fieldset-invalidation-optimization.html
fast/css/pseudo-invalid-fieldset-style-sharing.html
fast/css/pseudo-invalid-fieldset.html
fast/css/pseudo-valid-fieldset-invalidation-optimization.html
fast/css/pseudo-valid-fieldset-style-sharing.html
fast/css/pseudo-valid-fieldset.html
fast/selectors/invalid-fieldset-style-update-1.html
fast/selectors/invalid-fieldset-style-update-2.html
fast/selectors/invalid-fieldset-style-update-3.html
fast/selectors/invalid-fieldset-style-update-4.html
fast/selectors/invalid-fieldset-style-update-5.html
fast/selectors/valid-fieldset-style-update-1.html
fast/selectors/valid-fieldset-style-update-2.html
fast/selectors/valid-fieldset-style-update-3.html
fast/selectors/valid-fieldset-style-update-4.html
fast/selectors/valid-fieldset-style-update-5.html
- css/SelectorCheckerTestFunctions.h:
(WebCore::isInRange):
(WebCore::isOutOfRange):
(WebCore::isInvalid):
(WebCore::isValid):
The hack "ContainsValidityStyleRules" is in the way of correct styling
of FieldSet and Form.
It is not the right way to get stylesheet properties anyway.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithControl):
Make sure style sharing does not incorrectly share style for fieldset elements.
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Document::containsValidityStyleRules): Deleted.
(WebCore::Document::setContainsValidityStyleRules): Deleted.
- dom/Element.h:
(WebCore::Element::matchesValidPseudoClass):
(WebCore::Element::matchesInvalidPseudoClass):
(WebCore::Element::willValidate): Deleted.
(WebCore::Element::isValidFormControlElement): Deleted.
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::customError):
- html/FormAssociatedElement.h:
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::matchesValidPseudoClass):
(WebCore::HTMLFieldSetElement::matchesInvalidPseudoClass):
(WebCore::HTMLFieldSetElement::addInvalidDescendant):
(WebCore::HTMLFieldSetElement::removeInvalidDescendant):
Each HTMLFormControlElement that has constraint validation adds or removes
itself from its HTMLFieldSetElement ancestors.
It should be possible to just keep track of a count instead of a HashSet.
I decided to got with the HashSet to make the code more robust and easier
to debug. A few assertions ensure that the HashSet is actually used as a counter.
- html/HTMLFieldSetElement.h:
- html/HTMLFormControlElement.cpp:
(WebCore::addInvalidElementToAncestorFromInsertionPoint):
(WebCore::removeInvalidElementToAncestorFromInsertionPoint):
(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::removedFrom):
One tricky part of those two functions is that we cannot use
matchesValidPseudoClass() or matchesInvalidPseudoClass().
The reason is that HTMLFieldSetElement is a subclass of HTMLFormControlElement
and it has its own definition of what Valid and Invalid mean when matching selectors.
In HTMLFormControlElement, we must use the internal state,
willValidate() and isValidFormControlElement() must be used directly.
(WebCore::HTMLFormControlElement::matchesValidPseudoClass):
(WebCore::HTMLFormControlElement::matchesInvalidPseudoClass):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::addInvalidElementToAncestors):
(WebCore::removeInvalidElementFromAncestors):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
(WebCore::HTMLFormControlElement::setNeedsValidityCheck):
(WebCore::HTMLFormControlElement::isValidFormControlElement): Deleted.
- html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::isValidFormControlElement):
- html/HTMLKeygenElement.h:
- html/HTMLObjectElement.h:
- html/HTMLOutputElement.h:
LayoutTests:
There are many ways to change the validation state of a submittable element.
I included a series of test trying to exercises as many combination
as possible.
- fast/css/pseudo-valid-unapplied-expected.txt:
- fast/css/pseudo-valid-unapplied.html:
This test was checking that :valid and :invalid are not applied
to fieldset. Such results are incorrect with the latest specification.
- fast/css/pseudo-invalid-fieldset-expected.html: Added.
- fast/css/pseudo-invalid-fieldset-invalidation-optimization-expected.txt: Added.
- fast/css/pseudo-invalid-fieldset-invalidation-optimization.html: Added.
- fast/css/pseudo-invalid-fieldset-style-sharing-expected.html: Added.
- fast/css/pseudo-invalid-fieldset-style-sharing.html: Added.
- fast/css/pseudo-invalid-fieldset.html: Added.
- fast/css/pseudo-valid-fieldset-expected.html: Added.
- fast/css/pseudo-valid-fieldset-invalidation-optimization-expected.txt: Added.
- fast/css/pseudo-valid-fieldset-invalidation-optimization.html: Added.
- fast/css/pseudo-valid-fieldset-style-sharing-expected.html: Added.
- fast/css/pseudo-valid-fieldset-style-sharing.html: Added.
- fast/css/pseudo-valid-fieldset.html: Added.
- fast/selectors/invalid-fieldset-style-update-1-expected.txt: Added.
- fast/selectors/invalid-fieldset-style-update-1.html: Added.
- fast/selectors/invalid-fieldset-style-update-2-expected.txt: Added.
- fast/selectors/invalid-fieldset-style-update-2.html: Added.
- fast/selectors/invalid-fieldset-style-update-3-expected.txt: Added.
- fast/selectors/invalid-fieldset-style-update-3.html: Added.
- fast/selectors/invalid-fieldset-style-update-4-expected.txt: Added.
- fast/selectors/invalid-fieldset-style-update-4.html: Added.
- fast/selectors/invalid-fieldset-style-update-5-expected.txt: Added.
- fast/selectors/invalid-fieldset-style-update-5.html: Added.
- fast/selectors/valid-fieldset-style-update-1-expected.txt: Added.
- fast/selectors/valid-fieldset-style-update-1.html: Added.
- fast/selectors/valid-fieldset-style-update-2-expected.txt: Added.
- fast/selectors/valid-fieldset-style-update-2.html: Added.
- fast/selectors/valid-fieldset-style-update-3-expected.txt: Added.
- fast/selectors/valid-fieldset-style-update-3.html: Added.
- fast/selectors/valid-fieldset-style-update-4-expected.txt: Added.
- fast/selectors/valid-fieldset-style-update-4.html: Added.
- fast/selectors/valid-fieldset-style-update-5-expected.txt: Added.
- fast/selectors/valid-fieldset-style-update-5.html: Added.
- 10:49 PM Changeset in webkit [176173] by
-
- 8 edits in trunk/Source
[TexMap] Add typecasting support for GraphicsLayerTextureMapper
https://bugs.webkit.org/show_bug.cgi?id=138741
Reviewed by Martin Robinson.
Source/WebCore:
Add type traits for the GraphicsLayerTextureMapper class.
This enables using typecasting functions instead of
toGraphicsLayerTextureMapper().
Remove toTextureMapperLayer() casting function which actually
returned the TextureMapperLayer object that belonged to the
passed-in GraphicsLayerTextureMapper. Instead, the GraphicsLayer
object is now downcasted and the TextureMapperLayer is accessed
by calling the GraphicsLayerTextureMapper::layer() method.
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::isGraphicsLayerTextureMapper):
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::toTextureMapperLayerVector):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
(WebCore::toTextureMapperLayer): Deleted.
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::toGraphicsLayerTextureMapper): Deleted.
Source/WebKit/win:
Switch to using downcast<GraphicsLayerTextureMapper>() and replace
uses of toTextureMapperLayer() with downcasting and calling
the GraphicsLayerTextureMapper::layer() method.
- WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::initialize):
(AcceleratedCompositingContext::startedAnimation):
(AcceleratedCompositingContext::compositeLayersToContext):
Source/WebKit2:
Replace uses of toTextureMapperLayer() with downcasting and
calling the GraphicsLayerTextureMapper::layer() method.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::layerFlushTimerFired):
(WebKit::LayerTreeHostGtk::compositeLayersToContext):
- 10:46 PM Changeset in webkit [176172] by
-
- 14 edits in trunk/Source/WebCore
Move WebCore/loader to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=138646
Reviewed by Chris Dumez.
Replace OwnPtr with std::unique_ptr<> and std::make_unique<>.
However this patch leaves ResourceRequest::adopt() because this need
to be handled by different patch.
No new tests, no behavior changes.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::preflightSuccess):
- loader/DocumentThreadableLoader.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::notifyDone):
- loader/SubresourceLoader.h:
- loader/TextTrackLoader.h:
- loader/appcache/ApplicationCacheHost.h:
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::storeCopyOfCache):
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestPreload):
(WebCore::CachedResourceLoader::clearPreloads):
(WebCore::CachedResourceLoader::printPreloadStats):
- loader/cache/CachedResourceLoader.h:
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::deleteAllPreparedStatements):
(WebCore::readySQLiteStatement):
- loader/icon/IconDatabase.h:
- loader/icon/IconRecord.h:
- 9:41 PM Changeset in webkit [176171] by
-
- 3 edits2 adds in trunk
Crash when setting 'order' CSS property to a calculated value
https://bugs.webkit.org/show_bug.cgi?id=138780
Reviewed by Darin Adler.
Source/WebCore:
CSS Calculated values were not handled by the CSS parser for 'order'
CSS property. As a result, using calculated values wouldn't work in
release builds and would hit an assertion in debug builds.
This patch updates the CSS parser to directly convert the
CSS Calculated value into a simple integer CSSPrimitiveValue for
'order' property. We could have marked CSS Calculated values as
valid in the CSS Parser instead but this would have brought issues:
- The calculated value needs to be adjusted to INT_MIN + 2 if it is less than that. This would force us to calculate the expression anyway.
- The StyleBuilder would need updating to properly handle CSS Calculated values for 'order'.
Test: fast/css/order-calculated-value.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
LayoutTests:
Add a layout test to validate that setting a calculated value to the
'order' CSS property does not crash and behaves as expected.
- fast/css/order-calculated-value-expected.txt: Added.
- fast/css/order-calculated-value.html: Added.
- 9:38 PM Changeset in webkit [176170] by
-
- 4 edits2 adds in trunk
Assertion hit when setting a very large value to 'border-width' / 'font-size' CSS properties
https://bugs.webkit.org/show_bug.cgi?id=138770
Reviewed by Darin Adler.
Source/WebCore:
When setting a very large value to a CSS property, it is represented internally as
infinity. r166114 already tried to deal with this by adding an std::isinf() check
in CSSValuePool::createValue() and returning an identifier CSSPrimitiveValue with
CSSValueInvalid value in such case. The issue is that doing leads to the
StyleBuilder getting a CSSValueInvalid CSSPrimitive value as input, which is not
handled and leads to assertions.
This patch updates the CSSParser to detect cases where the double value is
infinity earlier (in CSSParser::validUnit() and parseSimpleLengthValue()), so
that we mark the value as invalid and actually drop it. As a result,
CSSPrimitiveValues with CSSValueInvalid value no longer make their way to the
StyleBuilder.
Test: fast/css/style-builder-infinite-value.html
fast/css/infinite-floating-value.html
- css/CSSParser.cpp:
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::validUnit):
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createValue):
LayoutTests:
Add a layout test setting very large values to 'border-width' and
'font-size' CSS properties.
- fast/css/style-builder-infinite-value-expected.txt: Added.
- fast/css/style-builder-infinite-value.html: Added.
- 9:14 PM Changeset in webkit [176169] by
-
- 5 edits2 adds in trunk
Attribute text in HTMLAnchorElement should behave as per specification.
https://bugs.webkit.org/show_bug.cgi?id=138557
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-11-16
Reviewed by Darin Adler.
Source/WebCore:
attribute text in HTMLAnchorElement should not be readonly as per specification
http://www.w3.org/TR/html/text-level-semantics.html#dom-a-text. It should behave as textContent attribute.
Also This matches the behavior of Chrome 38 and FireFox.
Test: fast/dom/HTMLAnchorElement/anchor-text-attribute.html
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::text):
(WebCore::HTMLAnchorElement::setText):
- html/HTMLAnchorElement.h:
- html/HTMLAnchorElement.idl:
LayoutTests:
- fast/dom/HTMLAnchorElement/anchor-text-attribute-expected.txt: Added.
- fast/dom/HTMLAnchorElement/anchor-text-attribute.html: Added.
- 8:35 PM Changeset in webkit [176168] by
-
- 4 edits in trunk/Source/WebCore
Move 'vertical-align' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138764
Reviewed by Darin Adler.
Move 'vertical-align' CSS property from DeprecatedStyleBuilder to the
new StyleBuilder by using custom code.
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyVerticalAlign::applyValue): Deleted.
(WebCore::ApplyPropertyVerticalAlign::createHandler): Deleted.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderFunctions::applyValueVerticalAlign):
- 7:27 PM Changeset in webkit [176167] by
-
- 2 edits in trunk/LayoutTests
Test expectation gardening.
- platform/mac/TestExpectations:
- 5:57 PM Changeset in webkit [176166] by
-
- 5 edits in trunk/Source
Use TextIndicator instead of the built in Lookup highlight
https://bugs.webkit.org/show_bug.cgi?id=138775
<rdar://problem/18953982>
Follow-up to r176164.
- UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]):
(-[WKView initWithFrame:context:configuration:webView:]):
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
Include the softlinking macros directly in the files they're used
in, as they're supposed to be used.
- platform/spi/mac/LookupSPI.h:
(WebCore::canDisableLookupIndicator): Deleted.
Remove canDisableLookupIndicator.
- 5:18 PM Changeset in webkit [176165] by
-
- 3 edits2 adds in trunk
Crash when setting '-webkit-line-clamp' CSS property to a calculated value
https://bugs.webkit.org/show_bug.cgi?id=138777
Reviewed by Benjamin Poulain.
Source/WebCore:
CSS Calculated values were not handled when converting a CSSPrimitiveValue
to a LineClampValue. As a result, we would hit an ASSERT_NOT_REACHED()
assertion. To address this issue, this patch updates the code to use
primitiveType() / getValue<>() instead of m_primitiveUnitType /
m_value.num, as those getter function properly handle CSS Calculated
values.
Test: fast/css/webkit-line-clamp-calculated-value.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator LineClampValue):
LayoutTests:
Add a layout test to check that assigning calculated values to the
'-webkit-line-clamp' CSS property does not crash and behaves as
expected.
- fast/css/webkit-line-clamp-calculated-value-expected.txt: Added.
- fast/css/webkit-line-clamp-calculated-value.html: Added.
- 12:41 PM Changeset in webkit [176164] by
-
- 28 edits1 add in trunk/Source
Use TextIndicator instead of the built in Lookup highlight
https://bugs.webkit.org/show_bug.cgi?id=138775
<rdar://problem/18953982>
Reviewed by Anders Carlsson.
In order to make the yellow highlight for Lookup more accurately match the
painted content of the web page (in light of e.g. Web fonts, and interesting
text features that only WebKit implements and cannot round-trip through
NSAttributedString), use a TextIndicator instead of the built-in Lookup
highlight where possible.
- Configurations/BaseTarget.xcconfig:
Make it possible to include headers from private frameworks. This matches WebCore.
- Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
- Shared/DictionaryPopupInfo.h:
Include the attributed string inside the DictionaryPopupInfo, instead of
as a secondary argument to DidPerformDictionaryLookup.
Add a TextIndicator to DictionaryPopupInfo, which can be used to highlight
the text in the UI process.
- UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _dictionaryLookupPopoverWillClose:]):
(-[WKView _setTextIndicator:fadeOut:animate:animationCompletionHandler:]):
(-[WKView _setTextIndicator:fadeOut:animate:]):
(-[WKView initWithFrame:context:configuration:webView:]):
(+[WKView hideWordDefinitionWindow]):
- UIProcess/API/mac/WKViewInternal.h:
Adopt the Lookup SPI header.
If we have the requisite API, register the notification that Lookup sends
when the popover closes, and hook that up to hide the text indicator.
Add a version of _setTextIndicator: that takes an animation completion handler.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didPerformDictionaryLookup):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::didPerformDictionaryLookup):
Adjust to the new didPerformDictionaryLookup signature.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Remove a WKSI import.
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
If we have the requisite API, disable Lookup's built-in highlight and
present a TextIndicator instead.
We currently have to run the animations serially (first bounce the TextIndicator,
then animate in the Lookup popover) because the act of adding the Lookup popover
blocks us from getting any animation events for the TextIndicator, and breaks
the bounce. We could also fix this by using a threaded animation for the TextIndicator,
but it's not clear that it's safe to do so.
(WebKit::PageClientImpl::dismissDictionaryLookupPanel):
When explicitly dismissing the Lookup panel, also hide the text indicator.
- UIProcess/mac/TextIndicatorWindow.h:
- UIProcess/mac/TextIndicatorWindow.mm:
(WebKit::TextIndicatorWindow::setTextIndicator):
Store the completion handler.
(WebKit::TextIndicatorWindow::bounceAnimationDidEnd):
Call the completion handler when the animation completes.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _createActionMenuItemForTag:]):
Disable the Lookup item if lookup is not available.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::showDefinitionForAttributedString):
Adjust to the new didPerformDictionaryLookup signature.
Since PDFPlugin can't trivially repaint the required part of the PDF,
we don't build a TextIndicator. This will result in PDFPlugin continuing
to use Lookup's built-in highlight.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange):
Build a TextIndicator from the Lookup range and pass it along with
the DictionaryPopupInfo.
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Remove a WKSI import/export that we don't need anymore.
- platform/spi/mac/LookupSPI.h: Added.
(WebCore::canDisableLookupIndicator):
Add Lookup SPI header.
Add a 'canDisableLookupIndicator', which must be called in any translation
unit that wants to use either of the soft-linked constants related to
that functionality, before calling the get* function.
- WebCore.xcodeproj/project.pbxproj:
- editing/mac/DictionaryLookup.mm:
(WebCore::rangeForDictionaryLookupForSelection):
(WebCore::rangeForDictionaryLookupAtHitTestResult):
Adopt the Lookup SPI header.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Remove a WKSI import.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _lookupText:]):
(-[WebActionMenuController _createActionMenuItemForTag:]):
Make use of the new Lookup SPI header.
Disable the Lookup item if lookup is not available.
- 9:13 AM Changeset in webkit [176163] by
-
- 2 edits in trunk/Source/WebCore
AX: [ATK] REGRESSION(r166288): Accessible values are no longer accessible via AT-SPI2
https://bugs.webkit.org/show_bug.cgi?id=138776
Reviewed by Chris Fleizach.
r166288 used #if...#else instead of #if...#endif, thus disabling the old
AtkValue support. Unfortunately AT-SPI2 doesn't yet have support for the
new AtkValue API. Thus r166288 broke access to value-holding elements for
AT-SPI2 assistive technologies. Replacing #else with #endif fixes things.
No new tests because catching this regression would require AT-SPI2.
- accessibility/atk/WebKitAccessibleInterfaceValue.cpp:
(webkitAccessibleValueGetMinimumIncrement):
(webkitAccessibleValueInterfaceInit):
- 8:51 AM Changeset in webkit [176162] by
-
- 12 edits in trunk
AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
https://bugs.webkit.org/show_bug.cgi?id=138771
Reviewed by Chris Fleizach.
Source/WebCore:
Add BlockquoteRole and assigns it to blockquote elements. Make
corresponding changes to platform role mappings: ATK_ROLE_BLOCK_QUOTE
for GTK and EFL; AXGroup (which was being used already) for the Mac.
No new tests are required. Instead, updated the existing expectations
to reflect the new mapping.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isBlockquote):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
Tools:
Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Updated the expectations for GTK and EFL as there is a new role
being used. The Mac expectations were not updated because the
new role on that platform continues to be to AXGroup.
- platform/efl/accessibility/roles-exposed-expected.txt: Updated
- platform/gtk/accessibility/roles-exposed-expected.txt: Updated
- 7:54 AM Changeset in webkit [176161] by
-
- 3 edits2 adds in trunk
Crash when setting 'alt' CSS property to inherit or initial
https://bugs.webkit.org/show_bug.cgi?id=138774
<rdar://problem/18995409>
Reviewed by Chris Fleizach.
Source/WebCore:
The StyleResolver was not handling 'inherit' or 'initial' values for
'alt' CSS property. As a result, the code was assuming the CSSValue
was a CSSPrimitiveValue (although it could be a CSSInitialValue or
a CSSInheritValue). In such case, the code would dereference a null
pointer because primitiveValue is initialized using:
CSSPrimitiveValue* primitiveValue = is<CSSPrimitiveValue>(*value)
? downcast<CSSPrimitiveValue>(value)
: nullptr;
Test: fast/css/alt-inherit-initial.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
LayoutTests:
Add a layout test to verify that setting the 'alt' CSS property to
inherit / initial is not crashing and working as intended.
- fast/css/alt-inherit-initial-expected.txt: Added.
- fast/css/alt-inherit-initial.html: Added.
Nov 15, 2014:
- 11:34 PM Changeset in webkit [176160] by
-
- 5 edits in trunk
AX: [ATK] Lists with selectable children should have ATK_ROLE_LIST_BOX
https://bugs.webkit.org/show_bug.cgi?id=127060
Reviewed by Chris Fleizach.
Source/WebCore:
Corrected the mapping from ATK_ROLE_LIST to ATK_ROLE_LIST_BOX.
No new tests. Instead, updated the expectations of roles-exposed.html to
reflect the corrected mapping.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
LayoutTests:
Updated the expectations to reflect the corrected role.
- platform/efl/accessibility/roles-exposed-expected.txt: updated
- platform/gtk/accessibility/roles-exposed-expected.txt: updated
- 11:32 PM Changeset in webkit [176159] by
-
- 11 edits in trunk
AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
https://bugs.webkit.org/show_bug.cgi?id=138767
Reviewed by Chris Fleizach.
Source/WebCore:
Map AudioRole and VideoRole to ATK_ROLE_AUDIO and ATK_ROLE_VIDEO
respectively, falling back on the existing mapping to ATK_ROLE_EMBEDDED
in environments which have an older version of ATK.
No new tests are required. Instead, existing expectations were updated
to reflect the new mapping.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
Tools:
Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Updated expectations to reflect the new mapping to ATK_ROLE_AUDIO and
ATK_ROLE_VIDEO.
- platform/efl/accessibility/media-element-expected.txt: updated
- platform/efl/accessibility/media-emits-object-replacement-expected.txt: updated
- platform/gtk/accessibility/media-controls-panel-title-expected.txt: updated
- platform/gtk/accessibility/media-controls-panel-title.html: updated
- platform/gtk/accessibility/media-element-expected.txt: updated
- platform/gtk/accessibility/media-emits-object-replacement-expected.txt: updated
- 11:26 PM Changeset in webkit [176158] by
-
- 6 edits in trunk
AX: [ATK] Expose the footer element as ATK_ROLE_FOOTER
https://bugs.webkit.org/show_bug.cgi?id=138773
Reviewed by Chris Fleizach.
Source/WebCore:
Map FooterRole to ATK_ROLE_FOOTER.
No new tests. Unskipped a test that verifies this mapping.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
LayoutTests:
- accessibility/roles-exposed.html: Unskip the footer element test for GTK and EFL
- platform/efl/accessibility/roles-exposed-expected.txt: Updated expectations
- platform/gtk/accessibility/roles-exposed-expected.txt: Updated expectations
- 3:02 PM Changeset in webkit [176157] by
-
- 33 edits6 moves in trunk
Rename WebKitCSSKeyframe(s)Rule into CSSKeyframe(s)Rule
https://bugs.webkit.org/show_bug.cgi?id=138763
<rdar://problem/18991569>
Reviewed by Simon Fraser.
Source/WebCore:
Globally rename WebKitCSSKeyframeRule and WebKitCSSKeyframesRule to
CSSKeyframeRule and CSSKeyframesRule respectively.
This *may* break some existing content, but is compatible with
what Blink and Firefox are doing. To minimize breakage, I kept an
alias for the old constant values on CSSRule: WEBKIT_KEYFRAMES_RULE
and WEBKIT_KEYFRAME_RULE.
Covered by existing tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/objc/DOMCSS.mm:
(kitClass):
- css/CSSGrammar.y.includes:
- css/CSSKeyframeRule.cpp: Renamed from Source/WebCore/css/WebKitCSSKeyframeRule.cpp.
(WebCore::StyleKeyframe::StyleKeyframe):
(WebCore::StyleKeyframe::~StyleKeyframe):
(WebCore::StyleKeyframe::mutableProperties):
(WebCore::StyleKeyframe::parseKeyString):
(WebCore::StyleKeyframe::cssText):
(WebCore::CSSKeyframeRule::CSSKeyframeRule):
(WebCore::CSSKeyframeRule::~CSSKeyframeRule):
(WebCore::CSSKeyframeRule::style):
(WebCore::CSSKeyframeRule::reattach):
- css/CSSKeyframeRule.h: Renamed from Source/WebCore/css/WebKitCSSKeyframeRule.h.
(WebCore::StyleKeyframe::create):
(WebCore::StyleKeyframe::keyText):
(WebCore::StyleKeyframe::setKeyText):
(WebCore::StyleKeyframe::getKeys):
(WebCore::StyleKeyframe::properties):
- css/CSSKeyframeRule.idl: Renamed from Source/WebCore/css/WebKitCSSKeyframeRule.idl.
- css/CSSKeyframesRule.cpp: Renamed from Source/WebCore/css/WebKitCSSKeyframesRule.cpp.
(WebCore::StyleRuleKeyframes::StyleRuleKeyframes):
(WebCore::StyleRuleKeyframes::~StyleRuleKeyframes):
(WebCore::StyleRuleKeyframes::parserAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperRemoveKeyframe):
(WebCore::StyleRuleKeyframes::findKeyframeIndex):
(WebCore::CSSKeyframesRule::CSSKeyframesRule):
(WebCore::CSSKeyframesRule::~CSSKeyframesRule):
(WebCore::CSSKeyframesRule::setName):
(WebCore::CSSKeyframesRule::appendRule):
(WebCore::CSSKeyframesRule::insertRule):
(WebCore::CSSKeyframesRule::deleteRule):
(WebCore::CSSKeyframesRule::findRule):
(WebCore::CSSKeyframesRule::cssText):
(WebCore::CSSKeyframesRule::length):
(WebCore::CSSKeyframesRule::item):
(WebCore::CSSKeyframesRule::cssRules):
(WebCore::CSSKeyframesRule::reattach):
- css/CSSKeyframesRule.h: Renamed from Source/WebCore/css/WebKitCSSKeyframesRule.h.
(WebCore::StyleRuleKeyframes::create):
(WebCore::StyleRuleKeyframes::keyframes):
(WebCore::StyleRuleKeyframes::name):
(WebCore::StyleRuleKeyframes::setName):
(WebCore::StyleRuleKeyframes::copy):
- css/CSSKeyframesRule.idl: Renamed from Source/WebCore/css/WebKitCSSKeyframesRule.idl.
- css/CSSParser.cpp:
- css/CSSRule.h:
- css/CSSRule.idl:
- css/CSSStyleSheet.cpp:
- css/RuleSet.cpp:
- css/StyleResolver.cpp:
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::createCSSOMWrapper):
- inspector/InspectorStyleSheet.cpp:
(WebCore::asCSSRuleList):
LayoutTests:
Some of the tests use the prefixed interface name. Replace that
with the unprefixed version.
The "keyframes-rule.html" test added a check to make sure the
old constant WEBKIT_KEYFRAMES_RULE is the same as the new
constant KEYFRAMES_RULE.
- animations/keyframes-rule-expected.txt:
- animations/keyframes-rule.html:
- fast/dom/resources/wrapper-identity-base.js:
- fast/dom/wrapper-classes.html:
- fast/dom/wrapper-identity-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/fast/dom/objc-wrapper-identity-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 10:57 AM Changeset in webkit [176156] by
-
- 6 edits in trunk/Source
REGRESSION (r176137): iOS build broke after moving DataDetectors scanning code to WebCore
This regressed with the following commit:
Move DataDetectors scanning code to WebCore
https://bugs.webkit.org/show_bug.cgi?id=138731
<rdar://problem/18877535>
Source/WebCore:
This fixes the following build failures:
In file included from WebCore/editing/mac/DataDetection.mm:29:
WebCore/platform/spi/mac/DataDetectorsSPI.h:66:11: error: unknown type name 'NSRect'
@property NSRect highlightFrame;
WebCore/editing/mac/DataDetection.mm:42:28: error: use of undeclared identifier 'DataDetection'
RetainPtr<DDActionContext> DataDetection::detectItemAroundHitTestResult(const HitTestResult& hitTestResult, FloatRect& detectedDataBoundingBox, RefPtr<Range>& detectedDataRange)
2 errors generated.
- WebCore.exp.in:
(DataDetection::detectItemAroundHitTestResult): Move symbol from
shared section to Mac-only section.
- editing/mac/DataDetection.mm: Add PLATFORM(MAC) check around
the entire implementation since it it unused on iOS.
- platform/spi/mac/DataDetectorsSPI.h: Expand PLATFORM(MAC)
check around DDActionContext class declarations.
Source/WebKit2:
- Shared/mac/ActionMenuHitTestResult.mm: Add PLATFORM(MAC) check
around the entire implementation since it it unused on iOS.
- 10:41 AM Changeset in webkit [176155] by
-
- 2 edits in trunk/Source/WebKit2
Raise an exception if -[WKWebView initWithFrame:configuration:] is passed a nil configuration
https://bugs.webkit.org/show_bug.cgi?id=138757
Reviewed by Simon Fraser.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- 12:37 AM Changeset in webkit [176154] by
-
- 2 edits in trunk/Source/WebKit2
Network process crash when running http/tests/appcache/fallback.html
https://bugs.webkit.org/show_bug.cgi?id=138740
Reviewed by Alexey Proskuryakov.
It happens because ResourceHandle::continueWillSendRequest() is
called with a null request. We could handle that case in the
ResourceHandle, but the thing is tha the behaviour is
not the same for async loads, or when loading in the web
process. In WebResourceLoader::willSendRequest(),
ResourceRequest::willSendRequest() is called, and cancels the load
if the client returns a null request. In this case, the
ResourceLoader is detached and WebResourceLoader::willSendRequest()
returns early without sending the ContinueWillSendRequest message
to the network process. However, for synchronous loads,
NetworkResourceLoader::continueWillSendRequest() is always called.
Fixes http/tests/appcache/fallback.html for GTK port when using
the network process.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueWillSendRequest): Do not
call ResourceHandle::continueWillSendRequest() if the client
request is null, since the load is going to be cancelled.
- 12:12 AM Changeset in webkit [176153] by
-
- 6 edits in trunk/Source
Implement data detectors and mailto action menus for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=138765
<rdar://problem/18877535>
Reviewed by Beth Dakin.
- WebView/WebActionMenuController.h:
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController willOpenMenu:withEvent:]):
Tell DataDetectors that the menu is going to open.
Select the text (or not) based on the number of items in the menu, just like WebKit2.
(-[WebActionMenuController didCloseMenu:withEvent:]):
Tell DataDetectors that the menu closed.
(-[WebActionMenuController _defaultMenuItemsForLink]):
Move these checks out of _defaultMenuItemsForLink, because we expect this
to always return a complete link menu.
(-[WebActionMenuController _defaultMenuItemsForMailtoLink]):
Implement. More or less copied from WebKit2.
(-[WebActionMenuController _selectDataDetectedText]):
Select the stashed range.
(-[WebActionMenuController _defaultMenuItemsForDataDetectedText]):
Implement. More or less copied from WebKit2.
The yellow highlight isn't hooked up yet.
Give the client a chance to override via _webView:actionContextForHitTestResult:range:.
(-[WebActionMenuController _selectLookupText]):
Remove an unnecessary return.
(-[WebActionMenuController _defaultMenuItems]):
Call into the two new menu types.
- WebView/WebUIDelegatePrivate.h:
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForMailtoLink]):
Nov 14, 2014:
- 6:32 PM Changeset in webkit [176152] by
-
- 5 edits in trunk/Source/WebCore
Compute the selector specificity as we match simple selectors
https://bugs.webkit.org/show_bug.cgi?id=138718
Reviewed by Andreas Kling.
This is an other tiny step toward dynamic specificity. Instead of computing
the entire specificity at the end, compute it dynamically as we are matching
each individual simple selector.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::specificity):
(WebCore::CSSSelector::simpleSelectorSpecificity):
(WebCore::CSSSelector::addSpecificities):
(WebCore::CSSSelector::specificityForPage):
(WebCore::CSSSelector::specificityForOneSelector): Deleted.
- css/CSSSelector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::matchSelectorList):
- css/SelectorChecker.h:
- 6:31 PM Changeset in webkit [176151] by
-
- 2 edits in trunk/Source/JavaScriptCore
STRH can store values with the wrong offset
https://bugs.webkit.org/show_bug.cgi?id=138723
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-14
Reviewed by Michael Saboff.
This is the counterpart of r176083 for the str instruction.
I believe this code is currently unreachable because there is only one client of strh()
in the MacroAssembler and it always setup the scale explicitely.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::strh):
- 5:58 PM Changeset in webkit [176150] by
-
- 2 edits in trunk/Source/WebKit2
Remove pre-[DDActionContext contextForView:...] fallback path
https://bugs.webkit.org/show_bug.cgi?id=138735
<rdar://problem/18982046>
Reviewed by Simon Fraser.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController willOpenMenu:withEvent:]):
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
(hasDataDetectorsCompletionAPI): Deleted.
Remove the now-unnecessary fallback path.
- 4:36 PM Changeset in webkit [176149] by
-
- 5 edits in trunk/Source/WebCore
[mac] Only images that are actually purgeable should be advertised as such.
<https://webkit.org/b/138759>
<rdar://problem/13205438>
Reviewed by Tim Horton.
Instead of saying that all images on >=Yosemite are purgeable, have BitmapImage
forward the question to CGImage for the correct answer.
The memory may be marked non-volatile by frameworks underneath WebKit at any
given time, but that's not something we need to worry about.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::decodedDataIsPurgeable):
- platform/graphics/BitmapImage.h:
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::decodedDataIsPurgeable):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::createFrameAtIndex):
- platform/spi/cg/CoreGraphicsSPI.h:
- 4:31 PM Changeset in webkit [176148] by
-
- 2 edits in trunk/Source/WebKit2
Frequent crashes under actionContextForResultAtPoint
https://bugs.webkit.org/show_bug.cgi?id=138761
<rdar://problem/18990684>
Reviewed by Dean Jackson.
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(PageOverlayClientImpl::actionContextForResultAtPoint):
Initialize apiRange.
- 4:26 PM Changeset in webkit [176147] by
-
- 5 edits in trunk/Source/WebCore
Remove computeTextPaintStyle's RenderText dependency.
https://bugs.webkit.org/show_bug.cgi?id=138754
Reviewed by Simon Fraser.
So that we can compute text paint style across renderers in simple line layout.
No change in functionality.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):
- rendering/TextPaintStyle.cpp:
(WebCore::computeTextPaintStyle):
- rendering/TextPaintStyle.h:
- 4:02 PM Changeset in webkit [176146] by
-
- 9 edits2 deletes in trunk/Source
Get rid of WebFontCache
https://bugs.webkit.org/show_bug.cgi?id=134752
Reviewed by Dave Hyatt.
Source/WebCore:
No new tests because there is no behavior change.
- Configurations/WebCore.xcconfig:
- PlatformMac.cmake:
- WebCore.exp.in:
- WebCore.order:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::acceptableChoice):
(WebCore::betterChoice):
(WebCore::toTraitsMask):
(WebCore::desiredFamilyToAvailableFamilyDictionary):
(WebCore::rememberDesiredFamilyToAvailableFamilyMapping):
(WebCore::fontWithFamily):
(WebCore::invalidateFontCache):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::createFontPlatformData):
- platform/mac/WebFontCache.h: Removed.
- platform/mac/WebFontCache.mm: Removed.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
- 3:50 PM Changeset in webkit [176145] by
-
- 2 edits in trunk/Source/WebKit/mac
Update some artwork for the legacy WebKit action menu
https://bugs.webkit.org/show_bug.cgi?id=138758
<rdar://problem/18989840>
- WebView/WebActionMenuController.mm:
(webKitBundleImageNamed): Deleted.
Fix the build.
- 3:45 PM Changeset in webkit [176144] by
-
- 2 edits1766 adds in trunk/LayoutTests
Import w3c tests for canvas
https://bugs.webkit.org/show_bug.cgi?id=138324.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2014-11-14
Reviewed by Dean Jackson.
804 tests are ported from w3c canvas test suite. There are 39 tests failed on WebKit
and there are 45 tests need to be changed such that they can be automatically verified.
- canvas: Added.
- canvas/2d.canvas.readonly-expected.txt: Added.
- canvas/2d.canvas.readonly.html: Added.
- canvas/2d.canvas.reference-expected.txt: Added.
- canvas/2d.canvas.reference.html: Added.
- canvas/2d.clearRect.basic-expected.txt: Added.
- canvas/2d.clearRect.basic.html: Added.
- canvas/2d.clearRect.clip-expected.txt: Added.
- canvas/2d.clearRect.clip.html: Added.
- canvas/2d.clearRect.globalalpha-expected.txt: Added.
- canvas/2d.clearRect.globalalpha.html: Added.
- canvas/2d.clearRect.globalcomposite-expected.txt: Added.
- canvas/2d.clearRect.globalcomposite.html: Added.
- canvas/2d.clearRect.negative-expected.txt: Added.
- canvas/2d.clearRect.negative.html: Added.
- canvas/2d.clearRect.nonfinite-expected.txt: Added.
- canvas/2d.clearRect.nonfinite.html: Added.
- canvas/2d.clearRect.path-expected.txt: Added.
- canvas/2d.clearRect.path.html: Added.
- canvas/2d.clearRect.shadow-expected.txt: Added.
- canvas/2d.clearRect.shadow.html: Added.
- canvas/2d.clearRect.transform-expected.txt: Added.
- canvas/2d.clearRect.transform.html: Added.
- canvas/2d.clearRect.zero-expected.txt: Added.
- canvas/2d.clearRect.zero.html: Added.
- canvas/2d.composite.canvas.copy-expected.txt: Added.
- canvas/2d.composite.canvas.copy.html: Added.
- canvas/2d.composite.canvas.destination-atop-expected.txt: Added.
- canvas/2d.composite.canvas.destination-atop.html: Added.
- canvas/2d.composite.canvas.destination-in-expected.txt: Added.
- canvas/2d.composite.canvas.destination-in.html: Added.
- canvas/2d.composite.canvas.destination-out-expected.txt: Added.
- canvas/2d.composite.canvas.destination-out.html: Added.
- canvas/2d.composite.canvas.destination-over-expected.txt: Added.
- canvas/2d.composite.canvas.destination-over.html: Added.
- canvas/2d.composite.canvas.lighter-expected.txt: Added.
- canvas/2d.composite.canvas.lighter.html: Added.
- canvas/2d.composite.canvas.source-atop-expected.txt: Added.
- canvas/2d.composite.canvas.source-atop.html: Added.
- canvas/2d.composite.canvas.source-in-expected.txt: Added.
- canvas/2d.composite.canvas.source-in.html: Added.
- canvas/2d.composite.canvas.source-out-expected.txt: Added.
- canvas/2d.composite.canvas.source-out.html: Added.
- canvas/2d.composite.canvas.source-over-expected.txt: Added.
- canvas/2d.composite.canvas.source-over.html: Added.
- canvas/2d.composite.canvas.xor-expected.txt: Added.
- canvas/2d.composite.canvas.xor.html: Added.
- canvas/2d.composite.clip.copy-expected.txt: Added.
- canvas/2d.composite.clip.copy.html: Added.
- canvas/2d.composite.clip.destination-atop-expected.txt: Added.
- canvas/2d.composite.clip.destination-atop.html: Added.
- canvas/2d.composite.clip.destination-in-expected.txt: Added.
- canvas/2d.composite.clip.destination-in.html: Added.
- canvas/2d.composite.clip.destination-out-expected.txt: Added.
- canvas/2d.composite.clip.destination-out.html: Added.
- canvas/2d.composite.clip.destination-over-expected.txt: Added.
- canvas/2d.composite.clip.destination-over.html: Added.
- canvas/2d.composite.clip.lighter-expected.txt: Added.
- canvas/2d.composite.clip.lighter.html: Added.
- canvas/2d.composite.clip.source-atop-expected.txt: Added.
- canvas/2d.composite.clip.source-atop.html: Added.
- canvas/2d.composite.clip.source-in-expected.txt: Added.
- canvas/2d.composite.clip.source-in.html: Added.
- canvas/2d.composite.clip.source-out-expected.txt: Added.
- canvas/2d.composite.clip.source-out.html: Added.
- canvas/2d.composite.clip.source-over-expected.txt: Added.
- canvas/2d.composite.clip.source-over.html: Added.
- canvas/2d.composite.clip.xor-expected.txt: Added.
- canvas/2d.composite.clip.xor.html: Added.
- canvas/2d.composite.globalAlpha.canvas-expected.txt: Added.
- canvas/2d.composite.globalAlpha.canvas.html: Added.
- canvas/2d.composite.globalAlpha.canvaspattern-expected.txt: Added.
- canvas/2d.composite.globalAlpha.canvaspattern.html: Added.
- canvas/2d.composite.globalAlpha.default-expected.txt: Added.
- canvas/2d.composite.globalAlpha.default.html: Added.
- canvas/2d.composite.globalAlpha.fill-expected.txt: Added.
- canvas/2d.composite.globalAlpha.fill.html: Added.
- canvas/2d.composite.globalAlpha.image-expected.txt: Added.
- canvas/2d.composite.globalAlpha.image.html: Added.
- canvas/2d.composite.globalAlpha.imagepattern-expected.txt: Added.
- canvas/2d.composite.globalAlpha.imagepattern.html: Added.
- canvas/2d.composite.globalAlpha.invalid-expected.txt: Added.
- canvas/2d.composite.globalAlpha.invalid.html: Added.
- canvas/2d.composite.globalAlpha.range-expected.txt: Added.
- canvas/2d.composite.globalAlpha.range.html: Added.
- canvas/2d.composite.image.copy-expected.txt: Added.
- canvas/2d.composite.image.copy.html: Added.
- canvas/2d.composite.image.destination-atop-expected.txt: Added.
- canvas/2d.composite.image.destination-atop.html: Added.
- canvas/2d.composite.image.destination-in-expected.txt: Added.
- canvas/2d.composite.image.destination-in.html: Added.
- canvas/2d.composite.image.destination-out-expected.txt: Added.
- canvas/2d.composite.image.destination-out.html: Added.
- canvas/2d.composite.image.destination-over-expected.txt: Added.
- canvas/2d.composite.image.destination-over.html: Added.
- canvas/2d.composite.image.lighter-expected.txt: Added.
- canvas/2d.composite.image.lighter.html: Added.
- canvas/2d.composite.image.source-atop-expected.txt: Added.
- canvas/2d.composite.image.source-atop.html: Added.
- canvas/2d.composite.image.source-in-expected.txt: Added.
- canvas/2d.composite.image.source-in.html: Added.
- canvas/2d.composite.image.source-out-expected.txt: Added.
- canvas/2d.composite.image.source-out.html: Added.
- canvas/2d.composite.image.source-over-expected.txt: Added.
- canvas/2d.composite.image.source-over.html: Added.
- canvas/2d.composite.image.xor-expected.txt: Added.
- canvas/2d.composite.image.xor.html: Added.
- canvas/2d.composite.operation.casesensitive-expected.txt: Added.
- canvas/2d.composite.operation.casesensitive.html: Added.
- canvas/2d.composite.operation.clear-expected.txt: Added.
- canvas/2d.composite.operation.clear.html: Added.
- canvas/2d.composite.operation.darker-expected.txt: Added.
- canvas/2d.composite.operation.darker.html: Added.
- canvas/2d.composite.operation.default-expected.txt: Added.
- canvas/2d.composite.operation.default.html: Added.
- canvas/2d.composite.operation.get-expected.txt: Added.
- canvas/2d.composite.operation.get.html: Added.
- canvas/2d.composite.operation.highlight-expected.txt: Added.
- canvas/2d.composite.operation.highlight.html: Added.
- canvas/2d.composite.operation.over-expected.txt: Added.
- canvas/2d.composite.operation.over.html: Added.
- canvas/2d.composite.operation.unrecognised-expected.txt: Added.
- canvas/2d.composite.operation.unrecognised.html: Added.
- canvas/2d.composite.solid.copy-expected.txt: Added.
- canvas/2d.composite.solid.copy.html: Added.
- canvas/2d.composite.solid.destination-atop-expected.txt: Added.
- canvas/2d.composite.solid.destination-atop.html: Added.
- canvas/2d.composite.solid.destination-in-expected.txt: Added.
- canvas/2d.composite.solid.destination-in.html: Added.
- canvas/2d.composite.solid.destination-out-expected.txt: Added.
- canvas/2d.composite.solid.destination-out.html: Added.
- canvas/2d.composite.solid.destination-over-expected.txt: Added.
- canvas/2d.composite.solid.destination-over.html: Added.
- canvas/2d.composite.solid.lighter-expected.txt: Added.
- canvas/2d.composite.solid.lighter.html: Added.
- canvas/2d.composite.solid.source-atop-expected.txt: Added.
- canvas/2d.composite.solid.source-atop.html: Added.
- canvas/2d.composite.solid.source-in-expected.txt: Added.
- canvas/2d.composite.solid.source-in.html: Added.
- canvas/2d.composite.solid.source-out-expected.txt: Added.
- canvas/2d.composite.solid.source-out.html: Added.
- canvas/2d.composite.solid.source-over-expected.txt: Added.
- canvas/2d.composite.solid.source-over.html: Added.
- canvas/2d.composite.solid.xor-expected.txt: Added.
- canvas/2d.composite.solid.xor.html: Added.
- canvas/2d.composite.transparent.copy-expected.txt: Added.
- canvas/2d.composite.transparent.copy.html: Added.
- canvas/2d.composite.transparent.destination-atop-expected.txt: Added.
- canvas/2d.composite.transparent.destination-atop.html: Added.
- canvas/2d.composite.transparent.destination-in-expected.txt: Added.
- canvas/2d.composite.transparent.destination-in.html: Added.
- canvas/2d.composite.transparent.destination-out-expected.txt: Added.
- canvas/2d.composite.transparent.destination-out.html: Added.
- canvas/2d.composite.transparent.destination-over-expected.txt: Added.
- canvas/2d.composite.transparent.destination-over.html: Added.
- canvas/2d.composite.transparent.lighter-expected.txt: Added.
- canvas/2d.composite.transparent.lighter.html: Added.
- canvas/2d.composite.transparent.source-atop-expected.txt: Added.
- canvas/2d.composite.transparent.source-atop.html: Added.
- canvas/2d.composite.transparent.source-in-expected.txt: Added.
- canvas/2d.composite.transparent.source-in.html: Added.
- canvas/2d.composite.transparent.source-out-expected.txt: Added.
- canvas/2d.composite.transparent.source-out.html: Added.
- canvas/2d.composite.transparent.source-over-expected.txt: Added.
- canvas/2d.composite.transparent.source-over.html: Added.
- canvas/2d.composite.transparent.xor-expected.txt: Added.
- canvas/2d.composite.transparent.xor.html: Added.
- canvas/2d.composite.uncovered.fill.copy-expected.txt: Added.
- canvas/2d.composite.uncovered.fill.copy.html: Added.
- canvas/2d.composite.uncovered.fill.destination-atop-expected.txt: Added.
- canvas/2d.composite.uncovered.fill.destination-atop.html: Added.
- canvas/2d.composite.uncovered.fill.destination-in-expected.txt: Added.
- canvas/2d.composite.uncovered.fill.destination-in.html: Added.
- canvas/2d.composite.uncovered.fill.source-in-expected.txt: Added.
- canvas/2d.composite.uncovered.fill.source-in.html: Added.
- canvas/2d.composite.uncovered.fill.source-out-expected.txt: Added.
- canvas/2d.composite.uncovered.fill.source-out.html: Added.
- canvas/2d.composite.uncovered.image.copy-expected.txt: Added.
- canvas/2d.composite.uncovered.image.copy.html: Added.
- canvas/2d.composite.uncovered.image.destination-atop-expected.txt: Added.
- canvas/2d.composite.uncovered.image.destination-atop.html: Added.
- canvas/2d.composite.uncovered.image.destination-in-expected.txt: Added.
- canvas/2d.composite.uncovered.image.destination-in.html: Added.
- canvas/2d.composite.uncovered.image.source-in-expected.txt: Added.
- canvas/2d.composite.uncovered.image.source-in.html: Added.
- canvas/2d.composite.uncovered.image.source-out-expected.txt: Added.
- canvas/2d.composite.uncovered.image.source-out.html: Added.
- canvas/2d.composite.uncovered.nocontext.copy-expected.txt: Added.
- canvas/2d.composite.uncovered.nocontext.copy.html: Added.
- canvas/2d.composite.uncovered.nocontext.destination-atop-expected.txt: Added.
- canvas/2d.composite.uncovered.nocontext.destination-atop.html: Added.
- canvas/2d.composite.uncovered.nocontext.destination-in-expected.txt: Added.
- canvas/2d.composite.uncovered.nocontext.destination-in.html: Added.
- canvas/2d.composite.uncovered.nocontext.source-in-expected.txt: Added.
- canvas/2d.composite.uncovered.nocontext.source-in.html: Added.
- canvas/2d.composite.uncovered.nocontext.source-out-expected.txt: Added.
- canvas/2d.composite.uncovered.nocontext.source-out.html: Added.
- canvas/2d.composite.uncovered.pattern.copy-expected.txt: Added.
- canvas/2d.composite.uncovered.pattern.copy.html: Added.
- canvas/2d.composite.uncovered.pattern.destination-atop-expected.txt: Added.
- canvas/2d.composite.uncovered.pattern.destination-atop.html: Added.
- canvas/2d.composite.uncovered.pattern.destination-in-expected.txt: Added.
- canvas/2d.composite.uncovered.pattern.destination-in.html: Added.
- canvas/2d.composite.uncovered.pattern.source-in-expected.txt: Added.
- canvas/2d.composite.uncovered.pattern.source-in.html: Added.
- canvas/2d.composite.uncovered.pattern.source-out-expected.txt: Added.
- canvas/2d.composite.uncovered.pattern.source-out.html: Added.
- canvas/2d.coordinatespace.html: Added.
- canvas/2d.drawImage.3arg-expected.txt: Added.
- canvas/2d.drawImage.3arg.html: Added.
- canvas/2d.drawImage.5arg-expected.txt: Added.
- canvas/2d.drawImage.5arg.html: Added.
- canvas/2d.drawImage.9arg.basic-expected.txt: Added.
- canvas/2d.drawImage.9arg.basic.html: Added.
- canvas/2d.drawImage.9arg.destpos-expected.txt: Added.
- canvas/2d.drawImage.9arg.destpos.html: Added.
- canvas/2d.drawImage.9arg.destsize-expected.txt: Added.
- canvas/2d.drawImage.9arg.destsize.html: Added.
- canvas/2d.drawImage.9arg.sourcepos-expected.txt: Added.
- canvas/2d.drawImage.9arg.sourcepos.html: Added.
- canvas/2d.drawImage.9arg.sourcesize-expected.txt: Added.
- canvas/2d.drawImage.9arg.sourcesize.html: Added.
- canvas/2d.drawImage.alpha-expected.txt: Added.
- canvas/2d.drawImage.alpha.html: Added.
- canvas/2d.drawImage.animated.apng.html: Added.
- canvas/2d.drawImage.animated.gif.html: Added.
- canvas/2d.drawImage.animated.poster-expected.txt: Added.
- canvas/2d.drawImage.animated.poster.html: Added.
- canvas/2d.drawImage.broken-expected.txt: Added.
- canvas/2d.drawImage.broken.html: Added.
- canvas/2d.drawImage.canvas-expected.txt: Added.
- canvas/2d.drawImage.canvas.html: Added.
- canvas/2d.drawImage.clip-expected.txt: Added.
- canvas/2d.drawImage.clip.html: Added.
- canvas/2d.drawImage.composite-expected.txt: Added.
- canvas/2d.drawImage.composite.html: Added.
- canvas/2d.drawImage.floatsource-expected.txt: Added.
- canvas/2d.drawImage.floatsource.html: Added.
- canvas/2d.drawImage.image.incomplete.empty-expected.txt: Added.
- canvas/2d.drawImage.image.incomplete.empty.html: Added.
- canvas/2d.drawImage.image.incomplete.omitted-expected.txt: Added.
- canvas/2d.drawImage.image.incomplete.omitted.html: Added.
- canvas/2d.drawImage.incomplete-expected.txt: Added.
- canvas/2d.drawImage.incomplete.html: Added.
- canvas/2d.drawImage.negativedest-expected.txt: Added.
- canvas/2d.drawImage.negativedest.html: Added.
- canvas/2d.drawImage.negativedir-expected.txt: Added.
- canvas/2d.drawImage.negativedir.html: Added.
- canvas/2d.drawImage.negativesource-expected.txt: Added.
- canvas/2d.drawImage.negativesource.html: Added.
- canvas/2d.drawImage.nonfinite-expected.txt: Added.
- canvas/2d.drawImage.nonfinite.html: Added.
- canvas/2d.drawImage.nowrap-expected.txt: Added.
- canvas/2d.drawImage.nowrap.html: Added.
- canvas/2d.drawImage.null-expected.txt: Added.
- canvas/2d.drawImage.null.html: Added.
- canvas/2d.drawImage.path-expected.txt: Added.
- canvas/2d.drawImage.path.html: Added.
- canvas/2d.drawImage.self.1-expected.txt: Added.
- canvas/2d.drawImage.self.1.html: Added.
- canvas/2d.drawImage.self.2-expected.txt: Added.
- canvas/2d.drawImage.self.2.html: Added.
- canvas/2d.drawImage.transform-expected.txt: Added.
- canvas/2d.drawImage.transform.html: Added.
- canvas/2d.drawImage.wrongtype-expected.txt: Added.
- canvas/2d.drawImage.wrongtype.html: Added.
- canvas/2d.drawImage.zerocanvas-expected.txt: Added.
- canvas/2d.drawImage.zerocanvas.html: Added.
- canvas/2d.drawImage.zerosource-expected.txt: Added.
- canvas/2d.drawImage.zerosource.html: Added.
- canvas/2d.fillRect.basic-expected.txt: Added.
- canvas/2d.fillRect.basic.html: Added.
- canvas/2d.fillRect.clip-expected.txt: Added.
- canvas/2d.fillRect.clip.html: Added.
- canvas/2d.fillRect.negative-expected.txt: Added.
- canvas/2d.fillRect.negative.html: Added.
- canvas/2d.fillRect.nonfinite-expected.txt: Added.
- canvas/2d.fillRect.nonfinite.html: Added.
- canvas/2d.fillRect.path-expected.txt: Added.
- canvas/2d.fillRect.path.html: Added.
- canvas/2d.fillRect.shadow-expected.txt: Added.
- canvas/2d.fillRect.shadow.html: Added.
- canvas/2d.fillRect.transform-expected.txt: Added.
- canvas/2d.fillRect.transform.html: Added.
- canvas/2d.fillRect.zero-expected.txt: Added.
- canvas/2d.fillRect.zero.html: Added.
- canvas/2d.fillStyle.default-expected.txt: Added.
- canvas/2d.fillStyle.default.html: Added.
- canvas/2d.fillStyle.get.semitransparent-expected.txt: Added.
- canvas/2d.fillStyle.get.semitransparent.html: Added.
- canvas/2d.fillStyle.get.solid-expected.txt: Added.
- canvas/2d.fillStyle.get.solid.html: Added.
- canvas/2d.fillStyle.get.transparent-expected.txt: Added.
- canvas/2d.fillStyle.get.transparent.html: Added.
- canvas/2d.fillStyle.invalidstring-expected.txt: Added.
- canvas/2d.fillStyle.invalidstring.html: Added.
- canvas/2d.fillStyle.invalidtype-expected.txt: Added.
- canvas/2d.fillStyle.invalidtype.html: Added.
- canvas/2d.fillStyle.parse.current.basic-expected.txt: Added.
- canvas/2d.fillStyle.parse.current.basic.html: Added.
- canvas/2d.fillStyle.parse.current.changed-expected.txt: Added.
- canvas/2d.fillStyle.parse.current.changed.html: Added.
- canvas/2d.fillStyle.parse.current.removed-expected.txt: Added.
- canvas/2d.fillStyle.parse.current.removed.html: Added.
- canvas/2d.fillStyle.parse.hex3-expected.txt: Added.
- canvas/2d.fillStyle.parse.hex3.html: Added.
- canvas/2d.fillStyle.parse.hex6-expected.txt: Added.
- canvas/2d.fillStyle.parse.hex6.html: Added.
- canvas/2d.fillStyle.parse.hsl-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsl-1.html: Added.
- canvas/2d.fillStyle.parse.hsl-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsl-2.html: Added.
- canvas/2d.fillStyle.parse.hsl-3-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsl-3.html: Added.
- canvas/2d.fillStyle.parse.hsl-4-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsl-4.html: Added.
- canvas/2d.fillStyle.parse.hsl-5-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsl-5.html: Added.
- canvas/2d.fillStyle.parse.hsl-6-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsl-6.html: Added.
- canvas/2d.fillStyle.parse.hsl-clamp-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsl-clamp-1.html: Added.
- canvas/2d.fillStyle.parse.hsl-clamp-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsl-clamp-2.html: Added.
- canvas/2d.fillStyle.parse.hsl-clamp-3-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsl-clamp-3.html: Added.
- canvas/2d.fillStyle.parse.hsl-clamp-4-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsl-clamp-4.html: Added.
- canvas/2d.fillStyle.parse.hsla-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsla-1.html: Added.
- canvas/2d.fillStyle.parse.hsla-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsla-2.html: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-1.html: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-2.html: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-3-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-3.html: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-4-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-4.html: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-5-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-5.html: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-6-expected.txt: Added.
- canvas/2d.fillStyle.parse.hsla-clamp-6.html: Added.
- canvas/2d.fillStyle.parse.html4-expected.txt: Added.
- canvas/2d.fillStyle.parse.html4.html: Added.
- canvas/2d.fillStyle.parse.invalid.hex1-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hex1.html: Added.
- canvas/2d.fillStyle.parse.invalid.hex2-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hex2.html: Added.
- canvas/2d.fillStyle.parse.invalid.hex3-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hex3.html: Added.
- canvas/2d.fillStyle.parse.invalid.hex4-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hex4.html: Added.
- canvas/2d.fillStyle.parse.invalid.hex5-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hex5.html: Added.
- canvas/2d.fillStyle.parse.invalid.hex6-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hex6.html: Added.
- canvas/2d.fillStyle.parse.invalid.hex7-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hex7.html: Added.
- canvas/2d.fillStyle.parse.invalid.hex8-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hex8.html: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-1.html: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-2.html: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-3-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-3.html: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-4-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-4.html: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-5-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-5.html: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-6-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hsl-6.html: Added.
- canvas/2d.fillStyle.parse.invalid.hsla-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hsla-1.html: Added.
- canvas/2d.fillStyle.parse.invalid.hsla-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.hsla-2.html: Added.
- canvas/2d.fillStyle.parse.invalid.name-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.name-1.html: Added.
- canvas/2d.fillStyle.parse.invalid.name-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.name-2.html: Added.
- canvas/2d.fillStyle.parse.invalid.name-3-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.name-3.html: Added.
- canvas/2d.fillStyle.parse.invalid.name-4-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.name-4.html: Added.
- canvas/2d.fillStyle.parse.invalid.name-5-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.name-5.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-1.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-2.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-3-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-3.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-4-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-4.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-5-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-5.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-6-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-6.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-7-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgb-7.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-1.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-2.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-3-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-3.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-4-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-4.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-5-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-5.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-6.html: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-7-expected.txt: Added.
- canvas/2d.fillStyle.parse.invalid.rgba-7.html: Added.
- canvas/2d.fillStyle.parse.rgb-clamp-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgb-clamp-1.html: Added.
- canvas/2d.fillStyle.parse.rgb-clamp-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgb-clamp-2.html: Added.
- canvas/2d.fillStyle.parse.rgb-clamp-3-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgb-clamp-3.html: Added.
- canvas/2d.fillStyle.parse.rgb-clamp-4-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgb-clamp-4.html: Added.
- canvas/2d.fillStyle.parse.rgb-clamp-5-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgb-clamp-5.html: Added.
- canvas/2d.fillStyle.parse.rgb-eof-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgb-eof.html: Added.
- canvas/2d.fillStyle.parse.rgb-num-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgb-num.html: Added.
- canvas/2d.fillStyle.parse.rgb-percent-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgb-percent.html: Added.
- canvas/2d.fillStyle.parse.rgba-clamp-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgba-clamp-1.html: Added.
- canvas/2d.fillStyle.parse.rgba-clamp-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgba-clamp-2.html: Added.
- canvas/2d.fillStyle.parse.rgba-eof-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgba-eof.html: Added.
- canvas/2d.fillStyle.parse.rgba-num-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgba-num-1.html: Added.
- canvas/2d.fillStyle.parse.rgba-num-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgba-num-2.html: Added.
- canvas/2d.fillStyle.parse.rgba-percent-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgba-percent.html: Added.
- canvas/2d.fillStyle.parse.rgba-solid-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgba-solid-1.html: Added.
- canvas/2d.fillStyle.parse.rgba-solid-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgba-solid-2.html: Added.
- canvas/2d.fillStyle.parse.rgba-solid-3-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgba-solid-3.html: Added.
- canvas/2d.fillStyle.parse.rgba-solid-4-expected.txt: Added.
- canvas/2d.fillStyle.parse.rgba-solid-4.html: Added.
- canvas/2d.fillStyle.parse.svg-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.svg-1.html: Added.
- canvas/2d.fillStyle.parse.svg-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.svg-2.html: Added.
- canvas/2d.fillStyle.parse.system-expected.txt: Added.
- canvas/2d.fillStyle.parse.system.html: Added.
- canvas/2d.fillStyle.parse.transparent-1-expected.txt: Added.
- canvas/2d.fillStyle.parse.transparent-1.html: Added.
- canvas/2d.fillStyle.parse.transparent-2-expected.txt: Added.
- canvas/2d.fillStyle.parse.transparent-2.html: Added.
- canvas/2d.getcontext.exists-expected.txt: Added.
- canvas/2d.getcontext.exists.html: Added.
- canvas/2d.getcontext.extraargs-expected.txt: Added.
- canvas/2d.getcontext.extraargs.html: Added.
- canvas/2d.getcontext.shared-expected.txt: Added.
- canvas/2d.getcontext.shared.html: Added.
- canvas/2d.getcontext.unique-expected.txt: Added.
- canvas/2d.getcontext.unique.html: Added.
- canvas/2d.gradient.empty-expected.txt: Added.
- canvas/2d.gradient.empty.html: Added.
- canvas/2d.gradient.interpolate.alpha-expected.txt: Added.
- canvas/2d.gradient.interpolate.alpha.html: Added.
- canvas/2d.gradient.interpolate.colour-expected.txt: Added.
- canvas/2d.gradient.interpolate.colour.html: Added.
- canvas/2d.gradient.interpolate.colouralpha-expected.txt: Added.
- canvas/2d.gradient.interpolate.colouralpha.html: Added.
- canvas/2d.gradient.interpolate.multiple-expected.txt: Added.
- canvas/2d.gradient.interpolate.multiple.html: Added.
- canvas/2d.gradient.interpolate.outside-expected.txt: Added.
- canvas/2d.gradient.interpolate.outside.html: Added.
- canvas/2d.gradient.interpolate.overlap-expected.txt: Added.
- canvas/2d.gradient.interpolate.overlap.html: Added.
- canvas/2d.gradient.interpolate.overlap2-expected.txt: Added.
- canvas/2d.gradient.interpolate.overlap2.html: Added.
- canvas/2d.gradient.interpolate.solid-expected.txt: Added.
- canvas/2d.gradient.interpolate.solid.html: Added.
- canvas/2d.gradient.interpolate.vertical-expected.txt: Added.
- canvas/2d.gradient.interpolate.vertical.html: Added.
- canvas/2d.gradient.interpolate.zerosize-expected.txt: Added.
- canvas/2d.gradient.interpolate.zerosize.fill-expected.txt: Added.
- canvas/2d.gradient.interpolate.zerosize.fill.html: Added.
- canvas/2d.gradient.interpolate.zerosize.fillRect-expected.txt: Added.
- canvas/2d.gradient.interpolate.zerosize.fillRect.html: Added.
- canvas/2d.gradient.interpolate.zerosize.fillText-expected.txt: Added.
- canvas/2d.gradient.interpolate.zerosize.fillText.html: Added.
- canvas/2d.gradient.interpolate.zerosize.html: Added.
- canvas/2d.gradient.interpolate.zerosize.stroke-expected.txt: Added.
- canvas/2d.gradient.interpolate.zerosize.stroke.html: Added.
- canvas/2d.gradient.interpolate.zerosize.strokeRect-expected.txt: Added.
- canvas/2d.gradient.interpolate.zerosize.strokeRect.html: Added.
- canvas/2d.gradient.interpolate.zerosize.strokeText-expected.txt: Added.
- canvas/2d.gradient.interpolate.zerosize.strokeText.html: Added.
- canvas/2d.gradient.linear.nonfinite-expected.txt: Added.
- canvas/2d.gradient.linear.nonfinite.html: Added.
- canvas/2d.gradient.linear.transform.1-expected.txt: Added.
- canvas/2d.gradient.linear.transform.1.html: Added.
- canvas/2d.gradient.linear.transform.2-expected.txt: Added.
- canvas/2d.gradient.linear.transform.2.html: Added.
- canvas/2d.gradient.linear.transform.3-expected.txt: Added.
- canvas/2d.gradient.linear.transform.3.html: Added.
- canvas/2d.gradient.object.compare-expected.txt: Added.
- canvas/2d.gradient.object.compare.html: Added.
- canvas/2d.gradient.object.crosscanvas-expected.txt: Added.
- canvas/2d.gradient.object.crosscanvas.html: Added.
- canvas/2d.gradient.object.current-expected.txt: Added.
- canvas/2d.gradient.object.current.html: Added.
- canvas/2d.gradient.object.invalidcolour-expected.txt: Added.
- canvas/2d.gradient.object.invalidcolour.html: Added.
- canvas/2d.gradient.object.invalidoffset-expected.txt: Added.
- canvas/2d.gradient.object.invalidoffset.html: Added.
- canvas/2d.gradient.object.return-expected.txt: Added.
- canvas/2d.gradient.object.return.html: Added.
- canvas/2d.gradient.object.update-expected.txt: Added.
- canvas/2d.gradient.object.update.html: Added.
- canvas/2d.gradient.radial.cone.behind-expected.txt: Added.
- canvas/2d.gradient.radial.cone.behind.html: Added.
- canvas/2d.gradient.radial.cone.beside-expected.txt: Added.
- canvas/2d.gradient.radial.cone.beside.html: Added.
- canvas/2d.gradient.radial.cone.bottom-expected.txt: Added.
- canvas/2d.gradient.radial.cone.bottom.html: Added.
- canvas/2d.gradient.radial.cone.cylinder-expected.txt: Added.
- canvas/2d.gradient.radial.cone.cylinder.html: Added.
- canvas/2d.gradient.radial.cone.front-expected.txt: Added.
- canvas/2d.gradient.radial.cone.front.html: Added.
- canvas/2d.gradient.radial.cone.shape1-expected.txt: Added.
- canvas/2d.gradient.radial.cone.shape1.html: Added.
- canvas/2d.gradient.radial.cone.shape2-expected.txt: Added.
- canvas/2d.gradient.radial.cone.shape2.html: Added.
- canvas/2d.gradient.radial.cone.top-expected.txt: Added.
- canvas/2d.gradient.radial.cone.top.html: Added.
- canvas/2d.gradient.radial.equal-expected.txt: Added.
- canvas/2d.gradient.radial.equal.html: Added.
- canvas/2d.gradient.radial.inside1-expected.txt: Added.
- canvas/2d.gradient.radial.inside1.html: Added.
- canvas/2d.gradient.radial.inside2-expected.txt: Added.
- canvas/2d.gradient.radial.inside2.html: Added.
- canvas/2d.gradient.radial.inside3-expected.txt: Added.
- canvas/2d.gradient.radial.inside3.html: Added.
- canvas/2d.gradient.radial.negative-expected.txt: Added.
- canvas/2d.gradient.radial.negative.html: Added.
- canvas/2d.gradient.radial.nonfinite-expected.txt: Added.
- canvas/2d.gradient.radial.nonfinite.html: Added.
- canvas/2d.gradient.radial.outside1-expected.txt: Added.
- canvas/2d.gradient.radial.outside1.html: Added.
- canvas/2d.gradient.radial.outside2-expected.txt: Added.
- canvas/2d.gradient.radial.outside2.html: Added.
- canvas/2d.gradient.radial.outside3-expected.txt: Added.
- canvas/2d.gradient.radial.outside3.html: Added.
- canvas/2d.gradient.radial.touch1-expected.txt: Added.
- canvas/2d.gradient.radial.touch1.html: Added.
- canvas/2d.gradient.radial.touch2-expected.txt: Added.
- canvas/2d.gradient.radial.touch2.html: Added.
- canvas/2d.gradient.radial.touch3-expected.txt: Added.
- canvas/2d.gradient.radial.touch3.html: Added.
- canvas/2d.gradient.radial.transform.1-expected.txt: Added.
- canvas/2d.gradient.radial.transform.1.html: Added.
- canvas/2d.gradient.radial.transform.2-expected.txt: Added.
- canvas/2d.gradient.radial.transform.2.html: Added.
- canvas/2d.gradient.radial.transform.3-expected.txt: Added.
- canvas/2d.gradient.radial.transform.3.html: Added.
- canvas/2d.imageData.create1.basic-expected.txt: Added.
- canvas/2d.imageData.create1.basic.html: Added.
- canvas/2d.imageData.create1.initial-expected.txt: Added.
- canvas/2d.imageData.create1.initial.html: Added.
- canvas/2d.imageData.create1.type-expected.txt: Added.
- canvas/2d.imageData.create1.type.html: Added.
- canvas/2d.imageData.create1.zero-expected.txt: Added.
- canvas/2d.imageData.create1.zero.html: Added.
- canvas/2d.imageData.create2.basic-expected.txt: Added.
- canvas/2d.imageData.create2.basic.html: Added.
- canvas/2d.imageData.create2.initial-expected.txt: Added.
- canvas/2d.imageData.create2.initial.html: Added.
- canvas/2d.imageData.create2.large-expected.txt: Added.
- canvas/2d.imageData.create2.large.html: Added.
- canvas/2d.imageData.create2.negative-expected.txt: Added.
- canvas/2d.imageData.create2.negative.html: Added.
- canvas/2d.imageData.create2.nonfinite-expected.txt: Added.
- canvas/2d.imageData.create2.nonfinite.html: Added.
- canvas/2d.imageData.create2.round-expected.txt: Added.
- canvas/2d.imageData.create2.round.html: Added.
- canvas/2d.imageData.create2.tiny-expected.txt: Added.
- canvas/2d.imageData.create2.tiny.html: Added.
- canvas/2d.imageData.create2.type-expected.txt: Added.
- canvas/2d.imageData.create2.type.html: Added.
- canvas/2d.imageData.create2.zero-expected.txt: Added.
- canvas/2d.imageData.create2.zero.html: Added.
- canvas/2d.imageData.get.basic-expected.txt: Added.
- canvas/2d.imageData.get.basic.html: Added.
- canvas/2d.imageData.get.clamp-expected.txt: Added.
- canvas/2d.imageData.get.clamp.html: Added.
- canvas/2d.imageData.get.length-expected.txt: Added.
- canvas/2d.imageData.get.length.html: Added.
- canvas/2d.imageData.get.nonfinite-expected.txt: Added.
- canvas/2d.imageData.get.nonfinite.html: Added.
- canvas/2d.imageData.get.nonpremul-expected.txt: Added.
- canvas/2d.imageData.get.nonpremul.html: Added.
- canvas/2d.imageData.get.order.alpha-expected.txt: Added.
- canvas/2d.imageData.get.order.alpha.html: Added.
- canvas/2d.imageData.get.order.cols-expected.txt: Added.
- canvas/2d.imageData.get.order.cols.html: Added.
- canvas/2d.imageData.get.order.rgb-expected.txt: Added.
- canvas/2d.imageData.get.order.rgb.html: Added.
- canvas/2d.imageData.get.order.rows-expected.txt: Added.
- canvas/2d.imageData.get.order.rows.html: Added.
- canvas/2d.imageData.get.range-expected.txt: Added.
- canvas/2d.imageData.get.range.html: Added.
- canvas/2d.imageData.get.source.negative-expected.txt: Added.
- canvas/2d.imageData.get.source.negative.html: Added.
- canvas/2d.imageData.get.source.outside-expected.txt: Added.
- canvas/2d.imageData.get.source.outside.html: Added.
- canvas/2d.imageData.get.source.size-expected.txt: Added.
- canvas/2d.imageData.get.source.size.html: Added.
- canvas/2d.imageData.get.tiny-expected.txt: Added.
- canvas/2d.imageData.get.tiny.html: Added.
- canvas/2d.imageData.get.type-expected.txt: Added.
- canvas/2d.imageData.get.type.html: Added.
- canvas/2d.imageData.get.unaffected-expected.txt: Added.
- canvas/2d.imageData.get.unaffected.html: Added.
- canvas/2d.imageData.get.zero-expected.txt: Added.
- canvas/2d.imageData.get.zero.html: Added.
- canvas/2d.imageData.object.clamp-expected.txt: Added.
- canvas/2d.imageData.object.clamp.html: Added.
- canvas/2d.imageData.object.ctor-expected.txt: Added.
- canvas/2d.imageData.object.ctor.html: Added.
- canvas/2d.imageData.object.nan-expected.txt: Added.
- canvas/2d.imageData.object.nan.html: Added.
- canvas/2d.imageData.object.properties-expected.txt: Added.
- canvas/2d.imageData.object.properties.html: Added.
- canvas/2d.imageData.object.readonly-expected.txt: Added.
- canvas/2d.imageData.object.readonly.html: Added.
- canvas/2d.imageData.object.round-expected.txt: Added.
- canvas/2d.imageData.object.round.html: Added.
- canvas/2d.imageData.object.set-expected.txt: Added.
- canvas/2d.imageData.object.set.html: Added.
- canvas/2d.imageData.object.string-expected.txt: Added.
- canvas/2d.imageData.object.string.html: Added.
- canvas/2d.imageData.object.undefined-expected.txt: Added.
- canvas/2d.imageData.object.undefined.html: Added.
- canvas/2d.imageData.put.alpha-expected.txt: Added.
- canvas/2d.imageData.put.alpha.html: Added.
- canvas/2d.imageData.put.basic-expected.txt: Added.
- canvas/2d.imageData.put.basic.html: Added.
- canvas/2d.imageData.put.clip-expected.txt: Added.
- canvas/2d.imageData.put.clip.html: Added.
- canvas/2d.imageData.put.created-expected.txt: Added.
- canvas/2d.imageData.put.created.html: Added.
- canvas/2d.imageData.put.cross-expected.txt: Added.
- canvas/2d.imageData.put.cross.html: Added.
- canvas/2d.imageData.put.dirty.negative-expected.txt: Added.
- canvas/2d.imageData.put.dirty.negative.html: Added.
- canvas/2d.imageData.put.dirty.outside-expected.txt: Added.
- canvas/2d.imageData.put.dirty.outside.html: Added.
- canvas/2d.imageData.put.dirty.rect1-expected.txt: Added.
- canvas/2d.imageData.put.dirty.rect1.html: Added.
- canvas/2d.imageData.put.dirty.rect2-expected.txt: Added.
- canvas/2d.imageData.put.dirty.rect2.html: Added.
- canvas/2d.imageData.put.dirty.zero-expected.txt: Added.
- canvas/2d.imageData.put.dirty.zero.html: Added.
- canvas/2d.imageData.put.modified-expected.txt: Added.
- canvas/2d.imageData.put.modified.html: Added.
- canvas/2d.imageData.put.nonfinite-expected.txt: Added.
- canvas/2d.imageData.put.nonfinite.html: Added.
- canvas/2d.imageData.put.null-expected.txt: Added.
- canvas/2d.imageData.put.null.html: Added.
- canvas/2d.imageData.put.path-expected.txt: Added.
- canvas/2d.imageData.put.path.html: Added.
- canvas/2d.imageData.put.unaffected-expected.txt: Added.
- canvas/2d.imageData.put.unaffected.html: Added.
- canvas/2d.imageData.put.unchanged-expected.txt: Added.
- canvas/2d.imageData.put.unchanged.html: Added.
- canvas/2d.imageData.put.wrongtype-expected.txt: Added.
- canvas/2d.imageData.put.wrongtype.html: Added.
- canvas/2d.line.cap.butt-expected.txt: Added.
- canvas/2d.line.cap.butt.html: Added.
- canvas/2d.line.cap.closed-expected.txt: Added.
- canvas/2d.line.cap.closed.html: Added.
- canvas/2d.line.cap.open-expected.txt: Added.
- canvas/2d.line.cap.open.html: Added.
- canvas/2d.line.cap.round-expected.txt: Added.
- canvas/2d.line.cap.round.html: Added.
- canvas/2d.line.cap.square-expected.txt: Added.
- canvas/2d.line.cap.square.html: Added.
- canvas/2d.line.cap.valid-expected.txt: Added.
- canvas/2d.line.cap.valid.html: Added.
- canvas/2d.line.cross-expected.txt: Added.
- canvas/2d.line.cross.html: Added.
- canvas/2d.line.defaults-expected.txt: Added.
- canvas/2d.line.defaults.html: Added.
- canvas/2d.line.join.bevel-expected.txt: Added.
- canvas/2d.line.join.bevel.html: Added.
- canvas/2d.line.join.closed-expected.txt: Added.
- canvas/2d.line.join.closed.html: Added.
- canvas/2d.line.join.miter-expected.txt: Added.
- canvas/2d.line.join.miter.html: Added.
- canvas/2d.line.join.open-expected.txt: Added.
- canvas/2d.line.join.open.html: Added.
- canvas/2d.line.join.parallel-expected.txt: Added.
- canvas/2d.line.join.parallel.html: Added.
- canvas/2d.line.join.round-expected.txt: Added.
- canvas/2d.line.join.round.html: Added.
- canvas/2d.line.join.valid-expected.txt: Added.
- canvas/2d.line.join.valid.html: Added.
- canvas/2d.line.miter.acute-expected.txt: Added.
- canvas/2d.line.miter.acute.html: Added.
- canvas/2d.line.miter.exceeded-expected.txt: Added.
- canvas/2d.line.miter.exceeded.html: Added.
- canvas/2d.line.miter.invalid-expected.txt: Added.
- canvas/2d.line.miter.invalid.html: Added.
- canvas/2d.line.miter.lineedge-expected.txt: Added.
- canvas/2d.line.miter.lineedge.html: Added.
- canvas/2d.line.miter.obtuse-expected.txt: Added.
- canvas/2d.line.miter.obtuse.html: Added.
- canvas/2d.line.miter.rightangle-expected.txt: Added.
- canvas/2d.line.miter.rightangle.html: Added.
- canvas/2d.line.miter.valid-expected.txt: Added.
- canvas/2d.line.miter.valid.html: Added.
- canvas/2d.line.miter.within-expected.txt: Added.
- canvas/2d.line.miter.within.html: Added.
- canvas/2d.line.union-expected.txt: Added.
- canvas/2d.line.union.html: Added.
- canvas/2d.line.width.basic-expected.txt: Added.
- canvas/2d.line.width.basic.html: Added.
- canvas/2d.line.width.invalid-expected.txt: Added.
- canvas/2d.line.width.invalid.html: Added.
- canvas/2d.line.width.scaledefault-expected.txt: Added.
- canvas/2d.line.width.scaledefault.html: Added.
- canvas/2d.line.width.transformed-expected.txt: Added.
- canvas/2d.line.width.transformed.html: Added.
- canvas/2d.line.width.valid-expected.txt: Added.
- canvas/2d.line.width.valid.html: Added.
- canvas/2d.path.arc.angle.1-expected.txt: Added.
- canvas/2d.path.arc.angle.1.html: Added.
- canvas/2d.path.arc.angle.2-expected.txt: Added.
- canvas/2d.path.arc.angle.2.html: Added.
- canvas/2d.path.arc.angle.3-expected.txt: Added.
- canvas/2d.path.arc.angle.3.html: Added.
- canvas/2d.path.arc.angle.4-expected.txt: Added.
- canvas/2d.path.arc.angle.4.html: Added.
- canvas/2d.path.arc.angle.5-expected.txt: Added.
- canvas/2d.path.arc.angle.5.html: Added.
- canvas/2d.path.arc.angle.6-expected.txt: Added.
- canvas/2d.path.arc.angle.6.html: Added.
- canvas/2d.path.arc.default-expected.txt: Added.
- canvas/2d.path.arc.default.html: Added.
- canvas/2d.path.arc.empty-expected.txt: Added.
- canvas/2d.path.arc.empty.html: Added.
- canvas/2d.path.arc.end-expected.txt: Added.
- canvas/2d.path.arc.end.html: Added.
- canvas/2d.path.arc.negative-expected.txt: Added.
- canvas/2d.path.arc.negative.html: Added.
- canvas/2d.path.arc.nonempty-expected.txt: Added.
- canvas/2d.path.arc.nonempty.html: Added.
- canvas/2d.path.arc.nonfinite-expected.txt: Added.
- canvas/2d.path.arc.nonfinite.html: Added.
- canvas/2d.path.arc.scale.1-expected.txt: Added.
- canvas/2d.path.arc.scale.1.html: Added.
- canvas/2d.path.arc.scale.2-expected.txt: Added.
- canvas/2d.path.arc.scale.2.html: Added.
- canvas/2d.path.arc.selfintersect.1-expected.txt: Added.
- canvas/2d.path.arc.selfintersect.1.html: Added.
- canvas/2d.path.arc.selfintersect.2-expected.txt: Added.
- canvas/2d.path.arc.selfintersect.2.html: Added.
- canvas/2d.path.arc.shape.1-expected.txt: Added.
- canvas/2d.path.arc.shape.1.html: Added.
- canvas/2d.path.arc.shape.2-expected.txt: Added.
- canvas/2d.path.arc.shape.2.html: Added.
- canvas/2d.path.arc.shape.3-expected.txt: Added.
- canvas/2d.path.arc.shape.3.html: Added.
- canvas/2d.path.arc.shape.4-expected.txt: Added.
- canvas/2d.path.arc.shape.4.html: Added.
- canvas/2d.path.arc.shape.5-expected.txt: Added.
- canvas/2d.path.arc.shape.5.html: Added.
- canvas/2d.path.arc.twopie.1-expected.txt: Added.
- canvas/2d.path.arc.twopie.1.html: Added.
- canvas/2d.path.arc.twopie.2-expected.txt: Added.
- canvas/2d.path.arc.twopie.2.html: Added.
- canvas/2d.path.arc.twopie.3-expected.txt: Added.
- canvas/2d.path.arc.twopie.3.html: Added.
- canvas/2d.path.arc.twopie.4-expected.txt: Added.
- canvas/2d.path.arc.twopie.4.html: Added.
- canvas/2d.path.arc.zero.1-expected.txt: Added.
- canvas/2d.path.arc.zero.1.html: Added.
- canvas/2d.path.arc.zero.2-expected.txt: Added.
- canvas/2d.path.arc.zero.2.html: Added.
- canvas/2d.path.arc.zeroradius-expected.txt: Added.
- canvas/2d.path.arc.zeroradius.html: Added.
- canvas/2d.path.arcTo.coincide.1-expected.txt: Added.
- canvas/2d.path.arcTo.coincide.1.html: Added.
- canvas/2d.path.arcTo.coincide.2-expected.txt: Added.
- canvas/2d.path.arcTo.coincide.2.html: Added.
- canvas/2d.path.arcTo.collinear.1-expected.txt: Added.
- canvas/2d.path.arcTo.collinear.1.html: Added.
- canvas/2d.path.arcTo.collinear.2-expected.txt: Added.
- canvas/2d.path.arcTo.collinear.2.html: Added.
- canvas/2d.path.arcTo.collinear.3-expected.txt: Added.
- canvas/2d.path.arcTo.collinear.3.html: Added.
- canvas/2d.path.arcTo.ensuresubpath.1-expected.txt: Added.
- canvas/2d.path.arcTo.ensuresubpath.1.html: Added.
- canvas/2d.path.arcTo.ensuresubpath.2-expected.txt: Added.
- canvas/2d.path.arcTo.ensuresubpath.2.html: Added.
- canvas/2d.path.arcTo.negative-expected.txt: Added.
- canvas/2d.path.arcTo.negative.html: Added.
- canvas/2d.path.arcTo.nonfinite-expected.txt: Added.
- canvas/2d.path.arcTo.nonfinite.html: Added.
- canvas/2d.path.arcTo.scale-expected.txt: Added.
- canvas/2d.path.arcTo.scale.html: Added.
- canvas/2d.path.arcTo.shape.curve1-expected.txt: Added.
- canvas/2d.path.arcTo.shape.curve1.html: Added.
- canvas/2d.path.arcTo.shape.curve2-expected.txt: Added.
- canvas/2d.path.arcTo.shape.curve2.html: Added.
- canvas/2d.path.arcTo.shape.end-expected.txt: Added.
- canvas/2d.path.arcTo.shape.end.html: Added.
- canvas/2d.path.arcTo.shape.start-expected.txt: Added.
- canvas/2d.path.arcTo.shape.start.html: Added.
- canvas/2d.path.arcTo.transformation-expected.txt: Added.
- canvas/2d.path.arcTo.transformation.html: Added.
- canvas/2d.path.arcTo.zero.1-expected.txt: Added.
- canvas/2d.path.arcTo.zero.1.html: Added.
- canvas/2d.path.arcTo.zero.2-expected.txt: Added.
- canvas/2d.path.arcTo.zero.2.html: Added.
- canvas/2d.path.beginPath-expected.txt: Added.
- canvas/2d.path.beginPath.html: Added.
- canvas/2d.path.bezierCurveTo.basic-expected.txt: Added.
- canvas/2d.path.bezierCurveTo.basic.html: Added.
- canvas/2d.path.bezierCurveTo.ensuresubpath.1-expected.txt: Added.
- canvas/2d.path.bezierCurveTo.ensuresubpath.1.html: Added.
- canvas/2d.path.bezierCurveTo.ensuresubpath.2-expected.txt: Added.
- canvas/2d.path.bezierCurveTo.ensuresubpath.2.html: Added.
- canvas/2d.path.bezierCurveTo.nonfinite-expected.txt: Added.
- canvas/2d.path.bezierCurveTo.nonfinite.html: Added.
- canvas/2d.path.bezierCurveTo.scaled-expected.txt: Added.
- canvas/2d.path.bezierCurveTo.scaled.html: Added.
- canvas/2d.path.bezierCurveTo.shape-expected.txt: Added.
- canvas/2d.path.bezierCurveTo.shape.html: Added.
- canvas/2d.path.clip.basic.1-expected.txt: Added.
- canvas/2d.path.clip.basic.1.html: Added.
- canvas/2d.path.clip.basic.2-expected.txt: Added.
- canvas/2d.path.clip.basic.2.html: Added.
- canvas/2d.path.clip.empty-expected.txt: Added.
- canvas/2d.path.clip.empty.html: Added.
- canvas/2d.path.clip.intersect-expected.txt: Added.
- canvas/2d.path.clip.intersect.html: Added.
- canvas/2d.path.clip.unaffected-expected.txt: Added.
- canvas/2d.path.clip.unaffected.html: Added.
- canvas/2d.path.clip.winding.1-expected.txt: Added.
- canvas/2d.path.clip.winding.1.html: Added.
- canvas/2d.path.clip.winding.2-expected.txt: Added.
- canvas/2d.path.clip.winding.2.html: Added.
- canvas/2d.path.closePath.empty-expected.txt: Added.
- canvas/2d.path.closePath.empty.html: Added.
- canvas/2d.path.closePath.newline-expected.txt: Added.
- canvas/2d.path.closePath.newline.html: Added.
- canvas/2d.path.closePath.nextpoint-expected.txt: Added.
- canvas/2d.path.closePath.nextpoint.html: Added.
- canvas/2d.path.fill.closed.basic-expected.txt: Added.
- canvas/2d.path.fill.closed.basic.html: Added.
- canvas/2d.path.fill.closed.unaffected-expected.txt: Added.
- canvas/2d.path.fill.closed.unaffected.html: Added.
- canvas/2d.path.fill.overlap-expected.txt: Added.
- canvas/2d.path.fill.overlap.html: Added.
- canvas/2d.path.fill.winding.add-expected.txt: Added.
- canvas/2d.path.fill.winding.add.html: Added.
- canvas/2d.path.fill.winding.subtract.1-expected.txt: Added.
- canvas/2d.path.fill.winding.subtract.1.html: Added.
- canvas/2d.path.fill.winding.subtract.2-expected.txt: Added.
- canvas/2d.path.fill.winding.subtract.2.html: Added.
- canvas/2d.path.fill.winding.subtract.3-expected.txt: Added.
- canvas/2d.path.fill.winding.subtract.3.html: Added.
- canvas/2d.path.initial-expected.txt: Added.
- canvas/2d.path.initial.html: Added.
- canvas/2d.path.isPointInPath.arc-expected.txt: Added.
- canvas/2d.path.isPointInPath.arc.html: Added.
- canvas/2d.path.isPointInPath.basic.1-expected.txt: Added.
- canvas/2d.path.isPointInPath.basic.1.html: Added.
- canvas/2d.path.isPointInPath.basic.2-expected.txt: Added.
- canvas/2d.path.isPointInPath.basic.2.html: Added.
- canvas/2d.path.isPointInPath.bezier-expected.txt: Added.
- canvas/2d.path.isPointInPath.bezier.html: Added.
- canvas/2d.path.isPointInPath.bigarc-expected.txt: Added.
- canvas/2d.path.isPointInPath.bigarc.html: Added.
- canvas/2d.path.isPointInPath.edge-expected.txt: Added.
- canvas/2d.path.isPointInPath.edge.html: Added.
- canvas/2d.path.isPointInPath.empty-expected.txt: Added.
- canvas/2d.path.isPointInPath.empty.html: Added.
- canvas/2d.path.isPointInPath.nonfinite-expected.txt: Added.
- canvas/2d.path.isPointInPath.nonfinite.html: Added.
- canvas/2d.path.isPointInPath.outside-expected.txt: Added.
- canvas/2d.path.isPointInPath.outside.html: Added.
- canvas/2d.path.isPointInPath.subpath-expected.txt: Added.
- canvas/2d.path.isPointInPath.subpath.html: Added.
- canvas/2d.path.isPointInPath.transform.1-expected.txt: Added.
- canvas/2d.path.isPointInPath.transform.1.html: Added.
- canvas/2d.path.isPointInPath.transform.2-expected.txt: Added.
- canvas/2d.path.isPointInPath.transform.2.html: Added.
- canvas/2d.path.isPointInPath.transform.3-expected.txt: Added.
- canvas/2d.path.isPointInPath.transform.3.html: Added.
- canvas/2d.path.isPointInPath.unclosed-expected.txt: Added.
- canvas/2d.path.isPointInPath.unclosed.html: Added.
- canvas/2d.path.isPointInPath.winding-expected.txt: Added.
- canvas/2d.path.isPointInPath.winding.html: Added.
- canvas/2d.path.lineTo.basic-expected.txt: Added.
- canvas/2d.path.lineTo.basic.html: Added.
- canvas/2d.path.lineTo.ensuresubpath.1-expected.txt: Added.
- canvas/2d.path.lineTo.ensuresubpath.1.html: Added.
- canvas/2d.path.lineTo.ensuresubpath.2-expected.txt: Added.
- canvas/2d.path.lineTo.ensuresubpath.2.html: Added.
- canvas/2d.path.lineTo.nextpoint-expected.txt: Added.
- canvas/2d.path.lineTo.nextpoint.html: Added.
- canvas/2d.path.lineTo.nonfinite-expected.txt: Added.
- canvas/2d.path.lineTo.nonfinite.html: Added.
- canvas/2d.path.moveTo.basic-expected.txt: Added.
- canvas/2d.path.moveTo.basic.html: Added.
- canvas/2d.path.moveTo.multiple-expected.txt: Added.
- canvas/2d.path.moveTo.multiple.html: Added.
- canvas/2d.path.moveTo.newsubpath-expected.txt: Added.
- canvas/2d.path.moveTo.newsubpath.html: Added.
- canvas/2d.path.moveTo.nonfinite-expected.txt: Added.
- canvas/2d.path.moveTo.nonfinite.html: Added.
- canvas/2d.path.quadraticCurveTo.basic-expected.txt: Added.
- canvas/2d.path.quadraticCurveTo.basic.html: Added.
- canvas/2d.path.quadraticCurveTo.ensuresubpath.1-expected.txt: Added.
- canvas/2d.path.quadraticCurveTo.ensuresubpath.1.html: Added.
- canvas/2d.path.quadraticCurveTo.ensuresubpath.2-expected.txt: Added.
- canvas/2d.path.quadraticCurveTo.ensuresubpath.2.html: Added.
- canvas/2d.path.quadraticCurveTo.nonfinite-expected.txt: Added.
- canvas/2d.path.quadraticCurveTo.nonfinite.html: Added.
- canvas/2d.path.quadraticCurveTo.scaled-expected.txt: Added.
- canvas/2d.path.quadraticCurveTo.scaled.html: Added.
- canvas/2d.path.quadraticCurveTo.shape-expected.txt: Added.
- canvas/2d.path.quadraticCurveTo.shape.html: Added.
- canvas/2d.path.rect.basic-expected.txt: Added.
- canvas/2d.path.rect.basic.html: Added.
- canvas/2d.path.rect.closed-expected.txt: Added.
- canvas/2d.path.rect.closed.html: Added.
- canvas/2d.path.rect.end.1-expected.txt: Added.
- canvas/2d.path.rect.end.1.html: Added.
- canvas/2d.path.rect.end.2-expected.txt: Added.
- canvas/2d.path.rect.end.2.html: Added.
- canvas/2d.path.rect.negative-expected.txt: Added.
- canvas/2d.path.rect.negative.html: Added.
- canvas/2d.path.rect.newsubpath-expected.txt: Added.
- canvas/2d.path.rect.newsubpath.html: Added.
- canvas/2d.path.rect.nonfinite-expected.txt: Added.
- canvas/2d.path.rect.nonfinite.html: Added.
- canvas/2d.path.rect.selfintersect-expected.txt: Added.
- canvas/2d.path.rect.selfintersect.html: Added.
- canvas/2d.path.rect.winding-expected.txt: Added.
- canvas/2d.path.rect.winding.html: Added.
- canvas/2d.path.rect.zero.1-expected.txt: Added.
- canvas/2d.path.rect.zero.1.html: Added.
- canvas/2d.path.rect.zero.2-expected.txt: Added.
- canvas/2d.path.rect.zero.2.html: Added.
- canvas/2d.path.rect.zero.3-expected.txt: Added.
- canvas/2d.path.rect.zero.3.html: Added.
- canvas/2d.path.rect.zero.4-expected.txt: Added.
- canvas/2d.path.rect.zero.4.html: Added.
- canvas/2d.path.rect.zero.5-expected.txt: Added.
- canvas/2d.path.rect.zero.5.html: Added.
- canvas/2d.path.rect.zero.6-expected.txt: Added.
- canvas/2d.path.rect.zero.6.html: Added.
- canvas/2d.path.stroke.empty-expected.txt: Added.
- canvas/2d.path.stroke.empty.html: Added.
- canvas/2d.path.stroke.overlap-expected.txt: Added.
- canvas/2d.path.stroke.overlap.html: Added.
- canvas/2d.path.stroke.prune.arc-expected.txt: Added.
- canvas/2d.path.stroke.prune.arc.html: Added.
- canvas/2d.path.stroke.prune.closed-expected.txt: Added.
- canvas/2d.path.stroke.prune.closed.html: Added.
- canvas/2d.path.stroke.prune.corner-expected.txt: Added.
- canvas/2d.path.stroke.prune.corner.html: Added.
- canvas/2d.path.stroke.prune.curve-expected.txt: Added.
- canvas/2d.path.stroke.prune.curve.html: Added.
- canvas/2d.path.stroke.prune.line-expected.txt: Added.
- canvas/2d.path.stroke.prune.line.html: Added.
- canvas/2d.path.stroke.prune.rect-expected.txt: Added.
- canvas/2d.path.stroke.prune.rect.html: Added.
- canvas/2d.path.stroke.scale1-expected.txt: Added.
- canvas/2d.path.stroke.scale1.html: Added.
- canvas/2d.path.stroke.scale2-expected.txt: Added.
- canvas/2d.path.stroke.scale2.html: Added.
- canvas/2d.path.stroke.skew-expected.txt: Added.
- canvas/2d.path.stroke.skew.html: Added.
- canvas/2d.path.stroke.unaffected-expected.txt: Added.
- canvas/2d.path.stroke.unaffected.html: Added.
- canvas/2d.path.stroke.union-expected.txt: Added.
- canvas/2d.path.stroke.union.html: Added.
- canvas/2d.path.transformation.basic-expected.txt: Added.
- canvas/2d.path.transformation.basic.html: Added.
- canvas/2d.path.transformation.changing-expected.txt: Added.
- canvas/2d.path.transformation.changing.html: Added.
- canvas/2d.path.transformation.multiple-expected.txt: Added.
- canvas/2d.path.transformation.multiple.html: Added.
- canvas/2d.pattern.animated.gif.html: Added.
- canvas/2d.pattern.basic.canvas-expected.txt: Added.
- canvas/2d.pattern.basic.canvas.html: Added.
- canvas/2d.pattern.basic.image-expected.txt: Added.
- canvas/2d.pattern.basic.image.html: Added.
- canvas/2d.pattern.basic.nocontext-expected.txt: Added.
- canvas/2d.pattern.basic.nocontext.html: Added.
- canvas/2d.pattern.basic.type-expected.txt: Added.
- canvas/2d.pattern.basic.type.html: Added.
- canvas/2d.pattern.basic.zerocanvas-expected.txt: Added.
- canvas/2d.pattern.basic.zerocanvas.html: Added.
- canvas/2d.pattern.crosscanvas-expected.txt: Added.
- canvas/2d.pattern.crosscanvas.html: Added.
- canvas/2d.pattern.image.incomplete-expected.txt: Added.
- canvas/2d.pattern.image.incomplete.empty-expected.txt: Added.
- canvas/2d.pattern.image.incomplete.empty.html: Added.
- canvas/2d.pattern.image.incomplete.html: Added.
- canvas/2d.pattern.image.incomplete.omitted-expected.txt: Added.
- canvas/2d.pattern.image.incomplete.omitted.html: Added.
- canvas/2d.pattern.image.null-expected.txt: Added.
- canvas/2d.pattern.image.null.html: Added.
- canvas/2d.pattern.image.string-expected.txt: Added.
- canvas/2d.pattern.image.string.html: Added.
- canvas/2d.pattern.image.undefined-expected.txt: Added.
- canvas/2d.pattern.image.undefined.html: Added.
- canvas/2d.pattern.modify.canvas1-expected.txt: Added.
- canvas/2d.pattern.modify.canvas1.html: Added.
- canvas/2d.pattern.modify.canvas2-expected.txt: Added.
- canvas/2d.pattern.modify.canvas2.html: Added.
- canvas/2d.pattern.modify.image1.html: Added.
- canvas/2d.pattern.modify.image2.html: Added.
- canvas/2d.pattern.paint.norepeat.basic-expected.txt: Added.
- canvas/2d.pattern.paint.norepeat.basic.html: Added.
- canvas/2d.pattern.paint.norepeat.coord1-expected.txt: Added.
- canvas/2d.pattern.paint.norepeat.coord1.html: Added.
- canvas/2d.pattern.paint.norepeat.coord2-expected.txt: Added.
- canvas/2d.pattern.paint.norepeat.coord2.html: Added.
- canvas/2d.pattern.paint.norepeat.coord3-expected.txt: Added.
- canvas/2d.pattern.paint.norepeat.coord3.html: Added.
- canvas/2d.pattern.paint.norepeat.outside-expected.txt: Added.
- canvas/2d.pattern.paint.norepeat.outside.html: Added.
- canvas/2d.pattern.paint.orientation.canvas-expected.txt: Added.
- canvas/2d.pattern.paint.orientation.canvas.html: Added.
- canvas/2d.pattern.paint.orientation.image-expected.txt: Added.
- canvas/2d.pattern.paint.orientation.image.html: Added.
- canvas/2d.pattern.paint.repeat.basic-expected.txt: Added.
- canvas/2d.pattern.paint.repeat.basic.html: Added.
- canvas/2d.pattern.paint.repeat.coord1-expected.txt: Added.
- canvas/2d.pattern.paint.repeat.coord1.html: Added.
- canvas/2d.pattern.paint.repeat.coord2-expected.txt: Added.
- canvas/2d.pattern.paint.repeat.coord2.html: Added.
- canvas/2d.pattern.paint.repeat.coord3-expected.txt: Added.
- canvas/2d.pattern.paint.repeat.coord3.html: Added.
- canvas/2d.pattern.paint.repeat.outside-expected.txt: Added.
- canvas/2d.pattern.paint.repeat.outside.html: Added.
- canvas/2d.pattern.paint.repeatx.basic-expected.txt: Added.
- canvas/2d.pattern.paint.repeatx.basic.html: Added.
- canvas/2d.pattern.paint.repeatx.coord1-expected.txt: Added.
- canvas/2d.pattern.paint.repeatx.coord1.html: Added.
- canvas/2d.pattern.paint.repeatx.outside-expected.txt: Added.
- canvas/2d.pattern.paint.repeatx.outside.html: Added.
- canvas/2d.pattern.paint.repeaty.basic-expected.txt: Added.
- canvas/2d.pattern.paint.repeaty.basic.html: Added.
- canvas/2d.pattern.paint.repeaty.coord1-expected.txt: Added.
- canvas/2d.pattern.paint.repeaty.coord1.html: Added.
- canvas/2d.pattern.paint.repeaty.outside-expected.txt: Added.
- canvas/2d.pattern.paint.repeaty.outside.html: Added.
- canvas/2d.pattern.repeat.case-expected.txt: Added.
- canvas/2d.pattern.repeat.case.html: Added.
- canvas/2d.pattern.repeat.empty-expected.txt: Added.
- canvas/2d.pattern.repeat.empty.html: Added.
- canvas/2d.pattern.repeat.null-expected.txt: Added.
- canvas/2d.pattern.repeat.null.html: Added.
- canvas/2d.pattern.repeat.undefined-expected.txt: Added.
- canvas/2d.pattern.repeat.undefined.html: Added.
- canvas/2d.pattern.repeat.unrecognised-expected.txt: Added.
- canvas/2d.pattern.repeat.unrecognised.html: Added.
- canvas/2d.scaled.html: Added.
- canvas/2d.shadow.alpha.1-expected.txt: Added.
- canvas/2d.shadow.alpha.1.html: Added.
- canvas/2d.shadow.alpha.2-expected.txt: Added.
- canvas/2d.shadow.alpha.2.html: Added.
- canvas/2d.shadow.alpha.3-expected.txt: Added.
- canvas/2d.shadow.alpha.3.html: Added.
- canvas/2d.shadow.alpha.4-expected.txt: Added.
- canvas/2d.shadow.alpha.4.html: Added.
- canvas/2d.shadow.alpha.5-expected.txt: Added.
- canvas/2d.shadow.alpha.5.html: Added.
- canvas/2d.shadow.attributes.shadowBlur.initial-expected.txt: Added.
- canvas/2d.shadow.attributes.shadowBlur.initial.html: Added.
- canvas/2d.shadow.attributes.shadowBlur.invalid-expected.txt: Added.
- canvas/2d.shadow.attributes.shadowBlur.invalid.html: Added.
- canvas/2d.shadow.attributes.shadowBlur.valid-expected.txt: Added.
- canvas/2d.shadow.attributes.shadowBlur.valid.html: Added.
- canvas/2d.shadow.attributes.shadowColor.initial-expected.txt: Added.
- canvas/2d.shadow.attributes.shadowColor.initial.html: Added.
- canvas/2d.shadow.attributes.shadowColor.invalid-expected.txt: Added.
- canvas/2d.shadow.attributes.shadowColor.invalid.html: Added.
- canvas/2d.shadow.attributes.shadowColor.valid-expected.txt: Added.
- canvas/2d.shadow.attributes.shadowColor.valid.html: Added.
- canvas/2d.shadow.attributes.shadowOffset.initial-expected.txt: Added.
- canvas/2d.shadow.attributes.shadowOffset.initial.html: Added.
- canvas/2d.shadow.attributes.shadowOffset.invalid-expected.txt: Added.
- canvas/2d.shadow.attributes.shadowOffset.invalid.html: Added.
- canvas/2d.shadow.attributes.shadowOffset.valid-expected.txt: Added.
- canvas/2d.shadow.attributes.shadowOffset.valid.html: Added.
- canvas/2d.shadow.blur.high.html: Added.
- canvas/2d.shadow.blur.low.html: Added.
- canvas/2d.shadow.canvas.alpha-expected.txt: Added.
- canvas/2d.shadow.canvas.alpha.html: Added.
- canvas/2d.shadow.canvas.basic-expected.txt: Added.
- canvas/2d.shadow.canvas.basic.html: Added.
- canvas/2d.shadow.canvas.transparent.1-expected.txt: Added.
- canvas/2d.shadow.canvas.transparent.1.html: Added.
- canvas/2d.shadow.canvas.transparent.2-expected.txt: Added.
- canvas/2d.shadow.canvas.transparent.2.html: Added.
- canvas/2d.shadow.clip.1-expected.txt: Added.
- canvas/2d.shadow.clip.1.html: Added.
- canvas/2d.shadow.clip.2-expected.txt: Added.
- canvas/2d.shadow.clip.2.html: Added.
- canvas/2d.shadow.clip.3-expected.txt: Added.
- canvas/2d.shadow.clip.3.html: Added.
- canvas/2d.shadow.composite.1-expected.txt: Added.
- canvas/2d.shadow.composite.1.html: Added.
- canvas/2d.shadow.composite.2-expected.txt: Added.
- canvas/2d.shadow.composite.2.html: Added.
- canvas/2d.shadow.composite.3-expected.txt: Added.
- canvas/2d.shadow.composite.3.html: Added.
- canvas/2d.shadow.enable.blur-expected.txt: Added.
- canvas/2d.shadow.enable.blur.html: Added.
- canvas/2d.shadow.enable.off.1-expected.txt: Added.
- canvas/2d.shadow.enable.off.1.html: Added.
- canvas/2d.shadow.enable.off.2-expected.txt: Added.
- canvas/2d.shadow.enable.off.2.html: Added.
- canvas/2d.shadow.enable.x-expected.txt: Added.
- canvas/2d.shadow.enable.x.html: Added.
- canvas/2d.shadow.enable.y-expected.txt: Added.
- canvas/2d.shadow.enable.y.html: Added.
- canvas/2d.shadow.gradient.alpha-expected.txt: Added.
- canvas/2d.shadow.gradient.alpha.html: Added.
- canvas/2d.shadow.gradient.basic-expected.txt: Added.
- canvas/2d.shadow.gradient.basic.html: Added.
- canvas/2d.shadow.gradient.transparent.1-expected.txt: Added.
- canvas/2d.shadow.gradient.transparent.1.html: Added.
- canvas/2d.shadow.gradient.transparent.2-expected.txt: Added.
- canvas/2d.shadow.gradient.transparent.2.html: Added.
- canvas/2d.shadow.image.alpha-expected.txt: Added.
- canvas/2d.shadow.image.alpha.html: Added.
- canvas/2d.shadow.image.basic-expected.txt: Added.
- canvas/2d.shadow.image.basic.html: Added.
- canvas/2d.shadow.image.scale-expected.txt: Added.
- canvas/2d.shadow.image.scale.html: Added.
- canvas/2d.shadow.image.section-expected.txt: Added.
- canvas/2d.shadow.image.section.html: Added.
- canvas/2d.shadow.image.transparent.1-expected.txt: Added.
- canvas/2d.shadow.image.transparent.1.html: Added.
- canvas/2d.shadow.image.transparent.2-expected.txt: Added.
- canvas/2d.shadow.image.transparent.2.html: Added.
- canvas/2d.shadow.offset.negativeX-expected.txt: Added.
- canvas/2d.shadow.offset.negativeX.html: Added.
- canvas/2d.shadow.offset.negativeY-expected.txt: Added.
- canvas/2d.shadow.offset.negativeY.html: Added.
- canvas/2d.shadow.offset.positiveX-expected.txt: Added.
- canvas/2d.shadow.offset.positiveX.html: Added.
- canvas/2d.shadow.offset.positiveY-expected.txt: Added.
- canvas/2d.shadow.offset.positiveY.html: Added.
- canvas/2d.shadow.outside-expected.txt: Added.
- canvas/2d.shadow.outside.html: Added.
- canvas/2d.shadow.pattern.alpha-expected.txt: Added.
- canvas/2d.shadow.pattern.alpha.html: Added.
- canvas/2d.shadow.pattern.basic-expected.txt: Added.
- canvas/2d.shadow.pattern.basic.html: Added.
- canvas/2d.shadow.pattern.transparent.1-expected.txt: Added.
- canvas/2d.shadow.pattern.transparent.1.html: Added.
- canvas/2d.shadow.pattern.transparent.2-expected.txt: Added.
- canvas/2d.shadow.pattern.transparent.2.html: Added.
- canvas/2d.shadow.stroke.basic-expected.txt: Added.
- canvas/2d.shadow.stroke.basic.html: Added.
- canvas/2d.shadow.stroke.cap.1-expected.txt: Added.
- canvas/2d.shadow.stroke.cap.1.html: Added.
- canvas/2d.shadow.stroke.cap.2-expected.txt: Added.
- canvas/2d.shadow.stroke.cap.2.html: Added.
- canvas/2d.shadow.stroke.join.1-expected.txt: Added.
- canvas/2d.shadow.stroke.join.1.html: Added.
- canvas/2d.shadow.stroke.join.2-expected.txt: Added.
- canvas/2d.shadow.stroke.join.2.html: Added.
- canvas/2d.shadow.stroke.join.3-expected.txt: Added.
- canvas/2d.shadow.stroke.join.3.html: Added.
- canvas/2d.shadow.transform.1-expected.txt: Added.
- canvas/2d.shadow.transform.1.html: Added.
- canvas/2d.shadow.transform.2-expected.txt: Added.
- canvas/2d.shadow.transform.2.html: Added.
- canvas/2d.state.saverestore.bitmap-expected.txt: Added.
- canvas/2d.state.saverestore.bitmap.html: Added.
- canvas/2d.state.saverestore.clip-expected.txt: Added.
- canvas/2d.state.saverestore.clip.html: Added.
- canvas/2d.state.saverestore.fillStyle-expected.txt: Added.
- canvas/2d.state.saverestore.fillStyle.html: Added.
- canvas/2d.state.saverestore.font-expected.txt: Added.
- canvas/2d.state.saverestore.font.html: Added.
- canvas/2d.state.saverestore.globalAlpha-expected.txt: Added.
- canvas/2d.state.saverestore.globalAlpha.html: Added.
- canvas/2d.state.saverestore.globalCompositeOperation-expected.txt: Added.
- canvas/2d.state.saverestore.globalCompositeOperation.html: Added.
- canvas/2d.state.saverestore.lineCap-expected.txt: Added.
- canvas/2d.state.saverestore.lineCap.html: Added.
- canvas/2d.state.saverestore.lineJoin-expected.txt: Added.
- canvas/2d.state.saverestore.lineJoin.html: Added.
- canvas/2d.state.saverestore.lineWidth-expected.txt: Added.
- canvas/2d.state.saverestore.lineWidth.html: Added.
- canvas/2d.state.saverestore.miterLimit-expected.txt: Added.
- canvas/2d.state.saverestore.miterLimit.html: Added.
- canvas/2d.state.saverestore.path-expected.txt: Added.
- canvas/2d.state.saverestore.path.html: Added.
- canvas/2d.state.saverestore.shadowBlur-expected.txt: Added.
- canvas/2d.state.saverestore.shadowBlur.html: Added.
- canvas/2d.state.saverestore.shadowColor-expected.txt: Added.
- canvas/2d.state.saverestore.shadowColor.html: Added.
- canvas/2d.state.saverestore.shadowOffsetX-expected.txt: Added.
- canvas/2d.state.saverestore.shadowOffsetX.html: Added.
- canvas/2d.state.saverestore.shadowOffsetY-expected.txt: Added.
- canvas/2d.state.saverestore.shadowOffsetY.html: Added.
- canvas/2d.state.saverestore.stack-expected.txt: Added.
- canvas/2d.state.saverestore.stack.html: Added.
- canvas/2d.state.saverestore.stackdepth-expected.txt: Added.
- canvas/2d.state.saverestore.stackdepth.html: Added.
- canvas/2d.state.saverestore.strokeStyle-expected.txt: Added.
- canvas/2d.state.saverestore.strokeStyle.html: Added.
- canvas/2d.state.saverestore.textAlign-expected.txt: Added.
- canvas/2d.state.saverestore.textAlign.html: Added.
- canvas/2d.state.saverestore.textBaseline-expected.txt: Added.
- canvas/2d.state.saverestore.textBaseline.html: Added.
- canvas/2d.state.saverestore.transformation-expected.txt: Added.
- canvas/2d.state.saverestore.transformation.html: Added.
- canvas/2d.state.saverestore.underflow-expected.txt: Added.
- canvas/2d.state.saverestore.underflow.html: Added.
- canvas/2d.strokeRect.basic-expected.txt: Added.
- canvas/2d.strokeRect.basic.html: Added.
- canvas/2d.strokeRect.clip-expected.txt: Added.
- canvas/2d.strokeRect.clip.html: Added.
- canvas/2d.strokeRect.globalalpha-expected.txt: Added.
- canvas/2d.strokeRect.globalalpha.html: Added.
- canvas/2d.strokeRect.globalcomposite-expected.txt: Added.
- canvas/2d.strokeRect.globalcomposite.html: Added.
- canvas/2d.strokeRect.negative-expected.txt: Added.
- canvas/2d.strokeRect.negative.html: Added.
- canvas/2d.strokeRect.nonfinite-expected.txt: Added.
- canvas/2d.strokeRect.nonfinite.html: Added.
- canvas/2d.strokeRect.path-expected.txt: Added.
- canvas/2d.strokeRect.path.html: Added.
- canvas/2d.strokeRect.shadow-expected.txt: Added.
- canvas/2d.strokeRect.shadow.html: Added.
- canvas/2d.strokeRect.transform-expected.txt: Added.
- canvas/2d.strokeRect.transform.html: Added.
- canvas/2d.strokeRect.zero.1-expected.txt: Added.
- canvas/2d.strokeRect.zero.1.html: Added.
- canvas/2d.strokeRect.zero.2-expected.txt: Added.
- canvas/2d.strokeRect.zero.2.html: Added.
- canvas/2d.strokeRect.zero.3-expected.txt: Added.
- canvas/2d.strokeRect.zero.3.html: Added.
- canvas/2d.strokeRect.zero.5-expected.txt: Added.
- canvas/2d.strokeRect.zero.5.html: Added.
- canvas/2d.strokeStyle.default-expected.txt: Added.
- canvas/2d.strokeStyle.default.html: Added.
- canvas/2d.text.align.default-expected.txt: Added.
- canvas/2d.text.align.default.html: Added.
- canvas/2d.text.align.valid-expected.txt: Added.
- canvas/2d.text.align.valid.html: Added.
- canvas/2d.text.baseline.default-expected.txt: Added.
- canvas/2d.text.baseline.default.html: Added.
- canvas/2d.text.baseline.valid-expected.txt: Added.
- canvas/2d.text.baseline.valid.html: Added.
- canvas/2d.text.draw.align.center.html: Added.
- canvas/2d.text.draw.align.end.ltr.html: Added.
- canvas/2d.text.draw.align.end.rtl.html: Added.
- canvas/2d.text.draw.align.left.html: Added.
- canvas/2d.text.draw.align.right.html: Added.
- canvas/2d.text.draw.align.start.ltr.html: Added.
- canvas/2d.text.draw.align.start.rtl.html: Added.
- canvas/2d.text.draw.baseline.alphabetic.html: Added.
- canvas/2d.text.draw.fill.basic.html: Added.
- canvas/2d.text.draw.fill.maxWidth.bound.html: Added.
- canvas/2d.text.draw.fill.maxWidth.fontface.html: Added.
- canvas/2d.text.draw.fill.maxWidth.large.html: Added.
- canvas/2d.text.draw.fill.maxWidth.negative-expected.txt: Added.
- canvas/2d.text.draw.fill.maxWidth.negative.html: Added.
- canvas/2d.text.draw.fill.maxWidth.small.html: Added.
- canvas/2d.text.draw.fill.maxWidth.zero.html: Added.
- canvas/2d.text.draw.fill.rtl.html: Added.
- canvas/2d.text.draw.fill.unaffected-expected.txt: Added.
- canvas/2d.text.draw.fill.unaffected.html: Added.
- canvas/2d.text.draw.fontface.html: Added.
- canvas/2d.text.draw.fontface.notinpage.html: Added.
- canvas/2d.text.draw.fontface.repeat.html: Added.
- canvas/2d.text.draw.kern.consistent.html: Added.
- canvas/2d.text.draw.space.basic.html: Added.
- canvas/2d.text.draw.space.collapse.nonspace.html: Added.
- canvas/2d.text.draw.stroke.basic.html: Added.
- canvas/2d.text.draw.stroke.unaffected-expected.txt: Added.
- canvas/2d.text.draw.stroke.unaffected.html: Added.
- canvas/2d.text.font.default-expected.txt: Added.
- canvas/2d.text.font.default.html: Added.
- canvas/2d.text.font.parse.basic-expected.txt: Added.
- canvas/2d.text.font.parse.basic.html: Added.
- canvas/2d.text.font.parse.complex-expected.txt: Added.
- canvas/2d.text.font.parse.complex.html: Added.
- canvas/2d.text.font.parse.invalid-expected.txt: Added.
- canvas/2d.text.font.parse.invalid.html: Added.
- canvas/2d.text.font.parse.size.percentage-expected.txt: Added.
- canvas/2d.text.font.parse.size.percentage.default-expected.txt: Added.
- canvas/2d.text.font.parse.size.percentage.default.html: Added.
- canvas/2d.text.font.parse.size.percentage.html: Added.
- canvas/2d.text.font.parse.system-expected.txt: Added.
- canvas/2d.text.font.parse.system.html: Added.
- canvas/2d.text.measure.width.basic.html: Added.
- canvas/2d.text.measure.width.empty-expected.txt: Added.
- canvas/2d.text.measure.width.empty.html: Added.
- canvas/2d.transformation.order-expected.txt: Added.
- canvas/2d.transformation.order.html: Added.
- canvas/2d.transformation.rotate.direction-expected.txt: Added.
- canvas/2d.transformation.rotate.direction.html: Added.
- canvas/2d.transformation.rotate.nonfinite-expected.txt: Added.
- canvas/2d.transformation.rotate.nonfinite.html: Added.
- canvas/2d.transformation.rotate.radians-expected.txt: Added.
- canvas/2d.transformation.rotate.radians.html: Added.
- canvas/2d.transformation.rotate.wrap-expected.txt: Added.
- canvas/2d.transformation.rotate.wrap.html: Added.
- canvas/2d.transformation.rotate.wrapnegative-expected.txt: Added.
- canvas/2d.transformation.rotate.wrapnegative.html: Added.
- canvas/2d.transformation.rotate.zero-expected.txt: Added.
- canvas/2d.transformation.rotate.zero.html: Added.
- canvas/2d.transformation.scale.basic-expected.txt: Added.
- canvas/2d.transformation.scale.basic.html: Added.
- canvas/2d.transformation.scale.large-expected.txt: Added.
- canvas/2d.transformation.scale.large.html: Added.
- canvas/2d.transformation.scale.multiple-expected.txt: Added.
- canvas/2d.transformation.scale.multiple.html: Added.
- canvas/2d.transformation.scale.negative-expected.txt: Added.
- canvas/2d.transformation.scale.negative.html: Added.
- canvas/2d.transformation.scale.nonfinite-expected.txt: Added.
- canvas/2d.transformation.scale.nonfinite.html: Added.
- canvas/2d.transformation.scale.zero-expected.txt: Added.
- canvas/2d.transformation.scale.zero.html: Added.
- canvas/2d.transformation.setTransform.multiple-expected.txt: Added.
- canvas/2d.transformation.setTransform.multiple.html: Added.
- canvas/2d.transformation.setTransform.nonfinite-expected.txt: Added.
- canvas/2d.transformation.setTransform.nonfinite.html: Added.
- canvas/2d.transformation.setTransform.skewed-expected.txt: Added.
- canvas/2d.transformation.setTransform.skewed.html: Added.
- canvas/2d.transformation.transform.identity-expected.txt: Added.
- canvas/2d.transformation.transform.identity.html: Added.
- canvas/2d.transformation.transform.multiply-expected.txt: Added.
- canvas/2d.transformation.transform.multiply.html: Added.
- canvas/2d.transformation.transform.nonfinite-expected.txt: Added.
- canvas/2d.transformation.transform.nonfinite.html: Added.
- canvas/2d.transformation.transform.skewed-expected.txt: Added.
- canvas/2d.transformation.transform.skewed.html: Added.
- canvas/2d.transformation.translate.basic-expected.txt: Added.
- canvas/2d.transformation.translate.basic.html: Added.
- canvas/2d.transformation.translate.nonfinite-expected.txt: Added.
- canvas/2d.transformation.translate.nonfinite.html: Added.
- canvas/2d.type.delete-expected.txt: Added.
- canvas/2d.type.delete.html: Added.
- canvas/2d.voidreturn-expected.txt: Added.
- canvas/2d.voidreturn.html: Added.
- canvas/canvas_colorsandstyles_addcolorstop_001-expected.txt: Added.
- canvas/canvas_colorsandstyles_addcolorstop_001.htm: Added.
- canvas/canvas_colorsandstyles_createlineargradient_001.htm: Added.
- canvas/canvas_complexshapes_arcto_001.htm: Added.
- canvas/canvas_complexshapes_beziercurveto_001.htm: Added.
- canvas/canvas_complexshapes_ispointInpath_001-expected.txt: Added.
- canvas/canvas_complexshapes_ispointInpath_001.htm: Added.
- canvas/canvas_compositing_globalcompositeoperation_001.htm: Added.
- canvas/canvas_linestyles_linecap_001.htm: Added.
- canvas/canvas_shadows_001.htm: Added.
- canvas/canvas_state_restore_001.htm: Added.
- canvas/canvas_text_font_001.htm: Added.
- canvas/canvas_transformations_scale_001.htm: Added.
- canvas/context.casesensitive-expected.txt: Added.
- canvas/context.casesensitive.html: Added.
- canvas/context.emptystring-expected.txt: Added.
- canvas/context.emptystring.html: Added.
- canvas/context.unrecognised.badname-expected.txt: Added.
- canvas/context.unrecognised.badname.html: Added.
- canvas/context.unrecognised.badsuffix-expected.txt: Added.
- canvas/context.unrecognised.badsuffix.html: Added.
- canvas/context.unrecognised.nullsuffix-expected.txt: Added.
- canvas/context.unrecognised.nullsuffix.html: Added.
- canvas/context.unrecognised.unicode-expected.txt: Added.
- canvas/context.unrecognised.unicode.html: Added.
- canvas/fallback.basic-expected.txt: Added.
- canvas/fallback.basic.html: Added.
- canvas/fallback.multiple-expected.txt: Added.
- canvas/fallback.multiple.html: Added.
- canvas/fallback.nested-expected.txt: Added.
- canvas/fallback.nested.html: Added.
- canvas/initial.colour-expected.txt: Added.
- canvas/initial.colour.html: Added.
- canvas/initial.reset.2dstate-expected.txt: Added.
- canvas/initial.reset.2dstate.html: Added.
- canvas/initial.reset.clip-expected.txt: Added.
- canvas/initial.reset.clip.html: Added.
- canvas/initial.reset.different-expected.txt: Added.
- canvas/initial.reset.different.html: Added.
- canvas/initial.reset.gradient-expected.txt: Added.
- canvas/initial.reset.gradient.html: Added.
- canvas/initial.reset.path-expected.txt: Added.
- canvas/initial.reset.path.html: Added.
- canvas/initial.reset.pattern-expected.txt: Added.
- canvas/initial.reset.pattern.html: Added.
- canvas/initial.reset.same-expected.txt: Added.
- canvas/initial.reset.same.html: Added.
- canvas/initial.reset.transform-expected.txt: Added.
- canvas/initial.reset.transform.html: Added.
- canvas/resources: Added.
- canvas/resources/2d.composite.canvas.copy.png: Added.
- canvas/resources/2d.composite.canvas.destination-atop.png: Added.
- canvas/resources/2d.composite.canvas.destination-in.png: Added.
- canvas/resources/2d.composite.canvas.destination-out.png: Added.
- canvas/resources/2d.composite.canvas.destination-over.png: Added.
- canvas/resources/2d.composite.canvas.lighter.png: Added.
- canvas/resources/2d.composite.canvas.source-atop.png: Added.
- canvas/resources/2d.composite.canvas.source-in.png: Added.
- canvas/resources/2d.composite.canvas.source-out.png: Added.
- canvas/resources/2d.composite.canvas.source-over.png: Added.
- canvas/resources/2d.composite.canvas.xor.png: Added.
- canvas/resources/2d.composite.image.copy.png: Added.
- canvas/resources/2d.composite.image.destination-atop.png: Added.
- canvas/resources/2d.composite.image.destination-in.png: Added.
- canvas/resources/2d.composite.image.destination-out.png: Added.
- canvas/resources/2d.composite.image.destination-over.png: Added.
- canvas/resources/2d.composite.image.lighter.png: Added.
- canvas/resources/2d.composite.image.source-atop.png: Added.
- canvas/resources/2d.composite.image.source-in.png: Added.
- canvas/resources/2d.composite.image.source-out.png: Added.
- canvas/resources/2d.composite.image.source-over.png: Added.
- canvas/resources/2d.composite.image.xor.png: Added.
- canvas/resources/2d.composite.solid.copy.png: Added.
- canvas/resources/2d.composite.solid.destination-atop.png: Added.
- canvas/resources/2d.composite.solid.destination-in.png: Added.
- canvas/resources/2d.composite.solid.destination-out.png: Added.
- canvas/resources/2d.composite.solid.destination-over.png: Added.
- canvas/resources/2d.composite.solid.lighter.png: Added.
- canvas/resources/2d.composite.solid.source-atop.png: Added.
- canvas/resources/2d.composite.solid.source-in.png: Added.
- canvas/resources/2d.composite.solid.source-out.png: Added.
- canvas/resources/2d.composite.solid.source-over.png: Added.
- canvas/resources/2d.composite.solid.xor.png: Added.
- canvas/resources/2d.composite.transparent.copy.png: Added.
- canvas/resources/2d.composite.transparent.destination-atop.png: Added.
- canvas/resources/2d.composite.transparent.destination-in.png: Added.
- canvas/resources/2d.composite.transparent.destination-out.png: Added.
- canvas/resources/2d.composite.transparent.destination-over.png: Added.
- canvas/resources/2d.composite.transparent.lighter.png: Added.
- canvas/resources/2d.composite.transparent.source-atop.png: Added.
- canvas/resources/2d.composite.transparent.source-in.png: Added.
- canvas/resources/2d.composite.transparent.source-out.png: Added.
- canvas/resources/2d.composite.transparent.source-over.png: Added.
- canvas/resources/2d.composite.transparent.xor.png: Added.
- canvas/resources/2d.composite.uncovered.fill.copy.png: Added.
- canvas/resources/2d.composite.uncovered.fill.destination-atop.png: Added.
- canvas/resources/2d.composite.uncovered.fill.destination-in.png: Added.
- canvas/resources/2d.composite.uncovered.fill.source-in.png: Added.
- canvas/resources/2d.composite.uncovered.fill.source-out.png: Added.
- canvas/resources/2d.composite.uncovered.image.copy.png: Added.
- canvas/resources/2d.composite.uncovered.image.destination-atop.png: Added.
- canvas/resources/2d.composite.uncovered.image.destination-in.png: Added.
- canvas/resources/2d.composite.uncovered.image.source-in.png: Added.
- canvas/resources/2d.composite.uncovered.image.source-out.png: Added.
- canvas/resources/2d.composite.uncovered.nocontext.copy.png: Added.
- canvas/resources/2d.composite.uncovered.nocontext.destination-atop.png: Added.
- canvas/resources/2d.composite.uncovered.nocontext.destination-in.png: Added.
- canvas/resources/2d.composite.uncovered.nocontext.source-in.png: Added.
- canvas/resources/2d.composite.uncovered.nocontext.source-out.png: Added.
- canvas/resources/2d.composite.uncovered.pattern.copy.png: Added.
- canvas/resources/2d.composite.uncovered.pattern.destination-atop.png: Added.
- canvas/resources/2d.composite.uncovered.pattern.destination-in.png: Added.
- canvas/resources/2d.composite.uncovered.pattern.source-in.png: Added.
- canvas/resources/2d.composite.uncovered.pattern.source-out.png: Added.
- canvas/resources/2d.coordinatespace.png: Added.
- canvas/resources/2d.fillStyle.parse.current.removed.png: Added.
- canvas/resources/2d.fillStyle.parse.hex3.png: Added.
- canvas/resources/2d.fillStyle.parse.hex6.png: Added.
- canvas/resources/2d.fillStyle.parse.hsl-1.png: Added.
- canvas/resources/2d.fillStyle.parse.hsl-2.png: Added.
- canvas/resources/2d.fillStyle.parse.hsl-3.png: Added.
- canvas/resources/2d.fillStyle.parse.hsl-4.png: Added.
- canvas/resources/2d.fillStyle.parse.hsl-5.png: Added.
- canvas/resources/2d.fillStyle.parse.hsl-6.png: Added.
- canvas/resources/2d.fillStyle.parse.hsl-clamp-1.png: Added.
- canvas/resources/2d.fillStyle.parse.hsl-clamp-2.png: Added.
- canvas/resources/2d.fillStyle.parse.hsl-clamp-3.png: Added.
- canvas/resources/2d.fillStyle.parse.hsl-clamp-4.png: Added.
- canvas/resources/2d.fillStyle.parse.hsla-1.png: Added.
- canvas/resources/2d.fillStyle.parse.hsla-2.png: Added.
- canvas/resources/2d.fillStyle.parse.hsla-clamp-1.png: Added.
- canvas/resources/2d.fillStyle.parse.hsla-clamp-2.png: Added.
- canvas/resources/2d.fillStyle.parse.hsla-clamp-3.png: Added.
- canvas/resources/2d.fillStyle.parse.hsla-clamp-4.png: Added.
- canvas/resources/2d.fillStyle.parse.hsla-clamp-5.png: Added.
- canvas/resources/2d.fillStyle.parse.hsla-clamp-6.png: Added.
- canvas/resources/2d.fillStyle.parse.html4.png: Added.
- canvas/resources/2d.fillStyle.parse.rgb-clamp-1.png: Added.
- canvas/resources/2d.fillStyle.parse.rgb-clamp-2.png: Added.
- canvas/resources/2d.fillStyle.parse.rgb-clamp-3.png: Added.
- canvas/resources/2d.fillStyle.parse.rgb-clamp-4.png: Added.
- canvas/resources/2d.fillStyle.parse.rgb-clamp-5.png: Added.
- canvas/resources/2d.fillStyle.parse.rgb-eof.png: Added.
- canvas/resources/2d.fillStyle.parse.rgb-num.png: Added.
- canvas/resources/2d.fillStyle.parse.rgb-percent.png: Added.
- canvas/resources/2d.fillStyle.parse.rgba-clamp-1.png: Added.
- canvas/resources/2d.fillStyle.parse.rgba-clamp-2.png: Added.
- canvas/resources/2d.fillStyle.parse.rgba-eof.png: Added.
- canvas/resources/2d.fillStyle.parse.rgba-num-1.png: Added.
- canvas/resources/2d.fillStyle.parse.rgba-num-2.png: Added.
- canvas/resources/2d.fillStyle.parse.rgba-percent.png: Added.
- canvas/resources/2d.fillStyle.parse.rgba-solid-1.png: Added.
- canvas/resources/2d.fillStyle.parse.rgba-solid-2.png: Added.
- canvas/resources/2d.fillStyle.parse.rgba-solid-3.png: Added.
- canvas/resources/2d.fillStyle.parse.rgba-solid-4.png: Added.
- canvas/resources/2d.fillStyle.parse.svg-1.png: Added.
- canvas/resources/2d.fillStyle.parse.svg-2.png: Added.
- canvas/resources/2d.fillStyle.parse.transparent-1.png: Added.
- canvas/resources/2d.fillStyle.parse.transparent-2.png: Added.
- canvas/resources/2d.gradient.interpolate.alpha.png: Added.
- canvas/resources/2d.gradient.interpolate.colour.png: Added.
- canvas/resources/2d.gradient.interpolate.colouralpha.png: Added.
- canvas/resources/2d.gradient.interpolate.multiple.png: Added.
- canvas/resources/2d.gradient.interpolate.overlap.png: Added.
- canvas/resources/2d.gradient.interpolate.vertical.png: Added.
- canvas/resources/2d.gradient.object.current.png: Added.
- canvas/resources/2d.imageData.put.alpha.png: Added.
- canvas/resources/2d.path.fill.overlap.png: Added.
- canvas/resources/2d.path.stroke.overlap.png: Added.
- canvas/resources/2d.scaled.png: Added.
- canvas/resources/2d.shadow.alpha.2.png: Added.
- canvas/resources/2d.shadow.alpha.3.png: Added.
- canvas/resources/2d.shadow.alpha.4.png: Added.
- canvas/resources/2d.shadow.alpha.5.png: Added.
- canvas/resources/2d.shadow.blur.high.png: Added.
- canvas/resources/2d.shadow.blur.low.png: Added.
- canvas/resources/2d.shadow.canvas.alpha.png: Added.
- canvas/resources/2d.shadow.gradient.alpha.png: Added.
- canvas/resources/2d.shadow.image.alpha.png: Added.
- canvas/resources/2d.shadow.pattern.alpha.png: Added.
- canvas/resources/2d.text.draw.fill.basic.png: Added.
- canvas/resources/2d.text.draw.fill.maxWidth.large.png: Added.
- canvas/resources/2d.text.draw.fill.rtl.png: Added.
- canvas/resources/2d.text.draw.stroke.basic.png: Added.
- canvas/resources/anim-gr.gif: Added.
- canvas/resources/anim-gr.png: Added.
- canvas/resources/anim-poster-gr.png: Added.
- canvas/resources/broken.png: Added.
- canvas/resources/clear-100x50.png: Added.
- canvas/resources/ggrr-256x256.png: Added.
- canvas/resources/green-100x50.png: Added.
- canvas/resources/green-1x1.png: Added.
- canvas/resources/green.png: Added.
- canvas/resources/initial.colour.png: Added.
- canvas/resources/initial.reset.different.png: Added.
- canvas/resources/initial.reset.path.png: Added.
- canvas/resources/initial.reset.same.png: Added.
- canvas/resources/red-16x16.png: Added.
- canvas/resources/red.png: Added.
- canvas/resources/redtransparent.png: Added.
- canvas/resources/rgrg-256x256.png: Added.
- canvas/resources/rrgg-256x256.png: Added.
- canvas/resources/size.attributes.default.png: Added.
- canvas/resources/size.attributes.get.png: Added.
- canvas/resources/size.attributes.parse.decimal.png: Added.
- canvas/resources/size.attributes.parse.em.png: Added.
- canvas/resources/size.attributes.parse.empty.png: Added.
- canvas/resources/size.attributes.parse.exp.png: Added.
- canvas/resources/size.attributes.parse.junk.png: Added.
- canvas/resources/size.attributes.parse.minus.png: Added.
- canvas/resources/size.attributes.parse.octal.png: Added.
- canvas/resources/size.attributes.parse.onlyspace.png: Added.
- canvas/resources/size.attributes.parse.percent.png: Added.
- canvas/resources/size.attributes.parse.plus.png: Added.
- canvas/resources/size.attributes.parse.space.png: Added.
- canvas/resources/size.attributes.parse.trailingjunk.png: Added.
- canvas/resources/size.attributes.parse.whitespace.png: Added.
- canvas/resources/size.attributes.reflect.setcontent.png: Added.
- canvas/resources/size.attributes.reflect.setidl.png: Added.
- canvas/resources/size.attributes.removed.png: Added.
- canvas/resources/size.attributes.set.png: Added.
- canvas/resources/size.attributes.setAttribute.decimal.png: Added.
- canvas/resources/size.attributes.setAttribute.em.png: Added.
- canvas/resources/size.attributes.setAttribute.empty.png: Added.
- canvas/resources/size.attributes.setAttribute.exp.png: Added.
- canvas/resources/size.attributes.setAttribute.junk.png: Added.
- canvas/resources/size.attributes.setAttribute.minus.png: Added.
- canvas/resources/size.attributes.setAttribute.octal.png: Added.
- canvas/resources/size.attributes.setAttribute.onlyspace.png: Added.
- canvas/resources/size.attributes.setAttribute.percent.png: Added.
- canvas/resources/size.attributes.setAttribute.plus.png: Added.
- canvas/resources/size.attributes.setAttribute.space.png: Added.
- canvas/resources/size.attributes.setAttribute.trailingjunk.png: Added.
- canvas/resources/size.attributes.setAttribute.whitespace.png: Added.
- canvas/resources/size.attributes.style.png: Added.
- canvas/resources/toDataURL.jpeg.alpha.png: Added.
- canvas/resources/toDataURL.jpeg.primarycolours.png: Added.
- canvas/resources/toDataURL.jpeg.quality.basic.png: Added.
- canvas/resources/toDataURL.png.complexcolours.png: Added.
- canvas/resources/toDataURL.png.primarycolours.png: Added.
- canvas/resources/transparent.png: Added.
- canvas/resources/transparent50.png: Added.
- canvas/resources/yellow.png: Added.
- canvas/resources/yellow75.png: Added.
- canvas/security.dataURI.html: Added.
- canvas/security.drawImage.canvas-expected.txt: Added.
- canvas/security.drawImage.canvas.html: Added.
- canvas/security.drawImage.image-expected.txt: Added.
- canvas/security.drawImage.image.html: Added.
- canvas/security.pattern.canvas.fillStyle-expected.txt: Added.
- canvas/security.pattern.canvas.fillStyle.html: Added.
- canvas/security.pattern.canvas.strokeStyle-expected.txt: Added.
- canvas/security.pattern.canvas.strokeStyle.html: Added.
- canvas/security.pattern.canvas.timing-expected.txt: Added.
- canvas/security.pattern.canvas.timing.html: Added.
- canvas/security.pattern.create-expected.txt: Added.
- canvas/security.pattern.create.html: Added.
- canvas/security.pattern.cross-expected.txt: Added.
- canvas/security.pattern.cross.html: Added.
- canvas/security.pattern.image.fillStyle-expected.txt: Added.
- canvas/security.pattern.image.fillStyle.html: Added.
- canvas/security.pattern.image.strokeStyle-expected.txt: Added.
- canvas/security.pattern.image.strokeStyle.html: Added.
- canvas/security.reset-expected.txt: Added.
- canvas/security.reset.html: Added.
- canvas/size.attributes.default-expected.txt: Added.
- canvas/size.attributes.default.html: Added.
- canvas/size.attributes.get-expected.txt: Added.
- canvas/size.attributes.get.html: Added.
- canvas/size.attributes.idl-expected.txt: Added.
- canvas/size.attributes.idl.html: Added.
- canvas/size.attributes.idl.set.zero-expected.txt: Added.
- canvas/size.attributes.idl.set.zero.html: Added.
- canvas/size.attributes.parse.decimal-expected.txt: Added.
- canvas/size.attributes.parse.decimal.html: Added.
- canvas/size.attributes.parse.em-expected.txt: Added.
- canvas/size.attributes.parse.em.html: Added.
- canvas/size.attributes.parse.empty-expected.txt: Added.
- canvas/size.attributes.parse.empty.html: Added.
- canvas/size.attributes.parse.exp-expected.txt: Added.
- canvas/size.attributes.parse.exp.html: Added.
- canvas/size.attributes.parse.hex-expected.txt: Added.
- canvas/size.attributes.parse.hex.html: Added.
- canvas/size.attributes.parse.junk-expected.txt: Added.
- canvas/size.attributes.parse.junk.html: Added.
- canvas/size.attributes.parse.minus-expected.txt: Added.
- canvas/size.attributes.parse.minus.html: Added.
- canvas/size.attributes.parse.octal-expected.txt: Added.
- canvas/size.attributes.parse.octal.html: Added.
- canvas/size.attributes.parse.onlyspace-expected.txt: Added.
- canvas/size.attributes.parse.onlyspace.html: Added.
- canvas/size.attributes.parse.percent-expected.txt: Added.
- canvas/size.attributes.parse.percent.html: Added.
- canvas/size.attributes.parse.plus-expected.txt: Added.
- canvas/size.attributes.parse.plus.html: Added.
- canvas/size.attributes.parse.space-expected.txt: Added.
- canvas/size.attributes.parse.space.html: Added.
- canvas/size.attributes.parse.trailingjunk-expected.txt: Added.
- canvas/size.attributes.parse.trailingjunk.html: Added.
- canvas/size.attributes.parse.whitespace-expected.txt: Added.
- canvas/size.attributes.parse.whitespace.html: Added.
- canvas/size.attributes.parse.zero-expected.txt: Added.
- canvas/size.attributes.parse.zero.html: Added.
- canvas/size.attributes.reflect.setcontent-expected.txt: Added.
- canvas/size.attributes.reflect.setcontent.html: Added.
- canvas/size.attributes.reflect.setidl-expected.txt: Added.
- canvas/size.attributes.reflect.setidl.html: Added.
- canvas/size.attributes.reflect.setidlzero-expected.txt: Added.
- canvas/size.attributes.reflect.setidlzero.html: Added.
- canvas/size.attributes.removed-expected.txt: Added.
- canvas/size.attributes.removed.html: Added.
- canvas/size.attributes.set-expected.txt: Added.
- canvas/size.attributes.set.html: Added.
- canvas/size.attributes.setAttribute.decimal-expected.txt: Added.
- canvas/size.attributes.setAttribute.decimal.html: Added.
- canvas/size.attributes.setAttribute.em-expected.txt: Added.
- canvas/size.attributes.setAttribute.em.html: Added.
- canvas/size.attributes.setAttribute.empty-expected.txt: Added.
- canvas/size.attributes.setAttribute.empty.html: Added.
- canvas/size.attributes.setAttribute.exp-expected.txt: Added.
- canvas/size.attributes.setAttribute.exp.html: Added.
- canvas/size.attributes.setAttribute.hex-expected.txt: Added.
- canvas/size.attributes.setAttribute.hex.html: Added.
- canvas/size.attributes.setAttribute.junk-expected.txt: Added.
- canvas/size.attributes.setAttribute.junk.html: Added.
- canvas/size.attributes.setAttribute.minus-expected.txt: Added.
- canvas/size.attributes.setAttribute.minus.html: Added.
- canvas/size.attributes.setAttribute.octal-expected.txt: Added.
- canvas/size.attributes.setAttribute.octal.html: Added.
- canvas/size.attributes.setAttribute.onlyspace-expected.txt: Added.
- canvas/size.attributes.setAttribute.onlyspace.html: Added.
- canvas/size.attributes.setAttribute.percent-expected.txt: Added.
- canvas/size.attributes.setAttribute.percent.html: Added.
- canvas/size.attributes.setAttribute.plus-expected.txt: Added.
- canvas/size.attributes.setAttribute.plus.html: Added.
- canvas/size.attributes.setAttribute.space-expected.txt: Added.
- canvas/size.attributes.setAttribute.space.html: Added.
- canvas/size.attributes.setAttribute.trailingjunk-expected.txt: Added.
- canvas/size.attributes.setAttribute.trailingjunk.html: Added.
- canvas/size.attributes.setAttribute.whitespace-expected.txt: Added.
- canvas/size.attributes.setAttribute.whitespace.html: Added.
- canvas/size.attributes.setAttribute.zero-expected.txt: Added.
- canvas/size.attributes.setAttribute.zero.html: Added.
- canvas/size.attributes.style-expected.txt: Added.
- canvas/size.attributes.style.html: Added.
- canvas/toDataURL.arguments.1-expected.txt: Added.
- canvas/toDataURL.arguments.1.html: Added.
- canvas/toDataURL.arguments.2-expected.txt: Added.
- canvas/toDataURL.arguments.2.html: Added.
- canvas/toDataURL.arguments.3-expected.txt: Added.
- canvas/toDataURL.arguments.3.html: Added.
- canvas/toDataURL.bogustype-expected.txt: Added.
- canvas/toDataURL.bogustype.html: Added.
- canvas/toDataURL.default-expected.txt: Added.
- canvas/toDataURL.default.html: Added.
- canvas/toDataURL.jpeg.alpha.html: Added.
- canvas/toDataURL.jpeg.primarycolours.html: Added.
- canvas/toDataURL.jpeg.quality.basic.html: Added.
- canvas/toDataURL.jpeg.quality.notnumber-expected.txt: Added.
- canvas/toDataURL.jpeg.quality.notnumber.html: Added.
- canvas/toDataURL.jpeg.quality.outsiderange-expected.txt: Added.
- canvas/toDataURL.jpeg.quality.outsiderange.html: Added.
- canvas/toDataURL.lowercase.ascii-expected.txt: Added.
- canvas/toDataURL.lowercase.ascii.html: Added.
- canvas/toDataURL.lowercase.unicode-expected.txt: Added.
- canvas/toDataURL.lowercase.unicode.html: Added.
- canvas/toDataURL.nocontext-expected.txt: Added.
- canvas/toDataURL.nocontext.html: Added.
- canvas/toDataURL.png-expected.txt: Added.
- canvas/toDataURL.png.complexcolours.html: Added.
- canvas/toDataURL.png.html: Added.
- canvas/toDataURL.png.primarycolours.html: Added.
- canvas/toDataURL.unrecognised-expected.txt: Added.
- canvas/toDataURL.unrecognised.html: Added.
- canvas/toDataURL.zerosize-expected.txt: Added.
- canvas/toDataURL.zerosize.html: Added.
- canvas/type.delete-expected.txt: Added.
- canvas/type.delete.html: Added.
- canvas/type.exists-expected.txt: Added.
- canvas/type.exists.html: Added.
- canvas/type.extend-expected.txt: Added.
- canvas/type.extend.html: Added.
- canvas/type.name-expected.txt: Added.
- canvas/type.name.html: Added.
- canvas/type.prototype-expected.txt: Added.
- canvas/type.prototype.html: Added.
- canvas/type.replace-expected.txt: Added.
- canvas/type.replace.html: Added.
- common: Added.
- common/canvas-frame.css: Added.
- common/canvas-index.css: Added.
- common/canvas-spec.css: Added.
- common/canvas-tests.css: Added.
- common/canvas-tests.js: Added.
- common/domtestcase.js: Added.
- common/media.js: Added.
- common/text-plain.txt: Added.
- 3:38 PM Changeset in webkit [176143] by
-
- 2 edits in trunk/Source/WebKit/mac
Update some artwork for the legacy WebKit action menu
https://bugs.webkit.org/show_bug.cgi?id=138758
<rdar://problem/18989840>
Reviewed by Simon Fraser.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _createActionMenuItemForTag:]):
- 3:31 PM Changeset in webkit [176142] by
-
- 5 edits2 adds in trunk/Source
[iOS] NSFileManager and QuickLook SPI not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138742
Reviewed by Pratik Solanki.
Source/WebCore:
Add a SPI wrapper headers {NSFileManager, QuickLook}SPI.h that forward declares
NSFileManager and QuickLook SPI, respectively, and use these header instead of
including private headers of Foundation and QuickLook directly.
- WebCore.xcodeproj/project.pbxproj: Add project and private header QuickLookSPI.h
and NSFileManagerSPI.h, respectively.
- platform/network/ios/QuickLook.mm: Include headers QuickLookSPI.h and NSFileManagerSPI.h
instead of including headers of QuickLook and Foundation directly.
- platform/spi/cocoa/NSFileManagerSPI.h: Added.
- platform/spi/ios/QuickLookSPI.h: Added.
Source/WebKit/mac:
Include header NSFileManagerSPI.h instead of the private header NSFileManager_NSURLExtras.h.
- WebCoreSupport/WebFrameLoaderClient.mm:
- 3:06 PM Changeset in webkit [176141] by
-
- 2 edits in trunk/LayoutTests
Application test expectation gardening on WK2.
- platform/mac-wk2/TestExpectations: Skip two tests that toggle private browsing,
and added a bug number to http/tests/appcache/auth.html.
- 2:27 PM Changeset in webkit [176140] by
-
- 26 edits in trunk/Source
[iOS] CoreGraphics SPI not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138709
Reviewed by David Kilzer.
Source/WebCore:
Add a SPI wrapper header called CoreGraphicsSPI.h that forward declares
CoreGraphics SPI and use this header instead of including private headers
of CoreGraphics directly.
- WebCore.xcodeproj/project.pbxproj: Add WebCore private header CoreGraphicsSPI.h. Also remove header
CGFontUnicodeSupportSPI.h as its functionality has been incorporated into header CoreGraphicsSPI.h.
- WebCore.vcxproj/WebCore.vcxproj: Add WebCore private header CoreGraphicsSPI.h.
- WebCore.vcxproj/WebCore.vcxproj.filters: Add directories platform/spi and platform/spi/cg.
- WebCore.vcxproj/WebCoreCG.props: Add include directory platform/spi/cg.
- WebCore.vcxproj/copyForwardingHeaders.cmd: Copy WebCore headers from directory platform/spi/cg. This
is necessary because WebCore/platform/graphics/SimpleFontData.h includes CoreGraphicsSPI.h. And
WebCore/platform/graphics/SimpleFontData.h is compiled for the Apple Windows port.
- platform/graphics/SimpleFontData.h: Move CGFontRenderingStyle declaration and associated enum
from this file to file CoreGraphicsSPI.h and include header CoreGraphicsSPI.h.
- platform/graphics/cg/BitmapImageCG.cpp: Remove unnecessary #include of header CGContextPrivate.h.
- platform/graphics/cg/ColorCG.cpp: Include header CoreGraphicsSPI.h instead of including headers
of CoreGraphics directly.
- platform/graphics/cg/GraphicsContextCG.cpp: Move forward declarations of CoreGraphics functions
from this file to file CoreGraphicsSPI.h and include header CoreGraphicsSPI.h. Also sort the list
of #include directives.
- platform/graphics/cg/ImageSourceCG.cpp: Include header CoreGraphicsSPI.h instead of including
headers of CoreGraphics directly.
- platform/graphics/cg/PDFDocumentImage.cpp: Ditto.
- platform/graphics/cocoa/FontPlatformDataCocoa.mm: Ditto.
- platform/graphics/ios/FontCacheIOS.mm: Include header CoreGraphicsSPI.h instead of including
header <CoreGraphics/CGFontUnicodeSupport.h> directly.
- platform/graphics/ios/FontServicesIOS.mm: Include header CoreGraphicsSPI.h instead of including
headers of CoreGraphics directly.
- platform/graphics/ios/SimpleFontDataIOS.mm: Ditto.
- platform/graphics/mac/FontMac.mm: Move forward declarations of CoreGraphics functions from this
file to file CoreGraphicsSPI.h and include header CoreGraphicsSPI.h.
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp: Substitute header CoreGraphicsSPI.h for CGFontUnicodeSupportSPI.h
and remove #include of headers CGFontUnicodeSupport.h (it will be included by CoreGraphicsSPI.h).
- platform/graphics/mac/SimpleFontDataMac.mm: Move forward declarations of CoreGraphics functions
from this file to file CoreGraphicsSPI.h and include header CoreGraphicsSPI.h.
- platform/ios/LegacyTileGrid.mm: Include header CoreGraphicsSPI.h instead of including headers of
CoreGraphics directly.
- platform/ios/wak/WKGraphics.h: Remove #include of header CoreGraphicsPrivate.h and forward declare
CGFontAntialiasingStyle Additionally, declare WKCompositeOperation as an alias of int and use this
data type instead of CGCompositeOperation (SPI). This approach lets us keep the definition of
CGCompositeOperation in file CoreGraphicsSPI.h, where all the other definitions/forward declarations
of CoreGraphics data types reside, as opposed to defining it in this file.
- platform/ios/wak/WKGraphics.mm:
(WKRectFillUsingOperation): Cast data type WKCompositeOperation to CGCompositeOperation and added
compile-time assert to ensure that the size of WKCompositeOperation is identical to the size of CGCompositeOperation.
- platform/graphics/cg/ImageSourceCG.cpp: Move CGImageCachingFlags declaration, associated enum, and
forward declaration of CGImageSetCachingFlags() from this file to file CoreGraphicsSPI.h and include
header CoreGraphicsSPI.h.
(WebCore::ImageSource::createFrameAtIndex): Fix incorrect comment.
- platform/spi/cocoa/CGFontUnicodeSupportSPI.h: Removed; moved its functionality into header CoreGraphicsSPI.h.
- platform/spi/cg/CoreGraphicsSPI.h: Added.
(CGFloatMin):
- rendering/RenderThemeIOS.mm: Substitute header CoreGraphics.h for CGPathPrivate.h as we no longer
make use of any functionality from CGPathPrivate.h in this file. The functionality we used from
CGPathPrivate.h, including CGPathAddRoundedRect(), has been moved to the public API header, CGPath.h,
which is included from header CoreGraphics.h.
Source/WebKit/ios:
Include header CoreGraphicsSPI.h instead of the private header CGFloat.h.
- WebCoreSupport/WebFixedPositionContent.mm:
Source/WebKit2:
Include header CoreGraphicsSPI.h instead of including headers of
CoreGraphics directly.
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/ios/WKScrollView.mm:
- 1:55 PM Changeset in webkit [176139] by
-
- 3 edits2 adds in trunk
[Media] Timeline scrubber not updating as the video plays
https://bugs.webkit.org/show_bug.cgi?id=138717
<rdar://problem/18957509>
Reviewed by Jer Noble.
Source/WebCore:
There is some confusing logic that determines
whether or not the controls are hidden, and a
slight error caused timelines to not advance unless
they were explicitly showing.
The fix was to be a bit more liberal in deciding
when the controls are showing, but still cautious
enough to stop up causing repaints when things
are hidden.
Test: media/media-controls-timeline-updates.html
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.controlsAreHidden): We only need
to check if we're an audio element or explicitly
hidden.
(Controller.prototype.showControls): Explicitly call
updateTime.
LayoutTests:
Tests that an inline video will actually advance the
timeline scrubber if it plays momentarily.
Eric wrote all the hard bits here. I just changed
a few lines to test if the timeline had moved from 0.
Unfortunately we can't rely on the timeline value
being identical to the currentTime of the media element,
because we only move the timeline when we get events.
- media/media-controls-timeline-updates.html: Added.
- 1:37 PM Changeset in webkit [176138] by
-
- 4 edits in tags/Safari-601.1.9.1/Source/JavaScriptCore
Merged r176087.
- 1:33 PM Changeset in webkit [176137] by
-
- 9 edits4 adds2 deletes in trunk/Source
Move DataDetectors scanning code to WebCore
https://bugs.webkit.org/show_bug.cgi?id=138731
<rdar://problem/18877535>
Reviewed by Anders Carlsson.
Move DataDetectors scanning code to WebCore, so that both WebKits can use it.
- Shared/TextIndicator.cpp:
(WebKit::TextIndicator::createWithRange):
Move createWithRange in from WebPageMac's textIndicatorForRange.
(WebKit::TextIndicator::createWithSelectionInFrame):
- Shared/TextIndicator.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createSelectionSnapshot):
- WebProcess/WebPage/WebFrame.h:
Constify some things.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performActionMenuHitTestAtLocation):
Avoid using the DD result if it didn't come with a non-null Range.
Make use of detectItemAroundHitTestResult and TextIndicator::createWithRange.
(WebKit::scanForDataDetectedItems): Deleted.
(WebKit::textIndicatorForRange): Deleted.
Moved these two to other places.
- WebCore.exp.in:
Export our new function.
- WebCore.xcodeproj/project.pbxproj:
Add DataDetection.{mm, h}
Adjust the project so that editing/mac actually points to editing/mac instead of editing/
- editing/mac/DictionaryLookup.h:
- editing/mac/DictionaryLookup.mm:
Swap to PLATFORM(MAC) instead of !PLATFORM(IOS).
Move DictionaryLookup.{mm, h} to editing/mac, where they were in the project but not on disk.
- editing/mac/DataDetection.h: Added.
- editing/mac/DataDetection.mm: Added.
(WebCore::DataDetection::detectItemAroundHitTestResult):
Moved from WebKit2.
- 1:28 PM Changeset in webkit [176136] by
-
- 12 edits in trunk/Source
<rdar://problem/18978497> Wrong (off-by-1) navigation snapshots shown after a mix of gesture and button back/forward navigation
https://bugs.webkit.org/show_bug.cgi?id=138753
Reviewed by Tim Horton.
Source/WebCore:
Removed a FrameLoaderClient function that no one overrides anymore.
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::willChangeCurrentHistoryItem): Deleted.
- loader/HistoryController.cpp:
(WebCore::HistoryController::setCurrentItem): Removed call to willChangeCurrentHistoryItem.
(WebCore::HistoryController::replaceCurrentItem): Ditto.
Source/WebKit2:
Rather than having the UI process record a snapshot jut before the Web Content process’s
notion of its current back/forward list item changes, have the UI process record a snapshot
right before its own current back/forward list item changes. This ensures that the right
snapshot gets attached to the right item in the UI process.
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem): If there is a current item, record a navigation
snapshot of it before making the new item current.
(WebKit::WebBackForwardList::goToItem): If there is a current item, record a navigation
snapshot of it before making another item current.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::willChangeCurrentHistoryItemForMainFrame): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Removed willChangeCurrentHistoryItemForMainFrame
message.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::willChangeCurrentHistoryItem): Deleted.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h: Removed declaration of
willChangeCurrentHistoryItem override.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::willChangeCurrentHistoryItemForMainFrame): Deleted.
- WebProcess/WebPage/WebPage.h:
- 12:44 PM Changeset in webkit [176135] by
-
- 2 edits in trunk/Source/WebCore
Do proper teardown for optimized fullscreen
https://bugs.webkit.org/show_bug.cgi?id=138648
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-11-14
Reviewed by Eric Carlson.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::invalidate): must do corresponding teardown based on mode.
- 12:24 PM Changeset in webkit [176134] by
-
- 14 edits in trunk/Source/JavaScriptCore
Reduce amount of cut-and-paste needed for probe mechanism implementations.
<https://webkit.org/b/138671>
Reviewed by Geoffrey Garen.
The existing code requires that each MacroAssembler implementation provide
their own copy of all of the probe implementations even when most of it is
identical. This patch hoists the common parts into AbstractMacroAssembler
(with some minor renaming). Each target specific MacroAssembler now only
need to implement a few target specific methods that are expected by and
documented in AbstractMacroAssembler.h in the ENABLE(MASM_PROBE) section.
In this patch, I also simplified the X86 and X86_64 ports to use the same
port implementation. The ARMv7 probe implementation should not conditionally
exclude the higher FP registers (since the JIT doesn't). Fixed the ARMv7
probe code to include the higher FP registers always.
This is all done in preparation to add printing functionality in JITted code
for debugging.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Label::Label):
(JSC::AbstractMacroAssembler::ConvertibleLoadLabel::ConvertibleLoadLabel):
(JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr):
(JSC::AbstractMacroAssembler::DataLabel32::DataLabel32):
(JSC::AbstractMacroAssembler::DataLabelCompact::DataLabelCompact):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::JumpList::link):
(JSC::AbstractMacroAssembler::JumpList::linkTo):
(JSC::AbstractMacroAssembler::ProbeContext::print):
(JSC::AbstractMacroAssembler::printIndent):
(JSC::AbstractMacroAssembler::printCPU):
(JSC::AbstractMacroAssembler::CachedTempRegister::CachedTempRegister):
- Except for the 3 printing methods (which are for the probe), the rest are touched simply because we need to add the MacroAssemblerType to the template args. The MacroAssemblerType is used by the abstract probe code to call the few probe methods that need to have CPU specific implementations.
- assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::printCPURegisters):
- This was refactored from ProbeContext::dumpCPURegisters() which no longer exists.
(JSC::MacroAssemblerARM::ProbeContext::dumpCPURegisters): Deleted.
(JSC::MacroAssemblerARM::ProbeContext::dump): Deleted.
- assembler/MacroAssemblerARM.h:
- assembler/MacroAssemblerARM64.h:
- assembler/MacroAssemblerARMv7.cpp:
(JSC::MacroAssemblerARMv7::printCPURegisters):
- This was refactored from ProbeContext::dumpCPURegisters() which no longer exists.
(JSC::MacroAssemblerARMv7::ProbeContext::dumpCPURegisters): Deleted.
(JSC::MacroAssemblerARMv7::ProbeContext::dump): Deleted.
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerMIPS.h:
- assembler/MacroAssemblerSH4.h:
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::trustedImm32FromPtr): Deleted.
(JSC::MacroAssemblerX86::probe): Deleted.
- assembler/MacroAssemblerX86Common.cpp:
(JSC::MacroAssemblerX86Common::printCPURegisters):
- This was refactored from ProbeContext::dumpCPURegisters() which no longer exists.
(JSC::MacroAssemblerX86Common::probe):
- This implementation of probe() is based on the one originally in MacroAssemblerX86_64.h. It is generic and should work for both 32-bit and 64-bit.
(JSC::MacroAssemblerX86Common::ProbeContext::dumpCPURegisters): Deleted.
(JSC::MacroAssemblerX86Common::ProbeContext::dump): Deleted.
- assembler/MacroAssemblerX86Common.h:
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::trustedImm64FromPtr): Deleted.
(JSC::MacroAssemblerX86_64::probe): Deleted.
- jit/JITStubsARMv7.h:
- 12:05 PM Changeset in webkit [176133] by
-
- 3 edits in trunk/Source/WebKit2
Add some tracing to help investigating <rdar://problem/18905383> [iOS] Crash due to null m_webPageProxyForBackForwardListForCurrentSwipe in ViewGestureController::endSwipeGesture
https://bugs.webkit.org/show_bug.cgi?id=138750
Reviewed by Tim Horton.
Emit trace messages at various points, and log them prior to crashing if the error condition
occurs. Otherwise, clear the trace messages.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::addLogEntry): Helper function that adds a message, including a time stamp and a
backtrace, to m_logEntries.
(WebKit::dumpLogEntries): Helper function that logs everything in m_logEntries.
(WebKit::ViewGestureController::beginSwipeGesture): Add a log entry.
(WebKit::ViewGestureController::endSwipeGesture): If
m_webPageProxyForBackForwardListForCurrentSwipe is null, dump the log entries just before
crashing. Otherwise, clear m_logEntries.
(WebKit::ViewGestureController::willCommitPostSwipeTransitionLayerTree): Add a log entry.
(WebKit::ViewGestureController::removeSwipeSnapshot): Add a log entry.
- UIProcess/mac/ViewGestureController.h: Defined ENABLE_VIEW_GESTURE_CONTROLLER_TRACING,
and added m_logEntries member variable.
- 11:25 AM Changeset in webkit [176132] by
-
- 2 edits in trunk/Source/WebKit/mac
WK1: Webpage preview can come up in wrong location
https://bugs.webkit.org/show_bug.cgi?id=138747
-and corresponding-
rdar://problem/18979004
Reviewed by Tim Horton.
Converting to window twice is bad.
- WebView/WebActionMenuController.mm:
(elementBoundingBoxInWindowCoordinatesFromNode):
(-[WebActionMenuController _quickLookURLFromActionMenu:]):
(elementBoundingBoxFromNode): Deleted.
- 11:12 AM Changeset in webkit [176131] by
-
- 2 edits in trunk/Source/WebKit2
URLs for some videos are not valid URLs, should not be exposed to action menu
https://bugs.webkit.org/show_bug.cgi?id=138746
-and corresponding-
rdar://problem/18941927
Reviewed by Tim Horton.
If the video cannot be downloaded, that is also an indication that the URL of the
video will not be valid on its own. In these cases, we should share or copy the
main page’s URL.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForVideo]):
(-[WKActionMenuController _copyVideoURL:]):
- 10:49 AM Changeset in webkit [176130] by
-
- 5 edits in tags/Safari-601.1.9.1/Source
Versioning.
- 10:47 AM Changeset in webkit [176129] by
-
- 1 copy in tags/Safari-601.1.9.1
New tag.
- 10:26 AM Changeset in webkit [176128] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Test that small caps of web fonts works regardless of where the font face is declared
https://bugs.webkit.org/show_bug.cgi?id=138700
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2014-11-14
Reviewed by Alexey Proskuryakov.
- fast/text/svg-small-caps-expected.html: Added.
- fast/text/svg-small-caps.html: Added.
- 10:25 AM Changeset in webkit [176127] by
-
- 4 edits in trunk
Add shortcut macros to Mac TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=138729
Reviewed by Simon Fraser.
- Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
Add version macros for current OS versions.
- 10:21 AM Changeset in webkit [176126] by
-
- 1 edit2 adds in trunk/LayoutTests
Test that small caps of web fonts works regardless of where the font face is declared
https://bugs.webkit.org/show_bug.cgi?id=138700
Reviewed by Alexey Proskuryakov.
- fast/text/svg-small-caps-expected.html: Added.
- fast/text/svg-small-caps.html: Added.
- 10:00 AM Changeset in webkit [176125] by
-
- 3 edits in trunk/LayoutTests
Many (most?) transitions tests are very flaky, frequently failing all at once
https://bugs.webkit.org/show_bug.cgi?id=137883
- TestExpectations:
- platform/mac/TestExpectations:
Add more affected tests to unbreak EWS.
- 8:53 AM Changeset in webkit [176124] by
-
- 5 edits2 adds in trunk
Table rows repaint entire table when their background color changes.
https://bugs.webkit.org/show_bug.cgi?id=26662
Reviewed by Simon Fraser.
Added fast/repaint/table-row-repaint.html
Source/WebCore:
- rendering/RenderTableCell.h:
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
Improve table row's function to unite with the cell rects that can possibly
have the the row's background color painted behind them.
LayoutTests:
- fast/repaint/table-row-repaint-expected.txt: Added.
- fast/repaint/table-row-repaint.html: Added.
- platform/mac/accessibility/table-detection-expected.txt:
- 8:20 AM Changeset in webkit [176123] by
-
- 6 edits1 add in trunk/Source/WebCore
Simple line layout: Move simple line layout RunResolver and LineResolver implementation to SimpleLineLayoutResolver.cpp
https://bugs.webkit.org/show_bug.cgi?id=138704
Reviewed by Antti Koivisto.
No change in functionality.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- rendering/SimpleLineLayoutResolver.cpp: Added.
(WebCore::SimpleLineLayout::RunResolver::Run::Run):
(WebCore::SimpleLineLayout::RunResolver::Run::rect):
(WebCore::SimpleLineLayout::RunResolver::Run::baseline):
(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::RunResolver::Iterator::advance):
(WebCore::SimpleLineLayout::RunResolver::Iterator::advanceLines):
(WebCore::SimpleLineLayout::RunResolver::RunResolver):
(WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):
(WebCore::SimpleLineLayout::RunResolver::rangeForRect):
(WebCore::SimpleLineLayout::LineResolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator*):
(WebCore::SimpleLineLayout::LineResolver::LineResolver):
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::Run::Run): Deleted.
(WebCore::SimpleLineLayout::RunResolver::Run::rect): Deleted.
(WebCore::SimpleLineLayout::RunResolver::Run::baseline): Deleted.
(WebCore::SimpleLineLayout::RunResolver::Run::text): Deleted.
(WebCore::SimpleLineLayout::RunResolver::Iterator::Iterator): Deleted.
(WebCore::SimpleLineLayout::RunResolver::Iterator::advance): Deleted.
(WebCore::SimpleLineLayout::RunResolver::Iterator::advanceLines): Deleted.
(WebCore::SimpleLineLayout::RunResolver::RunResolver): Deleted.
(WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight): Deleted.
(WebCore::SimpleLineLayout::RunResolver::rangeForRect): Deleted.
(WebCore::SimpleLineLayout::LineResolver::Iterator::Iterator): Deleted.
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator*): Deleted.
(WebCore::SimpleLineLayout::LineResolver::LineResolver): Deleted.
- 3:27 AM Changeset in webkit [176122] by
-
- 10 edits in trunk
AX: Improve AccessibilityTableCell isColumnHeaderCell function.
https://bugs.webkit.org/show_bug.cgi?id=138423
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-11-14
Reviewed by Chris Fleizach.
Source/WebCore:
<th> cell in the zero row should be column header.
New tests are not necessary.
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::isColumnHeaderCell):
LayoutTests:
Files of expected type are adapted to changes in the code of the function.
- accessibility/table-cells-roles-expected.txt:
- platform/efl/accessibility/table-attributes-expected.txt:
- platform/efl/accessibility/table-cells-expected.txt:
- platform/gtk/accessibility/table-attributes-expected.txt:
- platform/gtk/accessibility/table-cells-expected.txt:
- platform/mac/accessibility/table-attributes-expected.txt:
- platform/mac/accessibility/table-cells-expected.txt:
- 2:33 AM Changeset in webkit [176121] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Skip http/tests/appcache/auth.html after r175776.
Appcache manifest is still downloaded in the WebProcess.
- platform/gtk/TestExpectations:
- 1:21 AM Changeset in webkit [176120] by
-
- 3 edits in trunk/Source/WebCore
[SOUP] Use GMainLoopSource for request timeout in ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=138695
Reviewed by Sergio Villar Senin.
We are currently using soup_timeout_add() that simply creates a
GSource and attaches it to the given context. Using
GMainLoopSource we simplify the code and fix any potential problem
of converting the double value into milliseconds.
- platform/network/ResourceHandleInternal.h:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation):
(WebCore::ResourceHandle::sendPendingRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::requestTimeoutCallback): Deleted.
- 12:49 AM Changeset in webkit [176119] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] Encode/Decode allowCookies in ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=138730
Reviewed by Sergio Villar Senin.
We are not sending this information to the network process, making
cookies always available. Fixes
http/tests/xmlhttprequest/cross-origin-no-authorization.html when
network process is enabled.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
- 12:43 AM Changeset in webkit [176118] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for the GTK+ port using Clang.
- UIProcess/gtk/RedirectedXCompositeWindow.h: Include the <functional>
header for the use of std::function<>.
- 12:21 AM Changeset in webkit [176117] by
-
- 2 edits in trunk/LayoutTests
Remove some ineffective entries.
- platform/mac/TestExpectations: Remove entries that were meant to override other
ones, but don't.
Nov 13, 2014:
- 10:57 PM Changeset in webkit [176116] by
-
- 2 edits in trunk/Source/WebKit2
Two WKWebView internal methods are implemented in a category
https://bugs.webkit.org/show_bug.cgi?id=138728
Reviewed by Tim HOrton.
Moved the implementations from the category to the class.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _ignoresNonWheelMouseEvents]):
(-[WKWebView _setIgnoresNonWheelMouseEvents:]):
- 8:26 PM Changeset in webkit [176115] by
-
- 8 edits in trunk/Source/WebCore
[mac] Keep around more decoded image data, since it's purgeable
https://bugs.webkit.org/show_bug.cgi?id=125273
<rdar://problem/13205438>
Reviewed by Simon Fraser.
No new tests, just an optimization.
Instead of throwing away decoded image data eagerly, allow the operating
system to manage the memory via the standard purgeability mechanism,
where it can.
This improves the performance on some pathological cases (extremely large
animated GIFs) by up to 8x.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneLiveResourcesToSize):
Don't prune live resources' decoded data if it is purgeable.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
Don't eagerly throw away decoded image data if it's purgeable.
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.h:
(WebCore::CachedResource::decodedDataIsPurgeable):
- platform/graphics/BitmapImage.h:
- platform/graphics/Image.h:
(WebCore::Image::decodedDataIsPurgeable):
- 6:53 PM Changeset in webkit [176114] by
-
- 2 edits in trunk/Source/WebCore
Addressing post-review comment
https://bugs.webkit.org/show_bug.cgi?id=138633
- platform/spi/cg/CoreGraphicsSPI.h:
- 6:45 PM Changeset in webkit [176113] by
-
- 185 edits in trunk/LayoutTests
Rebaseline iOS layout tests
https://bugs.webkit.org/show_bug.cgi?id=138721
Reviewed by Simon Fraser.
Rebaseline many of the failures in compositing tests.
- platform/ios-simulator/compositing/absolute-inside-out-of-view-fixed-expected.txt:
- platform/ios-simulator/compositing/backing/backface-visibility-flip-expected.txt:
- platform/ios-simulator/compositing/backing/backface-visibility-in-3dtransformed-expected.txt:
- platform/ios-simulator/compositing/backing/border-radius-no-backing-expected.txt:
- platform/ios-simulator/compositing/backing/child-layer-no-backing-expected.txt:
- platform/ios-simulator/compositing/backing/filter-no-backing-expected.txt:
- platform/ios-simulator/compositing/backing/inline-block-no-backing-expected.txt:
- platform/ios-simulator/compositing/backing/masked-child-no-backing-expected.txt:
- platform/ios-simulator/compositing/backing/no-backing-for-clip-expected.txt:
- platform/ios-simulator/compositing/backing/no-backing-for-clip-overhang-expected.txt:
- platform/ios-simulator/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/ios-simulator/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/ios-simulator/compositing/backing/replaced-child-no-backing-expected.txt:
- platform/ios-simulator/compositing/backing/whitespace-nodes-no-backing-expected.txt:
- platform/ios-simulator/compositing/bounds-in-flipped-writing-mode-expected.txt:
- platform/ios-simulator/compositing/clip-child-by-non-stacking-ancestor-expected.txt:
- platform/ios-simulator/compositing/columns/ancestor-clipped-in-paginated-expected.txt:
- platform/ios-simulator/compositing/columns/clipped-in-paginated-expected.txt:
- platform/ios-simulator/compositing/columns/composited-columns-expected.txt:
- platform/ios-simulator/compositing/columns/composited-columns-vertical-rl-expected.txt:
- platform/ios-simulator/compositing/columns/composited-in-paginated-expected.txt:
- platform/ios-simulator/compositing/columns/composited-in-paginated-rl-expected.txt:
- platform/ios-simulator/compositing/columns/composited-in-paginated-writing-mode-rl-expected.txt:
- platform/ios-simulator/compositing/columns/composited-lr-paginated-repaint-expected.txt:
- platform/ios-simulator/compositing/columns/composited-nested-columns-expected.txt:
- platform/ios-simulator/compositing/columns/composited-rl-paginated-repaint-expected.txt:
- platform/ios-simulator/compositing/columns/hittest-composited-in-paginated-expected.txt:
- platform/ios-simulator/compositing/columns/rotated-in-paginated-expected.txt:
- platform/ios-simulator/compositing/columns/untransformed-composited-in-paginated-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/background-clip-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/background-color-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/body-background-painted-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/body-background-skipped-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/control-layer-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/filter-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/hidden-with-visible-child-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/hidden-with-visible-text-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/layer-opacity-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/layer-transform-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt:
- platform/ios-simulator/compositing/contents-opaque/visibility-hidden-expected.txt:
- platform/ios-simulator/compositing/contents-scale/animating-expected.txt:
- platform/ios-simulator/compositing/contents-scale/rounded-contents-scale-expected.txt:
- platform/ios-simulator/compositing/contents-scale/scaled-ancestor-expected.txt:
- platform/ios-simulator/compositing/contents-scale/simple-scale-expected.txt:
- platform/ios-simulator/compositing/contents-scale/z-translate-expected.txt:
- platform/ios-simulator/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- platform/ios-simulator/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
- platform/ios-simulator/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- platform/ios-simulator/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
- platform/ios-simulator/compositing/fixed-image-loading-expected.txt:
- platform/ios-simulator/compositing/geometry/ancestor-overflow-change-expected.txt:
- platform/ios-simulator/compositing/geometry/bounds-clipped-composited-child-expected.txt:
- platform/ios-simulator/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/ios-simulator/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
- platform/ios-simulator/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/ios-simulator/compositing/geometry/bounds-ignores-hidden-expected.txt:
- platform/ios-simulator/compositing/geometry/clip-expected.txt:
- platform/ios-simulator/compositing/geometry/clip-inside-expected.txt:
- platform/ios-simulator/compositing/geometry/composited-in-columns-expected.txt:
- platform/ios-simulator/compositing/geometry/fixed-position-composited-switch-expected.txt:
- platform/ios-simulator/compositing/geometry/flipped-writing-mode-expected.txt:
- platform/ios-simulator/compositing/geometry/foreground-layer-expected.txt:
- platform/ios-simulator/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/ios-simulator/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- platform/ios-simulator/compositing/geometry/limit-layer-bounds-fixed-expected.txt:
- platform/ios-simulator/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- platform/ios-simulator/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/ios-simulator/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- platform/ios-simulator/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- platform/ios-simulator/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- platform/ios-simulator/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- platform/ios-simulator/compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt:
- platform/ios-simulator/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/ios-simulator/compositing/geometry/vertical-scroll-composited-expected.txt:
- platform/ios-simulator/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/ios-simulator/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/ios-simulator/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/ios-simulator/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/ios-simulator/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/ios-simulator/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/ios-simulator/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/ios-simulator/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/ios-simulator/compositing/iframes/iframe-resize-expected.txt:
- platform/ios-simulator/compositing/iframes/iframe-size-from-zero-expected.txt:
- platform/ios-simulator/compositing/iframes/iframe-size-to-zero-expected.txt: Progression.
- platform/ios-simulator/compositing/iframes/iframe-src-change-expected.txt: Progression.
- platform/ios-simulator/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
- platform/ios-simulator/compositing/iframes/leave-compositing-iframe-expected.txt:
- platform/ios-simulator/compositing/iframes/overlapped-iframe-expected.txt:
- platform/ios-simulator/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/ios-simulator/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/ios-simulator/compositing/iframes/page-cache-layer-tree-expected.txt:
- platform/ios-simulator/compositing/iframes/resizer-expected.txt:
- platform/ios-simulator/compositing/iframes/scrolling-iframe-expected.txt:
- platform/ios-simulator/compositing/images/clip-on-directly-composited-image-expected.txt:
- platform/ios-simulator/compositing/layer-creation/animation-overlap-with-children-expected.txt:
- platform/ios-simulator/compositing/layer-creation/fixed-position-and-transform-expected.txt:
- platform/ios-simulator/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/ios-simulator/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
- platform/ios-simulator/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- platform/ios-simulator/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- platform/ios-simulator/compositing/layer-creation/fixed-position-transformed-into-view-expected.txt:
- platform/ios-simulator/compositing/layer-creation/fixed-position-under-transform-expected.txt:
- platform/ios-simulator/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt:
- platform/ios-simulator/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/ios-simulator/compositing/layer-creation/no-compositing-for-sticky-expected.txt:
- platform/ios-simulator/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- platform/ios-simulator/compositing/layer-creation/overlap-child-layer-expected.txt:
- platform/ios-simulator/compositing/layer-creation/overlap-clipping-expected.txt:
- platform/ios-simulator/compositing/layer-creation/overlap-transformed-3d-expected.txt:
- platform/ios-simulator/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
- platform/ios-simulator/compositing/layer-creation/overlap-transformed-layer-expected.txt:
- platform/ios-simulator/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
- platform/ios-simulator/compositing/layer-creation/overlap-transforms-expected.txt:
- platform/ios-simulator/compositing/layer-creation/rotate3d-overlap-expected.txt:
- platform/ios-simulator/compositing/layer-creation/scroll-partial-update-expected.txt:
- platform/ios-simulator/compositing/layer-creation/stacking-context-overlap-expected.txt:
- platform/ios-simulator/compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
- platform/ios-simulator/compositing/layer-creation/translatez-overlap-expected.txt:
- platform/ios-simulator/compositing/masks/mask-layer-size-expected.txt:
- platform/ios-simulator/compositing/overflow-trumps-transform-style-expected.txt:
- platform/ios-simulator/compositing/overflow/automatically-opt-into-composited-scrolling-expected.txt: Progression.
- platform/ios-simulator/compositing/overflow/clip-descendents-expected.txt:
- platform/ios-simulator/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
- platform/ios-simulator/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
- platform/ios-simulator/compositing/overflow/content-gains-scrollbars-expected.txt:
- platform/ios-simulator/compositing/overflow/content-loses-scrollbars-expected.txt:
- platform/ios-simulator/compositing/overflow/overflow-auto-with-touch-expected.txt:
- platform/ios-simulator/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt:
- platform/ios-simulator/compositing/overflow/overflow-overlay-with-touch-expected.txt:
- platform/ios-simulator/compositing/overflow/overflow-scrollbar-layer-positions-expected.txt:
- platform/ios-simulator/compositing/overflow/overflow-scrollbar-layers-expected.txt:
- platform/ios-simulator/compositing/overflow/resize-painting-expected.txt:
- platform/ios-simulator/compositing/regions/fixed-in-named-flow-clip-descendant-expected.txt:
- platform/ios-simulator/compositing/regions/fixed-in-named-flow-expected.txt:
- platform/ios-simulator/compositing/regions/fixed-in-named-flow-from-abs-in-named-flow-expected.txt:
- platform/ios-simulator/compositing/regions/fixed-in-named-flow-from-outflow-expected.txt:
- platform/ios-simulator/compositing/regions/fixed-in-named-flow-got-transformed-parent-expected.txt:
- platform/ios-simulator/compositing/regions/fixed-in-named-flow-lost-transformed-parent-expected.txt:
- platform/ios-simulator/compositing/regions/fixed-in-named-flow-overlap-composited-expected.txt:
- platform/ios-simulator/compositing/regions/fixed-in-named-flow-transformed-parent-expected.txt:
- platform/ios-simulator/compositing/regions/fixed-transformed-in-named-flow-expected.txt:
- platform/ios-simulator/compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt:
- platform/ios-simulator/compositing/repaint/become-overlay-composited-layer-expected.txt:
- platform/ios-simulator/compositing/repaint/fixed-background-scroll-expected.txt:
- platform/ios-simulator/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/ios-simulator/compositing/repaint/positioned-movement-expected.txt:
- platform/ios-simulator/compositing/repaint/repaint-on-layer-grouping-change-expected.txt:
- platform/ios-simulator/compositing/repaint/resize-repaint-expected.txt:
- platform/ios-simulator/compositing/rtl/rtl-absolute-expected.txt:
- platform/ios-simulator/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/ios-simulator/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- platform/ios-simulator/compositing/rtl/rtl-fixed-expected.txt:
- platform/ios-simulator/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/ios-simulator/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/ios-simulator/compositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/ios-simulator/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- platform/ios-simulator/compositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/ios-simulator/compositing/rtl/rtl-iframe-relative-expected.txt:
- platform/ios-simulator/compositing/rtl/rtl-relative-expected.txt:
- platform/ios-simulator/compositing/scrolling/touch-scroll-to-clip-expected.txt:
- platform/ios-simulator/compositing/tiled-layers-hidpi-expected.txt:
- platform/ios-simulator/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- platform/ios-simulator/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/ios-simulator/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/ios-simulator/compositing/tiling/huge-layer-img-expected.txt:
- platform/ios-simulator/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/ios-simulator/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/ios-simulator/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/ios-simulator/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/ios-simulator/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/ios-simulator/compositing/tiling/tiled-layer-resize-expected.txt:
- platform/ios-simulator/compositing/visibility/layer-visible-content-expected.txt:
- platform/ios-simulator/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/ios-simulator/compositing/visible-rect/2d-transformed-expected.txt:
- platform/ios-simulator/compositing/visible-rect/3d-transform-style-expected.txt:
- platform/ios-simulator/compositing/visible-rect/3d-transformed-expected.txt:
- platform/ios-simulator/compositing/visible-rect/clipped-by-viewport-expected.txt:
- platform/ios-simulator/compositing/visible-rect/clipped-visible-rect-expected.txt:
- platform/ios-simulator/compositing/visible-rect/flipped-preserve-3d-expected.txt:
- platform/ios-simulator/compositing/visible-rect/iframe-and-layers-expected.txt:
- platform/ios-simulator/compositing/visible-rect/nested-transform-expected.txt:
- platform/ios-simulator/compositing/visible-rect/scrolled-expected.txt:
- 6:19 PM Changeset in webkit [176112] by
-
- 23 edits1 copy1 move1 add in trunk/Source
Move FontMac and FontCacheMac off of WKSI
https://bugs.webkit.org/show_bug.cgi?id=138633
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2014-11-13
Reviewed by NOBODY (OOPS!).
Source/WebCore:
No new tests because there is no behavior change.
- WebCore.exp.in:
- WebCore.order:
- WebCore.vcxproj/WebCoreCG.props:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::FontCache::platformInit):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::platformInit):
(WebCore::FontCache::systemFallbackForCharacters):
- platform/graphics/mac/FontMac.mm:
(WebCore::isIntegral):
(WebCore::setCGFontRenderingMode):
(WebCore::Font::drawGlyphs):
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::platformInit):
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/spi/cocoa/CoreGraphicsSPI.h: Copied from Source/WebCore/platform/spi/cocoa/CGFontUnicodeSupportSPI.h.
- platform/spi/cocoa/CoreTextSPI.h:
- platform/spi/mac/NSFontSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CGFontUnicodeSupportSPI.h.
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- WebKit.order:
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- mac/WebKit2.order:
- 6:16 PM Changeset in webkit [176111] by
-
- 4 edits in trunk/Source/WebCore
Move 'image-resolution' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138715
Reviewed by Andreas Kling.
Move 'image-resolution' CSS property from DeprecatedStyleBuilder to
the new StyleBuilder by using custom code.
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyImageResolution::applyInheritValue): Deleted.
(WebCore::ApplyPropertyImageResolution::applyInitialValue): Deleted.
(WebCore::ApplyPropertyImageResolution::applyValue): Deleted.
(WebCore::ApplyPropertyImageResolution::createHandler): Deleted.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderFunctions::applyInheritImageResolution):
(WebCore::StyleBuilderFunctions::applyInitialImageResolution):
(WebCore::StyleBuilderFunctions::applyValueImageResolution):
- 5:15 PM Changeset in webkit [176110] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r176106.
https://bugs.webkit.org/show_bug.cgi?id=138719
needs build love (Requested by kling on #webkit).
Reverted changeset:
"[mac] Keep around more decoded image data, since it's
purgeable"
https://bugs.webkit.org/show_bug.cgi?id=125273
http://trac.webkit.org/changeset/176106
Patch by Commit Queue <commit-queue@webkit.org> on 2014-11-13
- 5:07 PM Changeset in webkit [176109] by
-
- 21 edits in trunk/Source/JavaScriptCore
Add scope operand to op_new_func* byte codes
https://bugs.webkit.org/show_bug.cgi?id=138707
Reviewed by Mark Lam.
Added scope operand to op_new_func and op_new_func_expr to replace the implicit use
of exec->scope().
- bytecode/BytecodeList.json: Increased size of op_new_func & op_new_func_expr bytecodes.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode): Added scope operand to dump output.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewFunctionInternal):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
Emit scope operand.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
Added new scope source nodes to NewFunction, NewFunctionExpression & NewFunctionNoCheck.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewFunctionNoCheck):
(JSC::DFG::SpeculativeJIT::compileNewFunctionExpression):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Use scope children when making new function JIT_Operation calls. Use JSScope* value instead of
exec->scope().
- dfg/DFGOperations.h:
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
Added new Jsc JIT_Operation parameter type for JSScope* values. Created declarations and
definitions for new JIT_Operations with Jsc parameters. Use the JSScope* parameters in lieu
of exec->scope() in operationNewFunction().
Removed comment for unused Jsa (JSLexicalEnvironment*) JIT_Operation parameter type.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
Use the scope operand instead of exec->scope().
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
Changed the operand indecies for added scope operand.
- 4:46 PM Changeset in webkit [176108] by
-
- 21 edits in trunk/Source
Context menus should not offer the "Download video" option for videos that cannot
be downloaded
https://bugs.webkit.org/show_bug.cgi?id=138530
-and corresponding-
rdar://problem/18919130
Patch by Eric Carlson <eric.carlson@apple.com> on 2014-11-13
Reviewed by Tim Horton.
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLMediaElement.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::canSaveMediaData):
(WebCore::MediaPlayer::supportsSave): Deleted.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::supportsFullscreen):
(WebCore::MediaPlayerPrivateInterface::canSaveMediaData):
(WebCore::MediaPlayerPrivateInterface::supportsSave): Deleted.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::resolvedURL):
(WebCore::MediaPlayerPrivateAVFoundation::canSaveMediaData):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::resolvedURL):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::canSaveMediaData):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::canSaveMediaData):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isDownloadableMedia):
Source/WebKit2:
Expose isDownloadableMedia() to the InjectedBundleHitTestResult.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultIsDownloadableMedia):
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::isDownloadableMedia):
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- 4:37 PM Changeset in webkit [176107] by
-
- 2 edits in trunk/Source/WebKit/mac
WK1: Clean up WebActionMenuController to use the _hitTestResult ivar
https://bugs.webkit.org/show_bug.cgi?id=138716
-and corresponding-
rdar://problem/18977222
Reviewed by Tim Horton.
It’s not necessary to use the WebElementDictionary for so many things now that we
are caching the HitTestResult. We should just use the HitTestResult.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController prepareForMenu:withEvent:]):
(-[WebActionMenuController _openURLFromActionMenu:]):
(-[WebActionMenuController _addToReadingListFromActionMenu:]):
(elementBoundingBoxFromNode):
(-[WebActionMenuController _quickLookURLFromActionMenu:]):
(-[WebActionMenuController _defaultMenuItemsForLink]):
(-[WebActionMenuController _defaultMenuItemsForImage]):
(-[WebActionMenuController _defaultMenuItemsForVideo]):
(-[WebActionMenuController _defaultMenuItemsForText]):
(-[WebActionMenuController _defaultMenuItemsForEditableText]):
(-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions]):
(-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
(-[WebActionMenuController _createActionMenuItemForTag:]):
(-[WebActionMenuController _defaultMenuItems]):
(-[WebActionMenuController _elementBoundingBoxFromDOMElement:]): Deleted.
(-[WebActionMenuController _defaultMenuItemsForLink:]): Deleted.
(-[WebActionMenuController _defaultMenuItemsForImage:]): Deleted.
(-[WebActionMenuController _defaultMenuItemsForVideo:]): Deleted.
(-[WebActionMenuController _defaultMenuItemsForText:]): Deleted.
(-[WebActionMenuController _defaultMenuItemsForEditableText:]): Deleted.
(-[WebActionMenuController _defaultMenuItemsForEditableTextWithSuggestions:]): Deleted.
(-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea:]): Deleted.
(-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]): Deleted.
(-[WebActionMenuController _defaultMenuItemsForHitTestResult:]): Deleted.
- 4:36 PM Changeset in webkit [176106] by
-
- 8 edits in trunk/Source/WebCore
[mac] Keep around more decoded image data, since it's purgeable
<https://webkit.org/b/125273>
<rdar://problem/13205438>
Patch by Tim Horton <timothy_horton@apple.com> on 2014-11-02
Reviewed by Simon Fraser and Andreas Kling.
No new tests, just an optimization.
Instead of throwing away decoded image data eagerly, allow the operating
system to manage the memory via the standard purgeability mechanism,
where it can.
This improves the performance on some pathological cases (extremely large
animated GIFs) by up to 8x.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneLiveResourcesToSize):
Don't prune live resources' decoded data if it is purgeable.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
Don't eagerly throw away decoded image data if it's purgeable.
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.h:
(WebCore::CachedResource::decodedDataIsPurgeable):
- platform/graphics/BitmapImage.h:
- platform/graphics/Image.h:
(WebCore::Image::decodedDataIsPurgeable):
- 4:34 PM Changeset in webkit [176105] by
-
- 12 edits in trunk/Source
[iOS] NSGeometry data types are not available in the public SDK
https://bugs.webkit.org/show_bug.cgi?id=137536
Reviewed by David Kilzer.
Source/WebCore:
Towards building iOS WebKit with the public iOS SDK, define NSGeometry
data types and functions in terms of CGGeometry data types and functions
because the former is SPI on iOS.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Include
header WAKAppKitStubs.h when building for iOS. Otherwise, include header NSGeometry.h.
- platform/graphics/ca/mac/PlatformCALayerMac.mm: Remove import of private header NSGeometry.h.
We will use the NSGeometry data types defined in WAKAppKitStubs.h, which is implicitly imported
by header WAKWindow.h.
- platform/graphics/mac/MediaPlayerProxy.h: Substitute WAKAppKitStubs.h for NSGeometry.h.
- platform/ios/PlatformEventFactoryIOS.mm: Ditto. Also fix up style issues with #import directives.
- platform/ios/WebEvent.mm: Ditto.
- platform/ios/wak/WAKAppKitStubs.h: Define typedefs and macros that map NSGeometry data types
and functions to the analogous CGGeometry data types and functions. Also, remove #ifdef OBJC-
guard as the existing content in WAKAppKitStubs.h assumes that this file will only be included
in an Objective-C/Objective-C++ file.
- platform/ios/wak/WAKView.h: Import header WAKAppKitStubs.h instead of defining macros for some
NSGeometry data types.
Source/WebKit/mac:
Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
private header.
- DOM/WebDOMOperationsPrivate.h:
Source/WebKit2:
Substitute header WAKAppKitStubs.h for NSGeometry.h as the latter is a
private header.
- Shared/ios/NativeWebTouchEventIOS.mm:
- 4:33 PM Changeset in webkit [176104] by
-
- 2 edits in trunk/Tools
https://bugs.webkit.org/show_bug.cgi?id=138628
A patch that doesn't apply is stuck in commit queue
Rubber-stamped by David Kilzer.
This also hopefully fixes other issues:
- a patch that has cq+ flag set by a non-committer kills commit queue;
- EWS never reports failing tests, and keeps spinning instead.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.set_flag_on_attachment):
(Bugzilla.obsolete_attachment):
Apply the fix from r174797 to more places.
- 4:10 PM Changeset in webkit [176103] by
-
- 7 edits in tags/Safari-601.1.9/Source/WebCore
Merged r176090. rdar://problem/18963531
- 3:50 PM Changeset in webkit [176102] by
-
- 5 edits in branches/safari-600.3-branch/Source
Versioning.
- 3:47 PM Changeset in webkit [176101] by
-
- 1 copy in tags/Safari-600.3.6
New Tag.
- 3:43 PM Changeset in webkit [176100] by
-
- 2 edits in trunk/Source/JavaScriptCore
Change X86/64 JIT probes to save/restore xmm regs as double instead of m128. [Follow up]
<https://webkit.org/b/138708>
Reviewed by Michael Saboff.
Removed a stale comment and a now unnecessary #include.
- assembler/X86Assembler.h:
- 3:30 PM Changeset in webkit [176099] by
-
- 3 edits in trunk/Source/WebKit/mac
WK1: Support default actions for video
https://bugs.webkit.org/show_bug.cgi?id=138713
-and corresponding-
rdar://problem/18877520
Reviewed by Tim Horton.
Call setToNonShadowAncestor() for media HitTestResults.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController performHitTestAtPoint:]):
Default items and actions.
(-[WebActionMenuController _defaultMenuItemsForVideo:]):
(-[WebActionMenuController _copyVideoURL:]):
(-[WebActionMenuController _saveVideoToDownloads:]):
(-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
(-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
- WebView/WebUIDelegatePrivate.h:
- 3:30 PM Changeset in webkit [176098] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r176087.
https://bugs.webkit.org/show_bug.cgi?id=138714
Broke the build (Requested by ap on #webkit).
Reverted changeset:
"Update WebKit to build with LLVM TOT"
https://bugs.webkit.org/show_bug.cgi?id=138519
http://trac.webkit.org/changeset/176087
- 3:27 PM Changeset in webkit [176097] by
-
- 11 edits in trunk/Source
[WK2] Fire a layout milestone on session restore based on render tree size
https://bugs.webkit.org/show_bug.cgi?id=138711
rdar://problem/16033854
Reviewed by Anders Carlsson.
Source/WebCore:
New layout milestone for session restore based on render tree size. Only used
in WK2 at present.
- page/LayoutMilestones.h:
Source/WebKit2:
Add a session-restore layout milestone which fires after restoring a session,
when the render tree size reaches 50% of the size saved in the session state.
- Shared/SessionState.h: Add renderTreeSize.
- UIProcess/API/Cocoa/WKWebView.mm:
(layoutMilestones): Translate from SPI to WebCore milestones.
- UIProcess/API/Cocoa/WKWebViewPrivate.h: New iOS-only milestone, er, event.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::renderingProgressEvents): Translate from WebCore milestone to rendering event.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Init stuff.
(WebKit::WebPageProxy::sessionState):
(WebKit::WebPageProxy::restoreFromSessionState): Zero out the target render tree size,
then get it out of session state and set the flag to say that we haven't reached it yet.
(WebKit::WebPageProxy::listenForLayoutMilestones): Set a flag to know that we should fire
the milestone. The other milestones get sent directly to WebCore.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::exceedsRenderTreeSizeSizeThreshold): Return true when we've reached 50%.
(WebKit::WebPageProxy::didCommitLayerTree): Fire the milestone when appropriate.
- UIProcess/mac/LegacySessionStateCoding.cpp: Rev the session state data for iOS
(where doing so is less disruptive). Standardize some CFString constants.
(WebKit::encodeSessionHistory): Wrap for legibility.
(WebKit::encodeLegacySessionState): Make a CFNumber for render tree size, and store
it in the root dictionary.
(WebKit::decodeBackForwardTreeNode): Move a comment to match another similar block.
(WebKit::decodeLegacySessionState): Decode render tree size and store it.
- 3:22 PM Changeset in webkit [176096] by
-
- 4 edits in trunk
Policy client not called for navigations through the page cache
https://bugs.webkit.org/show_bug.cgi?id=138703
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test added to TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadDifferentDocumentItem): When using a cached page, which already
has a document loader, set the document loader’s triggering action (so that the policy
client sees that this is a back/forward navigation) and clear its last checked request (so
that the policy client gets called).
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
(-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
(-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
- 3:00 PM Changeset in webkit [176095] by
-
- 6 edits in trunk/Source/JavaScriptCore
Change X86/64 JIT probes to save/restore xmm regs as double instead of m128.
<https://webkit.org/b/138708>
Reviewed by Michael Saboff.
The JIT code only uses the xmm regs as double registers. This patch changes
the storage types of the FP registers in X86Assembler.h to double instead of
m128, and updates the X86 and X86_64 JIT probe implementations accordingly.
Also made some minor cosmetic changes in the output of the probe dump functions.
- assembler/MacroAssemblerX86Common.cpp:
(JSC::MacroAssemblerX86Common::ProbeContext::dumpCPURegisters):
- assembler/X86Assembler.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86Common.h:
- jit/JITStubsX86_64.h:
- 2:59 PM Changeset in webkit [176094] by
-
- 2 edits in trunk/LayoutTests
Update expected .png for platform/mac/editing/input/devanagari-ligature.html
https://bugs.webkit.org/show_bug.cgi?id=138712
This doesn't actually fix the test, it just updates the image.
Reviewed by Zalan Bujtas.
- platform/mac/editing/input/devanagari-ligature-expected.png:
- 2:51 PM Changeset in webkit [176093] by
-
- 2 edits in trunk/Source/WebKit/mac
WK1: Update icon for Add to Reading List
https://bugs.webkit.org/show_bug.cgi?id=138710
<rdar://problem/18975774>
Reviewed by Beth Dakin.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
Use the right icon, matching WebKit2.
- 2:15 PM WebKitGTK/2.6.x edited by
- Adding a proposed merge for the next stable release (diff)
- 2:14 PM Changeset in webkit [176092] by
-
- 10 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r176086. rdar://problems/18947156
- 2:11 PM Changeset in webkit [176091] by
-
- 5 edits2 adds in trunk
AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
https://bugs.webkit.org/show_bug.cgi?id=137867
Reviewed by Chris Fleizach.
Source/WebCore:
Return ATK_ROLE_INVALID for null or otherwise invalid accessible objects.
Test: platform/gtk/accessibility/detached-object-role.html
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetRole):
Tools:
Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
able to test for the presence of ATK_ROLE_INVALID.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::role):
LayoutTests:
- platform/gtk/accessibility/detached-object-role-expected.txt: Added.
- platform/gtk/accessibility/detached-object-role.html: Added.
- 2:10 PM Changeset in webkit [176090] by
-
- 7 edits in trunk/Source/WebCore
[iOS] update optimized fullscreen media controls artwork
https://bugs.webkit.org/show_bug.cgi?id=138705
Reviewed by Dean Jackson.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::mediaUIImageData): Remove one button.
- Modules/mediacontrols/MediaControlsHost.idl:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.controlsAreHidden): Add parentheses to fix the logic.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.shouldHaveStartPlaybackButton): The big play button should not be
visible during playback.
(ControllerIOS.prototype.createControls): No longer necessary to insert style dynamically,
(ControllerIOS.prototype.setPlaying): Call the base class first so "isPlaying" is set before
calling updateControls, which calls shouldHaveStartPlaybackButton.
- platform/ios/WebCoreSystemInterfaceIOS.h: Update constants.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::mediaControlsStyleSheet): Add button style to the media controls sheet.
- 1:57 PM Changeset in webkit [176089] by
-
- 1 edit1 move in trunk/LayoutTests
Rename ios-sim to ios-sim-deprecated.
The results here are historical and new results should go into ios-simulator
directory. Eventually, we should get rid of this directory completely.
Rubber-stamped by Simon Fraser.
- platform/ios-sim: Removed.
- platform/ios-sim-deprecated: Copied from LayoutTests/platform/ios-sim.
- 1:55 PM Changeset in webkit [176088] by
-
- 2 edits in trunk/Tools
Update the "combineModules" script to handel more LLVM metadata.
https://bugs.webkit.org/show_bug.cgi?id=138514
Patch by Juergen Ributzka <juergen@apple.com> on 2014-11-13
Reviewed by Filip Pizlo.
- ReducedFTL/combineModules.rb:
- 1:54 PM Changeset in webkit [176087] by
-
- 4 edits in trunk/Source/JavaScriptCore
Update WebKit to build with LLVM TOT
https://bugs.webkit.org/show_bug.cgi?id=138519
Patch by Juergen Ributzka <juergen@apple.com> on 2014-11-13
Reviewed by Geoffrey Garen.
- Configurations/LLVMForJSC.xcconfig:
- llvm/LLVMAPIFunctions.h:
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
- 1:18 PM Changeset in webkit [176086] by
-
- 10 edits in trunk/Source/WebKit2
Adjust the WKBundlePageOverlay Data Detectors SPI
https://bugs.webkit.org/show_bug.cgi?id=138685
<rdar://problem/18947156>
Reviewed by Anders Carlsson.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
Forward DDActionContext callbacks to the Web process.
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
- WebProcess/WebPage/WebPageOverlay.cpp:
- WebProcess/WebPage/WebPageOverlay.h:
Add four DataDetectors-related WebKit2-only page overlay callbacks:
(WebKit::WebPageOverlay::actionContextForResultAtPoint):
Called during the action menu hit test; clients can reply with a DDActionContext
and a DOM range, and WebKit will treat that result and range as if it had
detected it itself, building the action menu and showing the yellow highlight as usual.
(WebKit::WebPageOverlay::dataDetectorsPresentedUI):
(WebKit::WebPageOverlay::dataDetectorsChangedUI):
(WebKit::WebPageOverlay::dataDetectorsHidUI):
These correspond to the DDActionContext callbacks, and can be used by clients
to show/hide corresponding UI while DataDetectors in the UI process is presenting UI.
(WebKit::WebPageOverlay::prepareForActionMenu): Deleted.
Get rid of prepareForActionMenu, as nobody ever used it.
- WebProcess/WebPage/WebPage.cpp:
Add WebPageOverlay.h so that we can build, because the destructor lives here.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performActionMenuHitTestAtLocation):
Give all of the WebPageOverlays the first shot at data detection; if none of them
reply with a valid DDActionContext/DOM range, we'll go ahead and do our normal detection.
(WebKit::WebPage::dataDetectorsPresentedUI):
(WebKit::WebPage::dataDetectorsChangedUI):
(WebKit::WebPage::dataDetectorsHidUI):
Forward these along to the active WebPageOverlay.
- 1:16 PM Changeset in webkit [176085] by
-
- 2 edits1 delete in trunk
Remove Source/Platform cruft
https://bugs.webkit.org/show_bug.cgi?id=138658
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- Source/Platform: Removed.
- 1:00 PM Changeset in webkit [176084] by
-
- 8 edits18 adds in trunk
Implement the matching for :nth-last-child(An+B of selector-list)
https://bugs.webkit.org/show_bug.cgi?id=138650
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-13
Reviewed by Andreas Kling.
Source/WebCore:
Matching is trivial based on the existing CSS4 infrastructure.
The tricky part is style invalidation. In the cases of the old :nth-last-child()
and :nth-last-of-type(), we were using the flag ChildrenAffectedByBackwardPositionalRules.
The problem with ChildrenAffectedByBackwardPositionalRules is that it only invalidate
subtrees when nodes are being added or removed. It is a valuable optimization by itself
since tree updates are less common than property updates.
For the case of property updates, I have added the new flag "ChildrenAffectedByPropertyBasedBackwardPositionalRules".
It pretty much work the same way but invalidates subtree on style recalc.
Tests: fast/css/nth-child-and-nth-last-child.html
fast/css/nth-last-child-of-classname.html
fast/css/nth-last-child-of-complex-selector.html
fast/css/nth-last-child-of-compound-selector.html
fast/css/nth-last-child-of-style-sharing-1.html
fast/css/nth-last-child-of-style-sharing-2.html
fast/css/nth-last-child-of-style-update-optimization.html
fast/css/nth-last-child-of-tagname.html
fast/selectors/nth-last-child-of-class-style-update.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- dom/Element.cpp:
(WebCore::Element::setChildrenAffectedByPropertyBasedBackwardPositionalRules):
(WebCore::Element::hasFlagsSetDuringStylingOfChildren):
(WebCore::Element::rareDataChildrenAffectedByPropertyBasedBackwardPositionalRules):
- dom/Element.h:
(WebCore::Element::childrenAffectedByPropertyBasedBackwardPositionalRules):
- dom/ElementRareData.h:
(WebCore::ElementRareData::childrenAffectedByPropertyBasedBackwardPositionalRules):
(WebCore::ElementRareData::setChildrenAffectedByPropertyBasedBackwardPositionalRules):
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::resetDynamicRestyleObservations):
- dom/Node.cpp:
(WebCore::Node::updateAncestorsForStyleRecalc):
(WebCore::Node::setNeedsStyleRecalc):
(WebCore::markAncestorsWithChildNeedsStyleRecalc): Deleted.
- dom/Node.h:
Unlike the other marking steps, ChildrenAffectedByPropertyBasedBackwardPositionalRules can only really
affect one level (because we don't have a parent-selectors). It is quite easy to mark large
trees with ChildrenAffectedByPropertyBasedBackwardPositionalRules by using a selector list that is a bit
too generic. When that happen, we must be careful not invalidating everything, just the affected subtree.
LayoutTests:
- fast/selectors/nth-last-child-of-class-style-update-expected.txt: Added.
- fast/selectors/nth-last-child-of-class-style-update.html: Added.
Verify simple cases of style update.
- fast/css/nth-last-child-of-style-update-optimization-expected.txt: Added.
- fast/css/nth-last-child-of-style-update-optimization.html: Added.
Verify that style invalidation stays reasonable.
- fast/css/nth-last-child-of-style-sharing-1-expected.html: Added.
- fast/css/nth-last-child-of-style-sharing-1.html: Added.
- fast/css/nth-last-child-of-style-sharing-2-expected.html: Added.
- fast/css/nth-last-child-of-style-sharing-2.html: Added.
Check that style sharing is disabled for elements matching :nth-last-child().
- fast/css/nth-child-and-nth-last-child-expected.html: Added.
- fast/css/nth-child-and-nth-last-child.html: Added.
Test uniqueness testing by combining :nth-child() and :nth-last-child().
- fast/css/nth-last-child-of-classname-expected.html: Added.
- fast/css/nth-last-child-of-classname.html: Added.
- fast/css/nth-last-child-of-complex-selector-expected.html: Added.
- fast/css/nth-last-child-of-complex-selector.html: Added.
- fast/css/nth-last-child-of-compound-selector-expected.html: Added.
- fast/css/nth-last-child-of-compound-selector.html: Added.
- fast/css/nth-last-child-of-tagname-expected.html: Added.
- fast/css/nth-last-child-of-tagname.html: Added.
Test matching, those are the "last-child" counterpart of the existing
"nth-child-of" tests.
- 12:43 PM Changeset in webkit [176083] by
-
- 4 edits in trunk/Source/JavaScriptCore
ARMv7(s) Assembler: LDRH with immediate offset is loading from the wrong offset
https://bugs.webkit.org/show_bug.cgi?id=136914
Reviewed by Michael Saboff.
TLDR: the immediate offset of half-word load was divided by 2.
Story time: So I started getting those weird reports of :nth-child() behaving bizarrely
on ARMv7 and ARMv7s. To make things worse, the behavior changes depending on style updates.
I started looking the disassembly on the tests cases...
The first thing I noticed was that the computation of An+B looked wrong. For example,
in the case of n+6, the instruction should have been:
but was
After spending a lot of time trying to find the error in the assembler, I discovered
the problem was not real, but just a bug in the disassembler.
This is the first fix: ARMv7DOpcodeAddSubtractImmediate3's immediate3() was truncating
the value to 2 bits instead of 3 bits.
The disassembler being fixed, I still have no lead on the weird bug. Some disassembly later,
I realize the LDRH instruction is not decoded at all. The reason is that both LDRH and STRH
were under the umbrella ARMv7DOpcodeLoadStoreRegisterImmediateHalfWord but the pattern
only matched SRTH.
I fix that next, ARMv7DOpcodeLoadStoreRegisterImmediateHalfWord is split into
ARMv7DOpcodeStoreRegisterImmediateHalfWord and ARMv7DOpcodeLoadRegisterImmediateHalfWord,
each with their own pattern and their instruction group.
Now that I can see the LDRHs correctly, there is something fishy about them, their offset
is way too small for the data I load.
This time, looking at the binary, the generated code is indeed incorrect. It turns out that
the ARMv7 assembler shifted the offset of half-word load as if they were byte load: divided by 4.
As a result, all the load of half-words with more than zero offset were loading
values with a smaller offset than what they should have.
That being fixed, I dump the assembly: still wrong. I am ready to throw my keyboard through
my screen at that point.
Looking at the disassembler, there is yet again a bug. The computation of the scale() adjustment
of the offset was incorrect for anything but word loads.
I replaced it by a switch-case to make it explicit.
STRH is likely incorrect too. I'll fix that in a follow up, I want to survey all the 16 bits cases
that are not directly used by the CSS JIT.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::ldrh):
Fix the immediate scaling. Add an assertion to make sure the alignment of the input is correct.
- disassembler/ARMv7/ARMv7DOpcode.cpp:
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::scale):
Fix the scaling code. Just hardcode instruction-to-scale table.
- disassembler/ARMv7/ARMv7DOpcode.h:
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::immediate3):
The mask for a 3 bits immediate is not 3 :)
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::scale): Deleted.
- 12:15 PM Changeset in webkit [176082] by
-
- 3 edits2 adds in trunk
REGRESSION (r172826): Password field placeholder text is missing if
placeholder attribute precedes type attribute
<https://bugs.webkit.org/show_bug.cgi?id=138682>
<rdar://problem/18574213>
Source/WebCore:
When the placeholder attribute is encountered, a shadow tree is created
to include the placeholder element. When the type attribute is
encountered, the previous shadow tree is destroyed, and a new shadow
tree is created. TextFieldInputType::createShadowSubtree() did not
handle creating the placeholder element.
This regressed in r172826 because prior to r172826, the placeholder
element would be recreated when
HTMLTextFormControlElement::updatePlaceholderVisibility() was called.
In r172826, updatePlaceholderVisibility() was changed to only show or
hide the placeholder element if it exists.
Reviewed by Benjamin Poulain.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
Call updatePlaceholderVisibility() to insert the placeholder element
(after the inner text element has been inserted, as it appears before
it in the shadow DOM).
LayoutTests:
Reviewed by Benjamin Poulain.
- fast/forms/placeholder-attribute-ordering-expected.html: Added.
- fast/forms/placeholder-attribute-ordering.html: Added.
- 11:57 AM Changeset in webkit [176081] by
-
- 1 edit1 add in trunk/Source/WebInspectorUI
Web Inspector: Replace PDF icon with SVG version
https://bugs.webkit.org/show_bug.cgi?id=137296
Reviewed by Timothy Hatcher.
Add another free icon for the Web Inspector in GTK+.
- UserInterface/Images/gtk/NavigationItemProbes.svg: Added.
- 11:36 AM Changeset in webkit [176080] by
-
- 3 edits1 add1 delete in trunk/Source/WebInspectorUI
Web Inspector: Replace PDF Probes icon with SVG version
https://bugs.webkit.org/show_bug.cgi?id=137296
Reviewed by Joseph Pecoraro.
- UserInterface/Images/NavigationItemProbes.pdf: Removed.
- UserInterface/Images/NavigationItemProbes.svg: Added.
- UserInterface/Views/ProbeDetailsSidebarPanel.js:
(WebInspector.ProbeDetailsSidebarPanel): Use NavigationItemProbes.svg.
- 11:18 AM Changeset in webkit [176079] by
-
- 2 edits in trunk/Source/JavaScriptCore
Generate put_by_id for bracket assignment with constant string subscript.
<https://webkit.org/b/138702>
Reviewed by Geoffrey Garen.
Transform of=x to o.f=x when generating bytecode. This allows our JIT
to inline-cache those accesses instead of always dropping out to C++.
Just like the get_by_id transformations, this gets a bunch of use on
real-web content (and Speedometer) but little/none on raw JS benchmarks.
- bytecompiler/NodesCodegen.cpp:
(JSC::AssignBracketNode::emitBytecode):
- 11:07 AM Changeset in webkit [176078] by
-
- 4 edits in trunk
Allow constructing a base PassRef with a derived Ref
https://bugs.webkit.org/show_bug.cgi?id=138701
Reviewed by Andreas Kling
Source/WTF:
- wtf/PassRef.h:
(WTF::PassRef<T>::PassRef):
Tools:
- TestWebKitAPI/Tests/WTF/Ref.cpp:
(TestWebKitAPI::passWithPassRef):
(TestWebKitAPI::passWithPassRefPtr):
(TestWebKitAPI::TEST):
- 10:57 AM WebKitGTK/2.6.x edited by
- Adding a proposed merge for the next stable release (diff)
- 10:52 AM Changeset in webkit [176077] by
-
- 1 edit1 add in trunk/PerformanceTests
Simple line layout: Add performance test case to measure line layout speed of monolithic text content.
https://bugs.webkit.org/show_bug.cgi?id=138699
Reviewed by Antti Koivisto.
- Layout/line-layout-long-long-text.html: Added.
- 10:20 AM Changeset in webkit [176076] by
-
- 3 edits2 adds in trunk
AX: [ATK] Accessible focus events are emitted when the selection is changed in non-focused combo boxes
https://bugs.webkit.org/show_bug.cgi?id=137866
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Check that the AccessibilityMenuList is really focused before notifying
the platform that it is focused. Likewise, only notify the platform of
an AccessibilityMenuListOption focus gain if the AccessibilityMenuList
containing that option is expanded.
Test: platform/gtk/accessibility/menu-list-unfocused-notifications.html
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange):
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
- platform/gtk/accessibility/menu-list-unfocused-notifications-expected.txt: Added.
- platform/gtk/accessibility/menu-list-unfocused-notifications.html: Added.
- 9:33 AM Changeset in webkit [176075] by
-
- 2 edits in trunk/LayoutTests
Simplify expectations for fullscreen/full-screen-iframe-legacy.html, as the more
specific variant doesn't work due to <https://bugs.webkit.org/show_bug.cgi?id=138698>.
- platform/mac/TestExpectations:
- 9:26 AM Changeset in webkit [176074] by
-
- 2 edits in trunk/LayoutTests
fast/events/overflow-scroll-fake-mouse-move.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=138697
- platform/mac-wk1/TestExpectations: Mark it as such.
- 9:21 AM Changeset in webkit [176073] by
-
- 2 edits in trunk/LayoutTests
Unreviewed WK2 subpixel gardening.
- platform/mac-wk2/TestExpectations:
- 8:43 AM Changeset in webkit [176072] by
-
- 4 edits in trunk/Source/JavaScriptCore
Create canonical lists of registers used by both the Assemblers and the JIT probes.
<https://webkit.org/b/138681>
Reviewed by Filip Pizlo.
- assembler/ARMAssembler.h:
- assembler/ARMv7Assembler.h:
- assembler/X86Assembler.h:
- The FP register storage type is still defined as m128 because the JIT probe code still expects that amount of storage to be available. Will change this to double when the JIT probe code is updated accordingly in a later patch.
- 4:50 AM Changeset in webkit [176071] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] Missing ResourceRequest members encoded/decoded
https://bugs.webkit.org/show_bug.cgi?id=138694
Reviewed by Sergio Villar Senin.
At least timeoutInterval and priority should also be
encoded/decoded. This fixes all http/tests/xmlhttprequest/timeout/
tests when using the network process, since the timeout is always
0 for all requests that we send to the network process.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
- 12:53 AM Changeset in webkit [176070] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Unexpected crashes in layout test after r175953
https://bugs.webkit.org/show_bug.cgi?id=138652
Reviewed by Csaba Osztrogonác.
In r175953, it set reusableNodeIndex value with m_partCache's size(). It causes
out of bound index crash because the reusableNodeIndex is Vector object.
No new test. This patch is to fix broken tests related to widgets on EFL port.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::getThemePartFromCache): Need to set reusableNodeIndex with "size() - 1".
- 12:21 AM Changeset in webkit [176069] by
-
- 6 edits2 adds in trunk
Lazily create HTMLInputElement's inputType and shadow subtree
https://bugs.webkit.org/show_bug.cgi?id=138524
Reviewed by Ryosuke Niwa.
Source/WebCore:
When an HTMLInputElement was created by the parser, we would first call
HTMLInputElement::create(), then call Element::parserSetAttributes() on
the constructed input. With the previous implementation, this was a bit
inefficient because HTMLInputElement::create() would construct a
TextInputType inputType (as this is the default) as well as its
corresponding shadow subtree. Then, parserSetAttributes() would often
set the |type| attribute and would need to destroy this input type as
well as its subtree if the new |type| is not 'text', to create a new
inputType / shadow subtree of the right type. The profiler showed that
this was fairly expensive.
To improve this, this patch delays the inputType / shadow subtree
creation when the HTMLInputElement is constructed by the parser, until
the attributes are actually set by the parser. This way, we directly
create an inputType / shadow subtree of the right type.
I see a 1.4% speed up on speedometer (73.95 -> 75.0).
Test: fast/dom/HTMLInputElement/border-attribute-crash.html
- dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
(WebCore::Element::parserDidSetAttributes):
- dom/Element.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::create):
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::runPostTypeUpdateTasks):
(WebCore::HTMLInputElement::initializeInputType):
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::parserDidSetAttributes):
(WebCore::HTMLInputElement::finishParsingChildren):
- html/HTMLInputElement.h:
LayoutTests:
Add a test case to make sure we don't crash when parsing an <input>
Element that has a |border| attribute as first attribute. This is what
was happening with the first version of this patch that landed in
r175852. When attributeChanged() was called for the |border| attribute
HTMLInputElement::isPresentationAttribute() would get called before
m_inputType is initialized, and "name == borderAttr && isImageButton()"
would crash because isImageButton() dereferences m_inputType.
- fast/dom/HTMLInputElement/border-attribute-crash-expected.txt: Added.
- fast/dom/HTMLInputElement/border-attribute-crash.html: Added.
