Context Navigation

← Previous Period
Next Period →

Timeline

Feb 1, 2002:

9:06 PM Changeset in webkit [586] by kocienda

11 edits in trunk/WebCore

2002-02-01 Kenneth Kocienda <kocienda@apple.com>

More cleanups to the no-copy NSData API.
This time the callback from the cache/loader has been
simplified from:

(void)WKURLHandle:(WKURLHandle *)sender resourceDataDidBecomeAvailable:(UInt8 *)bytes offset:(unsigned)offset length:(unsigned)length; to:
(void)WKURLHandle:(WKURLHandle *)sender resourceDataDidBecomeAvailable:(NSData *)data; This was made possible by some rearrangement in the private API. Changed name of WKByteBlockData to WKData.

include/WCURLHandle.h:
src/kwq/KWQKHTMLPart.mm: (-[KHTMLPartLoadClient WCURLHandle:resourceDataDidBecomeAvailable:userData:]):
src/kwq/KWQKloader.mm: (-[URLLoadClient WCURLHandle:resourceDataDidBecomeAvailable:userData:]):
CacheLoader.subproj/WCURLHandleGlue.m: (-[WCURLHandleClientProxy WKURLHandle:resourceDataDidBecomeAvailable:]):
CacheLoader.subproj/WKURLHandle.m: (-[WKURLHandleSynchronousClient WKURLHandle:resourceDataDidBecomeAvailable:]), (-[WKURLHandle notifyClientsDidLoadData]):
CacheLoader.subproj/WKURLHandleCGlue.h:
CacheLoader.subproj/WKURLHandleCGlue.m: (-[WKURLHandleCGlueClient WKURLHandle:resourceDataDidBecomeAvailable:]):
CacheLoader.subproj/WKURLHandleClient.h:
Misc.subproj/WKMutableDataPrivate.h:
Misc.subproj/WKMutableDataPrivate.m: (-[WKMutableData dataObjectsGreaterThanMatchedOffset:]), (+[WKData dataWithByteBlock:]), (-[WKData subdataWithRange:]):

5:58 PM Changeset in webkit [585] by cblu

17 edits in trunk

Enabled plug-in detection for Javascript. Apple.com now works as it should. Also fixed plug-in deallocation

5:36 PM Changeset in webkit [584] by rjw

3 edits in trunk/WebKit/WebView.subproj

Implemenation of locationChangeDone:forDataSource;

5:28 PM Changeset in webkit [583] by rjw

25 edits in trunk

Changes for dynamic scrolling views (not complete).
Added simple support for WKLocationChangeHandler so Alexander will diplsay
page when load is done.

1:56 PM Changeset in webkit [582] by rjw

1 edit
6 adds in trunk/WebKit

Added files from WebBrowser`

11:02 AM Changeset in webkit [581] by sullivan

8 edits in trunk/WebKit

Added call to examine the entry at the current index in
the back/forward list without modifying the list. I needed
this to save context data (in my case, scroll position)
on the currently-viewed entry.

History.subproj/WKBackForwardList.h:
History.subproj/WKBackForwardList.m: (-[WKBackForwardList currentEntry]): Just returns the entry at the current index.

Added useful mechanism and hideous hack for using remembered scroll positions
with the back/forward list. There's no way to do this cleanly at this level;
we have to get WebKit involved. Most of this code is fine though, only the
restoring part should have to be redone.

BackForwardListEntry.h:
BackForwardListEntry.m: (+[BackForwardListEntry entryWithURL:]), (-[BackForwardListEntry scrollPoint]), (-[BackForwardListEntry setScrollPoint:]): New subclass of WKURIEntry; remembers a scroll point with each entry, and adds a convenience constructor. Some or all of this may move into WebKit later.

BrowserDocument.m: (-[BrowserDocument saveScrollPosition]): New method, reads the current scroll position from the view and stores it into the current back/forward list entry.

(-[BrowserDocument restoreScrollPosition]):
New method, reads the previously-saved scroll position from the current
back/forward list entry and scrolls the view to match.

(-[BrowserDocument restoreScrollPositionFromTimerHack:]),
(-[BrowserDocument restoreScrollPositionLaterHack]):
Timer-based hackery to wait a little while before calling restoreScrollPosition
since calling it before the new page has loaded has no effect. This will have
to be replaced with a WebKit-based mechanism for telling the webView what the
incoming page's initial scroll point should be.

(-[BrowserDocument goToURLBypassingBackForwardList:]),
(-[BrowserDocument goToURL:]),
(-[BrowserDocument goBack]),
(-[BrowserDocument goForward]):
Call the save/restore methods at the right places.

WebBrowser.pbproj/project.pbxproj: Updated for new files

9:14 AM Changeset in webkit [580] by kocienda

8 edits in trunk/WebCore

2002-02-01 Kenneth Kocienda <kocienda@apple.com>

At Richard's urging, I made some changes to the API of WKMutableData. I cleaned
up the API, and hid the extra no-copy functionality so that it is not visible
outside of this framework. Everything should be functionally equivalent with
these changes.

CacheLoader.subproj/WKURLHandle.m: (-[WKURLHandle notifyClientsDidLoadData]):
Misc.subproj/WKMutableDataPrivate.h:
Misc.subproj/WKMutableDataPrivate.m: (WKDataCheckBound), (-[WKMutableData dataObjectsGreaterThanMatchedOffset:]), (+[WKByteBlockData dataWithByteBlock:]), (-[WKByteBlockData initWithByteBlock:]), (-[WKByteBlockData length]), (-[WKByteBlockData getBytes:]), (-[WKByteBlockData getBytes:length:]), (-[WKByteBlockData getBytes:range:]), (-[WKByteBlockData subdataWithRange:]), (-[WKByteBlockData copyWithZone:]), (-[WKByteBlockData dealloc]):

Made some cleanups to the no-copy NSData API, and those changes
make the use of the no-copy functionality in this client code
much cleaner.

include/WCURLHandle.h:
src/kwq/KWQKloader.mm: (-[URLLoadClient WCURLHandle:resourceDataDidBecomeAvailable:offset:length:userData:]):

Jan 31, 2002:

7:12 PM Changeset in webkit [579] by rjw

11 edits in trunk/WebCore

Added QString constructor, fixed javascript at head of document bug.

6:02 PM Changeset in webkit [578] by sullivan

5 edits in trunk/WebKit

History.subproj/WKURIList.m: (newURIListNode): retain entries before adding them to list. The node-freeing routine was releasing, but the node-adding routine wasn't retaining. Bad asymmetry, made up for by WebViewTest not autoreleasing. I fixed that too.

Tests/khtmlview/_KWQOwner.m: (-[_KWQOwner newUriDone:]): autorelease new WKURIEntry before handing it to WKBackForwardList.

Implemented simple back/forward, using the existing back/forward code that
WebViewTest was using (after fixing an object lifetime bug there). Also
cleaned up viewSource stuff a little.

BrowserDocument.h: Added declarations for canGoBack, canGoForward, goBack, goForward; changed webController to _webController; added _backForwardList.

BrowserDocument.m: (-[BrowserDocument currentURL]), (-[BrowserDocument setCurrentURL:]), (-[BrowserDocument setMainWebView:]), (-[BrowserDocument setUpSearchChannels]), (-[BrowserDocument searchChannels]): Just updated for instance variable name changes and/or moved around.

(-[BrowserDocument init]): Make a back/forward list
(-[BrowserDocument dealloc]): Nuke a back/forward list

(-[BrowserDocument goToURLBypassingBackForwardList:]): New method, contains
the code that used to be goToURL

(-[BrowserDocument goToURL:]): Now calls goToURLBypassingBackForwardList and
then adds an entry to the back/forward list.

(-[BrowserDocument canGoBack]),
(-[BrowserDocument canGoForward]),
(-[BrowserDocument goBack]),
(-[BrowserDocument goForward]): New methods, implement back/forward list by
calling methods on WKBackForwardList

(-[BrowserDocument openNewTextEditDocumentWithString:]): New helper method, contains
former guts of viewSource and viewReconstructedSource.
(-[BrowserDocument viewSource:]),
(-[BrowserDocument viewReconstructedSource:]): Call openNewTextEditDocumentWithString.

BrowserWindow.h: Added declaration for viewReconstructedSource

BrowserWindow.m: (-[BrowserWindow goBack:]), (-[BrowserWindow goForward:]): Call BrowserDocument methods.

(-[BrowserWindow isShowingSearchResults:]): Fixed bug where it would return YES
if there was no URL at all displayed.

(-[BrowserWindow validateToolbarItem:]): Call [[self document] canGoBack] instead
of [self canGoBack], same for forward.

(-[BrowserWindow validateMenuItem:]): add test for viewReconstructedSource. Make
both viewSource and viewReconstructedSource enabled only if currentURL is not nil.

(-[BrowserWindow viewReconstructedSource:]): removed casts made unnecessary by adding
the declaration to the header file.

5:40 PM Changeset in webkit [577] by rjw

8 edits in trunk/WebCore

Fixed javascript at head of document problem.

4:37 PM Changeset in webkit [576] by sullivan

3 edits in trunk/WebKit

WebKit.pbproj: Removed -O0, so it will now get all the same warnings as pbxbuild gets.

4:28 PM Changeset in webkit [575] by kocienda

14 edits in trunk/WebKit

2002-01-31 Kenneth Kocienda <kocienda@apple.com>

Removed dependency on WC versions of these files

History.subproj/WKBackForwardList.h:
History.subproj/WKBackForwardList.m:
History.subproj/WKURIEntry.h:
History.subproj/WKURIEntry.m:
WebKit.pbproj/project.pbxproj:

A set of in-progress changes. The new code here is not in a current code path,
but I'm checking in to make sure that some changes I made in WebKit work
with something I was able to test.

CacheLoader.subproj/WKURLHandle.m: (-[WKURLHandle notifyClientsDidLoadData]):
Misc.subproj/WKMutableData.h:
Misc.subproj/WKMutableData.m: (-[WKMutableData copyWithZone:]), (-[WKMutableData initWithBytes:length:copy:freeWhenDone:bytesAreVM:]):
WebFoundation.pbproj/project.pbxproj:

Removed dependency on WC classes backed by WebKit classes.

Tests/khtmlview/_KWQOwner.h:
Tests/khtmlview/_KWQOwner.m: (-[_KWQOwner changeURL:]), (-[_KWQOwner back:]), (-[_KWQOwner forward:]), (-[_KWQOwner newUriDone:]):

4:13 PM Changeset in webkit [574] by sullivan

3 edits in trunk/WebKit

WebKit.pbproj: Marked WKURIList.h as a public header

4:11 PM Changeset in webkit [573] by rjw

8 edits in trunk/WebKit

Added document source.

4:11 PM Changeset in webkit [572] by rjw

9 edits in trunk/WebCore

Added document source .

3:23 PM Changeset in webkit [571] by cblu

6 edits in trunk/WebCore

Added support for hidden plug-ins. Added focus events

1:28 PM Changeset in webkit [570] by kocienda

11 edits in trunk/WebCore

2002-01-31 Kenneth Kocienda <kocienda@apple.com>

Created a no-copy version of NSData (WKMutableData) that will minimize the amount of data copying.
Removed obsoleted WKURLData class
Incorporated use of the no-copy NSData object.

CacheLoader.subproj/WKHTTPURLProtocolHandler.m: (-[WKHTTPURLProtocolHandler performStreamRead:]):
CacheLoader.subproj/WKURLData.h:
CacheLoader.subproj/WKURLData.m:
CacheLoader.subproj/WKURLHandle.h:
Misc.subproj/WKMutableData.h:
Misc.subproj/WKMutableData.m: (+[WKByteBlock byteBlockWithBytes:length:]), (-[WKByteBlock initWithBytes:length:]), (-[WKByteBlock bytes]), (-[WKByteBlock length]), (-[WKByteBlock byteLength]), (-[WKByteBlock dealloc]), (+[WKByteRange rangeWithRange:]), (-[WKByteRange initWithRange:]), (-[WKByteRange range]), (-[WKByteRange isEqual:]), (-[WKByteRange hash]), (-[WKByteRange copyWithZone:]), (-[WKMutableData createBlockForRange:buffer:]), (-[WKMutableData length]), (-[WKMutableData bytes]), (-[WKMutableData byteBlocksForRange:]), (-[WKMutableData bytesInRange:]), (-[WKMutableData getBytes:]), (-[WKMutableData getBytes:length:]), (-[WKMutableData getBytes:range:]), (-[WKMutableData subdataWithRange:]), (-[WKMutableData initWithBytes:length:copy:freeWhenDone:bytesAreVM:]), (-[WKMutableData appendBytes:length:]), (-[WKMutableData dealloc]):
WebFoundation.pbproj/project.pbxproj:

Changes to incorporate use of the no-copy NSData object.

include/WCURLHandle.h:
src/kwq/KWQKHTMLPart.mm: (-[KHTMLPartLoadClient WCURLHandle:resourceDataDidBecomeAvailable:offset:length:userData:]):
src/kwq/KWQKloader.mm: (-[URLLoadClient WCURLHandle:resourceDataDidBecomeAvailable:offset:length:userData:]):