Timeline



Apr 4, 2002:

10:56 PM Changeset in webkit [971] by rjw
  • 3 edits in trunk/WebKit

Clear controller references from data source and view, as well as
frame.

7:07 PM Changeset in webkit [970] by rjw
  • 11 edits in trunk

Lazily dealloc controller and data source ONLY after all loads
have completed.

Extra bulletproofing to prevent script execution when in partially
dealloced state.

Guarantee that browser document isn't dangling after
deallocing the WebController.

5:15 PM Changeset in webkit [969] by cblu
  • 9 edits in trunk/WebCore

2002-04-04 Chris Blumenberg <​cblu@apple.com>

  • src/kwq/WCPlugin.mm: (-[WCPlugin load]):
  • src/kwq/npapi.h:
  • src/kwq/npapi.mm: (NPN_GetJavaEnv), (NPN_GetJavaPeer):

Added stubs for NPN_GetJavaEnv and NPN_GetJavaPeer. This fixes a flash crasher.

4:27 PM Changeset in webkit [968] by cblu
  • 7 edits in trunk/WebCore

2002-04-04 Chris Blumenberg <​cblu@apple.com>

  • src/kdelibs/khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
  • src/kwq/WCPluginWidget.mm: (WCPluginWidget::WCPluginWidget):

Moved the removal of KHTML EMBED attributes to WCPluginWidget. One less APPLE_CHANGES.

3:31 PM Changeset in webkit [967] by kocienda
  • 9 edits
    1 add in trunk/WebKit

2002-04-04 Kenneth Kocienda <​kocienda@apple.com>

Hack to handle displaying image URLs. The trick is to sense when
the main URL is an image type and wrap the URL in a small generated
HTML document and hand that off to the engine to display.

Works like a charm! :)

There may be some longer-term issues, but for now, this lets us
do something we could not before. It also lets us handle some iframes
that contain only image URLs.

  • Resources/image_document_template.html: Added.
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (loadImageDocumentTemplate), (-[IFMainURLHandleClient initWithDataSource:part:]), (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
2:50 PM Changeset in webkit [966] by cblu
  • 10 edits in trunk/WebKit

2002-04-04 Chris Blumenberg <​cblu@apple.com>

  • English.lproj/IFError.strings:
  • Misc.subproj/IFError.h:
  • Misc.subproj/IFError.m: (+[IFError initialize]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):

Added the IFNonHTMLContentNotSupportedError to IFError.

11:41 AM Changeset in webkit [965] by darin
  • 11 edits in trunk/WebCore

Redo clobbered fixes for problems that show up only when xNDEBUG is set

  • src/kwq/KWQApplication.mm: (QApplication::sendEvent):
  • src/kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandleResourceDidBeginLoading:]): Remove or ifdef otherwise-unused variables.
  • src/kwq/KWQFontMetrics.mm: (_rectForString): Add missing semicolons.
11:10 AM Changeset in webkit [964] by darin
  • 5 edits in trunk/WebCore
  • src/kwq/KWQString.mm: (QString::unicode), (QString::latin1), (QString::convertToQCString): Remove some excessive logging that was getting in the way of important log messages.
10:38 AM Changeset in webkit [963] by rjw
  • 8 edits in trunk/WebKit

Tuned and re-enabled resource layouts.

8:09 AM Changeset in webkit [962] by darin
  • 7 edits in trunk
  • configure.in: Replace the --disable/enable-debug with the new --with-build-style option that Maciej added.

Use --with-build-style=Development for development. You can also
use --with-build-style=Deployment for timings and official builds
and --with-build-style=Unoptimized for debugging.

Main Project Builder projects:

Add an Unoptimized build style: exactly like Development except without the -O.

7:52 AM Changeset in webkit [961] by darin
  • 3 edits in trunk/WebCore

Somehow this log entry didn't get in.

Apr 3, 2002:

6:05 PM Changeset in webkit [960] by rjw
  • 13 edits in trunk/WebKit

Changed name of finalURL to redirectedURL.
Disabled layout after resource load. It appears to really slow us down.

4:54 PM Changeset in webkit [959] by rjw
  • 28 edits in trunk

Added support for finalURL in data source.
Added support for finalURL and wasRedirected to datasource.
Added additional layouts on resource loads.
Added more implementations of frame related methods in data source.

3:57 PM Changeset in webkit [958] by darin
  • 5 edits
    2 adds in trunk/WebCore
  • src/Makefile.am: Concatenate libwebcore.exp and libwebcoretests.exp.
  • src/libwebcore.exp: Update with exports that are needed when inlining is turned off.
  • src/libwebcoretests.exp: Added. Exports that we need to run the test in the Tests directory.
  • .cvsignore: Ignore the concatenated file.
2:17 PM Changeset in webkit [957] by darin
  • 7 edits in trunk/WebCore
  • acconfig.h: Remove a bunch of unused stuff.
  • configure.in: Remove a bunch of unused stuff. Pass "" for the strip flags rather than "-x" for debug case so we don't do any stripping at all and have symbols.

WebCore:

  • src/Makefile.am: Don't strip at all if STRIP_FLAGS are empty.
  • src/kwq/qt/qtextcodec.h: Remove stray undef.
1:05 PM Changeset in webkit [956] by kocienda
  • 59 edits in trunk

2002-04-03 Kenneth Kocienda <​kocienda@apple.com>

WebBrowser:

Updated debugging log messages to use new varargs macros.

  • ActivityViewer.m: (-[ActivityViewer showActivity:]):
  • AppController.m: (-[AppController _computeHistoryFilePath]), (-[AppController updateHistoryInMenu]):
  • BrowserDocument.m: (-[BrowserDocument _saveScrollPosition]), (-[BrowserDocument _restoreScrollPosition]), (-[BrowserDocument locationChangeStartedForFrame:]), (-[BrowserDocument locationChangeCommittedForFrame:]), (-[BrowserDocument locationChangeDone:forFrame:]):
  • Debug/DebugUtilities.m: (+[DebugUtilities loadDebugBookmarks:]):
  • LoadProgressEntry.m: (-[LoadProgressEntry status]):
  • WebBrowser.pbproj/project.pbxproj:

WebCore:

Updated debugging log messages to use new varargs macros.

  • src/kwq/KWQApplication.mm: (QApplication::sendEvent), (QApplication::_initialize):
  • src/kwq/KWQColor.mm: (QColor::setNamedColor):
  • src/kwq/KWQComboBox.mm: (QComboBox::setCurrentItem):
  • src/kwq/KWQFont.mm: (QFont::getFont):
  • src/kwq/KWQFontMetrics.mm: (-[KWQLayoutInfo _initializeCaches]), (_rectForString):
  • src/kwq/KWQKHTMLPart.mm: (recursive), (KHTMLPart::write), (KHTMLPart::end), (KHTMLPart::nodeActivated):
  • src/kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandleResourceDidBeginLoading:]), (-[URLLoadClient IFURLHandleResourceDidCancelLoading:]), (-[URLLoadClient IFURLHandleResourceDidFinishLoading:data:]), (-[URLLoadClient IFURLHandle:resourceDataDidBecomeAvailable:]), (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]), (-[URLLoadClient IFURLHandle:didRedirectToURL:]), (Loader::servePendingRequests):
  • src/kwq/KWQObject.mm: (QObject::connect), (QObject::performAction):
  • src/kwq/KWQScrollView.mm: (QScrollView::addChild), (QScrollView::resizeContents), (QScrollView::updateContents), (QScrollView::repaintContents):
  • src/kwq/KWQString.mm: (QString::unicode), (QString::latin1):
  • src/kwq/KWQView.mm: (-[KWQHTMLView notificationReceived:]), (-[KWQHTMLView layout]), (-[KWQHTMLView drawRect:]), (-[KWQHTMLView resetView]), (-[KWQHTMLView mouseDragged:]):
  • src/kwq/KWQWidget.mm: (QWidget::resize), (QWidget::move):
  • src/kwq/WCPlugin.mm: (-[WCPlugin initializeWithPath:]), (-[WCPlugin load]):
  • src/kwq/WCPluginDatabase.mm: (findPlugins):
  • src/kwq/kwqdebug.h:
  • src/kwq/kwqdebug.mm: (timestamp), (KWQLog):

WebFoundation:

Updated debugging log messages to use new varargs macros.

  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Updated debugging log messages to use new varargs macros.

  • History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate removeEntryForURLString:]), (-[IFWebHistoryPrivate _loadHistoryGuts:]), (-[IFWebHistoryPrivate loadHistory]), (-[IFWebHistoryPrivate _saveHistoryGuts:]), (-[IFWebHistoryPrivate saveHistory]):
  • Misc.subproj/WebKitDebug.h:
  • Misc.subproj/WebKitDebug.m: (timestamp), (WebKitLog):
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]), (-[IFPluginView setWindow]), (-[IFPluginView newStream:mimeType:notifyData:]), (-[IFPluginView IFURLHandle:resourceDataDidBecomeAvailable:]), (-[IFPluginView IFURLHandleResourceDidFinishLoading:data:]), (-[IFPluginView becomeFirstResponder]), (-[IFPluginView resignFirstResponder]), (-[IFPluginView sendUpdateEvent]), (-[IFPluginView mouseDown:]), (-[IFPluginView mouseUp:]), (-[IFPluginView mouseEntered:]), (-[IFPluginView mouseExited:]), (-[IFPluginView keyUp:]), (-[IFPluginView keyDown:]), (-[IFPluginView getURLNotify:target:notifyData:]), (-[IFPluginView getURL:target:]), (-[IFPluginView status:]), (-[IFPluginView stop]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFBaseWebControllerPrivate.mm: (-[IFBaseWebController _receivedProgress:forResource:fromDataSource:]), (-[IFBaseWebController _mainReceivedProgress:forResource:fromDataSource:]):
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]), (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]), (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]), (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]), (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]), (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource isLoading]):
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _stopLoading]):
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToLayoutAcceptable]), (-[IFWebFrame _timedLayout:]), (-[IFWebFrame _setState:]), (-[IFWebFrame _isLoadComplete]):
  • WebView.subproj/IFWebView.mm: (-[IFWebView reapplyStyles]), (-[IFWebView layout]), (-[IFWebView setNeedsDisplay:]), (-[IFWebView setNeedsLayout:]), (-[IFWebView setNeedsToApplyStyles:]), (-[IFWebView drawRect:]):
11:41 AM Changeset in webkit [955] by darin
  • 18 edits in trunk/WebCore

Fix problems that show up only when xNDEBUG is set.

  • src/kwq/KWQApplication.mm: (QApplication::sendEvent):
  • src/kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandleResourceDidBeginLoading:]):
  • src/kwq/KWQView.mm: (-[KWQHTMLView layout]), (-[KWQHTMLView drawRect:]): Remove or ifdef otherwise-unused variables.
  • src/kwq/KWQFontMetrics.mm: (_rectForString):
  • src/kwq/KWQPainter.mm: (QPainter::setRasterOp), (QPainter::translate), (QPainter::scale): Add missing semicolons.
  • src/kwq/KWQKHTMLPart.mm: (KHTMLPart::begin): Fix an ifdef.
10:43 AM Changeset in webkit [954] by darin
  • 4 edits
    2 adds in trunk/WebCore
  • configure.in: Set up STRIP_FLAGS for use when building libwebcore.dylib. For debug mode, we'll use "-x", and for deployment mode we'll use "-x -S".
  • Tests/kde/Makefile.am:
  • Tests/qt/Makefile.am: Link with the unstripped libwebcore, since we need to call unexported functions to do our testing.

WebCore:

  • src/Makefile.am: Use nmedit and strip to remove the symbols we don't want to export.
  • src/libwebcore.exp: Added. List of symbols exported.
10:40 AM Changeset in webkit [953] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/Makefile.am: Gratuitous cleanup.
9:58 AM Changeset in webkit [952] by mjs
  • 4 edits in trunk/WebCore
  • src/Makefile.am: Pave the way for cutting down the exports list. Also, make the embed target when installing libwebcore.
7:17 AM Changeset in webkit [951]
  • 1 copy
    33 deletes in tags/WebFoundation-3

This commit was manufactured by cvs2svn to create tag
'WebFoundation-3'.

7:17 AM Changeset in webkit [950] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-04-03 Ken Kocienda <​kocienda@apple.com>

Labyrinth:

Updated tests to handle new WebFoundation logging output.

  • Tests/WebFoundation-CacheLoader/never-expires-test:
  • Tests/WebFoundation-CacheLoader/never-expires-test.chk:

WebFoundation:

Many logging changes.

  • Removed all DEBUG1, DEBUG2, ... variants, and replaced with a single macro that relies on cpp varargs (a new cpp feature that landed recently)
  • Updated log messages to be more consistent. Messages now log a time, and the string [WEBFOUNDATION] by default.
  • Touched all debugging calls to clean them up and bring them into line with the new conventions.
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (+[IFHTTPURLProtocolHandler parseHTTPDateString:]), (-[IFHTTPURLProtocolHandler createHTTPRequest]), (-[IFHTTPURLProtocolHandler performHTTPHeaderRead:]), (-[IFHTTPURLProtocolHandler setResponseHeaders:]), (-[IFHTTPURLProtocolHandler determineError]), (-[IFHTTPURLProtocolHandler willReturnCacheObject:]), (-[IFHTTPURLProtocolHandler cacheObjectIsValid:]), (-[IFHTTPURLProtocolHandler cacheObjectRequiresRevalidation:]), (-[IFHTTPURLProtocolHandler shouldCacheResourceData]):
  • CacheLoader.subproj/IFURLCacheLoaderConstantsPrivate.h:
  • CacheLoader.subproj/IFURLDiskCache.m: (-[IFURLDiskCache objectForURL:]), (-[IFURLDiskCache invalidateURL:]), (-[IFURLDiskCache clearCache]), (-[IFURLDiskCache syncCache]):
  • CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandle notifyClientsBackgroundLoadCancelled]), (-[IFURLHandle notifyClientsBackgroundLoadDidBegin]), (-[IFURLHandle notifyClientsDidLoadData]), (-[IFURLHandle notifyClientsBackgroundLoadComplete]), (-[IFURLHandle notifyClientsBackgroundLoadFailed]), (-[IFURLHandle notifyClientsURLRedirected]):
  • CacheLoader.subproj/IFURLLoad.m: (-[IFURLLoad succeeded]), (-[IFURLLoad didBeginLoading:]), (+[IFURLLoad IFURLLoadCacheCheckerRun:]), (_loadSweeper):
  • CacheLoader.subproj/IFURLMemoryCache.m: (-[IFURLMemoryCache truncateToSizeLimit]), (-[IFURLMemoryCache objectForURL:]):
  • Database.subproj/IFNDBMDatabase.m: (-[IFNDBMDatabase objectForKey:]):
  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileReader initWithPath:]), (-[IFURLFileDatabase removeAllObjects]), (-[IFURLFileDatabase objectForKey:]), (-[IFURLFileDatabase performSetObject:forKey:]), (-[IFURLFileDatabase performRemoveObjectForKey:]):
  • Misc.subproj/WebFoundationDebug.h:
  • Misc.subproj/WebFoundationDebug.m: (WebFoundationDebugAtLevel):
6:33 AM Changeset in webkit [949] by mjs
  • 8 edits in trunk/WebCore

Fixed Radar 2893361 (Two frames with same name cause memory
trasher (likely double-free)) by implementing the mechanism KDE
uses to guarantee unique frame names.

  • src/kwq/KWQKHTMLPart.mm: (KHTMLPart::frameExists): Actually implement this, so that the khtml code can guarantee unique frame names on each page.
  • src/kwq/external.h: Prototype IFWebDataSource's frameExists: method here.
5:35 AM Changeset in webkit [948] by mjs
  • 5 edits in trunk/WebCore

Top level:

  • Tests/kde/kurl-test.chk, Tests/kde/kurl-test.cpp: Added test cases to check that Radar 2893298 (KURL rejects spaces and other illegal but unambiguous characters, leading to load failures) is fixed.

WebCore:

Fixed Radar 2893298 (KURL rejects spaces and other illegal but
unambiguous characters, leading to load failures).

  • src/kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::makeRef, KURL::normalizeRelativeURLString): Escape forbidden characters (ones that are never legal in a URL), except '#' (since that can start a fragment identifier) and '%' (since that can be the start of a valid escape sequence).

(KURL::KWQKURLPrivate::KWQKURLPrivate,
KURL::KWQKURLPrivate::compose): out of paranoia, make sure urlRef
is set to NULL if not a valid value.

5:27 AM Changeset in webkit [947] by mjs
  • 5 edits in trunk/WebCore
  • src/kwq/kwqdebug.mm: (KWQGetLogLevel): Allocate and release NSScanner instead of using an autoreleased one, to fix Jersey redness whereby the regression tests leak.

Apr 2, 2002:

10:08 PM Changeset in webkit [946] by darin
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m:
  • CacheLoader.subproj/IFMutableData.m:
  • CacheLoader.subproj/IFMutableDataPrivate.m:
  • CacheLoader.subproj/IFURLDiskCache.m:
  • CacheLoader.subproj/IFURLHandle.m:
  • CacheLoader.subproj/IFURLHandleCGlue.m:
  • CacheLoader.subproj/IFURLLoad.m:
  • CacheLoader.subproj/IFURLMemoryCache.m:
  • Database.subproj/IFURLFileDatabase.m:
  • Database.subproj/IFNDBMDatabase.m:
  • Misc.subproj/IFLockFile.m: Add the newlines I omitted in my previous commits.
9:17 PM Changeset in webkit [945] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setTitle:]): Update title if the page is already in the committed state.
6:50 PM Changeset in webkit [944] by darin
  • 48 edits in trunk

WebFoundation:

  • WebFoundation.pbproj/project.pbxproj: Update warning flags, add -DAPPLE_CHANGES, make sure we don't get debugging symbols in non-debug builds.
  • Misc.subproj/WebFoundationDebug.h: Get rid of the log variants.
  • Misc.subproj/WebFoundationDebug.m: Get rid of the log variants.
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m:
  • CacheLoader.subproj/IFURLDiskCache.m:
  • CacheLoader.subproj/IFURLHandle.m:
  • CacheLoader.subproj/IFURLLoad.m::
  • CacheLoader.subproj/IFURLMemoryCache.m: Wean from the NSLog variants so they get printf type checking.

JavaScriptCore:

  • JavaScriptCore.pbproj/project.pbxproj: Update flags as I did for WebFoundation.

WebCore:

  • src/kwq/kwqdebug.h: Turn off logging when xNDEBUG is defined. Remove unused stuff. Add checking for printf parameters.
  • src/kwq/kwqdebug.mm: Remove unused variants.
  • src/kwq/KWQApplication.mm:
  • src/kwq/KWQKGlobal.mm:
  • src/kwq/KWQKloader.mm:
  • src/kwq/KWQObject.mm:
  • src/kwq/KWQString.mm:
  • src/kwq/KWQToolTip.mm:
  • src/kwq/KWQWidget.mm:
  • src/kwq/WCPlugin.mm:
  • src/kwq/WCPluginDatabase.mm:
  • src/kwq/npapi.mm: Fix types in log statements caught by the compiler.

WebKit:

  • WebKit.pbproj/project.pbxproj: Fix flags as I did in WebFoundation.
  • Misc.subproj/WebKitDebug.h: Turn off logging when xNDEBUG is defined. Remove unused stuff. Add checking for printf parameters.
  • Misc.subproj/WebKitDebug.m: Remove unused variants.
  • Plugins.subproj/IFPluginView.mm: Change to use WebKit logging, not WebCore logging.
  • WebView.subproj/IFMainURLHandleClient.mm:
  • WebView.subproj/IFWebView.mm: Fix types in log statements caught by the compiler.

WebBrowser:

  • WebBrowser.pbproj/project.pbxproj: Update flags as I did for WebFoundation.
3:34 PM Changeset in webkit [943] by darin
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Changes to get rid of logging from our non-development builds. We now define
xNDEBUG (will be NDEBUG some day if we can resolve the precompiled header issue)
for any non-development builds, and compile out logging code for those.

  • CacheLoader.subproj/IFURLCacheLoaderConstantsPrivate.h: Update comment.
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m:
  • CacheLoader.subproj/IFURLDiskCache.m:
  • CacheLoader.subproj/IFURLHandle.m:
  • CacheLoader.subproj/IFURLLoad.m:
  • CacheLoader.subproj/IFURLMemoryCache.m: Change callers to use macros instead of doing their own ifdefs in most cases. In the other cases, use an ifdef on xNDEBUG.
  • Misc.subproj/WebFoundationDebug.h: Put in empty definitions for the xNDEBUG case. Also make macros for logging, not just debugging.
  • Misc.subproj/WebFoundationDebug.m: Don't compile any of this when xNDEBUG is set.
  • WebFoundation.pbproj/project.pbxproj: Remove the unused build style. Make the default build style set xNDEBUG using DEBUG_CFLAGS. Move our warning flags into WARNING_CFLAGS. Make the Development style override DEBUG_CFLAGS. Some other minor build setting cleanups.
3:01 PM Changeset in webkit [942]
  • 1 copy
    2 deletes in tags/JavaScriptCore-2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-2'.

3:01 PM Changeset in webkit [941] by mjs
  • 5 edits in trunk/JavaScriptCore
  • JavaScriptCore.pbproj/project.pbxproj: Pass -Wno-format-y2k so the project builds with gcc3.
  • kjs/nodes.cpp: Avoid including an obsolete header to avoid warning with gcc3.
2:39 PM Changeset in webkit [940] by cblu
  • 7 edits in trunk/WebKit

2002-04-02 Chris Blumenberg <​cblu@apple.com>

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView IFURLHandleResourceDidCancelLoading:]), (-[IFPluginView IFURLHandle:resourceDidFailLoadingWithResult:]), (-[IFPluginView IFURLHandle:didRedirectToURL:]):

Added support for the above callbacks.

  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):

Return an error if non-html is requested.

2:08 PM Changeset in webkit [939] by rjw
  • 5 edits in trunk/WebCore

Fixed a fix, shoulda' been a #ifndef to exclude unnecessary code.

12:47 PM Changeset in webkit [938]
  • 19 copies in tags/ALEXANDER_0_2_PRE_7

This commit was manufactured by cvs2svn to create tag
'ALEXANDER_0_2_PRE_7'.

12:47 PM Changeset in webkit [937] by rjw
  • 10 edits in trunk

More noisy bulletproofing. Still need to find source of problem.

More relaxed about invalid states.

11:36 AM Changeset in webkit [936] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/property_map.cpp: (PropertyMap::~PropertyMap): Deallocate the map by calling clear so we don't leak the entire map.
11:35 AM Changeset in webkit [935] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setTitle:]): Fix a leak I introduced here by copying the string in a better way.
11:34 AM Changeset in webkit [934] by darin
  • 7 edits in trunk/WebCore

Fix some small storage leaks.

  • src/kwq/KWQWidget.mm: (QWidget::QWidget): Use a single shared default style instead of creating a new one for each widget. (QWidget::setFont): Since we store a QFont here, we don't have to delete the old font and we don't leak. (QWidget::setCursor): Since now store a QCursor here, we don't have to delete the old cursor. Also removed a lot of unused code in here.
  • src/kwq/KWQKURL.mm: Minor code cleanup.
11:01 AM Changeset in webkit [933] by rjw
  • 8 edits in trunk/WebCore

Added ref() of part from KHTMView.
Added log to catch m_doc == 0 case. Should never happen.

9:37 AM Changeset in webkit [932] by rjw
  • 5 edits in trunk/WebCore

Removed unnecessary and erroneous call to CGContextSetCharacterSpacing.

9:20 AM Changeset in webkit [931] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/internal.cpp: (InterpreterImp::globalClear): Add code to deallocate and null out emptyList, because once the last interpreter is destroyed there's nothing to keep it from being garbage collected.

Apr 1, 2002:

11:16 PM Changeset in webkit [930] by mjs
  • 6 edits in trunk/WebCore
  • src/kwq/KWQKHTMLPart.mm (KHTMLPartPrivate::~KHTMLPartPrivate): Delete the jScript interpreter if it exists, to avoid leaking it. Also, garbage collect in this case because when we destroy the interpreter a lot of objects will become garbage and this seems like a good time to clean it all up.
10:01 PM Changeset in webkit [929] by rjw
  • 5 edits in trunk/WebCore

Added log to catch more problems with NS/CFURL.

9:17 PM Changeset in webkit [928] by rjw
  • 27 edits in trunk

Cleaned up lots of potentially stale references to controller.
Added ref count to part.

7:32 PM Changeset in webkit [927] by rjw
  • 22 edits in trunk

i Logging changes.

Changes to support correct i/frame behavior.

Changes to support correct behavior is i/frame margins and
scroll views.

Changed method name.
Support showing frames in render tree. This isn't a direct reflection of the
kde render tree. I nest the render trees for each part.

5:03 PM Changeset in webkit [926] by sullivan
  • 10 edits in trunk/WebKit

Added method for updating url, title, and/or displayTitle
on existing entry.

  • History.subproj/IFWebHistory.h:
  • History.subproj/IFWebHistory.m: (-[IFWebHistory updateURL:title:displayTitle:forURL:]): Calls through to IFWebHistoryPrivate.
  • History.subproj/IFWebHistoryPrivate.h:
  • History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate _entryForURLString:]): Broke this out from containsURL. (-[IFWebHistoryPrivate containsURL:]): Call broken-out method. (-[IFWebHistoryPrivate updateURL:title:displayTitle:forURL:]): Find existing entry (if any), change its attributes.
  • BrowserDocument.m: (-[BrowserDocument displayName]): removed obsolete comment (-[BrowserDocument receivedPageTitle:forDataSource:]): update existing history entry; also use [NSArray makeObjectsPerformSelector] to simplify code.
  • BrowserWindow.m: (-[BrowserWindow updateTitle]): removed; unbeknownst to me, there was already a synchronizeWindowTitleWithDocumentName that did this same thing. (-[BrowserWindow frameLoadCommitted:]): use synchronizeWindowTitleWithDocumentName
3:49 PM Changeset in webkit [925] by darin
  • 8 edits in trunk/WebKit
  • Misc.subproj/IFError.h: Add the failing URL to IFError.
  • Misc.subproj/IFError.m: (-[IFError initWithErrorCode:]): Call through with nil for the URL. (-[IFError initWithErrorCode:failingURL:]): Retain the passed URL. (-[IFError dealloc]): Autorelease the URL. (-[IFError failingURL]): Return the URL. (-[IFError description]): Include the URL in the description.
  • WebView.subproj/IFBaseWebControllerPrivate.mm: (-[IFBaseWebController _receivedProgress:forResource:fromDataSource:]), (-[IFBaseWebController _mainReceivedProgress:forResource:fromDataSource:]): Put the URL into the IFError.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Put the URL into the IFError.
1:59 PM Changeset in webkit [924] by kocienda
  • 6 edits in trunk/WebCore

2002-04-01 Kenneth Kocienda <​kocienda@apple.com>

The guts of the fix for this bug:

Radar 2879234 (Redirected URLs not used for subsequent GETs)

This change, though small, will fix most of the outstanding problems
with URL redirects. Some little bits of work need to be done, but much
of that is on the UI level.

  • src/kwq/KWQKHTMLPart.mm: (KHTMLPart::begin), (KHTMLPart::setBaseURL):
1:42 PM Changeset in webkit [923] by darin
  • 6 edits in trunk/WebCore
  • src/kwq/KWQKHTMLPart.mm: (KHTMLPart::jScriptEnabled): Hook this up to the preference from WebKit. (KHTMLPart::jScript): Return 0 if JavaScript is disabled. This is exactly what the original KHTMLPart from KDE did.
1:00 PM Changeset in webkit [922] by rjw
  • 2 edits in trunk/WebKit/WebView.subproj

Made timing logs relative to start of document, not start of each data source.

12:46 PM Changeset in webkit [921] by rjw
  • 8 edits in trunk/WebKit

Added more logging to show time of layouts.

12:40 PM Changeset in webkit [920] by darin
  • 7 edits in trunk/WebKit

WebKit:

Added operations for JavaScript objects. Not sure if this was the best
place for them, but it should be OK for now.

  • Misc.subproj/IFCache.h:
  • Misc.subproj/IFCache.mm: (+[IFCache setDisabled:]), (+[IFCache javaScriptObjectsCount]), (+[IFCache garbageCollectJavaScriptObjects]):
  • WebKit.pbproj/project.pbxproj:

WebBrowser:

Rearranged caches window, renamed it, and added stuff about
JavaScript objects.

  • Debug/CacheController.h:
  • Debug/CacheController.mm: (-[CacheController windowDidLoad]), (-[CacheController emptyWebCoreCaches:]), (-[CacheController setStat:toKey:fromDict:]), (-[CacheController setTotal:fromDict:]), (-[CacheController refreshWebCoreStatisticsMatrix]), (-[CacheController refreshStatistics:]), (-[CacheController toggleDisableWebCoreCaches:]), (-[CacheController garbageCollectJavaScriptObjects:]):
  • Debug/CacheController.nib:
  • Debug/DebugUtilities.m: (+[DebugUtilities createDebugMenu]):
12:01 PM Changeset in webkit [919]
  • 1 copy
    2 deletes in tags/JavaScriptCore-1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-1'.

12:01 PM Changeset in webkit [918] by darin
  • 10 edits
    1 delete in trunk

JavaScriptCore:

Got rid of KWQDef.h because it's dangerous to have two files with
the same name and different contents.

  • JavaScriptCore.pbproj/project.pbxproj:
  • kjs/KWQDef.h: Removed.
  • kjs/ustring.h: Defines unsigned int types inline now.

WebCore:

  • src/kwq/KWQDef.h: Use KWQ_UNSIGNED_TYPES_DEFINED for compatibility with code in JavaScriptCore that has to do the same thing.
9:42 AM Changeset in webkit [917] by darin
  • 17 edits
    2 deletes in trunk/WebCore
  • src/kdelibs/khtml/khtmlview.cpp: (KHTMLView::restoreScrollBar): Disable code that checks if the scroll bar is visible, because it currently doesn't do us any good. We may want to turn it back on if we ever implement setVScrollBarMode. (KHTMLView::viewportWheelEvent): Disable this code for now since it requires access to the vertical scroll bar object.
  • src/kdelibs/khtml/rendering/render_form.cpp: (RenderTextArea::calcMinMaxWidth): Use our own verticalScrollBarWidth and horizontalScrollBarHeight rather than getting scroll bar widgets.
  • src/kwq/qt/qscrollview.h: Remove QScrollView::horizontalScrollBar() and QScrollView::verticalScrollBar(), since we don't have QWidgets to return for these two. We can re-add these later if we need to.
  • src/kwq/qt/qtextedit.h: Removed QMultiLineEdit, and QTextEdit() constructor.
  • src/kwq/kdeui/keditcl.h: Removed.
  • src/kwq/KWQTextEdit.mm: Remove unused functions. (QTextEdit::verticalScrollBarWidth), (QTextEdit::horizontalScrollBarHeight): Implement these two new ones.
  • src/kwq/KWQScrollView.mm: Remove unused functions.
  • src/kdelibs/khtml/rendering/render_form.cpp: Fixed spelling error.
9:05 AM Changeset in webkit [916] by darin
  • 1 delete in trunk/WebKit/WebKit.pbproj/kocienda.pbxuser

Added an icon for HotSpotFinder.

  • Tools/HotSpotFinder/HotSpotFinder.pbproj/project.pbxproj:
  • Tools/HotSpotFinder/noBikes.icns: Added.

Mar 31, 2002:

4:06 PM Changeset in webkit [915] by mjs
  • 7 edits in trunk/WebCore

Fix Radar 2890464 (abcnews.com renders as a blank blue page (probably a JavaScript
problem).) It turns out not to be a JavaScript problem:

  • src/kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): Report that load is finished to KDE layers. Otherwise, the tokenizer will wait forever for a script load completion message that never comes.
4:01 PM Changeset in webkit [914]
  • 1 copy
    33 deletes in tags/WebFoundation-2

This commit was manufactured by cvs2svn to create tag
'WebFoundation-2'.

4:01 PM Changeset in webkit [913]
  • 1 copy
    33 deletes in tags/WebFoundation-1

This commit was manufactured by cvs2svn to create tag
'WebFoundation-1'.

4:01 PM Changeset in webkit [912] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-03-31 Ken Kocienda <​kocienda@apple.com>

Labyrinth:

Modified check file to correspond to new flow of control
in the loader involving results returned from cache.

  • Tests/WebFoundation-CacheLoader/never-expires-test.chk:

Tweaked output of dates

  • Tools/DiskCachePeek/DiskCachePeek.pbproj/project.pbxproj:
  • Tools/DiskCachePeek/main.m: (main):

WebFoundation:

Better handling of cases where a revalidated cache object is returned,
including correct setting of headers and updating of cache object with revalidated
results.

The disk cache database now includes its own mmap code. Now, failed attempts to mmap a cache
file return better result codes. This makes it possible for the cache
to cut down on speculative disk I/O that had been necessary until now since
the mmap code in Foundation does not report why an mmap attempt failed.

  • CacheLoader.subproj/IFHTTPURLProtocolHandler.h:
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (-[IFHTTPURLProtocolHandler initWithURLLoad:]), (+[IFHTTPURLProtocolHandler parseHTTPDateString:]), (-[IFHTTPURLProtocolHandler debugStringForCacheAttributeValue:]), (-[IFHTTPURLProtocolHandler createHTTPRequest]), (-[IFHTTPURLProtocolHandler cacheObjectIsValid:]), (-[IFHTTPURLProtocolHandler cacheObjectRequiresRevalidation:]), (-[IFHTTPURLProtocolHandler shouldCacheResourceData]), (-[IFHTTPURLProtocolHandler timeIntervalFromHTTPResponseHeader:]), (-[IFHTTPURLProtocolHandler calculateObjectAge]):
  • CacheLoader.subproj/IFURLLoad.m: (-[IFURLLoad succeeded]), (-[IFURLLoad shouldCacheResourceData]), (-[IFURLLoad didBeginLoading:]), (+[IFURLLoad IFURLLoadCacheCheckerRun:]):
  • Database.subproj/IFURLFileDatabase.m: (URLFileReaderInit), (-[IFURLFileReader initWithPath:]), (-[IFURLFileReader data]), (-[IFURLFileReader dealloc]), (-[IFURLFileDatabase objectForKey:]), (-[IFURLFileDatabase performSetObject:forKey:]), (-[IFURLFileDatabase performRemoveObjectForKey:]):
7:33 AM Changeset in webkit [911] by darin
  • 5 edits in trunk/WebCore
  • src/kwq/KWQString.mm: (QString::toDouble): Fix to properly handle an empty string.
Note: See TracTimeline for information about the timeline view.