⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 20, 2002:

7:52 AM Changeset in webkit [1054] by darin
  • 9 edits in trunk/WebCore

Problems loading iframes seemed to be due to NSURL objects that
were not normalized, so I made the NSURL creation all be done
by KURL, which fixed the problem.

  • kwq/KWQKHTMLPart.mm: (KHTMLPart::requestFrame), (KHTMLPart::submitForm), (KHTMLPart::khtmlMouseReleaseEvent):
  • kwq/KWQKjobclasses.mm: Call getNSURL instead of creating NSURLs by converting to strings.
  • kwq/kdecore/kurl.h:
  • kwq/KWQKURL.mm: (KURL::getNSURL): New.

Apr 19, 2002:

3:09 PM Changeset in webkit [1053] by kocienda
  • 21 edits
    2 adds in trunk

2002-04-19 Kenneth Kocienda <​kocienda@apple.com>

WebFoundation:

Changes to support submission of forms using HTTP POST.

These changes focus on adding the form data to a post request.

  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (-[IFHTTPURLProtocolHandler addRequestMessageBody:]):
  • ChangeLog:
  • WebFoundation.pbproj/project.pbxproj:

WebCore:

Changes to support submission of forms using HTTP POST.

These changes move us over to using the new WebKit interface for creating
WebDataSource instances, one that passes a handle rather than just a URL,
enabling the specific request method to be communicated to WebFoundation.
This fixes:

Radar 2903602 (IFWebDataSource API must passes attributes and flags to IFURLHandle)

Fixed handling of password fields:

Radar 2903605 (WebCore form processing drops out password input data)

Added some hacks to get form <input type=image ...> working correctly:

Radar 2907198 (Forms not getting submitted correctly when <input type=image>)

  • khtml/rendering/render_form.cpp: (RenderImageButton::RenderImageButton), (RenderImageButton::~RenderImageButton), (RenderImageButton::printObject):
  • khtml/rendering/render_form.h:
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::requestFrame), (KHTMLPart::submitForm), (KHTMLPart::khtmlMouseReleaseEvent):
  • kwq/KWQNSTextField.mm: (-[KWQNSTextField setPasswordMode:]), (-[KWQNSTextField textDidChange:]), (-[KWQNSTextField stringValue]):
  • kwq/Makefile.am:
  • kwq/KWQInvisibleButton.h: Added
  • kwq/KWQInvisibleButton.mm: Added

WebKit:

Changes to support submission of forms using HTTP POST.

These changes move us over to using the new WebKit interface for creating
WebDataSource instances, one that passes a handle rather than just a URL,
enabling the specific request method to be communicated to WebFoundation.
This fixes:

Radar 2903602 (IFWebDataSource API must passes attributes and flags to IFURLHandle)

  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFWebDataSource.h:
  • WebView.subproj/IFWebDataSource.mm: (IFWebDataSourceMake), (-[IFWebDataSource initWithURL:]), (-[IFWebDataSource initWithHandle:]):
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:]):
9:57 AM Changeset in webkit [1052] by rjw
  • 6 edits in trunk/WebKit

Updated comments to reflect new API.

8:45 AM Changeset in webkit [1051] by darin
  • 6 edits in trunk/WebKit
  • Plugins.subproj/IFPluginView.h: Re-add the attributes and values arrays, since they need to live the life of the plugin.
  • Plugins.subproj/IFPluginView.mm: (newCString): New function to make a C++ new-allocated C string from an NSString. (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): Move code to allocate the arrays back here. (-[IFPluginView dealloc]): Deallocate the arrays and their contents. (-[IFPluginView start]): Simplify now that it does no work.

Apr 18, 2002:

8:18 PM Changeset in webkit [1050] by cblu
  • 6 edits in trunk/WebKit

2002-04-18 Chris Blumenberg <​cblu@apple.com>

Made stop and start work better. Fixed a bug darin made.

  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]), (-[IFPluginView setWindow]), (-[IFPluginView start]), (-[IFPluginView stop]):
8:07 PM Changeset in webkit [1049] by rjw
  • 7 edits in trunk/WebKit

Fixed typo.

8:02 PM Changeset in webkit [1048] by rjw
  • 12 edits
    2 adds in trunk/WebKit

New API for content policy.

4:01 PM Changeset in webkit [1047] by darin
  • 7 edits in trunk

Oops. Take out -Wstrict-prototypes, put back -Wmissing-prototypes.

3:54 PM Changeset in webkit [1046] by darin
  • 7 edits in trunk

Take out -Wmissing-prototypes
because system headers are triggering it when we don't have
precompiled headers on.

3:38 PM Changeset in webkit [1045] by darin
  • 98 edits in trunk
  • Makefile.am: Pass the -f flag to ln so it doesn't fail when there's already a link there.
  • configure.in: Use gcc3 and g++3 so we always get gcc 3.0, no matter how the system is configured. Besides the fact that gcc 3.0 includes more in -Wall, turned on the following additional warnings that were not on before:

-W
-Wbad-function-cast
-Wformat-security
-Wmissing-format-attribute
-Wstrict-prototypes
-Wwrite-strings

Also removed the -fno-coalesce-static-vtables flag for C++
and removed explicit mention of C++ warnings that are part of
-Wall in gcc 3.0 at least.

  • Tests/harness.c: (main): Const string fix.
  • Tests/kde/kurl-test.cpp: (testURL): Std namespace and const string fix.
  • Tests/libiftest/IFTestDirectory.c: (IFSetUpTestDirectory): Const string fix.
  • Tests/libiftest/IFTestDirectory.h: Const string fix.
  • Tests/qt/qarray-test.cpp:
  • Tests/qt/qbuffer-test.cpp:
  • Tests/qt/qchar-test.cpp:
  • Tests/qt/qcstring-test.cpp:
  • Tests/qt/qdate-test.cpp:
  • Tests/qt/qdatetime-test.cpp:
  • Tests/qt/qdict-test.cpp:
  • Tests/qt/qdir-test.cpp:
  • Tests/qt/qfile-test.cpp:
  • Tests/qt/qlist-test.cpp:
  • Tests/qt/qmap-test.cpp:
  • Tests/qt/qpoint-test.cpp:
  • Tests/qt/qptrdict-test.cpp:
  • Tests/qt/qrect-test.cpp:
  • Tests/qt/qregexp-test.cpp:
  • Tests/qt/qsize-test.cpp:
  • Tests/qt/qsortedlist-test.cpp:
  • Tests/qt/qstack-test.cpp:
  • Tests/qt/qstring-test.cpp:
  • Tests/qt/qstringlist-test.cpp:
  • Tests/qt/qtime-test.cpp:
  • Tests/qt/qvaluelist-test.cpp:
  • Tests/qt/qvector-test.cpp: Add "using namespace std" to each test as a simple std namespace fix.

WebFoundation:

Reviewed by Maciej

Fixes for compiling with gcc3 and more warnings.

  • WebFoundation.pbproj/project.pbxproj: Turn on gcc3 and the same set of warnings as in the rest of Labyrinth (see top level ChangeLog for details).
  • CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandle percentComplete]): Rearrange code to avoid a cast to (float) that gcc3 didn't like.
  • Database.subproj/IFNDBMDatabase.m: (-[IFNDBMDatabase objectForKey:]): Mark some variables volatile to make gcc3 happy about their values and the use of longjmp. Good catch on the compiler's part.
  • Database.subproj/IFURLFileDatabase.m: Work around bug 2905545 so we can have -W on for all the rest of WebFoundation. (URLFileReaderInit): Mark this as (void) so it's not a non-prototyped function. (-[IFURLFileReader initWithPath:]): Don't assign to self so gcc3 is not unhappy about the use of it with longjmp. (-[IFURLFileDatabase objectForKey:]): Mark some variables volatile to make gcc3 happy about their values and the use of longjmp.
  • Misc.subproj/IFNSObjectExtensions.m: (-[NSObject performBooleanSelector:]), (-[NSObject performBooleanSelector:withObject:]): Do a new implementation that does't make the compiler unhappy about type casts.
  • Misc.subproj/IFNSThreadExtensions.m: Work around bug 2905545 so we can have -W on for all the rest of WebFoundation. (InitJoinableThreads): Mark this as (void) so it's not a non-prototyped function.

JavaScriptCore:

Reviewed by Maciej

  • JavaScriptCore.pbproj/project.pbxproj: Turn on gcc3 and the same set of warnings as in the rest of Labyrinth (see top level ChangeLog for details).

WebCore:

Fixes for compiling with gcc3 and more warnings.

  • khtml/html/.cvsignore: Add kentities.c; I could have sworn I did this already.
  • khtml/html/Makefile.am: Remove erroneous duplicate definition of CLEAN_FILES.
  • libwebcore.exp:
  • libwebcoretests.exp: Rebuilt these lists from scratch. Almost everything in here is different since the C++ name mangling rules changed.
  • khtml/css/cssparser.cpp:
  • khtml/misc/htmlhashes.cpp: Disable inlining in part of this file as a workaround for Radar 2905890.
  • kwq/KWQApplication.mm: (QDesktopWidget::screenGeometry): Add casts to int needed to make gcc3 happy.
  • kwq/KWQArrayImpl.mm: Add missing #include of <string.h>.
  • kwq/KWQBitmap.mm:
  • kwq/KWQFrame.mm:
  • kwq/KWQLineEdit.mm: Removed some unused copy constructors and assignment operators to avoid warnings in them.
  • kwq/KWQButton.mm: (QButton::setText):
  • kwq/KWQListBox.mm: (QListBox::~QListBox), (QListBox::clear), (QListBox::setSelectionMode), (QListBox::currentItem), (QListBox::insertItem), (QListBox::setSelected), (QListBox::isSelected), (QListBoxItem::width), (QListBoxItem::height):
  • kwq/KWQScrollView.mm: (QScrollView::setContentsPos), (QScrollView::addChild), (QScrollView::resizeContents), (QScrollView::viewportToContents), Use local variables to work around Radar 2905835.
  • kwq/KWQCString.mm: (operator<<):
  • kwq/KWQPoint.mm: (operator<<):
  • kwq/KWQRect.mm: (operator<<):
  • kwq/KWQSize.mm: (operator<<):
  • kwq/qt/qarray.h:
  • kwq/qt/qcstring.h:
  • kwq/qt/qdatetime.h:
  • kwq/qt/qdict.h:
  • kwq/qt/qlist.h:
  • kwq/qt/qmap.h:
  • kwq/qt/qpainter.h:
  • kwq/qt/qpoint.h:
  • kwq/qt/qptrdict.h:
  • kwq/qt/qrect.h:
  • kwq/qt/qsize.h:
  • kwq/qt/qstack.h:
  • kwq/qt/qvaluelist.h:
  • kwq/qt/qvector.h: Say std::ostream instead of just ostream.
  • kwq/KWQCharsets.mm: Fix a const problem.
  • kwq/KWQDateTime.mm: (QTime::elapsed), (QTime::restart): Use int instead of uint, since these functions try to handle values that are less than 0. (operator<<): Say std::ostream instead of just ostream.
  • kwq/KWQTextArea.mm: (RangeOfParagraph): Fix an int/uint issue.
  • kwq/KWQFile.mm: (QFile::KWQFilePrivate::KWQFilePrivate), (QFile::KWQFilePrivate::~KWQFilePrivate): Use new/delete instead of malloc/free so we don't get void * warnings.
  • kwq/KWQFontMetrics.mm: (IFFillStyleWithAttributes), (-[KWQLayoutInfo drawString:atPoint:withFont:color:]), (-[KWQLayoutInfo _initializeCaches]), (_rectForString):
  • kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::KWQKURLPrivate), (RelativeURLKeyRetainCallBack), (RelativeURLKeyReleaseCallBack), (RelativeURLKeyEqualCallBack), (RelativeURLKeyHashCallBack), (KURL::normalizeURLString), (KURL::normalizeRelativeURLString):
  • kwq/KWQPainter.mm: (QPainter::save):
  • kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]), (-[URLLoadClient IFURLHandle:didRedirectToURL:]): Add type casts where necessary to make the stricter gcc3 happy.
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap): Explicitly initialize the underlying QPaintDevice. (QPixmap::size), (QPixmap::rect): Add type casts where necessary to make the stricter gcc3 happy.
  • kwq/KWQPtrDictImpl.mm: (KWQPtrDictImpl::KWQPtrDictPrivate::KWQPtrDictPrivate): Say std::bad_alloc instead of just bad_alloc. (invokeDeleteFuncOnValue), (KWQPtrDictImpl::clear): Pass a pointer to a function pointer rather than a function pointer to avoid a warning about turning function pointers into void *.
  • kwq/KWQRegion.mm: (QRegion::_initialize), (QRegion::~QRegion): Use new/delete rather than calloc/free so we don't get void * warnings. (QRegion::boundingRect): Add type casts.
  • kwq/KWQString.mm: (QString::fromStringWithEncoding): Add cast. (QString::setNum): use %ld and %lu rather than %D and %U. (QString::fill), (QString::convertToQCString): Add casts.
  • kwq/KWQTextStorage.mm: (-[KWQTextStorage _buildFragmentForString:]): Add a cast to make gcc3 happy.
  • kwq/KWQVariant.mm: Say "friend class" instead of "friend".
  • kwq/KWQVectorImpl.mm: (KWQVectorImpl::KWQVectorPrivate::KWQVectorPrivate): Say std::bad_alloc instead of just bad_alloc. (KWQVectorImpl::data): Replace the old autorelease trick with a new one that doesn't require mixing malloc with NSData.
  • kwq/KWQView.mm: (-[KWQHTMLView mouseUp:]), (-[KWQHTMLView mouseDown:]): Add casts to make gcc3 happy.
  • kwq/KWQWidget.mm: (QWidget::frameGeometry), (QWidget::mapToGlobal), (QWidget::minimumSizeHint): Add casts to make gcc3 happy. Also another workaround for Radar 2905835.
  • kwq/WCPlugin.mm: (-[WCPlugin load]): Add tons of type casts so we don't have to mix void * with function pointer types.
  • kwq/WCPluginWidget.h:
  • kwq/WCPluginWidget.mm: (WCIFPluginMakeFunction), (WCIFNullPluginMakeFunction): Change types so we don't have to mix void * with function pointer types. This caught a mistake where WCIFNullPluginMakeFunction was returning the wrong function pointer.
  • kwq/external.h: Add some missing interfaces that the pickier gcc3 needed to see.
  • kwq/kwqdebug.mm: Don't compile the file if xNDEBUG is set. Otherwise we get a warning in here.
  • kwq/npapi.h: Use function pointer types for function pointers and transition vectors so we don't have to mix void * with function pointer types.
  • kwq/npapi.mm: (NPN_GetURLNotify), (NPN_GetURL), (NPN_PostURLNotify), (NPN_PostURL), (NPN_NewStream), (NPN_Write), (NPN_DestroyStream), (NPN_Status), (NPN_GetValue), (NPN_SetValue), (NPN_InvalidateRect), (NPN_InvalidateRegion), (NPN_ForceRedraw): Use local variables to work around Radar 2905835. (functionPointerForTVector), (tVectorForFunctionPointer): Change types around so we don't have to mix void * with function pointer types.

WebKit:

Fixes for compiling with gcc3 and more warnings.

  • WebKit.pbproj/project.pbxproj: Turn on gcc3 and the same set of warnings as in the rest of Labyrinth (see top level ChangeLog for details).
  • Plugins.subproj/IFPluginView.mm: Avoid warnings about malloc by not using it. (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): Keep the arguments dictionary around instead of keeping the C format version of it around. Also don't bother keeping the C string form of the MIME type around, and simplify some other stuff in here. (-[IFPluginView dealloc]): Corresponding changes since we keep a different set of things. (-[IFPluginView newStream:mimeType:notifyData:]): Use [mimeType cString]. (-[IFPluginView start]): Build the lists of attributes and values in here. Do it using [NSString cString] for simplicity and don't keep the lists around after we're done with them. (-[IFPluginView IFURLHandleResourceDidFinishLoading:data:]): Use [filenameClassic cString].
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]), (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]), (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]), (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]), (-[IFWebDataSource _setLoading:]), (-[IFWebDataSource _setController:]), (-[IFWebDataSource _setLocationChangeHandler:]):
  • WebView.subproj/IFWebView.mm: (-[IFWebView provisionalDataSourceChanged:]), (-[IFWebView mouseUp:]), (-[IFWebView mouseDown:]): Add type casts required by pickier gcc3.
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebViewPrivate dealloc]): Add type cast required by pickier gcc3. (-[IFWebView _stopPlugins]): Use local variable to work around Radar 2905835.

WebBrowser:

Fixes for compiling with gcc3 and more warnings.

  • WebBrowser.pbproj/project.pbxproj: Turn on gcc3 and the same set of warnings as in the rest of Labyrinth (see top level ChangeLog for details).
  • InternetConfigUtilities.m: (stringValueForICKey), (setStringValue): Some const string fixes.
  • Preferences.subproj/TextPreferences.m: (-[TextPreferences changeFont:]): Remove a cast that makes gcc3 unhappy.
  • _CFA2UC.c: (NSGiantRaise): Const string fix. (gcompg): Old-style function prototype fix. (initialguess): Remove a cast that makes gcc3 unhappy.
11:49 AM Changeset in webkit [1044] by cblu
  • 6 edits in trunk/WebKit

Moved plugin instance creation to the start method in IFPluginView.

  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]), (-[IFPluginView dealloc]), (-[IFPluginView newStream:mimeType:notifyData:]), (-[IFPluginView start]), (-[IFPluginView stop]), (-[IFPluginView drawRect:]), (-[IFPluginView windowBecameKey:]), (-[IFPluginView windowResignedKey:]), (-[IFPluginView IFURLHandle:resourceDataDidBecomeAvailable:]), (-[IFPluginView IFURLHandleResourceDidFinishLoading:data:]):

Apr 17, 2002:

6:00 PM Changeset in webkit [1043]
  • 1 copy
    2 deletes in tags/JavaScriptCore-3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-3'.

6:00 PM Changeset in webkit [1042]
  • 10 copies in tags/Alex0_3c1

This commit was manufactured by cvs2svn to create tag 'Alex0_3c1'.

6:00 PM Changeset in webkit [1041] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by: Darin Adler <Darin Adler>

  • kjs/testkjs.cpp: Don't include <iostream.h> to avoid gcc3 warning.
4:37 PM Changeset in webkit [1040] by darin
  • 9 edits
    1 add
    1 delete in trunk/WebCore

Fix build problem.

  • Makefile.am: Don't build this directory before subdirs, because we link at this level. Move the kentities.c build out of here, because it needs to be done before khtml/html.
  • khtml/html/Makefile.am: Move kentities.c build rules here.
  • kentities.gperf: Removed.
  • khtml/html/kentities.gperf: Added.
  • .cvsignore: Don't ignore kentities.c.
  • khtml/html/.cvsignore: Ignore kentities.c.
4:12 PM Changeset in webkit [1039] by darin
  • 17 edits
    2 adds
    3 deletes in trunk

top level:

  • configure.in: Update for new organization of WebCore.
  • Tools/HotSpotFinder/HotSpotFinder.pbproj/project.pbxproj: Switch to gcc3 and turn on more warnings.
  • Tools/HotSpotFinder/SamplingData.m: (-[SamplingDataAccumulator processFunction:depth:]): Fix a signed/unsigned warning.

WebCore:

  • .cvsignore: Ignore new generated files at this level.
  • include/*: Removed. We don't need this hack any more.
  • src/*: Removed. Sources are now in their new locations.
  • src/libwebcore.exp: Removed. This is now in its new location.
  • src/libwebcoretests.exp: Removed. This is now in its new location.
  • Makefile.am: Build khtml and kwq subdirs, don't build src and include. Also add the rules that used to be in src about linking the library and the rules that used to be in src/kdelibs/kdecore about building the kentitices.c file.
  • dummy.mm: Moved here from src by hand.
  • kentities.gperf: Moved here from src/kdelibs/kdecore by hand.
  • khtml/html/Makefile.am: Add WebCore directory to includes so the include of "kentities.c" will work.
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQKJavaEmbed.mm:
  • kwq/KWQKloader.mm: Correct includes so we don't need a -I for each of the subdirectories.
  • kwq/khtml/java/javaembed.h: Removed. We use the one in the real khtml directory.
  • kwq/kwqdebug.h: Rolled over Chris's changes, which were done after the cvs surgery was done.

WebKit:

  • WebKit.pbproj/project.pbxproj: Update header search paths to find WebCore in the new location and eliminate WebCore/include.

WebBrowser:

  • WebBrowser.pbproj/project.pbxproj: Update header search paths to find WebCore in the new location and eliminate WebCore/include.
12:53 PM Changeset in webkit [1038] by cblu
  • 13 edits in trunk

Added a debug bit mask for plugins and downloads.

  • MIME.subproj/IFDownloadHandlerPrivate.m: (-[IFDownloadHandlerPrivate _openFile]), (-[IFDownloadHandlerPrivate _saveFile]), (-[IFDownloadHandler _initWithURLHandle:mimeHandler:]):
  • Misc.subproj/WebKitDebug.h:
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]), (-[IFPluginView setWindow]), (-[IFPluginView newStream:mimeType:notifyData:]), (-[IFPluginView stop]), (-[IFPluginView sendUpdateEvent]), (-[IFPluginView becomeFirstResponder]), (-[IFPluginView resignFirstResponder]), (-[IFPluginView mouseDown:]), (-[IFPluginView mouseUp:]), (-[IFPluginView mouseEntered:]), (-[IFPluginView mouseExited:]), (-[IFPluginView keyUp:]), (-[IFPluginView keyDown:]), (-[IFPluginView IFURLHandle:resourceDataDidBecomeAvailable:]), (-[IFPluginView IFURLHandleResourceDidFinishLoading:data:]), (-[IFPluginView getURLNotify:target:notifyData:]), (-[IFPluginView getURL:target:]), (-[IFPluginView postURLNotify:target:len:buf:file:notifyData:]), (-[IFPluginView postURL:target:len:buf:file:]), (-[IFPluginView newStream:target:stream:]), (-[IFPluginView write:len:buffer:]), (-[IFPluginView destroyStream:reason:]), (-[IFPluginView status:]), (-[IFPluginView getValue:value:]), (-[IFPluginView setValue:value:]), (-[IFPluginView invalidateRect:]), (-[IFPluginView invalidateRegion:]), (-[IFPluginView forceRedraw]):
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
  • src/kwq/kwqdebug.h:
7:56 AM Changeset in webkit [1037] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFPreferences.mm: (+[IFPreferences load]): Changed another Georgia that I missed to Times New Roman.

Apr 16, 2002:

10:58 PM Changeset in webkit [1036] by darin
  • 6 edits in trunk/WebKit
  • WebView.subproj/IFWebDataSource.mm:
  • WebView.subproj/IFWebDataSourcePrivate.mm: Touch these files to try to make Jersey build again.
6:07 PM Changeset in webkit [1035] by darin
  • 28 edits
    2 adds
    1 delete in trunk

WebCore:

  • src/kdelibs/khtml/khtml_part.cpp: Added. Not used yet, but maybe we'll use part of it some time soon.
  • src/kdelibs/khtml/khtml_part.h: Reenabled this file, and made changes so it could be used instead of our own header.
  • src/kwq/KWQKHTMLPart.h: Removed.
  • src/kwq/KWQKHTMLPart.mm: (KHTMLPart::KHTMLPart): Add parameter to match KDE. (KHTMLPart::settings): Add const to match KDE. (KHTMLPart::scheduleRedirection): Add parameter to match KDE. (KHTMLPart::encoding): Add const to match KDE. (KHTMLPart::urlCursor): Update return value to match KDE. (KHTMLPart::urlSelected): Add parameter to match KDE. (KHTMLPart::requestObject): Put plugins array on private object. (KHTMLPart::frames): Remove const to match KDE. (KHTMLPart::documentSource): Add const to match KDE. (KHTMLPart::setTitle): Put dataSource on private object. (KHTMLPart::setDataSource): New, not inline any more. (KHTMLPart::getDataSource): New, not inline any more.
  • src/libwebcore.exp: Update for function name changes.
  • src/kwq/khtml/khtml_settings.h:
  • src/kwq/KWQKHTMLSettings.mm: (KHTMLSettings::changeCursor): Add const.
  • src/kwq/KWQView.mm: (-[KWQHTMLView layout]): No need to check xmlDocImpl() and renderer() for NULL now, because KHTMLView::layout does.
  • src/kwq/KWQKloader.mm: (Loader::load): Use type instead of id.

WebKit:

  • WebView.subproj/IFBaseWebControllerPrivate.mm: Include khtml_part.h instead of KWQKHTMLPart.h.
  • WebView.subproj/IFWebFrame.mm: Include khtml_part.h instead of KWQKHTMLPart.h.
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource documentTextFromDOM]): Remove an unneeded cast and an extra retain/autorelease.
4:46 PM Changeset in webkit [1034] by darin
  • 8 edits in trunk/WebKit
  • WebView.subproj/IFWebFrame.h:
  • WebView.subproj/IFWebFrame.mm:
  • WebView.subproj/IFWebFramePrivate.h: Change view/setView back to be id, rather than IFWebView. In the future, the view may be some other kind of object.
3:37 PM Changeset in webkit [1033] by sullivan
  • 4 edits in trunk/WebKit

Fixed bug Chris noticed where Alexander wasn't putting up
an error sheet on failed page visits.

  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Don't set provisionalDataSource to nil until after sending it locationChangeDone.
3:30 PM Changeset in webkit [1032] by darin
  • 16 edits in trunk/WebKit
  • WebView.subproj/IFBaseWebController.mm: Remove special release handling because data sources now retain the controller as long as they are loading.
  • WebView.subproj/IFWebDataSource.mm: Remove special release handling because data sources now retain themselves as long as they are loading.
  • WebView.subproj/IFWebFrame.mm: Remove special release handling, because data sources now retain the controller as long as they are loading, and the controller retains the frame.
  • WebView.subproj/IFWebDataSourcePrivate.h: Add a "loading" boolean.
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setLoading:]): Change the "loading" state, retaining or releasing this object and the controller as necessary. (-[IFWebDataSource _updateLoading]): Update the loading state; called when some part of loading is done to see if it's all done. (-[IFWebDataSource _setController:]): Retain the new controller and release the old controller when loading. (-[IFWebDataSource _setPrimaryLoadComplete:]): Call _updateLoading. (-[IFWebDataSource _startLoading:]): Call _setLoading:YES. (-[IFWebDataSource _addURLHandle:]): Call _setLoading:YES. (-[IFWebDataSource _removeURLHandle:]): Call _updateLoading.
  • WebView.subproj/IFWebFrame.h: Use the real type, IFWebView, for setView and view.
  • WebView.subproj/IFWebFramePrivate.h: Formatting tweak.
  • WebKit.pbproj/project.pbxproj: Version wars.
3:30 PM Changeset in webkit [1031] by darin
  • 15 edits in trunk/WebCore
  • src/kwq/kio/jobclasses.h:
  • src/kwq/KWQKjobclasses.mm: (TransferJob::setError): New.
  • src/kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandleResourceDidCancelLoading:]), (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): Set an error code so that the load will abort intead of continuing.
  • src/kwq/KWQKHTMLPart.mm: Removed some unused code.
3:22 PM Changeset in webkit [1030] by sullivan
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _setController:]): removed a mistaken retain/release pair here for Darin.

More code restructuring. BrowserDocument no longer implements
the IFWebController protocol; its WebController object does all
the progress handling now.

Also made BrowserDocument stop loading on close for Darin, which fixes
a problem he discovered.

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument init]), (-[BrowserDocument dealloc]), (-[BrowserDocument close]), (-[BrowserDocument _webController]), (-[BrowserDocument goToURL:withFrameLoadType:]), (-[BrowserDocument isLoading]):
  • BrowserDocumentPrivate.h:
  • LoadProgressEntry.h:
  • LoadProgressEntry.m: (-[LoadProgressEntry status]):
  • LoadProgressMonitor.m: (-[LoadProgressMonitor addEntryForFrame:withType:stage:isMain:]):
  • LocationChangeHandler.h:
  • LocationChangeHandler.m: (-[LocationChangeHandler initWithFrame:forBrowserDocument:]), (-[LocationChangeHandler _webController]), (-[LocationChangeHandler _saveScrollPosition]), (-[LocationChangeHandler _scrollToTop]), (-[LocationChangeHandler _restoreScrollPosition]), (-[LocationChangeHandler locationChangeStarted]), (-[LocationChangeHandler locationChangeCommitted]), (-[LocationChangeHandler displayError:withStage:]), (-[LocationChangeHandler locationChangeDone:]), (-[LocationChangeHandler receivedPageTitle:forDataSource:]):
  • WebController.h:
  • WebController.m: (-[WebController initWithBrowserDocument:]), (-[WebController dealloc]), (-[WebController resetDocument]), (-[WebController document]), (-[WebController loadMonitor]), (-[WebController receivedProgress:forResource:fromDataSource:]), (-[WebController receivedError:forResource:partialProgress:fromDataSource:]), (-[WebController setStatusText:forDataSource:]), (-[WebController provideLocationChangeHandlerForFrame:]), (-[WebController pluginNotFoundSheetEnded:returnCode:contextInfo:]), (-[WebController pluginNotFoundForMIMEType:pluginPageURL:]), (-[WebController startedDownloadWithHandler:]), (-[WebController receivedProgress:forDownloadHandler:]), (-[WebController receivedError:forDownloadHandler:partialProgress:]): Much code moved from here to there; some code moved from there to here; callers updated to call the code on this object that used to be on that object, and vice-versa.
11:50 AM Changeset in webkit [1029] by darin
  • 5 edits in trunk/WebKit

Change default font to "Times New Roman 11" rather than
"Georgia 12" to be more like Macintosh Internet Explorer.

  • WebView.subproj/IFPreferences.mm:

A little simplifying of private pointers.

  • MIME.subproj/IFDownloadHandler.h:
  • MIME.subproj/IFDownloadHandler.m:
11:47 AM Changeset in webkit [1028] by darin
  • 31 edits in trunk/WebKit

A little simplifying of private pointers.

10:43 AM Changeset in webkit [1027] by darin
  • 83 edits in trunk/WebKit

Change headers so they don't include so much.
Also change IF_LOAD_TYPE to IFLoadType.

8:18 AM Changeset in webkit [1026] by kocienda
  • 23 edits
    4 deletes in trunk

2002-04-16 Kenneth Kocienda <​kocienda@apple.com>

Moved IFError class from WebKit to WebFoundation.

Labyrinth:

Updated test and tool code to track this change.

  • Tests/WebFoundationC/ifurlhandlec-test.c: (ResourceDidFailLoadingCallBack):
  • Tools/wftool/WFTool.m: (-[WFTool IFURLHandle:resourceDidFailLoadingWithResult:]):

WebBrowser:

Updated includes due to this change.

  • BrowserDocument.m:
  • FrameProgressEntry.m:
  • LoadProgressEntry.m:
  • LocationChangeHandler.m:
  • WebBrowser.pbproj/project.pbxproj:

WebCore:

Updated URL handle client interface to pass an IFError in
an error callback rather than a plain int. These files were
modified due to this change.

  • src/kwq/KWQKHTMLPart.mm: (WCSetIFWebDataSourceMakeFunc):
  • src/kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]):

Removed now unneeded file and function pointer symbol entry
since WebCore code never needs to create an IFError now that
those objects are created at a lower level (in WebFoundation).

  • src/kwq/WCError.h: Removed.
  • src/libwebcore.exp:

WebFoundation:

Updated URL handle client interface to pass an IFError in
an error callback rather than a plain int. These files were
modified due to this change.
I added some additional API to the C glue to make IFError objects
accessible from C code.

  • CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandleInstanceVariables dealloc]), (-[IFURLHandleSynchronousClient IFURLHandle:resourceDidFailLoadingWithResult:]), (-[IFURLHandle notifyClientsDidFailLoading]):
  • CacheLoader.subproj/IFURLHandleC.h:
  • CacheLoader.subproj/IFURLHandleC.m: (IFErrorGetErrorCode), (IFErrorGetErrorDescription), (IFErrorGetFailingURL):
  • CacheLoader.subproj/IFURLHandleCallBackClient.m: (-[IFURLHandleCallBackClient IFURLHandle:resourceDidFailLoadingWithResult:]):
  • CacheLoader.subproj/IFURLHandleClient.h:
  • Misc.subproj/IFError.h:
  • Misc.subproj/IFError.m: (+[IFError initialize]), (+[IFError errorWithCode:]), (+[IFError errorWithCode:failingURL:]), (-[IFError initWithErrorCode:]), (-[IFError errorDescription]), (-[IFError description]):
  • Misc.subproj/WebFoundation.h:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Moved IFError class from WebKit to WebFoundation.
Updated includes due to this change.
Updated URL handle client interface to pass an IFError in
an error callback rather than a plain int. The URL client was
modified due to this change.

  • Misc.subproj/IFError.h: Removed.
  • Misc.subproj/IFError.m: Removed.
  • Plugins.subproj/IFPluginView.mm:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFBaseWebControllerPrivate.mm:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):
  • WebView.subproj/IFWebFramePrivate.mm:
Note: See TracTimeline for information about the timeline view.