Timeline

May 3, 2002:

5:27 PM Changeset in webkit [1097] by darin

• 6 edits in trunk/WebCore

• khtml/css/cssstyleselector.cpp:
• khtml/dom/css_value.cpp:
• khtml/xml/dom_stringimpl.cpp: Put in some namespace-related statements to more-elegantly work around the conflicts between Macintosh and khtml identifiers.

4:05 PM Changeset in webkit [1096] by sullivan

• 17 edits in trunk/WebKit

Along with small corresponding WebBrowser change,
fixed 2919172 (Bookmarks aren't saved between sessions).

• Bookmarks.subproj/IFBookmark_Private.h: Declarations for new private methods.
• Bookmarks.subproj/IFBookmark.m: (-[IFBookmark _numberOfDescendants]): New private method, counts deep; used only for debugging messages at this time. (-[IFBookmark _initFromDictionaryRepresentation:withGroup:]): (-[IFBookmark _dictionaryRepresentation]): New private methods used to save/load bookmarks. Stub implementations; subclasses must implement.

• Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf _initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkLeaf _dictionaryRepresentation]): New methods.

• Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList _initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkList _dictionaryRepresentation]): (-[IFBookmarkList _numberOfDescendants]): New methods. (-[IFBookmarkList _setGroup:]): Recurse on children.

• Bookmarks.subproj/IFBookmarkGroup.h: New _loading instance variable.

• Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _setTopBookmark:]): Renamed from _resetTopBookmark, now has potentially non-nil argument. (-[IFBookmarkGroup initWithFile:]), (-[IFBookmarkGroup removeBookmark:]): Updated for name change. (-[IFBookmarkGroup _sendBookmarkGroupChangedNotification]): Don't send notifications while loading bookmarks from disk. (-[IFBookmarkGroup _loadBookmarkGroupGuts]), (-[IFBookmarkGroup loadBookmarkGroup]), (-[IFBookmarkGroup _saveBookmarkGroupGuts]), (-[IFBookmarkGroup saveBookmarkGroup]): New methods, load/save bookmarks and report timings.

• History.subproj/IFURIEntry.m: (-[IFURIEntry dictionaryRepresentation]), (-[IFURIEntry initFromDictionaryRepresentation:]): Handle nil URL case, which bookmarks run into.

• WebKit.pbproj/project.pbxproj: version wars

• AppController.m: (-[AppController applicationWillTerminate:]): Save bookmarks at quit time.

• WebBrowser.pbproj/project.pbxproj: version wars

2:52 PM Changeset in webkit [1095] by darin

• 3 edits in trunk/WebKit

• WebCoreSupport.subproj/IFCachedTextRenderer.m: Remove some of the unused code. I was going to wait and let Richard do it next week, but I was unable to control my urge to hack on it.

12:03 PM Changeset in webkit [1094] by darin

• 3 edits in trunk/WebKit

• Resources/url_icon.tiff: Improved icon. Could be better.

11:42 AM Changeset in webkit [1093] by darin

• 1 edit in trunk/WebKit/Resources/url_icon.tiff

Revert icon, oops.

11:36 AM Changeset in webkit [1092] by darin

• 26 edits
  8 adds
  5 deletes in trunk

WebCore:

• kwq/IFTextRenderer.h: Added.
• kwq/IFTextRendererFactory.h: Added.
• kwq/IFTextRendererFactory.m: Added. These three are the new API for supplying text rendering machinery for WebCore. The implementation is in WebKit. Later we might want to flesh out the default implementation in WebCore so that it works OK by itself.

• khtml/rendering/font.cpp: (Font::width): Function is now "width" without an underscore. We don't really need to hide the overload we added in this case.

• kwq/qt/qfont.h: Simplify a lot. Doesn't hold an NSFont any more.
• kwq/KWQFont.mm: (QFont::QFont): Eliminated the concept of "default font". Also, a QFont no longer holds an NSFont object. That's handled inside IFTextRenderer machinery. (QFont::~QFont): Simplify since we don't have an NSFont. (QFont::setFamily): Simplify since we don't have an NSFont. (QFont::setPixelSize): Simplify since we don't have an NSFont. (QFont::setPixelSizeFloat): Simplify since we don't have an NSFont. (QFont::setWeight): Simplify since we don't have an NSFont. (QFont::weight): Fix a bug where it would return Normal for a QFont that was both bold and italic. (QFont::setItalic): Simplify since we don't have an NSFont. (QFont::italic): Simplify since we have real "bool". (QFont::bold): Simplify since we have real "bool". (QFont::operator=): Simplify since we don't have an NSFont. (QFont::operator==): Rewrite since we don't have an NSFont.

• kwq/qt/qfontmetrics.h: Simplify a little. The _width() method is now just an overload of the width() method. The main change was removing the include of Cocoa.h.
• kwq/KWQFontMetrics.mm: Move most of the code out of here into WebKit. (QFontMetrics::ascent): Get it from the renderer. (QFontMetrics::descent): Get it from the renderer. (QFontMetrics::lineSpacing): Get it from the renderer. (QFontMetrics::width): Get it from the renderer. (QFontMetrics::boundingRect): Combine width and height that came from the renderer. (QFontMetrics::size): Combine width and height that came from the renderer.

• kwq/Makefile.am: Add IFTextRendererFactory.m, remove KWQTextStorage.mm and KWQTextContainer.mm.
• kwq/KWQMetrics.h: Removed.
• kwq/KWQTextContainer.h: Removed.
• kwq/KWQTextContainer.mm: Removed.
• kwq/KWQTextStorage.h: Removed.
• kwq/KWQTextStorage.mm: Removed.

• kwq/KWQPainter.mm: Move most of the code out of here into WebKit. (QPainter::drawText): Call the renderer to do it. (QPainter::drawUnderlineForText): Call the renderer to do it.

• libwebcore.exp: Export the IFTextRendererFactory class.

WebKit:

• Misc.subproj/WebKitDebug.h: Add WEBKIT_LOG_MEMUSAGE, WEBKIT_LOG_FONTCACHE, and WEBKIT_LOG_FONTCACHECHARMISS for font code moved here from WebCore.

• Resources/url_icon.tiff: New URL icon?

• WebCoreSupport.subproj/IFCachedTextRenderer.h: Added.
• WebCoreSupport.subproj/IFCachedTextRenderer.m: Added.
• WebCoreSupport.subproj/IFCachedTextRendererFactory.h: Added.
• WebCoreSupport.subproj/IFCachedTextRendererFactory.m: Added. This has code moved here from WebCore.

• WebKit.pbproj/project.pbxproj: Add the new source files.

• Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf setURLString:]): Use copy instead of initWithString.
• Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList initWithTitle:image:group:]): Use copy instead of stringWithString. (-[IFBookmarkList setTitle:]): Use copy instead of stringWithString.
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setTitle:]): Use mutableCopy instead of stringWithString.
• WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): Use copy instead of stringWithString.

11:07 AM Changeset in webkit [1091] by darin

• 1 edit in trunk/WebKit/Misc.subproj/WebDatabase.m

• AuthenticationManager.subproj/IFAuthenticationRequest.m: (-[IFAuthenticationRequest initWithURL:realm:username:passwordSentInClear:previousFailures:callback:]):
• AuthenticationManager.subproj/IFAuthenticationResult.m: (-[IFAuthenticationResult initWithUsername:password:]):
• Database.subproj/IFDatabase.m: (-[IFDatabase initWithPath:]): Simplify code by using [copy] instead of [NSString initWithString:].

May 2, 2002:

4:57 PM Changeset in webkit [1090] by sullivan

• 17 edits
  2 adds in trunk/WebKit

• Bookmarks.subproj/IFBookmark.h:
• Bookmarks.subproj/IFBookmark.m: (-[IFBookmark setTitle:]): (-[IFBookmark setImage:]): (-[IFBookmark setURLString:]): (-[IFBookmark insertChild:atIndex:]): (-[IFBookmark removeChild:]): (-[IFBookmark _parent]): (-[IFBookmark _group]):
• Bookmarks.subproj/IFBookmarkGroup.h:
• Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _resetTopBookmark]): (-[IFBookmarkGroup _bookmarkDidChange:]): (-[IFBookmarkGroup _bookmarkChildrenDidChange:]): (-[IFBookmarkGroup removeBookmark:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:image:URLString:isLeaf:]):
• Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf setTitle:]): (-[IFBookmarkLeaf setImage:]): (-[IFBookmarkLeaf setURLString:]):
• Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList setTitle:]): (-[IFBookmarkList setImage:]): (-[IFBookmarkList removeChild:]): (-[IFBookmarkList insertChild:atIndex:]):
• Bookmarks.subproj/IFBookmark_Private.h: Made _parent and _group private; made setTitle, setImage, setURLString, insertChild:atIndex:, and removeChild: public.

• Bookmarks.subproj/IFBookmarkGroup_Private.h: Added.
• WebKit.pbproj/project.pbxproj: Changed for new file.

3:31 PM Changeset in webkit [1089] by sullivan

• 4 edits in trunk/WebKit

Implemented removing the root node bookmark (i.e.,
removing all bookmarks with one call).

• Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _resetTopBookmark]): New method, releases old topBookmark and creates new one. (-[IFBookmarkGroup initWithFile:]): Call _resetTopBookmark. (-[IFBookmarkGroup removeBookmark:]): If the bookmark being removed is the top one, call _resetTopBookmark.

Added "Erase All Bookmarks" menu item to Debug menu, which will be
handy in the interim between making bookmarks persistent and making
them organizable (they are neither yet).

Along the way, made DebugUtilities be a shared instance instead of
a collection of class methods, to make some innards easier to
implement.

• Debug/DebugUtilities.h: new class method sharedDebugUtilities; changed other class methods to instance methods; made _debugMenu an instance variable.

• Debug/DebugUtilities.m: (-[DebugUtilities dealloc]): release _debugMenu. (+[DebugUtilities sharedDebugUtilities]): New method. (-[DebugUtilities addDebugBookmarkToMenu:forURL:keyEquivalent:]): (-[DebugUtilities pathForDebugBookmarks]): (-[DebugUtilities loadDebugBookmarks]): (-[DebugUtilities conditionallyDisplayPageLoadTestWindow]): Changed class methods to instance methods. Also updated private AppController method name that had changed, causing the debug bookmarks to become disabled with my last checkin. (-[DebugUtilities eraseAllBookmarks:]): New method. (-[DebugUtilities createDebugMenu]): Add "Erase All Bookmarks" menu item, with -eraseAllBookmarks as callback.

• AppController.m: (-[AppController awakeFromNib]): use sharedDebugUtilities where a class method used to work.

12:53 PM Changeset in webkit [1088] by sullivan

• 18 edits in trunk/WebKit

Some more implementation of bookmarks code, enough to support
adding bookmarks to the Bookmarks menu (but not yet enough to
support persistent bookmarks).

• Bookmarks.subproj/IFBookmark_Private.h:
• Bookmarks.subproj/IFBookmark.h:
• Bookmarks.subproj/IFBookmark.m: (-[IFBookmark numberOfChildren]): New public method, stub implementation. (-[IFBookmark _removeChild:]): New private method, stub implementation.

• Bookmarks.subproj/IFBookmarkGroup.h:
• Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _sendBookmarkGroupChangedNotification]): (-[IFBookmarkGroup removeBookmark:]): (-[IFBookmarkGroup addNewBookmarkToBookmark:withTitle:image:URLString:isLeaf:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:image:URLString:isLeaf:]): (-[IFBookmarkGroup updateBookmark:title:image:URLString:]): Changed "URL" to "URLString" in several places, added a "with" to some parameter names; added addNewBookmarkToBookmark public method; added notification that's sent when bookmarks are added or removed.

• Bookmarks.subproj/IFBookmarkLeaf.h:
• Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf initWithURLString:title:image:group:]): Added image parameter.

• Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList numberOfChildren]): New method. (-[IFBookmarkList _removeChild:]): Implemented.

Fixed 2917086 (Add Bookmark is not yet implemented). You
can now add bookmarks to the Bookmarks menu, and they work.
However, they aren't yet persistent, and there's only a flat
list that you can't yet reorder.

• AppController.h: Added instance variables for bookmarks stuff; added +standardBookmarks method.

• AppController.m: (-[AppController awakeFromNib]): Move history notification setup from here to -webHistory; added call to _updateBookmarksInMenu, and FIXME about doing this lazily eventually. (-[AppController dealloc]): release bookmarks. (-[AppController webHistory]): Moved history notification setup to here. (-[AppController menuTitleForURL:withTitle:]): Improved assert.

(-[AppController _setUpStringTruncator]):
(-[AppController _historyFilePath]):
(-[AppController _receivedHistoryChangedNotification:]):
(-[AppController _insertHistoryEntry:intoMenu:atIndex:]):
(-[AppController _insertItemsForDate:intoMenu:atIndex:withRunningTotal:limit:]):
(-[AppController _insertSubmenu:forDate:atIndex:]):
(-[AppController _takeLocationFromHistoryEntry:]):
(-[AppController _addHistoryToMenu]):
(-[AppController _updateHistoryInMenu]):
Added leading underscores to private methods, updated callers.

(-[AppController _standardBookmarksFilePath]):
(-[AppController _removeBookmarksFromMenu]):
(-[AppController _takeLocationFromBookmark:]):
(-[AppController _insertBookmark:intoMenu:atIndex:]):
(-[AppController _addBookmarksToMenu]):
(-[AppController _updateBookmarksInMenu]):
(-[AppController _receivedBookmarksChangedNotification:]):
(-[AppController standardBookmarks]): New methods.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument addBookmark:]): New method; accessed from menu item. (-[BrowserDocument validateUserInterfaceItem:]): Enable Add Bookmark menu item only when there's a currentURL.

• English.lproj/MainMenu.nib: Wire up some bookmark-related stuff.

• WebBrowser.pbproj/project.pbxproj: Version wars?

Apr 30, 2002:

4:50 PM Changeset in webkit [1087] by sullivan

• 3 edits
  19 adds in trunk/WebKit

Fixed silly bug Darin noticed by inspection where I was
doing string == @"" instead of [string length] == 0.

• BrowserWindow.m: (-[BrowserWindow setStatus:]):

Added initial set of files/API and some of the code for
bookmarks support. Nobody calls it yet, but it compiles.
I wanted to get this in before I ran into project file
merge conflicts.

• Bookmarks.subproj/IFBookmark.h: Added.
• Bookmarks.subproj/IFBookmark_Private.h: Added.
• Bookmarks.subproj/IFBookmark.m: Added. (-[IFBookmark dealloc]): (-[IFBookmark title]): (-[IFBookmark _setTitle:]): (-[IFBookmark image]): (-[IFBookmark _setImage:]): (-[IFBookmark isLeaf]): (-[IFBookmark URLString]): (-[IFBookmark _setURLString:]): (-[IFBookmark children]): (-[IFBookmark _insertChild:atIndex:]): (-[IFBookmark parent]): (-[IFBookmark _setParent:]): (-[IFBookmark group]): (-[IFBookmark _setGroup:]):
• Bookmarks.subproj/IFBookmarkGroup.h: Added.
• Bookmarks.subproj/IFBookmarkGroup.m: Added. (+[IFBookmarkGroup bookmarkGroupWithFile:]): (-[IFBookmarkGroup initWithFile:]): (-[IFBookmarkGroup dealloc]): (-[IFBookmarkGroup topBookmark]): (-[IFBookmarkGroup insertBookmark:atIndex:ofBookmark:]): (-[IFBookmarkGroup removeBookmark:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:title:image:URL:isLeaf:]): (-[IFBookmarkGroup updateBookmark:title:image:URL:]): (-[IFBookmarkGroup file]): (-[IFBookmarkGroup loadBookmarkGroup]): (-[IFBookmarkGroup saveBookmarkGroup]):
• Bookmarks.subproj/IFBookmarkLeaf.h: Added.
• Bookmarks.subproj/IFBookmarkLeaf.m: Added. (-[IFBookmarkLeaf dealloc]): (-[IFBookmarkLeaf title]): (-[IFBookmarkLeaf _setTitle:]): (-[IFBookmarkLeaf image]): (-[IFBookmarkLeaf _setImage:]): (-[IFBookmarkLeaf isLeaf]): (-[IFBookmarkLeaf URLString]): (-[IFBookmarkLeaf _setURLString:]):
• Bookmarks.subproj/IFBookmarkList.h: Added.
• Bookmarks.subproj/IFBookmarkList.m: Added. (-[IFBookmarkList initWithTitle:image:group:]): (-[IFBookmarkList dealloc]): (-[IFBookmarkList title]): (-[IFBookmarkList _setTitle:]): (-[IFBookmarkList image]): (-[IFBookmarkList _setImage:]): (-[IFBookmarkList isLeaf]): (-[IFBookmarkList children]): (-[IFBookmarkList _insertChild:atIndex:]):

• WebKit.pbproj/project.pbxproj: Updated for new files.