Timeline



May 6, 2002:

6:27 PM Changeset in webkit [1103] by sullivan
  • 8 edits in trunk/WebKit

Some improvements to the bookmark changed notifications.

  • Bookmarks.subproj/IFBookmarkGroup.h:
  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _sendChangeNotificationForBookmark:childrenChanged:]): (-[IFBookmarkGroup _setTopBookmark:]): (-[IFBookmarkGroup _bookmarkDidChange:]): (-[IFBookmarkGroup _bookmarkChildrenDidChange:]): Send bookmark that changed and whether its children changed as part of change notifications, so clients can choose to do less unnecessary work.
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf setTitle:]): Check for the no-change case and bail out without sending notification when you find it.

Fixed 2919147 (Organize Bookmarks menu item doesn't do anything).

First check-in of Bookmarks window. You can remove one or more bookmarks,
and you can edit the title & address of existing bookmarks, but that's all
so far. Removed the Erase All Bookmarks item from the Debug menu since you
can do it easily from the Bookmarks window now. Added keyboard equivalents
for the Bookmarks, History, and Activity Viewer windows in the style of
Mail. Also miscellaneous cleanups.

  • BookmarksController.h: Added.
  • BookmarksController.m: Added. (-[BookmarksController shouldCascadeWindows]): (-[BookmarksController _receivedBookmarksChangedNotification:]): (-[BookmarksController _setUpToolbar]): (-[BookmarksController windowDidLoad]): (-[BookmarksController dealloc]): (-[BookmarksController _removeAllBookmarks]): (-[BookmarksController _removeSelectedBookmarks:]): (-[BookmarksController outlineView:child:ofItem:]): (-[BookmarksController outlineView:isItemExpandable:]): (-[BookmarksController outlineView:numberOfChildrenOfItem:]): (-[BookmarksController outlineView:objectValueForTableColumn:byItem:]): (-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]): (-[BookmarksController outlineView:willDisplayCell:forTableColumn:item:]): (-[BookmarksController toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[BookmarksController toolbarAllowedItemIdentifiers:]): (-[BookmarksController toolbarDefaultItemIdentifiers:]): (-[BookmarksController toolbarDidRemoveItem:]): (-[BookmarksController toolbarWillAddItem:]): (-[BookmarksController validateUserInterfaceItem:]): New class that manages the Bookmarks window.
  • AppController.h:
  • AppController.m: (-[AppController dealloc]): release bookmarks controller. (-[AppController showBookmarks:]): create bookmarks controller if necessary, and tell it to show its window.
  • BrowserWindow.m: Changed static strings to #defines. (-[BrowserWindow setUpToolbar]): Remove call that explicitly sets toolbar display mode; we've no reason to override the default.
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Remove Erase All Bookmarks.
  • English.lproj/Bookmarks.nib: New nib file for Bookmarks window.
  • English.lproj/MainMenu.nib: Wired up "Organize Bookmarks..." and "Bookmarks" menu items; added keyboard shortcuts for Window menu items.
  • GlobalHistory.m: (-[GlobalHistory outlineView:objectValueForTableColumn:byItem:]): Changed two isEquals to isEqualToStrings. (-[GlobalHistory _anyURLsSelected]): Replaced anyDatesSelected with this. (-[GlobalHistory updateButtons]): Allow Add to Bookmarks to be enabled even if some dates are selected; just ignore them (at least one non-date has to be selected). (-[GlobalHistory addSelectedItemsToBookmarks:]): Removed obsolete comment.
  • Resources/Images/delete.tiff: New image, stolen for mail, used in Bookmarks window.
  • WebBrowser.pbproj/project.pbxproj: Updated for new files.
4:40 PM Changeset in webkit [1102] by darin
  • 55 edits
    3 adds in trunk

i * Makefile.am: Generate the PFE precompiled headers to be used

by automake compiles. Currently these don't have any dependency
tracking, but I'm sure Maciej can fix that if he wants to.

  • configure.in: Go from "xNDEBUG" to "NDEBUG" now that precompiled headers aren't in the way. Pass in the --load-pch option to all the various compiles so they get the precompiled headers.
  • Tests/libiftest/Makefile.am: Generate a top_srcdir.h file rather than passing it in on the command line. This works around a PFE bug with -D, Radar 2921026.
  • Tests/libiftest/IFTestDirectory.c: Use top_srcdir.h.
  • Tests/libiftest/.cvsignore: Ignore top_srcdir.h.
  • Tests/qt/qpoint-test.cpp: (main): Take out an unused variable and all the USING_BORROWED_QPOINT code.
  • Tools/Makefile.am: Don't built the HotSpots directory for now, since it runs into a PFE bug and we usually use the application version now.
  • Tools/Scripts/check-non-ASCII: Skip preprocessor directives.
  • Tools/Scripts/cvs-abandon: Tweak.

JavaScriptCore:

  • JavaScriptCorePrefix.h: Added.
  • JavaScriptCore.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.

WebFoundation:

Reviewed by Ken Kocienda:

  • WebFoundationPrefix.h: Added.
  • WebFoundation.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.
  • AuthenticationManager.subproj/IFAuthenticationManager.m:
  • CookieManager.subproj/IFCookie.m:
  • Misc.subproj/IFNSStringExtensions.m:
  • Misc.subproj/WebFoundationDebug.m: Add undefs to work around PFE problem with inline functions, Radar 2920554.
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m: Fix include to work with normal Project Builder way of dealing with frameworks. Switch from xNDEBUG to NDEBUG.
  • CacheLoader.subproj/IFURLLoad.m:
  • CookieManager.subproj/IFCookie.m:
  • Database.subproj/IFURLFileDatabase.m:
  • Misc.subproj/IFError.m:
  • Misc.subproj/IFMonitor.h:
  • Misc.subproj/IFMonitor.m:
  • Misc.subproj/IFRecursiveReadWriteLock.h: Use import instead of include.
  • Misc.subproj/IFCFNetworkExtensions.m: Added.
  • Misc.subproj/IFCFRunLoopExtensions.m: Added.
  • Misc.subproj/IFCFNetworkExtensions.c: Removed.
  • Misc.subproj/IFCFRunLoopExtensions.c: Removed. Renamed so we could share the Objective-C precompile. No need to compile this code as plain C, even though it doesn't use any Objective-C features.
  • Misc.subproj/WebFoundationDebug.h: Get rid of format attribute because of bug
  1. Switch from xNDEBUG to NDEBUG.

WebCore:

  • WebCorePrefix.h: Added.
  • .cvsignore: Ignore the .pfe files in this directory.
  • khtml/dom/dom_doc.cpp:
  • khtml/dom/dom_text.cpp: Added namespace directives as a clean workaround for a conflict with the struct named Comment in <Carbon/AIFF.h>
  • kwq/KWQFont.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQKGlobal.mm:
  • kwq/KWQListImpl.mm:
  • kwq/KWQPtrDictImpl.h:
  • kwq/KWQVectorImpl.mm:
  • kwq/kwqdebug.h:
  • kwq/qt/qcolor.h:
  • kwq/qt/qcombobox.h:
  • kwq/qt/qregion.h:
  • kwq/qt/qstring.h:
  • kwq/qt/qwidget.h: Remove old workaround for conflicts with Fixed, Rect, and Boolean. It does not good with a precompiled header anyway, and there is a more elegant small fix in the KDE code itself.
  • kwq/qt/qpoint.h:
  • kwq/KWQPointArray.mm: (QPointArray::setPoints): Work around bug with va_arg and PFE by not using varargs here.
  • kwq/KWQRect.mm: (QRect::unite): (QRect::operator&): Use std::min and std::max instead of defining our own MIN and MAX, which conflict with something in one of the headers we are precompiling (error message did not make it clear which).
  • kwq/KWQView.mm: (-[KWQHTMLView layout]), (-[KWQHTMLView drawRect:]): Switch from xNDEBUG to NDEBUG.
  • kwq/Makefile.am: Remove stuff for getting at the header inside the ApplicationServices and QD frameworks, since that code is now in WebKit.
  • kwq/kwqdebug.h: Get rid of format attribute because of bug 2920557. Switch from xNDEBUG to NDEBUG.
  • kwq/kwqdebug.mm: Switch from xNDEBUG to NDEBUG.
  • kwq/qt/qstring.h: Define QT_VERSION in here instead of on the command line to work around a PFE bug with -D, Radar 2921026.

WebKit:

  • WebKitPrefix.h: Added.
  • WebKit.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.
  • Misc.subproj/WebKitDebug.h: Get rid of format attribute because of bug
  1. Switch from xNDEBUG to NDEBUG.
  • Misc.subproj/WebKitDebug.m: Add undef to work around PFE problem with inline functions, Radar 2920554.
  • Plugins.subproj/IFPluginView.mm: Changed how we work around the bug in the CGS defines.
  • WebCoreSupport.subproj/IFCachedTextRenderer.h: Change include of the private QD header to use the form that works with more-normal way of getting at the private bits of frameworks.
  • WebCoreSupport.subproj/IFCachedTextRenderer.m: Use the header <CoreGraphics/CoreGraphicsPrivate.h> instead of <CoreGraphics/CGFontPrivate.h>.
  • Misc.subproj/IFCache.mm:
  • WebView.subproj/IFLoadProgress.mm:
  • WebView.subproj/IFWebFrame.mm:
  • WebView.subproj/IFWebFramePrivate.mm:
  • WebView.subproj/IFWebView.mm: Changed includes to imports.

WebBrowser:

  • WebBrowserPrefix.h: Added.
  • WebBrowser.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.
  • Debug/CacheController.m: Renamed to make it Objective C rather than Objective C++.
  • Debug/CacheController.mm: Removed.
  • main.m: Use the real CFA2UC. Use import instead of include.
  • _CFA2UC.c: Remove our copy.
  • Debug/DOMTree.mm:
  • Debug/RenderTree.mm:
  • Preferences.subproj/ActiveContentPreferences.h:
  • Preferences.subproj/AppearancePreferences.h:
  • Preferences.subproj/GeneralPreferences.h:
  • Preferences.subproj/SecurityPreferences.h:
  • Preferences.subproj/TextPreferences.h:
  • Preferences.subproj/WBPreferences.h:
  • Test/PageLoadTestLogger.m: Use import instead of include.
4:14 PM Changeset in webkit [1101] by cblu
  • 8 edits in trunk/WebKit

Made start and stop work cleaner.

Now observe defaults changes so that plug-ins
are disabled or enabled immediately (2871725).

  • Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender sendNullEvents]):
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): (-[IFPluginView start]): (-[IFPluginView stop]): (-[IFPluginView drawRect:]): (-[IFPluginView windowWillClose:]): (-[IFPluginView defaultsHaveChanged:]):
3:56 PM Changeset in webkit [1100] by rjw
  • 3 edits in trunk/WebKit

Fixed width measurement regression. We lost the final ROUND_TO_INT
in the width measurement funtion after the move from WebCore.

1:49 PM Changeset in webkit [1099] by rjw
  • 19 edits in trunk

Changes to support dhmtl.
Changes to support targeting (regression after 3.0 merge).

9:31 AM Changeset in webkit [1098] by sullivan
  • 3 edits in trunk/WebKit
  • Resources/url_icon.tiff: New bookmarks/history icon, looks more like the springy @ sign as seen from above, less like text.

May 3, 2002:

5:27 PM Changeset in webkit [1097] by darin
  • 6 edits in trunk/WebCore
  • khtml/css/cssstyleselector.cpp:
  • khtml/dom/css_value.cpp:
  • khtml/xml/dom_stringimpl.cpp: Put in some namespace-related statements to more-elegantly work around the conflicts between Macintosh and khtml identifiers.
4:05 PM Changeset in webkit [1096] by sullivan
  • 17 edits in trunk/WebKit

Along with small corresponding WebBrowser change,
fixed 2919172 (Bookmarks aren't saved between sessions).

  • Bookmarks.subproj/IFBookmark_Private.h: Declarations for new private methods.
  • Bookmarks.subproj/IFBookmark.m: (-[IFBookmark _numberOfDescendants]): New private method, counts deep; used only for debugging messages at this time. (-[IFBookmark _initFromDictionaryRepresentation:withGroup:]): (-[IFBookmark _dictionaryRepresentation]): New private methods used to save/load bookmarks. Stub implementations; subclasses must implement.
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf _initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkLeaf _dictionaryRepresentation]): New methods.
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList _initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkList _dictionaryRepresentation]): (-[IFBookmarkList _numberOfDescendants]): New methods. (-[IFBookmarkList _setGroup:]): Recurse on children.
  • Bookmarks.subproj/IFBookmarkGroup.h: New _loading instance variable.
  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _setTopBookmark:]): Renamed from _resetTopBookmark, now has potentially non-nil argument. (-[IFBookmarkGroup initWithFile:]), (-[IFBookmarkGroup removeBookmark:]): Updated for name change. (-[IFBookmarkGroup _sendBookmarkGroupChangedNotification]): Don't send notifications while loading bookmarks from disk. (-[IFBookmarkGroup _loadBookmarkGroupGuts]), (-[IFBookmarkGroup loadBookmarkGroup]), (-[IFBookmarkGroup _saveBookmarkGroupGuts]), (-[IFBookmarkGroup saveBookmarkGroup]): New methods, load/save bookmarks and report timings.
  • History.subproj/IFURIEntry.m: (-[IFURIEntry dictionaryRepresentation]), (-[IFURIEntry initFromDictionaryRepresentation:]): Handle nil URL case, which bookmarks run into.
  • WebKit.pbproj/project.pbxproj: version wars
  • AppController.m: (-[AppController applicationWillTerminate:]): Save bookmarks at quit time.
  • WebBrowser.pbproj/project.pbxproj: version wars
2:52 PM Changeset in webkit [1095] by darin
  • 3 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFCachedTextRenderer.m: Remove some of the unused code. I was going to wait and let Richard do it next week, but I was unable to control my urge to hack on it.
12:03 PM Changeset in webkit [1094] by darin
  • 3 edits in trunk/WebKit
  • Resources/url_icon.tiff: Improved icon. Could be better.
11:42 AM Changeset in webkit [1093] by darin
  • 1 edit in trunk/WebKit/Resources/url_icon.tiff

Revert icon, oops.

11:36 AM Changeset in webkit [1092] by darin
  • 26 edits
    8 adds
    5 deletes in trunk

WebCore:

  • kwq/IFTextRenderer.h: Added.
  • kwq/IFTextRendererFactory.h: Added.
  • kwq/IFTextRendererFactory.m: Added. These three are the new API for supplying text rendering machinery for WebCore. The implementation is in WebKit. Later we might want to flesh out the default implementation in WebCore so that it works OK by itself.
  • khtml/rendering/font.cpp: (Font::width): Function is now "width" without an underscore. We don't really need to hide the overload we added in this case.
  • kwq/qt/qfont.h: Simplify a lot. Doesn't hold an NSFont any more.
  • kwq/KWQFont.mm: (QFont::QFont): Eliminated the concept of "default font". Also, a QFont no longer holds an NSFont object. That's handled inside IFTextRenderer machinery. (QFont::~QFont): Simplify since we don't have an NSFont. (QFont::setFamily): Simplify since we don't have an NSFont. (QFont::setPixelSize): Simplify since we don't have an NSFont. (QFont::setPixelSizeFloat): Simplify since we don't have an NSFont. (QFont::setWeight): Simplify since we don't have an NSFont. (QFont::weight): Fix a bug where it would return Normal for a QFont that was both bold and italic. (QFont::setItalic): Simplify since we don't have an NSFont. (QFont::italic): Simplify since we have real "bool". (QFont::bold): Simplify since we have real "bool". (QFont::operator=): Simplify since we don't have an NSFont. (QFont::operator==): Rewrite since we don't have an NSFont.
  • kwq/qt/qfontmetrics.h: Simplify a little. The _width() method is now just an overload of the width() method. The main change was removing the include of Cocoa.h.
  • kwq/KWQFontMetrics.mm: Move most of the code out of here into WebKit. (QFontMetrics::ascent): Get it from the renderer. (QFontMetrics::descent): Get it from the renderer. (QFontMetrics::lineSpacing): Get it from the renderer. (QFontMetrics::width): Get it from the renderer. (QFontMetrics::boundingRect): Combine width and height that came from the renderer. (QFontMetrics::size): Combine width and height that came from the renderer.
  • kwq/Makefile.am: Add IFTextRendererFactory.m, remove KWQTextStorage.mm and KWQTextContainer.mm.
  • kwq/KWQMetrics.h: Removed.
  • kwq/KWQTextContainer.h: Removed.
  • kwq/KWQTextContainer.mm: Removed.
  • kwq/KWQTextStorage.h: Removed.
  • kwq/KWQTextStorage.mm: Removed.
  • kwq/KWQPainter.mm: Move most of the code out of here into WebKit. (QPainter::drawText): Call the renderer to do it. (QPainter::drawUnderlineForText): Call the renderer to do it.
  • libwebcore.exp: Export the IFTextRendererFactory class.

WebKit:

  • Misc.subproj/WebKitDebug.h: Add WEBKIT_LOG_MEMUSAGE, WEBKIT_LOG_FONTCACHE, and WEBKIT_LOG_FONTCACHECHARMISS for font code moved here from WebCore.
  • Resources/url_icon.tiff: New URL icon?
  • WebCoreSupport.subproj/IFCachedTextRenderer.h: Added.
  • WebCoreSupport.subproj/IFCachedTextRenderer.m: Added.
  • WebCoreSupport.subproj/IFCachedTextRendererFactory.h: Added.
  • WebCoreSupport.subproj/IFCachedTextRendererFactory.m: Added. This has code moved here from WebCore.
  • WebKit.pbproj/project.pbxproj: Add the new source files.
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf setURLString:]): Use copy instead of initWithString.
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList initWithTitle:image:group:]): Use copy instead of stringWithString. (-[IFBookmarkList setTitle:]): Use copy instead of stringWithString.
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setTitle:]): Use mutableCopy instead of stringWithString.
  • WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): Use copy instead of stringWithString.
11:07 AM Changeset in webkit [1091] by darin
  • 1 edit in trunk/WebKit/Misc.subproj/WebDatabase.m
  • AuthenticationManager.subproj/IFAuthenticationRequest.m: (-[IFAuthenticationRequest initWithURL:realm:username:passwordSentInClear:previousFailures:callback:]):
  • AuthenticationManager.subproj/IFAuthenticationResult.m: (-[IFAuthenticationResult initWithUsername:password:]):
  • Database.subproj/IFDatabase.m: (-[IFDatabase initWithPath:]): Simplify code by using [copy] instead of [NSString initWithString:].

May 2, 2002:

4:57 PM Changeset in webkit [1090] by sullivan
  • 17 edits
    2 adds in trunk/WebKit
  • Bookmarks.subproj/IFBookmark.h:
  • Bookmarks.subproj/IFBookmark.m: (-[IFBookmark setTitle:]): (-[IFBookmark setImage:]): (-[IFBookmark setURLString:]): (-[IFBookmark insertChild:atIndex:]): (-[IFBookmark removeChild:]): (-[IFBookmark _parent]): (-[IFBookmark _group]):
  • Bookmarks.subproj/IFBookmarkGroup.h:
  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _resetTopBookmark]): (-[IFBookmarkGroup _bookmarkDidChange:]): (-[IFBookmarkGroup _bookmarkChildrenDidChange:]): (-[IFBookmarkGroup removeBookmark:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:image:URLString:isLeaf:]):
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf setTitle:]): (-[IFBookmarkLeaf setImage:]): (-[IFBookmarkLeaf setURLString:]):
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList setTitle:]): (-[IFBookmarkList setImage:]): (-[IFBookmarkList removeChild:]): (-[IFBookmarkList insertChild:atIndex:]):
  • Bookmarks.subproj/IFBookmark_Private.h: Made _parent and _group private; made setTitle, setImage, setURLString, insertChild:atIndex:, and removeChild: public.
  • Bookmarks.subproj/IFBookmarkGroup_Private.h: Added.
  • WebKit.pbproj/project.pbxproj: Changed for new file.
3:31 PM Changeset in webkit [1089] by sullivan
  • 4 edits in trunk/WebKit

Implemented removing the root node bookmark (i.e.,
removing all bookmarks with one call).

  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _resetTopBookmark]): New method, releases old topBookmark and creates new one. (-[IFBookmarkGroup initWithFile:]): Call _resetTopBookmark. (-[IFBookmarkGroup removeBookmark:]): If the bookmark being removed is the top one, call _resetTopBookmark.

Added "Erase All Bookmarks" menu item to Debug menu, which will be
handy in the interim between making bookmarks persistent and making
them organizable (they are neither yet).

Along the way, made DebugUtilities be a shared instance instead of
a collection of class methods, to make some innards easier to
implement.

  • Debug/DebugUtilities.h: new class method sharedDebugUtilities; changed other class methods to instance methods; made _debugMenu an instance variable.
  • Debug/DebugUtilities.m: (-[DebugUtilities dealloc]): release _debugMenu. (+[DebugUtilities sharedDebugUtilities]): New method. (-[DebugUtilities addDebugBookmarkToMenu:forURL:keyEquivalent:]): (-[DebugUtilities pathForDebugBookmarks]): (-[DebugUtilities loadDebugBookmarks]): (-[DebugUtilities conditionallyDisplayPageLoadTestWindow]): Changed class methods to instance methods. Also updated private AppController method name that had changed, causing the debug bookmarks to become disabled with my last checkin. (-[DebugUtilities eraseAllBookmarks:]): New method. (-[DebugUtilities createDebugMenu]): Add "Erase All Bookmarks" menu item, with -eraseAllBookmarks as callback.
  • AppController.m: (-[AppController awakeFromNib]): use sharedDebugUtilities where a class method used to work.
12:53 PM Changeset in webkit [1088] by sullivan
  • 18 edits in trunk/WebKit

Some more implementation of bookmarks code, enough to support
adding bookmarks to the Bookmarks menu (but not yet enough to
support persistent bookmarks).

  • Bookmarks.subproj/IFBookmark_Private.h:
  • Bookmarks.subproj/IFBookmark.h:
  • Bookmarks.subproj/IFBookmark.m: (-[IFBookmark numberOfChildren]): New public method, stub implementation. (-[IFBookmark _removeChild:]): New private method, stub implementation.
  • Bookmarks.subproj/IFBookmarkGroup.h:
  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _sendBookmarkGroupChangedNotification]): (-[IFBookmarkGroup removeBookmark:]): (-[IFBookmarkGroup addNewBookmarkToBookmark:withTitle:image:URLString:isLeaf:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:image:URLString:isLeaf:]): (-[IFBookmarkGroup updateBookmark:title:image:URLString:]): Changed "URL" to "URLString" in several places, added a "with" to some parameter names; added addNewBookmarkToBookmark public method; added notification that's sent when bookmarks are added or removed.
  • Bookmarks.subproj/IFBookmarkLeaf.h:
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf initWithURLString:title:image:group:]): Added image parameter.
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList numberOfChildren]): New method. (-[IFBookmarkList _removeChild:]): Implemented.

Fixed 2917086 (Add Bookmark is not yet implemented). You
can now add bookmarks to the Bookmarks menu, and they work.
However, they aren't yet persistent, and there's only a flat
list that you can't yet reorder.

  • AppController.h: Added instance variables for bookmarks stuff; added +standardBookmarks method.
  • AppController.m: (-[AppController awakeFromNib]): Move history notification setup from here to -webHistory; added call to _updateBookmarksInMenu, and FIXME about doing this lazily eventually. (-[AppController dealloc]): release bookmarks. (-[AppController webHistory]): Moved history notification setup to here. (-[AppController menuTitleForURL:withTitle:]): Improved assert.

(-[AppController _setUpStringTruncator]):
(-[AppController _historyFilePath]):
(-[AppController _receivedHistoryChangedNotification:]):
(-[AppController _insertHistoryEntry:intoMenu:atIndex:]):
(-[AppController _insertItemsForDate:intoMenu:atIndex:withRunningTotal:limit:]):
(-[AppController _insertSubmenu:forDate:atIndex:]):
(-[AppController _takeLocationFromHistoryEntry:]):
(-[AppController _addHistoryToMenu]):
(-[AppController _updateHistoryInMenu]):
Added leading underscores to private methods, updated callers.

(-[AppController _standardBookmarksFilePath]):
(-[AppController _removeBookmarksFromMenu]):
(-[AppController _takeLocationFromBookmark:]):
(-[AppController _insertBookmark:intoMenu:atIndex:]):
(-[AppController _addBookmarksToMenu]):
(-[AppController _updateBookmarksInMenu]):
(-[AppController _receivedBookmarksChangedNotification:]):
(-[AppController standardBookmarks]): New methods.

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument addBookmark:]): New method; accessed from menu item. (-[BrowserDocument validateUserInterfaceItem:]): Enable Add Bookmark menu item only when there's a currentURL.
  • English.lproj/MainMenu.nib: Wire up some bookmark-related stuff.
  • WebBrowser.pbproj/project.pbxproj: Version wars?
Note: See TracTimeline for information about the timeline view.