Timeline



May 9, 2002:

8:18 PM Changeset in webkit [1125] by rjw
  • 5 edits in trunk/WebCore

i Added new method to avoid creation of NSString.

8:18 PM Changeset in webkit [1124] by rjw
  • 6 edits in trunk/WebKit

Tuned implementation more. Cleaned up and factored code.

6:35 PM Changeset in webkit [1123] by sullivan
  • 6 edits in trunk/WebKit
  • Bookmarks.subproj/IFBookmarkGroup.h:
  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup addNewBookmarkToBookmark:withTitle:image:URLString:isLeaf:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:image:URLString:isLeaf:]): Gave these two methods return values of the new bookmark created, to make callers' lives easier.

More work on bookmarks; you can now create new ones and new folders
from the Bookmarks window. You still can't reorder them by dragging.
There are many details wrong still, including some obvious ones.

Fixed these radar bugs along the way:
2921389 -- No way to create a folder in Bookmarks window
2923495 -- Shouldn't be able to create bookmarks with no title and/or URL string

Also improved what Activity Viewer shows for errors that had no description
(was "(null)", now is "error").

  • AppController.m: (-[AppController _insertBookmark:intoMenu:atIndex:]): Made this method handle non-leaf bookmarks (i.e., folders)
  • BookmarksController.m: (-[BookmarksController _collapseSelectionToSingleRow]): New helper routine that always ends up with a single row selected (unless outline view is empty).

(-[BookmarksController _removeSelectedBookmarks:]):
Call _collapseSelectionToSingleRow after removing selected items.

(-[BookmarksController _toggleEdit:]):
New method, turns edit mode on or off for the selected item.

(-[BookmarksController _findParentRowOfRow:]):
New helper routine for finding the row index that's the parent of
a given row.

(-[BookmarksController _newItemWithTitle:image:URLString:isLeaf:]):
Bottleneck for new-item-creating methods, finds appropriate place to
insert new item based on current selection, inserts it, selects it,
and puts its name into edit mode.

(-[BookmarksController _newSeparator:]):
New method, placeholder for now.

(-[BookmarksController _newFolder:]):
(-[BookmarksController _newBookmark:]):
Implement by calling _newItemWithTitle:

(-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]):
If new value after trimming whitespace is empty, ignore it.

(-[BookmarksController outlineView:shouldEditTableColumn:item:]):
Don't allow address cell of folder rows to be edited.

(-[BookmarksController toolbarAllowedItemIdentifiers:]):
New set of buttons is: New Bookmark, New Folder, Modify, Remove

(-[BookmarksController validateUserInterfaceItem:]):
Disable Modify when nothing is selected.

  • English.lproj/Bookmarks.nib: I don't remember what I changed here, possibly nothing real.
  • IFErrorAdditions.h: Added.
  • IFErrorAdditions.m: Added. (-[IFError errorSummary]): New category on IFError, implements just this one method, which returns a string of the form "<error description> (<error code>)" and handles the case where there's no description.
  • FrameProgressEntry.m: (-[FrameProgressEntry statusString]): use errorSummary.
  • ResourceProgressEntry.m: (-[ResourceProgressEntry statusString]): use errorSummary.
  • GlobalHistory.m: (-[GlobalHistory showWindow:]): Changed an NSLog to a WEBKITDEBUG
  • WebBrowser.pbproj/project.pbxproj: Updated for new files.
12:42 PM Changeset in webkit [1122]
  • 1 copy
    34 deletes in tags/WebFoundation-5

This commit was manufactured by cvs2svn to create tag
'WebFoundation-5'.

12:42 PM Changeset in webkit [1121]
  • 1 copy
    34 deletes in tags/WebFoundation-4

This commit was manufactured by cvs2svn to create tag
'WebFoundation-4'.

12:42 PM Changeset in webkit [1120] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Chris Blumenberg

Fix for this bug:

Radar 2922673 (Remove use of private NSData interface in IFURLFileDatabase.m)

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileReader initWithPath:]): Code now uses new Jaguar public API
12:25 PM Changeset in webkit [1119] by kocienda
  • 4 edits in trunk/WebCore

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2890624 (need to remove workaround for double free of image data from QPixmap)

The appropriate, bug-free AppKit code is now available to us on Jaguar.
Rolling out the workaround.

  • kwq/KWQPixmap.mm: (QPixmap::QPixmap)
9:43 AM Changeset in webkit [1118] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Tiny little string copying cleanup suggested by Darin.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase open]): small string copying cleanup.
9:35 AM Changeset in webkit [1117] by kocienda
  • 4 edits in trunk/WebKit/Misc.subproj

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Darin Adler

Fixes for these two bugs:

Radar 2859001 (Maintain usage calculation for on-disk cache)
Radar 2859009 (On-disk cache must be able to be truncated to a specific size)

Now, the on-disk database keeps track of the amount of data it stores and can enforce
a usage quota. This new system should work quite well as long as there is a one-to-one
mapping between processes and on-disk cache paths.

Further guarantees for synchronous access to a cache from multiple processes will be
offered if (when) we switch over to using the sleepycat Berkeley DB for the disk cache
implementation.

  • CacheLoader.subproj/IFURLDiskCache.m: (-[IFURLDiskCache initWithSizeLimit:path:]): Added code that calls into new database methods (-[IFURLDiskCache dealloc]): Added missing call to [super dealloc] (-[IFURLDiskCache setSizeLimit:]): New (-[IFURLDiskCache usage]): New
  • Database.subproj/IFDatabase.h:
  • Database.subproj/IFDatabase.m: (-[IFDatabase initWithPath:]): Added code to track size limit and usage (-[IFDatabase isOpen]): Added code to track size limit and usage (-[IFDatabase count]): New (-[IFDatabase sizeLimit]): New (-[IFDatabase setSizeLimit:]): New (-[IFDatabase usage]): New
  • Database.subproj/IFNDBMDatabase.h: Removed.
  • Database.subproj/IFNDBMDatabase.m: Removed.
  • Database.subproj/IFURLFileDatabase.h:
  • Database.subproj/IFURLFileDatabase.m: (+[IFURLFileDatabase uniqueFilePathForKey:]): Moved to private category (-[IFURLFileDatabase writeSizeFile:]): New (-[IFURLFileDatabase readSizeFile]): New (-[IFURLFileDatabase truncateToSizeLimit:]): New (-[IFURLFileDatabase initWithPath:]): Added code to deal with size reckoning (-[IFURLFileDatabase removeAllObjects]): Added code to deal with size reckoning (-[IFURLFileDatabase performSetObject:forKey:]): Added code to deal with size reckoning (-[IFURLFileDatabase performRemoveObjectForKey:]): Added code to deal with size reckoning (-[IFURLFileDatabase open]): Added code to deal with size reckoning (-[IFURLFileDatabase close]): Added code to deal with size reckoning (-[IFURLFileDatabase sync]): Added code to deal with size reckoning (-[IFURLFileDatabase count]): New (-[IFURLFileDatabase setSizeLimit:]): New
  • WebFoundation.pbproj/project.pbxproj: PB has its way again.
9:19 AM Changeset in webkit [1116]
  • 8 copies in tags/Alexander-3

This commit was manufactured by cvs2svn to create tag 'Alexander-3'.

9:19 AM Changeset in webkit [1115] by sheridan
  • 8 edits in trunk

Alexander-3 versioning

May 8, 2002:

8:05 PM Changeset in webkit [1114] by rjw
  • 6 edits in trunk/WebKit

Added optimizations for text rendering.

5:11 PM Changeset in webkit [1113] by darin
  • 7 edits in trunk/WebKit
  • Misc.subproj/IFCache.h: Add more JavaScript object statistics.
  • Misc.subproj/IFCache.mm: (+[IFCache javaScriptInterpretersCount]): New. (+[IFCache javaScriptNoGCAllowedObjectsCount]): New. (+[IFCache javaScriptReferencedObjectsCount]): New.
  • WebKit.pbproj/project.pbxproj: Rearranged two files, dunno why.
5:11 PM Changeset in webkit [1112] by darin
  • 5 edits in trunk/JavaScriptCore
  • kjs/collector.h:
  • kjs/collector.cpp: (Collector::numInterpreters): (Collector::numGCNotAllowedObjects): (Collector::numReferencedObjects): Add three new functions so we can see a bit more about leaking JavaScriptCore.
1:22 PM Changeset in webkit [1111] by cblu
  • 8 edits in trunk/WebKit

Cleaned up mach-o plug-in support.

Changed the init method in IFPlugin to initWithPath.

  • Plugins.subproj/IFPlugin.h:
  • Plugins.subproj/IFPlugin.m: (-[IFPlugin initWithPath:]): (-[IFPlugin load]):
  • Plugins.subproj/IFPluginDatabase.m: (findPlugins):
11:37 AM Changeset in webkit [1110] by darin
  • 2 edits in trunk/WebKit/WebView.subproj

Forgot include.

11:29 AM Changeset in webkit [1109] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setTitle:]): Use _IF_stringByTrimmingWhitespace.

May 7, 2002:

4:51 PM Changeset in webkit [1108] by rjw
  • 8 edits in trunk/WebKit

First pass at font substitution. Find a substitute font to
use when the specified font doesn't have glyphs for the characters that
need to be drawn.

Works correctly but hasn't been optimized yet, VERY slow.
Will optimize this evening and tomorrow. Try www.yahoo.co.jp,
it will take a long time to render be eventually will draw correctly.

4:36 PM Changeset in webkit [1107] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQFontMetrics.mm: Fixed storage leak by initializing refCount.
2:41 PM Changeset in webkit [1106] by darin
  • 3 edits
    4 adds
    2 deletes in trunk/WebKit

Oops. These files don't belong at the top level.

  • IFWebCoreViewFactory.h: Removed.
  • IFWebCoreViewFactory.m: Removed.
  • WebCoreSupport.subproj/IFWebCoreViewFactory.h: Added.
  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: Added.
  • WebKit.pbproj/project.pbxproj:
2:10 PM Changeset in webkit [1105] by darin
  • 23 edits
    26 adds
    13 deletes in trunk

WebCore:

Move more plugin code into WebKit.

Stop using IF for anything in WebCore to help make it clear what's part of
the BSD licensed stuff and what's part of our proprietary stuff.

  • libwebcore.exp: Names of what exported changed.
  • kwq/Makefile.am: Source file names changed.
  • kwq/IFTextRenderer.h: Renamed to WebCoreTextRenderer.
  • kwq/IFTextRendererFactory.h: Renamed to WebCoreTextRendererFactory.
  • kwq/IFTextRendererFactory.m: Renamed to WebCoreTextRendererFactory.
  • kwq/WebCoreTextRenderer.h: Renamed from IFTextRenderer.
  • kwq/WebCoreTextRendererFactory.h: Renamed from IFTextRendererFactory.
  • kwq/WebCoreTextRendererFactory.m: Renamed from IFTextRendererFactory.
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQPainter.mm: Updated for IF -> WebCore name change.
  • kwq/WebCoreViewFactory.h: Added.
  • kwq/WebCoreViewFactory.m: Added.
  • kwq/KWQKConfigBase.mm: (KConfig::readEntry): (KConfig::readNumEntry): Use the new [WebCoreViewFactory pluginsInfo] so we don't have to have the plugin database in WebCore any more.
  • kwq/WCJavaAppletWidget.h:
  • kwq/WCJavaAppletWidget.mm: (IFJavaAppletWidgetCreate):
  • kwq/WCPluginWidget.h:
  • kwq/WCPluginWidget.mm: (IFPluginWidgetCreate): Remove creation function machinery, and use the WebCoreViewFactory instead.
  • kwq/WCPlugin.h: Moved to WebKit.
  • kwq/WCPlugin.mm: Moved to WebKit.
  • kwq/WCPluginDatabase.h: Moved to WebKit.
  • kwq/WCPluginDatabase.mm: Moved to WebKit.
  • kwq/npapi.h: Moved to WebKit.
  • kwq/npapi.mm: Moved to WebKit.

WebKit:

Move more plugin code here from WebCore.

  • IFWebCoreViewFactory.h: Added.
  • IFWebCoreViewFactory.m: Added.
  • Plugins.subproj/IFPlugin.h: Moved from WebCore.
  • Plugins.subproj/IFPlugin.m: Moved from WebCore.
  • Plugins.subproj/IFPluginDatabase.h: Moved from WebCore.
  • Plugins.subproj/IFPluginDatabase.m: Moved from WebCore.
  • Plugins.subproj/npapi.h: Moved from WebCore.
  • Plugins.subproj/npapi.m: Moved from WebCore.
  • WebKit.pbproj/project.pbxproj: Source file names changed
  • MIME.subproj/IFMIMEDatabase.m:
  • MIME.subproj/IFMIMEHandler.m:
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: Updated for WC -> IF name change.
  • WebCoreSupport.subproj/IFCachedTextRenderer.h: Renamed to IFTextRenderer.
  • WebCoreSupport.subproj/IFCachedTextRenderer.m: Renamed to IFTextRenderer.
  • WebCoreSupport.subproj/IFCachedTextRendererFactory.h: Renamed to IFTextRendererFactory.
  • WebCoreSupport.subproj/IFCachedTextRendererFactory.m: Renamed to IFTextRendererFactory.
  • WebCoreSupport.subproj/IFTextRenderer.h: Renamed from IFCachedTextRenderer.
  • WebCoreSupport.subproj/IFTextRenderer.m: Renamed from IFCachedTextRenderer.
  • WebCoreSupport.subproj/IFTextRendererFactory.h: Renamed from IFCachedTextRendererFactory.
  • WebCoreSupport.subproj/IFTextRendererFactory.m: Renamed from IFCachedTextRendererFactory. Renamed to take "Cached" out of the name now that the simpler name is available.
  • WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): Create shared IFWebCoreViewFactory. (-[IFWebView delayLayout:]): Use WEBKITDEBUG, not KWQDEBUG. (-[IFWebView notificationReceived:]): Use WEBKITDEBUG, not KWQDEBUG.
8:56 AM Changeset in webkit [1104] by darin
  • 4 edits in trunk/WebKit
  • Tools/Scripts/cvs-fix-patch: Tweak error handling a tiny bit, make usage error go to stderr, and make it not touch the file if dift -f doesn't end up fixing anything.
  • Tools/Scripts/mv-if-different: Added. Useful to overwrite a file with a new version without touching the mod date if they are equal.
  • Tools/Scripts/set-alex-version: Use mv-if-different so we don't touch files if we aren't changing anything.

WebFoundation:

Use isEqualToString: instead of isEqual: more consistently. But only for strings.

  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (+[IFHTTPURLProtocolHandler canonicalizeURL:]):

WebKit:

Use isEqualToString: instead of isEqual: more consistently. But only for strings.

  • WebCoreSupport.subproj/IFCachedTextRendererFactory.m: (-[IFFontCacheKey isEqual:]):
  • WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController _frameNamed:fromFrame:]):

WebBrowser:

Use isEqualToString: instead of isEqual: more consistently. But only for strings.

  • AppController.m: (-[AppController handleGURLEvent:withReplyEvent:]):
  • BookmarksController.m: (-[BookmarksController outlineView:objectValueForTableColumn:byItem:]): (-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]):
  • BrowserWindow.m: (-[BrowserWindow setLocationFieldText:]): (-[BrowserWindow toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[BrowserWindow toolbarWillAddItem:]):
  • Debug/DOMTree.mm: (-[DOMTreeDataSource outlineView:objectValueForTableColumn:byItem:]):
  • Debug/RenderTree.mm: (-[RenderTreeDataSource outlineView:objectValueForTableColumn:byItem:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler _saveScrollPosition]): (-[LocationChangeHandler _restoreScrollPosition]):
  • StopAndGoButton.m: (-[StopAndGoButton setActiveImageSet:]):
  • Test/PageLoadTestController.m: (-[PageLoadTestController tableView:objectValueForTableColumn:row:]):

May 6, 2002:

6:27 PM Changeset in webkit [1103] by sullivan
  • 8 edits in trunk/WebKit

Some improvements to the bookmark changed notifications.

  • Bookmarks.subproj/IFBookmarkGroup.h:
  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _sendChangeNotificationForBookmark:childrenChanged:]): (-[IFBookmarkGroup _setTopBookmark:]): (-[IFBookmarkGroup _bookmarkDidChange:]): (-[IFBookmarkGroup _bookmarkChildrenDidChange:]): Send bookmark that changed and whether its children changed as part of change notifications, so clients can choose to do less unnecessary work.
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf setTitle:]): Check for the no-change case and bail out without sending notification when you find it.

Fixed 2919147 (Organize Bookmarks menu item doesn't do anything).

First check-in of Bookmarks window. You can remove one or more bookmarks,
and you can edit the title & address of existing bookmarks, but that's all
so far. Removed the Erase All Bookmarks item from the Debug menu since you
can do it easily from the Bookmarks window now. Added keyboard equivalents
for the Bookmarks, History, and Activity Viewer windows in the style of
Mail. Also miscellaneous cleanups.

  • BookmarksController.h: Added.
  • BookmarksController.m: Added. (-[BookmarksController shouldCascadeWindows]): (-[BookmarksController _receivedBookmarksChangedNotification:]): (-[BookmarksController _setUpToolbar]): (-[BookmarksController windowDidLoad]): (-[BookmarksController dealloc]): (-[BookmarksController _removeAllBookmarks]): (-[BookmarksController _removeSelectedBookmarks:]): (-[BookmarksController outlineView:child:ofItem:]): (-[BookmarksController outlineView:isItemExpandable:]): (-[BookmarksController outlineView:numberOfChildrenOfItem:]): (-[BookmarksController outlineView:objectValueForTableColumn:byItem:]): (-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]): (-[BookmarksController outlineView:willDisplayCell:forTableColumn:item:]): (-[BookmarksController toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[BookmarksController toolbarAllowedItemIdentifiers:]): (-[BookmarksController toolbarDefaultItemIdentifiers:]): (-[BookmarksController toolbarDidRemoveItem:]): (-[BookmarksController toolbarWillAddItem:]): (-[BookmarksController validateUserInterfaceItem:]): New class that manages the Bookmarks window.
  • AppController.h:
  • AppController.m: (-[AppController dealloc]): release bookmarks controller. (-[AppController showBookmarks:]): create bookmarks controller if necessary, and tell it to show its window.
  • BrowserWindow.m: Changed static strings to #defines. (-[BrowserWindow setUpToolbar]): Remove call that explicitly sets toolbar display mode; we've no reason to override the default.
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Remove Erase All Bookmarks.
  • English.lproj/Bookmarks.nib: New nib file for Bookmarks window.
  • English.lproj/MainMenu.nib: Wired up "Organize Bookmarks..." and "Bookmarks" menu items; added keyboard shortcuts for Window menu items.
  • GlobalHistory.m: (-[GlobalHistory outlineView:objectValueForTableColumn:byItem:]): Changed two isEquals to isEqualToStrings. (-[GlobalHistory _anyURLsSelected]): Replaced anyDatesSelected with this. (-[GlobalHistory updateButtons]): Allow Add to Bookmarks to be enabled even if some dates are selected; just ignore them (at least one non-date has to be selected). (-[GlobalHistory addSelectedItemsToBookmarks:]): Removed obsolete comment.
  • Resources/Images/delete.tiff: New image, stolen for mail, used in Bookmarks window.
  • WebBrowser.pbproj/project.pbxproj: Updated for new files.
4:40 PM Changeset in webkit [1102] by darin
  • 55 edits
    3 adds in trunk

i * Makefile.am: Generate the PFE precompiled headers to be used

by automake compiles. Currently these don't have any dependency
tracking, but I'm sure Maciej can fix that if he wants to.

  • configure.in: Go from "xNDEBUG" to "NDEBUG" now that precompiled headers aren't in the way. Pass in the --load-pch option to all the various compiles so they get the precompiled headers.
  • Tests/libiftest/Makefile.am: Generate a top_srcdir.h file rather than passing it in on the command line. This works around a PFE bug with -D, Radar 2921026.
  • Tests/libiftest/IFTestDirectory.c: Use top_srcdir.h.
  • Tests/libiftest/.cvsignore: Ignore top_srcdir.h.
  • Tests/qt/qpoint-test.cpp: (main): Take out an unused variable and all the USING_BORROWED_QPOINT code.
  • Tools/Makefile.am: Don't built the HotSpots directory for now, since it runs into a PFE bug and we usually use the application version now.
  • Tools/Scripts/check-non-ASCII: Skip preprocessor directives.
  • Tools/Scripts/cvs-abandon: Tweak.

JavaScriptCore:

  • JavaScriptCorePrefix.h: Added.
  • JavaScriptCore.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.

WebFoundation:

Reviewed by Ken Kocienda:

  • WebFoundationPrefix.h: Added.
  • WebFoundation.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.
  • AuthenticationManager.subproj/IFAuthenticationManager.m:
  • CookieManager.subproj/IFCookie.m:
  • Misc.subproj/IFNSStringExtensions.m:
  • Misc.subproj/WebFoundationDebug.m: Add undefs to work around PFE problem with inline functions, Radar 2920554.
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m: Fix include to work with normal Project Builder way of dealing with frameworks. Switch from xNDEBUG to NDEBUG.
  • CacheLoader.subproj/IFURLLoad.m:
  • CookieManager.subproj/IFCookie.m:
  • Database.subproj/IFURLFileDatabase.m:
  • Misc.subproj/IFError.m:
  • Misc.subproj/IFMonitor.h:
  • Misc.subproj/IFMonitor.m:
  • Misc.subproj/IFRecursiveReadWriteLock.h: Use import instead of include.
  • Misc.subproj/IFCFNetworkExtensions.m: Added.
  • Misc.subproj/IFCFRunLoopExtensions.m: Added.
  • Misc.subproj/IFCFNetworkExtensions.c: Removed.
  • Misc.subproj/IFCFRunLoopExtensions.c: Removed. Renamed so we could share the Objective-C precompile. No need to compile this code as plain C, even though it doesn't use any Objective-C features.
  • Misc.subproj/WebFoundationDebug.h: Get rid of format attribute because of bug
  1. Switch from xNDEBUG to NDEBUG.

WebCore:

  • WebCorePrefix.h: Added.
  • .cvsignore: Ignore the .pfe files in this directory.
  • khtml/dom/dom_doc.cpp:
  • khtml/dom/dom_text.cpp: Added namespace directives as a clean workaround for a conflict with the struct named Comment in <Carbon/AIFF.h>
  • kwq/KWQFont.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQKGlobal.mm:
  • kwq/KWQListImpl.mm:
  • kwq/KWQPtrDictImpl.h:
  • kwq/KWQVectorImpl.mm:
  • kwq/kwqdebug.h:
  • kwq/qt/qcolor.h:
  • kwq/qt/qcombobox.h:
  • kwq/qt/qregion.h:
  • kwq/qt/qstring.h:
  • kwq/qt/qwidget.h: Remove old workaround for conflicts with Fixed, Rect, and Boolean. It does not good with a precompiled header anyway, and there is a more elegant small fix in the KDE code itself.
  • kwq/qt/qpoint.h:
  • kwq/KWQPointArray.mm: (QPointArray::setPoints): Work around bug with va_arg and PFE by not using varargs here.
  • kwq/KWQRect.mm: (QRect::unite): (QRect::operator&): Use std::min and std::max instead of defining our own MIN and MAX, which conflict with something in one of the headers we are precompiling (error message did not make it clear which).
  • kwq/KWQView.mm: (-[KWQHTMLView layout]), (-[KWQHTMLView drawRect:]): Switch from xNDEBUG to NDEBUG.
  • kwq/Makefile.am: Remove stuff for getting at the header inside the ApplicationServices and QD frameworks, since that code is now in WebKit.
  • kwq/kwqdebug.h: Get rid of format attribute because of bug 2920557. Switch from xNDEBUG to NDEBUG.
  • kwq/kwqdebug.mm: Switch from xNDEBUG to NDEBUG.
  • kwq/qt/qstring.h: Define QT_VERSION in here instead of on the command line to work around a PFE bug with -D, Radar 2921026.

WebKit:

  • WebKitPrefix.h: Added.
  • WebKit.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.
  • Misc.subproj/WebKitDebug.h: Get rid of format attribute because of bug
  1. Switch from xNDEBUG to NDEBUG.
  • Misc.subproj/WebKitDebug.m: Add undef to work around PFE problem with inline functions, Radar 2920554.
  • Plugins.subproj/IFPluginView.mm: Changed how we work around the bug in the CGS defines.
  • WebCoreSupport.subproj/IFCachedTextRenderer.h: Change include of the private QD header to use the form that works with more-normal way of getting at the private bits of frameworks.
  • WebCoreSupport.subproj/IFCachedTextRenderer.m: Use the header <CoreGraphics/CoreGraphicsPrivate.h> instead of <CoreGraphics/CGFontPrivate.h>.
  • Misc.subproj/IFCache.mm:
  • WebView.subproj/IFLoadProgress.mm:
  • WebView.subproj/IFWebFrame.mm:
  • WebView.subproj/IFWebFramePrivate.mm:
  • WebView.subproj/IFWebView.mm: Changed includes to imports.

WebBrowser:

  • WebBrowserPrefix.h: Added.
  • WebBrowser.pbproj/project.pbxproj: Use PFE precompiling. Also switch from xNDEBUG to NDEBUG.
  • Debug/CacheController.m: Renamed to make it Objective C rather than Objective C++.
  • Debug/CacheController.mm: Removed.
  • main.m: Use the real CFA2UC. Use import instead of include.
  • _CFA2UC.c: Remove our copy.
  • Debug/DOMTree.mm:
  • Debug/RenderTree.mm:
  • Preferences.subproj/ActiveContentPreferences.h:
  • Preferences.subproj/AppearancePreferences.h:
  • Preferences.subproj/GeneralPreferences.h:
  • Preferences.subproj/SecurityPreferences.h:
  • Preferences.subproj/TextPreferences.h:
  • Preferences.subproj/WBPreferences.h:
  • Test/PageLoadTestLogger.m: Use import instead of include.
4:14 PM Changeset in webkit [1101] by cblu
  • 8 edits in trunk/WebKit

Made start and stop work cleaner.

Now observe defaults changes so that plug-ins
are disabled or enabled immediately (2871725).

  • Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender sendNullEvents]):
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): (-[IFPluginView start]): (-[IFPluginView stop]): (-[IFPluginView drawRect:]): (-[IFPluginView windowWillClose:]): (-[IFPluginView defaultsHaveChanged:]):
3:56 PM Changeset in webkit [1100] by rjw
  • 3 edits in trunk/WebKit

Fixed width measurement regression. We lost the final ROUND_TO_INT
in the width measurement funtion after the move from WebCore.

1:49 PM Changeset in webkit [1099] by rjw
  • 19 edits in trunk

Changes to support dhmtl.
Changes to support targeting (regression after 3.0 merge).

9:31 AM Changeset in webkit [1098] by sullivan
  • 3 edits in trunk/WebKit
  • Resources/url_icon.tiff: New bookmarks/history icon, looks more like the springy @ sign as seen from above, less like text.
Note: See TracTimeline for information about the timeline view.