Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

May 10, 2002:

4:08 PM Changeset in webkit [1136] by rjw

• 4 edits in trunk/WebCore

Made log output match webkit logging.

4:07 PM Changeset in webkit [1135] by rjw

• 8 edits
  1 add in trunk/WebKit

Logging changes.

3:28 PM Changeset in webkit [1134] by cblu

• 13 edits in trunk

WebKit:

Added support for non-html non-file URL data sources.
Added the init methods below. Removed initWithHandle.

• WebView.subproj/IFWebDataSource.h:
• WebView.subproj/IFWebDataSource.mm: (IFWebDataSourceMake): (-[IFWebDataSource initWithURL:]): (-[IFWebDataSource initWithURL:attributes:]): (-[IFWebDataSource startLoading:]):

WebCore:

Changed WCIFWebDataSourceMake to wrap around [IFWebDataSource initWithUR

L: attributes: flags:]

instead of initWithHandle.

• kwq/KWQKHTMLPart.mm: (KHTMLPart::requestFrame): (KHTMLPart::submitForm):
• kwq/WCWebDataSource.h:
• libwebcore.exp:

3:16 PM Changeset in webkit [1133] by darin

• 3 edits in trunk/WebCore

Fixed 2923728 (ellipsizing text method is taking a lot of CPU time) by writing a
new string truncator that uses fast text measurement.

• AppController.m: (-[AppController awakeFromNib]): Remove _setUpStringTruncator.

• BrowserDocument.h: Remove _cachedPageName; it was not doing any good.
• BrowserDocument.m: (-[BrowserDocument dealloc]): No need to release _cachedPageName. (-[BrowserDocument pageName]): No need to use _cachedPageName. (-[BrowserDocument _updateWindowTitles]): Name change.

• StringTruncator.h: Rewrite. Only the name is the same.
• StringTruncator.m: (+[StringTruncator centerTruncateString:length:omitCount:toBuffer:]): Does the work of removing the middle of a string. (+[StringTruncator centerTruncateString:toWidth:]): Convenience cover version that uses the menu font. (+[StringTruncator centerTruncateString:toWidth:withFont:]): The code to do the truncating.

• TextCell.m: (-[TextCell drawInteriorWithFrame:inView:]): Use the new truncator interface that takes a font, not the old one that took an attributes dictionary.

• WebBrowser.pbproj/project.pbxproj: Some little tweak.

3:11 PM Changeset in webkit [1132] by darin

• 11 edits in trunk/WebKit

• WebCoreSupport.subproj/IFTextRenderer.h: Moved most of the stuff from here into the .m file so this header can be included by clients. Also added floatWidthForCharacters:length:.
• WebCoreSupport.subproj/IFTextRenderer.m: (freeWidthMap): Check for NULL. (freeGlyphMap): Check for NULL. (-[IFTextRenderer slowFloatWidthForCharacters:length:]): Renamed, and made it return the float. (-[IFTextRenderer floatWidthForCharacters:length:]): Renamed, and made it return the float. (-[IFTextRenderer widthForCharacters:length:]): Do rounding here.

• WebCoreSupport.subproj/IFTextRendererFactory.h:
• WebCoreSupport.subproj/IFTextRendererFactory.m: Make the interface slightly easier to use by using the specific types.

• WebKit.pbproj/project.pbxproj: Exported the headers.

2:51 PM Changeset in webkit [1131] by kocienda

• 5 edits in trunk/WebKit

2002-05-10 Kenneth Kocienda <​kocienda@apple.com>

Fixed build breakage caused by my previous checkin.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:])

2:25 PM Changeset in webkit [1130] by sullivan

• 8 edits
  1 add in trunk/WebKit

Fixed 2922756 (@ image in History window is a little too tall)
Fixed 2923790 (bookmark folders need folder icons)

• Resources/bookmark_folder.tiff: New image (small folder, copied from elsewhere)
• Resources/url_icon.tiff: Shrunk this one a little bit.

• Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList image]): Return the default image if no custom image is set.

• History.subproj/IFURIEntry.m: (-[IFURIEntry image]): If the default image's file isn't found, don't try to create an NSImage, because it will come out horribly broken and evil if you do (I ran into this while adding the bookmark folder image; most of Alexander's menus did not appear at all because the bookmark folder image was using a bogus NSImage).

• WebKit.pbproj/project.pbxproj: Updated for new files.

Fixed 2922745 (Bookmark and History window should use same font size)
Fixed 2923792 (All buttons in Bookmarks window look the same)

• Resources/Images/new_bookmark.tiff: Added.
• Resources/Images/new_folder.tiff: Added.
• Resources/Images/pencil.tiff: Added. New images for buttons in Bookmarks window. new_folder was stolen from Finder; pencil was stolen from Mail; new_bookmark is a Sullivan Original™.

• AppController.m: (-[AppController _addBookmarksToMenu]): (-[AppController _updateBookmarksInMenu]): Remove count of bookmarks from debug timing message since it wasn't counting deep.

• BookmarksController.m: (-[BookmarksController toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): Use the right images for the right buttons.

• English.lproj/Bookmarks.nib: Change the font size to match History window.

• WebBrowser.pbproj/project.pbxproj: Updated for new files.

2:07 PM Changeset in webkit [1129] by kocienda

• 8 edits in trunk/WebKit

2002-05-10 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Maciej Stachowiak

WebFoundation:

This set of changes enhances the IFError object with two new pieces of
information:

1) An error domain, to help separate error codes from different
sources that may overlap

2) An indicator of whether the error should be treated as "terminal" by
code that receives and handles the error.

I have added a couple of other cleanups in this class, as described by
the bugs noted below.

The other code in this set of changes was modified to use the new interface
and features of IFError.

Fixes for these four bugs:

Radar 2923998 (Change IFError private data into a pointer to a private data object)
Radar 2924002 (IFError should include an error domain)
Radar 2924013 (IFError initialization is not threadsafe)
Radar 2924280 (IFError should contain a new field which tells whether the error is terminal)

• CacheLoader.subproj/IFFileURLProtocolHandler.m: (-[IFFileURLProtocolHandler fileLoadThread])
• CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (-[IFHTTPURLProtocolHandler continueBeginLoadInBackgroundAfterCreatingHTTPRequest]) (-[IFHTTPURLProtocolHandler retryWithRedirectedURL:]) (-[IFHTTPURLProtocolHandler handleReadStreamEvent:event:]) (-[IFHTTPURLProtocolHandler performHTTPHeaderRead:]) (-[IFHTTPURLProtocolHandler determineErrorAndFail])
• CacheLoader.subproj/IFURLCacheLoaderConstants.:h
• CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandle _backgroundLoadFailedWithResultCode:inDomain:isTerminal:]) (-[IFURLHandle _setError:]) (-[IFURLHandle _notifyClientsDidFailLoading])
• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode)
• CacheLoader.subproj/IFURLHandlePrivate.h:
• CacheLoader.subproj/IFURLLoad.h:
• CacheLoader.subproj/IFURLLoad.m: (-[IFURLLoad failedWithResultCode:inDomain:isTerminal:]) (-[IFURLLoad scheduleOriginLoad]) (-[IFURLLoad beginOriginLoad]) (_loadSweeper)
• Misc.subproj/IFError.h:
• Misc.subproj/IFError.m: (-[IFErrorPrivate dealloc]) (classInitialize) (+[IFError errorWithCode:inDomain:failingURL:isTerminal:]) (-[IFError initWithErrorCode:inDomain:failingURL:isTerminal:]) (-[IFError dealloc]) (-[IFError errorCode]) (-[IFError errorDomain]) (-[IFError terminalError]) (-[IFError errorDescription]) (-[IFError failingURL]) (-[IFError description])

WebKit:

This code was modified to use the new interface and features of IFError.
These features and changes are described in these four bug reports:

Radar 2923998 (Change IFError private data into a pointer to a private data object)
Radar 2924002 (IFError should include an error domain)
Radar 2924013 (IFError initialization is not threadsafe)
Radar 2924280 (IFError should contain a new field which tells whether the error is terminal)

• Plugins.subproj/IFPluginView.mm: (-[IFPluginView IFURLHandle:resourceDidFailLoadingWithResult:])
• WebView.subproj/IFBaseWebControllerPrivate.mm: (-[IFBaseWebController _receivedProgress:forResource:fromDataSource:]) (-[IFBaseWebController _mainReceivedProgress:forResource:fromDataSource:])
• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:])

1:52 PM Changeset in webkit [1128]

• 1 copy
  2 deletes in tags/JavaScriptCore-4

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-4'.

1:52 PM Changeset in webkit [1127] by mjs

• 5 edits in trunk/JavaScriptCore

JavaScriptCore-4

9:41 AM Changeset in webkit [1126] by mjs

• 9 edits in trunk/JavaScriptCore

Reviewed by: Ken Kocienda and Darin Adler

Fixed the following bug:

Radar 2890573 - JavaScriptCore needs to be thread-safe

Actually this is only a weak form of thread-safety - you can safely
use different interpreters from different threads at the same
time. If you try to use a single interpreter object from multiple
threads, you need to provide your own locking.

• kjs/collector.h, kjs/collector.cpp: (Collector::lock, Collector::unlock): Trivial implementation of a recursive mutex. (Collector::allocate): Lock around the body of this function. (Collector::collect): Likewise. (Collector::finalCheck): Likewise. (Collector::numInterpreters): Likewise. (Collector::numGCNotAllowedObjects): Likewise. (Collector::numReferencedObjects): Likewise.
• kjs/internal.cpp: (Parser::parse): use a mutex to lock around the whole parse, since it uses a bunch of global state. (InterpreterImp::InterpreterImp): Grab the Collector lock here, both the mutually exclude calls to the body of this function, and to protect the s_hook static member which the collector pokes at. (InterpreterImp::clear): Likewise.
• kjs/ustring.cpp: (statBufferKeyCleanup, statBufferKeyInit, UString::ascii): Convert use of static variable
• kjs/value.cpp: (ValueImp::ValueImp, ValueImp::mark, ValueImp::marked, ValueImp::setGcAllowed): Grab the GC lock around any flag changes.

May 9, 2002:

8:18 PM Changeset in webkit [1125] by rjw

• 5 edits in trunk/WebCore

i Added new method to avoid creation of NSString.

8:18 PM Changeset in webkit [1124] by rjw

• 6 edits in trunk/WebKit

Tuned implementation more. Cleaned up and factored code.

6:35 PM Changeset in webkit [1123] by sullivan

• 6 edits in trunk/WebKit

• Bookmarks.subproj/IFBookmarkGroup.h:
• Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup addNewBookmarkToBookmark:withTitle:image:URLString:isLeaf:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:image:URLString:isLeaf:]): Gave these two methods return values of the new bookmark created, to make callers' lives easier.

More work on bookmarks; you can now create new ones and new folders
from the Bookmarks window. You still can't reorder them by dragging.
There are many details wrong still, including some obvious ones.

Fixed these radar bugs along the way:
2921389 -- No way to create a folder in Bookmarks window
2923495 -- Shouldn't be able to create bookmarks with no title and/or URL string

Also improved what Activity Viewer shows for errors that had no description
(was "(null)", now is "error").

• AppController.m: (-[AppController _insertBookmark:intoMenu:atIndex:]): Made this method handle non-leaf bookmarks (i.e., folders)

• BookmarksController.m: (-[BookmarksController _collapseSelectionToSingleRow]): New helper routine that always ends up with a single row selected (unless outline view is empty).

(-[BookmarksController _removeSelectedBookmarks:]):
Call _collapseSelectionToSingleRow after removing selected items.

(-[BookmarksController _toggleEdit:]):
New method, turns edit mode on or off for the selected item.

(-[BookmarksController _findParentRowOfRow:]):
New helper routine for finding the row index that's the parent of
a given row.

(-[BookmarksController _newItemWithTitle:image:URLString:isLeaf:]):
Bottleneck for new-item-creating methods, finds appropriate place to
insert new item based on current selection, inserts it, selects it,
and puts its name into edit mode.

(-[BookmarksController _newSeparator:]):
New method, placeholder for now.

(-[BookmarksController _newFolder:]):
(-[BookmarksController _newBookmark:]):
Implement by calling _newItemWithTitle:

(-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]):
If new value after trimming whitespace is empty, ignore it.

(-[BookmarksController outlineView:shouldEditTableColumn:item:]):
Don't allow address cell of folder rows to be edited.

(-[BookmarksController toolbarAllowedItemIdentifiers:]):
New set of buttons is: New Bookmark, New Folder, Modify, Remove

(-[BookmarksController validateUserInterfaceItem:]):
Disable Modify when nothing is selected.

• English.lproj/Bookmarks.nib: I don't remember what I changed here, possibly nothing real.

• IFErrorAdditions.h: Added.
• IFErrorAdditions.m: Added. (-[IFError errorSummary]): New category on IFError, implements just this one method, which returns a string of the form "<error description> (<error code>)" and handles the case where there's no description.

• FrameProgressEntry.m: (-[FrameProgressEntry statusString]): use errorSummary.
• ResourceProgressEntry.m: (-[ResourceProgressEntry statusString]): use errorSummary.

• GlobalHistory.m: (-[GlobalHistory showWindow:]): Changed an NSLog to a WEBKITDEBUG

• WebBrowser.pbproj/project.pbxproj: Updated for new files.

12:42 PM Changeset in webkit [1122]

• 1 copy
  34 deletes in tags/WebFoundation-5

This commit was manufactured by cvs2svn to create tag
'WebFoundation-5'.

12:42 PM Changeset in webkit [1121]

• 1 copy
  34 deletes in tags/WebFoundation-4

This commit was manufactured by cvs2svn to create tag
'WebFoundation-4'.

12:42 PM Changeset in webkit [1120] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Chris Blumenberg

Fix for this bug:

Radar 2922673 (Remove use of private NSData interface in IFURLFileDatabase.m)

• Database.subproj/IFURLFileDatabase.m: (-[IFURLFileReader initWithPath:]): Code now uses new Jaguar public API

12:25 PM Changeset in webkit [1119] by kocienda

• 4 edits in trunk/WebCore

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2890624 (need to remove workaround for double free of image data from QPixmap)

The appropriate, bug-free AppKit code is now available to us on Jaguar.
Rolling out the workaround.

• kwq/KWQPixmap.mm: (QPixmap::QPixmap)

9:43 AM Changeset in webkit [1118] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Tiny little string copying cleanup suggested by Darin.

• Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase open]): small string copying cleanup.

9:35 AM Changeset in webkit [1117] by kocienda

• 4 edits in trunk/WebKit/Misc.subproj

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Darin Adler

Fixes for these two bugs:

Radar 2859001 (Maintain usage calculation for on-disk cache)
Radar 2859009 (On-disk cache must be able to be truncated to a specific size)

Now, the on-disk database keeps track of the amount of data it stores and can enforce
a usage quota. This new system should work quite well as long as there is a one-to-one
mapping between processes and on-disk cache paths.

Further guarantees for synchronous access to a cache from multiple processes will be
offered if (when) we switch over to using the sleepycat Berkeley DB for the disk cache
implementation.

• CacheLoader.subproj/IFURLDiskCache.m: (-[IFURLDiskCache initWithSizeLimit:path:]): Added code that calls into new database methods (-[IFURLDiskCache dealloc]): Added missing call to [super dealloc] (-[IFURLDiskCache setSizeLimit:]): New (-[IFURLDiskCache usage]): New
• Database.subproj/IFDatabase.h:
• Database.subproj/IFDatabase.m: (-[IFDatabase initWithPath:]): Added code to track size limit and usage (-[IFDatabase isOpen]): Added code to track size limit and usage (-[IFDatabase count]): New (-[IFDatabase sizeLimit]): New (-[IFDatabase setSizeLimit:]): New (-[IFDatabase usage]): New
• Database.subproj/IFNDBMDatabase.h: Removed.
• Database.subproj/IFNDBMDatabase.m: Removed.
• Database.subproj/IFURLFileDatabase.h:
• Database.subproj/IFURLFileDatabase.m: (+[IFURLFileDatabase uniqueFilePathForKey:]): Moved to private category (-[IFURLFileDatabase writeSizeFile:]): New (-[IFURLFileDatabase readSizeFile]): New (-[IFURLFileDatabase truncateToSizeLimit:]): New (-[IFURLFileDatabase initWithPath:]): Added code to deal with size reckoning (-[IFURLFileDatabase removeAllObjects]): Added code to deal with size reckoning (-[IFURLFileDatabase performSetObject:forKey:]): Added code to deal with size reckoning (-[IFURLFileDatabase performRemoveObjectForKey:]): Added code to deal with size reckoning (-[IFURLFileDatabase open]): Added code to deal with size reckoning (-[IFURLFileDatabase close]): Added code to deal with size reckoning (-[IFURLFileDatabase sync]): Added code to deal with size reckoning (-[IFURLFileDatabase count]): New (-[IFURLFileDatabase setSizeLimit:]): New
• WebFoundation.pbproj/project.pbxproj: PB has its way again.

9:19 AM Changeset in webkit [1116]

• 8 copies in tags/Alexander-3

This commit was manufactured by cvs2svn to create tag 'Alexander-3'.

9:19 AM Changeset in webkit [1115] by sheridan

• 8 edits in trunk

Alexander-3 versioning

May 8, 2002:

8:05 PM Changeset in webkit [1114] by rjw

• 6 edits in trunk/WebKit

Added optimizations for text rendering.

5:11 PM Changeset in webkit [1113] by darin

• 7 edits in trunk/WebKit

• Misc.subproj/IFCache.h: Add more JavaScript object statistics.
• Misc.subproj/IFCache.mm: (+[IFCache javaScriptInterpretersCount]): New. (+[IFCache javaScriptNoGCAllowedObjectsCount]): New. (+[IFCache javaScriptReferencedObjectsCount]): New.

• WebKit.pbproj/project.pbxproj: Rearranged two files, dunno why.

5:11 PM Changeset in webkit [1112] by darin

• 5 edits in trunk/JavaScriptCore

• kjs/collector.h:
• kjs/collector.cpp: (Collector::numInterpreters): (Collector::numGCNotAllowedObjects): (Collector::numReferencedObjects): Add three new functions so we can see a bit more about leaking JavaScriptCore.

1:22 PM Changeset in webkit [1111] by cblu

• 8 edits in trunk/WebKit

Cleaned up mach-o plug-in support.

Changed the init method in IFPlugin to initWithPath.

• Plugins.subproj/IFPlugin.h:
• Plugins.subproj/IFPlugin.m: (-[IFPlugin initWithPath:]): (-[IFPlugin load]):
• Plugins.subproj/IFPluginDatabase.m: (findPlugins):

11:37 AM Changeset in webkit [1110] by darin

• 2 edits in trunk/WebKit/WebView.subproj

Forgot include.

11:29 AM Changeset in webkit [1109] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setTitle:]): Use _IF_stringByTrimmingWhitespace.

May 7, 2002:

4:51 PM Changeset in webkit [1108] by rjw

• 8 edits in trunk/WebKit

First pass at font substitution. Find a substitute font to
use when the specified font doesn't have glyphs for the characters that
need to be drawn.

Works correctly but hasn't been optimized yet, VERY slow.
Will optimize this evening and tomorrow. Try www.yahoo.co.jp,
it will take a long time to render be eventually will draw correctly.

4:36 PM Changeset in webkit [1107] by darin

• 4 edits in trunk/WebCore

• kwq/KWQFontMetrics.mm: Fixed storage leak by initializing refCount.

2:41 PM Changeset in webkit [1106] by darin

• 3 edits
  4 adds
  2 deletes in trunk/WebKit

Oops. These files don't belong at the top level.

• IFWebCoreViewFactory.h: Removed.
• IFWebCoreViewFactory.m: Removed.
• WebCoreSupport.subproj/IFWebCoreViewFactory.h: Added.
• WebCoreSupport.subproj/IFWebCoreViewFactory.m: Added.
• WebKit.pbproj/project.pbxproj:

2:10 PM Changeset in webkit [1105] by darin

• 23 edits
  26 adds
  13 deletes in trunk

WebCore:

Move more plugin code into WebKit.

Stop using IF for anything in WebCore to help make it clear what's part of
the BSD licensed stuff and what's part of our proprietary stuff.

• libwebcore.exp: Names of what exported changed.
• kwq/Makefile.am: Source file names changed.

• kwq/IFTextRenderer.h: Renamed to WebCoreTextRenderer.
• kwq/IFTextRendererFactory.h: Renamed to WebCoreTextRendererFactory.
• kwq/IFTextRendererFactory.m: Renamed to WebCoreTextRendererFactory.
• kwq/WebCoreTextRenderer.h: Renamed from IFTextRenderer.
• kwq/WebCoreTextRendererFactory.h: Renamed from IFTextRendererFactory.
• kwq/WebCoreTextRendererFactory.m: Renamed from IFTextRendererFactory.

• kwq/KWQFontMetrics.mm:
• kwq/KWQPainter.mm: Updated for IF -> WebCore name change.

• kwq/WebCoreViewFactory.h: Added.
• kwq/WebCoreViewFactory.m: Added.

• kwq/KWQKConfigBase.mm: (KConfig::readEntry): (KConfig::readNumEntry): Use the new [WebCoreViewFactory pluginsInfo] so we don't have to have the plugin database in WebCore any more.

• kwq/WCJavaAppletWidget.h:
• kwq/WCJavaAppletWidget.mm: (IFJavaAppletWidgetCreate):
• kwq/WCPluginWidget.h:
• kwq/WCPluginWidget.mm: (IFPluginWidgetCreate): Remove creation function machinery, and use the WebCoreViewFactory instead.

• kwq/WCPlugin.h: Moved to WebKit.
• kwq/WCPlugin.mm: Moved to WebKit.
• kwq/WCPluginDatabase.h: Moved to WebKit.
• kwq/WCPluginDatabase.mm: Moved to WebKit.
• kwq/npapi.h: Moved to WebKit.
• kwq/npapi.mm: Moved to WebKit.

WebKit:

Move more plugin code here from WebCore.

• IFWebCoreViewFactory.h: Added.
• IFWebCoreViewFactory.m: Added.

• Plugins.subproj/IFPlugin.h: Moved from WebCore.
• Plugins.subproj/IFPlugin.m: Moved from WebCore.
• Plugins.subproj/IFPluginDatabase.h: Moved from WebCore.
• Plugins.subproj/IFPluginDatabase.m: Moved from WebCore.
• Plugins.subproj/npapi.h: Moved from WebCore.
• Plugins.subproj/npapi.m: Moved from WebCore.

• WebKit.pbproj/project.pbxproj: Source file names changed

• MIME.subproj/IFMIMEDatabase.m:
• MIME.subproj/IFMIMEHandler.m:
• Plugins.subproj/IFPluginView.h:
• Plugins.subproj/IFPluginView.mm: Updated for WC -> IF name change.

• WebCoreSupport.subproj/IFCachedTextRenderer.h: Renamed to IFTextRenderer.
• WebCoreSupport.subproj/IFCachedTextRenderer.m: Renamed to IFTextRenderer.
• WebCoreSupport.subproj/IFCachedTextRendererFactory.h: Renamed to IFTextRendererFactory.
• WebCoreSupport.subproj/IFCachedTextRendererFactory.m: Renamed to IFTextRendererFactory.
• WebCoreSupport.subproj/IFTextRenderer.h: Renamed from IFCachedTextRenderer.
• WebCoreSupport.subproj/IFTextRenderer.m: Renamed from IFCachedTextRenderer.
• WebCoreSupport.subproj/IFTextRendererFactory.h: Renamed from IFCachedTextRendererFactory.
• WebCoreSupport.subproj/IFTextRendererFactory.m: Renamed from IFCachedTextRendererFactory. Renamed to take "Cached" out of the name now that the simpler name is available.

• WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): Create shared IFWebCoreViewFactory. (-[IFWebView delayLayout:]): Use WEBKITDEBUG, not KWQDEBUG. (-[IFWebView notificationReceived:]): Use WEBKITDEBUG, not KWQDEBUG.

8:56 AM Changeset in webkit [1104] by darin

• 4 edits in trunk/WebKit

• Tools/Scripts/cvs-fix-patch: Tweak error handling a tiny bit, make usage error go to stderr, and make it not touch the file if dift -f doesn't end up fixing anything.

• Tools/Scripts/mv-if-different: Added. Useful to overwrite a file with a new version without touching the mod date if they are equal.

• Tools/Scripts/set-alex-version: Use mv-if-different so we don't touch files if we aren't changing anything.

WebFoundation:

Use isEqualToString: instead of isEqual: more consistently. But only for strings.

• CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (+[IFHTTPURLProtocolHandler canonicalizeURL:]):

WebKit:

Use isEqualToString: instead of isEqual: more consistently. But only for strings.

• WebCoreSupport.subproj/IFCachedTextRendererFactory.m: (-[IFFontCacheKey isEqual:]):
• WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController _frameNamed:fromFrame:]):

WebBrowser:

Use isEqualToString: instead of isEqual: more consistently. But only for strings.

• AppController.m: (-[AppController handleGURLEvent:withReplyEvent:]):
• BookmarksController.m: (-[BookmarksController outlineView:objectValueForTableColumn:byItem:]): (-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]):
• BrowserWindow.m: (-[BrowserWindow setLocationFieldText:]): (-[BrowserWindow toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[BrowserWindow toolbarWillAddItem:]):
• Debug/DOMTree.mm: (-[DOMTreeDataSource outlineView:objectValueForTableColumn:byItem:]):
• Debug/RenderTree.mm: (-[RenderTreeDataSource outlineView:objectValueForTableColumn:byItem:]):
• LocationChangeHandler.m: (-[LocationChangeHandler _saveScrollPosition]): (-[LocationChangeHandler _restoreScrollPosition]):
• StopAndGoButton.m: (-[StopAndGoButton setActiveImageSet:]):
• Test/PageLoadTestController.m: (-[PageLoadTestController tableView:objectValueForTableColumn:row:]):