⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 27, 2002:

2:32 PM Changeset in webkit [1222] by sullivan
  • 7 edits in trunk

Part of fix for 2922772 -- page title & location field don't
show redirected URLs.

  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource wasRedirected]): Fixed this method, now that we have a client that relies on it. Its logic was backwards, and it didn't handle the null _finalURL case.

WebBrowser part of fix for 2922772 -- page title & location field don't
show redirected URLs.

  • BrowserDocument.h: added BrowserDocumentRedirectedNotification
  • BrowserDocument.m: (-[BrowserDocument currentURL]): Return redirectedURL if appropriate.
  • BrowserWindow.m: (-[BrowserWindow windowDidLoad]): register for BrowserDocumentRedirectedNotification (-[BrowserWindow frameLoadRedirected:]): Update location field if appropriate.
  • LocationChangeHandler.m: (-[LocationChangeHandler serverRedirectTo:forDataSource:]): Send BrowserDocumentRedirectedNotification and title-changed messages if the frame is the top-level frame.
12:55 PM Changeset in webkit [1221] by sullivan
  • 3 edits
    1 add in trunk/WebCore
  • Resources/linkCursor.tiff: Added. Maciej forgot to cvs add this new file. I stole the one from haircut.

Added FIXME.

  • BrowserDocument.m: (-[BrowserDocument displayName]):
1:58 AM Changeset in webkit [1220] by mjs
  • 4 edits in trunk/WebCore

Fixed the vexing and long-standing:

Radar 2894699 - Crash at: ​http://cb.apple.com/jsplugins.html

  • khtml/ecma/kjs_navigator.cpp: This crash was caused by Plugin and MimeType objects referring to data that was held and refcounted by PluginBase, without holding a ref. I fixed it by making these individual items participate in the refcounting as well.

May 26, 2002:

10:59 PM Changeset in webkit [1219] by mjs
  • 4 edits in trunk/WebKit

Fixed Radar 936147 - debug output in console "keyUp: NSEvent: type=KeyUp"

  • WebView.subproj/IFWebView.mm: (-[IFWebView keyDown:]): Turned NSLog into WEBKITDEBUGLEBEL. (-[IFWebView keyUp:]): Likewise.
10:01 PM Changeset in webkit [1218] by mjs
  • 21 edits in trunk

WebCore:

Webcore part of fix for:

Radar 2884085 - add support for changing cursor over links

  • Makefile.am: Install tiff of link cursor.
  • kwq/qt/qcursor.h, kwq/KWQCursor.mm: (QCursor::QCursor): Change QCursor to contain an NSCursor. (QCursor::~QCursor): Likewise. (QCursor::operator=): Likewise. (QCursor::handle): Likewise.
  • kwq/KWQKCursor.mm: (+[NSCursor _WebCore_linkCursor]): NSCursor extension method that provides the link cursor. (KCursor::handCursor): Use the link cursor instead of the default arrow cursor.
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::changeCursor): Return TRUE; we always want cursor tracking.
  • kwq/KWQView.h, kwq/KWQView.mm: (-[KWQHTMLView setCursor:]): Remember the new cursor and invalidate cursor rects. (-[KWQHTMLView resetCursorRects]): Establish cursor rect for currently set cursor, if not default.
  • kwq/KWQWidget.mm: (QWidget::setCursor): Call setCursor: on the underlying NSView, if implemented. (QWidget::cursor): Implemented. (QWidget::unsetCursor): Implemented.

WebKit:

WebKit part of fix for:

Radar 2884085 - add support for changing cursor over links

Also, fix handling of mouseMoved events.

  • WebView.subproj/IFWebView.mm: (-[IFWebView mouseMovedNotification:]): Clip mouseMoved events to the view rect, otherwise mouseover effects might happen for elements past the edge of the window. (-[IFWebView setCursor:]): Implement. (-[IFWebView resetCursorRects]): Implement.
  • WebView.subproj/IFWebViewPrivate.h:
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebViewPrivate dealloc]): Added NSCursor *cursor field.

May 25, 2002:

3:47 AM Changeset in webkit [1217] by mjs
  • 9 edits
    6 adds
    2 deletes in trunk

WebCore:

Changed WebCore to build as a framework, not a dylib, so resources
can be added to it.

  • Makefile.am: Actual changes to build WebCore.framework
  • Resources/Info.plist: Added.
  • English.lproj/InfoPlist.strings: Added.
  • WebCore-tests.exp: Added.
  • WebCore.exp: Added.
  • libwebcore.exp: Removed.
  • libwebcoretests.exp: Removed.
  • .cvsignore: Updated.

WebKit:

  • WebKit.pbproj/project.pbxproj: Link against WebCore.framework, not libwebcore.dylib.

WebBrowser:

  • WebBrowser.pbproj/project.pbxproj: Link against WebCore.framework, not libwebcore.dylib.

Top level:

Link against WebCore.framework, not libwebcore.dylib.

  • Tests/kde/Makefile.am:
  • Tests/khtmlview/WebViewTest/WebViewTest.pbproj/project.pbxproj:
  • Tests/qt/Makefile.am:

May 24, 2002:

3:12 PM Changeset in webkit [1216] by mjs
  • 3 edits
    3 adds in trunk/JavaScriptCore

Added license and acknowledgements.

  • AUTHORS: Added.
  • COPYING.LIB: Added.
  • THANKS: Added.
9:57 AM Changeset in webkit [1215]
  • 6 copies
    1 delete in tags/Alexander_0_3

This commit was manufactured by cvs2svn to create tag
'Alexander_0_3'.

9:57 AM Changeset in webkit [1214] by sheridan
  • 8 edits in trunk

modified changelogs with 0.3 markers

8:45 AM Changeset in webkit [1213]
  • 6 copies
    1 delete in tags/Alexander-6

This commit was manufactured by cvs2svn to create tag 'Alexander-6'.

8:45 AM Changeset in webkit [1212] by sheridan
  • 8 edits in trunk

Alexander-6 version

May 23, 2002:

3:44 PM Changeset in webkit [1211] by mjs
  • 15 edits in trunk

WebCore:

Fixes for the following (the first bug also requires WebKit and
WebBrowser changes):

Radar 2896391 - command-click should open link in new window
Radar 2935858 - two mails for each mailto:

  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): Set flag for Meta key in addition to Control, Shift and Alt, since the Command key is treated as Meta.
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::urlSelected): Open a new window if the user command-clicked. (KHTMLPart::khtmlMouseMoveEvent): Clean up use of braces and ifdefs to make prepare-ChangeLog happy. (KHTMLPart::khtmlMouseReleaseEvent): Remove code that tried to process link click events here. This made link clicks get processed twice, now that mouse events are hooked up for real.
  • kwq/external.h: prototype openNewWindowWithURL: method.

WebKit:

WebKit part of the fix for:

Radar 2896391 - command-click should open link in new window

  • WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController openNewWindowWithURL:]): Default implementation silently does nothing.
  • WebView.subproj/IFWebController.h: Add openNewWindowWithURL: method.
  • WebView.subproj/IFWebView.mm: (-[IFWebView _addModifiers:toState:]): Split out modifier key handling to here. Treat Command as Meta. (-[IFWebView mouseUp:]): Use new method to set key modifiers for mouse events. (-[IFWebView mouseDown:]): Use new method to set key modifiers for mouse events. (-[IFWebView keyDown:]): Use new shared code for key modifiers. (-[IFWebView keyUp:]): Use new shared code for key modifiers.

WebBrowser:

WebBrowser part of the fix for:

Radar 2896391 - command-click should open link in new window

  • WebController.m: (-[WebController openNewWindowWithURL:]): Implement this new IFWebController method by opening a new browser window.
3:23 PM Changeset in webkit [1210] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-23 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Maciej Stachowiak

Fix for this bug:

Radar 2935882 (IFURLFileReader class has unbalanaced release count on an NSData ivar)

IFURLFileReader can create an ivar that points to a data using an method that
returns an autoreleased object. Then, without retaining the data anywhere
internally, it releases the data in its dealloc method.

This has been fixed. Now the retain/release count is guaranteed to be balanced

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileReader initWithPath:])
3:11 PM Changeset in webkit [1209] by kocienda
  • 5 edits in trunk/WebCore

2002-05-23 Kenneth Kocienda <​kocienda@apple.com>

More work to fix this bug:

Radar 2883631 (need to implement support for META HTTP_EQUIV=REFRESH)

There was yet two more cases where the refresh timers were getting clobbered.
Fixed.

  • khtml/ecma/kjs_window.cpp: (WindowQObject::parentDestroyed)
  • khtml/khtmlview.cpp: (KHTMLView::clear)
3:01 PM Changeset in webkit [1208] by rjw
  • 4 edits in trunk/WebCore

Fixed crasher 2935757. I still need to investigate the root cause
of this problem.

11:36 AM Changeset in webkit [1207] by kocienda
  • 17 edits in trunk

2002-05-23 Kenneth Kocienda <​kocienda@apple.com>

Fixes for these bugs:

Radar 2883631 (need to implement support for META HTTP_EQUIV=REFRESH)
Radar 2935472 (Non-standard html pages don't always get decoded)

WebCore

  • khtml/khtml_part.cpp: Don't kill all timers. Just kill the ones for this object. (KHTMLPart::~KHTMLPart):
  • khtml/khtml_part.h: Modified interface to slotData to add a flag for when all data for a load has been received.
  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Don't kill all timers. Just kill the ones for this object.
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::slotData): Senses when text encoding is not available, but all data has been received. (KHTMLPart::write): Ditto (KHTMLPart::scheduleRedirection):
  • libwebcore.exp: Changed symbol for slotData

WebKit:

  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient setContentPolicy:]): Updated method to use new processData interface. (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Senses when all data has been received for a load. (-[IFMainURLHandleClient processData:isComplete:allDataReceived:]): Modified interface to add a flag for when all data for a load has been received.
9:38 AM Changeset in webkit [1206] by sheridan
  • 8 edits in trunk

changing version number back to "unofficial"
tree is open

6:13 AM Changeset in webkit [1205]
  • 6 copies
    1 delete in tags/Alexander-5

This commit was manufactured by cvs2svn to create tag 'Alexander-5'.

6:13 AM Changeset in webkit [1204] by mjs
  • 17 edits
    20 adds in trunk

WebKit:

Move authentication panel to WebKit and make it a sheet, fixing:

Radar 2876445 - Authentication panel should be a sheet
Radar 2876449 - The Alexander authentication panel should be moved
to WebKit for use as a standard one

  • Panels.subproj/English.lproj/IFAuthenticationPanel.nib: Added.
  • Panels.subproj/IFAuthenticationPanel.h: Added.
  • Panels.subproj/IFAuthenticationPanel.m: Added.
  • Panels.subproj/IFPanelAuthenticationHandler.h: Added.
  • Panels.subproj/IFPanelAuthenticationHandler.m: Added.
  • Panels.subproj/IFStandardPanels.h: Added.
  • Panels.subproj/IFStandardPanels.m: Added.
  • Panels.subproj/IFStandardPanelsPrivate.h: Added.
  • WebKit.pbproj/project.pbxproj: Add new files to build.
  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandleResourceDidBeginLoading:]): Notify of load start. (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): Notify of load end. (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): Likewise. (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): Likewise. (-[IFPluginStream IFURLHandle:didRedirectToURL:]): Notify that old URL is no longer loading, but new one is.
  • WebView.subproj/IFBaseWebControllerPrivate.h:
  • WebView.subproj/IFBaseWebControllerPrivate.mm: (-[IFBaseWebController _didStartLoading:]): New private method used to track what URLs are loading on behalf of this controller. (-[IFBaseWebController _didStopLoading:]): Likewise.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]): Notify of load start. (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): Notify of load end. (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): Likewise. (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Likewise. (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Likewise. (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): Notify of load end and start.

WebCore:

Notify when loads of sub-URLs start and stop, so panels for these
can be attached to the right windows.

  • kwq/KWQKloader.mm: (-[URLLoadClient IFURLHandleResourceDidBeginLoading:]): (-[URLLoadClient IFURLHandleResourceDidCancelLoading:]): (-[URLLoadClient IFURLHandleResourceDidFinishLoading:data:]): (-[URLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[URLLoadClient IFURLHandle:didRedirectToURL:]):
  • kwq/external.h:
Note: See TracTimeline for information about the timeline view.