Context Navigation

← Previous Period
Next Period →

Timeline

May 28, 2002:

5:00 PM Changeset in webkit [1231] by rjw

6 edits in trunk/WebCore

Moved cancellation check before creation on job instance,
preventing leak.

4:55 PM Changeset in webkit [1230] by sullivan

16 edits in trunk/WebKit

Made -[IFBookmark group] and -[IFBookmark parent] public
methods, and renamed them to not use leading underscores,
as part of support for revealing a particular bookmark in
the Bookmarks window.

Bookmarks.subproj/IFBookmark_Private.h: removed _group and _parent.

Bookmarks.subproj/IFBookmark.h: added group and parent.

fixed 2923488 -- Silent failure when bookmark URL is invalid URL
fixed 2935830 (urls in Bookmarks should be "canonicalized" like urls in location field)
fixed 2935388 (errors in Activity window shouldn't show numeric error codes)

IFBookmarkAdditions.h: Added.
IFBookmarkAdditions.m: Added. (-[IFBookmark goTo]): New category, adds browser-specific behavior to IFBookmark. The first and only method so far goes to the bookmark's address; if the address string can't be turned into a valid URL, the user is told and given an opportunity to fix the address.

AppController.h:
AppController.m: (-[AppController showBookmarks:]): Moved initialization of _bookmarksController ivar out of here. (-[AppController _takeLocationFromBookmark:]): Now calls -[IFBookmark goTo]. (-[AppController bookmarksController]): New public method, initializes _bookmarksController ivar if necessary.

BookmarksController.h:
BookmarksController.m: (-[BookmarksController _goToSelectedItem:]): Now calls -[IFBookmark goTo]. (-[BookmarksController _expandAncestorsOfBookmark:]): New method, ensures that each ancestor folder of the specified bookmark is expanded in the outline view. (-[BookmarksController revealBookmark:]): New method, expands the bookmark's ancestors, then selects the bookmark and scrolls to reveal as necessary. (-[BookmarksController _editSelectedColumnWithID:]): New helper method, edits the contents of the specified column for the selected row. (-[BookmarksController editSelectedAddress]), (-[BookmarksController editSelectedName]): New methods, they call _editSelectedColumnWithID: for different columns. (-[BookmarksController _toggleEdit:]): Now calls editSelectedName.

IFErrorAdditions.m: (-[IFError errorSummary]): Removed error code from the string this method returns.

WebBrowser.pbproj/project.pbxproj: Updated for new files; also added new WebKit Additions group and moved some existing files into it.

4:17 PM Changeset in webkit [1229] by rjw

7 edits in trunk/WebCore

Fixed edge case cancellation problem (actually happens a lot).
No new loads are allowed after a data source has been
set as "stopping".

3:11 PM Changeset in webkit [1228] by rjw

4 edits in trunk/WebKit

Backed out band-aid add to fixed malformed resources URLs.

3:10 PM Changeset in webkit [1227] by rjw

7 edits in trunk/WebCore

Fixed reporting of malformed resources URLs. This fixed
exceptions that were being thrown because nil handles were
being added to datasource handle array.

2:07 PM Changeset in webkit [1226] by cblu

4 edits in trunk/WebKit

* empty log message *

1:18 PM Changeset in webkit [1225] by rjw

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Fixed double free of mapped file bytes (it's freed
by munmap).

11:34 AM Changeset in webkit [1224] by cblu

15 edits in trunk

WebBrowser:

Drag & Drop of file and URL support for the location field.

LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): Added URL and file drag types (-[LocationFieldEditor draggingEntered:]): new (-[LocationFieldEditor draggingUpdated:]): new (-[LocationFieldEditor prepareForDragOperation:]): new (-[LocationFieldEditor performDragOperation:]): new (-[LocationFieldEditor concludeDragOperation:]): support for URL and file types

WebKit:

Plugins.subproj/IFPluginDatabase.h:
Plugins.subproj/IFPluginDatabase.m: (-[IFPluginDatabase pluginForMimeType:]): renamed (-[IFPluginDatabase pluginForExtension:]): renamed (-[IFPluginDatabase pluginForFilename:]): renamed (findPlugins):
WebCoreSupport.subproj/IFWebCoreViewFactory.m: support for above renamed (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[IFWebCoreViewFactory viewForJavaAppletWithArguments:]):
WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _addURLHandle:]): fix for a nil handle being added to an array

WebCore:

Added framework-header-stamp

.cvsignore:

WebFoundation:

Fix for 2938040 - This flash movie at macboy.com doesn't load

Misc.subproj/IFNSStringExtensions.m: (-[NSString _IF_looksLikeAbsoluteURL]):

10:39 AM Changeset in webkit [1223] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFTextRenderer.m: (hasMissingGlyphs): Use recordSize instead of assuming records are sizeof(ATSLayoutRecord). (-[IFTextRenderer convertCharacters:length:toGlyphs:]): Free buffer after calling ATSUConvertCharToGlyphs; old code was using buffer after freeing it. (-[IFTextRenderer widthForString:]): Handle case where string is longer than LOCAL_GLYPH_BUFFER_SIZE. (-[IFTextRenderer slowPackGlyphsForCharacters:numCharacters:glyphBuffer:numGlyphs:]): (-[IFTextRenderer drawString:atPoint:withColor:]): Use recordSize instead of assuming records are sizeof(ATSLayoutRecord). (-[IFTextRenderer slowFloatWidthForCharacters:length:]): Use recordSize instead of assuming records are sizeof(ATSLayoutRecord). (-[IFTextRenderer floatWidthForCharacters:length:]): Remove extra rounding. The caller that converts the width to an integer already does the rounding. (-[IFTextRenderer extendCharacterToGlyphMapToInclude:]): Fix off by one error that caused us to include one extra character in each glyph map block. Also use recordSize instead of assuming records are sizeof(ATSLayoutRecord).

May 27, 2002:

2:32 PM Changeset in webkit [1222] by sullivan

7 edits in trunk

Part of fix for 2922772 -- page title & location field don't
show redirected URLs.

WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource wasRedirected]): Fixed this method, now that we have a client that relies on it. Its logic was backwards, and it didn't handle the null _finalURL case.

WebBrowser part of fix for 2922772 -- page title & location field don't
show redirected URLs.

BrowserDocument.h: added BrowserDocumentRedirectedNotification
BrowserDocument.m: (-[BrowserDocument currentURL]): Return redirectedURL if appropriate.

BrowserWindow.m: (-[BrowserWindow windowDidLoad]): register for BrowserDocumentRedirectedNotification (-[BrowserWindow frameLoadRedirected:]): Update location field if appropriate.

LocationChangeHandler.m: (-[LocationChangeHandler serverRedirectTo:forDataSource:]): Send BrowserDocumentRedirectedNotification and title-changed messages if the frame is the top-level frame.

12:55 PM Changeset in webkit [1221] by sullivan

3 edits
1 add in trunk/WebCore

Resources/linkCursor.tiff: Added. Maciej forgot to cvs add this new file. I stole the one from haircut.

Added FIXME.

BrowserDocument.m: (-[BrowserDocument displayName]):

1:58 AM Changeset in webkit [1220] by mjs

4 edits in trunk/WebCore

Fixed the vexing and long-standing:

Radar 2894699 - Crash at: http://cb.apple.com/jsplugins.html

khtml/ecma/kjs_navigator.cpp: This crash was caused by Plugin and MimeType objects referring to data that was held and refcounted by PluginBase, without holding a ref. I fixed it by making these individual items participate in the refcounting as well.

May 26, 2002:

10:59 PM Changeset in webkit [1219] by mjs

4 edits in trunk/WebKit

Fixed Radar 936147 - debug output in console "keyUp: NSEvent: type=KeyUp"

WebView.subproj/IFWebView.mm: (-[IFWebView keyDown:]): Turned NSLog into WEBKITDEBUGLEBEL. (-[IFWebView keyUp:]): Likewise.

10:01 PM Changeset in webkit [1218] by mjs

21 edits in trunk

WebCore:

Webcore part of fix for:

Radar 2884085 - add support for changing cursor over links

Makefile.am: Install tiff of link cursor.
kwq/qt/qcursor.h, kwq/KWQCursor.mm: (QCursor::QCursor): Change QCursor to contain an NSCursor. (QCursor::~QCursor): Likewise. (QCursor::operator=): Likewise. (QCursor::handle): Likewise.
kwq/KWQKCursor.mm: (+[NSCursor _WebCore_linkCursor]): NSCursor extension method that provides the link cursor. (KCursor::handCursor): Use the link cursor instead of the default arrow cursor.
kwq/KWQKHTMLSettings.mm: (KHTMLSettings::changeCursor): Return TRUE; we always want cursor tracking.
kwq/KWQView.h, kwq/KWQView.mm: (-[KWQHTMLView setCursor:]): Remember the new cursor and invalidate cursor rects. (-[KWQHTMLView resetCursorRects]): Establish cursor rect for currently set cursor, if not default.
kwq/KWQWidget.mm: (QWidget::setCursor): Call setCursor: on the underlying NSView, if implemented. (QWidget::cursor): Implemented. (QWidget::unsetCursor): Implemented.

WebKit:

WebKit part of fix for:

Radar 2884085 - add support for changing cursor over links

Also, fix handling of mouseMoved events.

WebView.subproj/IFWebView.mm: (-[IFWebView mouseMovedNotification:]): Clip mouseMoved events to the view rect, otherwise mouseover effects might happen for elements past the edge of the window. (-[IFWebView setCursor:]): Implement. (-[IFWebView resetCursorRects]): Implement.
WebView.subproj/IFWebViewPrivate.h:
WebView.subproj/IFWebViewPrivate.mm: (-[IFWebViewPrivate dealloc]): Added NSCursor *cursor field.