Context Navigation

← Previous Period
Next Period →

Timeline

Jun 2, 2002:

4:16 PM Changeset in webkit [1254] by darin

4 edits in trunk/JavaScriptCore

COPYING.LIB: Fix line endings. It was using CRs.

Jun 1, 2002:

12:40 PM Changeset in webkit [1253] by darin

4 edits in trunk/WebKit

WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer beginAnimationInView:inRect:fromRect:]): Remove an assert I added, since it is firing, and instead fixed the storage leak that inspired me to put the assert in.

9:32 AM Changeset in webkit [1252] by darin

4 edits in trunk/WebCore

kwq/KWQPtrDictImpl.mm: (KWQPtrDictPrivate::~KWQPtrDictPrivate): Fix compile error.

May 31, 2002:

11:07 PM Changeset in webkit [1251] by darin

7 edits in trunk/WebCore

Fix infinite loop while cancelling bug that was caused by dictionary
iterators not getting updated when keys are removed.

kwq/KWQPtrDictImpl.mm: (KWQPtrDictPrivate::KWQPtrDictPrivate): Set iterators list to 0. (KWQPtrDictPrivate::~KWQPtrDictPrivate): Tell iterators dict is gone. (KWQPtrDictImpl::remove): Tell each iterator that the item was removed. (KWQPtrDictIteratorPrivate::KWQPtrDictIteratorPrivate): Insert the iterator into a list with a head stored in the dict. (KWQPtrDictIteratorPrivate::~KWQPtrDictIteratorPrivate): Remove the iterator from the list. (KWQPtrDictIteratorPrivate::remove): Remove the key from the iterator's private storage. (KWQPtrDictIteratorPrivate::dictDestroyed): Clear out the dict pointer and set the count to 0.

kwq/KWQPtrDictImpl.h: Move private classes out so they can get at each other without being friends of each other.

kwq/qt/qptrdict.h: Simplify a bit.

8:57 PM Changeset in webkit [1250] by darin

7 edits in trunk/WebCore

khtml/khtmlview.h: Add KWQKHTMLPartImpl as friend class, remove khtml_part.h include that we added inside APPLE_CHANGES.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::end): Reinstate a line of code that required friend status.

kwq/KWQView.mm: Add include of khtml_part.h.

6:11 PM Changeset in webkit [1249] by darin

4 edits in trunk/WebKit

WebView.subproj/IFWebViewPrivate.mm: Add include to prepare for change to WebCore that will make it required.

5:04 PM Changeset in webkit [1248] by darin

4 edits in trunk/WebCore

kwq/kwqdebug.h: Don't use displayableString; it's an SPI and those are no nos inside WebCore.

5:03 PM Changeset in webkit [1247] by darin

8 edits in trunk/WebKit

WebCoreSupport.subproj/IFImageRenderer.h: Fixed the line endings (they were Macintosh CRs instead of Unix LFs). Also made all the methods be private for now since there's no need to have them be public.

WebCoreSupport.subproj/IFImageRenderer.m: Fixed the line endings (they were Macintosh CRs instead of Unix LFs). Some minor code tweaks too sharing a bit more code.

WebCoreSupport.subproj/IFImageRendererFactory.m: (-[IFImageRendererFactory imageRendererWithSize:]): Return an IFImageRenderer rather than just an NSImage, since an NSImage does not satisfy WebCoreImageRenderer.

11:33 AM Changeset in webkit [1246] by darin

14 edits
1 delete in trunk/WebCore

kwq/kio/jobclasses.h: Removed SimpleJob and made Job just enough for TransferJob to inherit from it. Removed unused stuff and made url() return an NSURL rather than a KURL.
kwq/KWQKjobclasses.mm: Removed much of the code, and reworked what remains to simplify it.
kwq/KWQKloader.mm: Update users of TransferJob::url since it now returns an NSURL rather than a KURL.

kwq/kio/job.h: Simplify.
kwq/KWQKJob.mm: Simplify.

kwq/kio/scheduler.h: Emptied this file out.
kwq/KWQKScheduler.mm: Removed.
kwq/Makefile.am: Removed KWQKScheduler.mm.

7:35 AM Changeset in webkit [1245] by darin

82 edits
6 adds
19 deletes in trunk/WebCore

Remove some unused stuff; total of 1000s of lines.

Makefile.am: Removed some strange uses of "./" and improved stamp-related rules.

WebCore-tests.exp: Removed QDir functions.

khtml/Makefile.am: Removed java subdirectory.
khtml/java/*: Removed.
khtml/rendering/render_applet.cpp: Rearrange APPLE_CHANGES so that we use our own KJavaAppletWidget rather than a QWidget.
kwq/khtml/java/kjavaappletcontext.h: Added.
kwq/khtml/java/kjavaappletwidget.h: Added.
kwq/KWQKJavaAppletWidget.mm: Added. Replaces WCJavaAppletWidget.mm.
kwq/KWQsignals.mm: Removed java-related signals.

khtml/css/Makefile.am:
khtml/misc/Makefile.am: Improve stamp-related rules.

khtml/misc/loader.cpp: Move around and add ifdefs so we don't need as much KWQ code. Maybe revisit this later -- related to the KDE implementation of animated and progressive loading images, which we probably don't need, but it may integrate slightly better than doing our hacks inside QPixmap.

kwq/KWQApplication.mm:
kwq/KWQFontInfo.mm:
kwq/KWQInputDialog.mm:
kwq/KWQKFileDialog.mm:
kwq/KWQKHTMLPartBrowserExtension.mm:
kwq/KWQKWin.mm:
kwq/KWQKWinModule.mm:
kwq/KWQKstddirs.mm:
kwq/KWQPixmap.mm: Simplified, removed unused code, minor tweaks.

kwq/Makefile.am: Removed all the old files, added some new ones.
kwq/KWQBitmap.mm: Removed.
kwq/KWQBrush.mm: Removed.
kwq/KWQDCOPClient.mm: Removed.
kwq/KWQDataStream.h: Removed.
kwq/KWQDir.mm: Removed.
kwq/KWQFontDatabase.mm: Removed.
kwq/KWQImage.mm: Removed.
kwq/KWQKInstance.mm: Removed.
kwq/KWQPaintDevice.mm: Removed.
kwq/KWQPart.mm: Removed.
kwq/KWQasyncimageio.mm: Removed.
kwq/KWQasyncio.mm: Removed.
kwq/KWQbrowserextension.mm: Removed.
kwq/WCJavaAppletWidget.h: Removed.
kwq/WCJavaAppletWidget.mm: Removed.
kwq/qt/qdatastream.h: Removed.
kwq/qt/qdir.h: Removed.
kwq/qt/qlayout.h: Removed.

kwq/KWQCursor.mm: (QCursor::handle): Return the cursor object as an integer rather than just returning 0; makes the code that uses handle() more likely to work although it introduces a 64-bit cleanliness problem.

kwq/KWQEvent.mm: Initialize event type in QEvent subclasses.

kwq/WebCoreImageRenderer.h: Added NSObject and NSCopying protocols to the WebCoreImageRenderer protocol.

kwq/kwqdebug.h: Use displayableString in DEBUG_OBJECT for better logging.

kwq/dcop/dcopclient.h:
kwq/kdecore/kstddirs.h:
kwq/kdecore/kwin.h:
kwq/kdecore/kwinmodule.h:
kwq/kfile/kfiledialog.h:
kwq/kparts/browserextension.h:
kwq/kparts/event.h:
kwq/qt/qapplication.h:
kwq/qt/qasyncimageio.h:
kwq/qt/qasyncio.h:
kwq/qt/qbitmap.h:
kwq/qt/qbrush.h:
kwq/qt/qbutton.h:
kwq/qt/qcheckbox.h:
kwq/qt/qcollection.h:
kwq/qt/qcolor.h:
kwq/qt/qcombobox.h:
kwq/qt/qcursor.h:
kwq/qt/qdrawutil.h:
kwq/qt/qevent.h:
kwq/qt/qfont.h:
kwq/qt/qfontdatabase.h:
kwq/qt/qfontinfo.h:
kwq/qt/qimage.h:
kwq/qt/qinputdialog.h:
kwq/qt/qintcache.h:
kwq/qt/qintdict.h:
kwq/qt/qpaintdevice.h:
kwq/qt/qpixmap.h:
kwq/qt/qstring.h: Removed lots of unused stuff, including old conditionals and the like.

khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseMoveEvent): Add missing parenthesis.

7:05 AM Changeset in webkit [1244] by darin

5 edits in trunk/JavaScriptCore

Makefile.am:
kjs/Makefile.am: Slight improvements to rules that touch stamp files.

7:05 AM Changeset in webkit [1243] by darin

5 edits in trunk/WebKit

Misc.subproj/WebKitDebug.h: Use displayableString in DEBUG_OBJECT for nicer logging.

WebView.subproj/IFWebView.mm: (-[IFWebView keyDown:]): (-[IFWebView keyUp:]): Use DEBUG_OBJECT so we don't get exceptions when the key characters are not simple ASCII characters.

May 30, 2002:

6:48 PM Changeset in webkit [1242] by rjw

6 edits in trunk/WebKit

API and comment cleanup.

5:41 PM Changeset in webkit [1241] by mjs

36 edits in trunk

WebCore:

WebCore part of fixes for:

Radar 2926169 - no support for window.open
Radar 2890469 - Preference to prevent JavaScript from automatically
opening new windows doesn't work
Radar 2938569 - link cursor does not appear on some pages

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): #ifdef'd out some parts of this code that are broken (but fortunately also unnecessary) in our project.
kwq/KWQKConfigBase.mm: (KConfig::KConfig): Changes to support JavaScript window opening pref. (KConfig::readUnsignedNumEntry): Likewise.
kwq/KWQKHTMLPart.mm: (KHTMLPart::openURLInFrame): Implemented.
kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::KHTMLPartBrowserExtension): Implemented. (KHTMLPartBrowserExtension::openURLRequest): Implemented by calling openURLInFrame on the part. (KHTMLPartBrowserExtension::createNewWindow): Implemented by calling new WebController openNewWindowWIthURL method.
kwq/KWQKHTMLSettings.mm: (KHTMLSettings::isJavaScriptEnabled): Handle renaming of pref.
kwq/KWQView.mm: (-[KWQHTMLView setCursor:]): Fixes to set cursor properly even if none was set.
kwq/external.h: Declare some new WebKit methods.
kwq/kparts/browserextension.h: Make formerly empty methods pure virtual.
kwq/khtml/khtml_ext.h: Declare some virtual methods.

WebKit:

WebKit parts of fixes for:

Radar 2926169 - no support for window.open
Radar 2890469 - Preference to prevent JavaScript from automatically
opening new windows doesn't work
Radar 2938569 - link cursor does not appear on some pages

WebView.subproj/IFWebController.h: Added openNewWindowWithURL: method for the benefit of JavaScript.
WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController openNewWindowWithURL:]): No-op default implementation.
WebView.subproj/IFDynamicScrollBarsView.h:
WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView setCursor:]): Fix cursor handling. (-[IFDynamicScrollBarsView resetCursorRects]): Likewise.
WebView.subproj/IFWebView.mm: (-[IFWebView mouseMovedNotification:]): Likewise. (-[IFWebView setCursor:]): Likewise.
WebView.subproj/IFPreferences.h:
WebView.subproj/IFPreferences.mm: (-[IFPreferences javaScriptEnabled]): Renamed from jScriptEnabled. (-[IFPreferences setJavaScriptEnabled:]): Renamed from setJScriptEnabled. (-[IFPreferences javaScriptCanOpenWindowsAutomatically]): New method. (-[IFPreferences setJavaScriptCanOpenWindowsAutomatically:]): Likewise.
WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:view:provisionalDataSource:controller:]): Create a dummy provisional data source if none is provided, so we always have a part for the frame.

WebBrowser:

2:52 PM Changeset in webkit [1240] by darin

61 edits
6 adds
1 delete in trunk

WebCore:

Cut down our copied and pasted code even more.

WebCore.exp: Change what's exported for things that moved from KHTMLPart into KWQKHTMLPartImpl.

khtml/.cvsignore:
khtml/css/.cvsignore:
khtml/dom/.cvsignore:
khtml/ecma/.cvsignore:
khtml/html/.cvsignore:
khtml/java/.cvsignore:
khtml/misc/.cvsignore:
khtml/rendering/.cvsignore:
khtml/xml/.cvsignore: Some .cvsignore hygiene.

khtml/khtml_part.cpp: Use a lot more of this file, rather than using a copy inside the kwq directory. Now we have KWQKHTMLPartImpl for the part that does need to be in kwq.
khtml/khtml_part.h: Add KWQKHTMLPartImpl pointer, remove most of the other APPLE_CHANGES.
khtml/khtmlpart_p.h: Remove almost all of the APPLE_CHANGES.
kwq/KWQKHTMLPart.mm: Changed everything from being part of KHTMLPart to be a separate KWQKHTMLPartImpl class. Minimized copied and pasted code; still more to do.
kwq/KWQKHTMLPartImpl.h: Added. Interface so KHTMLPart can call into kwq as necessary.

khtml/misc/Makefile.am: Added loader.cpp.
khtml/misc/loader.cpp: Added from KDE 3.0. Rolled most of the changes from KWQKloader.mm in here. The kwq-specific part is now in a KWQLoaderImpl class.
khtml/misc/loader.h: Replace LoaderPrivate with KWQLoaderImpl.
khtml/misc/loader.moc: Added empty file.
kwq/KWQKloader.mm: Changed everything to be a separate KWQLoaderImpl class. Minimized copied and pasted code.
kwq/KWQLoaderImpl.h: Added. Interface so loader can call into kwq as necessary.
kwq/loader.moc: Removed empty file.

kwq/kparts/historyprovider.h: Add HistoryProvider::insert.
kwq/KWQKHistoryProvider.mm: Add HistoryProvider::insert.

kwq/KWQKLocale.mm: (KLocale::language): Simplify.

kwq/KWQListBox.h:
kwq/KWQNSTextField.h: Use import instead of include for Cocoa.h.

kwq/KWQScrollView.mm: (QScrollView::contentsToViewport): Implement this.

kwq/external.h: Add declarations so this can be included cleanly.

kwq/khtml/khtml_pagecache.h: Put a no-op cache in here so we don't have to do so many APPLE_CHANGES ifdefs.

kwq/kparts/part.h: Put ref/deref and event/customEvent in here so they don't need to be added to KHTMLPart.

kwq/kio/scheduler.h: Add <qtimer.h> include to help us build (not sure if it's really needed.
kwq/kparts/partmanager.h: Add <qdatetime.h> include to help us build (not sure if it's really needed.

WebKit:

Use methods in KWQKHTMLPartImpl that were moved there from KHTMLPart.

WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): (-[IFMainURLHandleClient processData:isComplete:allDataReceived:]):
WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource documentText]):
WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setController:]):
WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):
WebView.subproj/IFWebView.mm: (-[IFWebView provisionalDataSourceChanged:]):

2:01 PM Changeset in webkit [1239] by mjs