Timeline



Jun 12, 2002:

8:33 PM Changeset in webkit [1340] by cblu
  • 75 edits
    34 adds
    4 deletes in trunk

Couldn't run ChangeLog because it hung with the massize diffs, so here's
a hand-made one.

Changes to support inline views.

Modified Files:

WebBrowser/BrowserDocument.m
WebBrowser/LocationChangeHandler.m
WebBrowser/Debug/DebugUtilities.m WebCore/WebCore.exp
WebCore/kwq/KWQKHTMLPart.mm
WebCore/kwq/KWQKHTMLPartBrowserExtension.mm
WebCore/kwq/KWQKloader.mm WebCore/kwq/KWQScrollView.mm
WebCore/kwq/KWQView.h WebCore/kwq/KWQView.mm
WebCore/kwq/KWQWidget.mm WebCore/kwq/external.h
WebKit/ChangeLog WebKit/Plugins.subproj/IFNullPluginView.mm
WebKit/Plugins.subproj/IFPluginDatabase.h
WebKit/Plugins.subproj/IFPluginDatabase.m
WebKit/Plugins.subproj/IFPluginView.mm
WebKit/WebCoreSupport.subproj/IFImageRenderer.h

WebKit/WebCoreSupport.subproj/IFWebCoreViewFactory.m

WebKit/WebKit.pbproj/project.pbxproj
WebKit/WebView.subproj/IFDOMNode.mm
WebKit/WebView.subproj/IFDynamicScrollBarsView.m
WebKit/WebView.subproj/IFMainURLHandleClient.h
WebKit/WebView.subproj/IFMainURLHandleClient.mm
WebKit/WebView.subproj/IFRenderNode.mm
WebKit/WebView.subproj/IFWebController.h
WebKit/WebView.subproj/IFWebController.mm
WebKit/WebView.subproj/IFWebControllerPrivate.h
WebKit/WebView.subproj/IFWebControllerPrivate.mm
WebKit/WebView.subproj/IFWebDataSource.h
WebKit/WebView.subproj/IFWebDataSource.mm
WebKit/WebView.subproj/IFWebDataSourcePrivate.h
WebKit/WebView.subproj/IFWebDataSourcePrivate.mm
WebKit/WebView.subproj/IFWebFrame.mm
WebKit/WebView.subproj/IFWebFramePrivate.h
WebKit/WebView.subproj/IFWebFramePrivate.mm
WebKit/WebView.subproj/IFWebView.h
WebKit/WebView.subproj/IFWebView.mm
WebKit/WebView.subproj/IFWebViewPrivate.h
WebKit/WebView.subproj/IFWebViewPrivate.mm

Added Files:

WebKit/Misc.subproj/IFNSViewExtras.h
WebKit/Misc.subproj/IFNSViewExtras.m
WebKit/WebView.subproj/IFDocument.h
WebKit/WebView.subproj/IFHTMLRepresentation.h
WebKit/WebView.subproj/IFHTMLRepresentation.mm
WebKit/WebView.subproj/IFHTMLView.h
WebKit/WebView.subproj/IFHTMLView.mm
WebKit/WebView.subproj/IFHTMLViewPrivate.h
WebKit/WebView.subproj/IFHTMLViewPrivate.mm
WebKit/WebView.subproj/IFImageRepresentation.h
WebKit/WebView.subproj/IFImageRepresentation.m
WebKit/WebView.subproj/IFImageView.h
WebKit/WebView.subproj/IFImageView.m
WebKit/WebView.subproj/IFTextRepresentation.h
WebKit/WebView.subproj/IFTextRepresentation.m
WebKit/WebView.subproj/IFTextView.h
WebKit/WebView.subproj/IFTextView.m

Removed Files:

WebKit/MIME.subproj/IFContentHandler.h
WebKit/MIME.subproj/IFContentHandler.m

WebKit/MIME.subproj/IFMIMEHandler.h

WebKit/MIME.subproj/IFMIMEHandler.m

3:09 PM Changeset in webkit [1339] by kocienda
  • 7 edits in trunk

2002-06-12 Kenneth Kocienda <​kocienda@apple.com>

Made assertion failure console message bolder and easier to see.

  • WebFoundation/Misc.subproj/WebFoundationDebug.h
  • WebKit/Misc.subproj/WebKitDebug.h
  • WebCore/kwq/kwqdebug.h
9:26 AM Changeset in webkit [1338] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/nodes.cpp: (Node::finalCheck): A bit of APPLE_CHANGES so we can compile with KJS_DEBUG_MEM defined if we want to.

Jun 11, 2002:

4:52 PM Changeset in webkit [1337] by darin
  • 7 edits in trunk/WebKit
  • WebView.subproj/IFMainURLHandleClient.mm: Add lots of assertions that allowed me to find the "leak the world" bug that Ken fixed in WebFoundation. These are a good idea anyway.
  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream initWithURL:pluginPointer:notifyData:attributes:]): Use cStringLength to get the length for the cString rather than assuming that length will be right. (-[IFPluginStream IFURLHandle:didRedirectToURL:]): Add a FIXME.
4:51 PM Changeset in webkit [1336] by darin
  • 3 edits in trunk/WebCore

Change log should have said: Remove the workaround for CFURL bug 2891336.

4:48 PM Changeset in webkit [1335] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQKURL.mm: (RelativeURLKeyRetainCallBack): Use a ref count. (RelativeURLKeyReleaseCallBack): Use a ref count instead of assuming there will never be more than one reference. (KURL::normalizeRelativeURLString): Use a ref count. (operator==): Don't put URLs on the autorelease pool just to compare them.
2:16 PM Changeset in webkit [1334] by sullivan
  • 16 edits in trunk/WebKit

Made methods that convert bookmarks to and from
property-list-compatible dictionaries public so they
can be used in the Bookmarks window for cut/paste.

  • Bookmarks.subproj/IFBookmark.h:
  • Bookmarks.subproj/IFBookmark.m: (+[IFBookmark bookmarkFromDictionaryRepresentation:withGroup:]): New method

(-[IFBookmark initFromDictionaryRepresentation:withGroup:]):
(-[IFBookmark dictionaryRepresentation]):

  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _loadBookmarkGroupGuts]): (-[IFBookmarkGroup _saveBookmarkGroupGuts]):
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkLeaf dictionaryRepresentation]):
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkList dictionaryRepresentation]):
  • Bookmarks.subproj/IFBookmarkSeparator.m: (-[IFBookmarkSeparator initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkSeparator dictionaryRepresentation]):
  • Bookmarks.subproj/IFBookmark_Private.h: Removed leading underscores from _initFromDictionaryRepresentation and _dictionaryRepresentation, and made them public.

-fixed 2921580 -- Need Cut/Copy/Paste support in Bookmarks window
-fixed 2952869 -- Alexander offers to undo Bookmark address change
when nothing changed
-made Activity, Bookmarks, and History window set the initial first
responder to their outline views, so Select All and keyboard navigation
work without requiring an initial click.
-eliminated unsightly gray line above outline views in Activity, Bookmarks,
and History windows

  • ActivityViewer.m: (-[ActivityViewer _setUpWindow]): Make outline view be first responder.
  • BookmarksController.h: Add ivars for _droppablePasteboardTypes and _pasteablePasteboardTypes; maybe these will be the same eventually.
  • BookmarksController.m: (-[BookmarksController _droppablePasteboardTypes]), (-[BookmarksController _pasteablePasteboardTypes]): Return array of the types we handle, lazily creating the array if necessary. (-[BookmarksController windowDidLoad]): Use _droppablePasteboardTypes; make outline view be first responder. (-[BookmarksController dealloc]): release new ivars (-[BookmarksController _selectedBookmarksWithoutRedundantDescendants]), (-[BookmarksController removeSelectedBookmarks:]): Extracted _selectedBookmarks... from removeSelectedBookmarks. (-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]): Fixed copy/paste error that was the cause of 2952869 (-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]): Call [NSPasteboard availableTypeFromArray:] instead of making dangerous assumptions. (-[BookmarksController _setSelectionToBookmarks:]), (-[BookmarksController outlineView:acceptDrop:item:childIndex:]): extracted _setSelectionToBookmarks: into its own function, and used availableTypeFromArray:

(-[BookmarksController copy:]),
(-[BookmarksController paste:]),
(-[BookmarksController clear:]),
(-[BookmarksController cut:]): New methods; the last three are Undoable

(-[BookmarksController _numberOfBookmarksOnPasteboard:]): New helper method used
to set title of Paste menu item.

(-[BookmarksController validateMenuItem:]): New method, used for items whose titles
change (i.e. Cut/Copy/Paste/Clear)
(-[BookmarksController validateUserInterfaceItem:]): No change, just moved.

  • English.lproj/ActivityViewer.nib,
  • English.lproj/Bookmarks.nib,
  • English.lproj/History.nib: Made outline views one pixel taller to avoid unsightly gray line at top.
  • GlobalHistory.h:
  • GlobalHistory.m: (-[selectAll:]): Removed unnecessary method. (-[GlobalHistory validateUserInterfaceItem:]): Removed validation for selectAll; let outline view handle it. (-[GlobalHistory showWindow:]): Make outline view be first responder.
1:50 PM Changeset in webkit [1333] by darin
  • 5 edits
    10 adds in trunk/WebKit

WebKit:

  • WebView.subproj/IFDOMNode.h: Added.
  • WebView.subproj/IFDOMNode.mm: Added.
  • WebView.subproj/IFRenderNode.h: Added.
  • WebView.subproj/IFRenderNode.mm: Added. These contain all the interesting bits of the code for the render and DOM tree viewers, mostly moved here from WebBrowser.
  • WebView.subproj/IFWebViewPrivate.mm: Remove the methods in here that aren't declared in the header and are only used for the render and DOM tree viewers.
  • WebKit.pbproj/project.pbxproj: Add new files.

WebBrowser:

Removed all C and Objective C++, making this all Objective C again, which
helps make build times faster.

  • _CFA2UC.c: Removed.
  • WebBrowserPrefix.h: Removed code to handle non-Objective C, and also removed <config.h>.
  • Debug/DOMTree.m: Renamed from DOMTree.mm. Also changed to use IFDOMNode from WebKit for all the interesting bits.
  • Debug/DOMTree.mm: Renamed to DOMTree.m.
  • Debug/DOMTree.h: Put dataSource in object as a step toward making this not leak some day.
  • Debug/RenderTree.m: Renamed from RenderTree.mm. Also changed to use IFRenderNode from WebKit for all the interesting bits.
  • Debug/RenderTree.mm: Renamed to RenderTree.m.
  • Debug/RenderTree.h: Put dataSource in object as a step toward making this not leak some day.
  • WebBrowser.pbproj/project.pbxproj: Change files around. Add warnings that weren't allowed in C++; this project is now all Objective C. Remove C and Objective C++ from PFE dialects list. Remove header search paths.
  • main.m: Use "../config.h" to get at config.h. In the long run, we can just get rid of this.
  • Debug/DebugUtilities.m: Unimportant tweaks.

Jun 10, 2002:

5:05 PM Changeset in webkit [1332] by darin
  • 5 edits
    1 add in trunk/WebKit
  • Makefile.am: Do a clean before building if the force-clean-timestamp file is newer than the previous-clean-timestamp. Edit force-clean-timestamp (doesn't matter what you change as long as you change it) to force a clean build in WebKit.
  • force-clean-timestamp: Added.
  • .cvsignore: Ignore previous-clean-timestamp.
3:18 PM Changeset in webkit [1331] by darin
  • 6 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.h: Remove the flavor of floatWidthForCharacters without the applyRounding boolean.
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Remove logic about characters in the 0x7F-0xA0 range, since it's already handled by the time we get around to drawing. (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:]): Pass in the applyRounding boolean when calling through to slowFloatWidthForCharacters. Move logic about characters in the 0x7F-0xA0 range from here into [extendCharacterToGlyphMapToInclude:]. (-[IFTextRenderer widthForCharacters:length:]): Call the version of floatWidthForCharacters that takes the applyRounding parameter; this was the only client of the flavor that didn't take the parameter. (-[IFTextRenderer extendCharacterToGlyphMapToInclude:]): Add the logic about characters in the 0x7F-0xA0 range into here.
1:45 PM Changeset in webkit [1330] by darin
  • 4 edits in trunk/WebCore
  • khtml/css/cssstyleselector.cpp: Fix uninitialized variable warning.
1:09 PM Changeset in webkit [1329] by rjw
  • 8 edits in trunk/WebKit

i Tweaks to new rounding code.

Added Cocoa-exact width measurement emulation flag to support IFStringTruncator.

Remove code that was already conditionally excluded calls to support
non-specified advance drawing (we now depend on tweaked advances).

  • Misc.subproj/IFStringTruncator.m: (+[IFStringTruncator centerTruncateString:toWidth:withFont:]):
  • WebCoreSupport.subproj/IFTextRenderer.h:
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer initWithFont:]): (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer slowFloatWidthForCharacters:length:applyRounding:]): (-[IFTextRenderer slowFloatWidthForCharacters:length:]): (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:]): (-[IFTextRenderer floatWidthForCharacters:length:]): (-[IFTextRenderer extendCharacterToGlyphMapToInclude:]):
1:08 PM Changeset in webkit [1328]
  • 1 copy
    112 deletes in branches/unlabeled-1.4.56

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.4.56'.

1:08 PM Changeset in webkit [1327]
  • 1 copy
    111 deletes in branches/unlabeled-1.3.56

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.3.56'.

1:08 PM Changeset in webkit [1326] by darin
  • 141 edits
    1 add in trunk

JavaScriptCore:

Merged in changes from KDE 3.0.1.

  • kjs/collector.cpp:
  • kjs/date_object.cpp:
  • kjs/function.cpp:
  • kjs/internal.cpp:
  • kjs/lookup.h:
  • kjs/object.cpp:
  • kjs/operations.cpp:
  • kjs/regexp.cpp:
  • kjs/regexp_object.cpp:
  • kjs/regexp_object.h:
  • kjs/string_object.cpp:
  • kjs/testkjs.cpp:
  • kjs/ustring.cpp:
  • kjs/value.cpp:
  • kjs/value.h: Do the merge, and add APPLE_CHANGES as needed to make things compile.
  • kjs/date_object.lut.h: Re-generated.

WebCore:

Merged in changes from KDE 3.0.1.

  • kwq/kdecore/kurl.h:
  • kwq/KWQKURL.mm: (operator==): New, needed by some 3.0.1 code.
  • kwq/qt/qpalette.h: Add QPalette::NColorGroups and QColorGroup::NColorRoles.
  • kwq/KWQPalette.mm: Simplify by getting rid of "private" indirection. (QPalette::color): New, needed by some 3.0.1 code.
  • kwq/KWQColorGroup.mm: Simplify by getting rid of "private" indirection.
  • kwq/qt/qstring.h:
  • kwq/KWQString.mm: (QConstString::QConstString): Change parameter to const QChar * to match Qt so we compile.
  • kwq/qt/qtextedit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setTabStopWidth): Add unimplemented placeholder, needed by some 3.0.1 code.
  • kwq/qt/qvaluelist.h:
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: Simplify implementation.
  • WebCore-tests.exp: Update for changes in QValueList implementation.
  • kwq/kdecore/klibloader.h: Add include of <kio/global.h> to make something compile.
  • kwq/khtml/java/kjavaappletcontext.h: Add JType and constructor that takes DCOPObject*.
  • kwq/kio/global.h: Add KIO::CacheControl.
  • khtml/css/css_ruleimpl.cpp:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_stylesheetimpl.h:
  • khtml/css/css_valueimpl.cpp:
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp:
  • khtml/css/cssparser.h:
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/css/html4.css:
  • khtml/dom/css_rule.cpp:
  • khtml/dom/css_rule.h:
  • khtml/dom/css_stylesheet.cpp:
  • khtml/dom/css_stylesheet.h:
  • khtml/dom/css_value.cpp:
  • khtml/dom/dom2_events.cpp:
  • khtml/dom/dom2_range.cpp:
  • khtml/dom/dom2_range.h:
  • khtml/dom/dom2_views.cpp:
  • khtml/dom/dom_doc.cpp:
  • khtml/dom/dom_element.cpp:
  • khtml/dom/dom_exception.h:
  • khtml/dom/dom_node.cpp:
  • khtml/dom/dom_string.cpp:
  • khtml/dom/dom_text.cpp:
  • khtml/dom/dom_xml.cpp:
  • khtml/dom/html_base.cpp:
  • khtml/dom/html_block.cpp:
  • khtml/dom/html_document.cpp:
  • khtml/dom/html_element.cpp:
  • khtml/dom/html_element.h:
  • khtml/dom/html_form.cpp:
  • khtml/dom/html_head.cpp:
  • khtml/dom/html_image.cpp:
  • khtml/dom/html_inline.cpp:
  • khtml/dom/html_list.cpp:
  • khtml/dom/html_misc.cpp:
  • khtml/dom/html_object.cpp:
  • khtml/dom/html_table.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_proxy.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_formimpl.cpp:
  • khtml/html/html_miscimpl.h:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_objectimpl.h:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmlparser.h:
  • khtml/html/htmltokenizer.cpp:
  • khtml/html/htmltokenizer.h:
  • khtml/khtml_part.cpp:
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp:
  • khtml/misc/helper.cpp:
  • khtml/misc/khtmllayout.h:
  • khtml/misc/loader.cpp:
  • khtml/misc/loader.h:
  • khtml/misc/loader_client.h:
  • khtml/misc/shared.h: Added.
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/break_lines.cpp:
  • khtml/rendering/font.cpp:
  • khtml/rendering/render_applet.cpp:
  • khtml/rendering/render_applet.h:
  • khtml/rendering/render_container.cpp:
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_image.cpp:
  • khtml/rendering/render_object.cpp:
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp:
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_root.cpp:
  • khtml/rendering/render_style.cpp:
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.cpp:
  • khtml/rendering/render_text.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.cpp:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_docimpl.cpp:
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_stringimpl.cpp:
  • khtml/xml/dom_stringimpl.h:
  • khtml/xml/xml_tokenizer.h: Merge in 3.0.1 changes and add APPLE_CHANGES as necessary to get it to compile.
12:44 PM Changeset in webkit [1325] by darin
  • 2 edits
    1 delete in trunk/WebKit
  • WebCoreSupport.subproj/IFCachedTextRenderer.m: Removed.
10:21 AM Changeset in webkit [1324] by sullivan
  • 4 edits in trunk/WebKit

Fixed leaks in History mechanism, found by overriding
release, retain, autorelease, and dealloc and watching
the spam fly.

  • History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate addEntry:]): Make autoreleased array for entries on a given date. (-[IFWebHistoryPrivate _loadHistoryGuts:]): autorelease entries as they are generated from data on disk.

Added workaround for NSOutlineView leak, by collapsing items
just before removing them from the history view.

  • GlobalHistory.m: (-[GlobalHistory removeSelectedItems:]):
9:47 AM Changeset in webkit [1323]
  • 16 copies in tags/KDE_3_0_1

This commit was manufactured by cvs2svn to create tag 'KDE_3_0_1'.

9:47 AM Changeset in webkit [1322] by darin
  • 1 add in branches/kde/WebCore/khtml/misc/shared.h

File that's new in 3.0.1

9:20 AM Changeset in webkit [1321] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Fix a typo where I left the S off of DRAW_WITHOUT_ADVANCES.
9:14 AM Changeset in webkit [1320] by darin
  • 217 edits in branches/kde

Check in the KDE 3.0.1 sources.

9:01 AM Changeset in webkit [1319] by darin
  • 1 delete in branches/kde/WebCore/khtml/java

Remove java subdir from kde branch.

9:00 AM Changeset in webkit [1318] by darin
  • 1 delete in branches/kde/WebCore/src

Get rid of old-location files from the kde branch.

3:23 AM Changeset in webkit [1317] by rjw
  • 4 edits in trunk/WebKit

90% solution to round-off problem. khtml breaks measures text on space
boundaries during layout. It assumes integer measurement, CG uses float
measurements. Some common fonts have non-integer space width. So,
differences in between drawing advances and measurement of space characters
can easily accumulate enough to be visually apparent. We may still accumulate
differences across words, although it's much less visible than for spaces.
As a next step we can fudge the advances of words to force
integer widths, although I think, given how khtml work, just accounting for
consistency in measuring and drawing spaces may be sufficient.
Many sites that looked flaky before now render correctly.

  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]):

Force rounding of advance for space characters.

(-[IFTextRenderer floatWidthForCharacters:length:]):

Force rounding of measurement for space characters.

Jun 9, 2002:

10:32 PM Changeset in webkit [1316] by sullivan
  • 14 edits in trunk/WebKit

WebKit part of fix for 2949646 (Can't drag & drop bookmarks
into auto-expanded folder). To get this to work right, I gave
each bookmark a unique (per-session) identifier.

While working on this, I found and fixed some leaks of bookmarks.

  • Bookmarks.subproj/IFBookmark.h: New -[identifier] method and _identifier ivar.
  • Bookmarks.subproj/IFBookmark.m: (+[IFBookmark _generateUniqueIdentifier]): (-[IFBookmark init]): (-[IFBookmark dealloc]): Remember unique identifier in each bookmark as it is created; delete when dealloc'd.

(-[IFBookmark identifier]): Return unique identifier.

(-[IFBookmark _setParent:]): Don't retain parent, to avoid
circular ownership.

(-[IFBookmark _setGroup:]): Tell coming and going group.

  • Bookmarks.subproj/IFBookmarkGroup.h: New +[bookmarkForIdentifier] method and _bookmarksByID ivar.
  • Bookmarks.subproj/IFBookmarkGroup_Private.h: Declarations of _removedBookmark: and _addedBookmark:
  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup initWithFile:]): alloc _bookmarksByID. (-[IFBookmarkGroup dealloc]): release _bookmarksByID. (-[IFBookmarkGroup _setTopBookmark:]): Don't bail out early; would now cause leak. (-[IFBookmarkGroup _removedBookmark:]): New method, removes bookmark from _bookmarksByID. (-[IFBookmarkGroup _addedBookmark:]): New method, adds bookmark to _bookmarksByID. (-[IFBookmarkGroup bookmarkForIdentifier:]): Looks up bookmark from _bookmarksByID dictionary. (-[IFBookmarkGroup _loadBookmarkGroupGuts]): autorelease newTopbookmark; this had been leaking.
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList _initFromDictionaryRepresentation:withGroup:]): autorelease children before adding them to parent; this had been leaking.

WebBrowser part of fix for 2949646 (Can't drag & drop bookmarks into
auto-expanded folder).

While working on this, I found and fixed some other unreported bugs, including
leaks of bookmarks.

  • BookmarksController.m: (-[BookmarksController windowDidLoad]): Use BookmarkIDListPboardType rather than RowListPboardType.

(-[BookmarksController _endEditing]),
(-[BookmarksController _toggleEdit:]): Broke _endEditing out of _toggleEdit so
it could be called by itself.

(-[BookmarksController _safeRemoveBookmark:]): Workaround for NSOutlineView bug
where removing expanded items leaks.

(-[BookmarksController removeSelectedBookmarks:]),
(-[BookmarksController _redoRemoveBookmarks:]): Call _endEditing to avoid problem
when removing a bookmark that's being edited; call _safeRemoveBookmark to prevent
leak.

(-[BookmarksController _anyAncestorOfRow:inArray:]): removed.
(-[BookmarksController _identifierOfBookmarkOrAnyAncestor:inArray:]):
Changed name from _rowOrAnyAncestor:inArray:, now deals with array of bookmark
identifiers rather than array of row numbers.

(-[BookmarksController outlineView:writeItems:toPasteboard:]),
(-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]),
(-[BookmarksController outlineView:acceptDrop:item:childIndex:]): Reworked to use
array of bookmark identifiers rather than array of row numbers.

  • Preferences.subproj/English.lproj/ActiveContentPreferences.nib: Added 2nd sentence to "allow JavaScript to open windows automatically" preference at Maciej's wise suggestion.
9:40 PM Changeset in webkit [1315] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Fixed a possible uninitialized variable problem that the compiler and Don caught.
2:16 PM Changeset in webkit [1314] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): Add code to handle drawing when are more than LOCAL_GLYPH_BUFFER_SIZE advances. I ran into this loading <​http://jersey.apple.com/data/20020606-074404M0.html>. Also fix handling of advances for the obscure case where we hit a non-base character, slowPackGlyphsForCharacters fails, and substituteFontforCharacters returns nil.
Note: See TracTimeline for information about the timeline view.