Timeline



Jun 15, 2002:

10:27 PM Changeset in webkit [1382] by rjw
  • 22 edits in trunk/WebKit
  • Misc.subproj/IFNSViewExtras.h:
  • Misc.subproj/IFNSViewExtras.m: (-[NSView _IF_superviewWithName:]): (-[NSView _IF_parentWebView]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

  • Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): Call _receiveProgress instead of directly calling handler.
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView start]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge loadURL:attributes:flags:inFrame:withParent:]):

Handle changing top frame correctly. Parent may be nil.

(-[IFWebCoreBridge didFinishLoadingWithHandle:]):

Added non-terminal error case.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceCommitted:]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

  • WebView.subproj/IFMainURLHandleClient.mm:
  • WebView.subproj/IFWebControllerPrivate.mm: Comment changes.
9:12 PM Changeset in webkit [1381] by darin
  • 6 edits in trunk/WebCore
  • kwq/KWQKloader.mm: (-[KWQURLLoadClient IFURLHandle:didRedirectToURL:]): Rolled out an assert I added by accident that will break Deployment builds.
9:03 PM Changeset in webkit [1380] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFWebCoreBridge.mm: Added a lot of assertions that I had used while debugging. (-[IFWebCoreBridge didRedirectWithHandle:fromURL:]): Commented out the line of code that calls [serverRedirectTo:forDataSource:]. Our old code was sending this to the web controller (that was a bug). But if we send it to the location change handler, then we confuse Alexander. We may return to this later, uncomment it, and change the interface so the client can tell what is being redirected. We'll need to do that if we want the activity window to show redirected URLs at the time of the redirect.
8:27 PM Changeset in webkit [1379] by darin
  • 6 edits in trunk/WebCore
  • kwq/KWQKloader.mm: (-[KWQURLLoadClient IFURLHandleResourceDidCancelLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidFinishLoading:data:]): (-[KWQURLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): Fixed the order so the URL handles are removed before we send notifications as before my change. This seems to fix the rest of the breakage.
7:31 PM Changeset in webkit [1378] by darin
  • 6 edits in trunk/WebCore
  • kwq/KWQKloader.mm: (-[KWQURLLoadClient initWithLoader:bridge:]): Fix bridge/m_bridge typo that was responsible for at least some of the breakage I caused.
3:15 PM Changeset in webkit [1377] by rjw
  • 12 edits in trunk

2002-06-15 Richard Williamson <​rjw@apple.com>

Fixed factoring problem.

  • kwq/KWQScrollView.mm: (-[NSView _IF_getDocumentView]): (-[NSView _IF_isScrollView]): (QScrollView::visibleWidth): (QScrollView::visibleHeight): (QScrollView::contentsWidth): (QScrollView::contentsHeight): (QScrollView::contentsX): (QScrollView::contentsY): (QScrollView::setContentsPos): (QScrollView::addChild): (QScrollView::resizeContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents):
  • kwq/qt/qscrollview.h:

Fixed _bridge not accounting for provisional data source,
broke access to window.frames during load.

  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebFrame _bridge]): (-[IFWebCoreBridge children]):
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):
2:44 PM Changeset in webkit [1376] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Don't turn negative numbers into 0 for margins. This was a mistake.
2:44 PM Changeset in webkit [1375] by darin
  • 4 edits in trunk/WebCore
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Implement the rule where a negative number means "don't set the margin".
2:34 PM Changeset in webkit [1374] by darin
  • 109 edits
    2 deletes in trunk/WebCore
  • kwq/kio/jobclasses.h: Removed import of WebFoundation.h.
  • kwq/KWQKjobclasses.mm: Added import of IFURLHandle.h.
  • kwq/KWQKloader.mm: Added import of IFError.h and IFURLHandle.h.
  • kwq/WCLoadProgress.h: Removed.
  • kwq/WCWebDataSource.h: Removed.
  • kwq/KWQKHTMLPart.mm: Removed import of WCWebDataSource.h.
  • *.mm: Changed all includes to imports using a perl script.
2:02 PM Changeset in webkit [1373] by darin
  • 51 edits
    1 delete in trunk

WebCore:

  • fixed 2942808 -- remove all calls to WebKit from WebCore

More work on the bridge. Now we don't call anything in WebKit explicitly,
although there are still implicit connections that need to be fixed.

  • WebCore.exp: Remove exports that are no longer needed, now that WebKit is using the bridge to get at more things.
  • khtml/misc/loader.h:
  • khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): (CachedScript::CachedScript): (CachedImage::CachedImage): Remove the extra parameter to the CachedObject constructor. We don't need it any more, so we can remove all these APPLE_CHANGES.
  • kwq/KWQKHTMLPart.mm: Remove getDataSource.
  • kwq/KWQLoaderImpl.h: Remove destructor.
  • kwq/KWQKloader.mm: (-[KWQURLLoadClient initWithLoader:bridge:]): Keep the bridge around instead of the data source. (-[KWQURLLoadClient dealloc]): Release the bridge instead of the data source. Also put another workaround for 2954901 here, like in WebKit. (-[KWQURLLoadClient IFURLHandleResourceDidBeginLoading:]): (-[KWQURLLoadClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[KWQURLLoadClient doneWithHandle:error:]): (-[KWQURLLoadClient IFURLHandleResourceDidCancelLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidFinishLoading:data:]): (-[KWQURLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[KWQURLLoadClient IFURLHandle:didRedirectToURL:]): (KWQLoaderImpl::setClient): (KWQLoaderImpl::serveRequest): Use the bridge to do all the heavy lifting, and put lots of common code into a doneWithHandle:error: method. Also store the URL so the redirect code works properly for multiple redirects and add asserts like the ones in IFMainURLHandleClient. (KWQLoaderImpl::objectFinished): Add a comment.
  • kwq/WebCoreBridge.h: Make header so it can be included from plain Objective C, not just Objective C++. Add a bunch of methods for bridging in to WebCore as opposed to out of WebCore. Add new methods for bridging out from WebCore too for all the progress hooks. Put all the subclass responsibility methods into a protocol in such a way that we don't need to implement them in the base class, and subclasses can set things up so they get errors if they forget to implement anything.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:]): Added. (-[WebCoreBridge addData:withEncoding:]): Added. (-[WebCoreBridge closeURL]): Added. (-[WebCoreBridge end]): Added. (-[WebCoreBridge setURL:]): Added. (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Added. (-[WebCoreBridge documentTextFromDOM]): Added. (-[WebCoreBridge scrollToBaseAnchor]): Added.
  • kwq/external.h: Removed.

WebKit:

  • fixed 2942808 -- remove all calls to WebKit from WebCore

Update to use the WebCore bridge for more things, reducing
dependencies in both directions. Besides using the bridge for all the
remaining WebCore to WebKit calls, almost no WebKit code deals with
KHTMLPart directly any more, instead the other side of the bridge handles it.

  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandleResourceDidBeginLoading:]): Remove unneeded casts. (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFPluginStream IFURLHandle:didRedirectToURL:]): Use the new IFProgress methods to simplify code.
  • WebCoreSupport.subproj/IFWebCoreBridge.h: Use the new WebCoreBridge protocol so we get a compiler error if we forget to implement anything. Add a method for IFWebDataSource that gets the WebCoreBridge if it has an IFHTMLRepresentation, and nil otherwise.
  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebDataSource _bridge]): Add; does checking so that it returns nil if the representation is not an IFHTMLRepresentation. This is now used almost everywhere so we don't have to do so much type casting. (-[IFWebCoreBridge loadURL:attributes:flags:inFrame:withParent:]): Remove a stray use of [IFWebCoreBridge dataSource] so we can remove it. (-[IFWebCoreBridge receivedData:withDataSource:]): Use the new [WebCoreBridge openURL:] and [WebCoreBridge addData:] methods from the other side of the bridge so we don't have to deal with the KHTMLPart directly. (-[IFWebCoreBridge addHandle:]): Added. (-[IFWebCoreBridge removeHandle:]): Added. (-[IFWebCoreBridge didStartLoadingWithHandle:]): Added. (-[IFWebCoreBridge receivedProgressWithHandle:]): Added. (-[IFWebCoreBridge didFinishLoadingWithHandle:]): Added. (-[IFWebCoreBridge didCancelLoadingWithHandle:]): Added. (-[IFWebCoreBridge didFailBeforeLoadingWithError:]): Added. (-[IFWebCoreBridge didFailToLoadWithHandle:error:]): Added. (-[IFWebCoreBridge didRedirectWithHandle:fromURL:]): Added.
  • WebView.subproj/IFHTMLRepresentation.h: Remove unneeded declarations.
  • WebView.subproj/IFHTMLRepresentation.mm: Remove [IFHTMLRepresentation part].
  • WebView.subproj/IFHTMLRepresentationPrivate.h: Remove [IFHTMLRepresentation part].
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Use the bridge.
  • WebView.subproj/IFHTMLViewPrivate.mm: Remove a bunch of unused stuff that was there for the render and document tree viewers. I had removed it once before but it got re-added as a side effect of the reorganization process.
  • WebView.subproj/IFLoadProgress.h: Remove the unused IFLoadType -- we can add it back if we find that it's needed. It didn't do much good to have it here and only partly implemented, and I don't think it's needed. Added some convenient interfaces for creating IFLoadProgress objects.
  • WebView.subproj/IFLoadProgress.mm: Get rid of WCSetIFLoadProgressMakeFunc stuff. (-[IFLoadProgress init]): Added. (-[IFLoadProgress initWithBytesSoFar:totalToLoad:]): Remove type part. (-[IFLoadProgress initWithURLHandle:]): Added. (+[IFLoadProgress progress]): Added. (+[IFLoadProgress progressWithBytesSoFar:totalToLoad:]): Added. (+[IFLoadProgress progressWithURLHandle:]): Added.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient dealloc]): Add more workaround for 2954901. (-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): Remove unneeded type casts and simplify by using new IFLoadProgress methods. Also simplify access to _bridge by using [IFWebDataSource _bridge].
  • WebView.subproj/IFWebControllerPrivate.mm:
  • WebView.subproj/IFWebFrame.mm: Remove unneeded include of KHTMLPart header.
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource documentTextFromDOM]):
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _stopLoading]):
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Use bridge.
1:04 PM Changeset in webkit [1372] by darin
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m
  • WebFoundation.pbproj/project.pbxproj: Removed explicit PFE_FILE_C_DIALECTS now that Project Builder handles this automatically. Removed explicit USE_GCC3 since that's implicit now.
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m:
  • CacheLoader.subproj/IFNetworkSettings.m:
  • CacheLoader.subproj/IFURLLoad.m:
  • CacheLoader.subproj/IFURLLoadManager.m:
  • CookieManager.subproj/IFCookieManager.m:
  • Database.subproj/IFURLFileDatabase.m:
  • Misc.subproj/IFError.m:
  • Misc.subproj/IFFileTypeMappings.m:
  • Misc.subproj/IFNSThreadExtensions.m: Use PTHREAD_ONCE_INIT now that the warning is fixed; also make some minor improvements to how it's used, making some globals static rather than extern.
12:59 PM Changeset in webkit [1371] by darin
  • 7 edits in trunk/JavaScriptCore
  • JavaScriptCore.pbproj/project.pbxproj: Removed explicit PFE_FILE_C_DIALECTS now that Project Builder handles this automatically. Removed explicit USE_GCC3 since that's implicit now. Also, since this project is all C++, only use WARNING_CFLAGS with flags that are appropriate for C++; don't bother breaking out C vs. C++.
  • kjs/collector.cpp: Now that the system warning is fixed, use PTHREAD_MUTEX_INITIALIZER and PTHREAD_COND_INITIALIZER.
  • kjs/internal.cpp: Use PTHREAD_MUTEX_INITIALIZER.
  • kjs/ustring.cpp: Use PTHREAD_ONCE_INIT.
4:55 AM Changeset in webkit [1370] by mjs
  • 4 edits in trunk/WebCore

Get current bits per pixel from CoreGraphics, thereby fixing

Radar 2943736 - JavaScript screen.colorDepth and

screen.pixelDepth properties always returns 32,

regardless of real depth

  • kwq/KWQPaintDeviceMetrics.mm: (QPaintDeviceMetrics::depth):
4:39 AM Changeset in webkit [1369] by mjs
  • 7 edits in trunk

Made Development build mode mean what Unoptimized used to mean.

Removed Unoptimized build mode.

Added a Mixed build mode which does what Deployment used to. All

this to fix:

Radar 2955367 - Change default build style to "Unoptimized"

2:55 AM Changeset in webkit [1368] by mjs
  • 5 edits in trunk/WebCore

Removed product and vendor properties, thereby fixing:

Radar 2943751 - JavaScript navigator.product property is

"Konqueror/khtml"

Radar 2943753 - JavaScript navigator.vendor property is "KDE"

  • khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): Return undefined for the above

mentioned properties.

Implemented functionality needed for missing Screen properties,

thereby fixing the following

bugs:

Radar 2943730 - JavaScript screen.availHeight property is not

implemented

Radar 2943732 - JavaScript screen.availLeft property is not

implemented

Radar 2943734 - JavaScript screen.availTop property not implemented
Radar 2943735 - JavaScript screen.availWidth property is not

implemented

  • kwq/KWQKWinModule.mm: (KWinModule::workArea): Return the correct screen size to fix the

above bugs.

2:42 AM Changeset in webkit [1367] by mjs
  • 5 edits in trunk/WebKit

Added temporary workardound for Radar 2954901 by making the

assertion more lenient.

  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]):

Jun 14, 2002:

7:28 PM Changeset in webkit [1366] by rjw
  • 11 edits in trunk/WebKit

i Removed redundant private _isDocumentHTML method.

  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _stopLoading]): (-[IFWebDataSource _addError:forResource:]):
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):
7:12 PM Changeset in webkit [1365] by rjw
  • 7 edits in trunk/WebCore

Changed IFResourceProgressHandler to pass back resource handle instead of
string description. This will address the needs descibed in 2954160.

  • kwq/KWQKloader.mm: (-[KWQURLLoadClient IFURLHandleResourceDidBeginLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidCancelLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidFinishLoading:data:]): (-[KWQURLLoadClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[KWQURLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[KWQURLLoadClient IFURLHandle:didRedirectToURL:]): (KWQLoaderImpl::serveRequest):
  • kwq/external.h:
7:12 PM Changeset in webkit [1364] by rjw
  • 45 edits in trunk/WebKit

Added handlers to IFWebController. Should eventually be possible to use
IFWebController w/o subclassing.

Changed IFResourceProgressHandler to pass back resource handle instead of
string description. This will address the needs descibed in 2954160.

Fixed many incorrect references to datasource reps.

  • Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]):
  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]):
  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebDataSource _bridge]): (-[IFWebCoreBridge createNewFrameNamed:withURL:renderPart:khtml::allowsScrolling:marginWidth:marginHeight:]):
  • WebView.subproj/IFDocument.h:
  • WebView.subproj/IFHTMLRepresentation.h:
  • WebView.subproj/IFHTMLRepresentationPrivate.h:
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): (-[IFHTMLView viewWillStartLiveResize]): (-[IFHTMLView viewDidEndLiveResize]):
  • WebView.subproj/IFImageView.m:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebController.mm: (-[IFWebController createFrameNamed:for:inParent:allowsScrolling:]): (-[IFWebController setResourceProgressHandler:]): (-[IFWebController resourceProgressHandler]): (-[IFWebController setPolicyHandler:]): (-[IFWebController policyHandler]): (+[IFWebController defaultURLPolicyForURL:]):
  • WebView.subproj/IFWebControllerPrivate.h:
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate dealloc]): (-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:]): (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:]): (-[IFWebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): (-[IFWebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]):
  • WebView.subproj/IFWebDataSource.h:
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource representation]): (-[IFWebDataSource isDocumentHTML]): (-[IFWebDataSource documentTextFromDOM]):
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]): (-[IFWebDataSource _setRepresentation:]): (-[IFWebDataSource _stopLoading]): (-[IFWebDataSource _isDocumentHTML]):
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]):
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):
5:14 PM Changeset in webkit [1363] by darin
  • 2 edits in trunk/WebKit

real, not read

5:13 PM Changeset in webkit [1362] by darin
  • 5 edits
    4 adds
    2 deletes in trunk/WebKit
  • Panels.subproj/IFStandardPanels.m: Use the read PTHREAD_ONCE_INIT, remove the workaround for 2905545.
  • IFWebCoreBridge.h: Moved into WebCoreSupport.subproj.
  • IFWebCoreBridge.mm: Moved into WebCoreSupport.subproj.
  • WebCoreSupport.subproj/IFWebCoreBridge.h: Moved from top level.
  • WebCoreSupport.subproj/IFWebCoreBridge.mm: Moved from top level.
  • WebKit.pbproj/project.pbxproj: Update for new file locations. Also pass -no-c++filt so we get mangled names (more useful for .exp files), and remove PFE_FILE_C_DIALECTS.
5:12 PM Changeset in webkit [1361] by cblu
  • 15 edits in trunk/WebKit

WebBrowser:

Only allow source to be shown if HTML

  • BrowserDocument.m: (-[BrowserDocument _isDocumentHTML]): added (-[BrowserDocument validateUserInterfaceItem:]): (-[BrowserDocument viewSource:]):

WebKit:

  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): If content type is the default type and there is no extension, assume HTML.

(-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]):

  • WebView.subproj/IFWebDataSource.h:
  • WebView.subproj/IFWebDataSource.mm:

Made isDocumentHTML public. Changed where needed.

(-[IFWebDataSource isDocumentHTML]):
(-[IFWebDataSource documentSource]):
(-[IFWebDataSource documentTextFromDOM]):

  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _stopLoading]): (-[IFWebDataSource _addError:forResource:]):
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):
4:45 PM Changeset in webkit [1360] by darin
  • 4 edits in trunk/WebKit
  • Panels.subproj/IFStandardPanels.m: Fix what I broke last time.
4:32 PM Changeset in webkit [1359] by darin
  • 8 edits in trunk/WebKit
  • Panels.subproj/IFStandardPanels.m: (-[IFStandardPanelsPrivate frontmostWindowLoadingURL:]): Change to call webView instead of view. Not sure why anyone was able to compile this.
  • Plugins.subproj/IFNullPluginView.mm: Remove include of obsolete WCPluginWidget.h.
  • WebView.subproj/IFHTMLRepresentation.mm: (-[IFHTMLRepresentation part]): Call part instead of KHTMLPart. Not sure why anyone was able to compile this.
4:31 PM Changeset in webkit [1358] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQDateTime.mm: Add ifdefs needed to make Deployment build compile.
4:15 PM Changeset in webkit [1357] by darin
  • 67 edits
    6 adds
    2 deletes in trunk

WebCore:

Add the new bridge class that connects us to WebCore in a nicer way.
Started to use it for some things. More to come.

  • WebKit.pbproj/project.pbxproj:
  • IFWebCoreBridge.h: Added.
  • IFWebCoreBridge.mm: Added.
  • Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler initWithDataSource:]): Call [super init]. (-[IFDownloadHandler dealloc]): Call [super dealloc].
  • Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender initializeWithNPP:functionPointer:window:]): Call [super init]. (-[IFPluginNullEventSender dealloc]): Call [super dealloc].
  • WebView.subproj/IFDOMNode.mm: (-[IFDOMNode dealloc]): Call [super dealloc].
  • WebView.subproj/IFImageView.m: (-[IFImageView dealloc]): Call [super dealloc].
  • WebView.subproj/IFRenderNode.mm: (-[IFRenderNode dealloc]): Call [super dealloc].
  • WebView.subproj/IFHTMLRepresentation.h: Moved variables into a private structure so this class can be made public.
  • WebView.subproj/IFHTMLRepresentationPrivate.h: Added. Has _bridge method.
  • WebView.subproj/IFHTMLRepresentation.mm: (-[IFHTMLRepresentation init]): Call [super init]. Also use the new private structure, and allocate the IFWebCoreBridge. (-[IFHTMLRepresentation dealloc]): Release the private structure and the IFWebCoreBridge. Also, call [super dealloc]. (-[IFHTMLRepresentation _bridge]): Private method to get to the bridge. (-[IFHTMLRepresentation receivedData:withDataSource:]): Use IFWebCoreBridge.
  • WebView.subproj/IFWebViewPrivate.h: Add _setMarginWidth and _setMarginHeight.
  • WebView.subproj/IFWebDataSourcePrivate.h: Tweak.
  • WebView.subproj/IFWebDataSource.mm: Tweak.
  • History.subproj/IFWebHistoryPrivate.m: Tweak.

WebKit:

Worked on eliminating calls to WebKit. About 3/4 done.

  • WebCore.exp: Export new WebCoreBridge class, fewer other things.
  • WebCorePrefix.h: #include <ostream> in debug builds; we couldn't before because of a PFE bug that has since been fixed (2920556).
  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): Add a comment explaining our latest change here.
  • khtml/khtml_part.cpp: (KHTMLPart::~KHTMLPart): Fix storage leak by deleting m_hostExtension.
  • khtml/misc/loader.h: Set type properly on client member so we don't have to do so much casting.
  • kwq/KWQKHTMLPartImpl.h: Add getBridge and setBridge, remove setDataSource.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Eliminate m_dataSource. (KWQKHTMLPartImpl::openURLInFrame): Use WebCoreBridge. (KWQKHTMLPartImpl::urlSelected): Use WebCoreBridge. (KWQKHTMLPartImpl::requestFrame): Use WebCoreBridge. (KWQKHTMLPartImpl::requestObject): Move WebCoreViewFactory code here; we don't need an entire WCPluginWidget file just for this function. (KWQKHTMLPartImpl::submitForm): Use WebCoreBridge. (KWQKHTMLPartImpl::frameExists): Use WebCoreBridge. (KWQKHTMLPartImpl::frames): Use WebCoreBridge. (KWQKHTMLPartImpl::setTitle): Use WebCoreBridge. (KWQKHTMLPartImpl::getDataSource): Use WebCoreBridge. (KWQKHTMLPartImpl::parentPart): Use WebCoreBridge.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Use WebCoreBridge.
  • kwq/KWQKloader.mm: Move the part of external.h that we still use in here, with the expectation of eliminating it soon. Also renamed URLLoadClient to KWQURLLoadClient so we don't hog namespace.
  • kwq/qt/qscrollview.h:
  • kwq/KWQScrollView.mm: Used helper functions to do the "documentView" selector thing more consistently.
  • kwq/KWQWidget.mm: Get interface for changing the cursor from WebCoreViewFactory.h instead of from external.h.
  • kwq/WebCoreViewFactory.h:
  • kwq/Makefile.am: Remove WCPluginWidget.mm, add WebCoreBridge.mm.
  • kwq/WCPluginWidget.h: Removed.
  • kwq/WCPluginWidget.mm: Removed.
  • kwq/WebCoreBridge.h: Added.
  • kwq/WebCoreBridge.mm: Added.
  • kwq/qt/qarray.h: Use <ostream> instead of <iostream>.
  • kwq/qt/qcstring.h: Remove <iostream> include since we include <qarray.h>.
  • kwq/qt/qdatetime.h: Replace unconditional <iostream> include with a conditional <ostream> include. Also made streaming operators conditional.
  • kwq/qt/qlist.h: Use <ostream> instead of <iostream>.
  • kwq/qt/qmap.h: Use <ostream> instead of <iostream>.
  • kwq/qt/qpoint.h: Use <iosfwd> instead of <iostream>.
  • kwq/qt/qsize.h: Use <iosfwd> instead of <iostream>.
  • kwq/qt/qvaluelist.h: Use <ostream> instead of <iostream>.
  • kwq/qt/qvector.h: Replace unconditional <iostream> include with a conditional <ostream> include. Also made streaming operators conditional.
3:26 PM Changeset in webkit [1356] by rjw
  • 32 edits in trunk

Lots of frame related cleanup. Added attempt to get
nested scrollbars to work correctly with window's resize
corner. Still not quite right.

Name change [IFWebFrame view] -> [IFWebFrame webView].

  • WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]):
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): (-[IFHTMLView viewDidEndLiveResize]):
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebController.mm: (-[IFWebController initWithView:provisionalDataSource:]): (-[IFWebController createFrameNamed:for:inParent:inScrollView:]): (-[IFWebController _frameForView:fromFrame:]): (-[IFWebController frameForView:]): (-[IFWebController haveContentPolicy:andPath:forLocationChangeHandler:]):
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate _clearControllerReferences:]):
  • WebView.subproj/IFWebFrame.h:
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame init]): (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]): (-[IFWebFrame setWebView:]): (-[IFWebFrame webView]): (-[IFWebFrame setProvisionalDataSource:]): (-[IFWebFrame reset]):
  • WebView.subproj/IFWebFramePrivate.h:
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate dealloc]): (-[IFWebFramePrivate setWebView:]): (-[IFWebFrame _timedLayout:]): (-[IFWebFrame _transitionProvisionalToCommitted]): (-[IFWebFrame _setState:]): (-[IFWebFrame _isLoadComplete]):

Name change [IFWebFrame view] -> [IFWebFrame webView].

  • BrowserDocument.m: (-[BrowserDocument mainWebView]): (-[BrowserDocument setMainWebView:]):
  • BrowserWindow.m: (-[BrowserWindow frameLoadStarted:]): (-[BrowserWindow frameLoadCommitted:]): (-[BrowserWindow frameLoadRedirected:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler _saveScrollPosition]): (-[LocationChangeHandler _scrollToTop]): (-[LocationChangeHandler _restoreScrollPosition]):

Name change view -> webView.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestFrame):
  • kwq/external.h:
1:54 PM Changeset in webkit [1355] by cblu
  • 4 edits in trunk/WebCore

Put #ifndef APPLE_CHANGES around one line that
was causing EMBED and OBJECT tags to not have render objects.

  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach):
12:58 PM Changeset in webkit [1354] by rjw
  • 8 edits in trunk/WebKit
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView initWithFrame:]):

Added notification so we can intelligently add/remove
mouse move observation when the window becomes/resigns
main. Also added window close observation so we can
clean up other observers.

(-[IFHTMLView viewWillStartLiveResize]):\

Backed out removal of scroll bars during resize.

(-[IFHTMLView viewDidEndLiveResize]):

Backed out removal of scroll bars during resize.

(-[IFHTMLView windowWillClose:]):
Clean up observers.
(-[IFHTMLView windowDidBecomeMain:]):
Add mouse move observer.
(-[IFHTMLView windowDidResignMain:]):
Remove mouse move observer.
(-[IFHTMLView mouseMovedNotification:]):

Only pay attention to mouse moves for this window.

  • WebView.subproj/IFImageView.m: (-[IFImageView layout]):

Removed unnecessary scroll view setDrawBackground calls.

  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _setState:]):

Added calls to scroll view setDrawBackground when the view
rect is valid.

11:22 AM Changeset in webkit [1353] by cblu
  • 64 edits in trunk

Enabled displaying of text, images and RTF
Fixed drag & drop
Committing Richard's changes to KWQPainter
Upated types that Alex can open.
Uncommented textFromDOM call.

Jun 13, 2002:

3:46 PM Changeset in webkit [1352]
  • 5 copies
    2 deletes in tags/JavaScriptCore-5_1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-5_1'.

3:46 PM Changeset in webkit [1351] by mjs
  • 3 edits in branches/jaguar-branch/JavaScriptCore
3:24 PM Changeset in webkit [1350]
  • 5 copies
    2 deletes in tags/JavaScriptCore-5~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-5~1'.

3:24 PM Changeset in webkit [1349] by mjs
  • 4 edits in branches/jaguar-branch/JavaScriptCore
  • JavaScriptCore.pbproj/project.pbxproj: Remove C++ warning flags that a

re

making JavaScriptCore die in the B & I build.

12:31 PM Changeset in webkit [1348] by sullivan
  • 11 edits
    4 adds in trunk/WebKit

Various changes to better support the pasteboard.

  • Bookmarks.subproj/IFBookmark.h,
  • Bookmarks.subproj/IFBookmark.m: (+[IFBookmark bookmarkOfType:]): New method.
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf init]): start out with a non-nil _entry (-[IFBookmarkLeaf setTitle:]): added assert (-[IFBookmarkLeaf setURLString:]): added assert
  • History.subproj/IFURLsWithTitles.h,
  • History.subproj/IFURLsWithTitles.m: (+[IFURLsWithTitles arrayWithIFURLsWithTitlesPboardType]), (+[IFURLsWithTitles writeURLs:andTitles:toPasteboard:]), (+[IFURLsWithTitles titlesFromPasteboard:]), (+[IFURLsWithTitles URLsFromPasteboard:]): New file with methods for reading/writing pasteboard entry representing a list of URLs with associated titles. Used by Bookmarks window and History window in Alexander.
  • History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate removeEntryForURLString:]): refactored to turn a WEBKITDEBUG into a more-appropriate WEBKIT_ASSERT.
  • WebKit.pbproj/project.pbxproj: Updated for new files.

Many changes for copy/paste & dragging support, and random little tweaks.

  • fixed 2927606 -- Should be able to drag items from History window to Bookmarks
  • BookmarksController.m: (-[BookmarksController _droppablePasteboardTypes]), (-[BookmarksController _pasteablePasteboardTypes]): Added IFURLsWithTitlesPboardType and NSURLPboardType.

(-[BookmarksController _selectedBookmarks]): Renamed from
_selectedBookmarksWithoutRedundantDescendants, and removed the descendant-filtering
code from here (used by some callers instead).
(-[BookmarksController removeSelectedBookmarks:]): Filter results of _selectedBookmarks.
(-[BookmarksController outlineView:writeItems:toPasteboard:]): Added support for writing
BookmarkDictionaryListPboardType, IFURLsWithTitlesPboardType, NSURLPboardType, and
NSStringPboardType.
(-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]):
Split code that sets the drag operation from code that retargets the drop; added support
for NSURLPboardType and IFURLsWithTitlesPboardType.
(+[BookmarksController _addBookmarksFromURLsWithTitlesOnPasteboard:to:]):
New convenience routine.
(-[BookmarksController paste:]),
(-[BookmarksController outlineView:acceptDrop:item:childIndex:]): Add support for
NSURLPboardType and IFURLsWithTitlesPboardType.
(-[BookmarksController copy:]): Just calls outlineView:writeItems:toPasteboard: now
instead of duplicating code.
(-[BookmarksController validateMenuItem:]),
(-[BookmarksController validateUserInterfaceItem:]): Removed all code that modified titles
of Cut/Copy/Paste/Clear items after realizing that this can't work with the Cocoa
responder chain model (no guarantee that the modified titles will be unmodified in other
contexts).

  • BrowserWindow.m: (-[BrowserWindow windowWillHandleKeyEvent:]): Returns NO always now; this means that BrowserWindow will no longer try to handle Page Up/Down, arrow keys, etc. We can remove this method entirely (and some other stuff) when 2955757 is addressed.
  • GlobalHistory.m: (-[GlobalHistory _entriesFromMixedItems:collapseDates:]): New convenience method that returns an array of history entries from an array containing a potential mix of history entries and calendar dates. (-[GlobalHistory outlineView:writeItems:toPasteboard:]): New method, writes these types to pasteboard: IFURLsWithTitlesPboardType, NSURLPboardType, NSStringPboardType (-[GlobalHistory _selectedItems]), (-[GlobalHistory removeSelectedItems:]): Broke _selectedItems out of removeSelectedItems. (-[GlobalHistory copy:]): New method, calls outlineView:writeItems:toPasteboard: with the selected items. (-[GlobalHistory validateUserInterfaceItem:]): Enable "Copy" if at least one item is selected.
  • LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): Swapped NSURLPboardType and NSStringPboardType so that NSURLPboardType is preferred. (-[LocationFieldEditor concludeDragOperation:]): Use #defines for pasteboard types instead of strings; fix broken use of NSURLPboardType.
  • ResourceProgressEntry.m: (-[ResourceProgressEntry setProgress:]): Improved an error message.
9:12 AM Changeset in webkit [1347] by kocienda
  • 2 edits in trunk/WebKit

2002-06-13 Kenneth Kocienda <​kocienda@apple.com>

Fixed typo in ChangeLog comment.

9:00 AM Changeset in webkit [1346] by kocienda
  • 5 edits in trunk/WebKit

2002-06-13 Kenneth Kocienda <​kocienda@apple.com>

Fixed uninitialized varible that broke the build.

  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:])
3:53 AM Changeset in webkit [1345] by rjw
  • 4 edits in trunk/WebCore

More cleanup to deal with special case of provisional view
not being in a scrollview.

3:32 AM Changeset in webkit [1344] by rjw
  • 6 edits in trunk/WebCore
  • kwq/KWQWidget.mm: (QWidget::setCursor): restored code
  • kwq/external.h: removed definitions no longer needed
  • khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): tweaked size
3:31 AM Changeset in webkit [1343] by rjw
  • 23 edits in trunk/WebKit

Lots of cleanup. Fixed most regressions.
Added removal of scrollbars during resizing,
not sure if it's the correct behavior, but it makes resizing
much smoother. Let's see what people think.

1:22 AM Changeset in webkit [1342] by cblu
  • 3 edits
    4 adds
    1 delete in trunk/WebKit

Removed MIME.subproj. Moved IFDownloadHandler to Misc.

  • MIME.subproj/IFDownloadHandler.h: Removed.
  • MIME.subproj/IFDownloadHandler.mm: Removed.
  • Misc.subproj/IFDownloadHandler.h: Added.
  • Misc.subproj/IFDownloadHandler.mm: Added. (-[IFDownloadHandler initWithDataSource:]): (-[IFDownloadHandler dealloc]): (-[IFDownloadHandler receivedData:isComplete:]): (-[IFDownloadHandler cancel]):
  • WebKit.pbproj/project.pbxproj:
1:13 AM Changeset in webkit [1341] by cblu
  • 11 edits
    6 deletes in trunk/WebKit

Fixed downloads.
Now write out download files as data comes in.
Removed useless lproj's.

  • Dutch.lproj/InfoPlist.strings: Removed.
  • Dutch.lproj/Localizable.strings: Removed.
  • French.lproj/InfoPlist.strings: Removed.
  • French.lproj/Localizable.strings: Removed.
  • German.lproj/InfoPlist.strings: Removed.
  • German.lproj/Localizable.strings: Removed.
  • Italian.lproj/InfoPlist.strings: Removed.
  • Italian.lproj/Localizable.strings: Removed.
  • Japanese.lproj/InfoPlist.strings: Removed.
  • Japanese.lproj/Localizable.strings: Removed.
  • MIME.subproj/IFDownloadHandler.h:
  • MIME.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler dealloc]): (-[IFDownloadHandler receivedData:isComplete:]): added (-[IFDownloadHandler cancel]): added
  • Spanish.lproj/InfoPlist.strings: Removed.
  • Spanish.lproj/Localizable.strings: Removed.
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:]): removed unused BOOL (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):

Jun 12, 2002:

8:33 PM Changeset in webkit [1340] by cblu
  • 75 edits
    34 adds
    4 deletes in trunk

Couldn't run ChangeLog because it hung with the massize diffs, so here's
a hand-made one.

Changes to support inline views.

Modified Files:

WebBrowser/BrowserDocument.m
WebBrowser/LocationChangeHandler.m
WebBrowser/Debug/DebugUtilities.m WebCore/WebCore.exp
WebCore/kwq/KWQKHTMLPart.mm
WebCore/kwq/KWQKHTMLPartBrowserExtension.mm
WebCore/kwq/KWQKloader.mm WebCore/kwq/KWQScrollView.mm
WebCore/kwq/KWQView.h WebCore/kwq/KWQView.mm
WebCore/kwq/KWQWidget.mm WebCore/kwq/external.h
WebKit/ChangeLog WebKit/Plugins.subproj/IFNullPluginView.mm
WebKit/Plugins.subproj/IFPluginDatabase.h
WebKit/Plugins.subproj/IFPluginDatabase.m
WebKit/Plugins.subproj/IFPluginView.mm
WebKit/WebCoreSupport.subproj/IFImageRenderer.h

WebKit/WebCoreSupport.subproj/IFWebCoreViewFactory.m

WebKit/WebKit.pbproj/project.pbxproj
WebKit/WebView.subproj/IFDOMNode.mm
WebKit/WebView.subproj/IFDynamicScrollBarsView.m
WebKit/WebView.subproj/IFMainURLHandleClient.h
WebKit/WebView.subproj/IFMainURLHandleClient.mm
WebKit/WebView.subproj/IFRenderNode.mm
WebKit/WebView.subproj/IFWebController.h
WebKit/WebView.subproj/IFWebController.mm
WebKit/WebView.subproj/IFWebControllerPrivate.h
WebKit/WebView.subproj/IFWebControllerPrivate.mm
WebKit/WebView.subproj/IFWebDataSource.h
WebKit/WebView.subproj/IFWebDataSource.mm
WebKit/WebView.subproj/IFWebDataSourcePrivate.h
WebKit/WebView.subproj/IFWebDataSourcePrivate.mm
WebKit/WebView.subproj/IFWebFrame.mm
WebKit/WebView.subproj/IFWebFramePrivate.h
WebKit/WebView.subproj/IFWebFramePrivate.mm
WebKit/WebView.subproj/IFWebView.h
WebKit/WebView.subproj/IFWebView.mm
WebKit/WebView.subproj/IFWebViewPrivate.h
WebKit/WebView.subproj/IFWebViewPrivate.mm

Added Files:

WebKit/Misc.subproj/IFNSViewExtras.h
WebKit/Misc.subproj/IFNSViewExtras.m
WebKit/WebView.subproj/IFDocument.h
WebKit/WebView.subproj/IFHTMLRepresentation.h
WebKit/WebView.subproj/IFHTMLRepresentation.mm
WebKit/WebView.subproj/IFHTMLView.h
WebKit/WebView.subproj/IFHTMLView.mm
WebKit/WebView.subproj/IFHTMLViewPrivate.h
WebKit/WebView.subproj/IFHTMLViewPrivate.mm
WebKit/WebView.subproj/IFImageRepresentation.h
WebKit/WebView.subproj/IFImageRepresentation.m
WebKit/WebView.subproj/IFImageView.h
WebKit/WebView.subproj/IFImageView.m
WebKit/WebView.subproj/IFTextRepresentation.h
WebKit/WebView.subproj/IFTextRepresentation.m
WebKit/WebView.subproj/IFTextView.h
WebKit/WebView.subproj/IFTextView.m

Removed Files:

WebKit/MIME.subproj/IFContentHandler.h
WebKit/MIME.subproj/IFContentHandler.m

WebKit/MIME.subproj/IFMIMEHandler.h

WebKit/MIME.subproj/IFMIMEHandler.m

3:09 PM Changeset in webkit [1339] by kocienda
  • 7 edits in trunk

2002-06-12 Kenneth Kocienda <​kocienda@apple.com>

Made assertion failure console message bolder and easier to see.

  • WebFoundation/Misc.subproj/WebFoundationDebug.h
  • WebKit/Misc.subproj/WebKitDebug.h
  • WebCore/kwq/kwqdebug.h
9:26 AM Changeset in webkit [1338] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/nodes.cpp: (Node::finalCheck): A bit of APPLE_CHANGES so we can compile with KJS_DEBUG_MEM defined if we want to.

Jun 11, 2002:

4:52 PM Changeset in webkit [1337] by darin
  • 7 edits in trunk/WebKit
  • WebView.subproj/IFMainURLHandleClient.mm: Add lots of assertions that allowed me to find the "leak the world" bug that Ken fixed in WebFoundation. These are a good idea anyway.
  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream initWithURL:pluginPointer:notifyData:attributes:]): Use cStringLength to get the length for the cString rather than assuming that length will be right. (-[IFPluginStream IFURLHandle:didRedirectToURL:]): Add a FIXME.
4:51 PM Changeset in webkit [1336] by darin
  • 3 edits in trunk/WebCore

Change log should have said: Remove the workaround for CFURL bug 2891336.

4:48 PM Changeset in webkit [1335] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQKURL.mm: (RelativeURLKeyRetainCallBack): Use a ref count. (RelativeURLKeyReleaseCallBack): Use a ref count instead of assuming there will never be more than one reference. (KURL::normalizeRelativeURLString): Use a ref count. (operator==): Don't put URLs on the autorelease pool just to compare them.
2:16 PM Changeset in webkit [1334] by sullivan
  • 16 edits in trunk/WebKit

Made methods that convert bookmarks to and from
property-list-compatible dictionaries public so they
can be used in the Bookmarks window for cut/paste.

  • Bookmarks.subproj/IFBookmark.h:
  • Bookmarks.subproj/IFBookmark.m: (+[IFBookmark bookmarkFromDictionaryRepresentation:withGroup:]): New method

(-[IFBookmark initFromDictionaryRepresentation:withGroup:]):
(-[IFBookmark dictionaryRepresentation]):

  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup _loadBookmarkGroupGuts]): (-[IFBookmarkGroup _saveBookmarkGroupGuts]):
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkLeaf dictionaryRepresentation]):
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkList dictionaryRepresentation]):
  • Bookmarks.subproj/IFBookmarkSeparator.m: (-[IFBookmarkSeparator initFromDictionaryRepresentation:withGroup:]): (-[IFBookmarkSeparator dictionaryRepresentation]):
  • Bookmarks.subproj/IFBookmark_Private.h: Removed leading underscores from _initFromDictionaryRepresentation and _dictionaryRepresentation, and made them public.

-fixed 2921580 -- Need Cut/Copy/Paste support in Bookmarks window
-fixed 2952869 -- Alexander offers to undo Bookmark address change
when nothing changed
-made Activity, Bookmarks, and History window set the initial first
responder to their outline views, so Select All and keyboard navigation
work without requiring an initial click.
-eliminated unsightly gray line above outline views in Activity, Bookmarks,
and History windows

  • ActivityViewer.m: (-[ActivityViewer _setUpWindow]): Make outline view be first responder.
  • BookmarksController.h: Add ivars for _droppablePasteboardTypes and _pasteablePasteboardTypes; maybe these will be the same eventually.
  • BookmarksController.m: (-[BookmarksController _droppablePasteboardTypes]), (-[BookmarksController _pasteablePasteboardTypes]): Return array of the types we handle, lazily creating the array if necessary. (-[BookmarksController windowDidLoad]): Use _droppablePasteboardTypes; make outline view be first responder. (-[BookmarksController dealloc]): release new ivars (-[BookmarksController _selectedBookmarksWithoutRedundantDescendants]), (-[BookmarksController removeSelectedBookmarks:]): Extracted _selectedBookmarks... from removeSelectedBookmarks. (-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]): Fixed copy/paste error that was the cause of 2952869 (-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]): Call [NSPasteboard availableTypeFromArray:] instead of making dangerous assumptions. (-[BookmarksController _setSelectionToBookmarks:]), (-[BookmarksController outlineView:acceptDrop:item:childIndex:]): extracted _setSelectionToBookmarks: into its own function, and used availableTypeFromArray:

(-[BookmarksController copy:]),
(-[BookmarksController paste:]),
(-[BookmarksController clear:]),
(-[BookmarksController cut:]): New methods; the last three are Undoable

(-[BookmarksController _numberOfBookmarksOnPasteboard:]): New helper method used
to set title of Paste menu item.

(-[BookmarksController validateMenuItem:]): New method, used for items whose titles
change (i.e. Cut/Copy/Paste/Clear)
(-[BookmarksController validateUserInterfaceItem:]): No change, just moved.

  • English.lproj/ActivityViewer.nib,
  • English.lproj/Bookmarks.nib,
  • English.lproj/History.nib: Made outline views one pixel taller to avoid unsightly gray line at top.
  • GlobalHistory.h:
  • GlobalHistory.m: (-[selectAll:]): Removed unnecessary method. (-[GlobalHistory validateUserInterfaceItem:]): Removed validation for selectAll; let outline view handle it. (-[GlobalHistory showWindow:]): Make outline view be first responder.
1:50 PM Changeset in webkit [1333] by darin
  • 5 edits
    10 adds in trunk/WebKit

WebKit:

  • WebView.subproj/IFDOMNode.h: Added.
  • WebView.subproj/IFDOMNode.mm: Added.
  • WebView.subproj/IFRenderNode.h: Added.
  • WebView.subproj/IFRenderNode.mm: Added. These contain all the interesting bits of the code for the render and DOM tree viewers, mostly moved here from WebBrowser.
  • WebView.subproj/IFWebViewPrivate.mm: Remove the methods in here that aren't declared in the header and are only used for the render and DOM tree viewers.
  • WebKit.pbproj/project.pbxproj: Add new files.

WebBrowser:

Removed all C and Objective C++, making this all Objective C again, which
helps make build times faster.

  • _CFA2UC.c: Removed.
  • WebBrowserPrefix.h: Removed code to handle non-Objective C, and also removed <config.h>.
  • Debug/DOMTree.m: Renamed from DOMTree.mm. Also changed to use IFDOMNode from WebKit for all the interesting bits.
  • Debug/DOMTree.mm: Renamed to DOMTree.m.
  • Debug/DOMTree.h: Put dataSource in object as a step toward making this not leak some day.
  • Debug/RenderTree.m: Renamed from RenderTree.mm. Also changed to use IFRenderNode from WebKit for all the interesting bits.
  • Debug/RenderTree.mm: Renamed to RenderTree.m.
  • Debug/RenderTree.h: Put dataSource in object as a step toward making this not leak some day.
  • WebBrowser.pbproj/project.pbxproj: Change files around. Add warnings that weren't allowed in C++; this project is now all Objective C. Remove C and Objective C++ from PFE dialects list. Remove header search paths.
  • main.m: Use "../config.h" to get at config.h. In the long run, we can just get rid of this.
  • Debug/DebugUtilities.m: Unimportant tweaks.
Note: See TracTimeline for information about the timeline view.