Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jun 20, 2002:

6:27 PM Changeset in webkit [1412] by rjw

• 8 edits in trunk/WebKit

• WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer frameDuration]):

Added minimum 1/60th second duration per frame.

• WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]):

Only display scrollview if scrollers changed.

• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _setState:]):

Explicity turn on copiesOnScroll. This may cause problems w/
plugins. Need to verify once plugins are no longer crashing.

4:35 PM Changeset in webkit [1411] by darin

• 41 edits
  2 deletes in trunk

WebCore:

• kwq/KWQKCharsets.mm: Removed unneeded parts.
• kwq/KWQStyle.mm: Removed.
• kwq/KWQToolTip.mm: Removed.
• kwq/KWQVariant.mm: Simplified.
• kwq/Makefile.am: Removed KWQStyle.mm and KWQToolTip.mm.

• kwq/KWQRefPtr.h: Streamlined implementation that inlines a bit less and is more efficient for creating empty pointers.

• kwq/KWQStyle.h: Removed unused stuff.

• kwq/kdecore/kcharsets.h: Removed unneeded parts.
• kwq/qt/qsortedlist.h: Removed unneeded parts.
• kwq/qt/qtooltip.h: Removed unneeded parts.
• kwq/qt/qvariant.h: Removed unneeded parts.

• khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Remove unneeded APPLE_CHANGES -- no need to nil something out in a destructor.

WebKit:

Fix for leak where sub-frame IFHTMLViews would not call _stopPlugins.

• Plugins.subproj/IFPluginView.mm: (-[IFPluginView viewWillMoveToWindow:]):
• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView viewWillMoveToWindow:]): Use this viewWillMoveToWindow instead of removeFromSuperview; it's a more reliable way to handle cases where the view is removed from the view hierarchy.

Fix for IFWebFrame -> IFWebDataSource -> LoadProgressMonitor -> IFWebFrame
reference cycle.

• WebView.subproj/IFLocationChangeHandler.h: Add dataSource parameters for the methods that don't have them so this can be "delegate" style.
• WebView.subproj/IFWebController.h: Pass a dataSource instead of a frame when asking for a location change handler.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Pass dataSource for locationChangeDone.

• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:]): Pass dataSource for locationChangeStarted.

• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]): Pass a dataSource instead of a frame when asking for a location change handler.

• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Pass dataSource for locationChangeCommitted. (-[IFWebFrame _isLoadComplete]): Pass dataSource for locationChangeDone.

• force-clean-timestamp: Give this mechanism a try. I'm not sure we really need a clean build right now.

• WebView.subproj/IFWebDataSource.mm: Simplify.

WebBrowser:

Fix for IFWebFrame -> IFWebDataSource -> LoadProgressMonitor -> IFWebFrame
reference cycle.

• LoadProgressMonitor.h:
• LoadProgressMonitor.m: (-[LoadProgressMonitor monitorLocationChangeHandler:forFrame:]): (-[LoadProgressMonitor setError:forLocationChangeHandler:frame:]): Changed to pass frames around, since the location change handler can't store a frame any more.

• LocationChangeHandler.h: Updated for new API that's delegate style, where the data source is passed into all methods rather than being retained.
• LocationChangeHandler.m: (-[LocationChangeHandler initWithBrowserDocument:]): A frame isn't passed any more. (-[LocationChangeHandler dealloc]): No frame to release. (-[LocationChangeHandler _mainFrame]): Get from document, not frame. (-[LocationChangeHandler _loadMonitor]): Get from document, not frame. (-[LocationChangeHandler locationChangeStartedForDataSource:]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]): (-[LocationChangeHandler receivedPageTitle:forDataSource:]): (-[LocationChangeHandler serverRedirectTo:forDataSource:]): (-[LocationChangeHandler requestContentPolicyForMIMEType:dataSource:]): (-[LocationChangeHandler unableToImplementContentPolicy:forDataSource:]): Use passed dataSource rather then the frame.

• WebController.m: (-[WebController provideLocationChangeHandlerForDataSource:]): No frame to pass in any more.

• WebBrowser.pbproj/project.pbxproj: Project Builder had some axe to grind.

1:27 PM Changeset in webkit [1410] by kocienda

• 21 edits in trunk/WebKit

2002-06-20 Kenneth Kocienda <​kocienda@apple.com>

A more complete fix for this bug:

Radar 2942728 (Link to Yahoo! Finance stocks page fails, says URL is "not a valid location")

I added a new +(NSURL)_IF_URLWithString: method to IFNSURLExtensions.
This is now the suggested way to create a URL from a string.

WebBrowser:

• AppController.m: (-[AppController handleGURLEvent:withReplyEvent:])
• BookmarksController.m: (-[BookmarksController outlineView:writeItems:toPasteboard:])
• BrowserDocument.m: (-[BrowserDocument goHome:])
• BrowserDocumentController.m: (-[BrowserDocumentController URLFromShortcutFile:])
• BrowserWindow.m: (-[BrowserWindow goToToolbarLocation:])
• Debug/DebugUtilities.m: (-[DebugUtilities addDebugBookmarkToMenu:forURL:keyEquivalent:]) (-[IFWebHistory populateHistoryWithTestData:])
• GoogleSearchChannel.m: (-[GoogleSearchChannel URLWithSearchCriteria:])
• IFBookmarkAdditions.m: (-[IFBookmark goTo])
• LocationFieldEditor.m: (-[LocationFieldEditor concludeDragOperation:]) (-[LocationFieldEditor paste:])
• ResourceProgressEntry.m: (-[ResourceProgressEntry URL])
• Scripting.subproj/Scripting.m: (-[GetURLCommand performDefaultImplementation]) (-[OpenURLCommand performDefaultImplementation])
• Test/PageLoadTestRunner.m: (-[PageLoadTestRunner setSingleTestURL:]) (-[PageLoadTestRunner loadTestSuiteFile:])
• WebBrowser.pbproj/project.pbxproj:

WebKit:

• History.subproj/IFURIEntry.m: (-[IFURIEntry initFromDictionaryRepresentation:])
• History.subproj/IFURLsWithTitles.m: (+[IFURLsWithTitles URLsFromPasteboard:])
• History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate updateURL:title:displayTitle:forURL:])
• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:])
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:]) (-[IFPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:])
• WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:])
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/IFWebDataSource.h:
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:])
• WebView.subproj/IFWebView.mm: (-[IFWebView performDragOperation:])

WebFoundation:

• AuthenticationManager.subproj/IFAuthenticationManager.m: (IFNSURLGetParent):
• CacheLoader.subproj/IFFileURLProtocolHandler.m: (+[IFFileURLProtocolHandler canonicalizeURL:]):
• CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (+[IFHTTPURLProtocolHandler canonicalizeURL:]): (-[IFHTTPURLProtocolHandler URLFromLocationHeader]): (-[IFHTTPURLProtocolHandler requestURL]):
• CacheLoader.subproj/IFURLLoadManager.m: (-[IFURLLoadManager canonicalizeCacheURL:]):
• CookieManager.subproj/IFCookie.m: (setDefaultsFromOriginURL):
• Misc.subproj/IFNSStringExtensions.h:
• Misc.subproj/IFNSStringExtensions.m:
• Misc.subproj/IFNSURLExtensions.h:
• Misc.subproj/IFNSURLExtensions.m: (CreateURLStringByAddingPercentEscapes): (+[NSURL _IF_URLWithString:]): (+[NSURL _IF_URLWithString:relativeToURL:]): (+[NSURL _IF_URLWithScheme:user:password:host:port:path:parameter:query:fragment:]):

12:58 PM Changeset in webkit [1409]

• 3 copies in tags/Alexander-9

This commit was manufactured by cvs2svn to create tag 'Alexander-9'.

12:58 PM Changeset in webkit [1408] by sheridan

• 8 edits in trunk

Alexander-9 version & ChangeLog tags

Jun 19, 2002:

5:09 PM Changeset in webkit [1407] by rjw

• 5 edits in trunk/WebCore

• kwq/KWQScrollView.mm: (QScrollView::addChild):

Fixed regression from fix to 2956444. Wrong view was being checked
for conformance to WebCoreFrameView.

• kwq/KWQWidget.mm: (QWidget::internalSetGeometry):

Fixed regression from fix to 2956444. Wrong view was being checked
for conformance to WebCoreFrameView.

2:28 PM Changeset in webkit [1406] by rjw

• 16 edits in trunk

• khtml/khtmlview.cpp: (KHTMLView::~KHTMLView):

Tweak

• khtml/rendering/render_image.cpp: (RenderImage::setPixmap):

Call stopAnimations when a image changes, i.e. may be changed
by JS.

• kwq/KWQPixmap.mm: (QPixmap::stopAnimations):

Call image renderer's stopAnimation.

• kwq/qt/qpixmap.h: Added stopAnimations.

Break image renderer reference cycle. When a view is removed from the view
hierarchy active image renderers are told to stop animating,
which will, in turn, cause them to release their view. We leverage
the existing _stopPlugins mechanism.

• WebCoreSupport.subproj/IFImageRenderer.h:
• WebCoreSupport.subproj/IFImageRenderer.m: (+[IFImageRenderer stopAnimationsInView:]): (-[IFImageRenderer beginAnimationInView:inRect:fromRect:]): (-[IFImageRenderer frameView]): (-[IFImageRenderer stopAnimation]):
• WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _stopPlugins]):

2:18 PM Changeset in webkit [1405] by sullivan

• 8 edits in trunk/WebKit

• fixed 2960677 -- attempt to insert nil key; content policy set twice on particular page.

The problem here was a bad URL not being propogated through the error-handling machinery
correctly because the url handle was nil, but used to get its string.

• WebCoreSupport.subproj/IFResourceURLHandleClient.m: (+[IFResourceURLHandleClient startLoadingResource:withURL:dataSource:]):
• WebView.subproj/IFWebControllerPrivate.mm: Use IFError init method that takes failingURL.

(-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:complete:]):
(-[IFWebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]):
Check [error failingURL] when resource handle is nil.

• fixed 2962304 -- No URL shown in Activity Window for certain error types

• WebController.m: (-[WebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): Get the URL's string from [error failingURL] when handle is nil. This obviates earlier workaround.

12:49 PM Changeset in webkit [1404] by darin

• 1 edit in trunk/WebCore/kwq/KWQWidget.mm

Oops.

12:46 PM Changeset in webkit [1403] by darin

• 22 edits
  1 add in trunk

WebCore:

• fixed 2956444 -- mac os x feedback form missing textarea

• kwq/WebCoreFrameView.h: Added.

• kwq/KWQWidget.mm: (QWidget::setCursor): Checked for cursor-setting call based on the WebCoreFrameView protocol instead of using an informal protocol. Also walk up the view chain so the cursor actually gets set. (QWidget::internalSetGeometry): Changed the special case in here to use the new WebCoreFrameView protocol, so it won't happen for all NSScrollView objects. Also add comments to explain the hack better and mention the code in QScrollView.

• kwq/KWQScrollView.mm: (-[NSView _KWQ_isScrollView]): Gave these KWQ names instead of IF names. (-[NSView _KWQ_getDocumentView]): Gave these KWQ names instead of IF names. (QScrollView::addChild): Changed the special case in here to use the new WebCoreFrameView protocol, so it won't happen for all NSScrollView objects. Also add comments to explain the hack better and mention the code in QWidget.

Other changes:

• kwq/kwqdebug.h: Cloned improved assert code from WebFoundation.

• kwq/KWQTextArea.h: Removed unused isReadOnly/setReadOnly.
• kwq/KWQTextArea.mm: Removed unused isReadOnly/setReadOnly.

• kwq/WebCoreViewFactory.h: Removed extraneous import and WebCoreCursorSetting API from here.

• kwq/KWQTextEdit.mm: Tweaked.
• kwq/kparts/part.h: Tweaked.

WebKit:

Fixed a storage leak and made some other changes to go along with
corresponding WebCore changes.

• WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient didStartLoadingWithURL:]): Added. (-[IFResourceURLHandleClient didStopLoading]): Added. (-[IFResourceURLHandleClient dealloc]): (-[IFResourceURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFResourceURLHandleClient IFURLHandle:didRedirectToURL:]): Use didStartLoadingWithURL and didStopLoading to cure problems where the handle would be left in the data sources list of loading handles.

• WebView.subproj/IFDynamicScrollBarsView.h: Changed to conform to the WebCoreFrameView protocol.

• Misc.subproj/WebKitDebug.h: Cloned improved assert code from WebFoundation.

• WebView.subproj/IFDynamicScrollBarsView.m: Fixed comment.

11:51 AM Changeset in webkit [1402] by cblu

• 4 edits in trunk/WebKit

WebKit:

Call setWindow in layout so that plug-in content is drawn without
needing to resize.

• Plugins.subproj/IFPluginView.mm: (-[IFPluginView layout]): (-[IFPluginView viewHasMoved:]):

WebBrowser:

Fix for 2956361 - use redirected name for downloaded files
Simplified mime parsing in Defaults.plist

• Defaults.plist:
• DownloadProgressEntry.m: (-[DownloadProgressEntry _initWithResource:progress:error:dataSource:]):
• LocationChangeHandler.m: (-[LocationChangeHandler requestContentPolicyForMIMEType:dataSource:]):

7:37 AM Changeset in webkit [1401] by kocienda

• 7 edits in trunk

2002-06-19 Kenneth Kocienda <​kocienda@apple.com>

I just played alchemical voodoo magic number games with the linker to
make all our frameworks and Alexander prebound.

Is voodoo our fate here? ....will B & I come to save us?
We poor humble groundlings yearn for the light of truth!

• JavaScriptCore/ChangeLog
• JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj: Now has -seg1addr 0x8000000
• WebBrowser/ChangeLog
• WebBrowser/WebBrowser.pbproj/project.pbxproj
• WebFoundation/ChangeLog
• WebFoundation/WebFoundation.pbproj/project.pbxproj: Now has -seg1addr 0x6000000
• WebKit/ChangeLog
• WebKit/WebKit.pbproj/project.pbxproj: Now has -seg1addr 0x7000000

Jun 18, 2002:

10:50 PM Changeset in webkit [1400] by cblu

• 8 edits in trunk/WebKit

WebKit:

Fix for 2961733 - Progress of plug-in files not shown in activity window
Plugin classed must call _IF_superviewWithName: not _IF_parentWebView

• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]):
• Plugins.subproj/IFPluginStream.mm: minor cleanup (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFPluginStream IFURLHandle:didRedirectToURL:]):
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView start]): (-[IFPluginView layout]):

WebBrowser:

Renamed content policy API's to include the data source.

• WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): (-[WebController receivedProgress:forResourceHandle:fromDataSource:]):

9:40 PM Changeset in webkit [1399] by cblu

• 32 edits in trunk/WebKit

WebBrowser:

Only have "View Source", "Save As" and "Print" menu items enabled
if currently at a web page and that web page is not loading.

Renamed content policy API's to include the data source.

• BrowserDocument.m: (-[BrowserDocument validateUserInterfaceItem:]):
• LocationChangeHandler.m: (-[LocationChangeHandler requestContentPolicyForMIMEType:dataSource:]): (-[LocationChangeHandler unableToImplementContentPolicy:forDataSource:]):
• WebBrowser.pbproj/project.pbxproj:

WebKit:

Enabled the viewing of plug-in content inline
(aka direct links to plugin media). Made IFPluginView a
IFDocumentView and IFPluginStream a IFDocumentRespresentation.

Renamed content policy API's to include the data source.

• Plugins.subproj/IFPluginDatabase.h:
• Plugins.subproj/IFPluginDatabase.m: (+[IFPluginDatabase installedPlugins]): registers plugins as IFDocument*
• Plugins.subproj/IFPluginStream.h:
• Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream init]): added for IFDocumentRepresentation (-[IFPluginStream initWithURL:pluginPointer:notifyData:attributes:]): removed load initiliazatoin (-[IFPluginStream dealloc]): (-[IFPluginStream startLoad]): added (-[IFPluginStream stop]): (-[IFPluginStream receivedData:]): added as the base implementation (-[IFPluginStream receivedError]): added as the base implementation (-[IFPluginStream finishedLoadingWithData:]): added as the base implementation (-[IFPluginStream receivedData:withDataSource:]): added for IFDocumentRepresentation (-[IFPluginStream receivedError:withDataSource:]): added for IFDocumentRepresentation (-[IFPluginStream finishedLoadingWithDataSource:]): added for IFDocumentRepresentation (-[IFPluginStream IFURLHandleResourceDidBeginLoading:]): (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): call receivedData (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): call finishedLoadingWithData (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): call receivedError (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): call receivedError (-[IFPluginStream IFURLHandle:didRedirectToURL:]):
• Plugins.subproj/IFPluginView.h:
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:]): removed special-case code for NP_FULL mose (-[IFPluginView start]): (-[IFPluginView initWithFrame:]): added for IFDocumentView (-[IFPluginView provisionalDataSourceChanged:]): added for IFDocumentView (-[IFPluginView provisionalDataSourceCommitted:]): added for IFDocumentView (-[IFPluginView dataSourceUpdated:]): added for IFDocumentView (-[IFPluginView layout]): added for IFDocumentView (-[IFPluginView removeFromSuperview]): call stop (-[IFPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): (-[IFPluginView pluginInstance]): added
• WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): call new init method (-[IFWebCoreViewFactory viewForJavaAppletWithArguments:]): call new init method
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/IFLocationChangeHandler.h: content policy method name changes
• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): content policy method name changes
• WebView.subproj/IFWebController.h:
• WebView.subproj/IFWebController.mm: (-[IFWebController haveContentPolicy:andPath:forDataSource:]): content policy method name changes
• WebView.subproj/IFWebDataSourcePrivate.h:

1:49 PM Changeset in webkit [1398] by kocienda

• 14 edits in trunk

2002-06-18 Kenneth Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2928483 (activity viewer does not show all the pieces of a web page when the page is cached)

• WebCore/khtml/misc/loader.cpp: (DocLoader::requestImage): Added APPLE_CHANGES call to the KWQCheckCacheObjectStatus function

described below

(DocLoader::requestStyleSheet): ditto
(DocLoader::requestScript): ditto

• WebCore/kwq/KWQKloader.mm: (KWQCheckCacheObjectStatus): New function that informs WebKit of the

fact that a URL was loaded from the WebCore/khtml cache.

• WebCore/kwq/KWQLoaderImpl.h: Added prototype for KWQCheckCacheObjectStatus
• WebCore/kwq/WebCoreBridge.h: Added KWQCheckCacheObjectStatus to WebCoreBridge protocol

• WebKit/WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge objectLoadedFromCache:size:]): New method that sends the appropriate progress indication.

9:28 AM Changeset in webkit [1397] by darin

• 5 edits in trunk/WebCore

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::~KWQKHTMLPartImpl): Remove an NSLog I left in by accident.

Jun 17, 2002:

7:35 PM Changeset in webkit [1396] by rjw

• 20 edits in trunk

Fixed window.open regression.
Partial fix to targeting frame of new name.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::urlSelected):

Partial fix to frame not found problem.

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):

Fix for window.open regression.

• kwq/WebCoreBridge.h: Changed return type of openNewWindowWithURL:

Fixed window.open regression.
Partial fix to targeting frame of new name.

• WebCoreSupport.subproj/IFWebCoreBridge.h:
• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge openNewWindowWithURL:]):

Return the newly created bridge.

(-[IFWebCoreBridge receivedData:withDataSource:]):

Use setDataSource: method

(-[IFWebCoreBridge startLoadingResource:withURL:]):

No change.

(-[IFWebCoreBridge setDataSource:]):

New method.

• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView mouseMovedNotification:]):

Selection support.

(-[IFHTMLView mouseDragged:]):

Selection support.

• WebView.subproj/IFWebController.mm: (-[IFWebController haveContentPolicy:andPath:forLocationChangeHandler:]): Only change representation if it hasn't been pre-bound, or if it's class changed.

• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]):

More hackery to support window.open.

• WebController.m: (-[WebController openNewWindowWithURL:]):

Cleanup.

4:49 PM Changeset in webkit [1395] by darin

• 24 edits in trunk

Fixed many of the reasons that we were leaking the world. But we still leak
KHTMLPart objects, so there must be more problems.

• WebCoreSupport.subproj/IFResourceURLHandleClient.m: (+[IFResourceURLHandleClient startLoadingResource:withURL:dataSource:]): Add missing autorelease. Without this, we leak the world. (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Weaken assert. It was firing before.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge receivedData:withDataSource:]): Don't retain the dataSource any more. Without this, we leak the world.

• WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate dealloc]): Release the policy handler too. Without this, we leak the world.

• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]): Release resourceData, representation, downloadPath, encoding, and contentType. Without this, we leak the world.

• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]): Release the dummy data source after setting it up so it doesn't leak.

• WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLViewPrivate dealloc]): Don't release the controller, we didn't retain it. (-[IFHTMLView _resetWidget]): Delete the provisional widget too.

• WebView.subproj/IFWebDataSourcePrivate.h: Remove unused "children" array.

• WebCoreSupport.subproj/IFImageRenderer.m: Fix comment.
• WebView.subproj/IFHTMLView.mm: Fix comments.

4:48 PM Changeset in webkit [1394] by darin

• 11 edits in trunk/WebCore

Fixed a storage leak.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge documentTextFromDOM]): Add a missing autorelease.

Remove a bunch of loader-related APPLE_CHANGES.

• khtml/misc/loader.h: Remove KWQURLLoadClient and KWQLoaderImpl.
• khtml/misc/loader.cpp: (Loader::Loader): Remove unneeded KWQLoaderImpl object. (Loader::~Loader): Remove unneeded KWQLoaderImpl object. (Loader::servePendingRequests): Call KWQServeRequest instead of KWQLoaderImpl::serveRequest. (Loader::slotFinished): Remove unneeded KWQLoaderImpl::objectFinished.

• kwq/KWQLoaderImpl.h:
• kwq/KWQKloader.mm: (KWQServeRequest): Replaces the KWQLoaderImpl class. The rest of what was in this class was obsolete.

3:45 PM Changeset in webkit [1393] by rjw

• 4 edits in trunk/WebKit

Fixed call to renamed progress method.

• Plugins.subproj/IFPluginStream.mm:

1:29 PM Changeset in webkit [1392] by cblu

• 6 edits in trunk/WebKit

WebBrowser:

Implemented save as.

• BrowserDocument.m: (-[BrowserDocument dataRepresentationOfType:]): return main data source's data

(-[BrowserDocument fileType]): added. Return [dataSource fileType]
(-[BrowserDocument _isDocumentHTML]): removed obsolete comments.

• WebBrowser.pbproj/project.pbxproj:

WebKit:

• WebView.subproj/IFWebDataSource.h:
• WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource contentType]): no changes (-[IFWebDataSource fileType]): added. Returns extension based on MIME.

1:23 PM Changeset in webkit [1391] by rjw

• 19 edits in trunk

Fixed www.2cpu.com regression. QWidget::_displayRect was displaying the wrong
view. This was a regression that would impact all DHTML.

• khtml/khtmlview.cpp: (KHTMLView::timerEvent):
• kwq/KWQScrollView.mm: (QScrollView::updateContents):
• kwq/KWQWidget.mm: (QWidget::QWidget): (QWidget::endEditing):
• kwq/qt/qwidget.h:

Added explicit complete check for resources, rather
than depend on bytesSoFar == totalToLoad.

• WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient receivedProgressWithHandle:complete:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidFinishLoading:data:]):
• WebView.subproj/IFWebControllerPrivate.h:
• WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:complete:]):

12:47 PM Changeset in webkit [1390] by cblu

• 4 edits in trunk/WebKit

Fix for 2939881. No more overwritting of one's files.

• Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler receivedData:]): (-[IFDownloadHandler finishedLoading]):

11:18 AM Changeset in webkit [1389] by rjw

• 11 edits in trunk/WebKit

Fixed IFImageViews not drawing correctly.

Changed compeletion to explicity use IFURLHandleResourceDidFinishLoading, rather
than depend on bytesSoFar == totalToLoad.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
• WebView.subproj/IFWebControllerPrivate.h:
• WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):

11:12 AM Changeset in webkit [1388] by darin

• 4 edits in trunk/WebCore

Fixed bug where some images would get left behind when scrolling. Turned out it
was all the tiled images that were getting left behind.

• kwq/KWQPainter.mm: (QPainter::drawTiledPixmap): Fixed to get the view for coordinates from [NSView focusView] the way drawPixmap does, rather than using data->widget->getView(), which gives the scroll view instead of the scrolled view.

Jun 16, 2002:

6:48 PM Changeset in webkit [1387] by darin

• 11 edits in trunk

WebCore:

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::frames): Fixed this function to get from frames to parts properly. It was still assuming that [WebCoreBridge childFrames] would return a list of WebCoreBridge objects, but now it returns WebCoreFrame objects.

• kwq/WebCoreFrame.h: Added [WebCoreFrame bridge] for the case above. Note that it always gives the "committed" bridge, not the provisional one.

WebKit:

• WebCoreSupport.subproj/IFWebCoreFrame.m: (-[IFWebCoreFrame bridge]): Added.

10:27 AM Changeset in webkit [1386] by darin

• 26 edits
  7 adds in trunk

WebCore:

Add a separate WebCoreFrame alongside WebCoreBridge to facilitate
handling of frames with no HTML content in them. This probably fixes
frames named "_blank".

Also fixed the build, because a clean build failed.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::openURLInFrame): (KWQKHTMLPartImpl::urlSelected): (KWQKHTMLPartImpl::requestFrame): (KWQKHTMLPartImpl::submitForm): (KWQKHTMLPartImpl::parentPart): Work with WebCoreFrame objects instead of WebCoreBridge objects when dealing with frame operations -- loading new URLs mainly.

• kwq/WebCoreBridge.h: Removed frame-related operations, now they are on WebCoreFrame. Broke out WebCoreResourceLoader into its own file. Added comments.

• kwq/WebCoreFrame.h: Added.

• kwq/WebCoreResourceLoader.h: Added.
• kwq/KWQKloader.mm: Include WebCoreResourceLoader.h now that it's broken out.

• WebCore-tests.exp: Tests still need QString::latin1(), although we don't need to export it for WebKit any more.

WebKit:

• WebCoreSupport.subproj/IFResourceURLHandleClient.m:
• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge frame]): Added. (-[IFWebCoreBridge parent]): Changed name from parentFrame, to emphasize that this gives a WebCoreBridge. (-[IFWebCoreBridge childFrames]): Return IFWebCoreFrame objects. (-[IFWebCoreBridge childFrameNamed:]): Return IFWebCoreFrame object. (-[IFWebCoreBridge descendantFrameNamed:]): Return IFWebCoreFrame object. (-[IFWebCoreBridge createChildFrameNamed:withURL:renderPart:khtml::allowsScrolling:marginWidth:marginHeight:]): Use the loadURL operation in IFWebCoreFrame. (-[IFWebCoreBridge mainFrame]): Return IFWebCoreFrame object. (-[IFWebCoreBridge frameNamed:]): Return IFWebCoreFrame object.

• WebCoreSupport.subproj/IFWebCoreFrame.h: Added.
• WebCoreSupport.subproj/IFWebCoreFrame.m: Added.
• WebKit.pbproj/project.pbxproj: Update for added files.

• WebView.subproj/IFHTMLViewPrivate.h: Made this includable from plain Objective C.

• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]): Create the IFWebCoreFrame.

• WebView.subproj/IFWebFramePrivate.h: Add _bridgeFrame method for getting IFWebCoreFrame.
• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate dealloc]): Release the IFWebCoreFrame. (-[IFWebFrame _bridgeFrame]): Added.

12:46 AM Changeset in webkit [1385] by darin

• 3 edits in trunk/WebCore/kwq

Forgot to save file.

12:45 AM Changeset in webkit [1384] by darin

• 18 edits
  6 adds in trunk

WebCore:

Moved the IFURLHandleClient subclass to WebKit, so it can some day be merged
with the one for the frames themselves; this one is for resources.

• kwq/kio/jobclasses.h:
• kwq/KWQKjobclasses.mm: (TransferJob::setHandle): Replaced the old TransferJob::begin with this.

• kwq/KWQLoaderImpl.h: Remove setClient.
• kwq/KWQKloader.mm: (-[WebCoreResourceLoader initWithLoader:job:]): Added. (-[WebCoreResourceLoader dealloc]): Added. (-[WebCoreResourceLoader addData:]): Added. (-[WebCoreResourceLoader cancel]): Added. (-[WebCoreResourceLoader finish]): Added. (KWQLoaderImpl::serveRequest): Use [WebCoreBridge startLoadingResource:withURL:].
• khtml/misc/loader.cpp: (Loader::load): Removed unneeded call to setClient.

• kwq/WebCoreBridge.h: Remove unneeded methods. Added [WebCoreBridge startLoadingResource:withURL:].

WebKit:

Moved the IFURLHandleClient subclass here from WebCore, so it can some day be merged
with the one for the frames themselves; this one is for resources.

• WebCoreSupport.subproj/IFResourceURLHandleClient.h: Added.
• WebCoreSupport.subproj/IFResourceURLHandleClient.m: Added.
• WebKit.pbproj/project.pbxproj: Added IFResourceURLHandleClient.h and .m.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge startLoadingResource:withURL:]): Added. Removed all the old methods, with their guts moved into IFResourceURLHandleClient.

12:04 AM Changeset in webkit [1383] by darin

• 11 edits in trunk

WebCore:

Fix frame-related calls. I was always searching all the frames, which was disastrous.
Also do name changes.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::urlSelected): Use descendantFrameNamed rather than frameNamed. (KWQKHTMLPartImpl::requestFrame): Use childFrameNamed rather than frameNamed. (KWQKHTMLPartImpl::frameExists): Use childFrameNamed rather than frameNamed.

• kwq/KWQScrollView.mm: (QScrollView::addChild): Asserts I used while debugging.

• kwq/WebCoreBridge.h: Add new calls. Change names of old ones to include the word frame consistently. (Also bits of new work that will do no harm, but are not really needed yet.)

WebKit:

Update for frame-related changes in WebCore.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebFrame _bridge]): Look at provisional data source first. (-[IFWebCoreBridge dealloc]): Release the data source. (-[IFWebCoreBridge parentFrame]): Renamed. (-[IFWebCoreBridge childFrames]): Renamed. (-[IFWebCoreBridge childFrameNamed:]): Added. (-[IFWebCoreBridge descendantFrameNamed:]): Added. (-[IFWebCoreBridge didFinishLoadingWithHandle:]): Don't call _didStopLoading twice when we finish loading.

Also changed controller getters to call [dataSource controller] and got rid of the
[IFWebCoreBridge controller] method.