Timeline



Jun 23, 2002:

11:17 AM Changeset in webkit [1418] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Use hasAlpha instead of isOpaque because the latter does not work (Radar 2966937).

Jun 21, 2002:

5:24 PM Changeset in webkit [1417] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Add back the higher-speed case where we draw directly for opaque animated images.
4:40 PM Changeset in webkit [1416] by darin
  • 18 edits in trunk

WebCore:

  • kwq/KWQFont.mm: Made it store a copy of the family name instead of storing a reference to the mutable CFString.
  • kwq/KWQPainter.mm: (QPainter::drawPixmap): Simplified. (QPainter::drawTiledPixmap): Used the new [tileInRect:].
  • kwq/WebCoreImageRenderer.h: Added [tileInRect:], removed [drawInRect:], and also removed view parameter from [beginAnimation].
  • kwq/qt/qpixmap.h: Removed unneeded getImageRenderer().

WebKit:

Cache the patterns we make for tiled images for added speed.

  • WebCoreSupport.subproj/IFImageRenderer.h: Removed declarations of methods inherited from WebCoreImageRenderer. Added patternColor field.
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer dealloc]): Release patternColor. (-[IFImageRenderer beginAnimationInRect:fromRect:]): Get the view with [NSView focusView] rather than taking a parameter that's used only for the animating case. (-[IFImageRenderer tileInRect:fromPoint:]): New. Caches the pattern in the patternColor field.
  • WebView.subproj/IFImageView.m: (-[IFImageView drawRect:]): No need to pass view to image renderer any more.
10:38 AM Changeset in webkit [1415] by darin
  • 3 edits in trunk/WebCore

Added bug number:

  • fixed 2964718 -- crash in KWQCheckCacheObjectStatus
10:24 AM Changeset in webkit [1414] by darin
  • 4 edits in trunk/WebKit

Fix rendering of non-opaque animated images.

  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Use [NSView displayRect:] instead of drawing explicitly so that views behind us get a chance to draw too. This is less efficient than just drawing for opaque images, but NSImage doesn't offer a way to find out if the image is opaque. Also, this changes things a bit because beginAnimationInView gets called again, so we don't have to reschedule the timer.
10:20 AM Changeset in webkit [1413] by darin
  • 6 edits in trunk/WebCore
  • kwq/KWQKloader.mm: (KWQCheckCacheObjectStatus): Handle case of nil object. Add comments. Remove questionable use of floating point abs() to convert always positive int to uint.

Jun 20, 2002:

6:27 PM Changeset in webkit [1412] by rjw
  • 8 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer frameDuration]):

Added minimum 1/60th second duration per frame.

  • WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]):

Only display scrollview if scrollers changed.

  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _setState:]):

Explicity turn on copiesOnScroll. This may cause problems w/
plugins. Need to verify once plugins are no longer crashing.

4:35 PM Changeset in webkit [1411] by darin
  • 41 edits
    2 deletes in trunk

WebCore:

  • kwq/KWQKCharsets.mm: Removed unneeded parts.
  • kwq/KWQStyle.mm: Removed.
  • kwq/KWQToolTip.mm: Removed.
  • kwq/KWQVariant.mm: Simplified.
  • kwq/Makefile.am: Removed KWQStyle.mm and KWQToolTip.mm.
  • kwq/KWQRefPtr.h: Streamlined implementation that inlines a bit less and is more efficient for creating empty pointers.
  • kwq/KWQStyle.h: Removed unused stuff.
  • kwq/kdecore/kcharsets.h: Removed unneeded parts.
  • kwq/qt/qsortedlist.h: Removed unneeded parts.
  • kwq/qt/qtooltip.h: Removed unneeded parts.
  • kwq/qt/qvariant.h: Removed unneeded parts.
  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Remove unneeded APPLE_CHANGES -- no need to nil something out in a destructor.

WebKit:

Fix for leak where sub-frame IFHTMLViews would not call _stopPlugins.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView viewWillMoveToWindow:]):
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView viewWillMoveToWindow:]): Use this viewWillMoveToWindow instead of removeFromSuperview; it's a more reliable way to handle cases where the view is removed from the view hierarchy.

Fix for IFWebFrame -> IFWebDataSource -> LoadProgressMonitor -> IFWebFrame
reference cycle.

  • WebView.subproj/IFLocationChangeHandler.h: Add dataSource parameters for the methods that don't have them so this can be "delegate" style.
  • WebView.subproj/IFWebController.h: Pass a dataSource instead of a frame when asking for a location change handler.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Pass dataSource for locationChangeDone.
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:]): Pass dataSource for locationChangeStarted.
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]): Pass a dataSource instead of a frame when asking for a location change handler.
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Pass dataSource for locationChangeCommitted. (-[IFWebFrame _isLoadComplete]): Pass dataSource for locationChangeDone.
  • force-clean-timestamp: Give this mechanism a try. I'm not sure we really need a clean build right now.
  • WebView.subproj/IFWebDataSource.mm: Simplify.

WebBrowser:

Fix for IFWebFrame -> IFWebDataSource -> LoadProgressMonitor -> IFWebFrame
reference cycle.

  • LoadProgressMonitor.h:
  • LoadProgressMonitor.m: (-[LoadProgressMonitor monitorLocationChangeHandler:forFrame:]): (-[LoadProgressMonitor setError:forLocationChangeHandler:frame:]): Changed to pass frames around, since the location change handler can't store a frame any more.
  • LocationChangeHandler.h: Updated for new API that's delegate style, where the data source is passed into all methods rather than being retained.
  • LocationChangeHandler.m: (-[LocationChangeHandler initWithBrowserDocument:]): A frame isn't passed any more. (-[LocationChangeHandler dealloc]): No frame to release. (-[LocationChangeHandler _mainFrame]): Get from document, not frame. (-[LocationChangeHandler _loadMonitor]): Get from document, not frame. (-[LocationChangeHandler locationChangeStartedForDataSource:]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]): (-[LocationChangeHandler receivedPageTitle:forDataSource:]): (-[LocationChangeHandler serverRedirectTo:forDataSource:]): (-[LocationChangeHandler requestContentPolicyForMIMEType:dataSource:]): (-[LocationChangeHandler unableToImplementContentPolicy:forDataSource:]): Use passed dataSource rather then the frame.
  • WebController.m: (-[WebController provideLocationChangeHandlerForDataSource:]): No frame to pass in any more.
  • WebBrowser.pbproj/project.pbxproj: Project Builder had some axe to grind.
1:27 PM Changeset in webkit [1410] by kocienda
  • 21 edits in trunk/WebKit

2002-06-20 Kenneth Kocienda <​kocienda@apple.com>

A more complete fix for this bug:

Radar 2942728 (Link to Yahoo! Finance stocks page fails, says URL is "not a valid location")

I added a new +(NSURL)_IF_URLWithString: method to IFNSURLExtensions.
This is now the suggested way to create a URL from a string.

WebBrowser:

  • AppController.m: (-[AppController handleGURLEvent:withReplyEvent:])
  • BookmarksController.m: (-[BookmarksController outlineView:writeItems:toPasteboard:])
  • BrowserDocument.m: (-[BrowserDocument goHome:])
  • BrowserDocumentController.m: (-[BrowserDocumentController URLFromShortcutFile:])
  • BrowserWindow.m: (-[BrowserWindow goToToolbarLocation:])
  • Debug/DebugUtilities.m: (-[DebugUtilities addDebugBookmarkToMenu:forURL:keyEquivalent:]) (-[IFWebHistory populateHistoryWithTestData:])
  • GoogleSearchChannel.m: (-[GoogleSearchChannel URLWithSearchCriteria:])
  • IFBookmarkAdditions.m: (-[IFBookmark goTo])
  • LocationFieldEditor.m: (-[LocationFieldEditor concludeDragOperation:]) (-[LocationFieldEditor paste:])
  • ResourceProgressEntry.m: (-[ResourceProgressEntry URL])
  • Scripting.subproj/Scripting.m: (-[GetURLCommand performDefaultImplementation]) (-[OpenURLCommand performDefaultImplementation])
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner setSingleTestURL:]) (-[PageLoadTestRunner loadTestSuiteFile:])
  • WebBrowser.pbproj/project.pbxproj:

WebKit:

  • History.subproj/IFURIEntry.m: (-[IFURIEntry initFromDictionaryRepresentation:])
  • History.subproj/IFURLsWithTitles.m: (+[IFURLsWithTitles URLsFromPasteboard:])
  • History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate updateURL:title:displayTitle:forURL:])
  • Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:])
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:]) (-[IFPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:])
  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:])
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFWebDataSource.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:])
  • WebView.subproj/IFWebView.mm: (-[IFWebView performDragOperation:])

WebFoundation:

  • AuthenticationManager.subproj/IFAuthenticationManager.m: (IFNSURLGetParent):
  • CacheLoader.subproj/IFFileURLProtocolHandler.m: (+[IFFileURLProtocolHandler canonicalizeURL:]):
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (+[IFHTTPURLProtocolHandler canonicalizeURL:]): (-[IFHTTPURLProtocolHandler URLFromLocationHeader]): (-[IFHTTPURLProtocolHandler requestURL]):
  • CacheLoader.subproj/IFURLLoadManager.m: (-[IFURLLoadManager canonicalizeCacheURL:]):
  • CookieManager.subproj/IFCookie.m: (setDefaultsFromOriginURL):
  • Misc.subproj/IFNSStringExtensions.h:
  • Misc.subproj/IFNSStringExtensions.m:
  • Misc.subproj/IFNSURLExtensions.h:
  • Misc.subproj/IFNSURLExtensions.m: (CreateURLStringByAddingPercentEscapes): (+[NSURL _IF_URLWithString:]): (+[NSURL _IF_URLWithString:relativeToURL:]): (+[NSURL _IF_URLWithScheme:user:password:host:port:path:parameter:query:fragment:]):
12:58 PM Changeset in webkit [1409]
  • 3 copies in tags/Alexander-9

This commit was manufactured by cvs2svn to create tag 'Alexander-9'.

12:58 PM Changeset in webkit [1408] by sheridan
  • 8 edits in trunk

Alexander-9 version & ChangeLog tags

Jun 19, 2002:

5:09 PM Changeset in webkit [1407] by rjw
  • 5 edits in trunk/WebCore
  • kwq/KWQScrollView.mm: (QScrollView::addChild):

Fixed regression from fix to 2956444. Wrong view was being checked
for conformance to WebCoreFrameView.

  • kwq/KWQWidget.mm: (QWidget::internalSetGeometry):

Fixed regression from fix to 2956444. Wrong view was being checked
for conformance to WebCoreFrameView.

2:28 PM Changeset in webkit [1406] by rjw
  • 16 edits in trunk
  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView):

Tweak

  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap):

Call stopAnimations when a image changes, i.e. may be changed
by JS.

  • kwq/KWQPixmap.mm: (QPixmap::stopAnimations):

Call image renderer's stopAnimation.

  • kwq/qt/qpixmap.h: Added stopAnimations.

Break image renderer reference cycle. When a view is removed from the view
hierarchy active image renderers are told to stop animating,
which will, in turn, cause them to release their view. We leverage
the existing _stopPlugins mechanism.

  • WebCoreSupport.subproj/IFImageRenderer.h:
  • WebCoreSupport.subproj/IFImageRenderer.m: (+[IFImageRenderer stopAnimationsInView:]): (-[IFImageRenderer beginAnimationInView:inRect:fromRect:]): (-[IFImageRenderer frameView]): (-[IFImageRenderer stopAnimation]):
  • WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _stopPlugins]):
2:18 PM Changeset in webkit [1405] by sullivan
  • 8 edits in trunk/WebKit
  • fixed 2960677 -- attempt to insert nil key; content policy set twice on particular page.

The problem here was a bad URL not being propogated through the error-handling machinery
correctly because the url handle was nil, but used to get its string.

  • WebCoreSupport.subproj/IFResourceURLHandleClient.m: (+[IFResourceURLHandleClient startLoadingResource:withURL:dataSource:]):
  • WebView.subproj/IFWebControllerPrivate.mm: Use IFError init method that takes failingURL.

(-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:complete:]):
(-[IFWebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]):
Check [error failingURL] when resource handle is nil.

  • fixed 2962304 -- No URL shown in Activity Window for certain error types
  • WebController.m: (-[WebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): Get the URL's string from [error failingURL] when handle is nil. This obviates earlier workaround.
12:49 PM Changeset in webkit [1404] by darin
  • 1 edit in trunk/WebCore/kwq/KWQWidget.mm

Oops.

12:46 PM Changeset in webkit [1403] by darin
  • 22 edits
    1 add in trunk

WebCore:

  • fixed 2956444 -- mac os x feedback form missing textarea
  • kwq/WebCoreFrameView.h: Added.
  • kwq/KWQWidget.mm: (QWidget::setCursor): Checked for cursor-setting call based on the WebCoreFrameView protocol instead of using an informal protocol. Also walk up the view chain so the cursor actually gets set. (QWidget::internalSetGeometry): Changed the special case in here to use the new WebCoreFrameView protocol, so it won't happen for all NSScrollView objects. Also add comments to explain the hack better and mention the code in QScrollView.
  • kwq/KWQScrollView.mm: (-[NSView _KWQ_isScrollView]): Gave these KWQ names instead of IF names. (-[NSView _KWQ_getDocumentView]): Gave these KWQ names instead of IF names. (QScrollView::addChild): Changed the special case in here to use the new WebCoreFrameView protocol, so it won't happen for all NSScrollView objects. Also add comments to explain the hack better and mention the code in QWidget.

Other changes:

  • kwq/kwqdebug.h: Cloned improved assert code from WebFoundation.
  • kwq/KWQTextArea.h: Removed unused isReadOnly/setReadOnly.
  • kwq/KWQTextArea.mm: Removed unused isReadOnly/setReadOnly.
  • kwq/WebCoreViewFactory.h: Removed extraneous import and WebCoreCursorSetting API from here.
  • kwq/KWQTextEdit.mm: Tweaked.
  • kwq/kparts/part.h: Tweaked.

WebKit:

Fixed a storage leak and made some other changes to go along with
corresponding WebCore changes.

  • WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient didStartLoadingWithURL:]): Added. (-[IFResourceURLHandleClient didStopLoading]): Added. (-[IFResourceURLHandleClient dealloc]): (-[IFResourceURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFResourceURLHandleClient IFURLHandle:didRedirectToURL:]): Use didStartLoadingWithURL and didStopLoading to cure problems where the handle would be left in the data sources list of loading handles.
  • WebView.subproj/IFDynamicScrollBarsView.h: Changed to conform to the WebCoreFrameView protocol.
  • Misc.subproj/WebKitDebug.h: Cloned improved assert code from WebFoundation.
  • WebView.subproj/IFDynamicScrollBarsView.m: Fixed comment.
11:51 AM Changeset in webkit [1402] by cblu
  • 4 edits in trunk/WebKit

WebKit:

Call setWindow in layout so that plug-in content is drawn without
needing to resize.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView layout]): (-[IFPluginView viewHasMoved:]):

WebBrowser:

Fix for 2956361 - use redirected name for downloaded files
Simplified mime parsing in Defaults.plist

  • Defaults.plist:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry _initWithResource:progress:error:dataSource:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler requestContentPolicyForMIMEType:dataSource:]):
7:37 AM Changeset in webkit [1401] by kocienda
  • 7 edits in trunk

2002-06-19 Kenneth Kocienda <​kocienda@apple.com>

I just played alchemical voodoo magic number games with the linker to
make all our frameworks and Alexander prebound.

Is voodoo our fate here? ....will B & I come to save us?
We poor humble groundlings yearn for the light of truth!

  • JavaScriptCore/ChangeLog
  • JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj: Now has -seg1addr 0x8000000
  • WebBrowser/ChangeLog
  • WebBrowser/WebBrowser.pbproj/project.pbxproj
  • WebFoundation/ChangeLog
  • WebFoundation/WebFoundation.pbproj/project.pbxproj: Now has -seg1addr 0x6000000
  • WebKit/ChangeLog
  • WebKit/WebKit.pbproj/project.pbxproj: Now has -seg1addr 0x7000000
Note: See TracTimeline for information about the timeline view.