⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 24, 2002:

9:50 PM Changeset in webkit [1425] by darin
  • 4 edits in trunk/WebKit
  • Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels didStopLoadingURL:inWindow:]): Fix a leak caused by calling the wrong method. This was calling objectForKey: instead of removeObjectForKey:.
6:59 PM Changeset in webkit [1424] by rjw
  • 4 edits in trunk/WebKit

Changed our usage of +[NSFont findFontLike:forString:withRange:inLanguage:]
after talking with Aki. We were erroneously passing a complete
string rather than a character cluster. Fixed 2964793.

  • WebCoreSupport.subproj/IFTextRenderer.m: (findLengthOfCharacterCluster): (-[IFTextRenderer slowPackGlyphsForCharacters:numCharacters:glyphBuffer:numGlyphs:]): (-[IFTextRenderer drawGlyphs:numGlyphs:atPoint:withColor:]): (-[IFTextRenderer slowDrawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer _drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:]):
4:21 PM Changeset in webkit [1423] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Take ownership before doing the setWidget. The other way the widget was getting deleted.
4:08 PM Changeset in webkit [1422] by cblu
  • 7 edits in trunk/WebCore

* empty log message *

3:06 PM Changeset in webkit [1421] by cblu
  • 12 edits in trunk/WebKit

WebKit:

  • Plugins.subproj/IFPlugin.h:
  • Plugins.subproj/IFPlugin.m: (-[IFPlugin initWithPath:]): Close resource files when done. (-[IFPlugin load]): Remove Java plug-in workaround, load as mach-o
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:baseURL:mime:arguments:]): take NSURLs (-[IFPluginView dealloc]): release baseURL
  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): take NSURLs (-[IFWebCoreViewFactory viewForJavaAppletWithArguments:]):

WebCore:

Changed the plug-in view constructor to take NSURL's rather
than URL strings.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestObject):
  • kwq/WebCoreViewFactory.h:
  • kwq/WebCoreViewFactory.m:
12:20 PM Changeset in webkit [1420] by darin
  • 10 edits in trunk/WebKit

Remove some unused stuff. Other minor cleanup.

  • WebView.subproj/IFDynamicScrollBarsView.h: Remove breakRecursionCycle, don't declare updateScrollers or resetCursorRects.
  • WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]): Make this work even for a view that doesn't allow scrolling, turning off both scrollers in that case. (-[IFDynamicScrollBarsView reflectScrolledClipView:]): Call updateScrollers unconditionally, letting it decide what to do, rather than looking at allowsScrolling. Also, no need to use a boolean to break the recursion cycle, now that updateScrollers does no work if none is needed. (-[IFDynamicScrollBarsView setCursor:]): Do nothing if the cursor is not changing. Also handle arrowCursor case here. (-[IFDynamicScrollBarsView resetCursorRects]): Call discardCursorRects so the old rects won't keep accumulating. (-[IFDynamicScrollBarsView setAllowsScrolling:]): Always call updateScrollers, not just when turning scrolling off.
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView initWithFrame:]): Remove unneeded NSWindowWillCloseNotification and isFlipped field. (-[IFHTMLView removeNotifications]): Moved here from NSWindowWillCloseNotification. (-[IFHTMLView viewWillMoveToWindow:]): Remove all the notifications when the view is removed from the window. (-[IFHTMLView setNeedsLayout:]): Call setNeedsDisplay in the YES case, so the callers don't all have to. (-[IFHTMLView isFlipped]): Just return YES. No need to store it. (-[IFHTMLView windowResized:]): Add a FIXME, since this is not the way we want to handle view resizing for the long run.
  • WebView.subproj/IFHTMLViewPrivate.h: Remove isFlipped.
12:13 PM Changeset in webkit [1419] by darin
  • 22 edits in trunk

WebCore:

  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Put APPLE_CHANGES later in the sequence so we don't deref the part before the code gets to run.
  • kwq/kwqdebug.h: Re-add the format attribute, now that Radar 2920557 is fixed.

WebKit:

Fix the last of the "leak the world" problems. The KHTMLView was leaking
in IFHTMLView.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView dealloc]): Call _reset instead of _stopPlugins, so we get rid of the widget too. (-[IFHTMLView viewWillMoveToWindow:]): Use _reset now instead of the old _stopPlugins; also check that the window isn't already nil so we don't do a reset as part of our first install. (-[IFHTMLView provisionalDataSourceCommitted:]): Use the new widgetOwned flag to tell if the widget should be deleted instead of deciding based on whether the dataSource is the main document.
  • WebView.subproj/IFHTMLViewPrivate.h: Add a widgetOwned boolean and a private _takeOwnershipOfWidget method. Combine _resetWidget and _stopPlugins into a single _reset call. Remove _removeSubviews.
  • WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _reset]): New name for the combination of _resetWidget and _stopPlugins. Now it decides whether to delete the widget based on the widget owned flag, so it is safe to call even for non-main-document views. (-[IFHTMLView _takeOwnershipOfWidget]): Sets widgetOwned to NO.
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame reset]): Use _resetWidget under its new name _reset.
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Don't bother doing explicit _stopPlugins and _removeSubviews. It's now the view's own responsibility to do this in viewWillMoveToWindow:. Call _takeOwnershipOfWidget after attaching the widget to the RenderPart.
  • WebView.subproj/IFImageView.m: (-[IFImageView viewWillMoveToWindow:]): Added. Break the reference cycle by stopping animated IFImageRenderer here instead of waiting for dealloc.
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView setWindow]): Fix a warning by changing the printf format string to match the parameter type.
  • Misc.subproj/WebKitDebug.h: Re-add the format attribute, now that Radar 2920557 is fixed.

Jun 23, 2002:

11:17 AM Changeset in webkit [1418] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Use hasAlpha instead of isOpaque because the latter does not work (Radar 2966937).

Jun 21, 2002:

5:24 PM Changeset in webkit [1417] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Add back the higher-speed case where we draw directly for opaque animated images.
4:40 PM Changeset in webkit [1416] by darin
  • 18 edits in trunk

WebCore:

  • kwq/KWQFont.mm: Made it store a copy of the family name instead of storing a reference to the mutable CFString.
  • kwq/KWQPainter.mm: (QPainter::drawPixmap): Simplified. (QPainter::drawTiledPixmap): Used the new [tileInRect:].
  • kwq/WebCoreImageRenderer.h: Added [tileInRect:], removed [drawInRect:], and also removed view parameter from [beginAnimation].
  • kwq/qt/qpixmap.h: Removed unneeded getImageRenderer().

WebKit:

Cache the patterns we make for tiled images for added speed.

  • WebCoreSupport.subproj/IFImageRenderer.h: Removed declarations of methods inherited from WebCoreImageRenderer. Added patternColor field.
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer dealloc]): Release patternColor. (-[IFImageRenderer beginAnimationInRect:fromRect:]): Get the view with [NSView focusView] rather than taking a parameter that's used only for the animating case. (-[IFImageRenderer tileInRect:fromPoint:]): New. Caches the pattern in the patternColor field.
  • WebView.subproj/IFImageView.m: (-[IFImageView drawRect:]): No need to pass view to image renderer any more.
10:38 AM Changeset in webkit [1415] by darin
  • 3 edits in trunk/WebCore

Added bug number:

  • fixed 2964718 -- crash in KWQCheckCacheObjectStatus
10:24 AM Changeset in webkit [1414] by darin
  • 4 edits in trunk/WebKit

Fix rendering of non-opaque animated images.

  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Use [NSView displayRect:] instead of drawing explicitly so that views behind us get a chance to draw too. This is less efficient than just drawing for opaque images, but NSImage doesn't offer a way to find out if the image is opaque. Also, this changes things a bit because beginAnimationInView gets called again, so we don't have to reschedule the timer.
10:20 AM Changeset in webkit [1413] by darin
  • 6 edits in trunk/WebCore
  • kwq/KWQKloader.mm: (KWQCheckCacheObjectStatus): Handle case of nil object. Add comments. Remove questionable use of floating point abs() to convert always positive int to uint.

Jun 20, 2002:

6:27 PM Changeset in webkit [1412] by rjw
  • 8 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer frameDuration]):

Added minimum 1/60th second duration per frame.

  • WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]):

Only display scrollview if scrollers changed.

  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _setState:]):

Explicity turn on copiesOnScroll. This may cause problems w/
plugins. Need to verify once plugins are no longer crashing.

4:35 PM Changeset in webkit [1411] by darin
  • 41 edits
    2 deletes in trunk

WebCore:

  • kwq/KWQKCharsets.mm: Removed unneeded parts.
  • kwq/KWQStyle.mm: Removed.
  • kwq/KWQToolTip.mm: Removed.
  • kwq/KWQVariant.mm: Simplified.
  • kwq/Makefile.am: Removed KWQStyle.mm and KWQToolTip.mm.
  • kwq/KWQRefPtr.h: Streamlined implementation that inlines a bit less and is more efficient for creating empty pointers.
  • kwq/KWQStyle.h: Removed unused stuff.
  • kwq/kdecore/kcharsets.h: Removed unneeded parts.
  • kwq/qt/qsortedlist.h: Removed unneeded parts.
  • kwq/qt/qtooltip.h: Removed unneeded parts.
  • kwq/qt/qvariant.h: Removed unneeded parts.
  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Remove unneeded APPLE_CHANGES -- no need to nil something out in a destructor.

WebKit:

Fix for leak where sub-frame IFHTMLViews would not call _stopPlugins.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView viewWillMoveToWindow:]):
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView viewWillMoveToWindow:]): Use this viewWillMoveToWindow instead of removeFromSuperview; it's a more reliable way to handle cases where the view is removed from the view hierarchy.

Fix for IFWebFrame -> IFWebDataSource -> LoadProgressMonitor -> IFWebFrame
reference cycle.

  • WebView.subproj/IFLocationChangeHandler.h: Add dataSource parameters for the methods that don't have them so this can be "delegate" style.
  • WebView.subproj/IFWebController.h: Pass a dataSource instead of a frame when asking for a location change handler.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Pass dataSource for locationChangeDone.
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:]): Pass dataSource for locationChangeStarted.
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]): Pass a dataSource instead of a frame when asking for a location change handler.
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Pass dataSource for locationChangeCommitted. (-[IFWebFrame _isLoadComplete]): Pass dataSource for locationChangeDone.
  • force-clean-timestamp: Give this mechanism a try. I'm not sure we really need a clean build right now.
  • WebView.subproj/IFWebDataSource.mm: Simplify.

WebBrowser:

Fix for IFWebFrame -> IFWebDataSource -> LoadProgressMonitor -> IFWebFrame
reference cycle.

  • LoadProgressMonitor.h:
  • LoadProgressMonitor.m: (-[LoadProgressMonitor monitorLocationChangeHandler:forFrame:]): (-[LoadProgressMonitor setError:forLocationChangeHandler:frame:]): Changed to pass frames around, since the location change handler can't store a frame any more.
  • LocationChangeHandler.h: Updated for new API that's delegate style, where the data source is passed into all methods rather than being retained.
  • LocationChangeHandler.m: (-[LocationChangeHandler initWithBrowserDocument:]): A frame isn't passed any more. (-[LocationChangeHandler dealloc]): No frame to release. (-[LocationChangeHandler _mainFrame]): Get from document, not frame. (-[LocationChangeHandler _loadMonitor]): Get from document, not frame. (-[LocationChangeHandler locationChangeStartedForDataSource:]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]): (-[LocationChangeHandler receivedPageTitle:forDataSource:]): (-[LocationChangeHandler serverRedirectTo:forDataSource:]): (-[LocationChangeHandler requestContentPolicyForMIMEType:dataSource:]): (-[LocationChangeHandler unableToImplementContentPolicy:forDataSource:]): Use passed dataSource rather then the frame.
  • WebController.m: (-[WebController provideLocationChangeHandlerForDataSource:]): No frame to pass in any more.
  • WebBrowser.pbproj/project.pbxproj: Project Builder had some axe to grind.
1:27 PM Changeset in webkit [1410] by kocienda
  • 21 edits in trunk/WebKit

2002-06-20 Kenneth Kocienda <​kocienda@apple.com>

A more complete fix for this bug:

Radar 2942728 (Link to Yahoo! Finance stocks page fails, says URL is "not a valid location")

I added a new +(NSURL)_IF_URLWithString: method to IFNSURLExtensions.
This is now the suggested way to create a URL from a string.

WebBrowser:

  • AppController.m: (-[AppController handleGURLEvent:withReplyEvent:])
  • BookmarksController.m: (-[BookmarksController outlineView:writeItems:toPasteboard:])
  • BrowserDocument.m: (-[BrowserDocument goHome:])
  • BrowserDocumentController.m: (-[BrowserDocumentController URLFromShortcutFile:])
  • BrowserWindow.m: (-[BrowserWindow goToToolbarLocation:])
  • Debug/DebugUtilities.m: (-[DebugUtilities addDebugBookmarkToMenu:forURL:keyEquivalent:]) (-[IFWebHistory populateHistoryWithTestData:])
  • GoogleSearchChannel.m: (-[GoogleSearchChannel URLWithSearchCriteria:])
  • IFBookmarkAdditions.m: (-[IFBookmark goTo])
  • LocationFieldEditor.m: (-[LocationFieldEditor concludeDragOperation:]) (-[LocationFieldEditor paste:])
  • ResourceProgressEntry.m: (-[ResourceProgressEntry URL])
  • Scripting.subproj/Scripting.m: (-[GetURLCommand performDefaultImplementation]) (-[OpenURLCommand performDefaultImplementation])
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner setSingleTestURL:]) (-[PageLoadTestRunner loadTestSuiteFile:])
  • WebBrowser.pbproj/project.pbxproj:

WebKit:

  • History.subproj/IFURIEntry.m: (-[IFURIEntry initFromDictionaryRepresentation:])
  • History.subproj/IFURLsWithTitles.m: (+[IFURLsWithTitles URLsFromPasteboard:])
  • History.subproj/IFWebHistoryPrivate.m: (-[IFWebHistoryPrivate updateURL:title:displayTitle:forURL:])
  • Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:])
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:mime:arguments:]) (-[IFPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:])
  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:])
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFWebDataSource.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:])
  • WebView.subproj/IFWebView.mm: (-[IFWebView performDragOperation:])

WebFoundation:

  • AuthenticationManager.subproj/IFAuthenticationManager.m: (IFNSURLGetParent):
  • CacheLoader.subproj/IFFileURLProtocolHandler.m: (+[IFFileURLProtocolHandler canonicalizeURL:]):
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (+[IFHTTPURLProtocolHandler canonicalizeURL:]): (-[IFHTTPURLProtocolHandler URLFromLocationHeader]): (-[IFHTTPURLProtocolHandler requestURL]):
  • CacheLoader.subproj/IFURLLoadManager.m: (-[IFURLLoadManager canonicalizeCacheURL:]):
  • CookieManager.subproj/IFCookie.m: (setDefaultsFromOriginURL):
  • Misc.subproj/IFNSStringExtensions.h:
  • Misc.subproj/IFNSStringExtensions.m:
  • Misc.subproj/IFNSURLExtensions.h:
  • Misc.subproj/IFNSURLExtensions.m: (CreateURLStringByAddingPercentEscapes): (+[NSURL _IF_URLWithString:]): (+[NSURL _IF_URLWithString:relativeToURL:]): (+[NSURL _IF_URLWithScheme:user:password:host:port:path:parameter:query:fragment:]):
12:58 PM Changeset in webkit [1409]
  • 3 copies in tags/Alexander-9

This commit was manufactured by cvs2svn to create tag 'Alexander-9'.

12:58 PM Changeset in webkit [1408] by sheridan
  • 8 edits in trunk

Alexander-9 version & ChangeLog tags

Note: See TracTimeline for information about the timeline view.