Timeline



Jun 25, 2002:

7:50 PM Changeset in webkit [1436] by rjw
  • 8 edits in trunk/WebKit

Disable the copy menu item when IFHTMLView is key
and has no selection.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView validateMenuItem:]): Disable menu if selection is empty. (-[IFHTMLView copy:]): Factored code that gets the bridge.
  • WebView.subproj/IFHTMLViewPrivate.h: Added _bridge.
  • WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _bridge]): We need to access the bridge from the view to get the part's selection.
7:26 PM Changeset in webkit [1435] by rjw
  • 8 edits in trunk/WebCore

Support for khtml style selection drawing. Ugly,
we'll want to make this more Mac like.

  • khtml/rendering/font.cpp: (Font::drawText):

Enable khtml code path. Removed APPLE_CHANGES

  • kwq/KWQFontMetrics.mm: (QFontMetrics::charWidth):

Implemented in terms of width().

  • kwq/KWQPainter.mm: (QPainter::drawText):

Implemented.

  • kwq/qt/qfontmetrics.h:

Added QFontMetrics::charWidth.

4:32 PM Changeset in webkit [1434] by cblu
  • 4 edits in trunk/WebKit

Remove downloaded file if cancelled.

  • Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler cancel]):
3:16 PM Changeset in webkit [1433] by rjw
  • 16 edits in trunk

Support for rudimentary plain text 'copy'.

  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]):
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView copy:]):
  • WebView.subproj/IFWebViewPrivate.h:
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _controller]):

Support for rudimentary plain text 'copy'.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedText]):
1:18 PM Changeset in webkit [1432] by rjw
  • 13 edits in trunk

Enabled progressive image loading code.

  • WebCoreSupport.subproj/IFImageRenderer.h:
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer initWithSize:]): (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]):
  • WebCoreSupport.subproj/IFImageRendererFactory.m: (-[IFImageRendererFactory imageRenderer]):

Enabled progressive image loading code.

  • khtml/misc/loader.cpp: (CachedImage::data):
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap):
11:56 AM Changeset in webkit [1431] by rjw
  • 4 edits in trunk/WebKit

Extended our text measurement rounding work-around for integer-float
mismatch to round on word boundaries as well as spaces.

10:38 AM Changeset in webkit [1430] by darin
  • 8 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Don't remove the URL handle from the data source until we've finished the loading process in KDE code. This may fix 2968527.
  • WebCoreSupport.subproj/IFTextRenderer.m: Keep around commented printfs so I can do the "dump all strings as they are rendered" again.
  • WebKit.pbproj/project.pbxproj: Re-add -Wmissing-format-attribute.
10:31 AM Changeset in webkit [1429] by darin
  • 4 edits in trunk/JavaScriptCore
  • JavaScriptCore.pbproj/project.pbxproj: Re-add -Wmissing-format-attribute.
10:30 AM Changeset in webkit [1428] by darin
  • 26 edits in trunk/WebCore

Removed remaining uses of BORROWED defines.
Made some simplifications and formatting fixes. All safe.

  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm:
  • kwq/KWQChar.mm:
  • kwq/KWQCharsets.mm:
  • kwq/KWQFile.mm:
  • kwq/KWQKCursor.mm:
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQListImpl.h:
  • kwq/KWQMapImpl.mm:
  • kwq/KWQString.mm:
  • kwq/KWQValueListImpl.mm:
  • kwq/KWQVectorImpl.h:
  • kwq/KWQtextcodec.mm:
  • kwq/make-charset-table.pl:
  • kwq/make-mac-encodings.c:
  • kwq/qt/qfile.h:
  • kwq/qt/qregexp.h:
  • kwq/qt/qtextcodec.h:
  • WebCore-tests.exp: Small change to exports for the array test.
7:30 AM Changeset in webkit [1427] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Remove stray NSLog.
12:33 AM Changeset in webkit [1426] by darin
  • 6 edits in trunk/WebKit
  • fixed 2968298 -- IFImageRenderer crash at download.com
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer initWithSize:]): Override this instead of [init]. This is the designated initializer and all the others call this. (-[IFImageRenderer copyWithZone:]): Override to nil out fields that can't be shared by the copy.

Fix leaks.

  • History.subproj/IFURIEntry.m: (-[IFURIEntry initWithURL:title:image:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry dealloc]): Release _displayTitle. Fixes a leak. (-[IFURIEntry setTitle:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry setDisplayTitle:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry initFromDictionaryRepresentation:]): Lose the extra retain for _lastVisitedDate. Fixes a leak.

Jun 24, 2002:

9:50 PM Changeset in webkit [1425] by darin
  • 4 edits in trunk/WebKit
  • Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels didStopLoadingURL:inWindow:]): Fix a leak caused by calling the wrong method. This was calling objectForKey: instead of removeObjectForKey:.
6:59 PM Changeset in webkit [1424] by rjw
  • 4 edits in trunk/WebKit

Changed our usage of +[NSFont findFontLike:forString:withRange:inLanguage:]
after talking with Aki. We were erroneously passing a complete
string rather than a character cluster. Fixed 2964793.

  • WebCoreSupport.subproj/IFTextRenderer.m: (findLengthOfCharacterCluster): (-[IFTextRenderer slowPackGlyphsForCharacters:numCharacters:glyphBuffer:numGlyphs:]): (-[IFTextRenderer drawGlyphs:numGlyphs:atPoint:withColor:]): (-[IFTextRenderer slowDrawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer _drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:]):
4:21 PM Changeset in webkit [1423] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Take ownership before doing the setWidget. The other way the widget was getting deleted.
4:08 PM Changeset in webkit [1422] by cblu
  • 7 edits in trunk/WebCore

* empty log message *

3:06 PM Changeset in webkit [1421] by cblu
  • 12 edits in trunk/WebKit

WebKit:

  • Plugins.subproj/IFPlugin.h:
  • Plugins.subproj/IFPlugin.m: (-[IFPlugin initWithPath:]): Close resource files when done. (-[IFPlugin load]): Remove Java plug-in workaround, load as mach-o
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:baseURL:mime:arguments:]): take NSURLs (-[IFPluginView dealloc]): release baseURL
  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): take NSURLs (-[IFWebCoreViewFactory viewForJavaAppletWithArguments:]):

WebCore:

Changed the plug-in view constructor to take NSURL's rather
than URL strings.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestObject):
  • kwq/WebCoreViewFactory.h:
  • kwq/WebCoreViewFactory.m:
12:20 PM Changeset in webkit [1420] by darin
  • 10 edits in trunk/WebKit

Remove some unused stuff. Other minor cleanup.

  • WebView.subproj/IFDynamicScrollBarsView.h: Remove breakRecursionCycle, don't declare updateScrollers or resetCursorRects.
  • WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]): Make this work even for a view that doesn't allow scrolling, turning off both scrollers in that case. (-[IFDynamicScrollBarsView reflectScrolledClipView:]): Call updateScrollers unconditionally, letting it decide what to do, rather than looking at allowsScrolling. Also, no need to use a boolean to break the recursion cycle, now that updateScrollers does no work if none is needed. (-[IFDynamicScrollBarsView setCursor:]): Do nothing if the cursor is not changing. Also handle arrowCursor case here. (-[IFDynamicScrollBarsView resetCursorRects]): Call discardCursorRects so the old rects won't keep accumulating. (-[IFDynamicScrollBarsView setAllowsScrolling:]): Always call updateScrollers, not just when turning scrolling off.
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView initWithFrame:]): Remove unneeded NSWindowWillCloseNotification and isFlipped field. (-[IFHTMLView removeNotifications]): Moved here from NSWindowWillCloseNotification. (-[IFHTMLView viewWillMoveToWindow:]): Remove all the notifications when the view is removed from the window. (-[IFHTMLView setNeedsLayout:]): Call setNeedsDisplay in the YES case, so the callers don't all have to. (-[IFHTMLView isFlipped]): Just return YES. No need to store it. (-[IFHTMLView windowResized:]): Add a FIXME, since this is not the way we want to handle view resizing for the long run.
  • WebView.subproj/IFHTMLViewPrivate.h: Remove isFlipped.
12:13 PM Changeset in webkit [1419] by darin
  • 22 edits in trunk

WebCore:

  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Put APPLE_CHANGES later in the sequence so we don't deref the part before the code gets to run.
  • kwq/kwqdebug.h: Re-add the format attribute, now that Radar 2920557 is fixed.

WebKit:

Fix the last of the "leak the world" problems. The KHTMLView was leaking
in IFHTMLView.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView dealloc]): Call _reset instead of _stopPlugins, so we get rid of the widget too. (-[IFHTMLView viewWillMoveToWindow:]): Use _reset now instead of the old _stopPlugins; also check that the window isn't already nil so we don't do a reset as part of our first install. (-[IFHTMLView provisionalDataSourceCommitted:]): Use the new widgetOwned flag to tell if the widget should be deleted instead of deciding based on whether the dataSource is the main document.
  • WebView.subproj/IFHTMLViewPrivate.h: Add a widgetOwned boolean and a private _takeOwnershipOfWidget method. Combine _resetWidget and _stopPlugins into a single _reset call. Remove _removeSubviews.
  • WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _reset]): New name for the combination of _resetWidget and _stopPlugins. Now it decides whether to delete the widget based on the widget owned flag, so it is safe to call even for non-main-document views. (-[IFHTMLView _takeOwnershipOfWidget]): Sets widgetOwned to NO.
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame reset]): Use _resetWidget under its new name _reset.
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Don't bother doing explicit _stopPlugins and _removeSubviews. It's now the view's own responsibility to do this in viewWillMoveToWindow:. Call _takeOwnershipOfWidget after attaching the widget to the RenderPart.
  • WebView.subproj/IFImageView.m: (-[IFImageView viewWillMoveToWindow:]): Added. Break the reference cycle by stopping animated IFImageRenderer here instead of waiting for dealloc.
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView setWindow]): Fix a warning by changing the printf format string to match the parameter type.
  • Misc.subproj/WebKitDebug.h: Re-add the format attribute, now that Radar 2920557 is fixed.

Jun 23, 2002:

11:17 AM Changeset in webkit [1418] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Use hasAlpha instead of isOpaque because the latter does not work (Radar 2966937).

Jun 21, 2002:

5:24 PM Changeset in webkit [1417] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Add back the higher-speed case where we draw directly for opaque animated images.
4:40 PM Changeset in webkit [1416] by darin
  • 18 edits in trunk

WebCore:

  • kwq/KWQFont.mm: Made it store a copy of the family name instead of storing a reference to the mutable CFString.
  • kwq/KWQPainter.mm: (QPainter::drawPixmap): Simplified. (QPainter::drawTiledPixmap): Used the new [tileInRect:].
  • kwq/WebCoreImageRenderer.h: Added [tileInRect:], removed [drawInRect:], and also removed view parameter from [beginAnimation].
  • kwq/qt/qpixmap.h: Removed unneeded getImageRenderer().

WebKit:

Cache the patterns we make for tiled images for added speed.

  • WebCoreSupport.subproj/IFImageRenderer.h: Removed declarations of methods inherited from WebCoreImageRenderer. Added patternColor field.
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer dealloc]): Release patternColor. (-[IFImageRenderer beginAnimationInRect:fromRect:]): Get the view with [NSView focusView] rather than taking a parameter that's used only for the animating case. (-[IFImageRenderer tileInRect:fromPoint:]): New. Caches the pattern in the patternColor field.
  • WebView.subproj/IFImageView.m: (-[IFImageView drawRect:]): No need to pass view to image renderer any more.
10:38 AM Changeset in webkit [1415] by darin
  • 3 edits in trunk/WebCore

Added bug number:

  • fixed 2964718 -- crash in KWQCheckCacheObjectStatus
10:24 AM Changeset in webkit [1414] by darin
  • 4 edits in trunk/WebKit

Fix rendering of non-opaque animated images.

  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Use [NSView displayRect:] instead of drawing explicitly so that views behind us get a chance to draw too. This is less efficient than just drawing for opaque images, but NSImage doesn't offer a way to find out if the image is opaque. Also, this changes things a bit because beginAnimationInView gets called again, so we don't have to reschedule the timer.
10:20 AM Changeset in webkit [1413] by darin
  • 6 edits in trunk/WebCore
  • kwq/KWQKloader.mm: (KWQCheckCacheObjectStatus): Handle case of nil object. Add comments. Remove questionable use of floating point abs() to convert always positive int to uint.
Note: See TracTimeline for information about the timeline view.