⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 1, 2002:

7:23 PM Changeset in webkit [1489] by mjs
  • 11 edits
    2 adds in trunk

WebCore:

Fixed Radar 2953256 - JavaScript window.moveTo() and
window.moveBy() methods do not work

This was done by creating a class to wrap an NSWindow as a
QWidget, which should be useful for many other window-related
features.

  • kwq/KWQWidget.mm: (QWidget::x): Implement in terms of the virtual frameGeometry() method. (QWidget::y): Likewise. (QWidget::width): Likewise. (QWidget::height): Likewise. (QWidget::size): Likewise. (QWidget::pos): Likewise. (QWidget::topLevelWidget): Implement by creating a KWQWindowWidget (QWidget::isVisible): Added FIXME comment.
  • kwq/KWQWindowWidget.h: Added.
  • kwq/KWQWindowWidget.mm: Added. (KWQWindowWidget::fromNSWindow): Static method that maintains a dictionary of top-level widgets, and creates them on demand. (deleteOnWindowClose): Delete top level widget on close. (KWQWindowWidget::KWQWindowWidget): (KWQWindowWidget::~KWQWindowWidget): (KWQWindowWidget::sizeHint): Implemented using NSWindow. (KWQWindowWidget::minimumSizeHint): Likewise. (KWQWindowWidget::frameGeometry): Likewise. (KWQWindowWidget::topLevelWidget): Likewise. (KWQWindowWidget::mapToGlobal): Likewise. (KWQWindowWidget::mapFromGlobal): Likewise. (KWQWindowWidget::setCursor): No-op implementation. (KWQWindowWidget::internalSetGeometry): Implemented using NSWindow.
  • kwq/Makefile.am: Add new files to build.
  • kwq/qt/qwidget.h: Make methods virtual as needed.

WebKit:

  • WebView.subproj/IFWebView.mm: (-[IFWebView window]): If the view hasn't been added to a window yet, get the window from the WindowContext.
4:31 PM Changeset in webkit [1488] by rjw
  • 5 edits in trunk/WebKit

i * WebView.subproj/IFMainURLHandleClient.mm:

(-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]):
Ensure that _didStopLoading is called for both error case and
non-error case.

4:07 PM Changeset in webkit [1487] by rjw
  • 5 edits in trunk/WebKit
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): A completion message was being sent, as well as an error message. This, no doubt confused Alexander. No only send either the final error message or the completion message.
2:17 PM Changeset in webkit [1486] by darin
  • 8 edits in trunk/WebKit

Ken fixed the load message sequencing problem in WebFoundation, so now we can
go back to the original versions of the asserts.

  • WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient dealloc]): (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): Roll out the stuff that's ifdef'd and marked with bug 2954901.
12:31 PM Changeset in webkit [1485] by darin
  • 8 edits in trunk/WebKit
  • WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]): After a closer reading of the NSScrollView source code, I see that we don't need to explicitly do tile or setNeedsDisplay: because the setters take care of that, so I made this simpler. (-[IFDynamicScrollBarsView reflectScrolledClipView:]): Replace the anti- recursion hack that I erroneously removed earlier.
  • WebView.subproj/IFTextView.h: Removed the isRTF flag.
  • WebView.subproj/IFTextView.m: (-[IFTextView provisionalDataSourceChanged:]): Do nothing here. (-[IFTextView dataSourceUpdated:]): Check the MIME type here.
12:01 PM Changeset in webkit [1484] by rjw
  • 6 edits in trunk/WebKit

Fixed 2976913.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView layout]): Augmented debugging info. (-[IFHTMLView setNeedsDisplay:]): Augmented debugging info. (-[IFHTMLView setNeedsLayout:]): Removed overload of this method to also set display flag. Why was this added? (-[IFHTMLView setNeedsToApplyStyles:]): Augmented debugging info. (-[IFHTMLView drawRect:]): Augmented debugging info.
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _timedLayout:]): If the view size is zero (width or height) force a layout now, rather than depending on the lazy layout that will happen in display. If the view size is 0,0 the AppKit will optimize out the display.
11:15 AM Changeset in webkit [1483] by cblu
  • 4 edits in trunk/WebKit

WebKit:

Minor cleanup

  • Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:]): (-[IFNullPluginView dealloc]):

WebBrowser:

Add support for delete, clear and stop menu items and keyboard shortcuts
in Downloads.

  • DownloadMonitor.m: (-[DownloadMonitor validateUserInterfaceItem:]): (-[DownloadMonitor stopLoading:]): added (-[DownloadMonitor clear:]): added (-[DownloadMonitor didDoubleClick]): (-[DownloadMonitor didHitDeleteKey]): added
  • ListView.m: (-[ListView keyDown:]): look for delete key (-[ListView validateUserInterfaceItem:]):
  • WebBrowser.pbproj/project.pbxproj:
10:00 AM Changeset in webkit [1482] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-07-01 Kenneth Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2967062 (alexander has fit on exit)

We no longer sync the contents of the cache to disk at quit time. I also
shortented the amount of time of disk cache waits before
declaring "idle time" from 5 seconds to 1 second. This might
need some tuning, but it should keep the disk cache queue with i
writes pending from getting too long, while not stepping on more i
time-critical things like page rendering.

  • CacheLoader.subproj/IFURLLoadManager.m: (-[IFURLLoadManager initWithDefaultStack]) (-[IFURLLoadManager loadDidFinish:])
  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase dealloc]) (-[IFURLFileDatabase setTimer])
9:19 AM Changeset in webkit [1481] by darin
  • 16 edits in trunk

top level:

  • Tools/CommitLogEditor/.cvsignore: Added.

WebCore:

  • khtml/css/cssparser.cpp:
  • khtml/misc/htmlhashes.cpp: Remove workaround for a PFE bug that no longer affects us.
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: Remove some unneeded APPLE_CHANGES.
  • WebCore.exp: One less symbol to export.

WebKit:

  • Plugins.subproj/IFPlugin.m: (-[IFPlugin _getPluginInfoForResourceFile:]): Fix off-by one error that would cause a memory trasher if we had a 255-character string.
  • WebView.subproj/IFHTMLView.mm:
  • WebView.subproj/IFRenderNode.mm: Touch these files so we don't have to do a full build of WebKit for my WebCore changes.
5:35 AM Changeset in webkit [1480] by mjs
  • 7 edits in trunk/WebKit

WebKit:

Build fixes (don't know why a plain build didn't catch these):

  • Plugins.subproj/IFPluginView.mm: openNewWindowWithURL: is not a method of the controller any more, nor are the status-related calls.
  • WebView.subproj/IFWebController.h: Un-ifdef the status calls.

WebBrowser:

Build fixes:

  • BrowserDocument.h,
  • BrowserDocument.m: (-[BrowserDocument highestPriorityStatusMessage]): Make this public. (-[BrowserDocument _updateStatusInBrowserWindow]): Adjust for rename.
  • WebController.m: (-[BrowserWebController statusTextForDataSource:]): Implemented.
1:48 AM Changeset in webkit [1479] by mjs
  • 4 edits in trunk/WebKit

WebKit:

Part of fix for Radar 2976618 - links targeting _blank hit
assertion trying to set provisional data source

  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame frameNamed:]): Show the window.

WebBrowser:

Part of fix for Radar 2976618 - links targeting _blank hit
assertion trying to set provisional data source

  • BrowserDocument.m: (-[BrowserDocument setShouldStartEmpty]): Ensure the window exists, so that there are a frame and web view ready in time.
1:18 AM Changeset in webkit [1478] by mjs
  • 4 edits in trunk/WebKit

Fix Radar 2953256 - Auth sheet appears detached when clicking
directly on auth link with Alex not running

  • Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels frontmostWindowLoadingURL:]): Don't consider windows that are not visible.

Jun 29, 2002:

10:31 PM Changeset in webkit [1477] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Fix calculation of oneTileRect. I think this is finally correct now.
4:28 PM Changeset in webkit [1476] by mjs
  • 26 edits in trunk

WebCore:

WebCore part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

  • kwq/WebCoreBridge.h: Add new calls needed for window size/position/feature getting and setting.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Set properties on window after creating it using new bridge calls; make it visible.
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Support scrollbars feature too.
  • kwq/kparts/browserextension.h: Include scrollbar setting stuff.

WebKit:

WebKit part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

Also, renamed IFScriptContextHandler protocol to IFWindowContext,
and made it a settable handler like the others rather than
something implemented by the controller, so it can be used w/o
subclassing.

  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge openNewWindowWithURL:]): Forward to the WindowContext. (-[IFWebCoreBridge areToolbarsVisisble]): Likewise. (-[IFWebCoreBridge setToolbarsVisible:]): Likewise. (-[IFWebCoreBridge areScrollbarsVisible]): Likewise. (-[IFWebCoreBridge setScrollbarsVisible:]): Likewise. (-[IFWebCoreBridge isStatusBarVisisble]): Likewise. (-[IFWebCoreBridge setStatusBarVisible:]): Likewise. (-[IFWebCoreBridge setWindowFrame:]): Likewise. (-[IFWebCoreBridge window]): Likewise.
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebController.mm: (-[IFWebController setWindowContext:]): Setter for new WindowContext handler (-[IFWebController windowContext]): Likewise.
  • WebView.subproj/IFWebControllerPrivate.h:
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate dealloc]): Release window context.
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame frameNamed:]): Open new windows via WindowContext.

WebBrowser:

WebBrowser part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

  • BrowserDocument.m: (-[BrowserDocument init]): Set the WebController as it's own WindowContext too.
  • BrowserWindow.h:
  • BrowserWindow.m: (-[BrowserWindow _saveFrameIfAllowed]): Don't save the frame if the last (-[BrowserWindow setFrameWithoutAutosaving:]): Change window size and position but without saving the frame; if this is a size change and not just a move, avoid saving the frame until the next user resize. (-[BrowserWindow windowDidResize:]): More stuff for the above. (-[BrowserWindow isFavoritesBarVisible]): Implemented. (-[BrowserWindow setFavoritesBarVisible:]): Implemented. (-[BrowserWindow isStatusBarVisible]): Implemented. (-[BrowserWindow setStatusBarVisible:]): Implemented. (-[BrowserWindow isToolbarVisible]): Implemented. (-[BrowserWindow setToolbarVisible:]): Implemented.
  • WebController.h:
  • WebController.m: (-[BrowserWebController openNewWindowWithURL:]): Don't initially show the window even if no URL is set, so initial parameters can be set properly. (-[BrowserWebController areToolbarsVisible]): Implemented. (-[BrowserWebController setToolbarsVisible:]): Implemented. (-[BrowserWebController isStatusBarVisible]): Implemented. (-[BrowserWebController setStatusBarVisible:]): Implemented. (-[BrowserWebController window]): Implemented. (-[BrowserWebController setFrame:]): Implemented.

Jun 28, 2002:

4:53 PM Changeset in webkit [1475] by darin
  • 6 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.h: Renamed statusOfCache to patternColorLoadStatus for clarity.
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer copyWithZone:]): Add FIXME. (-[IFImageRenderer tileInRect:fromPoint:]): Add optimization for the case where a single draw of the image will cover the entire area to be tiled. Also add comments and make other small improvements.
3:32 PM Changeset in webkit [1474]
  • 2 copies
    34 deletes in tags/WebFoundation-6~8

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~8'.

3:32 PM Changeset in webkit [1473]
  • 2 copies
    34 deletes in tags/WebFoundation-6~7

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~7'.

3:32 PM Changeset in webkit [1472]
  • 2 copies
    34 deletes in tags/WebFoundation-6~6

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~6'.

3:32 PM Changeset in webkit [1471]
  • 2 copies
    34 deletes in tags/WebFoundation-6~5

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~5'.

3:32 PM Changeset in webkit [1470] by kocienda
  • 1 edit in branches/jaguar-branch/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-28 Kenneth Kocienda <​kocienda@apple.com>

Fix for these two bugs:

  1. Radar 2971291 (-[IFURLFileDatabase initWithPath:] leak)

Object now released in delloc.

  1. Radar 2968370 (Crash in Pictures channel)

I fixed the fact that load failure messages were not being moved over to
the one thread that can safely call into CFNetwork.

In the process of doing this, I cleaned up this internal interface:

-(void)_backgroundLoadFailedWithResultCode:(IFURLHandleResult)errorCode inDomain:(IFErrorCodeDomain)domain isTerminal:(BOOL)terminal;

is now:

-(void)_backgroundLoadFailedWithError:(IFError *)error;

  • CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandle _backgroundLoadFailedWithError:])
  • CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode)
  • CacheLoader.subproj/IFURLHandlePrivate.h:
  • CacheLoader.subproj/IFURLLoad.m: (-[IFURLLoad failedWithResultCode:inDomain:isTerminal:]) (initLoader) (-[IFURLLoad setError:]) (-[IFURLLoad performFailed]) (_handleLoadRequests) (_loadSweeper)
  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase dealloc])
  • WebFoundation.pbproj/project.pbxproj
2:13 PM Changeset in webkit [1469] by rjw
  • 16 edits in trunk

Use float character measurement to determine selection
region. Necessary to ensure accuracy of selection
region. First step towards weaning khtml off int
measurements.

  • khtml/rendering/font.cpp: (Font::floatWidth): (Font::floatCharacterWidth):
  • khtml/rendering/font.h:
  • khtml/rendering/render_text.cpp: (TextSlave::checkSelectionPoint):
  • kwq/KWQFontMetrics.mm: (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidth):
  • kwq/WebCoreTextRenderer.h:
  • kwq/qt/qfontmetrics.h:

Use float character measurement to determine selection
region. Necessary to ensure accuracy of selection
region. First step towards weaning khtml off int
measurements.

  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Cleaned up use of loadStatus.
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):
1:20 PM Changeset in webkit [1468] by cblu
  • 10 edits in trunk/WebKit

WebBrowser:

Bugs fixes for Downloads

  • DownloadMonitor.h:
  • DownloadMonitor.m: (-[DownloadMonitor init]): init totals ivars (-[DownloadMonitor _findEntryForView:]): added (-[DownloadMonitor _makeSelectedDownloadsPerformSelector:]): prepended a "_" (-[DownloadMonitor sheetDidDismiss:returnCode:contextInfo:]): cancel downloads before quit (-[DownloadMonitor _updateTotals]): added, updates totals ivars (-[DownloadMonitor validateUserInterfaceItem:]): simplified, reveal allowed only for 1 item (-[DownloadMonitor didDoubleClick]): added, calls reveal (-[DownloadMonitor openSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector (-[DownloadMonitor stopSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector (-[DownloadMonitor revealSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector
  • DownloadProgressEntry.m: (-[DownloadProgressEntry stop]): only stops active downloads (-[DownloadProgressEntry reveal]): allowed for items currently downloading
  • ListView.m: (-[ListView mouseDown:]): watch for double-click

WebKit:

  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient downloadHandler]): added (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): removed [downloadHandler cancel]
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource stopLoading]): call [downloadHandler cancel] here so clean up is done immediately.

Jun 27, 2002:

5:07 PM Changeset in webkit [1467] by cblu
  • 4 edits in trunk/WebCore

Added an APPLE_CHANGES to fix 2894742. The attributes of an EMBED tag
must override the attributes of PARAM tags.

  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
4:25 PM Changeset in webkit [1466] by rjw
  • 6 edits in trunk/WebKit

Fixed tiling of progressively loaded images.

  • WebCoreSupport.subproj/IFImageRenderer.h:
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer initWithSize:]): (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]): (-[IFImageRenderer loadStatus]): (-[IFImageRenderer tileInRect:fromPoint:]):
4:09 PM Changeset in webkit [1465] by rjw
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]): Fixed uninitialized variable warning. Compile being too aggressive, broke deployment build.
2:59 PM Changeset in webkit [1464] by cblu
  • 4 edits in trunk/WebKit

Fixed plug-in positioning.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView

initWithFrame:plugin:url:baseURL:mime:arguments:]): added some logging.

(-[IFPluginView setWindow]): Use the window's content view as the

guide for the port's coordinates. Also added a workaround for Java.

2:39 PM Changeset in webkit [1463] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-27 Kenneth Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2971291 (-[IFURLFileDatabase initWithPath:] leak)

Object now released in delloc.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase dealloc]):
2:05 PM Changeset in webkit [1462] by darin
  • 5 edits in trunk/WebKit

Fixed DOM tree viewer.

  • WebView.subproj/IFDOMNode.mm: (-[IFDOMNode initWithDOMNode:DOM::]): A typo got in here somehow, leading to an infinite loop.
2:01 PM Changeset in webkit [1461] by darin
  • 4 edits in trunk/WebCore
  • fixed 2973342 -- copied text seems to have an extra blank line between paragraphs
  • khtml/khtml_part.cpp: (KHTMLPart::selectedText): Get rid of code that was adding an extraneous newline at the ends of various types of nodes, including <P>.
1:22 PM Changeset in webkit [1460] by darin
  • 4 edits
    2 deletes in trunk/WebKit
  • fixed 2973212 -- bad arg string != nil in _IF_URLWithString
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _startLoading:]): Get rid of essentially-dead code that computed but did not use a URL. Also order operations so that we first set the flag to say that we're loading, then tell the location change handler, and only then ask for the actual I/O to being.
  • WebView.subproj/IFBaseLocationChangeHandler.h: Removed.
  • WebView.subproj/IFBaseLocationChangeHandler.m: Removed.
1:19 PM Changeset in webkit [1459] by darin
  • 10 edits in trunk/WebCore

Fix Java. My changes this morning broke it.

  • khtml/rendering/render_applet.cpp: (RenderApplet::processArguments): Re-add required APPLE_CHANGES. Pass arguments to KJavaAppletWidget::processArguments.
  • kwq/khtml/java/kjavaappletwidget.h: Added KJavaAppletWidget::processArguments.
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::processArguments): Added.

Some QFont fixes.

  • kwq/qt/qfont.h: Remove unused setPixelSizeFloat.
  • kwq/KWQFont.mm: Change to keep family names in a set. Since there are only a small number of family names ever encountered, this is a bit of a memory win. (QFont::QFont): Don't retain the family name. (QFont::~QFont): Don't release the family name. (QFont::setFamily): Put the family name in a set, and use the one from the set. (QFont::operator=): Don't retain or release. (QFont::operator==): Use == to compare the name.
12:28 PM Changeset in webkit [1458]
  • 3 copies in tags/Alexander-10

This commit was manufactured by cvs2svn to create tag 'Alexander-10'.

12:28 PM Changeset in webkit [1457] by sheridan
  • 8 edits in trunk

Alex-10 version

11:14 AM Changeset in webkit [1456] by rjw
  • 12 edits in trunk

Method name changes in preparation for fixing
TextSlave::checkSelectionPoint().

  • kwq/WebCoreTextRenderer.h:

Method name changes in preparation for fixing
TextSlave::checkSelectionPoint(). Stubbed
only, no support for new parameters yet.

  • Misc.subproj/IFStringTruncator.m: (+[IFStringTruncator centerTruncateString:toWidth:withFont:]):
  • WebCoreSupport.subproj/IFTextRenderer.h:
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]): (-[IFTextRenderer widthForCharacters:length:]): (-[IFTextRenderer widthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]):
9:29 AM Changeset in webkit [1455] by rjw
  • 9 edits in trunk

Removed old methods and references.

  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawString:atPoint:withColor:]): (-[IFTextRenderer slowDrawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:attemptFontSubstitution:]): (-[IFTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]): Fixed final fragment rendering glitch.

Removed calls to old method.

  • kwq/KWQPainter.mm: (QPainter::drawText):
  • kwq/WebCoreTextRenderer.h: Removed old methods.
9:17 AM Changeset in webkit [1454] by darin
  • 23 edits in trunk

WebCore:

  • khtml/rendering/render_applet.cpp: Remove include of <iostream.h> to avoid bloat. (RenderApplet::RenderApplet): Remove APPLE_CHANGES. (RenderApplet::processArguments): Remove APPLE_CHANGES. This file is now back to 100% the same as the KDE original.
  • kwq/khtml/java/kjavaappletwidget.h: Added a bit of stuff so we match the interface of the KDE original and don't need APPLE_CHANGES.
  • kwq/KWQKJavaAppletWidget.mm: Remove include of <iostream.h> to avoid bloat. (KJavaAppletWidget::KJavaAppletWidget): Update for parameters that match the KDE original. (KJavaAppletWidget::~KJavaAppletWidget): Added. (KJavaAppletWidget::setBaseURL): Added. (KJavaAppletWidget::setParameter): Put strings into an NSMutableDictionary. (KJavaAppletWidget::showApplet): Use the new baseURL and parameters dictionary.
  • kwq/WebCoreViewFactory.h: Add baseURL parameter.
  • kwq/WebCoreViewFactory.m: (-[WebCoreViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]): Add baseURL parameter.
  • kwq/kdecore/kurl.h: Fix NSURL definition to fit idiom.
  • kwq/qt/qmap.h: Added the const version of the [] operator.
  • khtml/ecma/kjs_navigator.cpp: Tweak whitespace.
  • khtml/html/html_documentimpl.cpp: Tweak to make it a little closer to original.
  • kwq/KWQKCookieJar.h: Reduce includes.
  • kwq/KWQKCookieJar.mm: Move includes in here.
  • kwq/WebCoreCookieAdapter.h: Fix comment that emacs munged.

WebKit:

  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]): Pass baseURL as a separate parameter.
  • WebView.subproj/IFBaseLocationChangeHandler.m: Fix a typo. I think this file might be unneeded, but I won't delete it until I hear from Chris.
8:54 AM Changeset in webkit [1453] by rjw
  • 4 edits in trunk/WebKit

Fix selection in 'slow' code path (non-base characters and font substitution).

  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer slowDrawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:attemptFontSubstitution:]):
8:25 AM Changeset in webkit [1452] by rjw
  • 4 edits in trunk/WebKit

Implemented auto scrolling.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView mouseDragged:]):
8:20 AM Changeset in webkit [1451] by rjw
  • 9 edits in trunk

Implement selectAll.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView selectAll:]):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge selectAll]): Select all using the part.
6:52 AM Changeset in webkit [1450] by rjw
  • 2 edits in trunk/WebKit

Forgot to commit ChangeLog.

2:42 AM Changeset in webkit [1449] by mjs
  • 12 edits
    8 adds in trunk

WebCore:

WebCore part of fixes for JavaScript cookie bugs:

2943749 - JavaScript navigator.cookieEnabled property is always "true"
2856039 - JavaScript document.cookies property is not implemented

Thereby also fixing:

2944378 - Trying to log into my Yahoo web mail account sent
Alexander into a loop

  • kwq/KWQKCookieJar.h: Added.
  • kwq/KWQKCookieJar.mm: Added. (KWQKCookieJar::cookie): C++ veneer over WebCoreCookieAdapter call. (KWQKCookieJar::setCookie): Likewise. (KWQKCookieJar::cookieEnabled): Likewise.
  • kwq/Makefile.am: Add new files to build.
  • kwq/WebCoreCookieAdapter.h: Added.
  • kwq/WebCoreCookieAdapter.m: Added. (+[WebCoreCookieAdapter sharedAdapter]): Method to return shared instance, al la the WebCoreFactory classes. (-[WebCoreCookieAdapter init]): Establish self as shared instance. (-[WebCoreCookieAdapter cookiesEnabled]): No-op implementation. (-[WebCoreCookieAdapter cookiesForURL:]): Likewise. (-[WebCoreCookieAdapter setCookies:forURL:]): Likewise.
  • WebCore.exp: Export WebCoreCookieAdapter class.
  • khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): Call appropriate KWQCookieJar method.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::cookie): Call appropriate KWQCookieJar method. (HTMLDocumentImpl::setCookie): Likewise

WebKit:

WebKit part of fixes for JavaScript cookie bugs:

2943749 - JavaScript navigator.cookieEnabled property is always "true"
2856039 - JavaScript document.cookies property is not implemented

Thereby also fixing:

2944378 - Trying to log into my Yahoo web mail account sent
Alexander into a loop

  • WebCoreSupport.subproj/IFCookieAdapter.h: Added.
  • WebCoreSupport.subproj/IFCookieAdapter.m: Added. (+[IFCookieAdapter createSharedAdapter]): Set up an instance of IFCookieAdapter as the WebCoreCookieAdapter shared instance. (-[IFCookieAdapter cookiesEnabled]): Implement in terms of WebFoundation stuff. (-[IFCookieAdapter cookiesForURL:]): Likewise. (-[IFCookieAdapter setCookies:forURL:]): Likewise.
  • WebKit.pbproj/project.pbxproj: Add new files to build.
  • WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): Hook up the cookie adapter just like the various factory classes.
12:29 AM Changeset in webkit [1448] by cblu
  • 15 edits in trunk

WebCore:

Fix to support sending PARAM tags to the Java plug-in.

  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet): removed APPLE_CHANGES (RenderApplet::layout): removed APPLE_CHANGES
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): removed setView (KJavaAppletWidget::showApplet): call setView here
  • kwq/WebCoreViewFactory.h:
  • kwq/WebCoreViewFactory.m: (-[WebCoreViewFactory viewForJavaAppletWithFrame:andArguments:]): renamed
  • kwq/khtml/java/kjavaappletwidget.h: added KJavaApplet

WebKit:

Support for Java.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:baseURL:mime:arguments:]): set DOCBASE argument
  • WebCoreSupport.subproj/IFWebCoreViewFactory.m: (-[IFWebCoreViewFactory viewForJavaAppletWithFrame:andArguments:]): renamed

WebBrowser:

Removed some logging.

  • DownloadMonitor.m: (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:complete:]):
Note: See TracTimeline for information about the timeline view.