⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 2, 2002:

9:43 PM Changeset in webkit [1502] by cblu
  • 8 edits in trunk/WebKit

WebKit:

Added IFFileURLPolicyReveal. This makes things a little clearer for the client.

  • WebView.subproj/IFWebControllerPolicyHandler.h:
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _shouldShowDataSource:]): support for IFFileURLPolicyReveal.

WebBrowser:

Added IFFileURLPolicyReveal. This makes things a little clearer for the client.

  • WebController.m: (-[BrowserWebController unableToImplementURLPolicyForURL:error:]): removed old comments (-[BrowserWebController fileURLPolicyForMIMEType:dataSource:isDirectory:]): use IFFileURLPolicyReveal for files we don't open and IFFileURLPolicyOpenExternally for directories
9:38 PM Changeset in webkit [1501] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]): Fixed a syntax error caused by a "just before committing" edit.
9:30 PM Changeset in webkit [1500] by darin
  • 4 edits in trunk/WebKit
  • fixed 2952837 -- image not rendered if height or width attributes specified incorrectly
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]): Set the size of both the image and the image representation.
8:52 PM Changeset in webkit [1499] by cblu
  • 8 edits in trunk/WebKit

Can't call startLoading on a frame if setProvisionalDataSource

returned NO.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView

loadURL:inTarget:withNotifyData:andHandleAttributes:]):

  • WebCoreSupport.subproj/IFWebCoreFrame.m: (-[IFWebCoreFrame loadURL:attributes:flags:withParent:]):
  • WebView.subproj/IFWebView.mm: (-[IFWebView performDragOperation:]):
7:49 PM Changeset in webkit [1498] by cblu
  • 5 edits in trunk/WebKit

Fixed asseration failure caused by an iframe not having a correct mime type.
We now assume that local files without extensions are html files.

  • WebView.subproj/IFWebControllerPrivate.mm: (+[IFWebController _MIMETypeForFile:]):
5:52 PM Changeset in webkit [1497] by cblu
  • 32 edits
    6 adds in trunk/WebKit

WebFoundation:

  • CacheLoader.subproj/IFURLCacheLoaderConstants.h: removed IFErrorCode enum
  • Misc.subproj/IFError.h:
  • Misc.subproj/IFError.m: (classInitialize): removed WebKit error descriptions (-[IFError description]): no changes (+[IFError addErrorsFromDictionary:]): added, allows WebKit to register errors

WebKit:

  • Moved all policy methods to IFWebControllerPolicyHandler.h
  • Moved all file URL error checking to WebKit
  • Implemented file URL policy methods
  • Renamed IFContentPolicyOpenExternally to IFContentPolicySaveAndOpenExternally
  • Misc.subproj/IFWebKitErrors.h: Added.
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFLocationChangeHandler.h: removed content policy stuff
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): IFContentPolicySaveAndOpenExternally rename (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): call the policy handler for content policy stuff
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebController.mm: (-[IFWebController haveContentPolicy:andPath:forDataSource:]): sends a unableToImplementContentPolicy: (+[IFWebController canShowFile:]): now calls _MIMETypeForFile
  • WebView.subproj/IFWebControllerPolicyHandler.h: Added.
  • WebView.subproj/IFWebControllerPrivate.h:
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): IFContentPolicySaveAndOpenExternally

WebBrowser:

  • Moved all policy methods to IFWebControllerPolicyHandler
  • Moved all file URL error checking to WebKit
  • Implemented file URL policy methods
  • Renamed IFContentPolicyOpenExternally to IFContentPolicySaveAndOpenExternally
  • BrowserDocument.m: (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): load frame only if setProvisionalDataSource returns YES
  • BrowserWindow.h:
  • BrowserWindow.m: (-[BrowserWindow goToToolbarLocation:]): removed file URL error checking
  • DownloadMonitor.m: (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:complete:]): minor clean-up
  • LocationChangeHandler.m: removed content policy methods
  • WebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]): IFContentPolicySaveAndOpenExternally
3:44 PM Changeset in webkit [1496] by rjw
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFRenderNode.mm: (-[IFRenderNode initWithRenderObject:khtml::]): Fixed regression that prevented showing of nodes in subframes.
2:45 PM Changeset in webkit [1495] by darin
  • 4 edits in trunk/WebKit

WebKit:

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView setWindow]), (-[IFPluginView start]), (-[IFPluginView stop]): Fix unused variable issue that affects deployment builds.

WebBrowser:

  • LocationChangeHandler.m: Improve comments.
2:28 PM Changeset in webkit [1494] by sullivan
  • 4 edits in trunk/WebKit

Remove unnecessary code to fill with white from here; this code
path has changed. Now it just bails out early in the case where
there's no widget.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView drawRect:]):
1:57 PM Changeset in webkit [1493] by sullivan
  • 4 edits in trunk/WebKit

Made IFWebView fill with white when there's no document view. This fixes:

  • 2978210 -- problems with "hide status bar"
  • 2978742 -- Resizing initially-empty Alexander window results in garbage in window
  • WebView.subproj/IFWebView.mm: (-[IFWebView drawRect:]):
10:39 AM Changeset in webkit [1492] by darin
  • 4 edits in trunk/WebCore
  • fixed 2978806 -- Crash going to ebay home page
  • khtml/ecma/kjs_navigator.cpp: (PluginBase::PluginBase): Check to be sure that we are not at the end of the "tokens" collection before dereferencing the iterator.
8:16 AM Changeset in webkit [1491] by darin
  • 5 edits in trunk/WebKit
  • WebView.subproj/IFMainURLHandleClient.mm: Fix comment.
8:12 AM Changeset in webkit [1490] by darin
  • 4 edits in trunk/WebKit
  • fixed 2975790 - Ads on salon.com scribble all over page
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView setUpWindowAndPort]): New, sets up the window, but does not call NPP_SetWindow again. (-[IFPluginView setWindow]): Call [setUpWindowAndPort] then call NPP_SetWindow. (-[IFPluginView start]): Register for changes to the bounds or frame of any of our superviews, not just one particular one. Also, don't bother to register for notification when the window resizes. Finally, use the constants for the names of the notifications, not literal strings. (-[IFPluginView layout]): Just use [setUpWindowAndPort]; no need for a new call to NPP_SetWindow. (-[IFPluginView viewHasMoved:]): Just use [setUpWindowAndPort]; no need for a new call to NPP_SetWindow.

Jul 1, 2002:

7:23 PM Changeset in webkit [1489] by mjs
  • 11 edits
    2 adds in trunk

WebCore:

Fixed Radar 2953256 - JavaScript window.moveTo() and
window.moveBy() methods do not work

This was done by creating a class to wrap an NSWindow as a
QWidget, which should be useful for many other window-related
features.

  • kwq/KWQWidget.mm: (QWidget::x): Implement in terms of the virtual frameGeometry() method. (QWidget::y): Likewise. (QWidget::width): Likewise. (QWidget::height): Likewise. (QWidget::size): Likewise. (QWidget::pos): Likewise. (QWidget::topLevelWidget): Implement by creating a KWQWindowWidget (QWidget::isVisible): Added FIXME comment.
  • kwq/KWQWindowWidget.h: Added.
  • kwq/KWQWindowWidget.mm: Added. (KWQWindowWidget::fromNSWindow): Static method that maintains a dictionary of top-level widgets, and creates them on demand. (deleteOnWindowClose): Delete top level widget on close. (KWQWindowWidget::KWQWindowWidget): (KWQWindowWidget::~KWQWindowWidget): (KWQWindowWidget::sizeHint): Implemented using NSWindow. (KWQWindowWidget::minimumSizeHint): Likewise. (KWQWindowWidget::frameGeometry): Likewise. (KWQWindowWidget::topLevelWidget): Likewise. (KWQWindowWidget::mapToGlobal): Likewise. (KWQWindowWidget::mapFromGlobal): Likewise. (KWQWindowWidget::setCursor): No-op implementation. (KWQWindowWidget::internalSetGeometry): Implemented using NSWindow.
  • kwq/Makefile.am: Add new files to build.
  • kwq/qt/qwidget.h: Make methods virtual as needed.

WebKit:

  • WebView.subproj/IFWebView.mm: (-[IFWebView window]): If the view hasn't been added to a window yet, get the window from the WindowContext.
4:31 PM Changeset in webkit [1488] by rjw
  • 5 edits in trunk/WebKit

i * WebView.subproj/IFMainURLHandleClient.mm:

(-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]):
Ensure that _didStopLoading is called for both error case and
non-error case.

4:07 PM Changeset in webkit [1487] by rjw
  • 5 edits in trunk/WebKit
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): A completion message was being sent, as well as an error message. This, no doubt confused Alexander. No only send either the final error message or the completion message.
2:17 PM Changeset in webkit [1486] by darin
  • 8 edits in trunk/WebKit

Ken fixed the load message sequencing problem in WebFoundation, so now we can
go back to the original versions of the asserts.

  • WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient dealloc]): (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): Roll out the stuff that's ifdef'd and marked with bug 2954901.
12:31 PM Changeset in webkit [1485] by darin
  • 8 edits in trunk/WebKit
  • WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]): After a closer reading of the NSScrollView source code, I see that we don't need to explicitly do tile or setNeedsDisplay: because the setters take care of that, so I made this simpler. (-[IFDynamicScrollBarsView reflectScrolledClipView:]): Replace the anti- recursion hack that I erroneously removed earlier.
  • WebView.subproj/IFTextView.h: Removed the isRTF flag.
  • WebView.subproj/IFTextView.m: (-[IFTextView provisionalDataSourceChanged:]): Do nothing here. (-[IFTextView dataSourceUpdated:]): Check the MIME type here.
12:01 PM Changeset in webkit [1484] by rjw
  • 6 edits in trunk/WebKit

Fixed 2976913.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView layout]): Augmented debugging info. (-[IFHTMLView setNeedsDisplay:]): Augmented debugging info. (-[IFHTMLView setNeedsLayout:]): Removed overload of this method to also set display flag. Why was this added? (-[IFHTMLView setNeedsToApplyStyles:]): Augmented debugging info. (-[IFHTMLView drawRect:]): Augmented debugging info.
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _timedLayout:]): If the view size is zero (width or height) force a layout now, rather than depending on the lazy layout that will happen in display. If the view size is 0,0 the AppKit will optimize out the display.
11:15 AM Changeset in webkit [1483] by cblu
  • 4 edits in trunk/WebKit

WebKit:

Minor cleanup

  • Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:]): (-[IFNullPluginView dealloc]):

WebBrowser:

Add support for delete, clear and stop menu items and keyboard shortcuts
in Downloads.

  • DownloadMonitor.m: (-[DownloadMonitor validateUserInterfaceItem:]): (-[DownloadMonitor stopLoading:]): added (-[DownloadMonitor clear:]): added (-[DownloadMonitor didDoubleClick]): (-[DownloadMonitor didHitDeleteKey]): added
  • ListView.m: (-[ListView keyDown:]): look for delete key (-[ListView validateUserInterfaceItem:]):
  • WebBrowser.pbproj/project.pbxproj:
10:00 AM Changeset in webkit [1482] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-07-01 Kenneth Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2967062 (alexander has fit on exit)

We no longer sync the contents of the cache to disk at quit time. I also
shortented the amount of time of disk cache waits before
declaring "idle time" from 5 seconds to 1 second. This might
need some tuning, but it should keep the disk cache queue with i
writes pending from getting too long, while not stepping on more i
time-critical things like page rendering.

  • CacheLoader.subproj/IFURLLoadManager.m: (-[IFURLLoadManager initWithDefaultStack]) (-[IFURLLoadManager loadDidFinish:])
  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase dealloc]) (-[IFURLFileDatabase setTimer])
9:19 AM Changeset in webkit [1481] by darin
  • 16 edits in trunk

top level:

  • Tools/CommitLogEditor/.cvsignore: Added.

WebCore:

  • khtml/css/cssparser.cpp:
  • khtml/misc/htmlhashes.cpp: Remove workaround for a PFE bug that no longer affects us.
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: Remove some unneeded APPLE_CHANGES.
  • WebCore.exp: One less symbol to export.

WebKit:

  • Plugins.subproj/IFPlugin.m: (-[IFPlugin _getPluginInfoForResourceFile:]): Fix off-by one error that would cause a memory trasher if we had a 255-character string.
  • WebView.subproj/IFHTMLView.mm:
  • WebView.subproj/IFRenderNode.mm: Touch these files so we don't have to do a full build of WebKit for my WebCore changes.
5:35 AM Changeset in webkit [1480] by mjs
  • 7 edits in trunk/WebKit

WebKit:

Build fixes (don't know why a plain build didn't catch these):

  • Plugins.subproj/IFPluginView.mm: openNewWindowWithURL: is not a method of the controller any more, nor are the status-related calls.
  • WebView.subproj/IFWebController.h: Un-ifdef the status calls.

WebBrowser:

Build fixes:

  • BrowserDocument.h,
  • BrowserDocument.m: (-[BrowserDocument highestPriorityStatusMessage]): Make this public. (-[BrowserDocument _updateStatusInBrowserWindow]): Adjust for rename.
  • WebController.m: (-[BrowserWebController statusTextForDataSource:]): Implemented.
1:48 AM Changeset in webkit [1479] by mjs
  • 4 edits in trunk/WebKit

WebKit:

Part of fix for Radar 2976618 - links targeting _blank hit
assertion trying to set provisional data source

  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame frameNamed:]): Show the window.

WebBrowser:

Part of fix for Radar 2976618 - links targeting _blank hit
assertion trying to set provisional data source

  • BrowserDocument.m: (-[BrowserDocument setShouldStartEmpty]): Ensure the window exists, so that there are a frame and web view ready in time.
1:18 AM Changeset in webkit [1478] by mjs
  • 4 edits in trunk/WebKit

Fix Radar 2953256 - Auth sheet appears detached when clicking
directly on auth link with Alex not running

  • Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels frontmostWindowLoadingURL:]): Don't consider windows that are not visible.

Jun 29, 2002:

10:31 PM Changeset in webkit [1477] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Fix calculation of oneTileRect. I think this is finally correct now.
4:28 PM Changeset in webkit [1476] by mjs
  • 26 edits in trunk

WebCore:

WebCore part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

  • kwq/WebCoreBridge.h: Add new calls needed for window size/position/feature getting and setting.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Set properties on window after creating it using new bridge calls; make it visible.
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Support scrollbars feature too.
  • kwq/kparts/browserextension.h: Include scrollbar setting stuff.

WebKit:

WebKit part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

Also, renamed IFScriptContextHandler protocol to IFWindowContext,
and made it a settable handler like the others rather than
something implemented by the controller, so it can be used w/o
subclassing.

  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge openNewWindowWithURL:]): Forward to the WindowContext. (-[IFWebCoreBridge areToolbarsVisisble]): Likewise. (-[IFWebCoreBridge setToolbarsVisible:]): Likewise. (-[IFWebCoreBridge areScrollbarsVisible]): Likewise. (-[IFWebCoreBridge setScrollbarsVisible:]): Likewise. (-[IFWebCoreBridge isStatusBarVisisble]): Likewise. (-[IFWebCoreBridge setStatusBarVisible:]): Likewise. (-[IFWebCoreBridge setWindowFrame:]): Likewise. (-[IFWebCoreBridge window]): Likewise.
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebController.mm: (-[IFWebController setWindowContext:]): Setter for new WindowContext handler (-[IFWebController windowContext]): Likewise.
  • WebView.subproj/IFWebControllerPrivate.h:
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate dealloc]): Release window context.
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame frameNamed:]): Open new windows via WindowContext.

WebBrowser:

WebBrowser part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

  • BrowserDocument.m: (-[BrowserDocument init]): Set the WebController as it's own WindowContext too.
  • BrowserWindow.h:
  • BrowserWindow.m: (-[BrowserWindow _saveFrameIfAllowed]): Don't save the frame if the last (-[BrowserWindow setFrameWithoutAutosaving:]): Change window size and position but without saving the frame; if this is a size change and not just a move, avoid saving the frame until the next user resize. (-[BrowserWindow windowDidResize:]): More stuff for the above. (-[BrowserWindow isFavoritesBarVisible]): Implemented. (-[BrowserWindow setFavoritesBarVisible:]): Implemented. (-[BrowserWindow isStatusBarVisible]): Implemented. (-[BrowserWindow setStatusBarVisible:]): Implemented. (-[BrowserWindow isToolbarVisible]): Implemented. (-[BrowserWindow setToolbarVisible:]): Implemented.
  • WebController.h:
  • WebController.m: (-[BrowserWebController openNewWindowWithURL:]): Don't initially show the window even if no URL is set, so initial parameters can be set properly. (-[BrowserWebController areToolbarsVisible]): Implemented. (-[BrowserWebController setToolbarsVisible:]): Implemented. (-[BrowserWebController isStatusBarVisible]): Implemented. (-[BrowserWebController setStatusBarVisible:]): Implemented. (-[BrowserWebController window]): Implemented. (-[BrowserWebController setFrame:]): Implemented.

Jun 28, 2002:

4:53 PM Changeset in webkit [1475] by darin
  • 6 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.h: Renamed statusOfCache to patternColorLoadStatus for clarity.
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer copyWithZone:]): Add FIXME. (-[IFImageRenderer tileInRect:fromPoint:]): Add optimization for the case where a single draw of the image will cover the entire area to be tiled. Also add comments and make other small improvements.
3:32 PM Changeset in webkit [1474]
  • 2 copies
    34 deletes in tags/WebFoundation-6~8

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~8'.

3:32 PM Changeset in webkit [1473]
  • 2 copies
    34 deletes in tags/WebFoundation-6~7

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~7'.

3:32 PM Changeset in webkit [1472]
  • 2 copies
    34 deletes in tags/WebFoundation-6~6

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~6'.

3:32 PM Changeset in webkit [1471]
  • 2 copies
    34 deletes in tags/WebFoundation-6~5

This commit was manufactured by cvs2svn to create tag
'WebFoundation-6~5'.

3:32 PM Changeset in webkit [1470] by kocienda
  • 1 edit in branches/jaguar-branch/WebKit/Misc.subproj/WebFileDatabase.m

2002-06-28 Kenneth Kocienda <​kocienda@apple.com>

Fix for these two bugs:

  1. Radar 2971291 (-[IFURLFileDatabase initWithPath:] leak)

Object now released in delloc.

  1. Radar 2968370 (Crash in Pictures channel)

I fixed the fact that load failure messages were not being moved over to
the one thread that can safely call into CFNetwork.

In the process of doing this, I cleaned up this internal interface:

-(void)_backgroundLoadFailedWithResultCode:(IFURLHandleResult)errorCode inDomain:(IFErrorCodeDomain)domain isTerminal:(BOOL)terminal;

is now:

-(void)_backgroundLoadFailedWithError:(IFError *)error;

  • CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandle _backgroundLoadFailedWithError:])
  • CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode)
  • CacheLoader.subproj/IFURLHandlePrivate.h:
  • CacheLoader.subproj/IFURLLoad.m: (-[IFURLLoad failedWithResultCode:inDomain:isTerminal:]) (initLoader) (-[IFURLLoad setError:]) (-[IFURLLoad performFailed]) (_handleLoadRequests) (_loadSweeper)
  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase dealloc])
  • WebFoundation.pbproj/project.pbxproj
2:13 PM Changeset in webkit [1469] by rjw
  • 16 edits in trunk

Use float character measurement to determine selection
region. Necessary to ensure accuracy of selection
region. First step towards weaning khtml off int
measurements.

  • khtml/rendering/font.cpp: (Font::floatWidth): (Font::floatCharacterWidth):
  • khtml/rendering/font.h:
  • khtml/rendering/render_text.cpp: (TextSlave::checkSelectionPoint):
  • kwq/KWQFontMetrics.mm: (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidth):
  • kwq/WebCoreTextRenderer.h:
  • kwq/qt/qfontmetrics.h:

Use float character measurement to determine selection
region. Necessary to ensure accuracy of selection
region. First step towards weaning khtml off int
measurements.

  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Cleaned up use of loadStatus.
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[IFTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):
1:20 PM Changeset in webkit [1468] by cblu
  • 10 edits in trunk/WebKit

WebBrowser:

Bugs fixes for Downloads

  • DownloadMonitor.h:
  • DownloadMonitor.m: (-[DownloadMonitor init]): init totals ivars (-[DownloadMonitor _findEntryForView:]): added (-[DownloadMonitor _makeSelectedDownloadsPerformSelector:]): prepended a "_" (-[DownloadMonitor sheetDidDismiss:returnCode:contextInfo:]): cancel downloads before quit (-[DownloadMonitor _updateTotals]): added, updates totals ivars (-[DownloadMonitor validateUserInterfaceItem:]): simplified, reveal allowed only for 1 item (-[DownloadMonitor didDoubleClick]): added, calls reveal (-[DownloadMonitor openSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector (-[DownloadMonitor stopSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector (-[DownloadMonitor revealSelectedDownloads:]): calls _makeSelectedDownloadsPerformSelector
  • DownloadProgressEntry.m: (-[DownloadProgressEntry stop]): only stops active downloads (-[DownloadProgressEntry reveal]): allowed for items currently downloading
  • ListView.m: (-[ListView mouseDown:]): watch for double-click

WebKit:

  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient downloadHandler]): added (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): removed [downloadHandler cancel]
  • WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource stopLoading]): call [downloadHandler cancel] here so clean up is done immediately.
Note: See TracTimeline for information about the timeline view.