Timeline



Jul 5, 2002:

11:06 AM Changeset in webkit [1516] by darin
  • 10 edits in trunk/WebKit

Fix crashes I saw with zombies enabled caused by messing with windows that are
in the process of being destroyed.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView start]): Remove windowWillClose notification because we use viewDidMoveToWindow instead. (-[IFPluginView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
  • WebView.subproj/IFHTMLViewPrivate.h: Need a boolean flag to tell window changes before the first time we are installed from window changes afterward.
  • WebView.subproj/IFImageView.m: (-[IFImageView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.

Jul 4, 2002:

6:15 PM Changeset in webkit [1515] by mjs
  • 5 edits in trunk/WebCore

Say "Go to" instead of "Link to" for links that won't open a new
window. Also, the code is now set up to change the status text
when modifier keys are pressed, but the code is disabled for now
because it's impossible to do reliably.

  • khtml/khtml_part.cpp: (KHTMLPart::overURL): (KHTMLPart::khtmlMouseMoveEvent):
  • khtml/khtml_part.h:
6:08 PM Changeset in webkit [1514] by mjs
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView mouseMovedNotification:]): Pass the modifier flags along for mouse move events.
1:21 PM Changeset in webkit [1513] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

  • WebView.subproj/IFDynamicScrollBarsView.h: Updated FIXME to mention bug number.

WebBrowser:

  • finished a few details for 2953570 and 2953580 -- Open and Reveal in Downloads window don't handle missing-file case well
  • fixed 2981774 -- Status bar text not centered vertically
  • removed vestiges of ancient mechanism for swapping browser window view between webview & search modes
  • English.lproj/Browser.nib: Made the status bar a few pixels shorter. We may decide that it looks bad for it to be a different height than the favorites bar, but Don wanted to try this. Also made IFWebView a direct subview of the window's contentView, and eliminated the extra views that were part of the ancient web/search mode mechanism.
  • BrowserWindow.h: Removed tabView outlet.
  • BrowserWindow.m: (-[BrowserWindow toggleFavoritesBarWithAnimation:]): (-[BrowserWindow toggleStatusBarWithAnimation:]): Made these methods use webView instead of tabView.
  • DownloadMonitor.m: (-[DownloadMonitor _canOpenSelectedDownloads]): (-[DownloadMonitor _canStopSelectedDownloads]): (-[DownloadMonitor _canRevealSelectedDownloads]): (-[DownloadMonitor _canForgetSelectedDownloads]): Renamed these from "_totalSelectedAndXXXXable" and made them return BOOLs rather than ints, since that's all the callers cared about. Made them (except _canReveal) return as soon as a single valid entry is found (_canReveal has to make sure there is exactly one valid entry). Made _canOpen and _canReveal return YES even if file doesn't exist, so that the user will get the explanatory message if they click on Open or Reveal in this case.

(-[DownloadMonitor validateUserInterfaceItem:]):
Updated for method name and return-value changes; restructured so that it returns
as soon as the right selector is checked, rather than continuing to check against
other selectors.

(-[DownloadMonitor _showMissingFileErrorForOperation:andFile:]): Removed this
method; it was constructing messages using substitution patterns that might
not work in other languages.

(-[DownloadMonitor openSelectedDownloads:]):
Made the error message handle the multiple-missing-files case properly; let
all openable items be opened regardless of how many unopenable items there are
(formerly bailed at the first unopenable item). Moved sheet-displaying code
for this case into here.

(-[DownloadMonitor revealSelectedDownloads:]): Moved sheet-displaying code
for this case into here.

Jul 3, 2002:

3:58 PM Changeset in webkit [1512] by cblu
  • 8 edits in trunk/WebKit
  • Fix for 2975750
  • Removed Java workaround since that will be fixed soon.
  • Plugins.subproj/IFPlugin.h:
  • Plugins.subproj/IFPlugin.m: (-[IFPlugin _openResourceFile]): added (-[IFPlugin _closeResourceFile:]): added (-[IFPlugin _getPluginInfo]): rename (-[IFPlugin initWithPath:]): simplified (-[IFPlugin load]): calls _openResourceFile (-[IFPlugin unload]): calls _closeResourceFile
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView setUpWindowAndPort]): removed Java workaround
3:18 PM Changeset in webkit [1511] by darin
  • 4 edits in trunk/WebKit

top level:

  • Site/Internal/Design/IFRenamings.txt: Update a bit more, preparing for the team to review.

WebKit:

  • Misc.subproj/IFException.h: Use Objective C header style rather than plain C.

WebBrowser:

  • NSViewAdditions.h:
  • NSViewAdditions.m: Change name of this category to match the file name to smooth things over for the IF -> Web renaming.
12:34 PM Changeset in webkit [1510] by darin
  • 5 edits in trunk/WebCore

A small KURL speed improvement.

  • khtml/misc/loader.cpp: (Cache::requestImage): (Cache::requestStyleSheet): (Cache::requestScript): Don't do the isMalformed check, because it's expensive and has no clear benefit. There's no harm in caching null results for malformed URLs.
  • kwq/KWQKURL.mm: (KURL::KURL): Make the default constructor faster by not running all the normalize code on the empty string.
11:30 AM Changeset in webkit [1509]
  • 3 copies in tags/Alexander-11

This commit was manufactured by cvs2svn to create tag 'Alexander-11'.

11:30 AM Changeset in webkit [1508] by sheridan
  • 8 edits in trunk

Alex-11 and 0.4 versions & changelog markers

9:06 AM Changeset in webkit [1507] by darin
  • 7 edits in trunk/WebKit
  • Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler finishedLoading]):
  • WebView.subproj/IFWebController.h: A couple places where it still said IFContentPolicyOpenExternally.
5:20 AM Changeset in webkit [1506] by mjs
  • 17 edits in trunk

WebCore:

WebCore part of fixes for:

Radar 2950616 - JavaScript window.screenX and window.screenY always return -1
Radar 2950614 - JavaScript window.screenLeft and window.screenTop
properties are unimplemented
Radar 2950609 - JavaScript window.outerHeight and
window.outerWidth properties always return 0

  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (Window::get): Make ScreenLeft and ScreenTop synonyms for ScreenX and ScreenY respectively.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::setView): Set the real part's view too.
  • kwq/kdecore/kwin.h: Remove unneeded fields.
  • kwq/KWQKWin.mm: (KWin::info): Implemented.
  • kwq/qt/qwidget.h:
  • kwq/KWQWidget.mm: (QWidget::winId): Return long instead of int, to make sure there is room for a pointer even on 64-bit architectures. (QWidget::mapToGlobal): Use the top level widget to map.

WebKit:

WebKit part of fixes for:

Radar 2950616 - JavaScript window.screenX and window.screenY always return -1
Radar 2950614 - JavaScript window.screenLeft and window.screenTop
properties are unimplemented
Radar 2950609 - JavaScript window.outerHeight and
window.outerWidth properties always return 0

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Pass the real document view to the newly created bridge, since it will be ready by now and is needed by JavaScript.
4:18 AM Changeset in webkit [1505] by mjs
  • 4 edits in trunk/WebKit
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView status:]): Fix build problem. Why doesn't compiling catch these more reliably?
1:59 AM Changeset in webkit [1504] by rjw
  • 13 edits in trunk
  • kwq/KWQScrollView.mm: (QScrollView::addChild): Fixed regression that caused IFWebView frame origin to sometimes never be set correctly. (khtml sets the x origin to -500000 during initialization, and it was never getting set correctly). This problem manifested itself as blank white frames.
  • kwq/KWQWidget.mm: (QWidget::internalSetGeometry):
  • Misc.subproj/IFNSViewExtras.m: (-[NSView _IF_printViewHierarchy:]): Debugging help.
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView layout]): Added setLayouted(false).
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Tweaks attempting to fix frame drawing problems.
1:43 AM Changeset in webkit [1503] by mjs
  • 19 edits in trunk

top level:

  • Site/static/javascript/javascript_window_status.html:

WebCore:

WebKit part of fix for:

Radar 2943465 - JavaScript window.defaultStatus property not implemented
Radar 2943464 - JavaScript window.status property is not implemented
Radar 2926213 - show url of moused-over link in status bar

Also fixed:

Radar 2980091 - KHTMLPart::findFrame() and KHTML::frameExists()
should search all frames, not just child frames

  • khtml/khtml_part.cpp: (KHTMLPart::overURL): Unifdef most of this, but adjust the wording. (KHTMLPart::setStatusBarText): Implement by calling KWQKHTMLPartImpl.
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::frameExists): Search all frames, not just child frames. (KWQKHTMLPartImpl::findFrame): Search all frames, not just child frames. (KWQKHTMLPartImpl::setStatusBarText): Implemented by calling WebCoreBridge.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/WebCoreBridge.h: Declare new setStatusText method
  • kwq/kparts/part.h: Remove setStatusBarText method.

WebKit:

WebCore part of fix for:

Radar 2943465 - JavaScript window.defaultStatus property not implemented
Radar 2943464 - JavaScript window.status property is not implemented
Radar 2926213 - show url of moused-over link in status bar

  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge setStatusText:]): Connect bridge status text setting to window context.
  • WebView.subproj/IFWebController.h:

WebBrowser:

Fixed Radar 2980081 - Status bar should center-truncate status messages

  • BrowserWindow.h:
  • BrowserWindow.m: (-[BrowserWindow windowDidResize:]): (-[BrowserWindow dealloc]): (-[BrowserWindow setStatus:]):

Remove dataSource argument:

  • WebController.m: (-[BrowserWebController setStatusText:]): (-[BrowserWebController statusText]):

Jul 2, 2002:

9:43 PM Changeset in webkit [1502] by cblu
  • 8 edits in trunk/WebKit

WebKit:

Added IFFileURLPolicyReveal. This makes things a little clearer for the client.

  • WebView.subproj/IFWebControllerPolicyHandler.h:
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _shouldShowDataSource:]): support for IFFileURLPolicyReveal.

WebBrowser:

Added IFFileURLPolicyReveal. This makes things a little clearer for the client.

  • WebController.m: (-[BrowserWebController unableToImplementURLPolicyForURL:error:]): removed old comments (-[BrowserWebController fileURLPolicyForMIMEType:dataSource:isDirectory:]): use IFFileURLPolicyReveal for files we don't open and IFFileURLPolicyOpenExternally for directories
9:38 PM Changeset in webkit [1501] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]): Fixed a syntax error caused by a "just before committing" edit.
9:30 PM Changeset in webkit [1500] by darin
  • 4 edits in trunk/WebKit
  • fixed 2952837 -- image not rendered if height or width attributes specified incorrectly
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]): Set the size of both the image and the image representation.
8:52 PM Changeset in webkit [1499] by cblu
  • 8 edits in trunk/WebKit

Can't call startLoading on a frame if setProvisionalDataSource

returned NO.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView

loadURL:inTarget:withNotifyData:andHandleAttributes:]):

  • WebCoreSupport.subproj/IFWebCoreFrame.m: (-[IFWebCoreFrame loadURL:attributes:flags:withParent:]):
  • WebView.subproj/IFWebView.mm: (-[IFWebView performDragOperation:]):
7:49 PM Changeset in webkit [1498] by cblu
  • 5 edits in trunk/WebKit

Fixed asseration failure caused by an iframe not having a correct mime type.
We now assume that local files without extensions are html files.

  • WebView.subproj/IFWebControllerPrivate.mm: (+[IFWebController _MIMETypeForFile:]):
5:52 PM Changeset in webkit [1497] by cblu
  • 32 edits
    6 adds in trunk/WebKit

WebFoundation:

  • CacheLoader.subproj/IFURLCacheLoaderConstants.h: removed IFErrorCode enum
  • Misc.subproj/IFError.h:
  • Misc.subproj/IFError.m: (classInitialize): removed WebKit error descriptions (-[IFError description]): no changes (+[IFError addErrorsFromDictionary:]): added, allows WebKit to register errors

WebKit:

  • Moved all policy methods to IFWebControllerPolicyHandler.h
  • Moved all file URL error checking to WebKit
  • Implemented file URL policy methods
  • Renamed IFContentPolicyOpenExternally to IFContentPolicySaveAndOpenExternally
  • Misc.subproj/IFWebKitErrors.h: Added.
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/IFLocationChangeHandler.h: removed content policy stuff
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): IFContentPolicySaveAndOpenExternally rename (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): call the policy handler for content policy stuff
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebController.mm: (-[IFWebController haveContentPolicy:andPath:forDataSource:]): sends a unableToImplementContentPolicy: (+[IFWebController canShowFile:]): now calls _MIMETypeForFile
  • WebView.subproj/IFWebControllerPolicyHandler.h: Added.
  • WebView.subproj/IFWebControllerPrivate.h:
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): IFContentPolicySaveAndOpenExternally

WebBrowser:

  • Moved all policy methods to IFWebControllerPolicyHandler
  • Moved all file URL error checking to WebKit
  • Implemented file URL policy methods
  • Renamed IFContentPolicyOpenExternally to IFContentPolicySaveAndOpenExternally
  • BrowserDocument.m: (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): load frame only if setProvisionalDataSource returns YES
  • BrowserWindow.h:
  • BrowserWindow.m: (-[BrowserWindow goToToolbarLocation:]): removed file URL error checking
  • DownloadMonitor.m: (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:complete:]): minor clean-up
  • LocationChangeHandler.m: removed content policy methods
  • WebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]): IFContentPolicySaveAndOpenExternally
3:44 PM Changeset in webkit [1496] by rjw
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFRenderNode.mm: (-[IFRenderNode initWithRenderObject:khtml::]): Fixed regression that prevented showing of nodes in subframes.
2:45 PM Changeset in webkit [1495] by darin
  • 4 edits in trunk/WebKit

WebKit:

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView setWindow]), (-[IFPluginView start]), (-[IFPluginView stop]): Fix unused variable issue that affects deployment builds.

WebBrowser:

  • LocationChangeHandler.m: Improve comments.
2:28 PM Changeset in webkit [1494] by sullivan
  • 4 edits in trunk/WebKit

Remove unnecessary code to fill with white from here; this code
path has changed. Now it just bails out early in the case where
there's no widget.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView drawRect:]):
1:57 PM Changeset in webkit [1493] by sullivan
  • 4 edits in trunk/WebKit

Made IFWebView fill with white when there's no document view. This fixes:

  • 2978210 -- problems with "hide status bar"
  • 2978742 -- Resizing initially-empty Alexander window results in garbage in window
  • WebView.subproj/IFWebView.mm: (-[IFWebView drawRect:]):
10:39 AM Changeset in webkit [1492] by darin
  • 4 edits in trunk/WebCore
  • fixed 2978806 -- Crash going to ebay home page
  • khtml/ecma/kjs_navigator.cpp: (PluginBase::PluginBase): Check to be sure that we are not at the end of the "tokens" collection before dereferencing the iterator.
8:16 AM Changeset in webkit [1491] by darin
  • 5 edits in trunk/WebKit
  • WebView.subproj/IFMainURLHandleClient.mm: Fix comment.
8:12 AM Changeset in webkit [1490] by darin
  • 4 edits in trunk/WebKit
  • fixed 2975790 - Ads on salon.com scribble all over page
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView setUpWindowAndPort]): New, sets up the window, but does not call NPP_SetWindow again. (-[IFPluginView setWindow]): Call [setUpWindowAndPort] then call NPP_SetWindow. (-[IFPluginView start]): Register for changes to the bounds or frame of any of our superviews, not just one particular one. Also, don't bother to register for notification when the window resizes. Finally, use the constants for the names of the notifications, not literal strings. (-[IFPluginView layout]): Just use [setUpWindowAndPort]; no need for a new call to NPP_SetWindow. (-[IFPluginView viewHasMoved:]): Just use [setUpWindowAndPort]; no need for a new call to NPP_SetWindow.

Jul 1, 2002:

7:23 PM Changeset in webkit [1489] by mjs
  • 11 edits
    2 adds in trunk

WebCore:

Fixed Radar 2953256 - JavaScript window.moveTo() and
window.moveBy() methods do not work

This was done by creating a class to wrap an NSWindow as a
QWidget, which should be useful for many other window-related
features.

  • kwq/KWQWidget.mm: (QWidget::x): Implement in terms of the virtual frameGeometry() method. (QWidget::y): Likewise. (QWidget::width): Likewise. (QWidget::height): Likewise. (QWidget::size): Likewise. (QWidget::pos): Likewise. (QWidget::topLevelWidget): Implement by creating a KWQWindowWidget (QWidget::isVisible): Added FIXME comment.
  • kwq/KWQWindowWidget.h: Added.
  • kwq/KWQWindowWidget.mm: Added. (KWQWindowWidget::fromNSWindow): Static method that maintains a dictionary of top-level widgets, and creates them on demand. (deleteOnWindowClose): Delete top level widget on close. (KWQWindowWidget::KWQWindowWidget): (KWQWindowWidget::~KWQWindowWidget): (KWQWindowWidget::sizeHint): Implemented using NSWindow. (KWQWindowWidget::minimumSizeHint): Likewise. (KWQWindowWidget::frameGeometry): Likewise. (KWQWindowWidget::topLevelWidget): Likewise. (KWQWindowWidget::mapToGlobal): Likewise. (KWQWindowWidget::mapFromGlobal): Likewise. (KWQWindowWidget::setCursor): No-op implementation. (KWQWindowWidget::internalSetGeometry): Implemented using NSWindow.
  • kwq/Makefile.am: Add new files to build.
  • kwq/qt/qwidget.h: Make methods virtual as needed.

WebKit:

  • WebView.subproj/IFWebView.mm: (-[IFWebView window]): If the view hasn't been added to a window yet, get the window from the WindowContext.
4:31 PM Changeset in webkit [1488] by rjw
  • 5 edits in trunk/WebKit

i * WebView.subproj/IFMainURLHandleClient.mm:

(-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]):
Ensure that _didStopLoading is called for both error case and
non-error case.

4:07 PM Changeset in webkit [1487] by rjw
  • 5 edits in trunk/WebKit
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): A completion message was being sent, as well as an error message. This, no doubt confused Alexander. No only send either the final error message or the completion message.
2:17 PM Changeset in webkit [1486] by darin
  • 8 edits in trunk/WebKit

Ken fixed the load message sequencing problem in WebFoundation, so now we can
go back to the original versions of the asserts.

  • WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient dealloc]): (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]):
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): Roll out the stuff that's ifdef'd and marked with bug 2954901.
12:31 PM Changeset in webkit [1485] by darin
  • 8 edits in trunk/WebKit
  • WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView updateScrollers]): After a closer reading of the NSScrollView source code, I see that we don't need to explicitly do tile or setNeedsDisplay: because the setters take care of that, so I made this simpler. (-[IFDynamicScrollBarsView reflectScrolledClipView:]): Replace the anti- recursion hack that I erroneously removed earlier.
  • WebView.subproj/IFTextView.h: Removed the isRTF flag.
  • WebView.subproj/IFTextView.m: (-[IFTextView provisionalDataSourceChanged:]): Do nothing here. (-[IFTextView dataSourceUpdated:]): Check the MIME type here.
12:01 PM Changeset in webkit [1484] by rjw
  • 6 edits in trunk/WebKit

Fixed 2976913.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView layout]): Augmented debugging info. (-[IFHTMLView setNeedsDisplay:]): Augmented debugging info. (-[IFHTMLView setNeedsLayout:]): Removed overload of this method to also set display flag. Why was this added? (-[IFHTMLView setNeedsToApplyStyles:]): Augmented debugging info. (-[IFHTMLView drawRect:]): Augmented debugging info.
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _timedLayout:]): If the view size is zero (width or height) force a layout now, rather than depending on the lazy layout that will happen in display. If the view size is 0,0 the AppKit will optimize out the display.
11:15 AM Changeset in webkit [1483] by cblu
  • 4 edits in trunk/WebKit

WebKit:

Minor cleanup

  • Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:]): (-[IFNullPluginView dealloc]):

WebBrowser:

Add support for delete, clear and stop menu items and keyboard shortcuts
in Downloads.

  • DownloadMonitor.m: (-[DownloadMonitor validateUserInterfaceItem:]): (-[DownloadMonitor stopLoading:]): added (-[DownloadMonitor clear:]): added (-[DownloadMonitor didDoubleClick]): (-[DownloadMonitor didHitDeleteKey]): added
  • ListView.m: (-[ListView keyDown:]): look for delete key (-[ListView validateUserInterfaceItem:]):
  • WebBrowser.pbproj/project.pbxproj:
10:00 AM Changeset in webkit [1482] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-07-01 Kenneth Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2967062 (alexander has fit on exit)

We no longer sync the contents of the cache to disk at quit time. I also
shortented the amount of time of disk cache waits before
declaring "idle time" from 5 seconds to 1 second. This might
need some tuning, but it should keep the disk cache queue with i
writes pending from getting too long, while not stepping on more i
time-critical things like page rendering.

  • CacheLoader.subproj/IFURLLoadManager.m: (-[IFURLLoadManager initWithDefaultStack]) (-[IFURLLoadManager loadDidFinish:])
  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase dealloc]) (-[IFURLFileDatabase setTimer])
9:19 AM Changeset in webkit [1481] by darin
  • 16 edits in trunk

top level:

  • Tools/CommitLogEditor/.cvsignore: Added.

WebCore:

  • khtml/css/cssparser.cpp:
  • khtml/misc/htmlhashes.cpp: Remove workaround for a PFE bug that no longer affects us.
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: Remove some unneeded APPLE_CHANGES.
  • WebCore.exp: One less symbol to export.

WebKit:

  • Plugins.subproj/IFPlugin.m: (-[IFPlugin _getPluginInfoForResourceFile:]): Fix off-by one error that would cause a memory trasher if we had a 255-character string.
  • WebView.subproj/IFHTMLView.mm:
  • WebView.subproj/IFRenderNode.mm: Touch these files so we don't have to do a full build of WebKit for my WebCore changes.
5:35 AM Changeset in webkit [1480] by mjs
  • 7 edits in trunk/WebKit

WebKit:

Build fixes (don't know why a plain build didn't catch these):

  • Plugins.subproj/IFPluginView.mm: openNewWindowWithURL: is not a method of the controller any more, nor are the status-related calls.
  • WebView.subproj/IFWebController.h: Un-ifdef the status calls.

WebBrowser:

Build fixes:

  • BrowserDocument.h,
  • BrowserDocument.m: (-[BrowserDocument highestPriorityStatusMessage]): Make this public. (-[BrowserDocument _updateStatusInBrowserWindow]): Adjust for rename.
  • WebController.m: (-[BrowserWebController statusTextForDataSource:]): Implemented.
1:48 AM Changeset in webkit [1479] by mjs
  • 4 edits in trunk/WebKit

WebKit:

Part of fix for Radar 2976618 - links targeting _blank hit
assertion trying to set provisional data source

  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame frameNamed:]): Show the window.

WebBrowser:

Part of fix for Radar 2976618 - links targeting _blank hit
assertion trying to set provisional data source

  • BrowserDocument.m: (-[BrowserDocument setShouldStartEmpty]): Ensure the window exists, so that there are a frame and web view ready in time.
1:18 AM Changeset in webkit [1478] by mjs
  • 4 edits in trunk/WebKit

Fix Radar 2953256 - Auth sheet appears detached when clicking
directly on auth link with Alex not running

  • Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels frontmostWindowLoadingURL:]): Don't consider windows that are not visible.
Note: See TracTimeline for information about the timeline view.