⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 7, 2002:

2:57 AM Changeset in webkit [1518] by mjs
  • 20 edits in trunk

WebCore:

WebCore part of fix for Radar 2953431 - JavaScript window.close()
method is not working

  • khtml/ecma/kjs_window.cpp: (Window::scheduleClose): In AppleChanges
  • khtml/khtml_part.cpp: (KHTMLPart::openedByJS): Call kwq implementations, because we need to remember the openedByJS state across location changes, which in our case means replacing the part. (KHTMLPart::setOpenedByJS): Likewise.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::openedByJS): Implement by calling bridge. (KWQKHTMLPartImpl::setOpenedByJS): Likewise. (KWQKHTMLPartImpl::close): Likewise.
  • kwq/KWQKHTMLPartImpl.h: Prototype new PartImpl methods.
  • kwq/WebCoreBridge.h: Prototype new bridge methods.

WebKit:

WebCore part of fix for Radar 2953431 - JavaScript window.close()
method is not working

  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge openedByScript]): Implement by calling controller. (-[IFWebCoreBridge setOpenedByScript:]): Likewise.
  • WebView.subproj/IFWebControllerPrivate.h:
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _openedByScript]): Implement. (-[IFWebController _setOpenedByScript:]): Implement.

Jul 6, 2002:

12:41 AM Changeset in webkit [1517] by darin
  • 7 edits in trunk/WebCore
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::write): Remove reference to nonexistent class in a comment.
  • kwq/KWQKHTMLPartImpl.h: Remove unused and unimplemented getDataSource().

Jul 5, 2002:

11:06 AM Changeset in webkit [1516] by darin
  • 10 edits in trunk/WebKit

Fix crashes I saw with zombies enabled caused by messing with windows that are
in the process of being destroyed.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView start]): Remove windowWillClose notification because we use viewDidMoveToWindow instead. (-[IFPluginView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
  • WebView.subproj/IFHTMLViewPrivate.h: Need a boolean flag to tell window changes before the first time we are installed from window changes afterward.
  • WebView.subproj/IFImageView.m: (-[IFImageView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.

Jul 4, 2002:

6:15 PM Changeset in webkit [1515] by mjs
  • 5 edits in trunk/WebCore

Say "Go to" instead of "Link to" for links that won't open a new
window. Also, the code is now set up to change the status text
when modifier keys are pressed, but the code is disabled for now
because it's impossible to do reliably.

  • khtml/khtml_part.cpp: (KHTMLPart::overURL): (KHTMLPart::khtmlMouseMoveEvent):
  • khtml/khtml_part.h:
6:08 PM Changeset in webkit [1514] by mjs
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView mouseMovedNotification:]): Pass the modifier flags along for mouse move events.
1:21 PM Changeset in webkit [1513] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

  • WebView.subproj/IFDynamicScrollBarsView.h: Updated FIXME to mention bug number.

WebBrowser:

  • finished a few details for 2953570 and 2953580 -- Open and Reveal in Downloads window don't handle missing-file case well
  • fixed 2981774 -- Status bar text not centered vertically
  • removed vestiges of ancient mechanism for swapping browser window view between webview & search modes
  • English.lproj/Browser.nib: Made the status bar a few pixels shorter. We may decide that it looks bad for it to be a different height than the favorites bar, but Don wanted to try this. Also made IFWebView a direct subview of the window's contentView, and eliminated the extra views that were part of the ancient web/search mode mechanism.
  • BrowserWindow.h: Removed tabView outlet.
  • BrowserWindow.m: (-[BrowserWindow toggleFavoritesBarWithAnimation:]): (-[BrowserWindow toggleStatusBarWithAnimation:]): Made these methods use webView instead of tabView.
  • DownloadMonitor.m: (-[DownloadMonitor _canOpenSelectedDownloads]): (-[DownloadMonitor _canStopSelectedDownloads]): (-[DownloadMonitor _canRevealSelectedDownloads]): (-[DownloadMonitor _canForgetSelectedDownloads]): Renamed these from "_totalSelectedAndXXXXable" and made them return BOOLs rather than ints, since that's all the callers cared about. Made them (except _canReveal) return as soon as a single valid entry is found (_canReveal has to make sure there is exactly one valid entry). Made _canOpen and _canReveal return YES even if file doesn't exist, so that the user will get the explanatory message if they click on Open or Reveal in this case.

(-[DownloadMonitor validateUserInterfaceItem:]):
Updated for method name and return-value changes; restructured so that it returns
as soon as the right selector is checked, rather than continuing to check against
other selectors.

(-[DownloadMonitor _showMissingFileErrorForOperation:andFile:]): Removed this
method; it was constructing messages using substitution patterns that might
not work in other languages.

(-[DownloadMonitor openSelectedDownloads:]):
Made the error message handle the multiple-missing-files case properly; let
all openable items be opened regardless of how many unopenable items there are
(formerly bailed at the first unopenable item). Moved sheet-displaying code
for this case into here.

(-[DownloadMonitor revealSelectedDownloads:]): Moved sheet-displaying code
for this case into here.

Jul 3, 2002:

3:58 PM Changeset in webkit [1512] by cblu
  • 8 edits in trunk/WebKit
  • Fix for 2975750
  • Removed Java workaround since that will be fixed soon.
  • Plugins.subproj/IFPlugin.h:
  • Plugins.subproj/IFPlugin.m: (-[IFPlugin _openResourceFile]): added (-[IFPlugin _closeResourceFile:]): added (-[IFPlugin _getPluginInfo]): rename (-[IFPlugin initWithPath:]): simplified (-[IFPlugin load]): calls _openResourceFile (-[IFPlugin unload]): calls _closeResourceFile
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView setUpWindowAndPort]): removed Java workaround
3:18 PM Changeset in webkit [1511] by darin
  • 4 edits in trunk/WebKit

top level:

  • Site/Internal/Design/IFRenamings.txt: Update a bit more, preparing for the team to review.

WebKit:

  • Misc.subproj/IFException.h: Use Objective C header style rather than plain C.

WebBrowser:

  • NSViewAdditions.h:
  • NSViewAdditions.m: Change name of this category to match the file name to smooth things over for the IF -> Web renaming.
12:34 PM Changeset in webkit [1510] by darin
  • 5 edits in trunk/WebCore

A small KURL speed improvement.

  • khtml/misc/loader.cpp: (Cache::requestImage): (Cache::requestStyleSheet): (Cache::requestScript): Don't do the isMalformed check, because it's expensive and has no clear benefit. There's no harm in caching null results for malformed URLs.
  • kwq/KWQKURL.mm: (KURL::KURL): Make the default constructor faster by not running all the normalize code on the empty string.
11:30 AM Changeset in webkit [1509]
  • 3 copies in tags/Alexander-11

This commit was manufactured by cvs2svn to create tag 'Alexander-11'.

11:30 AM Changeset in webkit [1508] by sheridan
  • 8 edits in trunk

Alex-11 and 0.4 versions & changelog markers

9:06 AM Changeset in webkit [1507] by darin
  • 7 edits in trunk/WebKit
  • Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler finishedLoading]):
  • WebView.subproj/IFWebController.h: A couple places where it still said IFContentPolicyOpenExternally.
5:20 AM Changeset in webkit [1506] by mjs
  • 17 edits in trunk

WebCore:

WebCore part of fixes for:

Radar 2950616 - JavaScript window.screenX and window.screenY always return -1
Radar 2950614 - JavaScript window.screenLeft and window.screenTop
properties are unimplemented
Radar 2950609 - JavaScript window.outerHeight and
window.outerWidth properties always return 0

  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (Window::get): Make ScreenLeft and ScreenTop synonyms for ScreenX and ScreenY respectively.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::setView): Set the real part's view too.
  • kwq/kdecore/kwin.h: Remove unneeded fields.
  • kwq/KWQKWin.mm: (KWin::info): Implemented.
  • kwq/qt/qwidget.h:
  • kwq/KWQWidget.mm: (QWidget::winId): Return long instead of int, to make sure there is room for a pointer even on 64-bit architectures. (QWidget::mapToGlobal): Use the top level widget to map.

WebKit:

WebKit part of fixes for:

Radar 2950616 - JavaScript window.screenX and window.screenY always return -1
Radar 2950614 - JavaScript window.screenLeft and window.screenTop
properties are unimplemented
Radar 2950609 - JavaScript window.outerHeight and
window.outerWidth properties always return 0

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Pass the real document view to the newly created bridge, since it will be ready by now and is needed by JavaScript.
4:18 AM Changeset in webkit [1505] by mjs
  • 4 edits in trunk/WebKit
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView status:]): Fix build problem. Why doesn't compiling catch these more reliably?
1:59 AM Changeset in webkit [1504] by rjw
  • 13 edits in trunk
  • kwq/KWQScrollView.mm: (QScrollView::addChild): Fixed regression that caused IFWebView frame origin to sometimes never be set correctly. (khtml sets the x origin to -500000 during initialization, and it was never getting set correctly). This problem manifested itself as blank white frames.
  • kwq/KWQWidget.mm: (QWidget::internalSetGeometry):
  • Misc.subproj/IFNSViewExtras.m: (-[NSView _IF_printViewHierarchy:]): Debugging help.
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView layout]): Added setLayouted(false).
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Tweaks attempting to fix frame drawing problems.
1:43 AM Changeset in webkit [1503] by mjs
  • 19 edits in trunk

top level:

  • Site/static/javascript/javascript_window_status.html:

WebCore:

WebKit part of fix for:

Radar 2943465 - JavaScript window.defaultStatus property not implemented
Radar 2943464 - JavaScript window.status property is not implemented
Radar 2926213 - show url of moused-over link in status bar

Also fixed:

Radar 2980091 - KHTMLPart::findFrame() and KHTML::frameExists()
should search all frames, not just child frames

  • khtml/khtml_part.cpp: (KHTMLPart::overURL): Unifdef most of this, but adjust the wording. (KHTMLPart::setStatusBarText): Implement by calling KWQKHTMLPartImpl.
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::frameExists): Search all frames, not just child frames. (KWQKHTMLPartImpl::findFrame): Search all frames, not just child frames. (KWQKHTMLPartImpl::setStatusBarText): Implemented by calling WebCoreBridge.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/WebCoreBridge.h: Declare new setStatusText method
  • kwq/kparts/part.h: Remove setStatusBarText method.

WebKit:

WebCore part of fix for:

Radar 2943465 - JavaScript window.defaultStatus property not implemented
Radar 2943464 - JavaScript window.status property is not implemented
Radar 2926213 - show url of moused-over link in status bar

  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge setStatusText:]): Connect bridge status text setting to window context.
  • WebView.subproj/IFWebController.h:

WebBrowser:

Fixed Radar 2980081 - Status bar should center-truncate status messages

  • BrowserWindow.h:
  • BrowserWindow.m: (-[BrowserWindow windowDidResize:]): (-[BrowserWindow dealloc]): (-[BrowserWindow setStatus:]):

Remove dataSource argument:

  • WebController.m: (-[BrowserWebController setStatusText:]): (-[BrowserWebController statusText]):
Note: See TracTimeline for information about the timeline view.