Timeline



Jul 18, 2002:

10:10 PM Changeset in webkit [1594] by mjs
  • 6 edits in trunk/WebKit

More refactoring: Simplify a bit more by moving more logic into
the data source.

  • WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _gotFirstByte]): Removed. (-[WebDataSource _setGotFirstByte]): Removed. (-[WebDataSource _isReadyForData]): Removed. (-[WebDataSource _receivedData:]): Commit if appropriate, and pass data to representation and documentView.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:resourceDataDidBecomeAvailable:]): Change the check back to policy != None, because the first chunk will trigger a commit in the policy == Show case, so there is no need to worry about it.
9:37 PM Changeset in webkit [1593] by mjs
  • 7 edits in trunk/WebKit

Rename some methods for clarity. These two methods are defined by
the end state, not the start state (in fact,
transitionToLayoutAcceptable does most of it's work when it starts
in the cimmitted state, not provisional).

  • WebView.subproj/WebFramePrivate.h, WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToLayoutAcceptable]): Renamed from _transitionProvisionalToLayoutAcceptable. (-[WebFrame _transitionToCommitted]): Renamed from _transitionProvisionalToLayoutAcceptable.

And adjust all the calls to them:

  • WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
9:13 PM Changeset in webkit [1592] by mjs
  • 18 edits in trunk/WebKit

Even more exciting refactoring. Change the rules for committing
the data source and creating the representation so that both
happen when the first byte has been received _and_ the content
policy has been set to show. Previously these actions happened at
different times. Now we maintain the invariant that the data
source has a representation if and only if it is committed.

  • WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Simplify further by putting more of the work in WebDataSource.
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):
  • WebView.subproj/WebDataSource.h, WebView.subproj/WebDataSource.m: Move makeRepresentation method to private file.
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setContentPolicy:]): If the policy is set to show, commit if we have already gotten the first byte. (-[WebDataSource _commitIfReady]): Create representation and commit if we have the first byte and have a policy of show. (-[WebDataSource _gotFirstByte]): Method to check if this data source has gotten the first byte yet. Commit here if ready. (-[WebDataSource _setGotFirstByte]): Method to report that some data has been received. (-[WebDataSource _makeRepresentation]): Make and set up teh document view too. (-[WebDataSource _isReadyForData]): Return TRUE if policy is set (and if the policy is Show, if we have also received the first byte.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionProvisionalToCommitted]): Don't call the datasource (it now calls us)
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:resourceDataDidBecomeAvailable:]):
  • WebView.subproj/WebView.h, WebView.subproj/WebView.m: move makeDocumentViewForDataSource...
  • WebView.subproj/WebViewPrivate.h, WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]): To here.
5:06 PM Changeset in webkit [1591] by hyatt
  • 4 edits in trunk/WebCore
  • khtml/css/css_valueimpl.cpp: Changed the QRegExps used for font family matching to statics. Helped out one page on the base tests a fair bit. Overall (spread over all 40 pages) it's not that big though.
12:05 PM Changeset in webkit [1590] by mjs
  • 3 edits in trunk/WebKit

Avoid throwing an exception while stopping animations. Image
renders were getting into the array multiple times, which means
the code that iterated over the array backwards could throw an
exception, because callling removeObject: on the array would remove
all instances of the object.

This probably fixes the following crashers, and a bunch of huge leaks:

Radar 2999853 - Uninitialized memory access in plugins on theonion.com
Radar 2999892 - Crash disconnecting view from next view chain on theonion.com
Radar 2999911 - Infinite loop in [WebHTMLView dealloc], resulting in crash

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer scheduleFrame]): Move adding to array of image renderers from here... (-[WebImageRenderer beginAnimationInRect:fromRect:]): To here.
11:22 AM Changeset in webkit [1589] by hyatt
  • 4 edits in trunk/WebCore

Small change that gives us 25% speedup (uncached) on the cvs-base suite.

  • khtml/css/cssstyleselector.cpp: Optimized CLASS style comparison to avoid allocing QStrings when the CLASS attribute only contains one entry (as opposed to a list of entries).
9:35 AM Changeset in webkit [1588]
  • 3 copies in tags/Alexander-13

This commit was manufactured by cvs2svn to create tag 'Alexander-13'.

9:35 AM Changeset in webkit [1587] by sheridan
  • 8 edits in trunk

markers & version for Alex-13

1:46 AM Changeset in webkit [1586] by mjs
  • 7 edits in trunk/WebKit

Yet still more refactoring in preparation for the KHTMLPart
change. This is preparing things to change the commit rule to
require receiving at least one byte of data, and having the
content policy set to Show.

  • WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Remove more code since makeRepresentation now does most of the work.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource makeRepresentation]): Tell the WebView (if any) to create the documentView now too.
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView makeDocumentViewForDataSource:]): Hook document view up to data source.
12:47 AM Changeset in webkit [1585] by mjs
  • 5 edits in trunk/WebKit

Some refactoring in preparation for the KHTMLPart change.

  • WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Bail early if not loading. (-[WebDataSource _commit]): Method to mark when the data source is committed (it now knows whether it's committed or provisional). This will be useful for adding assertions later on about what operations may happen only when committed, and which can only happen when provisional.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionProvisionalToCommitted]): Call data source's _commit method.

Jul 17, 2002:

8:55 PM Changeset in webkit [1584] by rjw
  • 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

Made WebDocument.h public.

8:13 PM Changeset in webkit [1583] by rjw
  • 3 edits in trunk/WebKit
  • WebView.subproj/WebHTMLView.m: Removed unnecessary (and incorrect) lockFocus.
3:24 PM Changeset in webkit [1582] by mjs
  • 14 edits in trunk/WebKit

Some refactoring in preparation for the KHTMLPart change.

  • WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Move more of the work of creating and setting the representation and document view into WebDataSource and WebView.
  • WebView.subproj/WebDataSource.h, WebView.subproj/WebDataSource.m: (+[(id <WebDocumentRepresentation>) createRepresentationForMIMEType:]): Removed. (-[WebDataSource makeRepresentation]): A method to build the right kind of representation for the content type.
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _representationClass]): Method to get the right representation class for the current content type. (-[WebDataSource _bridge]): Move here from WebBridge.[mh], so we can later add an assertion that the data source is not provisional.
  • WebView.subproj/WebHTMLViewPrivate.m: #import WebDataSourcePrivate.h
  • WebView.subproj/WebView.h, WebView.subproj/WebView.m: (+[(id <WebDocumentRepresentation>) createDocumentViewForMIMEType:]): Removed. (-[WebView makeDocumentViewForMIMEType:]): Method to build the right kind of document view for the specified MIME type.
3:02 PM Changeset in webkit [1581] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Take out bogus check for nil path -- a URL with a nil path is OK, for example "about:blank". Also improved log message.

Jul 16, 2002:

9:26 PM Changeset in webkit [1580] by darin
  • 5 edits in trunk/WebKit

WebKit:

  • History.subproj/WebBackForwardList.m: Replace MyCompanyName with Apple Computer. (-[WebBackForwardList init]): Fix strange [super init] logic to be standard.
  • History.subproj/WebHistoryItem.h: Replace MyCompanyName with Apple Computer.
  • Misc.subproj/WebDownloadHandler.h: Replace MyCompanyName with Apple Computer.

WebBrowser:

  • LocationTextField.h: Replace MyCompanyName with Apple Computer.
  • LocationTextField.m: Replace MyCompanyName with Apple Computer.
9:15 PM Changeset in webkit [1579] by darin
  • 7 edits in trunk/WebKit
  • fixed 2997891 -- Alexander confused about base page URL for relative links
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient WebResourceHandle:didRedirectToURL:]): Don't tell the bridge the URL changed. The bridge doesn't care about redirects for subresources (and if it did, we'd need some way to tell it that this was a subresource redirect).
  • WebCoreSupport.subproj/WebBridge.m: Formatting tweaks.
  • WebCoreSupport.subproj/WebImageRenderer.m: Formatting tweaks.
  • WebView.subproj/WebView.m: Formatting tweaks.
7:39 PM Changeset in webkit [1578] by rjw
  • 3 edits in trunk/WebKit

Really, stop animation if last frame has zero duration, like IE.
Was checking adjustedFrameDuration, which is never zero.

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer unadjustedFrameDuration]): (-[WebImageRenderer frameDuration]): (-[WebImageRenderer nextFrame:]):
6:14 PM Changeset in webkit [1577] by mjs
  • 2 edits in trunk/WebKit

WebKit:
Corrected bug number in previous ChangeLog message.

5:48 PM Changeset in webkit [1576] by mjs
  • 15 edits in trunk

WebCore:

Moved URL mouseover status to KWQKHTMLPartImpl, and made it
responsive to modifier key presses, if enabled. Fixes:

Radar 2980152 - Link mouseover status messages are not localizable
Radar 2982043 - Link mouse-over status should change in response to modifier keys

  • khtml/khtml_part.cpp: (KHTMLPart::overURL): Remove extensive APPLE_CHANGES, and just call the impl method.
  • kwq/KWQKHTMLPartImpl.h: Prototype overURL method.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Construct status messages using format strings for localizability; change message in response to modifiers if modifier tracking is enabled.
  • kwq/WebCoreBridge.h: Prototype modifierTrackingEnabled method.

WebKit:

WebKit part of fix for:

Radar 2982043 - Link mouseover status messages are not localizable

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge modifierTrackingEnabled]): Implemented by checking bit on WebHTMLView class.
  • WebKit.pbproj/project.pbxproj: Install WebHTMLViewPrivate as a Private header.
  • WebView.subproj/WebHTMLViewPrivate.h: Prototype new modifier tracking SPI.
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView _setModifierTrackingEnabled:]): Method to inform WebHTMLView that modifier tracking is working. (+[WebHTMLView _modifierTrackingEnabled]): Obligatory getter. (+[WebHTMLView _postFlagsChangedEvent:]): Method to report flagsChanged events. Creates corresponding fake mouseMoved event and sends it as a notification.

WebBrowser:

WebBrowser part of fix for:

Radar 2982043 - Link mouseover status messages are not localizable

  • AppController.m: (-[AppController awakeFromNib]): Enable modifier tracking.
  • BrowserWindowController.m: (-[BrowserWindowController windowWillHandleKeyEvent:]): Post NSFlagsChanged events to WebHTMLView.
5:11 PM Changeset in webkit [1575] by rjw
  • 5 edits in trunk/WebCore

Fixed field length test. We were testing >= instead of >.

  • kwq/KWQNSTextField.mm: (-[KWQNSTextFieldFormatter isPartialStringValid:newEditingString:errorDescription:]):
4:17 PM Changeset in webkit [1574] by darin
  • 10 edits in trunk

WebCore:

  • fixed 2997244 -- crash when visiting cnn.com followed by another page

Turns out the requestFrame code I've been tinkering with used to be
dead code until we accidentally re-triggered the code path.

  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach): Remove APPLE_CHANGES that were causing us to reuse the same frame which were an attempt to fix a frame targeting problem that was actually elsewhere.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Remove the code that handles the case of an already-existing frame with the same name. This is handled at a higher level.
  • kwq/WebCoreBridge.h: Remove now-unneeded childFrameNamed method.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: Remove childFrameNamed since it's not needed, and every one of these bridge methods adds potential confusion. (-[WebBridge descendantFrameNamed:]): Make this look for descendants in the provisional data sources first. This is the same change Richard made to childFrameNamed, but it turns out that this is the method that's really used.
2:11 PM Changeset in webkit [1573] by kocienda
  • 1 delete in branches/jaguar-branch/WebKit

Removed all the files that "magically" showed up on the branch as
a result of the Web* renaming. We don't want any renamed files on
the branch.

11:59 AM Changeset in webkit [1572] by darin
  • 5 edits in trunk/WebCore
  • fixed 2998692 -- crash when you type "googl" into the page address
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Check for a nil part here to restore the old behavior. Whether that's OK or not is another question that I'd prefer to deal with later.
9:17 AM Changeset in webkit [1571] by darin
  • 163 edits
    4 adds
    126 deletes in trunk

top level:

  • many files: Renamed IF* -> Web*.

Tools:

  • various files: Renamed IF* -> Web*.

WebFoundation:

  • almost every file: Renamed IF* -> Web*.

WebCore:

  • almost every file: Renamed IF* -> Web*.

WebKit:

  • almost every file: Renamed IF* -> Web*.

WebBrowser:

  • almost every file: Renamed IF* -> Web*.
6:56 AM Changeset in webkit [1570] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-07-16 Ken Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2997750 (Sherlock crashes at launch - reproducible on my machine 100%)

This is a bug that only occurs when a zer-length cache file is encountered.
The NSUnarchiver init method does not handle this situation, and throws an exception.
Hence, calls to NSUnarchiver must be done inside an NS_DURING. Note that this change
merely expands the scope of the already-existing NS_DURING to include
the NSUnarchiver init method.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase objectForKey:])

Jul 15, 2002:

10:19 PM Changeset in webkit [1569] by rjw
  • 10 edits in trunk/WebKit

Removed dependence on window resize notification. We now
use the IFWebView setFrame: method to trigger layouts. Much
cleaner.

Cleaned up image animation timer scheduler.

Stop animation if last frame has zero duration, like IE.

Change minimum duration to 1/30th (used if zero frame duration is
specified). This is closer to what I see in IE empirically.

  • WebCoreSupport.subproj/IFImageRenderer.h:
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer frameDuration]): (-[IFImageRenderer _scheduleFrame]): (-[IFImageRenderer nextFrame:]): (-[IFImageRenderer beginAnimationInRect:fromRect:]):
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView initWithFrame:]): (-[IFHTMLView removeNotifications]):
  • WebView.subproj/IFWebView.mm: (-[IFWebView setFrame:]): (-[IFWebView viewWillStartLiveResize]): (-[IFWebView viewDidEndLiveResize]):
6:01 PM Changeset in webkit [1568] by mjs
  • 4 edits in trunk/WebKit

WebKit:

Fixed Radar 2957209 - Change "JavaScript can open new windows
automatically" preference to off by default

  • WebView.subproj/IFPreferences.mm: (+[IFPreferences load]): Switch default for "Allow JavaScript to open new windows automatically to FALSE.

WebBrowser:

Fixed Radar 2957209 - Change "JavaScript can open new windows
automatically" preference to off by default

  • Preferences.subproj/English.lproj/ActiveContentPreferences.nib: Tweak wording to make more sense now that the pref defaults to off.
5:43 PM Changeset in webkit [1567] by darin
  • 4 edits in trunk/WebKit

More weaning from C++.

  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView initWithFrame:plugin:url:baseURL:mime:arguments:]): Use malloc instead of new. (-[IFPluginView dealloc]): Use free instead of delete.
5:33 PM Changeset in webkit [1566] by darin
  • 30 edits in trunk/WebKit

top level:

  • Site/Internal/Design/IFRenamings.txt: Better naming proposals.

WebKit:

Fixes so we are ready to compile as Objective C, not C++.
The C++ front end misses a lot of things the C front end catches.

  • Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]): Add missing cast.
  • Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): Use [IFLoadProgress initWithURLHandle:] instead of getting at private fields.
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView setUpWindowAndPort]): Remove unused windowFrame. (-[IFPluginView start]): Don't use a variable within a for statement. Add missing cast.
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Use [IFWebFrame _setProvisionalDataSource:] so we don't have to get at the protected field _private.
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): Use [IFProgress bytesSoFar] so we don't have to get at the protected field bytesSoFar.
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Add missing cast. (-[IFWebFrame _setProvisionalDataSource:]): Added.
  • WebView.subproj/IFHTMLRepresentation.mm:
  • WebView.subproj/IFHTMLViewPrivate.h:
  • WebView.subproj/IFWebControllerPrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebFramePrivate.h:
  • WebView.subproj/IFWebViewPrivate.h: Make data in private class @public, since the main class needs to get at it directly.
3:23 PM Changeset in webkit [1565] by darin
  • 4 edits in trunk/WebCore

A teeny weeny bit of refactoring.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stateForEvent:]): Replaces addModifiers:toState:. (-[WebCoreBridge mouseUp:]): Use stateForEvent:. (-[WebCoreBridge mouseDown:]): Use stateForEvent:. (-[WebCoreBridge mouseMoved:]): Use stateForEvent:.
2:22 PM Changeset in webkit [1564] by rjw
  • 18 edits
    2 adds in trunk

Added isFrameSet method.

  • WebCore.pbproj/project.pbxproj:
  • khtml/khtml_part.cpp: (KHTMLPart::isFrameSet):
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQKHTMLPartImpl.cpp: Added. (KWQKHTMLPartImpl::isFrameSet):
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge isFrameSet]):

Only adjustFrames in parent if parent is a frame set.
(Anywhere from 2% to 6% gain, depending on what you believe.)

  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):
  • WebView.subproj/IFPreferences.mm: (+[IFPreferences load]): Increment initial layout from 1.5 seconds to 1.85 seconds.
2:06 PM Changeset in webkit [1563] by darin
  • 5 edits in trunk/WebKit

top level:

  • Site/Internal/Design/IFRenamings.txt: Update with naming proposals for recently added identifiers.

WebKit:

  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): Tweak a comment that included the word WebController, to smooth things over a tiny bit for the coming renaming.

WebBrowser:

Finished renaming WebController to BrowserWebController to head
off name conflict in the coming renaming.

  • WebController.h:
  • WebController.m: Removed. Used cvs surgery to rename.
  • BrowserWebController.h:
  • BrowserWebController.m: Used cvs surgery to rename to these names. Then changed references to the file name to use the new name.
  • BrowserDocument.h:
  • BrowserDocument.m:
  • Debug/DebugUtilities.m:
  • LocationChangeHandler.m:
  • WebBrowser.pbproj/project.pbxproj: Change all references to use BrowserWebController instead of WebController.
8:53 AM Changeset in webkit [1562] by darin
  • 4 edits
    1 delete in trunk/WebCore
  • WebCore.pbproj/project.pbxproj: Removed KWQKPrinter.mm.
  • kwq/KWQKPrinter.mm: Removed.
8:50 AM Changeset in webkit [1561] by darin
  • 13 edits
    1 delete in trunk/WebCore

top level:

  • Tests/qt/*.cpp: Removed unnecessary includes of <config.h>.

WebCore:

  • WebCore.pbproj/project.pbxproj: Removed unused qpopupmenu.h.
  • kwq/kdecore/ksimpleconfig.h: Removed unnecessary include of <config.h>.
  • kwq/kio/global.h: Removed unnecessary include of <config.h>.
  • kwq/kio/kprinter.h: Emptied out this file.
  • kwq/qt/qpopupmenu.h: Removed.
  • kwq/qt/qstylesheet.h: Removed unnecessary include of <config.h>.
  • kwq/qt/qtextedit.h: Removed unnecessary include of <config.h>.
8:39 AM Changeset in webkit [1560] by darin
  • 11 edits in trunk

WebCore:

  • kwq/qt/qfontmetrics.h: Remove unused, and not properly implemented, empty constructor. Add some const that was missing. Remove most of the parameters of size().
  • kwq/KWQFontMetrics.mm: (QFontMetrics::charWidth): Add const. (QFontMetrics::floatWidth): Add const. (QFontMetrics::floatCharacterWidth): Add const. (QFontMetrics::size): Remove unused parameters.
  • kwq/WebCoreTextRenderer.h: Remove two unused drawString methods and one unused widthForCharacters method.

WebKit:

  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer widthForCharacters:length:]): Remove implementation of some unused methods, including at least one that was never used.
1:28 AM Changeset in webkit [1559] by mjs
  • 5 edits
    4 adds in trunk/WebKit

WebFoundation:

Fixed the following bugs by implementing proper dispatching for
cookie accept handlers:

Radar 2896356 - cookie "ask for each site" not implemented yet
Radar 2921437 - IFCookieAcceptHandler protocol not suitable for use with a sheet, not cancellable
Radar 2921444 - CookieManager C wrappers need to use proper context object

  • AuthenticationManager.subproj/IFAuthenticationHandlerDispatcher.m: (-[IFAuthenticationHandlerDispatcher IFAuthenticationRequestAuthenticationHandlerBusy:]):
  • AuthenticationManager.subproj/IFAuthenticationManager.h:
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.h:
  • CacheLoader.subproj/IFHTTPURLProtocolHandler.m: (-[IFHTTPURLProtocolHandler initWithURLLoad:]): (-[IFHTTPURLProtocolHandler endLoadInBackground]): (-[IFHTTPURLProtocolHandler dealloc]): (-[IFHTTPURLProtocolHandler didAddCredentials:toRequest:context:]): (-[IFHTTPURLProtocolHandler addAuthenticationHeaders:andCall:]): (-[IFHTTPURLProtocolHandler pause]): (-[IFHTTPURLProtocolHandler processPausedEventQueue]): (-[IFHTTPURLProtocolHandler unpause]): (-[IFHTTPURLProtocolHandler continueAfterBytesAvailable]): (-[IFHTTPURLProtocolHandler continueAfterEndEncountered]): (-[IFHTTPURLProtocolHandler handleReadStreamEvent:event:]): (-[IFHTTPURLProtocolHandler continueHeaderReadAfter3xxResponseAndCall:]): (-[IFHTTPURLProtocolHandler continueHeaderReadAfterFailureResponseAndCall:]): (-[IFHTTPURLProtocolHandler performHTTPHeaderRead:andCall:]): (-[IFHTTPURLProtocolHandler setResponseHeaders:]): (-[IFHTTPURLProtocolHandler IFCookieManager:doneSettingCookies:]): (-[IFHTTPURLProtocolHandler setResponseHeadersUsingHTTPResponse:andCall:context:]):
  • CookieManager.subproj/IFCookieAcceptHandler.h:
  • CookieManager.subproj/IFCookieAcceptHandlerC.h: Added.
  • CookieManager.subproj/IFCookieAcceptHandlerC.m: Added. (-[IFCallBackCookieAcceptHandler initWithCallBacks:context:]): (+[IFCallBackCookieAcceptHandler handlerWithCallBacks:context:]): (-[IFCallBackCookieAcceptHandler dealloc]): (-[IFCallBackCookieAcceptHandler readyToStartCookieAcceptCheck:]): (-[IFCallBackCookieAcceptHandler startCookieAcceptCheck:]): (-[IFCallBackCookieAcceptHandler cancelCookieAcceptCheck:]): (IFCookieAcceptHandlerCreate):
  • CookieManager.subproj/IFCookieAcceptHandlerDispatcher.h: Added.
  • CookieManager.subproj/IFCookieAcceptHandlerDispatcher.m: Added. (-[IFCookieAcceptDispatchState initWithDispatcher:request:]): (-[IFCookieAcceptDispatchState dealloc]): (dispatchStartCookieAcceptCheck): (dispatchCancelCookieAcceptCheck): (dispatchCookieAcceptCheckDone): (dispatchCookieAcceptHandlerBusy): (-[IFCookieAcceptHandlerDispatcher _dispatchStartCookieAcceptCheck:]): (-[IFCookieAcceptHandlerDispatcher _IFCookieAcceptRequest:checkDone:]): (-[IFCookieAcceptHandlerDispatcher _IFCookieAcceptRequestCookieAcceptHandlerBusy:]): (-[IFCookieAcceptHandlerDispatcher _dispatchCancelCookieAcceptCheck:]): (-[IFCookieAcceptHandlerDispatcher _dispatchCookieAcceptCheckDone:]): (-[IFCookieAcceptHandlerDispatcher _dispatchCookieAcceptHandlerBusy:]): (-[IFCookieAcceptHandlerDispatcher initWithCookieAcceptHandler:]): (-[IFCookieAcceptHandlerDispatcher dealloc]): (-[IFCookieAcceptHandlerDispatcher hasHandler:]): (-[IFCookieAcceptHandlerDispatcher startCookieAcceptCheck:]): (-[IFCookieAcceptHandlerDispatcher cancelCookieAcceptCheck:]):
  • CookieManager.subproj/IFCookieAcceptRequest.h: Added.
  • CookieManager.subproj/IFCookieAcceptRequest.m: Added. (-[IFCookieAcceptRequestPrivate dealloc]): (-[IFCookieAcceptRequest _initWithURL:cookies:callback:]): (-[IFCookieAcceptRequest _cookieAcceptHandlerBusy]): (-[IFCookieAcceptRequest init]): (-[IFCookieAcceptRequest dealloc]): (-[IFCookieAcceptRequest url]): (-[IFCookieAcceptRequest cookies]): (-[IFCookieAcceptRequest cookieAcceptCheckDone:]):
  • CookieManager.subproj/IFCookieAcceptRequestC.h: Added.
  • CookieManager.subproj/IFCookieAcceptRequestC.m: Added. (IFCookieAcceptRequestCopyURL): (IFCookieAcceptRequestCopyCookies): (IFCookieAcceptRequestCheckDone):
  • CookieManager.subproj/IFCookieAcceptRequestPrivate.h: Added.
  • CookieManager.subproj/IFCookieConstants.h:
  • CookieManager.subproj/IFCookieManager.h:
  • CookieManager.subproj/IFCookieManager.m: (-[IFCookieAcceptRequestState initWithRequest:dispatcher:continuation:context:]): (-[IFCookieAcceptRequestState dealloc]): (-[IFCookieManagerPrivate init]): (-[IFCookieManagerPrivate dealloc]): (-[IFCookieManager _IFCookieAcceptRequest:checkDone:]): (-[IFCookieManager _IFCookieAcceptRequestCookieAcceptHandlerBusy:]): (-[IFCookieManager _invokeAcceptHandlersForCookies:forURL:andCall:context:]): (-[IFCookieManager _checkIfCookiesAccepted:forURL:andCall:context:]): (-[IFCookieManager _continueSetCookies:context:]): (-[IFCookieManager setCookie:]): (-[IFCookieManager setCookiesFromResponseHeaders:forURL:]): (-[IFCookieManager setCookiesFromResponseHeaders:forURL:setDelegate:context:]): (-[IFCookieManager cancelSetCookiesFromResponseHeadersWithContext:]): (-[IFCookieManager addAcceptHandler:]): (-[IFCookieManager removeAcceptHandler:]):
  • CookieManager.subproj/IFCookieManagerC.h:
  • CookieManager.subproj/IFCookieManagerC.m: (IFCookieManagerAddAcceptHandler): (IFCookieManagerRemoveAcceptHandler):
  • CookieManager.subproj/IFCookieStorage.h:
  • CookieManager.subproj/IFCookieStorage.m: (-[IFCookieStorage _updateDomainsFromServer]): (-[IFCookieStorage _establishConnection]): (-[IFCookieStorage init]): (-[IFCookieStorage addAcceptedDomain:]): (-[IFCookieStorage removeAcceptedDomain:]): (-[IFCookieStorage acceptedDomains]): (-[IFCookieStorage addRejectedDomain:]): (-[IFCookieStorage removeRejectedDomain:]): (-[IFCookieStorage rejectedDomains]):
  • CookieManager.subproj/IFCookieStorageServer.h:
  • CookieManager.subproj/IFCookieStorageServer.m: (-[IFCookieStorageServerPrivate init]): (-[IFCookieStorageServerPrivate dealloc]): (-[IFCookieStorageServer _saveCookiesIfScheduled]): (-[IFCookieStorageServer _scheduleSaveCookies]): (-[IFCookieStorageServer _saveDomains]): (-[IFCookieStorageServer _saveDomainsIfScheduled]): (-[IFCookieStorageServer _scheduleSaveDomains]): (-[IFCookieStorageServer _notifyCookiesChanged]): (-[IFCookieStorageServer _notifyDomainsChanged]): (-[IFCookieStorageServer _setCookiesWithoutSaving:]): (-[IFCookieStorageServer setCookies:]): (-[IFCookieStorageServer deleteCookies:]): (-[IFCookieStorageServer addAcceptedDomain:]): (-[IFCookieStorageServer removeAcceptedDomain:]): (-[IFCookieStorageServer acceptedDomains]): (-[IFCookieStorageServer addRejectedDomain:]): (-[IFCookieStorageServer removeRejectedDomain:]): (-[IFCookieStorageServer rejectedDomains]): (-[IFCookieStorageServer loadCookies]):
  • Misc.subproj/IFNSValueExtensions.h: Added.
  • Misc.subproj/IFNSValueExtensions.m: Added. (+[NSValue _IF_valueWithSelector:]): (-[NSValue _IF_selectorValue]):
  • Misc.subproj/WebFoundationDebug.h:
  • WebFoundation.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

WebKit part of fix for Radar 2896356 - cookie "ask for each site" not implemented yet

  • Panels.subproj/IFPanelCookieAcceptHandler.h: Added.
  • Panels.subproj/IFPanelCookieAcceptHandler.m: Added. (-[IFPanelCookieAcceptHandler init]): (-[IFPanelCookieAcceptHandler dealloc]): (-[IFPanelCookieAcceptHandler readyToStartCookieAcceptCheck:]): (-[IFPanelCookieAcceptHandler startCookieAcceptCheck:]): (-[IFPanelCookieAcceptHandler cancelCookieAcceptCheck:]): (-[IFPanelCookieAcceptHandler doneWithCheck:returnCode:contextInfo:]):
  • Panels.subproj/IFStandardPanels.m: (-[IFStandardPanels setUseStandardCookieAcceptPanel:]): (-[IFStandardPanels useStandardCookieAcceptPanel]):
  • WebKit.pbproj/project.pbxproj:

WebBrowser:

Fixed Radar 2896356 - cookie "ask for each site" not implemented yet

  • AppController.m: (-[AppController awakeFromNib]):
12:16 AM Changeset in webkit [1558] by mjs
  • 11 edits in trunk/WebKit

More workarounds for the Objective C++ typecasting bug.

  • WebView.subproj/IFDOMNode.mm: (-[IFDOMNode initWithWebView:]):
  • WebView.subproj/IFHTMLViewPrivate.mm: (-[NSView _IF_stopIfPluginView]):
  • WebView.subproj/IFRenderNode.mm: (-[IFRenderNode initWithWebView:]):
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame reset]):

Jul 14, 2002:

11:51 PM Changeset in webkit [1557] by darin
  • 5 edits in trunk/WebCore

WebCore:

  • kwq/WebCoreFrame.mm: (-[WebCoreFrame dealloc]): Fix NULL-dereferencing problem that was hidden by the "leak the world" bug in WebBrowser.

WebBrowser:

Fix "leak the world" bug.

  • BrowserDocument.m: (-[BrowserDocument close]): Having the web controller as its own window context creates a reference cycle. As with the other similar cases here, break the cycle by explicitly setting it to nil.
10:55 PM Changeset in webkit [1556] by mjs
  • 5 edits in trunk/WebCore

Assign getView() results to variable of appropriate type to work
around apparent ObjC++ compiler bug. I wonder why other people
aren't running into this (and why I haven't run into it before).

  • kwq/KWQButton.mm: (QButton::setText): (QButton::text):
  • kwq/KWQLineEdit.mm: (QLineEdit::setEchoMode): (QLineEdit::setText): (QLineEdit::text): (QLineEdit::setMaxLength): (QLineEdit::isReadOnly): (QLineEdit::setReadOnly): (QLineEdit::maxLength): (QLineEdit::selectAll): (QLineEdit::edited): (QLineEdit::setEdited):
10:08 PM Changeset in webkit [1555] by darin
  • 5 edits in trunk/WebCore
  • WebCore-tests.exp: Tests needed access to QPoint, QString, and KURL symbols that were formerly exported for the benefit of WebKit.
  • kwq/KWQPixmap.mm: I needed to touch something since .exp files don't cause a rebuild, so I fixed a comment in here.
4:49 PM Changeset in webkit [1554] by darin
  • 61 edits
    4 adds
    1 delete in trunk

WebCore:

Changes to WebCore that allow WebKit to work through Objective C without going
straight to the KHTML headers. Also remove a bunch of unused stuff, especially
in QPainter.

  • WebCore.exp: Export the new classes WebCoreCache and WebCoreJavaScript. Don't export any C++ symbols at all.
  • WebCore.pbproj/project.pbxproj: Remove KWQWMatrix.mm, add WebCoreCache.* and WebCoreJavaScript.*.
  • khtml/khtml_part.cpp: Put more unused code inside ifndef APPLE_CHANGES.
  • khtml/khtmlview.cpp: Put unused code inside #ifndef APPLE_CHANGES
  • khtml/khtmlview.h: Put unused virtual functions inside #ifndef APPLE_CHANGES.
  • khtml/misc/loader.cpp: (CachedImage::tiled_pixmap): Change this so it always returns pixmap(). Handling it at this level is better than changing all the callers for now.
  • khtml/rendering/render_box.cpp: (RenderBox::printBackground): Took out the APPLE_CHANGES now that tiled_pixmap() always just returns pixmap().
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): Put some unused code inside APPLE_CHANGES.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestFrame): Made it get the view using the bridge, since we don't have a [widget] method on the frame any more. (KWQKHTMLPartImpl::findFrame): Used committedBridge instead of bridge, since I changed bridge to return the provisional if available. (KWQKHTMLPartImpl::frames): Used committedBridge instead of bridge, since I changed bridge to return the provisional if available.
  • kwq/qt/qpixmap.h: Put an empty version of QWMatrix in here. We don't actually ever need a real matrix, just a class to let us compile.
  • kwq/qt/qpainter.h: Moved QWMatrix into qpixmap.h. Removed constructors that take QPixmap and QWidget. Removed unused variants of drawText. Removed unused setClipping, setClipRect, hasClipping, translate, scale, begin, end, and device functions.
  • kwq/KWQPainter.mm: (QPainter::QPainter): Remove the constructors that take a paint device, widget, or pixmap. We can get away without them. (QPainter::save): Simplify. Also remove the optimization for painters without stacks, since having an empty stack is very inexpensive. (QPainter::restore): Simplify. (QPainter::_drawPoints): Move paintingDisabled check in here. (QPainter::drawText): Removed many unused drawText variants.
  • kwq/KWQView.h: Tweaked.
  • kwq/KWQView.mm: Removed [KWQView drawRect:].
  • kwq/KWQWMatrix.mm: Removed.
  • kwq/qt/qwidget.h: Removed paint() virtual function.
  • kwq/KWQWidget.mm: Removed QWidget::paint().
  • kwq/WebCoreBridge.h: Added new methods installInFrame:, removeFromFrame, mouseDown:, mouseUp:, mouseMoved:, mouseDragged:, copyDOMTree:, and copyRenderTree:.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge dealloc]): Call removeFromFrame. (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Don't return the view any more, also set bridgeOwnsKHTMLView to YES. (-[WebCoreBridge copyDOMNode:DOM::copier:]): Added helper method for copyDOMTree. (-[WebCoreBridge copyDOMTree:]): Added method to be used by IFDOMNode to get at DOM tree without using C++. (-[WebCoreBridge copyRenderNode:khtml::copier:]): Added helper method for copyRenderTree. (-[WebCoreBridge copyRenderTree:]): Added method to be used by IFRenderNode to get at render tree without using C++. (-[WebCoreBridge removeFromFrame]): Added. Deletes the view if we own it. We don't want to wait for dealloc time to do this, since a lingering view might be visible. (-[WebCoreBridge installInFrame:]): Added. Does a set of things we need to do at the time we commit a provisional data source. (-[WebCoreBridge addModifiers:toState:]): Moved here from IFHTMLView. (-[WebCoreBridge mouseUp:]): Added. Used to get a mouse up event to the KHTMLView. (-[WebCoreBridge mouseDown:]): Added. Used to get a mouse down event to the KHTMLView. (-[WebCoreBridge mouseMoved:]): Added. Used to get a mouse moved event to the KHTMLView. (-[WebCoreBridge mouseDragged:]): Added. Used to get a mouse moved event to the KHTMLView in the case where we are dragging -- perhaps could be merged with mouseMoved.
  • kwq/WebCoreCache.h: Added. Allows control of the WebCore cache; previously done directly in IFCache in WebKit.
  • kwq/WebCoreCache.mm: Added.
  • kwq/WebCoreFrame.h: Remove widget method. Change semantics of bridge method to return provisional bridge if available, which corresponds to what the widget method did before. Added a committedBridge method that has the semantics that bridge did before.
  • kwq/WebCoreJavaScript.h: Added. Returns statistics about the state of JavaScript objects; previously done directly in IFCache in WebKit.
  • kwq/WebCoreJavaScript.mm: Added.

WebKit:

Wean WebKit completely from getting at the C++ parts of WebCore.
We probably don't need to use C++ at all for WebKit any more.

  • WebKit.pbproj/project.pbxproj: Remove all the header search paths; we don't need any special ones now.
  • WebKitPrefix.h: Remove <config.h>; we don't need it any more.
  • Misc.subproj/IFCache.h: Rename getStatistics to statistics.
  • Misc.subproj/IFCache.mm: (+[IFCache statistics]): (+[IFCache empty]): (+[IFCache setDisabled:]): Call through WebCoreCache instead of going directly to khtml::Cache. (+[IFCache javaScriptObjectsCount]): (+[IFCache javaScriptInterpretersCount]): (+[IFCache javaScriptNoGCAllowedObjectsCount]): (+[IFCache javaScriptReferencedObjectsCount]): (+[IFCache garbageCollectJavaScriptObjects]): Call through WebCoreJavaScript instead of going directly to kjs::Collector.
  • WebCoreSupport.subproj/IFWebCoreFrame.m: (-[IFWebCoreFrame bridge]): Change to return bridge from the provisional data source if it exists. (-[IFWebCoreFrame committedBridge]): Do what [bridge] used to do, always returning the bridge from the committed data source and never the provisional one.
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Don't store the provisional widget. It's stored in the bridge for the provisional data source. (-[IFHTMLView provisionalDataSourceCommitted:]): Use the bridge method installInFrame: to do most of the work that used to be here. The rest is don in removeFromFrame which is called elsewhere. (-[IFHTMLView mouseUp:]): Use the bridge's mouseUp method. (-[IFHTMLView mouseDown:]): Use the bridge's mouseDown method. (-[IFHTMLView mouseMovedNotification:]): Use the bridge's mouseMoved method. (-[IFHTMLView mouseDragged:]): Use the bridge's mouseDragged method.
  • WebView.subproj/IFHTMLViewPrivate.h: Remove the widget, widgetOwned, and provisionalWidget instance variables, and the _widget and _provisionalWidget methods.
  • WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _reset]): Remove the code that deleted the widget and the provisional widget. This is now handled elsewhere.
  • WebView.subproj/IFDOMNode.mm: Redo to use the copyDOMTree feature of the bridge.
  • WebView.subproj/IFRenderNode.mm: Redo to use the copyRenderTree feature of the bridge.
  • WebView.subproj/IFRenderNode.h: Use an NSRect instead of four integers (the switch to floating point is OK).
  • WebView.subproj/IFWebDataSourcePrivate.h: Add private _removeFromFrame method.
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _removeFromFrame]): Set the controller and location change handler references to nil, and also call [WebCoreBridge removeFromFrame].
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate setDataSource:]): Use _removeFromFrame where we formerly would set the controller and location change handler references to nil.
  • WebCoreSupport.subproj/IFWebCoreBridge.h: Tweak.

WebBrowser:

  • Debug/CacheController.m: (-[CacheController refreshWebCoreStatisticsMatrix]): Change name of method from getStatistics to statistics.
Note: See TracTimeline for information about the timeline view.