Timeline



Jul 20, 2002:

9:59 PM Changeset in webkit [1613] by darin
  • 4 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Turn stricter warnings back on now that we don't use C++ any more.
  • Plugins.subproj/WebPluginView.m: (-[WebPluginView sendActivateEvent:]): Fix cast that stricter warning didn't like. (-[WebPluginView sendUpdateEvent]): Fix cast that stricter warning didn't like. (-[WebPluginView frameStateChanged:]): Remove unneeded cast that stricter warning didn't like.
9:40 PM Changeset in webkit [1612]
  • 16 copies in tags/KDE_3_0_2

This commit was manufactured by cvs2svn to create tag 'KDE_3_0_2'.

9:40 PM Changeset in webkit [1611] by darin
  • 207 edits in branches/kde

Check in KDE 3.0.2 sources again, this time on the right server.

9:39 PM Changeset in webkit [1610] by darin
  • 9 deletes in branches/kde

No Makefiles in kde branch.

7:48 PM Changeset in webkit [1609] by hyatt
  • 10 edits in trunk/WebCore

Fixing the FOUC problem.

7:37 PM Changeset in webkit [1608] by darin
  • 3 edits in trunk/WebKit
  • fixed 2999643 -- Leak of NSSet in -[IFStandardPanels _didStartLoadingURL:inController:]

This is another case of the leak I fixed a month ago. I don't know how I managed to
overlook this other code path with the identical bug.

  • Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels _didStopLoadingURL:inController:]): Fix a leak caused by calling the wrong method. This was calling objectForKey: instead of removeObjectForKey:.
7:22 PM Changeset in webkit [1607] by darin
  • 8 edits in trunk

WebCore:

  • khtml/css/css_ruleimpl.cpp: (CSSImportRuleImpl::~CSSImportRuleImpl): Fix a potential leak by doing setParent(0) here just as is done in CSSMediaRuleImpl.
  • kwq/WebCoreBridge.h: Fix a misspelling of visible.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge areToolbarsVisible]): (-[WebBridge isStatusBarVisible]): Fix misspelling of visible.

WebBrowser:

  • fixed 2999637 -- CFStringRef leak in -[IFWebDataSource(IFPrivate) _setTitle:]
  • BrowserDocument.m: (-[BrowserDocument pageName]): Remove inexplicable "retain" call.
  • fixed another storage leak
  • LocationTextField.m: (-[LocationTextField setIcon:]): Release the icon when done.
6:22 PM Changeset in webkit [1606] by mjs
  • 19 edits in trunk

WebCore:

Changed the code to handle "icon" and "SHORTCUT ICON" links
separately, and give higher priority to the former.

  • fixed 3003672 - Assertion failure related to iconloader on metafilter
  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): Changed to handle both "icon" and "SHORTCUT ICON" links properly.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::setIconURL): Moved here from KWQKHTMLPartImpl to do it more the way KDE does. (KHTMLPartBrowserExtension::setTypedIconURL): New method for handling moz-style icon links, which include a type as well as a URL.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::loadIcon): Removed.
  • kwq/WebCoreBridge.h: Prototype setIcon: and setIcon:withType: methods.
  • kwq/khtml/khtml_ext.h: Prototype new methods.
  • kwq/kparts/browserextension.h: Make setIcon pure virtual instead of a no-op.

WebKit:

Changed the code to handle "icon" and "SHORTCUT ICON" links
separately, and give higher priority to the former.

Also, we don't start loading the icon the moment khtml finds one
in the document any more, instead we wait until the document is
done loading, in case there are both "icon" and "SHORTCUT ICON"
link tags.

  • fixed 3003672 - Assertion failure related to iconloader on metafilter
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setIconURL:]): Forward to the data source. (-[WebBridge setIconURL:withType:]): Likewise.
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Release iconURL. (-[WebDataSource _setDefaultIconURLIfUnset]): Renamed from _loadPageIconIfNecessary, and changed to only set iconURL rather than actually loading. (-[WebDataSource _setPrimaryLoadComplete:]): Call _loadIcon instead of _loadPageIconIfNecessary, since we defer all loads to this point. (-[WebDataSource _loadIcon]): Load current iconURL if set. (-[WebDataSource _setIconURL:]): Set iconURL if not set already (since typed icons are higher priority). (-[WebDataSource _setIconURL:withType:]): Set the iconURL.
2:12 PM Changeset in webkit [1605] by darin
  • 12 edits in trunk/WebKit
  • fixed 2999616 -- Possible leak in +[IFPluginDatabase installedPlugins]
  • Plugins.subproj/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): Move the code into an init function. (pluginLocations): Simplified. (-[WebPluginDatabase init]): Added. Cleaned up a bit, and made it release the WebPlugin objects -- this was the leak. (-[WebPluginDatabase dealloc]): Added.
  • Plugins.subproj/WebPluginDatabase.h: Tweaked formatting.
  • Plugins.subproj/WebPluginStream.h:
  • Plugins.subproj/WebPluginStream.m: (-[WebPluginStream startLoad]): (-[WebPluginStream stop]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]): (-[WebSubresourceClient WebResourceHandleDidCancelLoading:]): (-[WebSubresourceClient WebResourceHandleDidFinishLoading:data:]): (-[WebSubresourceClient WebResourceHandle:didFailLoadingWithResult:]):
  • WebView.subproj/WebDataSource.m: (-[WebDataSource stopLoading]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _startLoading:]): (-[WebDataSource _addResourceHandle:]): (-[WebDataSource _removeResourceHandle:]): Changed code that called it a URLHandle to say resourceHandle.
  • WebView.subproj/WebFrame.m: (-[WebFrame dealloc]): Add an autorelease pool here since this is called from a timer and AppKit does not use an explicit autorelease pool in that case. This makes the "world leak check" work better, and is mildly helpful in other cases too. Radar 3003650 is a request for the AppKit team to fix this, but this workaround will do for now.

Jul 19, 2002:

5:00 PM Changeset in webkit [1604] by darin
  • 28 edits in trunk/WebKit

WebFoundation:

  • CacheLoader.subproj/WebResourceClient.h: Renamed a couple of the client protocol methods to remove a double mention of the word "resource".
  • CacheLoader.subproj/WebResourceCallbackClient.m:
  • CacheLoader.subproj/WebResourceHandle.m: Updated for the above name change.
  • WebFoundation.pbproj/project.pbxproj: Moved the C APIs to their own group.

WebKit:

  • fixed 3001951 -- Massive memory leak after running base or static PLT
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _makeRepresentation]): Add a missing release.

Reduced our use of autorelease. This allows the page load test to detect leaks of the
world much more easily. We may later find we need to use the "retain autorelease" idiom
in a few more places, but I did a lot of testing and that did not show up.

  • Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _setTopBookmark:]): Use a plain release. (-[WebBookmarkGroup _loadBookmarkGroupGuts]): Use a plain release.
  • Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList copyWithZone:]): Use a plain release.
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]): Use a plain release.
  • Plugins.subproj/WebPluginView.m: (-[WebPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): Use a plain release.
  • WebView.subproj/WebController.m: (-[WebController createFrameNamed:for:inParent:allowsScrolling:]): Use a plain release. (-[WebController setWindowContext:]): Use a plain release. (-[WebController setResourceProgressHandler:]): Use a plain release. (-[WebController setDownloadProgressHandler:]): Use a plain release. (-[WebController setPolicyHandler:]): Use a plain release.
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Use plain release.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Use plain release. (-[WebDataSource _setPrimaryLoadComplete:]): Use plain release. (-[WebDataSource _setTitle:]): Use plain release.
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Use plain release. (-[WebFrame reset]): Invalidate and release the timer.
  • WebView.subproj/WebFramePrivate.h: Keep a reference to the timer.
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Invalidate and release the timer. Use plain release. (-[WebFramePrivate setName:]): Use plain release. (-[WebFramePrivate setWebView:]): Use plain release. (-[WebFramePrivate setDataSource:]): Use plain release. (-[WebFramePrivate setProvisionalDataSource:]): Use plain release. (-[WebFrame _scheduleLayout:]): Keep a reference to the timer. (-[WebFrame _timedLayout:]): Release and nil the timer.
  • WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithName:rect:view:children:]): Use plain release.
  • WebView.subproj/WebView.m: (-[WebView concludeDragOperation:]): Use plain release.
  • WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]): Use plain release.

Other changes to make the new page load test feature work.

  • Misc.subproj/WebKitStatistics.h:
  • Misc.subproj/WebKitStatistics.m: (+[WebKitStatistics HTMLRepresentationCount]): Added a stat for WebHTMLRepresentation objects.
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation init]): Bump the count. (-[WebHTMLRepresentation dealloc]): Decrement the count.

Renaming.

  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebKitStatisticsPrivate.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics emptyCache]): (+[WebCoreStatistics setCacheDisabled:]): Renamed to include the word cache now that the class does not.
  • Plugins.subproj/WebPluginStream.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebView.subproj/WebMainResourceClient.m: Updated for the WebFoundation renaming.

WebBrowser:

  • fixed 3002602 -- make Page Load Test close windows, check for leaked JS interpreters before and after
  • AppController.m:
  • Debug/CacheController.m: Update for WebCoreStatistics method name changes.
  • BrowserWebController.m: Tweak.
  • Test/PageLoadTest.nib: Add new button to control whether we do "leak the world" checking.
  • Test/PageLoadTestController.h: New action and outlet for leak the world button.
  • Test/PageLoadTestController.m: (-[PageLoadTestController init]): New notification for leak the world message. (-[PageLoadTestController windowDidLoad]): Add code for leak the world button and new default. (-[PageLoadTestController toggleCheckForWorldLeaks:]): Added. (-[PageLoadTestController detectedWorldLeak:]): Added. Puts up sheet. (-[AppController pageLoadTestController]): Moved global in here so it can be more private.
  • Test/PageLoadTestLogger.m: Updated for url -> URL method name change.
  • Test/PageLoadTestRunner.h: Add method to control leak the world checking. Also do url -> URL.
  • Test/PageLoadTestRunner.m: (-[NSWindow closeIfBrowserWindow]): Added. Used to close all browser windows for leak the world checking. (-[PageLoadTestRunner init]): Default for checkForWorldLeaks is YES. (-[PageLoadTestRunner clearCacheWithURL:]): Update for empty cache method name change. (-[PageLoadTestRunner addLeakToArray:count:name:]): Added. Helper for constructing string. (-[PageLoadTestRunner closeBrowserWindows]): Added. (-[PageLoadTestRunner finishCheckingForWorldLeaks]): Added; done after a delay. (-[PageLoadTestRunner checkForWorldLeaks]): Do the leak check. (-[PageLoadTestRunner checkForWorldLeaksNow]): Do the leak check without delay. (-[PageLoadTestRunner testDone]): Check for leaks when the test is done. (-[PageLoadTestRunner start]): Check for world leak objects before the test starts. (-[PageLoadTestRunner pageLoadStarted:]): Use our own autorelease pool to make objects less "lingery". (-[PageLoadTestRunner pageLoadDone:]): Use our own autorelease pool to make objects less "lingery". (-[PageLoadTestRunner setCheckForWorldLeaks:]): Added.
2:19 PM Changeset in webkit [1603] by cblu
  • 9 edits in trunk

top level:

  • Site/favicon.ico: Removed.

WebCore:

Per darin, only define loadIcon in KWQKHTMLPartImpl

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process):
  • khtml/khtml_part.cpp:
  • khtml/khtml_part.h:

WebKit:

  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadPageIconIfNecessary]): use the correct relative string to request favicon.ico
12:58 PM Changeset in webkit [1602] by cblu
  • 4 edits in trunk/WebKit
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem image]): call [WebIconLoader defaultIcon]
  • Misc.subproj/WebIconLoader.m: (+[WebIconLoader defaultIcon]): move bundle image loading code from [WebHistoryItem image] to here.
12:36 PM Changeset in webkit [1601] by cblu
  • 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

Fixed build failure by making WebIconLoader.h public

12:04 PM Changeset in webkit [1600] by cblu
  • 22 edits
    2 adds in trunk

top level:

  • Site/favicon.ico: Added.

WebCore:

Added support favicons.

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): added an APPLE_CHANGES
  • khtml/khtml_part.cpp: (KHTMLPart::loadIcon): added
  • khtml/khtml_part.h: added loadIcon
  • kwq/KWQKHTMLPartImpl.h: added loadIcon
  • kwq/KWQKHTMLPartImpl.mm: added loadIcon (KWQKHTMLPartImpl::loadIcon):
  • kwq/WebCoreBridge.h: added loadIcon

WebKit:

Added support favicons.

  • Misc.subproj/WebIconLoader.h: Added.
  • Misc.subproj/WebIconLoader.m: Added. (-[WebIconLoaderPrivate dealloc]): (+[WebIconLoader defaultIcon]): (-[WebIconLoader initWithURL:]): (-[WebIconLoader dealloc]): (-[WebIconLoader setDelegate:]): (-[WebIconLoader startLoading]): (-[WebIconLoader startLoadingOnlyFromCache]): (-[WebIconLoader stopLoading]): (-[WebIconLoader WebResourceHandleDidBeginLoading:]): (-[WebIconLoader WebResourceHandleDidCancelLoading:]): (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]): (-[WebIconLoader WebResourceHandle:resourceDataDidBecomeAvailable:]): (-[WebIconLoader WebResourceHandle:resourceDidFailLoadingWithResult:]): (-[WebIconLoader WebResourceHandle:didRedirectToURL:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadIcon:]): added
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _loadPageIconIfNecessary]): added (-[WebDataSource _setPrimaryLoadComplete:]): start loading icon (-[WebDataSource _stopLoading]): stop icon loader (-[WebDataSource receivedPageIcon:]): added (-[WebDataSource _loadIcon:]): added
  • WebView.subproj/WebLocationChangeHandler.h:

WebBrowser:

Added support favicons.

  • BrowserDocument.m: (-[BrowserDocument _receivedPageIcon:]): added
  • BrowserDocumentPrivate.h:
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController frameLoadCommitted:]): switch to default icon (-[BrowserWindowController mouseDownInRightButton:]): (-[BrowserWindowController setPageIcon:]): added
  • LocationChangeHandler.m: (-[LocationChangeHandler receivedPageIcon:forDataSource:]): added
  • LocationTextField.h:
  • LocationTextField.m: (-[LocationTextField setDisplayAttributes]): (-[LocationTextField setIcon:]): set the icon size to 16x16
  • Resources/Images/url_icon.tiff: Removed.
  • TextFieldWithControls.h:
  • TextFieldWithControls.m: renamed _completeImage to _backgroundImage (-[TextFieldWithControls dealloc]): (-[TextFieldWithControls backgroundImage]): (-[TextFieldWithControls setFrameSize:]): (-[TextFieldWithControls showRightButton:]): (-[TextFieldWithControls setLeftCapImage:]): (-[TextFieldWithControls setRightCapImage:]): (-[TextFieldWithControls setMiddleImage:]): (-[TextFieldWithControls setLeftButtonImage:withOrigin:]): (-[TextFieldWithControls setRightButtonImage:withOrigin:]):
  • WebBrowser.pbproj/project.pbxproj:
11:16 AM Changeset in webkit [1599] by darin
  • 3 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Forgot to export WebKitStatistics.h so it can be used by WebBrowser.
11:02 AM Changeset in webkit [1598] by darin
  • 15 edits
    3 adds in trunk

WebCore:

  • khtml/css/makeprop: Fail if we don't find gperf.
  • khtml/misc/makeattrs: Fail if we don't find gperf.
  • khtml/misc/maketags: Fail if we don't find gperf.

WebKit:

Added some stats that we can use to sniff out "leak the world" problems.

  • Misc.subproj/WebKitStatistics.h: Added.
  • Misc.subproj/WebKitStatistics.m: Added.
  • Misc.subproj/WebKitStatisticsPrivate.h: Added.
  • WebKit.pbproj/project.pbxproj: Added new files.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge init]): Bump count. (-[WebBridge dealloc]): Decrement count.
  • WebView.subproj/WebController.m: (-[WebController initWithView:provisionalDataSource:]): Bump count. (-[WebController dealloc]): Decrement count.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:attributes:flags:): Bump count. (-[WebDataSource dealloc]): Decrement count.
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Bump count. (-[WebFrame dealloc]): Decrement count.
  • WebView.subproj/WebView.m: (-[WebView initWithFrame:]): Bump count. (-[WebView dealloc]): Decrement count.
3:43 AM Changeset in webkit [1597] by mjs
  • 6 edits in trunk/WebKit

More refactoring: Use assertions to make sure a provisional data
source's bridge is never used - and then fix the places where it
would have been used. :-)

  • WebView.subproj/WebDataSource.m: (-[WebDataSource documentTextFromDOM]): Return nil if the document is not committed.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Don't tell the bridge to stop if we're provisional, because we won't have one. (-[WebDataSource _setFinalURL:]): Don't try to set the bridge URL if we are not committed - it will get set at commit time. (-[WebDataSource _removeFromFrame]): Assert that the data soource is committed - a provisional data source should never be removed from a frame because it should never be in a frame in the first place. (-[WebDataSource _bridge]): Assert that the view is committed. (-[WebDataSource _commitIfReady]): Do nothing if already committed. (-[WebDataSource _receivedData:]): Notice that first byte was read, if appropriate, and commit when ready.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:didRedirectToURL:]): Simplify code by using [WebDataSource _receivedData:]
2:33 AM Changeset in webkit [1596] by mjs
  • 4 edits in trunk/WebCore
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge installInFrame:]): Assert that this bridge is either for the main frame, or that it's frame has a render part. If neither of these conditions is met, the view will never get installed in the view hiearchy leading to nasty silent failure; and this condition should be guaranteed.
2:13 AM Changeset in webkit [1595] by mjs
  • 4 edits in trunk/WebKit

Fix a regression caused by a previous commit that broke frames.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Instead setting the data source implicitly here, and doing other special first-time init, simply assert that we have a data source. (-[WebBridge setDataSource:]): Do the extra work when setting the data source here instead.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): After making the representation, set the data source, because we no longer pass the first data chunk _before_ transitioning to committed, instead we do it right after, so the logic in WebBridge to do it implicitly was not going to cut it.

Jul 18, 2002:

10:10 PM Changeset in webkit [1594] by mjs
  • 6 edits in trunk/WebKit

More refactoring: Simplify a bit more by moving more logic into
the data source.

  • WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _gotFirstByte]): Removed. (-[WebDataSource _setGotFirstByte]): Removed. (-[WebDataSource _isReadyForData]): Removed. (-[WebDataSource _receivedData:]): Commit if appropriate, and pass data to representation and documentView.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:resourceDataDidBecomeAvailable:]): Change the check back to policy != None, because the first chunk will trigger a commit in the policy == Show case, so there is no need to worry about it.
9:37 PM Changeset in webkit [1593] by mjs
  • 7 edits in trunk/WebKit

Rename some methods for clarity. These two methods are defined by
the end state, not the start state (in fact,
transitionToLayoutAcceptable does most of it's work when it starts
in the cimmitted state, not provisional).

  • WebView.subproj/WebFramePrivate.h, WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToLayoutAcceptable]): Renamed from _transitionProvisionalToLayoutAcceptable. (-[WebFrame _transitionToCommitted]): Renamed from _transitionProvisionalToLayoutAcceptable.

And adjust all the calls to them:

  • WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
9:13 PM Changeset in webkit [1592] by mjs
  • 18 edits in trunk/WebKit

Even more exciting refactoring. Change the rules for committing
the data source and creating the representation so that both
happen when the first byte has been received _and_ the content
policy has been set to show. Previously these actions happened at
different times. Now we maintain the invariant that the data
source has a representation if and only if it is committed.

  • WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Simplify further by putting more of the work in WebDataSource.
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):
  • WebView.subproj/WebDataSource.h, WebView.subproj/WebDataSource.m: Move makeRepresentation method to private file.
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setContentPolicy:]): If the policy is set to show, commit if we have already gotten the first byte. (-[WebDataSource _commitIfReady]): Create representation and commit if we have the first byte and have a policy of show. (-[WebDataSource _gotFirstByte]): Method to check if this data source has gotten the first byte yet. Commit here if ready. (-[WebDataSource _setGotFirstByte]): Method to report that some data has been received. (-[WebDataSource _makeRepresentation]): Make and set up teh document view too. (-[WebDataSource _isReadyForData]): Return TRUE if policy is set (and if the policy is Show, if we have also received the first byte.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionProvisionalToCommitted]): Don't call the datasource (it now calls us)
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:resourceDataDidBecomeAvailable:]):
  • WebView.subproj/WebView.h, WebView.subproj/WebView.m: move makeDocumentViewForDataSource...
  • WebView.subproj/WebViewPrivate.h, WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]): To here.
5:06 PM Changeset in webkit [1591] by hyatt
  • 4 edits in trunk/WebCore
  • khtml/css/css_valueimpl.cpp: Changed the QRegExps used for font family matching to statics. Helped out one page on the base tests a fair bit. Overall (spread over all 40 pages) it's not that big though.
12:05 PM Changeset in webkit [1590] by mjs
  • 3 edits in trunk/WebKit

Avoid throwing an exception while stopping animations. Image
renders were getting into the array multiple times, which means
the code that iterated over the array backwards could throw an
exception, because callling removeObject: on the array would remove
all instances of the object.

This probably fixes the following crashers, and a bunch of huge leaks:

Radar 2999853 - Uninitialized memory access in plugins on theonion.com
Radar 2999892 - Crash disconnecting view from next view chain on theonion.com
Radar 2999911 - Infinite loop in [WebHTMLView dealloc], resulting in crash

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer scheduleFrame]): Move adding to array of image renderers from here... (-[WebImageRenderer beginAnimationInRect:fromRect:]): To here.
11:22 AM Changeset in webkit [1589] by hyatt
  • 4 edits in trunk/WebCore

Small change that gives us 25% speedup (uncached) on the cvs-base suite.

  • khtml/css/cssstyleselector.cpp: Optimized CLASS style comparison to avoid allocing QStrings when the CLASS attribute only contains one entry (as opposed to a list of entries).
9:35 AM Changeset in webkit [1588]
  • 3 copies in tags/Alexander-13

This commit was manufactured by cvs2svn to create tag 'Alexander-13'.

9:35 AM Changeset in webkit [1587] by sheridan
  • 8 edits in trunk

markers & version for Alex-13

1:46 AM Changeset in webkit [1586] by mjs
  • 7 edits in trunk/WebKit

Yet still more refactoring in preparation for the KHTMLPart
change. This is preparing things to change the commit rule to
require receiving at least one byte of data, and having the
content policy set to Show.

  • WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Remove more code since makeRepresentation now does most of the work.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource makeRepresentation]): Tell the WebView (if any) to create the documentView now too.
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView makeDocumentViewForDataSource:]): Hook document view up to data source.
12:47 AM Changeset in webkit [1585] by mjs
  • 5 edits in trunk/WebKit

Some refactoring in preparation for the KHTMLPart change.

  • WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Bail early if not loading. (-[WebDataSource _commit]): Method to mark when the data source is committed (it now knows whether it's committed or provisional). This will be useful for adding assertions later on about what operations may happen only when committed, and which can only happen when provisional.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionProvisionalToCommitted]): Call data source's _commit method.

Jul 17, 2002:

8:55 PM Changeset in webkit [1584] by rjw
  • 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

Made WebDocument.h public.

8:13 PM Changeset in webkit [1583] by rjw
  • 3 edits in trunk/WebKit
  • WebView.subproj/WebHTMLView.m: Removed unnecessary (and incorrect) lockFocus.
3:24 PM Changeset in webkit [1582] by mjs
  • 14 edits in trunk/WebKit

Some refactoring in preparation for the KHTMLPart change.

  • WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Move more of the work of creating and setting the representation and document view into WebDataSource and WebView.
  • WebView.subproj/WebDataSource.h, WebView.subproj/WebDataSource.m: (+[(id <WebDocumentRepresentation>) createRepresentationForMIMEType:]): Removed. (-[WebDataSource makeRepresentation]): A method to build the right kind of representation for the content type.
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _representationClass]): Method to get the right representation class for the current content type. (-[WebDataSource _bridge]): Move here from WebBridge.[mh], so we can later add an assertion that the data source is not provisional.
  • WebView.subproj/WebHTMLViewPrivate.m: #import WebDataSourcePrivate.h
  • WebView.subproj/WebView.h, WebView.subproj/WebView.m: (+[(id <WebDocumentRepresentation>) createDocumentViewForMIMEType:]): Removed. (-[WebView makeDocumentViewForMIMEType:]): Method to build the right kind of document view for the specified MIME type.
3:02 PM Changeset in webkit [1581] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Take out bogus check for nil path -- a URL with a nil path is OK, for example "about:blank". Also improved log message.

Jul 16, 2002:

9:26 PM Changeset in webkit [1580] by darin
  • 5 edits in trunk/WebKit

WebKit:

  • History.subproj/WebBackForwardList.m: Replace MyCompanyName with Apple Computer. (-[WebBackForwardList init]): Fix strange [super init] logic to be standard.
  • History.subproj/WebHistoryItem.h: Replace MyCompanyName with Apple Computer.
  • Misc.subproj/WebDownloadHandler.h: Replace MyCompanyName with Apple Computer.

WebBrowser:

  • LocationTextField.h: Replace MyCompanyName with Apple Computer.
  • LocationTextField.m: Replace MyCompanyName with Apple Computer.
9:15 PM Changeset in webkit [1579] by darin
  • 7 edits in trunk/WebKit
  • fixed 2997891 -- Alexander confused about base page URL for relative links
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient WebResourceHandle:didRedirectToURL:]): Don't tell the bridge the URL changed. The bridge doesn't care about redirects for subresources (and if it did, we'd need some way to tell it that this was a subresource redirect).
  • WebCoreSupport.subproj/WebBridge.m: Formatting tweaks.
  • WebCoreSupport.subproj/WebImageRenderer.m: Formatting tweaks.
  • WebView.subproj/WebView.m: Formatting tweaks.
7:39 PM Changeset in webkit [1578] by rjw
  • 3 edits in trunk/WebKit

Really, stop animation if last frame has zero duration, like IE.
Was checking adjustedFrameDuration, which is never zero.

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer unadjustedFrameDuration]): (-[WebImageRenderer frameDuration]): (-[WebImageRenderer nextFrame:]):
6:14 PM Changeset in webkit [1577] by mjs
  • 2 edits in trunk/WebKit

WebKit:
Corrected bug number in previous ChangeLog message.

5:48 PM Changeset in webkit [1576] by mjs
  • 15 edits in trunk

WebCore:

Moved URL mouseover status to KWQKHTMLPartImpl, and made it
responsive to modifier key presses, if enabled. Fixes:

Radar 2980152 - Link mouseover status messages are not localizable
Radar 2982043 - Link mouse-over status should change in response to modifier keys

  • khtml/khtml_part.cpp: (KHTMLPart::overURL): Remove extensive APPLE_CHANGES, and just call the impl method.
  • kwq/KWQKHTMLPartImpl.h: Prototype overURL method.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Construct status messages using format strings for localizability; change message in response to modifiers if modifier tracking is enabled.
  • kwq/WebCoreBridge.h: Prototype modifierTrackingEnabled method.

WebKit:

WebKit part of fix for:

Radar 2982043 - Link mouseover status messages are not localizable

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge modifierTrackingEnabled]): Implemented by checking bit on WebHTMLView class.
  • WebKit.pbproj/project.pbxproj: Install WebHTMLViewPrivate as a Private header.
  • WebView.subproj/WebHTMLViewPrivate.h: Prototype new modifier tracking SPI.
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView _setModifierTrackingEnabled:]): Method to inform WebHTMLView that modifier tracking is working. (+[WebHTMLView _modifierTrackingEnabled]): Obligatory getter. (+[WebHTMLView _postFlagsChangedEvent:]): Method to report flagsChanged events. Creates corresponding fake mouseMoved event and sends it as a notification.

WebBrowser:

WebBrowser part of fix for:

Radar 2982043 - Link mouseover status messages are not localizable

  • AppController.m: (-[AppController awakeFromNib]): Enable modifier tracking.
  • BrowserWindowController.m: (-[BrowserWindowController windowWillHandleKeyEvent:]): Post NSFlagsChanged events to WebHTMLView.
5:11 PM Changeset in webkit [1575] by rjw
  • 5 edits in trunk/WebCore

Fixed field length test. We were testing >= instead of >.

  • kwq/KWQNSTextField.mm: (-[KWQNSTextFieldFormatter isPartialStringValid:newEditingString:errorDescription:]):
4:17 PM Changeset in webkit [1574] by darin
  • 10 edits in trunk

WebCore:

  • fixed 2997244 -- crash when visiting cnn.com followed by another page

Turns out the requestFrame code I've been tinkering with used to be
dead code until we accidentally re-triggered the code path.

  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach): Remove APPLE_CHANGES that were causing us to reuse the same frame which were an attempt to fix a frame targeting problem that was actually elsewhere.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Remove the code that handles the case of an already-existing frame with the same name. This is handled at a higher level.
  • kwq/WebCoreBridge.h: Remove now-unneeded childFrameNamed method.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: Remove childFrameNamed since it's not needed, and every one of these bridge methods adds potential confusion. (-[WebBridge descendantFrameNamed:]): Make this look for descendants in the provisional data sources first. This is the same change Richard made to childFrameNamed, but it turns out that this is the method that's really used.
2:11 PM Changeset in webkit [1573] by kocienda
  • 1 delete in branches/jaguar-branch/WebKit

Removed all the files that "magically" showed up on the branch as
a result of the Web* renaming. We don't want any renamed files on
the branch.

11:59 AM Changeset in webkit [1572] by darin
  • 5 edits in trunk/WebCore
  • fixed 2998692 -- crash when you type "googl" into the page address
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Check for a nil part here to restore the old behavior. Whether that's OK or not is another question that I'd prefer to deal with later.
9:17 AM Changeset in webkit [1571] by darin
  • 163 edits
    4 adds
    126 deletes in trunk

top level:

  • many files: Renamed IF* -> Web*.

Tools:

  • various files: Renamed IF* -> Web*.

WebFoundation:

  • almost every file: Renamed IF* -> Web*.

WebCore:

  • almost every file: Renamed IF* -> Web*.

WebKit:

  • almost every file: Renamed IF* -> Web*.

WebBrowser:

  • almost every file: Renamed IF* -> Web*.
6:56 AM Changeset in webkit [1570] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-07-16 Ken Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2997750 (Sherlock crashes at launch - reproducible on my machine 100%)

This is a bug that only occurs when a zer-length cache file is encountered.
The NSUnarchiver init method does not handle this situation, and throws an exception.
Hence, calls to NSUnarchiver must be done inside an NS_DURING. Note that this change
merely expands the scope of the already-existing NS_DURING to include
the NSUnarchiver init method.

  • Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase objectForKey:])
Note: See TracTimeline for information about the timeline view.