Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jul 23, 2002:

11:58 PM Changeset in webkit [1649] by cblu

• 14 edits in trunk

WebCore:

More plumbing for contextual menu support.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge completeURLForDOMString:]): renamed (-[WebCoreBridge elementInfoAtPoint:]): renamed
• kwq/qt/qpixmap.h: added an accessor to the WebCoreImageRenderer

WebKit:

More plumbing for contextual menu support.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementInfoAtPoint:]): added

9:01 PM Changeset in webkit [1648] by darin

• 10 edits in trunk

WebFoundation:

• WebFoundation.pbproj/project.pbxproj: Fix file reference types to be more consistent.

WebCore:

• WebCore.pbproj/project.pbxproj: Fix file reference types to be more consistent.

• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag): Changed indenting to use spaces, makes our diff with KDE smaller. (HTMLTokenizer::end): Remove unneeded APPLE_CHANGES.

• kwq/KWQDOMNode.cpp: Tweak.
• kwq/KWQDOMNode.h: Tweak.

WebKit:

• WebKit.pbproj/project.pbxproj: Fix file reference types to be more consistent.

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Fix file reference types to be more consistent.

7:46 PM Changeset in webkit [1647] by hyatt

• 4 edits in trunk/WebCore

Fix bug 2803155 - images not displayed on ​http://bscw.gmd.de.
My fix is to use our newfound quirks mode to implement a comment
parsing quirk (this is how Mozilla handles this same issue).
Only in quirks mode, the tokenizer will treat <!--> atomically as
a complete comment.

This is bug 34302 on bugs.kde.org, for those who are curious.

• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):

6:33 PM Changeset in webkit [1646] by cblu

• 13 edits
  2 adds in trunk

WebCore:

Initial plumbing for contextual menu support.

• WebCore.pbproj/project.pbxproj:
• kwq/KWQDOMNode.cpp: Added. (isImage):
• kwq/KWQDOMNode.h: Added.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge _URLForDOMString:]): added (-[WebCoreBridge _elementInfoForMouseEvent:]): added

WebKit:

Initial plumbing for contextual menu support.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge elementInfoForMouseEvent:]): added
• WebView.subproj/WebController.h:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): added

6:22 PM Changeset in webkit [1645] by rjw

• 4 edits in trunk/WebCore

Turn on find related code in part in preparation for
implementing find in WebKit.

• khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::clear): (KHTMLPart::findTextNext):

5:55 PM Changeset in webkit [1644] by darin

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Fix paths for newly added files.

5:53 PM Changeset in webkit [1643] by hyatt

• 6 edits in trunk/WebCore

Fixing two bugs here. The first is bug with @import sheets not inheriting strict parsing mode from their parent sheet.
This means all @import sheets are being treated as strict mode!

The second bug is in KWQ. We were never calling determineParseMode, so we always defaulted to strict mode, and therefore
were highly intolerant of unitless numbers on absolutely positioned blocks. This fixes many problems, notably www.netscape.com
and ZDNet.com on the cvs-base tests.

• khtml/css/cssparser.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write):

5:19 PM Changeset in webkit [1642] by rjw

• 16 edits
  2 adds in trunk/WebKit

Use one LocationChangeHandler.
Cleaned up (a little) fallback URL code. This code
is still a convoluted and could be further untaggled.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): (-[BrowserDocument tryMultipleURLs:]): (-[BrowserDocument _goToNextFallbackURL]):
• BrowserDocumentPrivate.h:
• BrowserWebController.h:
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): (-[BrowserWindowController frameLoadRedirected:]): (-[BrowserWindowController frameLoadTryingFallback]):
• LocationChangeHandler.h:
• LocationChangeHandler.m: (-[LocationChangeHandler initWithBrowserDocument:]): (-[LocationChangeHandler dealloc]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]): (-[LocationChangeHandler serverRedirectTo:forDataSource:]):

Cleaned up LocationChangeHandler. We now have one per controller.

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController policyHandler]): (-[WebController setLocationChangeHandler:]): (-[WebController locationChangeHandler]):
• WebView.subproj/WebControllerPolicyHandler.h:
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]):

(-[WebDataSource _setIsDummy:)
(-[WebDataSource _isDummy]):
Hack on hack. MJS will remove when the dummy data source hack is removed.

(-[WebDataSource _locationChangeHandler]):
(-[WebDataSource _removeFromFrame]):
(-[WebFrame initWithName:webView:provisionalDataSource:controller:]):
(-[WebFrame setProvisionalDataSource:]):

• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]):

Added default policy handler. This is used if no policy handler is
set on the controller.

• WebView.subproj/WebDefaultControllerPolicyHandler.h: Added.
• WebView.subproj/WebDefaultControllerPolicyHandler.m: Added. (-[WebDefaultControllerPolicyHandler initWithWebController:]): (-[WebDefaultControllerPolicyHandler URLPolicyForURL:]): (-[WebDefaultControllerPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultControllerPolicyHandler unableToImplementFileURLPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler requestContentPolicyForMIMEType:dataSource:]): (-[WebDefaultControllerPolicyHandler unableToImplementURLPolicyForURL:error:]): (-[WebDefaultControllerPolicyHandler unableToImplementContentPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]):
• WebView.subproj/WebFrame.m:

4:24 PM Changeset in webkit [1641] by darin

• 4 edits in trunk/WebCore

top level:

• Tests/kde/kurl-test.chk: Updated test results to match what real web browsers need to do rather than what the RFC says for paths beginning with "../" or "./".
• Tests/kde/kurl-test.cpp: (main): Add comments for tests where the results are not matching the RFC.

WebCore:

• fixed 3004818 -- relative urls are assembled incorrectly at ticketmaster
• fixed 2999279 -- Invalid URI in request at subpage of swatch.com

The issue here is URLs with paths that start with "/../". RFC 2396 says one
thing, and that's what CFURL does. But real web browsers do another thing.

• kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::KWQKURLPrivate): Clean up a bit by removing unneeded init(). (escapeQString): Don't make a copy of the passed-in QString. (pathEndsWithSlash): Don't make a copy of the passed-in QString. (copyEscapedPath): Make this a static function instead of extern. (KURL::KWQKURLPrivate::decompose): Add the new "../" and "./" logic.

4:09 PM Changeset in webkit [1640] by hyatt

• 5 edits in trunk/WebCore

• khtml/rendering/font.cpp: Fix deployment build bustage by including <algorithm>.

• khtml/rendering/render_frames.cpp: (RenderPartObject::calcReplacedWidth): Fix a bug with ​http://www.moveabletype.com's top portion not showing up (bug 2986714). A hack was being improperly applied to fixed width plugins, when it should have only been applied to variable width plugins.

11:48 AM Changeset in webkit [1639] by darin

• 7 edits in trunk

WebCore:

• Makefile.am: Clean based on all, not all-am, so it happens before subdirs if any.

WebKit:

• Makefile.am: Clean based on all, not all-am, so it happens before subdirs if any.

11:45 AM Changeset in webkit [1638] by darin

• 33 edits
  1 add in trunk

top level:

• Tests/kde/kurl-test.cpp: (main): Add a lot of new tests. One of them demonstrates the issue underlying bug 3004818. The others are taken straight from the URI RFC (2396).
• Tests/kde/kurl-test.chk: Expected results for new tests.

• autogen.sh: Add the new WebCore timestamp file.

WebCore:

Changes require a make clean because of the Project Builder bug.
So I added the "make clean timestamp" hackery.

• .cvsignore: Ignore the new clean timestamp.
• force-clean-timestamp: Added.
• Makefile.am: Add rules for making clean happen.

• khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler): Fix NULL dereference bug in here that I ran into. Code later down in the same function has the check for NULL, so clearly this is just a bug.

• khtml/rendering/font.cpp: (Font::drawText): Simplify by using new drawText that takes a QChar array, no need to make a QConstString.
• khtml/rendering/render_text.cpp: (TextSlave::printDecoration): Simplify by using new drawUnderlineForText that takes a QChar array, no need to make a QConstString.

• kwq/WebCoreTextRenderer.h: Change underline-drawing to use a UniChar array.

• kwq/qt/qpainter.h:
• kwq/KWQPainter.mm: (QPainter::drawText): Change to take QChar array instead of a QString, but also discovered a bizarre overloading thing that was happening before and dealt with that by adding a new drawText that still does take a QString. (QPainter::drawUnderlineForText): Change to take QChar array.

• kwq/qt/qcolor.h: Mark constructor explicit, so we don't get subtle strangess like where the string to draw was being converted to a QColor.

• khtml/css/cssstyleselector.cpp: No need for APPLE_CHANGES for this change any more.

• kwq/kdecore/kcharsets.h:
• kwq/KWQKCharsets.mm: Remove unused functions.

• kwq/khtml/khtml_settings.h:
• kwq/KWQKHTMLSettings.mm: Remove unused functions.

• kwq/qt/qfont.h:
• kwq/KWQFont.mm: Simplify.

• kwq/KWQPaintDeviceMetrics.mm: Simplify.

• kwq/qt/qtextcodec.h:
• kwq/KWQtextcodec.mm: (QTextCodec::codecForName): Remove unused parameter.

WebKit:

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawUnderlineForCharacters:stringLength:atPoint:withColor:]): Change API to take character array instead of a string.

• WebKit.pbproj/project.pbxproj: Took "subproj" off the names of some groups.

10:54 AM Changeset in webkit [1637] by hyatt

• 5 edits in trunk/WebCore

The STYLE element was ignoring both the media and type
attributes (unlike its cousin, the LINK element). This
patch implements support for media and type and further
stops us from loading stylesheets that we should have no
business parsing.

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): (HTMLStyleElementImpl::parseAttribute): (HTMLStyleElementImpl::insertedIntoDocument): (HTMLStyleElementImpl::removedFromDocument): (HTMLStyleElementImpl::childrenChanged): (HTMLStyleElementImpl::sheetLoaded):
• khtml/html/html_headimpl.h:

9:34 AM Changeset in webkit [1636]

• 3 copies in tags/Alexander-14

This commit was manufactured by cvs2svn to create tag 'Alexander-14'.

9:34 AM Changeset in webkit [1635] by sheridan

• 8 edits in trunk

Alex-14 versioning

12:34 AM Changeset in webkit [1634] by hyatt

• 4 edits in trunk/WebCore

• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): Oops. I accidentally removed the call to an ancestor class attach function. What made this subtle is that it deliberately skipped over a couple of base classes and called the one three superclasses up. When I went to put it back in, I messed up and called the base class instead of the distant ancestor.

Silly me. marvel.com and matadorrecords.com should be ok now.

Jul 22, 2002:

10:26 PM Changeset in webkit [1633] by darin

• 13 edits
  2 adds in trunk/WebCore

• khtml/rendering/render_text.cpp: (TextSlave::printSelection): Add comments to APPLE_CHANGES. (TextSlave::printDecoration): Add comments to APPLE_CHANGES. (TextSlave::checkSelectionPoint): Add comments to APPLE_CHANGES.

• khtml/xml/dom_stringimpl.cpp: Add comments to APPLE_CHANGES.

• khtml/xml/xml_tokenizer.cpp: (XMLTokenizer::end): Remove APPLE_CHANGES.
• kwq/KWQsignals.mm: Add a new signal dummy function.

• kwq/WebCoreJavaScript.h: Fix header.
• kwq/WebCoreJavaScript.mm: Fix header.

• kwq/WebCoreSettings.h: Added. Not used yet.
• kwq/WebCoreSettings.m: Added. Not used yet.
• WebCore.pbproj/project.pbxproj: Added WebCoreSettings.h and .m.

• English.lproj/InfoPlist.strings: Fixed a spelling error.

• kwq/WebCoreTextRendererFactory.h: Tweak.

10:04 PM Changeset in webkit [1632] by mjs

• 6 edits in trunk/WebCore

Fixed Radar 3004897 - assert at mapquest

• khtml/html/html_baseimpl.cpp: (HTMLIFrameElementImpl::attach): Put back frame name uniqueness check. Lack of this check was causing duplicate frames to be left floating in space.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Add an assertion that no frame of the requested name already exists.

6:05 PM Changeset in webkit [1631] by hyatt

• 6 edits in trunk/WebCore

Fix for bug 3004889, plugin content on stylesheet pages not
showing up. The rendering tree needed to perform an update
when all children had arrived, and this was being handled by
the parser. With async rendering construction, I had to store
this in the content node instead, so it could do the update
once the render object was built at a later date.

• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::attach):
• khtml/html/html_objectimpl.h:
• khtml/html/htmlparser.cpp: (KHTMLParser::processCloseTag):

3:30 PM Changeset in webkit [1630] by hyatt

• 11 edits in trunk/WebCore

This checkin adds support for querying the selected style set,
for querying the preferred style set, and for changing the
selected style set dynamically. With this checkin, a Web page
in Alexander now has the capability to present its own alternate
stylesheet UI in the page and to toggle between sets using script.

• khtml/dom/css_stylesheet.cpp: (DocumentStyle::preferredStylesheetSet): (DocumentStyle::setSelectedStylesheetSet): (DocumentStyle::selectedStylesheetSet):
• khtml/dom/css_stylesheet.h: Added new methods to the DocumentStyle interface as per Hixie's proposed spec.

• khtml/dom/dom_doc.cpp:
• khtml/dom/dom_doc.h:
• khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): (DOMDocument::tryPut): (DOMDocument::putValue):
• khtml/ecma/kjs_dom.h: Implement the JS binding glue for the new properties.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): (DocumentImpl::preferredStylesheetSet): (DocumentImpl::selectedStylesheetSet): (DocumentImpl::setSelectedStylesheetSet): (DocumentImpl::recalcStyleSelector):
• khtml/xml/dom_docimpl.h: The implementation of the new properties. Also fixed a bug caused by the 3.02 merge in the stylesheet filtering code in recalcStyleSelector.

1:19 PM Changeset in webkit [1629] by rjw

• 10 edits in trunk/WebKit

Moved back/forward list from Alex's document to WebController. First step
to address a series of back/forward related issues.

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController backForwardList]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): (-[WebControllerPrivate dealloc]):

Moved back/forward list from Alex's document to WebController. First step
to address a series of back/forward related issues.

• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument dealloc]): (-[BrowserDocument goToURL:]): (-[BrowserDocument _backForwardList]): (-[BrowserDocument canGoBack]): (-[BrowserDocument canGoForward]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]):

10:44 AM Changeset in webkit [1628] by cblu

• 3 edits in trunk/WebKit

WebKit:

Strip white space before and after URL string 2998696

• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_bestURLForDraggingInfo:]):

WebBrowser:

Added document icon.

• WebBrowser.pbproj/project.pbxproj:
• document.icns: Added.

7:59 AM Changeset in webkit [1627] by kocienda

• 3 edits in trunk/WebKit

• WebView.subproj/WebHTMLView.m: import of removed WebFrame bridge header was left in, causing a build break.

7:01 AM Changeset in webkit [1626] by mjs

• 17 edits
  4 deletes in trunk

WebCore:

Merged WebCoreBridge and WebCoreFrameBridge.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURLInFrame): Use bridge, not frameBridge. (KWQKHTMLPartImpl::urlSelected): Use bridge, not frameBridge. (KWQKHTMLPartImpl::submitForm): Use bridge, not frameBridge. (KWQKHTMLPartImpl::findFrame): Use bridge, not frameBridge. (KWQKHTMLPartImpl::frames): Use bridge, not frameBridge.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge dealloc]): Free RenderPart if set. (-[WebCoreBridge renderPart]): Moved here from WebFrameBridge. (-[WebCoreBridge setRenderPart:]): Moved here from WebFrameBridge. (-[WebCoreBridge copyRenderNode:khtml::copier:]): No more need to get render part from frame bridge. (-[WebCoreBridge installInFrame:]): No more need to get render part from frame bridge.
• kwq/WebCoreFrameBridge.h: Removed.
• kwq/WebCoreFrameBridge.mm: Removed.
• WebCore.exp: Removed WebCoreFrameBridge.
• WebCore.pbproj/project.pbxproj: Removed WebCoreFrameBridge.

WebKit:

Merged WebBridge and WebFrameBridge.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): Return bridges, not frameBridges. (-[WebBridge descendantFrameNamed:]): Return bridge, not frameBridge. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Return a bridge, not a frameBridge. (-[WebBridge mainFrame]): Return a bridge, not a frameBridge. (-[WebBridge frameNamed:]):Return a bridge, not a frameBridge. (-[WebBridge loadURL:attributes:flags:withParent:]): Moved from WebFrameBridge. (-[WebBridge loadURL:]): Moved from WebFrameBridge. (-[WebBridge postWithURL:data:]): Moved from WebFrameBridge.
• WebCoreSupport.subproj/WebFrameBridge.h: Removed.
• WebCoreSupport.subproj/WebFrameBridge.m: Removed.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Don't create a WebFrameBridge.
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): No longer dealloc frameBridge, since we don't have one. (-[WebFrame _transitionToCommitted]): Pass along the frame's render part, if any. (-[WebFrame _frameBridge]): Removed.
• WebKit.pbproj/project.pbxproj: Removed deleted files.

4:45 AM Changeset in webkit [1625] by mjs

• 8 edits in trunk/WebKit

Change WebBridge to hold on to a WebFrame instead of a
WebDataSource. Since we will no longer ever have a bridge for a
provisional data source, we'll just bind the bridge to a
frame. Which means we can merge the bridge and the frame bridge
next.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: Changed below methods to work with direct knowledge of the frame but not the bridge (mostly a simplification). (-[WebBridge frame]): (-[WebBridge parent]): (-[WebBridge childFrames]): (-[WebBridge descendantFrameNamed:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge openNewWindowWithURL:]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge areScrollbarsVisible]): (-[WebBridge setScrollbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge window]): (-[WebBridge setStatusText:]): (-[WebBridge mainFrame]): (-[WebBridge frameNamed:]): (-[WebBridge receivedData:withDataSource:]): (-[WebBridge objectLoadedFromCache:size:]): (-[WebBridge setFrame:]): (-[WebBridge dataSourceChanged]): (-[WebBridge dataSource]): (-[WebBridge openedByScript]): (-[WebBridge setOpenedByScript:]):

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): Set bridge's frame and notify that the data source changed.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Set bridge's frame.
• WebView.subproj/WebFramePrivate.h, WebView.subproj/WebFramePrivate.m: (-[WebFrame _bridge]): Method to get the bridge.

1:32 AM Changeset in webkit [1624] by mjs

• 11 edits in trunk

WebCore:

Removed provisional/committed distinction from WebCore and the
WebCore SPI. WebCore will never see a provisional data source or
provisional anything, any more.

• kwq/KWQScrollView.mm: Remove mention of provisional widget from comment.
• kwq/WebCoreFrameBridge.h: Remove commitedBridge method, and remove comment about provisionality from bridge method.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write): Remove bogus comment about provisional/committed transition. (KWQKHTMLPartImpl::findFrame): Call bridge, not committedBridge. (KWQKHTMLPartImpl::frames): Likewise.

WebKit:

Removed provisional/committed distinction from WebCore and the
WebCore SPI. WebCore will never see a provisional data source or
provisional anything, any more.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge descendantFrameNamed:]): Don't bother with the provisional bridge - no such thing. (-[WebBridge setDataSource:]): Assert the data source is committed.
• WebCoreSupport.subproj/WebFrameBridge.m: (-[WebFrameBridge bridge]): Return committed bridge always, and remove committed bridge method.

Jul 21, 2002:

10:38 PM Changeset in webkit [1623] by darin

• 109 edits
  1 add in trunk

JavaScriptCore:

• kjs/*: Roll KDE 3.0.2 changes in. Also switch to not using APPLE_CHANGES for some of the changes that we definitely want to contribute upstream.

WebCore:

• khtml/*: Roll KDE 3.0.2 changes in. Also switch to not using APPLE_CHANGES for some of the changes that we definitely want to contribute upstream.

• WebCore.pbproj/project.pbxproj: Add KWQStyle.mm, remove KWQStyle.h, moving contents into qstyle.h.

• kwq/KWQApplication.mm: (QApplication::globalStrut): Remove _logNotYetImplemented().

• kwq/KWQButton.mm: (QButton::QButton): Use plain release, not autorelease.
• kwq/KWQComboBox.mm: (QComboBox::init): Use plain release, not autorelease.
• kwq/KWQListBox.mm: (QListBox::QListBox): Use plain release, not autorelease.
• kwq/KWQPainter.mm: (QPainter::drawArc): Use plain release, not autorelease.

• kwq/KWQKHTMLPartBrowserExtension.mm: Remove import of KWQKHTMLPartImpl.h, now that it's always part of khtml_part.h.
• kwq/KWQKHTMLPartImpl.cpp: Simplify.
• kwq/KWQKHTMLPartImpl.h: Add wrapper to allow multiple inclusion. Don't include khtml_part.h any more, since that file now includes this one to minimize changes to KDE code that needs to get to functions in here.
• kwq/KWQKHTMLPartImpl.mm: (KHTMLPart::onURL), (KHTMLPart::nodeActivated), (KHTMLPart::setStatusBarText): Moved here from khtml_part.cpp.
• kwq/KWQLoaderImpl.mm: Include khtml_part.h instead of KWQKHTMLPartImpl.h.

• kwq/KWQPushButton.mm: (buttonFontMetrics), (QPushButton::fontMetrics): Added. Used by the form code to size buttons.
• kwq/KWQStyle.mm: Added. (QStyle::sizeFromContents): Added. Used by the form code to size buttons.

• kwq/KWQStyle.h: Removed.
• kwq/qt/qstyle.h: Moved contents of KWQStyle.h in here.
• kwq/qt/qwidget.h: Include <qstyle.h> rather than KWQStyle.h.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge isFrameSet]): Call straight to impl.

• kwq/kdeui/klineedit.h: Add KLineEdit::frameWidth().
• kwq/qt/qnamespace.h: Remove GUIStyle, MacStyle, and WindowsStyle.
• kwq/qt/qpaintdevice.h: Add QInternal, QInternal::Printer, and QPaintDevice::devType().
• kwq/qt/qpainter.h: Add QPainter::device().
• kwq/qt/qpushbutton.h: Add QPushButton::fontMetrics().

6:59 PM Changeset in webkit [1622] by mjs

• 14 edits in trunk

WebCore:

Fix a recent regression that made JavaScript window closing
crash. Window closing was counting on delayed dealloc/destruction
of things associated with the window, but now that we have made
deallocs more synchronous, we need to add an explicit delay in
this case.

Also, change some fprintf diagnostics of things that should never
happen into assertions, since I actually ran into one.

• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Change fprintf diagnostic to assertion, remove comment that the diagnostic should be removed. (KWQKHTMLPartImpl::end): Change fprintf diagnostic to assertion, remove comment that the diagnostic should be removed. (KWQKHTMLPartImpl::scheduleClose): Renamed from close, changed to schedule window closing from the run loop rather than doing it immediately.
• khtml/ecma/kjs_window.cpp: (Window::scheduleClose): Adjusted for above rename.

WebKit:

Fix a regression in my recent refactoring that broke JavaScript
window opening, by doing some trickery to make a frame's initial
dummy data source committed.

• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Create dummy data source as committed, not provisional.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Allow the documentView to be nil if there is no webView either; this is temporarily needed to handle the special initial dummy data source, which will be going away soon.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedData:]): Add temporary special case to avoid sending empty NSData to the representation, to avoid triggering WebCore assertions.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:]): Get the committed data source, not the provisional one.

6:55 PM Changeset in webkit [1621] by hyatt

• 5 edits in trunk/WebCore

Alternate stylesheet support. Fixed numerous bugs in the handling of alternate sheets and implemented the ability to select alternate sheets per 14.3.2 of the HTML4 spec.

2:23 PM Changeset in webkit [1620] by cblu

• 6 edits in trunk/WebKit

WebKit:

Used darin-inspired code factoring to fix 3000801 (alex doesn't accept drag of webloc file) in 3 places where we accept drags.

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_parentWebView]): no changes (-[NSView _web_acceptableDragTypes]): added (-[NSView _web_bestURLForDraggingInfo:]): added (-[NSView _web_dragOperationForDraggingInfo:]): added
• WebKit.pbproj/project.pbxproj: made WebNSViewExtras.h public
• WebView.subproj/WebView.m: (-[WebView initWithFrame:]): calls _web_acceptableDragTypes (-[WebView draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[WebView concludeDragOperation:]): calls _web_bestURLForDraggingInfo

WebBrowser:

Used darin-inspired code factoring to fix 3000801 (alex doesn't accept drag of webloc file)
in 3 places where we accept drags.

• BrowserNSViewExtras.h:
• BrowserNSViewExtras.m: removed locationField specific drag methods
• LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): calls _web_acceptableDragTypes (-[LocationFieldEditor draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[LocationFieldEditor draggingUpdated:]): calls _web_dragOperationForDraggingInfo (-[LocationFieldEditor concludeDragOperation:]): calls _web_bestURLForDraggingInfo
• LocationTextField.m: (-[LocationTextField awakeFromNib]): calls _web_acceptableDragTypes (-[LocationTextField draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[LocationTextField draggingUpdated:]): calls _web_dragOperationForDraggingInfo (-[LocationTextField concludeDragOperation:]): calls _web_bestURLForDraggingInfo

10:54 AM Changeset in webkit [1619] by cblu

• 4 edits in trunk/WebKit

WebKit:

• We were loading icons when page loads ended in error. Fixed.
• Special-case file URLs once instead of twice by moving NSWorkspace call out of WebIconLoader

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): removed file URL special-case
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): check for document error, send file

WebBrowser:

• Comparison between a float and int was causing download history to be erased
• Set the dock mini window to display # of active downloads

• DownloadMonitor.h: renamed _hourlyTimer to _removeExpiredTimer
• DownloadMonitor.m: (-[DownloadMonitor dealloc]): (-[DownloadMonitor updateProgressUI]): set mini dock title (-[DownloadMonitor windowDidLoad]):

4:00 AM Changeset in webkit [1618] by mjs

• 11 edits in trunk

top level:

• Tests/ObjcUnit/Makefile.am: Remove products from symroots on `make clean'.
• Tests/TestPlugin/Makefile.am: Remove products from symroots on `make clean'.
• Tests/WebFoundation-CacheLoader/Makefile.am: Remove products from symroots on `make clean'.

Tools:

• CommitLogEditor/Makefile.am: Remove products from symroots on `make clean'.
• HotSpotFinder/Makefile.am: Remove products from symroots on `make clean'.

JavaScriptCore:

• Makefile.am: Remove products from symroots on `make clean'.

WebFoundation:

• Makefile.am: Remove products from symroots on `make clean'.

WebCore:

• Makefile.am: Remove products from symroots on `make clean'.

WebKit:

• Makefile.am: Remove products from symroots on `make clean'.

WebBrowser:

• Makefile.am: Remove products from symroots on `make clean'.

3:21 AM Changeset in webkit [1617] by mjs

• 4 edits in trunk/WebCore

• WebCore.pbproj/project.pbxproj: Set directories for the group folders, so that creating new files in them will put them in the right directory by default.

2:37 AM Changeset in webkit [1616] by mjs

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Set directories for the group folders, so that creating new files in them will put them in the right directory by default.

2:11 AM Changeset in webkit [1615] by mjs

• 6 edits in trunk/WebKit

More refactoring. Change bridge to get the data source via a
method instead of straight from the ivar, and in the method,
assert that the data source is not nil and is not
provisional. Turns out no one was using it while provisional,
which is great. This means we can eliminate the provisional
concept from the bridge interface as the next step.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSource]): New method to get data source - assert it is not nil, and committed. (-[WebBridge frame]): Get data source from method. (-[WebBridge childFrames]): Likewise. (-[WebBridge descendantFrameNamed:]): Likewise. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Likewise. (-[WebBridge openNewWindowWithURL:]): Likewise. (-[WebBridge areToolbarsVisible]): Likewise. (-[WebBridge setToolbarsVisible:]): Likewise. (-[WebBridge areScrollbarsVisible]): Likewise. (-[WebBridge setScrollbarsVisible:]): Likewise. (-[WebBridge isStatusBarVisible]): Likewise. (-[WebBridge setStatusBarVisible:]): Likewise. (-[WebBridge setWindowFrame:]): Likewise. (-[WebBridge window]): Likewise. (-[WebBridge setTitle:]): Likewise. (-[WebBridge setStatusText:]): Likewise. (-[WebBridge mainFrame]): Likewise. (-[WebBridge frameNamed:]): Likewise. (-[WebBridge receivedData:withDataSource:]): Likewise. (-[WebBridge startLoadingResource:withURL:]): Likewise. (-[WebBridge objectLoadedFromCache:size:]): Likewise. (-[WebBridge setDataSource:]): Likewise. (-[WebBridge openedByScript]): Likewise. (-[WebBridge setOpenedByScript:]): Likewise. (-[WebBridge setIconURL:]): Likewise. (-[WebBridge setIconURL:withType:]): Likewise.
• WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _isCommitted]): New private method to check if a data source is committed, for the benefit of WebBridge assertions.

12:46 AM Changeset in webkit [1614] by hyatt

• 6 edits in trunk/WebCore

Apologies for the lack of the changelog info. I need help setting that up on my laptop. I did edit the changelog, and you can see it there. This is a fix to speed up list boxes.

Jul 20, 2002:

9:59 PM Changeset in webkit [1613] by darin

• 4 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Turn stricter warnings back on now that we don't use C++ any more.

• Plugins.subproj/WebPluginView.m: (-[WebPluginView sendActivateEvent:]): Fix cast that stricter warning didn't like. (-[WebPluginView sendUpdateEvent]): Fix cast that stricter warning didn't like. (-[WebPluginView frameStateChanged:]): Remove unneeded cast that stricter warning didn't like.

9:40 PM Changeset in webkit [1612]

• 16 copies in tags/KDE_3_0_2

This commit was manufactured by cvs2svn to create tag 'KDE_3_0_2'.

9:40 PM Changeset in webkit [1611] by darin

• 207 edits in branches/kde

Check in KDE 3.0.2 sources again, this time on the right server.

9:39 PM Changeset in webkit [1610] by darin

• 9 deletes in branches/kde

No Makefiles in kde branch.

7:48 PM Changeset in webkit [1609] by hyatt

• 10 edits in trunk/WebCore

Fixing the FOUC problem.

7:37 PM Changeset in webkit [1608] by darin

• 3 edits in trunk/WebKit

• fixed 2999643 -- Leak of NSSet in -[IFStandardPanels _didStartLoadingURL:inController:]

This is another case of the leak I fixed a month ago. I don't know how I managed to
overlook this other code path with the identical bug.

• Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels _didStopLoadingURL:inController:]): Fix a leak caused by calling the wrong method. This was calling objectForKey: instead of removeObjectForKey:.

7:22 PM Changeset in webkit [1607] by darin

• 8 edits in trunk

WebCore:

• khtml/css/css_ruleimpl.cpp: (CSSImportRuleImpl::~CSSImportRuleImpl): Fix a potential leak by doing setParent(0) here just as is done in CSSMediaRuleImpl.

• kwq/WebCoreBridge.h: Fix a misspelling of visible.

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge areToolbarsVisible]): (-[WebBridge isStatusBarVisible]): Fix misspelling of visible.

WebBrowser:

• fixed 2999637 -- CFStringRef leak in -[IFWebDataSource(IFPrivate) _setTitle:]

• BrowserDocument.m: (-[BrowserDocument pageName]): Remove inexplicable "retain" call.

• fixed another storage leak

• LocationTextField.m: (-[LocationTextField setIcon:]): Release the icon when done.

6:22 PM Changeset in webkit [1606] by mjs

• 19 edits in trunk

WebCore:

Changed the code to handle "icon" and "SHORTCUT ICON" links
separately, and give higher priority to the former.

• fixed 3003672 - Assertion failure related to iconloader on metafilter

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): Changed to handle both "icon" and "SHORTCUT ICON" links properly.
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::setIconURL): Moved here from KWQKHTMLPartImpl to do it more the way KDE does. (KHTMLPartBrowserExtension::setTypedIconURL): New method for handling moz-style icon links, which include a type as well as a URL.
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::loadIcon): Removed.
• kwq/WebCoreBridge.h: Prototype setIcon: and setIcon:withType: methods.
• kwq/khtml/khtml_ext.h: Prototype new methods.
• kwq/kparts/browserextension.h: Make setIcon pure virtual instead of a no-op.

WebKit:

Changed the code to handle "icon" and "SHORTCUT ICON" links
separately, and give higher priority to the former.

Also, we don't start loading the icon the moment khtml finds one
in the document any more, instead we wait until the document is
done loading, in case there are both "icon" and "SHORTCUT ICON"
link tags.

• fixed 3003672 - Assertion failure related to iconloader on metafilter

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setIconURL:]): Forward to the data source. (-[WebBridge setIconURL:withType:]): Likewise.
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Release iconURL. (-[WebDataSource _setDefaultIconURLIfUnset]): Renamed from _loadPageIconIfNecessary, and changed to only set iconURL rather than actually loading. (-[WebDataSource _setPrimaryLoadComplete:]): Call _loadIcon instead of _loadPageIconIfNecessary, since we defer all loads to this point. (-[WebDataSource _loadIcon]): Load current iconURL if set. (-[WebDataSource _setIconURL:]): Set iconURL if not set already (since typed icons are higher priority). (-[WebDataSource _setIconURL:withType:]): Set the iconURL.

2:12 PM Changeset in webkit [1605] by darin

• 12 edits in trunk/WebKit

• fixed 2999616 -- Possible leak in +[IFPluginDatabase installedPlugins]

• Plugins.subproj/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): Move the code into an init function. (pluginLocations): Simplified. (-[WebPluginDatabase init]): Added. Cleaned up a bit, and made it release the WebPlugin objects -- this was the leak. (-[WebPluginDatabase dealloc]): Added.

• Plugins.subproj/WebPluginDatabase.h: Tweaked formatting.

• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: (-[WebPluginStream startLoad]): (-[WebPluginStream stop]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]): (-[WebSubresourceClient WebResourceHandleDidCancelLoading:]): (-[WebSubresourceClient WebResourceHandleDidFinishLoading:data:]): (-[WebSubresourceClient WebResourceHandle:didFailLoadingWithResult:]):
• WebView.subproj/WebDataSource.m: (-[WebDataSource stopLoading]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _startLoading:]): (-[WebDataSource _addResourceHandle:]): (-[WebDataSource _removeResourceHandle:]): Changed code that called it a URLHandle to say resourceHandle.

• WebView.subproj/WebFrame.m: (-[WebFrame dealloc]): Add an autorelease pool here since this is called from a timer and AppKit does not use an explicit autorelease pool in that case. This makes the "world leak check" work better, and is mildly helpful in other cases too. Radar 3003650 is a request for the AppKit team to fix this, but this workaround will do for now.

Jul 19, 2002:

5:00 PM Changeset in webkit [1604] by darin

• 28 edits in trunk/WebKit

WebFoundation:

• CacheLoader.subproj/WebResourceClient.h: Renamed a couple of the client protocol methods to remove a double mention of the word "resource".

• CacheLoader.subproj/WebResourceCallbackClient.m:
• CacheLoader.subproj/WebResourceHandle.m: Updated for the above name change.

• WebFoundation.pbproj/project.pbxproj: Moved the C APIs to their own group.

WebKit:

• fixed 3001951 -- Massive memory leak after running base or static PLT

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _makeRepresentation]): Add a missing release.

Reduced our use of autorelease. This allows the page load test to detect leaks of the
world much more easily. We may later find we need to use the "retain autorelease" idiom
in a few more places, but I did a lot of testing and that did not show up.

• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _setTopBookmark:]): Use a plain release. (-[WebBookmarkGroup _loadBookmarkGroupGuts]): Use a plain release.
• Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList copyWithZone:]): Use a plain release.
• Misc.subproj/WebIconLoader.m: (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]): Use a plain release.
• Plugins.subproj/WebPluginView.m: (-[WebPluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): Use a plain release.
• WebView.subproj/WebController.m: (-[WebController createFrameNamed:for:inParent:allowsScrolling:]): Use a plain release. (-[WebController setWindowContext:]): Use a plain release. (-[WebController setResourceProgressHandler:]): Use a plain release. (-[WebController setDownloadProgressHandler:]): Use a plain release. (-[WebController setPolicyHandler:]): Use a plain release.
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Use plain release.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Use plain release. (-[WebDataSource _setPrimaryLoadComplete:]): Use plain release. (-[WebDataSource _setTitle:]): Use plain release.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Use plain release. (-[WebFrame reset]): Invalidate and release the timer.
• WebView.subproj/WebFramePrivate.h: Keep a reference to the timer.
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Invalidate and release the timer. Use plain release. (-[WebFramePrivate setName:]): Use plain release. (-[WebFramePrivate setWebView:]): Use plain release. (-[WebFramePrivate setDataSource:]): Use plain release. (-[WebFramePrivate setProvisionalDataSource:]): Use plain release. (-[WebFrame _scheduleLayout:]): Keep a reference to the timer. (-[WebFrame _timedLayout:]): Release and nil the timer.
• WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithName:rect:view:children:]): Use plain release.
• WebView.subproj/WebView.m: (-[WebView concludeDragOperation:]): Use plain release.
• WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]): Use plain release.

Other changes to make the new page load test feature work.

• Misc.subproj/WebKitStatistics.h:
• Misc.subproj/WebKitStatistics.m: (+[WebKitStatistics HTMLRepresentationCount]): Added a stat for WebHTMLRepresentation objects.
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation init]): Bump the count. (-[WebHTMLRepresentation dealloc]): Decrement the count.

Renaming.

• Misc.subproj/WebCoreStatistics.h:
• Misc.subproj/WebKitStatisticsPrivate.h:
• Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics emptyCache]): (+[WebCoreStatistics setCacheDisabled:]): Renamed to include the word cache now that the class does not.

• Plugins.subproj/WebPluginStream.m:
• WebCoreSupport.subproj/WebSubresourceClient.m:
• WebView.subproj/WebMainResourceClient.m: Updated for the WebFoundation renaming.

WebBrowser:

• fixed 3002602 -- make Page Load Test close windows, check for leaked JS interpreters before and after

• AppController.m:
• Debug/CacheController.m: Update for WebCoreStatistics method name changes.

• BrowserWebController.m: Tweak.

• Test/PageLoadTest.nib: Add new button to control whether we do "leak the world" checking.

• Test/PageLoadTestController.h: New action and outlet for leak the world button.
• Test/PageLoadTestController.m: (-[PageLoadTestController init]): New notification for leak the world message. (-[PageLoadTestController windowDidLoad]): Add code for leak the world button and new default. (-[PageLoadTestController toggleCheckForWorldLeaks:]): Added. (-[PageLoadTestController detectedWorldLeak:]): Added. Puts up sheet. (-[AppController pageLoadTestController]): Moved global in here so it can be more private.

• Test/PageLoadTestLogger.m: Updated for url -> URL method name change.

• Test/PageLoadTestRunner.h: Add method to control leak the world checking. Also do url -> URL.
• Test/PageLoadTestRunner.m: (-[NSWindow closeIfBrowserWindow]): Added. Used to close all browser windows for leak the world checking. (-[PageLoadTestRunner init]): Default for checkForWorldLeaks is YES. (-[PageLoadTestRunner clearCacheWithURL:]): Update for empty cache method name change. (-[PageLoadTestRunner addLeakToArray:count:name:]): Added. Helper for constructing string. (-[PageLoadTestRunner closeBrowserWindows]): Added. (-[PageLoadTestRunner finishCheckingForWorldLeaks]): Added; done after a delay. (-[PageLoadTestRunner checkForWorldLeaks]): Do the leak check. (-[PageLoadTestRunner checkForWorldLeaksNow]): Do the leak check without delay. (-[PageLoadTestRunner testDone]): Check for leaks when the test is done. (-[PageLoadTestRunner start]): Check for world leak objects before the test starts. (-[PageLoadTestRunner pageLoadStarted:]): Use our own autorelease pool to make objects less "lingery". (-[PageLoadTestRunner pageLoadDone:]): Use our own autorelease pool to make objects less "lingery". (-[PageLoadTestRunner setCheckForWorldLeaks:]): Added.

2:19 PM Changeset in webkit [1603] by cblu

• 9 edits in trunk

top level:

• Site/favicon.ico: Removed.

WebCore:

Per darin, only define loadIcon in KWQKHTMLPartImpl

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process):
• khtml/khtml_part.cpp:
• khtml/khtml_part.h:

WebKit:

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadPageIconIfNecessary]): use the correct relative string to request favicon.ico

12:58 PM Changeset in webkit [1602] by cblu

• 4 edits in trunk/WebKit

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem image]): call [WebIconLoader defaultIcon]
• Misc.subproj/WebIconLoader.m: (+[WebIconLoader defaultIcon]): move bundle image loading code from [WebHistoryItem image] to here.

12:36 PM Changeset in webkit [1601] by cblu

• 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

Fixed build failure by making WebIconLoader.h public

12:04 PM Changeset in webkit [1600] by cblu

• 22 edits
  2 adds in trunk

top level:

• Site/favicon.ico: Added.

WebCore:

Added support favicons.

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): added an APPLE_CHANGES
• khtml/khtml_part.cpp: (KHTMLPart::loadIcon): added
• khtml/khtml_part.h: added loadIcon
• kwq/KWQKHTMLPartImpl.h: added loadIcon
• kwq/KWQKHTMLPartImpl.mm: added loadIcon (KWQKHTMLPartImpl::loadIcon):
• kwq/WebCoreBridge.h: added loadIcon

WebKit:

Added support favicons.

• Misc.subproj/WebIconLoader.h: Added.
• Misc.subproj/WebIconLoader.m: Added. (-[WebIconLoaderPrivate dealloc]): (+[WebIconLoader defaultIcon]): (-[WebIconLoader initWithURL:]): (-[WebIconLoader dealloc]): (-[WebIconLoader setDelegate:]): (-[WebIconLoader startLoading]): (-[WebIconLoader startLoadingOnlyFromCache]): (-[WebIconLoader stopLoading]): (-[WebIconLoader WebResourceHandleDidBeginLoading:]): (-[WebIconLoader WebResourceHandleDidCancelLoading:]): (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]): (-[WebIconLoader WebResourceHandle:resourceDataDidBecomeAvailable:]): (-[WebIconLoader WebResourceHandle:resourceDidFailLoadingWithResult:]): (-[WebIconLoader WebResourceHandle:didRedirectToURL:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadIcon:]): added
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _loadPageIconIfNecessary]): added (-[WebDataSource _setPrimaryLoadComplete:]): start loading icon (-[WebDataSource _stopLoading]): stop icon loader (-[WebDataSource receivedPageIcon:]): added (-[WebDataSource _loadIcon:]): added
• WebView.subproj/WebLocationChangeHandler.h:

WebBrowser:

Added support favicons.

• BrowserDocument.m: (-[BrowserDocument _receivedPageIcon:]): added
• BrowserDocumentPrivate.h:
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController frameLoadCommitted:]): switch to default icon (-[BrowserWindowController mouseDownInRightButton:]): (-[BrowserWindowController setPageIcon:]): added
• LocationChangeHandler.m: (-[LocationChangeHandler receivedPageIcon:forDataSource:]): added
• LocationTextField.h:
• LocationTextField.m: (-[LocationTextField setDisplayAttributes]): (-[LocationTextField setIcon:]): set the icon size to 16x16
• Resources/Images/url_icon.tiff: Removed.
• TextFieldWithControls.h:
• TextFieldWithControls.m: renamed _completeImage to _backgroundImage (-[TextFieldWithControls dealloc]): (-[TextFieldWithControls backgroundImage]): (-[TextFieldWithControls setFrameSize:]): (-[TextFieldWithControls showRightButton:]): (-[TextFieldWithControls setLeftCapImage:]): (-[TextFieldWithControls setRightCapImage:]): (-[TextFieldWithControls setMiddleImage:]): (-[TextFieldWithControls setLeftButtonImage:withOrigin:]): (-[TextFieldWithControls setRightButtonImage:withOrigin:]):
• WebBrowser.pbproj/project.pbxproj:

11:16 AM Changeset in webkit [1599] by darin

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Forgot to export WebKitStatistics.h so it can be used by WebBrowser.

11:02 AM Changeset in webkit [1598] by darin

• 15 edits
  3 adds in trunk

WebCore:

• khtml/css/makeprop: Fail if we don't find gperf.
• khtml/misc/makeattrs: Fail if we don't find gperf.
• khtml/misc/maketags: Fail if we don't find gperf.

WebKit:

Added some stats that we can use to sniff out "leak the world" problems.

• Misc.subproj/WebKitStatistics.h: Added.
• Misc.subproj/WebKitStatistics.m: Added.
• Misc.subproj/WebKitStatisticsPrivate.h: Added.

• WebKit.pbproj/project.pbxproj: Added new files.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge init]): Bump count. (-[WebBridge dealloc]): Decrement count.
• WebView.subproj/WebController.m: (-[WebController initWithView:provisionalDataSource:]): Bump count. (-[WebController dealloc]): Decrement count.
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:attributes:flags:): Bump count. (-[WebDataSource dealloc]): Decrement count.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Bump count. (-[WebFrame dealloc]): Decrement count.
• WebView.subproj/WebView.m: (-[WebView initWithFrame:]): Bump count. (-[WebView dealloc]): Decrement count.

3:43 AM Changeset in webkit [1597] by mjs

• 6 edits in trunk/WebKit

More refactoring: Use assertions to make sure a provisional data
source's bridge is never used - and then fix the places where it
would have been used. :-)

• WebView.subproj/WebDataSource.m: (-[WebDataSource documentTextFromDOM]): Return nil if the document is not committed.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Don't tell the bridge to stop if we're provisional, because we won't have one. (-[WebDataSource _setFinalURL:]): Don't try to set the bridge URL if we are not committed - it will get set at commit time. (-[WebDataSource _removeFromFrame]): Assert that the data soource is committed - a provisional data source should never be removed from a frame because it should never be in a frame in the first place. (-[WebDataSource _bridge]): Assert that the view is committed. (-[WebDataSource _commitIfReady]): Do nothing if already committed. (-[WebDataSource _receivedData:]): Notice that first byte was read, if appropriate, and commit when ready.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:didRedirectToURL:]): Simplify code by using [WebDataSource _receivedData:]

2:33 AM Changeset in webkit [1596] by mjs

• 4 edits in trunk/WebCore

• kwq/WebCoreBridge.mm: (-[WebCoreBridge installInFrame:]): Assert that this bridge is either for the main frame, or that it's frame has a render part. If neither of these conditions is met, the view will never get installed in the view hiearchy leading to nasty silent failure; and this condition should be guaranteed.

2:13 AM Changeset in webkit [1595] by mjs

• 4 edits in trunk/WebKit

Fix a regression caused by a previous commit that broke frames.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Instead setting the data source implicitly here, and doing other special first-time init, simply assert that we have a data source. (-[WebBridge setDataSource:]): Do the extra work when setting the data source here instead.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): After making the representation, set the data source, because we no longer pass the first data chunk _before_ transitioning to committed, instead we do it right after, so the logic in WebBridge to do it implicitly was not going to cut it.