Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jul 25, 2002:

8:44 PM Changeset in webkit [1679] by rjw

• 9 edits in trunk/WebKit

More incremental changes for back/forward migration.

• BackForwardListEntry.h:
• BackForwardListEntry.m:

More incremental changes for back/forward migration.

• History.subproj/WebBackForwardList.h:
• History.subproj/WebBackForwardList.m: (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList addEntry:]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goBackToIndex:]): (-[WebBackForwardList backEntry]): (-[WebBackForwardList currentEntry]): (-[WebBackForwardList forwardEntry]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goForwardToIndex:]): (-[WebBackForwardList canGoBack]): (-[WebBackForwardList canGoForward]): (-[WebBackForwardList description]):
• History.subproj/WebHistoryItem.h:
• History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURL:title:]): (-[WebHistoryItem initWithURL:title:image:]): (-[WebHistoryItem initWithURL:target:title:image:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem target]): (-[WebHistoryItem setTarget:]): (-[WebHistoryItem setLastVisitedDate:]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem setScrollPoint:]):
• History.subproj/WebHistoryList.m:
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate setLoadType:]): (-[WebFrame _setLoadType:]): (-[WebFrame _loadType]): (-[WebFrame _transitionToCommitted]):

7:26 PM Changeset in webkit [1678] by cblu

• 12 edits
  4 adds in trunk/WebKit

Made some WebPolicy API's private
Added support for download link/image to disk

• Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebControllerPolicyHandler.h:
• WebView.subproj/WebControllerPolicyHandler.m: (-[WebPolicyPrivate dealloc]): (-[WebPolicy _setPolicyAction:]): (-[WebPolicy policyAction]): (-[WebPolicy path]): (-[WebPolicy _setPath:]): (-[WebPolicy dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]): (+[WebClickPolicy webPolicyWithClickAction:andPath:]):
• WebView.subproj/WebControllerPolicyHandlerPrivate.h: Added.
• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler downloadURL:]): (-[WebDefaultContextMenuHandler downloadLinkToDisk:]): (-[WebDefaultContextMenuHandler openImageInNewWindow:]): (-[WebDefaultContextMenuHandler downloadImageToDisk:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):

6:14 PM Changeset in webkit [1677] by cblu

• 9 edits in trunk/WebKit

Fixed crasher caused by not retaining the content policy.

• WebView.subproj/WebControllerPolicyHandler.h:
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):

5:56 PM Changeset in webkit [1676] by cblu

• 23 edits
  1 add in trunk/WebKit

WebKit:

Made policy APIs return a WebPolicy object.
Added click policy.

• Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]): (-[WebDownloadHandler finishedLoading]): (-[WebDownloadHandler cancel]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (+[WebController defaultURLPolicyForURL:]):
• WebView.subproj/WebControllerPolicyHandler.h:
• WebView.subproj/WebControllerPolicyHandler.m: Added. (-[WebPolicy initWithPolicyAction:]): (-[WebPolicy policyAction]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]): (-[WebContentPolicy initWithContentPolicyAction:andPath:]): (-[WebContentPolicy dealloc]): (-[WebContentPolicy path]): (-[WebClickPolicy initWithClickPolicyAction:andPath:]): (+[WebClickPolicy webPolicyWithClickAction:andPath:]): (-[WebClickPolicy dealloc]): (-[WebClickPolicy path]):
• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource contentPolicy]): (-[WebDataSource fileType]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setContentPolicy:]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _isReadyForData]):
• WebView.subproj/WebDefaultPolicyHandler.m: (-[WebDefaultPolicyHandler URLPolicyForURL:]): (-[WebDefaultPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultPolicyHandler unableToImplementFileURLPolicy:error:forDataSource:]): (-[WebDefaultPolicyHandler unableToImplementURLPolicy:error:forURL:]): (-[WebDefaultPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]): (-[WebDefaultPolicyHandler clickPolicyForElement:button:modifierMask:]):
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowDataSource:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedProgressWithHandle:complete:]): (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient WebResourceHandleDidFinishLoading:data:]): (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):

WebBrowser:

Made policy APIs return a WebPolicy object.

• BrowserDocument.m: (-[BrowserDocument _stopNonDownloadingDataSource:]): (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]):
• BrowserWebController.m: (-[BrowserWebController URLPolicyForURL:]): (-[BrowserWebController unableToImplementURLPolicy:error:forURL:]): (-[BrowserWebController fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[BrowserWebController unableToImplementFileURLPolicy:error:forDataSource:]): (-[BrowserWebController contentPolicyForMIMEType:dataSource:]): (-[BrowserWebController unableToImplementContentPolicy:error:forDataSource:]): (-[BrowserWebController clickPolicyForElement:button:modifierMask:]):
• DownloadMonitor.m: (-[DownloadMonitor _monitorDownload:withProgress:error:dataSource:complete:]):
• DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithResource:progress:error:dataSource:]):

5:17 PM Changeset in webkit [1675] by darin

• 3 edits in trunk/WebCore

Remove bogus change log entry that I checked in by accident.

5:04 PM Changeset in webkit [1674] by darin

• 19 edits in trunk

top level:

• configure.in: Add DeploymentFat build style.

JavaScriptCore:

• JavaScriptCore.pbproj/project.pbxproj: Add DeploymentFat build style.

WebFoundation:

• WebFoundation.pbproj/project.pbxproj: Add DeploymentFat build style.

WebCore:

• WebCore.pbproj/project.pbxproj: Add DeploymentFat build style.

• fixed 3007532 -- Main documentation frame doesn't load on Apple docs page

This was caused by my recent fix for the "checkboxes in wrong place" bug.
While discussing that bug fix with Richard, I realized that I needed to do the
work at layout time, not print time. Luckily, this code ends up being simpler
than the original solution.

• khtml/rendering/render_replaced.cpp: (RenderWidget::resizeWidget): Take out size limits based on X limits. (RenderWidget::layout): Move widgets off into far away coordinate space when layout happens. They get moved back on to the right position during the print process.

• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: Removed paint, buildViewsNotYetAddedSet, viewsNotYetAdded, and addedWidget.
• kwq/KWQScrollView.mm: (QScrollView::addChild): Removed call to addedWidget.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Put the call to the renderer to print back in here, since it's simple again.

• kwq/KWQWidget.mm: (QWidget::internalSetGeometry): Left in a couple of asserts that were useful in narrowing this one down.

WebKit:

• WebKit.pbproj/project.pbxproj: Add DeploymentFat build style.

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Add DeploymentFat build style.

3:53 PM Changeset in webkit [1673] by hyatt

• 4 edits in trunk/WebCore

Floated images using "align" should have margins to prevent the text from running right
up against them. Matches IE and Mozilla behavior.

• khtml/css/html4.css:

3:36 PM Changeset in webkit [1672] by hyatt

• 4 edits in trunk/WebCore

Fix <blockquote> tags to have top and bottom margins of 1em. This matches the <blockquote>
behavior in Gecko.

• khtml/css/html4.css:

3:17 PM Changeset in webkit [1671] by darin

• 23 edits in trunk

WebFoundation:

WebFoundation part of fix for 3006054 -- assert error failingURL != nil

• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode): Call absoluteString. (IFErrorGetFailingURL): Change result type to CFStringRef.
• CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler continueHeaderReadAfterFailureResponseAndCall:]): Call absoluteString.
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:isTerminal:]): Call absoluteString.
• Misc.subproj/WebError.h:
• Misc.subproj/WebError.m: (+[WebError errorWithCode:inDomain:failingURL:isTerminal:]): Change type of failingURL to NSString. (-[WebError initWithErrorCode:inDomain:failingURL:isTerminal:]): Change type of failingURL to NSString. (-[WebError failingURL]): Change type to NSString. (-[WebError description]): Don't call absoluteString.

WebCore:

• fixed 2965269 -- sizes reported to progress handler from KWQCheckCacheObjectStatus for images are wrong
• fixed 3006054 -- assert error failingURL != nil

• khtml/misc/loader.h: Add dataSize() and m_dataSize.
• khtml/misc/loader.cpp: (CachedImage::CachedImage): Initialize m_dataSize. (CachedImage::data): Update m_dataSize.

• kwq/kio/jobclasses.h:
• kwq/KWQKjobclasses.mm: Store a KURL instead of an NSURL, because KURL can hold any string.

• kwq/KWQLoaderImpl.mm: (KWQServeRequest): Send an error with [WebCoreBridge reportError:] if the URL is so bad we can't construct an NSURL from it. This is the only case in all our code where we need to have failingURL accept a string. (KWQCheckCacheObjectStatus): If the object is an image, use the dataSize() rather than size(). The size() is a (bad) estimate of how much memory is used in the case of an image, but we want to report the size of the original data.

• kwq/WebCoreBridge.h: Add a [reportError:] method.

WebKit:

WebKit part of fix for 3006054 -- assert error failingURL != nil

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportError:]): New. Passes the error to the controller associated with the dataSource.

• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]): Call absoluteString. (-[WebSubresourceClient WebResourceHandleDidCancelLoading:]): Call absoluteString.
• WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Call absoluteString.
• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Don't call absoluteString.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowDataSource:]): Call absoluteString.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandleDidCancelLoading:]): Call absoluteString.

WebBrowser:

WebBrowser part of fix for 3006054 -- assert error failingURL != nil

• BrowserWebController.m: (-[BrowserWebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): Don't call absoluteString.
• DownloadProgressEntry.m: (-[DownloadProgressEntry stop]): Call absoluteString.
• LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:]): Don't call absoluteString. Also use _web_URLWithString to make a URL to parse out the host part. (-[LocationChangeHandler genericMessageForError:]): Don't call absoluteString.

3:11 PM Changeset in webkit [1670] by hyatt

• 4 edits in trunk/WebCore

Fix for huge white space problem on appleturns.com, bug 2947818. Vertical-align
was being applied to block-level elts in violation of the CSS2 spec. Vertical-align
is only supposed to apply to inline-level elts and table cells. getVerticalPosition
will now bail if the element is block-level.

• khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition):

12:50 PM Changeset in webkit [1669] by cblu

• 4 edits in trunk/WebKit

WebKit:

Remove reloadImage until its implemented.

• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):

WebBrowser:

Remove reloadImage until its implemented.

• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):

12:38 PM Changeset in webkit [1668] by cblu

• 15 edits in trunk

WebCore:

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): renamed

WebKit:

Renamed elementInfoAtPoint to elementAtPoint

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDefaultContextMenuHandler.h:
• WebView.subproj/WebDefaultContextMenuHandler.m: (+[WebDefaultContextMenuHandler addMenuItemWithTitle:action:target:toArray:]): renamed (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):

WebBrowser:

Added WebBrowser specific contextual menu items.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument setSaveDataSource:]): set the current data source to save (-[BrowserDocument dataRepresentationOfType:]): uses the current data source
• ContextMenuHandler.h: Added.
• ContextMenuHandler.m: Added. (-[ContextMenuHandler dealloc]): (-[ContextMenuHandler _addMenuItemWithAction:fromArray:toArray:]): (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler _document]): (-[ContextMenuHandler addLinkToBookmarks:]): (-[ContextMenuHandler viewSource:]): (-[ContextMenuHandler savePageAs:]):
• WebBrowser.pbproj/project.pbxproj:

12:41 AM Changeset in webkit [1667] by hyatt

• 5 edits in trunk/WebCore

Fix for bug 2992158, the calendar on www.blog.org in the upper
right was shoved offscreen (and causing a horizontal scrollbar
to be necessary). KHTML was not recomputing the margins for
the table when it became displaced by the float. It was also
mispositioning the float itself.

• khtml/rendering/render_box.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::addOverHangingFloats):

Jul 24, 2002:

6:38 PM Changeset in webkit [1666] by cblu

• 4 edits in trunk/WebKit

tiny change

• WebView.subproj/WebDefaultContextMenuHandler.m:

6:34 PM Changeset in webkit [1665] by cblu

• 9 edits in trunk/WebKit

Added implmentations for a few context menu items.

• WebView.subproj/WebController.h:
• WebView.subproj/WebDefaultContextMenuHandler.h:
• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler dealloc]): (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuHandler validateUserInterfaceItem:]): (-[WebDefaultContextMenuHandler openNewWindowWithURL:]): (-[WebDefaultContextMenuHandler openLinkInNewWindow:]): (-[WebDefaultContextMenuHandler copyLinkToClipboard:]): (-[WebDefaultContextMenuHandler openImageInNewWindow:]): (-[WebDefaultContextMenuHandler copyImageToClipboard:]): (-[WebDefaultContextMenuHandler reloadImage:]): (-[WebDefaultContextMenuHandler openFrameInNewWindow:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):

4:11 PM Changeset in webkit [1664] by rjw

• 4 edits in trunk/WebKit

Removed vestigal locationChangeHandler ivar.

• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]):

3:59 PM Changeset in webkit [1663] by hyatt

• 4 edits in trunk/WebCore

Fix for bug 2953423, viamichelin.com lays out incorrectly.
Remove a completely bogus optimization in the KHTML code that
attempted to bail when the specified width was 0. This was
a very basic problem, and it should fix other pages that were
laying out incorrectly as well.

• khtml/rendering/render_flow.cpp: (RenderFlow::layout):

3:54 PM Changeset in webkit [1662] by cblu

• 3 edits in trunk/WebKit

Call [self _locationChangeHandler] instead of _private-locationChangeHandler

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource receivedPageIcon:]):

3:41 PM Changeset in webkit [1661] by rjw

• 3 edits in trunk/WebKit

Implemented find for text views.

3:36 PM Changeset in webkit [1660] by cblu

• 7 edits in trunk/WebKit

Implemented initial contextual menus. All disabled right now.

• WebView.subproj/WebDefaultContextMenuHandler.h:
• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler dealloc]): added (-[WebDefaultContextMenuHandler addMenuItemWithTitle:action:toArray:]): added (-[WebDefaultContextMenuHandler contextMenuItemsForElementInfo:defaultMenuItems:]): create menu items
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):

2:22 PM Changeset in webkit [1659] by darin

• 4 edits in trunk/WebCore

• khtml/khtml_part.cpp: (KHTMLPart::clear): Remove code that reset m_frameNameId, to complete Maciej's change to fix bug 3006354.

2:14 PM Changeset in webkit [1658] by cblu

• 8 edits in trunk/WebKit

More renaming for WebDefaultPolicyHandler.

• WebView.subproj/WebController.m: (-[WebController policyHandler]):
• WebView.subproj/WebDefaultPolicyHandler.h:
• WebView.subproj/WebDefaultPolicyHandler.m:

2:07 PM Changeset in webkit [1657] by cblu

• 3 edits
  4 adds
  2 deletes in trunk/WebKit

Renamed WebDefaultControllerPolicyHandler to WebDefaultPolicyHandler.

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDefaultControllerPolicyHandler.h: Removed.
• WebView.subproj/WebDefaultControllerPolicyHandler.m: Removed.
• WebView.subproj/WebDefaultPolicyHandler.h: Added.
• WebView.subproj/WebDefaultPolicyHandler.m: Added. (-[WebDefaultControllerPolicyHandler initWithWebController:]): (-[WebDefaultControllerPolicyHandler URLPolicyForURL:]): (-[WebDefaultControllerPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultControllerPolicyHandler unableToImplementFileURLPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler requestContentPolicyForMIMEType:dataSource:]): (-[WebDefaultControllerPolicyHandler unableToImplementURLPolicyForURL:error:]): (-[WebDefaultControllerPolicyHandler unableToImplementContentPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]):

1:55 PM Changeset in webkit [1656] by cblu

• 14 edits
  4 adds in trunk/WebKit

More plumbing for contextual menu support.

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setContextMenuHandler:]): added (-[WebController contextMenuHandler]): added
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): alloc WebDefaultContextMenuHandler (-[WebControllerPrivate dealloc]): dealloc WebDefaultContextMenuHandler (-[WebController _defaultContextMenuHandler]):
• WebView.subproj/WebDefaultContextMenuHandler.h: Added.
• WebView.subproj/WebDefaultContextMenuHandler.m: Added. (-[WebDefaultContextMenuHandler contextMenuItemsForElementInfo:defaultMenuItems:]): new
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): call contextMenuHandlers
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _setController:]): added comment (-[WebHTMLView _controller]): added

1:37 PM Changeset in webkit [1655] by darin

• 25 edits in trunk

top level:

• Site/Internal/Quality/fontsizes.html: Added test cases for "+/-" and "0".

WebCore:

• fixed 2906567 -- Font size calculations should use 96 dpi instead of 72 dpi
• fixed 3005932 -- fonts specified in 'ex' units rendered waaaaaaay too large

• khtml/css/cssstyleselector.cpp: (CSSStyleSelector::computeFontSizes): Use a default font size that's the same as small, rather than a "medium font size". Don't multiply the values from settings by the scaling factor. (CSSStyleSelector::applyRule): Make the default font size here for nodes with no parents be small (m_fontSizes[2]) rather than medium (m_fontSizes[3]).

• khtml/html/html_inlineimpl.cpp: (parseFontSizeNumber): Added. Tolerant of non-numeric characters after the numeric size. Also distinguishes a size like "0" from something that's not a numeric size at all. (HTMLFontElementImpl::parseAttribute): Use parseFontSizeNumber, but also make size 3 be the same as CSS_VAL_SMALL, not CSS_VAL_MEDIUM. This mistake (using CSS_VAL_MEDIUM) led to all kinds of strangeness in the KHTML code, including mishandling of 0 and the need to create CSS_VALKONQ_XXX_LARGE. Also change code so that 0 is treated as CSS_VAL_SMALL (same as 3) rather than CSS_VAL_XX_SMALL. This makes 0 between -1 and +1.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Make default font size be small (fontSizes()[2]) rather than medium (fontSizes()[3]).
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): Make default font size be CSS_VAL_SMALL, not CSS_VAL_MEDIUM.

• kwq/qt/qfontmetrics.h:
• kwq/KWQFontMetrics.mm: (QFontMetrics::xHeight): Added.
• kwq/WebCoreTextRenderer.h: Added xHeight.

• khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLengthFloat): Use xHeight rather than computing the height of an actual letter 'x'.
• khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition): Use xHeight rather than computing the height of an actual letter 'x'.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStyles]): Fixed backwards if that prevented font changes from being reflected in the browser window.

• kwq/khtml/khtml_settings.h:
• kwq/KWQKHTMLSettings.mm: (KHTMLSettings::defaultFontSize):
• kwq/WebCoreSettings.h:
• kwq/WebCoreSettings.m: (-[WebCoreSettings setDefaultFontSize:]): (-[WebCoreSettings defaultFontSize]): Replace mediumFontSize with defaultFontSize.

• WebCore.pbproj/project.pbxproj: Rearrange some of the files.

WebKit:

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer xHeight]): Added. Calls [NSFont xHeight].

• WebView.subproj/WebPreferences.h:
• WebView.subproj/WebPreferences.m: (+[WebPreferences load]): (-[WebPreferences defaultFontSize]): (-[WebPreferences setDefaultFontSize:]): Renamed minimumFont to defaultFont, and changed it from 11 to 16. Also changed default monospaced font to Courier instead of Monaco.

WebBrowser:

• Preferences.subproj/TextPreferences.m: (-[TextPreferences defaultFontSize]), (-[TextPreferences setDefaultFontSize:]): Change to use new WebPreferences mediumFontSize (since default is the same as small, not medium).

• BrowserDocument.m: (-[BrowserDocument reapplyStyles:]): Use setNeedsDisplay: instead of display. It's impolite and unnecessary to do an explicit display.

• WebBrowser.pbproj/project.pbxproj: Small name tweak.

1:14 PM Changeset in webkit [1654] by rjw

• 12 edits in trunk

Support for find in HTML, find in text view coming soon.

• WebView.subproj/WebDocument.h:
• WebView.subproj/WebHTMLView.h:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView searchFor:direction:caseSensitive:]):
• WebView.subproj/WebTextView.h:
• WebView.subproj/WebTextView.m: (-[WebTextView searchFor:direction:caseSensitive:]):

Support for find in HTML.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge searchFor:direction:caseSensitive:]):

10:31 AM Changeset in webkit [1653] by darin

• 19 edits in trunk/WebCore

• fixed 2949235 -- checkboxes in wrong place until you scroll away and back

The problem here was that we put views in when we print, but we never removed them.
I added code to keep track of existing views, and remove them if they are not re-added.

• kwq/KWQKHTMLPartImpl.h: Add paint, addedWidget, buildViewsNotAddedSet, and viewsNotYetAdded. It might be nice to find a different place to hang this that is not included by the KHTML code. But I think that having this on the bridge would be worse.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::paint): Added. Removes any views that are not explicitly added by RenderWidget during the print process. (KWQKHTMLPartImpl::addedWidget): Added. Called by KWQScrollView to tell us a view was added. (KWQKHTMLPartImpl::buildViewsNotYetAddedSet): Added. Used to build the initial set of views.

• kwq/KWQScrollView.mm: (QScrollView::addChild): Added call to KWQKHTMLPartImpl::addedWidget.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Calls KWQKHTMLPartImpl::paint.

• kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry), (KWQWindowWidget::mapToGlobal), (KWQWindowWidget::mapFromGlobal), (KWQWindowWidget::internalSetGeometry): Fixed logic to work properly for windows not on main screen.

• khtml/khtml_part.cpp: Moved the boundary of an existing ifndef APPLE_CHANGES so that KHTMLPart::show() and hide() are not compiled, mainly for clarity.
• khtml/rendering/render_replaced.cpp: (RenderWidget::detach): Removed unneeded APPLE_CHANGES.

• kwq/KWQWindowWidget.h: Removed some unneeded virtual functions.
• kwq/qt/qscrollview.h: Removed some unneeded virtual functions, made others non-virtual.
• kwq/qt/qwidget.h: Removed some unneeded virtual functions, made others non-virtual.
• kwq/KWQWidget.mm: Removed a lot of unused and unneeded stuff.

• force-clean-timestamp: Needed to do this because I changed header files.

8:26 AM Changeset in webkit [1652] by darin

• 4 edits in trunk/WebCore

top level:

• Tests/kde/kurl-test.cpp: (main): Added a test case for a relative URL with a leading space in it.
• Tests/kde/kurl-test.chk: Added the expected result.

WebCore:

• fixed 3006329 - space should be stripped from beginning of relative url

• kwq/KWQKURL.mm: (KURL::normalizeRelativeURLString): Added a call to stripWhiteSpace.

2:37 AM Changeset in webkit [1651] by mjs

• 5 edits in trunk/WebCore

Made frame names globally unique, not just unique per parent frame

• this is needed to avoid triggering the assertion in 3006354 (Assertion failure on salon.com). Clearing my cache made the assertion go away by itself, but it seems good to avoid the possibility of triggering it in the future.

• khtml/khtmlpart_p.h: Make m_partNameId static.
• khtml/khtml_part.cpp: Initialize it here.

12:19 AM Changeset in webkit [1650] by darin

• 5 edits in trunk/WebCore

• 3006336 -- crash in _NSDescriptionWithLocaleFunc

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Don't use the result of getNSString() on a C++ temporary object. We could also fix this by doing retain autorelease in getNSString().

Jul 23, 2002:

11:58 PM Changeset in webkit [1649] by cblu

• 14 edits in trunk

WebCore:

More plumbing for contextual menu support.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge completeURLForDOMString:]): renamed (-[WebCoreBridge elementInfoAtPoint:]): renamed
• kwq/qt/qpixmap.h: added an accessor to the WebCoreImageRenderer

WebKit:

More plumbing for contextual menu support.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementInfoAtPoint:]): added

9:01 PM Changeset in webkit [1648] by darin

• 10 edits in trunk

WebFoundation:

• WebFoundation.pbproj/project.pbxproj: Fix file reference types to be more consistent.

WebCore:

• WebCore.pbproj/project.pbxproj: Fix file reference types to be more consistent.

• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag): Changed indenting to use spaces, makes our diff with KDE smaller. (HTMLTokenizer::end): Remove unneeded APPLE_CHANGES.

• kwq/KWQDOMNode.cpp: Tweak.
• kwq/KWQDOMNode.h: Tweak.

WebKit:

• WebKit.pbproj/project.pbxproj: Fix file reference types to be more consistent.

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Fix file reference types to be more consistent.

7:46 PM Changeset in webkit [1647] by hyatt

• 4 edits in trunk/WebCore

Fix bug 2803155 - images not displayed on ​http://bscw.gmd.de.
My fix is to use our newfound quirks mode to implement a comment
parsing quirk (this is how Mozilla handles this same issue).
Only in quirks mode, the tokenizer will treat <!--> atomically as
a complete comment.

This is bug 34302 on bugs.kde.org, for those who are curious.

• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):

6:33 PM Changeset in webkit [1646] by cblu

• 13 edits
  2 adds in trunk

WebCore:

Initial plumbing for contextual menu support.

• WebCore.pbproj/project.pbxproj:
• kwq/KWQDOMNode.cpp: Added. (isImage):
• kwq/KWQDOMNode.h: Added.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge _URLForDOMString:]): added (-[WebCoreBridge _elementInfoForMouseEvent:]): added

WebKit:

Initial plumbing for contextual menu support.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge elementInfoForMouseEvent:]): added
• WebView.subproj/WebController.h:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): added

6:22 PM Changeset in webkit [1645] by rjw

• 4 edits in trunk/WebCore

Turn on find related code in part in preparation for
implementing find in WebKit.

• khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::clear): (KHTMLPart::findTextNext):

5:55 PM Changeset in webkit [1644] by darin

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Fix paths for newly added files.

5:53 PM Changeset in webkit [1643] by hyatt

• 6 edits in trunk/WebCore

Fixing two bugs here. The first is bug with @import sheets not inheriting strict parsing mode from their parent sheet.
This means all @import sheets are being treated as strict mode!

The second bug is in KWQ. We were never calling determineParseMode, so we always defaulted to strict mode, and therefore
were highly intolerant of unitless numbers on absolutely positioned blocks. This fixes many problems, notably www.netscape.com
and ZDNet.com on the cvs-base tests.

• khtml/css/cssparser.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write):

5:19 PM Changeset in webkit [1642] by rjw

• 16 edits
  2 adds in trunk/WebKit

Use one LocationChangeHandler.
Cleaned up (a little) fallback URL code. This code
is still a convoluted and could be further untaggled.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): (-[BrowserDocument tryMultipleURLs:]): (-[BrowserDocument _goToNextFallbackURL]):
• BrowserDocumentPrivate.h:
• BrowserWebController.h:
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): (-[BrowserWindowController frameLoadRedirected:]): (-[BrowserWindowController frameLoadTryingFallback]):
• LocationChangeHandler.h:
• LocationChangeHandler.m: (-[LocationChangeHandler initWithBrowserDocument:]): (-[LocationChangeHandler dealloc]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]): (-[LocationChangeHandler serverRedirectTo:forDataSource:]):

Cleaned up LocationChangeHandler. We now have one per controller.

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController policyHandler]): (-[WebController setLocationChangeHandler:]): (-[WebController locationChangeHandler]):
• WebView.subproj/WebControllerPolicyHandler.h:
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]):

(-[WebDataSource _setIsDummy:)
(-[WebDataSource _isDummy]):
Hack on hack. MJS will remove when the dummy data source hack is removed.

(-[WebDataSource _locationChangeHandler]):
(-[WebDataSource _removeFromFrame]):
(-[WebFrame initWithName:webView:provisionalDataSource:controller:]):
(-[WebFrame setProvisionalDataSource:]):

• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]):

Added default policy handler. This is used if no policy handler is
set on the controller.

• WebView.subproj/WebDefaultControllerPolicyHandler.h: Added.
• WebView.subproj/WebDefaultControllerPolicyHandler.m: Added. (-[WebDefaultControllerPolicyHandler initWithWebController:]): (-[WebDefaultControllerPolicyHandler URLPolicyForURL:]): (-[WebDefaultControllerPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultControllerPolicyHandler unableToImplementFileURLPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler requestContentPolicyForMIMEType:dataSource:]): (-[WebDefaultControllerPolicyHandler unableToImplementURLPolicyForURL:error:]): (-[WebDefaultControllerPolicyHandler unableToImplementContentPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]):
• WebView.subproj/WebFrame.m:

4:24 PM Changeset in webkit [1641] by darin

• 4 edits in trunk/WebCore

top level:

• Tests/kde/kurl-test.chk: Updated test results to match what real web browsers need to do rather than what the RFC says for paths beginning with "../" or "./".
• Tests/kde/kurl-test.cpp: (main): Add comments for tests where the results are not matching the RFC.

WebCore:

• fixed 3004818 -- relative urls are assembled incorrectly at ticketmaster
• fixed 2999279 -- Invalid URI in request at subpage of swatch.com

The issue here is URLs with paths that start with "/../". RFC 2396 says one
thing, and that's what CFURL does. But real web browsers do another thing.

• kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::KWQKURLPrivate): Clean up a bit by removing unneeded init(). (escapeQString): Don't make a copy of the passed-in QString. (pathEndsWithSlash): Don't make a copy of the passed-in QString. (copyEscapedPath): Make this a static function instead of extern. (KURL::KWQKURLPrivate::decompose): Add the new "../" and "./" logic.

4:09 PM Changeset in webkit [1640] by hyatt

• 5 edits in trunk/WebCore

• khtml/rendering/font.cpp: Fix deployment build bustage by including <algorithm>.

• khtml/rendering/render_frames.cpp: (RenderPartObject::calcReplacedWidth): Fix a bug with ​http://www.moveabletype.com's top portion not showing up (bug 2986714). A hack was being improperly applied to fixed width plugins, when it should have only been applied to variable width plugins.

11:48 AM Changeset in webkit [1639] by darin

• 7 edits in trunk

WebCore:

• Makefile.am: Clean based on all, not all-am, so it happens before subdirs if any.

WebKit:

• Makefile.am: Clean based on all, not all-am, so it happens before subdirs if any.

11:45 AM Changeset in webkit [1638] by darin

• 33 edits
  1 add in trunk

top level:

• Tests/kde/kurl-test.cpp: (main): Add a lot of new tests. One of them demonstrates the issue underlying bug 3004818. The others are taken straight from the URI RFC (2396).
• Tests/kde/kurl-test.chk: Expected results for new tests.

• autogen.sh: Add the new WebCore timestamp file.

WebCore:

Changes require a make clean because of the Project Builder bug.
So I added the "make clean timestamp" hackery.

• .cvsignore: Ignore the new clean timestamp.
• force-clean-timestamp: Added.
• Makefile.am: Add rules for making clean happen.

• khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler): Fix NULL dereference bug in here that I ran into. Code later down in the same function has the check for NULL, so clearly this is just a bug.

• khtml/rendering/font.cpp: (Font::drawText): Simplify by using new drawText that takes a QChar array, no need to make a QConstString.
• khtml/rendering/render_text.cpp: (TextSlave::printDecoration): Simplify by using new drawUnderlineForText that takes a QChar array, no need to make a QConstString.

• kwq/WebCoreTextRenderer.h: Change underline-drawing to use a UniChar array.

• kwq/qt/qpainter.h:
• kwq/KWQPainter.mm: (QPainter::drawText): Change to take QChar array instead of a QString, but also discovered a bizarre overloading thing that was happening before and dealt with that by adding a new drawText that still does take a QString. (QPainter::drawUnderlineForText): Change to take QChar array.

• kwq/qt/qcolor.h: Mark constructor explicit, so we don't get subtle strangess like where the string to draw was being converted to a QColor.

• khtml/css/cssstyleselector.cpp: No need for APPLE_CHANGES for this change any more.

• kwq/kdecore/kcharsets.h:
• kwq/KWQKCharsets.mm: Remove unused functions.

• kwq/khtml/khtml_settings.h:
• kwq/KWQKHTMLSettings.mm: Remove unused functions.

• kwq/qt/qfont.h:
• kwq/KWQFont.mm: Simplify.

• kwq/KWQPaintDeviceMetrics.mm: Simplify.

• kwq/qt/qtextcodec.h:
• kwq/KWQtextcodec.mm: (QTextCodec::codecForName): Remove unused parameter.

WebKit:

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawUnderlineForCharacters:stringLength:atPoint:withColor:]): Change API to take character array instead of a string.

• WebKit.pbproj/project.pbxproj: Took "subproj" off the names of some groups.

10:54 AM Changeset in webkit [1637] by hyatt

• 5 edits in trunk/WebCore

The STYLE element was ignoring both the media and type
attributes (unlike its cousin, the LINK element). This
patch implements support for media and type and further
stops us from loading stylesheets that we should have no
business parsing.

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): (HTMLStyleElementImpl::parseAttribute): (HTMLStyleElementImpl::insertedIntoDocument): (HTMLStyleElementImpl::removedFromDocument): (HTMLStyleElementImpl::childrenChanged): (HTMLStyleElementImpl::sheetLoaded):
• khtml/html/html_headimpl.h:

9:34 AM Changeset in webkit [1636]

• 3 copies in tags/Alexander-14

This commit was manufactured by cvs2svn to create tag 'Alexander-14'.

9:34 AM Changeset in webkit [1635] by sheridan

• 8 edits in trunk

Alex-14 versioning

12:34 AM Changeset in webkit [1634] by hyatt

• 4 edits in trunk/WebCore

• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): Oops. I accidentally removed the call to an ancestor class attach function. What made this subtle is that it deliberately skipped over a couple of base classes and called the one three superclasses up. When I went to put it back in, I messed up and called the base class instead of the distant ancestor.

Silly me. marvel.com and matadorrecords.com should be ok now.

Jul 22, 2002:

10:26 PM Changeset in webkit [1633] by darin

• 13 edits
  2 adds in trunk/WebCore

• khtml/rendering/render_text.cpp: (TextSlave::printSelection): Add comments to APPLE_CHANGES. (TextSlave::printDecoration): Add comments to APPLE_CHANGES. (TextSlave::checkSelectionPoint): Add comments to APPLE_CHANGES.

• khtml/xml/dom_stringimpl.cpp: Add comments to APPLE_CHANGES.

• khtml/xml/xml_tokenizer.cpp: (XMLTokenizer::end): Remove APPLE_CHANGES.
• kwq/KWQsignals.mm: Add a new signal dummy function.

• kwq/WebCoreJavaScript.h: Fix header.
• kwq/WebCoreJavaScript.mm: Fix header.

• kwq/WebCoreSettings.h: Added. Not used yet.
• kwq/WebCoreSettings.m: Added. Not used yet.
• WebCore.pbproj/project.pbxproj: Added WebCoreSettings.h and .m.

• English.lproj/InfoPlist.strings: Fixed a spelling error.

• kwq/WebCoreTextRendererFactory.h: Tweak.

10:04 PM Changeset in webkit [1632] by mjs

• 6 edits in trunk/WebCore

Fixed Radar 3004897 - assert at mapquest

• khtml/html/html_baseimpl.cpp: (HTMLIFrameElementImpl::attach): Put back frame name uniqueness check. Lack of this check was causing duplicate frames to be left floating in space.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Add an assertion that no frame of the requested name already exists.

6:05 PM Changeset in webkit [1631] by hyatt

• 6 edits in trunk/WebCore

Fix for bug 3004889, plugin content on stylesheet pages not
showing up. The rendering tree needed to perform an update
when all children had arrived, and this was being handled by
the parser. With async rendering construction, I had to store
this in the content node instead, so it could do the update
once the render object was built at a later date.

• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::attach):
• khtml/html/html_objectimpl.h:
• khtml/html/htmlparser.cpp: (KHTMLParser::processCloseTag):

3:30 PM Changeset in webkit [1630] by hyatt

• 11 edits in trunk/WebCore

This checkin adds support for querying the selected style set,
for querying the preferred style set, and for changing the
selected style set dynamically. With this checkin, a Web page
in Alexander now has the capability to present its own alternate
stylesheet UI in the page and to toggle between sets using script.

• khtml/dom/css_stylesheet.cpp: (DocumentStyle::preferredStylesheetSet): (DocumentStyle::setSelectedStylesheetSet): (DocumentStyle::selectedStylesheetSet):
• khtml/dom/css_stylesheet.h: Added new methods to the DocumentStyle interface as per Hixie's proposed spec.

• khtml/dom/dom_doc.cpp:
• khtml/dom/dom_doc.h:
• khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): (DOMDocument::tryPut): (DOMDocument::putValue):
• khtml/ecma/kjs_dom.h: Implement the JS binding glue for the new properties.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): (DocumentImpl::preferredStylesheetSet): (DocumentImpl::selectedStylesheetSet): (DocumentImpl::setSelectedStylesheetSet): (DocumentImpl::recalcStyleSelector):
• khtml/xml/dom_docimpl.h: The implementation of the new properties. Also fixed a bug caused by the 3.02 merge in the stylesheet filtering code in recalcStyleSelector.

1:19 PM Changeset in webkit [1629] by rjw

• 10 edits in trunk/WebKit

Moved back/forward list from Alex's document to WebController. First step
to address a series of back/forward related issues.

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController backForwardList]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): (-[WebControllerPrivate dealloc]):

Moved back/forward list from Alex's document to WebController. First step
to address a series of back/forward related issues.

• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument dealloc]): (-[BrowserDocument goToURL:]): (-[BrowserDocument _backForwardList]): (-[BrowserDocument canGoBack]): (-[BrowserDocument canGoForward]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]):

10:44 AM Changeset in webkit [1628] by cblu

• 3 edits in trunk/WebKit

WebKit:

Strip white space before and after URL string 2998696

• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_bestURLForDraggingInfo:]):

WebBrowser:

Added document icon.

• WebBrowser.pbproj/project.pbxproj:
• document.icns: Added.

7:59 AM Changeset in webkit [1627] by kocienda

• 3 edits in trunk/WebKit

• WebView.subproj/WebHTMLView.m: import of removed WebFrame bridge header was left in, causing a build break.

7:01 AM Changeset in webkit [1626] by mjs

• 17 edits
  4 deletes in trunk

WebCore:

Merged WebCoreBridge and WebCoreFrameBridge.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURLInFrame): Use bridge, not frameBridge. (KWQKHTMLPartImpl::urlSelected): Use bridge, not frameBridge. (KWQKHTMLPartImpl::submitForm): Use bridge, not frameBridge. (KWQKHTMLPartImpl::findFrame): Use bridge, not frameBridge. (KWQKHTMLPartImpl::frames): Use bridge, not frameBridge.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge dealloc]): Free RenderPart if set. (-[WebCoreBridge renderPart]): Moved here from WebFrameBridge. (-[WebCoreBridge setRenderPart:]): Moved here from WebFrameBridge. (-[WebCoreBridge copyRenderNode:khtml::copier:]): No more need to get render part from frame bridge. (-[WebCoreBridge installInFrame:]): No more need to get render part from frame bridge.
• kwq/WebCoreFrameBridge.h: Removed.
• kwq/WebCoreFrameBridge.mm: Removed.
• WebCore.exp: Removed WebCoreFrameBridge.
• WebCore.pbproj/project.pbxproj: Removed WebCoreFrameBridge.

WebKit:

Merged WebBridge and WebFrameBridge.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): Return bridges, not frameBridges. (-[WebBridge descendantFrameNamed:]): Return bridge, not frameBridge. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Return a bridge, not a frameBridge. (-[WebBridge mainFrame]): Return a bridge, not a frameBridge. (-[WebBridge frameNamed:]):Return a bridge, not a frameBridge. (-[WebBridge loadURL:attributes:flags:withParent:]): Moved from WebFrameBridge. (-[WebBridge loadURL:]): Moved from WebFrameBridge. (-[WebBridge postWithURL:data:]): Moved from WebFrameBridge.
• WebCoreSupport.subproj/WebFrameBridge.h: Removed.
• WebCoreSupport.subproj/WebFrameBridge.m: Removed.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Don't create a WebFrameBridge.
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): No longer dealloc frameBridge, since we don't have one. (-[WebFrame _transitionToCommitted]): Pass along the frame's render part, if any. (-[WebFrame _frameBridge]): Removed.
• WebKit.pbproj/project.pbxproj: Removed deleted files.

4:45 AM Changeset in webkit [1625] by mjs

• 8 edits in trunk/WebKit

Change WebBridge to hold on to a WebFrame instead of a
WebDataSource. Since we will no longer ever have a bridge for a
provisional data source, we'll just bind the bridge to a
frame. Which means we can merge the bridge and the frame bridge
next.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: Changed below methods to work with direct knowledge of the frame but not the bridge (mostly a simplification). (-[WebBridge frame]): (-[WebBridge parent]): (-[WebBridge childFrames]): (-[WebBridge descendantFrameNamed:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge openNewWindowWithURL:]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge areScrollbarsVisible]): (-[WebBridge setScrollbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge window]): (-[WebBridge setStatusText:]): (-[WebBridge mainFrame]): (-[WebBridge frameNamed:]): (-[WebBridge receivedData:withDataSource:]): (-[WebBridge objectLoadedFromCache:size:]): (-[WebBridge setFrame:]): (-[WebBridge dataSourceChanged]): (-[WebBridge dataSource]): (-[WebBridge openedByScript]): (-[WebBridge setOpenedByScript:]):

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): Set bridge's frame and notify that the data source changed.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Set bridge's frame.
• WebView.subproj/WebFramePrivate.h, WebView.subproj/WebFramePrivate.m: (-[WebFrame _bridge]): Method to get the bridge.

1:32 AM Changeset in webkit [1624] by mjs

• 11 edits in trunk

WebCore:

Removed provisional/committed distinction from WebCore and the
WebCore SPI. WebCore will never see a provisional data source or
provisional anything, any more.

• kwq/KWQScrollView.mm: Remove mention of provisional widget from comment.
• kwq/WebCoreFrameBridge.h: Remove commitedBridge method, and remove comment about provisionality from bridge method.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write): Remove bogus comment about provisional/committed transition. (KWQKHTMLPartImpl::findFrame): Call bridge, not committedBridge. (KWQKHTMLPartImpl::frames): Likewise.

WebKit:

Removed provisional/committed distinction from WebCore and the
WebCore SPI. WebCore will never see a provisional data source or
provisional anything, any more.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge descendantFrameNamed:]): Don't bother with the provisional bridge - no such thing. (-[WebBridge setDataSource:]): Assert the data source is committed.
• WebCoreSupport.subproj/WebFrameBridge.m: (-[WebFrameBridge bridge]): Return committed bridge always, and remove committed bridge method.

Jul 21, 2002:

10:38 PM Changeset in webkit [1623] by darin

• 109 edits
  1 add in trunk

JavaScriptCore:

• kjs/*: Roll KDE 3.0.2 changes in. Also switch to not using APPLE_CHANGES for some of the changes that we definitely want to contribute upstream.

WebCore:

• khtml/*: Roll KDE 3.0.2 changes in. Also switch to not using APPLE_CHANGES for some of the changes that we definitely want to contribute upstream.

• WebCore.pbproj/project.pbxproj: Add KWQStyle.mm, remove KWQStyle.h, moving contents into qstyle.h.

• kwq/KWQApplication.mm: (QApplication::globalStrut): Remove _logNotYetImplemented().

• kwq/KWQButton.mm: (QButton::QButton): Use plain release, not autorelease.
• kwq/KWQComboBox.mm: (QComboBox::init): Use plain release, not autorelease.
• kwq/KWQListBox.mm: (QListBox::QListBox): Use plain release, not autorelease.
• kwq/KWQPainter.mm: (QPainter::drawArc): Use plain release, not autorelease.

• kwq/KWQKHTMLPartBrowserExtension.mm: Remove import of KWQKHTMLPartImpl.h, now that it's always part of khtml_part.h.
• kwq/KWQKHTMLPartImpl.cpp: Simplify.
• kwq/KWQKHTMLPartImpl.h: Add wrapper to allow multiple inclusion. Don't include khtml_part.h any more, since that file now includes this one to minimize changes to KDE code that needs to get to functions in here.
• kwq/KWQKHTMLPartImpl.mm: (KHTMLPart::onURL), (KHTMLPart::nodeActivated), (KHTMLPart::setStatusBarText): Moved here from khtml_part.cpp.
• kwq/KWQLoaderImpl.mm: Include khtml_part.h instead of KWQKHTMLPartImpl.h.

• kwq/KWQPushButton.mm: (buttonFontMetrics), (QPushButton::fontMetrics): Added. Used by the form code to size buttons.
• kwq/KWQStyle.mm: Added. (QStyle::sizeFromContents): Added. Used by the form code to size buttons.

• kwq/KWQStyle.h: Removed.
• kwq/qt/qstyle.h: Moved contents of KWQStyle.h in here.
• kwq/qt/qwidget.h: Include <qstyle.h> rather than KWQStyle.h.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge isFrameSet]): Call straight to impl.

• kwq/kdeui/klineedit.h: Add KLineEdit::frameWidth().
• kwq/qt/qnamespace.h: Remove GUIStyle, MacStyle, and WindowsStyle.
• kwq/qt/qpaintdevice.h: Add QInternal, QInternal::Printer, and QPaintDevice::devType().
• kwq/qt/qpainter.h: Add QPainter::device().
• kwq/qt/qpushbutton.h: Add QPushButton::fontMetrics().

6:59 PM Changeset in webkit [1622] by mjs

• 14 edits in trunk

WebCore:

Fix a recent regression that made JavaScript window closing
crash. Window closing was counting on delayed dealloc/destruction
of things associated with the window, but now that we have made
deallocs more synchronous, we need to add an explicit delay in
this case.

Also, change some fprintf diagnostics of things that should never
happen into assertions, since I actually ran into one.

• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Change fprintf diagnostic to assertion, remove comment that the diagnostic should be removed. (KWQKHTMLPartImpl::end): Change fprintf diagnostic to assertion, remove comment that the diagnostic should be removed. (KWQKHTMLPartImpl::scheduleClose): Renamed from close, changed to schedule window closing from the run loop rather than doing it immediately.
• khtml/ecma/kjs_window.cpp: (Window::scheduleClose): Adjusted for above rename.

WebKit:

Fix a regression in my recent refactoring that broke JavaScript
window opening, by doing some trickery to make a frame's initial
dummy data source committed.

• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Create dummy data source as committed, not provisional.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Allow the documentView to be nil if there is no webView either; this is temporarily needed to handle the special initial dummy data source, which will be going away soon.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedData:]): Add temporary special case to avoid sending empty NSData to the representation, to avoid triggering WebCore assertions.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:]): Get the committed data source, not the provisional one.

6:55 PM Changeset in webkit [1621] by hyatt

• 5 edits in trunk/WebCore

Alternate stylesheet support. Fixed numerous bugs in the handling of alternate sheets and implemented the ability to select alternate sheets per 14.3.2 of the HTML4 spec.

2:23 PM Changeset in webkit [1620] by cblu

• 6 edits in trunk/WebKit

WebKit:

Used darin-inspired code factoring to fix 3000801 (alex doesn't accept drag of webloc file) in 3 places where we accept drags.

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_parentWebView]): no changes (-[NSView _web_acceptableDragTypes]): added (-[NSView _web_bestURLForDraggingInfo:]): added (-[NSView _web_dragOperationForDraggingInfo:]): added
• WebKit.pbproj/project.pbxproj: made WebNSViewExtras.h public
• WebView.subproj/WebView.m: (-[WebView initWithFrame:]): calls _web_acceptableDragTypes (-[WebView draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[WebView concludeDragOperation:]): calls _web_bestURLForDraggingInfo

WebBrowser:

Used darin-inspired code factoring to fix 3000801 (alex doesn't accept drag of webloc file)
in 3 places where we accept drags.

• BrowserNSViewExtras.h:
• BrowserNSViewExtras.m: removed locationField specific drag methods
• LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): calls _web_acceptableDragTypes (-[LocationFieldEditor draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[LocationFieldEditor draggingUpdated:]): calls _web_dragOperationForDraggingInfo (-[LocationFieldEditor concludeDragOperation:]): calls _web_bestURLForDraggingInfo
• LocationTextField.m: (-[LocationTextField awakeFromNib]): calls _web_acceptableDragTypes (-[LocationTextField draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[LocationTextField draggingUpdated:]): calls _web_dragOperationForDraggingInfo (-[LocationTextField concludeDragOperation:]): calls _web_bestURLForDraggingInfo

10:54 AM Changeset in webkit [1619] by cblu

• 4 edits in trunk/WebKit

WebKit:

• We were loading icons when page loads ended in error. Fixed.
• Special-case file URLs once instead of twice by moving NSWorkspace call out of WebIconLoader

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): removed file URL special-case
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): check for document error, send file

WebBrowser:

• Comparison between a float and int was causing download history to be erased
• Set the dock mini window to display # of active downloads

• DownloadMonitor.h: renamed _hourlyTimer to _removeExpiredTimer
• DownloadMonitor.m: (-[DownloadMonitor dealloc]): (-[DownloadMonitor updateProgressUI]): set mini dock title (-[DownloadMonitor windowDidLoad]):

4:00 AM Changeset in webkit [1618] by mjs

• 11 edits in trunk

top level:

• Tests/ObjcUnit/Makefile.am: Remove products from symroots on `make clean'.
• Tests/TestPlugin/Makefile.am: Remove products from symroots on `make clean'.
• Tests/WebFoundation-CacheLoader/Makefile.am: Remove products from symroots on `make clean'.

Tools:

• CommitLogEditor/Makefile.am: Remove products from symroots on `make clean'.
• HotSpotFinder/Makefile.am: Remove products from symroots on `make clean'.

JavaScriptCore:

• Makefile.am: Remove products from symroots on `make clean'.

WebFoundation:

• Makefile.am: Remove products from symroots on `make clean'.

WebCore:

• Makefile.am: Remove products from symroots on `make clean'.

WebKit:

• Makefile.am: Remove products from symroots on `make clean'.

WebBrowser:

• Makefile.am: Remove products from symroots on `make clean'.

3:21 AM Changeset in webkit [1617] by mjs

• 4 edits in trunk/WebCore

• WebCore.pbproj/project.pbxproj: Set directories for the group folders, so that creating new files in them will put them in the right directory by default.

2:37 AM Changeset in webkit [1616] by mjs

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Set directories for the group folders, so that creating new files in them will put them in the right directory by default.

2:11 AM Changeset in webkit [1615] by mjs

• 6 edits in trunk/WebKit

More refactoring. Change bridge to get the data source via a
method instead of straight from the ivar, and in the method,
assert that the data source is not nil and is not
provisional. Turns out no one was using it while provisional,
which is great. This means we can eliminate the provisional
concept from the bridge interface as the next step.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSource]): New method to get data source - assert it is not nil, and committed. (-[WebBridge frame]): Get data source from method. (-[WebBridge childFrames]): Likewise. (-[WebBridge descendantFrameNamed:]): Likewise. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Likewise. (-[WebBridge openNewWindowWithURL:]): Likewise. (-[WebBridge areToolbarsVisible]): Likewise. (-[WebBridge setToolbarsVisible:]): Likewise. (-[WebBridge areScrollbarsVisible]): Likewise. (-[WebBridge setScrollbarsVisible:]): Likewise. (-[WebBridge isStatusBarVisible]): Likewise. (-[WebBridge setStatusBarVisible:]): Likewise. (-[WebBridge setWindowFrame:]): Likewise. (-[WebBridge window]): Likewise. (-[WebBridge setTitle:]): Likewise. (-[WebBridge setStatusText:]): Likewise. (-[WebBridge mainFrame]): Likewise. (-[WebBridge frameNamed:]): Likewise. (-[WebBridge receivedData:withDataSource:]): Likewise. (-[WebBridge startLoadingResource:withURL:]): Likewise. (-[WebBridge objectLoadedFromCache:size:]): Likewise. (-[WebBridge setDataSource:]): Likewise. (-[WebBridge openedByScript]): Likewise. (-[WebBridge setOpenedByScript:]): Likewise. (-[WebBridge setIconURL:]): Likewise. (-[WebBridge setIconURL:withType:]): Likewise.
• WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _isCommitted]): New private method to check if a data source is committed, for the benefit of WebBridge assertions.

12:46 AM Changeset in webkit [1614] by hyatt

• 6 edits in trunk/WebCore

Apologies for the lack of the changelog info. I need help setting that up on my laptop. I did edit the changelog, and you can see it there. This is a fix to speed up list boxes.