Timeline



Jul 27, 2002:

9:14 AM Changeset in webkit [1686] by cblu
  • 19 edits in trunk/WebKit

WebKit:

Implemented click policy, support for option-click
Implemented dragging of links and images from WebHTMLView

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:]): added, moved from WebBrowser (-[NSView _web_dragOperationForDraggingInfo:]): don't accept drag if source == destination
  • WebView.subproj/WebControllerPolicyHandler.h:
  • WebView.subproj/WebControllerPolicyHandler.m: (-[WebPolicy URL]): needed for click policy (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:toPath:]): added, simply downloads a URL
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler downloadURL:]): calls [WebController _downloadURL:toPath:]
  • WebView.subproj/WebDefaultPolicyHandler.m: (-[WebDefaultPolicyHandler clickPolicyForElement:button:modifierMask:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): calls _continueAfterCheckingDragForEvent (-[WebHTMLView mouseUp:]): calls _continueAfterClickPolicyForEvent (-[WebHTMLView draggingSourceOperationMaskForLocal:]): added (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): added, starts download
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _elementAtPoint:]): (-[WebHTMLView _continueAfterClickPolicyForEvent:]): added, implements click policy (-[WebHTMLView _continueAfterCheckingDragForEvent:]): added, checks if mouse event is a drag

WebBrowser:

Support for option-click.
Moved _web_dragShouldBeginFromMouseDown:withExpiration: to WebKit

  • BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierMask:]): support for option and command click
  • FavoriteButton.m: (-[FavoriteButton mouseDown:]): call _web_dragShouldBeginFromMouseDown:withExpiration:
  • LocationTextField.m: (-[LocationTextField mouseDown:]): call _web_dragShouldBeginFromMouseDown:withExpiration:

Jul 26, 2002:

6:37 PM Changeset in webkit [1685] by hyatt
  • 4 edits in trunk/WebCore

WebFoundation:

Changing the default user agent to be Gecko. This fixes
the layout issues with livepage.apple.com. We simply
cannot support absolute positioning while claiming to
be Mac MSIE, since Mac MSIE incorrectly computes the containing
block and sites have to correct for that.

As per discussion with gramps, simply removing the plist lookup
for the agent and hardcoding it to Gecko for now.

  • CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler defaultUserAgent]):
  • ChangeLog:
  • Defaults.plist:

WebCore:

Changing the default user agent to be Gecko. This fixes
the layout issues with livepage.apple.com. We simply
cannot support absolute positioning while claiming to
be Mac MSIE, since Mac MSIE incorrectly computes the containing
block and sites have to correct for that.

  • ChangeLog:
  • kwq/KWQKProtocolManager.mm: (KProtocolManager::userAgentForHost):
4:18 PM Changeset in webkit [1684] by rjw
  • 2 edits in trunk/WebKit

Fixed comment in changelog.

4:18 PM Changeset in webkit [1683] by rjw
  • 3 edits in trunk/WebKit

WebframeLoadType enum first value was explicitly set, so 0 was used.
I assumed 0 was unitialized, and depended on that to not execute some 'transitional'
back/forward. This problem broke back/forward.

  • WebView.subproj/WebFramePrivate.h:
3:27 PM Changeset in webkit [1682] by hyatt
  • 4 edits in trunk/WebCore

Fix for 2944382, NOWRAP was being incorrectly applied in KHTML.
It was being ignored incorrectly if a fixed width was specified
on a cell. This width on the cell is actually irrelevant and
should not have been checked, since NOWRAP will affect the
whole column and not just a specific cell.

  • khtml/rendering/render_table.cpp: (RenderTableCell::calcMinMaxWidth):
3:17 PM Changeset in webkit [1681] by sullivan
  • 8 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3009404 -- Back/Forward menu items should use [ and ],
but command-arrows should still work too.

  • WebView.subproj/WebController.h:
  • added goForward to windowContext protocol. This is temporary, just like goBack here is temporary; they can be migrated into the new back-forward-in-WebKit design together.
  • WebView.subproj/WebView.m: (-[WebView keyDown:]): call _goBack and _goForward for command-arrow keys
  • WebView.subproj/WebViewPrivate.h,
  • WebView.subproj/WebViewPrivate.m: (-[WebView _goForward]): add _goForward, parallel to _existing goBack.

WebBrowser:

WebBrowser part of fix for 3009404 -- Back/Forward menu items should use [ and ],
but command-arrows should still work too.

  • fixed 3009385 -- standard command-arrow shortcuts don't work in Alexander outline views
  • fixed 3009388 -- left and right arrow should collapse/expand in Alexander outline views
  • BrowserWebController.m: (-[BrowserWebController goForward]): Added, parallel to existing goBack. This is a temporary place for this API, awaiting WebKit cleanup.
  • Defaults.plist: Set NSAllowSimpleArrowItemExpandDefault to true; gotta love that this exists.
  • English.lproj/MainMenu.nib: Change menu shortcuts for Back, Forward, and Last Search Results to use brackets instead of arrows
  • Help/KeyShortcuts.html: Update to match arrow -> bracket changes.
12:59 PM Changeset in webkit [1680] by cblu
  • 6 edits in trunk/WebKit

Fixed crash in unknown_text
Fixed full-window plug-ins. I think darin broken this :)
Cleaned up WebPluginStream a bit

  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
  • Plugins.subproj/WebPluginStream.m: (-[WebPluginStream getFunctionPointersFromPluginView:]): (-[WebPluginStream initWithURL:pluginPointer:notifyData:attributes:]): (-[WebPluginStream startLoad]): (-[WebPluginStream stop]): (-[WebPluginStream setUpGlobalsWithHandle:]): (-[WebPluginStream receivedError:]): (-[WebPluginStream receivedData:withDataSource:]): (-[WebPluginStream receivedError:withDataSource:]): (-[WebPluginStream WebResourceHandle:dataDidBecomeAvailable:]): (-[WebPluginStream WebResourceHandleDidCancelLoading:]): (-[WebPluginStream WebResourceHandle:didFailLoadingWithResult:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _mainHandle]): added, WebPluginStream needs this

Jul 25, 2002:

8:44 PM Changeset in webkit [1679] by rjw
  • 9 edits in trunk/WebKit

More incremental changes for back/forward migration.

  • BackForwardListEntry.h:
  • BackForwardListEntry.m:

More incremental changes for back/forward migration.

  • History.subproj/WebBackForwardList.h:
  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList addEntry:]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goBackToIndex:]): (-[WebBackForwardList backEntry]): (-[WebBackForwardList currentEntry]): (-[WebBackForwardList forwardEntry]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goForwardToIndex:]): (-[WebBackForwardList canGoBack]): (-[WebBackForwardList canGoForward]): (-[WebBackForwardList description]):
  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURL:title:]): (-[WebHistoryItem initWithURL:title:image:]): (-[WebHistoryItem initWithURL:target:title:image:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem target]): (-[WebHistoryItem setTarget:]): (-[WebHistoryItem setLastVisitedDate:]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem setScrollPoint:]):
  • History.subproj/WebHistoryList.m:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate setLoadType:]): (-[WebFrame _setLoadType:]): (-[WebFrame _loadType]): (-[WebFrame _transitionToCommitted]):
7:26 PM Changeset in webkit [1678] by cblu
  • 12 edits
    4 adds in trunk/WebKit

Made some WebPolicy API's private
Added support for download link/image to disk

  • Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebControllerPolicyHandler.h:
  • WebView.subproj/WebControllerPolicyHandler.m: (-[WebPolicyPrivate dealloc]): (-[WebPolicy _setPolicyAction:]): (-[WebPolicy policyAction]): (-[WebPolicy path]): (-[WebPolicy _setPath:]): (-[WebPolicy dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]): (+[WebClickPolicy webPolicyWithClickAction:andPath:]):
  • WebView.subproj/WebControllerPolicyHandlerPrivate.h: Added.
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler downloadURL:]): (-[WebDefaultContextMenuHandler downloadLinkToDisk:]): (-[WebDefaultContextMenuHandler openImageInNewWindow:]): (-[WebDefaultContextMenuHandler downloadImageToDisk:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):
6:14 PM Changeset in webkit [1677] by cblu
  • 9 edits in trunk/WebKit

Fixed crasher caused by not retaining the content policy.

  • WebView.subproj/WebControllerPolicyHandler.h:
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):
5:56 PM Changeset in webkit [1676] by cblu
  • 23 edits
    1 add in trunk/WebKit

WebKit:

Made policy APIs return a WebPolicy object.
Added click policy.

  • Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]): (-[WebDownloadHandler finishedLoading]): (-[WebDownloadHandler cancel]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (+[WebController defaultURLPolicyForURL:]):
  • WebView.subproj/WebControllerPolicyHandler.h:
  • WebView.subproj/WebControllerPolicyHandler.m: Added. (-[WebPolicy initWithPolicyAction:]): (-[WebPolicy policyAction]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]): (-[WebContentPolicy initWithContentPolicyAction:andPath:]): (-[WebContentPolicy dealloc]): (-[WebContentPolicy path]): (-[WebClickPolicy initWithClickPolicyAction:andPath:]): (+[WebClickPolicy webPolicyWithClickAction:andPath:]): (-[WebClickPolicy dealloc]): (-[WebClickPolicy path]):
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource contentPolicy]): (-[WebDataSource fileType]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setContentPolicy:]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _isReadyForData]):
  • WebView.subproj/WebDefaultPolicyHandler.m: (-[WebDefaultPolicyHandler URLPolicyForURL:]): (-[WebDefaultPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultPolicyHandler unableToImplementFileURLPolicy:error:forDataSource:]): (-[WebDefaultPolicyHandler unableToImplementURLPolicy:error:forURL:]): (-[WebDefaultPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]): (-[WebDefaultPolicyHandler clickPolicyForElement:button:modifierMask:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowDataSource:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedProgressWithHandle:complete:]): (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient WebResourceHandleDidFinishLoading:data:]): (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):

WebBrowser:

Made policy APIs return a WebPolicy object.

  • BrowserDocument.m: (-[BrowserDocument _stopNonDownloadingDataSource:]): (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]):
  • BrowserWebController.m: (-[BrowserWebController URLPolicyForURL:]): (-[BrowserWebController unableToImplementURLPolicy:error:forURL:]): (-[BrowserWebController fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[BrowserWebController unableToImplementFileURLPolicy:error:forDataSource:]): (-[BrowserWebController contentPolicyForMIMEType:dataSource:]): (-[BrowserWebController unableToImplementContentPolicy:error:forDataSource:]): (-[BrowserWebController clickPolicyForElement:button:modifierMask:]):
  • DownloadMonitor.m: (-[DownloadMonitor _monitorDownload:withProgress:error:dataSource:complete:]):
  • DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithResource:progress:error:dataSource:]):
5:17 PM Changeset in webkit [1675] by darin
  • 3 edits in trunk/WebCore

Remove bogus change log entry that I checked in by accident.

5:04 PM Changeset in webkit [1674] by darin
  • 19 edits in trunk

top level:

  • configure.in: Add DeploymentFat build style.

JavaScriptCore:

  • JavaScriptCore.pbproj/project.pbxproj: Add DeploymentFat build style.

WebFoundation:

  • WebFoundation.pbproj/project.pbxproj: Add DeploymentFat build style.

WebCore:

  • WebCore.pbproj/project.pbxproj: Add DeploymentFat build style.
  • fixed 3007532 -- Main documentation frame doesn't load on Apple docs page

This was caused by my recent fix for the "checkboxes in wrong place" bug.
While discussing that bug fix with Richard, I realized that I needed to do the
work at layout time, not print time. Luckily, this code ends up being simpler
than the original solution.

  • khtml/rendering/render_replaced.cpp: (RenderWidget::resizeWidget): Take out size limits based on X limits. (RenderWidget::layout): Move widgets off into far away coordinate space when layout happens. They get moved back on to the right position during the print process.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: Removed paint, buildViewsNotYetAddedSet, viewsNotYetAdded, and addedWidget.
  • kwq/KWQScrollView.mm: (QScrollView::addChild): Removed call to addedWidget.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Put the call to the renderer to print back in here, since it's simple again.
  • kwq/KWQWidget.mm: (QWidget::internalSetGeometry): Left in a couple of asserts that were useful in narrowing this one down.

WebKit:

  • WebKit.pbproj/project.pbxproj: Add DeploymentFat build style.

WebBrowser:

  • WebBrowser.pbproj/project.pbxproj: Add DeploymentFat build style.
3:53 PM Changeset in webkit [1673] by hyatt
  • 4 edits in trunk/WebCore

Floated images using "align" should have margins to prevent the text from running right
up against them. Matches IE and Mozilla behavior.

  • khtml/css/html4.css:
3:36 PM Changeset in webkit [1672] by hyatt
  • 4 edits in trunk/WebCore

Fix <blockquote> tags to have top and bottom margins of 1em. This matches the <blockquote>
behavior in Gecko.

  • khtml/css/html4.css:
3:17 PM Changeset in webkit [1671] by darin
  • 23 edits in trunk

WebFoundation:

WebFoundation part of fix for 3006054 -- assert error failingURL != nil

  • CacheLoader.subproj/IFURLHandleC.h:
  • CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode): Call absoluteString. (IFErrorGetFailingURL): Change result type to CFStringRef.
  • CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler continueHeaderReadAfterFailureResponseAndCall:]): Call absoluteString.
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:isTerminal:]): Call absoluteString.
  • Misc.subproj/WebError.h:
  • Misc.subproj/WebError.m: (+[WebError errorWithCode:inDomain:failingURL:isTerminal:]): Change type of failingURL to NSString. (-[WebError initWithErrorCode:inDomain:failingURL:isTerminal:]): Change type of failingURL to NSString. (-[WebError failingURL]): Change type to NSString. (-[WebError description]): Don't call absoluteString.

WebCore:

  • fixed 2965269 -- sizes reported to progress handler from KWQCheckCacheObjectStatus for images are wrong
  • fixed 3006054 -- assert error failingURL != nil
  • khtml/misc/loader.h: Add dataSize() and m_dataSize.
  • khtml/misc/loader.cpp: (CachedImage::CachedImage): Initialize m_dataSize. (CachedImage::data): Update m_dataSize.
  • kwq/kio/jobclasses.h:
  • kwq/KWQKjobclasses.mm: Store a KURL instead of an NSURL, because KURL can hold any string.
  • kwq/KWQLoaderImpl.mm: (KWQServeRequest): Send an error with [WebCoreBridge reportError:] if the URL is so bad we can't construct an NSURL from it. This is the only case in all our code where we need to have failingURL accept a string. (KWQCheckCacheObjectStatus): If the object is an image, use the dataSize() rather than size(). The size() is a (bad) estimate of how much memory is used in the case of an image, but we want to report the size of the original data.
  • kwq/WebCoreBridge.h: Add a [reportError:] method.

WebKit:

WebKit part of fix for 3006054 -- assert error failingURL != nil

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportError:]): New. Passes the error to the controller associated with the dataSource.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]): Call absoluteString. (-[WebSubresourceClient WebResourceHandleDidCancelLoading:]): Call absoluteString.
  • WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Call absoluteString.
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Don't call absoluteString.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowDataSource:]): Call absoluteString.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandleDidCancelLoading:]): Call absoluteString.

WebBrowser:

WebBrowser part of fix for 3006054 -- assert error failingURL != nil

  • BrowserWebController.m: (-[BrowserWebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): Don't call absoluteString.
  • DownloadProgressEntry.m: (-[DownloadProgressEntry stop]): Call absoluteString.
  • LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:]): Don't call absoluteString. Also use _web_URLWithString to make a URL to parse out the host part. (-[LocationChangeHandler genericMessageForError:]): Don't call absoluteString.
3:11 PM Changeset in webkit [1670] by hyatt
  • 4 edits in trunk/WebCore

Fix for huge white space problem on appleturns.com, bug 2947818. Vertical-align
was being applied to block-level elts in violation of the CSS2 spec. Vertical-align
is only supposed to apply to inline-level elts and table cells. getVerticalPosition
will now bail if the element is block-level.

  • khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition):
12:50 PM Changeset in webkit [1669] by cblu
  • 4 edits in trunk/WebKit

WebKit:

Remove reloadImage until its implemented.

  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):

WebBrowser:

Remove reloadImage until its implemented.

  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
12:38 PM Changeset in webkit [1668] by cblu
  • 15 edits in trunk

WebCore:

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): renamed

WebKit:

Renamed elementInfoAtPoint to elementAtPoint

  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDefaultContextMenuHandler.h:
  • WebView.subproj/WebDefaultContextMenuHandler.m: (+[WebDefaultContextMenuHandler addMenuItemWithTitle:action:target:toArray:]): renamed (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):

WebBrowser:

Added WebBrowser specific contextual menu items.

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument setSaveDataSource:]): set the current data source to save (-[BrowserDocument dataRepresentationOfType:]): uses the current data source
  • ContextMenuHandler.h: Added.
  • ContextMenuHandler.m: Added. (-[ContextMenuHandler dealloc]): (-[ContextMenuHandler _addMenuItemWithAction:fromArray:toArray:]): (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler _document]): (-[ContextMenuHandler addLinkToBookmarks:]): (-[ContextMenuHandler viewSource:]): (-[ContextMenuHandler savePageAs:]):
  • WebBrowser.pbproj/project.pbxproj:
12:41 AM Changeset in webkit [1667] by hyatt
  • 5 edits in trunk/WebCore

Fix for bug 2992158, the calendar on www.blog.org in the upper
right was shoved offscreen (and causing a horizontal scrollbar
to be necessary). KHTML was not recomputing the margins for
the table when it became displaced by the float. It was also
mispositioning the float itself.

  • khtml/rendering/render_box.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::addOverHangingFloats):

Jul 24, 2002:

6:38 PM Changeset in webkit [1666] by cblu
  • 4 edits in trunk/WebKit

tiny change

  • WebView.subproj/WebDefaultContextMenuHandler.m:
6:34 PM Changeset in webkit [1665] by cblu
  • 9 edits in trunk/WebKit

Added implmentations for a few context menu items.

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebDefaultContextMenuHandler.h:
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler dealloc]): (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuHandler validateUserInterfaceItem:]): (-[WebDefaultContextMenuHandler openNewWindowWithURL:]): (-[WebDefaultContextMenuHandler openLinkInNewWindow:]): (-[WebDefaultContextMenuHandler copyLinkToClipboard:]): (-[WebDefaultContextMenuHandler openImageInNewWindow:]): (-[WebDefaultContextMenuHandler copyImageToClipboard:]): (-[WebDefaultContextMenuHandler reloadImage:]): (-[WebDefaultContextMenuHandler openFrameInNewWindow:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
4:11 PM Changeset in webkit [1664] by rjw
  • 4 edits in trunk/WebKit

Removed vestigal locationChangeHandler ivar.

  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]):
3:59 PM Changeset in webkit [1663] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 2953423, viamichelin.com lays out incorrectly.
Remove a completely bogus optimization in the KHTML code that
attempted to bail when the specified width was 0. This was
a very basic problem, and it should fix other pages that were
laying out incorrectly as well.

  • khtml/rendering/render_flow.cpp: (RenderFlow::layout):
3:54 PM Changeset in webkit [1662] by cblu
  • 3 edits in trunk/WebKit

Call [self _locationChangeHandler] instead of _private-locationChangeHandler

  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource receivedPageIcon:]):
3:41 PM Changeset in webkit [1661] by rjw
  • 3 edits in trunk/WebKit

Implemented find for text views.

3:36 PM Changeset in webkit [1660] by cblu
  • 7 edits in trunk/WebKit

Implemented initial contextual menus. All disabled right now.

  • WebView.subproj/WebDefaultContextMenuHandler.h:
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler dealloc]): added (-[WebDefaultContextMenuHandler addMenuItemWithTitle:action:toArray:]): added (-[WebDefaultContextMenuHandler contextMenuItemsForElementInfo:defaultMenuItems:]): create menu items
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
2:22 PM Changeset in webkit [1659] by darin
  • 4 edits in trunk/WebCore
  • khtml/khtml_part.cpp: (KHTMLPart::clear): Remove code that reset m_frameNameId, to complete Maciej's change to fix bug 3006354.
2:14 PM Changeset in webkit [1658] by cblu
  • 8 edits in trunk/WebKit

More renaming for WebDefaultPolicyHandler.

  • WebView.subproj/WebController.m: (-[WebController policyHandler]):
  • WebView.subproj/WebDefaultPolicyHandler.h:
  • WebView.subproj/WebDefaultPolicyHandler.m:
2:07 PM Changeset in webkit [1657] by cblu
  • 3 edits
    4 adds
    2 deletes in trunk/WebKit

Renamed WebDefaultControllerPolicyHandler to WebDefaultPolicyHandler.

  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDefaultControllerPolicyHandler.h: Removed.
  • WebView.subproj/WebDefaultControllerPolicyHandler.m: Removed.
  • WebView.subproj/WebDefaultPolicyHandler.h: Added.
  • WebView.subproj/WebDefaultPolicyHandler.m: Added. (-[WebDefaultControllerPolicyHandler initWithWebController:]): (-[WebDefaultControllerPolicyHandler URLPolicyForURL:]): (-[WebDefaultControllerPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultControllerPolicyHandler unableToImplementFileURLPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler requestContentPolicyForMIMEType:dataSource:]): (-[WebDefaultControllerPolicyHandler unableToImplementURLPolicyForURL:error:]): (-[WebDefaultControllerPolicyHandler unableToImplementContentPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]):
1:55 PM Changeset in webkit [1656] by cblu
  • 14 edits
    4 adds in trunk/WebKit

More plumbing for contextual menu support.

  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setContextMenuHandler:]): added (-[WebController contextMenuHandler]): added
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): alloc WebDefaultContextMenuHandler (-[WebControllerPrivate dealloc]): dealloc WebDefaultContextMenuHandler (-[WebController _defaultContextMenuHandler]):
  • WebView.subproj/WebDefaultContextMenuHandler.h: Added.
  • WebView.subproj/WebDefaultContextMenuHandler.m: Added. (-[WebDefaultContextMenuHandler contextMenuItemsForElementInfo:defaultMenuItems:]): new
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): call contextMenuHandlers
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _setController:]): added comment (-[WebHTMLView _controller]): added
1:37 PM Changeset in webkit [1655] by darin
  • 25 edits in trunk

top level:

  • Site/Internal/Quality/fontsizes.html: Added test cases for "+/-" and "0".

WebCore:

  • fixed 2906567 -- Font size calculations should use 96 dpi instead of 72 dpi
  • fixed 3005932 -- fonts specified in 'ex' units rendered waaaaaaay too large
  • khtml/css/cssstyleselector.cpp: (CSSStyleSelector::computeFontSizes): Use a default font size that's the same as small, rather than a "medium font size". Don't multiply the values from settings by the scaling factor. (CSSStyleSelector::applyRule): Make the default font size here for nodes with no parents be small (m_fontSizes[2]) rather than medium (m_fontSizes[3]).
  • khtml/html/html_inlineimpl.cpp: (parseFontSizeNumber): Added. Tolerant of non-numeric characters after the numeric size. Also distinguishes a size like "0" from something that's not a numeric size at all. (HTMLFontElementImpl::parseAttribute): Use parseFontSizeNumber, but also make size 3 be the same as CSS_VAL_SMALL, not CSS_VAL_MEDIUM. This mistake (using CSS_VAL_MEDIUM) led to all kinds of strangeness in the KHTML code, including mishandling of 0 and the need to create CSS_VALKONQ_XXX_LARGE. Also change code so that 0 is treated as CSS_VAL_SMALL (same as 3) rather than CSS_VAL_XX_SMALL. This makes 0 between -1 and +1.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Make default font size be small (fontSizes()[2]) rather than medium (fontSizes()[3]).
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): Make default font size be CSS_VAL_SMALL, not CSS_VAL_MEDIUM.
  • kwq/qt/qfontmetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::xHeight): Added.
  • kwq/WebCoreTextRenderer.h: Added xHeight.
  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLengthFloat): Use xHeight rather than computing the height of an actual letter 'x'.
  • khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition): Use xHeight rather than computing the height of an actual letter 'x'.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStyles]): Fixed backwards if that prevented font changes from being reflected in the browser window.
  • kwq/khtml/khtml_settings.h:
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::defaultFontSize):
  • kwq/WebCoreSettings.h:
  • kwq/WebCoreSettings.m: (-[WebCoreSettings setDefaultFontSize:]): (-[WebCoreSettings defaultFontSize]): Replace mediumFontSize with defaultFontSize.
  • WebCore.pbproj/project.pbxproj: Rearrange some of the files.

WebKit:

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer xHeight]): Added. Calls [NSFont xHeight].
  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): (-[WebPreferences defaultFontSize]): (-[WebPreferences setDefaultFontSize:]): Renamed minimumFont to defaultFont, and changed it from 11 to 16. Also changed default monospaced font to Courier instead of Monaco.

WebBrowser:

  • Preferences.subproj/TextPreferences.m: (-[TextPreferences defaultFontSize]), (-[TextPreferences setDefaultFontSize:]): Change to use new WebPreferences mediumFontSize (since default is the same as small, not medium).
  • BrowserDocument.m: (-[BrowserDocument reapplyStyles:]): Use setNeedsDisplay: instead of display. It's impolite and unnecessary to do an explicit display.
  • WebBrowser.pbproj/project.pbxproj: Small name tweak.
1:14 PM Changeset in webkit [1654] by rjw
  • 12 edits in trunk

Support for find in HTML, find in text view coming soon.

  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView searchFor:direction:caseSensitive:]):
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebTextView.m: (-[WebTextView searchFor:direction:caseSensitive:]):

Support for find in HTML.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge searchFor:direction:caseSensitive:]):
10:31 AM Changeset in webkit [1653] by darin
  • 19 edits in trunk/WebCore
  • fixed 2949235 -- checkboxes in wrong place until you scroll away and back

The problem here was that we put views in when we print, but we never removed them.
I added code to keep track of existing views, and remove them if they are not re-added.

  • kwq/KWQKHTMLPartImpl.h: Add paint, addedWidget, buildViewsNotAddedSet, and viewsNotYetAdded. It might be nice to find a different place to hang this that is not included by the KHTML code. But I think that having this on the bridge would be worse.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::paint): Added. Removes any views that are not explicitly added by RenderWidget during the print process. (KWQKHTMLPartImpl::addedWidget): Added. Called by KWQScrollView to tell us a view was added. (KWQKHTMLPartImpl::buildViewsNotYetAddedSet): Added. Used to build the initial set of views.
  • kwq/KWQScrollView.mm: (QScrollView::addChild): Added call to KWQKHTMLPartImpl::addedWidget.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Calls KWQKHTMLPartImpl::paint.
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry), (KWQWindowWidget::mapToGlobal), (KWQWindowWidget::mapFromGlobal), (KWQWindowWidget::internalSetGeometry): Fixed logic to work properly for windows not on main screen.
  • khtml/khtml_part.cpp: Moved the boundary of an existing ifndef APPLE_CHANGES so that KHTMLPart::show() and hide() are not compiled, mainly for clarity.
  • khtml/rendering/render_replaced.cpp: (RenderWidget::detach): Removed unneeded APPLE_CHANGES.
  • kwq/KWQWindowWidget.h: Removed some unneeded virtual functions.
  • kwq/qt/qscrollview.h: Removed some unneeded virtual functions, made others non-virtual.
  • kwq/qt/qwidget.h: Removed some unneeded virtual functions, made others non-virtual.
  • kwq/KWQWidget.mm: Removed a lot of unused and unneeded stuff.
  • force-clean-timestamp: Needed to do this because I changed header files.
8:26 AM Changeset in webkit [1652] by darin
  • 4 edits in trunk/WebCore

top level:

  • Tests/kde/kurl-test.cpp: (main): Added a test case for a relative URL with a leading space in it.
  • Tests/kde/kurl-test.chk: Added the expected result.

WebCore:

  • fixed 3006329 - space should be stripped from beginning of relative url
  • kwq/KWQKURL.mm: (KURL::normalizeRelativeURLString): Added a call to stripWhiteSpace.
2:37 AM Changeset in webkit [1651] by mjs
  • 5 edits in trunk/WebCore

Made frame names globally unique, not just unique per parent frame

  • this is needed to avoid triggering the assertion in 3006354 (Assertion failure on salon.com). Clearing my cache made the assertion go away by itself, but it seems good to avoid the possibility of triggering it in the future.
  • khtml/khtmlpart_p.h: Make m_partNameId static.
  • khtml/khtml_part.cpp: Initialize it here.
12:19 AM Changeset in webkit [1650] by darin
  • 5 edits in trunk/WebCore
  • 3006336 -- crash in _NSDescriptionWithLocaleFunc
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Don't use the result of getNSString() on a C++ temporary object. We could also fix this by doing retain autorelease in getNSString().
Note: See TracTimeline for information about the timeline view.