Timeline



Jul 30, 2002:

7:38 PM Changeset in webkit [1706] by mjs
  • 13 edits in trunk

WebCore:

Fixes of various bugs that prevented Alexander from running the
Mozilla page load test.

  • fixed 3008682 - Alexander cannot run Mozilla-PLT
  • khtml/misc/decoder.cpp: (Decoder::decode): Don't drop the accumulated buffer if the document happens to be unicode!
  • kwq/KWQCString.mm: (operator==): Fix reversed logic when comparing an empty QCString to a const char *.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Set complete flag later so that initializing it to false doesn't clobber setting it. (KWQKHTMLPartImpl::begin): Initialize complete flag to false. (KWQKHTMLPartImpl::write): Don't buffer things up for the decoder - the decoder does that internally.
  • kwq/WebCoreBridge.h, kwq/WebCoreBridge.mm: Remove setURL: method.

WebKit:

Fixes of various bugs that prevented Alexander from running the
Mozilla page load test.

  • fixed 3008682 - Alexander cannot run Mozilla-PLT
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSourceChanged]): Don't call setURL: to set a URL that we got from a redirect; just pass it directly to openURL:. The inputURL is irrelevant.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setFinalURL:]): Don't call setURL: on the bridge; instead, assert that the data source is committed, because it would be a mistake to get a redirect after having received data.
7:14 PM Changeset in webkit [1705] by rjw
  • 4 edits in trunk/WebCore

Don't create unnecessary unicode string. Of the
95695 unnecessary unicode allocations we do loading
the base test, this usage accounted for 7185. Most
of the others come from DOMString to QConstString to
QString to unicode() conversion during parsing. All
that unnecessary work needs to be removed.

  • kwq/KWQColor.mm: (decodeColorFromHexColorString):
4:53 PM Changeset in webkit [1704] by hyatt
  • 4 edits in trunk/WebCore

Ok, this time i've got it. I hope. I think. Fingers crossed.
Putting the table recalc check back in one more time. :)

  • khtml/rendering/render_table.cpp: (RenderTable::addColumns): (RenderTable::addColInfo):
4:30 PM Changeset in webkit [1703] by hyatt
  • 4 edits in trunk/WebCore

Backing myself out again. No crashes, but now pages stall.
#*&*#@%*&!!!!

  • khtml/rendering/render_table.cpp: (RenderTable::recalcColInfo): (RenderTable::addColInfo):
4:07 PM Changeset in webkit [1702] by hyatt
  • 5 edits in trunk/WebCore

Putting my table patch back in. Also optimizing the code
to avoid deleting and recreating the same colinfo over
and over again. Now colinfos can recalc their own
information.

  • khtml/rendering/render_table.cpp: (RenderTable::addColumns): (RenderTable::recalcColInfo): (RenderTable::addColInfo): (RenderTable::calcMinMaxWidth):
  • khtml/rendering/render_table.h:
3:38 PM Changeset in webkit [1701] by rjw
  • 4 edits in trunk/WebCore

Inline critical function.

  • kwq/KWQString.mm: (compareToLatinCharacter):
2:03 PM Changeset in webkit [1700] by rjw
  • 3 edits in trunk/WebKit

i Remove annoying log, it's really annoying. Added FIX ME

comment instead.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):
12:05 PM Changeset in webkit [1699] by rjw
  • 4 edits in trunk/WebCore

Wow! Avoid creation of unicode string when only a single character
is needed. Simple change for big gains, 7% - 10% improvement
on cached pages. Other similar gains may remain to be had.

  • khtml/css/cssparser.cpp:
12:04 PM Changeset in webkit [1698] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

  • fixed 3012083 "Looked for URLs on the pasteboard, but found none" spam dragging nil-target bookmark
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_bestURLForDraggingInfo:]): This method was getting data for types on the pasteboard without first checking whether the types were on the pasteboard, a no-no. Restructured this method and tweaked it here and there also.

(-[NSView _web_dragOperationForDraggingInfo:]): moved a fast
test in front of a slow test

WebBrowser:

  • fixed 3011887 -- dropping favorite on a favorites folder makes copy but should move
  • FavoriteButton.m: (-[FavoriteButton determineDragOperation:]): New helper routine to decide between move & copy based on drag source and option key state. (-[FavoriteButton draggingEntered:]), (-[FavoriteButton draggingUpdated:]): use determineDragOperation.
  • ToolbarButtonItem.m: (+[ToolbarButtonItem itemWithIdentifier:button:action:]): tweaked this while investigating some other bug.
11:04 AM Changeset in webkit [1697] by darin
  • 4 edits in trunk/WebCore
  • khtml/css/makevalues: Fail if we don't find gperf.
3:00 AM Changeset in webkit [1696] by hyatt
  • 4 edits in trunk/WebCore

Back myself out. I seem to have stumbled onto another bug.
Until I figure it out, turn this back off.

  • khtml/rendering/render_table.cpp: (RenderTable::addColumns): (RenderTable::addColInfo):
1:51 AM Changeset in webkit [1695] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3000604, 2902173, 2921313. Ensure that tables recalc their
column widths like they are supposed to. This fixes livepage.apple.com,
applemuseum.com, and many other pages (that didn't have bugs filed).
Yay!

  • khtml/rendering/render_table.cpp: (RenderTable::recalcColInfo): (RenderTable::addColInfo):

Jul 29, 2002:

6:15 PM Changeset in webkit [1694] by rjw
  • 6 edits in trunk/WebKit

Removed setDirectsAllLinksToSystemBrowser: method, not needed
and antiquated by the policy APIs.

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m:
6:12 PM Changeset in webkit [1693] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3008660, arstechnica regression. Move the acquisition
of the document's text color (and the addition of CSS properties)
to the attach() call instead of the constructor. The table won't
add the properties until it is building its render object.

Also removing the #ifndef around the layout scheduler. This fixes
:hover feedback and reflows from things like the marquee on
livepage.apple.com.

  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): (HTMLTableElementImpl::id): (HTMLTableElementImpl::attach):
  • khtml/html/html_tableimpl.h:
  • khtml/rendering/render_object.h:
6:08 PM Changeset in webkit [1692] by rjw
  • 15 edits in trunk/WebKit

Changes to support the migration of back/forward list to WebKit.
Back/forward in frames now works (2946164), still not done w/
restoring scroll positions (2927633).

  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryItem.m: (+[WebHistoryItem entryWithURL:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController initWithView:provisionalDataSource:]): (-[WebController setUseBackForwardList:]): (-[WebController useBackForwardList]): (-[WebController goBack]): (-[WebController goForward]):
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _setProvisionalDataSource:]): (-[WebFrame _goToURL:withFrameLoadType:]):
  • WebView.subproj/WebViewPrivate.m: (-[WebView _goBack]): (-[WebView _goForward]):

Changes to support the migration of back/forward list to WebKit.
Back/forward in frames now works (2946164), still not done w/
restoring scroll positions (2927633).

  • History.subproj/WebHistoryItem.h:
  • BackForwardListEntry.h: Removed.
  • BackForwardListEntry.m: Removed.
  • BrowserDocument.m: (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]):
  • BrowserWebController.m:
  • LocationChangeHandler.m: (-[LocationChangeHandler _saveScrollPosition]): (-[LocationChangeHandler _restoreScrollPosition]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]):
  • WebBrowser.pbproj/project.pbxproj:
1:54 PM Changeset in webkit [1691] by darin
  • 23 edits in trunk/WebCore

top level:

  • Tests/kde/kurl-test.cpp: (operator<<):
  • Tests/qt/qregexp-test.cpp: (operator<<):
  • Tests/qt/qstring-test.cpp: (operator<<):
  • Tests/qt/qstringlist-test.cpp: (operator<<): Added output streaming so the tests work even without the implicit conversion of QString to const char *.

WebCore:

  • fixed 3010875 -- Find only works for latin characters
  • dealt with part of 2948387 -- stop button flashes to "go" twice while loading citibank.com
  • force-clean-timestamp: Make everyone do a make clean because dependencies won't do the right thing.
  • khtml/khtml_part.h:
  • khtml/khtml_part.cpp: (KHTMLPart::slotRedirect): Changed the APPLE_CHANGES ifdefs around in this function so we can start using it again. (KHTMLPart::jumpToSelection): Removed. The bridge goes straight to the impl.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge jumpToSelection]): Go straight to the impl.
  • WebCore-tests.exp: One new export needed for tests with change to qstring.h.
  • kwq/qt/qevent.h:
  • kwq/KWQEvent.mm: Removed unused stuff.
  • kwq/KWQKHTMLPartImpl.h: Removed redirectURL(); we now use KHTMLPart::slotRedirect().
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write): Call latin1() explicitly in here for m_documentSource. It was being done implicitly before. (KWQKHTMLPartImpl::scheduleRedirection): Get rid of 1-second minimum delay for meta refresh. (KWQKHTMLPartImpl::timerEvent): Call KHTMLPart::slotRedirect() instead of redirectURL(), because they were identical, so we don't need our own copy.
  • kwq/kdeui/kmessagebox.h:
  • kwq/KWQKMessageBox.mm: (KMessageBox::questionYesNo): Added dontAskAgain string parameter. Before, it was being turned into a bool!
  • kwq/KWQKProtocolManager.mm: Tweak and add FIXME.
  • kwq/qt/qstring.h: Remove implicit conversion to const char *, which causes only pain.
  • kwq/KWQString.mm: (QString::find): Add caseSensitive parameter to the QString overload of this. (QString::contains): Add a QString version of this.
  • kwq/character-sets.txt: Add the MIB number for ISO-10646-J-1.
  • kwq/make-charset-table.pl: Remove special case for ISO-10646-J-1 MIB number.
1:38 PM Changeset in webkit [1690] by rjw
  • 14 edits in trunk

Fixed 3009074. Added [WebHTMLView jumpToSelection:] and related user interface
item validation.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView jumpToSelection:]): (-[WebHTMLView validateUserInterfaceItem:]):

Fixed 3009074. Added KHTMLPart::jumpToSelection and related scaffolding (part impl, bridge, etc.)

  • khtml/khtml_part.cpp: (KHTMLPart::jumpToSelection):
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::jumpToSelection):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge jumpToSelection]):
12:35 PM Changeset in webkit [1689] by rjw
  • 4 edits in trunk/WebKit

Fixed 3009085. Implemented takeFindStringFromSelection: on WebHTMLView and WebTextView.
Also added user interface item validation for that method.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hasSelection]): (-[WebHTMLView takeFindStringFromSelection:]): (-[WebHTMLView validateUserInterfaceItem:]):
  • WebView.subproj/WebTextView.m: (-[WebTextView canTakeFindStringFromSelection]): (-[WebTextView takeFindStringFromSelection:]):
11:55 AM Changeset in webkit [1688] by rjw
  • 4 edits in trunk/WebCore

Fixed 3009067. We were not correctly testing the first character of the node string. Fixed in KWQString.
This highlighted another problem. KWQ does not support unichar * string find w/ case sensitive argument.
KWQString implements QString::find(const char *chs, int index, bool caseSensitive), so QStrings passed
will be auto-cast to char *. Filed 3010875 to track that issue.

  • kwq/KWQString.mm: (compareToLatinCharacter): (QString::find):
8:19 AM Changeset in webkit [1687] by cblu
  • 3 edits in trunk/WebKit

WebKit:

Fixed:
2971845 - text view uses default "user font" (Helvetica), not fonts chosen in Alexander preferences

  • WebView.subproj/WebTextView.m: (-[WebTextView initWithFrame:]): add observer (-[WebTextView dealloc]): remove observer (-[WebTextView setFixedWidthFont]): added, checks defaults (-[WebTextView dataSourceUpdated:]): calls setFixedWidthFont (-[WebTextView searchFor:direction:caseSensitive:]): no changes (-[WebTextView defaultsChanged:]): calls setFixedWidthFont

WebBrowser:

Fixed:
3006975 - Typing in address field should replace favicon with generic
3009771 - Bookmark title for dragged icon from location field is sometimes incorrect
3009755 - Dragged icon from location field needs to include title

  • BrowserWindowController.m: (-[BrowserWindowController bookmarkTitleForLocationField:]): use pageName
  • FavoriteButton.h:
  • FavoriteButton.m: (-[FavoriteButton imageForDraggingFromEvent:]): made public (-[FavoriteButton mouseDown:]): use imageForDraggingFromEvent
  • LocationTextField.h:
  • LocationTextField.m: (-[LocationTextField dealloc]): release cached icon and string (-[LocationTextField _setIcon:save:]): added, caches icon (-[LocationTextField setIcon:]): calls _setIcon:save: (-[LocationTextField mouseDown:]): calls imageForDraggingFromEvent (-[LocationTextField setStringValue:]): caches string (-[LocationTextField textDidChange:]): sets generic icon

Jul 27, 2002:

9:14 AM Changeset in webkit [1686] by cblu
  • 19 edits in trunk/WebKit

WebKit:

Implemented click policy, support for option-click
Implemented dragging of links and images from WebHTMLView

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:]): added, moved from WebBrowser (-[NSView _web_dragOperationForDraggingInfo:]): don't accept drag if source == destination
  • WebView.subproj/WebControllerPolicyHandler.h:
  • WebView.subproj/WebControllerPolicyHandler.m: (-[WebPolicy URL]): needed for click policy (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:toPath:]): added, simply downloads a URL
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler downloadURL:]): calls [WebController _downloadURL:toPath:]
  • WebView.subproj/WebDefaultPolicyHandler.m: (-[WebDefaultPolicyHandler clickPolicyForElement:button:modifierMask:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): calls _continueAfterCheckingDragForEvent (-[WebHTMLView mouseUp:]): calls _continueAfterClickPolicyForEvent (-[WebHTMLView draggingSourceOperationMaskForLocal:]): added (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): added, starts download
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _elementAtPoint:]): (-[WebHTMLView _continueAfterClickPolicyForEvent:]): added, implements click policy (-[WebHTMLView _continueAfterCheckingDragForEvent:]): added, checks if mouse event is a drag

WebBrowser:

Support for option-click.
Moved _web_dragShouldBeginFromMouseDown:withExpiration: to WebKit

  • BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierMask:]): support for option and command click
  • FavoriteButton.m: (-[FavoriteButton mouseDown:]): call _web_dragShouldBeginFromMouseDown:withExpiration:
  • LocationTextField.m: (-[LocationTextField mouseDown:]): call _web_dragShouldBeginFromMouseDown:withExpiration:

Jul 26, 2002:

6:37 PM Changeset in webkit [1685] by hyatt
  • 4 edits in trunk/WebCore

WebFoundation:

Changing the default user agent to be Gecko. This fixes
the layout issues with livepage.apple.com. We simply
cannot support absolute positioning while claiming to
be Mac MSIE, since Mac MSIE incorrectly computes the containing
block and sites have to correct for that.

As per discussion with gramps, simply removing the plist lookup
for the agent and hardcoding it to Gecko for now.

  • CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler defaultUserAgent]):
  • ChangeLog:
  • Defaults.plist:

WebCore:

Changing the default user agent to be Gecko. This fixes
the layout issues with livepage.apple.com. We simply
cannot support absolute positioning while claiming to
be Mac MSIE, since Mac MSIE incorrectly computes the containing
block and sites have to correct for that.

  • ChangeLog:
  • kwq/KWQKProtocolManager.mm: (KProtocolManager::userAgentForHost):
4:18 PM Changeset in webkit [1684] by rjw
  • 2 edits in trunk/WebKit

Fixed comment in changelog.

4:18 PM Changeset in webkit [1683] by rjw
  • 3 edits in trunk/WebKit

WebframeLoadType enum first value was explicitly set, so 0 was used.
I assumed 0 was unitialized, and depended on that to not execute some 'transitional'
back/forward. This problem broke back/forward.

  • WebView.subproj/WebFramePrivate.h:
3:27 PM Changeset in webkit [1682] by hyatt
  • 4 edits in trunk/WebCore

Fix for 2944382, NOWRAP was being incorrectly applied in KHTML.
It was being ignored incorrectly if a fixed width was specified
on a cell. This width on the cell is actually irrelevant and
should not have been checked, since NOWRAP will affect the
whole column and not just a specific cell.

  • khtml/rendering/render_table.cpp: (RenderTableCell::calcMinMaxWidth):
3:17 PM Changeset in webkit [1681] by sullivan
  • 8 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3009404 -- Back/Forward menu items should use [ and ],
but command-arrows should still work too.

  • WebView.subproj/WebController.h:
  • added goForward to windowContext protocol. This is temporary, just like goBack here is temporary; they can be migrated into the new back-forward-in-WebKit design together.
  • WebView.subproj/WebView.m: (-[WebView keyDown:]): call _goBack and _goForward for command-arrow keys
  • WebView.subproj/WebViewPrivate.h,
  • WebView.subproj/WebViewPrivate.m: (-[WebView _goForward]): add _goForward, parallel to _existing goBack.

WebBrowser:

WebBrowser part of fix for 3009404 -- Back/Forward menu items should use [ and ],
but command-arrows should still work too.

  • fixed 3009385 -- standard command-arrow shortcuts don't work in Alexander outline views
  • fixed 3009388 -- left and right arrow should collapse/expand in Alexander outline views
  • BrowserWebController.m: (-[BrowserWebController goForward]): Added, parallel to existing goBack. This is a temporary place for this API, awaiting WebKit cleanup.
  • Defaults.plist: Set NSAllowSimpleArrowItemExpandDefault to true; gotta love that this exists.
  • English.lproj/MainMenu.nib: Change menu shortcuts for Back, Forward, and Last Search Results to use brackets instead of arrows
  • Help/KeyShortcuts.html: Update to match arrow -> bracket changes.
12:59 PM Changeset in webkit [1680] by cblu
  • 6 edits in trunk/WebKit

Fixed crash in unknown_text
Fixed full-window plug-ins. I think darin broken this :)
Cleaned up WebPluginStream a bit

  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
  • Plugins.subproj/WebPluginStream.m: (-[WebPluginStream getFunctionPointersFromPluginView:]): (-[WebPluginStream initWithURL:pluginPointer:notifyData:attributes:]): (-[WebPluginStream startLoad]): (-[WebPluginStream stop]): (-[WebPluginStream setUpGlobalsWithHandle:]): (-[WebPluginStream receivedError:]): (-[WebPluginStream receivedData:withDataSource:]): (-[WebPluginStream receivedError:withDataSource:]): (-[WebPluginStream WebResourceHandle:dataDidBecomeAvailable:]): (-[WebPluginStream WebResourceHandleDidCancelLoading:]): (-[WebPluginStream WebResourceHandle:didFailLoadingWithResult:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _mainHandle]): added, WebPluginStream needs this
Note: See TracTimeline for information about the timeline view.