⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 1, 2002:

6:51 PM Changeset in webkit [1724] by rjw
  • 11 edits in trunk/WebKit

Effort towards 3014555 (going back to frame), but not fixed.
Need to think more about appropriate solution and compromises.

  • History.subproj/WebBackForwardList.h:
  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList backEntryAtIndex:]):
  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURL:title:]): (-[WebHistoryItem initWithURL:title:image:]): (-[WebHistoryItem initWithURL:target:parent:title:image:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem parent]): (-[WebHistoryItem setTitle:]): (-[WebHistoryItem setTarget:]): (-[WebHistoryItem setParent:]): (-[WebHistoryItem setDisplayTitle:]):
  • WebCoreSupport.subproj/WebBridge.m:
  • WebView.subproj/WebController.m: (-[WebController _goToItem:withFrameLoadType:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]): (-[WebFrame _scrollToTop]):
4:44 PM Changeset in webkit [1723] by cblu
  • 3 edits in trunk/WebKit

WebKit:

Only send command key events if the plug-in is in the responder chain.

  • Plugins.subproj/WebPluginView.m: (-[WebPluginView isInResponderChain]): (-[WebPluginView performKeyEquivalent:]): (-[WebPluginView setWindow]): added some more logging

WebBrowser:

Fixed: 2897678 - send urls from LS to new windows

  • AppController.m: (-[AppController handleGURLEvent:withReplyEvent:]):
3:40 PM Changeset in webkit [1722] by darin
  • 4 edits in trunk/WebCore
  • fixed 2841277 -- support for charset=gb2312
  • kwq/character-sets.txt: Added "euc-cn" to the list of aliases for "gb2312", since that's the name used by CFStringEncoding for that character set.
2:48 PM Changeset in webkit [1721] by mjs
  • 7 edits in trunk/WebCore

Remove KWQKHTMLPartImpl's setBaseURL method and m_baseURL field,
since nothing should really need them any more.

  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::begin): Set base URL on document, if it exists. (KWQKHTMLPartImpl::requestFrame): Get base URL from document. (KWQKHTMLPartImpl::requestObject): Ditto. (KWQKHTMLPartImpl::frames): Ditto. (KWQKHTMLPartImpl::setBaseURL): Removed.
2:26 PM Changeset in webkit [1720] by cblu
  • 3 edits in trunk/WebKit

Only send command keyDown once by ignoring the keyDown that comes after performKeyEquivalent.

  • Plugins.subproj/WebPluginView.m: (-[WebPluginView keyDown:]):
2:09 PM Changeset in webkit [1719] by cblu
  • 3 edits in trunk/WebKit

Fixed: 2970530 - Command keys are not getting passed in to plugins

  • Plugins.subproj/WebPluginView.m: (-[WebPluginView performKeyEquivalent:]):
1:31 PM Changeset in webkit [1718] by rjw
  • 18 edits in trunk

WebKit:

More back/forward word. Support for restoring scroll position.
We still have a big remaining issue. We don't record the entire
frame tree in back/forward items. This means going back or forward
to a frame will looose the context of the containing frameset,
see 3014555.

  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList currentEntry]):
  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem anchor]): (-[WebHistoryItem setAnchor:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportError:]):
  • WebView.subproj/WebController.m: (-[WebController _goToItem:withFrameLoadType:]): (-[WebController goBack]): (-[WebController goForward]):
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]): (-[WebFrame _goToItem:withFrameLoadType:]): (-[WebFrame _restoreScrollPosition]): (-[WebFrame _scrollToTop]):

WebBrowser:

Removed old obsolete restore scroll position code.

  • LocationChangeHandler.m: (-[LocationChangeHandler locationChangeStartedForDataSource:]):

WebCore:

Added method to allow WebKit to direct khtml to
goto to an anchor point. Need for back/forward.

  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge gotoAnchor:]):

WebFoundation:

Convenience method to remove fragment (target anchor)
from URL.

  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLWithoutFragment]):
1:09 PM Changeset in webkit [1717] by kocienda
  • 4 edits in trunk/WebCore

Tweaked WebCore cache settings. The WebCore cache will now grow
to 1 MB (was 512k). The maximum cacheable item is 16k instead of 40k.

  • khtml/misc/loader.cpp
11:19 AM Changeset in webkit [1716] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Added socket loader to get uncached HTTP content without using CFNetwork.

Zoom!

11:03 AM Changeset in webkit [1715] by cblu
  • 3 edits in trunk/WebKit

Fixed:
2938010 - PLUGINS: right-click support
2938011 - PLUGINS: extended key events support
2970523 - Arrow key events not correctly passed to applets

  • Plugins.subproj/WebPluginView.m: (-[WebPluginView modifiersForEvent:]): (-[WebPluginView getCarbonEvent:withEvent:]): (-[WebPluginView mouseDown:]): (-[WebPluginView keyUp:]): (-[WebPluginView keyDown:]): (-[WebPluginView menuForEvent:]):
10:47 AM Changeset in webkit [1714]
  • 3 copies in tags/Alexander-15

This commit was manufactured by cvs2svn to create tag 'Alexander-15'.

10:47 AM Changeset in webkit [1713] by sheridan
  • 8 edits in trunk

Alex-15 versions & changelog markers

8:18 AM Changeset in webkit [1712] by gramps
  • 3 edits in trunk/WebKit

Fixed deployment build compile problem.

2:59 AM Changeset in webkit [1711] by mjs
  • 8 edits in trunk/WebCore

Restored the original KHTMLPart::write() now that none of our
changes in the impl version are beneficial in any way.

  • khtml/khtml_part.cpp: (KHTMLPart::write): Restore original code in lieue of calling impl version.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURL): Remove initialization of m_decodingStarted, since it is now gone. (KWQKHTMLPartImpl::write): Removed.
2:36 AM Changeset in webkit [1710] by mjs
  • 7 edits in trunk/WebCore

Removed m_documentSource and remaining ill-conceived uses thereof.

  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURL): Don't initialize it. (KWQKHTMLPartImpl::write): Don't use it.
1:30 AM Changeset in webkit [1709] by mjs
  • 13 edits in trunk

WebCore:

Remove stuff formerly useful for "View Reconstructed Source"
feature but now useless.

  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::documentSource): Removed.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge documentTextFromDOM]): Removed.

WebKit:

Remove stuff formerly useful for "View Reconstructed Source"
feature but now useless.

  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource documentTextFromDOM]): Removed.
12:52 AM Changeset in webkit [1708] by mjs
  • 16 edits in trunk/WebKit

Changed things around so that WebFrame, not WebDataSource, owns
WebBridge. This allows us to remove the dummy data source.

  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Remove all dummy data source-related crud, but call _changeBridge to create the initial bridge. (-[WebFrame setProvisionalDataSource:]): Remove dummy data source-related epicycles.
  • WebView.subproj/WebFramePrivate.h: Add bridge member to private class.
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate setDataSource:]): Don't remove old data source from frame, this is no longer needed and may even be harmful. (-[WebFrame _transitionToCommitted]): Remove much now-unneeded code. (-[WebFrame _isLoadComplete]): Get location change handler from controller. Don't call end on the bridge if the document is not html. (-[WebFrame _changeBridge]): Free the old bridge and make a new one. (-[WebFrame _bridge]): Get it directly, not from the data source.
  • WebView.subproj/WebDataSourcePrivate.h: Remove everything related to the `dummy' concept.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setFinalURL:]): Reorder code a bit. (-[WebDataSource _bridge]): Get bridge from frame. (-[WebDataSource _commitIfReady]): No more need to set the bridge's frame. (-[WebDataSource _makeRepresentation]): Set data source on the rep. (-[WebDataSource _startLoading:]): Get location change handler from controller. (-[WebDataSource _setTitle:]): Likewise. (-[WebDataSource receivedPageIcon:]): Likewise. (-[WebDataSource _loadIcon]): Likewise.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]): Get location change handler from the controller.
  • WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]): Change *and* commit the data source. This could probably be collapsed down to one method now.
  • WebView.subproj/WebDocument.h: Added setDataSource: method to the WebDocumentRepresenation protocol. For now it is only useful for the HTML representation, but could potentially be useful for other representation classes. It should also allow the data source to be removed as a parameter from other methods, but I have not done that yet. It may be even better still to pass the data source as a paremeter to the init method.
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation init]): Remove allocation of bridge. (-[WebHTMLRepresentation dealloc]): Remove release of bridge. (-[WebHTMLRepresentation setDataSource:]): Store unretained reference to the data source's frame's bridge.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _bridge]): Fetch the bridge from the frame, not the data source.
  • WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation setDataSource:]): Added empty implementation.
  • WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation setDataSource:]): Added empty implementation.
  • Plugins.subproj/WebPluginStream.m: (-[WebPluginStream setDataSource:]): Added empty implementation.

Jul 31, 2002:

2:57 PM Changeset in webkit [1707] by darin
  • 13 edits in trunk/WebCore
  • kwq/qt/qptrvector.h:
  • kwq/qt/qvector.h:
  • kwq/KWQVectorImpl.h:
  • kwq/KWQVectorImpl.mm:
  • force-clean-timestamp: New implementation of QVector that does not use CFArray. Should fix some data() anomalies. Shares wierdnesses with the original Qt class.
  • WebCore-tests.exp: Remove old QVector entry points and add new ones.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write): Did a tiny optimization by initializing the QString rather than first assigning and then initializing. Also reworded some comments and rearranged code to make it clearer that m_decodingStarted is now used only to decide when to call determineParseMode.
  • khtml/css/cssparser.cpp: Removed the APPLE_CHANGES around a change that's fine for non-Apple use as well.

Jul 30, 2002:

7:38 PM Changeset in webkit [1706] by mjs
  • 13 edits in trunk

WebCore:

Fixes of various bugs that prevented Alexander from running the
Mozilla page load test.

  • fixed 3008682 - Alexander cannot run Mozilla-PLT
  • khtml/misc/decoder.cpp: (Decoder::decode): Don't drop the accumulated buffer if the document happens to be unicode!
  • kwq/KWQCString.mm: (operator==): Fix reversed logic when comparing an empty QCString to a const char *.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Set complete flag later so that initializing it to false doesn't clobber setting it. (KWQKHTMLPartImpl::begin): Initialize complete flag to false. (KWQKHTMLPartImpl::write): Don't buffer things up for the decoder - the decoder does that internally.
  • kwq/WebCoreBridge.h, kwq/WebCoreBridge.mm: Remove setURL: method.

WebKit:

Fixes of various bugs that prevented Alexander from running the
Mozilla page load test.

  • fixed 3008682 - Alexander cannot run Mozilla-PLT
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSourceChanged]): Don't call setURL: to set a URL that we got from a redirect; just pass it directly to openURL:. The inputURL is irrelevant.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setFinalURL:]): Don't call setURL: on the bridge; instead, assert that the data source is committed, because it would be a mistake to get a redirect after having received data.
7:14 PM Changeset in webkit [1705] by rjw
  • 4 edits in trunk/WebCore

Don't create unnecessary unicode string. Of the
95695 unnecessary unicode allocations we do loading
the base test, this usage accounted for 7185. Most
of the others come from DOMString to QConstString to
QString to unicode() conversion during parsing. All
that unnecessary work needs to be removed.

  • kwq/KWQColor.mm: (decodeColorFromHexColorString):
4:53 PM Changeset in webkit [1704] by hyatt
  • 4 edits in trunk/WebCore

Ok, this time i've got it. I hope. I think. Fingers crossed.
Putting the table recalc check back in one more time. :)

  • khtml/rendering/render_table.cpp: (RenderTable::addColumns): (RenderTable::addColInfo):
4:30 PM Changeset in webkit [1703] by hyatt
  • 4 edits in trunk/WebCore

Backing myself out again. No crashes, but now pages stall.
#*&*#@%*&!!!!

  • khtml/rendering/render_table.cpp: (RenderTable::recalcColInfo): (RenderTable::addColInfo):
4:07 PM Changeset in webkit [1702] by hyatt
  • 5 edits in trunk/WebCore

Putting my table patch back in. Also optimizing the code
to avoid deleting and recreating the same colinfo over
and over again. Now colinfos can recalc their own
information.

  • khtml/rendering/render_table.cpp: (RenderTable::addColumns): (RenderTable::recalcColInfo): (RenderTable::addColInfo): (RenderTable::calcMinMaxWidth):
  • khtml/rendering/render_table.h:
3:38 PM Changeset in webkit [1701] by rjw
  • 4 edits in trunk/WebCore

Inline critical function.

  • kwq/KWQString.mm: (compareToLatinCharacter):
2:03 PM Changeset in webkit [1700] by rjw
  • 3 edits in trunk/WebKit

i Remove annoying log, it's really annoying. Added FIX ME

comment instead.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):
12:05 PM Changeset in webkit [1699] by rjw
  • 4 edits in trunk/WebCore

Wow! Avoid creation of unicode string when only a single character
is needed. Simple change for big gains, 7% - 10% improvement
on cached pages. Other similar gains may remain to be had.

  • khtml/css/cssparser.cpp:
12:04 PM Changeset in webkit [1698] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

  • fixed 3012083 "Looked for URLs on the pasteboard, but found none" spam dragging nil-target bookmark
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_bestURLForDraggingInfo:]): This method was getting data for types on the pasteboard without first checking whether the types were on the pasteboard, a no-no. Restructured this method and tweaked it here and there also.

(-[NSView _web_dragOperationForDraggingInfo:]): moved a fast
test in front of a slow test

WebBrowser:

  • fixed 3011887 -- dropping favorite on a favorites folder makes copy but should move
  • FavoriteButton.m: (-[FavoriteButton determineDragOperation:]): New helper routine to decide between move & copy based on drag source and option key state. (-[FavoriteButton draggingEntered:]), (-[FavoriteButton draggingUpdated:]): use determineDragOperation.
  • ToolbarButtonItem.m: (+[ToolbarButtonItem itemWithIdentifier:button:action:]): tweaked this while investigating some other bug.
11:04 AM Changeset in webkit [1697] by darin
  • 4 edits in trunk/WebCore
  • khtml/css/makevalues: Fail if we don't find gperf.
3:00 AM Changeset in webkit [1696] by hyatt
  • 4 edits in trunk/WebCore

Back myself out. I seem to have stumbled onto another bug.
Until I figure it out, turn this back off.

  • khtml/rendering/render_table.cpp: (RenderTable::addColumns): (RenderTable::addColInfo):
1:51 AM Changeset in webkit [1695] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3000604, 2902173, 2921313. Ensure that tables recalc their
column widths like they are supposed to. This fixes livepage.apple.com,
applemuseum.com, and many other pages (that didn't have bugs filed).
Yay!

  • khtml/rendering/render_table.cpp: (RenderTable::recalcColInfo): (RenderTable::addColInfo):

Jul 29, 2002:

6:15 PM Changeset in webkit [1694] by rjw
  • 6 edits in trunk/WebKit

Removed setDirectsAllLinksToSystemBrowser: method, not needed
and antiquated by the policy APIs.

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m:
6:12 PM Changeset in webkit [1693] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3008660, arstechnica regression. Move the acquisition
of the document's text color (and the addition of CSS properties)
to the attach() call instead of the constructor. The table won't
add the properties until it is building its render object.

Also removing the #ifndef around the layout scheduler. This fixes
:hover feedback and reflows from things like the marquee on
livepage.apple.com.

  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): (HTMLTableElementImpl::id): (HTMLTableElementImpl::attach):
  • khtml/html/html_tableimpl.h:
  • khtml/rendering/render_object.h:
6:08 PM Changeset in webkit [1692] by rjw
  • 15 edits in trunk/WebKit

Changes to support the migration of back/forward list to WebKit.
Back/forward in frames now works (2946164), still not done w/
restoring scroll positions (2927633).

  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryItem.m: (+[WebHistoryItem entryWithURL:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController initWithView:provisionalDataSource:]): (-[WebController setUseBackForwardList:]): (-[WebController useBackForwardList]): (-[WebController goBack]): (-[WebController goForward]):
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _setProvisionalDataSource:]): (-[WebFrame _goToURL:withFrameLoadType:]):
  • WebView.subproj/WebViewPrivate.m: (-[WebView _goBack]): (-[WebView _goForward]):

Changes to support the migration of back/forward list to WebKit.
Back/forward in frames now works (2946164), still not done w/
restoring scroll positions (2927633).

  • History.subproj/WebHistoryItem.h:
  • BackForwardListEntry.h: Removed.
  • BackForwardListEntry.m: Removed.
  • BrowserDocument.m: (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]):
  • BrowserWebController.m:
  • LocationChangeHandler.m: (-[LocationChangeHandler _saveScrollPosition]): (-[LocationChangeHandler _restoreScrollPosition]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]):
  • WebBrowser.pbproj/project.pbxproj:
1:54 PM Changeset in webkit [1691] by darin
  • 23 edits in trunk/WebCore

top level:

  • Tests/kde/kurl-test.cpp: (operator<<):
  • Tests/qt/qregexp-test.cpp: (operator<<):
  • Tests/qt/qstring-test.cpp: (operator<<):
  • Tests/qt/qstringlist-test.cpp: (operator<<): Added output streaming so the tests work even without the implicit conversion of QString to const char *.

WebCore:

  • fixed 3010875 -- Find only works for latin characters
  • dealt with part of 2948387 -- stop button flashes to "go" twice while loading citibank.com
  • force-clean-timestamp: Make everyone do a make clean because dependencies won't do the right thing.
  • khtml/khtml_part.h:
  • khtml/khtml_part.cpp: (KHTMLPart::slotRedirect): Changed the APPLE_CHANGES ifdefs around in this function so we can start using it again. (KHTMLPart::jumpToSelection): Removed. The bridge goes straight to the impl.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge jumpToSelection]): Go straight to the impl.
  • WebCore-tests.exp: One new export needed for tests with change to qstring.h.
  • kwq/qt/qevent.h:
  • kwq/KWQEvent.mm: Removed unused stuff.
  • kwq/KWQKHTMLPartImpl.h: Removed redirectURL(); we now use KHTMLPart::slotRedirect().
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write): Call latin1() explicitly in here for m_documentSource. It was being done implicitly before. (KWQKHTMLPartImpl::scheduleRedirection): Get rid of 1-second minimum delay for meta refresh. (KWQKHTMLPartImpl::timerEvent): Call KHTMLPart::slotRedirect() instead of redirectURL(), because they were identical, so we don't need our own copy.
  • kwq/kdeui/kmessagebox.h:
  • kwq/KWQKMessageBox.mm: (KMessageBox::questionYesNo): Added dontAskAgain string parameter. Before, it was being turned into a bool!
  • kwq/KWQKProtocolManager.mm: Tweak and add FIXME.
  • kwq/qt/qstring.h: Remove implicit conversion to const char *, which causes only pain.
  • kwq/KWQString.mm: (QString::find): Add caseSensitive parameter to the QString overload of this. (QString::contains): Add a QString version of this.
  • kwq/character-sets.txt: Add the MIB number for ISO-10646-J-1.
  • kwq/make-charset-table.pl: Remove special case for ISO-10646-J-1 MIB number.
1:38 PM Changeset in webkit [1690] by rjw
  • 14 edits in trunk

Fixed 3009074. Added [WebHTMLView jumpToSelection:] and related user interface
item validation.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView jumpToSelection:]): (-[WebHTMLView validateUserInterfaceItem:]):

Fixed 3009074. Added KHTMLPart::jumpToSelection and related scaffolding (part impl, bridge, etc.)

  • khtml/khtml_part.cpp: (KHTMLPart::jumpToSelection):
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::jumpToSelection):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge jumpToSelection]):
12:35 PM Changeset in webkit [1689] by rjw
  • 4 edits in trunk/WebKit

Fixed 3009085. Implemented takeFindStringFromSelection: on WebHTMLView and WebTextView.
Also added user interface item validation for that method.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hasSelection]): (-[WebHTMLView takeFindStringFromSelection:]): (-[WebHTMLView validateUserInterfaceItem:]):
  • WebView.subproj/WebTextView.m: (-[WebTextView canTakeFindStringFromSelection]): (-[WebTextView takeFindStringFromSelection:]):
11:55 AM Changeset in webkit [1688] by rjw
  • 4 edits in trunk/WebCore

Fixed 3009067. We were not correctly testing the first character of the node string. Fixed in KWQString.
This highlighted another problem. KWQ does not support unichar * string find w/ case sensitive argument.
KWQString implements QString::find(const char *chs, int index, bool caseSensitive), so QStrings passed
will be auto-cast to char *. Filed 3010875 to track that issue.

  • kwq/KWQString.mm: (compareToLatinCharacter): (QString::find):
8:19 AM Changeset in webkit [1687] by cblu
  • 3 edits in trunk/WebKit

WebKit:

Fixed:
2971845 - text view uses default "user font" (Helvetica), not fonts chosen in Alexander preferences

  • WebView.subproj/WebTextView.m: (-[WebTextView initWithFrame:]): add observer (-[WebTextView dealloc]): remove observer (-[WebTextView setFixedWidthFont]): added, checks defaults (-[WebTextView dataSourceUpdated:]): calls setFixedWidthFont (-[WebTextView searchFor:direction:caseSensitive:]): no changes (-[WebTextView defaultsChanged:]): calls setFixedWidthFont

WebBrowser:

Fixed:
3006975 - Typing in address field should replace favicon with generic
3009771 - Bookmark title for dragged icon from location field is sometimes incorrect
3009755 - Dragged icon from location field needs to include title

  • BrowserWindowController.m: (-[BrowserWindowController bookmarkTitleForLocationField:]): use pageName
  • FavoriteButton.h:
  • FavoriteButton.m: (-[FavoriteButton imageForDraggingFromEvent:]): made public (-[FavoriteButton mouseDown:]): use imageForDraggingFromEvent
  • LocationTextField.h:
  • LocationTextField.m: (-[LocationTextField dealloc]): release cached icon and string (-[LocationTextField _setIcon:save:]): added, caches icon (-[LocationTextField setIcon:]): calls _setIcon:save: (-[LocationTextField mouseDown:]): calls imageForDraggingFromEvent (-[LocationTextField setStringValue:]): caches string (-[LocationTextField textDidChange:]): sets generic icon
Note: See TracTimeline for information about the timeline view.