⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 6, 2002:

10:46 PM Changeset in webkit [1763] by hyatt
  • 6 edits in trunk/WebCore

Make user stylesheet changes dynamic. Web documents will now
update as the user stylesheet is applied and unapplied. Altered
how reapplyStyles works a bit.

  • khtml/khtml_part.cpp: (KHTMLPart::reparseConfiguration):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setUserStyleSheet):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStyles]):
9:19 PM Changeset in webkit [1762] by hyatt
  • 5 edits in trunk/WebCore

Enable user stylesheet support. It works from a fresh start but
is not yet completely dynamic.

  • khtml/khtml_part.cpp: (KHTMLPart::setUserStyleSheet):
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::userStyleSheet):
9:12 PM Changeset in webkit [1761] by darin
  • 12 edits in trunk

WebCore:

  • fixed 2965321 -- Crash on window close in kthml::Loader::cancelRequests from particular page
  • khtml/misc/loader.cpp: (Loader::servePendingRequests): Look at return value from KWQServeRequest instead of assuming it will always succeed.
  • kwq/KWQLoaderImpl.h: Add return value for KWQServeRequest.
  • kwq/KWQLoaderImpl.mm: (KWQServeRequest): Return false if we fail to make either the NSURL or the WebResourceHandle. Also make sure that we delete the job if necessary.

WebKit:

Fix assert I saw while fixing bug 2965321.

  • WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Create a suitable resource identifier from the failing URL in the WebError for cases where we fail before we are able to construct a resource handle.
8:58 PM Changeset in webkit [1760] by sullivan
  • 4 edits in trunk/WebCore
  • force-clean-timestamp: Edited this file to force a make clean in WebCore after discovering that it was necessary the hard way. I'm not sure which earlier checkin made this be required.
8:39 PM Changeset in webkit [1759] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Fix crash in overURL, another case just like bug 3006336.
8:29 PM Changeset in webkit [1758] by darin
  • 3 edits in trunk/WebKit
  • fixed 2970516 -- Activate Events don't appear to be coming in to the Java Applet.plugin correctly.
  • Plugins.subproj/WebPluginView.m: (-[WebPluginView sendActivateEvent:]): Use activeFlag to set modifiers, not activMask, which is an event mask.
7:05 PM Changeset in webkit [1757] by rjw
  • 11 edits in trunk/WebCore

Frame resizing related changes. Frames are now resizable
w/ a resize bar. Still need to draw frame borders.

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderFrame::slotViewCleared):
  • kwq/KWQFrame.mm: (QFrame::setFrameStyle): (QFrame::frameStyle): (QFrame::frameWidth):
  • kwq/KWQWidget.mm: (QWidget::lockDrawingFocus): (QWidget::unlockDrawingFocus): (QWidget::flushDrawing): (QWidget::enableFlushDrawing): (QWidget::disableFlushDrawing): (QWidget::setDrawingAlpha): (QWidget::displayRect):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
  • kwq/qt/qframe.h:
  • kwq/qt/qwidget.h:
5:57 PM Changeset in webkit [1756] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

Add mechanism to store userStyleSheet preferences in WebKit in
preparation for Dave wiring up the implementation.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetEnabled]), (-[WebPreferences setUserStyleSheetEnabled:]), (-[WebPreferences userStyleSheetLocation]), (-[WebPreferences setUserStyleSheetLocation:]): New methods, read and write UserDefaults values.

(+[WebPreferences load]): Set initial values for
userStyleSheetEnabled and userStyleSheetLocation

WebBrowser:

Updated to use userStyleSheet preferences from WebKit.

  • Defaults.plist,
  • PreferenceKeys.h: Remove preference keys for ApplyStyleSheet since this is in WebKit now.
  • Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences setStylesheetPathPreference:]), (-[AppearancePreferences stylesheetPathPreference]), (-[AppearancePreferences updateStylesheetViews]), (-[AppearancePreferences toggleApplyStylesheet:]): Update to use WebKit preferences API; remove local storage.
4:28 PM Changeset in webkit [1755] by mjs
  • 16 edits in trunk

WebCore:

Removed some APPLE_CHANGES no longer needed after the part change.

  • khtml/khtml_part.cpp: (KHTMLPart::openedByJS): Don't call impl version. (KHTMLPart::setOpenedByJS): Don't call impl version.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: Removed openedByJS and setOpenedByJS.
  • kwq/WebCoreBridge.h: Don't prototype setOpenedByScript: and openedByScript methods now that they are not needed.

WebKit:

Removed some APPLE_CHANGES no longer needed after the part change.

  • WebCoreSupport.subproj/WebBridge.m: Remove setOpenedByScript: and openedByScript methods now that they are not needed.
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: Remove setOpenedByScript: and openedByScript methods now that they are not needed.
3:37 PM Changeset in webkit [1754] by darin
  • 8 edits in trunk/WebKit

WebKit:

  • fixed 3017761 -- dataSource != nil assertion navigating at yahoo.com
  • WebView.subproj/WebLocationChangeHandler.h:
  • WebView.subproj/WebLocationChangeHandler.m: Change client redirect calls to pass the frame, not the data source. At the time a client redirect is requested, it's not even clear yet which data source will be involved. We may want to make some of the other calls pass frames, also, aside from the "start", "committed", "done", calls, which must specify the data source.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Pass frame, not data source. (-[WebBridge reportClientRedirectCancelled]): Pass frame, not data source.

WebBrowser:

Update for change to client redirect API.

  • LocationChangeHandler.m: (-[LocationChangeHandler clientRedirectTo:delay:fireDate:forFrame:]): (-[LocationChangeHandler clientRedirectCancelledForFrame:]): We get the frame now, not the data source.
1:16 PM Changeset in webkit [1753] by hyatt
  • 7 edits in trunk/WebCore

Make checkboxes and radio buttons use the small control
size. Tweak their baselines to not use font metrics and
to line up properly. (voodooextreme.com nearly renders
the left column correctly now.)

  • khtml/rendering/render_form.cpp: (RenderCheckBox::baselinePosition): (RenderRadioButton::baselinePosition):
  • khtml/rendering/render_form.h:
  • kwq/KWQCheckBox.mm: (QCheckBox::QCheckBox):
  • kwq/KWQRadioButton.mm: (QRadioButton::QRadioButton):
12:54 PM Changeset in webkit [1752] by darin
  • 52 edits in trunk/WebKit

WebFoundation:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.

WebKit:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.

WebBrowser:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.
11:09 AM Changeset in webkit [1751] by sullivan
  • 4 edits in trunk/WebCore

WebCore:

WebCore part of fix for 2915396 -- implement larger/smaller font
or page zoom functionality

  • khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor): inside APPLE_CHANGES, remove use of KHTML limits for zoom factor; this is a client responsibility in our model.

WebBrowser:

WebBrowser part of fix for 2915396 -- implement larger/smaller font
or page zoom functionality

  • BrowserDocument.h:
  • BrowserDocument.m: Define min/max text multiplier values, and ratio (-[BrowserDocument canMakeTextLarger]), (-[BrowserDocument canMakeTextSmaller]): New methods, check that there's a page and that the new size wouldn't be too big/small.

(-[BrowserDocument makeTextLarger:]),
(-[BrowserDocument makeTextSmaller:]):
New methods, set web controller's text multiplier.

(-[BrowserDocument validateUserInterfaceItem:]):
Disable makeTextLarger and makeTextSmaller when appropriate.

11:00 AM Changeset in webkit [1750] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Put in a check for nil that I missed.
10:13 AM Changeset in webkit [1749] by darin
  • 26 edits in trunk

WebCore:

  • fixed 2948805 -- Need WebKit API for larger/smaller font feature
  • khtml/khtml_part.cpp: (KHTMLPart::clear): Head in the direction of using the m_frames and m_objects arrays, by turning some APPLE_CHANGES code on. (KHTMLPart::checkCompleted): More code turned on here. (KHTMLPart::checkEmitLoadEvent): And more code turned on here. (KHTMLPart::parentPart): Remove APPLE_CHANGES version. We can use the original now. (KHTMLPart::setZoomFactor): Remove APPLE_CHANGES. We want this function now.
  • khtml/khtml_part.h: Remove some APPLE_CHANGES to make xmlDocImpl public. No longer needed.
  • khtml/khtmlpart_p.h: Remove a bunch of APPLE_CHANGES.
  • kwq/KWQKHTMLPartImpl.h: Remove parentPart(), add getDocument() and getRenderer().
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Use parentPart() instead of [bridge parent]. (KWQKHTMLPartImpl::requestFrame): Set up a ChildFrame in the m_frames array. (KWQKHTMLPartImpl::layout): Use getRenderer(). (KWQKHTMLPartImpl::getDocument): Added. (KWQKHTMLPartImpl::getRenderer): Added.
  • kwq/WebCoreBridge.h: Add [setParent:], remove [parent].
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setParent:]): Added. (-[WebCoreBridge reapplyStyles]): Use getDocument(). (-[WebCoreBridge forceLayout]): Use getRenderer(). (-[WebCoreBridge drawRect:withPainter:]): Use getRenderer(). (-[WebCoreBridge copyDOMTree:]): Use getDocument(). (-[WebCoreBridge copyRenderTree:]): Use getRenderer(). (-[WebCoreBridge completeURLForDOMString:]): Use getDocument(). (-[WebCoreBridge elementAtPoint:]): Use getRenderer(). (-[WebCoreBridge setTextSizeMultiplier:]):
  • kwq/khtml/khtml_ext.h: Add dummy setEnabled function to make khtml_part.cpp compile.
  • kwq/kparts/part.h: Add real parent() and setParent() implementation.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSourceChanged]): Call setParent:.
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): Initialize the text size multiplier to 1.
  • WebView.subproj/WebDataSource.h: Removed [redirectedURL], deprecated [inputURL], added [URL].
  • WebView.subproj/WebDataSource.m: (-[WebDataSource URL]): Added. Returns current URL, without requiring separate logic for the redirected and not-yet-redirected cases.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): Use [WebDataSource URL].
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler openFrameInNewWindow:]): Use [WebDataSource URL].

WebBrowser:

  • BrowserDocument.m: (-[BrowserDocument currentURL]): Use [WebDataSource URL]. (-[BrowserDocument provisionalURL]): Use [WebDataSource URL].
  • BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:dataSource:]): Use [WebDataSource URL].
  • DownloadMonitor.m: (-[DownloadMonitor receivedProgress:forResourceHandle:fromDataSource:complete:]): Use [WebDataSource URL].
  • FrameProgressEntry.m: (-[FrameProgressEntry URL]): Use [WebDataSource URL].
9:21 AM Changeset in webkit [1748] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3017539 -- Replace Serif and Sans-serif
font preferences with Default preference; let fixed width font
size be independent.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Add default value for fixed width size (-[WebPreferences fixedFontSize]), (-[WebPreferences setFixedFontSize:]): New methods.

WebBrowser:

WebBrowser part of fix for 3017539 -- Replace Serif and Sans-serif
font preferences with Default preference; let fixed width font
size be independent.

  • Preferences.subproj/TextPreferences.h:
  • Preferences.subproj/TextPreferences.m: (-[TextPreferences updateFontSampleField:]): (-[TextPreferences updateFontSampleFields]): (-[TextPreferences chooseFont:]): (-[TextPreferences chooseStandardFont:]): (-[TextPreferences changeFont:]): (-[TextPreferences initializeFromDefaults]): Removed serif and sans-serif code, replaced with standard font. Made font sizes independent of each other.
  • Preferences.subproj/English.lproj/TextPreferences.nib: Futzed with Interface Builder.
8:36 AM Changeset in webkit [1747] by darin
  • 3 edits in trunk/WebKit
  • fixed 3017536 -- Change default font to Lucida Grande 14 pt.
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Changed default font and sans serif font family names to Lucida Grande. Changed default font size to 14 point.

Aug 5, 2002:

11:04 PM Changeset in webkit [1746] by mjs
  • 9 edits in trunk

WebCore:

Fixed crashers and leaks that come up when changing the view
associated with a part.

  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Don't zero out the part's view, because that will mess up setting a new one.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Destroy the old view if we own it.

WebKit:

fixed 2974993 - window.open does not return the right window object
fixed 3017140 - WebKit creates a new KHTMLPart per page; should
reuse it like KHTML does

  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation setDataSource:]): Don't swap the part at this point. Now it gets reused.
10:23 PM Changeset in webkit [1745] by mjs
  • 3 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Fix tyops that broke Development build.
9:54 PM Changeset in webkit [1744] by darin
  • 9 edits in trunk

WebCore:

  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURLInFrame): (KWQKHTMLPartImpl::urlSelected): (KWQKHTMLPartImpl::requestFrame): (KWQKHTMLPartImpl::requestObject): Add some nil checks before making calls with nil NSURL objects. But we also have to figure out how to report some kind of error in these cases, because the current behavior is not so good.

WebKit:

  • .cvsignore: Ignore WebCore-combined.exp.
9:35 PM Changeset in webkit [1743] by mjs
  • 13 edits
    1 add in trunk

JavaScriptCore:

  • fixed 3007072 - need to be able to build fat

WebFoundation:

  • fixed 3007072 - need to be able to build fat
  • WebFoundation.pbproj/project.pbxproj: Fixed DeploymentFat build.

WebCore:

  • fixed 3007072 - need to be able to build fat
  • WebCore.pbproj/project.pbxproj: Fixed DeploymentFat build.

WebKit:

  • fixed 3007072 - need to be able to build fat
  • WebKit.pbproj/project.pbxproj: Fixed DeploymentFat build.
  • Makefile.am: Build WebCore-combined.exp for Development and Mixed build.
  • WebKit-tests.exp: Added.
  • WebKit.exp: Remove test-only function.

WebBrowser:

  • fixed 3007072 - need to be able to build fat
  • WebBrowser.pbproj/project.pbxproj: Fixed DeploymetFat build.
9:21 PM Changeset in webkit [1742] by darin
  • 23 edits in trunk

WebCore:

  • fixed 3016374 -- Change font default from small back to medium
  • khtml/css/cssstyleselector.cpp: (CSSStyleSelector::computeFontSizes): Change back to basing everything on mediumFontSize() as opposed to a defaultFontSize that was the same as "small". (CSSStyleSelector::applyRule): Default is m_fontSizes[3] again.
  • khtml/html/html_inlineimpl.cpp: (HTMLFontElementImpl::parseAttribute): Shift all the sizes up one, so 3 is now medium. It's important that 3 be the same as the default.
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::attach): Change the default back to medium.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Change the default back to [3].
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFontSize): Change name back.
  • kwq/khtml/khtml_settings.h: Change name back to medium.

Do a little bit of wiring for the "text size multiplier" feature.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setTextSizeMultiplier:]): Added.

WebKit:

Do the wiring for the "text size multiplier" feature. The rest of the work will probably be done
at the WebCore level.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setFrame:]): Set the text size multiplier.
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setTextSizeMultiplier:]): Added. Calls _textSizeMultiplierChanged on the main frame. (-[WebController textSizeMultiplier]): Added.
  • WebView.subproj/WebControllerPrivate.h: Added textSizeMultiplier instance variable.
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _textSizeMultiplierChanged]): Added. Calls setTextSizeMultiplier: on the bridge, and _textSizeMultiplierChanged on all the child frames.
9:15 PM Changeset in webkit [1741] by cblu
  • 5 edits in trunk/WebKit

WebKit:

Renamed icon loader delegate method to include the icon loader.

  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]):
  • WebView.subproj/WebDataSourcePrivate.m:

WebBrowser:

Rendezvous changes:
Properly get host's IP address.
Load and display host's favicon.

  • English.lproj/Rendezvous.nib:
  • RendezvousController.m: (-[RendezvousController windowDidLoad]): (-[RendezvousController _attributedStringWithImage:]): (-[RendezvousController goToHostDoubleAction:]): (-[RendezvousController tableView:objectValueForTableColumn:row:]): (-[RendezvousController netServiceBrowser:didFindService:moreComing:]): (-[RendezvousController netServiceBrowser:didRemoveService:moreComing:]): (+[RendezvousController _URLForNetService:]): (-[RendezvousController netServiceDidResolveAddress:]): (-[RendezvousController iconLoader:receivedPageIcon:]):
7:38 PM Changeset in webkit [1740] by rjw
  • 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebTextRendererFactory.m

Added a comment.

7:35 PM Changeset in webkit [1739] by rjw
  • 3 edits in trunk/WebKit

Added additional check to find appropriate fonts with available
weight, rather than always using a weight of 5.

Regarding "kCGErrorFailure : can't find name id 4 for font id 8395" errors:
CG appears to be lying to us about some fonts, Verdana in particular.
It claims to have an available Verdana font w/ the correct traits, but spits errors
when we request that font. Further, the Font Panel behaves oddly when you request
Verdana. The panel displays the font but if you select the font it doesn't
'stick'. A mystery.

  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]):
6:23 PM Changeset in webkit [1738] by darin
  • 7 edits in trunk

top level:

  • Tests/WebFoundation-Misc/ifnsstringextensions-test.chk:
  • Tests/WebFoundation-Misc/ifnsstringextensions-test.m: (main): Added test cases for _web_stringByCollapsingNonPrintingCharacters.

WebFoundation:

  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_stringByCollapsingNonPrintingCharacters]): Added. Collapses any non-printing characters into single spaces, and trims them from the ends too.

WebCore:

  • fixed 3009321 -- bookmark and history menus show black square for (tm)
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseSpecial): Call fixUpChar. (HTMLTokenizer::parseText): Call fixUpChar. (HTMLTokenizer::parseTag): Call fixUpChar.

WebKit:

  • fixed 2986567 -- suppress return characters from title in title bar, status bar, menu items
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setTitle:]): Call _web_stringByCollapsingNonPrintingCharacters.
5:23 PM Changeset in webkit [1737] by rjw
  • 3 edits
    1 add in trunk/WebKit

Added exported symbols file.

  • WebKit.exp: Added.
  • WebKit.pbproj/project.pbxproj:
4:19 PM Changeset in webkit [1736] by darin
  • 4 edits in trunk/WebCore
  • kwq/make-charset-table.pl: Added a hack that makes us treat for iso-8859-8-e and iso-8859-8-i the same as iso-8859-8; may not be exactly right, but it's probably OK modulo the actual bidi support.
3:47 PM Changeset in webkit [1735] by darin
  • 8 edits in trunk/WebKit

WebFoundation:

  • fixed 3015360 -- google.com, click on images link, stop icon spins forever
  • CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle contentLengthReceived]): Fixed race condition where sizes of objects would jump down to 0 by returning the length of resourceData here instead of the mark. (-[WebResourceHandle _setLoad:]): Added. (-[WebResourceHandle _load]): Added. (-[WebResourceHandle _notifyClientsDidCancelLoading]): Do the WebResourceHandleDidBeginLoading calls outside the lock/unlock also.
  • CacheLoader.subproj/WebResourceHandlePrivate.h: Added _setLoad: and _load.
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad handleCount]): Add call to checkForNewHandles. (-[WebResourceLoad _submittedAttributes]): Added. (-[WebResourceLoad cleanup]): Pass the load to loadDidFinish, rather than passing a handle.
  • CacheLoader.subproj/WebResourceLoadManager.m: (-[WebResourceLoadManagerInstanceVariables init]): (-[WebResourceLoadManagerInstanceVariables dealloc]): (-[WebResourceLoadManager invalidateURL:]): (-[WebResourceLoadManager addLoad:forHandle:]): (-[WebResourceLoadManager requestWithURLHandle:]): (-[WebResourceLoadManager cancelRequestWithURLHandle:]): (-[WebResourceLoadManager loadDidFinish:]):
  • CacheLoader.subproj/WebResourceLoadManager.m: Added new WebResourceLoadKey class, rather than trying to trick handles themselves into acting as keys. This works better for the case where a single load is shared by two handles. There's no telling which will be cancelled first, so there's no obvious choice for which to use as the key. (-[WebResourceLoadManager requestWithURLHandle:]): Rewrote for new scheme. I think it's a little less tricky than before, but it's also more terse. (-[WebResourceLoadManager cancelRequestWithURLHandle:]): Rewrote this too. (-[WebResourceLoadManager loadDidFinish:]): This too.
  • CacheLoader.subproj/WebResourceLoadManagerPrivate.h: Change parameter type of loadDidFinish to WebResourceLoad. Removed unused cancelAllRequestsWithURL and cancelAllRequestsInGroup.
  • CacheLoader.subproj/WebResourceLoadPrivate.h: Removed unused removeAllHandles, cancelIfServingOneHandle, and added _submittedAttributes.
  • CacheLoader.subproj/WebResourceLoad.h: Removed canonicalURL.
  • CacheLoader.subproj/WebFileProtocolHandler.m:
  • CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.m:
  • CacheLoader.subproj/WebHTTPResourceLoader.m:
  • CacheLoader.subproj/WebResourceLoadQueue.m: [WebResourceLoad url] now always returns a canonical URL. Got rid of [WebResourceLoad canonicalURL] and updated callers.
  • CacheLoader.subproj/WebResourceLoadManager.h: Tweak.
  • Misc.subproj/WebNSDictionaryExtras.m: Fix definitions to match header.

WebKit:

  • fixed 3014122 -- spinner never stops spinning when iframe has URL with bad path
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Initialize the state in WebFramePrivate init instead.
  • WebView.subproj/WebFramePrivate.h: Remove WebFrameStateUninitialized.
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate init]): Set initial state to WebFrameStateComplete. (-[WebFrame _transitionToLayoutAcceptable]): Remove WebFrameStateUninitialized case. (-[WebFrame _transitionToCommitted]): Remove WebFrameStateUninitialized case. (-[WebFrame _isLoadComplete]): Remove WebFrameStateUninitialized case.
  • WebView.subproj/WebDataSource.h: Tweak.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource stopLoading]): Move downloadHandler logic from here into _stopLoading. (-[WebDataSource isLoading]): Rewrite for simplicity.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Move downloadHandler logic here from stopLoading. Also make this work even if handles are removed from the list during the stop process. (-[WebDataSource _recursiveStopLoading]): Simplify a lot by using WebFrame's stopLoading. (-[WebDataSource _setTitle:]): Use the committed boolean rather than the state to check if the title change should be sent to the location change handler.
9:07 AM Changeset in webkit [1734] by mjs
  • 3 edits in trunk/WebKit
  • Misc.subproj/WebKitDebug.h: Put WEBKIT_ASSERT_NOT_REACHED() inside the appropriate #ifdef, and remove the various _log macros, which are onsolete in WebKit.
4:30 AM Changeset in webkit [1733] by mjs
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Simplified a bit.
4:08 AM Changeset in webkit [1732] by mjs
  • 15 edits in trunk

WebCore:

Merged KHTMLPart::end method with khtml original.

  • khtml/khtml_part.cpp: (KHTMLPart::end): Remove call to impl. Use original version, but clear KURL cache and call slotFinishedParsing as well.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::end): Removed. (KWQKHTMLPartImpl::gotoBaseAnchor): Removed. No longer needed.
  • kwq/KWQKURL.mm: (KURL::encodedHtmlRef): Implemented. (KURL::htmlRef): Implemented.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge scrollToBaseAnchor]): Removed. No longer needed.

WebKit:

Some changes related to re-merging the KHTMLPart end() method:

  • Misc.subproj/WebKitDebug.h: Added WEBKIT_ASSERT_NOT_REACHED().
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToLayoutAcceptable]): Replace NSException with ASSERT_NOT_REACHED (this is an internal consistency check, not an argument check on a public API, so an assert is more appropriate than an exception). (-[WebFrame _transitionToCommitted]): Likewise. (-[WebFrame _isLoadComplete]): Likewise; also, remove bridge call to scrollToBaseAnchor:, since that will now happen automatically when calling end.
2:07 AM Changeset in webkit [1731] by mjs
  • 8 edits in trunk/WebCore

Merged KHTMLPart::openURL method with khtml original.

  • khtml/khtml_part.cpp: (KHTMLPart::openURL): Don't call the impl version. Leave most of this #ifdef'd, except the parts that look useful.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURL): Removed.
1:13 AM Changeset in webkit [1730] by mjs
  • 11 edits in trunk/WebCore

Merged KHTMLPart::begin method with khtml original.

  • khtml/khtml_part.cpp: (KHTMLPart::begin): Restore this method and don't call the impl version. ifdef out the parts that don't compile.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::begin): Removed.
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::showAnimations): Implemented; always return false. (KHTMLSettings::userStyleSheet): Implemented; always return empty string.
  • kwq/kdecore/kurl.h: Implemented isValid as inline method.

Aug 4, 2002:

4:13 PM Changeset in webkit [1729] by hyatt
  • 4 edits in trunk/WebCore

Fix my bungled CSS for input fields in the user agent style
sheet.

  • khtml/css/html4.css:

Aug 3, 2002:

1:21 PM Changeset in webkit [1728] by darin
  • 4 edits in trunk/WebCore
  • fixed 2943519 - • is rendered as an asterisk rather than a bullet
  • khtml/html/htmltokenizer.cpp: (fixUpChar): Replaced the macro of this name by an inline function that follows the Unicode specification. The macro was both making Windows Latin 1 extensions character codes (like 149 for bullet) work, but also mapping to characters that were suitable for Qt. Since OS X has no problem with the real Unicode values, we don't need that hack.

Aug 2, 2002:

10:53 PM Changeset in webkit [1727] by darin
  • 46 edits
    6 adds in trunk

WebCore:

  • khtml/misc/decoder.cpp: (Decoder::setEncoding): Put some hacks for handling Hebrew text encoding inside ifndef APPLE_CHANGES. It's not clear that these or the equivalent are needed for WebCore (they are related to the as-yet unimplemented bidirectional text support) and they were making us crash.
  • fixed 2949235 -- checkboxes in wrong place until you scroll away and back

I fixed this once before, then removed that fix in favor of a simpler one.
But the simpler one didn't work, and I didn't test it properly. Now I have
a fix that works without the drawbacks of the original.

  • khtml/rendering/render_replaced.cpp: (RenderWidget::layout): Remove the call to move the widget aside. This does no good because it's only called if the widget is told it needs to layout, which only happens if it's resized.
  • khtml/rendering/render_root.cpp: (RenderRoot::layout): Call a KWQ function so we can do some work at layout time.
  • kwq/KWQKHTMLPartImpl.mm: (moveWidgetsAside): Added. Function used recursively to move all widgets aside. (KWQKHTMLPartImpl::layout): Added. Called at layout time; moves all the widgets aside. They are moved back when print functions are called.

WebCore support for feature where client redirects are treated as if the
page was continuing to load. A big part of this was changing redirection
so that it uses QTimer, allowing us to use more of the original KHTMLPart
code. I added a feature to QTimer that KWQKHTMLPartImpl uses to monitor
what KHTMLPart does with the timer.

  • kwq/qt/qobject.h: Changed "slots" definition so that all slots are public (to help KWQSlot get at them). Added a prefix for the slot and signal strings, so that we can detect the case where it's trying to connect a slot to another slot. Implement the convenience version of connect here in the header. Implement blockSignals. Remove setTarget. Make target mutable. Add new m_signalListHead and m_signalsBlocked.
  • kwq/KWQObject.mm: (QObject::findSignal): Added. Helper function that locates a signal by name. (QObject::connect): Connects a signal to a slot using the new KWQSignal and KWQSlot. (QObject::disconnect): Disconnects, similar to the above. (QObject::QObject): Initialize target, m_signalListHead, and m_signalsBlocked. (QObject::~QObject): Assert that m_signalListHead is 0.
  • khtml/khtml_part.cpp: (KHTMLPart::init): Move the code that connects the redirection timer out of APPLE_CHANGES. (KHTMLPart::~KHTMLPart): Remove the APPLE_CHANGES around the code that stops the redirection timer. (KHTMLPart::restoreURL): Remove the APPLE_CHANGES around the code that stops the redirection timer. (KHTMLPart::openURL): Move the APPLE_CHANGES so the code that stops the redirection timer will run. (KHTMLPart::closeURL): Remove the APPLE_CHANGES around the code that stops the redirection timer. (KHTMLPart::scheduleRedirection): Remove most of this function from the APPLE_CHANGES. We still probably need to revisit the handling of m_bComplete.
  • kwq/KWQSignal.h: Added.
  • kwq/KWQSignal.mm: Added.
  • kwq/KWQSlot.h: Added.
  • kwq/KWQSlot.mm: Added.
  • WebCore.pbproj/project.pbxproj: Added KWQSignal.h/mm, KWQSlot.h/mm.
  • khtml/misc/loader.h: Simplify APPLE_CHANGES ifdefs since all slots are now public.
  • force-clean-timestamp: Touch this since header files were changed.
  • khtml/ecma/kjs_window.cpp: (Window::get): Disable the "name" part of this. We can re-enable it if we need it, but every QObject had a name because of this one piece of code, and I don't think it was effectively setting the frame name. (Window::put): Disable the "name" part of this for the same reason. (History::getValueProperty): Disable the "length" part of this. It was calling some unimplemented stuff. We can re-enable this and implement what we need in KWQ then.
  • khtml/rendering/render_form.h: Remove RenderTextArea::performAction, because I changed this one case to use the new connect machinery. We can convert all the other form items to use the new machinery, and then eliminate performAction altogether.
  • khtml/rendering/render_form.cpp: (RenderSubmitButton::RenderSubmitButton): Remove unneeded setTarget. For the moment, connect takes care of this, and in the long run we won't need to set the target at all. (RenderLineEdit::RenderLineEdit): Ditto.
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_frames.cpp: Put partLoadingErrorNotify inside ifndef APPLE_CHANGES because it uses a bunch of Qt stuff that's not used anywhere else, and we never call it.
  • kwq/KWQKHTMLPartImpl.h: Remove scheduleRedirection, timerEvent, and m_redirectionTimer, add redirectionTimerStartedOrStopped and layout.
  • kwq/KWQKHTMLPartImpl.mm: (redirectionTimerMonitor): Added. Small stub that calls redirectionTimerStartedOrStopped. (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Set up a monitor on the redirection timer. (KWQKHTMLPartImpl::~KWQKHTMLPartImpl): Remove now-unneeded killTimer call. (KWQKHTMLPartImpl::jumpToSelection): Simplify by using dynamic_cast instead of render_name(). (KWQKHTMLPartImpl::redirectionTimerStartedOrStopped): Added. Calls bridge to report client redirect events whenever the redirection timer is started or stopped.
  • kwq/qt/qtextedit.h: Define a KWQSignal for textChanged, and a function that calls it.
  • kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): Set up a KWQSignal for textChanged.
  • kwq/KWQTextArea.mm: (-[KWQTextArea textDidEndEditing:]): Instead of calling emitAction, call textChanged, which will emit the signal using the new signal machinery.
  • kwq/qt/qtimer.h:
  • kwq/KWQTimer.mm: (+[KWQTimerTarget targetWithQTimer:]): Added. Used to implement QTimer in terms of NSTimer. (-[KWQTimerTarget timerFired:]): Added. Used to implement QTimer in terms of NSTimer. (QTimer::QTimer): Added. (QTimer::isActive): Implemented. (QTimer::start): Implemented. (QTimer::stop): Implemented. (QTimer::setMonitor): Implemented. (QTimer::fire): Implemented.
  • kwq/WebCoreBridge.h: Changed name of gotoAnchor to scrollToAnchor. Added client redirect methods.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge scrollToAnchor:]): Changed name.

WebKit:

WebKit support for feature where client redirects are treated as if the
page was continuing to load.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Added. Passes the client redirect along to the location change handler. (-[WebBridge reportClientRedirectCancelled]): Passes client redirect cancel along to the location change handler. (-[WebBridge dataSourceChanged]): Remove hack related to dummy data source. (-[WebBridge dataSource]): Remove hack related to dummy data source.
  • WebView.subproj/WebLocationChangeHandler.h: Added client redirect methods. Added class for base implementation of protocol. Updated stale comment.
  • WebView.subproj/WebLocationChangeHandler.m: Added. Provides base implementation of the WebLocationChangeHandler protocol so that clients don't need to implement all the methods if they are only interested in some of them.
  • WebKit.pbproj/project.pbxproj: Added WebLocationChangeHandler.m.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Call scrollToAnchor under its new name.
  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m:
  • WebView.subproj/WebControllerPolicyHandler.m:
  • WebView.subproj/WebControllerPolicyHandlerPrivate.h: Replaced MyCompanyName with the actual name of our company.

WebBrowser:

  • fixed 2948387 -- stop button flashes to "go" twice while loading citibank.com
  • LocationChangeHandler.m: (-[LocationChangeHandler locationChangeStartedForDataSource:]): Call _setInstantRedirectPending:NO when it's a load of the main frame. (-[LocationChangeHandler receivedPageTitle:forDataSource:]): Make this call through to the load monitor even for frames other than the main one. (-[LocationChangeHandler serverRedirectTo:forDataSource:]): Make this call through to the load monitor even for frames other than the main one. (-[LocationChangeHandler clientRedirectTo:delay:fireDate:forDataSource:]): Added. Call _setInstantRedirectPending:YES when it's a no-delay redirect of the main frame. (-[LocationChangeHandler clientRedirectCancelledForDataSource:]): Added. Call _setInstantRedirectPending:NO when it's the main frame, and also post a notification.
  • BrowserDocument.h: Added BrowserDocumentClientRedirectCancelledNotification and _instantRedirectPending instance variable.
  • BrowserDocument.m: (-[BrowserDocument isLoading]): Return YES if _instantRedirectPending. (-[BrowserDocument _setInstantRedirectPending:]): Set _instantRedirectPending.
  • BrowserDocumentPrivate.h: Declare _setInstantRedirectPending.
  • BrowserWindowController.h: Renamed frameLoadRedirected to mainFrameRedirected.
  • BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Connect the new BrowserDocumentClientRedirectCancelledNotification to frameLoadPossiblyFinished. (-[BrowserWindowController mainFrameRedirected]): Renamed from frameLoadRedirected and removed the parameter since it is called only for the main frame. (-[BrowserWindowController frameLoadPossiblyFinished:]): Renamed from frameLoadFinished since a frame load is not necessarily finished when this is called. Also move the work back in here from respondToFrameLoadFinished to undo my previous attempt at this feature.
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner init]): Connect the new BrowserDocumentClientRedirectCancelledNotification to pageLoadPossiblyDone. (-[PageLoadTestRunner pageLoadPossiblyDone:]): Renamed from pageLoadDone since the page load is not necessarily finished when this is called. Also move the work back in here from respondToPageLoadDone to undo my previous attempt at this feature.
  • BrowserNSControlExtras.h:
  • BrowserNSControlExtras.m:
  • ContextMenuHandler.h:
  • ContextMenuHandler.m:
  • TitleBarButton.h:
  • TitleBarButton.m: Replaced MyCompanyName with the actual name of our company.
5:45 PM Changeset in webkit [1726] by hyatt
  • 19 edits in trunk/WebCore

Lots of form control changes.

  • Inputs and textareas now respond to setFont and can have their font set by the Web page explicitly. These fields emulate the WinIE behavior of defaulting to the UI system font and only picking up new fonts if they are explicitly specified on the element itself.
  • Buttons and selects use the small versions now.
  • Stopped trying to align controls along baselines of their interior text. Konqueror is the only browser that does this, and it looks bad on many pages. With this patch controls align along their bottom borders (which extend slightly below the baseline of surrounding text). This matches Gecko, MacIE, and WinIE behavior.
  • Stopped using monospace for textareas and inputs.
  • Fixed a bug with inputs not calling setScrollable on their cells.
  • khtml/css/html4.css:
  • khtml/rendering/render_form.cpp: (RenderSubmitButton::calcMinMaxWidth): (RenderSubmitButton::baselinePosition): (RenderLineEdit::baselinePosition): (RenderSelect::baselinePosition):
  • khtml/rendering/render_form.h:
  • kwq/KWQButton.mm: (QButton::QButton): (QButton::sizeHint):
  • kwq/KWQComboBox.mm: (QComboBox::init):
  • kwq/KWQLineEdit.mm: (QLineEdit::cursorPosition): (QLineEdit::setFont):
  • kwq/KWQNSTextField.mm: (-[KWQNSTextField initWithFrame:widget:]):
  • kwq/KWQView.mm: (-[KWQNSButtonCell cellSizeForBounds:]): (+[KWQNSButton initialize]):
  • kwq/WebCoreTextRendererFactory.h:
  • kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory fontWithFamily:traits:size:]):
  • kwq/qt/qbutton.h:
  • kwq/qt/qlineedit.h:
2:44 PM Changeset in webkit [1725] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3015705 -- Command-up-arrow and -down-arrow should go to beginning and end of web page
  • WebView.subproj/WebView.m: (-[WebView keyDown:]): Added checks for command key.
Note: See TracTimeline for information about the timeline view.