Timeline



Aug 8, 2002:

10:32 PM Changeset in webkit [1782] by mjs
  • 3 edits in trunk/WebKit

Fix to get onLoad to fire, so the iBench test works.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Return the bridge for the new child frame.
10:32 PM Changeset in webkit [1781] by mjs
  • 8 edits in trunk/WebCore

Fix to get onLoad to fire, so the iBench test works.

  • khtml/khtml_part.cpp: (KHTMLPart::checkCompleted): Put back some needed code that was ifdef'd out (the part that emits completed()). (KHTMLPart::slotChildCompleted): Enabled; ifdef'd out part. (KHTMLPart::frame): Enabled.
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPartImpl.mm: (KHTMLPart::completed): Hack to get completed signal delivered to parent. (KWQKHTMLPartImpl::requestFrame): Initialize m_part
  • kwq/WebCoreBridge.h: createChildFrameNamed method now returns the bridge for the child frame.
9:21 PM Changeset in webkit [1780] by darin
  • 3 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Change the group name back to Debug.
1:46 PM Changeset in webkit [1779] by rjw
  • 13 edits in trunk

Added flag to turn on/off buffered text drawing to help
determine if we get any speed boost. Run from console
with "-BufferTextDrawing YES" to enable buffered text
drawing.

Moved buffered text drawing out of web core.

  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (+[WebTextRenderer shouldBufferTextDrawing]): (+[WebTextRenderer initialize]): (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]):
  • WebCoreSupport.subproj/WebTextRendererFactory.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):

Move stuff out of core into kit.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
  • kwq/WebCoreTextRendererFactory.h:
  • kwq/WebCoreTextRendererFactory.m:
12:37 PM Changeset in webkit [1778] by darin
  • 15 edits
    4 adds in trunk

top level:

  • Tests/WebFoundation-Misc/ifnsurlextensions-test.m: Added code to check the new URL extras methods against the old original versions, which are pasted in here for now.
  • Tests/WebFoundation-Misc/ifnsurlextensions-test.chk: Updated result to match the changes to _web_URLByRemovingLastPathComponent, and to reflect the new "compare with old original versions" testing.

WebFoundation:

  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLByRemovingLastPathComponent]): Changed behavior when the path is "/" to return the same URL with a path of "", to match the behavior of the old WebNSURLGetParent. I had hoped this would fix bug 3019790, but it did not.

WebCore:

  • fixed 3019353 -- Japanese (Autodetect) encoding not properly supported
  • kwq/make-charset-table.pl: Add a "japanese-autodetect" entry to the table explicitly, with a hardcoded encoding value. This should be good enough.
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFixedFontSize):
  • kwq/WebCoreEncodings.h:
  • kwq/WebCoreSettings.h:
  • kwq/WebCoreSettings.m: Change "fixed font size" to "default fixed font size".

Placeholders for the "drawing observer" method that I'll be using
to implement the "dump page as diffable text" feature.

  • kwq/WebCoreTestController.h: Added.
  • kwq/WebCoreTestController.m: Added.
  • WebCore.exp: Mention new class.
  • WebCore.pbproj/project.pbxproj: Mention new files.

WebKit:

Placeholders for the "drawing observer" method that I'll be using
to implement the "dump page as diffable text" feature.

  • Misc.subproj/WebTestController.h: Added.
  • Misc.subproj/WebTestController.m: Added.
  • WebKit.pbproj/project.pbxproj: Mention new files.
  • WebKit.exp: Mention new class.
  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: Changed "fixed font size" to "default fixed font size".

WebBrowser:

Some fixes to the text encoding menus.

  • Preferences.subproj/TextPreferences.m: (-[TextPreferences takeDefaultCharacterSetFrom:]): Update the text encoding menu when the character set is changed, because the section that includes that character set shows up at the top. (-[TextPreferences awakeFromNib]): Pass the TextPreferences object as the target for the menu items, because it's not going to be in the responder chain.
  • AppController.h: Added updateTextEncodingMenu.
  • AppController.m: (-[AppController applicationDidFinishLaunching:]): Call updateTextEncodingMenu. (-[AppController updateTextEncodingMenu]): Put the code to set up the text encoding menu in here, so it can be called when the default encoding changes.
  • TextEncodingMenu.h: Added target and preferred encoding parameters.
  • TextEncodingMenu.m: (-[NSMenu addItemToMenuForEncoding:withTarget:action:]): Add target setting. (-[NSMenu addStandardTextEncodingMenuItemsWithTarget:action:preferredEncoding:]): Remove old items before adding new so this can be reused on a menu. Fixed a bug in the original Mail code that causes an extra separator to be left at the bottom when the chosen group is the last one in the list.
  • LocationChangeHandler.m: Add an import that is needed now that I removed some unneeded imports from AppController.h.
11:51 AM Changeset in webkit [1777] by cblu
  • 3 edits in trunk/WebKit

WebFoundation:

  • Misc.subproj/WebNSFileManagerExtras.h:
  • Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_carbonPathForPath:]): added (-[NSFileManager _web_startupVolumeName]): added
  • WebFoundation.pbproj/project.pbxproj: made WebNSFileManagerExtras.h a private header

WebKit:

  • Plugins.subproj/WebPluginStream.m: (-[WebPluginStream finishedLoadingWithData:]): call [NSFileManager _web_carbonPathForPath:]

WebBrowser:

Fixed:

3015546 - title bar button should be draggable
3015545 - title bar button should have command-click pop-up menu

  • BrowserNSViewExtras.h:
  • BrowserNSViewExtras.m: (-[NSView draggingImage]): added, not used yet (-[NSView startDragFromEvent:withPasteBoard:andImage:]): dragOffset correction
  • BrowserWindow.h:
  • BrowserWindowController.m: (-[BrowserWindowController windowURL]): added, called by TitleBarButton (-[BrowserWindowController windowShouldGoToURL:]): added, called by TitleBarButton
  • ListView.h:
  • ListView.m:
  • TitleBarButton.m: (-[TitleBarButton initWithFrame:]): add observers (-[TitleBarButton dealloc]): remove observers (-[TitleBarButton drawRect:]): coord fix (-[TitleBarButton userChoseMenuItem:]): added (-[TitleBarButton _drawPathRepresentingPopUpMenuForEvent:andURL:]): added (-[TitleBarButton _startDragIfNecessaryForEvent:andURL:]): added (-[TitleBarButton mouseDown:]): call new methods above (-[TitleBarButton _resetWindowButtons:]): added (-[TitleBarButton resetFrame]): calls _resetWindowButtons (-[TitleBarButton windowDidEndSheet:]): added (-[TitleBarButton windowDidDeminiaturize:]): added
3:22 AM Changeset in webkit [1776] by mjs
  • 10 edits
    2 adds in trunk

WebCore:

Added an SPI that can be used to get at the WebCore
charset-name/encoding table; this is useful for a couple of things
in WebKit.

  • kwq/WebCoreEncodings.h: Added.
  • kwq/WebCoreEncodings.mm: Added. (+[WebCoreEncodings charsetNameForEncoding:]): (+[WebCoreEncodings encodingForCharsetName:]):
  • WebCore.exp: Export the new class.
  • WebCore.pbproj/project.pbxproj: Add new files.

WebKit:

  • fixed 2957197 - Need API for getting/setting default text encoding
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): Set default encoding if no other is set.
  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Added support for default text encoding pref. (-[WebPreferences defaultTextEncoding]): Likewise. (-[WebPreferences setDefaultTextEncoding:]): Likewise.

WebBrowser:

  • fixed 2896313 - Default text encoding preference is not yet implemented
  • English.lproj/MainMenu.nib: Added separator after Default item
  • Preferences.subproj/English.lproj/TextPreferences.nib: Made the pop-up wider so it would fit the widest encoding
  • Preferences.subproj/TextPreferences.h:
  • Preferences.subproj/TextPreferences.m: (-[TextPreferences updateDefaultCharacterSetPopup]): Implemented. (-[TextPreferences takeDefaultCharacterSetFrom:]): Implemented. (-[TextPreferences awakeFromNib]): Add encoding items to pop-up button, remove empty dummy item. (-[TextPreferences initializeFromDefaults]): Initialize pop-up too.
  • TextEncodingMenu.h:
  • TextEncodingMenu.m: (-[NSMenu addStandardTextEncodingMenuItemsWithAction:]): Add a selector parameter so we can use a different one for the real menu and the default pop-up. (_addItemToMenuForEncoding): Likewise.
  • AppController.m: (-[AppController applicationDidFinishLaunching:]): Pass selector when adding encoding menu items.
1:18 AM Changeset in webkit [1775] by rjw
  • 13 edits
    2 adds in trunk

Changes to coalesce all drawing calls of the same text
style and color into one call to CG. Significantly
improves drawing time. My tests should about 7-8% on
ALL pages. Disabled the code for now until I can verify
on speed improvements on Ken's test rig.

  • WebCoreSupport.subproj/WebGlyphBuffer.h: Added.
  • WebCoreSupport.subproj/WebGlyphBuffer.m: Added. (-[WebGlyphBuffer initWithFont:color:]): (-[WebGlyphBuffer font]): (-[WebGlyphBuffer color]): (-[WebGlyphBuffer reset]): (-[WebGlyphBuffer dealloc]): (-[WebGlyphBuffer drawInView:]): (-[WebGlyphBuffer addGlyphs:advances:count:at::]):
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]):
  • WebCoreSupport.subproj/WebTextRendererFactory.h:
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory coalesceTextDrawing]): (-[WebTextRendererFactory startCoalesceTextDrawing]): (-[WebTextRendererFactory endCoalesceTextDrawing]): (-[WebTextRendererFactory glyphBufferForFont:andColor:]): (-[WebTextRendererFactory dealloc]):
  • WebKit.pbproj/project.pbxproj:

Changes to coalesce all drawing calls of the same text
style and color into one call to CG. Significantly
improves drawing time. My tests should about 7-8% on
ALL pages. Disabled the code for now until I can verify
on speed improvements on Ken's test rig.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
  • kwq/WebCoreTextRendererFactory.h:
  • kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory endCoalesceTextDrawing]): (-[WebCoreTextRendererFactory startCoalesceTextDrawing]):

Made WebQueue a private class.

  • WebFoundation.exp:
  • WebFoundation.pbproj/project.pbxproj:

Aug 7, 2002:

11:24 PM Changeset in webkit [1774] by mjs
  • 19 edits in trunk

WebCore:

WebCore work for:

  • fixed 2956008 - Need API for getting/setting text encoding for current page
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Handle the possibility of override encoding - one that's not just a hint from the server but should override
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge addData:withEncoding:]): Adjust for slotData interface change. (-[WebCoreBridge addData:withOverrideEncoding:]): New method that allows passing override encoding as a CFStringEncoding. (-[WebCoreBridge textEncoding]): Return the current text encoding.

WebKit:

WebKit work for:

  • fixed 2956008 - Need API for getting/setting text encoding for current page
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Handle override encoding, if any.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:attributes:flags:]): Remember the flags and attributes.
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): Initialize overrideEncoding (-[WebDataSourcePrivate dealloc]): Release attributes (-[WebDataSource _setOverrideEncoding:]): Added. (-[WebDataSource _overrideEncoding]): Added. (-[WebDataSource _flags]): Added. (-[WebDataSource _attributes]): Added.
  • WebView.subproj/WebFrame.m: (-[WebFrame startLoading]): Pass proper forceRefresh value to data source based on load type (but the data source will ignore it). (-[WebFrame reload:]): Made this work a bit better. Now instead of crashing, it will actually reload, but it won't force a refresh (and may not handle the back/forward issues properly).
  • WebView.subproj/WebDocument.h: Defined new WebDocumentTextEncoding protocol.
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView textEncoding]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView setTextEncoding:]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView setDefaultTextEncoding]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView usingDefaultTextEncoding]): Implemented WebDocumentTextEncoding protocol.

WebBrowser:

  • fixed 2957200 - Text Encoding submenu is not yet implemented
  • AppController.h:
  • AppController.m: (-[AppController applicationDidFinishLaunching:]): Install standard Text Encoding menu items.
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Validate the menu items properly, based on whether the current view can change encodings. (-[BrowserWindowController changeTextEncoding:]): Hook up to new WebKit API.
  • English.lproj/MainMenu.nib: Add Default item to encoding menu, hook it up to AppController.
  • TextEncodingMenu.h: Added. Stolen from Mail.
  • TextEncodingMenu.m: Added. Stolen from Mail.
  • WebBrowser.pbproj/project.pbxproj: Added new files.
6:19 PM Changeset in webkit [1773] by hyatt
  • 1 edit in trunk/WebCore/khtml/css/cssstyleselector.cpp

Fix build bustage.

6:15 PM Changeset in webkit [1772] by hyatt
  • 12 edits in trunk/WebCore

Adding support for a separate fixed font size to WebCore.
Your fixed font size pref will now be honored when the
generic monospace family is used.

  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/rendering/font.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFixedFontSize):
  • kwq/WebCoreSettings.h:
  • kwq/WebCoreSettings.m: (-[WebCoreSettings setFixedFontSize:]): (-[WebCoreSettings fixedFontSize]):
  • kwq/khtml/khtml_settings.h:
1:30 PM Changeset in webkit [1771] by darin
  • 4 edits in trunk/WebCore
  • fixed 3017499 -- One-click crasher at hondamotorcycle.com
  • kwq/KWQKURL.mm: (operator==): Just compare the strings. Faster and safer.
12:33 PM Changeset in webkit [1770] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3017245 -- Shift-Delete should go forward
  • WebView.subproj/WebView.m: (-[WebView keyDown:]): Check for shift-delete.
12:19 PM Changeset in webkit [1769] by rjw
  • 9 edits in trunk

Fixed scrollview related drawing turd problems.
(3000844 and 2896459).

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
  • WebView.subproj/WebView.m: (-[WebView setFrame:]):

Removed debug log.

  • kwq/KWQFrame.mm: (QFrame::setFrameStyle):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
12:03 PM Changeset in webkit [1768] by darin
  • 8 edits in trunk

top level:

  • Tests/WebFoundation-Misc/ifnsurlextensions-test.m: New test that tests more of the code in WebNSExtras.
  • Tests/WebFoundation-Misc/ifnsurlextensions-test.chk: New output for new test. Matches the old for canonicalize test cases.

WebFoundation:

  • fixed 3017633 -- IPv6 URL support needed
  • fixed 2876174 -- Some URL functions should be moved to IFNSURLExtensions and have test cases added
  • Misc.subproj/WebNSURLExtras.h: Removed _web_extractHTTPBaseURLString and _web_URLWithScheme:user:password:host:port:path:parameter:query:fragment:, renamed _web_URLWithoutFragment to _web_URLByRemovingFragment.
  • Misc.subproj/WebNSURLExtras.m: (ReleaseIfNotNULL): Added. Used by the component-related functions. (StringByAddingPercentEscapes): Broken out from URLStringByAddingPercentEscapes. (URLStringByAddingPercentEscapes): Add code to handle the IPv6 case but make sure we escape any other bracket characters in the string. (+[NSURL _web_URLWithComponents:]): Added. (-[NSURL _web_URLComponents]): Added. These use the CFURL functions for breaking URLs into components, but makes them easier to use from AppKit by using autoreleased NSString objects and also fixes some anomalies in the CFURL functions. (-[NSURL _web_URLByRemovingFragment]): Simpler implementation, new name. (-[NSURL _web_URLByRemovingUserAndQueryAndFragment]): Added. Replaces WebNSURLRemoveUserAndSubresourceInfo. (-[NSURL _web_URLByRemovingPasswordAndPath]): Added. Replaces WebNSURLCanonicalRoot. (-[NSURL _web_URLByRemovingLastPathComponent]): Added. Replaces WebNSURLGetParent. (-[NSURL _web_canonicalize]): Rewrote to use _web_URLComponents.
  • CacheLoader.subproj/WebFileProtocolHandler.m: (+[WebFileProtocolHandler canonicalizeURL:]): Rewrite to use _web_URLComponents.
  • CacheLoader.subproj/WebHTTPProtocolHandler.m: (+[WebHTTPProtocolHandler canonicalizeURL:]): Rewrite to use _web_URLComponents.
  • AuthenticationManager.subproj/WebAuthenticationManager.m: Remove WebNSURLRemoveUserAndSubresourceInfo, WebNSURLCanonicalRoot, and WebNSURLGetParent, and use equivalent functions from WebNSURLExtras.
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_hasCaseInsensitivePrefix:]): Added.

WebCore:

  • kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::decompose): Use CFURLCopyPath instead calling _NSParseStringToGenericURLComponents.

WebKit:

  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Call _web_URLWithoutFragment by its new name _web_URLByRemovingFragment.
11:03 AM Changeset in webkit [1767] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3018632 - the show javascript files inline bug

  • WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]): support application/x-javascript
  • WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]): support application/x-javascript
10:43 AM Changeset in webkit [1766] by sullivan
  • 7 edits in trunk/WebKit

WebKit:

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_superviewOfClass:]): Changed name from _web_superviewWithName: and made it take a Class object instead of a string.
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView drawRect:]):
  • Plugins.subproj/WebPluginView.m: (-[WebPluginView start]): (-[WebPluginView layout]): Updated callers of _web_superviewWithName:
  • WebKit.pbproj/project.pbxproj: Changed WebNSViewExtras.h from Public to Private

WebBrowser:

  • BrowserNSViewExtras.h,
  • BrowserNSViewExtras.m: Remove superviewOfClass now that it's in WebKit
  • ActivityViewer.m: (-[ActivityViewer bestSizeForWindowContent]): Use _web_superviewOfClass:
9:28 AM Changeset in webkit [1765] by rjw
  • 1 edit in trunk/WebCore/kwq/WebCoreBridge.mm

Fixed compile problem.

9:22 AM Changeset in webkit [1764] by rjw
  • 4 edits in trunk/WebCore

Turned off temporary debugging I accidentally checked in.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):

Aug 6, 2002:

10:46 PM Changeset in webkit [1763] by hyatt
  • 6 edits in trunk/WebCore

Make user stylesheet changes dynamic. Web documents will now
update as the user stylesheet is applied and unapplied. Altered
how reapplyStyles works a bit.

  • khtml/khtml_part.cpp: (KHTMLPart::reparseConfiguration):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setUserStyleSheet):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStyles]):
9:19 PM Changeset in webkit [1762] by hyatt
  • 5 edits in trunk/WebCore

Enable user stylesheet support. It works from a fresh start but
is not yet completely dynamic.

  • khtml/khtml_part.cpp: (KHTMLPart::setUserStyleSheet):
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::userStyleSheet):
9:12 PM Changeset in webkit [1761] by darin
  • 12 edits in trunk

WebCore:

  • fixed 2965321 -- Crash on window close in kthml::Loader::cancelRequests from particular page
  • khtml/misc/loader.cpp: (Loader::servePendingRequests): Look at return value from KWQServeRequest instead of assuming it will always succeed.
  • kwq/KWQLoaderImpl.h: Add return value for KWQServeRequest.
  • kwq/KWQLoaderImpl.mm: (KWQServeRequest): Return false if we fail to make either the NSURL or the WebResourceHandle. Also make sure that we delete the job if necessary.

WebKit:

Fix assert I saw while fixing bug 2965321.

  • WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Create a suitable resource identifier from the failing URL in the WebError for cases where we fail before we are able to construct a resource handle.
8:58 PM Changeset in webkit [1760] by sullivan
  • 4 edits in trunk/WebCore
  • force-clean-timestamp: Edited this file to force a make clean in WebCore after discovering that it was necessary the hard way. I'm not sure which earlier checkin made this be required.
8:39 PM Changeset in webkit [1759] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Fix crash in overURL, another case just like bug 3006336.
8:29 PM Changeset in webkit [1758] by darin
  • 3 edits in trunk/WebKit
  • fixed 2970516 -- Activate Events don't appear to be coming in to the Java Applet.plugin correctly.
  • Plugins.subproj/WebPluginView.m: (-[WebPluginView sendActivateEvent:]): Use activeFlag to set modifiers, not activMask, which is an event mask.
7:05 PM Changeset in webkit [1757] by rjw
  • 11 edits in trunk/WebCore

Frame resizing related changes. Frames are now resizable
w/ a resize bar. Still need to draw frame borders.

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderFrame::slotViewCleared):
  • kwq/KWQFrame.mm: (QFrame::setFrameStyle): (QFrame::frameStyle): (QFrame::frameWidth):
  • kwq/KWQWidget.mm: (QWidget::lockDrawingFocus): (QWidget::unlockDrawingFocus): (QWidget::flushDrawing): (QWidget::enableFlushDrawing): (QWidget::disableFlushDrawing): (QWidget::setDrawingAlpha): (QWidget::displayRect):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
  • kwq/qt/qframe.h:
  • kwq/qt/qwidget.h:
5:57 PM Changeset in webkit [1756] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

Add mechanism to store userStyleSheet preferences in WebKit in
preparation for Dave wiring up the implementation.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetEnabled]), (-[WebPreferences setUserStyleSheetEnabled:]), (-[WebPreferences userStyleSheetLocation]), (-[WebPreferences setUserStyleSheetLocation:]): New methods, read and write UserDefaults values.

(+[WebPreferences load]): Set initial values for
userStyleSheetEnabled and userStyleSheetLocation

WebBrowser:

Updated to use userStyleSheet preferences from WebKit.

  • Defaults.plist,
  • PreferenceKeys.h: Remove preference keys for ApplyStyleSheet since this is in WebKit now.
  • Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences setStylesheetPathPreference:]), (-[AppearancePreferences stylesheetPathPreference]), (-[AppearancePreferences updateStylesheetViews]), (-[AppearancePreferences toggleApplyStylesheet:]): Update to use WebKit preferences API; remove local storage.
4:28 PM Changeset in webkit [1755] by mjs
  • 16 edits in trunk

WebCore:

Removed some APPLE_CHANGES no longer needed after the part change.

  • khtml/khtml_part.cpp: (KHTMLPart::openedByJS): Don't call impl version. (KHTMLPart::setOpenedByJS): Don't call impl version.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: Removed openedByJS and setOpenedByJS.
  • kwq/WebCoreBridge.h: Don't prototype setOpenedByScript: and openedByScript methods now that they are not needed.

WebKit:

Removed some APPLE_CHANGES no longer needed after the part change.

  • WebCoreSupport.subproj/WebBridge.m: Remove setOpenedByScript: and openedByScript methods now that they are not needed.
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: Remove setOpenedByScript: and openedByScript methods now that they are not needed.
3:37 PM Changeset in webkit [1754] by darin
  • 8 edits in trunk/WebKit

WebKit:

  • fixed 3017761 -- dataSource != nil assertion navigating at yahoo.com
  • WebView.subproj/WebLocationChangeHandler.h:
  • WebView.subproj/WebLocationChangeHandler.m: Change client redirect calls to pass the frame, not the data source. At the time a client redirect is requested, it's not even clear yet which data source will be involved. We may want to make some of the other calls pass frames, also, aside from the "start", "committed", "done", calls, which must specify the data source.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Pass frame, not data source. (-[WebBridge reportClientRedirectCancelled]): Pass frame, not data source.

WebBrowser:

Update for change to client redirect API.

  • LocationChangeHandler.m: (-[LocationChangeHandler clientRedirectTo:delay:fireDate:forFrame:]): (-[LocationChangeHandler clientRedirectCancelledForFrame:]): We get the frame now, not the data source.
1:16 PM Changeset in webkit [1753] by hyatt
  • 7 edits in trunk/WebCore

Make checkboxes and radio buttons use the small control
size. Tweak their baselines to not use font metrics and
to line up properly. (voodooextreme.com nearly renders
the left column correctly now.)

  • khtml/rendering/render_form.cpp: (RenderCheckBox::baselinePosition): (RenderRadioButton::baselinePosition):
  • khtml/rendering/render_form.h:
  • kwq/KWQCheckBox.mm: (QCheckBox::QCheckBox):
  • kwq/KWQRadioButton.mm: (QRadioButton::QRadioButton):
12:54 PM Changeset in webkit [1752] by darin
  • 52 edits in trunk/WebKit

WebFoundation:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.

WebKit:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.

WebBrowser:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.
11:09 AM Changeset in webkit [1751] by sullivan
  • 4 edits in trunk/WebCore

WebCore:

WebCore part of fix for 2915396 -- implement larger/smaller font
or page zoom functionality

  • khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor): inside APPLE_CHANGES, remove use of KHTML limits for zoom factor; this is a client responsibility in our model.

WebBrowser:

WebBrowser part of fix for 2915396 -- implement larger/smaller font
or page zoom functionality

  • BrowserDocument.h:
  • BrowserDocument.m: Define min/max text multiplier values, and ratio (-[BrowserDocument canMakeTextLarger]), (-[BrowserDocument canMakeTextSmaller]): New methods, check that there's a page and that the new size wouldn't be too big/small.

(-[BrowserDocument makeTextLarger:]),
(-[BrowserDocument makeTextSmaller:]):
New methods, set web controller's text multiplier.

(-[BrowserDocument validateUserInterfaceItem:]):
Disable makeTextLarger and makeTextSmaller when appropriate.

11:00 AM Changeset in webkit [1750] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Put in a check for nil that I missed.
10:13 AM Changeset in webkit [1749] by darin
  • 26 edits in trunk

WebCore:

  • fixed 2948805 -- Need WebKit API for larger/smaller font feature
  • khtml/khtml_part.cpp: (KHTMLPart::clear): Head in the direction of using the m_frames and m_objects arrays, by turning some APPLE_CHANGES code on. (KHTMLPart::checkCompleted): More code turned on here. (KHTMLPart::checkEmitLoadEvent): And more code turned on here. (KHTMLPart::parentPart): Remove APPLE_CHANGES version. We can use the original now. (KHTMLPart::setZoomFactor): Remove APPLE_CHANGES. We want this function now.
  • khtml/khtml_part.h: Remove some APPLE_CHANGES to make xmlDocImpl public. No longer needed.
  • khtml/khtmlpart_p.h: Remove a bunch of APPLE_CHANGES.
  • kwq/KWQKHTMLPartImpl.h: Remove parentPart(), add getDocument() and getRenderer().
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Use parentPart() instead of [bridge parent]. (KWQKHTMLPartImpl::requestFrame): Set up a ChildFrame in the m_frames array. (KWQKHTMLPartImpl::layout): Use getRenderer(). (KWQKHTMLPartImpl::getDocument): Added. (KWQKHTMLPartImpl::getRenderer): Added.
  • kwq/WebCoreBridge.h: Add [setParent:], remove [parent].
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setParent:]): Added. (-[WebCoreBridge reapplyStyles]): Use getDocument(). (-[WebCoreBridge forceLayout]): Use getRenderer(). (-[WebCoreBridge drawRect:withPainter:]): Use getRenderer(). (-[WebCoreBridge copyDOMTree:]): Use getDocument(). (-[WebCoreBridge copyRenderTree:]): Use getRenderer(). (-[WebCoreBridge completeURLForDOMString:]): Use getDocument(). (-[WebCoreBridge elementAtPoint:]): Use getRenderer(). (-[WebCoreBridge setTextSizeMultiplier:]):
  • kwq/khtml/khtml_ext.h: Add dummy setEnabled function to make khtml_part.cpp compile.
  • kwq/kparts/part.h: Add real parent() and setParent() implementation.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSourceChanged]): Call setParent:.
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): Initialize the text size multiplier to 1.
  • WebView.subproj/WebDataSource.h: Removed [redirectedURL], deprecated [inputURL], added [URL].
  • WebView.subproj/WebDataSource.m: (-[WebDataSource URL]): Added. Returns current URL, without requiring separate logic for the redirected and not-yet-redirected cases.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): Use [WebDataSource URL].
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler openFrameInNewWindow:]): Use [WebDataSource URL].

WebBrowser:

  • BrowserDocument.m: (-[BrowserDocument currentURL]): Use [WebDataSource URL]. (-[BrowserDocument provisionalURL]): Use [WebDataSource URL].
  • BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:dataSource:]): Use [WebDataSource URL].
  • DownloadMonitor.m: (-[DownloadMonitor receivedProgress:forResourceHandle:fromDataSource:complete:]): Use [WebDataSource URL].
  • FrameProgressEntry.m: (-[FrameProgressEntry URL]): Use [WebDataSource URL].
9:21 AM Changeset in webkit [1748] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3017539 -- Replace Serif and Sans-serif
font preferences with Default preference; let fixed width font
size be independent.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Add default value for fixed width size (-[WebPreferences fixedFontSize]), (-[WebPreferences setFixedFontSize:]): New methods.

WebBrowser:

WebBrowser part of fix for 3017539 -- Replace Serif and Sans-serif
font preferences with Default preference; let fixed width font
size be independent.

  • Preferences.subproj/TextPreferences.h:
  • Preferences.subproj/TextPreferences.m: (-[TextPreferences updateFontSampleField:]): (-[TextPreferences updateFontSampleFields]): (-[TextPreferences chooseFont:]): (-[TextPreferences chooseStandardFont:]): (-[TextPreferences changeFont:]): (-[TextPreferences initializeFromDefaults]): Removed serif and sans-serif code, replaced with standard font. Made font sizes independent of each other.
  • Preferences.subproj/English.lproj/TextPreferences.nib: Futzed with Interface Builder.
8:36 AM Changeset in webkit [1747] by darin
  • 3 edits in trunk/WebKit
  • fixed 3017536 -- Change default font to Lucida Grande 14 pt.
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Changed default font and sans serif font family names to Lucida Grande. Changed default font size to 14 point.

Aug 5, 2002:

11:04 PM Changeset in webkit [1746] by mjs
  • 9 edits in trunk

WebCore:

Fixed crashers and leaks that come up when changing the view
associated with a part.

  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Don't zero out the part's view, because that will mess up setting a new one.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Destroy the old view if we own it.

WebKit:

fixed 2974993 - window.open does not return the right window object
fixed 3017140 - WebKit creates a new KHTMLPart per page; should
reuse it like KHTML does

  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation setDataSource:]): Don't swap the part at this point. Now it gets reused.
10:23 PM Changeset in webkit [1745] by mjs
  • 3 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Fix tyops that broke Development build.
9:54 PM Changeset in webkit [1744] by darin
  • 9 edits in trunk

WebCore:

  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURLInFrame): (KWQKHTMLPartImpl::urlSelected): (KWQKHTMLPartImpl::requestFrame): (KWQKHTMLPartImpl::requestObject): Add some nil checks before making calls with nil NSURL objects. But we also have to figure out how to report some kind of error in these cases, because the current behavior is not so good.

WebKit:

  • .cvsignore: Ignore WebCore-combined.exp.
9:35 PM Changeset in webkit [1743] by mjs
  • 13 edits
    1 add in trunk

JavaScriptCore:

  • fixed 3007072 - need to be able to build fat

WebFoundation:

  • fixed 3007072 - need to be able to build fat
  • WebFoundation.pbproj/project.pbxproj: Fixed DeploymentFat build.

WebCore:

  • fixed 3007072 - need to be able to build fat
  • WebCore.pbproj/project.pbxproj: Fixed DeploymentFat build.

WebKit:

  • fixed 3007072 - need to be able to build fat
  • WebKit.pbproj/project.pbxproj: Fixed DeploymentFat build.
  • Makefile.am: Build WebCore-combined.exp for Development and Mixed build.
  • WebKit-tests.exp: Added.
  • WebKit.exp: Remove test-only function.

WebBrowser:

  • fixed 3007072 - need to be able to build fat
  • WebBrowser.pbproj/project.pbxproj: Fixed DeploymetFat build.
9:21 PM Changeset in webkit [1742] by darin
  • 23 edits in trunk

WebCore:

  • fixed 3016374 -- Change font default from small back to medium
  • khtml/css/cssstyleselector.cpp: (CSSStyleSelector::computeFontSizes): Change back to basing everything on mediumFontSize() as opposed to a defaultFontSize that was the same as "small". (CSSStyleSelector::applyRule): Default is m_fontSizes[3] again.
  • khtml/html/html_inlineimpl.cpp: (HTMLFontElementImpl::parseAttribute): Shift all the sizes up one, so 3 is now medium. It's important that 3 be the same as the default.
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::attach): Change the default back to medium.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Change the default back to [3].
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFontSize): Change name back.
  • kwq/khtml/khtml_settings.h: Change name back to medium.

Do a little bit of wiring for the "text size multiplier" feature.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setTextSizeMultiplier:]): Added.

WebKit:

Do the wiring for the "text size multiplier" feature. The rest of the work will probably be done
at the WebCore level.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setFrame:]): Set the text size multiplier.
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setTextSizeMultiplier:]): Added. Calls _textSizeMultiplierChanged on the main frame. (-[WebController textSizeMultiplier]): Added.
  • WebView.subproj/WebControllerPrivate.h: Added textSizeMultiplier instance variable.
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _textSizeMultiplierChanged]): Added. Calls setTextSizeMultiplier: on the bridge, and _textSizeMultiplierChanged on all the child frames.
9:15 PM Changeset in webkit [1741] by cblu
  • 5 edits in trunk/WebKit

WebKit:

Renamed icon loader delegate method to include the icon loader.

  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]):
  • WebView.subproj/WebDataSourcePrivate.m:

WebBrowser:

Rendezvous changes:
Properly get host's IP address.
Load and display host's favicon.

  • English.lproj/Rendezvous.nib:
  • RendezvousController.m: (-[RendezvousController windowDidLoad]): (-[RendezvousController _attributedStringWithImage:]): (-[RendezvousController goToHostDoubleAction:]): (-[RendezvousController tableView:objectValueForTableColumn:row:]): (-[RendezvousController netServiceBrowser:didFindService:moreComing:]): (-[RendezvousController netServiceBrowser:didRemoveService:moreComing:]): (+[RendezvousController _URLForNetService:]): (-[RendezvousController netServiceDidResolveAddress:]): (-[RendezvousController iconLoader:receivedPageIcon:]):
7:38 PM Changeset in webkit [1740] by rjw
  • 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebTextRendererFactory.m

Added a comment.

7:35 PM Changeset in webkit [1739] by rjw
  • 3 edits in trunk/WebKit

Added additional check to find appropriate fonts with available
weight, rather than always using a weight of 5.

Regarding "kCGErrorFailure : can't find name id 4 for font id 8395" errors:
CG appears to be lying to us about some fonts, Verdana in particular.
It claims to have an available Verdana font w/ the correct traits, but spits errors
when we request that font. Further, the Font Panel behaves oddly when you request
Verdana. The panel displays the font but if you select the font it doesn't
'stick'. A mystery.

  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]):
6:23 PM Changeset in webkit [1738] by darin
  • 7 edits in trunk

top level:

  • Tests/WebFoundation-Misc/ifnsstringextensions-test.chk:
  • Tests/WebFoundation-Misc/ifnsstringextensions-test.m: (main): Added test cases for _web_stringByCollapsingNonPrintingCharacters.

WebFoundation:

  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_stringByCollapsingNonPrintingCharacters]): Added. Collapses any non-printing characters into single spaces, and trims them from the ends too.

WebCore:

  • fixed 3009321 -- bookmark and history menus show black square for (tm)
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseSpecial): Call fixUpChar. (HTMLTokenizer::parseText): Call fixUpChar. (HTMLTokenizer::parseTag): Call fixUpChar.

WebKit:

  • fixed 2986567 -- suppress return characters from title in title bar, status bar, menu items
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setTitle:]): Call _web_stringByCollapsingNonPrintingCharacters.
5:23 PM Changeset in webkit [1737] by rjw
  • 3 edits
    1 add in trunk/WebKit

Added exported symbols file.

  • WebKit.exp: Added.
  • WebKit.pbproj/project.pbxproj:
4:19 PM Changeset in webkit [1736] by darin
  • 4 edits in trunk/WebCore
  • kwq/make-charset-table.pl: Added a hack that makes us treat for iso-8859-8-e and iso-8859-8-i the same as iso-8859-8; may not be exactly right, but it's probably OK modulo the actual bidi support.
3:47 PM Changeset in webkit [1735] by darin
  • 8 edits in trunk/WebKit

WebFoundation:

  • fixed 3015360 -- google.com, click on images link, stop icon spins forever
  • CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle contentLengthReceived]): Fixed race condition where sizes of objects would jump down to 0 by returning the length of resourceData here instead of the mark. (-[WebResourceHandle _setLoad:]): Added. (-[WebResourceHandle _load]): Added. (-[WebResourceHandle _notifyClientsDidCancelLoading]): Do the WebResourceHandleDidBeginLoading calls outside the lock/unlock also.
  • CacheLoader.subproj/WebResourceHandlePrivate.h: Added _setLoad: and _load.
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad handleCount]): Add call to checkForNewHandles. (-[WebResourceLoad _submittedAttributes]): Added. (-[WebResourceLoad cleanup]): Pass the load to loadDidFinish, rather than passing a handle.
  • CacheLoader.subproj/WebResourceLoadManager.m: (-[WebResourceLoadManagerInstanceVariables init]): (-[WebResourceLoadManagerInstanceVariables dealloc]): (-[WebResourceLoadManager invalidateURL:]): (-[WebResourceLoadManager addLoad:forHandle:]): (-[WebResourceLoadManager requestWithURLHandle:]): (-[WebResourceLoadManager cancelRequestWithURLHandle:]): (-[WebResourceLoadManager loadDidFinish:]):
  • CacheLoader.subproj/WebResourceLoadManager.m: Added new WebResourceLoadKey class, rather than trying to trick handles themselves into acting as keys. This works better for the case where a single load is shared by two handles. There's no telling which will be cancelled first, so there's no obvious choice for which to use as the key. (-[WebResourceLoadManager requestWithURLHandle:]): Rewrote for new scheme. I think it's a little less tricky than before, but it's also more terse. (-[WebResourceLoadManager cancelRequestWithURLHandle:]): Rewrote this too. (-[WebResourceLoadManager loadDidFinish:]): This too.
  • CacheLoader.subproj/WebResourceLoadManagerPrivate.h: Change parameter type of loadDidFinish to WebResourceLoad. Removed unused cancelAllRequestsWithURL and cancelAllRequestsInGroup.
  • CacheLoader.subproj/WebResourceLoadPrivate.h: Removed unused removeAllHandles, cancelIfServingOneHandle, and added _submittedAttributes.
  • CacheLoader.subproj/WebResourceLoad.h: Removed canonicalURL.
  • CacheLoader.subproj/WebFileProtocolHandler.m:
  • CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.m:
  • CacheLoader.subproj/WebHTTPResourceLoader.m:
  • CacheLoader.subproj/WebResourceLoadQueue.m: [WebResourceLoad url] now always returns a canonical URL. Got rid of [WebResourceLoad canonicalURL] and updated callers.
  • CacheLoader.subproj/WebResourceLoadManager.h: Tweak.
  • Misc.subproj/WebNSDictionaryExtras.m: Fix definitions to match header.

WebKit:

  • fixed 3014122 -- spinner never stops spinning when iframe has URL with bad path
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Initialize the state in WebFramePrivate init instead.
  • WebView.subproj/WebFramePrivate.h: Remove WebFrameStateUninitialized.
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate init]): Set initial state to WebFrameStateComplete. (-[WebFrame _transitionToLayoutAcceptable]): Remove WebFrameStateUninitialized case. (-[WebFrame _transitionToCommitted]): Remove WebFrameStateUninitialized case. (-[WebFrame _isLoadComplete]): Remove WebFrameStateUninitialized case.
  • WebView.subproj/WebDataSource.h: Tweak.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource stopLoading]): Move downloadHandler logic from here into _stopLoading. (-[WebDataSource isLoading]): Rewrite for simplicity.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Move downloadHandler logic here from stopLoading. Also make this work even if handles are removed from the list during the stop process. (-[WebDataSource _recursiveStopLoading]): Simplify a lot by using WebFrame's stopLoading. (-[WebDataSource _setTitle:]): Use the committed boolean rather than the state to check if the title change should be sent to the location change handler.
9:07 AM Changeset in webkit [1734] by mjs
  • 3 edits in trunk/WebKit
  • Misc.subproj/WebKitDebug.h: Put WEBKIT_ASSERT_NOT_REACHED() inside the appropriate #ifdef, and remove the various _log macros, which are onsolete in WebKit.
4:30 AM Changeset in webkit [1733] by mjs
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Simplified a bit.
4:08 AM Changeset in webkit [1732] by mjs
  • 15 edits in trunk

WebCore:

Merged KHTMLPart::end method with khtml original.

  • khtml/khtml_part.cpp: (KHTMLPart::end): Remove call to impl. Use original version, but clear KURL cache and call slotFinishedParsing as well.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::end): Removed. (KWQKHTMLPartImpl::gotoBaseAnchor): Removed. No longer needed.
  • kwq/KWQKURL.mm: (KURL::encodedHtmlRef): Implemented. (KURL::htmlRef): Implemented.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge scrollToBaseAnchor]): Removed. No longer needed.

WebKit:

Some changes related to re-merging the KHTMLPart end() method:

  • Misc.subproj/WebKitDebug.h: Added WEBKIT_ASSERT_NOT_REACHED().
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToLayoutAcceptable]): Replace NSException with ASSERT_NOT_REACHED (this is an internal consistency check, not an argument check on a public API, so an assert is more appropriate than an exception). (-[WebFrame _transitionToCommitted]): Likewise. (-[WebFrame _isLoadComplete]): Likewise; also, remove bridge call to scrollToBaseAnchor:, since that will now happen automatically when calling end.
2:07 AM Changeset in webkit [1731] by mjs
  • 8 edits in trunk/WebCore

Merged KHTMLPart::openURL method with khtml original.

  • khtml/khtml_part.cpp: (KHTMLPart::openURL): Don't call the impl version. Leave most of this #ifdef'd, except the parts that look useful.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURL): Removed.
1:13 AM Changeset in webkit [1730] by mjs
  • 11 edits in trunk/WebCore

Merged KHTMLPart::begin method with khtml original.

  • khtml/khtml_part.cpp: (KHTMLPart::begin): Restore this method and don't call the impl version. ifdef out the parts that don't compile.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::begin): Removed.
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::showAnimations): Implemented; always return false. (KHTMLSettings::userStyleSheet): Implemented; always return empty string.
  • kwq/kdecore/kurl.h: Implemented isValid as inline method.

Aug 4, 2002:

4:13 PM Changeset in webkit [1729] by hyatt
  • 4 edits in trunk/WebCore

Fix my bungled CSS for input fields in the user agent style
sheet.

  • khtml/css/html4.css:
Note: See TracTimeline for information about the timeline view.