Timeline



Aug 22, 2002:

11:14 PM Changeset in webkit [1907] by darin
  • 4 edits in trunk/WebCore
  • force-clean-timestamp: Without this, I crash on startup.
8:39 PM Changeset in webkit [1906] by mjs
  • 7 edits in trunk/WebCore

top level:

Fix test results to no longer reflect KURL or CFURL oddities that
we are not emulating.

  • Tests/kde/kurl-test.chk:
  • Tests/kde/kurl-test.cpp: (testURL): Replay mistaken n with \n.

WebCore:

Brand new KURL implementation which avoids CFURL, CFString, and
all that other allocation-happy goodness and instead does as much
work as possible with raw ASCII buffers.

For me this gave a ~5% performance improvement on cvs-base.

  • kwq/KWQKURL.mm: (KURL::KURL): (KURL::hasPath): (KURL::protocol): (KURL::host): (KURL::port): (KURL::pass): (KURL::user): (KURL::ref): (KURL::query): (KURL::path): (KURL::setProtocol): (KURL::setHost): (KURL::setPort): (KURL::setRef): (KURL::setQuery): (KURL::setPath): (KURL::prettyURL): (KURL::decode_string): (escapeBadChars): (KURL::parse): (KURL::getNSURL):
  • kwq/kdecore/kurl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::end): Don't call KURL::clearCaches() any more.
5:11 PM Changeset in webkit [1905] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQButton.mm: (QButton::~QButton): Disconnect the view from the widget by doing setTarget:nil.
  • kwq/KWQComboBox.mm: (QComboBox::~QComboBox): Ditto.
4:57 PM Changeset in webkit [1904] by hyatt
  • 4 edits in trunk/WebCore

Add vertical margins for checkboxes and radios. A later rule
in the file was overriding my earlier attempt to set up these margins.

  • khtml/css/html4.css:
4:50 PM Changeset in webkit [1903] by rjw
  • 6 edits in trunk/WebCore

New faster char * append (actually insert) for mjs.

  • kwq/KWQString.mm: (QString::insert):
  • kwq/qt/qstring.h:
3:37 PM Changeset in webkit [1902] by rjw
  • 10 edits in trunk/WebKit

i Changed public string from #define to extern NSString.

  • WebKit.exp:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m:
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuHandler openNewWindowWithURL:]): (-[WebDefaultContextMenuHandler downloadURL:]): (-[WebDefaultContextMenuHandler openLinkInNewWindow:]): (-[WebDefaultContextMenuHandler downloadLinkToDisk:]): (-[WebDefaultContextMenuHandler copyLinkToClipboard:]): (-[WebDefaultContextMenuHandler openImageInNewWindow:]): (-[WebDefaultContextMenuHandler downloadImageToDisk:]): (-[WebDefaultContextMenuHandler copyImageToClipboard:]): (-[WebDefaultContextMenuHandler openFrameInNewWindow:]):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): (-[WebHTMLView _continueAfterCheckingDragForEvent:]):
12:14 PM Changeset in webkit [1901] by darin
  • 6 edits in trunk/WebCore

Some small QString improvements.

  • kwq/qt/qstring.h: Add printf attribute to sprintf member function.
  • kwq/KWQString.mm: Remove extra \n characters from QSTRING_FAILURE calls. Change some fprintf to QSTRING_FAILURE. Change some QSTRING_FAILURE to KWQ_ASSERT. (QStringData::makeAscii): Fix bug where it would update _maxAscii with a new size even when it didn't allocate a new buffer. (QStringData::makeUnicode): Fix bug where it would update _maxUnicode with a new size even when it didn't allocate a new buffer. (QString::utf8): Fix bug where it assumed the UTF-8 form of a string has the same length as the Unicode version. Also save one allocation by doing it right into the QCString. (QString::local8Bit): Just call utf8(). (QString::setNum): Have all these call our sprintf. (QString::sprintf): Format once to get the length. Then do the second format right into the string buffer. This way we don't have to do any allocation at all, nor use CFString.
11:22 AM Changeset in webkit [1900] by kocienda
  • 4 edits in trunk/WebKit

Passing the main load's attributes to the subresource loads causes
breakage (most visible when we POST).

Right now, we just rely on flags to handle "back/forward" loads, so
the attributes were not actually being used.

A better fix needs to be put in place when the soon-to-be-done
attributes/flags rework is done.

  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]):
10:52 AM Changeset in webkit [1899]
  • 3 copies in tags/Alexander-20

This commit was manufactured by cvs2svn to create tag 'Alexander-20'.

10:52 AM Changeset in webkit [1898] by vicki
  • 8 edits in trunk

Alex-20

8:01 AM Changeset in webkit [1897] by darin
  • 4 edits in trunk/WebCore

Fixed a one-click crasher that Ken and Don told me about.

  • kwq/KWQObject.mm: (QObject::QObject): Initialize m_eventFilterObject.

Aug 21, 2002:

6:21 PM Changeset in webkit [1896] by rjw
  • 27 edits in trunk/WebKit

Simple name change. Plugin -> NetscapePlugin in anticipation
of other plugin related API.

Removed vestigal WebDocumentLoading.

  • Plugins.subproj/WebPlugin.h:
  • Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin load]):
  • Plugins.subproj/WebPluginDatabase.h:
  • Plugins.subproj/WebPluginDatabase.m: (+[WebNetscapePluginDatabase installedPlugins]): (-[WebNetscapePluginDatabase pluginForMimeType:]): (-[WebNetscapePluginDatabase pluginForExtension:]): (-[WebNetscapePluginDatabase pluginWithFilename:]): (-[WebNetscapePluginDatabase MIMETypes]): (-[WebNetscapePluginDatabase init]):
  • Plugins.subproj/WebPluginNullEventSender.h:
  • Plugins.subproj/WebPluginNullEventSender.m: (-[WebNetscapePluginNullEventSender initWithPluginView:]): (-[WebNetscapePluginNullEventSender sendNullEvents]):
  • Plugins.subproj/WebPluginStream.h:
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream getFunctionPointersFromPluginView:]): (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:attributes:]):
  • Plugins.subproj/WebPluginView.h:
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView initWithFrame:plugin:URL:baseURL:mime:arguments:]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView provisionalDataSourceChanged:]): (-[WebNetscapePluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): (-[WebNetscapePluginView destroyStream:reason:]):
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory pluginsInfo]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (+[WebController canShowMIMEType:]):
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView provisionalDataSourceChanged:]): (-[WebHTMLView provisionalDataSourceCommitted:]): (-[WebHTMLView dataSourceUpdated:]):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[NSView _web_stopIfPluginView]):
  • WebView.subproj/WebImageView.h:
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]):

Still need to muck with cvs server to change file names.

4:37 PM Changeset in webkit [1895] by darin
  • 4 edits in trunk/WebCore
  • fixed 3021908 -- text areas should be plain text only
  • kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): setRichText:NO (-[KWQTextArea dealloc]): Release the text view so we don't leak.
4:31 PM Changeset in webkit [1894] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQNSViewExtras.m: (-[NSClipView _KWQ_scrollRectToVisible:inView:]): Use bounds, not visibleRect. Seems to work better.
3:11 PM Changeset in webkit [1893] by sullivan
  • 5 edits in trunk/WebCore
  • commented out (with FIXME 2935687) the code that was advertising in the status bar that shift-command would open a link behind the current window, since it doesn't.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL):
2:02 PM Changeset in webkit [1892] by darin
  • 5 edits in trunk/WebCore

Fix for two problems with password fields.

1) Return wasn't working.

2) They were wrapping instead of scrolling.

  • kwq/KWQNSTextField.mm: (-[KWQNSTextField setUpTextField:]): Shared initialization, needed by both the text field and the secure field. This includes the two things we needed for the password text field; wiring up action properly and setScrollable:YES. (-[KWQNSTextField initWithFrame:]): Use setUpTextField. (-[KWQNSTextField setPasswordMode:]): Use setUpTextField.
1:36 PM Changeset in webkit [1891] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3015372, tables and blocks nested inside other tables
don't center. This fixes a lot of sites, from the forum
sites to the www.ve3d.com voodooextreme site.

  • khtml/html/html_tableimpl.cpp: (HTMLTablePartElementImpl::parseAttribute):
12:51 PM Changeset in webkit [1890] by darin
  • 11 edits
    2 adds in trunk/WebCore
  • fixed 3027927 -- selected text fields do not cause the web view to scroll to reveal them
  • kwq/KWQNSTextField.mm: (-[KWQNSTextField becomeFirstResponder]): Call [self _KWQ_scrollFrameToVisible]. (-[KWQSecureTextField becomeFirstResponder]): Call [self _KWQ_scrollFrameToVisible].
  • kwq/KWQNSViewExtras.h: Added. New scrolling functions.
  • kwq/KWQNSViewExtras.m: Added. New scrolling functions.
  • WebCore.pbproj/project.pbxproj: Added KWQNSViewExtras.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrame): Make sure superview and position is set up properly before we try to tab to something.
  • kwq/KWQWidget.mm: (QWidget::setFocus): Make sure superview and position is set up properly before we try to focus something.

Unrelated change.

  • kwq/KWQInvisibleButton.h:
  • kwq/KWQInvisibleButton.mm: Add KWQ prefix to the name of the private Objective C class to avoid potential conflicts.
10:15 AM Changeset in webkit [1889] by darin
  • 21 edits in trunk/WebCore

Implemented baseline alignment for form elements. We decided that this was better
than what we're currently doing. But it will look even better when the font of the
text field matches the font of the surrounding text, so we should consider that.

I also nudged the text down one pixel in popup menus, to match buttons. I think we
probably should suggest that this be done in Aqua by default (buttons and popup menus
already match in the normal size; this is the small size).

  • khtml/rendering/render_form.h: Remove some APPLE_CHANGES.
  • khtml/rendering/render_form.cpp: (RenderFormElement::baselinePosition): Use the widget's concept of the baseline position (the new QWidget::baselinePosition function). (RenderButton::baselinePosition): Just call the inherited version. (RenderSubmitButton::baselinePosition): Remove our ifdef because we want what the original code said, which was just calling the inherited version. (RenderLineEdit::baselinePosition): Removed our added method since we want to just call the inherited version. (RenderSelect::baselinePosition): Just call the inherited version for the pop up menu case. For the list box, just left the old code alone until someone can take a look at it.
  • kwq/qt/qwidget.h: Added new virtual baselinePosition function.
  • kwq/KWQWidget.mm: (QWidget::baselinePosition): Default for baseline is the bottom.
  • kwq/qt/qlineedit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::baselinePosition): Compute the baseline based on how NSTextField does it. Compared to the other widgets this was easy, because the cell's drawingRectForBounds gives you the place where the top of the line is. It does use defaultLineHeightForFont, which is not used by other widgets, but that's no real problem.
  • kwq/qt/qbutton.h:
  • kwq/KWQButton.mm: Moved all the code that's push-button specific into QPushButton.
  • kwq/qt/qpushbutton.h:
  • kwq/KWQPushButton.mm: (QPushButton::QPushButton): Set the bezel style of the button. (QPushButton::sizeHint): Moved here from QButton. (QPushButton::frameGeometry): Moved here from QButton. (QPushButton::setFrameGeometry): Moved here from QButton. (QPushButton::baselinePosition): Compute the baseline based on how NSButton does it. The rule for the style of button we use is "centered vertically in the available space, offset by kThemePushButtonSmallTextOffset", so I had to hardcode the value of kThemePushButtonSmallTextOffset; I called it VERTICAL_FUDGE_FACTOR (2).
  • kwq/qt/qcombobox.h:
  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell drawInteriorWithFrame:inView:]): Custom cell class that nudges the text down one pixel. (QComboBox::QComboBox): Attach the custom cell class. (QComboBox::baselinePosition): Compute the baseline based on how NSPopUpButton does it. The rule for the style of pop-up button we use is "CELLOFFSET pixels down from the top", so I had to hardcode the value of CELLOFFSET; I called it VERTICAL_FUDGE_FACTOR (2).
  • force-clean-timestamp: Yes, again.
12:47 AM Changeset in webkit [1888] by hyatt
  • 3 edits in trunk/WebKit

Raising the layout delay from 0.75 to 1.00. This should be
a little more conservative and matches the value used by Gecko.

  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]):

Aug 20, 2002:

10:23 PM Changeset in webkit [1887] by darin
  • 5 edits in trunk/JavaScriptCore

Three small changes to things that showed up in the sample.

5% speed increase on cvs-js-performance test.

  • kjs/simple_number.h: Check if double is an integer with d == (double)(int)d instead of remainder(d, 1) == 0, saving a function call each time.
  • kjs/ustring.cpp: (UString::find): Compare the first character before calling memcmp for the rest. (UString::rfind): Ditto. (KJS::operator==): Don't do a strlen before starting to compare the characters.
5:16 PM Changeset in webkit [1886] by hyatt
  • 3 edits in trunk/WebKit

Lower the paint/layout delay from 1.85 to 0.75, since we've
gotten a lot faster.

  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]):
4:03 PM Changeset in webkit [1885] by darin
  • 5 edits in trunk/WebCore
  • fix 3028936 -- fields are not submitting the correct data if they are selected when you submit
  • kwq/KWQNSTextField.mm: (-[KWQNSTextField controlTextDidChange:]): Call widget->textChanged and set edited to true here. The old code had two problems. First, it only sent textChanged from controlTextDidEndEditing. Second, it overrode textDidChange without calling super, preventing controlTextDidChange from being sent to the delegate.
3:56 PM Changeset in webkit [1884] by darin
  • 3 edits in trunk/JavaScriptCore

Fix log typos.

3:27 PM Changeset in webkit [1883] by sullivan
  • 4 edits in trunk/WebKit
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:]): Fixed uninitialized variable that Maciej's deployment build found.
2:58 PM Changeset in webkit [1882] by sullivan
  • 3 edits in trunk/WebKit

Fixed problem with previous checkin that was causing
drag-and-drop for files to fail (at least).

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowURL:]): pass isDirectory, not YES, to fileURLPolicyForMIMEType:inFrame:isDirectory:
2:53 PM Changeset in webkit [1881] by mjs
  • 4 edits in trunk/JavaScriptCore
  • kjs/object.cpp: Don't reference other ValueImps in the destructor, they may ha ve already been destroyed, and will have GC_ALLOWED set already in any case.
2:16 PM Changeset in webkit [1880] by sullivan
  • 14 edits in trunk/WebKit

WebKit:

WebKit part of fixes for:

  • 3027491 -- failure loading frame's resource leads to misbehaving panel
  • 3027494 -- failure loading frame's resource leads to error message in Alex, silence in IE
  • 3027697 -- alert box for missing file covered by browser window; should be a sheet
  • 3014123 -- error sheet when iframe has URL with bad path

Cleaned up the WebPolicy APIs to pass frames and URLs consistently. Also cleaned
up _shouldShowURL: (formerly _shouldShowDataSource:) method quite a bit.

  • WebView.subproj/WebControllerPolicyHandler.h:
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler downloadURL:]):
  • WebView.subproj/WebDefaultPolicyHandler.m: (-[WebDefaultPolicyHandler URLPolicyForURL:inFrame:]): (-[WebDefaultPolicyHandler fileURLPolicyForMIMEType:inFrame:isDirectory:]): (-[WebDefaultPolicyHandler unableToImplementPolicy:error:forURL:inFrame:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:]): Made various Policy-related methods pass the frame and when necessary the URL instead of the dataSource (or not even that in some broken cases). Collapsed the three unableToImplementXXXPolicy: methods into one.
  • WebView.subproj/WebFramePrivate.h: Change _shouldShowDataSource: to _shouldShowURL:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame handleUnimplementablePolicy:errorCode:forURL:]): New helper method. (-[WebFrame _shouldShowURL:]): use case statements instead of nested ifs; use handleUnimplementablePolicy: to reduce duplicated code; update for API changes; eliminate non-useful local variables.

WebBrowser:

WebBrowser part of fixes for:

  • 3027491 -- failure loading frame's resource leads to misbehaving panel
  • 3027494 -- failure loading frame's resource leads to error message in Alex, silence in IE
  • 3027697 -- alert box for missing file covered by browser window; should be a sheet
  • 3014123 -- error sheet when iframe has URL with bad path
  • BrowserDocument.m: (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): now pass frame to URLPolicyForURL:inFrame:
  • BrowserWebController.m: (-[BrowserWebController URLPolicyForURL:inFrame:]): add frame parameter to match changed API (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]): New method, replaces unableToImplementURLPolicy:error:forURL:, unableToImplementFileURLPolicy:error:forDataSource:, and unableToImplementContentPolicy:error:forDataSource:. Don't display error to user if it's not in the main frame. This matches the behavior of other browsers, and matches what Alexander does when a non-main-frame page fails to load.

(-[BrowserWebController fileURLPolicyForMIMEType:inFrame:isDirectory:]):
(-[BrowserWebController contentPolicyForMIMEType:URL:inFrame:]):
Updated signatures to match WebKit API changes.

12:55 PM Changeset in webkit [1879] by hyatt
  • 5 edits in trunk/WebCore

Fix background positioning so that it works with table cells.
This fixes the tabs on www.msn.com.

  • khtml/rendering/render_box.cpp: (RenderBox::printBackground):
  • khtml/rendering/render_table.h:
12:51 PM Changeset in webkit [1878] by darin
  • 3 edits in trunk/WebKit
  • fixed 3023076 -- Strange font chosen, widths screwed up, when text includes 007F characters
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]): (-[WebTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]): Treat 007F as a control character, skipping it just as we do other control characters.
12:32 PM Changeset in webkit [1877] by darin
  • 4 edits in trunk/WebKit

WebKit:

  • WebView.subproj/WebController.m: (-[WebController setApplicationNameForUserAgent:]): Lock in here, in anticipation of actually using the name in the user agent string.

WebBrowser:

  • BrowserWebController.m: (-[BrowserWebController initWithBrowserDocument:]): Set up the application name to be used in the user agent string. For now, there is a dummy string in there.
12:15 PM Changeset in webkit [1876] by darin
  • 23 edits in trunk

WebCore:

WebCore part of support for tabbing into and out of the toolbar.

  • kwq/KWQKHTMLPartImpl.h: Renamed static nextKeyView to nextKeyViewForWidget. Added nextKeyViewInFrameHierarchy.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrameHierarchy): New name for the old nextKeyView. (KWQKHTMLPartImpl::nextKeyView): Added. Does all the logic for handling views outside the frame hierarchy that used to be only in the static nextKeyView. (KWQKHTMLPartImpl::nextKeyViewForWidget): New name for the static nextKeyView, which now just does the widget-specific bits. Removed null check in here that's no longer needed.
  • kwq/KWQNSTextField.mm: Update to call nextKeyViewForWidget.
  • kwq/WebCoreBridge.h: Added nextKeyViewInsideWebViews, previousKeyViewInsideWebViews, nextKeyViewOutsideWebViews, and previousKeyViewOutsideWebViews.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge nextKeyViewInsideWebViews]): Call nextKeyViewInFrameHierarchy. (-[WebCoreBridge previousKeyViewInsideWebViews]): Call nextKeyViewInFrameHierarchy.

Introduced QString to sprong. See <​http://www.goat.demon.co.uk/sprong.html>.
A few other tweaks to QString API; wean it from mutable strings.

  • kwq/qt/qstring.h:
  • kwq/KWQString.mm: Sprongify it. (QString::setBufferFromCFString): Add a fixed-size buffer to avoid malloc. (QString::getCFString): Replace getCFMutableString with this. (QString::getNSString): Use NSString directly.
  • kwq/KWQDictImpl.mm:
  • kwq/KWQKURL.mm:
  • kwq/KWQStringList.mm:
  • kwq/KWQtextcodec.mm:
  • kwq/WebCoreBridge.mm: Use getCFString, not getCFMutableString.

WebKit:

WebKit part of support for tabbing into and out of the toolbar.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge nextKeyViewOutsideWebViews]): Ask the main WebView for its nextKeyView on behalf of WebCore. (-[WebBridge previousKeyViewOutsideWebViews]): Ask the main WebView for its previousKeyView on behalf of WebCore.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView becomeFirstResponder]): When we are being tabbed-into, make the first or last view in the bridge first responder, instead of taking it ourselves.
  • WebView.subproj/WebView.m: (-[WebView becomeFirstResponder]): Always make the document view the first responder instead of taking it ourselves.

WebBrowser:

  • fixed 2868093 -- Can't tab between toolbar items and main view
  • BrowserWindowController.m: (-[BrowserWindowController dealloc]): Cancel lingering perform requests. Good for the new one I added, but also for the status one. (-[BrowserWindowController clearStatus]): Don't bother calling centerTruncateString on @"". (-[BrowserWindowController leftmostToolbarKeyboardLoopItem]): Added. part of hack to make the toolbar loop stitch together with the rest of the views. (-[BrowserWindowController rebuildKeyboardLoop]): Added. Adds the web view into the keyboard loop along with the toolbar. (-[BrowserWindowController windowShouldRebuildKeyboardLoopSoon:]): Schedules a call to rebuildKeyboardLoop. We don't do the work right away because we need to wait until the toolbar is done with its loop calculations.
  • TextField.h: New methods for the window delegate.
  • TextField.m: (-[TextField windowShouldRebuildKeyboardLoopSoon]): Call windowShouldRebuildKeyboardLoopSoon on the window delegate. (-[TextField setNextKeyView:]): Call windowShouldRebuildKeyboardLoopSoon because a change in our next key view means that the toolbar is wiring up the keyboard loop. (-[TextField viewDidMoveToWindow]): Call windowShouldRebuildKeyboardLoopSoon because we are going back on screen, which means that the toolbar is likely coming back.

Aug 19, 2002:

7:53 PM Changeset in webkit [1875] by darin
  • 4 edits in trunk/WebCore
  • force-clean-timestamp: Richard's changes require a clean build.
7:11 PM Changeset in webkit [1874] by rjw
  • 8 edits in trunk/WebCore

QString rewrite. Much faster now.
QString has an inline rep, QStringData, which
has an inline character buffer. reps are
referenced indirectly via a handle. inline
reps are detached when necessary. Typical
stack based usage requires no allocations
for small string. Attempts are made to avoid
costly conversions between ascii and unicode.
Extensive diagnostics can be enable by
defining QSTRING_DEBUG_ALLOCATIONS and calling
_printQStringAllocationStatistics().

There appear to be a few small lingering leaks
that I need to track down.

  • WebCore-tests.exp:

Added symbols for qstring-test.cpp.

  • khtml/css/cssstyleselector.cpp:

Removed old string optimization hack.

  • kwq/KWQString.mm:

Rewrite.
(_isOnStack):
(countInstance):
(allocatedBuffers):
(ALLOC_CHAR):
(REALLOC_CHAR):
(DELETE_CHAR):
(ALLOC_QCHAR):
(REALLOC_QCHAR):
(DELETE_QCHAR):
(_printQStringAllocationStatistics):
(ucstrcmp):
(ucstrncmp):
(ucstrnicmp):
(ok_in_base):
(QStringData::QStringData):
(QStringData::initialize):
(QStringData::operator new):
(QStringData::operator delete):
(QString::makeSharedNullHandle):
(QString::makeSharedNull):
(QStringData::~QStringData):
(QStringData::ascii):
(QStringData::increaseAsciiSize):
(QStringData::unicode):
(QStringData::increaseUnicodeSize):
(QStringData::makeAscii):
(QStringData::makeUnicode):
(QString::setBufferFromCFString):
(QString::fromStringWithEncoding):
(QString::fromCFMutableString):
(QString::fromCFString):
(QString::fromNSString):
(QString::getCFMutableString):
(QString::getNSString):
(QString::~QString):
(QString::QString):
(QString::operator=):
(QString::at):
(QString::unicode):
(QString::compare):
(QString::startsWith):
(QString::endsWith):
(QString::latin1):
(QString::isNull):
(QString::find):
(QString::findRev):
(QString::contains):
(QString::toShort):
(QString::toUShort):
(QString::toInt):
(QString::toUInt):
(QString::toLong):
(QString::toULong):
(QString::toDouble):
(QString::findArg):
(QString::arg):
(QString::left):
(QString::right):
(QString::mid):
(QString::copy):
(QString::lower):
(QString::stripWhiteSpace):
(QString::simplifyWhiteSpace):
(QString::deref):
(QString::setUnicode):
(QString::setLatin1):
(QString::sprintf):
(QString::append):
(QString::insert):
(QString::detachInternal):
(QString::detach):
(QString::remove):
(QString::replace):
(QString::forceUnicode):
(QString::setLength):
(QString::truncate):
(QString::fill):
(QString::operator+=):
(QString::convertToQCString):
(operator==):
(QConstString::QConstString):
(QConstString::~QConstString):
(_initializeHandleNodeBlock):
(_allocatePageNode):
(_initializeHandleNodes):
(_allocateNode):
(allocateHandle):
(freeHandle):

  • kwq/qt/qstring.h: Rewrite
2:59 PM Changeset in webkit [1873] by mjs
  • 6 edits
    1 add in trunk/WebCore
  • Makefile.am: Added new mechanism to clean only the objects that depend on JavaScript.
  • force-js-clean-timestamp: Touched since I changed JSC just now.
  • .cvsignore: Ignore previous-js-clean-timestamp.
2:54 PM Changeset in webkit [1872] by darin
  • 4 edits in trunk/WebCore

Fixed tab cycle on slashdot.org and elsewhere by being stricter about what is
included in the tab cycle.

  • kwq/KWQWidget.mm: (QWidget::focusPolicy): Use the same rule as AppKit.
2:36 PM Changeset in webkit [1871] by hyatt
  • 5 edits in trunk/WebCore

Tweak baselines to look a little better for form controls.
This will be redone by Darin to really baseline align... this
is just temporary.

Also adding 3px margins to <input> and <textarea> and <select>.

  • khtml/css/html4.css:
  • khtml/rendering/render_form.cpp: (RenderButton::baselinePosition): (RenderSelect::baselinePosition):
2:29 PM Changeset in webkit [1870] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrame): Add null check.
2:14 PM Changeset in webkit [1869] by mjs
  • 5 edits in trunk/JavaScriptCore

Fixed the bug that made sony.com menus come out wrong and made
aa.com crash (Radar 3027762).

Mode most methods inline.

  • kjs/completion.cpp:
  • kjs/completion.h:
1:46 PM Changeset in webkit [1868] by cblu
  • 3 edits in trunk/WebKit

Fixed 3025019: "only-if-cached" attribute fetches data from network if cached but expired

  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader iconFromCache]):
1:11 PM Changeset in webkit [1867] by darin
  • 8 edits in trunk/WebCore

Put in more robust version of the next/previous key view checking
that matches what I did in WebHTMLView.

  • kwq/KWQNSTextField.h: Add inNextValidKeyView instance variable.
  • kwq/KWQNSTextField.mm: (-[KWQNSTextField dealloc]): No need to nil out widget. (-[KWQNSTextField nextKeyView]): Only do the computation when called from nextValidKeyView. (-[KWQNSTextField previousKeyView]): Only do the computation when called from previousValidKeyView. (-[KWQNSTextField nextValidKeyView]): Set boolean. (-[KWQNSTextField previousValidKeyView]): Set boolean. (-[KWQSecureTextField nextKeyView]): Only do the computation when called from nextValidKeyView. (-[KWQSecureTextField previousKeyView]): Only do the computation when called from nextValidKeyView. (-[KWQSecureTextField nextValidKeyView]): Set boolean. (-[KWQSecureTextField previousValidKeyView]): Set boolean.

Unrelated change.

  • kwq/mac-encodings.txt: Add an encoding name of gb18030, since I saw mention of it in bug 3002016.
11:59 AM Changeset in webkit [1866] by darin
  • 11 edits in trunk

WebCore:

Support so that WebKit can tab into a web view's fields.

  • kwq/KWQKHTMLPartImpl.h: Made another nextKeyView() version public.
  • kwq/WebCoreBridge.h: Add new methods, change parameters to one existing one.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:marginWidth:marginHeight:]): Remove width and height parameters. The passed-in view already has the correct width and height. (-[WebCoreBridge nextKeyView]): Call nextKeyView() with node == 0. (-[WebCoreBridge previousKeyView]): Call nextKeyView() with node == 0.

WebKit:

  • fixed 2863025 -- Need to implement TABing between widgets in forms

Implemented tabbing into a web view's fields. I now consider the task of
tabbing between widgets done. But there are many loose ends, each with its
own bug report.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView dealloc]): Set _private to nil so we can properly handle calls that come from NSView dealloc. (-[WebHTMLView provisionalDataSourceChanged:]): No need to pass width and height to createKHTMLViewWithNSView any more. Also, just pass self rather than making the roung trip to the WebFrame and the WebView back here. (-[WebHTMLView nextKeyView]): Added. Calls the bridge version when we are called from nextValidKeyView, the normal version the rest of the time. (-[WebHTMLView previousKeyView]): Added. Calls the bridge version when we are called from nextValidKeyView, the normal version the rest of the time. (-[WebHTMLView nextValidKeyView]): Set inNextValidKeyView and call super. (-[WebHTMLView previousValidKeyView]): Set inNextValidKeyView and call super.
  • WebView.subproj/WebHTMLViewPrivate.h: Add inNextValidKeyView flag.
9:53 AM Changeset in webkit [1865] by darin
  • 61 edits
    3 deletes in trunk/WebCore

First cut at implementation of "tab to change focus": Lots of loose ends, but it's
going well.

  • kwq/KWQNSTextField.h: Change initWithWidget to initWithQLineEdit.
  • kwq/KWQNSTextField.mm: (-[KWQNSTextField initWithQLineEdit:]): Keep a QLineEdit pointer so we don't cast later. (-[KWQNSTextField dealloc]): Sets widget to 0 to make nextKeyView and previousKeyView return nil while deallocating. (-[KWQNSTextField setPasswordMode:]): Pass widget when creating secure text field so it can handle the next/previous links properly. (-[KWQNSTextField nextKeyView]): Added. Calls KWQKHTMLPartImpl::nextKeyView. (-[KWQNSTextField previousKeyView]): Added. Calls KWQKHTMLPartImpl::nextKeyView. (-[KWQTextFieldCell isOpaque]): Added. Returns NO; fixes focus rectangle updating. (-[KWQSecureTextField initWithQWidget:]): Added. (-[KWQSecureTextField dealloc]): Added. Sets widget to 0 to make nextKeyView and previousKeyView return nil while deallocating. (-[KWQSecureTextField nextKeyView]): Added. Calls KWQKHTMLPartImpl::nextKeyView. (-[KWQSecureTextField previousKeyView]): Added. Calls KWQKHTMLPartImpl::nextKeyView.
  • kwq/KWQKHTMLPartImpl.h: Add KWQSelectionDirection. Change name of getBridge() to bridge(), getDocument() to document(), getRenderer() to renderer(), getBridgeForFrameName() to bridgeForFrameName(). Also added nextKeyView family of member functions.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrame): Added. (KWQKHTMLPartImpl::nextKeyView): Added.
  • kwq/qt/qwidget.h: Remove unneeded parameters from constructor. Also added a constructor that takes an NSView.
  • kwq/KWQWidget.mm: (QWidget::QWidget): Don't store focus policy (it was uninitialized before). (QWidget::focusPolicy): Return TabFocus for any widget that has a view with a first responder, NoFocus for any other. (QWidget::setFocusPolicy): Do nothing. (QWidget::setFocusProxy): Do nothing.
  • kwq/qt/qobject.h: Store the event filter object when installEventFilter is called. This is used to find the RenderWidget for a QWidget by the new tabbing code.
  • kwq/KWQObject.mm: Removed event-filter functions. Two are now inlines, one deleted.

Other changes related to KWQKHTMLPartImpl improvements.

  • kwq/KWQKHTMLPartBrowserExtension.mm:
  • kwq/KWQKHTMLPartImpl.mm:
  • kwq/KWQLoaderImpl.mm:
  • kwq/WebCoreBridge.mm: Update for KWQKHTMLPartImpl member name changes.

Various improvements for other widget implementations.

  • kwq/qt/qbutton.h:
  • kwq/KWQButton.mm: Stop using KWQNSButton. Instead just use a button adapter object, and a plain old NSButton. (QButton::QButton): Put all the NSButton setup in here. (QButton::~QButton): Release the adapter here. (QButton::clicked): Move this in here because it's virtual now so that QCheckBox can override it. (-[KWQButtonAdapter initWithQButton:]): Added. (-[KWQButtonAdapter action:]): Just call clicked().
  • kwq/qt/qpushbutton.h: Don't pass unused parent pointer to QButton constructor.
  • kwq/KWQPushButton.mm: (QPushButton::QPushButton): Don't pass unused parent pointer to QButton contructor.
  • kwq/qt/qcheckbox.h:
  • kwq/KWQCheckBox.mm: Just use NSButton, not KWQNSButton. (QCheckBox::clicked): Move the state-changed logic here; used to be in KWQNSButton.
  • kwq/KWQRadioButton.mm: (QRadioButton::QRadioButton): Don't pass unused parent pointer to QButton contructor.
  • kwq/qt/qcombobox.h:
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): Removed extra constructor. Make a plain NSPopUpButton, and use an adapter object, rather than having a KWQNSComboBox. (QComboBox::~QComboBox): Release the adapter. (QComboBox::insertItem): New implementation. No need to keep an items array around, because the menu does that just fine. (QComboBox::clear): Remove the items from the pop-up button directly. (-[KWQComboBoxAdapter initWithQComboBox:]): Added. (-[KWQComboBoxAdapter action:]): Just call activated().
  • kwq/kdeui/kcombobox.h: Empty this out and make it use only inlines.
  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Remove the setSize()/doneLoading() optimization for QComboBox because the new simpler QComboBox implementation obviates the speed problem this was originally intended to fix.
  • kwq/qt/qlineedit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): Call initWithQLineEdit instead of initWithWidget. Also don't take an unused parent pointer parameter.
  • kwq/kdeui/klineedit.h: Empty this out and make it use only inlines.
  • kwq/qt/qframe.h: Remove unused parent pointer from constructor.
  • kwq/KWQFrame.mm: Remove unneeded constructor.
  • kwq/KWQHBox.mm: (QHBox::QHBox): Don't pass unused parent pointer to QFrame.
  • kwq/KWQLabel.mm: (QLabel::QLabel): Don't pass unused parent pointer to QFrame.
  • kwq/qt/qscrollview.h: Make constructor inline.
  • kwq/KWQScrollView.mm: Remove unneeded constructor.
  • kwq/KWQWindowWidget.h: Remove unneeded constructor.
  • WebCore.pbproj/project.pbxproj: Remove KWQKComboBox.mm, KWQKLineEdit.mm, and KWQScrollBar.h.
  • kwq/KWQKComboBox.mm: Removed.
  • kwq/KWQKLineEdit.mm: Removed.
  • kwq/KWQScrollBar.h: Removed. Unused.
  • kwq/KWQTextArea.h: Change initWithWidget to initWithQTextEdit.
  • kwq/KWQTextArea.mm: (-[KWQTextArea initWithQTextEdit:]): Changed name.
  • kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): Call initWithQTextEdit instead of initWithWidget.
  • kwq/KWQView.h: Eliminated KWQNSButton, KWQNSComboBox, and KWQNSScrollView.
  • kwq/KWQView.mm: Ditto.

Housekeeping.

  • force-clean-timestamp: Yes, again.
  • khtml/khtml_part.h: Rearrange APPLE_CHANGES a bit.
  • kwq/qt/qvaluelist.h: Added -- as well as ++ for the const iterator, and fixed some minor const issues. At one point I needed this for the focus changes, but not any more.
1:54 AM Changeset in webkit [1864] by mjs
  • 5 edits in trunk/JavaScriptCore

Maintain stack of old "arguments" property values for functions
implicitly on the system stack instead of explicitly in the
FunctionImp. This eliminates only a trivial number of GC
allocations (less than 200) but eliminates one of the two cases
where a ListImp * is stored directly, paving the way to separate
List from Value.

  • kjs/function.h: Remove argStack, pushArgs and popArgs.
  • kjs/function.cpp: (FunctionImp::FunctionImp): Don't initalize argStack. (FunctionImp::~FunctionImp): Remove comment about argStack. (FunctionImp::mark): Don't mark the argStack. (FunctionImp::call): Save old "arguments" property in a Value, where it will be GC-protected, rather than keeping a list, and restore the old value when done executing.

Aug 18, 2002:

5:31 PM Changeset in webkit [1863] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/internal.cpp: (KJS::printInfo): Remove one more CompletionType that Maciej missed.
5:20 PM Changeset in webkit [1862] by darin
  • 15 edits in trunk/WebKit

WebFoundation:

Step 5 of adding user-agent API.

Add API to pass user agent into WebFoundation when creating a WebResourceHandle,
or to compute the user agent for each URL in a WebResourceClient method.

Also renamed the WebResourceClient methods to be more like delegate methods in AppKit.

  • CacheLoader.subproj/WebHTTPResourceLoader.m: (-[WebHTTPProtocolHandler addUserAgentHeader:]): Treat nil for user agent as "no user-agent header". (-[WebHTTPProtocolHandler createWFLoadRequest]): Treat nil for user agent as "no user-agent header".
  • CacheLoader.subproj/WebResourceCallbackClient.m: Updated methods for new names. Added nil-returning handleWillUseUserAgent:forURL:.
  • CacheLoader.subproj/WebResourceClient.h: New names.
  • CacheLoader.subproj/WebResourceHandle.h: Added userAgent parameter to init function.
  • CacheLoader.subproj/WebResourceHandle.m: Updated method for new names. (-[WebResourceHandleInstanceVariables dealloc]): Store originalUserAgent so we don't ask the handle twice about that same URL. Could do a bit more of this if needed. (-[WebResourceHandle _originalCanonicalURL]): Renamed canonicalURL to this for clarity. (-[WebResourceHandle _originalUserAgent]): Added. (-[WebResourceHandle _userAgentForURL:]): Made this actually call handleWillUseUserAgent:forURL:. Now we have no hard-coded user-agent string in WebFoundation at all.
  • CacheLoader.subproj/WebResourceHandlePrivate.h: Added _originalUserAgent.
  • CacheLoader.subproj/WebResourceLoad.h: Added userAgent, originalUserAgent.
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad userAgent]): Return this rather than recomputing it. (-[WebResourceLoad dealloc]): Release this. (-[WebResourceLoad _originalUserAgent]): Return this rather than recomputing it. (-[WebResourceLoad didRedirectToURL:cacheRedirect:]): Store userAgent when we update URL. (-[WebResourceLoad _cacheKey]): Allow userAgent of nil.
  • CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]): Allow userAgent of nil, and get it, don't compute it. (-[WebResourceLoadKey isEqual:]): Handle userAgent of nil properly.

WebKit:

Update WebResourceClient instances for new API, including adding
the handleWillUseUserAgent:forURL: method.

  • Misc.subproj/WebIconLoader.m:
  • Plugins.subproj/WebPluginStream.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebView.subproj/WebMainResourceClient.m: These were all the clients that needed updating.
  • WebView.subproj/WebController.m: (-[WebController setUserAgent:]): Lock so that we can set the user agent even though another thread could be calling userAgentForURL:. (-[WebController userAgentForURL:]): Ditto.
  • WebView.subproj/WebControllerPrivate.h: Add lock.
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): Create lock. (-[WebControllerPrivate dealloc]): Release lock.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Improve comment.
5:11 PM Changeset in webkit [1861] by mjs
  • 6 edits in trunk/JavaScriptCore

Remove stray references to CompletionType and CompletionImp.

  • kjs/completion.h:
  • kjs/object.cpp:
  • kjs/value.h:
3:57 PM Changeset in webkit [1860] by darin
  • 3 edits in trunk/WebKit
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader iconFromCache]): (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]): Don't process each icon twice. We need to have the loader as a client even for the synchronous case because of the user agent issue, but that causes double work.
12:21 AM Changeset in webkit [1859] by mjs
  • 9 edits
    2 adds in trunk/JavaScriptCore

Separated Completion from Value and made it a pure stack
object. This removed another 160,000 of the remaining 580,000
garbage collected object allocations.

6% speed increas on cvs-js-performance test.

  • kjs/completion.cpp: Added. New implementation that doesn't require a ValueImp *. (Completion::Completion): (Completion::complType): (Completion::value): (Completion::target): (Completion::isValueCompletion):
  • kjs/completion.h: Added.
  • kjs/function.cpp: (GlobalFuncImp::call): Removed some (apparently mistaken) uses of Completion as a Value.
  • kjs/internal.cpp:
  • kjs/internal.h:
  • kjs/types.cpp: Removed Completion stuff.
  • kjs/types.h: Removed Completion stuff.
  • JavaScriptCore.pbproj/project.pbxproj: Added new header.
Note: See TracTimeline for information about the timeline view.