⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 26, 2002:

5:19 PM Changeset in webkit [1918] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3026006. Ensure that TABLES inside <div>s with align="right"
are properly positioned. <div align="right"> was completely
unimplemented. This patch implements it for the common cases
(nested divs, tables within divs, and paragraphs).

  • khtml/css/html4.css:
2:33 PM Changeset in webkit [1917] by darin
  • 11 edits in trunk/WebKit

Add machinery for deferring callbacks. Not used yet.

  • WebView.subproj/WebControllerPrivate.h: Add methods.
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _defersCallbacks]): Returns old state. (-[WebController _setDefersCallbacks:]): Changes state and calls _defersCallbacksChanged on the main frame.
  • WebView.subproj/WebFramePrivate.h: Add _defersCallbacksChanged.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _defersCallbacksChanged]): Calls _defersCallbacksChanged on both data sources.
  • WebView.subproj/WebDataSourcePrivate.h: Add _defersCallbacksChanged.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setController:]): Call _defersCallbacksChanged if changing the controller changes the state. (-[WebDataSource _addResourceHandle:]): Call setDefersCallbacks:YES on the new handle if we are already attached to a controller that defers callbacks. (-[WebDataSource _defersCallbacksChanged]): Call setDefersCallbacks on all the handles, and call _defersCallbacksChanged on the child frames as well.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource controller]): We need to know about all controller changes, so it's unacceptable to consult our parent about the controller. But we already do know about it and this code was unnecessary. Leave the old code around as an assert only.
2:21 PM Changeset in webkit [1916] by darin
  • 4 edits in trunk/WebCore
  • khtml/rendering/render_list.cpp: Make file match the original KDE more closely (no substantive change).
1:50 PM Changeset in webkit [1915] by rjw
  • 12 edits
    2 adds in trunk

WebBrowser:

  • History.subproj/WebHistory.h:
  • History.subproj/WebHistory.m: (+[WebHistory webHistoryWithFile:]): Stage 1, set the shared history instance. This'll move to WebKit soon.
  • WebView.subproj/WebView.m: (-[WebView setFrame:]): Only force display if in live resize.

WebKit

Fixed for 2883623 (visited links only). Will change
w/ stage 2 of history move to webkit.

  • GlobalHistory.m: (-[GlobalHistory awakeFromNib]):

WebCore:

  • WebCore.exp:

Added WebCoreHistory

  • WebCore.pbproj/project.pbxproj:

Added WebCoreHistory

  • kwq/KWQKHistoryProvider.mm: Use WebCoreHistory to determine visited link.
  • kwq/WebCoreHistory.h: Added.
  • kwq/WebCoreHistory.m: Added.

Stage 1. Use WebKit's WebHistory. Writing
of history and initialization still handled
by Alex until stage 2.

(+[WebCoreHistory setSharedHistory:]):
(+[WebCoreHistory sharedHistory]):
(-[WebCoreHistory containsURL:]):

  • kwq/KWQString.mm: (QString::compare):

Optimization, use strcmp when both src and dst have valid ascii.

1:35 PM Changeset in webkit [1914] by hyatt
  • 5 edits in trunk/WebCore
  • Patch drawText to understand right-aligned drawing.
  • Fixed <ul> bullets so that they position properly.
  • Fixed bugs with horizontal and vertical positioning of <ol> bullets.
  • khtml/rendering/render_list.cpp: (RenderListMarker::printObject):
  • kwq/KWQPainter.mm: (QPainter::drawText):
7:27 AM Changeset in webkit [1913] by sullivan
  • 5 edits in trunk/WebKit

WebKit:

  • fixed bug where dragging a separator in the Bookmarks window would hit an assertion.
  • Bookmarks.subproj/WebBookmarkSeparator.m: (-[WebBookmarkSeparator initWithGroup:]): Removed obsolete assertion that group is not nil.
  • Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initWithTitle:group:]): Removed a similar obsolete assertion here.
  • Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initWithTitle:group:]): Removed a similar obsolete assertion here.

WebBrowser:

  • fixed bug where new separator would not be scrolled into view if necessary.
  • BookmarksController.m: (-[BookmarksController _focusOnNewlyCreatedBookmark:]): Scroll to reveal new item.

Aug 24, 2002:

11:41 PM Changeset in webkit [1912] by darin
  • 5 edits in trunk/WebCore
  • fixed 3032072 -- Crash on reload in DOM::DocumentImpl::~DocumentImpl [unified]()

This was a tough one to debug.
Turned out to be a subtle bug in our new QConstString implementation.

  • kwq/KWQString.mm: (QStringData::makeAscii): Don't invalidate the Unicode buffer unless the ASCII buffer is taking over the internal buffer from the Unicode. In other cases, it's important not to invalidate the Unicode because it can result in the Unicode being freed and re-created when unicode() is called, which is disastrous in the QConstString case because we can't free the Unicode. (QStringData::makeUnicode): Make the corresponding change for ASCII too. In this case, it's just an optimization, not a bug fix. (QString::insert), (QString::remove), (QString::fill), (QString::operator+=): Mark the other string invalid whenever we modify either the ASCII or the Unicode string. This was handled correctly for some operations before, but not all, and it now matters because makeAscii and makeUnicode will now allow this state.

Fixed a separate QString problem; I think I may have introduced this one.

  • kwq/KWQString.mm: (QString::getNSString): Since by ASCII, we actually mean ISO Latin 1, we can't use [NSString stringWithCString:]. Use CFStringCreateWithCString instead, pass CFStringCreateWithCString as the encoding, and use autorelease. We shouldn't really use the term ASCII in this class for the 8-bit-per-character buffer. Something more like Latin1 would be a more accurate way to refer to it. Maybe I'll do that renaming after talking to Richard about it on Monday.

Fixed a small storage leak.

  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cleanup): Added braces to fix obviously-incorrect if/else grouping.

Aug 23, 2002:

2:25 PM Changeset in webkit [1911] by darin
  • 4 edits in trunk/WebKit

WebKit:

  • WebView.subproj/WebFrame.m: (-[WebFrame reset]): Remove unneeded call to _reset.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _setDataSource:]): Add code that removes the KHTML stuff from the frame when switching to another type of view. It would be better to do this at some other level, but without this code, we end up leaving the entire KHTMLView behind when we switch to a non-HTML page.

WebBrowser:

Debugging tool to make it easy to reproduce problems like 3021018, where
a page transition happens while you are holding a menu down.

  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Add "Go to about:blank Soon menu item". (-[BrowserDocument goToAboutBlankSoon:]): Implementation.
10:28 AM Changeset in webkit [1910] by darin
  • 4 edits in trunk/WebCore

Got the kurl-test in the Tests directory working again.

  • kwq/KWQKURL.mm: (KURL::KURL): Fixed problem where relative path resolution code for "../" could eat up the host name too, treating it as part of the path.
10:16 AM Changeset in webkit [1909] by darin
  • 6 edits in trunk/WebCore
  • fixed 3032058 -- Links on local developer doc pages all broken (all local files?)
  • kwq/KWQKURL.mm: (KURL::getNSURL): Re-added a workaround for CFURL bug 2908969. We have to hack to make NSURL take "file:/" URLs.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyViewInFrame): Add a nil check. I ran into this because my frame failed to load.
3:24 AM Changeset in webkit [1908] by mjs
  • 6 edits in trunk/WebCore

A few more KURL changes that reduce it down to background noise
level.

For me this gave another 1-2% improvement on cvs-base.

  • kwq/kdecore/kurl.h:
  • kwq/KWQKURL.mm: (KURL::KURL): In the relative constructor, do all work in a char array for the relative path case, and leave it up to ::parse to create a QString. (KURL::parse): Do all work in a char array, only creating a QString at the end if needed. Also, take an optional pointer to the QString that the char * was created from, and if the final processed URL is the same as the original, assign the original instead of creating a new QString. (KURL::setProtocol): Adjust for prase() interface change. (KURL::setHost): Likewise. (KURL::setPort): Likewise. (KURL::setRef): Likewise. (KURL::setQuery): Likewise. (KURL::setPath): Likewise. (appendEscapingBadChars): Instead of taking and returning a QString like the old escapeBadChars, copy from and write into existing C string buffers.

Aug 22, 2002:

11:14 PM Changeset in webkit [1907] by darin
  • 4 edits in trunk/WebCore
  • force-clean-timestamp: Without this, I crash on startup.
8:39 PM Changeset in webkit [1906] by mjs
  • 7 edits in trunk/WebCore

top level:

Fix test results to no longer reflect KURL or CFURL oddities that
we are not emulating.

  • Tests/kde/kurl-test.chk:
  • Tests/kde/kurl-test.cpp: (testURL): Replay mistaken n with \n.

WebCore:

Brand new KURL implementation which avoids CFURL, CFString, and
all that other allocation-happy goodness and instead does as much
work as possible with raw ASCII buffers.

For me this gave a ~5% performance improvement on cvs-base.

  • kwq/KWQKURL.mm: (KURL::KURL): (KURL::hasPath): (KURL::protocol): (KURL::host): (KURL::port): (KURL::pass): (KURL::user): (KURL::ref): (KURL::query): (KURL::path): (KURL::setProtocol): (KURL::setHost): (KURL::setPort): (KURL::setRef): (KURL::setQuery): (KURL::setPath): (KURL::prettyURL): (KURL::decode_string): (escapeBadChars): (KURL::parse): (KURL::getNSURL):
  • kwq/kdecore/kurl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::end): Don't call KURL::clearCaches() any more.
5:11 PM Changeset in webkit [1905] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQButton.mm: (QButton::~QButton): Disconnect the view from the widget by doing setTarget:nil.
  • kwq/KWQComboBox.mm: (QComboBox::~QComboBox): Ditto.
4:57 PM Changeset in webkit [1904] by hyatt
  • 4 edits in trunk/WebCore

Add vertical margins for checkboxes and radios. A later rule
in the file was overriding my earlier attempt to set up these margins.

  • khtml/css/html4.css:
4:50 PM Changeset in webkit [1903] by rjw
  • 6 edits in trunk/WebCore

New faster char * append (actually insert) for mjs.

  • kwq/KWQString.mm: (QString::insert):
  • kwq/qt/qstring.h:
3:37 PM Changeset in webkit [1902] by rjw
  • 10 edits in trunk/WebKit

i Changed public string from #define to extern NSString.

  • WebKit.exp:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m:
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuHandler openNewWindowWithURL:]): (-[WebDefaultContextMenuHandler downloadURL:]): (-[WebDefaultContextMenuHandler openLinkInNewWindow:]): (-[WebDefaultContextMenuHandler downloadLinkToDisk:]): (-[WebDefaultContextMenuHandler copyLinkToClipboard:]): (-[WebDefaultContextMenuHandler openImageInNewWindow:]): (-[WebDefaultContextMenuHandler downloadImageToDisk:]): (-[WebDefaultContextMenuHandler copyImageToClipboard:]): (-[WebDefaultContextMenuHandler openFrameInNewWindow:]):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): (-[WebHTMLView _continueAfterCheckingDragForEvent:]):
12:14 PM Changeset in webkit [1901] by darin
  • 6 edits in trunk/WebCore

Some small QString improvements.

  • kwq/qt/qstring.h: Add printf attribute to sprintf member function.
  • kwq/KWQString.mm: Remove extra \n characters from QSTRING_FAILURE calls. Change some fprintf to QSTRING_FAILURE. Change some QSTRING_FAILURE to KWQ_ASSERT. (QStringData::makeAscii): Fix bug where it would update _maxAscii with a new size even when it didn't allocate a new buffer. (QStringData::makeUnicode): Fix bug where it would update _maxUnicode with a new size even when it didn't allocate a new buffer. (QString::utf8): Fix bug where it assumed the UTF-8 form of a string has the same length as the Unicode version. Also save one allocation by doing it right into the QCString. (QString::local8Bit): Just call utf8(). (QString::setNum): Have all these call our sprintf. (QString::sprintf): Format once to get the length. Then do the second format right into the string buffer. This way we don't have to do any allocation at all, nor use CFString.
11:22 AM Changeset in webkit [1900] by kocienda
  • 4 edits in trunk/WebKit

Passing the main load's attributes to the subresource loads causes
breakage (most visible when we POST).

Right now, we just rely on flags to handle "back/forward" loads, so
the attributes were not actually being used.

A better fix needs to be put in place when the soon-to-be-done
attributes/flags rework is done.

  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]):
10:52 AM Changeset in webkit [1899]
  • 3 copies in tags/Alexander-20

This commit was manufactured by cvs2svn to create tag 'Alexander-20'.

10:52 AM Changeset in webkit [1898] by vicki
  • 8 edits in trunk

Alex-20

8:01 AM Changeset in webkit [1897] by darin
  • 4 edits in trunk/WebCore

Fixed a one-click crasher that Ken and Don told me about.

  • kwq/KWQObject.mm: (QObject::QObject): Initialize m_eventFilterObject.
Note: See TracTimeline for information about the timeline view.