Timeline



Sep 3, 2002:

3:37 PM Changeset in webkit [1955] by sullivan
  • 3 edits in trunk/WebKit
  • Resources/url_icon.tiff: New image (still a placeholder) from HI. For the moment the default page icon is the legendary @-sign-on-a-spring. I've been promised a replacement by tomorrow sometime.
12:41 PM Changeset in webkit [1954] by sullivan
  • 5 edits
    1 delete in trunk/WebKit

WebKit:

  • removed small folder image used for bookmark lists; it is now up to clients to display an icon for bookmark lists.
  • Bookmarks.subproj/WebBookmarkList.h: Removed _icon ivar
  • Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList dealloc]): Don't release _icon (-[WebBookmarkList icon]): just return nil
  • Resources/bookmark_folder.tiff: Removed.
  • WebKit.pbproj/project.pbxproj: Updated for removed file.

WebBrowser:

  • made Favorites bar handle folder icons
  • made bookmarks view start with all top-level folders expanded
  • fixed bug where bookmarks outline would sometimes have horizontal scroll bar (which you couldn't get rid of)
  • fixed bug where bookmarks window (Debug menu) wouldn't start with outline view focused (so some menu items were disabled)
  • Resources/Images/folder16.tiff: Added. Small folder icon.
  • Resources/Images/folder32.tiff: Added. Bigger folder icon.
  • WebBrowser.pbproj/project.pbxproj: Updated for new images.
  • BookmarksController.m: (-[BookmarksController imageForBookmark:]): return small folder icon
  • BookmarksViewController.m: (-[BookmarksViewController expandTopLevelItems]): New method. (-[BookmarksViewController awakeFromNib]): Call expandTopLevelItems.
  • BookmarksWindowController.m: (-[BookmarksWindowController windowDidLoad]): set outline view as first responder; this handled in the mode-switching code in the bookmarks-in-browser-window case.
  • FavoriteButton.m: (-[FavoriteButton buttonImageFromBookmark]): New method, extracted from setBookmark and updated to handle large folder icons (will probably be consolidated with [BookmarksController imageForBookmark:] soon) (-[FavoriteButton setBookmark:]): call buttonImageFromBookmark
12:01 PM Changeset in webkit [1953] by cblu
  • 18 edits in trunk/WebKit

WebKit:

  • Moved the default icon method to WebIconDatabase
  • Removed "icon URL" from the location change handler API
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem icon]): don't worry about iconForSiteURL:withSize: returning nil
  • Misc.subproj/WebIconDatabase.h:
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:]): return defaultIconWithSize if none found (-[WebIconDatabase defaultIconWithSize:]): added, loads, caches default icon (-[WebIconDatabase _hasIconForSiteURL:]): added, called by webdatasource to determine if icon is necessary
  • Misc.subproj/WebIconDatabasePrivate.h: added _hasIconForSiteURL
  • Misc.subproj/WebIconLoader.h: removed default icon method
  • Misc.subproj/WebIconLoader.m: removed default icon method
  • Resources/url_icon.tiff: resized to 32 x 32
  • WebKit.exp: export symbol for a dictionary key
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): call _hasIconForSiteURL
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): call defaultIconWithSize
  • WebView.subproj/WebLocationChangeHandler.h:
  • WebView.subproj/WebLocationChangeHandler.m: (-[WebLocationChangeHandler receivedPageIcon:forDataSource:]): renamed

WebBrowser:

  • Moved the default icon method to WebIconDatabase
  • Removed "icon URL" from the location change handler API
  • ABHomePagesController.m: (-[ABHomePagesController tableView:willDisplayCell:forTableColumn:row:]): call defaultIconWithSize
  • BrowserWindowController.m: (-[BrowserWindowController frameLoadCommitted:]): call defaultIconWithSize (-[BrowserWindowController setUpFavoritesBar]): call defaultIconWithSize
  • LocationChangeHandler.m: (-[LocationChangeHandler receivedPageIcon:forDataSource:]): renamed, don't use icon URL anymore
  • LocationTextField.m: (-[LocationTextField setDisplayAttributes]): call defaultIconWithSize (-[LocationTextField textDidChange:]): call defaultIconWithSize
  • RendezvousController.m: (-[RendezvousController _iconForServiceDictionary:]): call defaultIconWithSize
  • TitleBarButton.m: (-[TitleBarButton initWithFrame:]): call defaultIconWithSize
  • WebBrowser.pbproj/project.pbxproj:
9:50 AM Changeset in webkit [1952] by kocienda
  • 11 edits in trunk/WebKit

WebFoundation:

More work on WebFoundation refactoring. This change concentrates on two
major areas:

1) Cleaning up the WebResourceHandle class by separating out the methods

of this class into separate files based on method visibility.

2) Added a new WebResourceRequest class that serves to collect the

information about a load request instead of having this information
sprinkled through the WebResourceHandle class.

With this initial WebResourceRequest revision, there isn't very much extra or
different about the API or the way clients use WebFoundation. Further changes
are planned very soon. These upcoming changes and will modify and enhance the API.

Note that these changes, while they touch a lot of code, should not break any
functionality of the framework or of Alexander.

WebKit:

Modify calls into WebFoundation to use the new WebResourceRequest class,
and the modified API that kicks off load requests using WebResourceHandle.
More changes are planned for this code as the WebFoundation API modifications
progress.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:])
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad])
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:])
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:])
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:])
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:])

WebBrowser:

Small tweaks to use new WebFoundation WebResourceRequest object when requesting
the "original URL" for a load.

  • BrowserWebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]) (-[BrowserWebController receivedError:forResourceHandle:partialProgress:fromDataSource:])
  • WebBrowser.pbproj/project.pbxproj
9:30 AM Changeset in webkit [1951] by darin
  • 4 edits in trunk/WebKit

Fix a reproducible crash pulling down the Go menu.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): Add a missing retain.
  • WebKit.pbproj/project.pbxproj: Project Builder wants what it wants.

Sep 2, 2002:

11:28 PM Changeset in webkit [1950] by cblu
  • 8 edits
    3 adds in trunk/WebKit

WebKit:

First implementation of the icon DB.

  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem _retainIconInDatabase:]): calls retainIconForSiteURL: or releaseIconForSiteURL: (-[WebHistoryItem initWithURL:target:parent:title:]): call _retainIconInDatabase: (-[WebHistoryItem dealloc]): call _retainIconInDatabase: (-[WebHistoryItem icon]): call iconForSiteURL:withSize: (-[WebHistoryItem setURL:]): call _retainIconInDatabase: (-[WebHistoryItem initFromDictionaryRepresentation:]): call _retainIconInDatabase:
  • Misc.subproj/WebIconDatabase.h: Added.
  • Misc.subproj/WebIconDatabase.m: Added. (+[WebIconDatabase sharedIconDatabase]): (-[WebIconDatabase init]): (-[WebIconDatabase iconForSiteURL:withSize:]): (-[WebIconDatabase setIcon:forSiteURL:]): (-[WebIconDatabase setIcon:forHost:]): (-[WebIconDatabase retainIconForSiteURL:]): (-[WebIconDatabase releaseIconForSiteURL:]): (-[WebIconDatabase delayDatabaseCleanup]): (-[WebIconDatabase allowDatabaseCleanup]): (-[WebIconDatabase applicationWillTerminate:]): (-[WebIconDatabase _createFileDatabase]): (-[WebIconDatabase _loadIconDictionaries]): (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _iconForIconURL:]): (-[WebIconDatabase _iconsForIconURL:]): (-[WebIconDatabase _iconForFileURL:withSize:]): (-[WebIconDatabase _setIcon:forIconURL:]): (-[WebIconDatabase _setIconURL:forSiteURL:]): (-[WebIconDatabase _setBuiltInIcon:forHost:]): (-[WebIconDatabase _retainIconForIconURL:]): (-[WebIconDatabase _releaseIconForIconURL:]): (-[WebIconDatabase _retainFutureIconForSiteURL:]): (-[WebIconDatabase _releaseFutureIconForSiteURL:]): (-[WebIconDatabase _retainOriginalIconsOnDisk]): (-[WebIconDatabase _releaseOriginalIconsOnDisk]): (-[WebIconDatabase _sendNotificationForSiteURL:]): (-[WebIconDatabase _addObject:toSetForKey:inDictionary:]): (-[WebIconDatabase _uniqueIconURL]): (-[WebIconDatabase _cachedIconFromArray:withSize:]): (-[WebIconDatabase _scaleIcon:toSize:]):
  • Misc.subproj/WebIconDatabasePrivate.h: Added.
  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m: (+[WebIconLoader iconForFileAtPath:]): (-[WebIconLoader startLoading]): (-[WebIconLoader handleDidFinishLoading:data:]):
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]):

WebBrowser:

Start using the icon DB.

  • AppController.m: (-[AppController _installBuiltItIcons]): (-[AppController awakeFromNib]): call _installBuiltItIcons, there might be a better place for this.
  • LocationChangeHandler.m: (-[LocationChangeHandler receivedPageIcon:fromURL:forDataSource:]): use the icon db instead of the passed icon
  • WebBrowser.pbproj/project.pbxproj:
4:35 PM Changeset in webkit [1949] by hyatt
  • 4 edits in trunk/WebCore

Tweak the damage rect testing to account for the fact that a child
layer may fall entirely outside the bounds of its parent layer.

  • khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):

Aug 31, 2002:

9:44 AM Changeset in webkit [1948] by darin
  • 7 edits in trunk/WebCore
  • fixed 3038336 -- repro crash in QTextDecoder trying to display UTF-16 file
  • kwq/mac-encodings.txt: Hook up the UTF-16 encoding to the name iso-10646-ucs-2. We have a long way to go to get this right. There are almost certainly going to be other bugs with 16-bit character pages.
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::encoding): Just return "latin1", not "NSISOLatin1StringEncoding".
  • kwq/KWQString.mm: (QString::fromStringWithEncoding): Pass true for the "pay attention to BOM" flag.
  • khtml/rendering/render_object.cpp: Take out unneeded APPLE_CHANGES.

Aug 30, 2002:

2:52 PM Changeset in webkit [1947] by kocienda
  • 4 edits in trunk/WebKit

Removed one last reference to the now-removed WebDefaultMIMEType symbol.
I missed it earlier.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:])
2:24 PM Changeset in webkit [1946] by kocienda
  • 5 edits in trunk/WebCore

Fixed a problem in this function where broken UTF-8 would cause a crash.

  • WebCore.pbproj/project.pbxproj:
  • kwq/KWQString.mm: (QString::fromStringWithEncoding)
1:13 PM Changeset in webkit [1945] by kocienda
  • 5 edits in trunk/WebKit

WebFoundation:

Failed to remove debugging spam before my last checkin. Sorry.

  • CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle contentType])
  • CacheLoader.subproj/WebResourceLoadManager.m: (-[WebResourceLoadManager requestWithURLHandle:])
  • Misc.subproj/WebFileTypeMappings.m: (-[WebFileTypeMappings MIMETypeForExtension:])

WebKit:

Failed to remove debugging spam before my last checkin. Sorry.

  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebControllerPrivate.m: (+[WebController _MIMETypeForFile:])
1:08 PM Changeset in webkit [1944] by kocienda
  • 4 edits in trunk/WebKit

WebFoundation:

Begin to refactor WebFoundation in preparation for some planned API changes.
This change removes all WebResourceHandle subclasses, pushing the functionality
that was contained in those classes to the corresponding WebProtocolHandler
subclasses. To make this work, I also did a small amount of mime type cleanup, and
as a bonus, I (unintentionally) managed to fix these two bugs:

Radar 3034795 (README fiel displays as HTML even though it's plain text)
Radar 3035320 (iana.org character sets page displays as HTML even though it's MIME type text/plain)

Bonus! :-)

Removed:

  • CacheLoader.subproj/WebAboutResource.h
  • CacheLoader.subproj/WebAboutResource.m
  • CacheLoader.subproj/WebFileResourceHandle.h
  • CacheLoader.subproj/WebFileResourceHandle.m
  • CacheLoader.subproj/WebHTTPResourceHandle.h
  • CacheLoader.subproj/WebHTTPResourceHandle.m

WebKit:

  • WebView.subproj/WebControllerPrivate.m: (+[WebController _MIMETypeForFile:]): Small tweak to account for change in behavior of a WebFoundation method upon which this method depends. The WebFoundation now returns nil when it cannot find a suitable mime type rather than returning a default. This function now checks for a nil return value and sets @"application/octet-stream" in that case.
12:03 PM Changeset in webkit [1943] by rjw
  • 1 edit in trunk/WebCore/force-clean-timestamp

Force clean for decoder.h buffer class change.

11:51 AM Changeset in webkit [1942] by rjw
  • 4 edits in trunk/WebCore

Removed debugging log.

  • kwq/KWQString.mm: (QString::fromStringWithEncoding):
11:45 AM Changeset in webkit [1941] by rjw
  • 9 edits in trunk

Made decoder more robust wrt nulls in content. Changed use
of QCString to null safe QString rather than modify
content.

  • khtml/misc/decoder.cpp: (Decoder::decode): (Decoder::flush):
  • khtml/misc/decoder.h:
  • kwq/KWQString.mm: (QString::fromStringWithEncoding):

Change link dragging behavior. Drags URL, not URL contents.
Still need to generate better image for dragging, will copy OmniWeb
and drag link text.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):
10:50 AM Changeset in webkit [1940] by darin
  • 17 edits in trunk/WebCore
  • fixed 3027407 -- Console error refers to closed bug
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Update bug number from 2959902 to 2942073.
  • fixed 3027532 -- can't tab into or out of textareas
  • kwq/KWQTextArea.h: Add setFont:.
  • kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Make a KWQTextAreaTextView. (-[KWQTextArea textDidChange:]): Send text changed messages when the text is changed, not when done editing. I did this for KWQNSTextField a while ago; it's tragic that AppKit leads us to have two separate classes for these nearly identical purposes. (-[KWQTextArea setFont:]): Call setFont on the text view. (-[KWQTextArea becomeFirstResponder]): Call makeFirstResponder on the text view. (-[KWQTextArea nextKeyView]): Do that voodoo, just like KWQNSTextField. (-[KWQTextArea previousKeyView]): Ditto. (-[KWQTextArea nextValidKeyView]): Ditto. (-[KWQTextArea previousValidKeyView]): Ditto. (-[KWQTextAreaTextView insertTab:]): Select the next key view. We don't get this automatically because this is not a field editor. But being a field editor leads to other unwanted behavior. (-[KWQTextAreaTextView insertBacktab:]): Ditto. (-[KWQTextAreaTextView becomeFirstResponder]): Select all on entry. (-[KWQTextAreaTextView shouldDrawInsertionPoint]): Don't draw insertion point when we are not the first responder. (-[KWQTextAreaTextView selectedTextAttributes]): Don't draw the selection when we are not the first responder.
  • kwq/qt/qtextedit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setFont): Call -[KWQTextArea setFont:]. (QTextEdit::focusPolicy): Always return TabFocus, because the top level widget is not an NSControl so QWidget::focusPolicy does not suffice.
  • kwq/qt/qwidget.h: Make focusPolicy virtual.
  • kwq/qt/qfont.h:
  • kwq/KWQFont.mm: (QFont::getNSFont): Add this helper function so we don't have to repeat this in multiple places.
  • kwq/KWQLineEdit.mm: (QLineEdit::setFont): Use QFont::getNSFont.
  • force-clean-timestamp: For you poor bastards who aren't using the new Project Builder yet.
10:21 AM Changeset in webkit [1939] by darin
  • 11 edits in trunk

JavaScriptCore:

  • JavaScriptCore.pbproj/project.pbxproj: Allowed the new Project Builder to put in encodings for each file.

WebFoundation:

  • WebFoundation.pbproj/project.pbxproj: Allowed the new Project Builder to put in encodings for each file.

WebCore:

  • WebCore.pbproj/project.pbxproj: Allowed the new Project Builder to put in encodings for each file.

WebKit:

  • WebKit.pbproj/project.pbxproj: Allowed the new Project Builder to put in encodings for each file.

WebBrowser:

  • WebBrowser.pbproj/project.pbxproj: Allowed the new Project Builder to put in encodings for each file.
Note: See TracTimeline for information about the timeline view.