Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Sep 8, 2002:

11:25 PM Changeset in webkit [2002] by darin

• 4 edits in trunk/WebKit

WebFoundation:

• Misc.subproj/WebAssertions.h: Use 0 instead of undefined for the XXX_DISABLED macros to be more consistent with the case where they are explicitly defined on purpose.

• CacheLoader.subproj/WebHTTPProtocolHandler.m: Use #if ! rather than #ifndef with LOG_DISABLED, since it is set to 0 rather than not defined when LOG is enabled.

• CacheLoader.subproj/WebResourceLoad.m: Same, but for ERROR, rather than LOG.

WebKit:

• Plugins.subproj/WebPluginStream.m:
• Plugins.subproj/WebPluginView.m: Use #if ! rather than #ifndef with LOG_DISABLED, since it is set to 0 rather than not defined when LOG is enabled.

WebBrowser:

• BookmarksController.m:
• GlobalHistory.m: Use #if ! rather than #ifndef with LOG_DISABLED, since it is set to 0 rather than not defined when LOG is enabled.

11:11 PM Changeset in webkit [2001] by darin

• 65 edits
  4 adds
  2 deletes in trunk/WebCore

Tools:

• Scripts/update-kwq-assert: Added. Script to keep the KWQ version of the assert macros in sync. with the WebFoundation version. Just update the WebFoundation one and run this script.

• wftool/WFTool.m: Remove obsolete include.

WebCore:

Switch over to new assertion/logging scheme.

• kwq/KWQAssertions.h: Added.
• kwq/KWQAssertions.m: Added.
• kwq/KWQLogging.h: Added.
• kwq/KWQLogging.m: Added.
• kwq/kwqdebug.h: Removed.
• kwq/kwqdebug.mm: Removed.
• WebCore.pbproj/project.pbxproj: Update to reflect above changes.

• kwq/KWQApplication.mm:
• kwq/KWQChar.mm:
• kwq/KWQColor.mm:
• kwq/KWQComboBox.mm:
• kwq/KWQCompletion.mm:
• kwq/KWQCursor.mm:
• kwq/KWQDrawUtil.mm:
• kwq/KWQEvent.mm:
• kwq/KWQFontInfo.mm:
• kwq/KWQFontMetrics.mm:
• kwq/KWQFrame.mm:
• kwq/KWQHBox.mm:
• kwq/KWQInputDialog.mm:
• kwq/KWQInvisibleButton.mm:
• kwq/KWQKConfigBase.mm:
• kwq/KWQKFileDialog.mm:
• kwq/KWQKFileItem.mm:
• kwq/KWQKGlobalSettings.mm:
• kwq/KWQKHTMLPartImpl.mm:
• kwq/KWQKHTMLSettings.mm:
• kwq/KWQKIconLoader.mm:
• kwq/KWQKJob.mm:
• kwq/KWQKLocale.mm:
• kwq/KWQKMimeType.mm:
• kwq/KWQKPartsEvent.mm:
• kwq/KWQKSimpleConfig.mm:
• kwq/KWQKURL.mm:
• kwq/KWQKWin.mm:
• kwq/KWQKWinModule.mm:
• kwq/KWQKjobclasses.mm:
• kwq/KWQKnetaccess.mm:
• kwq/KWQLabel.mm:
• kwq/KWQLineEdit.mm:
• kwq/KWQListBox.mm:
• kwq/KWQListImpl.mm:
• kwq/KWQLoaderImpl.mm:
• kwq/KWQObject.mm:
• kwq/KWQPaintDeviceMetrics.mm:
• kwq/KWQPainter.mm:
• kwq/KWQPixmap.mm:
• kwq/KWQRegion.mm:
• kwq/KWQScrollView.mm:
• kwq/KWQSlot.mm:
• kwq/KWQString.mm:
• kwq/KWQTimer.mm:
• kwq/KWQWidget.mm:
• kwq/KWQbrowserinterface.mm:
• kwq/KWQtextcodec.mm:
• kwq/KWQtextstream.mm:
• kwq/KWQxml.mm:
• kwq/WebCoreBridge.mm:
• kwq/WebCoreCookieAdapter.m:
• kwq/WebCoreHistory.m:
• kwq/WebCoreImageRendererFactory.m:
• kwq/WebCoreTextRendererFactory.m:
• kwq/WebCoreViewFactory.m: Update to use new assertions and logging macros. In some cases, just removed unneeded includes.

11:06 PM Changeset in webkit [2000] by darin

• 19 edits in trunk/WebKit

• Bookmarks.subproj/WebBookmarkGroup.m:
• History.subproj/WebHistoryPrivate.m:
• History.subproj/WebURLsWithTitles.m:
• Misc.subproj/WebDownloadHandler.m:
• Misc.subproj/WebIconDatabase.m:
• Misc.subproj/WebIconLoader.m:
• WebView.subproj/WebController.m:
• WebView.subproj/WebDataSourcePrivate.m:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebHTMLViewPrivate.m:
• WebView.subproj/WebMainResourceClient.m:
• WebView.subproj/WebPreferences.m:
• WebView.subproj/WebViewPrivate.m: Remove unnecessary includes.

11:04 PM Changeset in webkit [1999] by darin

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m:
• CacheLoader.subproj/WebCacheObject.m:
• CacheLoader.subproj/WebDiskCache.m:
• CacheLoader.subproj/WebHTTPProtocolHandler.m:
• CacheLoader.subproj/WebMemoryCache.m:
• CacheLoader.subproj/WebResourceHandle.m:
• CacheLoader.subproj/WebResourceHandleInternal.m:
• CacheLoader.subproj/WebResourceHandlePrivate.m:
• CacheLoader.subproj/WebResourceLoad.m:
• CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m:
• CookieManager.subproj/WebCookie.m:
• CookieManager.subproj/WebCookieManager.m:
• CookieManager.subproj/WebCookieStorage.m:
• Database.subproj/WebFileDatabase.m:
• Misc.subproj/WebBinaryHeap.m:
• Misc.subproj/WebReadWriteLock.m:
• Misc.subproj/WebRecursiveReadWriteLock.m: Remove some unnecessary includes.

• CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.h: Removed.
• CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.m: Removed.
• CacheLoader.subproj/WebHTTPResourceLoader.h: Removed.
• CacheLoader.subproj/WebHTTPResourceLoader.m: Removed. Removed these files. The ChangeLog says they were removed a long time ago, but cvs doesn't agree.

5:22 PM Changeset in webkit [1998] by darin

• 22 edits
  2 adds
  3 deletes in trunk/WebKit

Update logging to use new implementation. Remove old.

• Misc.subproj/WebKitDebug.h: Removed.
• Misc.subproj/WebKitDebug.m: Removed.
• Misc.subproj/WebKitLogging.h: Added.
• Misc.subproj/WebKitLogging.m: Added.
• Misc.subproj/WebKitReallyPrivate.h: Removed.
• WebKit.pbproj/project.pbxproj: Update for above changes.

• WebKit-tests.exp: Now empty.

• History.subproj/WebHistoryItem.m: Remove unneeded include.

• Bookmarks.subproj/WebBookmarkGroup.m:
• History.subproj/WebHistoryPrivate.m:
• Misc.subproj/WebDownloadHandler.m:
• Misc.subproj/WebIconDatabase.m:
• Plugins.subproj/WebPlugin.m:
• Plugins.subproj/WebPluginDatabase.m:
• Plugins.subproj/WebPluginNullEventSender.m:
• Plugins.subproj/WebPluginStream.m:
• Plugins.subproj/WebPluginView.m:
• Plugins.subproj/npapi.m:
• WebCoreSupport.subproj/WebTextRenderer.m:
• WebView.subproj/WebDataSourcePrivate.m:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebMainResourceClient.m: Change to use new log channels.

4:18 PM Changeset in webkit [1997] by darin

• 8 edits in trunk/WebKit

top level:

• Tests/WebFoundationC/ifurlhandlec-test.c: (run): Remove begin and cancel testing.

WebKit:

Remove empty handleDidBeginLoading and handleDidCancelLoading
methods, now that they will never be called.

• Misc.subproj/WebIconLoader.m:
• Plugins.subproj/WebPluginStream.m:
• WebCoreSupport.subproj/WebSubresourceClient.m:
• WebView.subproj/WebMainResourceClient.m:

4:07 PM Changeset in webkit [1996] by darin

• 5 edits in trunk/WebKit

Forgot to save out files from the editor in my last change.

• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: Oops.

3:53 PM Changeset in webkit [1995] by darin

• 11 edits in trunk/WebKit

Finished weaning us from handleDidCancelLoading. Now I will remove both
handleDidBeginLoading and handleDidCancelLoading.

• WebCoreSupport.subproj/WebSubresourceClient.h: Add a handle method.
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidCancelLoading:]): Remove guts, move to cancel. (-[WebSubresourceClient handleDidFinishLoading:]): Remove the client from the data source now, not the handle. (-[WebSubresourceClient handleDidFailLoading:withError:]): Ditto. (-[WebSubresourceClient cancel]): Move guts here, also make the above change. (-[WebSubresourceClient handle]): Added.

• WebView.subproj/WebDataSource.m: Use clients list, not handles list.
• WebView.subproj/WebDataSourcePrivate.h: Keep a list of subresource clients rather than a list of handles for the subresources.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Update to match new field names. (-[WebDataSource _updateLoading]): Use clients, not handles. (-[WebDataSource _startLoading:]): Move line about starting loading out of the if statement. I suspect the if statement is always true, though. (-[WebDataSource _addSubresourceClient:]): New name. Keep client pointer instead of handle now. (-[WebDataSource _removeSubresourceClient:]): Ditto. (-[WebDataSource _stopLoading]): Move download handler line into WebMainResourceClient since the "not sent when application is quitting" issue is gone now. Stop the subresource clients using the cancel call, not by cancelling the handle directly. (-[WebDataSource _defersCallbacksChanged]): Update for clients list, not handles list.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Cancel the download handler here. (-[WebMainResourceClient handleDidReceiveData:data:]): Call didCancelWithHandle here. A loose end from the previous change.

2:48 AM Changeset in webkit [1994] by hyatt

• 20 edits in trunk/WebCore

Landing the new layer system and turning it on for painting of
all types of positioned blocks (and for painting the root
and HTML layers as well).

Event handling is not yet using the new layer system, so you
may see oddities like DHTML menus now displaying correctly but
events not working (since the event code may still be stacking
incorrectly and think the DHTML is behind other content).

• khtml/css/cssstyleselector.cpp:
• khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::calcHeight): (RenderBox::calcAbsoluteHorizontal):
• khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode):
• khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): (RenderFlow::printObject): (RenderFlow::printSpecialObjects): (RenderFlow::layout): (RenderFlow::layoutSpecialObjects): (RenderFlow::layoutBlockChildren): (RenderFlow::insertSpecialObject):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_html.cpp: (RenderHtml::layout):
• khtml/rendering/render_image.cpp: (RenderImage::printObject):
• khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition): (RenderLayer::enclosingAncestor): (RenderLayer::addChild): (RenderLayer::convertToLayerCoords): (RenderLayer::paint): (RenderLayer::constructZTree): (RenderLayer::RenderZTreeNode::constructLayerList):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_replaced.cpp: (RenderReplaced::print): (RenderWidget::printObject):
• khtml/rendering/render_root.cpp: (RenderRoot::calcHeight): (RenderRoot::layout): (RenderRoot::printObject):
• khtml/rendering/render_root.h:
• khtml/rendering/render_style.cpp: (StyleBoxData::StyleBoxData): (StyleBoxData::operator==):
• khtml/rendering/render_style.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
• kwq/qt/qrect.h:

Sep 7, 2002:

4:55 PM Changeset in webkit [1993] by cblu

• 3 edits in trunk/WebKit

WebKit:

Made the wizzy scaling an experiment.

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconByScalingIcon:toSize:]):

WebBrowser:

• Text field/location bar combo
• Added a defaults key "Experiments" as a way to toggle experimental features, behaviors etc.
• Added an "Experiments" debug menu item. Vague, but couldn't think of a better title.
• The text field/location bar combo is an "Experiment".

"Experiments" is off by default.

• AppController.m: (-[AppController enableExperiments:]): toggle the default
• BrowserWindowController.h:
• BrowserWindowController.m: (-[BrowserWindowController setActivity:]): set _previousActivity so we know if we were searching or loading (-[BrowserWindowController textFieldToUpdateProgress]): added, returns the current text field that is showing a progress bar (-[BrowserWindowController setProgressBarValue:]): added, calls setProgressBarValue on current text field (-[BrowserWindowController incrementProgressBarBy:]): added, calls incrementProgressBarBy on current text field
• Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]):
• LoadProgressMonitor.h:
• LoadProgressMonitor.m: (-[LoadProgressMonitor initWithBrowserDocument:]): set _maxIncrement to the default (-[LoadProgressMonitor _setProgressBarValueToZero]): added (-[LoadProgressMonitor _stopProgressBar]): added (-[LoadProgressMonitor _incrementProgressBarWithProgress:previousProgress:isFrame:]): added, progress algorithm here (-[LoadProgressMonitor monitorResource:withProgress:error:dataSource:]): call _incrementProgressBarWithProgress:previousProgress:isFrame: (-[LoadProgressMonitor finishedLoadingFrame:]): call _stopProgressBar
• LocationTextField.m: (-[LocationTextField setDisplayAttributes]): set progress images
• PreferenceKeys.h:
• Resources/Images/Location_Left_Progress.tif: Added.
• Resources/Images/Location_Middle_Progress.tif: Added.
• Resources/Images/Location_Right_Progress.tif: Added.
• Resources/Images/Search_Left_Progress.tif: Added.
• Resources/Images/Search_Middle_Progress.tif: Added.
• Resources/Images/Search_Right_Progress.tif: Added.
• SearchTextField.m: (-[SearchTextField setDisplayAttributes]): set progress images
• TextFieldWithControls.h:
• TextFieldWithControls.m: (-[TextFieldWithControls becomeFirstResponder]): call setIsShowingProgressBar:NO (-[TextFieldWithControls textDidEndEditing:]): call setIsShowingProgressBar:YES (-[TextFieldWithControls dealloc]): release progress images (-[TextFieldWithControls backgroundImage]): added logic for showing progress bar (-[TextFieldWithControls setLeftProgressImage:]): added (-[TextFieldWithControls setRightProgressImage:]): added (-[TextFieldWithControls setMiddleProgressImage:]): added (-[TextFieldWithControls isShowingProgressBar]): added (-[TextFieldWithControls setIsShowingProgressBar:]): added (-[TextFieldWithControls setProgressBarValue:]): added (-[TextFieldWithControls incrementProgressBarBy:]): added
• WebBrowser.pbproj/project.pbxproj:

Sep 6, 2002:

6:06 PM Changeset in webkit [1992] by mjs

• 4 edits in trunk/WebCore

Fix another instance of the same problem:

• kwq/KWQString.mm: (QString::detach):

6:04 PM Changeset in webkit [1991] by mjs

• 4 edits in trunk/WebCore

Fix optimized build:

• kwq/KWQString.mm: (QString::detachInternal): Uselessly Initialize newData to NULL since the compiler can't tell that FATAL won't return.

5:45 PM Changeset in webkit [1990] by darin

• 29 edits in trunk

WebCore:

• kwq/WebCoreResourceLoader.h: Define WebCoreResourceHandle protocol.

• kwq/kio/jobclasses.h:
• kwq/KWQKjobclasses.mm:
• kwq/KWQLoaderImpl.mm: (KWQServeRequest):
• kwq/WebCoreBridge.h: Use WebCoreResourceHandle instead of WebResourceHandle.

• kwq/KWQString.mm: (QString::fill): Fix case where the new string is going to be empty, but the old string was not. Before, it leaked a handle.

• kwq/character-sets.txt: Updated to 2002-06-14 version from 2001-08-23 version.
• kwq/mac-encodings.txt: Updated encoding names to include ones gleaned from the I18N-Charset-1.17 Perl module.

• kwq/KWQCharsets.mm: Formatting tweaks.

WebKit:

Almost weaned WebKit entirely from the handleDidBeginLoading and handleDidCancelLoading
loading callbacks. We are planning to remove both of them.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad]): Call _didStartLoading here so we don't need to rely on handleDidBeginLoading any more. (-[WebNetscapePluginStream stop]): Call cancel here so we don't need to rely on handleDidCancelLoading any more. (-[WebNetscapePluginStream handleDidBeginLoading:]): Empty out. (-[WebNetscapePluginStream handleDidFinishLoading:]): Nil out resource here. (-[WebNetscapePluginStream handleDidCancelLoading:]): Empty out. (-[WebNetscapePluginStream cancel]): Put cancel code here. (-[WebNetscapePluginStream handleDidFailLoading:withError:]): Nil out resource here.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:]): Change to use WebCoreResourceHandle.

• WebCoreSupport.subproj/WebSubresourceClient.h: Change to use WebCoreResourceHandle.
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient dealloc]): Release handle too, now that we have it. (-[WebSubresourceClient receivedProgressWithComplete:]): Moved up here and removed handle parameter. (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]): Do work here so we don't need to rely on handleDidBeginLoading any more. (-[WebSubresourceClient receivedError:]): Removed handle parameter. (-[WebSubresourceClient handleWillUseUserAgent:forURL:]): (-[WebSubresourceClient handleDidBeginLoading:]): Emptied out. (-[WebSubresourceClient handleDidCancelLoading:]): Updated, still needs to be emptied out. (-[WebSubresourceClient handleDidFinishLoading:]): Nil out handle. (-[WebSubresourceClient handleDidFailLoading:withError:]): Nil out handle. (-[WebSubresourceClient cancel]): New method, used by WebCore.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer widthForCharacters:length:]): Moved up in the file to fix build failure.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): Call didStartLoadingWithURL so we don't have to rely on handleDidBeginLoading. (-[WebDataSource _stopLoading]): Call didCancelWithHandle so we don't have to rely on handleDidCancelLoading.

• WebView.subproj/WebMainResourceClient.h: Add didStartLoadingWithURL and didCancelWithHandle to the public methods.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient handleDidBeginLoading:]): Empty out. (-[WebMainResourceClient didCancelWithHandle:]): Move the bulk of handleDidCancelLoading here. (-[WebMainResourceClient handleDidCancelLoading:]): Empty out.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Move the mouse up a little bit so it's "on" the dragged area, but not over the text.

4:22 PM Changeset in webkit [1989] by rjw

• 13 edits in trunk

Added support for khtml's justified text drawing. Additional padding is distributed
to space widths. (Sites like www.osnews.com now render correctly.)

Change word end rounding hack to use ceil of word width. I'm still noticing a spacing anomaly
that is fixed by a reload. Occasionally text runs are still crammed together, but a reload uses
correct spacing. This anomaly is often visible on www.arstechnica.com. Still investigating.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer slowDrawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:attemptFontSubstitution:]): (-[WebTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):

Tweaks to dragged image.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

Start using khtml's 'toAdd' parameter to justify text.

• khtml/rendering/font.cpp: (Font::drawText):

Normalize all calls to get width to minimize use of
ObjC. Will make it easier to use IMPL cache later.

• kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidth):

Pass additional 'toAdd' parameter.

• kwq/KWQPainter.mm: (QPainter::drawText):
• kwq/qt/qpainter.h:

Remove methods now that width calls are normalized to single
method.

• kwq/WebCoreTextRenderer.h:

4:12 PM Changeset in webkit [1988]

• 4 copies in tags/Alexander-22~1

This commit was manufactured by cvs2svn to create tag
'Alexander-22~1'.

4:12 PM Changeset in webkit [1987] by rjw

• 3 edits in trunk/WebKit

Fixed symbol lookup problem. NSLookupAndBindSymbol() dies horribly
if symbol is missing. Use NSIsSymbolNameDefined() first to check if
symbol is present.

• WebCoreSupport.subproj/WebTextRendererFactory.m:

3:56 PM Changeset in webkit [1986] by darin

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Leak fixes and other related changes.

• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables prepareCallbacks]): Retain the callbackData to give it a more normal lifetime. (-[WebResourceHandleInstanceVariables dealloc]): Release response to fix a leak, and callbackData to match the change above. (-[WebResourceHandle _sendCallbacks]): Handle fail in a way that is parallel to finish, rather than parallel to cancel. And put the rule about not delivering any more callbacks after the end state at this level instead of in each function. (-[WebResourceHandle _notifyClientDidBeginLoading]): Remove unnecessary locking. (-[WebResourceHandle _notifyClientDidCancelLoading]): Ditto. (-[WebResourceHandle _notifyClientDidRedirectToURL]): Ditto. (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]): Ditto. (-[WebResourceHandle _notifyClientDidFailLoading]): Ditto. (-[WebResourceHandle _notifyClientDidFinishLoading]): Ditto.
• CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler dealloc]): Release responseDataGuard to fix a leak.

• Misc.subproj/WebQueue.m: (-[WebQueue take]): Rewrite the wait loop for clarity. Add code to update tail when taking the last element from the queue; fixes a bug. (-[WebQueue remove:]): Add code to update tail when removing the last element.

• CacheLoader.subproj/WebResourceLoadQueue.m: -[WebResourceLoadQueue put:]): Tweak.

• CacheLoader.subproj/WebResourceLoad.m: (_loadBegin): Add an autorelease pool. (_loadSweeper): Add an autorelease pool.

• Database.subproj/WebFileDatabase.m: (-[WebFileDatabaseOp initWithCode:key:object:]): Remove unneeded release of nil. (-[WebFileDatabase objectForKey:]): Tweak and remove an unnecessary "volatile".

• Misc.subproj/WebSystemBits.m: (WebSetThreadPriority): Use FATAL instead of printf.

1:34 PM Changeset in webkit [1985] by darin

• 8 edits in trunk/WebKit

Fix some minor anomalies and leaks.

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURL:target:parent:title:]): Use copy, not retain. (-[WebHistoryItem dealloc]): Release the anchor, fix leak. (-[WebHistoryItem setURL:]): Check for URLs that are equal, not just ==. (-[WebHistoryItem setTitle:]): Copy, not retain. (-[WebHistoryItem setTarget:]): Copy, not retain. (-[WebHistoryItem setParent:]): Copy, not retain. (-[WebHistoryItem setDisplayTitle:]): Copy, not retain. (-[WebHistoryItem setAnchor:]): Copy, not retain.
• WebView.subproj/WebControllerPolicyHandler.m: (-[WebPolicyPrivate dealloc]): Release the URL, call super, fix leaks. (-[WebPolicy _setPath:]): Use copy, not retain.
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Release downloadProgressHandler, contextMenuHandler, locationChangeHandler, fix leaks.

Some fun with Richard's new code.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Center image around mouse instead of putting it up and to the right. Add more X space than Y space.

1:21 PM Changeset in webkit [1984] by rjw

• 5 edits in trunk/WebKit

i * WebView.subproj/WebHTMLView.m:

(-[WebHTMLView mouseDragged:]):

More fun and games with dragged links.
Draw both a label and url (in a smaller font)
into the dragged image.

• Misc.subproj/WebStringTruncator.h:
• Misc.subproj/WebStringTruncator.m: (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):

Added right string truncator. Not optimized, but not used
very often. Currently just for dragged link experiment.

11:57 AM Changeset in webkit [1983]

• 3 copies in tags/Alexander-22

This commit was manufactured by cvs2svn to create tag 'Alexander-22'.

11:57 AM Changeset in webkit [1982] by sheridan

• 8 edits in trunk

Alex-22 markers & version

7:17 AM Changeset in webkit [1981] by kocienda

• 3 edits in trunk/WebKit

Declaration and initialization of variable on one line caused unused variable
warning when building under deployment since the only use of the variable was
in a debug statement.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedError:])

Sep 5, 2002:

11:15 PM Changeset in webkit [1980] by darin

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Change all logging to use the new logging.

• Misc.subproj/WebAssertions.h: Add real definition of WebLogChannel.
• Misc.subproj/WebAssertions.m: (WebLog): Implement.

• Misc.subproj/WebFoundationDebug.h: Removed.
• Misc.subproj/WebFoundationDebug.m: Removed.
• Misc.subproj/WebFoundationLogging.h: Added.
• Misc.subproj/WebFoundationLogging.m: Added.
• Misc.subproj/WebFoundationPrivate.h: Removed WebFoundationDebug.h.
• WebFoundation.pbproj/project.pbxproj: Removed and added files.

• AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m:
• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m:
• CacheLoader.subproj/WebCacheObject.m:
• CacheLoader.subproj/WebDiskCache.m:
• CacheLoader.subproj/WebFileProtocolHandler.m:
• CacheLoader.subproj/WebHTTPProtocolHandler.m:
• CacheLoader.subproj/WebMemoryCache.m:
• CacheLoader.subproj/WebProtocolHandler.m:
• CacheLoader.subproj/WebResourceData.m:
• CacheLoader.subproj/WebResourceHandle.m:
• CacheLoader.subproj/WebResourceHandleInternal.m:
• CacheLoader.subproj/WebResourceHandlePrivate.m:
• CacheLoader.subproj/WebResourceLoad.m:
• CacheLoader.subproj/WebResourceLoadManager.m:
• CacheLoader.subproj/WebResourceLoadQueue.m:
• CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m:
• CookieManager.subproj/WebCookie.m:
• CookieManager.subproj/WebCookieAcceptHandlerDispatcher.m:
• CookieManager.subproj/WebCookieManager.m:
• CookieManager.subproj/WebCookieStorage.m:
• Database.subproj/WebFileDatabase.m:
• Misc.subproj/WebBinaryHeap.m:
• Misc.subproj/WebHostNameResolver.m:
• Misc.subproj/WebNSStringExtras.m:
• Misc.subproj/WebQueue.m:
• Misc.subproj/WebReadWriteLock.m:
• Misc.subproj/WebRecursiveReadWriteLock.m: Update to use new log macro.

8:10 PM Changeset in webkit [1979] by rjw

• 3 edits in trunk/WebKit

Experiment w/ dragging link label as drag image.
Needs some visual tweaking, but good concept, I think.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

7:29 PM Changeset in webkit [1978] by rjw

• 13 edits in trunk

Add the first child text node of the element to the
element dictionary. This will be used as a link 'label'.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

Use the first text child node of the link element
as the title for a dragged link. We'll use this for
the dragged image later too.

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):

6:22 PM Changeset in webkit [1977] by mjs

• 4 edits in trunk/JavaScriptCore

First baby step towards moving List away from garbage collection.

• kjs/types.h: Add needsMarking boolean and make List inherit from Value privately instead of publicly.

5:58 PM Changeset in webkit [1976] by rjw

• 3 edits in trunk/WebKit

Correctly save of document state in current
document when going back.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge saveDocumentState:]): (-[WebBridge documentState]):

5:11 PM Changeset in webkit [1975] by rjw

• 3 edits in trunk/WebKit

Fixed 3043505. Disallows drag drops on originating view.

• WebView.subproj/WebView.m: (-[WebView draggingEntered:]):

4:56 PM Changeset in webkit [1974] by darin

• 48 edits in trunk/WebKit

Update to use the new style of assertions.
A few places still use the WebKitDebug.h, for logging.

• Bookmarks.subproj/WebBookmark.m:
• Bookmarks.subproj/WebBookmarkGroup.m:
• Bookmarks.subproj/WebBookmarkLeaf.m:
• Bookmarks.subproj/WebBookmarkList.m:
• Bookmarks.subproj/WebBookmarkSeparator.m:
• History.subproj/WebHistory.m:
• History.subproj/WebHistoryList.m:
• History.subproj/WebHistoryPrivate.m:
• History.subproj/WebURLsWithTitles.m:
• Misc.subproj/WebDownloadHandler.m:
• Misc.subproj/WebIconDatabase.m:
• Misc.subproj/WebIconLoader.m:
• Misc.subproj/WebKitDebug.h:
• Misc.subproj/WebStringTruncator.m:
• Panels.subproj/WebAuthenticationPanel.m:
• Plugins.subproj/WebPlugin.m:
• Plugins.subproj/WebPluginDatabase.m:
• Plugins.subproj/WebPluginNullEventSender.m:
• Plugins.subproj/WebPluginStream.m:
• Plugins.subproj/WebPluginView.m:
• Plugins.subproj/npapi.m:
• WebCoreSupport.subproj/WebBridge.m:
• WebCoreSupport.subproj/WebCookieAdapter.m:
• WebCoreSupport.subproj/WebImageRenderer.m:
• WebCoreSupport.subproj/WebImageRendererFactory.m:
• WebCoreSupport.subproj/WebSubresourceClient.m:
• WebCoreSupport.subproj/WebTextRenderer.m:
• WebCoreSupport.subproj/WebTextRendererFactory.m:
• WebCoreSupport.subproj/WebViewFactory.m:
• WebView.subproj/WebController.m:
• WebView.subproj/WebControllerPrivate.m:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.m:
• WebView.subproj/WebDefaultPolicyHandler.m:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebHTMLViewPrivate.m:
• WebView.subproj/WebMainResourceClient.m:
• WebView.subproj/WebPreferences.m:
• WebView.subproj/WebViewPrivate.m: Use new assertions.

4:35 PM Changeset in webkit [1973] by rjw

• 7 edits in trunk

Removed debugging.

• khtml/khtml_part.cpp: (KHTMLPart::closeURL):

Removed debugging.

• History.subproj/WebBackForwardList.m: (-[WebBackForwardList addEntry:]):

4:18 PM Changeset in webkit [1972] by rjw

• 19 edits in trunk

Added support for saving/restoring document state
in back/forward list.

• History.subproj/WebBackForwardList.m: (-[WebBackForwardList addEntry:]):
• History.subproj/WebHistoryItem.h:
• History.subproj/WebHistoryItem.m: (-[WebHistoryItem dealloc]): (-[WebHistoryItem setLastVisitedDate:]): (-[WebHistoryItem documentState]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge saveDocumentState:]): (-[WebBridge documentState]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]):

Lookup post Jaguar CG SPI. Can now run and build
w/o patched CG.

• WebCoreSupport.subproj/WebTextRendererFactory.m:

Changed image links to drag file contents.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

Always call KHTMLPart::closeURL when a new document is loaded.

Added support for saving and restoring document state in
the back/forward list. Document state includes form data.

• khtml/khtml_part.cpp: (KHTMLPart::openURL): (KHTMLPart::closeURL): (KHTMLPart::begin):
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::saveDocumentState): (KWQKHTMLPartImpl::restoreDocumentState):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentState]): (-[WebCoreBridge restoreDocumentState]):

2:04 PM Changeset in webkit [1971] by kocienda

• 6 edits in trunk/WebKit

WebFoundation:

Another change likes the ones I have been doing.

This time the WebError object has been removed from WebResourceHandle and WebResourceLoad.
They now rely on the WebError object in WebResourceResponse. All WebFoundation code
has been updated accordingly.

• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode) (IFURLHandleGetError)
• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler continueHeaderReadAfterFailureResponseAndCall:])
• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m:
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _notifyClientDidFailLoading])
• CacheLoader.subproj/WebResourceHandlePrivate.h:
• CacheLoader.subproj/WebResourceHandlePrivate.m:
• CacheLoader.subproj/WebResourceLoad.h:
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad succeeded]) (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:isTerminal:]) (-[WebResourceLoad dealloc])
• CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _examineHeaders])

WebKit:

The WebError object has been removed from WebResourceHandle.
Objects of that class now rely on the WebError object in WebResourceResponse.

This code has been updated to ask WebResourceResponse for it WebError object,
rather than asking WebResourceHandle.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:])
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:])

1:38 PM Changeset in webkit [1970] by cblu

• 4 edits in trunk/WebKit

Fixed 3021365 - Crash failing to load plugin from local file

• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:withHandle:]): (-[WebNetscapePluginStream receivedError:]): (-[WebNetscapePluginStream receivedData:withDataSource:]): (-[WebNetscapePluginStream handleDidReceiveData:data:]):

12:39 PM Changeset in webkit [1969] by kocienda

• 7 edits in trunk/WebKit

WebFoundation:

The first use of the WebResourceResponse object. This is just a baby step, though.
I only use one variable in the new class, the statusCode, but all the code in
the framework has been updated to use the statusCode from the response object.
All other references to status codes, be they in WebResourceHandle, or
WebResourceLoad, have been eliminated. More changes like this, where I rely
more and more on WebResourceResponse are to come.

• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleGetStatusCode): Call through to response object to get status code.
• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: Ditto. (-[WebCFNetworkHTTPProtocolHandler continueAfterBytesAvailable]):Ditto. (-[WebCFNetworkHTTPProtocolHandler handleReadStreamEvent:event:]):Ditto.
• CacheLoader.subproj/WebResourceHandle.h: Added accessor for WebResourceResponse ivar.
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle cancelLoadInBackground]): Call through to response object to get status code. (-[WebResourceHandle loadInForeground:]): Ditto. (-[WebResourceHandle response]): Added.
• CacheLoader.subproj/WebResourceHandleInternal.h: Add WebResourceResponse ivar. Remove statusCode ivar.
• CacheLoader.subproj/WebResourceHandleInternal.m: Remove handle support for its own status code ivar. (-[WebResourceHandleInstanceVariables initWithHandle:]): (+[WebResourceHandle _registerDefaults]):
• CacheLoader.subproj/WebResourceHandlePrivate.h: Declare method to set a WebResourceResponse on a handle.
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _didLoadData:]): Call through to response object to get status code. (-[WebResourceHandle _backgroundLoadComplete]): Ditto. (-[WebResourceHandle _backgroundLoadFailed]): Ditto. (-[WebResourceHandle _didRedirectToURL:]): Ditto. (-[WebResourceHandle _setResponse:]): Added
• CacheLoader.subproj/WebResourceLoad.h: Remove load support for its own status code ivar. Add WebResourceResponse ivar.
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]): Create new WebResourceResponse ivar. (-[WebResourceLoad cancel]): Call through to response object to get status code. (-[WebResourceLoad succeeded]): Ditto. (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:isTerminal:]): Ditto. (-[WebResourceLoad addHandle:]): Set WebResourceResponse on the handle when it is added. (-[WebResourceLoad _beginLoad]): Call through to response object to get status code. (-[WebResourceLoad _beginOriginLoad]): Ditto. (-[WebResourceLoad dealloc]): Release new WebResourceResponse instance. (_loadThrottler): Call through to response object to get status code.
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): Added (-[WebResourceResponse contentLength]): Implementation does not work yet, but nobody relies on it yet.
• CacheLoader.subproj/WebResourceResponsePrivate.h: Removed life-cycle methods I am going to try to do without.
• WebFoundation.pbproj/project.pbxproj:

WebKit:

The first use of the WebResourceResponse object. This is just a baby step, though.
I only use one variable in the new class, the statusCode, but all the code in
the framework has been updated to use the statusCode from the response object.

Each of these methods was modified to call through to a WebResourceResponse to get
the status code.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:])
• WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress initWithResourceHandle:])
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:])

12:34 PM Changeset in webkit [1968] by rjw

• 3 edits in trunk/WebKit

Only disable timed expiration of CG glyph cache if SPI is available.
(per Bertrand's request)

• WebCoreSupport.subproj/WebTextRendererFactory.m:

7:13 AM Changeset in webkit [1967] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• Resources/url_icon.tiff: New generic icon from Steve Lemay. The @ sign lives, but does not spring.

WebBrowser:

• new art from Steve Lemay
• removed all unused images from Alexander

• LocationTextField.m: (-[LocationTextField setDisplayAttributes]):
• SearchTextField.m: (-[SearchTextField setDisplayAttributes]): Updated to use new names for left/middle/right images, so I don't have to keep changing the names of the incoming art.

• Resources/Images/Back.tif:
• Resources/Images/BackPressed.tif:
• Resources/Images/Go.tif:
• Resources/Images/GoPressed.tif:
• Resources/Images/Search_SnapBack.tif:
• Resources/Images/Search_SnapBackPressed.tif:
• Resources/Images/ShowFavorites.tif:
• Resources/Images/Stop.tif:
• Resources/Images/StopPressed.tif:
• Resources/Images/Reload.tif:
• Resources/Images/ReloadPressed.tif: New and improved.

• Resources/Images/Location_Left.tif: Added.
• Resources/Images/Location_Middle.tif: Added.
• Resources/Images/Location_Right.tif: Added.
• Resources/Images/Search_Left.tif: Added.
• Resources/Images/Search_Middle.tif: Added.
• Resources/Images/Search_Right.tif: Added. New names for left/middle/right text field images; note that the search middle is now different than the location field middle (different shadowing)

• Resources/Images/RightCapBack.tiff: Removed.
• Resources/Images/favoritesCaret.tiff: Removed.
• Resources/Images/find.tiff: Removed.
• Resources/Images/find2_green.gif: Removed.
• Resources/Images/find_go.tiff: Removed.
• Resources/Images/find_green.gif: Removed.
• Resources/Images/find_red_0.gif: Removed.
• Resources/Images/find_red_1.gif: Removed.
• Resources/Images/find_red_2.gif: Removed.
• Resources/Images/find_red_3.gif: Removed.
• Resources/Images/find_red_4.gif: Removed.
• Resources/Images/find_red_5.gif: Removed.
• Resources/Images/find_red_6.gif: Removed.
• Resources/Images/find_red_7.gif: Removed.
• Resources/Images/leftCapFlat.tiff: Removed.
• Resources/Images/leftCapRound.tiff: Removed.
• Resources/Images/leftCapRoundWithGlass.tiff: Removed.
• Resources/Images/leftCapRoundWithGlassAndMenu.tiff: Removed.
• Resources/Images/middleTextField.tiff: Removed.
• Resources/Images/rightCapFlat.tiff: Removed.
• Resources/Images/rightCapRound.tiff: Removed.
• Resources/Images/spin_0.tiff: Removed.
• Resources/Images/spin_1.tiff: Removed.
• Resources/Images/spin_10.tiff: Removed.
• Resources/Images/spin_11.tiff: Removed.
• Resources/Images/spin_2.tiff: Removed.
• Resources/Images/spin_3.tiff: Removed.
• Resources/Images/spin_4.tiff: Removed.
• Resources/Images/spin_5.tiff: Removed.
• Resources/Images/spin_6.tiff: Removed.
• Resources/Images/spin_7.tiff: Removed.
• Resources/Images/spin_8.tiff: Removed.
• Resources/Images/spin_9.tiff: Removed.
• Resources/Images/stopSquare.tiff: Removed.
• Resources/Images/web2_green.gif: Removed.
• Resources/Images/web2_red_0.gif: Removed.
• Resources/Images/web2_red_1.gif: Removed.
• Resources/Images/web2_red_10.gif: Removed.
• Resources/Images/web2_red_11.gif: Removed.
• Resources/Images/web2_red_2.gif: Removed.
• Resources/Images/web2_red_3.gif: Removed.
• Resources/Images/web2_red_4.gif: Removed.
• Resources/Images/web2_red_5.gif: Removed.
• Resources/Images/web2_red_6.gif: Removed.
• Resources/Images/web2_red_7.gif: Removed.
• Resources/Images/web2_red_8.gif: Removed.
• Resources/Images/web2_red_9.gif: Removed.
• Resources/Images/web_go.tiff: Removed.
• Resources/Images/web_green.gif: Removed.
• Resources/Images/web_red_0.gif: Removed.
• Resources/Images/web_red_1.gif: Removed.
• Resources/Images/web_red_2.gif: Removed.
• Resources/Images/web_red_3.gif: Removed.
• Resources/Images/web_red_4.gif: Removed.
• Resources/Images/web_red_5.gif: Removed.
• Resources/Images/web_red_6.gif: Removed.
• Resources/Images/web_red_7.gif: Removed. Out with the old unused images.

• WebBrowser.pbproj/project.pbxproj: Updated for file changes.

Sep 4, 2002:

11:24 PM Changeset in webkit [1966] by darin

• 5 edits in trunk/WebKit

One more pass of refinement on that last change.

• History.subproj/WebBackForwardList.m: (-[WebBackForwardList addEntry:]): Replace the last entry instead of just ignoring if this one matches.

• History.subproj/WebHistoryList.h: Add replaceEntryAtIndex. Remove addURL: and removeURL:.

• History.subproj/WebHistoryList.m: (-[WebHistoryList addEntry:]): Call removeEntry: rather than using an entire pasted copy here. (-[WebHistoryList removeEntry:]): Use a hash of the URL and the URL rather than relying on the fact that WebHistoryItem hashes and does isEqual based on the URL only. (-[WebHistoryList replaceEntryAtIndex:withEntry:]): Added. Used by the code above.

11:05 PM Changeset in webkit [1965] by darin

• 4 edits in trunk/WebKit

Fix bug where doing a reload adds an entry to the back/forward list.

• History.subproj/WebBackForwardList.m: (-[WebBackForwardList addEntry:]): If URL, target, and parent all match, then don't add an entry.

• WebKit.pbproj/project.pbxproj: Let Project Builder be the boss; I guess this means Chris is still using the old version.

6:56 PM Changeset in webkit [1964] by cblu

• 5 edits in trunk/WebKit

• don't set nil data on the web file db
• store absolute URLs in the db, not base URL/path combination URLs
• support for multiple hosts with the same built-in icon

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): renamed some dictionaries (-[WebIconDatabase iconForSiteURL:withSize:]): call _builtInIconsForHost (-[WebIconDatabase _updateFileDatabase]): check for nil (-[WebIconDatabase _hasIconForSiteURL:]): call _pathForBuiltInIconForHost (-[WebIconDatabase _pathForBuiltInIconForHost:]): new (-[WebIconDatabase _builtInIconsForHost:]): call _pathForBuiltInIconForHost
• Misc.subproj/WebIconDatabasePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): use absolute URL

5:02 PM Changeset in webkit [1963] by cblu

• 5 edits in trunk/WebKit

WebKit:

Made the icon DB take a a path for built-in icons so that we only load them when necessary.

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForSiteURL:withSize:]): (-[WebIconDatabase _hasIconForSiteURL:]): (-[WebIconDatabase _builtInIconsForHost:]): (-[WebIconDatabase _setBuiltInIconAtPath:forHost:]):
• Misc.subproj/WebIconDatabasePrivate.h:
• WebKit.pbproj/project.pbxproj:

WebBrowser:

Added the built-in site icons to the Alexander.app package.

• AppController.m: (-[AppController _installBuiltInIcons]):
• Resources/SiteIcons/Icons.plist: Added.
• Resources/SiteIcons/amazon.tiff: Added.
• Resources/SiteIcons/apple.tiff: Added.
• Resources/SiteIcons/cnet.tiff: Added.
• Resources/SiteIcons/cnn.tiff: Added.
• Resources/SiteIcons/ebay.tiff: Added.
• Resources/SiteIcons/espn.tiff: Added.
• Resources/SiteIcons/msn.tiff: Added.
• Resources/SiteIcons/nyt.tiff: Added.
• Resources/SiteIcons/pbskids.tiff: Added.
• Resources/SiteIcons/yahoo.tiff: Added.
• WebBrowser.pbproj/project.pbxproj:

2:42 PM Changeset in webkit [1962] by darin

• 3 edits in trunk/WebKit

Fix unused variable warnings for deployment builds.

• Plugins.subproj/WebPluginView.m: Add ifndef NDEBUG around variable used only in log statements.

1:50 PM Changeset in webkit [1961] by darin

• 14 edits in trunk/WebKit

WebKit:

Removed the now-unnecessary iconURL from bookmarks and history.

• Bookmarks.subproj/WebBookmark.h:
• Bookmarks.subproj/WebBookmark.m:
• Bookmarks.subproj/WebBookmarkGroup.h:
• Bookmarks.subproj/WebBookmarkGroup.m:
• Bookmarks.subproj/WebBookmarkLeaf.h:
• Bookmarks.subproj/WebBookmarkLeaf.m:
• History.subproj/WebHistory.h:
• History.subproj/WebHistory.m:
• History.subproj/WebHistoryItem.h:
• History.subproj/WebHistoryItem.m:
• History.subproj/WebHistoryPrivate.h:
• History.subproj/WebHistoryPrivate.m: Removed iconURL instance variables, methods, and parameters.

WebBrowser:

Update users of bookmark or history APIs from WebKit that no longer take an iconURL.

• BookmarksController.m: (-[BookmarksController _blessOrCreateFavoritesRoot]):
• BookmarksViewController.m: (-[BookmarksViewController newItemWithTitle:URLString:type:positionIgnoresSelection:]):
• LocationChangeHandler.m: (-[LocationChangeHandler receivedPageTitle:forDataSource:]): Removed iconURL parameters.

1:42 PM Changeset in webkit [1960] by darin

• 14 edits
  1 add in trunk/WebKit

Did some minor plugin cleanup, mostly to make sure we don't
change pages while a plugin is tracking.

• Plugins.subproj/WebPluginView.h: Add sendEvent and sendUpdateEvent. Remove the NPP_HandleEvent method.
• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView sendEvent:]): Sets up the "defersCallbacks" state, then sends the event.

• Plugins.subproj/WebNetscapePluginViewPrivate.h: Added. This stuff was shared in a different way before, and it hadn't even been renamed.
• WebKit.pbproj/project.pbxproj: Added file.
• Plugins.subproj/npapi.m: Use the new private header.

• Plugins.subproj/WebPluginNullEventSender.h: Hold a reference to the view.
• Plugins.subproj/WebPluginNullEventSender.m: (-[WebNetscapePluginNullEventSender initWithPluginView:]): Retain the view. (-[WebNetscapePluginNullEventSender dealloc]): Release the view. (-[WebNetscapePluginNullEventSender sendNullEvents]): Use sendEvent:. (-[WebNetscapePluginNullEventSender stop]): No need for shouldStop.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): Don't set contentPolicy to an enum value, when it's an object reference. (-[WebDataSourcePrivate dealloc]): Release contentPolicy to fix a leak.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Set draggedURL to nil in the else case, it was uninitialized before. Also center the icon better when dragging, but shouldn't we be dragging something more than the icon here?

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase defaultIconWithSize:]): Add a call to release. Doesn't really plug a leak, but cleaner this way.

• Plugins.subproj/WebPlugin.m: Tweaks.
• WebView.subproj/WebMainResourceClient.m: Tweaks only.

10:04 AM Changeset in webkit [1959] by kocienda

• 9 edits in trunk/WebKit

WebFoundation:

Modified API and behavior so that WebResourceHandle objects no longer
buffer data as it is loaded. The responsibility to buffer data is now
passed to WebResourceClient objects, and I modified the code to
perform that buffering where necessary.

There was also an API change to the WebResourceClient protoccol.

• (void)handleDidFinishLoading:(WebResourceHandle *)handle data:(NSData *)data;

has become

• (void)handleDidFinishLoading:(WebResourceHandle *)handle;

This reflects the fact that WebResourceHandle no longer has the data to pass
in this callback (and may not be able to ask other objects in the framework to
provide the data so that it may be presented in the callback).

I also added a new WebResourceResponse class, although it is not wired up
to anything yet.

• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/IFURLHandleC.m:
• CacheLoader.subproj/WebResourceCallbackClient.m: (-[WebResourceCallbackClient handleDidFinishLoading:])
• CacheLoader.subproj/WebResourceClient.h:
• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadInForeground:]) (-[WebResourceHandle contentLengthReceived])
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables initWithHandle:]) (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]) (-[WebResourceHandle _notifyClientDidFinishLoading])
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _didLoadData:])
• CacheLoader.subproj/WebResourceResponse.h: Added.
• CacheLoader.subproj/WebResourceResponse.m: Added.
• CacheLoader.subproj/WebResourceResponsePrivate.h: Added.
• CacheLoader.subproj/WebResourceSynchronousClient.h:
• CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceSynchronousClient initWithMonitor:realClient:]) (-[WebResourceSynchronousClient dealloc]) (-[WebResourceSynchronousClient resourceData]) (-[WebResourceSynchronousClient handleDidFinishLoading:]) (-[WebResourceSynchronousClient handleDidReceiveData:data:])
• WebFoundation.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Made more adjustments for API and behavior change that occurred in WebFoundation,
now that WebResourceHandle objects no buffer resource data as it is loaded. Where
necessary, the WebKit objects now do their own buffering, however, in many cases,
buffering is not necessary to maintain correct behavior.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoaderPrivate dealloc]): Release new buffered resource data object. (-[WebIconLoader initWithURL:]): Allocate new buffered resource data object. (-[WebIconLoader handleDidFinishLoading:]): Modify API to remove data parameter. (-[WebIconLoader handleDidReceiveData:data:]): Buffer data as it is received.
• Plugins.subproj/WebPluginStream.h: Added new buffered resource data object.
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:attributes:]): Allocate new buffered resource data object. (-[WebNetscapePluginStream dealloc]): Release new buffered resource data object. (-[WebNetscapePluginStream receivedData:]): Buffer data as it is received (when necessary maintain correct behavior). (-[WebNetscapePluginStream handleDidFinishLoading:]): Modify API to remove data parameter.
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]): Modify API to remove data parameter.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]): Modify API to remove data parameter. (-[WebMainResourceClient handleDidReceiveData:data:]): Buffer data as it is received (when necessary maintain correct behavior).

9:08 AM Changeset in webkit [1958] by cblu

• 3 edits in trunk/WebKit

WebKit:

Fixed: 3043024 - Built-in icons should match on *whatever.com or *whatever.whatever
implemented wizzy scaling, but ifdef'd it out

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:]): call _builtItIconsForHost (-[WebIconDatabase _hasIconForSiteURL:]): call _builtItIconsForHost (-[WebIconDatabase _iconForFileURL:withSize:]): call _iconByScalingIcon:toSize: (-[WebIconDatabase _builtItIconsForHost:]): use better host matching (-[WebIconDatabase _cachedIconFromArray:withSize:]): call _iconByScalingIcon:toSize: (-[WebIconDatabase _iconByScalingIcon:toSize:]): renamed, ifdef'd out wizzy scaling

WebBrowser:

Release alloc'd image.

• AppController.m: (-[AppController _installBuiltItIcons]):

8:32 AM Changeset in webkit [1957] by kocienda

• 7 edits in trunk/WebKit

Changed WebKit so that it no longer relies on WebResourceHandle to buffer
resource data as it is loaded. Instead, this buffering task has been moved
out to the WebResourceClient, WebMainResourceClient in this case. This
change is a "proof of concept" for the upcoming change where the API in
WebFoundation for buffering resource data in WebResourceHandle will be
removed altogether.

• WebView.subproj/WebDataSource.m: (-[WebDataSource data]): Changed to call WebMainResourceClient when resource data is needed.
• WebView.subproj/WebMainResourceClient.h: Added mutable data ivar.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): Added mutable data ivar. (-[WebMainResourceClient dealloc]): Release new mutable data ivar. (-[WebMainResourceClient resourceData]): Added accessor method. (-[WebMainResourceClient handleDidReceiveData:data:]): Append received data to the new mutable data object.

8:04 AM Changeset in webkit [1956] by darin

• 10 edits in trunk/WebCore

• WebCore.pbproj/project.pbxproj:
• kwq/KWQObject.mm:
• kwq/KWQPainter.mm:
• kwq/KWQTimer.mm:
• kwq/WebCoreCookieAdapter.h:
• kwq/WebCoreImageRenderer.h:
• kwq/WebCoreImageRendererFactory.h: Tweaks, no substantive changes.