Context Navigation

← Previous Period
Next Period →

Timeline

Sep 11, 2002:

11:53 PM Changeset in webkit [2044] by mjs

4 edits in trunk/WebCore

WebCore:

Don't show the window here any more, now that WebBrowser will set
it up to be shown properly itself.

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):

WebBrowser:

Changed new window opening to happen right away instead of waiting
until the content policy is known. This avoids the horrible lack
of feedback and feeling of slowness on new window opening, but
re-introduces the problem that command-clicking on a link that
downloads leaves around an empty window (Radar 3049296).

While I was at it, I made goToInitialURL get called right away
instead of deferring it, since the problems that arose from
calling it right away before no longer apply.

fixed Radar 3017596 - Cmd click on link doesn't display new window fast enough
fixed Radar 3049291 - Deferring goToInitialURL can cause problems

BrowserDocument.h:
BrowserDocument.m: Remove methods and code related to awaiting the content policy, since we no longer wait for it.
BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:referrer:display:]): Show the window next time through the event loop. (-[BrowserDocumentController _createEmptyBrowserDocumentAndDisplay:]): Show the window next time through the event loop.
BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:URL:inFrame:]): No more need to show or close window when content policy is determined.
BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Go to initial URL immediately, not after delay.

6:59 PM Changeset in webkit [2043] by hyatt

4 edits in trunk/WebCore

Fix horizontal scrolling. The HTML render object lies. It lies,
I tell you.

khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):

6:01 PM Changeset in webkit [2042] by hyatt

11 edits in trunk/WebCore

Fix clipping to work with layers. This fixes the marquee
(once again) on livepage.apple.com.

khtml/rendering/render_box.cpp: (RenderBox::getClipRect):
khtml/rendering/render_box.h:
khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode):
khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): (RenderFlow::printObject):
khtml/rendering/render_layer.cpp: (RenderLayer::enclosingPositionedAncestor): (RenderLayer::convertToLayerCoords): (RenderLayer::paint): (RenderLayer::constructZTree):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.h:
khtml/rendering/render_replaced.cpp: (RenderReplaced::print):

4:23 PM Changeset in webkit [2041] by darin

4 edits in trunk/WebCore

WebFoundation:

Misc.subproj/WebAssertions.h: Changed assertions to use a different technique for varargs, which seems to work better on Claudius. Sorry about the nearly-full build.

CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest setMethod:]): Store a copy so we don't end up retaining a mutable string that the caller then modifies. (-[WebResourceRequest setHeaders:]): Allow nil for theHeaders, and make an empty dictionary in that case. (-[WebResourceRequest setHeader:forKey:]): Store a copy so we don't end up putting a reference to a mutable string in our dictionary. (-[WebResourceRequest addHeader:forKey:]): Ditto. (-[WebResourceRequest setExtraCookies:]): Ditto, same applies for NSArray. (-[WebResourceRequest setData:]): Ditto, same for NSData.

WebCore:

kwq/KWQAssertions.h: Updated copy of the assertions macros (made by script).

4:10 PM Changeset in webkit [2040] by mjs

8 edits in trunk/WebKit

Combined provisionalDataSourceChanged: and
provisionalDataSourceCommitted: methods into a single
setDataSource:, since they are always called one immediately after
the other.

Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setDataSource:]): (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]):
WebView.subproj/WebDocument.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView setDataSource:]):
WebView.subproj/WebImageView.m: (-[WebImageView setDataSource:]):
WebView.subproj/WebTextView.m: (-[WebTextView setDataSource:]):
WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]):

3:43 PM Changeset in webkit [2039] by rjw

3 edits in trunk/WebKit

i Better fix for previous problem.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):

2:05 PM Changeset in webkit [2038] by darin

4 edits in trunk/WebCore

fixed 3047552 -- crash using CFNotification calls on an NSNotification

kwq/KWQWindowWidget.mm: (KWQWindowWidget::KWQWindowWidget): Create a KWQWindowWidgetDeleter, and hook it up to the notification. (KWQWindowWidget::~KWQWindowWidget): Disconnect the KWQWindowWidgetDeleter and release it. (-[KWQWindowWidgetDeleter initWithWindowWidget:]): Store a pointer. (-[KWQWindowWidgetDeleter deleteWindowWidget]): Do a delete.

1:33 PM Changeset in webkit [2037] by rjw

3 edits in trunk/WebKit

Remove ceiling of text width at end of fragment. This was screwing up
intra fragment text measurements.

Selection of justified text is still screwed up. This is a fundamental problem
in khtml and will require a rewrite of their justification code. Konq has the
same problems selecting justified text. The drawing of code applies the justification
factor, but checking the selection doesn't add the justification factor, so selection
will be incorrect by the justification amount.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):

12:26 PM Changeset in webkit [2036] by darin

3 edits in trunk/WebKit

WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Use the current URL, not the original URL, when doing a reload. This prevents the URL from changing back and forth when you reload on a page that involved a redirect.

11:56 AM Changeset in webkit [2035] by darin

10 edits
1 add
1 delete in trunk/WebCore

fixed 3021137 -- changing font prefs doesn't redraw frames other than the main frame

kwq/WebCoreSettings.m: Renamed to WebCoreSettings.mm.
kwq/WebCoreSettings.mm: Renamed from WebCoreSettings.m so I could use C++. (-[WebCoreSettings _updateAllViews]): Iterate over all KWQKHTMLPartImpl instances, calling setNeedsReapplyStyles on each one.
WebCore.pbproj/project.pbxproj: Updated for name change.

kwq/KWQKHTMLPartImpl.h: Add instances() and mutableInstances(). Get rid of frameExists(), findFrame(), and frames().
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Add to instance list. (KWQKHTMLPartImpl::~KWQKHTMLPartImpl): Remove from instance list. (KWQKHTMLPartImpl::requestFrame): Update to not use frameExists(). (KWQKHTMLPartImpl::overURL): Update to not use frameExists, and improve handling of various cases. (KWQKHTMLPartImpl::mutableInstances): Create and return instance list.

kwq/WebCoreBridge.h: Add setNeedsReapplyStyles; already implemented in WebKit.

khtml/khtml_part.cpp: (KHTMLPart::findFrame): Remove APPLE_CHANGES. (KHTMLPart::frameExists): Remove APPLE_CHANGES. (KHTMLPart::frames): Remove APPLE_CHANGES.

11:52 AM Changeset in webkit [2034] by darin

4 edits in trunk/WebKit

Add machinery needed for fix to 3021137, changing font prefs
doesn't redraw frames other than the main frame.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsReapplyStyles]): Added. Lets the web views know that they need to reapply styles. If we did this over on the WebCore side, we'd have to do it right away. Maybe that would be OK; we can move that that later.

WebView.subproj/WebTextView.m: (-[WebTextView setFixedWidthFont]): Use the fixed-width size, rather than using the other size with the fixed-width family.

11:14 AM Changeset in webkit [2033] by kocienda

17 edits in trunk/WebKit

WebFoundation:

Major change to the API and design of WebFoundation.

Attributes, as a design concept, are now completely gone. The old usages of
attributes have been replaced with new API on the WebResourceRequest
and WebResourceResponse classes.

CacheLoader.subproj/IFHTTPURLHandleC.m: (IFHTTPURLHandleGetRequestMethod): Removed attribute usage. Replace with calls to new API. (IFHTTPURLHandleGetRequestHeaders): Ditto.
CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addUserRequestHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addUnconditionalUserRequestHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addAcceptHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addCookieHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler hasConditionalCustomHeaders]): Ditto.
CacheLoader.subproj/WebCacheLoaderConstants.h: Removed newly obsoleted attributes.
CacheLoader.subproj/WebCacheLoaderConstants.m: Ditto.
CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler shouldAttemptOriginLoad]): Removed attribute usage. Replace with calls to new API. (-[WebHTTPProtocolHandler shouldCacheResourceData]): Ditto. (-[WebHTTPProtocolHandler requestMethod]): Ditto. (-[WebHTTPProtocolHandler requestData]): Ditto. (-[WebHTTPProtocolHandler retryWithRedirectedURLAndResultCode:]): Ditto. (-[WebHTTPProtocolHandler testAndSetCacheObjectState:]): Ditto.
CacheLoader.subproj/WebResourceHandle.h: Removed attributeForKey method.
CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle description]): Removed attribute usage. Replace with calls to new API. (-[WebResourceHandle initWithRequest:client:]): WebResourceRequest no longer requires explicit validation.
CacheLoader.subproj/WebResourceHandleInternal.h: Removed processedAttributes.
CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]): Ditto.
CacheLoader.subproj/WebResourceHandlePrivate.h: Removed _setAttribute method.
CacheLoader.subproj/WebResourceHandlePrivate.m: Ditto.
CacheLoader.subproj/WebResourceLoad.h: Removed processedAttributes ivar. Removed attributeForKey and setAttribute:forKey: methods.
CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]): Ditto. (-[WebResourceLoad description]): Ditto. (-[WebResourceLoad dealloc]): Ditto.
CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]): Removed attributes from cache key. Need to put back some request info soon. (+[WebResourceLoadKey keyWithLoad:]): Ditto.
CacheLoader.subproj/WebResourceRequest.h: Removed attributes ivar. Added method, headers, extraCookies and data ivars. Added getter and setter methods for each of the new ivars.
CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]): API and implementation rejiggering to deal with removing attributes from the init methods. (-[WebResourceRequest initWithURL:flags:]): Ditto. (-[WebResourceRequest initWithURL:userAgent:flags:]): Ditto. (-[WebResourceRequest method]): Added. (-[WebResourceRequest setMethod:]): Added. (-[WebResourceRequest headers]): Added. (-[WebResourceRequest setHeaders:]): Added. (-[WebResourceRequest referrer]): Added. (-[WebResourceRequest setReferrer:]): Added. (-[WebResourceRequest extraCookies]): Added. (-[WebResourceRequest setExtraCookies:]): Added. (-[WebResourceRequest data]): Added. (-[WebResourceRequest setData:]): Added. (-[WebResourceRequest flags]): Just moved method in the file. No changes. (-[WebResourceRequest protocolHandlerClass]): Ditto. (-[WebResourceRequest copyWithZone:]): Made sure new ivars get copied. (-[WebResourceRequest dealloc]): Added new ivars.
CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler createHTTPRequest]): Removed attribute usage. Replace with calls to new API.
WebFoundation.exp: Removed attribute key exports.

WebKit:

Major change to the API and design of WebFoundation. WebKit has been modified
to use the new API.

WebFoundation attributes, as a design concept, are now completely gone. The old usages of
attributes have been replaced with new API on the WebResourceRequest
and WebResourceResponse classes.

Plugins.subproj/WebPluginStream.h: Removed attribute usage in init API. No need for replacement.
Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream initWithURL:pluginPointer:]): Removed attribute usage in init API. (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): Ditto. (-[WebNetscapePluginStream dealloc]): Remove attribute release. (-[WebNetscapePluginStream startLoad]): Removed attribute usage. Replace with calls to new API. (-[WebNetscapePluginStream receivedData:withHandle:]): Ditto.
Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView pluginURLFromCString:]): Added this helper method. (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]): Added. (-[WebNetscapePluginView getURLNotify:target:notifyData:]): Modified to call new loadRequest:inTarget:withNotifyData: method. (-[WebNetscapePluginView getURL:target:]): Ditto. (-[WebNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): Ditto.
WebCoreSupport.subproj/WebBridge.h: Removed attribute usage in loadURL API. No need for replacement.
WebCoreSupport.subproj/WebBridge.m: Added loadRequest:withParent: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge startLoadingResource:withURL:referrer:]): Removed attribute usage. Replace with calls to new API. (-[WebBridge isReloading]): Ditto. (-[WebBridge loadRequest:withParent:]): Added. (-[WebBridge loadURL:]): Modified to use new loadRequest:withParent: API (-[WebBridge loadURL:referrer:]): Ditto. (-[WebBridge loadURL:flags:withParent:]): Ditto. (-[WebBridge postWithURL:data:]): Ditto.
WebCoreSupport.subproj/WebSubresourceClient.h: Changed API to use an NSString referrer instead of an attributes dictionary.
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Removed attribute usage. Replace with calls to new API.
WebView.subproj/WebDataSource.h: Added initWithRequest: method.
WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:]): Removed attribute usage in init API. (-[WebDataSource initWithURL:flags:]): Ditto. (-[WebDataSource initWithRequest:]): Added. (-[WebDataSource request]): Added.
WebView.subproj/WebDataSourcePrivate.h: Added WebResourceRequest ivar.
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Added WebResourceRequest ivar. (-[WebDataSource _startLoading:]): Removed attribute usage. Replace with calls to new API.
WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Removed attribute usage. Replace with calls to new API.
WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Use new WebDataSource init API.

WebBrowser:

Updated to use new referrer ivar and accessor methods on WebResourceRequest, instead
of using attributes.

BrowserDocument.m: (-[BrowserDocument _goToURL:referrer:withFallbackURLs:])

9:37 AM Changeset in webkit [2032] by darin

36 edits in trunk

WebCore:

WebCore part of support for the "Referer" header.

khtml/khtml_part.cpp: (KHTMLPart::urlSelected): Use much more of this function. (KHTMLPart::submitForm): Use much more of this function.

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Parse the referrer out of the URLArgs and pass it along.

kwq/KWQKHTMLPartImpl.h: Change parameters to urlSelected and submitForm to allow KHTML to do more of the work. Add referrer helper function.
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Pass referrer of nil when opening a blank window. (KWQKHTMLPartImpl::referrer): Extract referrer from metadata. (KWQKHTMLPartImpl::openURLRequest): Pass referrer from args through the bridge. (KWQKHTMLPartImpl::urlSelected): Remove code that duplicates what's in KHTMLPart. Also pass referrer from args through the bridge as above. (KWQKHTMLPartImpl::submitForm): Ditto.

kwq/kdeui/kmessagebox.h: Add information member function.
kwq/KWQKMessageBox.mm: (KMessageBox::information): Implement.

kwq/kdecore/kurl.h: Add encode_string member function.
kwq/KWQKURL.mm: (KURL::KURL): Fix buffer overflow bug, and add an assert so we will notice these overflows even when using the static buffer. (KURL::parse): Added a similar assert, even though I didn't fix any overflow bug here. (KURL::encode_string): Implemented this, but didn't test it.

kwq/KWQLoaderImpl.mm: (KWQServeRequest): Pass referrer through the bridge.

kwq/WebCoreBridge.h: Add referrer parameters to loadURL, postWithURL, openNewWindowWithURL, and startLoadingResource.

kwq/kparts/browserextension.h: Implement setDoPost, setContentType, const version of metaData().

kwq/qt/qstring.h: Implement fromLatin1(const char *, int).

WebCore-tests.exp: Not sure why, but I needed to remove isMalformed, and the tests seem to still work with it removed.

WebKit:

WebKit part of support for the "Referer" header.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]): Add referrer parameter, and pass it on to the window context method. (-[WebBridge addAttributeForReferrer:toDictionary:]): Added. (-[WebBridge attributesForReferrer:]): Added. (-[WebBridge startLoadingResource:withURL:referrer:]): Put the referrer into an attributes dictionary and pass it to the WebSubresourceClient method. (-[WebBridge loadURL:referrer:]): Put the referrer into an attributes dictionary and pass it along. (-[WebBridge postWithURL:referrer:data:]): Put the referrer into an attributes dictionary and pass it along.

WebCoreSupport.subproj/WebSubresourceClient.h: Add an attributes parameter to the method that starts loading.
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:attributes:forDataSource:]): Put the attributes into the WebResourceRequest.

WebView.subproj/WebController.h: Add a referrer parameter to the WebWindowContext openNewWindowWithURL method.
WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler openNewWindowWithURL:referrer:]): Pass the referrer on to the window context. (-[WebDefaultContextMenuHandler openLinkInNewWindow:]): Pass nil for the referrer for now. Not sure if this is best. (-[WebDefaultContextMenuHandler openImageInNewWindow:]): Ditto. (-[WebDefaultContextMenuHandler openFrameInNewWindow:]): Ditto.

WebView.subproj/WebFrame.m: (-[WebFrame frameNamed:]): Pass nil for the referrer here where we are creating a new empty window.

WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): Pass nil for the referrer here in the WebClickPolicyOpenNewWindow. The policy API doesn't provide a way for the policy handler to specify the referrer; we might want to change that later.

Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): Pass nil for the referrer here. But it seems wrong that this function discards the handle attributes that are passed in for the case where it opens a new window.

WebBrowser:

WebBrowser part of support for the "Referer" header.

BrowserWebController.m: (-[BrowserWebController openNewWindowWithURL:referrer:]): Add referrer parameter, and pass it through to the document controller. (-[BrowserWebController pluginNotFoundSheetEnded:returnCode:contextInfo:]): Pass nil for referrer.

BrowserDocumentController.h: Add referrer parameter to the long version of goToURL.
BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:referrer:display:]): Change to not all makeDocumentWithContentsOfURL and instead create the document here, because we need to pass the referrer through. (-[BrowserDocumentController openDocumentWithContentsOfURL:display:]): Just call the version above that has a referrer, passing a referrer of nil. (-[BrowserDocumentController _goToEachURL:referrer:forceNewWindow:orderFront:]): Pas referrer to goToURL and to openDocumentWithContentsOfURL. (-[BrowserDocumentController goToEachURL:]): Pass nil for referrer. (-[BrowserDocumentController goToURL:referrer:forceNewWindow:orderFront:]): Add referrer parameter, and pass through to _goToEachURL.

BrowserDocument.h: Add _openWithReferrer field, initWithContentsOfURL method that takes a referrer, and goToURL method that takes a referrer.
BrowserDocument.m: (-[BrowserDocument initWithContentsOfURL:referrer:]): Set _openWithReferrer. (-[BrowserDocument dealloc]): Release _openWithReferrer. (-[BrowserDocument _goToURL:referrer:withFallbackURLs:]): Add referrer parameter. Set up attributes dictionary with referrer in it. (-[BrowserDocument goToURL:]): Call through to goToURL:referrer:. (-[BrowserDocument goToURL:referrer:]): Added. Passes referrer on. (-[BrowserDocument goToInitialURL:]): Pass _openWithReferrer. (-[BrowserDocument tryMultipleURLs:]): Pass nil for referrer.

ActivityViewer.m: (-[ActivityViewer _goToClickedItem:]): Pass nil for referrer.
AppController.m: (-[AppController application:openFile:]): Ditto. (-[AppController handleGURLEvent:withReplyEvent:]): Ditto.
BrowserWebBookmarkExtras.m: (-[WebBookmark _goToForceNewWindow:]): Ditto.
Test/PageLoadTestRunner.m: (-[PageLoadTestRunner goToPage]): Ditto.

8:41 AM Changeset in webkit [2031] by cblu

4 edits in trunk/WebKit

Fixed: 3048158 - Crash at google in _destroyInitializingClassList

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]):

3:36 AM Changeset in webkit [2030] by hyatt

8 edits in trunk/WebCore

This patch fixes a slew of bugs. It is an implementation
of the IE extensions offsetLeft, offsetTop, and offsetParent.
Konqueror actually had implementations for these properties
that were totally wrong, leading any DHTML that would use
these properties (like the DHTML on brainjar.com or livepage.apple.com)
to misposition child elements.

With these properties now implemented, the menus on brainjar.com
position correctly, and the marquee on livepage.apple.com once
again shows up (and now you can see how I've regressed clipping
by not shoving it into the layer system as well).

Next up will be fixing the clipping bug on livepage.apple.com.

khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty):
khtml/rendering/render_flow.cpp: (RenderFlow::offsetHeight): (RenderFlow::offsetLeft): (RenderFlow::offsetTop):
khtml/rendering/render_flow.h:
khtml/rendering/render_object.cpp: (RenderObject::offsetLeft): (RenderObject::offsetTop): (RenderObject::offsetParent):
khtml/rendering/render_object.h:

Sep 10, 2002:

9:28 PM Changeset in webkit [2029] by hyatt

7 edits in trunk/WebCore

Get more elements on mrskin painting as well as the menus
on brainjar.com.

khtml/rendering/render_flow.cpp: (RenderFlow::layout):
khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
khtml/rendering/render_object.cpp: (RenderObject::setLayouted):
khtml/rendering/render_object.h:

8:02 PM Changeset in webkit [2028] by hyatt

11 edits in trunk/WebCore

Fix the CSS clip property.

khtml/css/cssparser.cpp: (StyleBaseImpl::parseValue):
khtml/css/cssstyleselector.cpp:
khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::tryPut):
khtml/rendering/render_box.cpp: (RenderBox::calcClip):
khtml/rendering/render_flow.cpp: (RenderFlow::printObject):
khtml/rendering/render_replaced.cpp: (RenderReplaced::print):
khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (RenderStyle::diff):
khtml/rendering/render_style.h:

6:45 PM Changeset in webkit [2027] by rjw

2 edits in trunk/WebKit

Forgot to commit ChangeLog

6:43 PM Changeset in webkit [2026] by rjw

17 edits in trunk

Tests/html/mousetest.html: Added.

Fixed broken DOM handling of click count. DOM click
events can be tested with Labyrinth/Test/html/mousetest.html.
Preparation work for double and triple click selection.

khtml/khtml_events.cpp:
khtml/khtml_events.h:
khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseTripleClickEvent):
khtml/khtml_part.h:
khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseTripleClickEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent):
khtml/khtmlview.h:
kwq/KWQEvent.mm: (QMouseEvent::QMouseEvent):
kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]): (-[WebCoreBridge mouseDown:]):
kwq/qt/qevent.h:

Renamed method.

Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences toggleDisplayImages:]): (-[AppearancePreferences initializeFromDefaults]):

Renamed method.

WebView.subproj/WebPreferences.h:
WebView.subproj/WebPreferences.m: (-[WebPreferences _updateWebCoreSettings]): (-[WebPreferences setWillLoadImagesAutomatically:]): (-[WebPreferences willLoadImagesAutomatically]):

5:24 PM Changeset in webkit [2025] by cblu

11 edits in trunk/WebKit

WebFoundation:

initialize WebError class in all class methods

Misc.subproj/WebError.m: (+[WebError classInitialize]): added, calls classInitialize() (-[WebError initWithErrorCode:inDomain:failingURL:isTerminal:]): call +classInitialize (+[WebError addErrorsFromDictionary:]): call +classInitialize

WebKit:

Report download handler errors
Renamed error constants
Added new errors

Misc.subproj/WebDownloadHandler.h:
Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler errorWithCode:]): added (-[WebDownloadHandler receivedData:]): return an error (-[WebDownloadHandler finishedLoading]): return an error (-[WebDownloadHandler cancel]): return an error
Misc.subproj/WebKitErrors.h: added new errors
WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowURL:]): use renamed error constants
WebView.subproj/WebMainResourceClient.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:forHandle:]): don't send an error when errors are suppressed (-[WebMainResourceClient didCancelWithHandle:]): report download handler errors (-[WebMainResourceClient handleDidFinishLoading:]): report download handler errors (-[WebMainResourceClient handleDidReceiveData:data:]): report download handler errors (-[WebMainResourceClient handleDidFailLoading:withError:]): report download handler errors
WebView.subproj/WebView.m: (+[WebView initialize]): add new errors to WebError

WebBrowser:

Renamed error constants

BrowserWebController.m: (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]): use renamed error constants
DownloadMonitor.m: (-[DownloadMonitor _monitorDownload:withProgress:error:dataSource:complete:]): clean-up
DownloadProgressEntry.m: (-[DownloadProgressEntry setError:]): handle errors in succession (-[DownloadProgressEntry setProgress:]): handle errors in succession

5:07 PM Changeset in webkit [2024] by hyatt

4 edits in trunk/WebCore

Fix FOUC to behave correctly. I was smoking crack when I
implemented this the first time (mainly because KHTML had
a badly named API that didn't mean even remotely what
I thought it should).

khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): (HTMLLinkElementImpl::setStyleSheet): (HTMLLinkElementImpl::sheetLoaded): (HTMLStyleElementImpl::childrenChanged): (HTMLStyleElementImpl::sheetLoaded):

4:36 PM Changeset in webkit [2023] by sullivan

3 edits in trunk/WebKit

WebKit:

History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _loadHistoryGuts:]): removed the ERROR message in the case where the history file was not found, as this is normal initial-state behavior.

WebBrowser:

fixed 3047715 -- "Favorites" should no longer be a special folder
fixed 3030996 -- Why can't I delete an empty Favorites?
some other miscellaneous cleanup

I haven't yet cleaned out all the old favorites-related code; wrote up
3047885 to represent that work.

BookmarksController.m: (-[BookmarksController imageForBookmark:]): don't special-case _favoritesRoot; use "tiny_menu" as the "standard size" image instead of "heart_small". (-[BookmarksController awakeFromNib]): remove call to (and method) _blessOrCreateFavoritesRoot; this makes _favoritesRoot always nil, so the other code that special-cases it will never do anything interesting. (-[BookmarksController _newBookmarkSheetDidEnd:returnCode:contextInfo:]): find toolbar item in pop-up menu a different way. (-[BookmarksController _addToolbarToMenu:]): new method, adds item to pop-up menu that represents toolbar (needs an image though -- see 3047876) (-[BookmarksController _setUpPopUpMenuForNewBookmarksController:]): add toolbar item to pop-up menu instead of coopting "Favorites" item.

BrowserWindowController.h,
BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]), (-[BrowserWindowController dealloc]): removed all references to favorites bar. (-[BrowserWindowController toggleLocationBarWithAnimation:]): fixed comment.

Defaults.plist: changed default "Add Bookmarks" location to "Toolbar"
English.lproj/Browser.nib: not sure what I changed, perhaps nothing.

PreferenceKeys.h: realphabetized.

Resources/Images/heart_small.tiff: Removed.
WebBrowser.pbproj/project.pbxproj: Updated for removed file.

4:07 PM Changeset in webkit [2022] by mjs

19 edits
2 adds in trunk

WebCore:

WebCore part of fix for:

2952837 - Slide shows on homepage.mac.com don't show pictures, captions
2942073 - Deferring [BrowserDocument goToInitialURL] can cause problems
3021360 - second window pops up on 'Search' at chrysler.com
3030485 - Unexpected new window created with no scroll bars at sony.com

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Reuse existing frame if possible. Pass frame name when opening a new window.
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Don't warn when opening a new window. Check non-descendant frames too. (KWQKHTMLPartImpl::urlSelected): Pass frame name when opening window.
kwq/WebCoreBridge.h: Add frameName argument to openNewWindowWithURL:.

WebKit:

WebKit part of fix for:

2952837 - Slide shows on homepage.mac.com don't show pictures, captions
2942073 - Deferring [BrowserDocument goToInitialURL] can cause problems
3021360 - second window pops up on 'Search' at chrysler.com
3030485 - Unexpected new window created with no scroll bars at sony.com

This is done by adding a concept of named controller sets, so that
less browser-like uses of WebKit won't be affected.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:frameName:]): Pass frameName parameter to controller initializer.

WebView.subproj/WebController.h:
WebView.subproj/WebController.m: (-[WebController init]): Pass nil for controllerSetName.

(-[WebController dealloc]):
(-[WebController frameNamed:]): Check other windows in the same set too.

WebView.subproj/WebControllerPrivate.h:
WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): (-[WebController _setDefersCallbacks:]): (-[WebController _setTopLevelFrameName:]): (-[WebController _frameInThisWindowNamed:]):
WebView.subproj/WebControllerSets.h: Added.
WebView.subproj/WebControllerSets.m: Added. (+[WebControllerSets addController:toSetNamed:]): Method to maintain controller sets. (+[WebControllerSets removeController:fromSetNamed:]): Likewise.
WebKit.pbproj/project.pbxproj: Add new files.

WebBrowser:

WebBrowser part of fix for:

2952837 - Slide shows on homepage.mac.com don't show pictures, captions
2942073 - Deferring [BrowserDocument goToInitialURL] can cause problems
3021360 - second window pops up on 'Search' at chrysler.com
3030485 - Unexpected new window created with no scroll bars at sony.com

BrowserWebController.m: (-[BrowserWebController initWithBrowserDocument:]): Pass controller set name when creating WebController.

2:29 PM Changeset in webkit [2021] by kocienda

8 edits in trunk/WebKit

WebFoundation:

Changed API for setting the WebResourceClient for a request/load.

This has been removed from WebResourceRequest, and has been moved to
WebResourceHandle. The result is that the init method for a WebResourceHandle
now takes a WebResourceRequest and a WebResourceClient.

All of the changes below are simple code modifications to use the new API.

CacheLoader.subproj/WebResourceHandle.h:
CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadInForeground:]) (-[WebResourceHandle client]) (-[WebResourceHandle initWithRequest:client:])
CacheLoader.subproj/WebResourceHandleInternal.h:
CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _notifyClientDidRedirectToURL]) (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]) (-[WebResourceHandle _notifyClientDidFailLoading]) (-[WebResourceHandle _notifyClientDidFinishLoading])
CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _userAgentForURL:])
CacheLoader.subproj/WebResourceRequest.h:
CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]) (-[WebResourceRequest initWithURL:attributes:flags:]) (-[WebResourceRequest initWithURL:userAgent:attributes:flags:]) (-[WebResourceRequest copyWithZone:]) (-[WebResourceRequest dealloc])
CacheLoader.subproj/WebResourceResponse.h:

WebKit:

Changed API for setting the WebResourceClient for a request/load.

This has been removed from WebResourceRequest, and has been moved to
WebResourceHandle. The result is that the init method for a WebResourceHandle
now takes a WebResourceRequest and a WebResourceClient.

All of the changes below are simple code modifications to use the new API.

Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad])
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:])
WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:])
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:])

11:47 AM Changeset in webkit [2020] by cblu

9 edits in trunk/WebKit

WebKit:

History.subproj/WebHistory.h:
History.subproj/WebHistory.m: (-[WebHistory entryForURL:]): added
History.subproj/WebHistoryPrivate.h:
History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate entryForURL:]): added
Misc.subproj/WebIconDatabase.h: added WebIconLargeSize
Misc.subproj/WebIconDatabase.m: added WebIconLargeSize
WebKit.exp: export link label key and WebIconLargeSize

WebBrowser:

Check history and the link's label when suggesting a bookmark title.

ContextMenuHandler.m: (-[ContextMenuHandler addLinkToBookmarks:]):

9:01 AM Changeset in webkit [2019] by darin

4 edits in trunk/WebCore

Add back the APPLE_CHANGES for a few frame cases. We need to do some real testing
before we remove our alternate versions of these (but I still hope we do remove them).

khtml/khtml_part.cpp: (KHTMLPart::findFrame): Back to the old way. (KHTMLPart::frameExists): Ditto. (KHTMLPart::frames): Ditto.

8:52 AM Changeset in webkit [2018] by darin

46 edits in trunk

WebCore:

fixed 2942809 -- remove all direct access to "WebKit" defaults from WebCore

kwq/WebCoreSettings.h: Add willLoadImagesAutomatically and userStyleSheetLocation.
kwq/WebCoreSettings.m: (-[WebCoreSettings _updateAllViews]): Added. Placeholder for a function that will cause all views to update styles and layout. (-[WebCoreSettings setStandardFontFamily:]): Call _updateAllViews if a change happened. (-[WebCoreSettings setFixedFontFamily:]): Ditto. (-[WebCoreSettings setSerifFontFamily:]): Ditto. (-[WebCoreSettings setSansSerifFontFamily:]): Ditto. (-[WebCoreSettings setCursiveFontFamily:]): Ditto. (-[WebCoreSettings setFantasyFontFamily:]): Ditto. (-[WebCoreSettings setMinimumFontSize:]): Ditto. (-[WebCoreSettings setDefaultFontSize:]): Ditto. (-[WebCoreSettings setDefaultFixedFontSize:]): Ditto. (-[WebCoreSettings setWillLoadImagesAutomatically:]): Added. (-[WebCoreSettings willLoadImagesAutomatically]): Added. (-[WebCoreSettings setUserStyleSheetLocation:]): Added. Call _updateAllViews if a change happened. (-[WebCoreSettings userStyleSheetLocation]): Added.

WebCore.exp: Add WebCoreSettings to the exported class list.

kwq/KWQKHTMLSettings.mm: Get settings from WebCoreSettings rather than going directly at WebKit user defaults.
kwq/KWQKConfigBase.mm: (KConfig::readNumEntry): Check key. (KConfig::readUnsignedNumEntry): Use WebCoreSettings to get the value of the "JavaScript can open windows automatically" setting, rather than going directly at a WebKit user default. (KConfig::readColorEntry): Remove log message. This is implemented well enough.

fixed 3015877 -- either wean WebCore from _web_URLFromString, or make it public API in WebFoundation

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::redirectionTimerStartedOrStopped): Use KURL to make an NSURL rather than using [NSURL _web_URLWithString:].
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::setBaseURL): Ditto.
kwq/WebCoreBridge.mm: (-[WebCoreBridge completeURLForDOMString:]): Ditto.

After fixing the above bugs, I noticed that I could remove the WebFoundation dependency.

WebCore.pbproj/project.pbxproj: Remove WebFoundation framework.

kwq/WebCoreBridge.h: Replace reportError with reportBadURL.
kwq/KWQLoaderImpl.mm: (KWQServeRequest): Use reportBadURL instead of reportError. This was the last bit of direct dependency on WebFoundation.

Do some preparation work for implementing "referrer".

khtml/khtml_part.cpp: Remove lots of APPLE_CHANGES and compile more original code. This in preparation for using the "referrer" code from KHTML.
khtml/khtmlview.h: Ditto.
khtml/misc/loader.cpp: Ditto.

kwq/kdecore/kurl.h: Add things needed by code formerly inside APPLE_CHANGES.
kwq/KWQKURL.mm: (KURL::hasRef): Ditto. (urlcmp): Implement in a simple-minded way. Needed by some code formerly inside APPLE_CHANGES. We can make a more full-featured version when and if we need it.
kwq/kio/global.h: Ditto.
kwq/kio/job.h: Ditto.
kwq/kio/jobclasses.h: Ditto.
kwq/KWQKjobclasses.mm: Ditto.
kwq/kparts/browserextension.h:
kwq/kparts/part.h: Ditto.
kwq/qt/qstringlist.h: Ditto.
kwq/KWQStringList.mm: (QStringList::pop_front): Ditto.
kwq/qt/qvaluelist.h: Ditto.
kwq/KWQValueListImpl.h: Ditto.
kwq/KWQValueListImpl.mm: (KWQValueListImpl::isEqual): Ditto.

Other changes.

kwq/KWQApplication.mm: (QApplication::setOverrideCursor): Don't report an error for this, it's OK to do nothing. (QApplication::restoreOverrideCursor): Ditto.

WebKit:

WebKit part of weaning WebCore from getting directly at WebKit defaults.

WebView.subproj/WebPreferences.h:
WebView.subproj/WebPreferences.m: (-[WebPreferences _updateWebCoreSettings]): Added. Propagates all preferences to WebCore. This way WebCore doesn't have to actively ask for the values of preferences using defaults keys that are WebKit secrets. (+[WebPreferences load]): Set up an observer that calls _updateWebCoreSettings whenever NSUserDefaultsDidChangeNotification is posted. (-[WebPreferences setStandardFontFamily:]): Call _updateWebCoreSettings right away, don't wait for NSUserDefaultsDidChangeNotification. (-[WebPreferences setFixedFontFamily:]): Ditto. (-[WebPreferences setSerifFontFamily:]): Ditto. (-[WebPreferences setSansSerifFontFamily:]): Ditto. (-[WebPreferences setCursiveFontFamily:]): Ditto. (-[WebPreferences setFantasyFontFamily:]): Ditto. (-[WebPreferences setDefaultFontSize:]): Ditto. (-[WebPreferences setDefaultFixedFontSize:]): Ditto. (-[WebPreferences setMinimumFontSize:]): Ditto. (-[WebPreferences setUserStyleSheetEnabled:]): Ditto. (-[WebPreferences setUserStyleSheetLocation:]): Ditto. (-[WebPreferences setJavaEnabled:]): Ditto. (-[WebPreferences setJavaScriptEnabled:]): Ditto. (-[WebPreferences setJavaScriptCanOpenWindowsAutomatically:]): Ditto. (-[WebPreferences setPluginsEnabled:]): Ditto. (-[WebPreferences setDisplayImages:]): Ditto.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportBadURL:]): Add this method, which replaces reportError. Now WebCore doesn't use WebFoundation directly at all! Pretty neat.

WebBrowser:

Preferences.subproj/ActiveContentPreferences.m: WebKit now calls it "Java", not "java".

Sep 9, 2002:

5:59 PM Changeset in webkit [2017] by rjw

8 edits in trunk

Implemented disable images automatically (2896319).

Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences toggleDisplayImages:]): (-[AppearancePreferences initializeFromDefaults]):

Implemented disable images automatically (2896319).

WebView.subproj/WebPreferences.h:
WebView.subproj/WebPreferences.m: (+[WebPreferences load]): (-[WebPreferences setDisplayImages:]): (-[WebPreferences displayImages]):

Implemented disable images automatically (2896319).

kwq/KWQKHTMLSettings.mm: (KHTMLSettings::autoLoadImages):

5:33 PM Changeset in webkit [2016] by darin

6 edits in trunk/WebKit

fixed 3003605 -- Leaking 1 WebView after second run of static PLT

Fixing this should also help with footprint.

WebView.subproj/WebFrame.m: (-[WebFrame dealloc]): Remove old workaround for problem where we always deallocated the frames from timer cleanup. I found a better fix for this. (-[WebFrame stopLoading]): Explicitly fire the scheduled layout timer if any when we stop loading, rather than leaving it hanging.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Explicitly fire the scheduled layout timer if any.

WebView.subproj/WebDataSource.m: (-[WebDataSource isLoading]): Use an autorelease pool here so we don't end up putting all the frames in the main event loop's autorelease pool.

Bookmarks.subproj/WebBookmark.m: (-[WebBookmark init]): Use copy instead of retain. (-[WebBookmark identifier]): Use copy instead of retain.

5:19 PM Changeset in webkit [2015] by darin

5 edits in trunk/WebCore

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::nextKeyView): Remove stray printf.

4:56 PM Changeset in webkit [2014] by hyatt

12 edits in trunk/WebCore

Switching over to the layer system for the handling of mouse
events.

khtml/rendering/render_flow.cpp: (RenderFlow::nodeAtPoint):
khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint):
khtml/rendering/render_layer.cpp: (RenderLayer::paint): (RenderLayer::nodeAtPoint): (RenderLayer::constructZTree):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::prepareMouseEvent):
kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): (-[WebCoreBridge elementAtPoint:]):
kwq/qt/qrect.h:

2:52 PM Changeset in webkit [2013] by kocienda

3 edits in trunk/WebKit

Missed one call through asking WebResourceHandle for contentLength
instead of WebResourceResponse.

Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:withHandle:]):

2:24 PM Changeset in webkit [2012] by kocienda

5 edits in trunk/WebKit

Content length information now accessible via WebResourceResponse object,
rather than from WebResourceHandle.

WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress initWithResourceHandle:]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:]):

2:20 PM Changeset in webkit [2011] by rjw

3 edits in trunk/WebKit

Make both calls to adjust CG font cache dynamic.
The new CGFontCacheSetMaxSize() adds a font cache
parameter. Ugh! This is needed so we can compile
w/o warnings on stock Jag.

WebCoreSupport.subproj/WebTextRendererFactory.m:

2:03 PM Changeset in webkit [2010] by kocienda

4 edits in trunk/WebKit

Character set information now accessible via WebResourceResponse object,
rather than from WebResourceHandle.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:]):

11:47 AM Changeset in webkit [2009] by cblu

3 edits in trunk/WebKit

WebKit:

Re-enable wizzy scaling.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconByScalingIcon:toSize:]):

WebBrowser:

LoadProgressMonitor.m: (-[LoadProgressMonitor _incrementProgressBarWithProgress:previousProgress:isMainResource:]): renamed (-[LoadProgressMonitor monitorResource:withProgress:error:dataSource:]): _incrementProgressBarWithProgress:previousProgress:isMainResource: (-[LoadProgressMonitor finishedLoadingFrame:]): stop progress bar only if data was received

11:32 AM Changeset in webkit [2008] by darin

4 edits in trunk/WebCore

khtml/rendering/render_layer.h: Add a call to delete to fix a storage leak.

10:47 AM Changeset in webkit [2007] by kocienda

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

I removed WebCacheLoaderConstantsPrivate.h, but did not check for who
was importing that file. Duh!

Includes now fixed.

CacheLoader.subproj/WebCacheObject.m:
CacheLoader.subproj/WebDiskCache.m:
CacheLoader.subproj/WebMemoryCache.m:
CacheLoader.subproj/WebResourceHandle.m:
CacheLoader.subproj/WebResourceHandleInternal.h:
CacheLoader.subproj/WebResourceHandlePrivate.h:
CacheLoader.subproj/WebResourceLoad.h:
Database.subproj/WebFileDatabase.m:

10:22 AM Changeset in webkit [2006] by darin

33 edits in trunk/WebCore

khtml/misc/helper.cpp: (khtml::setNamedColor): Add a missing return I spotted.

kwq/KWQApplication.mm:
kwq/KWQChar.mm:
kwq/KWQCompletion.mm:
kwq/KWQCursor.mm:
kwq/KWQEvent.mm:
kwq/KWQFontInfo.mm:
kwq/KWQFontMetrics.mm:
kwq/KWQInputDialog.mm:
kwq/KWQKConfigBase.mm:
kwq/KWQKFileDialog.mm:
kwq/KWQKFileItem.mm:
kwq/KWQKGlobalSettings.mm:
kwq/KWQKHTMLSettings.mm:
kwq/KWQKIconLoader.mm:
kwq/KWQKMimeType.mm:
kwq/KWQKSimpleConfig.mm:
kwq/KWQKjobclasses.mm:
kwq/KWQKnetaccess.mm:
kwq/KWQLineEdit.mm:
kwq/KWQScrollView.mm:
kwq/KWQString.mm:
kwq/KWQWidget.mm:
kwq/KWQbrowserinterface.mm:
kwq/KWQtextstream.mm:
kwq/KWQxml.mm: Change various LOG(NotYetImplemented) to ERROR, FATAL, or removed them entirely. This will help us with the task of getting every last one either "not implemented on purpose" or implemented. I'm not sure the NotYetImplemented log channel is useful, because it's chock full of continuous "direction not implemented" messages.

kwq/KWQLogging.h:
kwq/KWQLogging.m: Removed the NeverImplemented logging channel. The distinction is no longer worth keeping around. We use NotYetImplemented instead.

9:38 AM Changeset in webkit [2005] by kocienda

5 edits in trunk/WebKit

WebResourcehandle no longer has a contentType method.
Call through to WebResourceResponse object to get content type.

Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:withHandle:]):
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidReceiveData:data:]):

9:03 AM Changeset in webkit [2004] by darin

8 edits in trunk/WebKit

Fixed lifetime problems happening due to new cancel mechanism.

WebCoreSupport.subproj/WebSubresourceClient.m: Add comments explaining why retain/release is needed.
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _recursiveStopLoading]): Add a retain/release so that we don't run into problems if _stopLoading causes the data source to go away.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Add retain/release for similar reasons, with comment explaining why. (-[WebMainResourceClient handleDidFinishLoading:]): Ditto. (-[WebMainResourceClient handleDidFailLoading:withError:]): Ditto.

Fixed the problem that was leading to the NSImage exception, but didn't turn on
the whizzy scaling -- leaving that to Chris.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:]): Eliminate the "size 0x0" feature. It was only implemented in one place, and tons of other places would actually make a size 0x0 icon. But also, we don't need it any more.
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource iconLoader: receivedPageIcon:), (-[WebDataSource _loadIcon]): Don't bother actually passing the icon to [WebLocationChangeHandler receivedPageIcon:forDataSource:]. We should probably eventually either just get rid of this method, or remove the icon parameter.

8:35 AM Changeset in webkit [2003] by cblu

4 edits in trunk/WebKit

WebKit:

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconByScalingIcon:toSize:]): Commented out wizzy scaling as it was causing an NSImage exception to be raised.
Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin _getPluginInfo]): Check Resource Manager errors

WebBrowser:

BrowserWindowController.m: (-[BrowserWindowController textFieldWithProgressBar]): renamed, simplified (-[BrowserWindowController setProgressBarValue:]): call textFieldWithProgressBar (-[BrowserWindowController incrementProgressBarBy:]): call textFieldWithProgressBar
TextFieldWithControls.m: (-[TextFieldWithControls selectText:]): remove progress bar here

Sep 8, 2002:

11:25 PM Changeset in webkit [2002] by darin

4 edits in trunk/WebKit

WebFoundation:

Misc.subproj/WebAssertions.h: Use 0 instead of undefined for the XXX_DISABLED macros to be more consistent with the case where they are explicitly defined on purpose.

CacheLoader.subproj/WebHTTPProtocolHandler.m: Use #if ! rather than #ifndef with LOG_DISABLED, since it is set to 0 rather than not defined when LOG is enabled.

CacheLoader.subproj/WebResourceLoad.m: Same, but for ERROR, rather than LOG.

WebKit:

Plugins.subproj/WebPluginStream.m:
Plugins.subproj/WebPluginView.m: Use #if ! rather than #ifndef with LOG_DISABLED, since it is set to 0 rather than not defined when LOG is enabled.

WebBrowser:

BookmarksController.m:
GlobalHistory.m: Use #if ! rather than #ifndef with LOG_DISABLED, since it is set to 0 rather than not defined when LOG is enabled.

11:11 PM Changeset in webkit [2001] by darin

65 edits
4 adds
2 deletes in trunk/WebCore

Tools:

Scripts/update-kwq-assert: Added. Script to keep the KWQ version of the assert macros in sync. with the WebFoundation version. Just update the WebFoundation one and run this script.

wftool/WFTool.m: Remove obsolete include.

WebCore:

Switch over to new assertion/logging scheme.

kwq/KWQAssertions.h: Added.
kwq/KWQAssertions.m: Added.
kwq/KWQLogging.h: Added.
kwq/KWQLogging.m: Added.
kwq/kwqdebug.h: Removed.
kwq/kwqdebug.mm: Removed.
WebCore.pbproj/project.pbxproj: Update to reflect above changes.

kwq/KWQApplication.mm:
kwq/KWQChar.mm:
kwq/KWQColor.mm:
kwq/KWQComboBox.mm:
kwq/KWQCompletion.mm:
kwq/KWQCursor.mm:
kwq/KWQDrawUtil.mm:
kwq/KWQEvent.mm:
kwq/KWQFontInfo.mm:
kwq/KWQFontMetrics.mm:
kwq/KWQFrame.mm:
kwq/KWQHBox.mm:
kwq/KWQInputDialog.mm:
kwq/KWQInvisibleButton.mm:
kwq/KWQKConfigBase.mm:
kwq/KWQKFileDialog.mm:
kwq/KWQKFileItem.mm:
kwq/KWQKGlobalSettings.mm:
kwq/KWQKHTMLPartImpl.mm:
kwq/KWQKHTMLSettings.mm:
kwq/KWQKIconLoader.mm:
kwq/KWQKJob.mm:
kwq/KWQKLocale.mm:
kwq/KWQKMimeType.mm:
kwq/KWQKPartsEvent.mm:
kwq/KWQKSimpleConfig.mm:
kwq/KWQKURL.mm:
kwq/KWQKWin.mm:
kwq/KWQKWinModule.mm:
kwq/KWQKjobclasses.mm:
kwq/KWQKnetaccess.mm:
kwq/KWQLabel.mm:
kwq/KWQLineEdit.mm:
kwq/KWQListBox.mm:
kwq/KWQListImpl.mm:
kwq/KWQLoaderImpl.mm:
kwq/KWQObject.mm:
kwq/KWQPaintDeviceMetrics.mm:
kwq/KWQPainter.mm:
kwq/KWQPixmap.mm:
kwq/KWQRegion.mm:
kwq/KWQScrollView.mm:
kwq/KWQSlot.mm:
kwq/KWQString.mm:
kwq/KWQTimer.mm:
kwq/KWQWidget.mm:
kwq/KWQbrowserinterface.mm:
kwq/KWQtextcodec.mm:
kwq/KWQtextstream.mm:
kwq/KWQxml.mm:
kwq/WebCoreBridge.mm:
kwq/WebCoreCookieAdapter.m:
kwq/WebCoreHistory.m:
kwq/WebCoreImageRendererFactory.m:
kwq/WebCoreTextRendererFactory.m:
kwq/WebCoreViewFactory.m: Update to use new assertions and logging macros. In some cases, just removed unneeded includes.

11:06 PM Changeset in webkit [2000] by darin

19 edits in trunk/WebKit

Bookmarks.subproj/WebBookmarkGroup.m:
History.subproj/WebHistoryPrivate.m:
History.subproj/WebURLsWithTitles.m:
Misc.subproj/WebDownloadHandler.m:
Misc.subproj/WebIconDatabase.m:
Misc.subproj/WebIconLoader.m:
WebView.subproj/WebController.m:
WebView.subproj/WebDataSourcePrivate.m:
WebView.subproj/WebFrame.m:
WebView.subproj/WebFramePrivate.m:
WebView.subproj/WebHTMLView.m:
WebView.subproj/WebHTMLViewPrivate.m:
WebView.subproj/WebMainResourceClient.m:
WebView.subproj/WebPreferences.m:
WebView.subproj/WebViewPrivate.m: Remove unnecessary includes.

11:04 PM Changeset in webkit [1999] by darin

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m:
CacheLoader.subproj/WebCacheObject.m:
CacheLoader.subproj/WebDiskCache.m:
CacheLoader.subproj/WebHTTPProtocolHandler.m:
CacheLoader.subproj/WebMemoryCache.m:
CacheLoader.subproj/WebResourceHandle.m:
CacheLoader.subproj/WebResourceHandleInternal.m:
CacheLoader.subproj/WebResourceHandlePrivate.m:
CacheLoader.subproj/WebResourceLoad.m:
CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m:
CookieManager.subproj/WebCookie.m:
CookieManager.subproj/WebCookieManager.m:
CookieManager.subproj/WebCookieStorage.m:
Database.subproj/WebFileDatabase.m:
Misc.subproj/WebBinaryHeap.m:
Misc.subproj/WebReadWriteLock.m:
Misc.subproj/WebRecursiveReadWriteLock.m: Remove some unnecessary includes.

CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.h: Removed.
CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.m: Removed.
CacheLoader.subproj/WebHTTPResourceLoader.h: Removed.
CacheLoader.subproj/WebHTTPResourceLoader.m: Removed. Removed these files. The ChangeLog says they were removed a long time ago, but cvs doesn't agree.

5:22 PM Changeset in webkit [1998] by darin

22 edits
2 adds
3 deletes in trunk/WebKit

Update logging to use new implementation. Remove old.

Misc.subproj/WebKitDebug.h: Removed.
Misc.subproj/WebKitDebug.m: Removed.
Misc.subproj/WebKitLogging.h: Added.
Misc.subproj/WebKitLogging.m: Added.
Misc.subproj/WebKitReallyPrivate.h: Removed.
WebKit.pbproj/project.pbxproj: Update for above changes.

WebKit-tests.exp: Now empty.

History.subproj/WebHistoryItem.m: Remove unneeded include.

Bookmarks.subproj/WebBookmarkGroup.m:
History.subproj/WebHistoryPrivate.m:
Misc.subproj/WebDownloadHandler.m:
Misc.subproj/WebIconDatabase.m:
Plugins.subproj/WebPlugin.m:
Plugins.subproj/WebPluginDatabase.m:
Plugins.subproj/WebPluginNullEventSender.m:
Plugins.subproj/WebPluginStream.m:
Plugins.subproj/WebPluginView.m:
Plugins.subproj/npapi.m:
WebCoreSupport.subproj/WebTextRenderer.m:
WebView.subproj/WebDataSourcePrivate.m:
WebView.subproj/WebFrame.m:
WebView.subproj/WebFramePrivate.m:
WebView.subproj/WebHTMLView.m:
WebView.subproj/WebMainResourceClient.m: Change to use new log channels.

4:18 PM Changeset in webkit [1997] by darin

8 edits in trunk/WebKit

top level:

Tests/WebFoundationC/ifurlhandlec-test.c: (run): Remove begin and cancel testing.

WebKit:

Remove empty handleDidBeginLoading and handleDidCancelLoading
methods, now that they will never be called.

Misc.subproj/WebIconLoader.m:
Plugins.subproj/WebPluginStream.m:
WebCoreSupport.subproj/WebSubresourceClient.m:
WebView.subproj/WebMainResourceClient.m:

4:07 PM Changeset in webkit [1996] by darin

5 edits in trunk/WebKit

Forgot to save out files from the editor in my last change.

WebView.subproj/WebDataSource.m:
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: Oops.

3:53 PM Changeset in webkit [1995] by darin

11 edits in trunk/WebKit

Finished weaning us from handleDidCancelLoading. Now I will remove both
handleDidBeginLoading and handleDidCancelLoading.

WebCoreSupport.subproj/WebSubresourceClient.h: Add a handle method.
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidCancelLoading:]): Remove guts, move to cancel. (-[WebSubresourceClient handleDidFinishLoading:]): Remove the client from the data source now, not the handle. (-[WebSubresourceClient handleDidFailLoading:withError:]): Ditto. (-[WebSubresourceClient cancel]): Move guts here, also make the above change. (-[WebSubresourceClient handle]): Added.

WebView.subproj/WebDataSource.m: Use clients list, not handles list.
WebView.subproj/WebDataSourcePrivate.h: Keep a list of subresource clients rather than a list of handles for the subresources.
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Update to match new field names. (-[WebDataSource _updateLoading]): Use clients, not handles. (-[WebDataSource _startLoading:]): Move line about starting loading out of the if statement. I suspect the if statement is always true, though. (-[WebDataSource _addSubresourceClient:]): New name. Keep client pointer instead of handle now. (-[WebDataSource _removeSubresourceClient:]): Ditto. (-[WebDataSource _stopLoading]): Move download handler line into WebMainResourceClient since the "not sent when application is quitting" issue is gone now. Stop the subresource clients using the cancel call, not by cancelling the handle directly. (-[WebDataSource _defersCallbacksChanged]): Update for clients list, not handles list.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Cancel the download handler here. (-[WebMainResourceClient handleDidReceiveData:data:]): Call didCancelWithHandle here. A loose end from the previous change.

2:48 AM Changeset in webkit [1994] by hyatt

20 edits in trunk/WebCore

Landing the new layer system and turning it on for painting of
all types of positioned blocks (and for painting the root
and HTML layers as well).

Event handling is not yet using the new layer system, so you
may see oddities like DHTML menus now displaying correctly but
events not working (since the event code may still be stacking
incorrectly and think the DHTML is behind other content).

khtml/css/cssstyleselector.cpp:
khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::calcHeight): (RenderBox::calcAbsoluteHorizontal):
khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode):
khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): (RenderFlow::printObject): (RenderFlow::printSpecialObjects): (RenderFlow::layout): (RenderFlow::layoutSpecialObjects): (RenderFlow::layoutBlockChildren): (RenderFlow::insertSpecialObject):
khtml/rendering/render_flow.h:
khtml/rendering/render_html.cpp: (RenderHtml::layout):
khtml/rendering/render_image.cpp: (RenderImage::printObject):
khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition): (RenderLayer::enclosingAncestor): (RenderLayer::addChild): (RenderLayer::convertToLayerCoords): (RenderLayer::paint): (RenderLayer::constructZTree): (RenderLayer::RenderZTreeNode::constructLayerList):
khtml/rendering/render_layer.h:
khtml/rendering/render_replaced.cpp: (RenderReplaced::print): (RenderWidget::printObject):
khtml/rendering/render_root.cpp: (RenderRoot::calcHeight): (RenderRoot::layout): (RenderRoot::printObject):
khtml/rendering/render_root.h:
khtml/rendering/render_style.cpp: (StyleBoxData::StyleBoxData): (StyleBoxData::operator==):
khtml/rendering/render_style.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
kwq/qt/qrect.h:

Sep 7, 2002:

4:55 PM Changeset in webkit [1993] by cblu

3 edits in trunk/WebKit

WebKit:

Made the wizzy scaling an experiment.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconByScalingIcon:toSize:]):

WebBrowser:

Text field/location bar combo
Added a defaults key "Experiments" as a way to toggle experimental features, behaviors etc.
Added an "Experiments" debug menu item. Vague, but couldn't think of a better title.
The text field/location bar combo is an "Experiment".

"Experiments" is off by default.

AppController.m: (-[AppController enableExperiments:]): toggle the default
BrowserWindowController.h:
BrowserWindowController.m: (-[BrowserWindowController setActivity:]): set _previousActivity so we know if we were searching or loading (-[BrowserWindowController textFieldToUpdateProgress]): added, returns the current text field that is showing a progress bar (-[BrowserWindowController setProgressBarValue:]): added, calls setProgressBarValue on current text field (-[BrowserWindowController incrementProgressBarBy:]): added, calls incrementProgressBarBy on current text field
Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]):
LoadProgressMonitor.h:
LoadProgressMonitor.m: (-[LoadProgressMonitor initWithBrowserDocument:]): set _maxIncrement to the default (-[LoadProgressMonitor _setProgressBarValueToZero]): added (-[LoadProgressMonitor _stopProgressBar]): added (-[LoadProgressMonitor _incrementProgressBarWithProgress:previousProgress:isFrame:]): added, progress algorithm here (-[LoadProgressMonitor monitorResource:withProgress:error:dataSource:]): call _incrementProgressBarWithProgress:previousProgress:isFrame: (-[LoadProgressMonitor finishedLoadingFrame:]): call _stopProgressBar
LocationTextField.m: (-[LocationTextField setDisplayAttributes]): set progress images
PreferenceKeys.h:
Resources/Images/Location_Left_Progress.tif: Added.
Resources/Images/Location_Middle_Progress.tif: Added.
Resources/Images/Location_Right_Progress.tif: Added.
Resources/Images/Search_Left_Progress.tif: Added.
Resources/Images/Search_Middle_Progress.tif: Added.
Resources/Images/Search_Right_Progress.tif: Added.
SearchTextField.m: (-[SearchTextField setDisplayAttributes]): set progress images
TextFieldWithControls.h:
TextFieldWithControls.m: (-[TextFieldWithControls becomeFirstResponder]): call setIsShowingProgressBar:NO (-[TextFieldWithControls textDidEndEditing:]): call setIsShowingProgressBar:YES (-[TextFieldWithControls dealloc]): release progress images (-[TextFieldWithControls backgroundImage]): added logic for showing progress bar (-[TextFieldWithControls setLeftProgressImage:]): added (-[TextFieldWithControls setRightProgressImage:]): added (-[TextFieldWithControls setMiddleProgressImage:]): added (-[TextFieldWithControls isShowingProgressBar]): added (-[TextFieldWithControls setIsShowingProgressBar:]): added (-[TextFieldWithControls setProgressBarValue:]): added (-[TextFieldWithControls incrementProgressBarBy:]): added
WebBrowser.pbproj/project.pbxproj:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed