Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Sep 13, 2002:

9:01 PM Changeset in webkit [2070] by rjw

• 3 edits in trunk/WebKit

Fixed 3051288. URLs were not being canonicalized, so matching failed.

• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addEntry:]): (-[WebHistoryPrivate removeEntry:]): (-[WebHistoryPrivate containsURL:]): (-[WebHistoryPrivate entryForURL:]):

8:30 PM Changeset in webkit [2069] by rjw

• 3 edits in trunk/WebKit

Fixed 3050636. 90% solution. The "Display Images Automatically"
preference will be used to disallow image draggging. So if this
is set after pages have loaded, their images will not be draggable,
and vice-versa. Not disastrous as dragging in either case has little
or no negative consequences.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

7:05 PM Changeset in webkit [2068] by hyatt

• 20 edits in trunk/WebCore

Landing code that makes textfields, buttons, checkboxes, radio
buttons, and dropdown lists all draw correctly with respect to
z-index. They all employ the same simple hack (just never paint
unless KHTML tells them to).

Unpatched widgets include the password field, the listbox, and the
textarea.

The only issue with regards to painting with the widgets I've
patched is the textfield... its editor floats to the top when the
field is being edited.

Event handling will also be incorrect and will need to be patched
separately.

• khtml/rendering/render_body.cpp: (RenderBody::printBoxDecorations):
• khtml/rendering/render_replaced.cpp: (RenderWidget::printObject):
• kwq/KWQButton.mm: (QButton::QButton): (QButton::paint): (-[KWQNSButton drawRect:]): (-[KWQNSButton paint]):
• kwq/KWQComboBox.mm: (-[KWQNSPopUpButton drawRect:]): (-[KWQNSPopUpButton paint]): (QComboBox::QComboBox): (QComboBox::insertItem): (QComboBox::paint):
• kwq/KWQLineEdit.mm: (QLineEdit::paint):
• kwq/KWQNSTextField.h:
• kwq/KWQNSTextField.mm: (-[KWQNSTextField paint]):
• kwq/qt/qbutton.h:
• kwq/qt/qcombobox.h:
• kwq/qt/qlineedit.h:
• kwq/qt/qwidget.h:

6:07 PM Changeset in webkit [2067] by rjw

• 5 edits in trunk/WebCore

Fixed navigation to link on mouse up after drag.

• khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): Change khtml's definition of double click to be based on mouse up of second click, not mouse down.

(KHTMLView::viewportMouseReleaseEvent):

• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]): (-[WebCoreBridge mouseDown:]): Changed double click to be on mouse up with click count of two.

5:53 PM Changeset in webkit [2066] by mjs

• 6 edits in trunk/WebKit

WebFoundation:

WebFoundation changes for:

• fixed 3032238 - Eliminate "Ask each time" choice for cookies

I also unwound some now-needless async code paths.

• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.h:
• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler endLoadInBackground]): (-[WebCFNetworkHTTPProtocolHandler handleReadStreamEvent:event:]): (-[WebCFNetworkHTTPProtocolHandler setResponseHeadersUsingHTTPResponse:andCall:context:]): (-[WebCFNetworkHTTPProtocolHandler performStreamRead:]):
• CookieManager.subproj/IFCookieAcceptHandlerC.h: Removed.
• CookieManager.subproj/IFCookieAcceptHandlerC.m: Removed.
• CookieManager.subproj/IFCookieAcceptRequestC.h: Removed.
• CookieManager.subproj/IFCookieAcceptRequestC.m: Removed.
• CookieManager.subproj/IFCookieManagerC.h:
• CookieManager.subproj/IFCookieManagerC.m: (IFCookieManagerSetCookiesFromResponseHeaders):
• CookieManager.subproj/WebCookieAcceptHandler.h: Removed.
• CookieManager.subproj/WebCookieAcceptHandlerDispatcher.h: Removed.
• CookieManager.subproj/WebCookieAcceptHandlerDispatcher.m: Removed.
• CookieManager.subproj/WebCookieAcceptRequest.h: Removed.
• CookieManager.subproj/WebCookieAcceptRequest.m: Removed.
• CookieManager.subproj/WebCookieAcceptRequestPrivate.h: Removed.
• CookieManager.subproj/WebCookieConstants.h:
• CookieManager.subproj/WebCookieManager.h:
• CookieManager.subproj/WebCookieManager.m: (-[WebCookieManagerPrivate init]): (-[WebCookieManagerPrivate dealloc]): (-[WebCookieManager _readAcceptCookiesPreference]): (-[WebCookieManager _setCookies:forURL:]): (-[WebCookieManager setCookie:]): (-[WebCookieManager setCookiesFromResponseHeaders:forURL:]):
• Misc.subproj/WebFoundation.h:
• WebFoundation.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

WebKit changes for:

• fixed 3032238 - Eliminate "Ask each time" choice for cookies

• Panels.subproj/WebStandardPanels.h:
• Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels useStandardAuthenticationPanel]):
• WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]):
• WebKit.pbproj/project.pbxproj:

WebBrowser:

WebBrowser changes for:

• fixed 3032238 - Eliminate "Ask each time" choice for cookies

• AppController.m: (-[AppController awakeFromNib]):
• Preferences.subproj/English.lproj/SecurityPreferences.nib:
• Preferences.subproj/SecurityPreferences.h:
• Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):

5:35 PM Changeset in webkit [2065] by darin

• 4 edits in trunk/WebCore

Fix crash in slot code.

• kwq/KWQSignal.mm: (KWQSignal::call): Copy the slots before calling through in case we are destroyed by the called function.

5:02 PM Changeset in webkit [2064] by darin

• 11 edits in trunk

WebCore:

Here's the *real* mistake that killed plugins. I accidentally
stopped creating objects at all! Duh. Fixed now.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart): Make a part for a plugin if we need one. Not a KHTMLPart, but a KWQPluginPart.

WebKit:

Added assertions, and dealt with some breakage I created while
trying to fix, here, what I broke in WebCore.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView start]): Do get the dataSource from our parent when we are being used as an object in a view rather than a document view.

• Plugins.subproj/WebPluginStream.m:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebFrame.m: Leave in the assertions I used to debug.

3:57 PM Changeset in webkit [2063] by darin

• 10 edits in trunk/WebKit

WebKit:

• fixed 3031685 -- The text encoding setting is not propagated to subframes

• WebView.subproj/WebDocument.h: Remove old WebDocumentTextEncoding methods, add supportsTextEncoding.
• WebView.subproj/WebController.m: (-[WebController supportsTextEncoding]): Check the document view to see if it supports WebDocumentTextEncoding and returns YES. (-[WebController setCustomTextEncoding:]): Call _reloadAllowingStaleDataWithOverrideEncoding. (-[WebController resetTextEncoding]): Ditto. (-[WebController _mainFrameOverrideEncoding]): Added. Gets encoding from the data source of the main frame; provisional if there, main if not. (-[WebController hasCustomTextEncoding]): Call _mainFrameOverrideEncoding. (-[WebController customTextEncoding]): Ditto.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setParent:]): Set the override encoding to the parent's.

• WebView.subproj/WebFrame.m: (-[WebFrame reload]): Release request to fix storage leak. Set the override encoding on the new data source to match the old.

• WebView.subproj/WebFramePrivate.h: New name for stale data reload method.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): Do pretty much the same thing reload does with a few differences. Get the encoding from the parameter rather than the old data source, and set the policy to the one that uses data from the cache, even stale data, if present

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView supportsTextEncoding]): Return YES.

WebBrowser:

WebCore part of text encoding fix.

• BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Call the new WebKit methods. (-[BrowserWindowController changeTextEncoding:]): Ditto.

3:38 PM Changeset in webkit [2062] by rjw

• 16 edits in trunk

Made justified text work correctly in khtml for rendering
and selection. Optimized selection point calculation by
only doing characters measurements once.

• khtml/rendering/font.cpp: (Font::floatCharacterWidths):
• khtml/rendering/font.h:
• khtml/rendering/render_text.cpp: (TextSlave::checkSelectionPoint): (RenderText::position):
• kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths):
• kwq/KWQPainter.mm: (QPainter::drawText):
• kwq/WebCoreTextRenderer.h:
• kwq/qt/qfontmetrics.h:

Adding padding and widths buffer to our canonical measurement
method. The padding argument is used to 'pad' measurements in
that same way that drawing is padded. The widths parameter
allows a caller to pass a buffer to get all the individual
character widths for the run of characters in the string.

• Misc.subproj/WebStringTruncator.m: (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
• WebCoreSupport.subproj/WebTextRenderer.h:
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]):

3:26 PM Changeset in webkit [2061] by darin

• 7 edits in trunk/WebCore

Quiet error messages related to the slot/signal changes.

• khtml/khtml_part.cpp: (KHTMLPart::startAutoScroll): Ifdef this out. (KHTMLPart::stopAutoScroll): Ditto.

• kwq/KWQObject.mm: (QObject::connect): Add two more expected members to the list for setStatusBarText and slotViewCleared.

• kwq/KWQSignal.h: Allow 4 slots per signal. I don't want to make it a variable number, but we can if we have to.
• kwq/KWQSignal.mm: (KWQSignal::connect): Support multiple slots. (KWQSignal::disconnect): Support multiple slots. (KWQSignal::call): Support multiple slots.

2:35 PM Changeset in webkit [2060] by darin

• 5 edits in trunk/WebKit

Fix dataSource-related plugin crash.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView start]): Don't grab dataSource here. It's too early. (-[WebNetscapePluginView setDataSource:]): Grab it here.

• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: Simplified includes and added asserts while debugging.

2:32 PM Changeset in webkit [2059] by darin

• 12 edits in trunk/WebCore

Fix assertion that happens on any page that has a non-HTML frame.

We were sending signals for objects in m_objects that are only supposed
to be sent for frames in m_frames. The fix is to use actual slot/signal
connections instead of our hard-coded logic.

• kwq/KWQKHTMLPartImpl.h: Add signals for started and completed.
• kwq/KWQKHTMLPartImpl.mm: (KHTMLPart::completed): Emit completed signal. (KHTMLPart::started): Emit started signal. (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Create signals.

• kwq/KWQObject.mm: (QObject::connect): Write out an error message if we see any signal connections to signals that aren't implemented, with a hardwired exception list for ones we either aren't ever going to do or just haven't gotten around to yet.

• kwq/KWQSignal.h: Add support for signals that take bool and KIO::Job *.
• kwq/KWQSignal.mm: (KWQSignal::connect): Put in an actual ERROR call for the case where this fails. (KWQSignal::disconnect): Put in an actual ERROR call for the case where it fails. (KWQSignal::call): Add overloads for bool and KIO::Job *.

• kwq/KWQSlot.h: Add support for slots that take bool and KIO::Job *.
• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Add four new members. (KWQSlot::call): Add overloads for bool and KIO::Job * and support for the new members.

1:06 PM Changeset in webkit [2058] by rjw

• 3 edits in trunk/WebKit

Changed drag hysteresis to 5 and disallow selection initiation within
a link.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

7:50 AM Changeset in webkit [2057] by darin

• 48 edits in trunk

top level:

• Tests/WebFoundation-Misc/ifnsurlextensions-test.m: Remove uneeded include of NSURLPathUtilities.h.

WebCore:

• kwq/KWQAssertions.h: Update assertions from from the copy in WebFoundation.
• WebCorePrefix.h: Remove NSURLPathUtilities.h include.

Use even more of the KHTML code so we get referrers in one more place.

• kwq/WebCoreBridge.h: Add referrer to createChildFrameNamed.

• khtml/khtml_part.h: Less APPLE_CHANGES, no substantive change.
• khtml/khtml_part.cpp: (KHTMLPart::requestFrame): Use more of this, less APPLE_CHANGES. (KHTMLPart::requestObject): Ditto. (KHTMLPart::processObjectRequest): Ditto.

• khtml/rendering/render_frames.h: Less APPLE_CHANGES.
• khtml/rendering/render_frames.cpp: Less APPLE_CHANGES.

• kwq/kparts/browserextension.h: Add lockHistory/setLockHistory and openURLNotify.

• kwq/khtml/khtml_ext.h: Add openURLNotify.
• kwq/KWQKHTMLPartImpl.h: Add openURLNotify.
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::openURLNotify): Implement.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart): Changed name from requestFrame. Do less work.

• kwq/qt/qtimer.h: Add singleShot.
• kwq/KWQTimer.mm: (+[KWQSingleShotTimerTarget targetWithQObject:member:]): Added. Used to implement singleShot. (-[KWQSingleShotTimerTarget dealloc]): Ditto. (-[KWQSingleShotTimerTarget timerFired:]): Ditto. (QTimer::singleShot): Added.

• kwq/qt/qmap.h: Add contains.

• kwq/qt/qvaluelist.h: Add iterator return value for append and prepend.
• kwq/KWQValueListImpl.h: Add iterator return value for appendNode and prependNode.
• kwq/KWQValueListImpl.mm: (KWQValueListImpl::appendNode): Add iterator. (KWQValueListImpl::prependNode): Add iterator.

• kwq/kparts/part.h: Add openURL.

WebKit:

Prep work for fixes to the text encoding for subframes.

• WebCoreSupport.subproj/WebBridge.h: Remove [loadURL:withParent:].
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Added referrer parameter.

• WebView.subproj/WebController.h: Add new methods, not implemented yet.
• WebView.subproj/WebController.m: (-[WebController supportsTextEncoding]): Here is one. (-[WebController setCustomTextEncoding:]): Another. (-[WebController resetTextEncoding]): Etc. (-[WebController hasCustomTextEncoding]): Etc. (-[WebController customTextEncoding]): Etc.

• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource startLoading]): Remove the forceRefresh flag. This is now controlled by the WebResourceRequest.
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Same for this private version.
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m: (-[WebFrame startLoading]): Remove the forceRefresh flag. (-[WebFrame reload]): Remove the forceRefresh flag. A reload without a forceRefresh is only used internally, not requested by the caller.

• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Add handling for the case where we reload, but allow stale data. (-[WebFrame _isLoadComplete]): Ditto. (-[WebFrame _reloadAllowingStaleData]): Placeholder, not implemented yet.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView setTextEncoding:]): Update for new API, but this is going away. (-[WebHTMLView setDefaultTextEncoding]): Ditto.

WebBrowser:

• BrowserDocument.m: (-[BrowserDocument refresh:]): Call the new [reload] instead of the old [reload:].

Sep 12, 2002:

11:48 PM Changeset in webkit [2056] by rjw

• 3 edits in trunk/WebKit

Don't initiate a drag if an autoscroll happened.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

8:21 PM Changeset in webkit [2055] by rjw

• 11 edits in trunk

Added "Absolute" position to the render tree view. Useful
to see how kthml LIES!

• Debug/RenderTree.m: (-[RenderTreeDataSource outlineView:objectValueForTableColumn:byItem:]):
• Debug/RenderTree.nib:

Added absolute position column to render node for
render tree view.

• WebView.subproj/WebRenderNode.h:
• WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithName:position:rect:view:children:]): (-[WebRenderNode absolutePositionString]): (-[WebKitRenderTreeCopier nodeWithName:position:rect:view:children:]):

Rewrite of khtml selection drawing code. Now does
a delta between old and new selection and only
draw those objects that have changed. Selection
drawing is now MUCH faster.

• khtml/rendering/render_root.cpp: (enclosingPositionedRect): (RenderRoot::setSelection): (RenderRoot::clearSelection):
• khtml/rendering/render_root.h:

Added additional absolute position property to render node
stuff for debug render tree view.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge copyRenderNode:copier:]):

6:35 PM Changeset in webkit [2054] by hyatt

• 4 edits in trunk/WebKit

Add text/xml to our list of MIME types that should use the
Web view. With this fix we now render XML and XHTML
correctly!

• WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]):
• WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]):

6:04 PM Changeset in webkit [2053] by hyatt

• 5 edits in trunk/WebCore

KHTML was butchering the laws of background propagation from
the <body> to the <html>. This fixes the logical flaws and
makes some of the geekiest CSS on the planet render correctly. ;)

• khtml/rendering/render_body.cpp: (RenderBody::printBoxDecorations):
• khtml/rendering/render_html.cpp: (RenderHtml::printBoxDecorations):

5:19 PM Changeset in webkit [2052] by hyatt

• 4 edits in trunk/WebCore

Make fixed positioned elements work when you scroll. We were
just missing the implementation of a QScrollView method.

• kwq/KWQScrollView.mm: (QScrollView::setStaticBackground):

3:23 PM Changeset in webkit [2051] by hyatt

• 4 edits in trunk/WebCore

Fix a bug in KHTML that leads it to claim cached @imported stylesheets
are not loaded (when in fact they are).

This fixes the W3C CSS page.

• khtml/css/css_ruleimpl.cpp: (CSSImportRuleImpl::init):

2:51 PM Changeset in webkit [2050] by kocienda

• 12 edits in trunk/WebKit

WebFoundation:

Removed load flags as a design concept. Replaced with new "caching policy" concept
which are set on a WebResourceRequest. These policies determine how a load will
be processed with regards to the cache.

• CacheLoader.subproj/IFURLHandleC.h: Removed obsolete IFURLHandleGetFlags function
• CacheLoader.subproj/IFURLHandleC.m: Ditto.
• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler continueHeaderReadAfter3xxResponseAndCall:]): Temporary hack until new redirect API is available.
• CacheLoader.subproj/WebCacheLoaderConstants.h: Removed all load flags.
• CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler determineErrorAndFail]): Removed calls to load flags and replaced with calls to new request policies. (-[WebHTTPProtocolHandler testAndSetCacheObjectState:]): Ditto.
• CacheLoader.subproj/WebResourceHandle.m: Removed flags accessor, and removed calls to load flags and replaced with calls to new request policies. (-[WebResourceHandle description]): Removed calls to load flags and replaced with calls to new request policies.
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad _beginLoad]): Ditto. (-[WebResourceLoad description]): Ditto.
• CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]): Ditto. (+[WebResourceLoadKey keyWithLoad:]): Ditto. (-[WebResourceLoadKey isEqual:]): Ditto. (-[WebResourceLoadKey hash]): Ditto. (-[WebResourceLoadManager requestWithURLHandle:]): Ditto. (-[WebResourceLoadManager loadDidFinish:]): Ditto.
• CacheLoader.subproj/WebResourceRequest.h: Added new WebRequestCachePolicy and WebResponseCachePolicy enums, and accessor methods to set these values on a request.
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]): Ditto. (-[WebResourceRequest requestCachePolicy]): Added. (-[WebResourceRequest setRequestCachePolicy:]): Added. (-[WebResourceRequest responseCachePolicy]): Added. (-[WebResourceRequest setResponseCachePolicy:]): Added (-[WebResourceRequest copyWithZone:]): Removed calls to load flags and replaced with calls to new request policies.
• CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m: (WebSimpleHTTPProtocolHandlerInit): Added some initial support for the notion of "specially-handled" headers. This work is not done yet. (-[WebSimpleHTTPProtocolHandler createHTTPRequest]): Fixed case where we appended nil if there was no user-agent set. (-[WebSimpleHTTPProtocolHandler _examineHeaders]): Removed calls to load flags and replaced with calls to new request policies.
• Misc.subproj/WebFoundation.h:
• WebFoundation.exp: Removed obsolete _IFURLHandleGetFlags symbol.

WebKit:

Removed load flags as a design concept. Replaced with new "caching policy" concept
which are set on a WebResourceRequest. These policies determine how a load will
be processed with regards to the cache.

• WebCoreSupport.subproj/WebBridge.h: Removed flags from loadURL method.
• WebCoreSupport.subproj/WebBridge.m: Removed calls to load flags and replaced with calls to new request policies. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge isReloading]): Ditto. (-[WebBridge loadURL:referrer:]): Ditto. (-[WebBridge loadURL:withParent:]): Removed flags from loadURL method. (-[WebBridge postWithURL:referrer:data:]): Removed calls to load flags and replaced with calls to new request policies.
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Ditto.
• WebView.subproj/WebDataSource.h: Removed flags from init method.
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:]): Ditto. (-[WebDataSource initWithRequest:]): Ditto.
• WebView.subproj/WebDataSourcePrivate.h: Removed flags ivar, and dangling attributes ivar.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Ditto.
• WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Removed calls to load flags and replaced with calls to new request policies.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Ditto.

1:25 PM Changeset in webkit [2049] by cblu

• 4 edits in trunk/WebCore

Fixed livepage crash on Marklar. It is naughty to divide by 0 on marklar so we now check before doing that.

• khtml/rendering/render_box.cpp: (RenderBox::printBackground):

12:15 PM Changeset in webkit [2048] by hyatt

• 4 edits in trunk/WebCore

Fix crash on trekweb.com. My simplified FOUC code was a little
bit too simple. ;)

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::setStyleSheet): (HTMLStyleElementImpl::childrenChanged):

12:05 PM Changeset in webkit [2047] by hyatt

• 8 edits in trunk/WebCore

Fix the Warcraft 3 page on blizzard.com so that the relative
positioned blocks inside centered tables inside enclosing tables
with percentage widths work correctly.

This fix also causes the textfields on mrskin.com to show up
again.

• khtml/rendering/render_box.cpp: (RenderBox::RenderBox): (RenderBox::setPos):
• khtml/rendering/render_box.h:
• khtml/rendering/render_container.cpp: (RenderContainer::addChild):
• khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
• khtml/rendering/render_object.h:

8:53 AM Changeset in webkit [2046]

• 3 copies in tags/Alexander-23

This commit was manufactured by cvs2svn to create tag 'Alexander-23'.

8:53 AM Changeset in webkit [2045] by cblu

• 5 edits in trunk/WebKit

WebKit:

Make WebTextView private and exported.

• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebTextView.h:

WebBrowser:

Show HTML source in Alex.

• BrowserDocument.h:
• BrowserDocument.m: (-[BrowserDocument viewSource:]): create new HTMLSourceDocument
• BrowserDocumentController.h:
• BrowserDocumentController.m: (-[BrowserDocumentController openHTMLSourceDocumentWithDataSource:]): added
• ContextMenuHandler.m: (-[ContextMenuHandler viewSource:]): create new HTMLSourceDocument
• English.lproj/HTMLSource.nib: Added.
• HTMLSourceController.h: Added.
• HTMLSourceController.m: Added. (-[HTMLSourceController windowDidLoad]): (-[HTMLSourceController setString:]): (-[HTMLSourceController targetForSearch]):
• HTMLSourceDocument.h: Added.
• HTMLSourceDocument.m: Added. (-[HTMLSourceDocument initWithDataSource:]): (-[HTMLSourceDocument dealloc]): (-[HTMLSourceDocument makeWindowControllers]): (-[HTMLSourceDocument dataRepresentationOfType:]): (-[HTMLSourceDocument saveDocumentTo:]): (-[HTMLSourceDocument fileName]): (-[HTMLSourceDocument fileType]): (-[HTMLSourceDocument displayName]):
• WebBrowser.pbproj/project.pbxproj:

Sep 11, 2002:

11:53 PM Changeset in webkit [2044] by mjs

• 4 edits in trunk/WebCore

WebCore:

Don't show the window here any more, now that WebBrowser will set
it up to be shown properly itself.

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):

WebBrowser:

Changed new window opening to happen right away instead of waiting
until the content policy is known. This avoids the horrible lack
of feedback and feeling of slowness on new window opening, but
re-introduces the problem that command-clicking on a link that
downloads leaves around an empty window (Radar 3049296).

While I was at it, I made goToInitialURL get called right away
instead of deferring it, since the problems that arose from
calling it right away before no longer apply.

• fixed Radar 3017596 - Cmd click on link doesn't display new window fast enough
• fixed Radar 3049291 - Deferring goToInitialURL can cause problems

• BrowserDocument.h:
• BrowserDocument.m: Remove methods and code related to awaiting the content policy, since we no longer wait for it.
• BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:referrer:display:]): Show the window next time through the event loop. (-[BrowserDocumentController _createEmptyBrowserDocumentAndDisplay:]): Show the window next time through the event loop.
• BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:URL:inFrame:]): No more need to show or close window when content policy is determined.
• BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Go to initial URL immediately, not after delay.

6:59 PM Changeset in webkit [2043] by hyatt

• 4 edits in trunk/WebCore

Fix horizontal scrolling. The HTML render object lies. It lies,
I tell you.

• khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):

6:01 PM Changeset in webkit [2042] by hyatt

• 11 edits in trunk/WebCore

Fix clipping to work with layers. This fixes the marquee
(once again) on livepage.apple.com.

• khtml/rendering/render_box.cpp: (RenderBox::getClipRect):
• khtml/rendering/render_box.h:
• khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode):
• khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): (RenderFlow::printObject):
• khtml/rendering/render_layer.cpp: (RenderLayer::enclosingPositionedAncestor): (RenderLayer::convertToLayerCoords): (RenderLayer::paint): (RenderLayer::constructZTree):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.cpp: (RenderReplaced::print):

4:23 PM Changeset in webkit [2041] by darin

• 4 edits in trunk/WebCore

WebFoundation:

• Misc.subproj/WebAssertions.h: Changed assertions to use a different technique for varargs, which seems to work better on Claudius. Sorry about the nearly-full build.

• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest setMethod:]): Store a copy so we don't end up retaining a mutable string that the caller then modifies. (-[WebResourceRequest setHeaders:]): Allow nil for theHeaders, and make an empty dictionary in that case. (-[WebResourceRequest setHeader:forKey:]): Store a copy so we don't end up putting a reference to a mutable string in our dictionary. (-[WebResourceRequest addHeader:forKey:]): Ditto. (-[WebResourceRequest setExtraCookies:]): Ditto, same applies for NSArray. (-[WebResourceRequest setData:]): Ditto, same for NSData.

WebCore:

• kwq/KWQAssertions.h: Updated copy of the assertions macros (made by script).

4:10 PM Changeset in webkit [2040] by mjs

• 8 edits in trunk/WebKit

Combined provisionalDataSourceChanged: and
provisionalDataSourceCommitted: methods into a single
setDataSource:, since they are always called one immediately after
the other.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setDataSource:]): (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]):
• WebView.subproj/WebDocument.h:
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView setDataSource:]):
• WebView.subproj/WebImageView.m: (-[WebImageView setDataSource:]):
• WebView.subproj/WebTextView.m: (-[WebTextView setDataSource:]):
• WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]):

3:43 PM Changeset in webkit [2039] by rjw

• 3 edits in trunk/WebKit

i Better fix for previous problem.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):

2:05 PM Changeset in webkit [2038] by darin

• 4 edits in trunk/WebCore

• fixed 3047552 -- crash using CFNotification calls on an NSNotification

• kwq/KWQWindowWidget.mm: (KWQWindowWidget::KWQWindowWidget): Create a KWQWindowWidgetDeleter, and hook it up to the notification. (KWQWindowWidget::~KWQWindowWidget): Disconnect the KWQWindowWidgetDeleter and release it. (-[KWQWindowWidgetDeleter initWithWindowWidget:]): Store a pointer. (-[KWQWindowWidgetDeleter deleteWindowWidget]): Do a delete.

1:33 PM Changeset in webkit [2037] by rjw

• 3 edits in trunk/WebKit

Remove ceiling of text width at end of fragment. This was screwing up
intra fragment text measurements.

Selection of justified text is still screwed up. This is a fundamental problem
in khtml and will require a rewrite of their justification code. Konq has the
same problems selecting justified text. The drawing of code applies the justification
factor, but checking the selection doesn't add the justification factor, so selection
will be incorrect by the justification amount.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):

12:26 PM Changeset in webkit [2036] by darin

• 3 edits in trunk/WebKit

• WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Use the current URL, not the original URL, when doing a reload. This prevents the URL from changing back and forth when you reload on a page that involved a redirect.

11:56 AM Changeset in webkit [2035] by darin

• 10 edits
  1 add
  1 delete in trunk/WebCore

• fixed 3021137 -- changing font prefs doesn't redraw frames other than the main frame

• kwq/WebCoreSettings.m: Renamed to WebCoreSettings.mm.
• kwq/WebCoreSettings.mm: Renamed from WebCoreSettings.m so I could use C++. (-[WebCoreSettings _updateAllViews]): Iterate over all KWQKHTMLPartImpl instances, calling setNeedsReapplyStyles on each one.
• WebCore.pbproj/project.pbxproj: Updated for name change.

• kwq/KWQKHTMLPartImpl.h: Add instances() and mutableInstances(). Get rid of frameExists(), findFrame(), and frames().
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Add to instance list. (KWQKHTMLPartImpl::~KWQKHTMLPartImpl): Remove from instance list. (KWQKHTMLPartImpl::requestFrame): Update to not use frameExists(). (KWQKHTMLPartImpl::overURL): Update to not use frameExists, and improve handling of various cases. (KWQKHTMLPartImpl::mutableInstances): Create and return instance list.

• kwq/WebCoreBridge.h: Add setNeedsReapplyStyles; already implemented in WebKit.

• khtml/khtml_part.cpp: (KHTMLPart::findFrame): Remove APPLE_CHANGES. (KHTMLPart::frameExists): Remove APPLE_CHANGES. (KHTMLPart::frames): Remove APPLE_CHANGES.

11:52 AM Changeset in webkit [2034] by darin

• 4 edits in trunk/WebKit

Add machinery needed for fix to 3021137, changing font prefs
doesn't redraw frames other than the main frame.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsReapplyStyles]): Added. Lets the web views know that they need to reapply styles. If we did this over on the WebCore side, we'd have to do it right away. Maybe that would be OK; we can move that that later.

• WebView.subproj/WebTextView.m: (-[WebTextView setFixedWidthFont]): Use the fixed-width size, rather than using the other size with the fixed-width family.

11:14 AM Changeset in webkit [2033] by kocienda

• 17 edits in trunk/WebKit

WebFoundation:

Major change to the API and design of WebFoundation.

Attributes, as a design concept, are now completely gone. The old usages of
attributes have been replaced with new API on the WebResourceRequest
and WebResourceResponse classes.

• CacheLoader.subproj/IFHTTPURLHandleC.m: (IFHTTPURLHandleGetRequestMethod): Removed attribute usage. Replace with calls to new API. (IFHTTPURLHandleGetRequestHeaders): Ditto.
• CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addUserRequestHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addUnconditionalUserRequestHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addAcceptHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addCookieHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler hasConditionalCustomHeaders]): Ditto.
• CacheLoader.subproj/WebCacheLoaderConstants.h: Removed newly obsoleted attributes.
• CacheLoader.subproj/WebCacheLoaderConstants.m: Ditto.
• CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler shouldAttemptOriginLoad]): Removed attribute usage. Replace with calls to new API. (-[WebHTTPProtocolHandler shouldCacheResourceData]): Ditto. (-[WebHTTPProtocolHandler requestMethod]): Ditto. (-[WebHTTPProtocolHandler requestData]): Ditto. (-[WebHTTPProtocolHandler retryWithRedirectedURLAndResultCode:]): Ditto. (-[WebHTTPProtocolHandler testAndSetCacheObjectState:]): Ditto.
• CacheLoader.subproj/WebResourceHandle.h: Removed attributeForKey method.
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle description]): Removed attribute usage. Replace with calls to new API. (-[WebResourceHandle initWithRequest:client:]): WebResourceRequest no longer requires explicit validation.
• CacheLoader.subproj/WebResourceHandleInternal.h: Removed processedAttributes.
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]): Ditto.
• CacheLoader.subproj/WebResourceHandlePrivate.h: Removed _setAttribute method.
• CacheLoader.subproj/WebResourceHandlePrivate.m: Ditto.
• CacheLoader.subproj/WebResourceLoad.h: Removed processedAttributes ivar. Removed attributeForKey and setAttribute:forKey: methods.
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]): Ditto. (-[WebResourceLoad description]): Ditto. (-[WebResourceLoad dealloc]): Ditto.
• CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]): Removed attributes from cache key. Need to put back some request info soon. (+[WebResourceLoadKey keyWithLoad:]): Ditto.
• CacheLoader.subproj/WebResourceRequest.h: Removed attributes ivar. Added method, headers, extraCookies and data ivars. Added getter and setter methods for each of the new ivars.
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]): API and implementation rejiggering to deal with removing attributes from the init methods. (-[WebResourceRequest initWithURL:flags:]): Ditto. (-[WebResourceRequest initWithURL:userAgent:flags:]): Ditto. (-[WebResourceRequest method]): Added. (-[WebResourceRequest setMethod:]): Added. (-[WebResourceRequest headers]): Added. (-[WebResourceRequest setHeaders:]): Added. (-[WebResourceRequest referrer]): Added. (-[WebResourceRequest setReferrer:]): Added. (-[WebResourceRequest extraCookies]): Added. (-[WebResourceRequest setExtraCookies:]): Added. (-[WebResourceRequest data]): Added. (-[WebResourceRequest setData:]): Added. (-[WebResourceRequest flags]): Just moved method in the file. No changes. (-[WebResourceRequest protocolHandlerClass]): Ditto. (-[WebResourceRequest copyWithZone:]): Made sure new ivars get copied. (-[WebResourceRequest dealloc]): Added new ivars.
• CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler createHTTPRequest]): Removed attribute usage. Replace with calls to new API.
• WebFoundation.exp: Removed attribute key exports.

WebKit:

Major change to the API and design of WebFoundation. WebKit has been modified
to use the new API.

WebFoundation attributes, as a design concept, are now completely gone. The old usages of
attributes have been replaced with new API on the WebResourceRequest
and WebResourceResponse classes.

• Plugins.subproj/WebPluginStream.h: Removed attribute usage in init API. No need for replacement.
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream initWithURL:pluginPointer:]): Removed attribute usage in init API. (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): Ditto. (-[WebNetscapePluginStream dealloc]): Remove attribute release. (-[WebNetscapePluginStream startLoad]): Removed attribute usage. Replace with calls to new API. (-[WebNetscapePluginStream receivedData:withHandle:]): Ditto.
• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView pluginURLFromCString:]): Added this helper method. (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]): Added. (-[WebNetscapePluginView getURLNotify:target:notifyData:]): Modified to call new loadRequest:inTarget:withNotifyData: method. (-[WebNetscapePluginView getURL:target:]): Ditto. (-[WebNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): Ditto.
• WebCoreSupport.subproj/WebBridge.h: Removed attribute usage in loadURL API. No need for replacement.
• WebCoreSupport.subproj/WebBridge.m: Added loadRequest:withParent: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge startLoadingResource:withURL:referrer:]): Removed attribute usage. Replace with calls to new API. (-[WebBridge isReloading]): Ditto. (-[WebBridge loadRequest:withParent:]): Added. (-[WebBridge loadURL:]): Modified to use new loadRequest:withParent: API (-[WebBridge loadURL:referrer:]): Ditto. (-[WebBridge loadURL:flags:withParent:]): Ditto. (-[WebBridge postWithURL:data:]): Ditto.
• WebCoreSupport.subproj/WebSubresourceClient.h: Changed API to use an NSString referrer instead of an attributes dictionary.
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Removed attribute usage. Replace with calls to new API.
• WebView.subproj/WebDataSource.h: Added initWithRequest: method.
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:]): Removed attribute usage in init API. (-[WebDataSource initWithURL:flags:]): Ditto. (-[WebDataSource initWithRequest:]): Added. (-[WebDataSource request]): Added.
• WebView.subproj/WebDataSourcePrivate.h: Added WebResourceRequest ivar.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Added WebResourceRequest ivar. (-[WebDataSource _startLoading:]): Removed attribute usage. Replace with calls to new API.
• WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Removed attribute usage. Replace with calls to new API.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Use new WebDataSource init API.

WebBrowser:

Updated to use new referrer ivar and accessor methods on WebResourceRequest, instead
of using attributes.

• BrowserDocument.m: (-[BrowserDocument _goToURL:referrer:withFallbackURLs:])

9:37 AM Changeset in webkit [2032] by darin

• 36 edits in trunk

WebCore:

WebCore part of support for the "Referer" header.

• khtml/khtml_part.cpp: (KHTMLPart::urlSelected): Use much more of this function. (KHTMLPart::submitForm): Use much more of this function.

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Parse the referrer out of the URLArgs and pass it along.

• kwq/KWQKHTMLPartImpl.h: Change parameters to urlSelected and submitForm to allow KHTML to do more of the work. Add referrer helper function.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Pass referrer of nil when opening a blank window. (KWQKHTMLPartImpl::referrer): Extract referrer from metadata. (KWQKHTMLPartImpl::openURLRequest): Pass referrer from args through the bridge. (KWQKHTMLPartImpl::urlSelected): Remove code that duplicates what's in KHTMLPart. Also pass referrer from args through the bridge as above. (KWQKHTMLPartImpl::submitForm): Ditto.

• kwq/kdeui/kmessagebox.h: Add information member function.
• kwq/KWQKMessageBox.mm: (KMessageBox::information): Implement.

• kwq/kdecore/kurl.h: Add encode_string member function.
• kwq/KWQKURL.mm: (KURL::KURL): Fix buffer overflow bug, and add an assert so we will notice these overflows even when using the static buffer. (KURL::parse): Added a similar assert, even though I didn't fix any overflow bug here. (KURL::encode_string): Implemented this, but didn't test it.

• kwq/KWQLoaderImpl.mm: (KWQServeRequest): Pass referrer through the bridge.

• kwq/WebCoreBridge.h: Add referrer parameters to loadURL, postWithURL, openNewWindowWithURL, and startLoadingResource.

• kwq/kparts/browserextension.h: Implement setDoPost, setContentType, const version of metaData().

• kwq/qt/qstring.h: Implement fromLatin1(const char *, int).

• WebCore-tests.exp: Not sure why, but I needed to remove isMalformed, and the tests seem to still work with it removed.

WebKit:

WebKit part of support for the "Referer" header.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]): Add referrer parameter, and pass it on to the window context method. (-[WebBridge addAttributeForReferrer:toDictionary:]): Added. (-[WebBridge attributesForReferrer:]): Added. (-[WebBridge startLoadingResource:withURL:referrer:]): Put the referrer into an attributes dictionary and pass it to the WebSubresourceClient method. (-[WebBridge loadURL:referrer:]): Put the referrer into an attributes dictionary and pass it along. (-[WebBridge postWithURL:referrer:data:]): Put the referrer into an attributes dictionary and pass it along.

• WebCoreSupport.subproj/WebSubresourceClient.h: Add an attributes parameter to the method that starts loading.
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:attributes:forDataSource:]): Put the attributes into the WebResourceRequest.

• WebView.subproj/WebController.h: Add a referrer parameter to the WebWindowContext openNewWindowWithURL method.
• WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler openNewWindowWithURL:referrer:]): Pass the referrer on to the window context. (-[WebDefaultContextMenuHandler openLinkInNewWindow:]): Pass nil for the referrer for now. Not sure if this is best. (-[WebDefaultContextMenuHandler openImageInNewWindow:]): Ditto. (-[WebDefaultContextMenuHandler openFrameInNewWindow:]): Ditto.

• WebView.subproj/WebFrame.m: (-[WebFrame frameNamed:]): Pass nil for the referrer here where we are creating a new empty window.

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): Pass nil for the referrer here in the WebClickPolicyOpenNewWindow. The policy API doesn't provide a way for the policy handler to specify the referrer; we might want to change that later.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): Pass nil for the referrer here. But it seems wrong that this function discards the handle attributes that are passed in for the case where it opens a new window.

WebBrowser:

WebBrowser part of support for the "Referer" header.

• BrowserWebController.m: (-[BrowserWebController openNewWindowWithURL:referrer:]): Add referrer parameter, and pass it through to the document controller. (-[BrowserWebController pluginNotFoundSheetEnded:returnCode:contextInfo:]): Pass nil for referrer.

• BrowserDocumentController.h: Add referrer parameter to the long version of goToURL.
• BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:referrer:display:]): Change to not all makeDocumentWithContentsOfURL and instead create the document here, because we need to pass the referrer through. (-[BrowserDocumentController openDocumentWithContentsOfURL:display:]): Just call the version above that has a referrer, passing a referrer of nil. (-[BrowserDocumentController _goToEachURL:referrer:forceNewWindow:orderFront:]): Pas referrer to goToURL and to openDocumentWithContentsOfURL. (-[BrowserDocumentController goToEachURL:]): Pass nil for referrer. (-[BrowserDocumentController goToURL:referrer:forceNewWindow:orderFront:]): Add referrer parameter, and pass through to _goToEachURL.

• BrowserDocument.h: Add _openWithReferrer field, initWithContentsOfURL method that takes a referrer, and goToURL method that takes a referrer.
• BrowserDocument.m: (-[BrowserDocument initWithContentsOfURL:referrer:]): Set _openWithReferrer. (-[BrowserDocument dealloc]): Release _openWithReferrer. (-[BrowserDocument _goToURL:referrer:withFallbackURLs:]): Add referrer parameter. Set up attributes dictionary with referrer in it. (-[BrowserDocument goToURL:]): Call through to goToURL:referrer:. (-[BrowserDocument goToURL:referrer:]): Added. Passes referrer on. (-[BrowserDocument goToInitialURL:]): Pass _openWithReferrer. (-[BrowserDocument tryMultipleURLs:]): Pass nil for referrer.

• ActivityViewer.m: (-[ActivityViewer _goToClickedItem:]): Pass nil for referrer.
• AppController.m: (-[AppController application:openFile:]): Ditto. (-[AppController handleGURLEvent:withReplyEvent:]): Ditto.
• BrowserWebBookmarkExtras.m: (-[WebBookmark _goToForceNewWindow:]): Ditto.
• Test/PageLoadTestRunner.m: (-[PageLoadTestRunner goToPage]): Ditto.

8:41 AM Changeset in webkit [2031] by cblu

• 4 edits in trunk/WebKit

Fixed: 3048158 - Crash at google in _destroyInitializingClassList

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]):

3:36 AM Changeset in webkit [2030] by hyatt

• 8 edits in trunk/WebCore

This patch fixes a slew of bugs. It is an implementation
of the IE extensions offsetLeft, offsetTop, and offsetParent.
Konqueror actually had implementations for these properties
that were totally wrong, leading any DHTML that would use
these properties (like the DHTML on brainjar.com or livepage.apple.com)
to misposition child elements.

With these properties now implemented, the menus on brainjar.com
position correctly, and the marquee on livepage.apple.com once
again shows up (and now you can see how I've regressed clipping
by not shoving it into the layer system as well).

Next up will be fixing the clipping bug on livepage.apple.com.

• khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty):
• khtml/rendering/render_flow.cpp: (RenderFlow::offsetHeight): (RenderFlow::offsetLeft): (RenderFlow::offsetTop):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_object.cpp: (RenderObject::offsetLeft): (RenderObject::offsetTop): (RenderObject::offsetParent):
• khtml/rendering/render_object.h:

Sep 10, 2002:

9:28 PM Changeset in webkit [2029] by hyatt

• 7 edits in trunk/WebCore

Get more elements on mrskin painting as well as the menus
on brainjar.com.

• khtml/rendering/render_flow.cpp: (RenderFlow::layout):
• khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
• khtml/rendering/render_object.cpp: (RenderObject::setLayouted):
• khtml/rendering/render_object.h:

8:02 PM Changeset in webkit [2028] by hyatt

• 11 edits in trunk/WebCore

Fix the CSS clip property.

• khtml/css/cssparser.cpp: (StyleBaseImpl::parseValue):
• khtml/css/cssstyleselector.cpp:
• khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::tryPut):
• khtml/rendering/render_box.cpp: (RenderBox::calcClip):
• khtml/rendering/render_flow.cpp: (RenderFlow::printObject):
• khtml/rendering/render_replaced.cpp: (RenderReplaced::print):
• khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (RenderStyle::diff):
• khtml/rendering/render_style.h:

6:45 PM Changeset in webkit [2027] by rjw

• 2 edits in trunk/WebKit

Forgot to commit ChangeLog

6:43 PM Changeset in webkit [2026] by rjw

• 17 edits in trunk

• Tests/html/mousetest.html: Added.

Fixed broken DOM handling of click count. DOM click
events can be tested with Labyrinth/Test/html/mousetest.html.
Preparation work for double and triple click selection.

• khtml/khtml_events.cpp:
• khtml/khtml_events.h:
• khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseTripleClickEvent):
• khtml/khtml_part.h:
• khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseTripleClickEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent):
• khtml/khtmlview.h:
• kwq/KWQEvent.mm: (QMouseEvent::QMouseEvent):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]): (-[WebCoreBridge mouseDown:]):
• kwq/qt/qevent.h:

Renamed method.

• Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences toggleDisplayImages:]): (-[AppearancePreferences initializeFromDefaults]):

Renamed method.

• WebView.subproj/WebPreferences.h:
• WebView.subproj/WebPreferences.m: (-[WebPreferences _updateWebCoreSettings]): (-[WebPreferences setWillLoadImagesAutomatically:]): (-[WebPreferences willLoadImagesAutomatically]):

5:24 PM Changeset in webkit [2025] by cblu

• 11 edits in trunk/WebKit

WebFoundation:

initialize WebError class in all class methods

• Misc.subproj/WebError.m: (+[WebError classInitialize]): added, calls classInitialize() (-[WebError initWithErrorCode:inDomain:failingURL:isTerminal:]): call +classInitialize (+[WebError addErrorsFromDictionary:]): call +classInitialize

WebKit:

Report download handler errors
Renamed error constants
Added new errors

• Misc.subproj/WebDownloadHandler.h:
• Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler errorWithCode:]): added (-[WebDownloadHandler receivedData:]): return an error (-[WebDownloadHandler finishedLoading]): return an error (-[WebDownloadHandler cancel]): return an error
• Misc.subproj/WebKitErrors.h: added new errors
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowURL:]): use renamed error constants
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:forHandle:]): don't send an error when errors are suppressed (-[WebMainResourceClient didCancelWithHandle:]): report download handler errors (-[WebMainResourceClient handleDidFinishLoading:]): report download handler errors (-[WebMainResourceClient handleDidReceiveData:data:]): report download handler errors (-[WebMainResourceClient handleDidFailLoading:withError:]): report download handler errors
• WebView.subproj/WebView.m: (+[WebView initialize]): add new errors to WebError

WebBrowser:

Renamed error constants

• BrowserWebController.m: (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]): use renamed error constants
• DownloadMonitor.m: (-[DownloadMonitor _monitorDownload:withProgress:error:dataSource:complete:]): clean-up
• DownloadProgressEntry.m: (-[DownloadProgressEntry setError:]): handle errors in succession (-[DownloadProgressEntry setProgress:]): handle errors in succession

5:07 PM Changeset in webkit [2024] by hyatt

• 4 edits in trunk/WebCore

Fix FOUC to behave correctly. I was smoking crack when I
implemented this the first time (mainly because KHTML had
a badly named API that didn't mean even remotely what
I thought it should).

• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): (HTMLLinkElementImpl::setStyleSheet): (HTMLLinkElementImpl::sheetLoaded): (HTMLStyleElementImpl::childrenChanged): (HTMLStyleElementImpl::sheetLoaded):

4:36 PM Changeset in webkit [2023] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _loadHistoryGuts:]): removed the ERROR message in the case where the history file was not found, as this is normal initial-state behavior.

WebBrowser:

• fixed 3047715 -- "Favorites" should no longer be a special folder
• fixed 3030996 -- Why can't I delete an empty Favorites?
• some other miscellaneous cleanup

I haven't yet cleaned out all the old favorites-related code; wrote up
3047885 to represent that work.

• BookmarksController.m: (-[BookmarksController imageForBookmark:]): don't special-case _favoritesRoot; use "tiny_menu" as the "standard size" image instead of "heart_small". (-[BookmarksController awakeFromNib]): remove call to (and method) _blessOrCreateFavoritesRoot; this makes _favoritesRoot always nil, so the other code that special-cases it will never do anything interesting. (-[BookmarksController _newBookmarkSheetDidEnd:returnCode:contextInfo:]): find toolbar item in pop-up menu a different way. (-[BookmarksController _addToolbarToMenu:]): new method, adds item to pop-up menu that represents toolbar (needs an image though -- see 3047876) (-[BookmarksController _setUpPopUpMenuForNewBookmarksController:]): add toolbar item to pop-up menu instead of coopting "Favorites" item.

• BrowserWindowController.h,
• BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]), (-[BrowserWindowController dealloc]): removed all references to favorites bar. (-[BrowserWindowController toggleLocationBarWithAnimation:]): fixed comment.

• Defaults.plist: changed default "Add Bookmarks" location to "Toolbar"
• English.lproj/Browser.nib: not sure what I changed, perhaps nothing.

• PreferenceKeys.h: realphabetized.

• Resources/Images/heart_small.tiff: Removed.
• WebBrowser.pbproj/project.pbxproj: Updated for removed file.

4:07 PM Changeset in webkit [2022] by mjs

• 19 edits
  2 adds in trunk

WebCore:

WebCore part of fix for:

2952837 - Slide shows on homepage.mac.com don't show pictures, captions
2942073 - Deferring [BrowserDocument goToInitialURL] can cause problems
3021360 - second window pops up on 'Search' at chrysler.com
3030485 - Unexpected new window created with no scroll bars at sony.com

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Reuse existing frame if possible. Pass frame name when opening a new window.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Don't warn when opening a new window. Check non-descendant frames too. (KWQKHTMLPartImpl::urlSelected): Pass frame name when opening window.
• kwq/WebCoreBridge.h: Add frameName argument to openNewWindowWithURL:.

WebKit:

WebKit part of fix for:

2952837 - Slide shows on homepage.mac.com don't show pictures, captions
2942073 - Deferring [BrowserDocument goToInitialURL] can cause problems
3021360 - second window pops up on 'Search' at chrysler.com
3030485 - Unexpected new window created with no scroll bars at sony.com

This is done by adding a concept of named controller sets, so that
less browser-like uses of WebKit won't be affected.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:frameName:]): Pass frameName parameter to controller initializer.

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController init]): Pass nil for controllerSetName.

(-[WebController dealloc]):
(-[WebController frameNamed:]): Check other windows in the same set too.

• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): (-[WebController _setDefersCallbacks:]): (-[WebController _setTopLevelFrameName:]): (-[WebController _frameInThisWindowNamed:]):
• WebView.subproj/WebControllerSets.h: Added.
• WebView.subproj/WebControllerSets.m: Added. (+[WebControllerSets addController:toSetNamed:]): Method to maintain controller sets. (+[WebControllerSets removeController:fromSetNamed:]): Likewise.
• WebKit.pbproj/project.pbxproj: Add new files.

WebBrowser:

WebBrowser part of fix for:

2952837 - Slide shows on homepage.mac.com don't show pictures, captions
2942073 - Deferring [BrowserDocument goToInitialURL] can cause problems
3021360 - second window pops up on 'Search' at chrysler.com
3030485 - Unexpected new window created with no scroll bars at sony.com

• BrowserWebController.m: (-[BrowserWebController initWithBrowserDocument:]): Pass controller set name when creating WebController.

2:29 PM Changeset in webkit [2021] by kocienda

• 8 edits in trunk/WebKit

WebFoundation:

Changed API for setting the WebResourceClient for a request/load.

This has been removed from WebResourceRequest, and has been moved to
WebResourceHandle. The result is that the init method for a WebResourceHandle
now takes a WebResourceRequest and a WebResourceClient.

All of the changes below are simple code modifications to use the new API.

• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadInForeground:]) (-[WebResourceHandle client]) (-[WebResourceHandle initWithRequest:client:])
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _notifyClientDidRedirectToURL]) (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]) (-[WebResourceHandle _notifyClientDidFailLoading]) (-[WebResourceHandle _notifyClientDidFinishLoading])
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _userAgentForURL:])
• CacheLoader.subproj/WebResourceRequest.h:
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]) (-[WebResourceRequest initWithURL:attributes:flags:]) (-[WebResourceRequest initWithURL:userAgent:attributes:flags:]) (-[WebResourceRequest copyWithZone:]) (-[WebResourceRequest dealloc])
• CacheLoader.subproj/WebResourceResponse.h:

WebKit:

Changed API for setting the WebResourceClient for a request/load.

This has been removed from WebResourceRequest, and has been moved to
WebResourceHandle. The result is that the init method for a WebResourceHandle
now takes a WebResourceRequest and a WebResourceClient.

All of the changes below are simple code modifications to use the new API.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad])
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:])
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:])
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:])

11:47 AM Changeset in webkit [2020] by cblu

• 9 edits in trunk/WebKit

WebKit:

• History.subproj/WebHistory.h:
• History.subproj/WebHistory.m: (-[WebHistory entryForURL:]): added
• History.subproj/WebHistoryPrivate.h:
• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate entryForURL:]): added
• Misc.subproj/WebIconDatabase.h: added WebIconLargeSize
• Misc.subproj/WebIconDatabase.m: added WebIconLargeSize
• WebKit.exp: export link label key and WebIconLargeSize

WebBrowser:

Check history and the link's label when suggesting a bookmark title.

• ContextMenuHandler.m: (-[ContextMenuHandler addLinkToBookmarks:]):

9:01 AM Changeset in webkit [2019] by darin

• 4 edits in trunk/WebCore

Add back the APPLE_CHANGES for a few frame cases. We need to do some real testing
before we remove our alternate versions of these (but I still hope we do remove them).

• khtml/khtml_part.cpp: (KHTMLPart::findFrame): Back to the old way. (KHTMLPart::frameExists): Ditto. (KHTMLPart::frames): Ditto.

8:52 AM Changeset in webkit [2018] by darin

• 46 edits in trunk

WebCore:

• fixed 2942809 -- remove all direct access to "WebKit" defaults from WebCore

• kwq/WebCoreSettings.h: Add willLoadImagesAutomatically and userStyleSheetLocation.
• kwq/WebCoreSettings.m: (-[WebCoreSettings _updateAllViews]): Added. Placeholder for a function that will cause all views to update styles and layout. (-[WebCoreSettings setStandardFontFamily:]): Call _updateAllViews if a change happened. (-[WebCoreSettings setFixedFontFamily:]): Ditto. (-[WebCoreSettings setSerifFontFamily:]): Ditto. (-[WebCoreSettings setSansSerifFontFamily:]): Ditto. (-[WebCoreSettings setCursiveFontFamily:]): Ditto. (-[WebCoreSettings setFantasyFontFamily:]): Ditto. (-[WebCoreSettings setMinimumFontSize:]): Ditto. (-[WebCoreSettings setDefaultFontSize:]): Ditto. (-[WebCoreSettings setDefaultFixedFontSize:]): Ditto. (-[WebCoreSettings setWillLoadImagesAutomatically:]): Added. (-[WebCoreSettings willLoadImagesAutomatically]): Added. (-[WebCoreSettings setUserStyleSheetLocation:]): Added. Call _updateAllViews if a change happened. (-[WebCoreSettings userStyleSheetLocation]): Added.

• WebCore.exp: Add WebCoreSettings to the exported class list.

• kwq/KWQKHTMLSettings.mm: Get settings from WebCoreSettings rather than going directly at WebKit user defaults.
• kwq/KWQKConfigBase.mm: (KConfig::readNumEntry): Check key. (KConfig::readUnsignedNumEntry): Use WebCoreSettings to get the value of the "JavaScript can open windows automatically" setting, rather than going directly at a WebKit user default. (KConfig::readColorEntry): Remove log message. This is implemented well enough.

• fixed 3015877 -- either wean WebCore from _web_URLFromString, or make it public API in WebFoundation

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::redirectionTimerStartedOrStopped): Use KURL to make an NSURL rather than using [NSURL _web_URLWithString:].
• kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::setBaseURL): Ditto.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge completeURLForDOMString:]): Ditto.

After fixing the above bugs, I noticed that I could remove the WebFoundation dependency.

• WebCore.pbproj/project.pbxproj: Remove WebFoundation framework.

• kwq/WebCoreBridge.h: Replace reportError with reportBadURL.
• kwq/KWQLoaderImpl.mm: (KWQServeRequest): Use reportBadURL instead of reportError. This was the last bit of direct dependency on WebFoundation.

Do some preparation work for implementing "referrer".

• khtml/khtml_part.cpp: Remove lots of APPLE_CHANGES and compile more original code. This in preparation for using the "referrer" code from KHTML.
• khtml/khtmlview.h: Ditto.
• khtml/misc/loader.cpp: Ditto.

• kwq/kdecore/kurl.h: Add things needed by code formerly inside APPLE_CHANGES.
• kwq/KWQKURL.mm: (KURL::hasRef): Ditto. (urlcmp): Implement in a simple-minded way. Needed by some code formerly inside APPLE_CHANGES. We can make a more full-featured version when and if we need it.
• kwq/kio/global.h: Ditto.
• kwq/kio/job.h: Ditto.
• kwq/kio/jobclasses.h: Ditto.
• kwq/KWQKjobclasses.mm: Ditto.
• kwq/kparts/browserextension.h:
• kwq/kparts/part.h: Ditto.
• kwq/qt/qstringlist.h: Ditto.
• kwq/KWQStringList.mm: (QStringList::pop_front): Ditto.
• kwq/qt/qvaluelist.h: Ditto.
• kwq/KWQValueListImpl.h: Ditto.
• kwq/KWQValueListImpl.mm: (KWQValueListImpl::isEqual): Ditto.

Other changes.

• kwq/KWQApplication.mm: (QApplication::setOverrideCursor): Don't report an error for this, it's OK to do nothing. (QApplication::restoreOverrideCursor): Ditto.

WebKit:

WebKit part of weaning WebCore from getting directly at WebKit defaults.

• WebView.subproj/WebPreferences.h:
• WebView.subproj/WebPreferences.m: (-[WebPreferences _updateWebCoreSettings]): Added. Propagates all preferences to WebCore. This way WebCore doesn't have to actively ask for the values of preferences using defaults keys that are WebKit secrets. (+[WebPreferences load]): Set up an observer that calls _updateWebCoreSettings whenever NSUserDefaultsDidChangeNotification is posted. (-[WebPreferences setStandardFontFamily:]): Call _updateWebCoreSettings right away, don't wait for NSUserDefaultsDidChangeNotification. (-[WebPreferences setFixedFontFamily:]): Ditto. (-[WebPreferences setSerifFontFamily:]): Ditto. (-[WebPreferences setSansSerifFontFamily:]): Ditto. (-[WebPreferences setCursiveFontFamily:]): Ditto. (-[WebPreferences setFantasyFontFamily:]): Ditto. (-[WebPreferences setDefaultFontSize:]): Ditto. (-[WebPreferences setDefaultFixedFontSize:]): Ditto. (-[WebPreferences setMinimumFontSize:]): Ditto. (-[WebPreferences setUserStyleSheetEnabled:]): Ditto. (-[WebPreferences setUserStyleSheetLocation:]): Ditto. (-[WebPreferences setJavaEnabled:]): Ditto. (-[WebPreferences setJavaScriptEnabled:]): Ditto. (-[WebPreferences setJavaScriptCanOpenWindowsAutomatically:]): Ditto. (-[WebPreferences setPluginsEnabled:]): Ditto. (-[WebPreferences setDisplayImages:]): Ditto.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportBadURL:]): Add this method, which replaces reportError. Now WebCore doesn't use WebFoundation directly at all! Pretty neat.

WebBrowser:

• Preferences.subproj/ActiveContentPreferences.m: WebKit now calls it "Java", not "java".