Timeline
Sep 19, 2002:
- 11:25 PM Changeset in webkit [2103] by
-
- 8 edits in trunk/WebKit
WebFoundation:
- Makefile.am: Make
doc' target depend onall'.
WebKit:
- Makefile.am: Make
doc' target depend onall'. - WebView.subproj/WebContextMenuHandler.h: Fix typo found by `make doc'.
- WebView.subproj/WebLocationChangeHandler.h: Likewise.
- 10:42 PM Changeset in webkit [2102] by
-
- 3 edits in trunk/WebKit
Tools:
- Scripts/make-docs: Added. New script to generate html docs.
WebFoundation:
- Makefile.am: Changed `make doc' target to use make-docs script (and actually work).
- CacheLoader.subproj/WebProtocolHandler.h: Remove some docs that made headerdoc2html barf.
- CacheLoader.subproj/WebCacheObject.h: Added some docs.
- CacheLoader.subproj/WebResourceHandle.h: Added some docs.
- CacheLoader.subproj/WebResourceResponse.h: Added some docs.
WebKit:
- Makefile.am: Added `make doc' target.
- 9:09 PM Changeset in webkit [2101] by
-
- 8 edits in trunk/WebCore
Implemented double and triple click selection.
- khtml/khtml_events.h:
- khtml/khtml_part.cpp: (KHTMLPart::customEvent): (KHTMLPart::khtmlMouseDoubleClickEvent): (firstSlaveAt): (lastSlaveAt): (KHTMLPart::khtmlMouseTripleClickEvent):
- khtml/khtml_part.h:
- khtml/rendering/render_text.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]):
- 6:03 PM Changeset in webkit [2100] by
-
- 5 edits in trunk/WebCore
- fixed 3045651 -- null-dereference in DOM::CharacterDataImpl constructor setting up text area element
- khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::CharacterDataImpl): Set str to an empty DOMStringImpl instead of to 0. This was easier than going around finding all the places that don't like a str of 0.
- WebCore.pbproj/project.pbxproj: Let PB sort things as it likes.
- 11:59 AM Changeset in webkit [2099] by
-
- 6 edits2 adds in trunk/WebKit
WebKit:
- cleaned up some SPI for handling URLs on pasteboard
- Misc.subproj/WebNSPasteboardExtras.h: Added.
- Misc.subproj/WebNSPasteboardExtras.m: Added. (+[NSPasteboard _web_dragTypesForURL]): Moved this here; was -[NSView _web_acceptableDragTypes] (-[NSPasteboard _web_bestURL]): Moved this here; was +[NSView _web_bestURLFromPasteboard:]
- WebView.subproj/WebView.m: (-[WebView initWithFrame:]), (-[WebView draggingEntered:]), (-[WebView concludeDragOperation:]): Updated for SPI change; also removed methods now in NSPasteboard.
- Misc.subproj/WebNSViewExtras.h:
- Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragOperationForDraggingInfo:]): Updated for SPI change.
- WebKit.pbproj/project.pbxproj: Updated for new files.
WebBrowser:
- updated to match SPI changes in WebKit
- BrowserWebBookmarkExtras.m: (+[WebBookmark bookmarkPasteboardTypes]): Use +[NSPasteboard _web_dragTypesForURL] instead of secret inside knowledge about which types are used by [NSPasteboard _web_bestURL] (+[WebBookmark anyBookmarksOnPasteboard:]), (+[WebBookmark bookmarksFromPasteboard:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL]
- LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): (-[LocationFieldEditor concludeDragOperation:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL], and replace -[NSView _web_acceptableDragTypes] with +[NSPasteboard _web_dragTypesForURL]
- LocationTextField.m: (-[LocationTextField awakeFromNib]): (-[LocationTextField concludeDragOperation:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL], and replace -[NSView _web_acceptableDragTypes] with +[NSPasteboard _web_dragTypesForURL]
- 11:17 AM Changeset in webkit [2098]
-
- 3 copies in tags/Alexander-24
This commit was manufactured by cvs2svn to create tag 'Alexander-24'.
- 11:17 AM Changeset in webkit [2097] by
-
- 8 edits in trunk
Alex-24 version stamp
Sep 18, 2002:
- 10:50 PM Changeset in webkit [2096] by
-
- 3 edits in trunk/WebKit
Fix two problems that led to an assertion now that a bogus
load progress doesn't pass the "bytesReceived == total" test.
- Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handleDidFinishLoading:]): Nil out the resource at the start of the function so that a cancel doesn't do anything if called in the middle when we stop. (-[WebNetscapePluginStream cancel]): Send a cancel error instead of a _receivedProgress. And make a partial progress rather than sending an empty progress. (-[WebNetscapePluginStream handleDidFailLoading:withError:]): Same as handleDidFinishLoading.
- 7:23 PM Changeset in webkit [2095] by
-
- 10 edits in trunk/WebKit
More documentation stuff.
Added attributed text API as requested (yuck!).
Add reconstructedDocumentSource API as requested.
Removed cruft (stale API, bogus comments).
- WebView.subproj/WebDataSource.h:
- WebView.subproj/WebDataSource.m:
- WebView.subproj/WebHTMLRepresentation.h:
- WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation reconstructedDocumentSource]): (-[WebHTMLRepresentation attributedText]):
- WebView.subproj/WebHTMLRepresentationPrivate.h:
- WebView.subproj/WebHTMLView.h:
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView selectedAttributedText]): (-[WebHTMLView selectedText]):
- WebView.subproj/WebView.h:
- 6:43 PM Changeset in webkit [2094] by
-
- 21 edits in trunk/WebKit
Header file reorg.
- BrowserWebController.m:
- ContextMenuHandler.m:
Get HTML source from rep.
- WebBrowser/HTMLSourceDocument.m
Fix compile errors from John's last checkin.
*WebBrowser/LocationFieldEditor.m
*WebBrowser/LocationTextField.m
Added document keywords to headers.
Made bookmark related APIs private.
- Misc.subproj/WebIconDatabase.h:
- Misc.subproj/WebIconLoader.h:
- Misc.subproj/WebKitErrors.h:
- Panels.subproj/WebStandardPanels.h:
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebDefaultContextMenuHandler.h:
- WebView.subproj/WebLoadProgress.h:
- WebView.subproj/WebLocationChangeHandler.h:
- WebView.subproj/WebPreferences.h:
Made public
- WebHTMLRepresentation.h
- WebHTMLRepresentation.m
- 5:46 PM Changeset in webkit [2093] by
-
- 5 edits in trunk/WebKit
WebKit:
WebKit part of fix for
- 3000823 -- special-case drag of webloc file to bookmarks
- 3004466 -- favorites bar doesn't accept drops of URL strings or webloc files
- Misc.subproj/WebNSViewExtras.h:
- make _web_bestURLForDraggingInfo: a class method and have it take an NSPasteboard * instead of an NSDraggingInfo *; change name to _web_bestURLFromPasteboard:
- Misc.subproj/WebNSViewExtras.m: (+[NSView _web_bestURLFromPasteboard:]):
- make this a class method and have it take an NSPasteboard * instead of an NSDraggingInfo * (-[NSView _web_dragOperationForDraggingInfo:]): Updated for SPI change.
- WebView.subproj/WebView.m: (-[WebView draggingEntered:]), (-[WebView concludeDragOperation:]): Updated for SPI change.
WebBrowser:
WebBrowser part of fix for
- 3000823 -- special-case drag of webloc file to bookmarks
- 3004466 -- favorites bar doesn't accept drops of URL strings or webloc files
- BrowserWebBookmarkExtras.h:
- BrowserWebBookmarkExtras.m: (+[WebBookmark defaultTitleFromURL:]): New method, broken out of bookmarkFromURL, now handles remote as well as file URLs, and URLs ending with /. (+[WebBookmark bookmarkFromURL:]): call defaultTitleFromURL: (+[WebBookmark bookmarkPasteboardTypes]): include the types that _web_bestURLFromPasteboard: (+[WebBookmark anyBookmarksOnPasteboard:]): New method, faster than getting bookmarksFromPasteboard and checking for non-empty array; more accurate than just checking bookmarkPasteboardTypes. (+[WebBookmark bookmarksFromPasteboard:]): Use _web_bestURLFromPasteboard: if all else fails.
- BookmarksViewController.m: (-[BookmarksViewController outlineView:validateDrop:proposedItem:proposedChildIndex:]), (-[BookmarksViewController canPaste]): Use +[WebBookmark anyBookmarksOnPasteboard] instead of just checking types, since NSStringPboardType (e.g.) may or may not be convertible to a bookmark
- 4:58 PM Changeset in webkit [2092] by
-
- 21 edits8 adds in trunk/WebKit
Added documentation keywords to header.
Create seperate files for the protocols
that were defined in WebController.h.
Made -[WebController createFrameNamed:for:inParent:allowsScrolling:]):
private.
- Plugins.subproj/WebPluginView.m:
- WebCoreSupport.subproj/WebBridge.m:
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebContextMenuHandler.h: Added.
- WebView.subproj/WebController.h:
- WebView.subproj/WebController.m:
- WebView.subproj/WebControllerPrivate.h:
- WebView.subproj/WebControllerPrivate.m:
- WebView.subproj/WebDefaultContextMenuHandler.m:
- WebView.subproj/WebFrame.m:
- WebView.subproj/WebHTMLView.m:
- WebView.subproj/WebHTMLViewPrivate.m:
- WebView.subproj/WebMainResourceClient.m:
- WebView.subproj/WebResourceProgressHandler.h: Added.
- WebView.subproj/WebView.m:
- WebView.subproj/WebWindowContext.h: Added.
- 3:50 PM Changeset in webkit [2091] by
-
- 6 edits in trunk/WebKit
Added documentation keywords to header.
- WebView.subproj/WebControllerPolicyHandler.h:
Made WebDynamicScrollBarsView private
- WebKit.pbproj/project.pbxproj:
- 3:33 PM Changeset in webkit [2090] by
-
- 3 edits in trunk/WebKit
- fixed 3053155 -- REGRESSION: Activity Window thinks 0-byte images are "complete"
I thought I had fixed it before, but this is needed too.
- WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress init]): Set "bytes so far" to 0, not -1. (-[WebLoadProgress initWithResourceHandle:]): Make sure we set total to -1, not 0, when the response is nil.
- 3:19 PM Changeset in webkit [2089] by
-
- 3 edits in trunk/WebKit
Added documentation keywords to header.
- WebView.subproj/WebDocument.h:
- 3:06 PM Changeset in webkit [2088] by
-
- 7 edits in trunk/WebKit
Added documentation keywords to headers.
Made reset a private method.
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebFrame.h:
- WebView.subproj/WebFrame.m:
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebFramePrivate.m: (-[WebFrame reset]):
- 2:47 PM Changeset in webkit [2087] by
-
- 3 edits in trunk/WebKit
Added documentation keywords to headers.
- WebView.subproj/WebView.h:
- 2:41 PM Changeset in webkit [2086] by
-
- 3 edits in trunk/WebKit
Added documentation keywords to headers.
- WebView.subproj/WebDataSource.h:
- 12:46 PM Changeset in webkit [2085] by
-
- 4 edits in trunk/WebKit
- WebView.subproj/WebController.h: Fix typo.
- 12:27 PM Changeset in webkit [2084] by
-
- 6 edits in trunk/WebKit
- WebView.subproj/WebController.h: Add getters.
- WebView.subproj/WebController.m: (-[WebController applicationNameForUserAgent]): Added. (-[WebController userAgent]): Added.
- 11:39 AM Changeset in webkit [2083] by
-
- 5 edits in trunk
Matt Watson's approved changes to fix the fat build on gcc-1203
- 11:28 AM Changeset in webkit [2082] by
-
- 17 edits2 deletes in trunk/WebCore
- fixed 3037974 -- successful Find does not deselect text field
- khtml/khtml_part.cpp: (KHTMLPart::checkCompleted): Turn off the code that restores the cursor position because we don't use the KHTML saveState/restoreState. But we should.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::setSelection): Call setFocusNode(0), because on the Macintosh, selection and focus are mutually exclusive. (DocumentImpl::close): Remove no-longer-needed APPLE_CHANGES. (DocumentImpl::setFocusNode): Set focus to the KHTMLView when focus is being removed from a particular node. Clear the selection when focus is set on a particular node because on the Macintosh, selection and focus are mutually exclusive.
- kwq/KWQKHTMLPartImpl.h: Add set/clearDocumentFocus functions that we can use to keep document's idea of focused node in sync. with AppKit's.
- kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::setDocumentFocus): Added. (KWQKHTMLPartImpl::clearDocumentFocus): Added.
- kwq/KWQNSTextField.mm: (-[KWQNSTextField becomeFirstResponder]): Call setDocumentFocus. (-[KWQSecureTextField becomeFirstResponder]): Call setDocumentFocus.
- kwq/qt/qwidget.h: Removed endEditing().
- kwq/KWQWidget.mm: (QWidget::clearFocus): Call clearDocumentFocus. (QWidget::endEditing): Removed.
- khtml/rendering/render_form.h:
- khtml/rendering/render_form.cpp: (RenderImageButton::RenderImageButton): Remove the KWQInvisibleButton hack, which is no longer needed.
- kwq/KWQInvisibleButton.h: Removed.
- kwq/KWQInvisibleButton.mm: Removed.
- WebCore.pbproj/project.pbxproj: Removed KWQInvisibleButton.
- 9:15 AM Changeset in webkit [2081] by
-
- 5 edits in trunk/WebCore
- fixed 3027470 -- hitting tab when the google.com text field is selected (all bars hidden) makes border flash
- kwq/KWQNSTextField.mm: (-[KWQNSTextField textDidEndEditing:]): Added. Don't call super when the next valid key view is nil. (-[KWQSecureTextField textDidEndEditing:]): Ditto. Too bad we can't share code here. Maybe I'll figure out a way later.
Sep 17, 2002:
- 10:12 PM Changeset in webkit [2080] by
-
- 7 edits in trunk/WebCore
- fixed 3025022 -- Crash in KWQKHTMLPartImpl::redirectionTimerStartedOrStopped()
- kwq/WebCoreBridge.mm: (-[WebCoreBridge dealloc]): Set the bridge on the part to nil just in case someone else is holding a reference, so we won't try to dispatch methods to an already-deallocated bridge.
- fixed 3028476 -- illegal instruction crash in KWQTimerCallback timerFired
- khtml/ecma/kjs_window.cpp: (WindowQObject::parentDestroyed): Remove APPLE_CHANGES to avoid calling killTimers(); we can call it now that we have a working implementation.
- khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Remove APPLE_CHANGES that kills timers. All timers are killed by ~QObject now, just as in Qt. (KHTMLView::clear): Remove APPLE_CHANGES to avoid calling killTimers(); we can call it now that we have a working implementation.
- kwq/KWQObject.mm: (QObject::~QObject): Call killTimers(). (QObject::startTimer): Keep a dictionary keyed by QObject, with a dictionary of timers for each, rather than one global dictionary. This makes it efficient to kill all the timers for an object. (QObject::killTimer): Update for new level of dictionary. (QObject::killTimers): Kill all the timers in this object's timer dictionary rather than all timers in the world. (QObject::inherits): Add an ERROR for the case where the class name is unknown.
- 4:56 PM Changeset in webkit [2079] by
-
- 4 edits in trunk/WebCore
- fixed 3050818 -- Crash in relative-KURL constructor at site with _ in host name
- kwq/KWQKURL.mm: Change _ so that it's allowed in host names. (KURL::KURL): If base URL is invalid, make result invalid too.
- 4:38 PM Changeset in webkit [2078] by
-
- 6 edits in trunk/WebCore
- khtml/khtmlview.cpp: (KHTMLView::viewportMouseTripleClickEvent): Added implementation. Same as viewportMouseReleaseEvent except dispatches additional MouseTripleClickEvent event.
(KHTMLView::viewportMouseDoubleClickEvent):
Send extra release event. This emulates Qt
behavior.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]): Don't send extra release event here, instead send it in viewportMouseDoubleClickEvent and also in viewportMouseTripleClickEvent so DOM doesn't get confused.
- kwq/KWQColor.mm: (QColor::hsv): Fixed marklar divide by 0 problemn.
- 3:50 PM Changeset in webkit [2077] by
-
- 4 edits in trunk/WebKit
Fix bug where image documents were broken.
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): loadStatus of 0 means the whole image is ready, not 0 scan lines; so check > 0, not >= 0.
- WebKit.pbproj/project.pbxproj: Let Project Builder be the boss of me.
- 3:18 PM Changeset in webkit [2076] by
-
- 16 edits in trunk/WebCore
WebCore:
- fixed 2936933 -- Pages that claim to be UTF-8 but contain invalid sequences do not render at all
Misc. speed improvements. Total 2.6% speedup for cvs-base.
Improvements for signals.
- kwq/KWQChar.mm: (QChar::isSpace): Add fast case for ASCII. (QChar::lower): Add fast case for ASCII. (QChar::upper): Add fast case for ASCII.
- kwq/qt/qcolor.h: Just store RGB values, not NSColor objects.
- kwq/KWQColor.mm: (QColor::QColor): No need to set color to nil. (QColor::name): Use QString::sprintf instead of NSString. (QColor::setNamedColor): Use KWQInvalidColor instead of nil. (QColor::getNSColor): Make an autoreleased NSColor.
- kwq/KWQKHTMLPartImpl.mm: (moveWidgetsAside): Use isWidget() instead of dynamic_cast.
- kwq/KWQSignal.h: use a QValueList instead of a fixed-size array.
- kwq/KWQSignal.mm: (KWQSignal::connect): Append to list. (KWQSignal::disconnect): Remove from list. (KWQSignal::call): Use the QValueList.
- kwq/KWQSlot.mm: (KWQSlot::call): Use static_cast instead of dynamic_cast where possible.
- kwq/qt/qstring.h: Add return value to forceUnicode.
- kwq/KWQString.mm: (QString::fromStringWithEncoding): Implemented using the Text Encoding Converter instead of CFString. (compareIgnoringCaseForASCIIOnly): New function. Faster find. (QString::find): Separate case-sensitive from case-insensitive and speed up both of them. (QString::stripWhiteSpace): Use the new forceUnicode for simplicity. (QString::simplifyWhiteSpace): Ditto. (QString::insert): Ditto. (QString::remove): Ditto. (QString::forceUnicode): Return the unicode pointer. (QString::fill): Use the new forceUnicode for simplicity.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]): Fix two bugs. First, don't treat a slow click as a double click. Second, deliver a mouse release event even for a double click, as Qt does.
WebBrowser:
Don't update the tool tip rectangles every time we update the
background image. This makes things a little faster.
- TextFieldWithControls.h: Boolean for whether tool tip rectangles are up to date.
- TextFieldWithControls.m: (-[TextFieldWithControls updateToolTips]): Do work only if flag is NO. Set flag to YES when done. (-[TextFieldWithControls backgroundImage]): Don't update the tool tip rectangles here. (-[TextFieldWithControls setFrameOrigin:]): Mark the tool tip rectangles as out of date. (-[TextFieldWithControls setFrameSize:]): Mark the tool tip rectangles as out of date. (-[TextFieldWithControls drawRect:]): Update the tool tips if needed. (-[TextFieldWithControls showRightButton:]): Mark the tool tip rectangles as out of date. (-[TextFieldWithControls setLeftButtonImage:withOrigin:]): Ditto. (-[TextFieldWithControls setRightButtonImage:withOrigin:]): Ditto.
- 3:10 PM Changeset in webkit [2075] by
-
- 18 edits in trunk
- History.subproj/WebHistory.h:
- History.subproj/WebHistory.m: (-[WebHistory addEntryForURLString:]): (-[WebHistory containsEntryForURLString:]): Added URL string API. We should remove use of NSURL from this API.
- History.subproj/WebHistoryPrivate.h:
- History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _entryForURLString:]): (-[WebHistoryPrivate containsEntryForURLString:]): Implementation of above.
- WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): Use ((int)(x + (1.0 - FLT_EPSILON))) instead of ceil().
- khtml/css/cssstyleselector.cpp: Fixed bug in KHTML that incorrectly modified '' in fragment part of URL.
- kwq/KWQKHistoryProvider.mm: Use string based API to add entry. May eventually remove NSURL from history entirely.
- kwq/KWQKURL.mm: (KURL::canonicalURL): Simply return the urlString.
(KURL::parse):
Added "/" to http and https empty path URLs.
- kwq/KWQString.mm: (QString::mid): Optimize ascii case.
- kwq/WebCoreHistory.h:
- kwq/WebCoreHistory.m: (-[WebCoreHistory addEntryForURLString:]): Use string based API to add entry.
- kwq/kdecore/kurl.h: Defined methods to access canonical components, currently conditionally excluded.
No longer commit history in the browser, now done in WebKit.
- BrowserDocument.m:
- LocationChangeHandler.m: (-[LocationChangeHandler locationChangeCommittedForDataSource:]):
Sep 16, 2002:
- 6:24 PM Changeset in webkit [2074] by
-
- 3 edits in trunk/WebKit
- History.subproj/WebHistoryPrivate.m: Do that for real.
- 4:23 PM Changeset in webkit [2073] by
-
- 5 edits in trunk/WebKit
Remove fix (according to John, partial fix) for 3051288.
Canonicalizing the URL strings used in the history db
is very slow! ~8% slower.
- History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addEntry:]): (-[WebHistoryPrivate removeEntry:]): (-[WebHistoryPrivate containsURL:]): (-[WebHistoryPrivate entryForURL:]):
- WebView.subproj/WebHTMLView.h: Removed cruft from header.
- 12:17 PM Changeset in webkit [2072] by
-
- 5 edits in trunk/WebCore
Fix the stylesheet loading regression on rubyfruit.
- khtml/html/html_headimpl.cpp: (HTMLStyleElementImpl::HTMLStyleElementImpl): (HTMLStyleElementImpl::childrenChanged): (HTMLStyleElementImpl::isLoading):
- khtml/html/html_headimpl.h:
- 8:09 AM Changeset in webkit [2071] by
-
- 3 edits in trunk/WebKit
- fixed 3050810 -- while an image is loading progressively, it draws white rather then page background
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): Added. Used instead of a direct call to drawInRect:fromRect:operation:fraction:, this only draws the part of the image that is valid according to loadStatus. (-[WebImageRenderer nextFrame:]): Use drawClippedToValidInRect:fromRect:. (-[WebImageRenderer beginAnimationInRect:fromRect:]): Ditto. (-[WebImageRenderer tileInRect:fromPoint:]): Ditto.