⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 22, 2002:

9:31 PM Changeset in webkit [2119] by darin
  • 3 edits in trunk/WebKit
  • fixed 3057380 -- insertion point shows through elements in front of text fields
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView initialize]): Make WebNSTextView pose as NSTextView. (-[WebNSTextView _web_inHTMLView]): Helper method. (-[WebNSTextView isOpaque]): Override to return NO for all text views that are inside an WebHTMLView, so they don't try to do insertion point caching. (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Use setNeedsDisplayInRect to trigger insertion point drawing outside drawRect instead of drawing right away. (-[WebNSTextView _drawRect:clip:]): Set flag so the above can know when it's inside drawRect and when it's not.
9:27 PM Changeset in webkit [2118] by darin
  • 8 edits in trunk/WebCore

Change code that moves NSViews out of the way to run inside drawRect
after a layout change rather than running at layout time. This makes
sure that views are in the right place when propagating dirty rects.

  • kwq/KWQKHTMLPartImpl.h: Add paint method and _needsToSetWidgetsAside flag.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Set _needsToSetWidgetsAside to false. (KWQKHTMLPartImpl::layout): Set _needsToSetWidgetsAside to true. Don't call moveWidgetsAside any more. (KWQKHTMLPartImpl::paint): Moved the code here from the bridge, but also call moveWidgetsAside if _needsToSetWidgetsAside flag is set.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Call KWQKHTMLPartImpl::paint, which is where I moved this code.

Sep 21, 2002:

11:01 PM Changeset in webkit [2117] by darin
  • 3 edits in trunk/WebCore
  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Remove special case for javascript and about:blank that was leading to a crash.
10:52 PM Changeset in webkit [2116] by darin
  • 4 edits in trunk/WebCore

Fix crashing part of 3057265 -- REGRESSION: Crash loading ​http://www.undetectables.co.uk/

  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Remove special case for javascript and about:blank that was leading to a crash.
4:54 PM Changeset in webkit [2115] by darin
  • 26 edits in trunk

WebCore:

WebCore part of the new approach to AppKit drawing control.
Works better than the previous try. Once we fix anomalies with focus rectangles
and a minor problems with subframes this should work perfectly.

  • kwq/qt/qwidget.h: The paint() method isn't virtual any more. Also remove flushDrawing().
  • kwq/KWQWidget.mm: (QWidget::enableFlushDrawing): Do a flushWindowIfNeeded instead of requiring a separate flushDrawing() call to do a flushWindow. (QWidget::paint): Added. Calls displayRectIgnoringOpacity.
  • kwq/qt/qbutton.h: Remove paint() override.
  • kwq/KWQButton.mm: (QButton::QButton): No need for a subclass any more, so drop KWQNSButton. Also remove paint().
  • kwq/qt/qcombobox.h: Remove paint() override.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): No need for a subclass any more, so drop KWQNSPopUpButton. Also remove paint() method.
  • kwq/qt/qlineedit.h: Remove paint() override.
  • kwq/KWQLineEdit.mm: Remove paint().
  • kwq/KWQFileButton.mm: (KWQFileButton::clicked): Fix typo. Was calling paint instead of clicked on the base class.
  • kwq/KWQNSTextField.h: Remove paint method.
  • kwq/KWQNSTextField.mm: (-[KWQNSTextField display]): Add a display method that does nothing to work around bug 2753974. (-[KWQSecureTextField display]): Ditto.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): Remove call to flushDrawing.

WebKit:

WebKit part of the new approach to AppKit drawing control.
Works better than the previous try. Once we fix anomalies with focus rectangles
and a some remaining problems with subframes this should work perfectly.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView isOpaque]): Return NO for frames other than the main frame. (-[WebHTMLView drawRect:]): Restore the subviews that were set aside.
  • WebView.subproj/WebHTMLViewPrivate.h: Add _isMainFrame. Add savedSubviews and subviewsSetAside.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _isMainFrame]): Added. (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Added. If this is the main frame, get all the dirty rects from the subviews and then set them aside so the AppKit machinery won't draw them. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto. (-[NSView _web_propagateDirtyRectToAncestor]): Added. Propagates dirty rects the same way that AppKit does, but always does it, ignoring the value of isOpaque.

Sep 20, 2002:

6:58 PM Changeset in webkit [2114] by rjw
  • 4 edits in trunk/WebCore

Don't modify selection if no appropriate DOM::Node under
mouse.

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseMoveEvent):
6:44 PM Changeset in webkit [2113] by rjw
  • 4 edits in trunk/WebCore

Assume triple click for selection if click count >= 3,
not == 3, as in OS X.

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMousePressEvent):
6:33 PM Changeset in webkit [2112] by rjw
  • 5 edits in trunk/WebCore

Fixed crasher in findTextSlave.

  • khtml/rendering/render_text.cpp: (RenderText::findTextSlave):

Added error checks.

  • khtml/khtml_part.cpp: (startAndEndLineNodesIncludingNode):
6:00 PM Changeset in webkit [2111] by rjw
  • 1 edit in trunk/WebCore/khtml/xml/dom_elementimpl.cpp

Removed debugging.

5:58 PM Changeset in webkit [2110] by rjw
  • 12 edits in trunk/WebCore

Made double and triple click selection behave like
like other selection in OS X. That is, selection happens
on mouse down, not mouse up, and can be extended by
further dragging. Triple click followed by dragging extends
the selection a line at a time.

  • khtml/khtml_events.cpp:
  • khtml/khtml_events.h:
  • khtml/khtml_part.cpp: (KHTMLPart::customEvent): (firstSlaveAt): (lastSlaveAt): (startAndEndLineNodesIncludingNode): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseDoubleClickEvent): (KHTMLPart::khtmlMouseMoveEvent):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp:
  • khtml/khtmlview.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttribute):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]):
5:42 PM Changeset in webkit [2109] by darin
  • 8 edits in trunk/WebCore
  • kwq/KWQFileButton.h: Add an icon.
  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Nil out icon. (KWQFileButton::~KWQFileButton): Release icon. (KWQFileButton::setFilename): Get icon with [NSWorkspace iconForFile:]. (KWQFileButton::clicked): Set prompt string to "Choose", and start directory to "~". (KWQFileButton::sizeHint): Pad more for icon width. (KWQFileButton::frameGeometry): Ditto. (KWQFileButton::setFrameGeometry): Ditto. (KWQFileButton::paint): Draw icon. Draw "no file selected" if no filename.
  • kwq/KWQKFileItem.mm: Our "nonimplementation" is good enough. Stop complaining.
  • kwq/KWQKnetaccess.mm: Ditto. Also just extract path when asked to download.
4:45 PM Changeset in webkit [2108] by darin
  • 6 edits
    2 adds
    1 delete in trunk/WebCore

Some first steps toward implementing input=file.

  • khtml/rendering/render_form.cpp: (RenderFileButton::RenderFileButton): Create a KWQFileButton as the widget. (RenderFileButton::calcMinMaxWidth): Use sizeHint(). (RenderFileButton::updateFromElement): Call setFilename(). (RenderFileButton::select): Don't try to selectAll() on m_edit.
  • kwq/KWQFileButton.h: Added.
  • kwq/KWQFileButton.mm: Added.
  • kwq/qt/qhbox.h: Emptied.
  • kwq/KWQHBox.mm: Removed.
  • WebCore.pbproj/project.pbxproj: Removed KWQHBox.mm. Added KWQFileButton.
2:26 PM Changeset in webkit [2107] by darin
  • 4 edits in trunk/WebCore
  • kwq/mac-encodings.txt: When people say ShiftJIS, they really mean DOSJapanese. So do what they mean, not what they say.
12:23 PM Changeset in webkit [2106] by darin
  • 5 edits in trunk/WebKit
  • History.subproj/WebHistory.m: (-[WebHistory addEntryForURLString:]): Use _web_URLWithString so we can handle unusual characters.
  • WebView.subproj/WebDefaultPolicyHandler.m: Remove stray semicolon.
10:13 AM Changeset in webkit [2105] by darin
  • 5 edits in trunk/WebCore
  • fixed 3055339 -- repro crash in RenderPartObject::updateWidget()
  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Only create a new part if we have no old part.
  • kwq/KWQtextstream.mm: Remove some of the "not implemented" logging. Once we have logged that the stream is not created correctly, there's no need to continue logging each time something is written out to the non-stream.
9:58 AM Changeset in webkit [2104] by cblu
  • 6 edits in trunk/WebKit

Fixed wasteful memory usage in the WebIconDatabase:

  • Rather than have multiple NSImages with multiple representations at multiple sizes, have 1 NSImage per size
  • Added API to allow client to control memory caching
  • Misc.subproj/WebIconDatabase.h:
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:]): call iconForSiteURL:withSize:cache:YES (-[WebIconDatabase iconForSiteURL:withSize:cache:]): new, was iconForSiteURL:withSize: (-[WebIconDatabase defaultIconWithSize:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _updateFileDatabase]): write the largest icon to disk (-[WebIconDatabase _hasIconForSiteURL:]): cleaned-up (-[WebIconDatabase _iconsForIconURL:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _iconForFileURL:withSize:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _builtInIconsForHost:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _setIcon:forIconURL:]): _iconsBySplittingRepresentationsOfIcon: (-[WebIconDatabase _releaseIconForIconURL:]): icons at different sizes are now stored in dictionaries (-[WebIconDatabase _largestIconFromDictionary:]): new, scans the icon dictionary (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): creates the icon dictionary (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): returns icon from dict, resizes if necessary (-[WebIconDatabase _iconByScalingIcon:toSize:]): tweak
  • Misc.subproj/WebIconDatabasePrivate.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): don't call _iconsForIconURL: because it doesn't exist.

Sep 19, 2002:

11:25 PM Changeset in webkit [2103] by mjs
  • 8 edits in trunk/WebKit

WebFoundation:

  • Makefile.am: Make doc' target depend on all'.

WebKit:

  • Makefile.am: Make doc' target depend on all'.
  • WebView.subproj/WebContextMenuHandler.h: Fix typo found by `make doc'.
  • WebView.subproj/WebLocationChangeHandler.h: Likewise.
10:42 PM Changeset in webkit [2102] by mjs
  • 3 edits in trunk/WebKit

Tools:

  • Scripts/make-docs: Added. New script to generate html docs.

WebFoundation:

  • Makefile.am: Changed `make doc' target to use make-docs script (and actually work).
  • CacheLoader.subproj/WebProtocolHandler.h: Remove some docs that made headerdoc2html barf.
  • CacheLoader.subproj/WebCacheObject.h: Added some docs.
  • CacheLoader.subproj/WebResourceHandle.h: Added some docs.
  • CacheLoader.subproj/WebResourceResponse.h: Added some docs.

WebKit:

  • Makefile.am: Added `make doc' target.
9:09 PM Changeset in webkit [2101] by rjw
  • 8 edits in trunk/WebCore

Implemented double and triple click selection.

  • khtml/khtml_events.h:
  • khtml/khtml_part.cpp: (KHTMLPart::customEvent): (KHTMLPart::khtmlMouseDoubleClickEvent): (firstSlaveAt): (lastSlaveAt): (KHTMLPart::khtmlMouseTripleClickEvent):
  • khtml/khtml_part.h:
  • khtml/rendering/render_text.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]):
6:03 PM Changeset in webkit [2100] by darin
  • 5 edits in trunk/WebCore
  • fixed 3045651 -- null-dereference in DOM::CharacterDataImpl constructor setting up text area element
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::CharacterDataImpl): Set str to an empty DOMStringImpl instead of to 0. This was easier than going around finding all the places that don't like a str of 0.
  • WebCore.pbproj/project.pbxproj: Let PB sort things as it likes.
11:59 AM Changeset in webkit [2099] by sullivan
  • 6 edits
    2 adds in trunk/WebKit

WebKit:

  • cleaned up some SPI for handling URLs on pasteboard
  • Misc.subproj/WebNSPasteboardExtras.h: Added.
  • Misc.subproj/WebNSPasteboardExtras.m: Added. (+[NSPasteboard _web_dragTypesForURL]): Moved this here; was -[NSView _web_acceptableDragTypes] (-[NSPasteboard _web_bestURL]): Moved this here; was +[NSView _web_bestURLFromPasteboard:]
  • WebView.subproj/WebView.m: (-[WebView initWithFrame:]), (-[WebView draggingEntered:]), (-[WebView concludeDragOperation:]): Updated for SPI change; also removed methods now in NSPasteboard.
  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragOperationForDraggingInfo:]): Updated for SPI change.
  • WebKit.pbproj/project.pbxproj: Updated for new files.

WebBrowser:

  • updated to match SPI changes in WebKit
  • BrowserWebBookmarkExtras.m: (+[WebBookmark bookmarkPasteboardTypes]): Use +[NSPasteboard _web_dragTypesForURL] instead of secret inside knowledge about which types are used by [NSPasteboard _web_bestURL] (+[WebBookmark anyBookmarksOnPasteboard:]), (+[WebBookmark bookmarksFromPasteboard:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL]
  • LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): (-[LocationFieldEditor concludeDragOperation:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL], and replace -[NSView _web_acceptableDragTypes] with +[NSPasteboard _web_dragTypesForURL]
  • LocationTextField.m: (-[LocationTextField awakeFromNib]): (-[LocationTextField concludeDragOperation:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL], and replace -[NSView _web_acceptableDragTypes] with +[NSPasteboard _web_dragTypesForURL]
11:17 AM Changeset in webkit [2098]
  • 3 copies in tags/Alexander-24

This commit was manufactured by cvs2svn to create tag 'Alexander-24'.

11:17 AM Changeset in webkit [2097] by sheridan
  • 8 edits in trunk

Alex-24 version stamp

Sep 18, 2002:

10:50 PM Changeset in webkit [2096] by darin
  • 3 edits in trunk/WebKit

Fix two problems that led to an assertion now that a bogus
load progress doesn't pass the "bytesReceived == total" test.

  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handleDidFinishLoading:]): Nil out the resource at the start of the function so that a cancel doesn't do anything if called in the middle when we stop. (-[WebNetscapePluginStream cancel]): Send a cancel error instead of a _receivedProgress. And make a partial progress rather than sending an empty progress. (-[WebNetscapePluginStream handleDidFailLoading:withError:]): Same as handleDidFinishLoading.
7:23 PM Changeset in webkit [2095] by rjw
  • 10 edits in trunk/WebKit

More documentation stuff.
Added attributed text API as requested (yuck!).
Add reconstructedDocumentSource API as requested.
Removed cruft (stale API, bogus comments).

  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation reconstructedDocumentSource]): (-[WebHTMLRepresentation attributedText]):
  • WebView.subproj/WebHTMLRepresentationPrivate.h:
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView selectedAttributedText]): (-[WebHTMLView selectedText]):
  • WebView.subproj/WebView.h:
6:43 PM Changeset in webkit [2094] by rjw
  • 21 edits in trunk/WebKit

Header file reorg.

  • BrowserWebController.m:
  • ContextMenuHandler.m:

Get HTML source from rep.

  • WebBrowser/HTMLSourceDocument.m

Fix compile errors from John's last checkin.
*WebBrowser/LocationFieldEditor.m
*WebBrowser/LocationTextField.m

Added document keywords to headers.
Made bookmark related APIs private.

  • Misc.subproj/WebIconDatabase.h:
  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebKitErrors.h:
  • Panels.subproj/WebStandardPanels.h:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDefaultContextMenuHandler.h:
  • WebView.subproj/WebLoadProgress.h:
  • WebView.subproj/WebLocationChangeHandler.h:
  • WebView.subproj/WebPreferences.h:

Made public

  • WebHTMLRepresentation.h
  • WebHTMLRepresentation.m
5:46 PM Changeset in webkit [2093] by sullivan
  • 5 edits in trunk/WebKit

WebKit:

WebKit part of fix for

  • 3000823 -- special-case drag of webloc file to bookmarks
  • 3004466 -- favorites bar doesn't accept drops of URL strings or webloc files
  • Misc.subproj/WebNSViewExtras.h:
  • make _web_bestURLForDraggingInfo: a class method and have it take an NSPasteboard * instead of an NSDraggingInfo *; change name to _web_bestURLFromPasteboard:
  • Misc.subproj/WebNSViewExtras.m: (+[NSView _web_bestURLFromPasteboard:]):
  • make this a class method and have it take an NSPasteboard * instead of an NSDraggingInfo * (-[NSView _web_dragOperationForDraggingInfo:]): Updated for SPI change.
  • WebView.subproj/WebView.m: (-[WebView draggingEntered:]), (-[WebView concludeDragOperation:]): Updated for SPI change.

WebBrowser:

WebBrowser part of fix for

  • 3000823 -- special-case drag of webloc file to bookmarks
  • 3004466 -- favorites bar doesn't accept drops of URL strings or webloc files
  • BrowserWebBookmarkExtras.h:
  • BrowserWebBookmarkExtras.m: (+[WebBookmark defaultTitleFromURL:]): New method, broken out of bookmarkFromURL, now handles remote as well as file URLs, and URLs ending with /. (+[WebBookmark bookmarkFromURL:]): call defaultTitleFromURL: (+[WebBookmark bookmarkPasteboardTypes]): include the types that _web_bestURLFromPasteboard: (+[WebBookmark anyBookmarksOnPasteboard:]): New method, faster than getting bookmarksFromPasteboard and checking for non-empty array; more accurate than just checking bookmarkPasteboardTypes. (+[WebBookmark bookmarksFromPasteboard:]): Use _web_bestURLFromPasteboard: if all else fails.
  • BookmarksViewController.m: (-[BookmarksViewController outlineView:validateDrop:proposedItem:proposedChildIndex:]), (-[BookmarksViewController canPaste]): Use +[WebBookmark anyBookmarksOnPasteboard] instead of just checking types, since NSStringPboardType (e.g.) may or may not be convertible to a bookmark
4:58 PM Changeset in webkit [2092] by rjw
  • 21 edits
    8 adds in trunk/WebKit

Added documentation keywords to header.
Create seperate files for the protocols
that were defined in WebController.h.
Made -[WebController createFrameNamed:for:inParent:allowsScrolling:]):
private.

  • Plugins.subproj/WebPluginView.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebContextMenuHandler.h: Added.
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m:
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m:
  • WebView.subproj/WebDefaultContextMenuHandler.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebHTMLView.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebResourceProgressHandler.h: Added.
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebWindowContext.h: Added.
3:50 PM Changeset in webkit [2091] by rjw
  • 6 edits in trunk/WebKit

Added documentation keywords to header.

  • WebView.subproj/WebControllerPolicyHandler.h:

Made WebDynamicScrollBarsView private

  • WebKit.pbproj/project.pbxproj:
3:33 PM Changeset in webkit [2090] by darin
  • 3 edits in trunk/WebKit
  • fixed 3053155 -- REGRESSION: Activity Window thinks 0-byte images are "complete"

I thought I had fixed it before, but this is needed too.

  • WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress init]): Set "bytes so far" to 0, not -1. (-[WebLoadProgress initWithResourceHandle:]): Make sure we set total to -1, not 0, when the response is nil.
3:19 PM Changeset in webkit [2089] by rjw
  • 3 edits in trunk/WebKit

Added documentation keywords to header.

  • WebView.subproj/WebDocument.h:
3:06 PM Changeset in webkit [2088] by rjw
  • 7 edits in trunk/WebKit

Added documentation keywords to headers.
Made reset a private method.

  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame reset]):
2:47 PM Changeset in webkit [2087] by rjw
  • 3 edits in trunk/WebKit

Added documentation keywords to headers.

  • WebView.subproj/WebView.h:
2:41 PM Changeset in webkit [2086] by rjw
  • 3 edits in trunk/WebKit

Added documentation keywords to headers.

  • WebView.subproj/WebDataSource.h:
12:46 PM Changeset in webkit [2085] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/WebController.h: Fix typo.
12:27 PM Changeset in webkit [2084] by darin
  • 6 edits in trunk/WebKit
  • WebView.subproj/WebController.h: Add getters.
  • WebView.subproj/WebController.m: (-[WebController applicationNameForUserAgent]): Added. (-[WebController userAgent]): Added.
11:39 AM Changeset in webkit [2083] by vicki
  • 5 edits in trunk

Matt Watson's approved changes to fix the fat build on gcc-1203

11:28 AM Changeset in webkit [2082] by darin
  • 17 edits
    2 deletes in trunk/WebCore
  • fixed 3037974 -- successful Find does not deselect text field
  • khtml/khtml_part.cpp: (KHTMLPart::checkCompleted): Turn off the code that restores the cursor position because we don't use the KHTML saveState/restoreState. But we should.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setSelection): Call setFocusNode(0), because on the Macintosh, selection and focus are mutually exclusive. (DocumentImpl::close): Remove no-longer-needed APPLE_CHANGES. (DocumentImpl::setFocusNode): Set focus to the KHTMLView when focus is being removed from a particular node. Clear the selection when focus is set on a particular node because on the Macintosh, selection and focus are mutually exclusive.
  • kwq/KWQKHTMLPartImpl.h: Add set/clearDocumentFocus functions that we can use to keep document's idea of focused node in sync. with AppKit's.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::setDocumentFocus): Added. (KWQKHTMLPartImpl::clearDocumentFocus): Added.
  • kwq/KWQNSTextField.mm: (-[KWQNSTextField becomeFirstResponder]): Call setDocumentFocus. (-[KWQSecureTextField becomeFirstResponder]): Call setDocumentFocus.
  • kwq/qt/qwidget.h: Removed endEditing().
  • kwq/KWQWidget.mm: (QWidget::clearFocus): Call clearDocumentFocus. (QWidget::endEditing): Removed.
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_form.cpp: (RenderImageButton::RenderImageButton): Remove the KWQInvisibleButton hack, which is no longer needed.
  • kwq/KWQInvisibleButton.h: Removed.
  • kwq/KWQInvisibleButton.mm: Removed.
  • WebCore.pbproj/project.pbxproj: Removed KWQInvisibleButton.
9:15 AM Changeset in webkit [2081] by darin
  • 5 edits in trunk/WebCore
  • fixed 3027470 -- hitting tab when the google.com text field is selected (all bars hidden) makes border flash
  • kwq/KWQNSTextField.mm: (-[KWQNSTextField textDidEndEditing:]): Added. Don't call super when the next valid key view is nil. (-[KWQSecureTextField textDidEndEditing:]): Ditto. Too bad we can't share code here. Maybe I'll figure out a way later.
Note: See TracTimeline for information about the timeline view.