Timeline



Sep 23, 2002:

9:28 PM Changeset in webkit [2135] by cblu
  • 7 edits in trunk/WebKit

WebKit:

Factored URL pasteboard initialization to 1 place.
Fixed: 3048924 - regression: drag & drop broken for initial empty page
Fixed: 3045997 - Dragging a link from one Alex window to another one doesn't work

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): new
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate copyLinkToClipboard:]): call -[NSPasteboard _web_writeURL:andTitle:withOwner:]
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): call -[NSPasteboard _web_writeURL:andTitle:withOwner:]
  • WebView.subproj/WebView.m: (-[WebView draggingEntered:]): handle nil cases

WebBrowser:

  • main.m: (main): Fixed comment
6:56 PM Changeset in webkit [2134] by mjs
  • 6 edits in trunk/WebKit

Added documentation for these two delegate protocols.

  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebResourceProgressDelegate.h:
5:16 PM Changeset in webkit [2133] by rjw
  • 3 edits in trunk/WebKit

Made WebIconLoader and WebIconDatabase SPI.

  • WebKit.pbproj/project.pbxproj:
5:13 PM Changeset in webkit [2132] by rjw
  • 2 edits in trunk/WebKit/WebView.subproj

Put back changes I blew away.

5:02 PM Changeset in webkit [2131] by rjw
  • 42 edits
    2 adds
    12 deletes in trunk/WebKit

WebContextMenuHandler becomes WebContextMenuDelegate
WebControllerPolicyHandler becomes WebControllerPolicyDelegate
WebLocationChangeHandler becomes WebLocationChangeDelegate
WebResourceProgressHandler becomes WebResourceProgressDelegate
WebWindowContext becomes WebWindowOperationsDelegate

  • Misc.subproj/WebDownloadHandler.m:
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView drawRect:]):
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebNetscapePluginView status:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge window]): (-[WebBridge setStatusText:]): (-[WebBridge reportClientRedirectTo:delay:fireDate:]): (-[WebBridge reportClientRedirectCancelled]):
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebContextMenuHandler.h: Removed.
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setWindowOperationsDelegate:]): (-[WebController windowOperationsDelegate]): (-[WebController setResourceProgressDelegate:]): (-[WebController resourceProgressDelegate]): (-[WebController setDownloadProgressDelegate:]): (-[WebController downloadProgressDelegate]): (-[WebController setContextMenuDelegate:]): (-[WebController contextMenuDelegate]): (-[WebController setPolicyDelegate:]): (-[WebController policyDelegate]): (-[WebController setLocationChangeDelegate:]): (-[WebController locationChangeDelegate]):
  • WebView.subproj/WebControllerPolicyDelegate.m: Added. (-[WebPolicyPrivate dealloc]): (-[WebPolicy _setPolicyAction:]): (-[WebPolicy policyAction]): (-[WebPolicy path]): (-[WebPolicy URL]): (-[WebPolicy _setPath:]): (-[WebPolicy dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
  • WebView.subproj/WebControllerPolicyDelegatePrivate.h:
  • WebView.subproj/WebControllerPolicyHandler.h: Removed.
  • WebView.subproj/WebControllerPolicyHandler.m: Removed.
  • WebView.subproj/WebControllerPolicyHandlerPrivate.h: Removed.
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): (-[WebControllerPrivate dealloc]): (-[WebController _defaultContextMenuDelegate]): (-[WebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): (-[WebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setURL:]): (-[WebDataSource _loadIcon]):
  • WebView.subproj/WebDefaultContextMenuDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]): (-[WebDefaultContextMenuDelegate downloadURL:]):
  • WebView.subproj/WebDefaultContextMenuHandler.h: Removed.
  • WebView.subproj/WebDefaultContextMenuHandler.m: Removed.
  • WebView.subproj/WebDefaultPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebDefaultPolicyHandler.h: Removed.
  • WebView.subproj/WebDefaultPolicyHandler.m: Removed.
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): (-[WebFrame frameNamed:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]): (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]): (-[WebFrame handleUnimplementablePolicy:errorCode:forURL:]): (-[WebFrame _shouldShowURL:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView setNeedsLayout:]):
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebLocationChangeDelegate.m:
  • WebView.subproj/WebLocationChangeHandler.h: Removed.
  • WebView.subproj/WebLocationChangeHandler.m: Removed.
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient receivedProgressWithHandle:complete:]): (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient handleDidReceiveData:data:]):
  • WebView.subproj/WebResourceProgressDelegate.h:
  • WebView.subproj/WebResourceProgressHandler.h: Removed.
  • WebView.subproj/WebView.m: (-[WebView window]):
  • WebView.subproj/WebWindowContext.h: Removed.
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebContextMenuHandler becomes WebContextMenuDelegate
WebControllerPolicyHandler becomes WebControllerPolicyDelegate
WebLocationChangeHandler becomes WebLocationChangeDelegate
WebResourceProgressHandler becomes WebResourceProgressDelegate
WebWindowContext becomes WebWindowOperationsDelegate

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument dealloc]): (-[BrowserDocument close]):
  • BrowserWebController.h:
  • BrowserWebController.m: (-[BrowserWebController setFrame:]):
  • ContextMenuHandler.h:
  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
  • DownloadMonitor.h:
  • LocationChangeHandler.h:
4:02 PM Changeset in webkit [2130] by hyatt
  • 4 edits in trunk/WebCore

Found the problem with the CSS W3C page.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector):
3:43 PM Changeset in webkit [2129] by darin
  • 15 edits in trunk

WebCore:

WebCore part of fixes for proper layering when drawing subframes.

  • kwq/KWQWidget.mm: (QWidget::paint): Use the parent view in the "WebCoreFrameView" case so we update the scroll view too, not just the HTML part. Also use the passed in rectangle instead of always using the view bounds.
  • kwq/KWQScrollView.mm: (QScrollView::updateContents): Call setNeedsDisplayInRect instead of displayRect.
  • kwq/KWQPainter.mm: (QPainter::drawRect): Use NSRectFill and NSFrameRect instead of NSBezierPath. (QPainter::fillRect): Ditto.

WebKit:

  • fixed 3052543 -- iframes don't work with z-index
  • fixed 3057382 -- code to prevent subviews from drawing not working perfectly for subframes
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView isOpaque]): Change this back to always return YES. We handle this issue at another level now. (-[WebHTMLView drawRect:]): Clip to the passed-in rect. This was the big change that fixed most of the trouble.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove _isMainFrame.
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView initialize]): Add an imposter for NSView too, so we can make opaqueAncestor do what we need it to do. This will only work if the application doesn't also poseAsClass NSView, but it does work. (-[WebNSView opaqueAncestor]): Always return the topmost WebHTMLView if the object is inside one, even if there is an intervening opaque object.
  • WebView.subproj/WebView.m: (-[WebView setFrame:]): Do the display call at the window level so the topmost WebHTMLView always gets involved.
  • WebView.subproj/WebViewPrivate.h: Remove _controller, since we already have a public controller method. Add _isMainFrame.
  • WebView.subproj/WebViewPrivate.m: (-[WebView _isMainFrame]): Added.
3:17 PM Changeset in webkit [2128] by mjs
  • 3 edits in trunk/WebKit
  • Panels.subproj/WebStandardPanels.h: Added inline header docs.
2:44 PM Changeset in webkit [2127] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Changes to the WebCache interface to bring it closer into line
with the current API proposal. Changes in other classes have been made to
keep up with the WebCache changes.

Added removeCacheObjectForKey method.
Renamed cacheVars pointer in WebCache header to more "standard" _private.
Changed names of private methods so that they begin with underscores.

  • CacheLoader.subproj/WebCache.h:
  • CacheLoader.subproj/WebCache.m: (-[WebCache initWithSizeLimit:]) (-[WebCache removeCacheObjectForKey:]) (-[WebCache sizeLimit]) (-[WebCache setSizeLimit:]) (-[WebCache objectSizeLimit]) (-[WebCache setObjectSizeLimit:]) (-[WebCache currentUsage]) (-[WebCache clearCache]) (-[WebCache dealloc]) (-[WebCache _syncCache]) (-[WebCache _setCurrentUsage:]) (-[WebCache _truncateToSizeLimit:])
  • CacheLoader.subproj/WebCachePrivate.h:
  • CacheLoader.subproj/WebDiskCache.m: (-[WebDiskCache removeCacheObjectForKey:]) (-[WebDiskCache _syncCache]) (-[WebDiskCache _truncateToSizeLimit:])
  • CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCache _truncateToSizeLimit]) (-[WebMemoryCache storeCacheObject:forKey:]) (-[WebMemoryCache removeCacheObjectForKey:]) (-[WebMemoryCache clearCache])
  • CacheLoader.subproj/WebResourceLoadManager.m: (-[WebResourceLoadManager syncAllCaches])
  • Database.subproj/WebFileDatabase.m: (-[WebFileDatabase _truncateToSizeLimit:]) (-[WebFileDatabase performSetObject:forKey:]) (-[WebFileDatabase setSizeLimit:])
2:36 PM Changeset in webkit [2126] by mjs
  • 5 edits in trunk/WebKit
  • WebView.subproj/WebWindowContext.h: Added inline header docs.
12:30 PM Changeset in webkit [2125] by hyatt
  • 5 edits in trunk/WebCore

Don't let alternate stylesheets delay render tree construction.

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLLinkElementImpl::process): (HTMLLinkElementImpl::setStyleSheet): (HTMLLinkElementImpl::sheetLoaded):
  • khtml/html/html_headimpl.h:
10:56 AM Changeset in webkit [2124] by hyatt
  • 5 edits in trunk/WebCore

Make overflow:auto and scroll map to hidden until we figure
out something better.

  • khtml/css/cssstyleselector.cpp:
10:25 AM Changeset in webkit [2123] by kocienda
  • 8 edits in trunk/WebKit

Fixes for some build problems I missed earlier due to the fact that PB can't handle header dependencies,
and I did not do a clean build of WebKit.

  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedError:withDataSource:]): WebFoundation error constant name change. (-[WebNetscapePluginStream cancel]): Ditto.
  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]): Modified to use [[WebCookieManager sharedCookieManager] acceptPolicy] rather than reaching down into CFPreferences directly.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): WebFoundation error constant name change. (-[WebSubresourceClient cancel]): Ditto.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Ditto.
10:22 AM Changeset in webkit [2122] by darin
  • 3 edits in trunk/WebKit
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Don't special case the top level frame's view so much. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto. (-[NSView _web_propagateDirtyRectToAncestor]): Use public method here instead of private.
10:21 AM Changeset in webkit [2121] by darin
  • 12 edits in trunk/WebCore

More refinement of the AppKit hackery.

  • khtml/rendering/render_replaced.cpp: (RenderWidget::printObject): Pass in the painter and rect.
  • kwq/qt/qwidget.h: Take a painter and rect parameter.
  • kwq/KWQWidget.mm: (QWidget::paint): Use painter; not working yet to use rect.
  • kwq/KWQFileButton.h: Change paint to take painter and rect.
  • kwq/KWQFileButton.mm: (KWQFileButton::paint): Use painter.
  • kwq/qt/qpainter.h: Added paintingDisabled() function.
  • kwq/KWQPainter.mm: (QPainter::paintingDisabled): Added.
7:58 AM Changeset in webkit [2120] by kocienda
  • 4 edits in trunk/WebKit

WebFoundation:

Modified code to work with new WebError API. Many changes in that API, including removing terminal errors,
taking a pass at the error constants, and cleaning up the init methods.

  • AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager _checkForAuthenticationFailureInHTTPResponse:withURL:result:]): WebFoundation error code constant name changes
  • AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h: Removed WebResult enumerated type; replace with int
  • CacheLoader.subproj/IFURLHandleC.h: WebError API change
  • CacheLoader.subproj/IFURLHandleC.m: Ditto (IFURLHandleBackgroundLoadFailedWithResultCode):
  • CacheLoader.subproj/WebCacheLoaderConstants.h: Removed error constants; moved to WebError.h
  • CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle cancelLoadInBackground]): WebFoundation error code constant name changes
  • CacheLoader.subproj/WebResourceLoad.h: WebError API change
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]): WebError API change (-[WebResourceLoad didRedirectToURL:permanent:]): Ditto. (-[WebResourceLoad _scheduleOriginLoad]): Ditto. (-[WebResourceLoad _beginOriginLoad]): Ditto. (_loadSweeper): Ditto.
  • CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): WebFoundation error code constant name changes
  • English.lproj/WebError.strings: Updated strings file. This file was way out of date.
  • Misc.subproj/WebError.h: Updated API. Terminal error concept removed. API simplified. Error constants moved into this file.
  • Misc.subproj/WebError.m: (classInitialize): Changes to adapt to new API. (-[WebError initWithErrorCode:inDomain:failingURL:]): Ditto (-[WebError errorDescription]): Ditto (+[WebError addErrorsWithCodesAndDescriptions:inDomain:]): Ditto
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler continueBeginLoadInBackgroundAfterCreatingHTTPRequest]): WebFoundation error code constant na

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportBadURL:]): WebFoundation error code constant name change
  • WebView.subproj/WebView.m: (+[WebView initialize]): WebError addErrorsFromDictionary changed to addErrorsWithCodesAndDescriptions

WebBrowser:

Modified code to work with new WebError API.

  • DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDictionary:]): Modified for new "no terminal error" WebError API (-[DownloadProgressEntry stop]): WebFoundation error code constant name change
  • FrameProgressEntry.m: (-[FrameProgressEntry stage]): Ditto
  • LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): Ditto (-[LocationChangeHandler specializedMessageForError:]): Ditto (-[LocationChangeHandler displayLocationChangeError:]): Ditto
  • LocationChangeHandler.m: (-[LocationChangeHandler locationChangeDone:forDataSource:]): Modified for new "no terminal error" WebError API
  • Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences updateCookiesViews]): Fixed unitialized variable build breaker I encountered when doing a Deployment build.
  • ResourceProgressEntry.m: (-[ResourceProgressEntry stage]): WebFoundation error code constant name change

Sep 22, 2002:

9:31 PM Changeset in webkit [2119] by darin
  • 3 edits in trunk/WebKit
  • fixed 3057380 -- insertion point shows through elements in front of text fields
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView initialize]): Make WebNSTextView pose as NSTextView. (-[WebNSTextView _web_inHTMLView]): Helper method. (-[WebNSTextView isOpaque]): Override to return NO for all text views that are inside an WebHTMLView, so they don't try to do insertion point caching. (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Use setNeedsDisplayInRect to trigger insertion point drawing outside drawRect instead of drawing right away. (-[WebNSTextView _drawRect:clip:]): Set flag so the above can know when it's inside drawRect and when it's not.
9:27 PM Changeset in webkit [2118] by darin
  • 8 edits in trunk/WebCore

Change code that moves NSViews out of the way to run inside drawRect
after a layout change rather than running at layout time. This makes
sure that views are in the right place when propagating dirty rects.

  • kwq/KWQKHTMLPartImpl.h: Add paint method and _needsToSetWidgetsAside flag.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Set _needsToSetWidgetsAside to false. (KWQKHTMLPartImpl::layout): Set _needsToSetWidgetsAside to true. Don't call moveWidgetsAside any more. (KWQKHTMLPartImpl::paint): Moved the code here from the bridge, but also call moveWidgetsAside if _needsToSetWidgetsAside flag is set.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Call KWQKHTMLPartImpl::paint, which is where I moved this code.

Sep 21, 2002:

11:01 PM Changeset in webkit [2117] by darin
  • 3 edits in trunk/WebCore
  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Remove special case for javascript and about:blank that was leading to a crash.
10:52 PM Changeset in webkit [2116] by darin
  • 4 edits in trunk/WebCore

Fix crashing part of 3057265 -- REGRESSION: Crash loading ​http://www.undetectables.co.uk/

  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Remove special case for javascript and about:blank that was leading to a crash.
4:54 PM Changeset in webkit [2115] by darin
  • 26 edits in trunk

WebCore:

WebCore part of the new approach to AppKit drawing control.
Works better than the previous try. Once we fix anomalies with focus rectangles
and a minor problems with subframes this should work perfectly.

  • kwq/qt/qwidget.h: The paint() method isn't virtual any more. Also remove flushDrawing().
  • kwq/KWQWidget.mm: (QWidget::enableFlushDrawing): Do a flushWindowIfNeeded instead of requiring a separate flushDrawing() call to do a flushWindow. (QWidget::paint): Added. Calls displayRectIgnoringOpacity.
  • kwq/qt/qbutton.h: Remove paint() override.
  • kwq/KWQButton.mm: (QButton::QButton): No need for a subclass any more, so drop KWQNSButton. Also remove paint().
  • kwq/qt/qcombobox.h: Remove paint() override.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): No need for a subclass any more, so drop KWQNSPopUpButton. Also remove paint() method.
  • kwq/qt/qlineedit.h: Remove paint() override.
  • kwq/KWQLineEdit.mm: Remove paint().
  • kwq/KWQFileButton.mm: (KWQFileButton::clicked): Fix typo. Was calling paint instead of clicked on the base class.
  • kwq/KWQNSTextField.h: Remove paint method.
  • kwq/KWQNSTextField.mm: (-[KWQNSTextField display]): Add a display method that does nothing to work around bug 2753974. (-[KWQSecureTextField display]): Ditto.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): Remove call to flushDrawing.

WebKit:

WebKit part of the new approach to AppKit drawing control.
Works better than the previous try. Once we fix anomalies with focus rectangles
and a some remaining problems with subframes this should work perfectly.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView isOpaque]): Return NO for frames other than the main frame. (-[WebHTMLView drawRect:]): Restore the subviews that were set aside.
  • WebView.subproj/WebHTMLViewPrivate.h: Add _isMainFrame. Add savedSubviews and subviewsSetAside.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _isMainFrame]): Added. (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Added. If this is the main frame, get all the dirty rects from the subviews and then set them aside so the AppKit machinery won't draw them. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto. (-[NSView _web_propagateDirtyRectToAncestor]): Added. Propagates dirty rects the same way that AppKit does, but always does it, ignoring the value of isOpaque.

Sep 20, 2002:

6:58 PM Changeset in webkit [2114] by rjw
  • 4 edits in trunk/WebCore

Don't modify selection if no appropriate DOM::Node under
mouse.

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseMoveEvent):
6:44 PM Changeset in webkit [2113] by rjw
  • 4 edits in trunk/WebCore

Assume triple click for selection if click count >= 3,
not == 3, as in OS X.

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMousePressEvent):
6:33 PM Changeset in webkit [2112] by rjw
  • 5 edits in trunk/WebCore

Fixed crasher in findTextSlave.

  • khtml/rendering/render_text.cpp: (RenderText::findTextSlave):

Added error checks.

  • khtml/khtml_part.cpp: (startAndEndLineNodesIncludingNode):
6:00 PM Changeset in webkit [2111] by rjw
  • 1 edit in trunk/WebCore/khtml/xml/dom_elementimpl.cpp

Removed debugging.

5:58 PM Changeset in webkit [2110] by rjw
  • 12 edits in trunk/WebCore

Made double and triple click selection behave like
like other selection in OS X. That is, selection happens
on mouse down, not mouse up, and can be extended by
further dragging. Triple click followed by dragging extends
the selection a line at a time.

  • khtml/khtml_events.cpp:
  • khtml/khtml_events.h:
  • khtml/khtml_part.cpp: (KHTMLPart::customEvent): (firstSlaveAt): (lastSlaveAt): (startAndEndLineNodesIncludingNode): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseDoubleClickEvent): (KHTMLPart::khtmlMouseMoveEvent):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp:
  • khtml/khtmlview.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttribute):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]):
5:42 PM Changeset in webkit [2109] by darin
  • 8 edits in trunk/WebCore
  • kwq/KWQFileButton.h: Add an icon.
  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Nil out icon. (KWQFileButton::~KWQFileButton): Release icon. (KWQFileButton::setFilename): Get icon with [NSWorkspace iconForFile:]. (KWQFileButton::clicked): Set prompt string to "Choose", and start directory to "~". (KWQFileButton::sizeHint): Pad more for icon width. (KWQFileButton::frameGeometry): Ditto. (KWQFileButton::setFrameGeometry): Ditto. (KWQFileButton::paint): Draw icon. Draw "no file selected" if no filename.
  • kwq/KWQKFileItem.mm: Our "nonimplementation" is good enough. Stop complaining.
  • kwq/KWQKnetaccess.mm: Ditto. Also just extract path when asked to download.
4:45 PM Changeset in webkit [2108] by darin
  • 6 edits
    2 adds
    1 delete in trunk/WebCore

Some first steps toward implementing input=file.

  • khtml/rendering/render_form.cpp: (RenderFileButton::RenderFileButton): Create a KWQFileButton as the widget. (RenderFileButton::calcMinMaxWidth): Use sizeHint(). (RenderFileButton::updateFromElement): Call setFilename(). (RenderFileButton::select): Don't try to selectAll() on m_edit.
  • kwq/KWQFileButton.h: Added.
  • kwq/KWQFileButton.mm: Added.
  • kwq/qt/qhbox.h: Emptied.
  • kwq/KWQHBox.mm: Removed.
  • WebCore.pbproj/project.pbxproj: Removed KWQHBox.mm. Added KWQFileButton.
2:26 PM Changeset in webkit [2107] by darin
  • 4 edits in trunk/WebCore
  • kwq/mac-encodings.txt: When people say ShiftJIS, they really mean DOSJapanese. So do what they mean, not what they say.
12:23 PM Changeset in webkit [2106] by darin
  • 5 edits in trunk/WebKit
  • History.subproj/WebHistory.m: (-[WebHistory addEntryForURLString:]): Use _web_URLWithString so we can handle unusual characters.
  • WebView.subproj/WebDefaultPolicyHandler.m: Remove stray semicolon.
10:13 AM Changeset in webkit [2105] by darin
  • 5 edits in trunk/WebCore
  • fixed 3055339 -- repro crash in RenderPartObject::updateWidget()
  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Only create a new part if we have no old part.
  • kwq/KWQtextstream.mm: Remove some of the "not implemented" logging. Once we have logged that the stream is not created correctly, there's no need to continue logging each time something is written out to the non-stream.
9:58 AM Changeset in webkit [2104] by cblu
  • 6 edits in trunk/WebKit

Fixed wasteful memory usage in the WebIconDatabase:

  • Rather than have multiple NSImages with multiple representations at multiple sizes, have 1 NSImage per size
  • Added API to allow client to control memory caching
  • Misc.subproj/WebIconDatabase.h:
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:]): call iconForSiteURL:withSize:cache:YES (-[WebIconDatabase iconForSiteURL:withSize:cache:]): new, was iconForSiteURL:withSize: (-[WebIconDatabase defaultIconWithSize:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _updateFileDatabase]): write the largest icon to disk (-[WebIconDatabase _hasIconForSiteURL:]): cleaned-up (-[WebIconDatabase _iconsForIconURL:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _iconForFileURL:withSize:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _builtInIconsForHost:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _setIcon:forIconURL:]): _iconsBySplittingRepresentationsOfIcon: (-[WebIconDatabase _releaseIconForIconURL:]): icons at different sizes are now stored in dictionaries (-[WebIconDatabase _largestIconFromDictionary:]): new, scans the icon dictionary (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): creates the icon dictionary (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): returns icon from dict, resizes if necessary (-[WebIconDatabase _iconByScalingIcon:toSize:]): tweak
  • Misc.subproj/WebIconDatabasePrivate.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): don't call _iconsForIconURL: because it doesn't exist.

Sep 19, 2002:

11:25 PM Changeset in webkit [2103] by mjs
  • 8 edits in trunk/WebKit

WebFoundation:

  • Makefile.am: Make doc' target depend on all'.

WebKit:

  • Makefile.am: Make doc' target depend on all'.
  • WebView.subproj/WebContextMenuHandler.h: Fix typo found by `make doc'.
  • WebView.subproj/WebLocationChangeHandler.h: Likewise.
10:42 PM Changeset in webkit [2102] by mjs
  • 3 edits in trunk/WebKit

Tools:

  • Scripts/make-docs: Added. New script to generate html docs.

WebFoundation:

  • Makefile.am: Changed `make doc' target to use make-docs script (and actually work).
  • CacheLoader.subproj/WebProtocolHandler.h: Remove some docs that made headerdoc2html barf.
  • CacheLoader.subproj/WebCacheObject.h: Added some docs.
  • CacheLoader.subproj/WebResourceHandle.h: Added some docs.
  • CacheLoader.subproj/WebResourceResponse.h: Added some docs.

WebKit:

  • Makefile.am: Added `make doc' target.
9:09 PM Changeset in webkit [2101] by rjw
  • 8 edits in trunk/WebCore

Implemented double and triple click selection.

  • khtml/khtml_events.h:
  • khtml/khtml_part.cpp: (KHTMLPart::customEvent): (KHTMLPart::khtmlMouseDoubleClickEvent): (firstSlaveAt): (lastSlaveAt): (KHTMLPart::khtmlMouseTripleClickEvent):
  • khtml/khtml_part.h:
  • khtml/rendering/render_text.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]):
6:03 PM Changeset in webkit [2100] by darin
  • 5 edits in trunk/WebCore
  • fixed 3045651 -- null-dereference in DOM::CharacterDataImpl constructor setting up text area element
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::CharacterDataImpl): Set str to an empty DOMStringImpl instead of to 0. This was easier than going around finding all the places that don't like a str of 0.
  • WebCore.pbproj/project.pbxproj: Let PB sort things as it likes.
11:59 AM Changeset in webkit [2099] by sullivan
  • 6 edits
    2 adds in trunk/WebKit

WebKit:

  • cleaned up some SPI for handling URLs on pasteboard
  • Misc.subproj/WebNSPasteboardExtras.h: Added.
  • Misc.subproj/WebNSPasteboardExtras.m: Added. (+[NSPasteboard _web_dragTypesForURL]): Moved this here; was -[NSView _web_acceptableDragTypes] (-[NSPasteboard _web_bestURL]): Moved this here; was +[NSView _web_bestURLFromPasteboard:]
  • WebView.subproj/WebView.m: (-[WebView initWithFrame:]), (-[WebView draggingEntered:]), (-[WebView concludeDragOperation:]): Updated for SPI change; also removed methods now in NSPasteboard.
  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragOperationForDraggingInfo:]): Updated for SPI change.
  • WebKit.pbproj/project.pbxproj: Updated for new files.

WebBrowser:

  • updated to match SPI changes in WebKit
  • BrowserWebBookmarkExtras.m: (+[WebBookmark bookmarkPasteboardTypes]): Use +[NSPasteboard _web_dragTypesForURL] instead of secret inside knowledge about which types are used by [NSPasteboard _web_bestURL] (+[WebBookmark anyBookmarksOnPasteboard:]), (+[WebBookmark bookmarksFromPasteboard:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL]
  • LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): (-[LocationFieldEditor concludeDragOperation:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL], and replace -[NSView _web_acceptableDragTypes] with +[NSPasteboard _web_dragTypesForURL]
  • LocationTextField.m: (-[LocationTextField awakeFromNib]): (-[LocationTextField concludeDragOperation:]): replace +[NSView _web_bestURLFromPasteboard:] with -[NSPasteboard _web_bestURL], and replace -[NSView _web_acceptableDragTypes] with +[NSPasteboard _web_dragTypesForURL]
11:17 AM Changeset in webkit [2098]
  • 3 copies in tags/Alexander-24

This commit was manufactured by cvs2svn to create tag 'Alexander-24'.

11:17 AM Changeset in webkit [2097] by sheridan
  • 8 edits in trunk

Alex-24 version stamp

Note: See TracTimeline for information about the timeline view.