⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 24, 2002:

6:42 PM Changeset in webkit [2157] by rjw
  • 11 edits in trunk/WebKit

More documentation tweaks.

  • History.subproj/WebHistory.h:
  • History.subproj/WebHistoryItem.h:
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebResourceProgressDelegate.h:
6:20 PM Changeset in webkit [2156] by darin
  • 8 edits
    2 adds in trunk/WebKit
  • fixed 3059513 -- REGRESSION: Scrolling to fragment doesn't work

Turns out it was better to just put the extra smarts into the clip view
that we are already creating. Making WebHTMLView be a second clip view
was silly and broke things.

  • WebView.subproj/WebView.m: (-[WebView initWithFrame:]): Create a WebClipView and use it as the content view rather than the NSClipView created by default.
  • WebKit.pbproj/project.pbxproj: Added WebClipView.
  • WebView.subproj/WebClipView.h: Added.
  • WebView.subproj/WebClipView.m: Added.
  • WebView.subproj/WebHTMLView.h: Don't be a subclass of NSClipView any more.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Call setAdditionalClip and resetAdditionalClip on the clip view.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove inDrawRect and drawRect.
  • WebView.subproj/WebHTMLViewPrivate.m: Remove visibleRect override. This is now in WebClipView.
5:31 PM Changeset in webkit [2155] by darin
  • 7 edits in trunk/WebCore

Tests:

  • harness.c: (runtest): Turn off leak checking. It's broken.
  • qt/qdate-test.chk: Update test for changes to QDate.
  • qt/qdate-test.cpp: (main): Ditto.
  • qt/qtime-test.chk: Update test for changes to QTime.
  • qt/qtime-test.cpp: (main): Ditto.

WebCore:

  • fixed 3057928 -- lstat private/etc/localtime repeatedly reported by fs_usage when mouse is moved
  • WebCore-tests.exp: Remove now-unneeded external entry points for QTime, QDate, QDateTime.
  • kwq/qt/qdatetime.h:
  • kwq/KWQDateTime.mm: Redid QDateTime using CoreFoundation instead of time/localtime. This avoids constantly hitting the disk when getting the current time to stuff into an event.
5:30 PM Changeset in webkit [2154] by cblu
  • 6 edits in trunk/WebKit

More documentation changes.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.h:
  • WebView.subproj/WebDocument.h:
4:25 PM Changeset in webkit [2153] by hyatt
  • 4 edits in trunk/WebCore

Make sure we dispatch both a capturing and a bubbling event
to target nodes. DOM lvl 2 event compliance.

  • ChangeLog:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent):
4:22 PM Changeset in webkit [2152] by rjw
  • 4 edits in trunk/WebKit

Added FIXME not about unresolved issue with CFStringEncoding/NSStringEncoding.

  • WebView.subproj/WebController.h:
4:20 PM Changeset in webkit [2151] by rjw
  • 11 edits in trunk

i Fixed 3055078. Ensure file: URLs have before path.

  • kwq/KWQKURL.mm: (KURL::parse):

Documentation for WebDataSource and WebFrame.

  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource frameExists:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource addFrame:]):
  • WebView.subproj/WebFrame.h:
3:34 PM Changeset in webkit [2150] by hyatt
  • 4 edits in trunk/WebCore

Better fix. Clears the boolean when CLASS has no value.
This will keep the style system from thinking you have
a class when you don't.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):
3:21 PM Changeset in webkit [2149] by hyatt
  • 4 edits in trunk/WebCore

Fix updating of the document's notion of the focused node
to happen on mouse down rather than click. This matches
the behavior of all other browsers (IE, Gecko, etc.).

This fixes the drawing of the outline on the brainjar.com
DHTML menus.

  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent):
3:20 PM Changeset in webkit [2148] by darin
  • 3 edits in trunk/WebKit
  • fixed 3059266 -- REGRESSION: clicking in web view when location field is focused does not focus web view
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView needsPanelToBecomeKey]): Must override this to return YES, because NSClipView makes it return NO even though we accept the first responder.
2:45 PM Changeset in webkit [2147] by hyatt
  • 4 edits in trunk/WebCore

Make sure that changes to the CLASS attribute mark the
element as changed (as if a CSS property were added or
removed).

This makes the brainjar.com rollovers work much better.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):
2:26 PM Changeset in webkit [2146] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3056158 -- REGRESSION: Page up/down should scroll one whole contentView minus at least one readable line of text

This was broken a while back when the keyboard scrolling code
migrated into WebKit.

  • WebView.subproj/WebViewPrivate.m: (-[WebView _verticalKeyboardScrollAmount]), (-[WebView _horizontalKeyboardScrollAmount]): New private methods, return one arrow key's worth of scrolling. (-[WebView _scrollLineVertically:]), (-[WebView _scrollLineHorizontally:]): Now use the broken-out methods. (-[WebView _pageVertically:]), (-[WebView _pageHorizontally:]): overlap by one arrow key's worth of scrolling instead of the teensy-weensy one click's worth.
2:02 PM Changeset in webkit [2145] by cblu
  • 3 edits in trunk/WebKit

Documentation for WebHTMLView

  • WebView.subproj/WebHTMLView.h:
1:05 PM Changeset in webkit [2144] by rjw
  • 16 edits in trunk/WebKit

Documentation changes. Removal of imports from
some headers required modification of .m.

  • Plugins.subproj/WebNullPluginView.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m:
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate defaultURLPolicyForURL:]): (-[WebDefaultPolicyDelegate URLPolicyForURL:inFrame:]):
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebHTMLViewPrivate.m:

Documentation changes. Removal of imports from
some headers required modification of .m.

  • BrowserDocument.m:
  • BrowserWebController.m: (-[BrowserWebController URLPolicyForURL:inFrame:]):
  • DownloadMonitor.m:
  • DownloadProgressEntry.m:
11:37 AM Changeset in webkit [2143] by cblu
  • 21 edits in trunk

WebCore:

Renamed element info keys to WebElement* instead of WebContextMenuElement*

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

WebKit:

Renamed element info keys to WebElement* instead of WebContextMenuElement*
Added WebKit API documentation

  • Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin load]): clean-up
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m:
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]): (-[WebDefaultContextMenuDelegate downloadURL:]): (-[WebDefaultContextMenuDelegate openLinkInNewWindow:]): (-[WebDefaultContextMenuDelegate downloadLinkToDisk:]): (-[WebDefaultContextMenuDelegate copyLinkToClipboard:]): (-[WebDefaultContextMenuDelegate openImageInNewWindow:]): (-[WebDefaultContextMenuDelegate downloadImageToDisk:]): (-[WebDefaultContextMenuDelegate copyImageToClipboard:]): (-[WebDefaultContextMenuDelegate openFrameInNewWindow:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):

WebBrowser:

Renamed element info keys to WebElement* instead of WebContextMenuElement*

  • BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierMask:]):
  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler addLinkToBookmarks:]): (-[ContextMenuHandler viewSource:]): (-[ContextMenuHandler savePageAs:]): (-[ContextMenuHandler openWithiTunes:]):
11:29 AM Changeset in webkit [2142] by darin
  • 8 edits in trunk/WebKit

Cleaned up some loose ends from adding setNeedsLayout to the WebDocumentView
protocol. Was causing exceptions.

  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setNeedsLayout:]):
  • WebView.subproj/WebTextView.m: (-[WebTextView setNeedsLayout:]): Added missing stubs.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsReapplyStyles]): Removed unneeded cast.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]): Remove an unneeded cast and call to isDocumentHTML.
  • WebView.subproj/WebHTMLView.h: No need to re-declare setNeedsLayout.
  • WebView.subproj/WebView.m: (-[WebView setFrame:]): Get rid of unneeded check of isDocumentHTML.
10:48 AM Changeset in webkit [2141] by darin
  • 4 edits in trunk/WebCore

Apparently the strings at this site were just the right length to expose a bug
in our QString implementation, one that I probably introduced when fixing 3032072.
One nice thing about this is that getting this correct could also result in a
little bit of a speedup, as the internal buffer is used more.

  • kwq/KWQString.mm: (QStringData::makeAscii): Set _maxAscii to QS_INTERNAL_BUFFER_CHARS when using the internal buffer instead of leaving it uninitialized. (QStringData::makeUnicode): Same for _maxUnicode.
10:24 AM Changeset in webkit [2140] by darin
  • 10 edits in trunk/WebCore

Remove the focus border hack, which was no longer doing us any good.

  • kwq/KWQNSTextField.h: Don't define FOCUS_BORDER_SIZE.
  • kwq/KWQNSTextField.mm: Remove KWQTextFieldCell. (-[KWQNSTextField updateSecureFieldFrame]): Don't inset by FOCUS_BORDER_SIZE.
  • kwq/qt/qlineedit.h: Don't override frameGeometry and setFrameGeometry any more.
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Don't subtract the focus border size.
10:17 AM Changeset in webkit [2139] by darin
  • 6 edits in trunk/WebKit
  • fixed 3057383 -- focus rectangles are being drawn multiple times
  • fixed 3051025 -- focus ring on password field gets darker and darker

To make focus rings clip too, we have to do more than just set the clip.
We also have to set the visible rectangle to make clipping happen, and we
need to be a subclass of NSClipView so that the focus ring drawing code will
consult us rather than one of our superviews.

  • WebView.subproj/WebHTMLView.h: Be a subclass of NSClipView.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Set a inDrawRect flag, and a drawRect rectangle. This tells us to clip to this rectangle. what we need to clip to.
  • WebView.subproj/WebHTMLViewPrivate.h: Added inDrawRect and drawRect.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView visibleRect]): Clip the visible rect based on the drawRect while inDrawRect is set.
10:13 AM Changeset in webkit [2138] by darin
  • 4 edits in trunk/WebCore
  • kwq/mac-encodings.txt: Remove constant for Japanese auto-detect.
9:53 AM Changeset in webkit [2137] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQFileButton.mm: (KWQFileButton::paint): Fix typo.
9:22 AM Changeset in webkit [2136] by darin
  • 5 edits in trunk/WebCore

Some improvements to the file button, including displaying the file without the
extension if it's set that way by the user, and using the system font rather
than hard-coding "Lucida Grande".

  • kwq/KWQFileButton.h: Add _label field.
  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Set up label. (KWQFileButton::~KWQFileButton): Release label. (KWQFileButton::setFilename): Use NSFileManager componentsToDisplayForPath to figure out the appropriate label. (KWQFileButton::paint): Clip to passed-in rect, get font using systemFontOfSize, and use NSString drawing rather than our own.

Sep 23, 2002:

9:28 PM Changeset in webkit [2135] by cblu
  • 7 edits in trunk/WebKit

WebKit:

Factored URL pasteboard initialization to 1 place.
Fixed: 3048924 - regression: drag & drop broken for initial empty page
Fixed: 3045997 - Dragging a link from one Alex window to another one doesn't work

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): new
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate copyLinkToClipboard:]): call -[NSPasteboard _web_writeURL:andTitle:withOwner:]
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): call -[NSPasteboard _web_writeURL:andTitle:withOwner:]
  • WebView.subproj/WebView.m: (-[WebView draggingEntered:]): handle nil cases

WebBrowser:

  • main.m: (main): Fixed comment
6:56 PM Changeset in webkit [2134] by mjs
  • 6 edits in trunk/WebKit

Added documentation for these two delegate protocols.

  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebResourceProgressDelegate.h:
5:16 PM Changeset in webkit [2133] by rjw
  • 3 edits in trunk/WebKit

Made WebIconLoader and WebIconDatabase SPI.

  • WebKit.pbproj/project.pbxproj:
5:13 PM Changeset in webkit [2132] by rjw
  • 2 edits in trunk/WebKit/WebView.subproj

Put back changes I blew away.

5:02 PM Changeset in webkit [2131] by rjw
  • 42 edits
    2 adds
    12 deletes in trunk/WebKit

WebContextMenuHandler becomes WebContextMenuDelegate
WebControllerPolicyHandler becomes WebControllerPolicyDelegate
WebLocationChangeHandler becomes WebLocationChangeDelegate
WebResourceProgressHandler becomes WebResourceProgressDelegate
WebWindowContext becomes WebWindowOperationsDelegate

  • Misc.subproj/WebDownloadHandler.m:
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView drawRect:]):
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebNetscapePluginView status:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge window]): (-[WebBridge setStatusText:]): (-[WebBridge reportClientRedirectTo:delay:fireDate:]): (-[WebBridge reportClientRedirectCancelled]):
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebContextMenuHandler.h: Removed.
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setWindowOperationsDelegate:]): (-[WebController windowOperationsDelegate]): (-[WebController setResourceProgressDelegate:]): (-[WebController resourceProgressDelegate]): (-[WebController setDownloadProgressDelegate:]): (-[WebController downloadProgressDelegate]): (-[WebController setContextMenuDelegate:]): (-[WebController contextMenuDelegate]): (-[WebController setPolicyDelegate:]): (-[WebController policyDelegate]): (-[WebController setLocationChangeDelegate:]): (-[WebController locationChangeDelegate]):
  • WebView.subproj/WebControllerPolicyDelegate.m: Added. (-[WebPolicyPrivate dealloc]): (-[WebPolicy _setPolicyAction:]): (-[WebPolicy policyAction]): (-[WebPolicy path]): (-[WebPolicy URL]): (-[WebPolicy _setPath:]): (-[WebPolicy dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
  • WebView.subproj/WebControllerPolicyDelegatePrivate.h:
  • WebView.subproj/WebControllerPolicyHandler.h: Removed.
  • WebView.subproj/WebControllerPolicyHandler.m: Removed.
  • WebView.subproj/WebControllerPolicyHandlerPrivate.h: Removed.
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): (-[WebControllerPrivate dealloc]): (-[WebController _defaultContextMenuDelegate]): (-[WebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): (-[WebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setURL:]): (-[WebDataSource _loadIcon]):
  • WebView.subproj/WebDefaultContextMenuDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]): (-[WebDefaultContextMenuDelegate downloadURL:]):
  • WebView.subproj/WebDefaultContextMenuHandler.h: Removed.
  • WebView.subproj/WebDefaultContextMenuHandler.m: Removed.
  • WebView.subproj/WebDefaultPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebDefaultPolicyHandler.h: Removed.
  • WebView.subproj/WebDefaultPolicyHandler.m: Removed.
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): (-[WebFrame frameNamed:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]): (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]): (-[WebFrame handleUnimplementablePolicy:errorCode:forURL:]): (-[WebFrame _shouldShowURL:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView setNeedsLayout:]):
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebLocationChangeDelegate.m:
  • WebView.subproj/WebLocationChangeHandler.h: Removed.
  • WebView.subproj/WebLocationChangeHandler.m: Removed.
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient receivedProgressWithHandle:complete:]): (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient handleDidReceiveData:data:]):
  • WebView.subproj/WebResourceProgressDelegate.h:
  • WebView.subproj/WebResourceProgressHandler.h: Removed.
  • WebView.subproj/WebView.m: (-[WebView window]):
  • WebView.subproj/WebWindowContext.h: Removed.
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebContextMenuHandler becomes WebContextMenuDelegate
WebControllerPolicyHandler becomes WebControllerPolicyDelegate
WebLocationChangeHandler becomes WebLocationChangeDelegate
WebResourceProgressHandler becomes WebResourceProgressDelegate
WebWindowContext becomes WebWindowOperationsDelegate

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument dealloc]): (-[BrowserDocument close]):
  • BrowserWebController.h:
  • BrowserWebController.m: (-[BrowserWebController setFrame:]):
  • ContextMenuHandler.h:
  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
  • DownloadMonitor.h:
  • LocationChangeHandler.h:
4:02 PM Changeset in webkit [2130] by hyatt
  • 4 edits in trunk/WebCore

Found the problem with the CSS W3C page.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector):
3:43 PM Changeset in webkit [2129] by darin
  • 15 edits in trunk

WebCore:

WebCore part of fixes for proper layering when drawing subframes.

  • kwq/KWQWidget.mm: (QWidget::paint): Use the parent view in the "WebCoreFrameView" case so we update the scroll view too, not just the HTML part. Also use the passed in rectangle instead of always using the view bounds.
  • kwq/KWQScrollView.mm: (QScrollView::updateContents): Call setNeedsDisplayInRect instead of displayRect.
  • kwq/KWQPainter.mm: (QPainter::drawRect): Use NSRectFill and NSFrameRect instead of NSBezierPath. (QPainter::fillRect): Ditto.

WebKit:

  • fixed 3052543 -- iframes don't work with z-index
  • fixed 3057382 -- code to prevent subviews from drawing not working perfectly for subframes
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView isOpaque]): Change this back to always return YES. We handle this issue at another level now. (-[WebHTMLView drawRect:]): Clip to the passed-in rect. This was the big change that fixed most of the trouble.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove _isMainFrame.
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView initialize]): Add an imposter for NSView too, so we can make opaqueAncestor do what we need it to do. This will only work if the application doesn't also poseAsClass NSView, but it does work. (-[WebNSView opaqueAncestor]): Always return the topmost WebHTMLView if the object is inside one, even if there is an intervening opaque object.
  • WebView.subproj/WebView.m: (-[WebView setFrame:]): Do the display call at the window level so the topmost WebHTMLView always gets involved.
  • WebView.subproj/WebViewPrivate.h: Remove _controller, since we already have a public controller method. Add _isMainFrame.
  • WebView.subproj/WebViewPrivate.m: (-[WebView _isMainFrame]): Added.
3:17 PM Changeset in webkit [2128] by mjs
  • 3 edits in trunk/WebKit
  • Panels.subproj/WebStandardPanels.h: Added inline header docs.
2:44 PM Changeset in webkit [2127] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Changes to the WebCache interface to bring it closer into line
with the current API proposal. Changes in other classes have been made to
keep up with the WebCache changes.

Added removeCacheObjectForKey method.
Renamed cacheVars pointer in WebCache header to more "standard" _private.
Changed names of private methods so that they begin with underscores.

  • CacheLoader.subproj/WebCache.h:
  • CacheLoader.subproj/WebCache.m: (-[WebCache initWithSizeLimit:]) (-[WebCache removeCacheObjectForKey:]) (-[WebCache sizeLimit]) (-[WebCache setSizeLimit:]) (-[WebCache objectSizeLimit]) (-[WebCache setObjectSizeLimit:]) (-[WebCache currentUsage]) (-[WebCache clearCache]) (-[WebCache dealloc]) (-[WebCache _syncCache]) (-[WebCache _setCurrentUsage:]) (-[WebCache _truncateToSizeLimit:])
  • CacheLoader.subproj/WebCachePrivate.h:
  • CacheLoader.subproj/WebDiskCache.m: (-[WebDiskCache removeCacheObjectForKey:]) (-[WebDiskCache _syncCache]) (-[WebDiskCache _truncateToSizeLimit:])
  • CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCache _truncateToSizeLimit]) (-[WebMemoryCache storeCacheObject:forKey:]) (-[WebMemoryCache removeCacheObjectForKey:]) (-[WebMemoryCache clearCache])
  • CacheLoader.subproj/WebResourceLoadManager.m: (-[WebResourceLoadManager syncAllCaches])
  • Database.subproj/WebFileDatabase.m: (-[WebFileDatabase _truncateToSizeLimit:]) (-[WebFileDatabase performSetObject:forKey:]) (-[WebFileDatabase setSizeLimit:])
2:36 PM Changeset in webkit [2126] by mjs
  • 5 edits in trunk/WebKit
  • WebView.subproj/WebWindowContext.h: Added inline header docs.
12:30 PM Changeset in webkit [2125] by hyatt
  • 5 edits in trunk/WebCore

Don't let alternate stylesheets delay render tree construction.

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLLinkElementImpl::process): (HTMLLinkElementImpl::setStyleSheet): (HTMLLinkElementImpl::sheetLoaded):
  • khtml/html/html_headimpl.h:
10:56 AM Changeset in webkit [2124] by hyatt
  • 5 edits in trunk/WebCore

Make overflow:auto and scroll map to hidden until we figure
out something better.

  • khtml/css/cssstyleselector.cpp:
10:25 AM Changeset in webkit [2123] by kocienda
  • 8 edits in trunk/WebKit

Fixes for some build problems I missed earlier due to the fact that PB can't handle header dependencies,
and I did not do a clean build of WebKit.

  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedError:withDataSource:]): WebFoundation error constant name change. (-[WebNetscapePluginStream cancel]): Ditto.
  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]): Modified to use [[WebCookieManager sharedCookieManager] acceptPolicy] rather than reaching down into CFPreferences directly.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): WebFoundation error constant name change. (-[WebSubresourceClient cancel]): Ditto.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Ditto.
10:22 AM Changeset in webkit [2122] by darin
  • 3 edits in trunk/WebKit
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Don't special case the top level frame's view so much. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto. (-[NSView _web_propagateDirtyRectToAncestor]): Use public method here instead of private.
10:21 AM Changeset in webkit [2121] by darin
  • 12 edits in trunk/WebCore

More refinement of the AppKit hackery.

  • khtml/rendering/render_replaced.cpp: (RenderWidget::printObject): Pass in the painter and rect.
  • kwq/qt/qwidget.h: Take a painter and rect parameter.
  • kwq/KWQWidget.mm: (QWidget::paint): Use painter; not working yet to use rect.
  • kwq/KWQFileButton.h: Change paint to take painter and rect.
  • kwq/KWQFileButton.mm: (KWQFileButton::paint): Use painter.
  • kwq/qt/qpainter.h: Added paintingDisabled() function.
  • kwq/KWQPainter.mm: (QPainter::paintingDisabled): Added.
7:58 AM Changeset in webkit [2120] by kocienda
  • 4 edits in trunk/WebKit

WebFoundation:

Modified code to work with new WebError API. Many changes in that API, including removing terminal errors,
taking a pass at the error constants, and cleaning up the init methods.

  • AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager _checkForAuthenticationFailureInHTTPResponse:withURL:result:]): WebFoundation error code constant name changes
  • AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h: Removed WebResult enumerated type; replace with int
  • CacheLoader.subproj/IFURLHandleC.h: WebError API change
  • CacheLoader.subproj/IFURLHandleC.m: Ditto (IFURLHandleBackgroundLoadFailedWithResultCode):
  • CacheLoader.subproj/WebCacheLoaderConstants.h: Removed error constants; moved to WebError.h
  • CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle cancelLoadInBackground]): WebFoundation error code constant name changes
  • CacheLoader.subproj/WebResourceLoad.h: WebError API change
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]): WebError API change (-[WebResourceLoad didRedirectToURL:permanent:]): Ditto. (-[WebResourceLoad _scheduleOriginLoad]): Ditto. (-[WebResourceLoad _beginOriginLoad]): Ditto. (_loadSweeper): Ditto.
  • CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): WebFoundation error code constant name changes
  • English.lproj/WebError.strings: Updated strings file. This file was way out of date.
  • Misc.subproj/WebError.h: Updated API. Terminal error concept removed. API simplified. Error constants moved into this file.
  • Misc.subproj/WebError.m: (classInitialize): Changes to adapt to new API. (-[WebError initWithErrorCode:inDomain:failingURL:]): Ditto (-[WebError errorDescription]): Ditto (+[WebError addErrorsWithCodesAndDescriptions:inDomain:]): Ditto
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler continueBeginLoadInBackgroundAfterCreatingHTTPRequest]): WebFoundation error code constant na

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportBadURL:]): WebFoundation error code constant name change
  • WebView.subproj/WebView.m: (+[WebView initialize]): WebError addErrorsFromDictionary changed to addErrorsWithCodesAndDescriptions

WebBrowser:

Modified code to work with new WebError API.

  • DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDictionary:]): Modified for new "no terminal error" WebError API (-[DownloadProgressEntry stop]): WebFoundation error code constant name change
  • FrameProgressEntry.m: (-[FrameProgressEntry stage]): Ditto
  • LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): Ditto (-[LocationChangeHandler specializedMessageForError:]): Ditto (-[LocationChangeHandler displayLocationChangeError:]): Ditto
  • LocationChangeHandler.m: (-[LocationChangeHandler locationChangeDone:forDataSource:]): Modified for new "no terminal error" WebError API
  • Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences updateCookiesViews]): Fixed unitialized variable build breaker I encountered when doing a Deployment build.
  • ResourceProgressEntry.m: (-[ResourceProgressEntry stage]): WebFoundation error code constant name change

Sep 22, 2002:

9:31 PM Changeset in webkit [2119] by darin
  • 3 edits in trunk/WebKit
  • fixed 3057380 -- insertion point shows through elements in front of text fields
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView initialize]): Make WebNSTextView pose as NSTextView. (-[WebNSTextView _web_inHTMLView]): Helper method. (-[WebNSTextView isOpaque]): Override to return NO for all text views that are inside an WebHTMLView, so they don't try to do insertion point caching. (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Use setNeedsDisplayInRect to trigger insertion point drawing outside drawRect instead of drawing right away. (-[WebNSTextView _drawRect:clip:]): Set flag so the above can know when it's inside drawRect and when it's not.
9:27 PM Changeset in webkit [2118] by darin
  • 8 edits in trunk/WebCore

Change code that moves NSViews out of the way to run inside drawRect
after a layout change rather than running at layout time. This makes
sure that views are in the right place when propagating dirty rects.

  • kwq/KWQKHTMLPartImpl.h: Add paint method and _needsToSetWidgetsAside flag.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Set _needsToSetWidgetsAside to false. (KWQKHTMLPartImpl::layout): Set _needsToSetWidgetsAside to true. Don't call moveWidgetsAside any more. (KWQKHTMLPartImpl::paint): Moved the code here from the bridge, but also call moveWidgetsAside if _needsToSetWidgetsAside flag is set.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Call KWQKHTMLPartImpl::paint, which is where I moved this code.

Sep 21, 2002:

11:01 PM Changeset in webkit [2117] by darin
  • 3 edits in trunk/WebCore
  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Remove special case for javascript and about:blank that was leading to a crash.
10:52 PM Changeset in webkit [2116] by darin
  • 4 edits in trunk/WebCore

Fix crashing part of 3057265 -- REGRESSION: Crash loading ​http://www.undetectables.co.uk/

  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Remove special case for javascript and about:blank that was leading to a crash.
4:54 PM Changeset in webkit [2115] by darin
  • 26 edits in trunk

WebCore:

WebCore part of the new approach to AppKit drawing control.
Works better than the previous try. Once we fix anomalies with focus rectangles
and a minor problems with subframes this should work perfectly.

  • kwq/qt/qwidget.h: The paint() method isn't virtual any more. Also remove flushDrawing().
  • kwq/KWQWidget.mm: (QWidget::enableFlushDrawing): Do a flushWindowIfNeeded instead of requiring a separate flushDrawing() call to do a flushWindow. (QWidget::paint): Added. Calls displayRectIgnoringOpacity.
  • kwq/qt/qbutton.h: Remove paint() override.
  • kwq/KWQButton.mm: (QButton::QButton): No need for a subclass any more, so drop KWQNSButton. Also remove paint().
  • kwq/qt/qcombobox.h: Remove paint() override.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): No need for a subclass any more, so drop KWQNSPopUpButton. Also remove paint() method.
  • kwq/qt/qlineedit.h: Remove paint() override.
  • kwq/KWQLineEdit.mm: Remove paint().
  • kwq/KWQFileButton.mm: (KWQFileButton::clicked): Fix typo. Was calling paint instead of clicked on the base class.
  • kwq/KWQNSTextField.h: Remove paint method.
  • kwq/KWQNSTextField.mm: (-[KWQNSTextField display]): Add a display method that does nothing to work around bug 2753974. (-[KWQSecureTextField display]): Ditto.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): Remove call to flushDrawing.

WebKit:

WebKit part of the new approach to AppKit drawing control.
Works better than the previous try. Once we fix anomalies with focus rectangles
and a some remaining problems with subframes this should work perfectly.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView isOpaque]): Return NO for frames other than the main frame. (-[WebHTMLView drawRect:]): Restore the subviews that were set aside.
  • WebView.subproj/WebHTMLViewPrivate.h: Add _isMainFrame. Add savedSubviews and subviewsSetAside.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _isMainFrame]): Added. (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Added. If this is the main frame, get all the dirty rects from the subviews and then set them aside so the AppKit machinery won't draw them. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto. (-[NSView _web_propagateDirtyRectToAncestor]): Added. Propagates dirty rects the same way that AppKit does, but always does it, ignoring the value of isOpaque.

Sep 20, 2002:

6:58 PM Changeset in webkit [2114] by rjw
  • 4 edits in trunk/WebCore

Don't modify selection if no appropriate DOM::Node under
mouse.

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseMoveEvent):
6:44 PM Changeset in webkit [2113] by rjw
  • 4 edits in trunk/WebCore

Assume triple click for selection if click count >= 3,
not == 3, as in OS X.

  • khtml/khtml_part.cpp: (KHTMLPart::khtmlMousePressEvent):
6:33 PM Changeset in webkit [2112] by rjw
  • 5 edits in trunk/WebCore

Fixed crasher in findTextSlave.

  • khtml/rendering/render_text.cpp: (RenderText::findTextSlave):

Added error checks.

  • khtml/khtml_part.cpp: (startAndEndLineNodesIncludingNode):
6:00 PM Changeset in webkit [2111] by rjw
  • 1 edit in trunk/WebCore/khtml/xml/dom_elementimpl.cpp

Removed debugging.

5:58 PM Changeset in webkit [2110] by rjw
  • 12 edits in trunk/WebCore

Made double and triple click selection behave like
like other selection in OS X. That is, selection happens
on mouse down, not mouse up, and can be extended by
further dragging. Triple click followed by dragging extends
the selection a line at a time.

  • khtml/khtml_events.cpp:
  • khtml/khtml_events.h:
  • khtml/khtml_part.cpp: (KHTMLPart::customEvent): (firstSlaveAt): (lastSlaveAt): (startAndEndLineNodesIncludingNode): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseDoubleClickEvent): (KHTMLPart::khtmlMouseMoveEvent):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp:
  • khtml/khtmlview.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttribute):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]):
5:42 PM Changeset in webkit [2109] by darin
  • 8 edits in trunk/WebCore
  • kwq/KWQFileButton.h: Add an icon.
  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Nil out icon. (KWQFileButton::~KWQFileButton): Release icon. (KWQFileButton::setFilename): Get icon with [NSWorkspace iconForFile:]. (KWQFileButton::clicked): Set prompt string to "Choose", and start directory to "~". (KWQFileButton::sizeHint): Pad more for icon width. (KWQFileButton::frameGeometry): Ditto. (KWQFileButton::setFrameGeometry): Ditto. (KWQFileButton::paint): Draw icon. Draw "no file selected" if no filename.
  • kwq/KWQKFileItem.mm: Our "nonimplementation" is good enough. Stop complaining.
  • kwq/KWQKnetaccess.mm: Ditto. Also just extract path when asked to download.
4:45 PM Changeset in webkit [2108] by darin
  • 6 edits
    2 adds
    1 delete in trunk/WebCore

Some first steps toward implementing input=file.

  • khtml/rendering/render_form.cpp: (RenderFileButton::RenderFileButton): Create a KWQFileButton as the widget. (RenderFileButton::calcMinMaxWidth): Use sizeHint(). (RenderFileButton::updateFromElement): Call setFilename(). (RenderFileButton::select): Don't try to selectAll() on m_edit.
  • kwq/KWQFileButton.h: Added.
  • kwq/KWQFileButton.mm: Added.
  • kwq/qt/qhbox.h: Emptied.
  • kwq/KWQHBox.mm: Removed.
  • WebCore.pbproj/project.pbxproj: Removed KWQHBox.mm. Added KWQFileButton.
2:26 PM Changeset in webkit [2107] by darin
  • 4 edits in trunk/WebCore
  • kwq/mac-encodings.txt: When people say ShiftJIS, they really mean DOSJapanese. So do what they mean, not what they say.
12:23 PM Changeset in webkit [2106] by darin
  • 5 edits in trunk/WebKit
  • History.subproj/WebHistory.m: (-[WebHistory addEntryForURLString:]): Use _web_URLWithString so we can handle unusual characters.
  • WebView.subproj/WebDefaultPolicyHandler.m: Remove stray semicolon.
10:13 AM Changeset in webkit [2105] by darin
  • 5 edits in trunk/WebCore
  • fixed 3055339 -- repro crash in RenderPartObject::updateWidget()
  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Only create a new part if we have no old part.
  • kwq/KWQtextstream.mm: Remove some of the "not implemented" logging. Once we have logged that the stream is not created correctly, there's no need to continue logging each time something is written out to the non-stream.
9:58 AM Changeset in webkit [2104] by cblu
  • 6 edits in trunk/WebKit

Fixed wasteful memory usage in the WebIconDatabase:

  • Rather than have multiple NSImages with multiple representations at multiple sizes, have 1 NSImage per size
  • Added API to allow client to control memory caching
  • Misc.subproj/WebIconDatabase.h:
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:]): call iconForSiteURL:withSize:cache:YES (-[WebIconDatabase iconForSiteURL:withSize:cache:]): new, was iconForSiteURL:withSize: (-[WebIconDatabase defaultIconWithSize:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _updateFileDatabase]): write the largest icon to disk (-[WebIconDatabase _hasIconForSiteURL:]): cleaned-up (-[WebIconDatabase _iconsForIconURL:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _iconForFileURL:withSize:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _builtInIconsForHost:]): call _iconFromDictionary:forSize:cache: (-[WebIconDatabase _setIcon:forIconURL:]): _iconsBySplittingRepresentationsOfIcon: (-[WebIconDatabase _releaseIconForIconURL:]): icons at different sizes are now stored in dictionaries (-[WebIconDatabase _largestIconFromDictionary:]): new, scans the icon dictionary (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): creates the icon dictionary (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): returns icon from dict, resizes if necessary (-[WebIconDatabase _iconByScalingIcon:toSize:]): tweak
  • Misc.subproj/WebIconDatabasePrivate.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): don't call _iconsForIconURL: because it doesn't exist.
Note: See TracTimeline for information about the timeline view.