Timeline



Sep 26, 2002:

8:25 PM Changeset in webkit [2181] by darin
  • 4 edits in trunk/WebCore
  • fixed 2953256 -- JavaScript window.moveTo() and window.moveBy() methods do not work
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry): Fix calculation. It was returning the bottom left coordinate instead of the top left.
8:06 PM Changeset in webkit [2180] by darin
  • 12 edits in trunk/WebCore
  • fixed 3060459 -- REGRESSION: crash leaving page that sets cookie in JavaScript unload handler
  • khtml/khtml_part.cpp: (KHTMLPart::begin): Call updatePolicyBaseURL to set the "policy base URL" on the documents so the cookie can be based on the URL of the main document.
  • khtml/dom/html_document.h: Add setPolicyBaseURL.
  • khtml/dom/html_document.cpp: (HTMLDocument::setPolicyBaseURL): Call the impl.
  • khtml/html/html_documentimpl.h: Add policyBaseURL, setPolicyBaseURL.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::setCookie): Pass the base URL that's stored here instead of getting at the part through the view, since the view will be 0 during the unload event.
  • kwq/KWQKHTMLPartImpl.h: Add updatePolicyBaseURL and setPolicyBaseURL.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::updatePolicyBaseURL): Set the base URL based on the URL if this is the topmost part, based on the parent's policy base URL if this is not the topmost part. (KWQKHTMLPartImpl::setPolicyBaseURL): Change the policy base URL for this part and all the subparts.
5:45 PM Changeset in webkit [2179] by darin
  • 18 edits in trunk

Tools:

  • HotSpotFinder/HotSpotFinder.pbproj/project.pbxproj: File encodings.

WebCore:

  • kwq/WebCoreBridge.h: Use NSString for encoding name, not CFStringEncoding.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge addData:withOverrideEncoding:]): Ditto.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Use NSString for encoding.
  • WebView.subproj/WebController.h: Update names to use separate boolean for user agent and strings for text encodings instead of CFStringEncoding.
  • WebView.subproj/WebController.m: (-[WebController setCustomUserAgent:]): Name change. (-[WebController resetUserAgent]): Added. (-[WebController hasCustomUserAgent]): Added. (-[WebController customUserAgent]): Name change. (-[WebController setCustomTextEncodingName:]): Take NSString. (-[WebController resetTextEncoding]): Update for NSString. (-[WebController _mainFrameOverrideEncoding]): Ditto. (-[WebController hasCustomTextEncoding]): Ditto. (-[WebController customTextEncodingName]): Return NSString.
  • WebView.subproj/WebDataSourcePrivate.h: Use NSString instead of CFStringEncoding.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): No need to init. (-[WebDataSource _setContentType:]): Copy, don't retain. (-[WebDataSource _setEncoding:]): Copy, don't retain. (-[WebDataSource _setOverrideEncoding:]): Use NSString. (-[WebDataSource _overrideEncoding]): Use NSString.
  • WebView.subproj/WebFramePrivate.h: Use NSString.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): Use NSString.
  • WebView.subproj/WebPreferences.h: Use NSString instead of CFStringEncoding.
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Use NSString. (-[WebPreferences defaultTextEncodingName]): Use NSString. (-[WebPreferences setDefaultTextEncodingName:]): Use NSString.

WebBrowser:

  • AppController.m: (-[AppController updateTextEncodingMenu]): Convert to CFStringEncoding.
  • BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Convert to CFStringEncoding. (-[BrowserWindowController changeTextEncoding:]): Convert to NSString.
  • Debug/DebugUtilities.m: (-[BrowserDocument setUserAgent:]): Update for API change. (-[BrowserDocument validate_setUserAgent:]): Ditto. (-[BrowserDocument resetUserAgent:]): Ditto. (-[BrowserDocument validate_resetUserAgent:]): Ditto.
  • Preferences.subproj/TextPreferences.m: (-[TextPreferences updateDefaultCharacterSetPopup]): Convert to CFStringEncoding. (-[TextPreferences takeDefaultCharacterSetFrom:]): Convert to NSString.
3:37 PM Changeset in webkit [2178] by cblu
  • 3 edits in trunk/WebKit

WebKit:

Made WebTextView super-private.

  • WebKit.pbproj/project.pbxproj:

WebBrowser:

  • Made the view source window
    • larger
    • use Monaco, 10 font
    • respond to makeTextLarger and makeTextSmaller
    • use saveDocumentAs

Fixed: 3053366 - source window should have file proxy after save

  • BrowserDocument.h:
  • BrowserDocument.m:
  • English.lproj/HTMLSource.nib: made window larger, use WebSearchableTextView
  • HTMLSourceController.h:
  • HTMLSourceController.m: (-[HTMLSourceController windowDidLoad]): set the text multiplier (-[HTMLSourceController setTextSizeMultiplier:]): new (-[HTMLSourceController textSizeMultiplier]): new
  • HTMLSourceDocument.h:
  • HTMLSourceDocument.m: (-[HTMLSourceDocument dataRepresentationOfType:]): new saved flag (-[HTMLSourceDocument saveDocumentTo:]): call saveDocumentAs (-[HTMLSourceDocument displayName]): perform hacks to get window title and saved filename correct (-[HTMLSourceDocument controller]): new (-[HTMLSourceDocument browserDocumentLoadingFinished:]): don't update after save (-[HTMLSourceDocument canMakeTextLarger]): new (-[HTMLSourceDocument canMakeTextSmaller]): new (-[HTMLSourceDocument makeTextLarger:]): new (-[HTMLSourceDocument makeTextSmaller:]): new (-[HTMLSourceDocument validateUserInterfaceItem:]): new
3:11 PM Changeset in webkit [2177] by rjw
  • 3 edits in trunk/WebKit

i Use a rectangle with rounded corners for dragged label.

Put a subtle shadow behind text in label.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):
12:07 PM Changeset in webkit [2176] by cblu
  • 15 edits
    2 adds in trunk

WebCore:

Added WebCoreElementImageLocationKey to the element dictionary.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

WebKit:

  • When dragging an image, use the image itself for the drag image
  • Support promised file and image data drag types for dragged images.
  • Misc.subproj/WebNSImageExtras.h: Added.
  • Misc.subproj/WebNSImageExtras.m: Added. (-[NSImage _web_scaleToMaxSize:]): new, scales an image is greater than max (-[NSImage _web_dissolveToFraction:]): new, dissolves image in place
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.h: Added WebElementImageLocationKey to the element dictionary
  • WebView.subproj/WebController.m: ditto
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): subclassed for only for image drags (-[WebHTMLView mouseDragged:]): use the promised file api again. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): use the retained element dictionary instead of the dragged URL which I deleted.
  • WebView.subproj/WebHTMLViewPrivate.h:
10:20 AM Changeset in webkit [2175]
  • 3 copies in tags/Alexander-25

This commit was manufactured by cvs2svn to create tag 'Alexander-25'.

10:20 AM Changeset in webkit [2174] by sheridan
  • 8 edits in trunk

Alex-25 versions + markers

8:20 AM Changeset in webkit [2173] by darin
  • 5 edits in trunk/JavaScriptCore

Fix the infinity problem Dave worked around. We didn't have the
configuration flags set right to make infinity work. Setting those
properly made everything work without changes to min and max.

  • kjs/config.h: Define HAVE_FUNC_ISINF, HAVE_STRING_H, and also WORDS_BIGENDIAN (if on ppc).
  • kjs/math_object.cpp: (MathFuncImp::call): Roll out min and max changes from yesterday.

Sep 25, 2002:

7:15 PM Changeset in webkit [2172] by rjw
  • 9 edits in trunk/WebKit

API tweaks.

  • Misc.subproj/WebKit.h: Added headers.
  • Misc.subproj/WebKitErrors.h: Removed #defines.
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): (-[WebDataSource _loadIcon]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): Removed isMainDocument.

Moved errors string #defines here.

  • WebView.subproj/WebView.m:

Updated to reflect API tweaks.

  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
5:57 PM Changeset in webkit [2171] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3060773 -- Wrong title proposed when image link dropped on favorites bar
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Claim the pasteboard (via declareTypes:) before putting data on it.
5:51 PM Changeset in webkit [2170] by rjw
  • 24 edits in trunk/WebKit

API and documentation tweaks.

WebDocumentDragSettings: canDrag -> acceptsDrag
WebDataSource: removed originalURL
WebStandardPanels: use -> uses

  • History.subproj/WebBackForwardList.h:
  • Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]):
  • Panels.subproj/WebStandardPanels.h:
  • Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels setUsesStandardAuthenticationPanel:]): (-[WebStandardPanels usesStandardAuthenticationPanel]):
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView frameStateChanged:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient cancel]):
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): (-[WebFrame startLoading]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _setState:]): (-[WebFrame _goToItem:withFrameLoadType:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView setAcceptsDrags:]): (-[WebHTMLView acceptsDrags]): (-[WebHTMLView setAcceptsDrops:]): (-[WebHTMLView acceptsDrops]):
  • WebView.subproj/WebImageView.m: (-[WebImageView setAcceptsDrags:]): (-[WebImageView acceptsDrags]): (-[WebImageView setAcceptsDrops:]): (-[WebImageView acceptsDrops]):
  • WebView.subproj/WebLoadProgress.h:
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]):
  • WebView.subproj/WebView.h:

Updated to reflect API tweaks.

  • AppController.m: (-[AppController awakeFromNib]):
  • DownloadProgressEntry.m: (-[DownloadProgressEntry stop]):
  • LocationChangeHandler.m: (-[LocationChangeHandler locationChangeStartedForDataSource:]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]):
3:47 PM Changeset in webkit [2169] by hyatt
  • 5 edits in trunk/WebCore

Implement scrollX and scrollY on the window object. This
gets brainjar closer to reality. :)

  • khtml/ecma/kjs_window.cpp: (Window::get):
  • khtml/ecma/kjs_window.h:
3:46 PM Changeset in webkit [2168] by hyatt
  • 4 edits in trunk/JavaScriptCore

Fix the impls of min/max to not use +inf/-inf when you have
arguments. Technically there's still a bug here for the no
argument case, probably caused by a screwup when +inf/-inf are
converted to doubles.

  • kjs/math_object.cpp: (MathFuncImp::call):
1:25 PM Changeset in webkit [2167] by darin
  • 4 edits in trunk/JavaScriptCore
  • fixed 3057964 -- JS problem performing MD5 script embedded in yahoo login page
  • kjs/simple_number.h: Fix incorrect check for sign bit that was munging numbers in the range 0x10000000 to 0x1FFFFFFF.
11:23 AM Changeset in webkit [2166] by kocienda
  • 9 edits in trunk/WebKit

WebFoundation:

Changes to move the WebResourceHandle API closer to the
specified design. This includes:

  • Removed loadInBackground method from the public interface.
  • Start asynchronous loading in WebResourceHandle init method.
  • Remove loadInForeground: from WebResourceHandle interface.
  • Add nice comments to WebResourceHandle header file.
  • Move WebResourceHandle callback deferral methods to SPI header file.
  • Some cleanups in synchronous loading.
  • Change name of WebResourceHandle cancelLoadInBackground method to cancel.
  • Some changes to the C glue (why do I even pretend that I am keeping this glue code working?)
  • CacheLoader.subproj/IFURLHandleC.h:
  • CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleCancelLoadInBackground) (IFURLHandleDidRedirectToURL)
  • CacheLoader.subproj/WebResourceHandle.h:
  • CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle canInitWithRequest:]) (-[WebResourceHandle initWithRequest:delegate:]) (-[WebResourceHandle cancel]) (-[WebResourceHandle loadInForeground:]) (-[WebResourceHandle loadInForeground])
  • CacheLoader.subproj/WebResourceHandleInternal.h:
  • CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _loadInBackground]) (-[WebResourceHandle _postCallback:]) (-[WebResourceHandle _sendCallbacks])
  • CacheLoader.subproj/WebResourceHandlePrivate.h:
  • CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _setDefersCallbacks:]) (-[WebResourceHandle _defersCallbacks])
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad cancel])
  • CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate run:]) (-[WebResourceHandleSynchronousDelegate finished])
  • WebFoundation.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Changes to move the WebResourceHandle API closer to the
specified design. This includes:

  • Removed loadInBackground method from the public interface.
  • Start asynchronous loading in WebResourceHandle init method. This required some code reorganization in callers.
  • Remove loadInForeground: from WebResourceHandle interface.
  • Move WebResourceHandle callback deferral methods to SPI header file.
  • Change name of WebResourceHandle cancelLoadInBackground method to cancel.
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]) (-[WebIconLoader stopLoading])
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad]) (-[WebNetscapePluginStream cancel])
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]) (-[WebSubresourceClient cancel])
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]) (-[WebDataSource _addSubresourceClient:]) (-[WebDataSource _stopLoading]) (-[WebDataSource _defersCallbacksChanged])
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveData:])
11:01 AM Changeset in webkit [2165] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3050665 - REGRESSION: mp3 audio loads and plays, but no progress or play control is visible

  • Plugins.subproj/WebPluginView.h:
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setNeedsLayout:]): (-[WebNetscapePluginView layout]): (-[WebNetscapePluginView drawRect:]):
9:03 AM Changeset in webkit [2164] by darin
  • 4 edits in trunk/WebCore

Fix error with the color "indigo".

  • kwq/KWQColor.mm: (getNamedColors): There were some spaces in our color table so we wouldn't handle indianred or indigo.
8:50 AM Changeset in webkit [2163] by darin
  • 5 edits in trunk/WebKit

Make the "set aside subviews" logic stronger so it can handle a display
while inside drawRect. But note, this recursive display is most likely
the cause of the redrawing problems we have while resizing, like bug 2969367.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Restore views and then set them aside again, but don't leave the "views set aside" boolean set.
  • WebView.subproj/WebHTMLViewPrivate.h: Add private _setAsideSubviews and _restoreSubviews methods.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _setAsideSubviews]): Added. (-[WebHTMLView _restoreSubviews]): Added. (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Use the new _setAsideSubviews and _restoreSubviews methods. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto.
8:32 AM Changeset in webkit [2162] by kocienda
  • 4 edits in trunk/WebKit

WebFoundation:

Removed this method from WebResourceHandle:

+(BOOL)canInitWithURL:(NSURL *)theURL;

replaced with:

+(BOOL)canInitWithRequest:(WebResourceRequest *)request;

Also added a convenience method to WebResourceRequest that
allocates, inits, and returns an autoreleased instance.

  • CacheLoader.subproj/WebResourceHandle.h:
  • CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle canInitWithRequest:])
  • CacheLoader.subproj/WebResourceRequest.h:
  • CacheLoader.subproj/WebResourceRequest.m: (+[WebResourceRequest requestWithURL:])

WebKit:

Removed this method from WebResourceHandle:

+(BOOL)canInitWithURL:(NSURL *)theURL;

replaced with:

+(BOOL)canInitWithRequest:(WebResourceRequest *)request;

Callers have been updated to reflect the change.

  • WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate defaultURLPolicyForURL:])
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowURL:])
7:18 AM Changeset in webkit [2161] by kocienda
  • 8 edits in trunk/WebKit

WebFoundation:

More moves to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

-(void)handle:(WebResourceHandle *)handle didReceiveData:(NSData *)data;

  • CacheLoader.subproj/WebResourceCallbackClient.m: (-[WebResourceCallbackClient handle:didReceiveData:])
  • CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientDataDidBecomeAvailable])
  • CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate handle:didReceiveData:])

WebKit:

More moves to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

-(void)handle:(WebResourceHandle *)handle didReceiveData:(NSData *)data;

  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader handle:didReceiveData:])
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:didReceiveData:])
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveData:])
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveData:])
7:02 AM Changeset in webkit [2160] by kocienda
  • 8 edits in trunk/WebKit

WebFoundation:

Moving to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

  • (void)handle:(WebResourceHandle *)handle didFailLoadingWithError:(WebError *)result;
  • CacheLoader.subproj/WebResourceCallbackClient.m:
  • CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientDidFailLoading])
  • CacheLoader.subproj/WebResourceSynchronousClient.m:

WebKit:

Moving to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

  • (void)handle:(WebResourceHandle *)handle didFailLoadingWithError:(WebError *)result;
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader handle:didFailLoadingWithError:])
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:didFailLoadingWithError:])
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didFailLoadingWithError:])
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didFailLoadingWithError:])
6:25 AM Changeset in webkit [2159] by kocienda
  • 13 edits in trunk/WebKit

WebFoundation:

Begin change from WebResourceClient to WebResourceHandleDelegate.
In this step, I have just changed the name of the protocol; the
protocol interface is the same.

As part of this change, WebResourceSynchronousClient becomes
WebResourceHandleSynchronousDelegate. Also, the init interface
for WebResourceHandle assumes the form specified in the new API
specification:

-(id)initWithRequest:(WebResourceRequest *)request delegate:(id <WebResourceHandleDelegate>)delegate;

I also made cosmetic changes to variable names and such.

Note that I am removing the WebResourceClient.h file, but I
copied the ,v file in the repository so that the history for WebResourceClient.h
is preserved in WebResourceHandleDelegate.h.

  • CacheLoader.subproj/WebResourceCallbackClient.h:
  • CacheLoader.subproj/WebResourceClient.h: Removed.
  • CacheLoader.subproj/WebResourceHandle.h:
  • CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadInForeground:]) (-[WebResourceHandle initWithRequest:delegate:])
  • CacheLoader.subproj/WebResourceHandleInternal.h:
  • CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _notifyClientDidRedirectToURL]) (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]) (-[WebResourceHandle _notifyClientDidFailLoading]) (-[WebResourceHandle _notifyClientDidFinishLoading])
  • CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _userAgentForURL:])
  • CacheLoader.subproj/WebResourceResponse.h:
  • CacheLoader.subproj/WebResourceSynchronousClient.h:
  • CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate initWithMonitor:realDelegate:]) (-[WebResourceHandleSynchronousDelegate dealloc]) (-[WebResourceHandleSynchronousDelegate handleWillUseUserAgent:forURL:]) (-[WebResourceHandleSynchronousDelegate handleDidFinishLoading:]) (-[WebResourceHandleSynchronousDelegate handleDidReceiveData:data:]) (-[WebResourceHandleSynchronousDelegate handleDidRedirect:toURL:])
  • Misc.subproj/WebFoundation.h:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Begin change from WebResourceClient to WebResourceHandleDelegate.
In this step, I have just changed the name of the protocol; the
protocol interface is the same.

I made other cosmetic changes to variable names and such.

  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad])
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:])
  • WebCoreSupport.subproj/WebSubresourceClient.h:
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:])
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading])
  • WebView.subproj/WebMainResourceClient.h:
1:22 AM Changeset in webkit [2158] by mjs
  • 17 edits in trunk

Tests:

  • CookieManager/wkcookiemanager-test.m: (main): Adjust for API change.

WebFoundation:

  • fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"
  • CacheLoader.subproj/WebResourceRequest.h:
  • CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest cookiePolicyBaseURL]): (-[WebResourceRequest setCookiePolicyBaseURL:]): (-[WebResourceRequest copyWithZone:]):
  • CookieManager.subproj/IFCookieManagerC.m: (IFCookieManagerSetCookiesFromResponseHeaders):
  • CookieManager.subproj/WebCookieConstants.h:
  • CookieManager.subproj/WebCookieManager.h:
  • CookieManager.subproj/WebCookieManager.m: (-[WebCookieManager _readAcceptCookiesPreference]): (-[WebCookieManager _setCookies:forURL:policyBaseURL:]): (-[WebCookieManager setCookie:]): (-[WebCookieManager setCookiesFromResponseHeaders:forURL:policyBaseURL:]): (-[WebCookieManager setAcceptPolicy:]):
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_domainFromHost]):
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler setResponseHeadersUsingHTTPResponse:andCall:context:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _parseHeadersFromData:]):

WebCore:

  • fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::setCookie):
  • kwq/KWQKCookieJar.h:
  • kwq/KWQKCookieJar.mm: (KWQKCookieJar::setCookie):
  • kwq/WebCoreCookieAdapter.h:
  • kwq/WebCoreCookieAdapter.m: (-[WebCoreCookieAdapter setCookies:forURL:policyBaseURL:]):

WebKit:

  • fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"
  • WebCoreSupport.subproj/WebCookieAdapter.h:
  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient handleDidRedirect:toURL:]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidRedirect:toURL:]):

WebBrowser:

  • fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"
  • Preferences.subproj/English.lproj/SecurityPreferences.nib:
  • Preferences.subproj/SecurityPreferences.h:
  • Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):

Sep 24, 2002:

6:42 PM Changeset in webkit [2157] by rjw
  • 11 edits in trunk/WebKit

More documentation tweaks.

  • History.subproj/WebHistory.h:
  • History.subproj/WebHistoryItem.h:
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebResourceProgressDelegate.h:
6:20 PM Changeset in webkit [2156] by darin
  • 8 edits
    2 adds in trunk/WebKit
  • fixed 3059513 -- REGRESSION: Scrolling to fragment doesn't work

Turns out it was better to just put the extra smarts into the clip view
that we are already creating. Making WebHTMLView be a second clip view
was silly and broke things.

  • WebView.subproj/WebView.m: (-[WebView initWithFrame:]): Create a WebClipView and use it as the content view rather than the NSClipView created by default.
  • WebKit.pbproj/project.pbxproj: Added WebClipView.
  • WebView.subproj/WebClipView.h: Added.
  • WebView.subproj/WebClipView.m: Added.
  • WebView.subproj/WebHTMLView.h: Don't be a subclass of NSClipView any more.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Call setAdditionalClip and resetAdditionalClip on the clip view.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove inDrawRect and drawRect.
  • WebView.subproj/WebHTMLViewPrivate.m: Remove visibleRect override. This is now in WebClipView.
5:31 PM Changeset in webkit [2155] by darin
  • 7 edits in trunk/WebCore

Tests:

  • harness.c: (runtest): Turn off leak checking. It's broken.
  • qt/qdate-test.chk: Update test for changes to QDate.
  • qt/qdate-test.cpp: (main): Ditto.
  • qt/qtime-test.chk: Update test for changes to QTime.
  • qt/qtime-test.cpp: (main): Ditto.

WebCore:

  • fixed 3057928 -- lstat private/etc/localtime repeatedly reported by fs_usage when mouse is moved
  • WebCore-tests.exp: Remove now-unneeded external entry points for QTime, QDate, QDateTime.
  • kwq/qt/qdatetime.h:
  • kwq/KWQDateTime.mm: Redid QDateTime using CoreFoundation instead of time/localtime. This avoids constantly hitting the disk when getting the current time to stuff into an event.
5:30 PM Changeset in webkit [2154] by cblu
  • 6 edits in trunk/WebKit

More documentation changes.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.h:
  • WebView.subproj/WebDocument.h:
4:25 PM Changeset in webkit [2153] by hyatt
  • 4 edits in trunk/WebCore

Make sure we dispatch both a capturing and a bubbling event
to target nodes. DOM lvl 2 event compliance.

  • ChangeLog:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent):
4:22 PM Changeset in webkit [2152] by rjw
  • 4 edits in trunk/WebKit

Added FIXME not about unresolved issue with CFStringEncoding/NSStringEncoding.

  • WebView.subproj/WebController.h:
4:20 PM Changeset in webkit [2151] by rjw
  • 11 edits in trunk

i Fixed 3055078. Ensure file: URLs have before path.

  • kwq/KWQKURL.mm: (KURL::parse):

Documentation for WebDataSource and WebFrame.

  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource frameExists:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource addFrame:]):
  • WebView.subproj/WebFrame.h:
3:34 PM Changeset in webkit [2150] by hyatt
  • 4 edits in trunk/WebCore

Better fix. Clears the boolean when CLASS has no value.
This will keep the style system from thinking you have
a class when you don't.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):
3:21 PM Changeset in webkit [2149] by hyatt
  • 4 edits in trunk/WebCore

Fix updating of the document's notion of the focused node
to happen on mouse down rather than click. This matches
the behavior of all other browsers (IE, Gecko, etc.).

This fixes the drawing of the outline on the brainjar.com
DHTML menus.

  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent):
3:20 PM Changeset in webkit [2148] by darin
  • 3 edits in trunk/WebKit
  • fixed 3059266 -- REGRESSION: clicking in web view when location field is focused does not focus web view
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView needsPanelToBecomeKey]): Must override this to return YES, because NSClipView makes it return NO even though we accept the first responder.
2:45 PM Changeset in webkit [2147] by hyatt
  • 4 edits in trunk/WebCore

Make sure that changes to the CLASS attribute mark the
element as changed (as if a CSS property were added or
removed).

This makes the brainjar.com rollovers work much better.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):
2:26 PM Changeset in webkit [2146] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3056158 -- REGRESSION: Page up/down should scroll one whole contentView minus at least one readable line of text

This was broken a while back when the keyboard scrolling code
migrated into WebKit.

  • WebView.subproj/WebViewPrivate.m: (-[WebView _verticalKeyboardScrollAmount]), (-[WebView _horizontalKeyboardScrollAmount]): New private methods, return one arrow key's worth of scrolling. (-[WebView _scrollLineVertically:]), (-[WebView _scrollLineHorizontally:]): Now use the broken-out methods. (-[WebView _pageVertically:]), (-[WebView _pageHorizontally:]): overlap by one arrow key's worth of scrolling instead of the teensy-weensy one click's worth.
2:02 PM Changeset in webkit [2145] by cblu
  • 3 edits in trunk/WebKit

Documentation for WebHTMLView

  • WebView.subproj/WebHTMLView.h:
1:05 PM Changeset in webkit [2144] by rjw
  • 16 edits in trunk/WebKit

Documentation changes. Removal of imports from
some headers required modification of .m.

  • Plugins.subproj/WebNullPluginView.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m:
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate defaultURLPolicyForURL:]): (-[WebDefaultPolicyDelegate URLPolicyForURL:inFrame:]):
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebHTMLViewPrivate.m:

Documentation changes. Removal of imports from
some headers required modification of .m.

  • BrowserDocument.m:
  • BrowserWebController.m: (-[BrowserWebController URLPolicyForURL:inFrame:]):
  • DownloadMonitor.m:
  • DownloadProgressEntry.m:
11:37 AM Changeset in webkit [2143] by cblu
  • 21 edits in trunk

WebCore:

Renamed element info keys to WebElement* instead of WebContextMenuElement*

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

WebKit:

Renamed element info keys to WebElement* instead of WebContextMenuElement*
Added WebKit API documentation

  • Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin load]): clean-up
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m:
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]): (-[WebDefaultContextMenuDelegate downloadURL:]): (-[WebDefaultContextMenuDelegate openLinkInNewWindow:]): (-[WebDefaultContextMenuDelegate downloadLinkToDisk:]): (-[WebDefaultContextMenuDelegate copyLinkToClipboard:]): (-[WebDefaultContextMenuDelegate openImageInNewWindow:]): (-[WebDefaultContextMenuDelegate downloadImageToDisk:]): (-[WebDefaultContextMenuDelegate copyImageToClipboard:]): (-[WebDefaultContextMenuDelegate openFrameInNewWindow:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):

WebBrowser:

Renamed element info keys to WebElement* instead of WebContextMenuElement*

  • BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierMask:]):
  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler addLinkToBookmarks:]): (-[ContextMenuHandler viewSource:]): (-[ContextMenuHandler savePageAs:]): (-[ContextMenuHandler openWithiTunes:]):
11:29 AM Changeset in webkit [2142] by darin
  • 8 edits in trunk/WebKit

Cleaned up some loose ends from adding setNeedsLayout to the WebDocumentView
protocol. Was causing exceptions.

  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setNeedsLayout:]):
  • WebView.subproj/WebTextView.m: (-[WebTextView setNeedsLayout:]): Added missing stubs.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsReapplyStyles]): Removed unneeded cast.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]): Remove an unneeded cast and call to isDocumentHTML.
  • WebView.subproj/WebHTMLView.h: No need to re-declare setNeedsLayout.
  • WebView.subproj/WebView.m: (-[WebView setFrame:]): Get rid of unneeded check of isDocumentHTML.
10:48 AM Changeset in webkit [2141] by darin
  • 4 edits in trunk/WebCore

Apparently the strings at this site were just the right length to expose a bug
in our QString implementation, one that I probably introduced when fixing 3032072.
One nice thing about this is that getting this correct could also result in a
little bit of a speedup, as the internal buffer is used more.

  • kwq/KWQString.mm: (QStringData::makeAscii): Set _maxAscii to QS_INTERNAL_BUFFER_CHARS when using the internal buffer instead of leaving it uninitialized. (QStringData::makeUnicode): Same for _maxUnicode.
10:24 AM Changeset in webkit [2140] by darin
  • 10 edits in trunk/WebCore

Remove the focus border hack, which was no longer doing us any good.

  • kwq/KWQNSTextField.h: Don't define FOCUS_BORDER_SIZE.
  • kwq/KWQNSTextField.mm: Remove KWQTextFieldCell. (-[KWQNSTextField updateSecureFieldFrame]): Don't inset by FOCUS_BORDER_SIZE.
  • kwq/qt/qlineedit.h: Don't override frameGeometry and setFrameGeometry any more.
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Don't subtract the focus border size.
10:17 AM Changeset in webkit [2139] by darin
  • 6 edits in trunk/WebKit
  • fixed 3057383 -- focus rectangles are being drawn multiple times
  • fixed 3051025 -- focus ring on password field gets darker and darker

To make focus rings clip too, we have to do more than just set the clip.
We also have to set the visible rectangle to make clipping happen, and we
need to be a subclass of NSClipView so that the focus ring drawing code will
consult us rather than one of our superviews.

  • WebView.subproj/WebHTMLView.h: Be a subclass of NSClipView.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Set a inDrawRect flag, and a drawRect rectangle. This tells us to clip to this rectangle. what we need to clip to.
  • WebView.subproj/WebHTMLViewPrivate.h: Added inDrawRect and drawRect.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView visibleRect]): Clip the visible rect based on the drawRect while inDrawRect is set.
10:13 AM Changeset in webkit [2138] by darin
  • 4 edits in trunk/WebCore
  • kwq/mac-encodings.txt: Remove constant for Japanese auto-detect.
9:53 AM Changeset in webkit [2137] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQFileButton.mm: (KWQFileButton::paint): Fix typo.
9:22 AM Changeset in webkit [2136] by darin
  • 5 edits in trunk/WebCore

Some improvements to the file button, including displaying the file without the
extension if it's set that way by the user, and using the system font rather
than hard-coding "Lucida Grande".

  • kwq/KWQFileButton.h: Add _label field.
  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Set up label. (KWQFileButton::~KWQFileButton): Release label. (KWQFileButton::setFilename): Use NSFileManager componentsToDisplayForPath to figure out the appropriate label. (KWQFileButton::paint): Clip to passed-in rect, get font using systemFontOfSize, and use NSString drawing rather than our own.

Sep 23, 2002:

9:28 PM Changeset in webkit [2135] by cblu
  • 7 edits in trunk/WebKit

WebKit:

Factored URL pasteboard initialization to 1 place.
Fixed: 3048924 - regression: drag & drop broken for initial empty page
Fixed: 3045997 - Dragging a link from one Alex window to another one doesn't work

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): new
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate copyLinkToClipboard:]): call -[NSPasteboard _web_writeURL:andTitle:withOwner:]
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): call -[NSPasteboard _web_writeURL:andTitle:withOwner:]
  • WebView.subproj/WebView.m: (-[WebView draggingEntered:]): handle nil cases

WebBrowser:

  • main.m: (main): Fixed comment
6:56 PM Changeset in webkit [2134] by mjs
  • 6 edits in trunk/WebKit

Added documentation for these two delegate protocols.

  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebResourceProgressDelegate.h:
5:16 PM Changeset in webkit [2133] by rjw
  • 3 edits in trunk/WebKit

Made WebIconLoader and WebIconDatabase SPI.

  • WebKit.pbproj/project.pbxproj:
5:13 PM Changeset in webkit [2132] by rjw
  • 2 edits in trunk/WebKit/WebView.subproj

Put back changes I blew away.

5:02 PM Changeset in webkit [2131] by rjw
  • 42 edits
    2 adds
    12 deletes in trunk/WebKit

WebContextMenuHandler becomes WebContextMenuDelegate
WebControllerPolicyHandler becomes WebControllerPolicyDelegate
WebLocationChangeHandler becomes WebLocationChangeDelegate
WebResourceProgressHandler becomes WebResourceProgressDelegate
WebWindowContext becomes WebWindowOperationsDelegate

  • Misc.subproj/WebDownloadHandler.m:
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView drawRect:]):
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebNetscapePluginView status:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge window]): (-[WebBridge setStatusText:]): (-[WebBridge reportClientRedirectTo:delay:fireDate:]): (-[WebBridge reportClientRedirectCancelled]):
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebContextMenuHandler.h: Removed.
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setWindowOperationsDelegate:]): (-[WebController windowOperationsDelegate]): (-[WebController setResourceProgressDelegate:]): (-[WebController resourceProgressDelegate]): (-[WebController setDownloadProgressDelegate:]): (-[WebController downloadProgressDelegate]): (-[WebController setContextMenuDelegate:]): (-[WebController contextMenuDelegate]): (-[WebController setPolicyDelegate:]): (-[WebController policyDelegate]): (-[WebController setLocationChangeDelegate:]): (-[WebController locationChangeDelegate]):
  • WebView.subproj/WebControllerPolicyDelegate.m: Added. (-[WebPolicyPrivate dealloc]): (-[WebPolicy _setPolicyAction:]): (-[WebPolicy policyAction]): (-[WebPolicy path]): (-[WebPolicy URL]): (-[WebPolicy _setPath:]): (-[WebPolicy dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
  • WebView.subproj/WebControllerPolicyDelegatePrivate.h:
  • WebView.subproj/WebControllerPolicyHandler.h: Removed.
  • WebView.subproj/WebControllerPolicyHandler.m: Removed.
  • WebView.subproj/WebControllerPolicyHandlerPrivate.h: Removed.
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): (-[WebControllerPrivate dealloc]): (-[WebController _defaultContextMenuDelegate]): (-[WebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): (-[WebController _mainReceivedError:forResourceHandle:partialProgress:fromDataSource:]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setURL:]): (-[WebDataSource _loadIcon]):
  • WebView.subproj/WebDefaultContextMenuDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]): (-[WebDefaultContextMenuDelegate downloadURL:]):
  • WebView.subproj/WebDefaultContextMenuHandler.h: Removed.
  • WebView.subproj/WebDefaultContextMenuHandler.m: Removed.
  • WebView.subproj/WebDefaultPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebDefaultPolicyHandler.h: Removed.
  • WebView.subproj/WebDefaultPolicyHandler.m: Removed.
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): (-[WebFrame frameNamed:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]): (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]): (-[WebFrame handleUnimplementablePolicy:errorCode:forURL:]): (-[WebFrame _shouldShowURL:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView setNeedsLayout:]):
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebLocationChangeDelegate.m:
  • WebView.subproj/WebLocationChangeHandler.h: Removed.
  • WebView.subproj/WebLocationChangeHandler.m: Removed.
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient receivedProgressWithHandle:complete:]): (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient handleDidReceiveData:data:]):
  • WebView.subproj/WebResourceProgressDelegate.h:
  • WebView.subproj/WebResourceProgressHandler.h: Removed.
  • WebView.subproj/WebView.m: (-[WebView window]):
  • WebView.subproj/WebWindowContext.h: Removed.
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebContextMenuHandler becomes WebContextMenuDelegate
WebControllerPolicyHandler becomes WebControllerPolicyDelegate
WebLocationChangeHandler becomes WebLocationChangeDelegate
WebResourceProgressHandler becomes WebResourceProgressDelegate
WebWindowContext becomes WebWindowOperationsDelegate

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument dealloc]): (-[BrowserDocument close]):
  • BrowserWebController.h:
  • BrowserWebController.m: (-[BrowserWebController setFrame:]):
  • ContextMenuHandler.h:
  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
  • DownloadMonitor.h:
  • LocationChangeHandler.h:
4:02 PM Changeset in webkit [2130] by hyatt
  • 4 edits in trunk/WebCore

Found the problem with the CSS W3C page.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector):
3:43 PM Changeset in webkit [2129] by darin
  • 15 edits in trunk

WebCore:

WebCore part of fixes for proper layering when drawing subframes.

  • kwq/KWQWidget.mm: (QWidget::paint): Use the parent view in the "WebCoreFrameView" case so we update the scroll view too, not just the HTML part. Also use the passed in rectangle instead of always using the view bounds.
  • kwq/KWQScrollView.mm: (QScrollView::updateContents): Call setNeedsDisplayInRect instead of displayRect.
  • kwq/KWQPainter.mm: (QPainter::drawRect): Use NSRectFill and NSFrameRect instead of NSBezierPath. (QPainter::fillRect): Ditto.

WebKit:

  • fixed 3052543 -- iframes don't work with z-index
  • fixed 3057382 -- code to prevent subviews from drawing not working perfectly for subframes
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView isOpaque]): Change this back to always return YES. We handle this issue at another level now. (-[WebHTMLView drawRect:]): Clip to the passed-in rect. This was the big change that fixed most of the trouble.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove _isMainFrame.
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView initialize]): Add an imposter for NSView too, so we can make opaqueAncestor do what we need it to do. This will only work if the application doesn't also poseAsClass NSView, but it does work. (-[WebNSView opaqueAncestor]): Always return the topmost WebHTMLView if the object is inside one, even if there is an intervening opaque object.
  • WebView.subproj/WebView.m: (-[WebView setFrame:]): Do the display call at the window level so the topmost WebHTMLView always gets involved.
  • WebView.subproj/WebViewPrivate.h: Remove _controller, since we already have a public controller method. Add _isMainFrame.
  • WebView.subproj/WebViewPrivate.m: (-[WebView _isMainFrame]): Added.
3:17 PM Changeset in webkit [2128] by mjs
  • 3 edits in trunk/WebKit
  • Panels.subproj/WebStandardPanels.h: Added inline header docs.
2:44 PM Changeset in webkit [2127] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Changes to the WebCache interface to bring it closer into line
with the current API proposal. Changes in other classes have been made to
keep up with the WebCache changes.

Added removeCacheObjectForKey method.
Renamed cacheVars pointer in WebCache header to more "standard" _private.
Changed names of private methods so that they begin with underscores.

  • CacheLoader.subproj/WebCache.h:
  • CacheLoader.subproj/WebCache.m: (-[WebCache initWithSizeLimit:]) (-[WebCache removeCacheObjectForKey:]) (-[WebCache sizeLimit]) (-[WebCache setSizeLimit:]) (-[WebCache objectSizeLimit]) (-[WebCache setObjectSizeLimit:]) (-[WebCache currentUsage]) (-[WebCache clearCache]) (-[WebCache dealloc]) (-[WebCache _syncCache]) (-[WebCache _setCurrentUsage:]) (-[WebCache _truncateToSizeLimit:])
  • CacheLoader.subproj/WebCachePrivate.h:
  • CacheLoader.subproj/WebDiskCache.m: (-[WebDiskCache removeCacheObjectForKey:]) (-[WebDiskCache _syncCache]) (-[WebDiskCache _truncateToSizeLimit:])
  • CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCache _truncateToSizeLimit]) (-[WebMemoryCache storeCacheObject:forKey:]) (-[WebMemoryCache removeCacheObjectForKey:]) (-[WebMemoryCache clearCache])
  • CacheLoader.subproj/WebResourceLoadManager.m: (-[WebResourceLoadManager syncAllCaches])
  • Database.subproj/WebFileDatabase.m: (-[WebFileDatabase _truncateToSizeLimit:]) (-[WebFileDatabase performSetObject:forKey:]) (-[WebFileDatabase setSizeLimit:])
2:36 PM Changeset in webkit [2126] by mjs
  • 5 edits in trunk/WebKit
  • WebView.subproj/WebWindowContext.h: Added inline header docs.
12:30 PM Changeset in webkit [2125] by hyatt
  • 5 edits in trunk/WebCore

Don't let alternate stylesheets delay render tree construction.

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLLinkElementImpl::process): (HTMLLinkElementImpl::setStyleSheet): (HTMLLinkElementImpl::sheetLoaded):
  • khtml/html/html_headimpl.h:
10:56 AM Changeset in webkit [2124] by hyatt
  • 5 edits in trunk/WebCore

Make overflow:auto and scroll map to hidden until we figure
out something better.

  • khtml/css/cssstyleselector.cpp:
10:25 AM Changeset in webkit [2123] by kocienda
  • 8 edits in trunk/WebKit

Fixes for some build problems I missed earlier due to the fact that PB can't handle header dependencies,
and I did not do a clean build of WebKit.

  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedError:withDataSource:]): WebFoundation error constant name change. (-[WebNetscapePluginStream cancel]): Ditto.
  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]): Modified to use [[WebCookieManager sharedCookieManager] acceptPolicy] rather than reaching down into CFPreferences directly.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): WebFoundation error constant name change. (-[WebSubresourceClient cancel]): Ditto.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Ditto.
10:22 AM Changeset in webkit [2122] by darin
  • 3 edits in trunk/WebKit
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Don't special case the top level frame's view so much. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto. (-[NSView _web_propagateDirtyRectToAncestor]): Use public method here instead of private.
10:21 AM Changeset in webkit [2121] by darin
  • 12 edits in trunk/WebCore

More refinement of the AppKit hackery.

  • khtml/rendering/render_replaced.cpp: (RenderWidget::printObject): Pass in the painter and rect.
  • kwq/qt/qwidget.h: Take a painter and rect parameter.
  • kwq/KWQWidget.mm: (QWidget::paint): Use painter; not working yet to use rect.
  • kwq/KWQFileButton.h: Change paint to take painter and rect.
  • kwq/KWQFileButton.mm: (KWQFileButton::paint): Use painter.
  • kwq/qt/qpainter.h: Added paintingDisabled() function.
  • kwq/KWQPainter.mm: (QPainter::paintingDisabled): Added.
7:58 AM Changeset in webkit [2120] by kocienda
  • 4 edits in trunk/WebKit

WebFoundation:

Modified code to work with new WebError API. Many changes in that API, including removing terminal errors,
taking a pass at the error constants, and cleaning up the init methods.

  • AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager _checkForAuthenticationFailureInHTTPResponse:withURL:result:]): WebFoundation error code constant name changes
  • AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h: Removed WebResult enumerated type; replace with int
  • CacheLoader.subproj/IFURLHandleC.h: WebError API change
  • CacheLoader.subproj/IFURLHandleC.m: Ditto (IFURLHandleBackgroundLoadFailedWithResultCode):
  • CacheLoader.subproj/WebCacheLoaderConstants.h: Removed error constants; moved to WebError.h
  • CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle cancelLoadInBackground]): WebFoundation error code constant name changes
  • CacheLoader.subproj/WebResourceLoad.h: WebError API change
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]): WebError API change (-[WebResourceLoad didRedirectToURL:permanent:]): Ditto. (-[WebResourceLoad _scheduleOriginLoad]): Ditto. (-[WebResourceLoad _beginOriginLoad]): Ditto. (_loadSweeper): Ditto.
  • CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): WebFoundation error code constant name changes
  • English.lproj/WebError.strings: Updated strings file. This file was way out of date.
  • Misc.subproj/WebError.h: Updated API. Terminal error concept removed. API simplified. Error constants moved into this file.
  • Misc.subproj/WebError.m: (classInitialize): Changes to adapt to new API. (-[WebError initWithErrorCode:inDomain:failingURL:]): Ditto (-[WebError errorDescription]): Ditto (+[WebError addErrorsWithCodesAndDescriptions:inDomain:]): Ditto
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler continueBeginLoadInBackgroundAfterCreatingHTTPRequest]): WebFoundation error code constant na

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportBadURL:]): WebFoundation error code constant name change
  • WebView.subproj/WebView.m: (+[WebView initialize]): WebError addErrorsFromDictionary changed to addErrorsWithCodesAndDescriptions

WebBrowser:

Modified code to work with new WebError API.

  • DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDictionary:]): Modified for new "no terminal error" WebError API (-[DownloadProgressEntry stop]): WebFoundation error code constant name change
  • FrameProgressEntry.m: (-[FrameProgressEntry stage]): Ditto
  • LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): Ditto (-[LocationChangeHandler specializedMessageForError:]): Ditto (-[LocationChangeHandler displayLocationChangeError:]): Ditto
  • LocationChangeHandler.m: (-[LocationChangeHandler locationChangeDone:forDataSource:]): Modified for new "no terminal error" WebError API
  • Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences updateCookiesViews]): Fixed unitialized variable build breaker I encountered when doing a Deployment build.
  • ResourceProgressEntry.m: (-[ResourceProgressEntry stage]): WebFoundation error code constant name change

Sep 22, 2002:

9:31 PM Changeset in webkit [2119] by darin
  • 3 edits in trunk/WebKit
  • fixed 3057380 -- insertion point shows through elements in front of text fields
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView initialize]): Make WebNSTextView pose as NSTextView. (-[WebNSTextView _web_inHTMLView]): Helper method. (-[WebNSTextView isOpaque]): Override to return NO for all text views that are inside an WebHTMLView, so they don't try to do insertion point caching. (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]): Use setNeedsDisplayInRect to trigger insertion point drawing outside drawRect instead of drawing right away. (-[WebNSTextView _drawRect:clip:]): Set flag so the above can know when it's inside drawRect and when it's not.
9:27 PM Changeset in webkit [2118] by darin
  • 8 edits in trunk/WebCore

Change code that moves NSViews out of the way to run inside drawRect
after a layout change rather than running at layout time. This makes
sure that views are in the right place when propagating dirty rects.

  • kwq/KWQKHTMLPartImpl.h: Add paint method and _needsToSetWidgetsAside flag.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Set _needsToSetWidgetsAside to false. (KWQKHTMLPartImpl::layout): Set _needsToSetWidgetsAside to true. Don't call moveWidgetsAside any more. (KWQKHTMLPartImpl::paint): Moved the code here from the bridge, but also call moveWidgetsAside if _needsToSetWidgetsAside flag is set.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Call KWQKHTMLPartImpl::paint, which is where I moved this code.
Note: See TracTimeline for information about the timeline view.