Timeline



Sep 28, 2002:

4:57 PM Changeset in webkit [2201] by darin
  • 6 edits in trunk/WebCore

Turn -Werror back on. There must have been some miscommunication
about the fat build; this was supposed to have been on.

  • WebCore.pbproj/project.pbxproj: Add -Werror back.
  • kwq/WebCoreHistory.h: Add missing method to fix warning.
  • kwq/KWQKHistoryProvider.mm: Tweak.
1:38 PM Changeset in webkit [2200] by darin
  • 6 edits in trunk/WebCore

Give the next fat build a better chance of working with the
new gcc without turning warnings off.

  • khtml/css/cssparser.cpp: Use a macro to disable inlining.
  • khtml/html/htmltokenizer.cpp: Ditto.
  • khtml/misc/htmlhashes.cpp: Ditto.
12:49 PM Changeset in webkit [2199] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Catch a request that we can't use here instead of failing later.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Added an assert so the failure was less confusing; good idea to leave it in.
12:35 PM Changeset in webkit [2198] by cblu
  • 4 edits in trunk/WebKit

Support for latest Flash plug-in. It requests a javascript URL for every plug-in instance. Until javascript URLs work, we return an error to the plug-in.

Fixed: 3035582 - flash animations don't work after upgrading flash
Fixed: 3021936 - links in flash at foggypetronasracing.com doesn't work

  • Plugins.subproj/WebPluginStream.h:
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): Make the request here and return nil if we can't create a handle with it. (-[WebNetscapePluginStream dealloc]): release the request (-[WebNetscapePluginStream startLoad]): use the request when creating the handle
1:06 AM Changeset in webkit [2197] by darin
  • 4 edits in trunk/WebCore
  • fixed 3022441 -- scroll bar is missing in window created with window.open
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): The checks for extra parameters to window.open were using isNull, which checks for a null ValueImp pointer, not an "Undefined".
12:39 AM Changeset in webkit [2196] by darin
  • 15 edits in trunk

WebCore:

  • fixed 2886111 -- changing font or size preference causes open windows to redraw incorrectly
  • khtml/rendering/render_table.cpp: (RenderTable::addColInfo): Fix logic about when a recalc of the minWidth and maxWidth is needed.

Fixed bug where changing the text size multiplier would cause the
window to redraw twice -- once with the text size changed, and then
later with the layout changed.

  • khtml/khtmlview.h: Added unscheduleRelayout.
  • khtml/khtmlview.cpp: (KHTMLView::unscheduleRelayout): Added.
  • kwq/KWQKHTMLPartImpl.h: Added forceLayout.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::forceLayout): Call both layout and unscheduleRelayout.
  • kwq/WebCoreBridge.h: Add setNeedsLayout.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge forceLayout]): Call KWQKHTMLPartImpl::forceLayout. (-[WebCoreBridge setTextSizeMultiplier:]): Call forceLayout.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsLayout]): Added.

Sep 27, 2002:

9:22 PM Changeset in webkit [2195] by cblu
  • 4 edits in trunk/WebKit

Fixed KJS crasher caused by nil plug-in returned from WebPlugin.
Got the RealPlayer plug-in loaded, nothing playing yet.

  • Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin getPluginInfo]): check for nil plug-in names/descriptions (-[WebNetscapePlugin stringByResolvingSymlinksAndAliasesInPath:]): new, resolves old-style aliases (-[WebNetscapePlugin initWithPath:]): call stringByResolvingSymlinksAndAliasesInPath
5:45 PM Changeset in webkit [2194] by darin
  • 4 edits in trunk/WebCore
  • khtml/rendering/render_table.cpp: (RenderTable::addColInfo): Fixed a > that should have been a < that prevented tables from changing sizes when table minimum widths changed.
5:16 PM Changeset in webkit [2193] by darin
  • 2 edits in trunk/WebKit/WebView.subproj
  • LocationChangeError.m: (-[LocationChangeHandler displayLocationChangeError:]): Add back the WebErrorCodeCancelled case.
4:44 PM Changeset in webkit [2192] by rjw
  • 4 edits in trunk/WebKit

i Fix 3058315: crash in WebHTMLRepresentation receivedData:withDataSource

​http://www.u2.com/lite/ does some whacky things with its framset's onLoad
handler. The fix ensures that data isn't sent to the bridge once
the bridge has been dealloced.

  • WebKit.pbproj/project.pbxproj: Nothing changed. PB dorkiness.
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation receivedData:withDataSource:]):

Fix related to 3058315.

  • LoadProgressMonitor.m: (-[LoadProgressMonitor receivedUpdateForKey:URLString:bytesLoaded:bytesExpected:error:dataSource:isComplete:]):
2:34 PM Changeset in webkit [2191] by darin
  • 9 edits in trunk/WebCore
  • fixed 2937198 -- Checkboxes and radiobuttons don't align with title control in forms
  • kwq/qt/qcheckbox.h: Add baselinePosition override.
  • kwq/KWQCheckBox.mm: Tweak the size constants. (QCheckBox::baselinePosition): Implement this. Line up baseline two pixels above the bottom, not at the bottom.
  • kwq/qt/qradiobutton.h: Add baselinePosition override.
  • kwq/KWQRadioButton.mm: Tweak the size constants. (QRadioButton::baselinePosition): Implement this. Line up baseline two pixels above the bottom, not at the bottom.
2:31 PM Changeset in webkit [2190] by cblu
  • 14 edits in trunk

WebCore:

WebPlugin clean up.

  • kwq/KWQKConfigBase.mm: (KConfig::readEntry):
  • kwq/WebCoreViewFactory.h:

WebKit:

Fixed: 3056559 - QT plugin doesn't load (claudius)
Fixed: 3042850 - Enable Java by default

Cleaned up WebPlugin and WebPluginDatabase.

  • Plugins.subproj/WebPlugin.h:
  • Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin openResourceFile]): (-[WebNetscapePlugin closeResourceFile:]): (-[WebNetscapePlugin stringForStringListID:andIndex:]): (-[WebNetscapePlugin getPluginInfo]): (-[WebNetscapePlugin initWithPath:]): (-[WebNetscapePlugin load]): (-[WebNetscapePlugin unload]): (-[WebNetscapePlugin MIMEToExtensionsDictionary]): (-[WebNetscapePlugin extensionToMIMEDictionary]): (-[WebNetscapePlugin MIMEToDescriptionDictionary]): (-[WebNetscapePlugin description]):
  • Plugins.subproj/WebPluginDatabase.h:
  • Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase pluginForMIMEType:]): (-[WebNetscapePluginDatabase pluginForExtension:]): (-[WebNetscapePluginDatabase pluginForFilename:]): (-[WebNetscapePluginDatabase MIMETypes]): (-[WebNetscapePluginDatabase init]):
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setDataSource:]):
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Enable Java by default
1:50 PM Changeset in webkit [2189] by rjw
  • 21 edits in trunk

WebBrowser no longer responsible for setting page title in history.

  • LocationChangeHandler.m: (-[LocationChangeHandler receivedPageTitle:forDataSource:]):

Fixed 3060158: REGRESSION: iframes added to session history
Also moved setting title in history to WebKit.

  • History.subproj/WebHistory.h:
  • History.subproj/WebHistory.m: (+[WebHistory sharedHistory]): (+[WebHistory webHistoryWithFile:]): (-[WebHistory addEntryForURL:]): (-[WebHistory addEntries:]):
  • History.subproj/WebHistoryPrivate.h:
  • History.subproj/WebHistoryPrivate.m:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURL]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

Fixed 3059237: Visited links do not appear in a different color on yahoo.com
Fixed 3051288: visited links are not colored in local files
Fixed 3060158: REGRESSION: iframes added to session history
Always use the canonical originally requested URL as the URL entered in history.

  • khtml/khtml_part.cpp: (KHTMLPart::begin):
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestedURLString):
  • kwq/KWQKHistoryProvider.mm:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreHistory.h:
12:40 PM Changeset in webkit [2188] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3058119, doctype of HTML docs should be null.

  • khtml/dom/dom_doc.cpp:
12:27 PM Changeset in webkit [2187] by hyatt
  • 4 edits in trunk/WebCore

DOM compliance. Fix for 3058100, hasFeature of HTML returns
false. Oops.

  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature):
11:35 AM Changeset in webkit [2186] by darin
  • 4 edits in trunk/WebCore
  • fixed 3060487 -- error connecting member slot to signal (KWQObject)
  • kwq/KWQObject.mm: (QObject::connect): Add slotShowDocument to the list of slots that we don't care about hooking up.
10:32 AM Changeset in webkit [2185] by cblu
  • 5 edits in trunk/WebKit

WebKit:

Added support for dragging links the the dock.
Created new pasteboard types WebURLPboardType WebURLNamePboardType that the dock requires.

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]): set WebURLPboardType and WebURLNamePboardType (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): use WebURLPboardType and WebURLNamePboardType
  • WebKit.exp: export WebURLPboardType and WebURLNamePboardType

WebBrowser:

Added support for dragging links the the dock.
Created new pasteboard types WebURLPboardType WebURLNamePboardType that the dock requires.

  • BrowserWebBookmarkExtras.m: (+[WebBookmark writeBookmarks:toPasteboard:withOwner:]): use WebURLPboardType and WebURLNamePboardType
10:27 AM Changeset in webkit [2184] by darin
  • 4 edits in trunk/JavaScriptCore
  • fixed 3033969 -- repro crash (infinite recursion in JavaScript) clicking on "screens" option at fsv.sf.net
  • kjs/object.h: Change recursion limit to 100 levels rather than 1000.
8:25 AM Changeset in webkit [2183] by cblu
  • 1 edit in trunk/WebKit/Misc.subproj/WebNSPasteboardExtras.m

* empty log message *

4:30 AM Changeset in webkit [2182] by mjs
  • 5 edits in trunk/WebKit

WebFoundation:

Put in place all the API changes needed for the "remember
password" feature and examining stored passwords. The actual
storing of passwords in Keychain is not implemented yet - that's
the next step.

  • AuthenticationManager.subproj/WebAuthenticatingResource.h: Added.
  • AuthenticationManager.subproj/WebAuthenticatingResource.m: Added. New class that's the data holder part of WebAuthenticationRequest, the part that describes the resource needing authentication. (-[WebAuthenticatingResourcePrivate dealloc]): (-[WebAuthenticatingResource initWithURL:realm:username:receivesCredentialSecurely:proxyHost:proxyType:]): (+[WebAuthenticatingResource resourceWithURL:realm:username:receivesCredentialSecurely:proxyHost:proxyType:]): (-[WebAuthenticatingResource init]): (-[WebAuthenticatingResource dealloc]): (-[WebAuthenticatingResource URL]): (-[WebAuthenticatingResource realm]): (-[WebAuthenticatingResource username]): (-[WebAuthenticatingResource receivesCredentialSecurely]): (-[WebAuthenticatingResource isProxy]): (-[WebAuthenticatingResource proxyHost]): (-[WebAuthenticatingResource proxyType]): (-[WebAuthenticatingResource copyWithZone:]):
  • AuthenticationManager.subproj/WebAuthenticationHandler.h:
  • AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationDispatchState dealloc]): (-[WebAuthenticationHandlerDispatcher _dispatchStartAuthentication:]): (-[WebAuthenticationHandlerDispatcher WebAuthenticationRequest:useCredential:]): (-[WebAuthenticationHandlerDispatcher _dispatchAuthenticationDone:]): (-[WebAuthenticationHandlerDispatcher startAuthentication:]):
  • AuthenticationManager.subproj/WebAuthenticationManager.h:
  • AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager removeCredentialForResource:]): (-[WebAuthenticationManager resourceCredentials]): (-[WebAuthenticationManager _invokeHandlersWithURL:realm:forRequest:withCallback:context:]): (-[WebAuthenticationManager _invokeHandlersWithURL:proxy:forRequest:withCallback:context:]): (-[WebAuthenticationManager _tryRequest:]): (-[WebAuthenticationManager WebAuthenticationRequest:useCredential:]):
  • AuthenticationManager.subproj/WebAuthenticationRequest.h:
  • AuthenticationManager.subproj/WebAuthenticationRequest.m: (-[WebAuthenticationRequestPrivate initWithResource:previousFailureCount:delegate:]): (-[WebAuthenticationRequestPrivate dealloc]): (-[WebAuthenticationRequest _initWithResource:previousFailureCount:delegate:]): Change to init with a WebAuthenticatingResource rather than passing all the data. (-[WebAuthenticationRequest _authenticationHandlerBusy]): (-[WebAuthenticationRequest resource]): New method (-[WebAuthenticationRequest previousFailureCount]): Renamed from previousFailures (-[WebAuthenticationRequest useCredential:]): Renamed from authenticationDone: (-[WebAuthenticationRequest cancel]): Removed to fix in-band signalling
  • AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
  • AuthenticationManager.subproj/WebAuthenticationResult.m: Removed.
  • AuthenticationManager.subproj/WebCredential.h: Added.
  • AuthenticationManager.subproj/WebCredential.m: Added. Renamed from WebAuthenticationResult. (-[WebCredentialPrivate dealloc]): (-[WebCredential initWithUsername:password:remembered:]): Add remembered: parameter (+[WebCredential credentialWithUsername:password:remembered:]): Likewise (-[WebCredential dealloc]): (-[WebCredential username]): (-[WebCredential password]): (-[WebCredential remembered]): New method (-[WebCredential copyWithZone:]):
  • Misc.subproj/WebFoundation.h:
  • WebFoundation.exp: Fix exports.
  • WebFoundation.pbproj/project.pbxproj: Add new files, remove removed ones.

Mechanical fixes to get C glue to compile:

  • AuthenticationManager.subproj/IFAuthenticationHandlerC.m: (-[IFCallBackAuthenticationHandler isReadyToStartAuthentication:]):
  • AuthenticationManager.subproj/IFAuthenticationRequestC.m: (IFAuthenticationRequestCopyURL): (IFAuthenticationRequestCopyRealm): (IFAuthenticationRequestCopyUsername): (IFAuthenticationRequestWillPasswordBeSentInClear): (IFAuthenticationRequestGetPreviousFailures): (IFAuthenticationRequestIsForProxy): (IFAuthenticationRequestCopyProxyHost): (IFAuthenticationRequestCopyProxyType): (IFAuthenticationRequestDone):
  • AuthenticationManager.subproj/IFAuthenticationResultC.m: (IFAuthenticationResultCreate): (IFAuthenticationResultCopyUsername): (IFAuthenticationResultCopyPassword):

WebKit:

  • Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): (-[WebAuthenticationPanel runAsModalDialogWithRequest:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
  • Panels.subproj/WebPanelAuthenticationHandler.h:
  • Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler isReadyToStartAuthentication:]): (-[WebPanelAuthenticationHandler startAuthentication:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithRequest:result:]):

Sep 26, 2002:

8:25 PM Changeset in webkit [2181] by darin
  • 4 edits in trunk/WebCore
  • fixed 2953256 -- JavaScript window.moveTo() and window.moveBy() methods do not work
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry): Fix calculation. It was returning the bottom left coordinate instead of the top left.
8:06 PM Changeset in webkit [2180] by darin
  • 12 edits in trunk/WebCore
  • fixed 3060459 -- REGRESSION: crash leaving page that sets cookie in JavaScript unload handler
  • khtml/khtml_part.cpp: (KHTMLPart::begin): Call updatePolicyBaseURL to set the "policy base URL" on the documents so the cookie can be based on the URL of the main document.
  • khtml/dom/html_document.h: Add setPolicyBaseURL.
  • khtml/dom/html_document.cpp: (HTMLDocument::setPolicyBaseURL): Call the impl.
  • khtml/html/html_documentimpl.h: Add policyBaseURL, setPolicyBaseURL.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::setCookie): Pass the base URL that's stored here instead of getting at the part through the view, since the view will be 0 during the unload event.
  • kwq/KWQKHTMLPartImpl.h: Add updatePolicyBaseURL and setPolicyBaseURL.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::updatePolicyBaseURL): Set the base URL based on the URL if this is the topmost part, based on the parent's policy base URL if this is not the topmost part. (KWQKHTMLPartImpl::setPolicyBaseURL): Change the policy base URL for this part and all the subparts.
5:45 PM Changeset in webkit [2179] by darin
  • 18 edits in trunk

Tools:

  • HotSpotFinder/HotSpotFinder.pbproj/project.pbxproj: File encodings.

WebCore:

  • kwq/WebCoreBridge.h: Use NSString for encoding name, not CFStringEncoding.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge addData:withOverrideEncoding:]): Ditto.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Use NSString for encoding.
  • WebView.subproj/WebController.h: Update names to use separate boolean for user agent and strings for text encodings instead of CFStringEncoding.
  • WebView.subproj/WebController.m: (-[WebController setCustomUserAgent:]): Name change. (-[WebController resetUserAgent]): Added. (-[WebController hasCustomUserAgent]): Added. (-[WebController customUserAgent]): Name change. (-[WebController setCustomTextEncodingName:]): Take NSString. (-[WebController resetTextEncoding]): Update for NSString. (-[WebController _mainFrameOverrideEncoding]): Ditto. (-[WebController hasCustomTextEncoding]): Ditto. (-[WebController customTextEncodingName]): Return NSString.
  • WebView.subproj/WebDataSourcePrivate.h: Use NSString instead of CFStringEncoding.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): No need to init. (-[WebDataSource _setContentType:]): Copy, don't retain. (-[WebDataSource _setEncoding:]): Copy, don't retain. (-[WebDataSource _setOverrideEncoding:]): Use NSString. (-[WebDataSource _overrideEncoding]): Use NSString.
  • WebView.subproj/WebFramePrivate.h: Use NSString.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): Use NSString.
  • WebView.subproj/WebPreferences.h: Use NSString instead of CFStringEncoding.
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Use NSString. (-[WebPreferences defaultTextEncodingName]): Use NSString. (-[WebPreferences setDefaultTextEncodingName:]): Use NSString.

WebBrowser:

  • AppController.m: (-[AppController updateTextEncodingMenu]): Convert to CFStringEncoding.
  • BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Convert to CFStringEncoding. (-[BrowserWindowController changeTextEncoding:]): Convert to NSString.
  • Debug/DebugUtilities.m: (-[BrowserDocument setUserAgent:]): Update for API change. (-[BrowserDocument validate_setUserAgent:]): Ditto. (-[BrowserDocument resetUserAgent:]): Ditto. (-[BrowserDocument validate_resetUserAgent:]): Ditto.
  • Preferences.subproj/TextPreferences.m: (-[TextPreferences updateDefaultCharacterSetPopup]): Convert to CFStringEncoding. (-[TextPreferences takeDefaultCharacterSetFrom:]): Convert to NSString.
3:37 PM Changeset in webkit [2178] by cblu
  • 3 edits in trunk/WebKit

WebKit:

Made WebTextView super-private.

  • WebKit.pbproj/project.pbxproj:

WebBrowser:

  • Made the view source window
    • larger
    • use Monaco, 10 font
    • respond to makeTextLarger and makeTextSmaller
    • use saveDocumentAs

Fixed: 3053366 - source window should have file proxy after save

  • BrowserDocument.h:
  • BrowserDocument.m:
  • English.lproj/HTMLSource.nib: made window larger, use WebSearchableTextView
  • HTMLSourceController.h:
  • HTMLSourceController.m: (-[HTMLSourceController windowDidLoad]): set the text multiplier (-[HTMLSourceController setTextSizeMultiplier:]): new (-[HTMLSourceController textSizeMultiplier]): new
  • HTMLSourceDocument.h:
  • HTMLSourceDocument.m: (-[HTMLSourceDocument dataRepresentationOfType:]): new saved flag (-[HTMLSourceDocument saveDocumentTo:]): call saveDocumentAs (-[HTMLSourceDocument displayName]): perform hacks to get window title and saved filename correct (-[HTMLSourceDocument controller]): new (-[HTMLSourceDocument browserDocumentLoadingFinished:]): don't update after save (-[HTMLSourceDocument canMakeTextLarger]): new (-[HTMLSourceDocument canMakeTextSmaller]): new (-[HTMLSourceDocument makeTextLarger:]): new (-[HTMLSourceDocument makeTextSmaller:]): new (-[HTMLSourceDocument validateUserInterfaceItem:]): new
3:11 PM Changeset in webkit [2177] by rjw
  • 3 edits in trunk/WebKit

i Use a rectangle with rounded corners for dragged label.

Put a subtle shadow behind text in label.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):
12:07 PM Changeset in webkit [2176] by cblu
  • 15 edits
    2 adds in trunk

WebCore:

Added WebCoreElementImageLocationKey to the element dictionary.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

WebKit:

  • When dragging an image, use the image itself for the drag image
  • Support promised file and image data drag types for dragged images.
  • Misc.subproj/WebNSImageExtras.h: Added.
  • Misc.subproj/WebNSImageExtras.m: Added. (-[NSImage _web_scaleToMaxSize:]): new, scales an image is greater than max (-[NSImage _web_dissolveToFraction:]): new, dissolves image in place
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.h: Added WebElementImageLocationKey to the element dictionary
  • WebView.subproj/WebController.m: ditto
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): subclassed for only for image drags (-[WebHTMLView mouseDragged:]): use the promised file api again. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): use the retained element dictionary instead of the dragged URL which I deleted.
  • WebView.subproj/WebHTMLViewPrivate.h:
10:20 AM Changeset in webkit [2175]
  • 3 copies in tags/Alexander-25

This commit was manufactured by cvs2svn to create tag 'Alexander-25'.

10:20 AM Changeset in webkit [2174] by sheridan
  • 8 edits in trunk

Alex-25 versions + markers

8:20 AM Changeset in webkit [2173] by darin
  • 5 edits in trunk/JavaScriptCore

Fix the infinity problem Dave worked around. We didn't have the
configuration flags set right to make infinity work. Setting those
properly made everything work without changes to min and max.

  • kjs/config.h: Define HAVE_FUNC_ISINF, HAVE_STRING_H, and also WORDS_BIGENDIAN (if on ppc).
  • kjs/math_object.cpp: (MathFuncImp::call): Roll out min and max changes from yesterday.

Sep 25, 2002:

7:15 PM Changeset in webkit [2172] by rjw
  • 9 edits in trunk/WebKit

API tweaks.

  • Misc.subproj/WebKit.h: Added headers.
  • Misc.subproj/WebKitErrors.h: Removed #defines.
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): (-[WebDataSource _loadIcon]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): Removed isMainDocument.

Moved errors string #defines here.

  • WebView.subproj/WebView.m:

Updated to reflect API tweaks.

  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
5:57 PM Changeset in webkit [2171] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3060773 -- Wrong title proposed when image link dropped on favorites bar
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Claim the pasteboard (via declareTypes:) before putting data on it.
5:51 PM Changeset in webkit [2170] by rjw
  • 24 edits in trunk/WebKit

API and documentation tweaks.

WebDocumentDragSettings: canDrag -> acceptsDrag
WebDataSource: removed originalURL
WebStandardPanels: use -> uses

  • History.subproj/WebBackForwardList.h:
  • Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]):
  • Panels.subproj/WebStandardPanels.h:
  • Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels setUsesStandardAuthenticationPanel:]): (-[WebStandardPanels usesStandardAuthenticationPanel]):
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView frameStateChanged:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient cancel]):
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): (-[WebFrame startLoading]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _setState:]): (-[WebFrame _goToItem:withFrameLoadType:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView setAcceptsDrags:]): (-[WebHTMLView acceptsDrags]): (-[WebHTMLView setAcceptsDrops:]): (-[WebHTMLView acceptsDrops]):
  • WebView.subproj/WebImageView.m: (-[WebImageView setAcceptsDrags:]): (-[WebImageView acceptsDrags]): (-[WebImageView setAcceptsDrops:]): (-[WebImageView acceptsDrops]):
  • WebView.subproj/WebLoadProgress.h:
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]):
  • WebView.subproj/WebView.h:

Updated to reflect API tweaks.

  • AppController.m: (-[AppController awakeFromNib]):
  • DownloadProgressEntry.m: (-[DownloadProgressEntry stop]):
  • LocationChangeHandler.m: (-[LocationChangeHandler locationChangeStartedForDataSource:]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]):
3:47 PM Changeset in webkit [2169] by hyatt
  • 5 edits in trunk/WebCore

Implement scrollX and scrollY on the window object. This
gets brainjar closer to reality. :)

  • khtml/ecma/kjs_window.cpp: (Window::get):
  • khtml/ecma/kjs_window.h:
3:46 PM Changeset in webkit [2168] by hyatt
  • 4 edits in trunk/JavaScriptCore

Fix the impls of min/max to not use +inf/-inf when you have
arguments. Technically there's still a bug here for the no
argument case, probably caused by a screwup when +inf/-inf are
converted to doubles.

  • kjs/math_object.cpp: (MathFuncImp::call):
1:25 PM Changeset in webkit [2167] by darin
  • 4 edits in trunk/JavaScriptCore
  • fixed 3057964 -- JS problem performing MD5 script embedded in yahoo login page
  • kjs/simple_number.h: Fix incorrect check for sign bit that was munging numbers in the range 0x10000000 to 0x1FFFFFFF.
11:23 AM Changeset in webkit [2166] by kocienda
  • 9 edits in trunk/WebKit

WebFoundation:

Changes to move the WebResourceHandle API closer to the
specified design. This includes:

  • Removed loadInBackground method from the public interface.
  • Start asynchronous loading in WebResourceHandle init method.
  • Remove loadInForeground: from WebResourceHandle interface.
  • Add nice comments to WebResourceHandle header file.
  • Move WebResourceHandle callback deferral methods to SPI header file.
  • Some cleanups in synchronous loading.
  • Change name of WebResourceHandle cancelLoadInBackground method to cancel.
  • Some changes to the C glue (why do I even pretend that I am keeping this glue code working?)
  • CacheLoader.subproj/IFURLHandleC.h:
  • CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleCancelLoadInBackground) (IFURLHandleDidRedirectToURL)
  • CacheLoader.subproj/WebResourceHandle.h:
  • CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle canInitWithRequest:]) (-[WebResourceHandle initWithRequest:delegate:]) (-[WebResourceHandle cancel]) (-[WebResourceHandle loadInForeground:]) (-[WebResourceHandle loadInForeground])
  • CacheLoader.subproj/WebResourceHandleInternal.h:
  • CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _loadInBackground]) (-[WebResourceHandle _postCallback:]) (-[WebResourceHandle _sendCallbacks])
  • CacheLoader.subproj/WebResourceHandlePrivate.h:
  • CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _setDefersCallbacks:]) (-[WebResourceHandle _defersCallbacks])
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad cancel])
  • CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate run:]) (-[WebResourceHandleSynchronousDelegate finished])
  • WebFoundation.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Changes to move the WebResourceHandle API closer to the
specified design. This includes:

  • Removed loadInBackground method from the public interface.
  • Start asynchronous loading in WebResourceHandle init method. This required some code reorganization in callers.
  • Remove loadInForeground: from WebResourceHandle interface.
  • Move WebResourceHandle callback deferral methods to SPI header file.
  • Change name of WebResourceHandle cancelLoadInBackground method to cancel.
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]) (-[WebIconLoader stopLoading])
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad]) (-[WebNetscapePluginStream cancel])
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]) (-[WebSubresourceClient cancel])
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]) (-[WebDataSource _addSubresourceClient:]) (-[WebDataSource _stopLoading]) (-[WebDataSource _defersCallbacksChanged])
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveData:])
11:01 AM Changeset in webkit [2165] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3050665 - REGRESSION: mp3 audio loads and plays, but no progress or play control is visible

  • Plugins.subproj/WebPluginView.h:
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setNeedsLayout:]): (-[WebNetscapePluginView layout]): (-[WebNetscapePluginView drawRect:]):
9:03 AM Changeset in webkit [2164] by darin
  • 4 edits in trunk/WebCore

Fix error with the color "indigo".

  • kwq/KWQColor.mm: (getNamedColors): There were some spaces in our color table so we wouldn't handle indianred or indigo.
8:50 AM Changeset in webkit [2163] by darin
  • 5 edits in trunk/WebKit

Make the "set aside subviews" logic stronger so it can handle a display
while inside drawRect. But note, this recursive display is most likely
the cause of the redrawing problems we have while resizing, like bug 2969367.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Restore views and then set them aside again, but don't leave the "views set aside" boolean set.
  • WebView.subproj/WebHTMLViewPrivate.h: Add private _setAsideSubviews and _restoreSubviews methods.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _setAsideSubviews]): Added. (-[WebHTMLView _restoreSubviews]): Added. (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Use the new _setAsideSubviews and _restoreSubviews methods. (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Ditto.
8:32 AM Changeset in webkit [2162] by kocienda
  • 4 edits in trunk/WebKit

WebFoundation:

Removed this method from WebResourceHandle:

+(BOOL)canInitWithURL:(NSURL *)theURL;

replaced with:

+(BOOL)canInitWithRequest:(WebResourceRequest *)request;

Also added a convenience method to WebResourceRequest that
allocates, inits, and returns an autoreleased instance.

  • CacheLoader.subproj/WebResourceHandle.h:
  • CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle canInitWithRequest:])
  • CacheLoader.subproj/WebResourceRequest.h:
  • CacheLoader.subproj/WebResourceRequest.m: (+[WebResourceRequest requestWithURL:])

WebKit:

Removed this method from WebResourceHandle:

+(BOOL)canInitWithURL:(NSURL *)theURL;

replaced with:

+(BOOL)canInitWithRequest:(WebResourceRequest *)request;

Callers have been updated to reflect the change.

  • WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate defaultURLPolicyForURL:])
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowURL:])
7:18 AM Changeset in webkit [2161] by kocienda
  • 8 edits in trunk/WebKit

WebFoundation:

More moves to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

-(void)handle:(WebResourceHandle *)handle didReceiveData:(NSData *)data;

  • CacheLoader.subproj/WebResourceCallbackClient.m: (-[WebResourceCallbackClient handle:didReceiveData:])
  • CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientDataDidBecomeAvailable])
  • CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate handle:didReceiveData:])

WebKit:

More moves to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

-(void)handle:(WebResourceHandle *)handle didReceiveData:(NSData *)data;

  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader handle:didReceiveData:])
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:didReceiveData:])
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveData:])
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveData:])
7:02 AM Changeset in webkit [2160] by kocienda
  • 8 edits in trunk/WebKit

WebFoundation:

Moving to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

  • (void)handle:(WebResourceHandle *)handle didFailLoadingWithError:(WebError *)result;
  • CacheLoader.subproj/WebResourceCallbackClient.m:
  • CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientDidFailLoading])
  • CacheLoader.subproj/WebResourceSynchronousClient.m:

WebKit:

Moving to the new WebResourceHandleDelegate API.

This change moves all WebResourceHandleDelegate implementors to:

  • (void)handle:(WebResourceHandle *)handle didFailLoadingWithError:(WebError *)result;
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader handle:didFailLoadingWithError:])
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:didFailLoadingWithError:])
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didFailLoadingWithError:])
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didFailLoadingWithError:])
6:25 AM Changeset in webkit [2159] by kocienda
  • 13 edits in trunk/WebKit

WebFoundation:

Begin change from WebResourceClient to WebResourceHandleDelegate.
In this step, I have just changed the name of the protocol; the
protocol interface is the same.

As part of this change, WebResourceSynchronousClient becomes
WebResourceHandleSynchronousDelegate. Also, the init interface
for WebResourceHandle assumes the form specified in the new API
specification:

-(id)initWithRequest:(WebResourceRequest *)request delegate:(id <WebResourceHandleDelegate>)delegate;

I also made cosmetic changes to variable names and such.

Note that I am removing the WebResourceClient.h file, but I
copied the ,v file in the repository so that the history for WebResourceClient.h
is preserved in WebResourceHandleDelegate.h.

  • CacheLoader.subproj/WebResourceCallbackClient.h:
  • CacheLoader.subproj/WebResourceClient.h: Removed.
  • CacheLoader.subproj/WebResourceHandle.h:
  • CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadInForeground:]) (-[WebResourceHandle initWithRequest:delegate:])
  • CacheLoader.subproj/WebResourceHandleInternal.h:
  • CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _notifyClientDidRedirectToURL]) (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]) (-[WebResourceHandle _notifyClientDidFailLoading]) (-[WebResourceHandle _notifyClientDidFinishLoading])
  • CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _userAgentForURL:])
  • CacheLoader.subproj/WebResourceResponse.h:
  • CacheLoader.subproj/WebResourceSynchronousClient.h:
  • CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate initWithMonitor:realDelegate:]) (-[WebResourceHandleSynchronousDelegate dealloc]) (-[WebResourceHandleSynchronousDelegate handleWillUseUserAgent:forURL:]) (-[WebResourceHandleSynchronousDelegate handleDidFinishLoading:]) (-[WebResourceHandleSynchronousDelegate handleDidReceiveData:data:]) (-[WebResourceHandleSynchronousDelegate handleDidRedirect:toURL:])
  • Misc.subproj/WebFoundation.h:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Begin change from WebResourceClient to WebResourceHandleDelegate.
In this step, I have just changed the name of the protocol; the
protocol interface is the same.

I made other cosmetic changes to variable names and such.

  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad])
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:])
  • WebCoreSupport.subproj/WebSubresourceClient.h:
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:])
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading])
  • WebView.subproj/WebMainResourceClient.h:
1:22 AM Changeset in webkit [2158] by mjs
  • 17 edits in trunk

Tests:

  • CookieManager/wkcookiemanager-test.m: (main): Adjust for API change.

WebFoundation:

  • fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"
  • CacheLoader.subproj/WebResourceRequest.h:
  • CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest cookiePolicyBaseURL]): (-[WebResourceRequest setCookiePolicyBaseURL:]): (-[WebResourceRequest copyWithZone:]):
  • CookieManager.subproj/IFCookieManagerC.m: (IFCookieManagerSetCookiesFromResponseHeaders):
  • CookieManager.subproj/WebCookieConstants.h:
  • CookieManager.subproj/WebCookieManager.h:
  • CookieManager.subproj/WebCookieManager.m: (-[WebCookieManager _readAcceptCookiesPreference]): (-[WebCookieManager _setCookies:forURL:policyBaseURL:]): (-[WebCookieManager setCookie:]): (-[WebCookieManager setCookiesFromResponseHeaders:forURL:policyBaseURL:]): (-[WebCookieManager setAcceptPolicy:]):
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_domainFromHost]):
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler setResponseHeadersUsingHTTPResponse:andCall:context:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _parseHeadersFromData:]):

WebCore:

  • fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::setCookie):
  • kwq/KWQKCookieJar.h:
  • kwq/KWQKCookieJar.mm: (KWQKCookieJar::setCookie):
  • kwq/WebCoreCookieAdapter.h:
  • kwq/WebCoreCookieAdapter.m: (-[WebCoreCookieAdapter setCookies:forURL:policyBaseURL:]):

WebKit:

  • fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"
  • WebCoreSupport.subproj/WebCookieAdapter.h:
  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient handleDidRedirect:toURL:]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidRedirect:toURL:]):

WebBrowser:

  • fixed 2854536 - New cookie policy: "accept cookies only from the same domain as the main page"
  • Preferences.subproj/English.lproj/SecurityPreferences.nib:
  • Preferences.subproj/SecurityPreferences.h:
  • Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):

Sep 24, 2002:

6:42 PM Changeset in webkit [2157] by rjw
  • 11 edits in trunk/WebKit

More documentation tweaks.

  • History.subproj/WebHistory.h:
  • History.subproj/WebHistoryItem.h:
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebResourceProgressDelegate.h:
6:20 PM Changeset in webkit [2156] by darin
  • 8 edits
    2 adds in trunk/WebKit
  • fixed 3059513 -- REGRESSION: Scrolling to fragment doesn't work

Turns out it was better to just put the extra smarts into the clip view
that we are already creating. Making WebHTMLView be a second clip view
was silly and broke things.

  • WebView.subproj/WebView.m: (-[WebView initWithFrame:]): Create a WebClipView and use it as the content view rather than the NSClipView created by default.
  • WebKit.pbproj/project.pbxproj: Added WebClipView.
  • WebView.subproj/WebClipView.h: Added.
  • WebView.subproj/WebClipView.m: Added.
  • WebView.subproj/WebHTMLView.h: Don't be a subclass of NSClipView any more.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Call setAdditionalClip and resetAdditionalClip on the clip view.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove inDrawRect and drawRect.
  • WebView.subproj/WebHTMLViewPrivate.m: Remove visibleRect override. This is now in WebClipView.
5:31 PM Changeset in webkit [2155] by darin
  • 7 edits in trunk/WebCore

Tests:

  • harness.c: (runtest): Turn off leak checking. It's broken.
  • qt/qdate-test.chk: Update test for changes to QDate.
  • qt/qdate-test.cpp: (main): Ditto.
  • qt/qtime-test.chk: Update test for changes to QTime.
  • qt/qtime-test.cpp: (main): Ditto.

WebCore:

  • fixed 3057928 -- lstat private/etc/localtime repeatedly reported by fs_usage when mouse is moved
  • WebCore-tests.exp: Remove now-unneeded external entry points for QTime, QDate, QDateTime.
  • kwq/qt/qdatetime.h:
  • kwq/KWQDateTime.mm: Redid QDateTime using CoreFoundation instead of time/localtime. This avoids constantly hitting the disk when getting the current time to stuff into an event.
5:30 PM Changeset in webkit [2154] by cblu
  • 6 edits in trunk/WebKit

More documentation changes.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.h:
  • WebView.subproj/WebDocument.h:
4:25 PM Changeset in webkit [2153] by hyatt
  • 4 edits in trunk/WebCore

Make sure we dispatch both a capturing and a bubbling event
to target nodes. DOM lvl 2 event compliance.

  • ChangeLog:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent):
4:22 PM Changeset in webkit [2152] by rjw
  • 4 edits in trunk/WebKit

Added FIXME not about unresolved issue with CFStringEncoding/NSStringEncoding.

  • WebView.subproj/WebController.h:
4:20 PM Changeset in webkit [2151] by rjw
  • 11 edits in trunk

i Fixed 3055078. Ensure file: URLs have before path.

  • kwq/KWQKURL.mm: (KURL::parse):

Documentation for WebDataSource and WebFrame.

  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource frameExists:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource addFrame:]):
  • WebView.subproj/WebFrame.h:
3:34 PM Changeset in webkit [2150] by hyatt
  • 4 edits in trunk/WebCore

Better fix. Clears the boolean when CLASS has no value.
This will keep the style system from thinking you have
a class when you don't.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):
3:21 PM Changeset in webkit [2149] by hyatt
  • 4 edits in trunk/WebCore

Fix updating of the document's notion of the focused node
to happen on mouse down rather than click. This matches
the behavior of all other browsers (IE, Gecko, etc.).

This fixes the drawing of the outline on the brainjar.com
DHTML menus.

  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent):
3:20 PM Changeset in webkit [2148] by darin
  • 3 edits in trunk/WebKit
  • fixed 3059266 -- REGRESSION: clicking in web view when location field is focused does not focus web view
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView needsPanelToBecomeKey]): Must override this to return YES, because NSClipView makes it return NO even though we accept the first responder.
2:45 PM Changeset in webkit [2147] by hyatt
  • 4 edits in trunk/WebCore

Make sure that changes to the CLASS attribute mark the
element as changed (as if a CSS property were added or
removed).

This makes the brainjar.com rollovers work much better.

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):
2:26 PM Changeset in webkit [2146] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3056158 -- REGRESSION: Page up/down should scroll one whole contentView minus at least one readable line of text

This was broken a while back when the keyboard scrolling code
migrated into WebKit.

  • WebView.subproj/WebViewPrivate.m: (-[WebView _verticalKeyboardScrollAmount]), (-[WebView _horizontalKeyboardScrollAmount]): New private methods, return one arrow key's worth of scrolling. (-[WebView _scrollLineVertically:]), (-[WebView _scrollLineHorizontally:]): Now use the broken-out methods. (-[WebView _pageVertically:]), (-[WebView _pageHorizontally:]): overlap by one arrow key's worth of scrolling instead of the teensy-weensy one click's worth.
2:02 PM Changeset in webkit [2145] by cblu
  • 3 edits in trunk/WebKit

Documentation for WebHTMLView

  • WebView.subproj/WebHTMLView.h:
1:05 PM Changeset in webkit [2144] by rjw
  • 16 edits in trunk/WebKit

Documentation changes. Removal of imports from
some headers required modification of .m.

  • Plugins.subproj/WebNullPluginView.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m:
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate defaultURLPolicyForURL:]): (-[WebDefaultPolicyDelegate URLPolicyForURL:inFrame:]):
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebHTMLViewPrivate.m:

Documentation changes. Removal of imports from
some headers required modification of .m.

  • BrowserDocument.m:
  • BrowserWebController.m: (-[BrowserWebController URLPolicyForURL:inFrame:]):
  • DownloadMonitor.m:
  • DownloadProgressEntry.m:
11:37 AM Changeset in webkit [2143] by cblu
  • 21 edits in trunk

WebCore:

Renamed element info keys to WebElement* instead of WebContextMenuElement*

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

WebKit:

Renamed element info keys to WebElement* instead of WebContextMenuElement*
Added WebKit API documentation

  • Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin load]): clean-up
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m:
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]): (-[WebDefaultContextMenuDelegate downloadURL:]): (-[WebDefaultContextMenuDelegate openLinkInNewWindow:]): (-[WebDefaultContextMenuDelegate downloadLinkToDisk:]): (-[WebDefaultContextMenuDelegate copyLinkToClipboard:]): (-[WebDefaultContextMenuDelegate openImageInNewWindow:]): (-[WebDefaultContextMenuDelegate downloadImageToDisk:]): (-[WebDefaultContextMenuDelegate copyImageToClipboard:]): (-[WebDefaultContextMenuDelegate openFrameInNewWindow:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):

WebBrowser:

Renamed element info keys to WebElement* instead of WebContextMenuElement*

  • BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierMask:]):
  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler addLinkToBookmarks:]): (-[ContextMenuHandler viewSource:]): (-[ContextMenuHandler savePageAs:]): (-[ContextMenuHandler openWithiTunes:]):
11:29 AM Changeset in webkit [2142] by darin
  • 8 edits in trunk/WebKit

Cleaned up some loose ends from adding setNeedsLayout to the WebDocumentView
protocol. Was causing exceptions.

  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setNeedsLayout:]):
  • WebView.subproj/WebTextView.m: (-[WebTextView setNeedsLayout:]): Added missing stubs.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsReapplyStyles]): Removed unneeded cast.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]): Remove an unneeded cast and call to isDocumentHTML.
  • WebView.subproj/WebHTMLView.h: No need to re-declare setNeedsLayout.
  • WebView.subproj/WebView.m: (-[WebView setFrame:]): Get rid of unneeded check of isDocumentHTML.
10:48 AM Changeset in webkit [2141] by darin
  • 4 edits in trunk/WebCore

Apparently the strings at this site were just the right length to expose a bug
in our QString implementation, one that I probably introduced when fixing 3032072.
One nice thing about this is that getting this correct could also result in a
little bit of a speedup, as the internal buffer is used more.

  • kwq/KWQString.mm: (QStringData::makeAscii): Set _maxAscii to QS_INTERNAL_BUFFER_CHARS when using the internal buffer instead of leaving it uninitialized. (QStringData::makeUnicode): Same for _maxUnicode.
10:24 AM Changeset in webkit [2140] by darin
  • 10 edits in trunk/WebCore

Remove the focus border hack, which was no longer doing us any good.

  • kwq/KWQNSTextField.h: Don't define FOCUS_BORDER_SIZE.
  • kwq/KWQNSTextField.mm: Remove KWQTextFieldCell. (-[KWQNSTextField updateSecureFieldFrame]): Don't inset by FOCUS_BORDER_SIZE.
  • kwq/qt/qlineedit.h: Don't override frameGeometry and setFrameGeometry any more.
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Don't subtract the focus border size.
10:17 AM Changeset in webkit [2139] by darin
  • 6 edits in trunk/WebKit
  • fixed 3057383 -- focus rectangles are being drawn multiple times
  • fixed 3051025 -- focus ring on password field gets darker and darker

To make focus rings clip too, we have to do more than just set the clip.
We also have to set the visible rectangle to make clipping happen, and we
need to be a subclass of NSClipView so that the focus ring drawing code will
consult us rather than one of our superviews.

  • WebView.subproj/WebHTMLView.h: Be a subclass of NSClipView.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Set a inDrawRect flag, and a drawRect rectangle. This tells us to clip to this rectangle. what we need to clip to.
  • WebView.subproj/WebHTMLViewPrivate.h: Added inDrawRect and drawRect.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView visibleRect]): Clip the visible rect based on the drawRect while inDrawRect is set.
10:13 AM Changeset in webkit [2138] by darin
  • 4 edits in trunk/WebCore
  • kwq/mac-encodings.txt: Remove constant for Japanese auto-detect.
9:53 AM Changeset in webkit [2137] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQFileButton.mm: (KWQFileButton::paint): Fix typo.
9:22 AM Changeset in webkit [2136] by darin
  • 5 edits in trunk/WebCore

Some improvements to the file button, including displaying the file without the
extension if it's set that way by the user, and using the system font rather
than hard-coding "Lucida Grande".

  • kwq/KWQFileButton.h: Add _label field.
  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Set up label. (KWQFileButton::~KWQFileButton): Release label. (KWQFileButton::setFilename): Use NSFileManager componentsToDisplayForPath to figure out the appropriate label. (KWQFileButton::paint): Clip to passed-in rect, get font using systemFontOfSize, and use NSString drawing rather than our own.
Note: See TracTimeline for information about the timeline view.