⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 30, 2002:

10:30 PM Changeset in webkit [2212] by cblu
  • 11 edits
    7 adds
    3 deletes in trunk/WebKit

A ton o' plugin view clean-up and arch changes. Turned WebPluginView into WebBaseNetscapePluginView. New classes WebNetscapePluginEmbeddedView and WebNetscapePluginDocumentView are subclasses of WebBaseNetscapePluginView. WebNetscapePluginDocumentView handles non-HTML plug-in content and WebNetscapePluginEmbeddedView is the WebHTMLView subview.

Found that we leak the world on complex pages with plug-ins such as macromedia.com and marvel.com when closing the window. Still need to figure this out.

  • Plugins.subproj/WebBaseNetscapePluginView.h: Added.
  • Plugins.subproj/WebBaseNetscapePluginView.m: Added. (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView modifiersForEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView keyMessageForEvent:]): (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (-[WebBaseNetscapePluginView acceptsFirstResponder]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView isInResponderChain]): (-[WebBaseNetscapePluginView performKeyEquivalent:]): (-[WebBaseNetscapePluginView menuForEvent:]): (-[WebBaseNetscapePluginView setUpWindowAndPort]): (-[WebBaseNetscapePluginView setWindow]): (-[WebBaseNetscapePluginView removeTrackingRect]): (-[WebBaseNetscapePluginView resetTrackingRect]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView webFrame]): (-[WebBaseNetscapePluginView controller]): (-[WebBaseNetscapePluginView plugin]): (-[WebBaseNetscapePluginView setMIMEType:]): (-[WebBaseNetscapePluginView setBaseURL:]): (-[WebBaseNetscapePluginView setArguments:]): (-[WebBaseNetscapePluginView setMode:]): (-[WebBaseNetscapePluginView initWithFrame:]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView isFlipped]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewHasMoved:]): (-[WebBaseNetscapePluginView windowWillClose:]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView defaultsHaveChanged:]): (-[WebBaseNetscapePluginView frameStateChanged:]): (-[WebBaseNetscapePluginView pluginInstance]): (-[WebBaseNetscapePluginView pluginURLFromCString:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): (-[WebBaseNetscapePluginView getURL:target:]): (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): (-[WebBaseNetscapePluginView newStream:target:stream:]): (-[WebBaseNetscapePluginView write:len:buffer:]): (-[WebBaseNetscapePluginView destroyStream:reason:]): (-[WebBaseNetscapePluginView status:]): (-[WebBaseNetscapePluginView invalidateRect:]): (-[WebBaseNetscapePluginView invalidateRegion:]): (-[WebBaseNetscapePluginView forceRedraw]):
  • Plugins.subproj/WebBaseNetscapePluginViewPrivate.h: Added.
  • Plugins.subproj/WebNetscapePluginDocumentView.h: Added.
  • Plugins.subproj/WebNetscapePluginDocumentView.m: Added. (-[WebNetscapePluginDocumentView initWithFrame:]): (-[WebNetscapePluginDocumentView dealloc]): (-[WebNetscapePluginDocumentView drawRect:]): (-[WebNetscapePluginDocumentView dataSource]): (-[WebNetscapePluginDocumentView setDataSource:]): (-[WebNetscapePluginDocumentView dataSourceUpdated:]): (-[WebNetscapePluginDocumentView setNeedsLayout:]): (-[WebNetscapePluginDocumentView layout]):
  • Plugins.subproj/WebNetscapePluginEmbeddedView.h: Added.
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m: Added. (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:arguments:]): (-[WebNetscapePluginEmbeddedView dealloc]): (-[WebNetscapePluginEmbeddedView viewDidMoveToWindow]): (-[WebNetscapePluginEmbeddedView start]): (-[WebNetscapePluginEmbeddedView dataSource]):
  • Plugins.subproj/WebNetscapePluginViewPrivate.h: Removed.
  • Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase init]):
  • Plugins.subproj/WebPluginNullEventSender.h:
  • Plugins.subproj/WebPluginNullEventSender.m: (-[WebNetscapePluginNullEventSender initWithPluginView:]): (-[WebNetscapePluginNullEventSender sendNullEvents]):
  • Plugins.subproj/WebPluginStream.h:
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream getFunctionPointersFromPluginView:]): (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream startLoad]): (-[WebNetscapePluginStream receivedData:withDataSource:]): (-[WebNetscapePluginStream handleWillUseUserAgent:forURL:]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream cancel]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]): (-[WebNetscapePluginStream handleDidRedirect:toURL:]):
  • Plugins.subproj/WebPluginView.h: Removed.
  • Plugins.subproj/WebPluginView.m: Removed.
  • Plugins.subproj/npapi.m: (NPN_GetURLNotify): (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_Status): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw):
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[NSView _web_stopIfPluginView]):
2:39 PM Changeset in webkit [2211] by hyatt
  • 4 edits in trunk/WebCore

Fix the case sensitivity problem with attribute names
in HTML. They are now lower-cased when being queried
from the DOM. Bug 3058145.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::attrName):
1:25 PM Changeset in webkit [2210] by hyatt
  • 4 edits in trunk/WebCore

Make sure to keep the fix checked in for 1.18. That fix is
good.

  • khtml/rendering/render_table.cpp: (RenderTable::addColInfo):
1:03 PM Changeset in webkit [2209] by hyatt
  • 4 edits in trunk/WebCore

Backing out change to render_table.cpp. The original logic
(in version 1.16) is correct.

  • khtml/rendering/render_table.cpp: (RenderTable::addColInfo):
11:09 AM Changeset in webkit [2208] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Remove the ill-advised "don't even create a WebDataSource if WebResourceHandle can't handle this request" code.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Rearrange checks so we won't get confused if we can't create a handle.
10:52 AM Changeset in webkit [2207] by darin
  • 13 edits in trunk/WebCore
  • kwq/qt/qobject.h: Add the destroyed signal.
  • kwq/KWQObject.mm: (QObject::connect): Remove names of parentDestroyed and slotWidgetDestructed from the list of "slots OK to fail to connect without complaining". (QObject::QObject): Initialize the destroyed signal.
  • kwq/qt/qguardedptr.h:
  • kwq/KWQGuardedPtr.mm:
  • kwq/KWQSignal.h:
  • kwq/KWQSlot.h: Rearrange includes so qobject.h can include KWQSignal.h.
  • kwq/KWQSignal.mm: Tweak.
  • kwq/KWQSlot.mm: Added support for the parentDestroyed slot in KJS::WindowQObject and the slotWidgetDestructed slot in khtml::RenderWidget.
10:08 AM Changeset in webkit [2206] by darin
  • 2 edits
    1 add in trunk/WebKit

Tools:

  • Scripts/extract-localizable-strings: Added.

WebFoundation:

  • English.lproj/StringsNotToBeLocalized.txt: Added.

WebKit:

  • English.lproj/StringsNotToBeLocalized.txt: Added.

WebBrowser:

  • English.lproj/StringsNotToBeLocalized.txt: Added.
9:26 AM Changeset in webkit [2205] by darin
  • 3 edits in trunk/WebKit
  • fixed crashing part of 3063517 -- crash loading .png in separate window
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView start]): Don't try to start if the NPP_New is 0. This indicates the the plugin hasn't been loaded.
8:49 AM Changeset in webkit [2204] by darin
  • 3 edits in trunk/WebKit
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setLoading:]): Remove extra quotes in use of ASSERT_ARG.

Sep 29, 2002:

10:03 PM Changeset in webkit [2203] by darin
  • 11 edits in trunk/WebKit

WebKit:

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): Don't be case sensitive about filename extensions.
  • Misc.subproj/WebDownloadHandler.m:
  • Misc.subproj/WebIconLoader.m:
  • Plugins.subproj/WebPluginStream.m:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebView.m: Don't use WebFoundation.h -- faster building to just import what we really use.

WebBrowser:

  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): Don't be case sensitive about filename extensions.
  • Preferences.subproj/SecurityPreferences.m: Don't use WebFoundation.h -- faster building to just import what we really use.
10:04 AM Changeset in webkit [2202] by cblu
  • 5 edits in trunk/WebKit

WebKit:

Fixed: 2978258 - quake3arena.com sends me to the flash=false site
The page has a flash plugin that once loaded, requests the flash=true page. If the plugin doesn't load, the meta refresh tag to the flash=false page fires after 3 seconds. This is how this site's flash detection works.

The reason this doesn't work for us is because the flash movie is at the bottom of the page. Plugins don't start until the initial drawRect. Since the movie is at the bottom of the page and out of site, the plugin never gets the drawRect and thus, never starts. We now start plug-ins when they are added to the window.

Fixed: 3062224 - context menu includes "Download Item to Disk" for mailto links

  • Fixed click then click and drag causes crash.
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView drawRect:]): don't start plug-in here (-[WebNetscapePluginView viewDidMoveToWindow]): start it here
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): don't provide "Download Link To Disk" and "Open Link In New Window" items for URLs we cant handle.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): clean-up (-[WebHTMLView mouseDragged:]): Don't allow drag if the frame has a provisional data source because this view may be released and the drag callbacks might reference this released view.

WebBrowser:

Fixed: 3062224 - context menu includes "Download Item to Disk" for mailto links

  • Added "Open With QuickTime Player" context menu for URLs ending with .mov.
  • Only show "Open With*" items for http URLs.
  • ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler openWithiTunes:]): (-[ContextMenuHandler openWithQuickTime:]):

Sep 28, 2002:

4:57 PM Changeset in webkit [2201] by darin
  • 6 edits in trunk/WebCore

Turn -Werror back on. There must have been some miscommunication
about the fat build; this was supposed to have been on.

  • WebCore.pbproj/project.pbxproj: Add -Werror back.
  • kwq/WebCoreHistory.h: Add missing method to fix warning.
  • kwq/KWQKHistoryProvider.mm: Tweak.
1:38 PM Changeset in webkit [2200] by darin
  • 6 edits in trunk/WebCore

Give the next fat build a better chance of working with the
new gcc without turning warnings off.

  • khtml/css/cssparser.cpp: Use a macro to disable inlining.
  • khtml/html/htmltokenizer.cpp: Ditto.
  • khtml/misc/htmlhashes.cpp: Ditto.
12:49 PM Changeset in webkit [2199] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Catch a request that we can't use here instead of failing later.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Added an assert so the failure was less confusing; good idea to leave it in.
12:35 PM Changeset in webkit [2198] by cblu
  • 4 edits in trunk/WebKit

Support for latest Flash plug-in. It requests a javascript URL for every plug-in instance. Until javascript URLs work, we return an error to the plug-in.

Fixed: 3035582 - flash animations don't work after upgrading flash
Fixed: 3021936 - links in flash at foggypetronasracing.com doesn't work

  • Plugins.subproj/WebPluginStream.h:
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): Make the request here and return nil if we can't create a handle with it. (-[WebNetscapePluginStream dealloc]): release the request (-[WebNetscapePluginStream startLoad]): use the request when creating the handle
1:06 AM Changeset in webkit [2197] by darin
  • 4 edits in trunk/WebCore
  • fixed 3022441 -- scroll bar is missing in window created with window.open
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): The checks for extra parameters to window.open were using isNull, which checks for a null ValueImp pointer, not an "Undefined".
12:39 AM Changeset in webkit [2196] by darin
  • 15 edits in trunk

WebCore:

  • fixed 2886111 -- changing font or size preference causes open windows to redraw incorrectly
  • khtml/rendering/render_table.cpp: (RenderTable::addColInfo): Fix logic about when a recalc of the minWidth and maxWidth is needed.

Fixed bug where changing the text size multiplier would cause the
window to redraw twice -- once with the text size changed, and then
later with the layout changed.

  • khtml/khtmlview.h: Added unscheduleRelayout.
  • khtml/khtmlview.cpp: (KHTMLView::unscheduleRelayout): Added.
  • kwq/KWQKHTMLPartImpl.h: Added forceLayout.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::forceLayout): Call both layout and unscheduleRelayout.
  • kwq/WebCoreBridge.h: Add setNeedsLayout.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge forceLayout]): Call KWQKHTMLPartImpl::forceLayout. (-[WebCoreBridge setTextSizeMultiplier:]): Call forceLayout.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsLayout]): Added.

Sep 27, 2002:

9:22 PM Changeset in webkit [2195] by cblu
  • 4 edits in trunk/WebKit

Fixed KJS crasher caused by nil plug-in returned from WebPlugin.
Got the RealPlayer plug-in loaded, nothing playing yet.

  • Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin getPluginInfo]): check for nil plug-in names/descriptions (-[WebNetscapePlugin stringByResolvingSymlinksAndAliasesInPath:]): new, resolves old-style aliases (-[WebNetscapePlugin initWithPath:]): call stringByResolvingSymlinksAndAliasesInPath
5:45 PM Changeset in webkit [2194] by darin
  • 4 edits in trunk/WebCore
  • khtml/rendering/render_table.cpp: (RenderTable::addColInfo): Fixed a > that should have been a < that prevented tables from changing sizes when table minimum widths changed.
5:16 PM Changeset in webkit [2193] by darin
  • 2 edits in trunk/WebKit/WebView.subproj
  • LocationChangeError.m: (-[LocationChangeHandler displayLocationChangeError:]): Add back the WebErrorCodeCancelled case.
4:44 PM Changeset in webkit [2192] by rjw
  • 4 edits in trunk/WebKit

i Fix 3058315: crash in WebHTMLRepresentation receivedData:withDataSource

​http://www.u2.com/lite/ does some whacky things with its framset's onLoad
handler. The fix ensures that data isn't sent to the bridge once
the bridge has been dealloced.

  • WebKit.pbproj/project.pbxproj: Nothing changed. PB dorkiness.
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation receivedData:withDataSource:]):

Fix related to 3058315.

  • LoadProgressMonitor.m: (-[LoadProgressMonitor receivedUpdateForKey:URLString:bytesLoaded:bytesExpected:error:dataSource:isComplete:]):
2:34 PM Changeset in webkit [2191] by darin
  • 9 edits in trunk/WebCore
  • fixed 2937198 -- Checkboxes and radiobuttons don't align with title control in forms
  • kwq/qt/qcheckbox.h: Add baselinePosition override.
  • kwq/KWQCheckBox.mm: Tweak the size constants. (QCheckBox::baselinePosition): Implement this. Line up baseline two pixels above the bottom, not at the bottom.
  • kwq/qt/qradiobutton.h: Add baselinePosition override.
  • kwq/KWQRadioButton.mm: Tweak the size constants. (QRadioButton::baselinePosition): Implement this. Line up baseline two pixels above the bottom, not at the bottom.
2:31 PM Changeset in webkit [2190] by cblu
  • 14 edits in trunk

WebCore:

WebPlugin clean up.

  • kwq/KWQKConfigBase.mm: (KConfig::readEntry):
  • kwq/WebCoreViewFactory.h:

WebKit:

Fixed: 3056559 - QT plugin doesn't load (claudius)
Fixed: 3042850 - Enable Java by default

Cleaned up WebPlugin and WebPluginDatabase.

  • Plugins.subproj/WebPlugin.h:
  • Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin openResourceFile]): (-[WebNetscapePlugin closeResourceFile:]): (-[WebNetscapePlugin stringForStringListID:andIndex:]): (-[WebNetscapePlugin getPluginInfo]): (-[WebNetscapePlugin initWithPath:]): (-[WebNetscapePlugin load]): (-[WebNetscapePlugin unload]): (-[WebNetscapePlugin MIMEToExtensionsDictionary]): (-[WebNetscapePlugin extensionToMIMEDictionary]): (-[WebNetscapePlugin MIMEToDescriptionDictionary]): (-[WebNetscapePlugin description]):
  • Plugins.subproj/WebPluginDatabase.h:
  • Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase pluginForMIMEType:]): (-[WebNetscapePluginDatabase pluginForExtension:]): (-[WebNetscapePluginDatabase pluginForFilename:]): (-[WebNetscapePluginDatabase MIMETypes]): (-[WebNetscapePluginDatabase init]):
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setDataSource:]):
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Enable Java by default
1:50 PM Changeset in webkit [2189] by rjw
  • 21 edits in trunk

WebBrowser no longer responsible for setting page title in history.

  • LocationChangeHandler.m: (-[LocationChangeHandler receivedPageTitle:forDataSource:]):

Fixed 3060158: REGRESSION: iframes added to session history
Also moved setting title in history to WebKit.

  • History.subproj/WebHistory.h:
  • History.subproj/WebHistory.m: (+[WebHistory sharedHistory]): (+[WebHistory webHistoryWithFile:]): (-[WebHistory addEntryForURL:]): (-[WebHistory addEntries:]):
  • History.subproj/WebHistoryPrivate.h:
  • History.subproj/WebHistoryPrivate.m:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURL]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

Fixed 3059237: Visited links do not appear in a different color on yahoo.com
Fixed 3051288: visited links are not colored in local files
Fixed 3060158: REGRESSION: iframes added to session history
Always use the canonical originally requested URL as the URL entered in history.

  • khtml/khtml_part.cpp: (KHTMLPart::begin):
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestedURLString):
  • kwq/KWQKHistoryProvider.mm:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreHistory.h:
12:40 PM Changeset in webkit [2188] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3058119, doctype of HTML docs should be null.

  • khtml/dom/dom_doc.cpp:
12:27 PM Changeset in webkit [2187] by hyatt
  • 4 edits in trunk/WebCore

DOM compliance. Fix for 3058100, hasFeature of HTML returns
false. Oops.

  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature):
11:35 AM Changeset in webkit [2186] by darin
  • 4 edits in trunk/WebCore
  • fixed 3060487 -- error connecting member slot to signal (KWQObject)
  • kwq/KWQObject.mm: (QObject::connect): Add slotShowDocument to the list of slots that we don't care about hooking up.
10:32 AM Changeset in webkit [2185] by cblu
  • 5 edits in trunk/WebKit

WebKit:

Added support for dragging links the the dock.
Created new pasteboard types WebURLPboardType WebURLNamePboardType that the dock requires.

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]): set WebURLPboardType and WebURLNamePboardType (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): use WebURLPboardType and WebURLNamePboardType
  • WebKit.exp: export WebURLPboardType and WebURLNamePboardType

WebBrowser:

Added support for dragging links the the dock.
Created new pasteboard types WebURLPboardType WebURLNamePboardType that the dock requires.

  • BrowserWebBookmarkExtras.m: (+[WebBookmark writeBookmarks:toPasteboard:withOwner:]): use WebURLPboardType and WebURLNamePboardType
10:27 AM Changeset in webkit [2184] by darin
  • 4 edits in trunk/JavaScriptCore
  • fixed 3033969 -- repro crash (infinite recursion in JavaScript) clicking on "screens" option at fsv.sf.net
  • kjs/object.h: Change recursion limit to 100 levels rather than 1000.
8:25 AM Changeset in webkit [2183] by cblu
  • 1 edit in trunk/WebKit/Misc.subproj/WebNSPasteboardExtras.m

* empty log message *

4:30 AM Changeset in webkit [2182] by mjs
  • 5 edits in trunk/WebKit

WebFoundation:

Put in place all the API changes needed for the "remember
password" feature and examining stored passwords. The actual
storing of passwords in Keychain is not implemented yet - that's
the next step.

  • AuthenticationManager.subproj/WebAuthenticatingResource.h: Added.
  • AuthenticationManager.subproj/WebAuthenticatingResource.m: Added. New class that's the data holder part of WebAuthenticationRequest, the part that describes the resource needing authentication. (-[WebAuthenticatingResourcePrivate dealloc]): (-[WebAuthenticatingResource initWithURL:realm:username:receivesCredentialSecurely:proxyHost:proxyType:]): (+[WebAuthenticatingResource resourceWithURL:realm:username:receivesCredentialSecurely:proxyHost:proxyType:]): (-[WebAuthenticatingResource init]): (-[WebAuthenticatingResource dealloc]): (-[WebAuthenticatingResource URL]): (-[WebAuthenticatingResource realm]): (-[WebAuthenticatingResource username]): (-[WebAuthenticatingResource receivesCredentialSecurely]): (-[WebAuthenticatingResource isProxy]): (-[WebAuthenticatingResource proxyHost]): (-[WebAuthenticatingResource proxyType]): (-[WebAuthenticatingResource copyWithZone:]):
  • AuthenticationManager.subproj/WebAuthenticationHandler.h:
  • AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationDispatchState dealloc]): (-[WebAuthenticationHandlerDispatcher _dispatchStartAuthentication:]): (-[WebAuthenticationHandlerDispatcher WebAuthenticationRequest:useCredential:]): (-[WebAuthenticationHandlerDispatcher _dispatchAuthenticationDone:]): (-[WebAuthenticationHandlerDispatcher startAuthentication:]):
  • AuthenticationManager.subproj/WebAuthenticationManager.h:
  • AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager removeCredentialForResource:]): (-[WebAuthenticationManager resourceCredentials]): (-[WebAuthenticationManager _invokeHandlersWithURL:realm:forRequest:withCallback:context:]): (-[WebAuthenticationManager _invokeHandlersWithURL:proxy:forRequest:withCallback:context:]): (-[WebAuthenticationManager _tryRequest:]): (-[WebAuthenticationManager WebAuthenticationRequest:useCredential:]):
  • AuthenticationManager.subproj/WebAuthenticationRequest.h:
  • AuthenticationManager.subproj/WebAuthenticationRequest.m: (-[WebAuthenticationRequestPrivate initWithResource:previousFailureCount:delegate:]): (-[WebAuthenticationRequestPrivate dealloc]): (-[WebAuthenticationRequest _initWithResource:previousFailureCount:delegate:]): Change to init with a WebAuthenticatingResource rather than passing all the data. (-[WebAuthenticationRequest _authenticationHandlerBusy]): (-[WebAuthenticationRequest resource]): New method (-[WebAuthenticationRequest previousFailureCount]): Renamed from previousFailures (-[WebAuthenticationRequest useCredential:]): Renamed from authenticationDone: (-[WebAuthenticationRequest cancel]): Removed to fix in-band signalling
  • AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
  • AuthenticationManager.subproj/WebAuthenticationResult.m: Removed.
  • AuthenticationManager.subproj/WebCredential.h: Added.
  • AuthenticationManager.subproj/WebCredential.m: Added. Renamed from WebAuthenticationResult. (-[WebCredentialPrivate dealloc]): (-[WebCredential initWithUsername:password:remembered:]): Add remembered: parameter (+[WebCredential credentialWithUsername:password:remembered:]): Likewise (-[WebCredential dealloc]): (-[WebCredential username]): (-[WebCredential password]): (-[WebCredential remembered]): New method (-[WebCredential copyWithZone:]):
  • Misc.subproj/WebFoundation.h:
  • WebFoundation.exp: Fix exports.
  • WebFoundation.pbproj/project.pbxproj: Add new files, remove removed ones.

Mechanical fixes to get C glue to compile:

  • AuthenticationManager.subproj/IFAuthenticationHandlerC.m: (-[IFCallBackAuthenticationHandler isReadyToStartAuthentication:]):
  • AuthenticationManager.subproj/IFAuthenticationRequestC.m: (IFAuthenticationRequestCopyURL): (IFAuthenticationRequestCopyRealm): (IFAuthenticationRequestCopyUsername): (IFAuthenticationRequestWillPasswordBeSentInClear): (IFAuthenticationRequestGetPreviousFailures): (IFAuthenticationRequestIsForProxy): (IFAuthenticationRequestCopyProxyHost): (IFAuthenticationRequestCopyProxyType): (IFAuthenticationRequestDone):
  • AuthenticationManager.subproj/IFAuthenticationResultC.m: (IFAuthenticationResultCreate): (IFAuthenticationResultCopyUsername): (IFAuthenticationResultCopyPassword):

WebKit:

  • Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): (-[WebAuthenticationPanel runAsModalDialogWithRequest:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
  • Panels.subproj/WebPanelAuthenticationHandler.h:
  • Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler isReadyToStartAuthentication:]): (-[WebPanelAuthenticationHandler startAuthentication:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithRequest:result:]):

Sep 26, 2002:

8:25 PM Changeset in webkit [2181] by darin
  • 4 edits in trunk/WebCore
  • fixed 2953256 -- JavaScript window.moveTo() and window.moveBy() methods do not work
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry): Fix calculation. It was returning the bottom left coordinate instead of the top left.
8:06 PM Changeset in webkit [2180] by darin
  • 12 edits in trunk/WebCore
  • fixed 3060459 -- REGRESSION: crash leaving page that sets cookie in JavaScript unload handler
  • khtml/khtml_part.cpp: (KHTMLPart::begin): Call updatePolicyBaseURL to set the "policy base URL" on the documents so the cookie can be based on the URL of the main document.
  • khtml/dom/html_document.h: Add setPolicyBaseURL.
  • khtml/dom/html_document.cpp: (HTMLDocument::setPolicyBaseURL): Call the impl.
  • khtml/html/html_documentimpl.h: Add policyBaseURL, setPolicyBaseURL.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::setCookie): Pass the base URL that's stored here instead of getting at the part through the view, since the view will be 0 during the unload event.
  • kwq/KWQKHTMLPartImpl.h: Add updatePolicyBaseURL and setPolicyBaseURL.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::updatePolicyBaseURL): Set the base URL based on the URL if this is the topmost part, based on the parent's policy base URL if this is not the topmost part. (KWQKHTMLPartImpl::setPolicyBaseURL): Change the policy base URL for this part and all the subparts.
5:45 PM Changeset in webkit [2179] by darin
  • 18 edits in trunk

Tools:

  • HotSpotFinder/HotSpotFinder.pbproj/project.pbxproj: File encodings.

WebCore:

  • kwq/WebCoreBridge.h: Use NSString for encoding name, not CFStringEncoding.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge addData:withOverrideEncoding:]): Ditto.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Use NSString for encoding.
  • WebView.subproj/WebController.h: Update names to use separate boolean for user agent and strings for text encodings instead of CFStringEncoding.
  • WebView.subproj/WebController.m: (-[WebController setCustomUserAgent:]): Name change. (-[WebController resetUserAgent]): Added. (-[WebController hasCustomUserAgent]): Added. (-[WebController customUserAgent]): Name change. (-[WebController setCustomTextEncodingName:]): Take NSString. (-[WebController resetTextEncoding]): Update for NSString. (-[WebController _mainFrameOverrideEncoding]): Ditto. (-[WebController hasCustomTextEncoding]): Ditto. (-[WebController customTextEncodingName]): Return NSString.
  • WebView.subproj/WebDataSourcePrivate.h: Use NSString instead of CFStringEncoding.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): No need to init. (-[WebDataSource _setContentType:]): Copy, don't retain. (-[WebDataSource _setEncoding:]): Copy, don't retain. (-[WebDataSource _setOverrideEncoding:]): Use NSString. (-[WebDataSource _overrideEncoding]): Use NSString.
  • WebView.subproj/WebFramePrivate.h: Use NSString.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): Use NSString.
  • WebView.subproj/WebPreferences.h: Use NSString instead of CFStringEncoding.
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Use NSString. (-[WebPreferences defaultTextEncodingName]): Use NSString. (-[WebPreferences setDefaultTextEncodingName:]): Use NSString.

WebBrowser:

  • AppController.m: (-[AppController updateTextEncodingMenu]): Convert to CFStringEncoding.
  • BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Convert to CFStringEncoding. (-[BrowserWindowController changeTextEncoding:]): Convert to NSString.
  • Debug/DebugUtilities.m: (-[BrowserDocument setUserAgent:]): Update for API change. (-[BrowserDocument validate_setUserAgent:]): Ditto. (-[BrowserDocument resetUserAgent:]): Ditto. (-[BrowserDocument validate_resetUserAgent:]): Ditto.
  • Preferences.subproj/TextPreferences.m: (-[TextPreferences updateDefaultCharacterSetPopup]): Convert to CFStringEncoding. (-[TextPreferences takeDefaultCharacterSetFrom:]): Convert to NSString.
3:37 PM Changeset in webkit [2178] by cblu
  • 3 edits in trunk/WebKit

WebKit:

Made WebTextView super-private.

  • WebKit.pbproj/project.pbxproj:

WebBrowser:

  • Made the view source window
    • larger
    • use Monaco, 10 font
    • respond to makeTextLarger and makeTextSmaller
    • use saveDocumentAs

Fixed: 3053366 - source window should have file proxy after save

  • BrowserDocument.h:
  • BrowserDocument.m:
  • English.lproj/HTMLSource.nib: made window larger, use WebSearchableTextView
  • HTMLSourceController.h:
  • HTMLSourceController.m: (-[HTMLSourceController windowDidLoad]): set the text multiplier (-[HTMLSourceController setTextSizeMultiplier:]): new (-[HTMLSourceController textSizeMultiplier]): new
  • HTMLSourceDocument.h:
  • HTMLSourceDocument.m: (-[HTMLSourceDocument dataRepresentationOfType:]): new saved flag (-[HTMLSourceDocument saveDocumentTo:]): call saveDocumentAs (-[HTMLSourceDocument displayName]): perform hacks to get window title and saved filename correct (-[HTMLSourceDocument controller]): new (-[HTMLSourceDocument browserDocumentLoadingFinished:]): don't update after save (-[HTMLSourceDocument canMakeTextLarger]): new (-[HTMLSourceDocument canMakeTextSmaller]): new (-[HTMLSourceDocument makeTextLarger:]): new (-[HTMLSourceDocument makeTextSmaller:]): new (-[HTMLSourceDocument validateUserInterfaceItem:]): new
3:11 PM Changeset in webkit [2177] by rjw
  • 3 edits in trunk/WebKit

i Use a rectangle with rounded corners for dragged label.

Put a subtle shadow behind text in label.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):
12:07 PM Changeset in webkit [2176] by cblu
  • 15 edits
    2 adds in trunk

WebCore:

Added WebCoreElementImageLocationKey to the element dictionary.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

WebKit:

  • When dragging an image, use the image itself for the drag image
  • Support promised file and image data drag types for dragged images.
  • Misc.subproj/WebNSImageExtras.h: Added.
  • Misc.subproj/WebNSImageExtras.m: Added. (-[NSImage _web_scaleToMaxSize:]): new, scales an image is greater than max (-[NSImage _web_dissolveToFraction:]): new, dissolves image in place
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.h: Added WebElementImageLocationKey to the element dictionary
  • WebView.subproj/WebController.m: ditto
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): subclassed for only for image drags (-[WebHTMLView mouseDragged:]): use the promised file api again. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): use the retained element dictionary instead of the dragged URL which I deleted.
  • WebView.subproj/WebHTMLViewPrivate.h:
10:20 AM Changeset in webkit [2175]
  • 3 copies in tags/Alexander-25

This commit was manufactured by cvs2svn to create tag 'Alexander-25'.

10:20 AM Changeset in webkit [2174] by sheridan
  • 8 edits in trunk

Alex-25 versions + markers

8:20 AM Changeset in webkit [2173] by darin
  • 5 edits in trunk/JavaScriptCore

Fix the infinity problem Dave worked around. We didn't have the
configuration flags set right to make infinity work. Setting those
properly made everything work without changes to min and max.

  • kjs/config.h: Define HAVE_FUNC_ISINF, HAVE_STRING_H, and also WORDS_BIGENDIAN (if on ppc).
  • kjs/math_object.cpp: (MathFuncImp::call): Roll out min and max changes from yesterday.
Note: See TracTimeline for information about the timeline view.