Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 1, 2002:

5:21 PM Changeset in webkit [2222] by sullivan

• 4 edits in trunk/WebKit

WebKit:

• WebKit.exp: added .objc_class_name_WebTextRendererFactory so I could use it from WebBrowser.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:referrer:]): Just changed whitespace so the .exp change would be built.

WebBrowser:

• finished implementing the "etched text" look in the status bar. I had to do some Cocoa API trickery to access WebTextRenderer stuff in order to make it fast; I'll get this cleaned up soon. (Note that this makes a 1-2% speedup in cvs-base)

• BrowserWindowController.h: remove statusField outlet; we always use statusStringView now

• BrowserWindowController.m: (-[BrowserWindowController clearStatus]): remove statusField (-[BrowserWindowController setStatus:]): always use statusStringView

• PreferenceKeys.h: eliminate preference key for etched text
• Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Remove menu item to toggle etched text

• English.lproj/Browser.nib: reposition string view slightly

• EtchedStringView.m: (+[EtchedStringView textRenderer]): new method, get (and lazily create) WebTextRenderer used to draw all status bar strings. (+[EtchedStringView lightColor]): new method, get (and lazily create) the whitish color (+[EtchedStringView darkColor]): new method, get (and lazily create) the blackish color (-[EtchedStringView drawRect:]): use WebTextRenderer drawing code.

Also removed some old methods used by the AppKit drawing code.

3:42 PM Changeset in webkit [2221] by cblu

• 3 edits in trunk/WebKit

Fixed build breakage.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setWindow]):

3:28 PM Changeset in webkit [2220] by darin

• 4 edits in trunk/WebCore

• fixed 3055076 -- window.scroll does a window.scrollby, not a window.scrollto

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Moved a case so that the scroll code would scroll to, not by.

3:25 PM Changeset in webkit [2219] by kocienda

• 7 edits in trunk/WebKit

WebFoundation:

Implemented WebResourceRequest "category" design for extending a
request with protocol-specific data.

• CacheLoader.subproj/IFHTTPURLHandleC.m: Now imports WebHTTPResourceRequest.h.
• CacheLoader.subproj/WebProtocolHandler.h: Added partOfRequest:withClass:createIfDoesNotExist: method.
• CacheLoader.subproj/WebProtocolHandler.m: (+[WebProtocolHandler partOfRequest:withClass:createIfDoesNotExist:]):
• CacheLoader.subproj/WebResourceLoad.m: Now imports WebHTTPResourceRequest.h.
• CacheLoader.subproj/WebResourceLoadManager.m: Ditto.
• CacheLoader.subproj/WebResourceRequest.h: Removed HTTP-protocol-specific fields and methods.
• CacheLoader.subproj/WebResourceRequest.m: Ditto. (-[WebResourceRequest initWithURL:]): Deal with fact that HTTP-protocol-specific fields and methods have been removed. (-[WebResourceRequest copyWithZone:]): Ditto. Copy protocol-specific parts. (-[WebResourceRequest copyWithURL:]): Ditto. Ditto. :) (-[WebResourceRequest _partWithClass:createIfDoesNotExist:]): Added implementation. (-[WebResourceRequest dealloc]): Deal with fact that HTTP-protocol-specific fields and methods have been removed.
• CacheLoader.subproj/WebResourceRequestPrivate.h: Added.
• Misc.subproj/WebFoundation.h: Now imports WebHTTPResourceRequest.h.
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: Now imports WebHTTPResourceRequest.h.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: Ditto.
• ProtocolHandlers.subproj/WebHTTPResourceRequest.h: Added.
• ProtocolHandlers.subproj/WebHTTPResourceRequest.m: Added.
• ProtocolHandlers.subproj/WebHTTPResourceRequestParameters.h: Added.
• ProtocolHandlers.subproj/WebHTTPResourceRequestParameters.m: Added.
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: Now imports WebHTTPResourceRequest.h.
• WebFoundation.pbproj/project.pbxproj

WebKit:

Implemented WebResourceRequest "category" design for extending a
request with protocol-specific data.

• WebCoreSupport.subproj/WebBridge.m: Now imports WebHTTPResourceRequest.h.
• WebCoreSupport.subproj/WebSubresourceClient.m: Ditto.
• WebView.subproj/WebMainResourceClient.m: Ditto.

WebBrowser:

• BrowserDocument.m: Now imports WebHTTPResourceRequest.h to get at protocol-specific request information.

2:49 PM Changeset in webkit [2218] by cblu

• 3 edits in trunk/WebKit

• Added debug drawing
• removed unnecessary ifdef'ing.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView menuForEvent:]): (-[WebBaseNetscapePluginView setWindow]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView drawRect:]):

10:49 AM Changeset in webkit [2217] by kocienda

• 6 edits in trunk/WebKit

WebFoundation:

Reorganization of code in WebResourceResponse. This moves the code to the
point where the next change will be to break out HTTP-specific response
information into its own subclass.

• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]): Call protocol handler to get the right class for the response. (-[WebResourceLoad succeeded]):
• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): (-[WebResourceResponse initWithCoder:]): (-[WebResourceResponse encodeWithCoder:]): (-[WebResourceResponse textEncodingName]): Changed name from characterSet. (-[WebResourceResponse userAgent]): (-[WebResourceResponse headers]): (-[WebResourceResponse resultCode]): (-[WebResourceResponse _resourceData]): (-[WebResourceResponse _setTextEncodingName:]): Changed name from _setCharacterSet:. (-[WebResourceResponse _takePersistentValuesFrom:]): (-[WebResourceResponse dealloc]):
• CacheLoader.subproj/WebResourceResponsePrivate.h:
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler setResponseMetadata:]):

WebKit:

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]): Fixed Development build breakage. Call to [response statusCode] now calls the handle's private method to get the status code.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]): Ditto. (-[WebMainResourceClient handle:didReceiveData:]): Calls new textEncodingName method, replacing call to characterSet.

10:12 AM Changeset in webkit [2216] by kocienda

• 3 edits in trunk/WebKit

WebFoundation:

This change focuses on "status codes". Status codes are an enum that describe
the state of a handle's load (e.g. loading, finished, cancelled).

Removed status code from WebResourceResponse, and moved it to WebResourceHandle.
The status code is now available as private API on WebResourceHandle. This
change made it possible to make some nice cleanups and simplifications.

The great majority of these changes merely move the method calls from the old
design of calling WebResourceResponse to access the status code to calling
the WebResourceHandle to get the status code.

• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/WebCacheLoaderConstants.h:
• CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle sendSynchronousRequest:]) (-[WebResourceHandle initWithRequest:]) (-[WebResourceHandle loadWithDelegate:]) (-[WebResourceHandle cancel])
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandlePrivate.h:
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _didReceiveResponseMetadata:]) (-[WebResourceHandle _didLoadData:]) (-[WebResourceHandle _backgroundLoadComplete]) (-[WebResourceHandle _backgroundLoadFailed]) (-[WebResourceHandle _didRedirectToURL:]) (-[WebResourceHandle _load]) (-[WebResourceHandle _statusCode]) (-[WebResourceHandle _setStatusCode:])
• CacheLoader.subproj/WebResourceLoad.h:
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad cancel]) (-[WebResourceLoad isCancelled]) (-[WebResourceLoad succeeded]) (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]) (-[WebResourceLoad addHandle:]) (-[WebResourceLoad _beginLoad]) (_loadThrottler)
• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse _setResourceData:])
• CacheLoader.subproj/WebResourceResponsePrivate.h:

WebKit:

• WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress initWithResourceHandle:]): Status code moved from WebResourceResponse to WebResourceHandle private API.

9:17 AM Changeset in webkit [2215] by kocienda

• 8 edits in trunk/WebKit

WebFoundation:

Changed WebResourceHandle so that the init method no longer starts the
loading of the request to begin. Added new loadWithDelegate: method which
is called separatetly from the init method, to start loads.

• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle initWithRequest:]) (-[WebResourceHandle loadWithDelegate:])
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m:
• CacheLoader.subproj/WebResourceSynchronousDelegate.m: (-[WebResourceHandleSynchronousDelegate run:])

WebKit:

Changed WebResourceHandle so that the init method no longer starts the
loading of the request to begin. Added new loadWithDelegate: method which
is called separatetly from the init method, to start loads.

All of the changes here update code that depends on WebResourceHandle. The
changes move the code to the modified API.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad])
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:])
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:])
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading])

8:41 AM Changeset in webkit [2214] by cblu

• 20 edits in trunk/WebKit

Fixed copyright comments.

• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
• Plugins.subproj/WebNetscapePluginDocumentView.h:
• Plugins.subproj/WebNetscapePluginDocumentView.m:
• Plugins.subproj/WebNetscapePluginEmbeddedView.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m:
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m:
• Plugins.subproj/WebPlugin.h:
• Plugins.subproj/WebPlugin.m:
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m:
• Plugins.subproj/WebPluginNullEventSender.h:
• Plugins.subproj/WebPluginNullEventSender.m:
• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m:
• Plugins.subproj/npapi.h:
• Plugins.subproj/npapi.m:

7:38 AM Changeset in webkit [2213] by kocienda

• 19 edits in trunk/WebKit

WebFoundation:

Big set of changes to move the code closer to the proposed WebFoundation API. Major work includes:

• Implemented new callbacks for WebResourceHandleDelegate. All delegates of WebResourceHandle were updated to reflect this change.

• Modified the way WebProtocolHandler creates protocol-specific responses.

• Move WebResourceHandle API much closer to the final proposal. The public API on this class is very thin now. Some private methods are still available to code inside Intrigue (to ease the transition), and the dependencies on these private methods will be reduced over time.

• WebResourceRequest and WebResourceResponse classes are now closer to their proposed APIs, but work remains to be done with them.

• Synchronous loading code received a large rewrite.

And an extra:

• Sped up implementation of file protocol handler. This protocol handler no longer kicks a thread for each file load.

• CacheLoader.subproj/IFHTTPURLHandleC.h:
• CacheLoader.subproj/IFHTTPURLHandleC.m: (IFHTTPURLHandleGetRequestMethod) (IFHTTPURLHandleGetRequestHeaders)
• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode) (IFURLHandleGetURL) (IFURLHandleGetCanonicalURL) (IFURLHandleGetStatusCode) (IFURLHandleGetResultCode) (IFURLHandleGetContentType) (IFURLHandleGetError) (IFURLHandleGetContentLength) (IFURLHandleGetContentLengthReceived) (IFURLHandleGetPercentComplete)
• CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCache _truncateToSizeLimit])
• CacheLoader.subproj/WebProtocolHandler.h:
• CacheLoader.subproj/WebProtocolHandler.m: (-[WebProtocolHandler responseClass]) (-[WebProtocolHandler responseMetadataAvailable]) (-[WebProtocolHandler setResponseMetadata:])
• CacheLoader.subproj/WebResourceCallbackClient.m: (-[WebResourceCallbackClient handle:willSendRequest:]) (-[WebResourceCallbackClient handle:didReceiveResponse:])
• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle sendSynchronousRequest:]) (-[WebResourceHandle initWithRequest:delegate:])
• CacheLoader.subproj/WebResourceHandleDelegate.h:
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables prepareCallbacks]) (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _loadInBackground]) (-[WebResourceHandle _sendCallbacks]) (-[WebResourceHandle _notifyClientWillSendRequest]) (-[WebResourceHandle _notifyClientDidReceiveResponse]) (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]) (-[WebResourceHandle _notifyClientDidFailLoading]) (-[WebResourceHandle _notifyClientDidFinishLoading])
• CacheLoader.subproj/WebResourceHandlePrivate.h:
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _didReceiveResponseMetadata:]) (-[WebResourceHandle _backgroundLoadComplete]) (-[WebResourceHandle _backgroundLoadFailed]) (-[WebResourceHandle _didRedirectToURL:]) (-[WebResourceHandle _request]) (-[WebResourceHandle _response]) (-[WebResourceHandle _redirectedURL])
• CacheLoader.subproj/WebResourceLoad.h:
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]) (-[WebResourceLoad didLoadBytes:length:]) (-[WebResourceLoad succeeded]) (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]) (-[WebResourceLoad addHandle:]) (-[WebResourceLoad cacheObjectCheckingRedirects:]) (-[WebResourceLoad didRedirectToURL:permanent:]) (-[WebResourceLoad originalRequest]) (-[WebResourceLoad _beginLoad]) (-[WebResourceLoad _cacheKey]) (-[WebResourceLoad description]) (-[WebResourceLoad dealloc])
• CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]) (+[WebResourceLoadKey keyWithLoad:]) (-[WebResourceLoadKey hash]) (-[WebResourceLoadManager requestWithURLHandle:])
• CacheLoader.subproj/WebResourceLoadQueue.m: (-[WebResourceLoadQueue put:])
• CacheLoader.subproj/WebResourceRequest.h:
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]) (-[WebResourceRequest canonicalURL]) (-[WebResourceRequest protocolHandlerClass]) (-[WebResourceRequest copyWithZone:]) (-[WebResourceRequest copyWithURL:])
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse contentType])
• CacheLoader.subproj/WebResourceSynchronousClient.h:
• CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate initWithRequest:monitor:]) (-[WebResourceHandleSynchronousDelegate dealloc]) (-[WebResourceHandleSynchronousDelegate run:]) (-[WebResourceHandleSynchronousDelegate started]) (-[WebResourceHandleSynchronousDelegate handle]) (-[WebResourceHandleSynchronousDelegate response]) (-[WebResourceHandleSynchronousDelegate result]) (-[WebResourceHandleSynchronousDelegate handle:willSendRequest:]) (-[WebResourceHandleSynchronousDelegate handleDidFinishLoading:]) (-[WebResourceHandleSynchronousDelegate handle:didReceiveResponse:]) (-[WebResourceHandleSynchronousDelegate handle:didReceiveData:])
• Misc.subproj/WebFoundation.h:
• Misc.subproj/WebFoundationLogging.h:
• Misc.subproj/WebFoundationLogging.m:
• Misc.subproj/WebNSStringExtras.m: (-[NSString _web_isCaseInsensitiveEqualToString:]
• ProtocolHandlers.subproj/WebAboutProtocolHandler.h:
• ProtocolHandlers.subproj/WebAboutProtocolHandler.m: (-[WebAboutProtocolHandler beginLoad]) (-[WebAboutProtocolHandler responseClass]) (-[WebAboutProtocolHandler responseMetadataAvailable]) (-[WebAboutProtocolHandler setResponseMetadata:])
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addAuthenticationHeaders:andCall:]) (-[WebCFNetworkHTTPProtocolHandler continueAfterBytesAvailable]) (-[WebCFNetworkHTTPProtocolHandler handleReadStreamEvent:event:]) (-[WebCFNetworkHTTPProtocolHandler performHTTPHeaderRead:andCall:])
• ProtocolHandlers.subproj/WebFileProtocolHandler.h:
• ProtocolHandlers.subproj/WebFileProtocolHandler.m: (-[WebFileProtocolHandler initWithResourceLoad:]) (-[WebFileProtocolHandler dealloc]) (-[WebFileProtocolHandler didLoadData:]) (-[WebFileProtocolHandler beginLoad]) (-[WebFileProtocolHandler endLoad]) (-[WebFileProtocolHandler responseClass]) (-[WebFileProtocolHandler responseMetadataAvailable]) (-[WebFileProtocolHandler setResponseMetadata:])
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler responseClass]) (-[WebHTTPProtocolHandler responseMetadataAvailable]) (-[WebHTTPProtocolHandler setResponseMetadata:]) (-[WebHTTPProtocolHandler shouldCacheResponse:]) (-[WebHTTPProtocolHandler URL]) (-[WebHTTPProtocolHandler retryWithRedirectedURLAndResultCode:])
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler createHTTPRequest]) (-[WebSimpleHTTPProtocolHandler _examineHeaders])
• WebFoundation.exp
• WebFoundation.pbproj/project.pbxproj

WebKit:

Many changes to coincide with API work in WebFoundation. Most of the modifications
here have to do with changes for the new callback scheme.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader handleDidFinishLoading:]) (-[WebIconLoader handle:willSendRequest:]): New method. A no-op here. (-[WebIconLoader handle:didReceiveResponse:]): Ditto.
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView stop]): Fix for Deployment build breakage.
• Plugins.subproj/WebPluginStream.h: Add response ivar.
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad]): Tweak method name for new API. (-[WebNetscapePluginStream receivedData:withHandle:]): (-[WebNetscapePluginStream handle:willSendRequest:]): New method. Replaces old redirect callback. (-[WebNetscapePluginStream handle:didReceiveResponse:]): New method. Set the response ivar.
• WebCoreSupport.subproj/WebSubresourceClient.h: Add response ivar.
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient dealloc]): Release response ivar. (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Set the request user agent here. (-[WebSubresourceClient handle:willSendRequest:]): New method. Handle like a redirect. (-[WebSubresourceClient handle:didReceiveResponse:]): New method. Set the response ivar. (-[WebSubresourceClient handle:didReceiveData:]): Tweaks for new WebFoundation API and method names. (-[WebSubresourceClient handleDidFinishLoading:]): Ditto. (-[WebSubresourceClient handle:didFailLoadingWithError:]): Ditto.
• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Ditto.
• WebView.subproj/WebDataSourcePrivate.h: Add _setRequest method.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Call didStartLoadingWithURL with request URL instead of handle URL. (-[WebDataSource _setRequest:]): Add implementation.
• WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress initWithResourceHandle:]): Tweaks for new WebFoundation API and method names.
• WebView.subproj/WebMainResourceClient.h: Add response ivar.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): Set user agent on request here. (-[WebMainResourceClient dealloc]): Release response ivar. (-[WebMainResourceClient didCancelWithHandle:]): Tweaks for new WebFoundation API and method names. (-[WebMainResourceClient handleDidFinishLoading:]): Tweaks for new WebFoundation API and method names. (-[WebMainResourceClient handle:willSendRequest:]): New method. Handle like a redirect. (-[WebMainResourceClient handle:didReceiveResponse:]): New method. Set the response ivar. (-[WebMainResourceClient handle:didReceiveData:]): Tweaks for new WebFoundation API and method names. (-[WebMainResourceClient handle:didFailLoadingWithError:]): Ditto.

WebBrowser:

Updated a couple methods to reflect changes in WebFoundation API names.

• BrowserWebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]): Call for the URL on the handles response instead of the URL of the handle itself. (-[BrowserWebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): Ditto.
• DownloadMonitor.m: (-[DownloadMonitor receivedError:forResourceHandle:partialProgress:fromDataSource:]): Request accessor for handle is now private; reflect that in method name (i.e. add an underscore).

Sep 30, 2002:

10:30 PM Changeset in webkit [2212] by cblu

• 11 edits
  7 adds
  3 deletes in trunk/WebKit

A ton o' plugin view clean-up and arch changes. Turned WebPluginView into WebBaseNetscapePluginView. New classes WebNetscapePluginEmbeddedView and WebNetscapePluginDocumentView are subclasses of WebBaseNetscapePluginView. WebNetscapePluginDocumentView handles non-HTML plug-in content and WebNetscapePluginEmbeddedView is the WebHTMLView subview.

Found that we leak the world on complex pages with plug-ins such as macromedia.com and marvel.com when closing the window. Still need to figure this out.

• Plugins.subproj/WebBaseNetscapePluginView.h: Added.
• Plugins.subproj/WebBaseNetscapePluginView.m: Added. (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView modifiersForEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView keyMessageForEvent:]): (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (-[WebBaseNetscapePluginView acceptsFirstResponder]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView isInResponderChain]): (-[WebBaseNetscapePluginView performKeyEquivalent:]): (-[WebBaseNetscapePluginView menuForEvent:]): (-[WebBaseNetscapePluginView setUpWindowAndPort]): (-[WebBaseNetscapePluginView setWindow]): (-[WebBaseNetscapePluginView removeTrackingRect]): (-[WebBaseNetscapePluginView resetTrackingRect]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView webFrame]): (-[WebBaseNetscapePluginView controller]): (-[WebBaseNetscapePluginView plugin]): (-[WebBaseNetscapePluginView setMIMEType:]): (-[WebBaseNetscapePluginView setBaseURL:]): (-[WebBaseNetscapePluginView setArguments:]): (-[WebBaseNetscapePluginView setMode:]): (-[WebBaseNetscapePluginView initWithFrame:]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView isFlipped]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewHasMoved:]): (-[WebBaseNetscapePluginView windowWillClose:]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView defaultsHaveChanged:]): (-[WebBaseNetscapePluginView frameStateChanged:]): (-[WebBaseNetscapePluginView pluginInstance]): (-[WebBaseNetscapePluginView pluginURLFromCString:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): (-[WebBaseNetscapePluginView getURL:target:]): (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): (-[WebBaseNetscapePluginView newStream:target:stream:]): (-[WebBaseNetscapePluginView write:len:buffer:]): (-[WebBaseNetscapePluginView destroyStream:reason:]): (-[WebBaseNetscapePluginView status:]): (-[WebBaseNetscapePluginView invalidateRect:]): (-[WebBaseNetscapePluginView invalidateRegion:]): (-[WebBaseNetscapePluginView forceRedraw]):
• Plugins.subproj/WebBaseNetscapePluginViewPrivate.h: Added.
• Plugins.subproj/WebNetscapePluginDocumentView.h: Added.
• Plugins.subproj/WebNetscapePluginDocumentView.m: Added. (-[WebNetscapePluginDocumentView initWithFrame:]): (-[WebNetscapePluginDocumentView dealloc]): (-[WebNetscapePluginDocumentView drawRect:]): (-[WebNetscapePluginDocumentView dataSource]): (-[WebNetscapePluginDocumentView setDataSource:]): (-[WebNetscapePluginDocumentView dataSourceUpdated:]): (-[WebNetscapePluginDocumentView setNeedsLayout:]): (-[WebNetscapePluginDocumentView layout]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.h: Added.
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: Added. (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:arguments:]): (-[WebNetscapePluginEmbeddedView dealloc]): (-[WebNetscapePluginEmbeddedView viewDidMoveToWindow]): (-[WebNetscapePluginEmbeddedView start]): (-[WebNetscapePluginEmbeddedView dataSource]):
• Plugins.subproj/WebNetscapePluginViewPrivate.h: Removed.
• Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase init]):
• Plugins.subproj/WebPluginNullEventSender.h:
• Plugins.subproj/WebPluginNullEventSender.m: (-[WebNetscapePluginNullEventSender initWithPluginView:]): (-[WebNetscapePluginNullEventSender sendNullEvents]):
• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream getFunctionPointersFromPluginView:]): (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream startLoad]): (-[WebNetscapePluginStream receivedData:withDataSource:]): (-[WebNetscapePluginStream handleWillUseUserAgent:forURL:]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream cancel]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]): (-[WebNetscapePluginStream handleDidRedirect:toURL:]):
• Plugins.subproj/WebPluginView.h: Removed.
• Plugins.subproj/WebPluginView.m: Removed.
• Plugins.subproj/npapi.m: (NPN_GetURLNotify): (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_Status): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebHTMLViewPrivate.m: (-[NSView _web_stopIfPluginView]):

2:39 PM Changeset in webkit [2211] by hyatt

• 4 edits in trunk/WebCore

Fix the case sensitivity problem with attribute names
in HTML. They are now lower-cased when being queried
from the DOM. Bug 3058145.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::attrName):

1:25 PM Changeset in webkit [2210] by hyatt

• 4 edits in trunk/WebCore

Make sure to keep the fix checked in for 1.18. That fix is
good.

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo):

1:03 PM Changeset in webkit [2209] by hyatt

• 4 edits in trunk/WebCore

Backing out change to render_table.cpp. The original logic
(in version 1.16) is correct.

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo):

11:09 AM Changeset in webkit [2208] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Remove the ill-advised "don't even create a WebDataSource if WebResourceHandle can't handle this request" code.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Rearrange checks so we won't get confused if we can't create a handle.

10:52 AM Changeset in webkit [2207] by darin

• 13 edits in trunk/WebCore

• kwq/qt/qobject.h: Add the destroyed signal.
• kwq/KWQObject.mm: (QObject::connect): Remove names of parentDestroyed and slotWidgetDestructed from the list of "slots OK to fail to connect without complaining". (QObject::QObject): Initialize the destroyed signal.

• kwq/qt/qguardedptr.h:
• kwq/KWQGuardedPtr.mm:
• kwq/KWQSignal.h:
• kwq/KWQSlot.h: Rearrange includes so qobject.h can include KWQSignal.h.

• kwq/KWQSignal.mm: Tweak.

• kwq/KWQSlot.mm: Added support for the parentDestroyed slot in KJS::WindowQObject and the slotWidgetDestructed slot in khtml::RenderWidget.

10:08 AM Changeset in webkit [2206] by darin

• 2 edits
  1 add in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Added.

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Added.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Added.

WebBrowser:

• English.lproj/StringsNotToBeLocalized.txt: Added.

9:26 AM Changeset in webkit [2205] by darin

• 3 edits in trunk/WebKit

• fixed crashing part of 3063517 -- crash loading .png in separate window

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView start]): Don't try to start if the NPP_New is 0. This indicates the the plugin hasn't been loaded.

8:49 AM Changeset in webkit [2204] by darin

• 3 edits in trunk/WebKit

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setLoading:]): Remove extra quotes in use of ASSERT_ARG.

Sep 29, 2002:

10:03 PM Changeset in webkit [2203] by darin

• 11 edits in trunk/WebKit

WebKit:

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): Don't be case sensitive about filename extensions.

• Misc.subproj/WebDownloadHandler.m:
• Misc.subproj/WebIconLoader.m:
• Plugins.subproj/WebPluginStream.m:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDefaultContextMenuDelegate.m:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebView.m: Don't use WebFoundation.h -- faster building to just import what we really use.

WebBrowser:

• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): Don't be case sensitive about filename extensions.

• Preferences.subproj/SecurityPreferences.m: Don't use WebFoundation.h -- faster building to just import what we really use.

10:04 AM Changeset in webkit [2202] by cblu

• 5 edits in trunk/WebKit

WebKit:

Fixed: 2978258 - quake3arena.com sends me to the flash=false site
The page has a flash plugin that once loaded, requests the flash=true page. If the plugin doesn't load, the meta refresh tag to the flash=false page fires after 3 seconds. This is how this site's flash detection works.

The reason this doesn't work for us is because the flash movie is at the bottom of the page. Plugins don't start until the initial drawRect. Since the movie is at the bottom of the page and out of site, the plugin never gets the drawRect and thus, never starts. We now start plug-ins when they are added to the window.

Fixed: 3062224 - context menu includes "Download Item to Disk" for mailto links

• Fixed click then click and drag causes crash.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView drawRect:]): don't start plug-in here (-[WebNetscapePluginView viewDidMoveToWindow]): start it here
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): don't provide "Download Link To Disk" and "Open Link In New Window" items for URLs we cant handle.
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): clean-up (-[WebHTMLView mouseDragged:]): Don't allow drag if the frame has a provisional data source because this view may be released and the drag callbacks might reference this released view.

WebBrowser:

Fixed: 3062224 - context menu includes "Download Item to Disk" for mailto links

• Added "Open With QuickTime Player" context menu for URLs ending with .mov.
• Only show "Open With*" items for http URLs.

• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler openWithiTunes:]): (-[ContextMenuHandler openWithQuickTime:]):

Sep 28, 2002:

4:57 PM Changeset in webkit [2201] by darin

• 6 edits in trunk/WebCore

Turn -Werror back on. There must have been some miscommunication
about the fat build; this was supposed to have been on.

• WebCore.pbproj/project.pbxproj: Add -Werror back.

• kwq/WebCoreHistory.h: Add missing method to fix warning.
• kwq/KWQKHistoryProvider.mm: Tweak.

1:38 PM Changeset in webkit [2200] by darin

• 6 edits in trunk/WebCore

Give the next fat build a better chance of working with the
new gcc without turning warnings off.

• khtml/css/cssparser.cpp: Use a macro to disable inlining.
• khtml/html/htmltokenizer.cpp: Ditto.
• khtml/misc/htmlhashes.cpp: Ditto.

12:49 PM Changeset in webkit [2199] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Catch a request that we can't use here instead of failing later.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Added an assert so the failure was less confusing; good idea to leave it in.

12:35 PM Changeset in webkit [2198] by cblu

• 4 edits in trunk/WebKit

Support for latest Flash plug-in. It requests a javascript URL for every plug-in instance. Until javascript URLs work, we return an error to the plug-in.

Fixed: 3035582 - flash animations don't work after upgrading flash
Fixed: 3021936 - links in flash at foggypetronasracing.com doesn't work

• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): Make the request here and return nil if we can't create a handle with it. (-[WebNetscapePluginStream dealloc]): release the request (-[WebNetscapePluginStream startLoad]): use the request when creating the handle

1:06 AM Changeset in webkit [2197] by darin

• 4 edits in trunk/WebCore

• fixed 3022441 -- scroll bar is missing in window created with window.open

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): The checks for extra parameters to window.open were using isNull, which checks for a null ValueImp pointer, not an "Undefined".

12:39 AM Changeset in webkit [2196] by darin

• 15 edits in trunk

WebCore:

• fixed 2886111 -- changing font or size preference causes open windows to redraw incorrectly

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo): Fix logic about when a recalc of the minWidth and maxWidth is needed.

Fixed bug where changing the text size multiplier would cause the
window to redraw twice -- once with the text size changed, and then
later with the layout changed.

• khtml/khtmlview.h: Added unscheduleRelayout.
• khtml/khtmlview.cpp: (KHTMLView::unscheduleRelayout): Added.

• kwq/KWQKHTMLPartImpl.h: Added forceLayout.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::forceLayout): Call both layout and unscheduleRelayout.

• kwq/WebCoreBridge.h: Add setNeedsLayout.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge forceLayout]): Call KWQKHTMLPartImpl::forceLayout. (-[WebCoreBridge setTextSizeMultiplier:]): Call forceLayout.

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsLayout]): Added.

Sep 27, 2002:

9:22 PM Changeset in webkit [2195] by cblu

• 4 edits in trunk/WebKit

Fixed KJS crasher caused by nil plug-in returned from WebPlugin.
Got the RealPlayer plug-in loaded, nothing playing yet.

• Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin getPluginInfo]): check for nil plug-in names/descriptions (-[WebNetscapePlugin stringByResolvingSymlinksAndAliasesInPath:]): new, resolves old-style aliases (-[WebNetscapePlugin initWithPath:]): call stringByResolvingSymlinksAndAliasesInPath

5:45 PM Changeset in webkit [2194] by darin

• 4 edits in trunk/WebCore

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo): Fixed a > that should have been a < that prevented tables from changing sizes when table minimum widths changed.

5:16 PM Changeset in webkit [2193] by darin

• 2 edits in trunk/WebKit/WebView.subproj

• LocationChangeError.m: (-[LocationChangeHandler displayLocationChangeError:]): Add back the WebErrorCodeCancelled case.

4:44 PM Changeset in webkit [2192] by rjw

• 4 edits in trunk/WebKit

i Fix 3058315: crash in WebHTMLRepresentation receivedData:withDataSource

​http://www.u2.com/lite/ does some whacky things with its framset's onLoad
handler. The fix ensures that data isn't sent to the bridge once
the bridge has been dealloced.

• WebKit.pbproj/project.pbxproj: Nothing changed. PB dorkiness.
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation receivedData:withDataSource:]):

Fix related to 3058315.

• LoadProgressMonitor.m: (-[LoadProgressMonitor receivedUpdateForKey:URLString:bytesLoaded:bytesExpected:error:dataSource:isComplete:]):

2:34 PM Changeset in webkit [2191] by darin

• 9 edits in trunk/WebCore

• fixed 2937198 -- Checkboxes and radiobuttons don't align with title control in forms

• kwq/qt/qcheckbox.h: Add baselinePosition override.
• kwq/KWQCheckBox.mm: Tweak the size constants. (QCheckBox::baselinePosition): Implement this. Line up baseline two pixels above the bottom, not at the bottom.

• kwq/qt/qradiobutton.h: Add baselinePosition override.
• kwq/KWQRadioButton.mm: Tweak the size constants. (QRadioButton::baselinePosition): Implement this. Line up baseline two pixels above the bottom, not at the bottom.

2:31 PM Changeset in webkit [2190] by cblu

• 14 edits in trunk

WebCore:

WebPlugin clean up.

• kwq/KWQKConfigBase.mm: (KConfig::readEntry):
• kwq/WebCoreViewFactory.h:

WebKit:

Fixed: 3056559 - QT plugin doesn't load (claudius)
Fixed: 3042850 - Enable Java by default

Cleaned up WebPlugin and WebPluginDatabase.

• Plugins.subproj/WebPlugin.h:
• Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin openResourceFile]): (-[WebNetscapePlugin closeResourceFile:]): (-[WebNetscapePlugin stringForStringListID:andIndex:]): (-[WebNetscapePlugin getPluginInfo]): (-[WebNetscapePlugin initWithPath:]): (-[WebNetscapePlugin load]): (-[WebNetscapePlugin unload]): (-[WebNetscapePlugin MIMEToExtensionsDictionary]): (-[WebNetscapePlugin extensionToMIMEDictionary]): (-[WebNetscapePlugin MIMEToDescriptionDictionary]): (-[WebNetscapePlugin description]):
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase pluginForMIMEType:]): (-[WebNetscapePluginDatabase pluginForExtension:]): (-[WebNetscapePluginDatabase pluginForFilename:]): (-[WebNetscapePluginDatabase MIMETypes]): (-[WebNetscapePluginDatabase init]):
• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setDataSource:]):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Enable Java by default

1:50 PM Changeset in webkit [2189] by rjw

• 21 edits in trunk

WebBrowser no longer responsible for setting page title in history.

• LocationChangeHandler.m: (-[LocationChangeHandler receivedPageTitle:forDataSource:]):

Fixed 3060158: REGRESSION: iframes added to session history
Also moved setting title in history to WebKit.

• History.subproj/WebHistory.h:
• History.subproj/WebHistory.m: (+[WebHistory sharedHistory]): (+[WebHistory webHistoryWithFile:]): (-[WebHistory addEntryForURL:]): (-[WebHistory addEntries:]):
• History.subproj/WebHistoryPrivate.h:
• History.subproj/WebHistoryPrivate.m:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURL]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

Fixed 3059237: Visited links do not appear in a different color on yahoo.com
Fixed 3051288: visited links are not colored in local files
Fixed 3060158: REGRESSION: iframes added to session history
Always use the canonical originally requested URL as the URL entered in history.

• khtml/khtml_part.cpp: (KHTMLPart::begin):
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestedURLString):
• kwq/KWQKHistoryProvider.mm:
• kwq/WebCoreBridge.h:
• kwq/WebCoreHistory.h:

12:40 PM Changeset in webkit [2188] by hyatt

• 4 edits in trunk/WebCore

Fix for 3058119, doctype of HTML docs should be null.

• khtml/dom/dom_doc.cpp:

12:27 PM Changeset in webkit [2187] by hyatt

• 4 edits in trunk/WebCore

DOM compliance. Fix for 3058100, hasFeature of HTML returns
false. Oops.

• khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature):

11:35 AM Changeset in webkit [2186] by darin

• 4 edits in trunk/WebCore

• fixed 3060487 -- error connecting member slot to signal (KWQObject)

• kwq/KWQObject.mm: (QObject::connect): Add slotShowDocument to the list of slots that we don't care about hooking up.

10:32 AM Changeset in webkit [2185] by cblu

• 5 edits in trunk/WebKit

WebKit:

Added support for dragging links the the dock.
Created new pasteboard types WebURLPboardType WebURLNamePboardType that the dock requires.

• Misc.subproj/WebNSPasteboardExtras.h:
• Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]): set WebURLPboardType and WebURLNamePboardType (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): use WebURLPboardType and WebURLNamePboardType
• WebKit.exp: export WebURLPboardType and WebURLNamePboardType

WebBrowser:

Added support for dragging links the the dock.
Created new pasteboard types WebURLPboardType WebURLNamePboardType that the dock requires.

• BrowserWebBookmarkExtras.m: (+[WebBookmark writeBookmarks:toPasteboard:withOwner:]): use WebURLPboardType and WebURLNamePboardType

10:27 AM Changeset in webkit [2184] by darin

• 4 edits in trunk/JavaScriptCore

• fixed 3033969 -- repro crash (infinite recursion in JavaScript) clicking on "screens" option at fsv.sf.net

• kjs/object.h: Change recursion limit to 100 levels rather than 1000.

8:25 AM Changeset in webkit [2183] by cblu

• 1 edit in trunk/WebKit/Misc.subproj/WebNSPasteboardExtras.m

* empty log message *

4:30 AM Changeset in webkit [2182] by mjs

• 5 edits in trunk/WebKit

WebFoundation:

Put in place all the API changes needed for the "remember
password" feature and examining stored passwords. The actual
storing of passwords in Keychain is not implemented yet - that's
the next step.

• AuthenticationManager.subproj/WebAuthenticatingResource.h: Added.
• AuthenticationManager.subproj/WebAuthenticatingResource.m: Added. New class that's the data holder part of WebAuthenticationRequest, the part that describes the resource needing authentication. (-[WebAuthenticatingResourcePrivate dealloc]): (-[WebAuthenticatingResource initWithURL:realm:username:receivesCredentialSecurely:proxyHost:proxyType:]): (+[WebAuthenticatingResource resourceWithURL:realm:username:receivesCredentialSecurely:proxyHost:proxyType:]): (-[WebAuthenticatingResource init]): (-[WebAuthenticatingResource dealloc]): (-[WebAuthenticatingResource URL]): (-[WebAuthenticatingResource realm]): (-[WebAuthenticatingResource username]): (-[WebAuthenticatingResource receivesCredentialSecurely]): (-[WebAuthenticatingResource isProxy]): (-[WebAuthenticatingResource proxyHost]): (-[WebAuthenticatingResource proxyType]): (-[WebAuthenticatingResource copyWithZone:]):
• AuthenticationManager.subproj/WebAuthenticationHandler.h:
• AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationDispatchState dealloc]): (-[WebAuthenticationHandlerDispatcher _dispatchStartAuthentication:]): (-[WebAuthenticationHandlerDispatcher WebAuthenticationRequest:useCredential:]): (-[WebAuthenticationHandlerDispatcher _dispatchAuthenticationDone:]): (-[WebAuthenticationHandlerDispatcher startAuthentication:]):
• AuthenticationManager.subproj/WebAuthenticationManager.h:
• AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager removeCredentialForResource:]): (-[WebAuthenticationManager resourceCredentials]): (-[WebAuthenticationManager _invokeHandlersWithURL:realm:forRequest:withCallback:context:]): (-[WebAuthenticationManager _invokeHandlersWithURL:proxy:forRequest:withCallback:context:]): (-[WebAuthenticationManager _tryRequest:]): (-[WebAuthenticationManager WebAuthenticationRequest:useCredential:]):
• AuthenticationManager.subproj/WebAuthenticationRequest.h:
• AuthenticationManager.subproj/WebAuthenticationRequest.m: (-[WebAuthenticationRequestPrivate initWithResource:previousFailureCount:delegate:]): (-[WebAuthenticationRequestPrivate dealloc]): (-[WebAuthenticationRequest _initWithResource:previousFailureCount:delegate:]): Change to init with a WebAuthenticatingResource rather than passing all the data. (-[WebAuthenticationRequest _authenticationHandlerBusy]): (-[WebAuthenticationRequest resource]): New method (-[WebAuthenticationRequest previousFailureCount]): Renamed from previousFailures (-[WebAuthenticationRequest useCredential:]): Renamed from authenticationDone: (-[WebAuthenticationRequest cancel]): Removed to fix in-band signalling
• AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
• AuthenticationManager.subproj/WebAuthenticationResult.m: Removed.
• AuthenticationManager.subproj/WebCredential.h: Added.
• AuthenticationManager.subproj/WebCredential.m: Added. Renamed from WebAuthenticationResult. (-[WebCredentialPrivate dealloc]): (-[WebCredential initWithUsername:password:remembered:]): Add remembered: parameter (+[WebCredential credentialWithUsername:password:remembered:]): Likewise (-[WebCredential dealloc]): (-[WebCredential username]): (-[WebCredential password]): (-[WebCredential remembered]): New method (-[WebCredential copyWithZone:]):
• Misc.subproj/WebFoundation.h:
• WebFoundation.exp: Fix exports.
• WebFoundation.pbproj/project.pbxproj: Add new files, remove removed ones.

Mechanical fixes to get C glue to compile:

• AuthenticationManager.subproj/IFAuthenticationHandlerC.m: (-[IFCallBackAuthenticationHandler isReadyToStartAuthentication:]):
• AuthenticationManager.subproj/IFAuthenticationRequestC.m: (IFAuthenticationRequestCopyURL): (IFAuthenticationRequestCopyRealm): (IFAuthenticationRequestCopyUsername): (IFAuthenticationRequestWillPasswordBeSentInClear): (IFAuthenticationRequestGetPreviousFailures): (IFAuthenticationRequestIsForProxy): (IFAuthenticationRequestCopyProxyHost): (IFAuthenticationRequestCopyProxyType): (IFAuthenticationRequestDone):
• AuthenticationManager.subproj/IFAuthenticationResultC.m: (IFAuthenticationResultCreate): (IFAuthenticationResultCopyUsername): (IFAuthenticationResultCopyPassword):

WebKit:

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): (-[WebAuthenticationPanel runAsModalDialogWithRequest:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
• Panels.subproj/WebPanelAuthenticationHandler.h:
• Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler isReadyToStartAuthentication:]): (-[WebPanelAuthenticationHandler startAuthentication:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithRequest:result:]):