Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 3, 2002:

7:48 PM Changeset in webkit [2244] by rjw

• 10 edits in trunk/WebKit

Changed name of controller's resourceProgressDelegate methods to resourceLoadDelegate.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient initWithLoader:dataSource:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setResourceLoadDelegate:]): (-[WebController resourceLoadDelegate]): (-[WebController setDownloadDelegate:]): (-[WebController downloadDelegate]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient handle:didReceiveResponse:]):

Changed name of controller's resourceProgressDelegate methods to resourceLoadDelegate.

• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument close]):

7:35 PM Changeset in webkit [2243] by rjw

• 4 edits in trunk/WebKit

Create the activity entry in resourceRequest:didReceiveResponse:fromDataSource:
rather than resourceRequest:willSendRequest:fromDataSource:.

• BrowserWebController.m: (-[BrowserWebController resourceRequest:willSendRequest:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveResponse:fromDataSource:]):

Always call resourceRequest:willSendRequest: on resourceProgressDelegate.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]):

7:11 PM Changeset in webkit [2242] by rjw

• 4 edits in trunk/WebKit

Add calls to downloadProgressDelegate.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):

6:38 PM Changeset in webkit [2241] by rjw

• 5 edits in trunk/WebKit

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:]): Hack to prevent handle creation with nil delegate, still perform frame complete check.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): Removed unused code.

(-[WebMainResourceClient handle:willSendRequest:]):
Copy the request, ugh.

• BrowserWebController.m: (-[BrowserWebController resourceRequest:willSendRequest:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveContentLength:fromDataSource:]): (-[BrowserWebController resourceRequest:didFinishLoadingFromDataSource:]): Clean up activity value changes.

• FrameProgressEntry.m: (-[FrameProgressEntry trackSubresource:withIdentifier:forDataSource:]): (-[FrameProgressEntry updateKeyFrom:to:dataSource:]): (-[FrameProgressEntry updateSubresource:ofDataSource:withURLString:bytesLoaded:bytesExpected:error:]): Update key when request changes. May be removed if with go with opaque identifier.

• LoadProgressMonitor.h:
• LoadProgressMonitor.m: (-[LoadProgressMonitor entryForKey:dataSource:]): Accessor method for ResourceProgressEntry.

Copy request if a different instance is returned.

• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientWillSendRequest]):

5:43 PM Changeset in webkit [2240] by darin

• 4 edits in trunk/WebCore

• fixed 3065730 -- Crash loading "My T-Mobile" page (in khtml::Decoder::decode)

• khtml/misc/decoder.cpp: (Decoder::decode): Fixed a mistake that would cause the loop to run off the end of the buffer, introduced back on 2002-08-30.

5:31 PM Changeset in webkit [2239] by darin

• 11 edits in trunk

WebCore:

Add API to execute JavaScript.

• kwq/WebCoreBridge.h: Add method.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge executeJavaScriptFromString:]): Call through to KHTML. But only if the document is not nil. We need to figure out what to do in the case where the document is nil.

WebKit:

Add API for executing JavaScript.

• WebView.subproj/WebController.h: Add method.
• WebView.subproj/WebController.m: (-[WebController executeJavaScriptFromString:]): Call through to WebCore to do the heavy lifting.

WebBrowser:

Fixed most of 2980477 -- javascript: URLs don't work when typed
into the page address field or in bookmarks

They work now, but only if the frontmost window is not empty.

• BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): Rename, change to take a policy parameter instead of a boolean, and add code for the javascript: case. (-[WebBookmark goTo]): Pass ReuseAvailableWindow. (-[WebBookmark goToInNewWindow]): Pass CreateWindow. (-[WebBookmark goToUsingNewWindowAccordingToEvent:]): Choose policy based on both the command key and the shift key.

• BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]): Add add code for the javascript: case.

3:53 PM Changeset in webkit [2238] by darin

• 7 edits
  1 delete in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Do all the remaining TODO items for this script.

WebFoundation:

• English.lproj/Localizable.strings: Added. Generated by script.
• English.lproj/StringsNotToBeLocalized.txt: Updated with many more entries.

• Misc.subproj/WebError.m: Switch from NSLocalizedStringFromTable to UI_STRING.
• Misc.subproj/WebNSStringExtras.m: Switch from dummy WebLocalizedStringWithKeyAndValue to UI_STRING.

• Misc.subproj/WebQueue.m: (+[WebQueue newNode]): Just use malloc.

• English.lproj/WebError.strings: Removed.
• Misc.subproj/WebMultipartForm.h: Removed.
• Misc.subproj/WebMultipartForm.m: Removed.

• WebFoundation.pbproj/project.pbxproj: Changed encoding of many files to UTF-8. Removed files. Added Localizable.strings and StringsNotToBeLocalized.txt.

WebKit:

• English.lproj/Localizable.strings: Generated by the script.
• English.lproj/StringsNotToBeLocalized.txt: Added many more strings to ignore.
• English.lproj/WebError.strings: Removed.

• WebView.subproj/WebDefaultContextMenuDelegate.m:
• WebView.subproj/WebView.m: Use UI_STRING instead of NSLocalizedString.

• WebKit.pbproj/project.pbxproj: Changed encodings of some files to UTF-8. Removed WebError.strings.

WebBrowser:

• BrowserWebController.m: (-[BrowserWebController mouseoverTextForElement:modifierFlags:]): Added. Also put in strings for when the control key is down. (-[BrowserWebController mouseDidMoveOverElement:modifierFlags:]): Factor out the actual string change here. More work on this is required.

• ABHomePagesController.m:
• BookmarkToolbarItem.m:
• BookmarksController.m:
• BookmarksViewController.m:
• BookmarksWindowController.m:
• BrowserWebBookmarkExtras.m:
• BrowserWebController.m:
• BrowserWebErrorExtras.m:
• BrowserWindowController.m:
• ContextMenuHandler.m:
• DownloadMonitor.m:
• DownloadProgressEntry.m:
• FavoriteButton.m:
• FindPanelController.m:
• FrameProgressEntry.m:
• GlobalHistory.m:
• HTMLSourceDocument.m:
• LoadProgressMonitor.m:
• LocationChangeError.m:
• RendezvousController.m:
• Preferences.subproj/AppearancePreferences.m: Switch from NSLocalizedString to UI_STRING

• DateCell.m: Replace the dummy NSLocalizedStringWithKeyAndValue with UI_STRING.
• ResourceProgressEntry.m: (-[ResourceProgressEntry _committedStatus]): Got rid of FIXME: Localize, and put in use of UI_STRING.

• English.lproj/StringsNotToBeLocalized.txt: Add some more exceptions.
• English.lproj/Localizable.strings: Check in script-generated file for now.

• BrowserStrings.h: Removed.

• WebBrowser.pbproj/project.pbxproj: Changed encodings for many files to UTF-8. Also added StringsNotToBeLocalized.txt, although not in any target.

3:06 PM Changeset in webkit [2237] by rjw

• 13 edits
  1 delete in trunk/WebKit

Renamed WebResourceProgressDelegate.h to WebResourceLoadDelegate.h

• BrowserWebController.m:

Renamed WebResourceProgressDelegate.h to WebResourceLoadDelegate.h

• Misc.subproj/WebKit.h:
• WebCoreSupport.subproj/WebSubresourceClient.m:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.m:
• WebView.subproj/WebControllerPrivate.m:
• WebView.subproj/WebMainResourceClient.m:
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebResourceProgressDelegate.h: Removed.

2:53 PM Changeset in webkit [2236] by rjw

• 26 edits
  2 deletes in trunk/WebKit

Changed to reflect new WebResourceLoadDelegate API.

• BrowserWebController.h:
• BrowserWebController.m: (-[BrowserWebController resourceRequest:willSendRequest:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveContentLength:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveResponse:fromDataSource:]): (-[BrowserWebController resourceRequest:didFinishLoadingFromDataSource:]):
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor _monitorDownload:withBytesLoaded:bytesExpected:error:dataSource:complete:]): (-[DownloadMonitor resourceRequest:willSendRequest:fromDataSource:]): (-[DownloadMonitor resourceRequest:didReceiveContentLength:fromDataSource:]): (-[DownloadMonitor resourceRequest:didReceiveResponse:fromDataSource:]): (-[DownloadMonitor resourceRequest:didFinishLoadingFromDataSource:]): (-[DownloadMonitor resourceRequest:didFailLoadingWithError:fromDataSource:]):
• FrameProgressEntry.m: (-[FrameProgressEntry updateSubresource:ofDataSource:withURLString:bytesLoaded:bytesExpected:error:]):
• LoadProgressMonitor.m:

Changed to reflect new WebResourceLoadDelegate API.

• Misc.subproj/WebIconLoader.m:
• Misc.subproj/WebKit.h:
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream cancel]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:]): (-[WebBridge reportBadURL:]):
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient initWithLoader:dataSource:]): (-[WebSubresourceClient dealloc]): (-[WebSubresourceClient receivedProgressWithComplete:]): (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient handle:willSendRequest:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]): (-[WebSubresourceClient cancel]):
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setResourceProgressDelegate:]): (-[WebController resourceProgressDelegate]): (-[WebController setDownloadProgressDelegate:]): (-[WebController downloadProgressDelegate]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedProgressForResourceHandle:fromDataSource:complete:]): (-[WebController _mainReceivedProgressForResourceHandle:bytesSoFar:fromDataSource:complete:]): (-[WebController _receivedError:forResourceHandle:fromDataSource:]): (-[WebController _mainReceivedError:forResourceHandle:fromDataSource:]):
• WebView.subproj/WebLoadProgress.h: Removed.
• WebView.subproj/WebLoadProgress.m: Removed.
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient receivedProgressWithHandle:complete:]): (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebResourceProgressDelegate.h:

Always send a handle:willSendRequest: before sending a request,
including first time. This will allow WebKit clients to intervene
on every load should they so choose.

• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadWithDelegate:]):

12:27 PM Changeset in webkit [2235]

• 3 copies in tags/Alexander-26

This commit was manufactured by cvs2svn to create tag 'Alexander-26'.

12:27 PM Changeset in webkit [2234] by sheridan

• 8 edits in trunk

Alex-26 version

Oct 2, 2002:

5:37 PM Changeset in webkit [2233] by mjs

• 8 edits in trunk/WebKit

• Added "remember my password" checkbox (underlying feature not yet implemented).

• Fixed a bug that caused a crash when cancelling the auth sheet.

• Panels.subproj/English.lproj/WebAuthenticationPanel.nib: Added "remember this password" checkbox.
• Panels.subproj/WebAuthenticationPanel.h:
• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel cancel:]): Make sure the panel gets retained a bit longer, so the cleanup that happens after this message is sent can use the panel object. (-[WebAuthenticationPanel logIn:]): Make sure the panel gets retained a bit longer, so the cleanup that happens after this message is sent can use the panel object. (-[WebAuthenticationPanel runAsModalDialogWithRequest:]): Pass proper remembered value with credential. (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]): Pass proper remembered value with credential.
• WebKit.pbproj/project.pbxproj: Project Builder had its way with this file.

4:52 PM Changeset in webkit [2232] by darin

• 23 edits in trunk

WebCore:

Moved "overURL" handling out of WebCore into WebKit and Alex.
Also separated the two levels of the "element dictionary" so they
don't rely on having the same keys.

• khtml/khtml_part.h: Revert the APPLE_CHANGES to overURL.
• khtml/khtml_part.cpp: (KHTMLPart::overURL): Removed the APPLE_CHANGES and just ifdef'd out the whole thing for our version. (KHTMLPart::khtmlMouseMoveEvent): Get rid of the APPLE_CHANGES and don't do any of the status bar setup.

• kwq/KWQKHTMLPartImpl.h: Remove overURL.
• kwq/KWQKHTMLPartImpl.mm: Ditto.

• kwq/WebCoreBridge.h: Change keys so they don't match the WebKit ones so we don't accidentally rely on that. Add WebCoreElementLinkTarget.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Add code to set up WebCoreElementLinkTarget.

WebKit:

Machinery so we can handle mouseover feedback at the browser level.

• WebView.subproj/WebWindowOperationsDelegate.h: Added mouseDidMoveOverElement:modifierFlags:.

• WebKit.exp: Export WebElementLinkTargetFrameKey.
• WebView.subproj/WebController.h: Add WebElementLinkTargetFrameKey.
• WebView.subproj/WebController.m: Ditto.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView removeMouseMovedObserver]): Send a callback when we stop tracking the mouse altogether. (-[WebHTMLView viewDidMoveToWindow]): Only set up the mouse moved observer if we are the top-level HTML view. (-[WebHTMLView windowDidBecomeMain:]): Ditto. (-[WebHTMLView mouseMovedNotification:]): Handle mouse over if we are over any subview of the HTML view. Also send the callback.

• WebView.subproj/WebHTMLViewPrivate.h: Added lastMouseOverElementWasNotNil, _mouseOverElement:modifierFlags: and _insideAnotherHTMLView.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Copy over each element separately so we don't rely on keys matching. Find the target frame given the target string, and include it in the dictionary. (-[WebHTMLView _mouseOverElement:modifierFlags]): Added. Calls the window operations delegate method, but doesn't call it over and over again if the information is still "nil". (-[WebHTMLView _insideAnotherHTMLView]): Added. (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Added. Helper for the _elementAtPoint method which could be moved to WebNSDictionaryExtras some day.

WebBrowser:

• fixed 2935687 -- cmd-shift-click should open new window behind
• fixed 3050456 -- Click modifier actions are decided by WebBrowser, but status messages come from WebCore

• BrowserWebController.m: (-[BrowserWebController mouseDidMoveOverElement:modifierFlags:]): Added. Contains the same logic that used to be in WebCore for mouseover messages, but translated into WebKit-ese as opposed to WebCore-ese.

• WebBrowser.pbproj/project.pbxproj: Change encoding of BrowserWebController.m to UTF-8. Be careful if you open this file without having the project open in Project Builder.

4:14 PM Changeset in webkit [2231] by kocienda

• 3 edits in trunk/WebKit

WebFoundation:

Implemented HTTP-specific subclass for WebResourceResponse.

• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode): (IFURLHandleGetResultCode):
• CacheLoader.subproj/WebCacheLoaderConstants.h:
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle cancel]):
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]):
• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): (-[WebResourceResponse initWithCoder:]): (-[WebResourceResponse encodeWithCoder:]): (-[WebResourceResponse _takePersistentValuesFrom:]): (-[WebResourceResponse dealloc]):
• CacheLoader.subproj/WebResourceResponsePrivate.h:
• Misc.subproj/WebError.h:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler performHTTPHeaderRead:andCall:]):
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler responseClass]): (-[WebHTTPProtocolHandler setResponseMetadata:]): (-[WebHTTPProtocolHandler shouldCacheResponse:]): (-[WebHTTPProtocolHandler cacheableAttributesWithDefaults:]):
• ProtocolHandlers.subproj/WebHTTPResourceResponse.h:
• ProtocolHandlers.subproj/WebHTTPResourceResponse.m:
• ProtocolHandlers.subproj/WebHTTPResourceResponsePrivate.h: Added.
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _examineHeaders]):
• WebFoundation.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Implemented HTTP-specific subclass for WebResourceResponse.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:]): Add import for WebHTTPResourceResponse.

1:53 PM Changeset in webkit [2230] by darin

• 8 edits in trunk/WebKit

WebFoundation:

Add return value to willSendRequest callback.

• CacheLoader.subproj/WebResourceHandleDelegate.h: Add return value.

• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadWithDelegate:]): Call _notifyClientWillSendRequest to do the work of sending the willSendRequest message in the canonical URL case, to avoid duplicate code.

• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientWillSendRequest]): Keep the returned request.

• CacheLoader.subproj/WebResourceCallbackClient.m: (-[WebResourceCallbackClient handle:willSendRequest:]):
• CacheLoader.subproj/WebResourceSynchronousDelegate.m: (-[WebResourceHandleSynchronousDelegate handle:willSendRequest:]): Update to return the request.

WebKit:

Add return value to willSendRequest callback.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader handle:willSendRequest:]):
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:willSendRequest:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:willSendRequest:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Update to return the request.

12:47 PM Changeset in webkit [2229] by darin

• 11 edits in trunk/WebKit

Use the text encoding name from the response and got rid of
[WebDataSource encoding]. Also remove the "first chunk" logic since we
now get a separate callback for the response.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Get the encoding name from the response, or fall back on the default.

• WebView.subproj/WebDataSource.h: Removed encoding.
• WebView.subproj/WebDataSource.m: Ditto.

• WebView.subproj/WebDataSourcePrivate.h: Removed _setEncoding.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): No need to release encoding any more.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): No isFirstChunk to initialize. (-[WebMainResourceClient handle:didReceiveResponse:]): Moved the response handling in here, including the policy logic. (-[WebMainResourceClient handle:didReceiveData:]): This has only what's left.

12:12 PM Changeset in webkit [2228] by cblu

• 14 edits in trunk/WebKit

WebKit:

Replaced contentType on WebDataSource to response.

• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:]): (-[WebNetscapePluginStream setResponse:]): (-[WebNetscapePluginStream setDataSource:]): (-[WebNetscapePluginStream receivedData:withDataSource:]): (-[WebNetscapePluginStream handle:didReceiveResponse:]): (-[WebNetscapePluginStream handle:didReceiveData:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource response]): (-[WebDataSource fileType]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _representationClass]): (-[WebDataSource _setResponse:]): (-[WebDataSource _setContentPolicy:]):
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]):
• WebView.subproj/WebTextView.m: (-[WebTextView dataSourceUpdated:]):
• WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]):

WebBrowser:

Replaced contentType on WebDataSource to response.

• BrowserWebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]):

11:59 AM Changeset in webkit [2227] by darin

• 11 edits in trunk/WebKit

WebKit:

More work on "open window behind".

• WebView.subproj/WebControllerPolicyDelegate.h: Add new OpenNewWindowBehind constants to the enums.

• WebView.subproj/WebWindowOperationsDelegate.h: Add a behind: parameter to the openNewWindowWithURL method.

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): In the new WebClickPolicyOpenNewWindowBehind case, pass YES for behind.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]):
• WebView.subproj/WebFrame.m: (-[WebFrame frameNamed:]): Pass NO for behind.

WebBrowser:

More work on "open window behind".

• BrowserWebController.m: (-[BrowserWebController openNewWindowWithURL:referrer:behind:]): Add new behind parameter to match change to window operations delegate in WebKit. (-[BrowserWebController clickPolicyForElement:button:modifierFlags:]): Use the WebClickPolicyOpenNewWindowBehind policy if the shift key and command key are down.

10:39 AM Changeset in webkit [2226] by darin

• 7 edits in trunk/WebKit

Cut down on unnecessary use of WebFoundation private stuff.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad]): Remove unnecessary use of [WebResourceHandle _request].
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]): Remove assert about status code, since status codes are going away.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Use currentURL for logging. (-[WebMainResourceClient handleDidFinishLoading:]): Ditto. (-[WebMainResourceClient handle:didReceiveData:]): Ditto.

10:03 AM Changeset in webkit [2225] by darin

• 6 edits in trunk/WebKit

WebKit:

• WebView.subproj/WebControllerPolicyDelegate.h: Change modifierMask to modifierFlags to match NSEvent.
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForElement:button:modifierFlags:]): Ditto.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): Ditto.

WebBrowser:

Start of the "open window behind" feature.

• BrowserDocument.m: (-[BrowserDocument close]): Move a cancel here from the BrowserWebController resetDocument method that really didn't belong there. (-[BrowserDocument _goToURL:referrer:withFallbackURLs:]): Rearrange this function so that the part that is just "go to a particular WebResourceRequest" is clearly separated, in preparation for using a method in WebController some day.

• BrowserDocumentController.h: Add URLWindowPolicy enum, and use it as the parameter for goToURL and tryMultipleURLs.
• BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:referrer:behind:): Remove display: parameter, and add behind: parameter. (-[BrowserDocumentController _goToEachURL:referrer:windowPolicy:]): Update to take a windowPolicy parameter instead of separate booleans. (-[BrowserDocumentController goToEachURL:]): Use windowPolicy. (-[BrowserDocumentController openDocument:]): Use windowPolicy. (-[BrowserDocumentController goToURL:]): Use windowPolicy. (-[BrowserDocumentController goToURL:referrer:windowPolicy:]): Use windowPolicy. (-[BrowserDocumentController tryMultipleURLs:windowPolicy:]): Use windowPolicy.

• BrowserWebController.m: (-[BrowserWebController resetDocument]): Move cancel to BrowserDocument close. (-[BrowserWebController openNewWindowWithURL:referrer:]): Use windowPolicy. (-[BrowserWebController pluginNotFoundSheetEnded:returnCode:contextInfo:]): Use windowPolicy. (-[BrowserWebController clickPolicyForElement:button:modifierFlags:]): Update name to match change in WebKit.

• ActivityViewer.m: (-[ActivityViewer _goToClickedItem:]):
• AppController.m: (-[AppController application:openFile:]): (-[AppController handleGURLEvent:withReplyEvent:]):
• BrowserWebBookmarkExtras.m: (-[WebBookmark _goToForceNewWindow:]):
• Test/PageLoadTestRunner.m: (-[PageLoadTestRunner goToPage]): Update to use windowPolicy.

9:46 AM Changeset in webkit [2224] by darin

• 5 edits in trunk/WebKit

Get rid of uses of canonicalURL.

• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Start with normal URL. The change to the canonical URL will come in as a redirect. (-[WebSubresourceClient handle:didReceiveData:]): Remove assert. (-[WebSubresourceClient handleDidFinishLoading:]): Ditto.
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]):Start with normal URL. The change to the canonical URL will come in as a redirect.

9:23 AM Changeset in webkit [2223] by kocienda

• 3 edits in trunk/WebKit

Added import of WebHTTPResourceRequest.h to get access to methods
which have moved to the HTTP-sepcific request category.

• WebView.subproj/WebDataSourcePrivate.m

Oct 1, 2002:

5:21 PM Changeset in webkit [2222] by sullivan

• 4 edits in trunk/WebKit

WebKit:

• WebKit.exp: added .objc_class_name_WebTextRendererFactory so I could use it from WebBrowser.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:referrer:]): Just changed whitespace so the .exp change would be built.

WebBrowser:

• finished implementing the "etched text" look in the status bar. I had to do some Cocoa API trickery to access WebTextRenderer stuff in order to make it fast; I'll get this cleaned up soon. (Note that this makes a 1-2% speedup in cvs-base)

• BrowserWindowController.h: remove statusField outlet; we always use statusStringView now

• BrowserWindowController.m: (-[BrowserWindowController clearStatus]): remove statusField (-[BrowserWindowController setStatus:]): always use statusStringView

• PreferenceKeys.h: eliminate preference key for etched text
• Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Remove menu item to toggle etched text

• English.lproj/Browser.nib: reposition string view slightly

• EtchedStringView.m: (+[EtchedStringView textRenderer]): new method, get (and lazily create) WebTextRenderer used to draw all status bar strings. (+[EtchedStringView lightColor]): new method, get (and lazily create) the whitish color (+[EtchedStringView darkColor]): new method, get (and lazily create) the blackish color (-[EtchedStringView drawRect:]): use WebTextRenderer drawing code.

Also removed some old methods used by the AppKit drawing code.

3:42 PM Changeset in webkit [2221] by cblu

• 3 edits in trunk/WebKit

Fixed build breakage.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setWindow]):

3:28 PM Changeset in webkit [2220] by darin

• 4 edits in trunk/WebCore

• fixed 3055076 -- window.scroll does a window.scrollby, not a window.scrollto

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Moved a case so that the scroll code would scroll to, not by.

3:25 PM Changeset in webkit [2219] by kocienda

• 7 edits in trunk/WebKit

WebFoundation:

Implemented WebResourceRequest "category" design for extending a
request with protocol-specific data.

• CacheLoader.subproj/IFHTTPURLHandleC.m: Now imports WebHTTPResourceRequest.h.
• CacheLoader.subproj/WebProtocolHandler.h: Added partOfRequest:withClass:createIfDoesNotExist: method.
• CacheLoader.subproj/WebProtocolHandler.m: (+[WebProtocolHandler partOfRequest:withClass:createIfDoesNotExist:]):
• CacheLoader.subproj/WebResourceLoad.m: Now imports WebHTTPResourceRequest.h.
• CacheLoader.subproj/WebResourceLoadManager.m: Ditto.
• CacheLoader.subproj/WebResourceRequest.h: Removed HTTP-protocol-specific fields and methods.
• CacheLoader.subproj/WebResourceRequest.m: Ditto. (-[WebResourceRequest initWithURL:]): Deal with fact that HTTP-protocol-specific fields and methods have been removed. (-[WebResourceRequest copyWithZone:]): Ditto. Copy protocol-specific parts. (-[WebResourceRequest copyWithURL:]): Ditto. Ditto. :) (-[WebResourceRequest _partWithClass:createIfDoesNotExist:]): Added implementation. (-[WebResourceRequest dealloc]): Deal with fact that HTTP-protocol-specific fields and methods have been removed.
• CacheLoader.subproj/WebResourceRequestPrivate.h: Added.
• Misc.subproj/WebFoundation.h: Now imports WebHTTPResourceRequest.h.
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: Now imports WebHTTPResourceRequest.h.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: Ditto.
• ProtocolHandlers.subproj/WebHTTPResourceRequest.h: Added.
• ProtocolHandlers.subproj/WebHTTPResourceRequest.m: Added.
• ProtocolHandlers.subproj/WebHTTPResourceRequestParameters.h: Added.
• ProtocolHandlers.subproj/WebHTTPResourceRequestParameters.m: Added.
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: Now imports WebHTTPResourceRequest.h.
• WebFoundation.pbproj/project.pbxproj

WebKit:

Implemented WebResourceRequest "category" design for extending a
request with protocol-specific data.

• WebCoreSupport.subproj/WebBridge.m: Now imports WebHTTPResourceRequest.h.
• WebCoreSupport.subproj/WebSubresourceClient.m: Ditto.
• WebView.subproj/WebMainResourceClient.m: Ditto.

WebBrowser:

• BrowserDocument.m: Now imports WebHTTPResourceRequest.h to get at protocol-specific request information.

2:49 PM Changeset in webkit [2218] by cblu

• 3 edits in trunk/WebKit

• Added debug drawing
• removed unnecessary ifdef'ing.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView menuForEvent:]): (-[WebBaseNetscapePluginView setWindow]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView drawRect:]):

10:49 AM Changeset in webkit [2217] by kocienda

• 6 edits in trunk/WebKit

WebFoundation:

Reorganization of code in WebResourceResponse. This moves the code to the
point where the next change will be to break out HTTP-specific response
information into its own subclass.

• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]): Call protocol handler to get the right class for the response. (-[WebResourceLoad succeeded]):
• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): (-[WebResourceResponse initWithCoder:]): (-[WebResourceResponse encodeWithCoder:]): (-[WebResourceResponse textEncodingName]): Changed name from characterSet. (-[WebResourceResponse userAgent]): (-[WebResourceResponse headers]): (-[WebResourceResponse resultCode]): (-[WebResourceResponse _resourceData]): (-[WebResourceResponse _setTextEncodingName:]): Changed name from _setCharacterSet:. (-[WebResourceResponse _takePersistentValuesFrom:]): (-[WebResourceResponse dealloc]):
• CacheLoader.subproj/WebResourceResponsePrivate.h:
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler setResponseMetadata:]):

WebKit:

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]): Fixed Development build breakage. Call to [response statusCode] now calls the handle's private method to get the status code.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]): Ditto. (-[WebMainResourceClient handle:didReceiveData:]): Calls new textEncodingName method, replacing call to characterSet.

10:12 AM Changeset in webkit [2216] by kocienda

• 3 edits in trunk/WebKit

WebFoundation:

This change focuses on "status codes". Status codes are an enum that describe
the state of a handle's load (e.g. loading, finished, cancelled).

Removed status code from WebResourceResponse, and moved it to WebResourceHandle.
The status code is now available as private API on WebResourceHandle. This
change made it possible to make some nice cleanups and simplifications.

The great majority of these changes merely move the method calls from the old
design of calling WebResourceResponse to access the status code to calling
the WebResourceHandle to get the status code.

• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/WebCacheLoaderConstants.h:
• CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle sendSynchronousRequest:]) (-[WebResourceHandle initWithRequest:]) (-[WebResourceHandle loadWithDelegate:]) (-[WebResourceHandle cancel])
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandlePrivate.h:
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _didReceiveResponseMetadata:]) (-[WebResourceHandle _didLoadData:]) (-[WebResourceHandle _backgroundLoadComplete]) (-[WebResourceHandle _backgroundLoadFailed]) (-[WebResourceHandle _didRedirectToURL:]) (-[WebResourceHandle _load]) (-[WebResourceHandle _statusCode]) (-[WebResourceHandle _setStatusCode:])
• CacheLoader.subproj/WebResourceLoad.h:
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad cancel]) (-[WebResourceLoad isCancelled]) (-[WebResourceLoad succeeded]) (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]) (-[WebResourceLoad addHandle:]) (-[WebResourceLoad _beginLoad]) (_loadThrottler)
• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse _setResourceData:])
• CacheLoader.subproj/WebResourceResponsePrivate.h:

WebKit:

• WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress initWithResourceHandle:]): Status code moved from WebResourceResponse to WebResourceHandle private API.

9:17 AM Changeset in webkit [2215] by kocienda

• 8 edits in trunk/WebKit

WebFoundation:

Changed WebResourceHandle so that the init method no longer starts the
loading of the request to begin. Added new loadWithDelegate: method which
is called separatetly from the init method, to start loads.

• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle initWithRequest:]) (-[WebResourceHandle loadWithDelegate:])
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m:
• CacheLoader.subproj/WebResourceSynchronousDelegate.m: (-[WebResourceHandleSynchronousDelegate run:])

WebKit:

Changed WebResourceHandle so that the init method no longer starts the
loading of the request to begin. Added new loadWithDelegate: method which
is called separatetly from the init method, to start loads.

All of the changes here update code that depends on WebResourceHandle. The
changes move the code to the modified API.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad])
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:])
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:])
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading])

8:41 AM Changeset in webkit [2214] by cblu

• 20 edits in trunk/WebKit

Fixed copyright comments.

• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
• Plugins.subproj/WebNetscapePluginDocumentView.h:
• Plugins.subproj/WebNetscapePluginDocumentView.m:
• Plugins.subproj/WebNetscapePluginEmbeddedView.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m:
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m:
• Plugins.subproj/WebPlugin.h:
• Plugins.subproj/WebPlugin.m:
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m:
• Plugins.subproj/WebPluginNullEventSender.h:
• Plugins.subproj/WebPluginNullEventSender.m:
• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m:
• Plugins.subproj/npapi.h:
• Plugins.subproj/npapi.m:

7:38 AM Changeset in webkit [2213] by kocienda

• 19 edits in trunk/WebKit

WebFoundation:

Big set of changes to move the code closer to the proposed WebFoundation API. Major work includes:

• Implemented new callbacks for WebResourceHandleDelegate. All delegates of WebResourceHandle were updated to reflect this change.

• Modified the way WebProtocolHandler creates protocol-specific responses.

• Move WebResourceHandle API much closer to the final proposal. The public API on this class is very thin now. Some private methods are still available to code inside Intrigue (to ease the transition), and the dependencies on these private methods will be reduced over time.

• WebResourceRequest and WebResourceResponse classes are now closer to their proposed APIs, but work remains to be done with them.

• Synchronous loading code received a large rewrite.

And an extra:

• Sped up implementation of file protocol handler. This protocol handler no longer kicks a thread for each file load.

• CacheLoader.subproj/IFHTTPURLHandleC.h:
• CacheLoader.subproj/IFHTTPURLHandleC.m: (IFHTTPURLHandleGetRequestMethod) (IFHTTPURLHandleGetRequestHeaders)
• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode) (IFURLHandleGetURL) (IFURLHandleGetCanonicalURL) (IFURLHandleGetStatusCode) (IFURLHandleGetResultCode) (IFURLHandleGetContentType) (IFURLHandleGetError) (IFURLHandleGetContentLength) (IFURLHandleGetContentLengthReceived) (IFURLHandleGetPercentComplete)
• CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCache _truncateToSizeLimit])
• CacheLoader.subproj/WebProtocolHandler.h:
• CacheLoader.subproj/WebProtocolHandler.m: (-[WebProtocolHandler responseClass]) (-[WebProtocolHandler responseMetadataAvailable]) (-[WebProtocolHandler setResponseMetadata:])
• CacheLoader.subproj/WebResourceCallbackClient.m: (-[WebResourceCallbackClient handle:willSendRequest:]) (-[WebResourceCallbackClient handle:didReceiveResponse:])
• CacheLoader.subproj/WebResourceHandle.h:
• CacheLoader.subproj/WebResourceHandle.m: (+[WebResourceHandle sendSynchronousRequest:]) (-[WebResourceHandle initWithRequest:delegate:])
• CacheLoader.subproj/WebResourceHandleDelegate.h:
• CacheLoader.subproj/WebResourceHandleInternal.h:
• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables prepareCallbacks]) (-[WebResourceHandleInstanceVariables dealloc]) (-[WebResourceHandle _loadInBackground]) (-[WebResourceHandle _sendCallbacks]) (-[WebResourceHandle _notifyClientWillSendRequest]) (-[WebResourceHandle _notifyClientDidReceiveResponse]) (-[WebResourceHandle _notifyClientDataDidBecomeAvailable]) (-[WebResourceHandle _notifyClientDidFailLoading]) (-[WebResourceHandle _notifyClientDidFinishLoading])
• CacheLoader.subproj/WebResourceHandlePrivate.h:
• CacheLoader.subproj/WebResourceHandlePrivate.m: (-[WebResourceHandle _didReceiveResponseMetadata:]) (-[WebResourceHandle _backgroundLoadComplete]) (-[WebResourceHandle _backgroundLoadFailed]) (-[WebResourceHandle _didRedirectToURL:]) (-[WebResourceHandle _request]) (-[WebResourceHandle _response]) (-[WebResourceHandle _redirectedURL])
• CacheLoader.subproj/WebResourceLoad.h:
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]) (-[WebResourceLoad didLoadBytes:length:]) (-[WebResourceLoad succeeded]) (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]) (-[WebResourceLoad addHandle:]) (-[WebResourceLoad cacheObjectCheckingRedirects:]) (-[WebResourceLoad didRedirectToURL:permanent:]) (-[WebResourceLoad originalRequest]) (-[WebResourceLoad _beginLoad]) (-[WebResourceLoad _cacheKey]) (-[WebResourceLoad description]) (-[WebResourceLoad dealloc])
• CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]) (+[WebResourceLoadKey keyWithLoad:]) (-[WebResourceLoadKey hash]) (-[WebResourceLoadManager requestWithURLHandle:])
• CacheLoader.subproj/WebResourceLoadQueue.m: (-[WebResourceLoadQueue put:])
• CacheLoader.subproj/WebResourceRequest.h:
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]) (-[WebResourceRequest canonicalURL]) (-[WebResourceRequest protocolHandlerClass]) (-[WebResourceRequest copyWithZone:]) (-[WebResourceRequest copyWithURL:])
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse contentType])
• CacheLoader.subproj/WebResourceSynchronousClient.h:
• CacheLoader.subproj/WebResourceSynchronousClient.m: (-[WebResourceHandleSynchronousDelegate initWithRequest:monitor:]) (-[WebResourceHandleSynchronousDelegate dealloc]) (-[WebResourceHandleSynchronousDelegate run:]) (-[WebResourceHandleSynchronousDelegate started]) (-[WebResourceHandleSynchronousDelegate handle]) (-[WebResourceHandleSynchronousDelegate response]) (-[WebResourceHandleSynchronousDelegate result]) (-[WebResourceHandleSynchronousDelegate handle:willSendRequest:]) (-[WebResourceHandleSynchronousDelegate handleDidFinishLoading:]) (-[WebResourceHandleSynchronousDelegate handle:didReceiveResponse:]) (-[WebResourceHandleSynchronousDelegate handle:didReceiveData:])
• Misc.subproj/WebFoundation.h:
• Misc.subproj/WebFoundationLogging.h:
• Misc.subproj/WebFoundationLogging.m:
• Misc.subproj/WebNSStringExtras.m: (-[NSString _web_isCaseInsensitiveEqualToString:]
• ProtocolHandlers.subproj/WebAboutProtocolHandler.h:
• ProtocolHandlers.subproj/WebAboutProtocolHandler.m: (-[WebAboutProtocolHandler beginLoad]) (-[WebAboutProtocolHandler responseClass]) (-[WebAboutProtocolHandler responseMetadataAvailable]) (-[WebAboutProtocolHandler setResponseMetadata:])
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addAuthenticationHeaders:andCall:]) (-[WebCFNetworkHTTPProtocolHandler continueAfterBytesAvailable]) (-[WebCFNetworkHTTPProtocolHandler handleReadStreamEvent:event:]) (-[WebCFNetworkHTTPProtocolHandler performHTTPHeaderRead:andCall:])
• ProtocolHandlers.subproj/WebFileProtocolHandler.h:
• ProtocolHandlers.subproj/WebFileProtocolHandler.m: (-[WebFileProtocolHandler initWithResourceLoad:]) (-[WebFileProtocolHandler dealloc]) (-[WebFileProtocolHandler didLoadData:]) (-[WebFileProtocolHandler beginLoad]) (-[WebFileProtocolHandler endLoad]) (-[WebFileProtocolHandler responseClass]) (-[WebFileProtocolHandler responseMetadataAvailable]) (-[WebFileProtocolHandler setResponseMetadata:])
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler responseClass]) (-[WebHTTPProtocolHandler responseMetadataAvailable]) (-[WebHTTPProtocolHandler setResponseMetadata:]) (-[WebHTTPProtocolHandler shouldCacheResponse:]) (-[WebHTTPProtocolHandler URL]) (-[WebHTTPProtocolHandler retryWithRedirectedURLAndResultCode:])
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler createHTTPRequest]) (-[WebSimpleHTTPProtocolHandler _examineHeaders])
• WebFoundation.exp
• WebFoundation.pbproj/project.pbxproj

WebKit:

Many changes to coincide with API work in WebFoundation. Most of the modifications
here have to do with changes for the new callback scheme.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader handleDidFinishLoading:]) (-[WebIconLoader handle:willSendRequest:]): New method. A no-op here. (-[WebIconLoader handle:didReceiveResponse:]): Ditto.
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView stop]): Fix for Deployment build breakage.
• Plugins.subproj/WebPluginStream.h: Add response ivar.
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad]): Tweak method name for new API. (-[WebNetscapePluginStream receivedData:withHandle:]): (-[WebNetscapePluginStream handle:willSendRequest:]): New method. Replaces old redirect callback. (-[WebNetscapePluginStream handle:didReceiveResponse:]): New method. Set the response ivar.
• WebCoreSupport.subproj/WebSubresourceClient.h: Add response ivar.
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient dealloc]): Release response ivar. (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Set the request user agent here. (-[WebSubresourceClient handle:willSendRequest:]): New method. Handle like a redirect. (-[WebSubresourceClient handle:didReceiveResponse:]): New method. Set the response ivar. (-[WebSubresourceClient handle:didReceiveData:]): Tweaks for new WebFoundation API and method names. (-[WebSubresourceClient handleDidFinishLoading:]): Ditto. (-[WebSubresourceClient handle:didFailLoadingWithError:]): Ditto.
• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Ditto.
• WebView.subproj/WebDataSourcePrivate.h: Add _setRequest method.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Call didStartLoadingWithURL with request URL instead of handle URL. (-[WebDataSource _setRequest:]): Add implementation.
• WebView.subproj/WebLoadProgress.m: (-[WebLoadProgress initWithResourceHandle:]): Tweaks for new WebFoundation API and method names.
• WebView.subproj/WebMainResourceClient.h: Add response ivar.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): Set user agent on request here. (-[WebMainResourceClient dealloc]): Release response ivar. (-[WebMainResourceClient didCancelWithHandle:]): Tweaks for new WebFoundation API and method names. (-[WebMainResourceClient handleDidFinishLoading:]): Tweaks for new WebFoundation API and method names. (-[WebMainResourceClient handle:willSendRequest:]): New method. Handle like a redirect. (-[WebMainResourceClient handle:didReceiveResponse:]): New method. Set the response ivar. (-[WebMainResourceClient handle:didReceiveData:]): Tweaks for new WebFoundation API and method names. (-[WebMainResourceClient handle:didFailLoadingWithError:]): Ditto.

WebBrowser:

Updated a couple methods to reflect changes in WebFoundation API names.

• BrowserWebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]): Call for the URL on the handles response instead of the URL of the handle itself. (-[BrowserWebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): Ditto.
• DownloadMonitor.m: (-[DownloadMonitor receivedError:forResourceHandle:partialProgress:fromDataSource:]): Request accessor for handle is now private; reflect that in method name (i.e. add an underscore).

Sep 30, 2002:

10:30 PM Changeset in webkit [2212] by cblu

• 11 edits
  7 adds
  3 deletes in trunk/WebKit

A ton o' plugin view clean-up and arch changes. Turned WebPluginView into WebBaseNetscapePluginView. New classes WebNetscapePluginEmbeddedView and WebNetscapePluginDocumentView are subclasses of WebBaseNetscapePluginView. WebNetscapePluginDocumentView handles non-HTML plug-in content and WebNetscapePluginEmbeddedView is the WebHTMLView subview.

Found that we leak the world on complex pages with plug-ins such as macromedia.com and marvel.com when closing the window. Still need to figure this out.

• Plugins.subproj/WebBaseNetscapePluginView.h: Added.
• Plugins.subproj/WebBaseNetscapePluginView.m: Added. (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView modifiersForEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView keyMessageForEvent:]): (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (-[WebBaseNetscapePluginView acceptsFirstResponder]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView isInResponderChain]): (-[WebBaseNetscapePluginView performKeyEquivalent:]): (-[WebBaseNetscapePluginView menuForEvent:]): (-[WebBaseNetscapePluginView setUpWindowAndPort]): (-[WebBaseNetscapePluginView setWindow]): (-[WebBaseNetscapePluginView removeTrackingRect]): (-[WebBaseNetscapePluginView resetTrackingRect]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView webFrame]): (-[WebBaseNetscapePluginView controller]): (-[WebBaseNetscapePluginView plugin]): (-[WebBaseNetscapePluginView setMIMEType:]): (-[WebBaseNetscapePluginView setBaseURL:]): (-[WebBaseNetscapePluginView setArguments:]): (-[WebBaseNetscapePluginView setMode:]): (-[WebBaseNetscapePluginView initWithFrame:]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView isFlipped]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewHasMoved:]): (-[WebBaseNetscapePluginView windowWillClose:]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView defaultsHaveChanged:]): (-[WebBaseNetscapePluginView frameStateChanged:]): (-[WebBaseNetscapePluginView pluginInstance]): (-[WebBaseNetscapePluginView pluginURLFromCString:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): (-[WebBaseNetscapePluginView getURL:target:]): (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): (-[WebBaseNetscapePluginView newStream:target:stream:]): (-[WebBaseNetscapePluginView write:len:buffer:]): (-[WebBaseNetscapePluginView destroyStream:reason:]): (-[WebBaseNetscapePluginView status:]): (-[WebBaseNetscapePluginView invalidateRect:]): (-[WebBaseNetscapePluginView invalidateRegion:]): (-[WebBaseNetscapePluginView forceRedraw]):
• Plugins.subproj/WebBaseNetscapePluginViewPrivate.h: Added.
• Plugins.subproj/WebNetscapePluginDocumentView.h: Added.
• Plugins.subproj/WebNetscapePluginDocumentView.m: Added. (-[WebNetscapePluginDocumentView initWithFrame:]): (-[WebNetscapePluginDocumentView dealloc]): (-[WebNetscapePluginDocumentView drawRect:]): (-[WebNetscapePluginDocumentView dataSource]): (-[WebNetscapePluginDocumentView setDataSource:]): (-[WebNetscapePluginDocumentView dataSourceUpdated:]): (-[WebNetscapePluginDocumentView setNeedsLayout:]): (-[WebNetscapePluginDocumentView layout]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.h: Added.
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: Added. (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:arguments:]): (-[WebNetscapePluginEmbeddedView dealloc]): (-[WebNetscapePluginEmbeddedView viewDidMoveToWindow]): (-[WebNetscapePluginEmbeddedView start]): (-[WebNetscapePluginEmbeddedView dataSource]):
• Plugins.subproj/WebNetscapePluginViewPrivate.h: Removed.
• Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase init]):
• Plugins.subproj/WebPluginNullEventSender.h:
• Plugins.subproj/WebPluginNullEventSender.m: (-[WebNetscapePluginNullEventSender initWithPluginView:]): (-[WebNetscapePluginNullEventSender sendNullEvents]):
• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream getFunctionPointersFromPluginView:]): (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream startLoad]): (-[WebNetscapePluginStream receivedData:withDataSource:]): (-[WebNetscapePluginStream handleWillUseUserAgent:forURL:]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream cancel]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]): (-[WebNetscapePluginStream handleDidRedirect:toURL:]):
• Plugins.subproj/WebPluginView.h: Removed.
• Plugins.subproj/WebPluginView.m: Removed.
• Plugins.subproj/npapi.m: (NPN_GetURLNotify): (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_Status): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebHTMLViewPrivate.m: (-[NSView _web_stopIfPluginView]):

2:39 PM Changeset in webkit [2211] by hyatt

• 4 edits in trunk/WebCore

Fix the case sensitivity problem with attribute names
in HTML. They are now lower-cased when being queried
from the DOM. Bug 3058145.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::attrName):

1:25 PM Changeset in webkit [2210] by hyatt

• 4 edits in trunk/WebCore

Make sure to keep the fix checked in for 1.18. That fix is
good.

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo):

1:03 PM Changeset in webkit [2209] by hyatt

• 4 edits in trunk/WebCore

Backing out change to render_table.cpp. The original logic
(in version 1.16) is correct.

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo):

11:09 AM Changeset in webkit [2208] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Remove the ill-advised "don't even create a WebDataSource if WebResourceHandle can't handle this request" code.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Rearrange checks so we won't get confused if we can't create a handle.

10:52 AM Changeset in webkit [2207] by darin

• 13 edits in trunk/WebCore

• kwq/qt/qobject.h: Add the destroyed signal.
• kwq/KWQObject.mm: (QObject::connect): Remove names of parentDestroyed and slotWidgetDestructed from the list of "slots OK to fail to connect without complaining". (QObject::QObject): Initialize the destroyed signal.

• kwq/qt/qguardedptr.h:
• kwq/KWQGuardedPtr.mm:
• kwq/KWQSignal.h:
• kwq/KWQSlot.h: Rearrange includes so qobject.h can include KWQSignal.h.

• kwq/KWQSignal.mm: Tweak.

• kwq/KWQSlot.mm: Added support for the parentDestroyed slot in KJS::WindowQObject and the slotWidgetDestructed slot in khtml::RenderWidget.

10:08 AM Changeset in webkit [2206] by darin

• 2 edits
  1 add in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Added.

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Added.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Added.

WebBrowser:

• English.lproj/StringsNotToBeLocalized.txt: Added.

9:26 AM Changeset in webkit [2205] by darin

• 3 edits in trunk/WebKit

• fixed crashing part of 3063517 -- crash loading .png in separate window

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView start]): Don't try to start if the NPP_New is 0. This indicates the the plugin hasn't been loaded.

8:49 AM Changeset in webkit [2204] by darin

• 3 edits in trunk/WebKit

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setLoading:]): Remove extra quotes in use of ASSERT_ARG.

Sep 29, 2002:

10:03 PM Changeset in webkit [2203] by darin

• 11 edits in trunk/WebKit

WebKit:

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): Don't be case sensitive about filename extensions.

• Misc.subproj/WebDownloadHandler.m:
• Misc.subproj/WebIconLoader.m:
• Plugins.subproj/WebPluginStream.m:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDefaultContextMenuDelegate.m:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebView.m: Don't use WebFoundation.h -- faster building to just import what we really use.

WebBrowser:

• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): Don't be case sensitive about filename extensions.

• Preferences.subproj/SecurityPreferences.m: Don't use WebFoundation.h -- faster building to just import what we really use.

10:04 AM Changeset in webkit [2202] by cblu

• 5 edits in trunk/WebKit

WebKit:

Fixed: 2978258 - quake3arena.com sends me to the flash=false site
The page has a flash plugin that once loaded, requests the flash=true page. If the plugin doesn't load, the meta refresh tag to the flash=false page fires after 3 seconds. This is how this site's flash detection works.

The reason this doesn't work for us is because the flash movie is at the bottom of the page. Plugins don't start until the initial drawRect. Since the movie is at the bottom of the page and out of site, the plugin never gets the drawRect and thus, never starts. We now start plug-ins when they are added to the window.

Fixed: 3062224 - context menu includes "Download Item to Disk" for mailto links

• Fixed click then click and drag causes crash.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView drawRect:]): don't start plug-in here (-[WebNetscapePluginView viewDidMoveToWindow]): start it here
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): don't provide "Download Link To Disk" and "Open Link In New Window" items for URLs we cant handle.
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): clean-up (-[WebHTMLView mouseDragged:]): Don't allow drag if the frame has a provisional data source because this view may be released and the drag callbacks might reference this released view.

WebBrowser:

Fixed: 3062224 - context menu includes "Download Item to Disk" for mailto links

• Added "Open With QuickTime Player" context menu for URLs ending with .mov.
• Only show "Open With*" items for http URLs.

• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler openWithiTunes:]): (-[ContextMenuHandler openWithQuickTime:]):